Dungeon Crawl Stone Soup Tracker - DCSS
Viewing Issue Advanced Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
11468 Bug Report major always 2018-05-04 12:43 2018-09-29 22:33
Reporter: Ge0ff Local or Remote: Remote  
Assigned To: ebering Operating System: Online  
Priority: normal Console or Tiles: WebTiles  
Status: resolved Product Branch: 0.22 ancient branch  
Product Version: Resolution: done  
Projection: none      
ETA: none Fixed in Branch:  
Summary: 0011468: Specifying an unsupported colour in menu_colour crashes the game
Description: To reproduce the bug add into .rc the following:

menu_colour += stash:gold:gold piece

then spawn a pile of gold and do a stash search with Ctrl-f .

Local tiles are not affected.
Steps To Reproduce:
Additional Information:
System Description:
Relationships
Attached Files:
Issue History
Date Modified Username Field Change
2018-05-04 12:43 Ge0ff New Issue
2018-06-08 19:16 ebering Note Added: 0032286
2018-06-08 19:57 ebering Note Added: 0032287
2018-09-29 22:33 ebering Note Added: 0032661
2018-09-29 22:33 ebering Status new => resolved
2018-09-29 22:33 ebering Resolution open => done
2018-09-29 22:33 ebering Assigned To => ebering

Notes
(0032286)
ebering   
2018-06-08 19:16   
Digging in to this, any unsupported color won't cause a crash.

Using the name of an elemental colour is what's triggering this bug, as str_to_colour is being used to get a color number, and is returning a non-console value for strings that match the name of a crawl elemental colour.
(0032287)
ebering   
2018-06-08 19:57   
More digging. The commit 900b867fb7dce fixed a similar crash.

https://github.com/crawl/crawl/pull/781 [^] changes str_to_colour to default to returning only terminal colours, and explicitly allows elemental colours in dlua for vault support.
(0032661)
ebering   
2018-09-29 22:33   
Fixed in 0.23-a0-265-g9c2c487