|
Dungeon Crawl Stone Soup Tracker - DCSS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
11092 |
Bug Report |
minor |
sometimes |
2017-06-07 18:49 |
2017-06-22 18:09 |
|
|
Reporter:
|
cut1less |
Local or Remote:
|
Local |
|
|
Assigned To:
|
advil |
Operating System:
|
Linux |
|
|
Priority:
|
normal |
Console or Tiles:
|
Both |
|
|
Status:
|
closed |
Product Branch:
|
experimental branch |
|
|
Product Version:
|
0.21-a0-43-g1479571521 |
Resolution:
|
done |
|
|
Projection:
|
none |
|
|
|
|
ETA:
|
none |
Fixed in Branch:
|
0.21 ancient branch |
|
|
|
Summary:
|
0011092: Viable species/background option ("+" key) returning random species/backgrounds |
|
Description:
|
At the new game character creation screen, using the viable species/background option (the + key) gives a random and potentially non-viable species/background even if the other choice (the background or species) has already been chosen.
Some examples that I've gotten are HuSk, SpNe, TeNe, and VsCK, which are not viable in either direction but sometimes come up as completed characters from using the + key on the species or the background screens.
Expected behavior:
1) If both species and background are unchosen, + key would give a random option for one.
2) If a species/background has been chosen (either by the player or randomly, as above or via *), then choose a viable background or species from what is recommended by the species/background.
Note: The viable character button ("#") works as intended, giving combos that are viable in at least one direction. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
|
System Description:
|
|
| Relationships | | has duplicate | 0011085 | resolved | PleasingFungus | Tab for a Viable [race] does not guarantee a viable character. |
|
|
Attached Files:
|
 0001-Fix-Viable-species-background-new-game-option.patch [^] (990 bytes) 2017-06-08 00:24 [Show Content] [Hide Content]From 3341e9ebc9853a41bf6e23557f4a185d0117eab9 Mon Sep 17 00:00:00 2001
From: cut1less <kazoon401@gmail.com>
Date: Wed, 7 Jun 2017 17:13:10 -0500
Subject: [PATCH] Fix Viable species/background new game option
---
crawl-ref/source/newgame.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crawl-ref/source/newgame.cc b/crawl-ref/source/newgame.cc
index eddbf91ce3..006bea500d 100644
--- a/crawl-ref/source/newgame.cc
+++ b/crawl-ref/source/newgame.cc
@@ -695,8 +695,8 @@ static void _add_choice_menu_options(int choice_type,
tmp->set_fg_colour(BROWN);
tmp->add_hotkey('+');
// If the player has species chosen, use VIABLE, otherwise use RANDOM
- if ((choice_type == C_SPECIES && ng.species != SP_UNKNOWN)
- || (choice_type == C_JOB && ng.job != JOB_UNKNOWN))
+ if ((choice_type == C_SPECIES && ng.job != JOB_UNKNOWN)
+ || (choice_type == C_JOB && ng.species != SP_UNKNOWN))
{
tmp->set_id(M_VIABLE);
}
--
2.13.0
|
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2017-06-07 18:49 |
cut1less |
New Issue |
|
|
2017-06-07 19:07 |
PleasingFungus |
Relationship added |
has duplicate 0011085 |
|
2017-06-07 20:50 |
advil |
Status |
new => confirmed |
|
2017-06-08 00:24 |
cut1less |
File Added: 0001-Fix-Viable-species-background-new-game-option.patch |
|
|
2017-06-08 00:25 |
cut1less |
Note Added: 0031664 |
|
|
2017-06-15 19:55 |
advil |
Note Added: 0031682 |
|
|
2017-06-15 19:55 |
advil |
Status |
confirmed => resolved |
|
2017-06-15 19:55 |
advil |
Fixed in Branch |
=> 0.20 development branch |
|
2017-06-15 19:55 |
advil |
Resolution |
open => done |
|
2017-06-15 19:55 |
advil |
Assigned To |
=> advil |
|
2017-06-22 18:09 |
cut1less |
Status |
resolved => closed |