|
Dungeon Crawl Stone Soup Tracker - DCSS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Severity:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
10659 |
Bug Report |
minor |
always |
2016-09-06 19:27 |
2019-01-25 14:30 |
|
|
Reporter:
|
bsdbeard |
Local or Remote:
|
Both |
|
|
Assigned To:
|
ebering |
Operating System:
|
All |
|
|
Priority:
|
normal |
Console or Tiles:
|
Both |
|
|
Status:
|
resolved |
Product Branch:
|
0.19 ancient branch |
|
|
Product Version:
|
0.19-a0-1277-g7cecae3 |
Resolution:
|
done |
|
|
Projection:
|
none |
|
|
|
|
ETA:
|
none |
Fixed in Branch:
|
|
|
|
|
Summary:
|
0010659: Petrify lists success chance vs player ghosts, which can't be affected |
|
Description:
|
When trying to use petrify vs insubstantial enemies (i.e. spectral caustic shrike, insubstantial wisp), you will see this message:
You can't see any susceptible monsters within range! (Use Z to cast anyway.)
However, when using petrify against player ghosts, that message is not displayed, it lists a % chance to affect the ghost. After casting the spell it will say:
John Doe's ghost is unaffected.
The game should emit the same message for player ghosts as for other insubstantial enemies.
Steps to reproduce:
Summon player ghost in wizmode using &m player ghost hd:1
Cast petrify |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
|
System Description:
|
|
| Relationships | | related to | 0011706 | closed | ebering | Little-known and misleading behaviour with polymorph on ugly things, shapeshifters, undead |
|
|
Attached Files:
|
 check-petrify-susceptibility.patch [^] (855 bytes) 2018-07-02 18:36 [Show Content] [Hide Content]From c70c1c47d3835316873e7cef69dcad21ea1d2f8f Mon Sep 17 00:00:00 2001
From: dcandido <davidjoec@gmail.com>
Date: Thu, 28 Jun 2018 15:19:05 -0500
Subject: [PATCH] Add petrify to the enchantment flavour susceptibility check
---
crawl-ref/source/beam.cc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/crawl-ref/source/beam.cc b/crawl-ref/source/beam.cc
index 1eb25a3fbb..2637f21a7f 100644
--- a/crawl-ref/source/beam.cc
+++ b/crawl-ref/source/beam.cc
@@ -5072,6 +5072,10 @@ bool ench_flavour_affects_monster(beam_type flavour, const monster* mon,
rc = !(mon->is_summoned() || mon->has_ench(ENCH_INNER_FLAME));
break;
+ case BEAM_PETRIFY:
+ rc = !mon->res_petrify();
+ break;
+
case BEAM_INFESTATION:
rc = mons_gives_xp(*mon, you) && !mon->has_ench(ENCH_INFESTATION);
break;
--
2.17.1
|
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2016-09-06 19:27 |
bsdbeard |
New Issue |
|
|
2016-09-08 01:12 |
PleasingFungus |
Status |
new => confirmed |
|
2016-09-13 19:21 |
silentsnack |
Note Added: 0031006 |
|
|
2018-01-07 03:05 |
rchandra |
Note Added: 0032020 |
|
|
2018-01-07 03:07 |
rchandra |
Note Edited: 0032020 |
|
|
2018-01-08 20:39 |
NormalPerson7 |
Note Added: 0032027 |
|
|
2018-07-02 18:36 |
stormdragon |
File Added: check-petrify-susceptibility.patch |
|
|
2018-07-02 18:41 |
stormdragon |
Note Added: 0032319 |
|
|
2018-07-02 18:43 |
stormdragon |
Note Added: 0032320 |
|
|
2018-07-02 18:44 |
stormdragon |
Note Deleted: 0032319 |
|
|
2019-01-24 01:45 |
ebering |
Note Added: 0032972 |
|
|
2019-01-24 01:47 |
ebering |
Status |
confirmed => assigned |
|
2019-01-24 01:47 |
ebering |
Assigned To |
=> ebering |
|
2019-01-24 01:59 |
ebering |
Relationship added |
related to 0011706 |
|
2019-01-24 14:22 |
stormdragon |
Note Added: 0032997 |
|
|
2019-01-25 07:23 |
ebering |
Note Added: 0032998 |
|
|
2019-01-25 07:47 |
ebering |
Note Added: 0032999 |
|
|
2019-01-25 07:47 |
ebering |
Status |
assigned => resolved |
|
2019-01-25 07:47 |
ebering |
Resolution |
open => done |
|
2019-01-25 14:30 |
stormdragon |
Note Added: 0033002 |
|
|
Notes |
|
|
(0031006)
|
|
silentsnack
|
|
2016-09-13 19:21
|
|
|
Similar thing happens with some other enemies, like trying to paralyze/enslave a gargoyle with a wand: Displays a %chance before casting but says "unaffected" after wasting time/charges. |
|
|
|
(0032020)
|
|
rchandra
|
2018-01-07 03:05
(edited on: 2018-01-07 03:07) |
|
This is still (0.21.0) the case. Other instances: wraith, catoblepas.
|
|
|
|
(0032027)
|
|
NormalPerson7
|
|
2018-01-08 20:39
|
|
|
Gargoyles are not immune to wand paralysis/enslavement. |
|
|
|
(0032320)
|
|
stormdragon
|
|
2018-07-02 18:43
|
|
I believe ench_flavor_affects_monster is supposed to check if a given beam type will affect a given monster, but it does not account for the Petrify beam type.
To fix this, I have uploaded a git patch using Upload File above - please let me know if this is the correct way to submit fixes. |
|
|
|
(0032972)
|
|
ebering
|
|
2019-01-24 01:45
|
|
|
A much preferred way to submit fixes is to open a Github pull request; mantis gets a lot of traffic and they tend to get lost. I've assigned this issue to myself and will try to get this patch in soon. |
|
|
|
(0032997)
|
|
stormdragon
|
|
2019-01-24 14:22
|
|
|
Gotcha, thanks for letting me know. |
|
|
|
(0032998)
|
|
ebering
|
|
2019-01-25 07:23
|
|
|
How do you wish to appear in CREDITS.txt? |
|
|
|
(0032999)
|
|
ebering
|
|
2019-01-25 07:47
|
|
Merged in 0.23-a0-841-g41928f00c8
Thanks for the patch! |
|
|
|
(0033002)
|
|
stormdragon
|
|
2019-01-25 14:30
|
|
|
I get to be in the credits? Cool, thanks! David Candido. |
|