Dungeon Crawl Stone Soup Tracker - DCSS
Viewing Issue Advanced Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
10060 Bug Report minor always 2015-11-08 19:30 2021-07-17 19:21
Reporter: DraconicPenguin Local or Remote: Local  
Assigned To: advil Operating System: Windows  
Priority: normal Console or Tiles: Tiles  
Status: closed Product Branch: 0.16 ancient branch  
Product Version: 0.16.2 Resolution: done  
Projection: none      
ETA: none Fixed in Branch: 0.24 old branch  
Summary: 0010060: Arena: Duplicate messages written to arena.result with arena_dump_msgs = true
Description: When I add arena_dump_msgs = true into my init.txt file (per https://github.com/guyht/crawl/blob/master/crawl-ref/docs/arena.txt), [^] which is supposed to log messages to the file arena.result, the complete contents of the message log are getting written out on every turn, resulting in duplicate messages in the file.

Reproduces on both Windows (official binary) and Linux (openSUSE Tumbleweed RPM) Tiles version 0.16.2 stable. An example output file demonstrating the bug (for Lom Lobon v 50 Orb Guardian) is attached.
Steps To Reproduce:
Additional Information:
System Description:
Relationships
Attached Files: ? file icon arena.result [^] (331,805 bytes) 2015-11-08 19:30
Issue History
Date Modified Username Field Change
2015-11-08 19:30 DraconicPenguin New Issue
2015-11-08 19:30 DraconicPenguin File Added: arena.result
2015-11-08 20:06 DraconicPenguin Note Added: 0029754
2015-11-10 22:39 DraconicPenguin Note Edited: 0029754
2015-11-12 08:29 DraconicPenguin Note Added: 0029770
2015-11-12 08:30 DraconicPenguin Note Edited: 0029770
2019-07-11 21:41 advil Note Added: 0033332
2019-07-11 21:41 advil Status new => resolved
2019-07-11 21:41 advil Fixed in Branch => 0.24 development branch
2019-07-11 21:41 advil Resolution open => done
2019-07-11 21:41 advil Assigned To => advil
2021-07-17 19:21 DraconicPenguin Status resolved => closed

Notes
(0029754)
DraconicPenguin   
2015-11-08 20:06   
(edited on: 2015-11-10 22:39)
I took a closer look and noticed that the message log on the last write-out to arena.result in a more complex case involving a test spawner was truncated. It might be a good idea to 1) expand the message log buffer and/or 2) simply write out only the messages generated in the previous turn, at each turn.

The current behavior of writing out the complete contents of the message log leaves something to be desired.
(0029770)
DraconicPenguin   
2015-11-12 08:29   
(edited on: 2015-11-12 08:30)
The issue continues to reproduce under Stone Soup 0.17.0 Tiles for Windows. (Official openSUSE Tumbleweed binaries for 0.17 are not yet available.)
(0033332)
advil   
2019-07-11 21:41   
This should be fixed in https://github.com/crawl/crawl/commit/29c01f8b8473 [^]