Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0009275 [DCSS] Patches feature N/A 2014-11-29 01:55 2014-12-11 01:05
Reporter Sandman25 View Status public  
Assigned To wheals
Priority normal Resolution done  
Status closed   Product Branch 0.16 ancient branch
Summary 0009275: PATCH: new option item_slot
Description I based the patch on commit e257a1c5c535ba84917669b6846bfce9eb294aea (2014/11/24).
New option "item_slot" is similar to existing "spell_slot" except it affects potions, scrolls and jewelry instead of spells.
Example of init.txt:
item_slot += potion of invisibility:W
item_slot += scroll of fear:a
item_slot += ring of invisibility:I

Example of in-game messages:
Put on which piece of jewellery? (? for menu, Esc to quit)
You become transparent for a moment.
I - a ring of invisibility (left hand)
Read which item? (? for menu, Esc to quit)
As you read the scroll labeled ANLAIMN BUKEXA, it crumbles to dust.
You assume a fearsome visage. Nothing appears to happen.
It was a scroll of fear.
a - a scroll of fear; e - a +0,+0 short sword (weapon)
Drink which item? (? for menu, Esc to quit)
You fade into invisibility!
It was a potion of invisibility.
W - 2 potions of invisibility

Inventory after those actions:
Hand weapons
 e - a +0,+0 short sword (weapon)
Scrolls
 a - a scroll of fear
Jewellery
 I - a ring of invisibility (left hand) {+Inv, !d}
Potions
 W - a potion of invisibility

If there is interest, I can try to reassign known items on pickup also (i.e. if there was only potion of invisibility and it was quaff ID-ed but next time a potion of invisibility is picked up, it is automatically assigned to I).

Reasoning for the patch:
I like "c" as ring of protection from cold, "f" as ring of protection from fire, "m" as ring of protectiob from magic etc. but it takes much time and effort in every game.
Additional Information
Tags No tags attached.
Attached Files ? file icon itemslot1.patch [^] (6,405 bytes) 2014-11-29 02:23 [Show Content]

- Relationships
has duplicate 0007870resolvedwheals Ability to use 'item_slot' option in the rc file the same way, and for the same reasons as 'spell_slot' 

-  Notes
(0027930)
Sandman25 (reporter)
2014-11-29 02:24

Please use file itemslot1 instead, I forgot to check that item is already in required slot (it resulted in 3 identical messages).
(0027932)
doy (developer)
2014-11-29 05:34

Oh hey, another feature from Interhack(:
(0027936)
Sandman25 (reporter)
2014-11-29 13:51
edited on: 2014-11-29 13:53

I have never played Interhack, the feature is what I really miss as player.

Probably abilities can be used too (I like to set "f" to flight, "i" to evocable invisibility and some capital letter for Greater Servant of Makhleb since it is dangerous with low Invocations if pressed accidentally)

(0028047)
wheals (administrator)
2014-12-10 19:36

Added, with code cleanup, in http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=3c7236ec6793. [^] My version also adds remapping on game start and on item pickup.

Doing this for ability slots would be awesome (there's an implementable for it, even).
(0028051)
Sandman25 (reporter)
2014-12-11 01:05

Thanks!

- Issue History
Date Modified Username Field Change
2014-11-29 01:55 Sandman25 New Issue
2014-11-29 01:55 Sandman25 File Added: itemslot.patch
2014-11-29 02:23 Sandman25 File Added: itemslot1.patch
2014-11-29 02:24 Sandman25 Note Added: 0027930
2014-11-29 05:34 doy Note Added: 0027932
2014-11-29 13:51 Sandman25 Note Added: 0027936
2014-11-29 13:52 Sandman25 Note Edited: 0027936
2014-11-29 13:52 Sandman25 Note Edited: 0027936
2014-11-29 13:53 Sandman25 Note Edited: 0027936
2014-11-29 13:53 Sandman25 Note Edited: 0027936
2014-12-06 23:01 chris File Deleted: itemslot.patch
2014-12-10 18:08 wheals Relationship added has duplicate 0007870
2014-12-10 19:36 wheals Note Added: 0028047
2014-12-10 19:36 wheals Status new => resolved
2014-12-10 19:36 wheals Fixed in Branch => 0.16 development branch
2014-12-10 19:36 wheals Resolution open => done
2014-12-10 19:36 wheals Assigned To => wheals
2014-12-11 01:05 Sandman25 Note Added: 0028051
2014-12-11 01:05 Sandman25 Status resolved => closed


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker