|
Viewing Issue Simple Details
[ Jump to Notes ]
[ Wiki ]
|
[ View Advanced ]
[ Issue History ]
[ Print ]
|
|
ID |
Category |
Severity |
Reproducibility |
Date Submitted |
Last Update |
|
0008879 |
[DCSS] Bug Report |
text |
always |
2014-08-16 12:35 |
2014-08-17 10:26 |
|
|
Reporter |
nagdon |
View Status |
public |
|
|
Assigned To |
doy |
|
Priority |
normal |
Resolution |
done |
|
|
Status |
closed |
|
Product Branch |
0.16 ancient branch |
|
|
Summary |
0008879: "Spell assigned to 'a'." is printed at game start for jobs with a starting spell |
|
Description |
Example game start messages:
Spell assigned to 'a'. Welcome, example the Human Wizard.
The bosom of this dungeon contains the most powerful artefact, the Orb of Zot.
Press ? for a list of commands and other information.
...
This message is confusing without the memorisation messages usually preceding it, and it is unneccessary.
I uploaded a very trivial (3 lines) patch fixing this problem by simply not printing the message if you.num_turns is zero.
As this is a trivial but frequently appearing bug, maybe this fix could be also added to 0.15. |
|
Additional Information |
|
| Tags |
No tags attached. |
|
|
Attached Files |
 remove_spell_assign_msg.patch [^] (1,075 bytes) 2014-08-16 12:35 [Show Content] [Hide Content]From a17edaeb56aae297af1201e251f15bd5cb742c23 Mon Sep 17 00:00:00 2001
From: nagdon <m1nagdon@gmail.com>
Date: Sat, 16 Aug 2014 12:09:44 +0200
Subject: [PATCH] Do not display "Spell assigned to 'a'." at game start
Now this is the first message for jobs with a pre-memorized spell
(it is printed before "Welcome, [character name] the [race] [job]."). This
message works well after the memorization messages, but is confusing and
strange without them (and almost completely unneccessary).
---
crawl-ref/source/spl-util.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/crawl-ref/source/spl-util.cc b/crawl-ref/source/spl-util.cc
index 41272af..dda2771 100644
--- a/crawl-ref/source/spl-util.cc
+++ b/crawl-ref/source/spl-util.cc
@@ -281,7 +281,9 @@ bool add_spell_to_memory(spell_type spell)
break;
}
- mprf("Spell assigned to '%c'.", index_to_letter(j));
+ if (you.num_turns)
+ mprf("Spell assigned to '%c'.", index_to_letter(j));
+
you.spell_letter_table[j] = i;
you.spell_no++;
--
1.7.10.4
|
|
|
