0011255: Abyss exits from pan are erroneously generated 100% of the time.

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0011255

[DCSS] Bug Report

minor

have not tried

2017-10-11 20:09

2018-04-07 20:43

Reporter

Siegurt

View Status

public

Assigned To

amalloy

Priority

normal

Resolution

done

Status

closed

Product Branch

0.21 ancient branch

Summary

0011255: Abyss exits from pan are erroneously generated 100% of the time.

Description

This commit:
https://github.com/crawl/crawl/commit/f50c63c7b1503a7f07f967361d726c81af0a4a2d [^]

tried to set the chances of generating an abyssal/pan exit proportional to the number of runes generated, however due to a typo, the abyssal exits are generated 100% of the time.

Relevant bits of pan.des:
NAME: pan_exit
TAGS: extra allow_dup transparent no_dump
CHANCE: 100%
{{
local exit_chance = 5 + 3*count_pan_runes()
local floor_chance = 100 - exit_chance
kfeat("O = exit_pandemonium w:" .. exit_chance .. " / floor w:" .. floor_chance)
}}
MAP
O
ENDMAP

NAME: pan_to_abyss
TAGS: extra allow_dup transparent no_dump
CHANCE: 100%
{{
local exit_chance = 25 + 10*count_pan_runes()
local floor_chance = 100 - exit_chance
kfeat("O = exit_through_abyss w:" .. exit_chance ..
" / floor w:" .. floor_chance)
}}
KFEAT: O = exit_through_abyss
MAP
O
ENDMAP

You'll note that the abyssal exit definition puts an extra "KFEAT" line after the per-rune chance, which obviates the block of lua that is doing the odds for a per-rune chance.

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0031874) amalloy (developer) 2017-10-11 20:27	Fixed in https://github.com/crawl/crawl/commit/45b0a09d6633 [^]

Issue History
Date Modified	Username	Field	Change
2017-10-11 20:09	Siegurt	New Issue
2017-10-11 20:27	amalloy	Note Added: 0031874
2017-10-11 20:27	amalloy	Status	new => resolved
2017-10-11 20:27	amalloy	Fixed in Branch	=> 0.21 development branch
2017-10-11 20:27	amalloy	Resolution	open => done
2017-10-11 20:27	amalloy	Assigned To	=> amalloy
2018-04-07 20:43	Siegurt	Status	resolved => closed

Mantis 1.1.8[^]