0010936: High score file race condition - Dungeon Crawl Stone Soup Tracker

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Severity

Reproducibility

Date Submitted

Last Update

0010936

[DCSS] Bug Report

minor

have not tried

2017-02-11 00:48

2019-01-24 03:44

Reporter

droogie

View Status

public

Assigned To

ebering

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.21 ancient branch

Summary

0010936: High score file race condition

Description

On high score page the game is highlighting the wrong player name.

<+|amethyst> it calculates your hiscore index while it's in the process of writing out the new score file
<+|amethyst> then, to print the scores, it reopens the file and reads the entries again
<+|amethyst> but someone else may have ended their game in the intervening time
<+|amethyst> we do lock the file, but
<+|amethyst> that doesn't matter when you close it and then reopen it, because that drops the lock

Additional Information

Tags

No tags attached.

dcss-bug.png [^] (49,139 bytes) 2017-02-11 00:48

Relationships

Notes
(0032210) currency (reporter) 2018-04-30 11:47	This was addressed in the following PR: https://github.com/crawl/crawl/pull/742 [^]

(0032989) ebering (developer) 2019-01-24 03:44	The PR was merged as 0.23-a0-687-gb50ad93e3a

Issue History
Date Modified	Username	Field	Change
2017-02-11 00:48	droogie	New Issue
2017-02-11 00:48	droogie	File Added: dcss-bug.png
2018-04-30 11:47	currency	Note Added: 0032210
2019-01-24 03:44	ebering	Note Added: 0032989
2019-01-24 03:44	ebering	Status	new => resolved
2019-01-24 03:44	ebering	Resolution	open => done
2019-01-24 03:44	ebering	Assigned To	=> ebering

Mantis 1.1.8[^]

Copyright © 2000 - 2009 Mantis Group