0010340: Legacy score entry (In the scores file) crashes the program when you try and view the High Scores...

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0010340

[DCSS] Bug Report

crash

always

2016-04-03 09:34

2016-04-10 22:53

Reporter

Twilight

View Status

public

Assigned To

wheals

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.18 ancient branch

Summary

0010340: Legacy score entry (In the scores file) crashes the program when you try and view the High Scores...

Description

On this version:

0.16-a0-1625

the entry shows the character death as "Forgot to breathe (deterioration mutation)", but on this version:

0.18-a0-1197

the program crashes as soon as you try and view the High Scores from the main menu. Removing the entire entry from the scores file fixes the problem, so I know it's this entry.

After experimenting a bit, I think it's something to do with the "ktyp=stupidity" or something after that, because changing the ktyp to "ktyp=winning" allowed the High Scores to show (With the faulty entry incorrectly showing as a win, of course), and truncating the colon and everything after from colon in "ktyp=stupidity:" allows the entry to show (With death cause as "nibbled to death by software bugs").

Perhaps it's related to a change in how stat decreases work (Used to be instant death at 0, and now it takes awhile?)?

The problem entry is listed below:

v=0.8.0-a0:lv=0.1:name=Gaulin:race=Mountain Dwarf:cls=Fighter:char=MDFi:xl=16:sk=Shields:sklev=16:title=Blocker:place=Lab:br=Vault:lvl=3:absdepth=21:ltyp=Lab:hp=141:mhp=141:mmhp=141:str=30:int=0:dex=12:god=Yredelemnul:start=20101115134839S:dur=18332:turn=53940:kills=1662:gold=63:goldfound=4286:goldspent=4243:fruit=79744:sc=103502:ktyp=stupidity:dam=-9999:sdam=0:tdam=0:kaux=deterioration mutation:piety=79:end=20101115221742S

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0030346) wheals (administrator) 2016-04-10 22:52	Fixed by PleasingFungus in https://github.com/crawl/crawl/commit/5e55f6385c17 [^]

(0030347) PleasingFungus (administrator) 2016-04-10 22:53 edited on: 2016-04-10 22:54	Should be fixed in 5e55f63, thanks! (You were very close, but not quite there - the bug was because ktyp=stupidity prints 'forgot to exist' instead of 'forgot to breathe' if the character was unbreathing (e.g. mummies), and trying to figure out whether a removed species could breathe caused a crash. Very good bug.) Also, thanks for the hi-score entry - that was extremely useful in reproducing & fixing the problem!

Issue History
Date Modified	Username	Field	Change
2016-04-03 09:34	Twilight	New Issue
2016-04-10 22:52	wheals	Note Added: 0030346
2016-04-10 22:52	wheals	Status	new => resolved
2016-04-10 22:52	wheals	Fixed in Branch	=> 0.18 development branch
2016-04-10 22:52	wheals	Resolution	open => done
2016-04-10 22:52	wheals	Assigned To	=> wheals
2016-04-10 22:53	PleasingFungus	Note Added: 0030347
2016-04-10 22:54	PleasingFungus	Note Edited: 0030347

Mantis 1.1.8[^]