0010064: @ gives misleading feedback about attack speed

(0029759)
Reaver (developer)
2015-11-10 02:47

Just to be sure: you're not wearing a shield on this char, correct?

(0029760)
dpeg (administrator)
2015-11-10 02:51

Can't because I am a DE and it's a two-hander! (% says "shield currently unavailable", and I am indeed not wearing one.)

(0029761)
wheals (administrator)
2015-11-10 02:53

I think this is happening because it's a speed weapon, so in player.cc:_display_attack_delay(), the two calls to you.attack_delay may return different numbers even though your delay is really the same.

(0029763)
Napkin (administrator)
2015-11-10 07:44

Nice weapon, dpeg :D

Is there another bug with this message? Should it rather be saying "(is slowed by your insufficient shield skill)"?

Without shield I see a certain attack speed reported. Putting a shield on lowers the reported speed by 1 or 2 - and with the original sentence, does it really mean the real attack speed will be even further slowed than already shown?

(0029767)
wheals (administrator)
2015-11-10 17:49

Fixed in https://github.com/crawl/crawl/commit/2733cf4fda70. [^]

Issue History
Date Modified	Username	Field	Change
2015-11-10 02:41	dpeg	New Issue
2015-11-10 02:47	Reaver	Note Added: 0029759
2015-11-10 02:51	dpeg	Note Added: 0029760
2015-11-10 02:53	wheals	Note Added: 0029761
2015-11-10 07:44	Napkin	Note Added: 0029763
2015-11-10 17:49	wheals	Note Added: 0029767
2015-11-10 17:49	wheals	Status	new => resolved
2015-11-10 17:49	wheals	Fixed in Branch	=> 0.18 development branch
2015-11-10 17:49	wheals	Resolution	open => done
2015-11-10 17:49	wheals	Assigned To	=> wheals
2015-11-17 17:56	Medar	Relationship added	has duplicate 0010083

Notes
(0029759) Reaver (developer) 2015-11-10 02:47	Just to be sure: you're not wearing a shield on this char, correct?

(0029760) dpeg (administrator) 2015-11-10 02:51	Can't because I am a DE and it's a two-hander! (% says "shield currently unavailable", and I am indeed not wearing one.)

(0029761) wheals (administrator) 2015-11-10 02:53	I think this is happening because it's a speed weapon, so in player.cc:_display_attack_delay(), the two calls to you.attack_delay may return different numbers even though your delay is really the same.

(0029763) Napkin (administrator) 2015-11-10 07:44	Nice weapon, dpeg :D Is there another bug with this message? Should it rather be saying "(is slowed by your insufficient shield skill)"? Without shield I see a certain attack speed reported. Putting a shield on lowers the reported speed by 1 or 2 - and with the original sentence, does it really mean the real attack speed will be even further slowed than already shown?

(0029767) wheals (administrator) 2015-11-10 17:49	Fixed in https://github.com/crawl/crawl/commit/2733cf4fda70. [^]