|
Viewing Issue Advanced Details
[ Jump to Notes ]
[ Wiki ]
|
[ View Simple ]
[ Issue History ]
[ Print ]
|
|
ID |
Category |
Severity |
Reproducibility |
Date Submitted |
Last Update |
|
0008038 |
[DCSS] Patches |
trivial |
N/A |
2014-01-24 00:44 |
2014-01-24 17:57 |
|
|
Reporter |
chris |
View Status |
public |
|
|
Assigned To |
Kate |
|
Priority |
normal |
Resolution |
done |
Local or Remote |
Local |
|
Status |
closed |
|
Operating System |
Other |
|
Projection |
none |
|
Console or Tiles |
Both |
|
ETA |
none |
Fixed in Branch |
0.14 ancient branch |
Product Branch |
0.14 ancient branch |
| |
Product Version |
|
|
|
Summary |
0008038: Exclude firewood from Ctrl-V except for Fedhas worshippers |
|
Description |
Those might frequently need to check plant HP for retreating, and Ctrl-V
is a convenient way of doing so. Everybody else just doesn't care about
stuff enough to flash it in (usually) green all over their screen.
---
I don't particularly like this special-casing on interface code myself, but it's both really useful with Fedhas and really annoying without, so here is my take. |
|
Steps To Reproduce |
|
|
Additional Information |
|
| Tags |
No tags attached. |
|
|
Attached Files |
 0001-Exclude-firewood-from-Ctrl-V-except-for-Fedhas-worsh.patch [^] (1,460 bytes) 2014-01-24 00:44 [Show Content] [Hide Content]From fbe72d84c59a1b4190d6f4b744d9f44936c1b164 Mon Sep 17 00:00:00 2001
From: Chris Oelmueller <chris.oelmueller@gmail.com>
Date: Fri, 24 Jan 2014 00:41:13 +0100
Subject: Exclude firewood from Ctrl-V except for Fedhas worshippers
Those might frequently need to check plant HP for retreating, and Ctrl-V
is a convenient way of doing so. Everybody else just doesn't care about
stuff enough to flash it in (usually) green all over their screen.
---
crawl-ref/source/showsymb.cc | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/crawl-ref/source/showsymb.cc b/crawl-ref/source/showsymb.cc
index 5adf88a..14621a1 100644
--- a/crawl-ref/source/showsymb.cc
+++ b/crawl-ref/source/showsymb.cc
@@ -17,6 +17,7 @@
#include "mon-util.h"
#include "monster.h"
#include "options.h"
+#include "religion.h"
#include "show.h"
#include "stash.h"
#include "state.h"
@@ -175,8 +176,13 @@ static monster_type _show_mons_type(const monster_info& mi)
static int _get_mons_colour(const monster_info& mi)
{
- if (crawl_state.viewport_monster_hp) // show hp directly on the monster
+ // Show hp directly on the monster, except for irrelevant ones.
+ // Fedhas worshippers might be interested in their plants however.
+ if (crawl_state.viewport_monster_hp
+ && (you_worship(GOD_FEDHAS) || !mons_class_is_firewood(mi.type)))
+ {
return dam_colour(mi) | COLFLAG_ITEM_HEAP;
+ }
int col = mi.colour;
--
1.8.5.3
|
|
|
Relationships 
