0007868: commanding enslaved monsters to retreat allows player to attack them without breaking charm

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0007868

[DCSS] Bug Report

minor

always

2013-12-16 13:23

2013-12-18 07:27

Reporter

LordLovebone

View Status

public

Assigned To

neil

Priority

normal

Resolution

done

Local or Remote

Both

Status

resolved

Operating System

All

Projection

none

Console or Tiles

Both

ETA

none

Fixed in Branch

0.13 ancient branch

Product Branch

0.14 ancient branch

Product Version

0.14-a0-1519-gc5e2f7f

Summary

0007868: commanding enslaved monsters to retreat allows player to attack them without breaking charm

Description

Seems like a possible bug/exploit

1) enslave any creature
2) command creature to Retreat (preferably player can stand in hall way and block hall way and make the creature retreat to a point blocked by the character)
3) The enslaved minion will just stand in front of you while you attack it, attacking it does not break enslavement. (if not ordered to retreat, it will break charm if you damage it)

Basically enslavement+retreat is a very safe method of killing extremely strong enemies since enslavement has a much longer duration than other disable spells.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Attached Files

0001-Allow-retreating-allies-to-go-hostile-when-attacked.patch [^] (884 bytes) 2013-12-16 20:11 [Show Content] [Hide Content]

From 5c633adcde72c3a700218312d51de125ed52fc8e Mon Sep 17 00:00:00 2001
From: BlackSheep <chris.terenzi@gmail.com>
Date: Mon, 16 Dec 2013 14:10:13 -0500
Subject: [PATCH] Allow retreating allies to go hostile when attacked

---
 crawl-ref/source/mon-behv.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crawl-ref/source/mon-behv.cc b/crawl-ref/source/mon-behv.cc
index 94db147..ba3502d 100644
--- a/crawl-ref/source/mon-behv.cc
+++ b/crawl-ref/source/mon-behv.cc
@@ -1255,7 +1255,7 @@ void behaviour_event(monster* mon, mon_event_type event, const actor *src,
     case ME_WHACK:
     case ME_ANNOY:
         // Orders to withdraw take precedence over interruptions
-        if (mon->behaviour == BEH_WITHDRAW)
+        if (mon->behaviour == BEH_WITHDRAW && src != &you)
             break;
 
         // Will turn monster against <src>, unless they
-- 
1.8.1.2

Relationships

Notes
(0024747) BlackSheep (reporter) 2013-12-16 20:16	One-line fix attached. I don't think src is ever null when behaviour_event() is called for ME_WHACK or ME_ANNOY, but it might be a good idea to throw "src && " ahead of the conditional I added.

(0024767) neil (administrator) 2013-12-18 07:27	Blacksheep's fix is now in trunk (0.14-a0-1548-g09a3b55) and stable (0.13.1-19-g4b9377e). Thanks! It isn't necessary to add a test for null, because the comparison is testing the pointers, not the values, and &you will never be null.

Issue History
Date Modified	Username	Field	Change
2013-12-16 13:23	LordLovebone	New Issue
2013-12-16 20:11	BlackSheep	File Added: 0001-Allow-retreating-allies-to-go-hostile-when-attacked.patch
2013-12-16 20:16	BlackSheep	Note Added: 0024747
2013-12-18 07:27	neil	Note Added: 0024767
2013-12-18 07:27	neil	Status	new => resolved
2013-12-18 07:27	neil	Fixed in Branch	=> 0.13 stable branch
2013-12-18 07:27	neil	Resolution	open => done
2013-12-18 07:27	neil	Assigned To	=> neil

Mantis 1.1.8[^]