0006729: Dispel undead allows casting when enemy out of range and doesn't confirm targeting yourself

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

Tags

patch

Attached Files

dispel.png [^] (246,466 bytes) 2013-03-03 11:40

0001-Confirm-self-targeting-with-Dispel-Undead.patch [^] (1,006 bytes) 2013-04-05 18:44 [Show Content] [Hide Content]

From ab227035b2d06eef43d91faeba64ac1bc55545e3 Mon Sep 17 00:00:00 2001
From: Pekka Lampila <pekka.lampila@iki.fi>
Date: Fri, 5 Apr 2013 19:41:01 +0300
Subject: [PATCH] Confirm self targeting with Dispel Undead

---
 crawl-ref/source/directn.cc |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/crawl-ref/source/directn.cc b/crawl-ref/source/directn.cc
index 3cd8628..59b0260 100644
--- a/crawl-ref/source/directn.cc
+++ b/crawl-ref/source/directn.cc
@@ -960,7 +960,8 @@ bool direction_chooser::move_is_ok() const
 
             if (!may_target_self && (mode == TARG_ENEMY
                                      || mode == TARG_HOSTILE
-                                     || mode == TARG_HOSTILE_SUBMERGED))
+                                     || mode == TARG_HOSTILE_SUBMERGED
+                                     || mode == TARG_HOSTILE_UNDEAD))
             {
                 if (cancel_at_self || Options.allow_self_target == CONFIRM_CANCEL)
                 {
-- 
1.7.10.4

Relationships

duplicate of	0006674	resolved	Kate	Plants should not count against "no visible monsters within range"
has duplicate	0007050	resolved	Kate	When casting Dispel Undead as a Vampire, it automatically targets yourself without prompt

Notes
(0021239) elliptic (developer) 2013-03-03 16:17	Are you sure there is no confirmation? You should still get a confirmation message when you actually try to fire dispel undead at yourself, unless you've messed up your rcfile settings. Aside from that, this is the fault of those pesky plants, as explained in 0006674.

(0021241) Medar (developer) 2013-03-03 17:10	Tested again, with default rcfile in the latest trunk. No warning.

(0022154) Medar (developer) 2013-04-05 18:44	Added a patch to confirm self targeting

(0022414) Kate (developer) 2013-04-24 02:41	Pushed, thanks for the patch!

Issue History
Date Modified	Username	Field	Change
2013-03-03 11:40	Medar	New Issue
2013-03-03 11:40	Medar	File Added: dispel.png
2013-03-03 16:15	elliptic	Relationship added	duplicate of 0006674
2013-03-03 16:17	elliptic	Note Added: 0021239
2013-03-03 17:10	Medar	Note Added: 0021241
2013-04-05 18:44	Medar	File Added: 0001-Confirm-self-targeting-with-Dispel-Undead.patch
2013-04-05 18:44	Medar	Note Added: 0022154
2013-04-12 15:14	Medar	Tag Attached: patch
2013-04-24 02:41	Kate	Note Added: 0022414
2013-04-24 02:41	Kate	Status	new => resolved
2013-04-24 02:41	Kate	Fixed in Branch	=> 0.13 development branch
2013-04-24 02:41	Kate	Resolution	open => done
2013-04-24 02:41	Kate	Assigned To	=> Kate
2013-04-24 02:53	Medar	Status	resolved => closed
2013-05-15 19:59	Kate	Relationship added	has duplicate 0007050

Mantis 1.1.8[^]