0005554: reproducible crash in line_reader - Dungeon Crawl Stone Soup Tracker

Notes
(0017714) edlothiol (developer) 2012-04-11 15:09	I think it happens with any input when it's too long to fit into the message area (i.e. needs more lines than there are available).

(0017715) neil (administrator) 2012-04-11 15:39 edited on: 2012-04-11 15:54	I looked into fixing this, thinking I could just cut off the first N lines if the first line would have y = (1 - N). However, that just leads to a different crash, when the last few lines go off the end of the screen. The number of lines needed is estimated by ((start.x + nchars - 1) / wrapcol), but wordwrap_line might produce more lines (up to twice as many) because it tries not to break words. A solution would be to character-wrap rather than word-wrap; or to restructure the code so that the lines are wrapped before trying to guess where the cursor should go. The former still has problems with full-width CJK characters.

(0028539) neil (administrator) 2015-02-20 21:23	Probably simpler to fix now that it's back to column- rather than word-wrapping (0.16-a0-4058-ga3e9557).

(0028673) neil (administrator) 2015-03-19 22:43	Should be fixed, finally, in 0.17-a0-117-g31482b3. There are still some display bugs (when the prompt scrolls off because of the size of the input line, it won't come back even if you clear the input line), but the crashes seem to be fixed.

Relationships