Viewing Issue Advanced Details Jump to Notes ] Wiki ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0012240 [DCSS] Bug Report minor always 2020-04-15 15:55 2020-04-17 00:01
Reporter Flugkiller View Status public  
Assigned To
Priority normal Resolution open Local or Remote Remote
Status new   Operating System Online
Projection none   Console or Tiles WebTiles
ETA none Fixed in Branch Product Branch 0.25 stable branch
  Product Version
Summary 0012240: Xom fake banishment does not work properly at XL 5 or below
Description I might be missing something here, but when looking at the code, in xom.cc, line 3020, the debug parameter is true, which means that _revert_banishment() is not called in line 2600. I assume that to fix this you'd just have to change the parameter to false.
Steps To Reproduce
Additional Information
Tags No tags attached.
Attached Files bz2 file icon 2019-03-30.03_59_32.ttyrec.bz2 [^] (141,826 bytes) 2020-04-15 16:22
txt file icon morgue-Flugkiller-20190330-044207.txt [^] (25,455 bytes) 2020-04-16 23:59 [Show Content]

- Relationships

-  Notes
(0033768)
Flugkiller (reporter)
2020-04-15 16:21

If I did misinterpret this (which is likely), I have at least one example of Xom banishment at XL 5 where I couldn't see any messages about Xom being bored (which hopefully means I can assume that Xom isn't bored). I'll attach this to the issue.
(0033769)
amalloy (developer)
2020-04-15 16:31

The code you point to doesn't look like a problem to me. I don't really understand the purpose of this debug parameter, but the important thing is that in either case it returns XOM_BAD_PSEUDO_BANISHMENT, and _xom_pseudo_banishment clearly calls _revert_banishment at the end.
(0033770)
Flugkiller (reporter)
2020-04-16 00:44

Oh, I see, thanks for clarifying. ...should this issue be closed then?
(0033772)
amalloy (developer)
2020-04-16 02:22

Well, you have a ttyrec that suggests it's still happening. I haven't had a chance to watch, but if that's correct then the issue is still occurring and should be open.

Do you have a morgue file as well? That would probably help more than a ttyrec anyway.
(0033773)
amalloy (developer)
2020-04-16 02:22

Well, you have a ttyrec that suggests it's still happening. I haven't had a chance to watch, but if that's correct then the issue is still occurring and should be open.

Do you have a morgue file as well? That would probably help more than a ttyrec anyway.
(0033775)
Flugkiller (reporter)
2020-04-17 00:01

I've attached the morgue now. Looking at the morgue, it does seem like the banishment should have been caused by Xom being bored, but there were no messages about Xom becoming/being bored in the game (which was the reason why I thought this was caused by a "normal" Xom action). Do you know what could have caused this?

Also, I'm aware that this morgue is from a somewhat earlier version of the game, I hope this isn't an issue, sorry.

- Issue History
Date Modified Username Field Change
2020-04-15 15:55 Flugkiller New Issue
2020-04-15 16:11 Flugkiller Issue Monitored: Flugkiller
2020-04-15 16:11 Flugkiller Issue End Monitor: Flugkiller
2020-04-15 16:21 Flugkiller Note Added: 0033768
2020-04-15 16:22 Flugkiller File Added: 2019-03-30.03_59_32.ttyrec.bz2
2020-04-15 16:31 amalloy Note Added: 0033769
2020-04-16 00:44 Flugkiller Note Added: 0033770
2020-04-16 00:44 Flugkiller Note Added: 0033771
2020-04-16 00:45 Flugkiller Note Deleted: 0033771
2020-04-16 02:22 amalloy Note Added: 0033772
2020-04-16 02:22 amalloy Note Added: 0033773
2020-04-16 23:59 Flugkiller File Added: morgue-Flugkiller-20190330-044207.txt
2020-04-17 00:01 Flugkiller Note Added: 0033775


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker