Anonymous | Login | 2024-04-24 15:38 CEST |
Main | My View | View Issues | Change Log | Wiki | Tavern | News |
Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ] | [ View Simple ] [ Issue History ] [ Print ] | ||||||||||||
ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||||||
0011122 | [DCSS] Bug Report | minor | always | 2017-06-25 00:59 | 2017-10-12 18:36 | ||||||||
Reporter | Fixer | View Status | public | ||||||||||
Assigned To | advil | ||||||||||||
Priority | normal | Resolution | done | Local or Remote | Local | ||||||||
Status | resolved | Operating System | Windows | ||||||||||
Projection | none | Console or Tiles | Tiles | ||||||||||
ETA | none | Fixed in Branch | 0.21 ancient branch | Product Branch | 0.21 ancient branch | ||||||||
Product Version | |||||||||||||
Summary | 0011122: Bad resizing on small screens (fullscreen mode) | ||||||||||||
Description |
Had luck playing 0.20 on laptop with 1366*768px ("thank you" laptop manufactures for putting 90s resolution on anything mainstream), dcss code detected screen size is too small and forced it to go fullscreen, no problem, BUT, WHY this -90/-90px insanity for fullscreen? You end up with ugly blurry scaling to 1276x678 in default config. What is usecase for this change for fullscreen? I think fullscreen should not have -90/-90px but must use native resolution. Windows 10 32bit @ DCSS 0.20 stable Thanks! Commit in question: https://github.com/crawl/crawl/commit/45bdf812ecb1ac09e19663bf9380a0f58f1c2b4c [^] |
||||||||||||
Steps To Reproduce | |||||||||||||
Additional Information | |||||||||||||
Tags | No tags attached. | ||||||||||||
Attached Files | |||||||||||||
|
Notes | |
(0031691) advil (administrator) 2017-06-25 10:13 |
Crawl should run just fine as windowed at 1366x768, and does so at least on a mac (macbook air 11"). Can you confirm that you have tile_full_screen = falsein your rc file? I'm not sure offhand why it's doing the -90 thing, that could be a bug (maybe intended for non-fullscreen), but it looks like as a workaround you should be able to override that by setting: tile_window_width = 0 tile_window_height = 0 |
(0031692) advil (administrator) 2017-06-25 10:33 edited on: 2017-06-25 11:02 |
Just a bit more info, the size below which fullscreen is forced is 1024x800 (in either dimension). I think though that if `tile_full_screen=false`, it won't do that -- it would need to be set as auto. Also, on a mac setting the windowsize in fullscreen mode has no effect [edit: setting it negatively, i.e. probably setting it to a non-allowed resolution], so there may be some platform differences here that are causing problems. |
(0031693) Fixer (reporter) 2017-06-25 13:31 edited on: 2017-06-25 13:31 |
I've used clean config, options state that "tile_full_screen = false", I believe it properly detected that 768px < 800px and went fullscreen and used tile_window_width = -90 tile_window_height = -90 which resulted in ugly downscaling in fullscreen mode to 1276x678. Even windows warned me about this unoptimal resolution. Setting tile_window_width and tile_window_height to zero made it run properly in fullscreen native resolution. |
(0031694) Fixer (reporter) 2017-06-25 13:45 edited on: 2017-06-25 13:46 |
Fullscreen mode now uses native resolution and ignores tile_window_width/height setting since https://github.com/crawl/crawl/commit/b3e98cc55699 [^] Bug report can be closed I guess. |
(0031695) advil (administrator) 2017-06-25 18:34 |
'options state that "tile_full_screen = false"' This is actually incorrect, it is auto by default (but I guess the docs never got updated because there's no way to explicitly set auto except leaving the field out). If you explicitly set it to false it will override the auto mode. |
(0031696) Fixer (reporter) 2017-06-26 20:47 edited on: 2017-06-26 20:49 |
I've tried new build on 1366*768 screen and it runs with proper native resolution in fullscreen mode. Bug is fixed for me. Thanks! Can be closed. |
(0031881) advil (administrator) 2017-10-12 18:36 |
belatedly marking this as resolved, I think this is entirely fixed (including the docs). |
Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group |