-------------------------------------------------------------------------------- 0d7ab7f379 | Nicholas Feinberg | 2021-09-21 16:32:20 -0700 An immobile stone gathers much moss (Sastreii) New stone wall tiles for Swamp and Sewer. -------------------------------------------------------------------------------- 47465dbb04 | Nicholas Feinberg | 2021-09-21 16:22:53 -0700 Tweak orc weapon offsets again (ardl, gammafunk) -------------------------------------------------------------------------------- 960c72b710 | advil | 2021-09-21 10:27:04 -0400 fix: clean up failed crawl processes correctly in webtiles I think this should fix the lobby in scenarios we see where something goes very wrong with the webtiles server and the lobby ends up looking like there are many duplicate games. What was happening is that if an exception prevents the crawl process from starting altogether, the cleanup code was also throwing an exception on this first logging call because self.process was None. This prevented the inprogress file from getting removed, and the webserver's ongoing game table from getting cleaned up. This will unfortunately make it *harder* to see when a webtiles server is completely borked, so possibly something should be done about that. I did add an error message to the player when this happens. (In the process of adding this, I attempted to alleviate a race condition that was preventing exit dialogs from being shown when a process never started. Hopefully I did so correctly. Basically, multiple go_lobby messages in close timing will wipe out an exit dialog if it's already been shown.) -------------------------------------------------------------------------------- cc94558de3 | Nicholas Feinberg | 2021-09-20 21:35:55 -0700 Reduce delay for top-end twohanders It takes a ludicrous amount of XP to reach extremely high weapon skill in Dungeon Crawl, which made the rare top-end weapons (executioner's axes, lochaber axes and triple swords) hard to justify using. These are intended to be very exciting items, so it's sad that they ended up being 'traps' even for most characters that are interested in using their weapon type! In combination with the earlier XP curve changes, reducing delay by 1 aut each should hopefully make these weapons more viable for use in 3-rune games. New skill to mindelay: - Executioner's axe: 24 (was 26) - Bardiche: 24 (was 26) - Sword sword sword: 22 (was 24) -------------------------------------------------------------------------------- 2e89a317aa | AdamPG | 2021-09-20 21:35:55 -0700 Reduce the experience cost of high-level skills The cost of increasing a skill from 20 to 27 was more than the cost of increasing a skill from 0 to 20, making training extremely high level skills (e.g. for level 9 spells or slow two-handed weapons) a poor investment for most of the game. This commit makes the implicit quadratic-with-break-point formula explicit, and divides the break point contributions to skill costs above level 9 by 2. This has the following implications: * Skill costs up to level 9 are unaffected; * The new cost of skill level 15 is half-way between the old costs of level 14 and 15; * The new cost of skill level 20 is approximately the same as the old cost of skill level 19; * The new cost of skill level 27 is approximately the same as the old cost of skill level 25; * The decreases in costs are roughly equivalent to a +1 increase in aptitude by skill level 23, and the impact is always smaller than a +2 increase in aptitude. [Committer's note: code refactored.] Closes #1733. -------------------------------------------------------------------------------- 2eadbcdadc | Nicholas Feinberg | 2021-09-20 21:34:01 -0700 Cut late-game XP This commit reduces the total XP in a 3-rune game by about 20%, overwhelmingly concentrated in late-game areas. D and Lair are almost unchanged, while Zot loses about a third of its XP, for example. This should help compensate for impending apt changes, and also generally help with the late-game difficulty slump. -------------------------------------------------------------------------------- 902bb890a6 | Nicholas Feinberg | 2021-09-20 17:31:10 -0700 Flush some good art right down the toilet Repurpose last commit's Swamp wall tiles for Sewer. -------------------------------------------------------------------------------- c9b6b5e602 | Nicholas Feinberg | 2021-09-20 16:54:56 -0700 New Sastreii tiles (bloated husk etc) Also included are some Swamp tiles, but those are currently unused - I'm not sure what the best place to put them is. Maybe they should replace the existing rock tiles? -------------------------------------------------------------------------------- 9ecc6377bc | Nicholas Feinberg | 2021-09-20 16:46:12 -0700 Update battlesphere description (ardl) -------------------------------------------------------------------------------- 2d6a64c10f | Nicholas Feinberg | 2021-09-20 16:46:12 -0700 Fix Gozag player ghost speech (Spaninq) Oops! -------------------------------------------------------------------------------- f79e20f00e | Nicholas Feinberg | 2021-09-20 16:46:12 -0700 Fix Sting effect tile (spaninq) Oops! -------------------------------------------------------------------------------- 83f2989fac | Kate | 2021-09-20 02:14:13 +0100 Fix crashes when attempting to leave Zot For games where Depths was generated in a broken version, fix up the branch entry location for Zot and hopefully allow leaving the Zot again without crashing. -------------------------------------------------------------------------------- 6c43a8f463 | Implojin | 2021-09-19 21:46:17 +0100 fix: allow unrand air enhancer stacking (#2134) e08c5e17fd added an air enhancer to the amulet of the air, but unlike the rest of the spell enhancers in the game, it didn't permit stacking this with the elemental staff. This looks to me like an oversight rather than a balance issue, (especially given that you could still stack the amulet with a vanilla staff of air), so here's a fix. -------------------------------------------------------------------------------- eef7685dc3 | Implojin | 2021-09-19 21:45:30 +0100 Fix missing MUT_NOISE_DAMPENING punctuation (#2141) -------------------------------------------------------------------------------- 121bc3e445 | advil | 2021-09-19 12:32:23 -0400 fix: branch entry depths for zot and zigs This will ensure that zot entry actually generates. (I think it may also cause a fix up for any games without it on depths 4? Not sure.) -------------------------------------------------------------------------------- 516edc7163 | advil | 2021-09-19 11:35:43 -0400 test: tweak a bunch of CI test output * Remove the rng test, I think this is no longer needed * Apply some indents in a few cases * Remove most of the vault-related output; hopefully the failing seed number will be enough if this trips. This level of output was really from back when this test often failed. -------------------------------------------------------------------------------- 203a4d6027 | advil | 2021-09-19 11:35:34 -0400 fix: further update unique tests for shallower depths -------------------------------------------------------------------------------- 8b1ebaf2f3 | Nicholas Feinberg | 2021-09-19 08:17:04 -0700 ...fix the build? -------------------------------------------------------------------------------- 613524ee8a | Nicholas Feinberg | 2021-09-19 07:56:32 -0700 Shift orc weapons 1px left Feels better with their new beefy look. -------------------------------------------------------------------------------- 9bb89235eb | advil | 2021-09-19 10:33:11 -0400 fix: update fixup for depths portals to new values Also, comment on the code duplication. -------------------------------------------------------------------------------- e2d2658822 | Nicholas Feinberg | 2021-09-18 21:37:11 -0700 Fix the build Oops -------------------------------------------------------------------------------- 98ec5579a3 | Nicholas Feinberg | 2021-09-18 21:34:48 -0700 Make allies avoid shooting you (Torax) Use aimed_at_spot to have allies avoid hitting the player when they miss their actual target. Keep enemy & neutral behavior the same. It seems polite. -------------------------------------------------------------------------------- 3d4abc6862 | Nicholas Feinberg | 2021-09-18 21:09:52 -0700 Switch Sting back to its old tile The poison arrow is way too big and fancy for a level 1 spell. Partially reverts 3cb921fa598. -------------------------------------------------------------------------------- c732d1d4b8 | Nicholas Feinberg | 2021-09-18 21:06:04 -0700 Make Abyssal Knights a bit dumber Move 1 int into str and 1 into dex. They're no berserkers, but they're still not particularly inclined towards spellcasting, and they're weak enough that we might as will give them some slightly better suited stats. -------------------------------------------------------------------------------- 3788438092 | Nicholas Feinberg | 2021-09-18 21:04:35 -0700 Remove Tukima's Dance's power boost (hellmonk) Recent changes (removing monster weapon delay, allowing Tukima's Dance to affect ranged weapons) have made the spell much more powerful. It no longer needs the power boost it got when I originally rewrote it, so... let's toss it. -------------------------------------------------------------------------------- a22a9363c6 | Nicholas Feinberg | 2021-09-18 20:59:18 -0700 Ban channeling when you can't cast (gressup) Standardize and streamline. It might be helpful to have extra messaging here when you enter one of these states while channeling - it might be too easy to miss right now. -------------------------------------------------------------------------------- 706b79e7bb | Nicholas Feinberg | 2021-09-18 20:41:13 -0700 Remove tarantellas' bite Tarantellas are a perfectly fine monster and a great name pun, but their theme is extremely misleading. If a spider bites you, you'd naturally expect rPois to protect against the effects. But that's not how tarantellas work! Instead, make their attack a 'touch'. That should hopefully make their behaviour a little more intuitive, though I expect some people will still be surprised by the pure fact of them being spiders... -------------------------------------------------------------------------------- 2322c75162 | Nicholas Feinberg | 2021-09-18 20:36:22 -0700 Fix cloud targeters (CarefulOdds) They can't actually hit stuff through transparent walls. Broken since, god, 098d46cfcc740f maybe? Not sure, honestly. -------------------------------------------------------------------------------- 6302f7b1d6 | Nicholas Feinberg | 2021-09-18 20:25:47 -0700 Remove Depths:1 (mostly) Recent changes to differentiate Depths from Vaults caused it to become considerably more intense. That's not a bad thing! But 5 straight levels of powerful intensity are a bit much. Let's draw it down to 4. Vaults have mostly been adjusted, but I'm sure I missed a few. -------------------------------------------------------------------------------- c45d5503f1 | Nicholas Feinberg | 2021-09-18 20:04:29 -0700 Clarify Conjure Living Spells desc Specify which spells a given tome will create in the spell description. -------------------------------------------------------------------------------- e8cdce0153 | Nicholas Feinberg | 2021-09-18 19:56:12 -0700 Plop walking tomes in Depths Replacing the high tier deep elves, which still have plenty of other places to show up (Elf, Vaults:5, many vaults, etc). On average, looks like you'll see about two tomes per Depths. -------------------------------------------------------------------------------- a443631078 | Nicholas Feinberg | 2021-09-18 19:42:29 -0700 Make Blink Allies Encircling drain energy (ardl) Don't let enemies hit you on the same turn they get blinked encircling around you. It seems excessively cruel to be hit by 5 guys who weren't on screen the turn before. -------------------------------------------------------------------------------- f8b08d3f47 | Nicholas Feinberg | 2021-09-18 19:42:23 -0700 Axe ironbound beastmasters Ironbound beastmasters were a whole pile of cool ideas, none of which quite panned out. - They depended very heavily on their bands, which tends to work poorly (it's pretty common for monsters to get separated) - They had some hacks to guarantee they'd only generate with bands, which broke monster queries and still didn't prevent them from getting separated. - The effects of their spell was poorly communicated to players - the energy system is a very secret under-the-hood effect, unlike e.g. haste, which has a visible effect. - They weren't tuned to the point of being very strong. (This is the most fixable issue.) There was some discussion of replacing them with a summoner that calls and berserks harpies and such, and we could still do that. For now, though, let's roll back this experiment. Partially reverts 0b001bae985. -------------------------------------------------------------------------------- ea7fc97e4c | Nicholas Feinberg | 2021-09-18 15:42:34 -0700 Give orcs a workout (Sastreii) New basic orc and orc warrior tiles. -------------------------------------------------------------------------------- 4d16425fc6 | Nicholas Feinberg | 2021-09-18 15:38:30 -0700 Add a truly thrilling trio (Sastreii) -------------------------------------------------------------------------------- 5baa6b73be | Nicholas Feinberg | 2021-09-16 19:17:31 -0700 Spider stone sprites (Sastreii) SSSS SSSS -------------------------------------------------------------------------------- b47aa1321a | Nicholas Feinberg | 2021-09-16 17:55:39 -0700 Add a truly thrilling trio (Sastreii) New tiles: zombie human, elf, and ogre.n -------------------------------------------------------------------------------- 0b43c73ce0 | Nicholas Feinberg | 2021-09-16 07:38:35 -0700 Fix Ignis invocation frames (Sastreii) -------------------------------------------------------------------------------- 0f06bd746f | Nicholas Feinberg | 2021-09-15 17:11:03 -0700 New zombie tiles (Sastreii) Lizard and large and in charge. -------------------------------------------------------------------------------- 7dc2aef8ca | Nicholas Feinberg | 2021-09-15 08:03:36 -0700 Simplify Petrifying (dilly) Don't consider petrifying creatures to be fully incapacitated. This fixes a bug in which petrifying monsters couldn't shoot or throw (though they could still cast spells, attack, etc). It also allows all petrifying (but not petrified) creatures, monsters and players, to block attacks with shields, which probably doesn't matter that much. -------------------------------------------------------------------------------- 535839065c | Nicholas Feinberg | 2021-09-14 17:37:22 -0700 Fix slime wall death message Broken in e619aef00bffaae3f811d3ff97aa9ddea2c37f07. Oops! -------------------------------------------------------------------------------- 079b763570 | Nicholas Feinberg | 2021-09-14 17:24:39 -0700 Electrify cats and calamari (Sastreii) Two new species-specific Storm Form tiles. -------------------------------------------------------------------------------- 50180c0d78 | Nicholas Feinberg | 2021-09-14 11:39:27 -0700 Storm Form player tile (Sastreii) -------------------------------------------------------------------------------- 27616f31e4 | Kate | 2021-09-14 18:26:12 +0100 Don't crash when failing to pacify nothing Targeting empty space with pacification is allowed so that invisible monsters can be pacified, but doing so still costs a turn to avoid leaking information. However if the attempt to use the ability rolled a failure, it would instead crash when targeting an empty space due to a missing fail_check(). -------------------------------------------------------------------------------- 5218f81949 | Kate | 2021-09-14 18:26:12 +0100 Adjust some randart names Remove "of Battle" to avoid overlap with the unrand, and Australianise some spelling. -------------------------------------------------------------------------------- 5de4b4396b | Edgar A. Bering IV | 2021-09-14 09:17:37 -0500 fix: give seracall its own beam name -------------------------------------------------------------------------------- e8575c7553 | Edgar A. Bering IV | 2021-09-14 09:08:26 -0500 fix: restore berserk and confusion checks for evocables (12651) The misc evokers had confusion (but not berserk) checks in their specific methods, while wands had no checks at all. -------------------------------------------------------------------------------- 103e827438 | Edgar A. Bering IV | 2021-09-14 08:11:21 -0500 feat: replace hell contam with temporary mutations In the game of one of these things is not like the other, the contam hell effect produced permanent strategic damage, the other two produced XP gated strategic damage. Contam hits a few more things other than mutations (putting a brake on miscasts and preventing invis) but the interaction with the mutation system is the noticable part in hell. At the rate we'd like to apply hell effects, however, it gets to be a bit much in terms of permanent damage. So let's try temp mutations. -------------------------------------------------------------------------------- 5e7bb1d84c | Edgar A. Bering IV | 2021-09-14 08:11:21 -0500 feat: slow down hell effects Still trying to dial these in to a good place. The larger effects less frequently make for spikes, which are more exciting (do I gamble and press on I'm almost there) than smaller more frequent attrition. -------------------------------------------------------------------------------- e2dae52223 | Nicholas Feinberg | 2021-09-13 21:06:00 -0700 Remove unthings None of these placeholder monsters exist enough to even be used in vaults. -------------------------------------------------------------------------------- 0687ed57fd | Nicholas Feinberg | 2021-09-13 12:26:56 -0700 New randart name Specifically to break formatting. -------------------------------------------------------------------------------- 941f9de75c | Nicholas Feinberg | 2021-09-13 09:14:22 -0700 Reorganize Mlio Since it no longer appears in Depths. -------------------------------------------------------------------------------- 6aa5aab5a4 | Nicholas Feinberg | 2021-09-13 07:57:04 -0700 Remove an antique "faith special case (hellmonk) If you were at 15 piety or less when you removed the amulet of faith, you wouldn't lose any piety. This was introduced in the very first commit that added "faith, 5871154a2e, and has never really had a good reason to exist. Simplify. -------------------------------------------------------------------------------- 2dc4ca5097 | Nicholas Feinberg | 2021-09-12 21:19:52 -0700 Make Chei chill out Instead of being angry at berserk rage, just turn off the haste (as Chei already did when you quaffed un-id'd !zerk). In general, there aren't a lot of situations where divine penance for actions is more fun than your god just shutting things off. This (esp in light of recent changes to e.g. zerkitis) was no exception. -------------------------------------------------------------------------------- 91930fd77e | Nicholas Feinberg | 2021-09-12 20:11:38 -0700 Walking Tome tiles (Sastreii) Book it! -------------------------------------------------------------------------------- aa0f46ea79 | Neil Moore | 2021-09-12 21:33:22 -0400 Two new splash screens by KaoNedong Licensed under CC0. Source for the images: https://www.deviantart.com/kaonedong -------------------------------------------------------------------------------- 4afc6ae9f4 | Kate | 2021-09-13 00:20:54 +0100 Fix tag_upgrade compilation -------------------------------------------------------------------------------- ce0acab4f2 | Kate | 2021-09-12 23:52:33 +0100 Replace Leech's *Rage with Harm *Rage is a fairly severe downside and means the player should expect to berserk in every combat, which heavily limits the chances of any items with it from being actually used. It's very thematic on the Wrath of Trog and necklace of Bloodlust, and the zealot's sword also has a unique (although perhaps hard-to-utilise) interaction with berserk, but the other unrands with *Rage could use different downsides to encourage still using them. The hat of the Bear Spirit could use a new idea, but for Leech, replace *Rage with Harm (and drain-on-unequip to prevent it from being freely swappable). The only other use of Harm on an unrand is the robe of Misfortune, so Leech's guaranteed vampiricism seems like a fun place to encourage trying to work around Harm's downsides. -------------------------------------------------------------------------------- cbfb7e9818 | Kate | 2021-09-12 23:52:23 +0100 Remove the Elemental Staff's Will++ Since it doesn't fit the elemental theme, and it's now a pretty strong actual weapon on top of giving out a heap of resistances. -------------------------------------------------------------------------------- b5e7e19f26 | Kate | 2021-09-12 23:25:36 +0100 Give the *Rage inscription its star back Since the * is inscription-ese for "this thing triggers some random portion of the time when x condition is met" (as with *Noise, *Slow, *Corrode). -------------------------------------------------------------------------------- 73f125ba1b | Kate | 2021-09-12 23:25:19 +0100 Remove an unused parameter -------------------------------------------------------------------------------- 0f1c06f14f | Kate | 2021-09-12 23:25:12 +0100 Fix compilation -------------------------------------------------------------------------------- 2fb25c9035 | Edgar A. Bering IV | 2021-09-12 17:10:28 -0400 feat: combine berserkitis and item Rage The separate displays and (slightly) separate semantics for "go berserk on melee hit" confounded the issue, especially since berserkitis' chances are so small at low levels. This commit changes berserkitis to simply grant angry percentage points, identical to other sources of random berserk. It does mean that berserkitis now works through clarity and causes Cheibriados penance. This is consistent with the previous commits: berserkitis only triggers on melee attacks, which are intentional. If this is too severe some grace can be hacked in for Chei followers, but the fraction of characters that will find berserkitis much worse than they already do is tiny. -------------------------------------------------------------------------------- e692aea802 | Edgar A. Bering IV | 2021-09-12 17:08:49 -0400 feat: remove evoked berserk, increase *Rage berserk chance Step-by-step we have been cutting back on items that add active abilities to the 'a' menu: even with the quiver these abilities are often forgotten by players for ui reasons since they only come from artefacts (+Inv is the remaing exception) so aren't frequently encountered. A player can't forget to use a "passive" ego. *Rage was meant as a bad property. With a 5% chance to berserk it was small enough that one could take a swing here and there and not expect to berserk (making it an unreliable source of zerk), but large enough that a player trying to use it had to approach fights expecting to go berserk in every fight. This commit removes +Rage in favor of giving *Rage a greater chance to trigger berserk, currently 20%. This leans into the "always be ready to zerk", while being low enough that it's not a guaranteed immediate berserk in desparate situations. The insrcription is changed simply to "Rage". When it comes to changing unrands: - Leech and Bear Spirit might want lower (or 0) Angry values, but for now they both get the standard 20% for clarity; - the necklace of bloodlust, which has a swap penalty and extra zerk powers, gets a 50% zerk chance - the wrath of Trog, with its swap penalty, keeps its 50% zerk chance - the Zealot's sword gets the standard 20% chance; The chance contribution is shown in the item description, and the total zerk chance is shown in the character overview if nonzero. -------------------------------------------------------------------------------- d8b2e6da16 | Nicholas Feinberg | 2021-09-12 12:15:42 -0700 s/inflammable/combustible (FIQ) Reduce ambiguity about the meaning of FIRE_VULN. -------------------------------------------------------------------------------- a6d6528d93 | Edgar A. Bering IV | 2021-09-12 13:00:12 +0200 fix: clarify battlesphere description (12644) -------------------------------------------------------------------------------- 35c06b56df | Edgar A. Bering IV | 2021-09-12 12:59:05 +0200 Revert "fix: Clarity once again blocks *Rage berserk (Mantis 12640)" This reverts commit 51f8dfeb475ed0e39ea3046524384fdaf5c92adb. Commit 51f8dfe intentionally made *Rage on artefacts an intentional source of berserk, as equipping the item and attacking in melee is intentional, and otherwise Chei players could get access to penance free berserk (the hates item code is only for generating the warning prompt, penance comes from actually using it). This revert clarifies the description of *Rage to make it read as intentional source of berserk (like the potion or +Rage), which clarity does not block. It also displays the items contribution to the berserk chance, and makes these contributions linear so the probability is clear to players. -------------------------------------------------------------------------------- 1f95980246 | Nicholas Feinberg | 2021-09-11 21:32:30 -0700 Clarify Ash wrath (JF) -------------------------------------------------------------------------------- b986a403c0 | gammafunk | 2021-09-11 22:03:30 -0500 fix: Don't give cloud rings to friendly pan lords Before this commit, friendly pan lords from the Pentagram card could get cloud rings that would damage the player and their allies. Prevent this by passing the necessary attitude information to the ghost demon code we use to initialize pan lords. -------------------------------------------------------------------------------- 51f8dfeb47 | Seve Monahan | 2021-09-11 14:02:42 -0500 fix: Clarity once again blocks *Rage berserk (Mantis 12640) 516ec7 unintentionally caused *Rage to work on characters with Clarity. This is because 'intentional' rage bypasses Clarity, and 516ec7 caused *Rage berserks to be classified as intentional. Since 911e812, *Rage artifacts have been classified as intentionally hasty at all times. This has similar implications for Chei worshippers as 516ec7 was intending (i.e, Chei worshippers can't use *Rage artifacts without provoking penance). As a result, I do not believe any further changes to the Chei/*Rage interaction are necessary. -------------------------------------------------------------------------------- 34660d7429 | advil | 2021-09-11 13:03:29 -0400 fix: improve SIGHUP handling in clua code on dgl builds User lua that involved hand-rolled prompts could interact in a bad way with SIGHUPs, prevent the game from ever properly handling the HUP. The following example based on long-time crash generator `ziggurnaut` is a case in point: { function ready() force_prompt("asdf") end function force_prompt(text) while true do crawl.formatted_mpr(text) crawl.formatted_mpr("Type p", "prompt") res = crawl.getch() if string.lower(string.char(res)) == "p" then break end end end } If the player disconnects at the prompt, the `while` loop runs in a tight loop because getch returns immediately without a client, and the loop never exits on its own, so the HUP isn't handled. The webserver does detect this 10s or so later, and kills the process with SIGABRT, so the issue isn't catastrophic, but it still is 100% cpu for that time period and generates an annoying crash report in #crawl-dev. (For reference, the best thing to do here on the current API would be to also accept ESC (27) at any prompt implemented in a loop like this; getch returns ESC on disconnects. Or just use crawl.yesno instead of trying to write a custom one.) This commit piggybacks on the clua throttle code to check for HUPs if the throttle trips; if a HUP has been seen it immediately errors out of clua code, which leads to a graceful shutdown of the process. It's possible this could use its own separate hook (which would let it work by default on non-DGL builds as well, and possibly be checked more often), but the main problem here is on webtiles so I'm going with this more minimal solution for now. -------------------------------------------------------------------------------- 1af55ca459 | advil | 2021-09-11 13:03:29 -0400 fix: don't allow c_message reentry This hook is already pretty wild, given the arbitrary points where mpr can be called from, but it's additionally very, very easy to trigger recursion that would be infinite if it weren't for the lua stack limit. Depending on what happens this recursion can be quite cpu intense as well, even with the stack limit. This commit just prevents any recursive triggering of the hook in a heavy-handed way. (Overall, I find this hook quite worrying, and I suspect it still needs substantial auditing.) -------------------------------------------------------------------------------- 8072b577e9 | advil | 2021-09-11 13:03:29 -0400 fix: step up lua throttle aggressiveness On testing, a tight loop in ready() takes nearly 3 minutes to get killed by this on a fast cpu, and does still have a noticeable cpu impact until then -- I expect it'd be much worse on a busy server. This commit makes the throttle kill scripts much more aggressively, and also, if ready() in particular is killed by the throttle, keeps it from running again. If this runs up against legitimate online use we can adjust, but I really think it won't. I tested this on qw, and qw does trip the throttle but never more than ~4 times in a row at the absolute max. So 15 is still extremely conservative. It's possible that this could be tightened even further: e.g. by starting the throttle time at something like 128ms instead of 2, or by reducing the number of lua instructions this is checked between (currently defaults to 50000 I think). No impact outside of webtiles. -------------------------------------------------------------------------------- b603f484b2 | Nicholas Feinberg | 2021-09-11 08:15:45 -0700 Scorch and Flame Wave tiles (Sastreii) -------------------------------------------------------------------------------- e3cd3e9c68 | Nicholas Feinberg | 2021-09-10 20:00:27 -0700 Stoker tile (Sastreii) I'm stoked. Are you? -------------------------------------------------------------------------------- 4cf4cd4993 | Nicholas Feinberg | 2021-09-10 10:08:01 -0700 Dial down tile_show_threat_level defaults Only show on nasties by default. -------------------------------------------------------------------------------- 3d58a18ffd | Nicholas Feinberg | 2021-09-10 10:02:08 -0700 Ignis altar tile (Sastreii) -------------------------------------------------------------------------------- 3d5cecec24 | Nicholas Feinberg | 2021-09-10 09:15:51 -0700 Make a BIG removal Remove SIZE_BIG, switching monsters into either SIZE_LARGE or SIZE_GIANT as seems appropriate. Following up on 7bd0902ce6cc84c6, we really don't need two sizes that are 'bigger than any player race'. Is a yaktaur bigger than a centaur? How does a spatial maelstrom compare in size to a fire dragon? These are questions that we don't care about and shouldn't bother with. This is a small buff to dragon form and maybe a nerf to something else. Who knows. -------------------------------------------------------------------------------- 07589e2de0 | advil | 2021-09-10 11:58:17 -0400 fix: remove comma -------------------------------------------------------------------------------- 392f49ab0d | Nicholas Feinberg | 2021-09-10 08:40:45 -0700 Remove Okawaru Commander title (Graveyardigan) Since Okawaru now prevents you from commanding anyone. Toss in 'Myrmidon' instead, shifting "Warmonger" one higher. -------------------------------------------------------------------------------- 579aff930e | Nicholas Feinberg | 2021-09-10 08:23:57 -0700 Refactor Ignis quiver logic (advil) Allow quivering but don't do so by default. -------------------------------------------------------------------------------- 32eb216c14 | Nicholas Feinberg | 2021-09-10 08:22:35 -0700 Don't autoquiver wizmode abilities Makes testing default quiver stuff impossible. -------------------------------------------------------------------------------- e87aa7cc50 | Nicholas Feinberg | 2021-09-10 08:17:05 -0700 Default tile_show_threat_levels Experimentally set tough and nasty on by default, in an attempt to make it clearer to players when something spooky is headed their way. -------------------------------------------------------------------------------- 118590704b | Nicholas Feinberg | 2021-09-10 08:12:59 -0700 Ignis ability icons (Sastreii) Might want to recolor these or Trog's at some point to avoid overlap, but confusion doesn't seem very likely. -------------------------------------------------------------------------------- c56ee47f37 | Nicholas Feinberg | 2021-09-10 07:59:22 -0700 Searing Wretch tile (Sastreii) https://cdn02.plentymarkets.com/qozbgypaugq8/item/images/1625/full/PSTR-DOOM002. jpg -------------------------------------------------------------------------------- 1448048969 | Nicholas Feinberg | 2021-09-09 11:18:36 -0700 Turn down Hell effects Per popular demand. - Contamination down 25% (from 4-8k to 3-6k). - Stat drain down 33% (from 2-7 to 1-5). HP drain is unaffected. These numbers are still fairly arbitrary and remain subject to revision in either direction. -------------------------------------------------------------------------------- b8cf3755b2 | Nicholas Feinberg | 2021-09-09 11:13:25 -0700 Don't quiver Ignis abilities (various) Too pricey, too easy to misfire. Womp womp. -------------------------------------------------------------------------------- 6657d4870c | Nicholas Feinberg | 2021-09-09 11:09:26 -0700 Nargun tile (Sastreii) https://media.discordapp.net/attachments/747522859361894521/885578302797021234/S chermata_2021-09-09_alle_19.31.21.png -------------------------------------------------------------------------------- da42bb4400 | Nicholas Feinberg | 2021-09-09 07:46:38 -0700 Wendigo tile (Sastreii) when do they call it wendigo when you wendy go the cold food wendy go hot eat the food? -------------------------------------------------------------------------------- d0eccab798 | Nicholas Feinberg | 2021-09-08 11:45:25 -0700 Dragon cleanup (Sastreii) -------------------------------------------------------------------------------- b4fee303d0 | advil | 2021-09-08 14:17:11 -0400 fix: remove a book that required a lvl 1 hex This book placement is not saved by ffd9c288d6fe because there's nothing to reroll -- it'll crash unless there is a level 1 hex. Could be replaced? But for now I'm just removing it to fix crashing games. -------------------------------------------------------------------------------- af36da5c11 | Nicholas Feinberg | 2021-09-08 07:38:10 -0700 New Cactus & Manifold tiles (Sastreii) New tiles for the Manifold Assault and Summon Cactus Giant spells, along with a new tile for the Cactus Giant itself. -------------------------------------------------------------------------------- d71735cc25 | Nicholas Feinberg | 2021-09-07 15:54:29 -0700 Add Ignis altar description Oops! -------------------------------------------------------------------------------- d1dd6c5fb5 | hellmonk | 2021-09-07 14:04:56 -0400 feat: add an ambush vault to lair It's called ambush because there am a lot of bush. -------------------------------------------------------------------------------- 0c02eea278 | Nicholas Feinberg | 2021-09-07 09:16:54 -0700 New Kobold tiles (Sastreii) Goodbye, kobold vest. You will be missed. -------------------------------------------------------------------------------- 3dc288482e | Nicholas Feinberg | 2021-09-07 08:30:18 -0700 New zombie tiles (Sastreii) Gnoll, orc, wolf, bear, hydras. -------------------------------------------------------------------------------- 01ebcbcbcd | sdynet | 2021-09-07 08:16:38 -0700 Simplify the ranger card There are too many monsters with similar roles on this card. I want to cut out too many branches and leave only those who match the name of this card. Modified Effect: Now it summon only these three(centaur warrior, naga sharpshooter, deep elf master archer). -------------------------------------------------------------------------------- 4da15c877b | John Stahara | 2021-09-07 08:13:11 -0700 Accurately order a comment with the variables it describes -------------------------------------------------------------------------------- cae3918e47 | Perry Fraser | 2021-09-07 08:12:07 -0700 Improve Ratskin Cloak god interactions [Committer's note: - Don't allow the cloak to spawn rats that should hate you (hell rats under good gods, any rats under Oka or Sac Love) - Unmark the cloak as evil.] Closes #2102 -------------------------------------------------------------------------------- cf6c460519 | Nicholas Feinberg | 2021-09-07 07:59:26 -0700 Tweak Ignis wratch status msg (dilly) -------------------------------------------------------------------------------- 55a29874ef | Nicholas Feinberg | 2021-09-07 07:45:43 -0700 Make Scorch suitable for sauna use Create steam clouds when it hits someone in water, for consistency with other fire effects. -------------------------------------------------------------------------------- de365fb1df | Nicholas Feinberg | 2021-09-06 13:39:49 -0700 Cut Storm Form power scaling 20% It's a bit stronger than I intended at high power, partially because I got the math slightly wrong when setting it up. Let's scale it back somewhat. -------------------------------------------------------------------------------- 9c2f8b1708 | Nicholas Feinberg | 2021-09-06 13:15:01 -0700 Reduce Searing Ray power scaling Searing Ray is a fun and distinctive early-game spell. However, with the current damage values, it remains surprisingly effective well into Lair branches, reducing the need to branch out into new spells. To increase variety, let's keep the min damage the same while reducing the max damage about 25%, from 3d7 to 2d8. (Fewer dice should also increase variance, which is nice.) -------------------------------------------------------------------------------- ffd9c288d6 | advil | 2021-09-06 14:02:57 -0400 fix: reroll spell schools for crashing hex books After d4a3b56016 removed corona, there are currently no level 1 hexes. The vault spec randbook generation code did not handle cases where a vault spec could not find any spells at all, which happened for some early randbook placements that tried to include a single level 1 spell, if they rolled hexes after this change. This commit adds a somewhat convoluted means of rerolling the book discipline(s) if the first try fails. It does fix the version of this crash that I have replicated. -------------------------------------------------------------------------------- bef64dd269 | hellmonk | 2021-09-05 23:53:28 -0400 Rework the flesh golem This Cigotuvi wizlab monster is a reskinned iron golem, so it got buffed when they did. While a wizlab-depth player can certainly deal with a slow 300 hp monster, it feels pretty awful to have to do it. Lower it to ~100 hp and give it corrupting pulse so it has something to do besides walk slowly at you. -------------------------------------------------------------------------------- 6a72785379 | Nicholas Feinberg | 2021-09-05 10:59:27 -0700 End Ctouch on hitting will∞ (Graveyardigan) To save players who have made poor life decisions (e.g. casting Confusing Touch when going up against a fire elemental), make Confusing Touch end itself when you hit something that has infinite willpower (and hence can never be affected). -------------------------------------------------------------------------------- d4a3b56016 | Nicholas Feinberg | 2021-09-05 10:43:13 -0700 Make the hex 'Corona' monster-only See discussion in cafe5c4f27db83f. We may offer some compensation to arkane markspersons at a future date. (Or we may decide they're fine as-is.) -------------------------------------------------------------------------------- 69098e2f6d | Kate | 2021-09-05 00:53:25 +0100 Shorten a vault shop name It was too long to display the "What would you like to do?" shop prompt in console. -------------------------------------------------------------------------------- 4bac719ec2 | Nicholas Feinberg | 2021-09-04 12:09:37 -0700 Don't let sp. servitors cast v weak spells https://www.reddit.com/r/dcss/comments/phpjtn/ Also prune some monster-only spells. -------------------------------------------------------------------------------- b337144f63 | Kate | 2021-09-04 19:30:26 +0100 Staticify a function -------------------------------------------------------------------------------- d1960fc7b0 | Nicholas Feinberg | 2021-09-04 10:45:04 -0700 Make nonflammable trees block fire (ardl) (But really people shouldn't be using nonflammable trees! Booooo) -------------------------------------------------------------------------------- eb13ee3423 | Nicholas Feinberg | 2021-09-04 10:22:10 -0700 Maybe fix !cancel fly desc (particleface, shummie) Don't claim that !cancel will remove permanent sources of flight (e.g. items, species, etc) when you had some other actually dispellable duration active. -------------------------------------------------------------------------------- c0c42a9b79 | advil | 2021-09-04 10:57:45 -0400 build: improve messaging if `git describe` fails This message was pretty cryptic and didn't cover one major case at all (when `git describe --tags` fails because the repository is a shallow clone). The new error is extremely verbose but hopefully provides much better hints as to what went wrong. This also adds a comment documenting a workround to gen_ver.pl. This workaround seemed too niche to me to put in INSTALL.md, but maybe it should be there? See discussion in #2115 -------------------------------------------------------------------------------- e240ad9e29 | hellmonk3 | 2021-09-04 00:46:55 -0400 Merge pull request #2110 from crawl/delightfullyreddevilish feat: rework red devils -------------------------------------------------------------------------------- bc928eaac7 | hellmonk3 | 2021-09-04 00:36:00 -0400 feat: add six wizlab maps Expand Crawl's wizlab offerings: -Eringya's Formal Garden (removed in 0.17) returns with a modified layout, nastier archers, and the addition of some of the swamp monsters that have been added between then and now. -Tukima's Studio (also removed in 0.17) returns with a modified layout and several brand-new monster types to complement the dancing weapons: walking tomes, which cast living spells that cast themselves at the player. Thanks to PleasingFungus for the monster concept. -Yara's Duelist Academy features mana vipers, lots of warrior-mages wielding antimagic weapons, and a fearsome semi-unique Head Instructor who likes to dual-wield triple swords. -Borgnjor's Mausoleum features both corporeal and incorporeal undead. Lost souls occasionally appear when monsters are killed, making big fights scarier. A cult of halazid warlocks serve as the final encounter. -Maxwell's Workshop features an array of golems and big, meaty workers who wield big, meaty maces. You'll find some of Maxwell's cast-off equipment here, perhaps including the legendary artifacts themselves. -Alistair's Party Mansion features an array of wizards and their bizarre guests. There's some good consumables to be had if you don't mind crashing the party of the century... and wading through statrotting clouds of degeneration. In addition to the new wizlabs, this commit removes the golem set from the Tomb of Doroklohe (because it was mostly taken by Maxwell), so that map will exclusively place demons or undead now. The inner chamber of Iskenderun's Mystic Tower was also changed slightly; classed purple draconians will show up to make the end a bit more dynamic. With luck, we will soon have new tiles for the added maps and monsters, but until then you can enjoy some truly q u a l i t y art. -------------------------------------------------------------------------------- 0fcadc17a9 | Kate | 2021-09-04 04:14:10 +0100 Capitalise fruit And remove some duplicate entries from the randart name database. -------------------------------------------------------------------------------- 1a7b1a870f | Kate | 2021-09-03 22:28:38 +0100 Remove the book of stone from vaults Missed in the previous commit, oops. -------------------------------------------------------------------------------- db61641bf8 | Kate | 2021-09-03 21:53:38 +0100 Make Bolt of Magma a monster-only spell With the addition of Flame Wave, fire magic now has a very wide range of mid-level attack spells (which fits the school's flavour), but Bolt of Magma sticks out as one of the remaining old-style bolt spells and is much less interesting than the newer spells around it. Even with it removed, fire magic still is still more heavily weighted towards direct attack spells than other elements. Earth magic also now has access to Borgnjor's Vile Clutch at the same spell level, which fills a similar purpose but again has a more interesting design. Lightning Bolt remains as a classic bolt spell which has been more intentionally kept around due to the bouncing behaviour fitting air magic's theme. Some spellbook contents are shuffled to accomodate the change, and the book of Stone is removed to avoid repeating too many spells. -------------------------------------------------------------------------------- 8d994e73c7 | Nicholas Feinberg | 2021-09-03 07:57:29 -0700 Probably fix flame wave crash (spaninq) Off by one. -------------------------------------------------------------------------------- 4d1e82e741 | advil | 2021-09-03 10:25:05 -0400 fix: don't corrupt place_info on &ctrl-r in the vestibule As usual, place_info handling is a complete mess and extremely brittle. This crash could happen because the vestibule is a depth 1 connected branch, so a fixup corrected levels_seen in files.cc before getting to the wizmode handling for this field for this command, which assumed that it was uncorrected. This commit adds a workaround on top of the fixup. The fixup was originally created for a very specific bug but is *also* necessary for `&ctrl-r` in the vestibule, because otherwise the following assert crashes due to the branch depth. Possibly place_info validity handling should be entirely rethought. Resolves #2067 -------------------------------------------------------------------------------- 142c4e0e00 | advil | 2021-09-03 09:30:39 -0400 fix: improve `auto_switch` behavior with two bad weapons This makes the check on the current weapon and the target weapon identical, following a suggestion in #2057. I was initially worried that this would lead to further special cases but I think it's ok. This commit also makes an item definedness check explicit, where before it relied on `is_melee_weapon` to do the right thing. Resolves #2057 -------------------------------------------------------------------------------- 57a78d8006 | advil | 2021-09-03 09:16:10 -0400 docs: better document auto_switch=true This is a clarification in response to #2057, though I won't immediately close that issue. -------------------------------------------------------------------------------- 7265e17f22 | advil | 2021-09-03 08:43:40 -0400 fix: remove incorrect key handling for primary fire Handling for `()Q` was incorrectly inherited from action_cycler. Resolves #2083 -------------------------------------------------------------------------------- b254ac4902 | Nicholas Feinberg | 2021-09-02 21:21:18 -0700 Update the manual For the foxfire -> scorch swap. -------------------------------------------------------------------------------- 4726060ac2 | Kate | 2021-09-03 05:14:22 +0100 Update options_guide -------------------------------------------------------------------------------- c9e9834ff9 | Kate | 2021-09-03 05:11:55 +0100 Remove an extra character from Flame Wave desc -------------------------------------------------------------------------------- 0a9eca1c1b | Nicholas Feinberg | 2021-09-02 17:43:53 -0700 Update FE spell list As part of the mission of increasing variety across games and making backgrounds more of a 'starting kit' than a fully game-defining role, make Flame Wave the new top end of Fire Elementalists' start kit. Together with Scorch, Fire Elementalists should have a more fun and varied early game while still wanting to branch out by the time they reach Lair. -------------------------------------------------------------------------------- f3a705cdda | Nicholas Feinberg | 2021-09-02 17:43:53 -0700 New Spell: Flame Wave (L4 Fire/Conj) Flame Wave is a channeled spell (like Searing Ray) that blasts your surroundings with ever-wider waves of flame. It's intended to be a fun (and spectacular!) capper to the Fire Elementalist start. Fact sheet: - Max damage 10 + pow * 0.4. - Channel costs 1 MP per turn. - Can be channeled twice normally, for a max radius of 3. - Veh range extension allows a third channel at radius 4. - Noise starts at 12 (shout+) and goes up by 2 per turn. - Burns trees (very efficiently!) It would be nice to explain how Veh works in the spell description. -------------------------------------------------------------------------------- 79de503ca0 | Edgar A. Bering IV | 2021-09-02 11:46:17 +0300 fix: adjust hell effect strength The timing reduction in the final balance got hell effects in about the right place in terms of frequency, and contam in the right place for quantity. Drain was checking rN, which players carry a lot of. Instead of turning it up to big number, this commit makes hell effect drain ignore rN. Stat drain was hitting with reasonable frequency, but the XP available made it worked off easily. This commit increases the amount of stat drained. -------------------------------------------------------------------------------- 0ad3c213c0 | hellmonk | 2021-09-01 22:41:33 -0400 feat: rework red devils Instead of kiting (annoying), let red devils impede the player's movement more directly by giving them a melee attack flavor that inflicts barbs if any damage is dealt. They still spawn with polearms, so can use this to their immediate advantage especially in groups. -------------------------------------------------------------------------------- 9e0c098162 | Nicholas Feinberg | 2021-09-01 15:14:13 -0700 Add Scorch to FE and CA As discussed in the previous commit. Also push CA back toward spellcasting stats - you'll have to start with melee for a level or so, but I'd like for it not too be *too* hard to get Scorch castable. -------------------------------------------------------------------------------- 08d601b168 | Nicholas Feinberg | 2021-09-01 15:14:12 -0700 New spell: Scorch (L2 Fire) Scorch is a damage spell that strikes a random enemy within 3 tiles, dealing fire damage to them and (if it beats AC & resists) applying Cerebov's rF- debuff to them for a few turns. Currently, it does 2d5 damage at 0 power, scaling to 2d10 at 50 power. Veh extends range as usual. Scorch is intended to provide additional variety to the Fire Elementalist early game (reducing reliance on Foxfire) and to make Cinder Acolyte feel more distinctive from FE by replacing its Foxfire entirely. -------------------------------------------------------------------------------- 33c4956463 | Edgar A. Bering IV | 2021-09-01 17:41:43 +0300 fix: further tweak the Manifold Assault desc -------------------------------------------------------------------------------- 937acc2988 | Edgar A. Bering IV | 2021-09-01 08:37:18 +0300 fix: clarify Manifold Assault description -------------------------------------------------------------------------------- 6a4b6a32f9 | Edgar A. Bering IV | 2021-09-01 08:32:55 +0300 feat: downgrade Fighters to a buckler The starting kite shield on a Fighter was in a weird place. It had the kind of very long term value that the recent changes to spellcasting backgrounds have moved backgrounds further away from. It was completely reasonable to put some enchant armour scrolls into it and use it throughout the game. Unlike the aux armour of other backgrounds which provide 0-1 AC at the start and 2-4 AC at best, the kite shield starts out around 8SH and without enchants or increased dexterity rises to 13SH with training; it is a significant portion of the user's defenses. On the other hand, with the 0.27 change linearizing shield delay penalty, the shield was a liability for normal sized races. The penalty was sufficiently high that "remove your shield turn 1" advice reappeared and was not unreasonable. This is unfortunate, as a starting kit should ideally be useful at game start. Given the above, lets replace the kite shield with a buckler. The buckler will be worth using on turn 1, but any normal-sized heavy melee fighter will want to find an upgrade... or consider a two-hander or an alternate character archetype, depending on what drops. Races that cannot use a buckler get a kite shield. Currently this leaves the background description and manual intry as is---both simply mention "shield". -------------------------------------------------------------------------------- f8c7cfddd9 | gammafunk | 2021-08-31 22:03:27 -0500 feat: Despoiler loot and monsters in a Lair ending For due_jungle_book, the thematic loot item guarded by the obsidian statue is at a position where one had to step in view of the statue to see the item at all. Additionally the statue is easy to autoexplore into, and the area in which it resides is rather cramped for it to be able to use its summons. This commit encloses the loot item in a clear stone room with a clear door, placing the statue in front. The room is visible from another room usually encountered before the statue area. Hence the player can always see basic information about the loot item before deciding to fight the statue, and the statue itself will likely be seen and autoexcluded before it's reached. An additional bonus is that the loot item can't simply be apported without fighting the statue, since the door must be opened first. Finally, we clean up the terrain surrounding the statue to open up space a little, allowing its summons to work better. -------------------------------------------------------------------------------- 84fbe2c6ea | hellmonk | 2021-08-31 22:44:53 -0400 fix: don't spawn an oklob vault as often -------------------------------------------------------------------------------- 46f4d3c346 | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Change a miniruin subvault for better wand placement -------------------------------------------------------------------------------- b29a9eb848 | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 checkin the whites -------------------------------------------------------------------------------- 5d38da674a | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Two new encompass vaults for Desolation Two new encompass vaults for Desolation: Pilgrimage, in which the three mini-ruin subvaults are laid out linearly across the salt flats, and Temple, which eschews subvaults entirely and scatters loot around the outlines of an ancient crumbling temple. -------------------------------------------------------------------------------- 8f02261bec | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Add a handful of Desolation mini-ruin subvaults -------------------------------------------------------------------------------- c8992b3357 | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 New entry vaults for Desolation Inspired by the famous report "Expert Judgement on Markers to Deter Inadvertent Human Intrusion into the Waste Isolation Pilot Plant", these entry vaults are designed to suggest that the Desolation is not a place of honor and no great deed is commemorated there. Lower weights since they're big. -------------------------------------------------------------------------------- 4e71d33c19 | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Change the statue tiles used in Desolation Statues are renamed to "ruined idols" in Desolation, but the description says they've all had their features removed, while the statues still use the regular dungeon tiles, which have plenty of features. After discussion in the discord, use the crumbling column tiles for now for statues in Desolation. At least they're featureless. -------------------------------------------------------------------------------- 963f628cec | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Rearrange the order of subvaults in Desolation Put the paired intact/wrecked vaults in a separate section from the unpaired singleton vaults. The other arrangement was driving me bonkers. -------------------------------------------------------------------------------- 3674f0abaf | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Fix some subvault misconceptions in Desolation The desolation_ruins_setup function called by all the subvaults in Desolation doesn't need to subst . = , - the main vault can't replace anything in a subvault anyway. Also, subvaults don't need ORIENT statements. -------------------------------------------------------------------------------- e74157ce7a | advil | 2021-08-31 18:21:55 -0400 refactor: remove CMD_EVOKE_WIELDED Until recently, there were only 3 holdouts that used this command, all unrands. Previous commits moved those unrand evocations into abilities in order to have a cleaner, more standardized, UI for them, leaving nothing that uses evoke wielded. Based on past discussion, we are unlikely to add anything that does use it, and item-specific abilities are generally better. As part of this I've removed all the old stuff for triggering reaching weapons via evocations; this was partly dismantled already as part of the introduction of CMD_PRIMARY_ATTACK. For one-key triggering of Olgreb (a common request), there are two recommended solutions after this commit: quiver the ability and use `p`, or just macro the ability like any other. -------------------------------------------------------------------------------- 28a71e5310 | advil | 2021-08-31 18:21:55 -0400 fix: add ability descriptions for dispater/asmodeus Also, tweak the Olgreb description. This commit intentionally leaves the artefact descriptions of these abilities in place (which lets them be obvious while not wielding them). -------------------------------------------------------------------------------- 31e2066950 | advil | 2021-08-31 18:21:55 -0400 refactor: converk staff of olgreb evoke to an ability As with the previous two commits, this lets a much more straightforward version of the power be shown to the player. As part of this, I have simply removed the fail check. This required 5 evo skill to get to 100%, which is trivial; it originates from earlier versions of the staff that could also cast venom bolt. -------------------------------------------------------------------------------- b9327a18ab | advil | 2021-08-31 18:21:54 -0400 refactor: convert staff of dispater evoke to an ability This allows for better transparency for the costs, more code reuse, etc. I have provisionally converted the HP cost to a percentage, which overall should work better for damnation. This is currently set at 10%, and it may be a nerf to many characters at higher HPs. Further adjustment might be required. -------------------------------------------------------------------------------- 3858e25e18 | advil | 2021-08-31 18:21:54 -0400 refactor: Convert Sceptre of Asmodeus evoke to an ability This regularizes the interface to the sceptre, allowing nice things like showing the fail rate, etc. The existing evocations check didn't fit well into the more standardized ability.cc checks, so I've adjusted it (I think this is a buff, but I'm not sure it matters -- anyways, others can feel free to adjust further). -------------------------------------------------------------------------------- b16ebcc8e8 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 feat: don't place shafts in hell The small levels and placement of hatches give a fast enough dive, shafts are an ultra fast forward. We'll permit Fo to shaft in hells and permit shafts in vaults for the hells, so that they can be used as vault "loot". -------------------------------------------------------------------------------- 51d9a1de7a | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 fix: new hell mosnter description tweaks (PleasingFungus) -------------------------------------------------------------------------------- 46c4a727e1 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 feat: update doom howl spawns -------------------------------------------------------------------------------- 4b270e8d09 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 fix: describe stoker movement (dilly) -------------------------------------------------------------------------------- 5fa11ae2f9 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 text: add some newlines (PleasingFungus) -------------------------------------------------------------------------------- 5d3d9a63fa | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 vaults: adjust Tartarus vaults for new monsters Add the new Tar cast to the vault des. Some places shadow demons were replaced with doom hounds, for the summon effect, and others profane servitors for the "shadowy flavour". Most reapers are gone but a few stick around as guests. -------------------------------------------------------------------------------- 4c841b28f7 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 vaults: adjust monsters in Cocytus vaults Some care was needed to make sure there's simulacra around for the wendigo, but placing wendigo bands can take care of that when needed. Otherwise, blizzard demons were replaced by titans or shard shrikes depending on context, and several vaults were 098-ified. -------------------------------------------------------------------------------- 3d3c2c6d84 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust Gehenna vault monsters This adjusts all Gehenna vaults to use the new cast. Fewer changes than the Dis vaults, mostly replacing sun demons with searing wretches and sprinkling in some creeping infernos. -------------------------------------------------------------------------------- 2bde554b36 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: Dis end vault monster set adjustments In line with the Dis changes, remove trash mobs and replace with the new Dis cast. As with the non-end vaults, a few juggernauts sneak in as a guest threat, and the cacodemons in the one grunt ending stick around. Might have been too heavy with caustic shrikes on some of these. -------------------------------------------------------------------------------- f8756136d3 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust non-end Dis vault monsters and cleanup Adjust monster sets of Dis vaults. When possible I tried to stick with or switch to 098. When vault storyline demanded eg. a humanoid or a boss monster one was chosen from the new Dis cast appropriately. Occasionally some vaults desired slightly more variety, and juggernauts get sprinkled in there. I'd considered putting them on the Dis spawn table, but a few vault cameos seems to be better for them. -------------------------------------------------------------------------------- 3a40abb400 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: make hangedman_mysterious_dungeon_monster_house 098 Essentially. The generic undead are preserved (with some branch flavoring so Cocytus wendigo have simulacra to collapse), and the "fodder" placements are replaced with 09. The "boss" is specified to be a top tier threat for the branch. -------------------------------------------------------------------------------- 8b58bad9cc | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new Cocytus spawn table The icy hell, ruled by Antaeus, this monster set has a slightly more cryptonatural feel, keeping with the "newness" of Cocytus in the lore. The monster mix aims to beset the player with iceblasts, cold, and status effects (much worse under -Potion) This places the following monsters in addition to the cross hell threat set. "basic" branch welcome monsters: - simulacra Using the adjusted simulacra list, these simulacra either hit hard, are fast, or mess up player position (often two or more). - freezing wraiths Somewhat on the weak side for hell, a lucky slowing hit goes much further when a player cannot obtain potion help. - frost giants Lower tier colossus, following Antaeus' leadership. "branch flavour" monsters: - titans More of Antaeus' pals. Titans' airstrike is spooky in Coc's mostly open layouts, as is their flight over deep water. - azure jelly Rarer, might be a bit too weak for its place, but a good cold monster with big ol hits. - wendigo To help slower simulacra really nail the player, the wendigo can turn them into 3d43 iceblasts (one time only, destroyingn the simulacrum), in addition to having stunning burst and some strong melee. Wendigo are fragile and cannot fly, however, so they can be managed with care using Cocytus' terrain. - nagrun Earth spirits who were here first and tolerate the new hell that was dug out around them. Petrification is much more threatening if it can't be cancelled, so these earth spirits come with it, plus AF_VULN to help it land. "signature threat" monsters. Equal chance at max depth, otherwise more shrikes - shard shrike Basically TIE fighters with blue lasers. A player favorite. - ice fiend The cold tier 1 demon. -------------------------------------------------------------------------------- 58b44f322d | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new Tartarus spawn table The decaying hell, this monster set is out to bewitch the player and drown them in foul miasma. Unlike other hells, because of the misma quantity no living holiness monsters are added. This places the following monsters in addition to the cross hell threat set. "basic" branch welcome monsters: - spectral things The generic late population is adjusted so that the spectrals that place should be a somewhat serious threat to the player, if they start to swarm. - shadow wraiths Not very hard hitting, but AF_DRAIN_SPEED makes these a thematic mix. - eidola Also not very hard hitting (could they gain dispell undead lol?) but with Tar's new Will/2 their Cause Fear has a chance at landing and constraining player movement. "branch flavour" monsters - profane servitors A monster from "elsewhere" repurposed to service in Tartarus. Some concern about this aura and silence aura being difficult to see in combination in console. They're a nice melee threat and combined with their aura a nice threat multiplier. - bone dragons Big dumb hits. Thwacks. Tramples. - putrid mouths Somewhat similar to ushabti, putrid mouths are a stronger melee threat in addition to the warning cry and miasma breath. They apply poison and stat drain fitting in with Tar's theme. - doom hounds Definitely not spirit wolves. Everyone's favorite "summoner" monsnter. - silent spectres (rarer, flat distribution) These are sprinkled in to fit with Tar theme and provide a unique tactical challenge. Much rarer than regular monsters. "signature threats" - tainted leviathans A C genus monster for tar. With mesmerisation to use the Will/2 branch-wide effect, a miasma ring, silence, and large rocks, these giants are an all-around top tier threat. - tzitzimimeh The branch's tier 1 demon. -------------------------------------------------------------------------------- a5164bd282 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new Dis spawn table The iron city, this uses a mix of new and classic monsters to beset the corroded player with big hits (wham pow), metal splinters, and prevent their escape with fetters and barbs. This places the following monsters in addition to the cross hell threat set. "basic" branch welcome monsters that fall off with depth and aren't used for ood rolls beyond max depth: - ancient champion Iron shot, haste, good hits. Currently they have skeletal warrior bands, perhaps that should change. - war gargoyle Metal splinters and fast, but not tough. - iron dragon Metal splinters and stronger melee than a war gargoyle, tougher as well. Unfortunately they're slow, so currently less frequent. Might be worth making them speed 10. "branch flavour" monsters to fill out the regular threats: - iron golem Buffed iron golems are hard to kill and hit really hard at normal speed, so it is not good to be next to them. That's easy to do because they're slow, but it does mean they might block an escape in the kind of layouts Dis generates. - caustic shrike The pigeons of Dis. Recontextualize a top-tier depths threat as a regular friend in the iron city. Their corrosive attack stacks with the present Dis corrosion for maximum fun! - quicksilver elementals At least one Dis castle places quicksilver dragons (good flavor, but not really strong enough for a Dis threat). These elementals are a cross between a quicksilver ooze, a qsd, and a shard shrike. Quicksilver bolt will remove some corrosion, but do you really want to keep one as a pet? - crystal echidna Iron golems are slow, many other Dis threats are regular speed. To help everyone along these spiny green helpers have throw barbs, along with crystal bolt so they're not defenseless on their own. The cramped layouts of Dis should give them many bolt bouncing opportunities. "signature threat" monsters (becoming equal chance at max ood). - iron giant The classic C, with harpoons and iron shots and now hurling buffed iron golems (which get a swing on the turn they're thrown). - hell sentinel The tier 1 demon of Dis. -------------------------------------------------------------------------------- 1c5eef2bd2 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new Gehenna spawn table The firey hell, this uses new monsters along side classic favorites to beset the player with fire storms, fireballs, and burn away their resistance. This places the following monsters in addition to the cross hell threat set. "basic" branch welcome monsters that fall off with depth and aren't used for ood rolls: - hell hog The classic fast fireballing demon. Their fireballs hit enough to hurt and they swarm, but they aren't so tough. - fire giant Increasing placement of 'C' genus monsters in hell is a lorebuilding exercise. Not as fast as hell hogs, stronger melee. - salamander tyrant The highest tier salamander monster, recontextualized here in hell. Their lava spells work well in Gehenna's lava pool terrain. "branch flavour" monsters that fill out the regular spawns in the mid range and fall off for ood (but not as sharply as the cross-hell set): - balrug Classic demon; subsequent changes to the other hells makes this one of the few non-fiend non-common demons appearing. - searing wretch Resistance stripping melee threat. - stoker (less common) Ranged, maintain range threat. In Gehenna's layouts corners are hard to comeby, and hiding from creeping infernos is a good deal trickier than dodging oods. Setting them off early is a possibility for the player, but comes at a cost. - creeping inferno (less common) Like a lurking horror, but with Fire Storm. "signature threat" monsters that fill out the ood weight. At depth 7 helephants are more common than fiends, and at the depth cap they have equal chances. - hellephant 3d40 bolt of fire (ow!), trample, and blink. Tough but not too tough defenses. A good firey monster for the firey hell. - brimstone fiend Every hell needs a thematic 1 and the brimstone fiends are the fiends for Gehenna. -------------------------------------------------------------------------------- 1c56b440e8 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: define a cross-hell spawn population To unify the hell branches, this defines a population subtable that produces "cross-hell" threats: a flat (falling off in ood range) sprinkling of tormentors and hellions bringing suffering to the damned, plus rare lichen making sundry unholy pacts. Lore note: Lichen, having mastered life and death, are not minions of hell or bound there. They're simply visiting. So we don't want to put a ton in any hell, even Tartarus. -------------------------------------------------------------------------------- cec1ff2907 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: enable a higher ood cap for hells In order to let 098 pick out true nightmares without making each hell 6/7 roll oops all fiends, let's set an ood cap that we can work with. Technically we lose a bit of expressivity at the deepest possible 8 depth, but I don't think that's needed. -------------------------------------------------------------------------------- a084dd16cf | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: revise generic_late_zombie populations (nojaa) The generic_late_zombie population is used for derived undead base classes in areas where the player is expected to be quite strong. This commit adjusts the way depth is handled by the picker so that the population list has its own depth cap (independent of branch depth caps). It also changes the monster selection to focus on derived undead that are either fast or interfere with player movement or both, with a few hard hitters for good measure. -------------------------------------------------------------------------------- e6604a7e06 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: adjust derived undead attack flavours This commit allows spectrals and simulacra to constrict and reach (losing the flavor brand on that attack) and all derived undead to trample. These "physical" attack flavours mess with player positioning in various ways; not including them on the higher tier derived undead made it challenging to use those derived undead as serious threats. -------------------------------------------------------------------------------- 5587a7b593 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, nargun Without cancellation pots, status effects are much more deadly in Cocytus. Nargun are modelled after the Australian mythic stone creatures, and are gargoyle-esque: they hit hard, have big AC, and a threatening spell but weak HP. In this case they bring Petrify to the mix, along with AF_VULN and a big HD to help it land. They are lrdable and treated as icy. -------------------------------------------------------------------------------- a7dcba2b6e | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, wendigo Wendigo are a new Cocytus monster. They're somewhat flimsy and act as threat multipliers, with stunning burst and a new spell seracfall. Seracfall turns a simulacrum in view into a very high power (3d43) iceblast. Cocytus will have plenty of simulacra around as part of the overhaul, but many simulacra are slow. The wendigo "help" the simulacra along in a couple of ways. The targeting also means that a player facing a wendigo plus simulacra will have to manage LOF from several directions as the simulacra advance. -------------------------------------------------------------------------------- 5a7b489cf3 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, tainted leviathan A non-fiend top tier threat for Tartarus. Tainted leviathans come with mesmerise and a cloud ring to pull players into. Oh! And they're giants so they thro rük. -------------------------------------------------------------------------------- 0cc904eb20 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, putrid mouth Putrid mouths are a new Tar monster, meant to be a more substatial (ha) wraith genus monster to fill out the branch flavour set of threats. They are based on Chinese mythology around hungry ghosts and re-use the old hungry ghost tile since it was so cool. As a monster they aren't the toughest of Tar threat, but the mix of miasma, poison, and warning cry should combine with the small levels to prevent a player who mismanaged the encounter from recovering before reenforcements arrive. -------------------------------------------------------------------------------- 6bad965b88 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, crystal echidna Meant as a "support caster" type monster for Dis, crystal echidnas have barbs (to confine the player's movement while slow things catch up) and crystal bolt (to be a bolt-bouncing threat when they're met alone in the cramped rooms of most Dis layouts). Crystal Echidna are nonliving and explode like green crystal for LRD. -------------------------------------------------------------------------------- e42411b9ad | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, quicksilver elemental I considered simply using quicksilver oozes or quicksilver dragons in Dis, as both are reasonably strong late-game threats. However both dragons and oozes are vulnerable to some of the collateral damage done to allies by hell minions. It seemed like a better idea to make a monster in a genus that won't fall so easily to tormennts, since the new Dis list already has its share of living creatures. This monster is something like a cross between a quicksilver dragon and a shard shrike, with batty movement and qs breath, though not as fast as a shrike. Not 100% happy with repeating the shard shrike gimmick, could instead just make quicksilver oozes torment immune. (How does one torment a blob of quicksilver anyway?). -------------------------------------------------------------------------------- 6bbbebb4f9 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: buff iron golems (amcnicky) Iron Golems are slow, and slow monsters are often sad. Dis has iron giants, which can throw them into range, which makes them more exciting. Except they're also not that strong, and attack slowly to boot. To make them a better Dis monster this gives them a big buff to their AC and HP, the idea being that they are avoidable but will block a player's manouverability. To make their obstruction to manouvering even more pointed, they get buffed attack and a second attack, and attack at normal speed. The normal speed attack ensures that (depending on monster list sequencing) they get a good chance to swing at the player after being thrown. Big big big ruk. -------------------------------------------------------------------------------- a2eda6f88b | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, stoker Stokers are a ranged harrassment and positioning threat in Geh. The player can defeat one solo by setting off its own creeping infernos against it, but in a fray this back-line threat should keep the player off balance with wind blasts and inferno-firestorms. -------------------------------------------------------------------------------- a95eead60a | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, searing wretch A hard-hitting melee threat for Gehenna, searing wretches are ghoul genus monsters that stack on fire, sticky flame and strip fire resistance. They are complementary to the other Geh threats, which all have some sort of ranged component, and other than hellephants are a bit flimsy at hell depth. -------------------------------------------------------------------------------- b7fef34776 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, creeping inferno Creeping infernos are a new monster for Gehenna. Operating with lurking horror move rules, creeping infernos unleash a power 120 fire storm at their location upon death. The savvy player will be able to use them to advantage, so we won't place too many, but the player caught off guard will be exploded. -------------------------------------------------------------------------------- 751aad3b66 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust Tartarus vaults for new hell levelgen Fewer encompasses here, large vaults again get ORIENT: centre to keep them from wandering off, stairs adjusted. -------------------------------------------------------------------------------- 8c116a9034 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust Cocytus vaults for new hell levelgen Similar to Dis, several of these vaults are very large and given ORIENT: centre, one is turned into an encompass. Stair placement fixed up. -------------------------------------------------------------------------------- ffef9bb0b2 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adust Gehenna vaults for new hell levelgen -------------------------------------------------------------------------------- 0cff350621 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: add green crystal to Dis While Dis is the Iron hell, it is also notionally earth/metal themed. Moreover elemental iron can crystalize. So let's spice up the wall types a bit. Currently this is accomplished by repurposing serial_glass to place green crystal instead of glass. Other Dis specific crystal vaults welcome. -------------------------------------------------------------------------------- 2e6bbc7fcc | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust Dis vaults for new level generation Several large Dis vaults disconnected the level and were practically encompasses in their own right; they get promoted. Other large vaults are given ORIENT: float or trimmed as need be to get them to play nice with the new small levels. All stair placing vaults have their placements adjusted for single stairs. -------------------------------------------------------------------------------- e5be5493b6 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: revise miscelaneous vaults appearing in hell This commit adjusts vaults that are defined in various files other than the branch specific vault files. Vaults that are too large are removed from hell spawning and appropriate conditionals for stairs are added. Vaults that break connectivity (elevators) are also dropped from the hells spawn lists. -------------------------------------------------------------------------------- 4708905124 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: only place one up and down stair in the hells This changes the level generator to only place one stair in each hell branch, as a complement to the previous change to level generation size. This commit will currenlty break crawl due to the number of vaults that place disconnected stair bubbles in Hell. Follow-up commits will be adjusting hell vaults to account for all level generator changes. -------------------------------------------------------------------------------- 43dec93354 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: add error checking for some dungeon builder lua -------------------------------------------------------------------------------- 903cbe717e | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: shrink Hell subbranches on floors 1-6 This commit converts hells layouts to use the new dgn.builder_bounds() instead of dgn.max_bounds(), adding parameterization on grid size for some procedural values that were previously hard coded. The dive portion of the hells can be exciting, but quickly becomes a slog if the player must make the dive a second or third time, due to how the stairs work. By shrinking the levels we reduce the time a player spends with unfun repetition and increase the time spent in "good dive moments". A subsequent commit will reduce the number of stairs spawned on each level to 1 guaranteed stone stair. -------------------------------------------------------------------------------- 9424aacb20 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: separate builder_bounds and max_bounds This adds two stub functions dgn_builder_x and dgn_builder_y to allow parameterizing the dungeon buillder's driving dimensions. Subsequent commits will use these to shrink intermediate hell levels. The assumption that GXM and GYM are constants is baked in across the layout code, so layouts will be adapted to use the builder_bounds gradually. Layouts switched to use builder_bounds will be tested for support of various builder sizes. -------------------------------------------------------------------------------- 20ce1ca697 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 fix: resolve a todo in zonify mapping -------------------------------------------------------------------------------- bc17ff6ebb | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 refactor: move padded_bounds to a layout library This function is used with the various omnigrid gridding functions to put a bit of padding to allow the grid to expand into the edge of this padding. There were two versions of it, one in layout_city the other in layout_grids; layout_cellular was implicitly using one of them without an explicit include. This moves the function to omnigrid so that we have only one copy. -------------------------------------------------------------------------------- 43d0ba7266 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: shift timed hell effects to do more strategic damage The effects of the hells serve two purposes. One is to spice up encounters with tactical shifts: new monsters, noise, damage; the other is to deal strategic damage. The previous commits added a branch-wide effect to each hell branch to give them a distinct tactical flavour. This commit shifts the timed-effects to do strategic damage to those who would linger: contam, drain, and stat rot. -------------------------------------------------------------------------------- e744962671 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: persistent hell effects: rot tartarus (Lici) The third of four branch-wide hell effects, meant to give each hell a unique tactical experience. In Tartarus, halve half willpower. Ereshkigal has paralysis, and the new Tar monster set will have some will checking monsters. Lets make it harder for the player to simply Will++++ item their way out of these concerns. -------------------------------------------------------------------------------- 6f13a9c4bf | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: persistent hell effects: fill gehenna with acrid smoke The third of four branch-wide hell effects, meant to give each hell a unique tactical experience. In Gehenna, prevent the use of scrolls. -------------------------------------------------------------------------------- 3d7a220799 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: persistent hell effects: freeze cocytus solid The second of four branch-wide hell effects, meant to give each hell a unique tactical experience. In Cocytus, prevent the use of potions. -------------------------------------------------------------------------------- 49807740c2 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: persistent hell effects: rust dis The first of four branch-wide hell effects, meant to give each hell a unique tactical experience. In Dis, apply two stacks of corrosion. -------------------------------------------------------------------------------- 79cbbdc86d | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 refactor: abstract corrosion to a method -------------------------------------------------------------------------------- 21599a725c | Perry Fraser | 2021-08-31 13:00:22 -0700 Have C-glyph altars use temple_god_list() Previously there was a hardcoded list of gods that couldn't generate for C glyphs in dungeons. It turns out this was essentially equivalent to the list already used in temple_god_list(), so this removes that duplication. This also fixes an issue where an altar to Ignis could generate on a few Zot dungeon levels which used random altars. -------------------------------------------------------------------------------- d86dc11844 | Nicholas Feinberg | 2021-08-31 11:53:27 -0700 Bump SCG to L6 (ardl) Cactus giants were a bit stronger than expected, and with the removal of Shadow Creatures, there were no other L6 summons left. -------------------------------------------------------------------------------- 98b9f98406 | Nicholas Feinberg | 2021-08-31 11:50:16 -0700 Fix monster cactus giant display -------------------------------------------------------------------------------- df715e3894 | Perry Fraser | 2021-08-31 08:15:42 -0700 Fix dancing weapon death messages [Committer's notes: - Don't claim that summoned dancing weapons turn to gold on death. - Allow summoned corpseless monsters to create clouds on death, just like other summons. - Fix handling of banished unrand dancing weapons. Closes #2092. ] -------------------------------------------------------------------------------- bc0475efdd | Kate | 2021-08-31 02:52:45 +0100 Prevent cactus spines from working outside LOS -------------------------------------------------------------------------------- bced6e68ee | Nicholas Feinberg | 2021-08-29 19:07:02 -0700 Remove an unused corpse tile Oops! Should fix tests. -------------------------------------------------------------------------------- 8ac975c05d | Nicholas Feinberg | 2021-08-29 17:54:53 -0700 New spell: Summon Cactus Giant (L5 Summoning) Summon Cactus Giant summons a giant cactus warrior. Enemies that hit it in melee take 5d8 AC-reduced spines damage. Oof! The intent is to have another situational/toolbox summoning spell: it's not particularly great against "casters" or "ranged" enemies, but fun against melee foes, particularly ones that move fast rather than hitting hard. To differentiate from Guardian Golem, which has a vaguely similar role, it's a few levels high (L5 1school vs L3 2school). The giants also have giant spiked clubs, mainly for comedy value. They're intended to not do that much against with their attack (as opposed to their spines), so their attacks take 3 turns and their base damage is very low. Giant stats: 1 AC, 2 EV, roughly (27 + spellpower) HP, though it's randomized like other monsters'. Standardish summon duration, like call canine familiar. The spell appears in the Book of Dryads (renamed to Book of the Wilderness) and a new Book of Scorching, which also gets Foxfire and Fireball. (I actually named this book before I came up with the idea for Scorch, but you better bet that's going in there if it lands.) -------------------------------------------------------------------------------- 620d9153ef | Kate | 2021-08-30 00:07:12 +0100 Remove some broken speech lines _fruit_name_ is a key in the randart database and can't be used in the speech database. -------------------------------------------------------------------------------- f6d37e6e1d | Kate | 2021-08-29 22:31:04 +0100 Disable Okawaru Duel in Sprint Instead of crashing, disable the ability in Sprint, since it's not supposed to be possible to leave the single D floor by any means (and the Abyss is also disabled). While it'd be possible to special-case the Arena and enable the branch, it seems likely to break Sprint balance even more than usuali (especially in maps like linesprint and arenasprint, for example). -------------------------------------------------------------------------------- e87a16407d | Nicholas Feinberg | 2021-08-29 08:49:46 -0700 Blame Ignis for fire champs (gammafunk) No idea if this works correctly for cikiller, tbh! -------------------------------------------------------------------------------- 28825b98b6 | Edgar A. Bering IV | 2021-08-29 10:25:10 +0300 docs: first changelog update for 0.28-a0 -------------------------------------------------------------------------------- 2a6f7409c1 | Edgar A. Bering IV | 2021-08-29 08:40:47 +0300 docs: update credits -------------------------------------------------------------------------------- 9e858e973b | Nicholas Feinberg | 2021-08-28 20:09:21 -0700 De-damn missed bolts (ardl) oops -------------------------------------------------------------------------------- 7e9a150488 | Nicholas Feinberg | 2021-08-28 19:41:38 -0700 Add missing Cinder Acolyte icon (Really, swap in the Delver candle, since it fits, and give Delver a lantern instead.) -------------------------------------------------------------------------------- 80eddfa388 | Kate | 2021-08-29 01:18:52 +0100 Fix interactions between noise, fake noise and silence (#12293) "Fake" noise (primarily created by alarm traps and the Orb) was intended to ignore silence and still alert monsters, but didn't actually work since no noise (including fake noise) was ever allowed to propagate through any silenced squares. Instead, allow all noise to propagate through silence, but only allow fake noise to actually originate within silence and to alert monsters in a silenced area. This also fixes problematic behaviour of the Demonspawn silence aura mutation, where the aura blocked all noise from the player from propagating outwards. -------------------------------------------------------------------------------- bb949333c4 | Kate | 2021-08-28 23:10:01 +0100 Give Haunt a summon cap of 8 As a high-level summon it doesn't need as strong a limitation as most of the earlier summons, but it previously had no cap at all - give it a high summon cap to at least make it a little less practical to haunt multiple different targets at once. -------------------------------------------------------------------------------- 1a59d63638 | Kate | 2021-08-28 23:10:01 +0100 Make Shadow Creatures a monster-only spell It doesn't work well with the reduced player summon caps, since a big part of its functionality is being able to create monster bands, and the interaction between bands and the summon cap was already fairly messy. Being able to summon rare branch-specific monsters and big monster bands is a fun effect, but works much better on the already-existent scroll of summoning, which avoids the problems of summon caps and is balanced by being a consumable. -------------------------------------------------------------------------------- db2750068a | Kate | 2021-08-28 23:10:01 +0100 Remove the XP penalty from summon kills With the caps on most summon spells substantially reduced, it should now be reasonable to remove the 50% XP penalty on kills made entirely by allies. Other temporary allies also have the penalty removed, as these show up much less often (for example, charmed allies and summons from items and god abilities) so should have a fairly minimal effect. Undead allies also have the penalty removed, with plans to further adjust corpse-using spells in the future. Currently permanent allies from gods (specifically Beogh and Yredelemnul) are unchanged - these require more substantial reworks to their design, with the plan being to hopefully then fully remove the XP penalty from them when their respective redesigns are worked on. -------------------------------------------------------------------------------- 635202c219 | Kate | 2021-08-28 23:10:01 +0100 Give monsters separate summon caps to players Making summon caps for monsters match the reduced player caps unintentionally weakens a small set of monster summoners whose spells are coincidentally also player-castable. Instead let monsters retain the old caps, and document these in the spell description when examining a monster. -------------------------------------------------------------------------------- af93940d1b | Kate | 2021-08-28 23:10:01 +0100 Reduce most summon spell caps to 1 Summoning magic has long had the downside of kills by allies granting only 50% XP, which works fine in terms of balance due to how hugely powerful summoned allies are, but is very inelegant as well as just feeling bad to many players. The main problem caused by summon spells is how easy it is to quickly and repeatably create a very large number of allies, so to try and balance this better and allow removal of the XP penalty, greatly reduce the summon caps for player-castable summoning spells. Almost all spells are capped at 1 summon, with a few exceptions for spells that wouldn't function with such a low cap (such as Summon Small Mammal where the individual allies are very weak), for a few high-level spells (Summon Hydra and Monstrous Menagerie) which are instead capped at 2, and for the very highest level spells (such as Summon Horrible Things and Dragon's Call) where the high level of investment required can justify their strength. Being able to create allies on demand is still fundamentally an extremely powerful ability so this is very unlikely to cause problems for summon- focused characters - it'll just be required to either hybridise more or to use a wider variety of summon spells. -------------------------------------------------------------------------------- 99b01970c5 | gammafunk | 2021-08-28 16:46:57 -0500 fix: Make a function static -------------------------------------------------------------------------------- ae8ea5ec39 | Edgar A. Bering IV | 2021-08-28 23:15:54 +0300 feat: adjust Mlioglotl's spawn range Mlio's spawn range was picked to cover holes in the distribution of uniques. Unfortunately, an S-branch threat simply isn't all that spooky by Vaults or Depths. Additionally, in Abyss Mlio's one weird trick doesn't do anything. So let's place Mlio in the S branches, corrupting an otherwise peaceful runic experience, and very rarely in the abyssal lair end as the source of the corruption. -------------------------------------------------------------------------------- 832ee520b4 | Edgar A. Bering IV | 2021-08-28 23:11:37 +0300 fix: inscribe the obsidian axe (rayg00n) -------------------------------------------------------------------------------- 47ca004b5c | Nicholas Feinberg | 2021-08-28 12:07:32 -0700 Ban fire championing priests (Lightli) Another god already took that one! -------------------------------------------------------------------------------- 0e18a103e6 | Nicholas Feinberg | 2021-08-28 12:02:53 -0700 Cleanup beogh_follower_convert -------------------------------------------------------------------------------- 1796491f69 | Nicholas Feinberg | 2021-08-28 12:02:53 -0700 Ban fire champion conversions (Lightli) Another god already grabbed that orc! You can't have them! -------------------------------------------------------------------------------- 5b1f6a4db3 | Nicholas Feinberg | 2021-08-28 12:02:53 -0700 Fix fire champion wizmode name -------------------------------------------------------------------------------- 6d487c6445 | Kate | 2021-08-28 19:20:20 +0100 Reduce Lesser Beckoning's power cap As a level 3 spell it's not especially appropriate for it to scale all the way up to 200 power. Instead cap it at 100, with the range scaling up to 5 instead of 7. -------------------------------------------------------------------------------- e22f211cc6 | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis: ability cleanup Swap Foxfire Swarm and Sea of Fire, since foxfires are more powerful in practice. Make all abilities significantly cheaper. Add spacing to the enums. -------------------------------------------------------------------------------- c0270e7ab8 | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis: monster dialogue -------------------------------------------------------------------------------- 3a68cb0a86 | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis: zealot start Gnoll and human should do well with the flexibility, hill orc likes the fire, and mummy likes the rF, ha. -------------------------------------------------------------------------------- 7cb2ebde44 | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis wrath: Fire Champion Chooses the toughest monster in LOS and gives it increased move speed and AF_FIRE permanently. Lots of conditions to try to choose only an interesting monster to fight, not a rat or whatever. Dare you risk the wrath... of the super fire yak? -------------------------------------------------------------------------------- d1c9835b8b | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis wrath: shaft -------------------------------------------------------------------------------- c171122a48 | Nicholas Feinberg | 2021-08-28 10:50:07 -0700 Ignis wrath: fire elementals -------------------------------------------------------------------------------- 8762c4751e | Nicholas Feinberg | 2021-08-28 10:50:03 -0700 Ignis: add rF=0 to god wrath And tweak duration and messaging. -------------------------------------------------------------------------------- b194a03854 | Nicholas Feinberg | 2021-08-28 10:47:29 -0700 Ignis: wrath description -------------------------------------------------------------------------------- 8c10d7e454 | Nicholas Feinberg | 2021-08-28 10:47:29 -0700 Ignis: ignore amulets of faith And refactor the relevant code in the process. It might be nice to care about "faith (getting discounts on abilities), but maybe there are weird incentives..? Not handling it right now, anyway. -------------------------------------------------------------------------------- dc0d7ab00c | Nicholas Feinberg | 2021-08-28 10:47:19 -0700 Ignis: die After abandoment and mollification, Ignis dies. RIP. -------------------------------------------------------------------------------- 24c43e5e87 | Nicholas Feinberg | 2021-08-28 10:46:20 -0700 Ignis: Rising Flame ability -------------------------------------------------------------------------------- 44ce977461 | Nicholas Feinberg | 2021-08-28 10:46:20 -0700 Ignis: Sea of Fire ability -------------------------------------------------------------------------------- 8782af215f | Nicholas Feinberg | 2021-08-28 10:46:20 -0700 Ignis: Foxfire Swarm ability -------------------------------------------------------------------------------- 68b9825e2d | Nicholas Feinberg | 2021-08-28 10:46:14 -0700 Ignis: Add rF passive -------------------------------------------------------------------------------- 61f1a7678b | Nicholas Feinberg | 2021-08-28 10:46:11 -0700 Ignis: initial implementation A god specifically designed for use as a zealot start. What if your 'starting kit' was a god that got used up, burned out, and pushed you to risk its (weak) wrath? -------------------------------------------------------------------------------- f7720a2501 | Nicholas Feinberg | 2021-08-28 09:09:04 -0700 Fix evolution The last implementation of it required you to be at the next XL to evolve... which was impossible. When you did reach the next XL, you'd need to reach the one after that to evolve, and so on. Instead, require one XL worth of XP for each evolution. -------------------------------------------------------------------------------- 81c34554c2 | Matthew Daley | 2021-08-28 17:43:59 +0300 feat: Show turn counts and real game times in lobby This lets spectators find potentially interesting games to view, i.e. from a speedrunning perspective. webserver/process_handler.py: * Treat the turn count and duration (real game time) as "interesting info" in the wherefile. webserver/static/scripts/client.js: * Show the new turn count and duration fields. Keep the columns hidden until we see at least one game with the new fields, for nicer backwards compatibility. * While at it, rationalise the units shown for idle times ("min" -> "m", and drop the spaces). webserver/static/style.css, webserver/templates/client.html: * Add new fields, defaulting to be hidden until changed by client.js. -------------------------------------------------------------------------------- 4b70cb3502 | Edgar A. Bering IV | 2021-08-28 17:36:23 +0300 docs: update debian package name for DejaVu (Cebolla) Closes #2094 -------------------------------------------------------------------------------- cd7d0065d9 | Aliscans | 2021-08-28 17:30:15 +0300 Change the spelling of some words to Australian English. Change a few places where words were spelt with -eling at the end and where this is not a correct spelling according to https://www.australian-dictionary.com.au/wordcheck/. This only changes things in places where the spellings may be displayed to the user. I include the documentation in this. I haven't changed the changelog, or any of the contrib stuff. This changes: channeling -> channelling dueling -> duelling groveling -> grovelling quarreling -> quarrelling raveling -> ravelling traveling -> travelling tunneling -> tunnelling Closes #2093 -------------------------------------------------------------------------------- 0b7dbbd7ef | Edgar A. Bering IV | 2021-08-28 17:20:41 +0300 fix: a crash bug in clua.target_desc (mgdelmonte) Closes #2090. -------------------------------------------------------------------------------- f02e23bfe7 | Aliscans | 2021-08-28 17:14:03 +0300 Show gnolls how many levels they need to reach a skill target Show gnolls how many levels they need to reach min delay / no shield penalty for an item. The game already told other species how much experience they needed to remove the penalty for a shield, or reach the minimum attack delay for a weapon. This change extends this to gnolls. It doesn't enable gnolls to set a target as they cannot vary how much experience they put into a skill. [ Committer's note: Closes #2085. Refactored lightly in action selection to deduplicate a condition. ] -------------------------------------------------------------------------------- 3f656e82c2 | Nicholas Feinberg | 2021-08-27 14:50:10 -0700 Reinforce transparent stone tiles To make them hopefully look a bit tougher and more distinct from transparent rock. -------------------------------------------------------------------------------- 1c0f7aac2b | Nicholas Feinberg | 2021-08-27 11:45:54 -0700 Fix Dj spell icons on local tiles Closes #2091 Closes #2095 -------------------------------------------------------------------------------- 36ea832cf1 | John Stahara | 2021-08-27 11:40:58 -0700 Don't ever consider books evil Unfortunate from a flavour perspective, but in gameplay terms it's never detrimental to read a book. This allows autopickup to read books, even if your current god forbids you from casting the spells contained within. It isn't the knowledge that's harmful, after all, but how you use it! -------------------------------------------------------------------------------- 048bc9fd10 | Kate | 2021-08-27 01:47:48 +0100 Remove unused handling for self-casting Tukima's Dance -------------------------------------------------------------------------------- 1e3a1f7914 | advil | 2021-08-26 20:29:42 -0400 fix: prevent bad array access for describing unid'd staves Also add a bunch of other checks around this particular crash; the basic problem here was that SK_NONE is greater than NUM_SKILLS and a lot of code that has skill-related arrays doesn't check bounds and stops at NUM_SKILLS. The specific crash was because `staff_skill` returns SK_NONE in cases where it can't find a matching skill, which happens when a staff is unid'd. Because the bug depended on what was in adjacent memory, the crash was somewhat variable. -------------------------------------------------------------------------------- 17d1ee0984 | advil | 2021-08-26 18:35:18 -0400 fix: transparent tags for some vaults It's better to mark vaults transparent than not, because that allows the builder to check for teleport closets itself, and also allows the placement script to more easily check that the intention indicated by a tag matches with what happens when the vault places. This commit has a batch of fixes for vaults that automated testing indicates should be marked transparent. This stops in a somewhat arbitrary place as I was working on this several months ago and haven't managed to get back to it, but eventually this should be checked for all vaults. This commit also includes a few teleport closet fixes for vaults that didn't immediately show up as being marked transparent. -------------------------------------------------------------------------------- 6aaddb815b | advil | 2021-08-26 18:35:18 -0400 feat: script options for checking vault opacity This new set of options to the placement checker script is designed to find vaults that are not marked as transparent but probably should be. To use this, make sure to test with enough iterations so that randomization can play out. It's actually also somewhat useful for finding vaults that aren't marked as transparent and have a teleport island, when going through vaults one by one. -------------------------------------------------------------------------------- c0b50483a2 | wheals | 2021-08-26 21:43:09 +0300 Interrupt explore by default when a shopping target is reached (perryprog) -------------------------------------------------------------------------------- a0e16d178b | wheals | 2021-08-26 21:43:07 +0300 Fix explore being interrupted by autopickupable items Caused by 14faa60; check_for_interesting_features uses the stash to determine whether to stop, but it was being called without actually updating the stash. -------------------------------------------------------------------------------- f6564f113a | Nicholas Feinberg | 2021-08-26 07:55:33 -0700 Remove riposte from long blades It was intended to create strategic variance by encouraging characters with more EV to use long blades and characters with less EV to use other weapon types. In practice, it just created more complexity without corresponding interesting decisions for players. It'd be possible to simplify into a damage bonus from EV (or Dodging, or Dex), which would accomplish the original design goal... but it's not obvious that said goal would produce good gameplay even if it worked. It's quite difficult to find alternative weapon gimmicks. Wu Jian has taken up much of the rest of the design space, and other common suggestions, e.g. adding innate SH to lbl, just add more numbers & problems to the game without contributing any real decisions. Correspondingly, long blades are mostly returned to their old stats from before 4dea7376dac , with some tweaks from ba988d45092 kept. Fencer's Gloves still have riposte until/unless we decide otherwise. -------------------------------------------------------------------------------- 8de209e91f | Nicholas Feinberg | 2021-08-25 18:59:24 -0700 Fix monster slime wall damage -------------------------------------------------------------------------------- 644a552097 | Nicholas Feinberg | 2021-08-25 18:49:31 -0700 Further spriggan druid desc fixes (dilly) -------------------------------------------------------------------------------- c0dc8c719c | Nicholas Feinberg | 2021-08-25 18:29:27 -0700 Remove more acid splash damage To simplify acid damage and make it more visible in monster descriptions, make acid spells deal all of their damage in the initial attack, rather than following up with some in a separate 'acid splash'. Since this acid splash did 2d4 to monsters and 4d5 to players, and I'm using the latter values for monster acid damage, this is a buff for allied ally damage. To compensate, I've lowered Fedhas oklob fire speed by 25%, roughly the complement of the damage increase. Other sources of allied monster acid damage, such as ?summoned yellow draconians or non-summoned oklobs under Fedhas, are still somewhat buffed, but that seems like a small change with few consequences. -------------------------------------------------------------------------------- f4e2d62f27 | Nicholas Feinberg | 2021-08-25 18:18:45 -0700 Split up acid_splash and corrosion -------------------------------------------------------------------------------- 1c58e7f47f | Nicholas Feinberg | 2021-08-25 18:04:40 -0700 Simplify acid cloud damage -------------------------------------------------------------------------------- 1afa1a9824 | Nicholas Feinberg | 2021-08-25 18:04:20 -0700 Remove unused splash_with_acid params -------------------------------------------------------------------------------- e619aef00b | Nicholas Feinberg | 2021-08-25 18:00:25 -0700 Simplify acid wall splashes -------------------------------------------------------------------------------- 1ef7cba1b3 | Nicholas Feinberg | 2021-08-25 17:27:54 -0700 Clarify sp druid death effect (dilly) It wasn't mentioned in the monster description before. -------------------------------------------------------------------------------- 79ebb2a17b | Kate | 2021-08-26 00:39:03 +0100 Add AoE resistible spells to the default force_targeter These targeters are useful for indicating affected monsters and their chances to resist AoE spells, but are normally only accessible through the quiver. Instead add various untargeted AoE resistible spells to the default list of spells where the targeter is always displayed. -------------------------------------------------------------------------------- 9004c80361 | Nicholas Feinberg | 2021-08-25 12:49:15 -0700 Rename Corrupt Locale -> Corrupt (gammafunk) Nothing to really disambiguate against and much more flavourful. -------------------------------------------------------------------------------- 46a7db7966 | Kate | 2021-08-25 18:52:34 +0100 Don't let Ghostly Sacrifice target projectiles (causative) Projectiles are always considered as "aligned" with other actors (since they never make actual direct attacks?), so orbs of destruction fired by anyone were considered valid targets for monster Ghostly Sacrifice. -------------------------------------------------------------------------------- b8bfbab023 | Kate | 2021-08-25 00:13:55 +0100 Shuffle squares for monster Upheaval animation As with player Upheaval, instead of always displaying them in the same order. -------------------------------------------------------------------------------- cf53092a1b | Kate | 2021-08-25 00:01:29 +0100 Remove some dead Upheaval code Since very shortly after the god was implemented, the code to have Upheaval occasionally destroy walls hasn't actually functioned. Also simplify monster Upheaval's implementation - it iterated over radius 2 but then only ever affected squares in radius 1, so make the code reflect that properly. -------------------------------------------------------------------------------- 639a1a48b9 | Kate | 2021-08-24 04:21:53 +0100 Don't crash when casting an uncapped summon Oops. -------------------------------------------------------------------------------- fa261e29c3 | Kate | 2021-08-24 03:42:48 +0100 Don't try to reroll Shadow Creature spell sets Since no monsters have variable spell sets any more. -------------------------------------------------------------------------------- 01758ec4b5 | Kate | 2021-08-24 03:21:47 +0100 Remove variable timeouts from capped summons Summon spells all had custom timers on how long a summon would remain after hitting the summon cap, but they almost all expired after 5-15 aut (with the only exceptions being Summon Horrible Things, and Summon Dragon, which expired after 40 aut). Instead of having a near-meaningless distinction here, make all capped summons expire after 10 aut. -------------------------------------------------------------------------------- 8580c7503b | Kate | 2021-08-24 03:21:34 +0100 Remove some obsolete summon cap handling Since Monstrous Menagerie no longer creates bands, it doesn't need special handling around summon caps. -------------------------------------------------------------------------------- fbb0926a3a | Kate | 2021-08-23 22:41:23 +0100 Use correct pronouns for monster targeting descriptions -------------------------------------------------------------------------------- 8e8b57cc88 | Kate | 2021-08-23 22:37:46 +0100 Improve skill descriptions for god-related skills Instead of adding some details for Trog only, include information about Invocations usage for all gods, as well as describing any god-hated skills (which is still only Trog in that case, but now properly extends the information to skills other than Spellcasting). -------------------------------------------------------------------------------- 68911e0c57 | advil | 2021-08-22 15:45:15 -0400 refactor: handle self-targeting checks better in beam.cc Xom's chessboard fakes smite targeting for a variety of effects by just setting the beam source to a target monster's position. This leads to some conflation of real self-targeting and fake smite-targeting in a bunch of subtle corner cases, and also led to 12637. Rather then handle this on case-by-case basis as in 395adb26f73b for poly and a708605c5b for teleport, this commit restores the general check from pre-395adb26f73 but makes it more restrictive. It also sets the agent for xom's chessboard actions (as the player, tbc) in the course of this. This commit should also fix some related weirdness with wrath that hasn't yet come up. -------------------------------------------------------------------------------- 79c9209bdd | Kate | 2021-08-22 20:17:53 +0100 Simplify some rain cloud behaviour Don't make the chance of rain clouds creating water depend on how much water or lava is adjacent to them. -------------------------------------------------------------------------------- 9cc4ca73b0 | Kate | 2021-08-22 20:17:39 +0100 Make the robe of Clouds' thunder passive So as to continue moving away from activated abilities on equipment (as with other unrands such as the cloak of the Thief and ratskin cloak), give the robe of Clouds a chance of creating a storm cloud on enemies within radius 2 each turn. Also mention its cloud immunity in the description. -------------------------------------------------------------------------------- 5c1c4949f7 | Kate | 2021-08-22 18:12:03 +0100 Fix spacing -------------------------------------------------------------------------------- 5d50cf8172 | Kate | 2021-08-22 18:11:36 +0100 Remove some obsolete ability code And an outdated comment. -------------------------------------------------------------------------------- c3c367e0a5 | Edgar A. Bering IV | 2021-08-22 16:38:42 +0300 feat: corrupt trees into demonic trees For Mliogotl and player corruption, turn (permanently) trees corrupted into demonic trees. This is technically not a "flavour" effect because of the difference in how they burn, but it's close enough and ultra flavourful. -------------------------------------------------------------------------------- b8ca4b6547 | Kate | 2021-08-22 02:59:18 +0100 Adjust some stat zero effects Replace 0 strength's regeneration reduction with -Regen in monster LOS (the same as the mutation), to give it an effect in combat without making resting take excessive time. Also replace 0 intelligence's 4/5 chance for scroll-reading to fail with -Scroll (since it no longer needs to be possible to read remove curse scrolls to unequip cursed -Int gear). This whole mechanic could probably be simplified further since it's such a rare occurence. -------------------------------------------------------------------------------- dd10bd25a4 | Kate | 2021-08-22 02:51:30 +0100 Add a description for the -Regen status light -------------------------------------------------------------------------------- b1a13b149e | Kate | 2021-08-22 01:15:53 +0100 Rework Sap Magic It was very overcomplicated for such a rare effect, and its implementation of applying multiple levels of spell failure penalty required the player to repeatedly check their spell success rates between each cast. Instead of the scaling penalty, make casting spells under Sap Magic always apply a short duration -Cast. (This also makes its effect on players more similar to its effect on monsters of applying antimagic - it'd probably be feasible to make the effects match and implement -Cast for monsters but this doesn't seem worth the effort.) Sap Magic also had a confusing 3/10 chance to have no effect when cast, despite being otherwise irresistible - just remove this failure chance entirely, since the spell already has a fairly low cast rate. -------------------------------------------------------------------------------- 086cc6695f | Nicholas Feinberg | 2021-08-21 14:58:14 -0700 Update Attr status description. -------------------------------------------------------------------------------- 7ea6ab310f | Nicholas Feinberg | 2021-08-21 14:56:42 -0700 Fix a 7-year-old typo oops -------------------------------------------------------------------------------- d9515000ea | Edgar A. Bering IV | 2021-08-21 20:00:48 +0300 fix: silence a compiler warning -------------------------------------------------------------------------------- 237fc358d9 | mgdelmonte | 2021-08-21 19:54:05 +0300 feat: lua access to monster targeting descriptions This commit adds target_desc, target_weapon, target_spell, and target_throw functions to the Lua monster_info object. target_desc returns the targeting description of the monster. The other function returns the descriptions shown if you target a monster with your weapon, a spell, or a thrown item. [ Committer's note: Closes #1922. Rebased and cleaned up commit history. Made the spell target_desc pick up all of the possible fancy addl descs and be future proof for them, as well as crash robust for spells that lack a hitfunc. ] -------------------------------------------------------------------------------- b260e8e558 | Edgar A. Bering IV | 2021-08-21 17:45:34 +0300 fix: Mlio spell logic fixes Move all corrupt locale casting to use the spell_logic structures. Clean up the code to use const refs instead of passing by value. Properly handle a friendly Mlio. -------------------------------------------------------------------------------- b12d812e02 | amcnicky | 2021-08-21 16:07:10 +0300 feat: Mlioglotl, an Abyss themed unique Mlioglotl is a mid game unique with the power to (temporarily) corrupt levels, spawning in Swamp, Vaults, Depths, and Abyss:2 onward. Mlio's corruption produces abyssal summons drawn from the full spawn table; a Swamp-depth character might have to run depending on the roll. The gameplay feel is to force the player to either avoid or swiftly kill before the summons and terrain get out of control. [ Committer's notes: buffed the damage, defenses, and casting frequencies so that Mlio hits appropriately hard for his locales, expanded the spawn range to include V:$ and U:4-5. Gave corruption guaranteed summons (and a roll), and allowed it to roll monsters from the full abyss table. Mlio might pull chaff to his aid, or he might get a hell sentinel and a bone dragon. There will be a lot of variability in the nature of encounters, but this is part of the design vision. The summon duration is shorter, to allow escapes. Simplified and refactored the monster version of corrupt, it doesn't need to be a complete mirror of the player mechanics. Especially don't recolour outside of Mlio's immediate locale. The temp terrain is placed for a shorter duration, so that a long encounter will get some "abyssal churn" feel. Fixed whitespace, cleared unneeded XXX comments other code clean-up. Moved Mlio to the appropriate place in Mon-data and used brown for the console colour so that glyphs don't overlap. Closes #2058 ] -------------------------------------------------------------------------------- 76b539d98b | Nicolae Carpathia | 2021-08-20 11:19:33 -0400 Rearrange existing quotes and add new ones Scroll of tele quote (ADMIN) moved to Swiftness, at PF's suggestion. Existing scroll of fear quote moved to /dev/null, it's not even by Plato, and replaced with old eidolon quote. Add new quotes, featuring T.S. Eliot, Homer, Lovecraft, Pablo Neruda, Shakespeare, Lord Byron, Nine Inch Nails, and more. -------------------------------------------------------------------------------- 1bb7f9241b | Kate | 2021-08-20 15:35:27 +0100 Tweak duel speech weighting So that adding new speech lines doesn't affect their chance to speak. -------------------------------------------------------------------------------- 0f8ce75afc | Kate | 2021-08-20 15:35:27 +0100 Fix spelling and some incorrect speech keys -------------------------------------------------------------------------------- 2b4a79830d | Edgar A. Bering IV | 2021-08-20 17:11:55 +0300 feat: recommend brigand over hunter for Ko (dilly) Recommendations are supposed to be thematic and flavourful as well as suited to the species. Kobolds have AM as a "ranged" recommend, and there's literally a Kobold Brigand monster. What could be more thematic than to be one yourself! Closes #2038 -------------------------------------------------------------------------------- ad6161974e | RojjaCebolla | 2021-08-20 16:57:14 +0300 Add a few more _anger_possessive_ strings -------------------------------------------------------------------------------- c0b1434407 | RojjaCebolla | 2021-08-20 16:56:23 +0300 Add pennants for duel spectators (text string) -------------------------------------------------------------------------------- 8eabd40a87 | RojjaCebolla | 2021-08-20 16:56:23 +0300 Add a couple adjective strings -------------------------------------------------------------------------------- dc40aaacc9 | RojjaCebolla | 2021-08-20 16:56:23 +0300 Add a few more actions for Okawaru Duel spectators -------------------------------------------------------------------------------- 0da4227f7a | RojjaCebolla | 2021-08-20 16:56:23 +0300 Re-add fruit names to the string generators This brings back some of the fruits of 1eb5282a -------------------------------------------------------------------------------- 8e425c6592 | Edgar A. Bering IV | 2021-08-20 13:44:03 +0300 doc: changelog for 0.27.1 main and debian -------------------------------------------------------------------------------- cbf37d0371 | robertxgray | 2021-08-20 12:34:40 +0300 Vampires are not (pure) lifeless undead This cleans up the following undesired effects: - Rage and lignification potions are tagged as useless. - Wanderers can't receive such potions. - Poison ring tagged as useless while bloddless and other poison related side effects. - Kikubaaqudgha does not grant Sublimation of Blood. [ Committer's note: Closes #2055. Adjusted commit message. Tweaked a few other vampire hacks in spl-util.cc. ] -------------------------------------------------------------------------------- b7ea06bb7e | Edgar A. Bering IV | 2021-08-20 12:21:03 +0300 Revert "Don't consider rings of rPois useless for bloodless vampires" This reverts commit e31878e1fe37459b33a9e04917198de829909ca1. A different solution will be commited subsequently. -------------------------------------------------------------------------------- a7b0c1cb7f | Edgar A. Bering IV | 2021-08-20 12:19:53 +0300 doc: update CREDITS -------------------------------------------------------------------------------- 50b444eb91 | Zhang Kai | 2021-08-20 12:17:55 +0300 Update branches.txt Add translation. 增添翻译。 [ Committer's note: Closes #2063. Fixed whitespace, removed incorrectly placed credit line. Corresponding with the PR author on appropriate CREDITS entry. ] -------------------------------------------------------------------------------- b0f16cbe65 | John Stahara | 2021-08-20 12:14:55 +0300 indent fix -------------------------------------------------------------------------------- 080cfb6e2c | John Stahara | 2021-08-20 12:14:55 +0300 "Okay, then" on saying 'n' to warn_hatches prompts -------------------------------------------------------------------------------- 14faa605fd | Aliscans | 2021-08-20 12:01:39 +0300 Check for monsters, objects & features as soon as you move. (#2041) Check for things after the player moves, rather than waiting for the start of the next turn. Improve the accuracy of a comment in check_for_interesting_features(). Co-authored-by: Aliscans -------------------------------------------------------------------------------- ea8a313d67 | kippig | 2021-08-20 11:51:28 +0300 vaults: edit tgw_trog vault to avoid rat spawns late Ran into some rats in depths and it felt bad. This change removes them and makes it a bit more dangerous. [ Committer's note: Closes #2050. ] -------------------------------------------------------------------------------- c2c9e32840 | Nicholas Feinberg | 2021-08-19 20:21:31 -0700 Don't recalculate MP when Evo is trained They're no longer connected! -------------------------------------------------------------------------------- 3091681fa3 | Nicholas Feinberg | 2021-08-19 19:57:26 -0700 Remove Stairs (The card.) Partially implemented in 30824b7084af3c2dce35d as a debugging tool for the Xom stair-moving effect and left around ever since. -------------------------------------------------------------------------------- 655a12affb | Nicholas Feinberg | 2021-08-19 19:34:39 -0700 Always show all cards in ?/ Since there are few enough to show, these days. -------------------------------------------------------------------------------- f40de95187 | advil | 2021-08-19 16:56:24 -0400 fix: adjust buggy rest delay check Two changes: * tweak the base delay up, recalibrated by ogre healing rather than troll healing. (Turns out regen matters!) * account for collapse, which gives a 4x multiplier on time to full heal, and so collapsed characters with lots of hp would hit the old delay without too much trouble. -------------------------------------------------------------------------------- 2406090169 | advil | 2021-08-19 16:56:24 -0400 fix: accept numpad enter keycode for menu "enter" I'm not sure how reliably this keycode gets used, but it sometimes can be, so accept it in menus. -------------------------------------------------------------------------------- 214da3ba67 | Kate | 2021-08-19 20:47:49 +0100 Fix some invalid vault syntax Just place a fixed amount of a few items that were trying (and failing) to create a randomised stack size. -------------------------------------------------------------------------------- d305098ac3 | Kate | 2021-08-19 20:47:06 +0100 Add Okawaru to tgw_lugonu_bribe Offer Okawaru worshippers some nice summoning items. -------------------------------------------------------------------------------- 298df9dbad | advil | 2021-08-18 20:42:50 -0400 fix: refix something that is *not* an off-by-one-error da2e87d06967ae turns out not to have been an off-by-one error, but rather the result of bad initial calculations when the menu is not yet displayed, resulting in invalid scroll values. In addition, da2e87d06967ae broke scrolling in menus that don't use a hover. This wasn't noticed before now partly because webtiles still works, the bug seems to be a bit erratic, and in the words of one dev, "oh so that key is actually broke and its not my broken keyboard". -------------------------------------------------------------------------------- a584919b07 | Nicholas Feinberg | 2021-08-18 15:09:08 -0700 Warn about unsilencable spells Since players get surprised by these all the time. -------------------------------------------------------------------------------- 74814aa22a | advil | 2021-08-18 14:05:46 -0400 fix: more player shadow vs wrath avatar cleanups I went through references to MONS_PLAYER_SHADOW as well as mons_is_player_shadow to double check them vs. the previous commit and f9c1391b6; these are the resulting changes. -------------------------------------------------------------------------------- 4e69de0771 | advil | 2021-08-18 13:36:06 -0400 fix: don't crash on fedhas wave wrath Via side effects, this wrath action results in `move_player_to_grid` which puts the player on the same square as the fake monster casting the spell. This monster reuses shadow creature code, but as of f9c1391b6 no longer returns true for mons_is_player_shadow, so an ASSERT got tripped. This commit just adds another similar function for god wrath so that at least this special case can be checked without knowing implementation details, but also this implementation of wrath is not ideal. -------------------------------------------------------------------------------- 7c5eadcf33 | advil | 2021-08-18 10:36:43 -0400 fix: don't use homebrew includes over contribs Mac clang imposes `-I /usr/local/include` on builds, which takes precedence over our use of `-isystem` and leads to an unfortunate interaction with homebrew. Regular mac build tools don't actually use this location, and nor does macports, but homebrew does. For example if the user has SDL2 installed via homebrew, those includes will be used even though the build tries to link with the contrib version of SDL2, resulting in build failure. (This has been reported for a couple of years, it seems.) There may be a number of ways to fix this, and I'm not sure I'm a fan of using -isystem for contrib libraries that we are providing and maintaining and that aren't located in a system include path, but this commit takes a more minimal approach to working around this issue, just ensuring that checking this directory takes precedence under any `-isystem` includes introduced in the Makefile. (Of course, it's arguably a bug that mac clang does this with `-I` instead of `-isystem`, but good luck getting that changed.) Possibly in the future `-isystem` should be switched back to `-I` for contribs so that we have better control over this (by using `-isystem` we ceded control to any way of setting `-I` e.g. via environment variables), but doing so would require a lot of testing. (See e84909d808a7 for where this originated; from the dev logs I suspect this may be partly about suppressing warnings from include headers as well.) -------------------------------------------------------------------------------- 42b4daccc1 | advil | 2021-08-17 16:20:16 -0400 fix: remove accidental debug code -------------------------------------------------------------------------------- 9e3c00f94b | advil | 2021-08-17 15:12:35 -0400 fix: use correct names for non-alpha ctrl keys in SDL This was handled correctly for key help, but not the macro menu. I know I wrote this code in 378ef55cfb79986e3 but this is an extremely magical looking invocation, I wonder if there's a better option? -------------------------------------------------------------------------------- 0687de6023 | advil | 2021-08-17 15:12:35 -0400 fix: local tiles ctrl-key names (perryprog) This got overly #ifdef'd in 643d97a57c66bc5, but the issue hasn't popped up yet because that commit wasn't in the 0.27 release. -------------------------------------------------------------------------------- b5bb297faa | Nicholas Feinberg | 2021-08-17 10:28:51 -0700 Ban devolution as tempmut Seems very unkind to have our good abyssal starry friends give out permanent badmuts, even indirectly. This code is not great. -------------------------------------------------------------------------------- c707856eba | Nicholas Feinberg | 2021-08-17 10:28:51 -0700 New badmutation: Devolution Evolution's evil twin. Gives out a couple of bad mutations over time (currently once every 1/4th of an XL), then goes away. Better cure it fast, huh? -------------------------------------------------------------------------------- 9383fbc173 | Nicholas Feinberg | 2021-08-17 10:28:51 -0700 Solve Darwin's dilemma The Evolution mutation worked in a strange, complex, and not very satisfying way. Once every 500-1500 turns (!), it would check to see whether the total accumulated XP you'd gotten since your last evolution mutation, times the mutation level, times 1d10, was greater than the XP needed for your next XL. (So, it took a long time to do anything.) Once it triggered, it had a 20% chance of trying to remove a bad mut, 64% of applying a good mut, and 16% of applying a bad mut. Regardless, it had a 10% chance of removing itself. Surprisingly often, it would remove itself without doing much of anything at all. Instead, let's simplify. Each level of evolution is now worth 2 good muts. Once per XL's worth of experience, you'll get a good mut. After the second mut, you'll lose a level of evolution. It's a 'delayed gift box' mutation - very nice in the medium term, does nothing in the short term. Do you really want to quaff !mut if you still have a level of evolution pending? Tough choice... Don't worry - failures die fast. -------------------------------------------------------------------------------- 2552a6465f | advil | 2021-08-17 12:21:36 -0400 fix: correctly set target when firing untargeted abilities This keeps autofight_check from applying to quivered abilities without a targeter triggered by `f`, reported by discord user rypofalem. Applies to things like DD healing, ely abilities, etc. -------------------------------------------------------------------------------- 48023c6eb5 | Edgar A. Bering IV | 2021-08-17 18:12:29 +0300 fix: make confused trees claw the walls (PleasingFungus) -------------------------------------------------------------------------------- 12f296af85 | advil | 2021-08-17 10:38:20 -0400 feat: implement CTRL/SHIFT cues for */ in webtiles These are if anything more important than in console these days, since you may need to use them to override browser shortcuts on windows/linux, but the message window cues were only implemented on console. This just uses the more div to show custom messages. -------------------------------------------------------------------------------- b3f9c8a74a | advil | 2021-08-17 10:38:20 -0400 fix: default ctrl/shift behavior for numpad `*`/`/` This allows rebinding these keys, in contrast to regular * and /. -------------------------------------------------------------------------------- ed537f1d7e | advil | 2021-08-17 10:38:20 -0400 Revert "fix: temporarily disable new keymappings except 0-9" This restores full new-numpad handling from the commit sequence pre-tournament. * In trunk, people who have macros set to F1-Fn using keycodes in the -1000 range will need to adjust those to the correct keycode range (-265 etc). There'll probably be complaints about this, but this change needs to happen some time or other. * Distinct keycodes for more number pad keys are enabled; this is a bit keyboard dependent. These should already, hopefully, have reasonable default bindings. This reverts commit 662ed650adae8ada8c3a4fa3e5978df99d465dd1. -------------------------------------------------------------------------------- 780c878087 | Edgar A. Bering IV | 2021-08-17 17:16:07 +0300 fix: describe frost creeping from trees -------------------------------------------------------------------------------- 7777c1c129 | Edgar A. Bering IV | 2021-08-17 17:13:45 +0300 fix: a frozen tree form information leak (12624) -------------------------------------------------------------------------------- 638331083e | Edgar A. Bering IV | 2021-08-17 16:07:51 +0300 fix: update item seen status in relevant places (12626) This also fixes sporadic reports of monsters still picking up items a player has seen: the SEEN flag was not being set until the _prep_input stage of the player's turn, so a monster could walk into view and wield an item just revealed by the player. -------------------------------------------------------------------------------- 911e812f60 | Edgar A. Bering IV | 2021-08-17 10:13:02 +0300 fix: warnings for hasty artefacts (Majang) -------------------------------------------------------------------------------- 5eb9c77d6f | Edgar A. Bering IV | 2021-08-17 09:54:19 +0300 fix: set an appropriate string for a const prop (12629) Also closes #2070 and #2071. The bug was that both ITEM_TILE_KEY and WORN_TILE_KEY had the same value; on local tiles this would manifest by occasionally tripping an assert when a doll tyle would pass through tile_main_info. On webtiles javascript is more flexible and happily indexed the strange tiles requested, resulting in player doll tiles appearing in item stack icons and unseen mosnter tiles appearing on the floor. -------------------------------------------------------------------------------- a708605c5b | Nicholas Feinberg | 2021-08-16 19:37:26 -0700 hack: Make monsters not res tele self Very curious when this bug was introduced. I saw it reported a few months ago, but I'm not sure it was in 0.26. -------------------------------------------------------------------------------- d8966da807 | Nicholas Feinberg | 2021-08-16 19:24:00 -0700 Make potions of attraction translocate (kate) To preserve their utility for stabbing sleeping monsters (fun and potentially risky!) while keeping them consistent/intuitive with effects like Lesser Beckoning and Gell's Gravitas, which do wake monsters, retheme Attraction as translocating its victims rather than 'pulling' them. This is also more consistent with its behaviour wrt terrain obstacles like deep water and lava. The tloc clouds might have other weird effects, but even in zigs, they don't seem to do an awful lot in practice. This reverts commit 8d3330d46d1c987e9b2bae9433c9aefaa59c07d7. -------------------------------------------------------------------------------- a704b87b3c | Nicholas Feinberg | 2021-08-16 19:03:33 -0700 Fix Oka/Trog gift message order Maybe! This probably breaks something else important. -------------------------------------------------------------------------------- b2089b6bb7 | Edgar A. Bering IV | 2021-08-17 00:21:42 +0300 fix: try to place the entire requested number of maps with place_maps Since 2010, the dgn.place_maps function would attempt to place the requested number of maps... until one failed to place for any reason, then it would give up. Before then it would error, so this was an improvement. However the commit messages around that time suggest that the goal was for the function to continue in its attempt, and return the total number of placed vaults. This change should hopefully make some of our serial vaults shine a bit better. If they become too overwrought we might need to retune the number of serial maps each one places, but in my local testing it seemed ok. -------------------------------------------------------------------------------- 0eb5c47895 | Kate | 2021-08-16 22:07:03 +0100 Adjust "toggle layers" keybinds Use 'a' to toggle all visible layers instead of escape, so that escape can be used for its expected behaviour of cancelling out of the prompt. -------------------------------------------------------------------------------- 6f4fce7e9c | Kate | 2021-08-16 22:04:31 +0100 Dismiss summoned allies on joining Okawaru Instead of turning them hostile. -------------------------------------------------------------------------------- 787e458d71 | Kate | 2021-08-16 03:27:54 +0100 Revert "chore: add a trunk reminder for the 0.27 tournament" Tournament over! This reverts commit 06dbe2521f2f3a55d5c719914c39637abdb66fd0. -------------------------------------------------------------------------------- f39b64463d | Kate | 2021-08-16 03:09:24 +0100 Remove a duplicate failure check from +Blink So that (for example) activating it with Ozo's Armour active gives the prompt to abort before checking whether the ability fails. -------------------------------------------------------------------------------- 745f8db33d | Kate | 2021-08-16 02:54:43 +0100 Add a missing return -------------------------------------------------------------------------------- 5b07bef5ff | Kate | 2021-08-16 02:15:31 +0100 Give Okawaru a no-allies conduct Okawaru now demands that the player fight alone and prevents all allies, functioning the same as Ru's Sacrifice Love while worshipped. Requiring that the player fight alone fits well into Okawaru's theme (and has already been shown to work well as a conduct under Ru) so should let the god remain strong and straightforward but with a noticeable downside. -------------------------------------------------------------------------------- 7b975550ec | Kate | 2021-08-16 02:07:47 +0100 New Okawaru ability: Duel Granted at 5* (with Finesse moving earlier, to 4*), the Duel ability smite-targets a single non-summoned enemy in LOS (which must be threat level "tough" or higher), and transports them and the player to an Arena portal vault. The ability is aimed at giving Okawaru worshippers a more exciting top-end power, letting them isolate key foes and (alongside the upcoming conduct) fitting with the god's theme of appreciating the player proving themselves in combat. Invocations skill currently only affects success rate, but could possibly be used to give duels a power-dependent time limit. Water/lava-only monsters cannot be dueled, and banishment from within the Arena is blocked for both the player and monster. Winning the duel opens a gate to return from the portal vault, and the player will be forcibly teleported back after a short duration (to give them some time to loot before leaving). The Arena vault itself has a few cosmetic variations - any future variants should remain simple, with minimal terrain, and should be small enough for the whole arena to be in LOS on arrival. Each Arena also includes some favoured of Okawaru spectating the duel and cheering/jeering, and these could use some custom tiles and possibly more speech lines. -------------------------------------------------------------------------------- 7eff39e849 | Kate | 2021-08-15 22:21:15 +0100 Remove remaining support for mechanical traps Cleans up a large amount of dead code, with a few very minor gameplay implications - monster intelligence no longer has any effect on whether they try to avoid specific traps, since its only remaining effect was on friendlies avoiding teleportation traps. Instead of having only intelligent allies avoid them, let all allies avoid them. -------------------------------------------------------------------------------- 4af1e16f07 | Kate | 2021-08-15 22:21:15 +0100 Remove mechanical traps from Sprints They were already only a few left, and none of them were likely to have meaningful effects. Also clean up a couple of other vault definitions with '~' glyphs that weren't used in the vault itself any more. -------------------------------------------------------------------------------- e36b712cf9 | Kate | 2021-08-15 22:20:58 +0100 Fix spelling A pesky 'z' snuck back in. -------------------------------------------------------------------------------- 83978e0af5 | Nicholas Feinberg | 2021-08-15 13:42:48 -0700 De-indent Ignition logic -------------------------------------------------------------------------------- 3afc62176d | Nicholas Feinberg | 2021-08-15 13:38:17 -0700 Nerf Robin's damage Reduce back to 0.26 levels. (This is in response to a big spike in Robin kills in 0.27 - Robin was overlooked in those changes.) -------------------------------------------------------------------------------- bfbcaea002 | Nicholas Feinberg | 2021-08-15 13:34:54 -0700 Give Sigmund his slow scythe back 581982f5c1d5d0416b5a increased Sigmund's attack speed by 33% (from 15 aut/swing to 10), which dramatically increased his lethality. Let's bring him back to his usual level of cruelty. -------------------------------------------------------------------------------- e028cf09b9 | Nicholas Feinberg | 2021-08-15 13:34:23 -0700 Cut Jackal spawn rate considerably This rose by about 75% from 0.26 to 0.27, which wasn't intended and considerably increased early game caster deaths. There's probably more cleanup to be done here. This seems to increase D:1 XP somewhat; that might have other knock-on effects... -------------------------------------------------------------------------------- 77845bc91e | Nicholas Feinberg | 2021-08-15 13:33:42 -0700 Add a message for dj quaffing magic When quaff-iding !magic, add a message indicating that it was useless for you. -------------------------------------------------------------------------------- 10db4a4e68 | Nicholas Feinberg | 2021-08-15 13:33:22 -0700 Remove 8x from starburst damage description Not really meaningful. Should Fireball be 9x..? -------------------------------------------------------------------------------- 1a3d647539 | Nicholas Feinberg | 2021-08-15 13:32:55 -0700 Tighten up Usk description Remove some distracting fluff to make it clearer what 'the dance' is. -------------------------------------------------------------------------------- 5ad2e3275a | Nicholas Feinberg | 2021-08-15 13:32:29 -0700 Fix the build -------------------------------------------------------------------------------- f2ccef998a | Nicholas Feinberg | 2021-08-15 13:28:01 -0700 Make all shields only use Dex Instead of kite & large shields using a mix of strength and dex for bonuses. I doubt this will have a large impact on most characters, but should make shields a little simpler to reason about, and will reinforce Dex's role as a defensively focused attribute. -------------------------------------------------------------------------------- 6dc78333b9 | Nicholas Feinberg | 2021-08-15 13:27:45 -0700 Randomize wizmode player ghost names Seemed funny. -------------------------------------------------------------------------------- 162c5fecbd | Nicholas Feinberg | 2021-08-15 13:27:26 -0700 Customize antimagic wield messages for dj Since it has no effect on them. -------------------------------------------------------------------------------- 722926ba4e | Nicholas Feinberg | 2021-08-15 13:27:10 -0700 Remove nonexistent prop references Added in 0d0c82d5f74 but never actually implemented. -------------------------------------------------------------------------------- 184090c6a4 | Nicholas Feinberg | 2021-08-15 13:27:08 -0700 Constify almost all string literal props To avoid silly issues caused by typos. The rest should probably be constified too, I just ran out of energy. -------------------------------------------------------------------------------- 3b27209acc | Nicholas Feinberg | 2021-08-15 13:21:57 -0700 Remove separate acc/damage plusses Funny antique leftover in vaults parsing code. -------------------------------------------------------------------------------- e0fec98b5a | Nicholas Feinberg | 2021-08-15 13:21:45 -0700 Remove curses A few last leftovers. -------------------------------------------------------------------------------- 9f22321abd | Nicholas Feinberg | 2021-08-15 13:21:27 -0700 Standardize more monster Blink spells This should again have very few gameplay effects, but along with fixing the sap magic interaction, this will also cause blink range, blink away, and blink close to cause (a tiny amount of) noise. Exciting! -------------------------------------------------------------------------------- 09c23b12f5 | Nicholas Feinberg | 2021-08-15 13:21:12 -0700 Standardize monster Blink spell logic Remove a weird special code branch. This should have very few gameplay effects, though does mean that sap magic will interact properly with Blink. -------------------------------------------------------------------------------- d229782820 | Nicholas Feinberg | 2021-08-15 13:20:18 -0700 Fix MCC goldification Looks like it was intended that MCC would still make gold under Gozag, but one vital check was missed. -------------------------------------------------------------------------------- f319017eea | Nicholas Feinberg | 2021-08-15 13:16:20 -0700 Simplify find_maxwells_possibles() Use grid_distance() instead of reimplementing it and de-indent. -------------------------------------------------------------------------------- 0a0d85e590 | Nicholas Feinberg | 2021-08-15 13:16:20 -0700 Give Maxwell's LOS range Range was limited to 5 to avoid risk-free murder of statues, but, as a level 8 spell, it's probably fine to murder statues freely. It's simpler to reason about the spell if it can hit anywhere in LOS - players already get confused about the delayed targeting, so we don't need to add more space for ambiguity. (If it did miss due to being outside range, it'd be quite unclear what had happened.) -------------------------------------------------------------------------------- 71813d69f4 | Nicholas Feinberg | 2021-08-15 13:16:20 -0700 Simplify maxwell's name code monster::name already handles invisible monsters, and we don't have to worry about ones around corners. -------------------------------------------------------------------------------- ff2bc6137f | Nicholas Feinberg | 2021-08-15 13:16:20 -0700 Use constants for Maxwell's props To avoid simple errors. -------------------------------------------------------------------------------- fe3a445f75 | Nicholas Feinberg | 2021-08-15 13:10:50 -0700 Improve maxwell's no-target message Clarify that it failed due to a lack of target. ('Nothing happens' is very unclear in this context! And many others...) Also, de-indent. -------------------------------------------------------------------------------- 6365dcfadc | Nicholas Feinberg | 2021-08-15 13:10:50 -0700 Add a message for Maxwell's charge To clarify that something is actually happening when you hit '.'. The flashy status effect is cool, but very easy to miss if you aren't looking for it. -------------------------------------------------------------------------------- ab93a79d97 | Nicholas Feinberg | 2021-08-15 13:10:49 -0700 Tweak Coupling desc Clarify that you need to channel. Remove a mention of relec - not a confusion people seem likely to have. -------------------------------------------------------------------------------- 182d1643c2 | Nicholas Feinberg | 2021-08-15 13:09:04 -0700 Trigger battlesphere on staff of battle hits It seems cool. -------------------------------------------------------------------------------- a8238b5478 | Nicholas Feinberg | 2021-08-15 13:08:02 -0700 Move mobile golems onto 9 The '8' glyph was overstuffed, with 22ish monsters, while '9' had only 3. Shifting all mobile monsters from '8' to '9' creates a much better balance: 16 '9's and 9 '8's. If we want to have more golems or statues later, this should give us more flexibility. It also means that saltling no longer shares a glyph & colour with pillars of salt & diamond obelisks. -------------------------------------------------------------------------------- d52c3af447 | Nicholas Feinberg | 2021-08-15 13:05:44 -0700 Simplify airstrike damage Remove the floor of 3 on bonus damage from surrounding empty spaces. Now that we display this to players, it's too confusing to try to explain. This is a small nerf. -------------------------------------------------------------------------------- 176428ccee | Nicholas Feinberg | 2021-08-15 13:05:42 -0700 Display airstrike bonus in the targeter -------------------------------------------------------------------------------- febfb30b37 | Nicholas Feinberg | 2021-08-15 13:04:56 -0700 Show empty spaces around Airstrike targets And avoid information leaks. -------------------------------------------------------------------------------- e8fccdb193 | Nicholas Feinberg | 2021-08-15 13:04:55 -0700 Add an airstrike targeter Show a brighter or darker target indicator based on the number of empty spaces around the target. -------------------------------------------------------------------------------- 4aefe609b9 | Nicholas Feinberg | 2021-08-15 13:04:55 -0700 Show shatter damage in the targeter Highlight susceptible enemies with AFF_MULTIPLE and show enemies that take reduced damage (eg jellies) with AFF_MAYBE. -------------------------------------------------------------------------------- 63affc0d33 | Nicholas Feinberg | 2021-08-15 13:04:55 -0700 Make the Shatter targeter more precise Show visible affected monsters & walls, including the chance to shatter different terrain types (roughly). -------------------------------------------------------------------------------- 99093fa9e1 | Nicholas Feinberg | 2021-08-15 13:02:34 -0700 Remove the rune requirement to enter ziggurats This was added in 07949ec7b9c0 as a replacement for the old gold-based ziggurat entry cost, rather than as something with a solid justification in itself. Later discussions (e.g. https://s-z.org/crawl-dev/%23%23crawl-dev-20140929.lg ) suggested that the reason for the 2-rune requirement was as a 'progression' between Vaults and Zot. The Zot rune lock exists so that players are forced to battle the difficult and exciting encounters guarding runes before winning the game, and the Vaults rune lock likewise exists to encourage players to get at least one rune earlier, while the earlier S runes are still challenging. The Zig rune lock, in contrast, has no real justification other than history. So let's cut it! -------------------------------------------------------------------------------- cafe5c4f27 | Nicholas Feinberg | 2021-08-15 13:01:55 -0700 Give Enchanters invisibility again Corona is not a very fun spell to use. The player is being asked to spend their time flipping a coin, and, unlike Ensorcelled Hibernation or Petrify or similar spells, they don't get a satisfying reward. Instead, they get a roughly 20% accuracy increase, which is really quite hard to notice. Most of the time, players are better off throwing stones or doing almost anything else. So, we'll remove Corona from the Enchanter starting book (that is, leaving them without a level 1 spell) and give them a single potion of invisiblity instead. This should be a net buff to the background overall. (It's a nerf to muen, but mummies should be used to suffering by now.) Arkane markspersons will be addressed in some way once ranged combat is reworked. They aren't changed in this commit. Does not revert 64f0e6ef8afa5d38b99351a6346e47b553adcc76 . -------------------------------------------------------------------------------- 027562a8d8 | advil | 2021-08-15 09:41:55 -0400 refactor: improve Menu action api a bit (take 2) Previously, the general on_single_selection function needed to handle selection for every MenuEntry, leading to things like conditioning on hotkeys in an awkward way, code being split up, etc. -- at least for the Menu use cases I've been introducing in the 0.27 cycle (macro submenus and the like). This commit lets a MenuEntry be defined directly with an action in the form of an on_select function, making for more coherent (though not less verbose) code in macro.cc. This reverts commit e9cb50d38746ba62bce27ec046d3c630cd5bc1b2. -------------------------------------------------------------------------------- cbb86046cc | Kate | 2021-08-15 00:38:20 +0100 Rebrace -------------------------------------------------------------------------------- e31878e1fe | Kate | 2021-08-15 00:37:39 +0100 Don't consider rings of rPois useless for bloodless vampires The useless item filter shouldn't drop items which will become useful again on returning to life. -------------------------------------------------------------------------------- f70498e230 | Kate | 2021-08-14 23:25:11 +0100 Improve vampire transformation messages -------------------------------------------------------------------------------- 8d3330d46d | Kate | 2021-08-14 23:25:11 +0100 Make potions of attraction wake up monsters Other methods of forced movement (Beckoning, Gravitas, etc) all wake monsters up, so potions of attraction not doing so is fairly unintuitive. -------------------------------------------------------------------------------- 73ec313a74 | Nicholas Feinberg | 2021-08-13 19:30:46 -0700 Fix yellow drac monster cast messages Broken since 29bf9f277ad , 2016. -------------------------------------------------------------------------------- e9cb50d387 | advil | 2021-08-13 19:18:01 -0400 Revert "refactor: improve Menu action api a bit" This broke some inventory menus, apparently. I don't have time to do a direct fix right now. This reverts commit 1b086527081208bf4a99ba5dbfafc23619dfe122. -------------------------------------------------------------------------------- fd0ec89410 | advil | 2021-08-13 12:01:58 -0400 doc: fix a confused comment -------------------------------------------------------------------------------- 1b08652708 | advil | 2021-08-13 11:52:12 -0400 refactor: improve Menu action api a bit Previously, the general on_single_selection function needed to handle selection for every MenuEntry, leading to things like conditioning on hotkeys in an awkward way, code being split up, etc. -- at least for the Menu use cases I've been introducing in the 0.27 cycle (macro submenus and the like). This commit lets a MenuEntry be defined directly with an action in the form of an on_select function, making for more coherent (though not less verbose) code in macro.cc. -------------------------------------------------------------------------------- a53d8862b5 | advil | 2021-08-13 11:52:12 -0400 refactor: unify some slaying calculations This is a followup to 09634a79b; adopting the assumption there that this calculation should be the same for monsters and players, just unify the code so they would be modified together. (Also, add a comment on the oddity of this calculation.) -------------------------------------------------------------------------------- a52ba8600a | Nicholas Feinberg | 2021-08-12 10:46:39 -0700 Redewiggle Closes #1825. -------------------------------------------------------------------------------- 278a0e9555 | Nicholas Feinberg | 2021-08-12 10:34:31 -0700 Rewriggl This reverts commit 9df8b82d6f4c636b92ce8c650f64e25a7c1e846f. -------------------------------------------------------------------------------- 9df8b82d6f | Nicholas Feinberg | 2021-08-12 10:32:48 -0700 Dewriggl -------------------------------------------------------------------------------- b8161351ab | advil | 2021-08-12 13:13:46 -0400 fix: rework fungal movement behavior Previously, fungus movement constraints were checked (at least) once per square they consider moving to. For deathcaps and wandering mushrooms, this is fine; their constraint is absolute. For lurking horrors, this led to some odd behavior: the `random2` call is rerolled for every possible target square, leading to a chance for movement that is a bit hard to reason about, and determined largely by the degree of openness around the monster. Various people have also reported that lurking horror movement patterns have changed, with them becoming more likely to charge and having weirder ("wiggly") paths. I *think* that to the extent this is true it is because of subtle interactions with changes in monster pathing over time: monsters consider more path options than they used to (I think), and so the odds of them charging at a distance have changed, and their paths are drawn from a wider variety of indirect paths. There may also have been an interaction with the introduction of squarelos. Though I have tested them with versions going back to 0.12 and the changes are not gigantic. This commit moves the movement check out of the low-level movement code, and so does the random check only once. This means that a lurking horror always has exactly 1 in LOS+1 chances of moving at the edge of LOS, rather than up to 5 in LOS+1 chances depending on the terrain. One noticeable side effect of this change is that a wandering mushroom at the edge of los will follow a foe as they move out of los, rather than giving the foe a turn out of los. This is because the sequencing is that the player moves, the fungus is out of los, and then can move. On the old code, the movement target was also considered, perhaps for this exact scenario. So if players find this too confusing, it may be necessary to restore some version of it at least for wandering mushrooms and deathcaps. I don't think lurking horrors would need it. -------------------------------------------------------------------------------- 169bfb5c5e | advil | 2021-08-12 10:27:47 -0400 fix: indicate SK_THROWING as a skill for stones (mishima) The only impact that I know of is that the skill will show up by default in the skill menu, but there could be other side effects. -------------------------------------------------------------------------------- 2bf3c13a2f | advil | 2021-08-12 00:54:00 -0400 fix: clean up redundant warning prompts This affected bad items when no hostiles were in view, they led to a double prompt. -------------------------------------------------------------------------------- 53fca2b799 | advil | 2021-08-12 00:54:00 -0400 feat: targeter and range checks for scroll of torment This also fixes (?) the handling of torment resistance in monster_info, where it seems to have been mostly ignored. Unless I'm missing something... -------------------------------------------------------------------------------- a44e4a4e2b | advil | 2021-08-12 00:54:00 -0400 fix: don't show ranged to-hit for non-missiles in default targeter This was specifically showing up for scrolls of torment, which don't have a targeter, but all of the details that this prevents are applicable only when this targeting behaviour is used for missiles. -------------------------------------------------------------------------------- 7ef01f2898 | hellmonk | 2021-08-11 23:11:07 -0400 feat: New ghost vault with an iron shot theme -------------------------------------------------------------------------------- 8873947cb4 | hellmonk | 2021-08-11 21:46:24 -0400 Improve descriptions of some weapon types (hawthornbunny) -------------------------------------------------------------------------------- 8b7c386d52 | advil | 2021-08-11 18:01:45 -0400 fix: use current los for lurking horror movement checks This doesn't really fix whatever general problems there may be with lurking horror movement, but it at least keeps them from getting stuck at the edge of Barachi vision range. (It shouldn't affect smaller ranges significantly because of the you.see_cell(targ) check.) -------------------------------------------------------------------------------- 844de0d849 | advil | 2021-08-11 17:07:12 -0400 fix: quiver range check for blinkbolt When there is no enemy in blinkbolt range, gray the quiver and improve autofight messaging. -------------------------------------------------------------------------------- c083491d3f | advil | 2021-08-11 16:59:27 -0400 fix: enforce range in blinkbolt targeting (kate) Previously, you could use ! or @ to target an enemy out of range, and blink to the end of range along the bolt path. This imposes the targeting restriction from power leap and line pass that also requires the monster target to be in range. (It also renames the relevant enum value and clarifies the comments in the enum.) -------------------------------------------------------------------------------- 0b5ac8c916 | advil | 2021-08-11 13:32:38 -0400 feat: a better wizmode interface to feature placing Sometimes for debugging purposes it is helpful to set up specific dungeon layouts in wizmode, but the interface via `&` for doing this was really quite painful. This commit adds a much better interface for placing a bunch of features quickly, via some wizmode-specific abilities that provide a helpful targeter. It may or may not be a good idea to have wizard-specific abilities (none exist prior to this), and if it turns out to be too annoying, I can convert these back to something more like the old `&` interface and selection. But for now, let's try this -- they are very convenient to access. Some further features it would be nice to have if there's demand (but since none of this is user-facing, low priority): * a way to change the feature being built within the targeting interface, right now you need to use the separate ability. * some way to create feature_property_types, right now you have to use the old UI to do this. * a better feature selection interface, what's there is the old one split off into its own function. * a way of toggling xray vision in the targeter? This is definitely most useful with xray vision on. (Is this the beginning of dcss creative mode???) -------------------------------------------------------------------------------- 49a0850c41 | advil | 2021-08-10 17:00:12 -0400 fix: improve message order for constriction damage This needs to message before the `hurt` call, otherwise various messages in `ouch` don't make sense, and messaging is missing entirely on player death. -------------------------------------------------------------------------------- 1f5599b4a6 | advil | 2021-08-10 16:45:07 -0400 feat: add a killer type for constriction Dying by constriction was completely undistinguished from melee damage aside from a status; this is probably ok for a direct constriction attack but is very confusing for BVC/grasping roots. On par with things like barbs and collisions, add a ktyp. -------------------------------------------------------------------------------- 4baf66127a | advil | 2021-08-10 10:18:39 -0400 fix: properly handle return on y/n popups with hover Return was just sending the default answer, not the selected one. (For legacy reasons, Menu distinguishes between on_single_select and pressing the hotkey for the item, but this really should be cleaned up so that Menus don't constantly need the kind of on_single_select I just added here.) -------------------------------------------------------------------------------- 63c4f9efeb | Kate | 2021-08-10 10:04:11 +0100 Remove mechanical traps from Tomb:1 The Tomb:1 corridor still had some mechanical traps left over. -------------------------------------------------------------------------------- 18048e5a82 | Kate | 2021-08-09 23:31:50 +0100 Add targeters for Blink, Disjunction, and Manifold Assault -------------------------------------------------------------------------------- 47d82705ae | Kate | 2021-08-09 16:10:53 +0100 Fully identify some partially-identified randarts Partial identification of these items is fairly confusing from a distance, since outside of specific rare vault placements, almost all items are now either fully unidentified or fully identified. Instead of partially identifying vault randarts and displaying the brand or base type but no other properties, just fully identify any randarts that have a fixed base type or are unrand fallbacks with a guaranteed brand. -------------------------------------------------------------------------------- 2c61e4fb76 | Kate | 2021-08-09 14:21:20 +0100 Adjust a monster attack brand description It's a little awkwardly worded either way, but rewording AF_BLINK to say "blink self" fixes the case where monsters with the brand were referred to as "it" even for monsters that should use a different pronoun. -------------------------------------------------------------------------------- cfcbea5bde | Kate | 2021-08-09 14:21:20 +0100 Fix uselessness checks for rCorr Rings of resist corrosion were incorrectly being considered permanently useless with temporary rCorr active (from a potion or a form that provides rCorr, for example). -------------------------------------------------------------------------------- 102d6777a4 | advil | 2021-08-08 14:07:30 -0400 feat: indicate existence of /help in webtiles chat The existence of commands that this describes, especially /mute, were not at all apparent to newer players, especially ones not familiar with something like irc. This commit also changes: * don't count interaction with / commands as unread messages * "back to game" -> "close", as a more accurate description of what this actually does. Also, maybe this should say "esc" unless focus is in the chat box? But no change here. These will need a webtiles restart and possibly hard cache reset for players to pick up. -------------------------------------------------------------------------------- f9c1391b64 | advil | 2021-08-08 13:30:02 -0400 fix: don't credit the player for wrath kills (Turukano) Wrath attacks reuse shadow creature code, and because of this, wrath kills were credited in the same way that shadow kills were credited. A version of this was supposedly fixed in 9176aad88b6178, but I don't think it actually was. The relevant check is not to the monster's actual mindex; in mon-death.cc killer_index is simply reset to the player with the actual mindex discarded as long as mons_is_player_shadow returns true. (As noted in the comment there I think this would all work better if the wrath code didn't reuse the player shadow code in entirety, this is a recipe for bugs to sneak in.) -------------------------------------------------------------------------------- 65e1ffefe4 | Edgar A. Bering IV | 2021-08-07 21:56:29 +0300 fix: okay then when cancelling Stack 5 (12622) -------------------------------------------------------------------------------- 325244837d | advil | 2021-08-06 16:07:12 -0400 fix: adjust targeter highlight colours In terms of the practical effect, this ups the alpha values so that the highlighters are more opaque; I also did a bit of color adjustment and moved the dimmer highlight a bit towards gray. This makes them more visible against blue and brown backgrounds, as in shoals. The new colors are probably uglier, but they are definitely more visible. More tweaking may be required. In the long run, I do wonder if some other color than yellow might work better here, or even something more complex like showing tile borders. Under the hood, this replaces the targeter highlight tiles with programmatically generated tiles, and fills out the tile tool with some commands to make this possible to do. -------------------------------------------------------------------------------- 8149849420 | advil | 2021-08-06 12:12:26 -0400 fix: respect no_tele_into in pan landing selection There is exactly one vault in pan.des which actually uses the prop, but that vault definitely places a formicid-dooming tele trap, so let's check the flag. I suspect it wasn't checked simply because historically it wasn't used. -------------------------------------------------------------------------------- 934d61de66 | advil | 2021-08-06 12:02:31 -0400 feat: show no_tele in wizmode cell description This is in order to make it very easy to double check vault props in console. -------------------------------------------------------------------------------- 9442e6b4c1 | Edgar A. Bering IV | 2021-08-06 17:45:46 +0300 feat: add bolt of draining to tengu reavers -------------------------------------------------------------------------------- 718bdbf3cc | Edgar A. Bering IV | 2021-08-06 17:30:58 +0300 fix: reset ashenzari boosts with fishtail merging -------------------------------------------------------------------------------- 25d27de915 | Edgar A. Bering IV | 2021-08-06 16:35:10 +0300 fix: don't add a redundant spectral Now that spectral is a brand we don't need to name the monster "a spectral +4 spectral quarterstaff". -------------------------------------------------------------------------------- b9de417b3f | Edgar A. Bering IV | 2021-08-06 12:50:55 +0300 fix: don't crash when abandoning ash with the finger necklace (CanOfWorms) -------------------------------------------------------------------------------- 9a7839dea9 | Edgar A. Bering IV | 2021-08-06 00:22:42 +0300 fix: range and chance in dispersal targeter -------------------------------------------------------------------------------- 9604337dc0 | advil | 2021-08-05 17:04:31 -0400 fix: render targeters after other overlays After a lot of digging, it turns out that these are simply assembled in the wrong order, so the targeter (ray) tiles are always drawn first. In local tiles, the way alpha blending works means this doesn't matter (or at least, I'm pretty sure that's what is going on), but in webtiles the effect was that the targeter goes under other tiles. In particular, it layered under wave tiles. This commit just brute-force pulls them out of the overlay list and draws them last in this list. Possibly these should be rendered even later. Also, for future people digging into this: `draw_ray` does not draw these ray tiles. I don't know what this function does draw. -------------------------------------------------------------------------------- 516ec72166 | Edgar A. Bering IV | 2021-08-05 22:32:34 +0300 feat: treat *Rage as intentionally hasty Players excpect it, the property is identified, berserk is triggered when the player makes a choice, and other intentional berserks anger Chei. -------------------------------------------------------------------------------- 312a84cf96 | Edgar A. Bering IV | 2021-08-05 21:37:18 +0300 fix: keep the lighthouse keepers from the flame -------------------------------------------------------------------------------- 7c29f1f256 | advil | 2021-08-05 12:05:57 -0400 fix: handle multiple SDL key events for numpad `.` For some reason, SDL is sending both . and Del for numpad . on some keyboards, even when . isn't delete. This commit handles that case by suppressing the . when there's a double event, and providing a default mapping of delete to CMD_WAIT. This should be fine because it's previously unbound, but I've set this to local tiles only; it seems buggy that SDL is sending this keycode at all (at least on my keyboard), so this may be a temporary fix if I can figure out what is going on here. SDL numpad handling generally needs some attention. For background on the key handling issues, see af9c1943b0bc. Reported by discord user Dank Memer. -------------------------------------------------------------------------------- 70931ec564 | Edgar A. Bering IV | 2021-08-05 18:54:53 +0300 fix: update acrobat for quiver-fired wait spells -------------------------------------------------------------------------------- 2d7b7a1a19 | Edgar A. Bering IV | 2021-08-05 18:19:00 +0300 fix: display hit chance in the starburst targeter -------------------------------------------------------------------------------- 9707f7362f | advil | 2021-08-03 12:35:43 -0400 fix: mark ENCH_SHORT_LIVED in monster descriptions Indicate that briar patches will crumble away. -------------------------------------------------------------------------------- 444c7a33f5 | Nicholas Feinberg | 2021-08-01 21:11:30 -0700 Alphabetize gods.txt Move Wu Jian into its proper location. -------------------------------------------------------------------------------- 53beef7077 | Nicholas Feinberg | 2021-08-01 16:43:17 -0700 Fix Tukima's description (rockygr) Forgot to touch this when I allowed Tukima to affect ranged weapons. -------------------------------------------------------------------------------- 616f7b5f32 | Kate | 2021-08-02 00:11:35 +0100 Fix Summon Lightning Spire not having a targeter As with other summons, it should show potential locations when its targeter is enabled via the force_targeter option. -------------------------------------------------------------------------------- 1dcfd26496 | Kate | 2021-08-01 23:34:27 +0100 Fix spelling in a description Missed this one in 70c531d6. -------------------------------------------------------------------------------- 15dc114455 | advil | 2021-08-01 14:16:25 -0400 feat: keycode help for macro mappings This introduces a detailed help screen for crawl-internal keycodes, and shows it in a couple of places in the macro menu. Some TODOs: * map SDL keycodes to this space so things are uniform across build targets * generate this help automatically from keycodes * fix a bug in webtiles where a popup over a title prompt does not receive focus for key input -------------------------------------------------------------------------------- 42140f4989 | Nicholas Feinberg | 2021-08-01 09:31:24 -0700 Fix transform wieldability display bug (sanka) Weapons that couldn't be wielded due to your current form (e.g. due to Blade Hands) would claim to be "too large" when examined. This should no longer occur. -------------------------------------------------------------------------------- 16105a9d8c | gammafunk | 2021-08-01 11:21:45 -0500 fix: Identify a guaranteed vault potion (Yermak) In wizlab_wucad, there's a guaranteed potion of experience. Pre-identify this potion in a way consistent with how we identify other guaranteed or highly probably loot types and properties. -------------------------------------------------------------------------------- 77753f3aa7 | gammafunk | 2021-08-01 11:21:45 -0500 feat: Don't use trees in a Swamp transporter vault The vault gammafunk_worm_tunnel uses a border of trees to help it blend in with the surrounding level. It's trivial to burn some of these trees with an item as common as scroll of immolation and collect the loot in a way that bypasses all threats in the vault. Also, the vault's size has been greatly reduced, so it doesn't stand out in a drastically weird way. This commit restores the stone walls when it places in Swamp, so it uses the same wall type in all places it generates. -------------------------------------------------------------------------------- 84acfa7270 | advil | 2021-07-31 16:19:07 -0400 fix: speed up explosion calculations (gammafunk) The check for whether a cell had already been seen with count value <= n was not properly taking into account the additive factor cadd that is accumulated on recursion, and so was redoing a lot of calculations to no extra effect. This led to big slowdowns on e.g. firestorm targeters in open areas. Or at least, that's what I *think* was happening, this algorithm is pretty complicated. But this change speeds things up quite a bit, and doesn't change explosion shapes as far as I can tell. N.b. this function is still called many times during targeting, but without noticeable slowdown after this change, in my profiling. -------------------------------------------------------------------------------- dd8709b231 | Kate | 2021-07-31 20:58:50 +0100 Fix poison-vulnerable monsters displaying as meph immune -------------------------------------------------------------------------------- 49dcd67cf8 | gammafunk | 2021-07-30 13:04:52 -0500 doc: Credit ZureaL in the server admin list I've also reorganized these names using the "last name or nick" ordering that we use for other credits. -------------------------------------------------------------------------------- 3707ed8130 | advil | 2021-07-30 13:08:41 -0400 fix: handle clicking on non-chr hotkey items correctly When input is sent via `data`, it is passed through `chr()` in the python code. But, the value stored here is a keycode and may be negative for special keys, so this was causing an exception in python. This comes up specifically when clicking on macro menu entries for some special keys, and pretty much nowhere else (the main menu uses esc, but this is still a positive keycode). On the user side, it's relatively harmless, the symptom is just that clicking doesn't work, so backporting to stable is not urgent. It just produces log messages. Two changes around this: * for arrow-selection menus, don't use the hotkey at all, force calling on_singleselect. (Hopefully in the future this distinction is better cleaned up.) * send hotkeys via `keycode` rather than `data`, so that this code is more robust for the future. Should have no impact on current menus... -------------------------------------------------------------------------------- bfdb43030f | advil | 2021-07-30 12:13:31 -0400 fix: extend aa6b198b to keydown handling (Spaniq, wheals) This will be more impactful once full numpad key handling is back on, but for now it is also impactful on keyboards that send a high/numpad-specialized keycode for some numpad operator keys together with a regular keypress (I can reproduce this on mine). I think this override (and the one in aa6b198b) could be made better by checking whether the menu is in key entry mode specifically, it doesn't need to happen for the entire menu. However, I don't want to mess with this too much just now. -------------------------------------------------------------------------------- 06dbe2521f | advil | 2021-07-30 10:09:38 -0400 chore: add a trunk reminder for the 0.27 tournament -------------------------------------------------------------------------------- 041002c0f2 | advil | 2021-07-30 10:09:24 -0400 Revert "chore: Add a trunk reminder for the 0.26 tournament" This reverts commit e6e398f9e6a4651d34eba70066e19c64dbf84b5b. -------------------------------------------------------------------------------- e6e398f9e6 | advil | 2021-07-30 10:06:28 -0400 chore: Add a trunk reminder for the 0.26 tournament -------------------------------------------------------------------------------- 6846a8eab2 | advil | 2021-07-30 10:06:28 -0400 fix: shorten tournament message to <80 chars This is not wrapping on current UI for whatever reason, so just shorten the message a bit so it can be fully shown on console. -------------------------------------------------------------------------------- 662ed650ad | advil | 2021-07-30 10:04:22 -0400 fix: temporarily disable new keymappings except 0-9 Because the previous commit fixes this in code that usually takes a while to make its way into people's caches, I'm just temporarily bringing trunk's keypad and fn key behavior in line with 0.27, in hopes of getting the persistance bug to go away quicker. This commit partially readds some of the legacy handling for function keycodes in the -1000 range, so that their names aren't shown confusingly for anyone actually using trunk while this commit is in place. I expect to revert this commit in the near future. -------------------------------------------------------------------------------- f225e029a1 | advil | 2021-07-30 09:35:00 -0400 fix: actively reset keycode mappings on lobby load Because these were getting set only on load of the entire app, my attempts at versioned keycode mapping were getting reset only on a full reload and therefore persisting across versions -- needless to say this created a bunch of confusion. -------------------------------------------------------------------------------- 54b5640690 | gammafunk | 2021-07-30 00:13:20 -0500 doc: Final changelog updates for 0.27.0 Main and debian changelogs (cherry picked from commit a0080399dad664af76b4aa87ab7530497249abb0) -------------------------------------------------------------------------------- b16ffaf7c1 | Nicholas Feinberg | 2021-07-29 19:30:06 -0700 Djinni changelog rewording (gammafunk) Mention using Spellcasting instead of spell schools. -------------------------------------------------------------------------------- 8378e6c968 | Kate | 2021-07-30 02:22:47 +0100 Remove mechanical traps from a Tomb entry vault It was using the ~ random trap glyph, which shouldn't really be used anywhere. -------------------------------------------------------------------------------- 271197699b | Nicholas Feinberg | 2021-07-29 14:36:36 -0700 Tweak end_maxwells_coupling Reduce indentation and fix a typo. -------------------------------------------------------------------------------- f87c99a2d6 | Edgar A. Bering IV | 2021-07-30 00:00:43 +0300 docs: update CREDITS.txt -------------------------------------------------------------------------------- ed1d120c62 | Kate | 2021-07-29 21:54:54 +0100 End Searing Ray on Felid revival In the extremely rare case of being revived on the same square that the player died on, Searing Ray would continue being channeled. -------------------------------------------------------------------------------- a6d7c33c12 | Kate | 2021-07-29 21:54:41 +0100 Fix compilation -------------------------------------------------------------------------------- f67c460f1f | Edgar A. Bering IV | 2021-07-29 23:33:00 +0300 fix: expire ramparts and mcc on felid revival -------------------------------------------------------------------------------- 867ca72370 | Elliott Bernstein | 2021-07-29 23:33:00 +0300 fix: empty corrupting presence source messages Closes #2046 [ Committer's note: also addressed the use of malmutate (currently ignored but good future proofing and adjusted the commit message. ] -------------------------------------------------------------------------------- 0740493359 | Edgar A. Bering IV | 2021-07-29 23:33:00 +0300 tile: Word of Chaos ability icon (CanOfWorms) -------------------------------------------------------------------------------- 04a2f65e3b | advil | 2021-07-29 16:23:44 -0400 fix: add some default bindings for distinct numpad extra keys Some numpad operator keys may now be bindable separately from their regular versions. This commit assigns as many of them as I could their regular default bindings in various contexts. This commit is a bit brute-force, and some eventual unification with local tiles would also be nice. It may actually be better in the long run to collapse the multiple versions of `=/*-+.`? For one thing, I don't think the differentiation of these across different devices is wholly reliable. -------------------------------------------------------------------------------- eb8ac83edc | advil | 2021-07-29 11:21:21 -0400 fix: minimize impact of numpad changes on old versions This commit should restore the exact (sometimes broken, but mostly semi-working) behavior of the numpad on pre-0.27 versions. I've seen reports of issues on e.g. 0.26 where it's a bit tricky to identify the exact cause, and so this is to try to eliminate them. Possibly, some of this can be later removed, e.g. this restores a browser-specific chrome tweak that doesn't line up with my testing of current chrome in the wild (that's why I originally removed it). -------------------------------------------------------------------------------- fd831c5874 | advil | 2021-07-29 09:28:30 -0400 fix: capture ctrl+0-9 keys (dilly) It does not look like the crawl binary handles these at all, so I'm not sure how much this will do, but this may help with ctrl+numpad combos where the number key is interpreted as an arrow/home/etc and the browser was capturing it. -------------------------------------------------------------------------------- fa555f5c9d | advil | 2021-07-29 08:58:00 -0400 fix: only normalize numpad number keycodes The key conditional in 7b1be97da7 was converting too many cases; for example it was possible for `code` to be NumpadX with arrows/home/etc. This also should fix shift handling for a number of cases, depending on what the keyboard actually sends. * report 1 (Ham): shift-5 sends clear. This should now be fixed for this key configuration, as I think it was being prevented by keycode overwriting. It's worth noting that this is a pretty non-standard arrangement, and since we have no specific translation for shift-5, it probably just sends numeric 5 on many keyboards (as it does on mine). I'll await more reports to see if there should be some standardization for shift+5. Shift+0 is in a similar state. * report 2 (dinky): `code` values lined up with number keys, but `key` and `keyCode` are arrow/home/etc. keys. Interestingly, no keypress event at all. Again, fixed by reining in keycode replacement. We'll see what other exciting keyboard situations the world provides next... -------------------------------------------------------------------------------- 7b1be97da7 | advil | 2021-07-28 15:01:48 -0400 fix: improve handling of numpad keycodes on webtiles Modern browsers can differentiate numpad keycodes from their regular versions quite straightforwardly, but this information wasn't being handled well by the javascript interface. This was manageable on devices that have numlock, because with numlock off, the keycodes for the secondary keycodes are usually fine for movement, and the number keys are available for macros. But on devices without numlock (like all macs for many years), this was pretty annoying if you use the numpad for movement -- there was no way to use the numrow number keys separately, and rebinding them rebound the number pad keys. Moreover, these keys were generally handled better on local console/tiles. This commit attempts to remedy this situation along with some other tweaks. * key handling in the webtiles client now has a versioned component that can override unversioned key handling. * Support for legacy F keycodes (see b0746d5dc15c) is dropped going forward. This will break some existing macros that used the (wrong) values in the range -1011 to -1014, these should be easy enough to fix up but basically the correct values are -265 to -268. * The client uses w3c `code` values[1] to detect numpad keys in a way that works across browsers and maps them to (a version of) the internal keycodes that local console was already using for them. This means that default movement bindings etc continue to work for them. * I did some standardization and cleanup of these keys for non-local-tiles builds, and their names will show in the macro editor. [1] https://www.w3.org/TR/uievents-code/#code-value-tables Caveats: * The underlying curses code remains quite shaky, and numpad = is currently not handled at all. * The versioned keymapping API is non-existent; and in the future we may want to consider modernizing this to check `code`. * Probably more variation across devices / builds than is accounted for here... -------------------------------------------------------------------------------- da2e87d069 | advil | 2021-07-28 11:35:06 -0400 fix: off-by-one error in menu calculations This was causing javascript exceptions in webtiles with 1-item menus. I'm not sure it was otherwise very consequential, maybe visual glitches when spectating? I'm actually still not sure that this is being calculated right (based on some output debugging) but it isn't causing invalid menu jump_to targets any more, that I can find. -------------------------------------------------------------------------------- f34e66f144 | gammafunk | 2021-07-28 01:40:20 -0500 doc: Mention Storm Form in the changelog -------------------------------------------------------------------------------- 560ac104fe | gammafunk | 2021-07-27 14:00:28 -0500 fix: Don't make redundant explosion calculations Some targeters use explosion map data calculated by struct bolt for both the minimum and maximum possible explosion radii. In cases where those radii are identical, the calculations are still run twice. This commit copies the minimum radius explosion data when the maximum data would be identical. -------------------------------------------------------------------------------- 6621cef402 | gammafunk | 2021-07-27 13:58:42 -0500 fix: Correct the LRD targeter display (CanOfWorms) The fragmentation targeter's display wasn't properly accounting for intervening walls and statues and indicated additional cells as being affected that were not in the final explosion. This was because the targeter was running the explosion map determination code with the incorrect arguments and beam flavor. The actual LRD explosion was correct, since that's run later, and in the correct way. This commit corrects the targeter logic so it agrees with the actual explosion. -------------------------------------------------------------------------------- 4b2499a8ea | Edgar A. Bering IV | 2021-07-27 18:51:57 +0300 fix: apply item_slot when merging stacks from a shop Closes #1685 -------------------------------------------------------------------------------- 9cfa8ffb95 | Edgar A. Bering IV | 2021-07-27 18:14:39 +0300 fix: don't pick up floor-id'd useless items (12530) -------------------------------------------------------------------------------- 3fd8b35b7f | Edgar A. Bering IV | 2021-07-27 17:36:06 +0300 fix: adjust default autopickup autopickup exceptions is an ordered option, put the good_item default last so useless items that would be good for someone else don't get picked up. Closes #2042 -------------------------------------------------------------------------------- 9055cd164d | Edgar A. Bering IV | 2021-07-27 17:34:08 +0300 docs: correct an options guide entry -------------------------------------------------------------------------------- af9d615c11 | Edgar A. Bering IV | 2021-07-27 17:20:18 +0300 fix: don't consider branded missiles emergency items 6be897d added these, unfortunately the `\` menu doesn't break down missiles by brand and this has led to autopickup confusion reported in several places by players, both inexperienced and veterans. So until the interface issues can be revised let's not do that. -------------------------------------------------------------------------------- 8ae03cc802 | Edgar A. Bering IV | 2021-07-27 17:15:26 +0300 feat: two new quotes (hyperactiveChipmunk) Move the old very ugly thing quote to fenstrider witches (where it fits better) and put the muppet show quote on very ugly things. Closes #2043 -------------------------------------------------------------------------------- d9e24bc47f | Edgar A. Bering IV | 2021-07-27 10:26:43 +0300 docs: update the mailmap -------------------------------------------------------------------------------- 10cfe34aa0 | Edgar A. Bering IV | 2021-07-27 10:13:43 +0300 docs: two CREDITS renames -------------------------------------------------------------------------------- 6342605492 | Edgar A. Bering IV | 2021-07-27 09:30:14 +0300 docs: update the credits -------------------------------------------------------------------------------- 8dfe7f97f6 | gammafunk | 2021-07-26 23:38:42 -0500 fix: Have Overgrow fail after targeting (#2018) Targeted abilities like Fedhas' Overgrow should always allow the targeter to work before processing any failure chance. This way players can see what they might affect using the ability targeter as part of deciding whether the attempted use is worthwhile. Fedhas' other targeted abilities already work this way, so have Overgrow do the same. -------------------------------------------------------------------------------- bb1da1a3e9 | gammafunk | 2021-07-26 23:38:42 -0500 fix: Show affected walls for Overgrow (#2018) Fedhas' Overgrow ability targeter lost its can_affect_walls() override in the targeter reworks that followed positional magic. Restore this so that the targeter can display which walls Overgrow will affect. -------------------------------------------------------------------------------- 84e2d79d80 | Kate | 2021-07-27 03:31:19 +0100 Move a volcano entry out of flame cloud range volcano_tomb could still immediately drop players into a flame cloud on entry. -------------------------------------------------------------------------------- 0adfcbbeba | gammafunk | 2021-07-26 16:06:34 -0500 fix: monsters targeting of invis players (dilly) If a player goes invisible, monsters that have the player as a foe and that are sufficiently close to the player will have their throwing and launcher tracers "fuzzed" to indicate that the tracer hit. This allows monsters to sometimes shoot at invisible players and works fine if the player is reachable. But if the player isn't reachable, the logic leads to monsters performing pointless actions that can lead to monster collateral kills. For example, if the player goes invisible in front of a group of hostile monsters behind glass, monsters that can throw or fire launchers will attempt to shoot at the player, instead hitting monsters in front of them. This commit updates the monster logic in two places to prevent this behaviour. First we don't allow invisible player "hit fuzzing" to work for monster tracers if the player is not reachable under LOS_NO_TRANS. Then we require monster throwing/launcher actions to have the same "friendly monster or hostile monster with a LOS_NO_TRANS reachable foe" requirement used for spells, most special abilities, potions, and scrolls. The second change re-uses the result of a check we've already performed to prevent the tracer from being fired in the first place. The first change is still good to have, since it's not ever logical for a tracer to falsely tell a monster that an unreachable player can be hit. The logic that governs under what conditions monster take certain actions could be simplified more than I've done in this commit. Since we are close to release I want any change to be as minimal as possible, so this change will only affect throwing/launchers specifically. The other types of actions either already have the "friendly or near foe" condition described above, or do their own LOS_NO_TRANS check. I also suspect that the "friendly" portion of "friendly or near foe" condition can be dropped, since there's no reason a friendly monster would want to bypass reachability conditions. -------------------------------------------------------------------------------- 95c66c932c | Edgar A. Bering IV | 2021-07-26 19:59:57 +0300 tile: blinkbolt ability icon (CanOfWorms) -------------------------------------------------------------------------------- 84096a565d | Edgar A. Bering IV | 2021-07-26 19:45:24 +0300 tile: Shatter the Chains ability icon (CanOfWorms) Closes #2033 -------------------------------------------------------------------------------- e5760e785a | wheals | 2021-07-26 19:22:04 +0300 Remove CMD_FORCE_EVOKE_WIELDED -------------------------------------------------------------------------------- 17765e0794 | wheals | 2021-07-26 19:22:04 +0300 Change some false claims about staves They cannot be evoked (except for some few unrands) and they are on | by default, not \. -------------------------------------------------------------------------------- 643d97a57c | wheals | 2021-07-26 19:21:28 +0300 Standardize conversion of keycodes to text Only main change is that End and its variants should be properly rendered in the macro menu. Just to be safe, though, this should not be cherry-picked. -------------------------------------------------------------------------------- aa6b198bf9 | wheals | 2021-07-26 18:44:55 +0300 Allow +/- as inputs in the macro menu on Webtiles (Spaninq) -------------------------------------------------------------------------------- 9d592f0669 | CanOfWorms | 2021-07-26 09:40:12 -0400 Differentiate hydra tiles from plant tiles The shape of hydras (necks that stick out of a body) is similar to some plant tiles, so make the underbelly yellow to create contrast. -------------------------------------------------------------------------------- f74fda84f9 | Kate | 2021-07-25 23:49:55 +0100 Don't turn clear doors opaque when sealing them Closed clear doors were handled correctly, but opened ones were being turned into regular opaque doors when closing them to activate a vault warden's seal doors ability. Fixes #2024. -------------------------------------------------------------------------------- dd470a43dd | Nicholas Feinberg | 2021-07-25 14:22:19 -0700 Block wereblood heals under death's door (dilly) This check should probably be refactored in some way - I think it's duplicated in a few places. -------------------------------------------------------------------------------- 269154a5ba | Kate | 2021-07-25 22:16:43 +0100 Don't destroy cursed weapons without prompting when changing forms With a cursed holy wrath weapon equipped, trying to enter lichform would prompt the player about unequipping and destroying their weapon, but if the weapon was melded due to entering a different form first, there was no prompt when swapping from that form to lichform. Fixes #2027. -------------------------------------------------------------------------------- 3c0819f736 | Edgar A. Bering IV | 2021-07-25 22:50:37 +0300 fix: don't crash checking books for rampage -------------------------------------------------------------------------------- 8ee6c6440a | mainiacjoe | 2021-07-25 22:29:03 +0300 Mephitic Cloud --> Corpse Rot in Book of Vapours All the spells that appear in only one book and are not available in starting libraries are all level 7 or higher, except for Corpse Rot. At the same time, Mephitic Cloud is available from Turn 1 for two backgrounds, and also appears in three books. Thus with Mephtic Cloud being so easily gained, and Corpse Rot as hard to find as end-game spells, and both having a theme of noxious fumes, put Corpse Rot into the Book of Vapours in place of Mephitic Cloud. -------------------------------------------------------------------------------- e5b3285e1b | a | 2021-07-25 22:26:39 +0300 Fix typo in the manual's Missiles section This commit fixes a typo in the manual's Missiles section. The verb should be "throw" since it's being used as an infinitive. -------------------------------------------------------------------------------- d5dc72f758 | Edgar A. Bering IV | 2021-07-25 22:25:36 +0300 fix: fire fineffs after monster moves, too Closes #2036 -------------------------------------------------------------------------------- 30eb4d6358 | Edgar A. Bering IV | 2021-07-25 22:25:36 +0300 feat: increase penance for rampaging Simplify the check, only apply it to a rampaged move (or a step with the lightning scales) and always trigger the conduct. It should maybe cost more than one piety per rampaged move, but I leave that for the future. -------------------------------------------------------------------------------- 390debcb5f | Edgar A. Bering IV | 2021-07-25 22:25:36 +0300 fix: give a hasty item warning for non-armour Rampage (u/Delicious-Most5180) -------------------------------------------------------------------------------- 70c531d6f8 | Kate | 2021-07-25 20:02:47 +0100 Fix spelling A good instance where we used three distinct spellings, none of which were the apparent standard Australian English spelling. -------------------------------------------------------------------------------- aa4a0049d6 | Nicholas Feinberg | 2021-07-25 08:37:13 -0700 Embellish the changelog -------------------------------------------------------------------------------- 964c8b829e | Kate | 2021-07-24 21:29:15 +0100 Adjust some tutorial text Tweak a spellbook name and wrap an overly long line in a summary. -------------------------------------------------------------------------------- 1e78e81bf7 | advil | 2021-07-24 10:56:10 -0400 docs: changelog updates This is mostly filling in UI/options things; a few clarifications elsewhere. -------------------------------------------------------------------------------- 6e044cfa68 | Kate | 2021-07-23 05:01:48 +0100 Update hints mode Fix some typos and broken hint triggers, remove some obsolete hints, and update some out-of-date information. -------------------------------------------------------------------------------- 84f66890ac | gammafunk | 2021-07-22 22:53:24 -0500 Update the changelog through 0.27-b1-2-g8387495791 -------------------------------------------------------------------------------- 334057b17a | advil | 2021-07-22 15:50:32 -0400 fix: exclude autofight paths that can't see the target This is a solution to: https://crawl.develz.org/mantis/view.php?id=11905 https://crawl.develz.org/mantis/view.php?id=12576 In both of these cases, autofight's pathfinding gets into a trap because under various conditions it prioritizes a move that doesn't keep sight of the target along a path visible from the starting point. But, because the search is greedy, it doesn't go back and try an alternative path when this first attempt fails. Because (for whatever reason) it prioritizes diagonal moves, the setup usually involves a diagonal, but I think that switching the prioritization would lead to similar problems for straight moves. The sequencing here looks very delicate and for the most part it does seem to make do with a greedy search, so I didn't want to try messing with this. Rather, this commit introduces a check that throws out immediate moves where the current target would not be visible from. I've convinced myself that in theory this is entirely safe to do: if there's a path at all for autofight, there's a path that keeps sight of the target at every point. (And of course, potential paths that don't.) Hopefully this will hold up in practice. -------------------------------------------------------------------------------- 1ec5790e4f | Nicholas Feinberg | 2021-07-22 12:21:14 -0700 Fix webtiles display of corrosion (ShaperMC) This is duplicated in three places. TODO: FIXME -------------------------------------------------------------------------------- eb5a7e5f55 | advil | 2021-07-22 14:57:00 -0400 fix: default bind F1 to CMD_GAME_MENU The `~` binding is ok-ish for US keyboards and has some resonance with the previous binding on this key (which is now a submenu), but it's pretty non-intuitive, and the symbol typically involves a complex chord on many international keyboards. At the same time, ESC, which is a typical binding for this in other games is fairly non-viable in crawl, because it is used to clear mores and get out of menus very quickly, while being a noop at the main interface. (The qw bot even has a function where it exploits this to reliably exit menus.) This commit adds F1 as a binding for the game menu. This still isn't perfect, but is a much more likely key for such a thing than `~`. A lot of people (including myself) like to bind F1 for e.g. casting, and this is still fine; for advanced users the `~` binding still exists (or it can be otherwise rebound). Hopefully this all works across platforms, but I've tested on local tiles, console, and webtiles and mac. -------------------------------------------------------------------------------- fc94bf0d26 | Nicholas Feinberg | 2021-07-22 10:29:15 -0700 Make dancing launchers prefer ranged (gammafunk) -------------------------------------------------------------------------------- 643f2454ad | advil | 2021-07-21 17:30:13 -0400 fix: typo in comment We can count this as resolves #1988 -------------------------------------------------------------------------------- 835d75f5b3 | advil | 2021-07-21 17:02:12 -0400 fix: quiet a compiler warning (#2031) Not sure about the other warning in this report, but this one is easily fixed and the fix is probably better style. -------------------------------------------------------------------------------- 4fb8d4a8fc | gammafunk | 2021-07-21 15:24:46 -0500 feat: Reindent an Elf vault Shameless commit scumming made to diverge trunk and stable! -------------------------------------------------------------------------------- fb6a3606f8 | advil | 2021-07-21 13:32:00 -0400 feat: add a status light for inhibited regeneration If this is too blinky, it can be easily removed. But I think it might be helpful to see, and it also helps identify some corner cases (e.g. situations where a monster can't attack but has the player as a foe). -------------------------------------------------------------------------------- 9e7ac92ab0 | advil | 2021-07-21 13:32:00 -0400 fix: don't rest when regeneration is inhibited The first fruit of 05da648f! This seems to have come about when 7fb00627a50e removed the vampire check from player_regenerates_hp, perhaps under the assumption that this function was not about current regeneration. However, it is used only for current regeneration state, in order to decide whether resting is pointless. As of this change, 5 with a monster in sight but out of reach (e.g. across water) will trigger wait, not rest. Possibly it should also message, analogous to i_feel_safe's messaging. -------------------------------------------------------------------------------- e3c52671f8 | Nicholas Feinberg | 2021-07-21 10:20:09 -0700 Revert "Check for monsters, objects & features on move" Broke autoexplore somewhat - see https://github.com/crawl/crawl/issues/2026 . This reverts commit 09c7552f22266b3fe47164032a29611aefc84864. -------------------------------------------------------------------------------- 42a3d12a42 | advil | 2021-07-21 10:30:01 -0400 test: possibly fix randbook test I'm pretty sure this was relying on an uninitialized static before this commit. Unfortunately catch2 doesn't seem to work on M1 so I can't rerun locally. -------------------------------------------------------------------------------- 81a68cc532 | advil | 2021-07-21 10:02:45 -0400 fix: improve some spell data statics This applies the construct-on-first-use (v2) paradigm to a couple of key spell data statics, so as to avoid static constructor order issues. This may improve some hard-to-reproduce issues reported after a7dfd5ec23, since the Options constructor is called on static initialization but makes use of this constructor. Spell data isn't in place on the first call so this may or may not really matter, but it can at least now reliably be determined that spell data isn't set up yet. -------------------------------------------------------------------------------- 56f7456a25 | advil | 2021-07-21 10:02:45 -0400 fix: avoid static initialization of ability list This is not necessarily an ideal fix, but is aimed at preventing static initialization order issues resulting from a7dfd5ec23. After that, the constructor for the static Options object relies on the static Abilities_List object, and I suspect this is a source of crashes on some builds reported in bugs like #2010 (this bug went away, but I have no confidence that it is fixed). -------------------------------------------------------------------------------- de56a17b89 | gammafunk | 2021-07-21 00:45:20 -0500 feat: Clarify bush and briar behaviour Bushes and briar patches allow beams to pass through them unaffected, but block explosions and enchantments, which is behaviour that wouldn't otherwise be obvious to players. Document this aspect of plant physics in their monster descriptions. I don't mention the exceptions of beams from ranged Sticky Flame and Chain Lightning being blocked, as those are niche. -------------------------------------------------------------------------------- ff50d6eb01 | gammafunk | 2021-07-20 22:58:09 -0500 doc: Add a tier 1 vault demon to the mailmap -------------------------------------------------------------------------------- de9417c70f | gammafunk | 2021-07-20 22:54:09 -0500 feat: Remove `allow_dup` from a shop vault (ardl) This style of "inconvenient shop" is amusing, but less amusing the second time you get it in the same game. Remove `allow_dup`, so it only generates once per game. -------------------------------------------------------------------------------- 669cdb294d | gammafunk | 2021-07-20 22:33:34 -0500 feat: Allow spectral ego on certain weapons Currently the spectral ego is only allowed on two-handed weapons or the one-handed club base type, even for artefacts and vault-defined weapons that request the spectral ego. Yet the scroll of brand weapon bypasses this exception, allowing spectral as a result on any one-handed melee weapon, to help make that scroll more exciting. We already have the weapon property data to limit spectral to only club or staves on mundane generated items. This commit removes the handedness restriction for spectral, thus allowing it to generate on all artefact melee weapons and on vault-defined melee weapons that specifically ask for that ego. This won't increase the amount of spectral too much and makes the ego's logic consistent. It's now simply a melee-only ego that's allowed on artefacts, like other such egos, but is limited to clubs and staves for mundane weapon generation. -------------------------------------------------------------------------------- 60587a63ad | gammafunk | 2021-07-20 22:23:24 -0500 feat: Adjust monster-placing Elf vaults Most changes are to refactor syntax of recently merged Elf branch monster vaults by nicolae. We use numeric glyphs for monsters and simplify statements. A couple vaults have more significant changes, as described here: nicolae_elf_defective_weapons_storage: Instead of having various helpless and inneffective dancing weapons, rework this vault to place dancing weapons that all have some kind of permanent debuff (and hence are still "defective"), but have other aspects allowing them to still be significant threats. Break weapons up into three tiers by type of ego we'll give as well as type of debuff: fast acting chaos weapons get blindness, slower acting distortion weapons get slowness, so they'll be slower than normal speed, and we use highest quality base types for venom, but make them "damaged" (-1 to -4 enchant) and permanently corroded. The vault is now a runed door vault since it's fairly dangerous and having these weird weapons leak out into the level would ruin the theme. Not to mention that the blind weapons need to stay in a fairly confined area to be effective. It's layout has gotten a slight trim to completely reveal the loot inside. Since I worked with nicolae to re-imagine this vault, we agreed to rename it to nicolae_gammafunk_elf_defective_weapons_storage. nicolae_elf_double_double_double_trouble: This is a runed door vault, but the current layout means a player might be forced to open the door to reach otherwise disconnected areas in Elf. We like to avoid forcing players to take runed doors, and although two blade masters with two double swords is not an especially dangerous threat that would normally warrant a runed door, it's helpful for the specific theme of this vault. So mark the doors and sealed areas of the vault as opaque for connectivity purposes. Add more runed door to keep the two blademasters separated, increasing the visual theme. Upgrade one of the blademasters' double swords to either good_item or randart, thus allowing them to pose a bit more of a threat. Finally, introduce a star_item and two normal item loot pieces on both sides of the vault, giving some incentive to open the vault for those who wouldn't benefit from the weapons. -------------------------------------------------------------------------------- 979284e43a | Nicolae Carpathia | 2021-07-20 22:23:24 -0500 Update elf_deep_mausoleum based on gammafunk comments -------------------------------------------------------------------------------- ddbec97b21 | gammafunk | 2021-07-20 22:23:24 -0500 feat: Adjust some Elf entry vaults For nicolae_elf_arrival_dilemma, technically we shouldn't require passage through a runed door like this to the rest of a level, but I'm allowing it in this case. The right side of the vault is a perfectly ordinary encounter with four monsters, hence always a reasonable option for those with basic preparation for Elf. The runed door for this side fits the "border check" aspect, which allows inexperienced players to re-evaluate their decision before it's too later. The two choices feel one-dimensional, and a single high level elf feels a bit sad alone behind a runed door. So we up the runed door aspect, adding a second high level elf to the left section and two high quality loot pieces, also adding one normal quality loot item to the right section. Give this entry half weight so that it's not too common. For nicolae_elf_arrival_no_cutting_in_line, ensure we place at least two monsters in each of the two thematic groups. The odds of rolling no monsters in the orc group or no monsters in the elf group are not that small, and if either happens the vault's theme is ruined. This increases the size of each group by 1.5 monsters on-average, but the groups are only 3.5 monsters each, and the monsters used here are common for Orc and late dungeon. Some glyph and syntax cleanups for this and two other entry vaults. -------------------------------------------------------------------------------- ed5bec7572 | gammafunk | 2021-07-20 22:23:24 -0500 feat: Split up vaults in elf.des Move decorative and monster-placing vaults into their own distinct sections. -------------------------------------------------------------------------------- 2d3e3a81d9 | gammafunk | 2021-07-20 22:23:24 -0500 fix: Remove `decor` from Elf vaults The decor tag does nothing in vaults except on D:14- and in Depths, hence we don't need that tag for vaults in Elf. Also update the DES syntax document for decor to refer to the correct range where the tag applies. -------------------------------------------------------------------------------- 5ea49452ee | gammafunk | 2021-07-20 22:23:24 -0500 fix: Remove `no_dump` from a Hall of Blades vault Forgot to remove this tag from this vault in a previous commit. -------------------------------------------------------------------------------- 7cc329e542 | Nicolae Carpathia | 2021-07-20 22:23:24 -0500 Add two decor vaults to Elf. -------------------------------------------------------------------------------- 7c62198929 | Nicolae Carpathia | 2021-07-20 22:23:24 -0500 Add some more regular monstriferous vaults to Elf. Committer's Note: Squashed a commit into this one. Three of the vaults added in this commit get significant modifications in subsequent commits as part of PR #2029, namely nicolae_elf_deep_mausoleum, nicolae_elf_defective_weapons_storage, and nicolae_elf_double_double_double_trouble. -------------------------------------------------------------------------------- fba2232dec | Nicolae Carpathia | 2021-07-20 22:23:24 -0500 Add new arrival vaults to Elf. -------------------------------------------------------------------------------- 2e09723bad | Nicholas Feinberg | 2021-07-20 19:46:56 -0700 Adjust changelog Reorder, reword, fix some inaccuracies, and add highlights. -------------------------------------------------------------------------------- 1368757f42 | Kate | 2021-07-20 23:17:15 +0100 Let Spellforged Servitors cast Shock As one of their fallback spells, since the rest of the L1 conjurations are valid. -------------------------------------------------------------------------------- e58577e147 | Kate | 2021-07-20 21:32:04 +0100 Fix typo in Majin-Bo description (FizzleBang) -------------------------------------------------------------------------------- 05da648ff6 | advil | 2021-07-20 09:49:45 -0400 fix: add a debug tripwire for long delays, v2 There have been some cases of delays going on much longer than they should lately (#1757, #2037 among others) and while a few bugs have been fixed, the worst cases have resisted debugging or replication. This commit is an attempt to get more information, while at the same time protecting the player a bit better. If a rest delay exceeds 500 turns, this will trigger a crash, and if an explore delay exceeds 2k turns (1/3 of the per-level zot clock) it will also crash. These are intended to be numbers that can't be triggered on demand ever, so if I've missed something that allows this, this code should be further amended. The rest one at least would have been triggered by the case in #2037. cd13fe65733ae6d1 was missing some cases where you.running.turns_passed needs to be reset, and they should be taken care of here. -------------------------------------------------------------------------------- 0b823d0a13 | Nicholas Feinberg | 2021-07-19 13:57:28 -0700 Don't revive decorative cats (tilp) They aren't meant to be used in the actual game, only in decor vaults, and reviving them causes weird issues when they get killed (by eg krakens). Shouldn't have gotten stuck at xl 1, felids! -------------------------------------------------------------------------------- fd1010017a | Nicholas Feinberg | 2021-07-19 12:47:33 -0700 Revert "fix: add a debug tripwire for long delays" Triggering way too often. Reverting for now. This reverts commit cd13fe65733ae6d1ebf66b383617bb497fa25090. -------------------------------------------------------------------------------- cd13fe6573 | advil | 2021-07-19 13:38:18 -0400 fix: add a debug tripwire for long delays There have been some cases of delays going on much longer than they should lately (#1757, #2037 among others) and while a few bugs have been fixed, the worst cases have resisted debugging or replication. This commit is an attempt to get more information, while at the same time protecting the player a bit better. If a rest delay exceeds 500 turns, this will trigger a crash, and if an explore delay exceeds 2k turns (1/3 of the per-level zot clock) it will also crash. These are intended to be numbers that can't be triggered on demand ever, so if I've missed something that allows this, this code should be further amended. The rest one at least would have been triggered by the case in #2037. -------------------------------------------------------------------------------- 01599e1a9e | advil | 2021-07-19 13:38:18 -0400 Revert "Forbid DEBUG_TRAVEL without DEBUG_DIAGNOSTICS" Revert reason: this was disabled by default before this commit, and it's *extremely slow* to enable, so return to the disabled-by-default state. Instead of an `#ifdef`, add a comment explaining the situation. This reverts commit d8756d56bca0c83564c4a383b0931343e2ffb2e0. -------------------------------------------------------------------------------- c56fcc985a | Nicholas Feinberg | 2021-07-18 07:26:55 -0700 Fix touching typo (hardworking goddess, reeces) -------------------------------------------------------------------------------- 15f69828bf | gammafunk | 2021-07-18 00:47:19 -0500 feat: Organize elf.des and refactor functions Give elf.des section headers like we do for other DES files. Make sections for entries, normal vaults, blade entries, blade main vaults, and the elf end maps. Add a function to set standard blade monsters, since multiple maps where using a common definition. Remove `no_dump` from main blade maps, since we now have multiple vaults, not all of which use entry subvaults. -------------------------------------------------------------------------------- 8427feac8f | Nicolae Carpathia | 2021-07-17 23:25:49 -0500 Add new entry subvaults for the Hall of Blades Committer's Note: I'm not adding nicolae_blade_animated_armoury, since animated armour monsters designed to be a player ally, not a compelling hostile monster. Melee-only slow monsters are something we've almost completely removed at this point. There's not an obvious design for hostile animated armour monsters that's sufficiently unique, but if that changes, a vault like this can be reevaluated. -------------------------------------------------------------------------------- 0c1c6157e4 | Nicolae Carpathia | 2021-07-17 23:25:17 -0500 Add two new layouts for the Hall of Blades -------------------------------------------------------------------------------- 5a1362afc6 | gammafunk | 2021-07-17 20:05:18 -0500 fix: Adjust three transporter vaults again (advil) A recent report I'd seen for the vault emtedronai_trogs_sanctum showed it generating areas only reachable via its transporters, effectively sealing off access to its entrance transporter. This report lead me to make 97d24401, which put borders of floor around this vault and two others, since it seemed there was no other way to prevent these problems. However advil informs me that the problem with emtedronai_trogs_sanctum was due to it not conditionally applying its `passable` tag only for the Vaults branch. The `passable` tag was added for the Vaults layout to allow features like transporters place in Vaults rooms, but when enabled in other branches it leads to the layout generator to incorrectly think that areas inside the transporter vaults are connected to the vault entries without using a transporter. Hence 2170ac5a makes `passable` now only apply in the Vaults branch. advil also informs me that now that we can't misapply `passable`, these transporter vaults will both never generate such disconnected areas nor will passage through the transporter ever be required to reach the rest of the level, specifically because the internals of these vaults are marked with the `opaque` tag as of 97d24401. Hence this commit restores the behaviour before that commit which only applied the border of floor around these vaults in the Vaults branch; it's still necessary in that branch for them to place properly as rooms. Now the vaults will better integrate into non-Vaults levels in that they can embed properly in surrounding walls yet have their two entries properly connected to the rest of the level. Additionally, I've changed the wall types of these vaults to rock when placing in Vaults, so the layout code of that branch can correctly substitute the wall to the surrounding wall type of the level. Interestingly, this seems to allow gammafunk_its_a_trap to properly place in Vaults. In my previous testing, it always failed to place as a vaults room even though the other two vaults were able to. Finally, correctly apply the `transparent` tag to emtedronai_trogs_sanctum and fix its opaque mask to correctly cover all internal vault squares. The slightly incorrect mask was added 97d24401, but since the vault wasn't actually given `transparent`, this error wasn't seen. This commit partially reverts 97d24401. -------------------------------------------------------------------------------- d5c625afe7 | advil | 2021-07-17 15:26:21 -0400 fix: reorder currency symbols so that `$` shows in help Bug introduced in 1715c4e68; the help menu can't handle unicode keybindings and shows a number, and `$` is probably the best one to show anyways. -------------------------------------------------------------------------------- 5988178df2 | advil | 2021-07-17 15:25:07 -0400 fix: quick macro keybinding add, take 3 Unfortunately, ctrl-m is equivalent to return, and so this turns one of the standard noops (that people use to clear mores) into a menu key by accident. This third attempt moves the travel speed toggle to ctrl-t, and puts quick add on ctrl-e. I *think* this should be fine in webtiles. (Unfortunately, it does mean that windows webtiles users will need to use *t for travel speed toggle, because it seems that most windows browsers eat ctrl-t in a way that isn't easy to override.) -------------------------------------------------------------------------------- 1b087cb4c1 | Nicholas Feinberg | 2021-07-17 10:03:25 -0700 Improve slime creature messaging (nojaa, jilles) Be clearer about's going on when they merge. (Not touching unmerging yet, but that probably wants love too.) -------------------------------------------------------------------------------- 8f6b6f5ddb | advil | 2021-07-17 12:52:40 -0400 fix: simplify macro action entry (Yermak) After this commit, entering an action while doing a macro binding returns to the main macro menu (or exits in the case of quick-add), while esc gets you to the mapping menu. This reduces the keystrokes used when setting at the slight cost of keystrokes when cancelling. Two remaining issues: (i) when editing an old macro, it first brings you to the mapping submenu. This could go right into editing the action, at the cost of making the submenu c/R options harder to get to. (ii) What should this UI do on enter with a blank action? Right now this cancels, but I'm not sure this is very intuitive. Other possibilities include having this case clear the macro, and disabling enter with an empty action. A few other minor tweaks to display stuff. -------------------------------------------------------------------------------- 2170ac5abd | advil | 2021-07-17 11:32:50 -0400 fix: limit `passable` tag masking to Vaults This tag is a bug magnet outside of Vaults, because it makes it very easy to trick the builder into generating disconnected zones. In some vaults these issues had been fixed by explicitly conditionalizing the tag, but there's not a lot of use-cases outside of Vaults layouts that can't be better handled by other techniques, so simplify things on the vault designer here. I've also updated the docs to more clearly warn designers about the pitfalls. -------------------------------------------------------------------------------- 9c98e07f0c | Nicholas Feinberg | 2021-07-17 08:09:07 -0700 Decay mon breath timeout at EOT (mishima, gressup) Similarly to netted monsters, which already work this way, have monsters reduce their breath timeout after their turn instead of before their next one. That way, if you see a monster 'catching its breath' on your turn, they won't be able to use a breath weapon on you before your next turn unless they get a double turn. It's possible that other enchantments might be changed to work similarly, but for e.g. paralysis, that would be a big stabber nerf. I haven't done an audit to look for other candidates. -------------------------------------------------------------------------------- 6eef9f81b9 | advil | 2021-07-17 11:06:56 -0400 fix: move macro quick-add to ctrl-m This is now working, so I think it must have been a cache issue. ctrl-t is new tab on windows, so doesn't work so well. -------------------------------------------------------------------------------- 97d2440184 | gammafunk | 2021-07-17 00:02:43 -0500 feat: Adjust aspects of three transporter vaults For the transporter vaults gammafunk_its_a_trap, gammafunk_dig_for_victory, and emtedronai_trogs_sanctum, give these vaults a border of floor. Having connectivity require a path through the transporter frequently leads to one side of the transporter being left in a disconnected area, thus either stranding the player who travels through the vault via transporters or preventing transporter entry altogether. This is a bug in our layout code, which should ensure that these disconnected areas won't happen. Even if this were not the case, these vaults are meant to pose an optional, difficult challenge, so we shouldn't require passage through their transporters to reach other portions of the normal level. We now add no_item_gen throughout these vaults instead of only in certain sealed or trap-laden sections, since there's no reason to lock away normal level items. For gammafunk_its_a_trap, remove its placement from Spider, but allow it to place on D:14. I previously allowed it in Spider to connect sections of the cave-like layout, but as described above we're no longer requiring access through these types of vaults for normal level access. The vault's highly angular stone structure is out of place in a "natural" place like Spider. For D:14, this is an ok depth to beging exposing players to Zot traps, since it's very close to their normal generation and behind a transporter. For all three vaults, mark them as transparent and mask the vault insides as opaque. Revise glyph usage so we can distinguish between the inside and outside of each vault. Simplify and clean up some DES syntax. -------------------------------------------------------------------------------- 7cc0d9ac62 | Nicholas Feinberg | 2021-07-16 19:35:02 -0700 Remove wanderer debug code BIG oops (This made all wanderers start with two minor books, I think?) -------------------------------------------------------------------------------- 29e9f9e103 | Nicholas Feinberg | 2021-07-16 19:20:07 -0700 Add storm form tile (alex1729) And remove the old hydra form tile. RIP. -------------------------------------------------------------------------------- 2387c0671f | Nicholas Feinberg | 2021-07-16 19:19:50 -0700 Clarify spectral ego -------------------------------------------------------------------------------- d28e588067 | Nicholas Feinberg | 2021-07-16 19:08:20 -0700 Rename the Desolation entrance (Undo, ardl) To avert confusion for players who assume something ruined is unusable. I wanted to use 'unsealed gateway', but we already have 'unsealed gates', which are a bit too similar sounding. -------------------------------------------------------------------------------- 4a8006d288 | Nicholas Feinberg | 2021-07-16 18:53:10 -0700 Avert a riot (dinky) (OK Tukima launchers) Lots of weird special cases here. This might be a bit strong. -------------------------------------------------------------------------------- 51fae8af72 | gammafunk | 2021-07-16 17:32:31 -0500 fix: Place a Swamp exit in bugged saves (Sergey) The Swamp exits destroyed by eleionoma due to the issue fixed by 0d5cf04 need to be restored in affected saves, otherwise those games always crash on Swamp:1. This commit adds a save compat function _ensure_exit() that's analogous to the _ensure_entry() function used for ensuring branch entries and calls it for Swamp:1. We find whether Swamp is missing its exit, and if so, find a floor or shallow water square that's as close as possible to the first down stairs, thus helping to ensure that our exit is placed at a connected location. -------------------------------------------------------------------------------- acd6f1ce93 | advil | 2021-07-16 17:37:18 -0400 docs: update allow_extended_colours in options guide (gammafunk) -------------------------------------------------------------------------------- 52be93032c | advil | 2021-07-16 17:27:37 -0400 fix: default allow_extended_colours to true This *may* still be a terrible idea, but I'm not sure we'll find out without trying. Some of the historical reasons for the old defaults are no longer an issue, like old mac osx terminals. One remaining one is that this may decrease the default readability of ttyrecs. We'll see... -------------------------------------------------------------------------------- e1855fdbe6 | advil | 2021-07-16 16:17:54 -0400 feat: command for quick macro adding/editing This renames previous CMD_MACRO_ADD to CMD_MACRO_MENU, and adds a new command under CMD_MACRO_ADD that is a bit more true to the name. The new command jumps straight into macro editing given a specific key, and skips the macro menu. Basically, it comes full circle and very nearly replicates the pre-0.26 CMD_MACRO_ADD functionality except with an updated UI. The one difference is that it is macro only -- no keybinds. But people shouldn't be using keybinds anyways. The new command is currently bound to ctrl-t. Ctrl-m is actually free but I could not get it to work in webtiles. To rebind this, e.g. if you hate all this menu stuff I've been adding, you can do something in your options file like: `bindkey = [~] CMD_MACRO_ADD`. -------------------------------------------------------------------------------- becab4ff2c | advil | 2021-07-16 16:17:54 -0400 fix: streamline new action entry Treat new actions started by `~` and by key in the same way, jumping right into editing. To get raw entry, you can use enter to get out to the menu with a blank mapping; esc still cancels. (I'm not sure if this behavior is very intuitive and it is currently somewhat hidden, but raw key entry may also be a fairly niche feature.) Doing this required adding an on_show callback to Menu, and tweaking the title_prompt api to provide a way to detect whether text entry was cancelled or not. -------------------------------------------------------------------------------- 8c6f3a9b5b | advil | 2021-07-16 16:17:54 -0400 fix: various macro menu tweaks * fix webtiles spacing issues * fix some cases where the mapping menu wasn't pushed to webtiles * more consistent behavior after entering an action * explicit save option in the mapping menu (no behavior change, this still uses esc) * better status msg behavior -------------------------------------------------------------------------------- 3b5a371ceb | advil | 2021-07-16 16:17:54 -0400 feat: macro menu, the final form 4a6b093f0 filled a big need in macro editing, by allowing macros to be chosen from a menu, and viewed all at once. However, it was pretty incomplete in a number of ways, keeping the old message-window pseudo-ui for actual editing. This had a number of problems. 97433f2 exaggerated some of the problems of this approach -- since the menu is just used to pick which macro to edit, there's a lot of keystrokes to restart the process if you want to edit more than one at once, or select the wrong one, etc. This commit attempts to finally provide a coherent macro editing UI. * Editing individual mappings is now done via popus from the main macro edit menu. All of the message-window code has been converted to Menu-based code. Text entry uses a generalized version of the title_prompt input box previously only used for spell search. Hopefully most aspects of this will be much more convenient than the old approach. * To make it easier to use this menu with arrow keys, several meta-functions have also been Menu-ified. * Deleting individual mappings is possible from the main list. * Macros vs the various keymap modes are now handled within the menu; getting at keymap editing is a bit hidden to keep people from preferring those over macros. (Basically every "this key doesn't work" report I've run across was someone using a keymap instead of a macro.) * key hints throughout these menus have been (I hope) improved from the message window version. * This UI has a proper help screen. Main TODO that I am aware of: it would be nice to show a cursor when editing in local tiles / console. (Webtiles is fine.) Some subsidiary stuff: * The `Menu::title_prompt` API has been massively improved so that it works in webtiles in a general way, and setting a custom prompt always works. * min Menu width now (sort of) works in webtiles * various minor tweaks / bugfixes to menu code (including some weird stuff with spell search) -------------------------------------------------------------------------------- 0d5cf0409e | Nicholas Feinberg | 2021-07-16 10:10:34 -0700 Stop eleios from destroying the world Very big oversight in 450c7e4133f94db. -------------------------------------------------------------------------------- ad902ab807 | Nicholas Feinberg | 2021-07-15 21:32:23 -0700 Fix Roxanne books (Yermak) Roxanne wants her statue form! -------------------------------------------------------------------------------- 38290d930c | Nicholas Feinberg | 2021-07-15 21:32:11 -0700 Tweak book of iron description Maybe this is a little better? I think there's still room for improvement. -------------------------------------------------------------------------------- 2c003e96b8 | advil | 2021-07-15 22:49:08 -0400 feat: unhide staff skills in skill menu (PleasingFungus) This extends 4390dbc5be0fb to make staff spell school skills show up as trainable by default when carrying a staff that involves such a skill. -------------------------------------------------------------------------------- b82cc645e0 | advil | 2021-07-15 22:38:43 -0400 fix: clarify dj staff wording As far as I know, melee damage is the only thing affected, so clarify the wording so it doesn't confuse the issue with respect to spell school enhancement. -------------------------------------------------------------------------------- 6b5ea614c1 | advil | 2021-07-15 22:25:06 -0400 feat: explicitly mark dj staff limitations I'm still not actually sure this is the best solution to this interaction, but as long as this interaction exists, make it clear. -------------------------------------------------------------------------------- 8cdb131401 | Kate | 2021-07-15 23:38:06 +0100 Don't start Recite's cooldown until ending recitation And decrease the cooldown duration, to clean up the status light display. -------------------------------------------------------------------------------- 299f9947c5 | Kate | 2021-07-15 22:00:23 +0100 Fix a description typo (Goratrix) -------------------------------------------------------------------------------- 458e30bab1 | Kate | 2021-07-15 21:29:30 +0100 Add Nemelex card ability info to the quiver -------------------------------------------------------------------------------- 57f10a385c | gammafunk | 2021-07-14 20:18:56 -0500 feat: Adjust the due_jungle_book Lair end vault We don't have a lot of data for the new version of this map, and its newness means players are more likely to make mistakes, but early indications are that people die to it in practice a lot. It does feature a somewhat higher monster count as well as some legitimately nasty monsters not commonly seen in Lair. This commit reduces the monster count by about 20% and fixes up portions of the layout. For monsters, we reduce the bands spawning in the major combat areas from 6 monster total on-average to 3. That way the focus is on the final necromancers in the two end chambers. We also reduce the random spawns throughout the map, concentrating them on the earlier entryway area, since none of the bands spawn there. That way the map is less likely to be empty until one of the bands are encountered. For layout, we remove the many additional entry connectors, since just one is necessary. The additional ones likely increased the number of vetoes. This might increase the chance that the vault is located at the end of a passage, but this is fitting for the "spooky jungle castle" theme the map now has. -------------------------------------------------------------------------------- c03b058e8b | gammafunk | 2021-07-14 19:33:27 -0500 feat: Rework parts of a Lair ending For gammafunk_lair_ancient_temple, rework the way the temple is "ruined", tweak monster placement and loot, and simplify syntax. For layout, we greatly simplify the crumbled wall sections. Each of the three walls now has an independent 50% of being "collapsed". The collapse wall sections avoid clumping the "broken" wall pieces together and add dry land to facilitate their usage by players. We add an inner chamber with possible door to house the loot and provide more structure. Introduce very light ruining of the fixed wall portions and chamber to prove a few small entrances into the temple. Finally, we introduce random dry land throughout the map to give players better footing while fighting closer to and inside the temple. For monsters, we reduce the average monster count by about 33%. The map was not extreme in terms of monster placement, but it's been the Lair end with the most kills by a wide margin for a long time, in large part due to how effective the merfolk avatar is at punishing incautious players. We now place a couple more of the Shoals themed threats on average, since those were somewhat underused. Add snapping turtles to the list of Shoals monsters, which will help prevent an overall increase in wind drakes; those seem to pose the biggest challenge of the non-avatar monsters in the Shoals set. For the Lair natives, add blink frogs and steam dragons, and remove the very trivial water moccasins. For loot, we replace some of the normal items with thematic items that include 2-4 good loot potions and a single water/Shoals themed item. The water/Shoals themed item includes throwing nets, trident weapons, and phial of floods, and small chances for the three unrands Captain's Cutlass, Trident of the Octopus King, and a ring of the Octopus King. -------------------------------------------------------------------------------- 0e7b3fb1d2 | gammafunk | 2021-07-13 20:36:17 -0500 feat: tweak the abyssal woods Lair ending For hellmonk_lair_end_abyssal_woods, slightly adjust the monster set, introduce chances to have shortcut entrances, tweak the use of demonic trees, add some use of floor tiles, and clean up DES syntax. For the monsters, introduce a 5th monster tier below the "boss" tier on glyph 6. Move the small chance of large abominations formerly on 6 to this new 5 glyph, which it now shares with ugly things. The latter are appropriate to the map, and although they are common enemies later, we don't overuse them here. Then 6 remains dedicated to thrashing horrors, whose numbers we constrain somewhat. Now only 2-4 of those can now place, with an average of 3, since we only place these in the final chamber, and we place a few 5 glyph monsters throughout the map. For layout, introduce two potential shortcuts, each with an independent 33% chance, one that leads something part the starting area and another on the far side that leads in close to the final chamber. Instead of a forest of all demonic trees, use mostly regular trees, gradually introducing demonic trees at an increasing rate until the final chamber, which uses all demonic trees. Also add Abyss-themed floor tiles in this final chamber. Adjust a few loot locations due to the new shortcuts. Closes #1967. -------------------------------------------------------------------------------- 214d61ee58 | hellmonk | 2021-07-13 20:36:17 -0500 Abyssal woods Lair end Adds a new lair end vault based on enchanted_forest, but makes use of demonic trees and an abyssal monster set. Thrashing horrors are the big threat here, so adjusting the number of those would be the easiest way to modify difficulty. Committer's Note: The subsequent commit reworks parts of this map. -------------------------------------------------------------------------------- 57bb12a6e0 | Kate | 2021-07-14 00:27:33 +0100 Remove some food leftovers -------------------------------------------------------------------------------- bdbb211e1e | Kate | 2021-07-14 00:23:06 +0100 Don't let Folly's brilliance stack with the potion To make its behaviour slightly clearer, since as originally implemented the MP reduction didn't stack but the enhancer did. Its permabrilliance is now technically separate from regular Archmagi, so would stack with it if a non-body-armour source of Archmagi existed. Potions of brilliance are marked as temporarily useless with Folly equipped. -------------------------------------------------------------------------------- 622f6405ea | Kate | 2021-07-13 22:25:26 +0100 Rework the robe of Folly (hellmonk) Make it grant perma-brilliance (archmagi and halved spell costs), increase its intelligence and enchantment bonuses, but have it set your willpower to zero. -------------------------------------------------------------------------------- e1afea27ad | Kate | 2021-07-13 22:23:35 +0100 Update unrand descriptions and inscriptions Move information on special unrand features to DBRAND and DESCRIP entries where possible, so that it's all grouped together with standard item properties. This allows shortening the actual descriptions, and making room for them to be primarily focused on flavour and more general descriptions of the item's abilities. -------------------------------------------------------------------------------- 492c89284f | Kate | 2021-07-13 17:57:47 +0100 Adjust weapon brand descriptions For consistency and brevity - it's not necessary to explicitly spell out that fire damage deals more damage to things with fire vulnerability in this single description of one source of fire damage, for example. -------------------------------------------------------------------------------- f8a67e7463 | Neil Moore | 2021-07-13 00:05:33 -0400 Correct Abyss feature placement check. Instead of checking whether a potential feature was surrounded by seven or more solid cells, the old code checked whether the previous feature was solid and surrounded by seven or more cells. -------------------------------------------------------------------------------- d3c00ef09d | Neil Moore | 2021-07-12 23:14:56 -0400 Fix quote formatting. -------------------------------------------------------------------------------- e6b0c8b507 | hellmonk | 2021-07-12 18:42:25 -0400 Adjust snake endvault monsters Many snake end vaults placed large numbers of monsters (50+ on average, with 90 average monsters in the most extreme case) with low randomization. This commit reduces snake end vault average monster counts to ~35-40 for most vaults and randomizes formerly static monster counts. Additionally, two snake rune vaults that previously placed twice as often now share the standard vault weight. -------------------------------------------------------------------------------- 3eddc1d3d3 | Aliscans | 2021-07-12 23:10:51 +0300 Let the player create both Maggie and Margery in wizard mode. Wizard mode let you bypass the "has this unique been generated?" check, but not the "has the other unique been generated?" one. Instead of the second check, this change has the game mark Maggie and Margery as having been created whenever either one is. [ Committer's note: Moved the class to its own header. If more "storyline uniques" are generated this should be further datified, but the type doesn't belong in player.h regardless. Closes #1884 ] -------------------------------------------------------------------------------- e3ff63456f | Nikolai Lavsky | 2021-07-12 22:08:17 +0300 Don't allow cancelling hostile Battlespheres -------------------------------------------------------------------------------- e30191f0e2 | Aliscans | 2021-07-12 20:35:58 +0300 Fix the "stat zero" warnings for rings. If you say no to a "stat zero" prompt for wearing a ring, don't remove your existing ring. -------------------------------------------------------------------------------- 3b8667add3 | Aliscans | 2021-07-12 20:35:58 +0300 Fix the "stat zero" warnings for amulets. If you put on an amulet, having not previously been wearing one, check for stats below 1. If you say no to a "stat zero" prompt for wearing an amulet, don't remove your existing amulet. -------------------------------------------------------------------------------- b3396a012b | Aliscans | 2021-07-12 20:35:58 +0300 Fix the "stat zero" warnings for armour. If you say no to a "stat zero" prompt when changing your armour, don't remove your existing armour. Don't give a "stat zero" prompt if wearing your current armour at the same time as a new piece in the same slot would give a stat below 1. Give a "stat zero" prompt if wearing some new armour alone would give a stat below 1. -------------------------------------------------------------------------------- cf74c853f4 | Aliscans | 2021-07-12 20:35:58 +0300 Fix the "stat zero" warnings for weapons. Remove the second MSG_OK from when you say no to a "stat zero" prompt as you wield a weapon. Don't give a "stat zero" prompt if wielding your current weapon at the same time as a new one would give a stat below 1. Give a "stat zero" prompt if wielding a new weapon alone would give a stat below 1. -------------------------------------------------------------------------------- 09c7552f22 | Aliscans | 2021-07-12 20:27:53 +0300 Check for monsters, objects & features as soon as you move. (#1936) The game previously only reported which monsters had "come into view" when a monster shouted or the player was ready to start a turn. This interacted badly with ABIL_WU_JIAN_WALLJUMP (for one), as you move to a new location as part of the turn, and both you and the monster can act before the next "start of turn" rolls around. Calling update_monsters_in_view() from moveto_location_effects() should make the "comes into view" message the first one you see for a monster. I also call check_for_interesting_features() so that nearby objects and features are announced at the same time. Co-authored-by: Aliscans -------------------------------------------------------------------------------- 25c1220f7b | hellmonk3 | 2021-07-12 13:03:15 -0400 place water under goliath frogs in frog pond -------------------------------------------------------------------------------- b5d4ac33de | hellmonk3 | 2021-07-12 12:56:04 -0400 modify frog_pond Add a chance to place goliath frogs and reduce the notoriously high monster density by about 25%. -------------------------------------------------------------------------------- db44c70a1d | Kate | 2021-07-12 17:33:59 +0100 Fix a vault loot definition -------------------------------------------------------------------------------- 81e557bc32 | Edgar A. Bering IV | 2021-07-12 10:31:44 +0300 vaults: Adjust the despoilered loot in portals For the most part, change the loot lists to use standard dgn.* constants instead of identifying everything. The identification in early portals would eat up a large portion of the remaining item ID game, which would be a shame. Usingn the dgn.* constants does mean that portal loot has a different distribution than the floor, but it's not a vault by vault absurd spoiler. Closes #1855 -------------------------------------------------------------------------------- f0cfdccd6e | hellmonk | 2021-07-12 10:09:28 +0300 vaults: Identify non-random potion types in many vaults This was an extremely obtuse, though little-abused, spoiler. -------------------------------------------------------------------------------- 98b9705cb8 | nlavsky | 2021-07-12 09:25:31 +0300 Remove a couple of obsolete descriptions (#2022) -------------------------------------------------------------------------------- ca18f49f40 | gammafunk | 2021-07-12 01:05:28 -0500 Rework the Elemental Staff guarded unrand vault For dilly_guarded_unrand_elemental_staff, rework monster placement and the decorative chambers, and reorganize and simplify DES syntax. We extend the placement range to include D:8, and have difficulty scaling conditions cover each of D:8-11, D:12-13, and D:14-15 separately. The monster sets are adjusted to have more depth-appropriate threats at each range, with a low-tier elemental set for each element that doesn't go out of depth and a shared moderate out of depth tier. Monster counts also scale with depth. The boss is modified to be a depth-appropriate monster wielding the Elemental Staff. For Dungeon we increase from deep elf pyromancer, to deep elf zephyrmancer, to tengu reaver. For Elf and Depths we used the master elementalist vault-defined monster already used by mu_elemental_laboratory. The decorate elemental areas have been simplified to just use appropriate clouds and not use decorative monsters. There aren't appropriate conjured monsters for each element, and the vault already nicely communicates the elemental theme with the decor and actual monsters. Closes #2021. -------------------------------------------------------------------------------- 89162da0c7 | dilly | 2021-07-12 01:04:08 -0500 A guarded unrand vault for the Elemental Staff Committer's Note: Reword commit message. The subsequent commit revises many aspect of this vault. -------------------------------------------------------------------------------- 491fb513fc | gammafunk | 2021-07-12 01:01:19 -0500 Rework the master elementalist vault The vault mu_elemental_laboratory features a vault-defined "master elementalist" monster that's themed as having mastered the four forms of elemental magic. However this monster doesn't pose a very good threat, certainly not one worthy of a having a vault-defined monster. The vault itself is not especially challenging either. This commit reworks the monster and the associated vault to pose a greater challenge and give greater rewards, reworking it into a rare runed door vault. The master elementalist gets an HD bump to 18 and boasts a formidable array of spells: Ozocubu's Refrigeration, Lehudib's Crystal Spear, Chain Lightning, and Fire Storm. It still has Haste, but loses Blink for Repell Missiles, since the former doesn't work great for its terrain in this vault. The monster attempts to generate with the Elemental Staff, thus giving him formidable elemental resistances. If the Elemental Staff is unavailable, it instead gets a staff of air, and its robe gains the resistance ego, thus it will always have at least rF, rC, and rElec. The master elementalist is a formidable spellcaster, but it doesn't have especially good HP or other defenses, so players with good resistances who act quickly can take it on. The rest of the vault monsters have been given a rework to pose a serious threat for both Elf and Depths, and the elemental-themed terrain has been enhanced. Loot includes randbook for one of each of the four elemental schools, as well an artefact jewellery, an enhancer staff, and a manual, all theme from one of the elemental schools. The master elementalist monster definition is moved to a function, since it will be re-used for a forthcoming guarded unrand vault. -------------------------------------------------------------------------------- 1e82c303ef | Kate | 2021-07-11 03:04:27 +0100 Remove mechanical traps from Ossuaries This was the last place they existed outside of Sprints, and even with vaults that were originally designed around them they didn't really fulfil any real purpose. Some of the vaults keep alarm and net traps which might have more relevant effects, but all of the plain damage traps could almost always be easily avoided, ignored or rested off. -------------------------------------------------------------------------------- 90fbb72469 | Edgar A. Bering IV | 2021-07-10 21:31:41 +0300 feat: a more electrifying storm fist (ardl) -------------------------------------------------------------------------------- 5d1bdbc639 | wheals | 2021-07-10 21:25:28 +0300 Add a quote for Storm Form -------------------------------------------------------------------------------- c46b4539cf | Edgar A. Bering IV | 2021-07-10 12:36:07 +0300 fix: a doubled word (FizzleBang) -------------------------------------------------------------------------------- 1038ab4fd7 | gammafunk | 2021-07-09 21:15:56 -0500 Simplify a lua test and reindent I'm not sure if this test needs to exist as a standalone test given our existing map connectivity checks, but so long as it does exist, it needs to properly ignore any shoals encompass maps for the branch end. A previous fix to the dlua API allows the existing code to work. This commit just simplifies its logic and reindents. Closes #2003. -------------------------------------------------------------------------------- 4b6fb3c526 | gammafunk | 2021-07-09 21:15:56 -0500 Fix the return value of a dungeon lua API method For vault placement lua objects, have orient() return a string with the name of the orientation instead of returning the relatively useless raw enum value. -------------------------------------------------------------------------------- d9be06fd8e | hellmonk | 2021-07-09 21:15:56 -0500 Fix a shoals lua test -------------------------------------------------------------------------------- 1d15788f7f | hellmonk | 2021-07-09 21:15:56 -0500 Two new encompass Shoals rune vaults shoals_end_hellmonk_lost_city: A ruined city at the bottom of shoals, feat. sphinxes and minotaurs. shoals_end_hellmonk_storm_palace: Features wind and water enemies, merfolk, and a storm dragon or titan. Committer's Note: Squashed commits and cleaned up and combined commit messages. -------------------------------------------------------------------------------- 1261f788d9 | nicolae-carpathia | 2021-07-09 22:14:23 -0400 Merge pull request #2011 from crawl/nicolae-quotes-0721 Add new quotes to the Crawl quotes list -------------------------------------------------------------------------------- 7b03791ad5 | Nicolae Carpathia | 2021-07-09 22:05:40 -0400 Add new quotes to the Crawl quotes list Improve the Crawl quotes list, with a diverse assortment of choice quotes from such sources as Mary Shelley, Ovid, Hesiod, T.S. Eliot, John Milton, DMX, and ADMIN. -------------------------------------------------------------------------------- c8121b24ce | Edgar A. Bering IV | 2021-07-09 20:31:40 +0300 fix: fix the previous fix -------------------------------------------------------------------------------- f355649ca4 | Edgar A. Bering IV | 2021-07-09 20:20:07 +0300 fix: highlight gozag gold blue in webtiles under distraction aura Closes #1691 I don't claim to fully understand CSS inheritance, but it seems like having a separate block for #stats_gozag_gold is unnecessary. -------------------------------------------------------------------------------- 1ef64ffb57 | Edgar A. Bering IV | 2021-07-09 19:39:26 +0300 fix: correct capitalization of Storm fists -------------------------------------------------------------------------------- b01f110dc7 | Edgar A. Bering IV | 2021-07-09 19:32:17 +0300 fix: correctly sum a geometric series The probability display for pacify chances was not the correct probability computation. -------------------------------------------------------------------------------- 8568cbafd6 | gammafunk | 2021-07-09 10:40:57 -0500 Rework a transporter vault The vault gammafunk_worm_tunnel is a memorable challenge, but it's conspicuously large for a challenge vault of this type. This commit drastically reduces its size, slightly changing layout and adjusting swamp worm placement slightly so it remains a significant challenge. It also adapts the vault to place in earlier dungeon and Lair, using net traps instead of Zot traps with an additional miasma cloud generator before D:14. The net traps are far less lethal than Zot traps, but still trap players, give the worms more opportunities to slurp. The additional miasma generator near the exit chamber door is used when when net traps are used to slow down a player using a blink scroll a bit more than a net trap at that location would. When Zot traps are used, a player doing this must run the risk of blinking onto a Zot trap, so a trap there is appropriate. Loot and additional worm placement is revised to scale better with placement depth. We use trees in Swamp so that this vault better fits in with the surrounding layout. I opted against using trees elsewhere to minimize the use of fire magic to break into the vault. In Swamp we're a bit happier to let fire magic take over the place. -------------------------------------------------------------------------------- 5dd8012253 | Nicholas Feinberg | 2021-07-09 07:41:10 -0700 New Holy Roller title (PF (particleface)) Palentonga Invo 27 with any good god. -------------------------------------------------------------------------------- 2aaa0cc67b | Kate | 2021-07-09 02:32:09 +0100 Adjust randomisation in some kennysheep vaults ks_random_setup is used in a number of vaults to heavily randomise various features, but the randomisation of water in particular could have some extremely strange results in certain vaults, with large pools being replaced with huge numbers of statues. Instead only allow water to be substituted for floor, lava, or trees (this also has the bonus of making the behaviour match how the function's comment claims it works). -------------------------------------------------------------------------------- 99fd57bada | advil | 2021-07-08 17:25:22 -0400 fix: avoid a crash on upgrading randbooks after ca9b790695f0 Randbooks don't have artefact props, and ca9b790695f0 added some explicit checks for this. Most code is careful about this, but there were a bunch of fairly old save compat checks that were not. It probably would be fine to loosen up the artefact_property check, but it's also easy to prevent the call for the save compat cases. I've made the artefact_property check more explicit as well, so that it might be easier to guess what's going on here. -------------------------------------------------------------------------------- 29bd1443cf | Edgar A. Bering IV | 2021-07-08 23:11:33 +0300 docs: update credits -------------------------------------------------------------------------------- 8a69ca93ff | Zhang Kai | 2021-07-08 23:09:16 +0300 Update unident.txt Add translation. 增添翻译。 [ Committer's note: Also removes deck of cards description, as those no longer appear as items in game. Closes #1948. ] -------------------------------------------------------------------------------- bfabb6706f | Zhang Kai | 2021-07-08 23:09:05 +0300 Create clouds.txt Add translation. 增添翻译。 Closes #1945 -------------------------------------------------------------------------------- d2886d99c2 | Zhang Kai | 2021-07-08 23:09:04 +0300 Update species.txt Add translation. 增添翻译。 [ Committer's note: Did not include the kobold translation which references eating so was based on an old version. Closes #1900. ] -------------------------------------------------------------------------------- f492b14eaa | Zhang Kai | 2021-07-08 23:08:21 +0300 Update cards.txt Add translation. 增添翻译。 [ Committer's note: Did not include the Foxfire and Shaft translations, the former was based on an outdated description, the latter has been removed. Closes #1895 ] -------------------------------------------------------------------------------- 6a8ace0863 | advil | 2021-07-08 14:50:40 -0400 feat: clickable game menu access for local tiles (PleasingFungus) This also removes the player tile editor from the system toolbar, and simplifies the save game menu option by using CMD_SAVE_GAME_NOW. -------------------------------------------------------------------------------- 97433f2c34 | advil | 2021-07-08 14:50:40 -0400 feat: add a game menu This commit introduces a serviceable in-game menu of the sort you might expect in games that aren't 20 year old open source roguelikes. It's possible that some people will hate this nod to modernism, but I think it's actually kind of useful, and helpful to new players. Will take suggestions on what should or shouldn't be here. This also may be a useful place to get to a hypothetical future in-games options editor. Unfortunately, I don't think it's a great idea to put this on ESC on the default keybinding, since that has for so long been a noop when at the main game UI. So for now it replaces macro editing on `~` (and hitting `~~` brings you to the macro editor). For tiles, this commit reuses existing tiles (partly drawing on ones for the local tiles system toolbar, which has some functionality overlap with this menu). Some of these might benefit from artist attention. -------------------------------------------------------------------------------- 1715c4e68f | advil | 2021-07-08 09:50:10 -0400 feat: try to map more currency symbols to CMD_LIST_GOLD I am not sure whether this will (a) build on every platform, or (b) work on every build target. When testing on a US keyboard layout on mac, I can consistently get these to work on console, but not on the other two. However, I think this is because I need to enter them as complex chorded keystrokes involving number keys, where local tiles number key processing interferes. Not sure what's happening in webtiles at all, but on a US layout these definitely don't work for me. We'll see what, if anything, happens on other layouts. -------------------------------------------------------------------------------- 3203f140b7 | Edgar Bering | 2021-07-08 03:16:01 -0400 feat: further reduce book spawns They still feel overabundant. A previous commit had pulled them back some, and metioned that further triming could be warranted. -------------------------------------------------------------------------------- 47ed6a6988 | dicedlemming | 2021-07-08 08:54:56 +0300 Update mutation-data.h (#2019) The spell school it improves is Hexes. The Book of Maledictions was the starter Hex book, but Hex is the spell school that gains power. "Power" is also the terminology used on items that do similar things like Staff of Air, ie "increases the power of air spells" -------------------------------------------------------------------------------- 9d6fb14e67 | gammafunk | 2021-07-07 14:39:02 -0500 feat: Rework a monster float vault (again) This commit finishes aspects of gammafunk_indiana_jones I wasn't able to do in the last commit. It reworks the final chamber to feature lindwurms safely protected from fire clouds while still having lava snakes, putting the fire cloud machines on the lava directly. It also adds a Tomb theme for D:14- and Spider featuring death scarabs and spectrals in the final chamber. Loot, monster, and trap placement progression with placement depth is now consistent and should pose a nicely scaling challenge and reward for all levels. Other slight tweaks have been made to the layout to more consistently apply the visual theme, including statues and plant "overgrowth" in the starting area, as well as statues in the final chamber. All doors inside are runed doors, which is the best balance between UI and preventing spoilers. -------------------------------------------------------------------------------- 450c7e4133 | Nicholas Feinberg | 2021-07-06 20:33:37 -0700 Make eleios live in harmony with nature Instead of destroying trees, make them move adjacent. This avoids weird issues caused by terrain destruction, ensures they have a tree nearby to do woodweal magic with, and also feels nicely thematic. -------------------------------------------------------------------------------- f0d5c502f9 | Kate | 2021-07-07 01:43:54 +0100 Let fallback misc acquirement create Xom chesspieces Since every misc item is equally redundant at that point, there's no reason for them not to be included. -------------------------------------------------------------------------------- 2ba4aa32ac | Kate | 2021-07-07 01:26:16 +0100 Fix a compiler warning (geekosaur) -------------------------------------------------------------------------------- f8f22f7954 | Edgar A. Bering IV | 2021-07-07 00:16:14 +0300 fix: correct a typo (#1988) -------------------------------------------------------------------------------- 9ca5906e5d | Edgar A. Bering IV | 2021-07-07 00:12:49 +0300 fix: guarantee all potion petition sets are non-empty Closes #1996 -------------------------------------------------------------------------------- 2c4abef907 | 4Hooves2Appendages | 2021-07-06 23:59:18 +0300 Second Antaeus quote (#1965) Add second Antaeus quote. -------------------------------------------------------------------------------- 8390803364 | Alexei-Barnes | 2021-07-06 23:57:35 +0300 Removed dead code ranged_attack::calc_to_hit (#2001) This method calls the base and then returns the result. This can be achieved by simply not overriding the base method. I believe this was missed during editing because of the conditional in the method, however, since this conditional just returns the same result, it is obsolete. Co-authored-by: root -------------------------------------------------------------------------------- dd09596130 | Edgar A. Bering IV | 2021-07-06 23:48:45 +0300 fix: end engulf upon polymorph Closes #1935. Polymorph is described as the monster evaporating and reforming, so the lore solution to this bug of "you are now engulfed by flesh", while terrifying, doesn't quite fit. -------------------------------------------------------------------------------- 4e304d196c | Edgar A. Bering IV | 2021-07-06 23:24:11 +0300 fix: don't fire fineffs at beam end (12547) In addition to turning monster explosions into fineffs, 0.26-a0-844-g3dd439832f added fire_final_effects to bolt::finish_beam. This broke a long-time assumption in many spells that use the bolt struct creatively and possibly fire several bolts: that final effects (e.g. death channel spawns) were fired only after all beams were complete. The bug in the subject line was one example, similar behaivors could be found with ignition, starburst, imb and maybe more. -------------------------------------------------------------------------------- 57d10ac81f | Edgar A. Bering IV | 2021-07-06 23:24:11 +0300 text: clarify that dream dust is visual (12529) -------------------------------------------------------------------------------- 61de9534bc | Edgar A. Bering IV | 2021-07-06 23:24:11 +0300 fix: patch a tree burning information leak (12548) Resolves an XXX, but it might be better if Fedhas just prevented you from starting forest fires. -------------------------------------------------------------------------------- 763157803f | Kate | 2021-07-06 17:54:59 +0100 Don't allow cancelling hostile Malign Gateways -------------------------------------------------------------------------------- 2674c19aa4 | Edgar A. Bering IV | 2021-07-06 19:47:31 +0300 fix: clear engulf on monster move (12566) -------------------------------------------------------------------------------- 0d460d363a | Edgar A. Bering IV | 2021-07-06 19:37:08 +0300 feat: make autotravel slightly less cautious (12559) 0.27-a0-234-g56efc2da1b made autotravel avoid stepping next to either an unknown square or a currently unseen known non-wall square if possible. The unknown behavior is good, the unseen but known is more debatable in the days of no wandering spawns. -------------------------------------------------------------------------------- 18c06f7514 | Edgar A. Bering IV | 2021-07-06 19:26:11 +0300 fix: guard a teleport closet (12564) -------------------------------------------------------------------------------- 2ff873f930 | Edgar A. Bering IV | 2021-07-06 19:24:39 +0300 fix: don't shatter conjured monsters (12552) -------------------------------------------------------------------------------- 5102b24f49 | Edgar A. Bering IV | 2021-07-06 19:06:50 +0300 fix: adjust spacing in cloud descriptions (12570) -------------------------------------------------------------------------------- 3d396884e3 | Edgar A. Bering IV | 2021-07-06 19:01:00 +0300 fix: prompt for god switching at a faded altar (12580) -------------------------------------------------------------------------------- 0645571d10 | Edgar A. Bering IV | 2021-07-06 18:51:37 +0300 fix: don't trigger the staff of battle in rude situations (kate) -------------------------------------------------------------------------------- f3ba162646 | Edgar A. Bering IV | 2021-07-06 18:42:49 +0300 fix: prevent extraneous commas in an inscription (12612) -------------------------------------------------------------------------------- 7f483be983 | Edgar A. Bering IV | 2021-07-06 18:40:12 +0300 fix: bolt and arrow uselessness checks (kate-, Yermak) -------------------------------------------------------------------------------- d41220b2a5 | Edgar A. Bering IV | 2021-07-06 18:29:17 +0300 text: adjust a command description -------------------------------------------------------------------------------- 2081246efe | Edgar A. Bering IV | 2021-07-06 18:03:10 +0300 fix: process ring unequips when sacrificing hand (12587) This adds a bit of a special case to avoid charging the player a removal penalty if they keep the ring on because of the sacrifice swap hand/tentacle. A simpler solution would be to always impose the swap penalty, but this would come at the cost of adding more prompts to sac hand for special cases. This is cleaner and bothers the player less. -------------------------------------------------------------------------------- 0bd348349d | Edgar A. Bering IV | 2021-07-06 18:03:10 +0300 fix: abort Yred animate dead when useless (12588) -------------------------------------------------------------------------------- 07712775d2 | Edgar A. Bering IV | 2021-07-06 18:03:10 +0300 fix: don't retaliate against your reflection (12596) -------------------------------------------------------------------------------- 51990a9c54 | Edgar A. Bering IV | 2021-07-06 18:03:10 +0300 fix: sequence holy word application (12600) -------------------------------------------------------------------------------- b3c598c8fe | Edgar A. Bering IV | 2021-07-06 18:03:10 +0300 fix: prompt when summoning would be a bad plan (12602) Previously we warned the player about summoning with OTR up, but we should really check for bog and vortex too. If this results in a profusion of prompts rude_stop_summoning prompt can be changed to take an optional pal representative and made a bit smarter, but I expect that this change won't generate very many more prompts, given the non-overlap of spell schools. -------------------------------------------------------------------------------- f13327c4b8 | Edgar A. Bering IV | 2021-07-06 15:17:28 +0300 fix: mark arrows and bolts useless for one-handers (12608) -------------------------------------------------------------------------------- b642d533b8 | Edgar A. Bering IV | 2021-07-06 15:06:35 +0300 fix: don't clua crash on randbooks (12508) Throughout the codebase arterfact_property is only called on items satisfying its opening asserts. With one exception, artprop in the Item metatable in clua. The ticket suggested modifying artefact_property. Since tripping those asserts indicate a possible missuse, this commit makes the clua function appropriately robust. -------------------------------------------------------------------------------- d9270de0a6 | Edgar A. Bering IV | 2021-07-06 15:00:23 +0300 fix: respect use_animations for monster upheavals (12582) -------------------------------------------------------------------------------- 88c68e56d1 | Edgar A. Bering IV | 2021-07-06 14:49:42 +0300 fix: autoexplore over bogs while flying (12553) -------------------------------------------------------------------------------- a6938257b9 | Edgar A. Bering IV | 2021-07-06 14:40:09 +0300 fix: ignore immune allies in cloud tracers (12558) -------------------------------------------------------------------------------- 887aaaf34d | Edgar A. Bering IV | 2021-07-06 14:24:29 +0300 fix: don't consider resisted electricity harmless (12560) For self-targeting beams this warns the player about self damage. A bug for over a decade! -------------------------------------------------------------------------------- 0648b932ec | Edgar A. Bering IV | 2021-07-06 14:02:03 +0300 fix: be more accurate when describing melding (12583) Sorry for leaning harder into the XX advil. -------------------------------------------------------------------------------- e9f228fa16 | Edgar A. Bering IV | 2021-07-06 12:00:22 +0300 fix: actually check battlesphere spell schools -------------------------------------------------------------------------------- 6df09b6f62 | Edgar A. Bering IV | 2021-07-06 11:36:23 +0300 fix: vaults transparency (12591) -------------------------------------------------------------------------------- 3d13938747 | Edgar A. Bering IV | 2021-07-06 11:04:50 +0300 docs: update credits -------------------------------------------------------------------------------- 157b2762af | Edgar A. Bering IV | 2021-07-06 11:00:46 +0300 fix: battlesphere triggering behavior (12598) -------------------------------------------------------------------------------- 4244d9059e | Edgar A. Bering IV | 2021-07-06 10:44:21 +0300 fix: alphashops typo (12613) -------------------------------------------------------------------------------- 426ee5db0f | Edgar A. Bering IV | 2021-07-06 10:43:29 +0300 vaults: remove unnecessary no_monster_gen in ecu vaults -------------------------------------------------------------------------------- 0b0bf74c28 | Edgar A. Bering IV | 2021-07-06 10:43:29 +0300 fix: spacing tweak in ecumenical.des -------------------------------------------------------------------------------- 47bcd709c3 | DreamDustDCSS | 2021-07-06 10:42:00 +0300 vaults: DreamDust faded altar vaults Six new ecumenical altar vaults [ Committer's notes: Overall adjusted tags (allow monsters, rotation). Squashed commits and rebased. Specific vault adjustment notes follow. Closes #1946. hidden_grotto: use delayed decay for the corpse, remove the quarterstaff and butterflies, trim size. angels_and_demons: console aesthetics, trim size. drowned_temple: statuary and console aesthetics, trim size. grove: remove butterflies, guarantee connectivity, console aesthetics. sealed_demon: console aesthetics. ] -------------------------------------------------------------------------------- 28d7adaeb8 | Shapermc | 2021-07-06 10:40:39 +0300 vaults: ShaperMC ecumenical altar ruins Adding 7 new ecumenical altar vaults [ Committer's notes: Adjusted foliage counts and placements (we don't want to overly annoy players making them crush plants). Placed some controls on the Plato randbook. Fixed up the skeleton placement for Pompeii. Cleaned up spacing. Fixed commit history. Closes #1999. ] -------------------------------------------------------------------------------- 2c0bbc4b58 | MainiacJoe | 2021-07-06 10:39:41 +0300 vaults: unaligned overflow altar vaults by ManiacJoe Each of these vaults has a fixed altar count. Seventeen place one altar, six place two altars, and one places four altars. [ Committer's notes: Squashed and rebased. Added transparency tags to all vaults. Corrected typos and removed extraneous headers in boulavard, catwalk, and surrounded_room. Removed borders from large_24_doors, chevrons, and large_starburst. Removed some over-use of clear stone. Made the_wave 2 tiles wide. Tweak alcove_2 and catwalk. Closes #1858. ] -------------------------------------------------------------------------------- f5a116941d | Kate | 2021-07-05 05:05:53 +0100 Reduce the number of bees in wad_woods_minihive It's probably still excessive, but at least slightly less so. -------------------------------------------------------------------------------- 331ba6fa66 | gammafunk | 2021-07-04 21:37:46 -0500 feat: Adjustments to Ice Cave entry vaults Many of these vaults haven't been updated for monster changes over the years. In these vaults, replace ice beasts with simulacra appropriate for placement depth, placing fewer, since simulacra tend to be nastier. Remove some arbitrary down-weights on some normal entry vaults, but keep down-weighting on easy entry vaults that place an out of depth monster. Organize entry vaults into sections based on whether they place for one specific type of ice cave difficulty and clean up syntax. -------------------------------------------------------------------------------- 183a74056d | gammafunk | 2021-07-04 21:37:46 -0500 feat: Adjust hard Ice Cave placement Currently hard ice caves can only place in Elf and Lair branches, but D:14-D:15 is comparable depth to Lair branches, and an easy ice cave will generally be very easy by D:14. This commit extends hard ice caves to the final two levels of Dungeon. -------------------------------------------------------------------------------- cde07775c6 | gammafunk | 2021-07-04 21:37:46 -0500 feat: Have all Ice Cave maps use the same weight Maps currently have a weight of either 5 or 6, making them individual place at nearly the same frequency. The weight of 6 was used for the five "small cave" maps to make them place twice as often as the three "sprawling cave" maps that use weight 5. This isn't necessary, however, since the themes of these maps are strongly overlapping. The two map sets share similar monsters, have similar difficulty as a whole, and nearly all of the "small" maps are in fact quite big. This commit has all maps use the default weight of 10. -------------------------------------------------------------------------------- cc58b11c1d | gammafunk | 2021-07-04 21:37:43 -0500 feat: Rework many aspects of Ice Cave maps (hellmonk) Many ice cave maps don't define variants for the hard difficulty version of the portal that places at later levels, which means less map variety at these locations. Additionally, terrain in many maps includes freezing vapour generators that are randomly placed, leading to annoying gameplay and many out-of-LOS collateral monster kills. Many maps place large deep water areas that are either completely enclosed with rock or lead to spoilery dead ends with no gameplay relevance. Finally, some maps share common functions and data for defining thematic monsters and loot, but these are a patchwork that's not used consistently among all maps. This commit addresses these issues. Partially based on hellmonk's PR #1942, we add hard variant monster and item sets to all ice caves. To help achieve this, the vault functions for items and monsters are generalized and shared to some degree among all maps. As before this commit, there are two thematic sets of monsters, natural and demons+undead, but instead of using the natural set only for easy difficulty and undead+demons only for hard, both sets have definitions for each difficulty. Both sets define eight monster definitions using the same glyphs 1 through 8, with a designated function at each glyph like "statue monster", "miniboss", and "boss". This way any map can use the definitions interchangeably, regardless of monster set or difficulty. All but four maps use these monster sets, and the three "sprawling caverns" can use either set at either difficulty, randomly choosing between the two. The monster lists have been tweaked to be more coherent with more well-defined difficulty progression. For statue monsters, we use ice statue for both sets at easy, orange crystal statue for the natural natural at hard difficulty, and obsidian statue for undead+demon at hard. To allow Shadow Creatures to work for orange crystal statues and the player spell, both monster sets defined appropriate random monster lists at both difficulties. Additionally the simulacrum lists used by the undead+demon set have been expanded to have definitions at both difficulties, rebalanced, and refactored to be more easily reused. Both sets now define two boss monsters, a stronger, but smaller group monsters and a weaker, but larger group monster, and most maps randomly choose one of these two configurations. For the natural monster set at easy difficulty, the player faces either two ironbound frosthearts or a single frost giant. At hard difficulty, this is either two or more frost giants or one to two shard shrikes. For the undead+demons set at easy difficulty, the player faces either two bog bodies or a single reaper. At hard difficulty, this is either two or more blizzard demons or one to two ice fiends. Trivia: the infamous double ice fiend found on ice_cave_small_demon at hard difficulty was due to a bug where the original author misapplied a substitution pattern used in other maps. They meant to give either two blizzard demons or one ice fiend, and gave instead either one blizzard demon or two ice fiends. This double fiend is so universally loved that I made it possible on any map using the undead+necro set at high difficulty, albeit with reduced chance. I also expanded the idea to the natural monster set using shard shrikes. Enjoy! The ice-themed common loot definitions have been improved to have six common classes of items: three tiers of armour (aux+light, medium, and heavy), two tiers of weapons (any weapon and upper-tier weapons), and a magic set (books, enhancers, jewellery, and misc items). Additionally, necromancy-themed maps share a common ice-themed necromancy loot definition. These definitions used to some degree by all maps, replacing the many different and overlapping definitions used previously. Larger maps that place loot items at early or midpoint locations now always place one of the armour class items at these locations, so a player might get access to rC before the map is finished. The tier of armour item at these locations is randomized, so it won't always be light armour, for example. For maps that previously had hidden water caverns, we turns some of these areas on each map into randomized shortcuts that are each open 50% of the time. These shortcuts contain either deep water (encouraging use of flight or amphibiousness) or floor with a freezing vapour generator. These shortcuts are at fixed locations that provide meaningful skips of significant fights and in a way where collateral monster deaths to freezing vapour will be reduced. More randomly placed freezing vapour machines are gone altogether, with the exception for the ones at the end of ice_cave_small_demon. All freezing vapour machines now place with the same power level (cloud duration), but vary by size (number of clouds placed) as appropriate for their map location. Many other aspects of monster placement and composition have changed on a per-map basis. Comments have been updated at the top of each map to summarize types of monsters and loot, and there are comments for each group of SUBST/NSUBST/SHUFFLE. On each map, comments above the conditional check for hard or easy difficulty describe the major differences between the two difficulties. Some additional notes on specific maps: ice_cave_small_demon: Any reaper placed now gets a robe of cold resistance and either a ring of protection from cold or a ring of ice, bringing it to rC+++ and freezing vapour immunity. Gone are the days of the mysterious dead reaper! This map could randomize between reapers and blizzard fiends since it doesn't have an explicit necromancy theme, but for now we're going with reapers only for tier 2 demons. ice_cave_statue_garden_transporter: The final transporter area has been reworked to be small enough so it can be entirely seen by the player before taking the transporter. ice_cave_statue_garden_chambered: The map was created before circlelos became squarelos, when visual range was 8 squares for all characters. Hence its ice statues were all in view of each other before squarelos, but it wasn't updated for the reduction of visual range to 7 squares. I've reduced the map two squares in its longest dimension to bring them back within LOS of each other. Closes #1942. -------------------------------------------------------------------------------- 84e617a3e7 | gammafunk | 2021-07-04 21:32:04 -0500 doc: Update comments in icecave.des Add vault sections with guidelines and instructions for entry vaults and the ice cave maps. Clean up descriptions of ice cave themes and reorganize. -------------------------------------------------------------------------------- e31baa5f3c | gammafunk | 2021-07-04 21:32:04 -0500 feat: Add a vault utility function The lua function dgn.random_entry_arg() can be used to add an argument to each entry in a delimited string. This can be useful when adding weights or terms to strings defined for monster and item definition purposes so that said strings can be re-used without repeating their contents in multiple places. This will be used in a subsequent commit that updates the Ice Cave maps. Also improve and reformat comments for other functions in this file. -------------------------------------------------------------------------------- 282632147b | Kate | 2021-07-05 00:57:38 +0100 Let Poisonous Vapours set ally targets -------------------------------------------------------------------------------- 9c78c815f3 | Kate | 2021-07-04 17:50:25 +0100 Don't expire Coupling/Ramparts etc when flight ends -------------------------------------------------------------------------------- 0fd888774e | wheals | 2021-07-04 18:22:59 +0300 Remove unused spl-pick.{cc,h} -------------------------------------------------------------------------------- 0929e78a5e | wheals | 2021-07-04 18:18:19 +0300 Change random-pick to use vector and c++11 list initialization This removes the need for a terminator entry at the end -------------------------------------------------------------------------------- 4c2704cb36 | wheals | 2021-07-04 16:32:19 +0300 Remove butchering -related option -------------------------------------------------------------------------------- aadcdd2144 | wheals | 2021-07-04 16:32:19 +0300 Move travel_open_doors to the travel section of the options guide. -------------------------------------------------------------------------------- 1844267e3d | wheals | 2021-07-04 16:32:19 +0300 Remove the now-unused spflag::emergency. -------------------------------------------------------------------------------- 87b6fcb595 | Nicholas Feinberg | 2021-07-03 18:10:06 -0700 Make storm form insubstantial (gammafunk) Purely for flavour. -------------------------------------------------------------------------------- 300acc8974 | Nicholas Feinberg | 2021-07-03 16:28:04 -0700 Add a bad storm form tile PF'd again -------------------------------------------------------------------------------- 96bc1138ba | Nicholas Feinberg | 2021-07-03 16:17:24 -0700 One more book freq tweak Per objstat, this gets average spells generated in Lair and D back to the same levels they were at pre-recent-changes. -------------------------------------------------------------------------------- 6853699f2c | Nicholas Feinberg | 2021-07-03 15:15:52 -0700 Remove stab_bypass Previously, stabbing could randomly bypass some of the defender's AC. At 5 stealth skill and 5 shortblades, you'd get on average 1.25 bonus damage out of this, assuming your target had at least 5 AC and they were sleeping, paralysed, or petrified (otherwise, you'd get on average ~0.3 bonus damage). At 18 stealth and 12 shortblades, you'd get on average about 3.75 bonus damage, with the same qualifications (target had at least 15 AC, etc). This seems unecessarily complex. Why add such a tiny bonus specifically against enemies with AC? Stabbing is already good against AC; it does huge damage! Instead, let's just add this tiny little flat bonus directly into damage, pre-AC. This is a small player buff. (We may later want to just cut this flat component entirely and shift other things around if necessary.) -------------------------------------------------------------------------------- 9b7c6745da | Nicholas Feinberg | 2021-07-03 14:38:39 -0700 Pull back on book gen again Drop it by 25% (not counting vaults), since it looks like we overshot a bit. May need to drop it farther. -------------------------------------------------------------------------------- 4b3bd47ff3 | mgdelmonte | 2021-07-03 17:29:06 +0300 feat: add monster.flags Adds a flags function to the Lua monster_info object, which returns the list of flags set for the monster. This allows more script future proofing as compared to the flag method. [ Committer's note: Updated commit message. Closes #1921. ] -------------------------------------------------------------------------------- 66c3ed4545 | mgdelmonte | 2021-07-03 17:17:58 +0300 feat: add travel.is_excluded The travel module in Lua lets you set and remove exclusions, but not test for them. This adds the is_excluded function to that module. [ Committer's note: Edited commit message. Closes #1928. ] -------------------------------------------------------------------------------- b48c9e4e3a | mgdelmonte | 2021-07-03 17:14:09 +0300 fix: check for exclusions in view.is_safe_square Currently view.is_safe_square returns false if a square has clouds or a trap or something known to be nasty, but not if the square is marked excluded. However, a marked exclusion, whether by the player or the game, would seem to be an obvious indicator that the square is unsafe. With the current implementation of view.is_safe_square, hitting TAB to autofight when a monster is within an excluded area, such as that surrounding an ice statue, can result in the question "Are you sure you want to move into that travel-excluded area?" even if non-excluded targets are available. With the advent of the travel_one_unsafe_move option, autofights inconsistent treatment of exclusions is an interface screw. This commit addresses that issue. [ Committer's note: Rewrote commit message. ] -------------------------------------------------------------------------------- 6f15984924 | Edgar A. Bering IV | 2021-07-02 10:46:28 +0300 docs: remove starting books from the manual -------------------------------------------------------------------------------- 9e18931815 | Edgar A. Bering IV | 2021-07-02 10:46:15 +0300 feat: Spell background adjustments part I (kate-, hellmonk) Book backgrounds have for a long time presented friction with the notion that a background should be a starting kit, and not completely determine a character's arc. With many books containing L5 spells many could carry comfortably to the midgame. In part this was necessary to make them fun: with spell books being large and somewhat rare, finding "the right book" could take some time and without the level of progression found in current books they would be sunk cost traps. The recent changes to book items smooth out spell drops, giving more opportunity for characters to adapt. This opens up space to make spell backgrounds more of a starting kit and less of a complete package. Some of the backgrounds would be awkward with a blunt delete all L5 spells from spell starts, so this commit starts the process incrementally. This is also a good opportunity to reduce the number of schools in each start and the total number of spells even if there are no L5 spells, also in support of this goal. Ne, FE, and Wr are untouched, as chopping off their L5 spells leave the books a bit too thin. They will be visited in future commits (possibly in 0.28). AE loses lightning bolt. There's a bit of an aesthetic loss in that lbolt is quite iconic, but the start still has a strong collection of spells that can support developing in various directions based on the dungeon. Indeed, there are many players who already ignore lbolt in the book. AM loses Leda's. The AM book had four (4) schools for a background that notionally also wants to train a weapon. At level 4 dual school Leda's was the hardest to reach of these spells, so its absence won't be too felt. EE loses LRD. People kill OOFs with an acid wand and LRD, come on. Without it the "jank stabber", "pick up some kind of tmut either form or otherwise", and "be a blaster" possibilities invited by the book have more equal appeal. IE loses Metabolic Englaciation. The loss makes repeated Hailstorm harder to set-up from the book alone, but it remains very strong. Su loses Summon Ice Beast. Still very strong but reduces the book to a three school book. VM loses Ignite Poison. This reduces the number of schools in the book to 4 (still high) and returns VM to an era of needing to branch out sooner, especially to deal with resistant threats. This is much like VM's past, but with the new opportunities provided by more frequent spell drops it should be less of a "VM sucks" vibe. -------------------------------------------------------------------------------- 4eff083807 | Edgar A. Bering IV | 2021-07-02 10:01:39 +0300 docs: changelog typos (geekosaur) -------------------------------------------------------------------------------- cffa5a9b16 | Kate | 2021-07-02 06:58:28 +0100 Fix book names in vaults -------------------------------------------------------------------------------- 28b6d0f915 | Nicholas Feinberg | 2021-07-01 22:13:03 -0700 Depluralize (ardl) Avoid "an inescapable atlases" (now "...atlas") or "an unrestrained analects" (now "the unrestrained analects", fairly hackily). -------------------------------------------------------------------------------- 4113b66390 | Nicholas Feinberg | 2021-07-01 22:07:09 -0700 Fix book of stone desc (hellmonk) oops -------------------------------------------------------------------------------- 2e30c3664c | hellmonk3 | 2021-07-01 23:47:02 -0400 Fix book of the spheres description -------------------------------------------------------------------------------- c0e7b40ece | Kate | 2021-07-02 01:34:05 +0100 Don't crash on examining ponderous artifacts Extend the available space in descriptions so that "ponderous" fits, and add handling so that future egos with long names will just be cut off rather than crashing. -------------------------------------------------------------------------------- 6348b4e45d | Kate | 2021-07-01 23:11:04 +0100 Cap the number of spells Djinn can start with Giving Djinn more than 8 spells caused them to hit the cap on known spells as they levelled up. This could only happen rarely for Wanderers, but handle it generally for all new characters Just In Case. -------------------------------------------------------------------------------- 2b061281b7 | Kate | 2021-07-01 23:11:04 +0100 Fix a crash when Djinn learn too many spells In rare cases, Djinn Wanderers could start off with 9 or 10 spells, which would cause them to hit the cap of known spells at level 25 or 27, and crash when trying to learn their next spell. To rescue any games trapped in this situation, make them forget spells from the start of their innate set to make room for the later ones. A later commit should adjust Wanderer starts to prevent Djinn from giving out so many spells and causing the issue in the first place. -------------------------------------------------------------------------------- 2d92212324 | Edgar A. Bering IV | 2021-07-02 01:00:20 +0300 docs: changelog through 0.27-a0-1423-ge5d6b6a -------------------------------------------------------------------------------- e5d6b6ab6a | Nicholas Feinberg | 2021-07-01 14:19:07 -0700 Fix Book of Weapons desc (Ge0ff) -------------------------------------------------------------------------------- a6f8dd0138 | Kate | 2021-07-01 18:56:48 +0100 Shuffle around some high-level spells Since the spells that were previously rarebook-only can now appear in randart books, adjust book contents so that each L9 spell is only in one fixed book. -------------------------------------------------------------------------------- 8daf88dee0 | Kate | 2021-07-01 18:56:40 +0100 Remove special handling for "rare" spellbooks Previously, the book of Annihilations, Grand Grimoire, and the Necronomicon had special behaviour - they couldn't be gifted by Sif, and their spells never appeared in randart books (but could appear in Sif randart gifts). The book reworks moved many of the affected spells out of the rare books and into normal books, so rather than keeping the special behaviour around for a very narrow remaining set of spells, just treat them and their contents the same as any other books. -------------------------------------------------------------------------------- 4d0b0a1ddf | Edgar A. Bering IV | 2021-07-01 19:22:27 +0300 fix: Give capacitive coupling and searing ray identical ending behavior -------------------------------------------------------------------------------- c69eb68267 | advil | 2021-07-01 11:59:02 -0400 fix: move newchar quiver setup later (dang3rdave) It turns out that _setup_generic happens before the player's init file is read for real, and so anything that is waiting on early setup calls or lua isn't reliable at this point in character creation. This includes the new fire order options, because there's an overly elaborate spell name cache thing that isn't in place for the first rc read (and some maybe-related but not fully identified issues for abilities). To solve this I have moved new character quiver setup later in the sequence. It might eventually be better to simplify spell/ability startup so it's more reliable. -------------------------------------------------------------------------------- 5cd3f1290e | Nicholas Feinberg | 2021-07-01 08:47:52 -0700 Rework monster CBL Give it actual damage (not the sad 3x3d6 it did before - now 3x3d25 on Lom Lobon) and describe it in xv. I think spellforged servitor doesn't work properly with it before or after this change. Not sure why. -------------------------------------------------------------------------------- 4c841f645e | Edgar Bering | 2021-07-01 09:54:26 -0400 fix: Harmonize spell distributions In the process of preparing branch reading_rainbow for merging, Confusing Touch and Vampiric Draining ended up in one book each, with Petrify and Animate Dead appearing in three. This commit balances the book apperances of these four spells to match the design spreadsheet. -------------------------------------------------------------------------------- 941b2bd30b | Nicholas Feinberg | 2021-06-30 22:51:31 -0700 Fix book weights? (wheals, others) -------------------------------------------------------------------------------- 413ade4df3 | Nicholas Feinberg | 2021-06-30 22:19:26 -0700 Fix chain lightning no-hostiles check Correctly check to see whether there are any targetable enemies in range. -------------------------------------------------------------------------------- 2fbb07c8a5 | Nicholas Feinberg | 2021-06-30 22:12:47 -0700 Fix chain lightning + statues (ardl) Don't attempt to arc through them. -------------------------------------------------------------------------------- ded080b69b | Nicholas Feinberg | 2021-06-30 22:05:35 -0700 Fix creeping frost death message No more killed by 'a frost'. This code is awful and makes me sad :( -------------------------------------------------------------------------------- b7b94b6bbb | Nicholas Feinberg | 2021-06-30 21:59:04 -0700 Fix chain lightning death message No more just 'killed from afar'! -------------------------------------------------------------------------------- 987ffbb14b | Nicholas Feinberg | 2021-06-30 21:41:23 -0700 Tweak ar description (dinky) Like magic, a wand has become a chess piece. -------------------------------------------------------------------------------- a306adf81e | Nicholas Feinberg | 2021-06-30 21:35:22 -0700 Fix curare death message (7+ year bug) Don't claim to be killed by "kobold brigand's curare-tipped dart". Instead, let's just be killed by *a* brigand. This bug dates to at *least* 51a3c3daa54 and probably farther back. -------------------------------------------------------------------------------- ea6a400864 | Nicholas Feinberg | 2021-06-30 21:24:14 -0700 Update book background descriptions Don't claim they start with books. They don't! -------------------------------------------------------------------------------- a93db79ee8 | Edgar A. Bering IV | 2021-06-30 21:08:18 -0700 vaults: Adjust explicit book placement floats, shops, and portals -------------------------- This adjusts explicit books placed by shops, floats, portal vaults, and mini vaults in light of the new book shuffle. Some book placement weights are moved upward in portal loot, as new books have fewer spells this seems ok from a loot point of view. arena sprint ------------ Add some more books to the arena sprint shop, since each book has fewer spells. The pricing still probably makes this a tougher deal for heavy spell users even with the increased selection. Hard cheese. -------------------------------------------------------------------------------- e29514b5c3 | Nicholas Feinberg | 2021-06-30 21:08:18 -0700 Increase book generation rates Move them from weight 30 to 100, slightly more than doubling the number of books generated. This is in preparation for a future change that will shrink books. All other item generation drops by about 2%, which I'm not currently compensating. This keep total spells more in line with what we saw before. -------------------------------------------------------------------------------- b47a77b0f7 | Nicholas Feinberg | 2021-06-30 21:08:14 -0700 Adjust book costs -------------------------------------------------------------------------------- c126db5c3d | Nicholas Feinberg | 2021-06-30 21:07:25 -0700 Split fixed books into smaller sizes To smooth out the vagaries of randomness and make it more viable for players to adapt to what books they find, shrink most fixed books to contain exactly 3 spells and add about 30 new books to compensate. These books are designed to be relevant to a wide variety of character levels and types, to increase the chance that they'll have at least one spell that the finder will be able to use, even if it's less likely that every spell in there will be useful. They're also supposed to have fun, evocative themes. -------------------------------------------------------------------------------- 69d6a04d60 | Nicholas Feinberg | 2021-06-30 21:05:58 -0700 Adjust randbook sizes Roughly halve the sizes of most randbooks. Exempt Sif gifts, but make her gift timeout scale based on the size of the books gifted. -------------------------------------------------------------------------------- 60a263dd95 | Nicholas Feinberg | 2021-06-30 20:49:26 -0700 Fix artefact description formatting Format armour ego descriptions in the same way as randart properties when on a randart (or unrand). -------------------------------------------------------------------------------- b235c8b66b | Nicholas Feinberg | 2021-06-30 20:49:26 -0700 Remove unused (?) armour desc code This covered the case in which you knew that a piece of armour was magic, but it didn't have an ego, but you didn't know what its plus was. That almost certainly can no longer happen. -------------------------------------------------------------------------------- 8c83a1b76d | hellmonk | 2021-06-30 23:29:40 -0400 Noise dampening good mutation A rare good mut that halves noise from all sources within the player's los. -------------------------------------------------------------------------------- fb4300f5bb | Kate | 2021-07-01 03:55:27 +0100 Improve some unrand descriptions Add DESCRIP lines for the Wrath of Trog, necklace of Bloodlust, ring of Shadows and amulet of the Air. Unrands generally could probably use a full pass to put pure mechanics information in DESCRIP lines, free up the actual unrand description portions to be primarily flavourful, and possibly to use the new ARTP syntax of showing the inscription alongside the description (such as "SInv: It lets you see invisible"). Also fixes a typo in the cloak of the Thief description (via geekosaur, thanks!). -------------------------------------------------------------------------------- 22e92bf66e | Kate | 2021-07-01 03:55:27 +0100 Fix artefact and jewellery desc spacing/linebreaks Fixes a large number of inconsistencies in linebreaks across randarts, unrands, and some mundane jewellery. These hopefully all now consistently have a single empty line in between each of the base item description, any special unrand-only brands and/or descriptions, any randart properties, and the remainder of the descriptions. Also fixes a missing space for +Stealth items. -------------------------------------------------------------------------------- 8a2cd6d854 | Kate | 2021-07-01 03:55:27 +0100 Mention berserk extension in Trog's description It's probably not a detail that needs a full entry on the overview page, but should at least be mentioned in the extended description. -------------------------------------------------------------------------------- 85a84b9822 | Kate | 2021-07-01 03:55:27 +0100 Give Trog berserk a small piety-based failure rate To compensate for the removed chance of paralysis (since although Trog reliably prevents it later, it could very occasionally happen early on), and in general just to slightly weaken the ability in the extremely early game where it's incredibly powerful. -------------------------------------------------------------------------------- 0ac0241410 | Kate | 2021-07-01 03:55:27 +0100 Remove the chance of paralysis when ending berserk Paralysis was a rare occurence on ending berserk, and under Trog was particularly unlikely to happen except very early on, due to the piety-based chance to prevent it. It was slightly more relevant for non-Trog berserk, but since that's much less reliably repeatable (and weaker due to not being extended on kill), remove the chance of paralysis to simplify the effect overall. -------------------------------------------------------------------------------- c49bf3aad3 | Kate | 2021-07-01 03:55:27 +0100 Fix Trog being unable to burn an altar vault book (Goratrix) The vault was looking for an unidentified book - instead check for the book by its vault-defined title. -------------------------------------------------------------------------------- a6dc6547e3 | Nicholas Feinberg | 2021-06-30 19:19:46 -0700 Revert "Revert "Adjustments to book generation"" With some fixes to shopping.cc and book gen. -------------------------------------------------------------------------------- 6e7fd8c9ca | Nicholas Feinberg | 2021-06-30 19:00:38 -0700 Remove fun (buff felids/blade hands) RIP one of the greats. -------------------------------------------------------------------------------- 778c2f8729 | Nicholas Feinberg | 2021-06-30 18:56:10 -0700 Wereblood: only heal on adj kills A duration spell has to be balanced very carefully, to encourage it to be used situationally, rather than on all the time (since spells in DCSS do not work well for 'always-on' effects). Adding healing to Wereblood was intended to make it more useful in the early game, so that characters would have the 'sustain' needed to keep fighting multiple enemies and to make use of the slaying, but it seems to have made it too generally applicable. Let's limit it a bit. -------------------------------------------------------------------------------- 48c30b3128 | advil | 2021-06-30 15:26:09 -0400 fix: adjust early processing of fire order options (Goratrix) This will hopefully fix a crash on windows, that seems to result from some ability code being called too early in the initialization process on the first read of the rc file. Though I'm not sure why `all` works while `berserk` crashes, but Goratrix has kindly done some bisection to isolate that particular line. This commit also just prevents user-rc fire order options from being processed on this initial pass. -------------------------------------------------------------------------------- 8d3c4a4866 | MainiacJoe | 2021-06-30 22:09:57 +0300 Make the Wrath of Trog angrier This adds two new behaviors intended to make the weapon more appealing for characters who can go berserk without making it too powerful for those who can circumvent the *Rage. The first is berserk duration extension identical to that of the Necklace of Bloodlust. The second is Rampage: rampaging doesn't incur berserk penalties if it is used to take a swing. This is an overlap of effect, but the Wrath of Trog offers no optional berserk and the ``extras'' are cleaner. Bloodlust might need some design work, but that's out of scope for this commit. To prevent using the weapon to go berserk on demand and otherwise not deal with berserking in every fight, this also adds an on-wield penalty: the berserk cool down. [ Committer's note: Closes #1890. Did some commit re-ordering and editing. Added the wield penalty. ] -------------------------------------------------------------------------------- 3b62c0300e | MainiacJoe | 2021-06-30 21:47:38 +0300 Enable rampage on unrands Creates RAMPAGE as a bool in util/art-text.pl -------------------------------------------------------------------------------- e902cdc63c | advil | 2021-06-30 10:44:13 -0400 feat: enable arrow keys on quiver menu Would like this feature to get more testing before general use, and the quiver menu seems like a reasonable place for it to get that. -------------------------------------------------------------------------------- b8d40accb6 | advil | 2021-06-30 09:55:49 -0400 feat: uselessness check for forest space (dinky) This disables summon forest in the quiver when there isn't enough space for it. -------------------------------------------------------------------------------- 365887799b | Edgar A. Bering IV | 2021-06-30 09:24:45 +0300 fix: Tweak Capacitive Coupling's quiver name to fit -------------------------------------------------------------------------------- c2e3725628 | Edgar A. Bering IV | 2021-06-30 09:18:03 +0300 feat: Animate the status light for Maxwell's We could use plusses but the number of turns waiting isn't easily available unless we leak the charge time which is intentionally randomized and hidden. So instead, a little twirly dash to give some feedback that something is happening. -------------------------------------------------------------------------------- 1422d76b99 | advil | 2021-06-29 22:23:21 -0400 feat: autofight for wait spells The need to specifically hit `.` is a bit of an interface screw more than anything; this commit enables just triggering autofight (`p` etc) if the wait spell is quivered to continue casting it. This has been on my list for a while but now that there are two of them it became more important. As part of this commit, I also made it clearer in the targeter that casting it that way would restart the spell. Possibly should be included in `z` as well for people who have the Maxwell's targeter disabled. -------------------------------------------------------------------------------- bd6db1e6d9 | Kate | 2021-06-29 23:46:59 +0100 Adjust spacing in spellbook descriptions So that "Maxwell's Capacitive Coupling" will fit. -------------------------------------------------------------------------------- a7dfd5ec23 | advil | 2021-06-29 18:10:42 -0400 feat: options for controlling spell/ability quivering Long-requested quiver features: These options let you control what appears in the cycle order (and autoquiver on game start) in a much finer-grained way. Ideally this would have some sort of in-game UI but that's a much bigger project, so these fairly brute-force options will do for now. These options do not affect what is shown in the Q menu, if there is demand for that I could consider a further tweak along those lines. Since some people seem convinced that quivers are for attacking only, I have provided some shortcuts to set your spell/ability fire order lists that way; probably most useful with autofight_throw=true since the notion of "attack" this uses is exactly identical to that one. Also by popular demand, this commit excludes berserk by default from fire_order_ability, keeping it out of cycle order and autoquiver. I could still be convinced to revert this part, though I do agree that berserk is very different from everything else that this option is relevant to at game start. This can of course be overridden with: fire_order_ability += berserk As part of this commit I also made `fire_items_start` be respected for all quiverable item types, not just ammo. -------------------------------------------------------------------------------- 81fdcbfb23 | advil | 2021-06-29 14:42:58 -0400 fix: update quiver on item adjustment This is a long-missing behavior for newquivers. Spells and abilities already handled adjustment correctly, because they didn't rely on anything tied to letter position, but inventory items need to manually have the quiver slot changed. -------------------------------------------------------------------------------- f508b8f851 | advil | 2021-06-29 13:09:37 -0400 feat: range checks for various scrolls The main goal of this was to improve the enabled check when a scroll is quivered (e.g. fear is now disabled with no susceptible enemies), but I also added a double-check prompt when reading the scroll. If this is too annoying it can be removed. It's possible these checks are a bit slow when a scroll is quivered, and need a cache mechanism like `spell_action`s have. However, I'm not sure how much consumables will really be quivered in practice, so I'll wait and see. -------------------------------------------------------------------------------- e6a161afd2 | advil | 2021-06-29 13:09:37 -0400 refactor: consolidate some reading code Only scrolls are readable, so this commit removes the distinction between `read` and `read_scroll` and restructures reading checks accordingly. The reading checks are reordered and cleaned up in the process, so this commit should fix https://crawl.develz.org/mantis/view.php?id=12610. -------------------------------------------------------------------------------- defffd1ff6 | Kate | 2021-06-29 04:49:37 +0100 Staticify a function -------------------------------------------------------------------------------- 9e2faccc22 | Kate | 2021-06-29 04:49:18 +0100 Don't crash when cancelling a Searing Ray -------------------------------------------------------------------------------- 3820e56076 | Kate | 2021-06-29 01:20:33 +0100 Don't allow activating the Sceptre of Asmodeus with Sac Love Previously it would spend a turn but do nothing, so just print the failure reason without costing a turn. -------------------------------------------------------------------------------- 4b199c8bd3 | Edgar A. Bering IV | 2021-06-29 01:01:59 +0300 feat: New Spell: Maxwell's Capacitive Coupling Commit 64d35965e29 removed Absolute Zero because the memorable, spectacular instant kill effect didn't have good playfeel. It often felt cheap, with the monster getting no chance to react. The result was that boss fights felt like anticlimaxes. This re-introduces the guaranteed kill effect, but it is no longer instant. Instead, the spell has a (random, not revealed) aut charging time between cast and effect. In this time the player must wait (like searing ray). At the end of the time a random closest monster is killed. Any action other than waiting causes the spell to fizzle (with no MP refund). The flavour is currently Air: a reference to capacitive coupling. The effect (especially with the time lag) fits the "bouncy, pointy, or hard to direct" archetype that we went for with Air in positional magic much better than Ice (I will admit a bit of contortion in calling A0 "subtle".) With Chain Lightning moved up to L9 Conj/Air, Air magic has space for a L7 or 8 attack spell. This reverts commit 64d35965e295382a687bd14c17aadd49688b771d. -------------------------------------------------------------------------------- c14e5d3922 | advil | 2021-06-28 17:51:34 -0400 fix: missing header? -------------------------------------------------------------------------------- ea054b796d | advil | 2021-06-28 17:26:16 -0400 feat: add static targeters for several scrolls Another niche feature, somewhat more involved than I had hoped. The trick here is that even where scrolls correspond to spells, the call that does the effect is always pretty low-level and so it wasn't easy to reuse all the your_spells scaffolding. This commit adds targeters for fear, summoning, vulnerability, immolation, holy word, silence, and reuses the existing blink targeting code. (In implementing this, I slightly refactored how hop is called because of needing to change shared code.) Most of these aren't very exciting unless you aren't used to the effect, but fear seems useful. It would be nice if there were a nicer interface for getting to these targeters besides quivering the scroll and using `f`, but I'm not sure what that would be. This commit also prevents quivering unid'd spells and scrolls, for the sake of simplicity. -------------------------------------------------------------------------------- a08111df00 | advil | 2021-06-28 17:18:34 -0400 refactor: generalize and unify some quiver boilerplate This combines a bunch of shared / repeated code for actions involving items. There's some hackiness here to do with hard coding class names for serialization + equality purposes, but it's still probably better than repeating this code so many times. (Not aware of a cleaner c++ approach to this, though perhaps there is something.) -------------------------------------------------------------------------------- 6e4aca1174 | advil | 2021-06-28 17:18:34 -0400 feat: quivering spells/potions This is a pretty niche feature so I haven't included these in the default `Q` list. However, it was easy to implement, requested, and this is one step closer to a complete generic trigger api for item effects. E.g. eventually I'd like to use actions for local tiles buttons so that the item activation api is not distinct. One noticeable gap is targeters for scrolls, to be added in a future commit. Another is that scroll actions don't have a very good enabled check. -------------------------------------------------------------------------------- 58471f690d | Kate | 2021-06-28 19:18:34 +0100 Remove Pakellas ability tiles and descriptions Since their functionality has been removed. -------------------------------------------------------------------------------- 1ea419760f | Kate | 2021-06-28 17:49:01 +0100 Remove obsolete code for Pakellas' Device Surge It had lots of dead code and resulted in a large number of TAG_MAJOR_VERSION checks in any place that calculated evocations power. There's no save compatibility requirement to keep it around and any future re-implementation of Pakellas would need a full redesign, so fully remove the ability to clean up evoker code around it. Also fixes some overzealous TAG_MAJOR_VERSION checks which had scheduled surge_power() and surge_power_wand() for removal - these handle messaging for normal enhancers and still function without Pakellas. -------------------------------------------------------------------------------- 229a95b9f4 | Kate | 2021-06-28 16:14:18 +0100 Make Archmagi affect randart pricing -------------------------------------------------------------------------------- c7843cd938 | Kate | 2021-06-28 16:13:20 +0100 Fix spacing -------------------------------------------------------------------------------- d924e931ac | Kate | 2021-06-28 16:11:05 +0100 Fix Archmagi and +MP randarts never generating -------------------------------------------------------------------------------- e71e8f7681 | dilly | 2021-06-28 10:31:10 +0300 Add Wr and AM for Ba recommends (#1994) Four weren't enough. Let players do something else more. [ Committer's note: Ba make good hybrids, we use recommendations both for things that play well and things that build lore. These backgrounds meet both criteria. ] -------------------------------------------------------------------------------- 9667eb783e | Skrybe | 2021-06-28 10:29:59 +0300 Update special_room_magic_class (#1961) Some adjustments to the magic classroom special room I submitted a while back. Added necromancers to the monster set, and adjusted weights in general. Vampire knights and deep troll earth mages get the biggest drop in weight, and deep elf sorcerers and deep elf death mages get the biggest increase. Depths:5 draconian annihilators are more common now as well. This should make the room generate a more varied monster set. Boss monsters are untouched. -------------------------------------------------------------------------------- e0d888d967 | Alexei-Barnes | 2021-06-28 10:06:43 +0300 Corrects the description of Tin of Tremorstones The description states that the power scales with your evocations skill. This is not the case since 6f112fb28d. -------------------------------------------------------------------------------- e7c6b5271d | Goratrix | 2021-06-28 10:03:55 +0300 Add Archmagi as a randart property This adds Archmagi as a randart property and enables it to generate on robes only (for now). Also added are equip/unequip messages, same as for the Archmagi ego, and an indicator in the character overview screen. -------------------------------------------------------------------------------- 234f4a1dcd | Nikolai Lavsky | 2021-06-28 09:59:29 +0300 Fix Dj's hair on the species selection menu The newgame doll was missing red hair, which is the default according to `tilepick-p.cc:tilep_race_default()`. -------------------------------------------------------------------------------- 4cf9878b8b | robertxgray | 2021-06-28 09:49:34 +0300 Allow zoom in via ctrl-'+' The key combination ctrl-'=' doesn't work in some European keyboards like Spanish or German. -------------------------------------------------------------------------------- a2a4dfd6fd | Nicholas Feinberg | 2021-06-27 19:09:28 -0700 Maybe fix a book crash (kate) -------------------------------------------------------------------------------- a0a28fc8c3 | Nicholas Feinberg | 2021-06-27 14:45:43 -0700 Revert "Maybe fix a book crash" This reverts commit b88236dc16387cae4b30a5264a106c4c44de900a. -------------------------------------------------------------------------------- 5d287be605 | Nicholas Feinberg | 2021-06-27 14:41:53 -0700 Revert "Adjustments to book generation" This reverts commit caca448e221395f958a5f12a07e8ffd255cb755f. -------------------------------------------------------------------------------- b88236dc16 | Nicholas Feinberg | 2021-06-27 14:24:13 -0700 Maybe fix a book crash -------------------------------------------------------------------------------- 1158a0e862 | Nicholas Feinberg | 2021-06-27 13:57:10 -0700 Don't list the books a spell can be found in This was never particularly useful, and would break when we added more book types. -------------------------------------------------------------------------------- caca448e22 | Nicholas Feinberg | 2021-06-27 13:56:54 -0700 Adjustments to book generation - Support future books beyond the current limit of 60. - Remove the concepts of 'book rarity' and 'spell rarity'. Instead, try to generate books with spells that will be potentially interesting to players at the corresponding absdepth. - Price books by total spell level, not by rarity. -------------------------------------------------------------------------------- 14994ecaaf | Kate | 2021-06-27 20:31:32 +0100 Adjust Slime floor zig scaling To replace some of the azure jelly weight with rockslimes and quicksilver oozes. They're unlikely to be especially worrying threats, but they do probably at least deserve some additional weight as the new top-end Slime monsters. -------------------------------------------------------------------------------- bb9dc7d752 | Kate | 2021-06-27 20:21:16 +0100 Remove some obsolete Djinn code (From their previous implementation.) -------------------------------------------------------------------------------- 47152c58aa | Nicholas Feinberg | 2021-06-27 12:00:44 -0700 Remove book ID Books being unknown had almost no impact on the game. They were a little fun in antique shops, but that was fairly rare and not worth keeping the feature given the limitations it presents (max 60 book types), let's scrap it. -------------------------------------------------------------------------------- f014654284 | Nicholas Feinberg | 2021-06-27 12:00:00 -0700 Remove known book tracking Extremely little point to it now that libraries exist. -------------------------------------------------------------------------------- 4272520434 | Nicholas Feinberg | 2021-06-27 11:59:18 -0700 Make Damnation bolts only mulch on hit Seems polite. -------------------------------------------------------------------------------- 58f33c6695 | Nicholas Feinberg | 2021-06-27 08:33:55 -0700 Maybe fix dform steam res (advil, 2tousent) -------------------------------------------------------------------------------- d8886f0a89 | Nicholas Feinberg | 2021-06-26 22:06:02 -0700 Title armour properties To help clarify for newer players who get lost in the sea that is our very long item descriptions. (We need more organization, formatting, sections, etc... but instead I'm doing this.) Example output: 'Of rampaging': It allows the wearer to take one free step toward enemies. (Or however that goes...) -------------------------------------------------------------------------------- 60794d8430 | Nicholas Feinberg | 2021-06-26 22:06:02 -0700 Title artefact properties Explain what inscription each artp corresponds to in item descriptions. (E.g.: "rPois: It confers resistance to poison", or something like that.) Formatting could use some work. -------------------------------------------------------------------------------- b432ad73d2 | hellmonk | 2021-06-26 20:59:13 -0400 Buff Wucad-Mu Reworked Wucad-Mu felt a bit underwhelming. Increase the chance of a refund, and refund the MP on success even if a side effect is rolled. Can be tweaked further if this ends up being too much. -------------------------------------------------------------------------------- 9fd5ee6ec5 | hellmonk | 2021-06-26 20:37:33 -0400 Add salamander tyrants to snake themed zig floors -------------------------------------------------------------------------------- 643e45de12 | hellmonk | 2021-06-26 20:13:02 -0400 Don't unbribe monsters that haven't been bribed yet Whatever jank this causes is probably less bad than turning monsters hostile because the player hit a monster that, unknown to them, would receive a bribe when it entered their line of sight. -------------------------------------------------------------------------------- a99462a43c | Nicholas Feinberg | 2021-06-26 11:48:01 -0700 Only explode Damnation on hit When fired from the unrand Damnation, bolts should only explode if they actually hit the target. (Thus, firing with '.' is no longer very silly secret tech.) -------------------------------------------------------------------------------- dcd0597939 | Nicholas Feinberg | 2021-06-26 10:47:33 -0700 Remove a redundant yesno (advil) -------------------------------------------------------------------------------- 561ffd6492 | Nicholas Feinberg | 2021-06-26 10:43:52 -0700 Allow monsters to wand each other The prophecy is fulfilled. -------------------------------------------------------------------------------- 81ec99bee2 | Nicholas Feinberg | 2021-06-26 10:40:55 -0700 Break monster AI (greenscarf) Allow berserk monsters to launch reaching attacks, as with players. In principle allow monsters to reach, swoop, or use wands while offscreen. (But wands still don't quite work.) -------------------------------------------------------------------------------- 1e49fe14ad | Nicholas Feinberg | 2021-06-26 10:10:57 -0700 Remove superfluous parens -------------------------------------------------------------------------------- bddd1c10ba | Nicholas Feinberg | 2021-06-26 09:48:30 -0700 Allow Poisonous Vapours on empty space To allow people to cast it on invisible enemies (which seems fairly intuitive). Now that vapours doesn't create clouds, this should be unproblematic. (Kate, if I've misunderstood your intent, please let me know.) This probably needs some way to bypass the yesno prompt but I'm not sure what. Partially reverts d1c2c16caae861bf6d9ccddd45d859ddfa191991 . -------------------------------------------------------------------------------- c13eec7c8e | Aliscans | 2021-06-26 18:57:23 +0300 Add a help option for the wizard mode create monster command. Entering ? as the monster name causes some help text to appear. This is derived from the MONS section of docs/develop/levels/syntax.txt, but with a few changes. 1. Use colour - yellow for headings, white for keywords which can be entered as part of the command, and cyan for other things such as text the game produces in response to a command, or file references. 2. Remove quotation marks from around keywords. I haven't done this with cyan text, as this contains longer phrases which may be harder to separate. 3. Don't give advice on how the command should be used (such as "use this sparingly"). 4. Rearrange the paragraphs a bit, and add a new opening paragraph. 5. Add lists of valid characteristics for mutant beasts and ugly things. -------------------------------------------------------------------------------- 23b85b8d87 | Edgar A. Bering IV | 2021-06-26 12:04:23 +0300 docs: changelog typo -------------------------------------------------------------------------------- 2746e35aca | Edgar A. Bering IV | 2021-06-25 22:18:29 +0300 docs: changelog through 0.27-a0-1333-gcdc07c3a8f -------------------------------------------------------------------------------- cdc07c3a8f | Nicholas Feinberg | 2021-06-25 11:18:36 -0700 Unlock dangerous quantities of punny vaults Add nicolae to the dev team! Well deserved and welcome :) -------------------------------------------------------------------------------- 84bddb5ca7 | advil | 2021-06-24 19:41:31 -0400 fix: proper range check for poisonous vapours Also, move it into spl-damage.cc since as of 3f0e5c0cca2eb01 there are no clouds involved. Possibly this can just be zappified to simplify it further? This fixes https://crawl.develz.org/mantis/view.php?id=12502 -------------------------------------------------------------------------------- 60ef6b6952 | advil | 2021-06-24 17:41:10 -0400 fix: better BVC auto-targeting This keeps BVC from repeatedly targeting already-clutched enemies. Resolves #1956 -------------------------------------------------------------------------------- c68dd95e36 | advil | 2021-06-24 17:28:41 -0400 feat: handle @Qn inscriptions directly in quiver menu Before (after newquivers) these were only usable by going into the item submenu. This will work even for items that don't show up in this menu by default, though as of yet there is no way to inscribe non-items. (This was reported somewhere by someone, but I can't figure out who or where to credit, sorry.) -------------------------------------------------------------------------------- 14410a1de8 | advil | 2021-06-24 14:02:36 -0400 feat: hide dj MP bar in webtiles -------------------------------------------------------------------------------- a61f464a61 | advil | 2021-06-24 13:48:10 -0400 feat: hide dj MP bar in console/local tiles This is kind of ugly because as it stands, y positions for certain hud elements are calculated in multiple places. (In fact, this calculation was already buggy.) But doing this "right" involves a lot of high-effort refactoring and testing, or at least more than I'm going to do right now. However, I have at least renamed the infamous yhack to something more interpretable and changed its logic accordingly. -------------------------------------------------------------------------------- 9601c94f4e | advil | 2021-06-24 12:48:51 -0400 feat: arrow key navigation for macros menu More incremental improvements for the macro menu. The immediate goal of this is to allow more easily selecting existing macros for editing that have hotkeys that menu code would otherwise intercept. Despite the limited application of this change, the commit is a fairly comprehensive rewrite of hover code that is tested to work on any single-selection menu. I may activate it more generally in the future as I think it's a net usability improvement in all sorts of menus (though I expect a certain amount of grumbling because it is *change*). However, it needs to be extended to handle multiselection before this is fully viable. As part of this change, I needed to rewrite webtiles hover code to use a regular css class rather than the :hover pseudo-class; unfortunately one cannot interact programmatically with :hover. There *should* be no user-visible change resulting from this but this was more complicated than I had hoped, so we'll see. The webtiles client-server communication about hover is still somewhat dubious here. -------------------------------------------------------------------------------- 66ddcf376d | advil | 2021-06-24 12:48:51 -0400 fix: set last_visible correctly in webtiles menus The for-loop here for setting last visible only checks the case where i-1 is the last visible element, so when the last element is visible, it didn't do anything, leaving last_visible set to 0. Instead, make the fallthrough case already the last element in the list. As far as I can tell this should work even on very strange bounding boxes. As a practical matter, this will prevent menus from wrapping to the beginning on pgdn in webtiles, which they apparently have been doing for a while. We'll see how used to this players are. Other clients have a MF_WRAP setting for when menus are supposed to have this behavior, but this doesn't seem to be implemented in webtiles. This commit also fixes a bunch of js exceptions on corner cases with empty menus. -------------------------------------------------------------------------------- 58a489ad9e | Nicholas Feinberg | 2021-06-23 08:45:34 -0700 Remove local dj mp display Webtiles is harder so I'm leaving that to someone else, sorry! -------------------------------------------------------------------------------- e0d8e047f6 | advil | 2021-06-22 10:08:50 -0400 feat: better integrate the macro menu Before, there was a pre-menu to select the kind of binding to edit before entering the edit menu. After this change you are dropped directly into macro edit mode, and can use `!` to switch to keybind editing. This is one fewer keystroke for macros, the same number of keystrokes for regular keybinds, and extra keystrokes for the obscure keybind modes. I've also slightly hidden the details of keybinds from the first view, because in almost all circumstances I don't think players want to edit these in-game, and in almost all circumstances, macros are a better choice than keybinds for people who don't know what they are doing. Still lots of further improvements to be made here. The editing itself should be moved onto the same screen as the menu, and I think this menu would also be more convenient if arrows selected (but unfortunately the Menu class doesn't support this at all, as far as I know). -------------------------------------------------------------------------------- 4214377f51 | gammafunk | 2021-06-22 03:50:54 -0500 Adjust spawns in a vault (dilly) The vault nicolae_shoals_spring_well_temple places about 7.5 water nymphs on average, in addition to two well springs, which is pretty extreme. The upper-limit of what vaults can place given extreme and rare RNG results is allowed to be ridiculous, sometimes worse than branch endings and potentially leading the player to abandon a level. However unless the vault is intended to be an extreme challenge, which often means down-weighting or runed door/transporter vault, the average case should be more reasonable. This commit adjusts the vault to only place 3 water nymphs on-average and adjust the well spring placement from guaranteed 2 to place 1 to 3 with an average of two. -------------------------------------------------------------------------------- fdffb62a71 | Nicholas Feinberg | 2021-06-21 22:30:07 -0700 Mostly remove resilience This basically just confused a lot of people over the years. It's OK, you can say 'health' when you mean 'health'. We already use it in a few places! It's more flavourful for stuff like Borg's anyway - very Raistlin Majere. Skeletons and zombies are a bit beyond the whole 'health' thing, and I think resilience is less confusing for them anyway, so they can keep it. Ditto the reference on the amulet of vitality - that one's very straightforward. -------------------------------------------------------------------------------- d358eaa319 | Kate | 2021-06-21 21:18:35 +0100 Prevent repeating Nemelex Stack Five and Triple Draw (#12607) Repeating abilities with submenus causes weird behaviour. -------------------------------------------------------------------------------- a591dbc05d | Kate | 2021-06-21 21:16:34 +0100 Fix command repeat handling for some unrepeatable actions Various actions couldn't be repeated with 0, but could be with `. Prevent these more consistently, and fix a case where aborting out of an attempt to repeat rampaging movement would result in a partial move still taking place. -------------------------------------------------------------------------------- eec4fb4e21 | Kate | 2021-06-21 04:12:14 +0100 Refactor Kiku's Necronomicon gift, re-add Haunt With Haunt being moved out of the Necronomicon it had become impossible for Kiku to gift knowledge of it. Instead of gifting a physical Necronomicon, make Kiku add its spells directly to the library as with the earlier spell gifts, and add Haunt back to the list of included spells. -------------------------------------------------------------------------------- 0c770c2c28 | Kate | 2021-06-21 04:12:02 +0100 Refactor Kiku book gifts Instead of gifting randbooks, just gift the spell knowledge directly, since the spell library now supports this. Saves some weirdness with not being able to receive spell gifts over water/lava. -------------------------------------------------------------------------------- d1140b374c | Kate | 2021-06-20 19:58:53 +0100 Fix braces -------------------------------------------------------------------------------- 0783df26cf | Kate | 2021-06-20 19:58:12 +0100 Fix a newly-introduced melee crash Don't bail out of combat and crash after a fire vortex attacks and destroys itself. -------------------------------------------------------------------------------- b2afe90b7e | Kate | 2021-06-20 18:17:23 +0100 Clean up monsters that die due to acid retaliation damage Fixes an issue with invalid dead spectral weapons when they die to acid retaliation damage, hopefully fixes a related crash, and probably doesn't break anything else? -------------------------------------------------------------------------------- dfdbaa49b7 | Kate | 2021-06-20 18:06:43 +0100 Don't allow GDR below 0% (For wizmode display purposes.) -------------------------------------------------------------------------------- 2e558cd5dc | Kate | 2021-06-20 17:04:22 +0100 Fix an information leak with LOS attack spells (#12605) Don't consider invisible creatures as valid affected targets if you can't see them. -------------------------------------------------------------------------------- 5cdb2b3542 | Kate | 2021-06-18 22:20:48 +0100 Fix tag_upgrade compilation -------------------------------------------------------------------------------- 670f4b6da9 | Kate | 2021-06-18 22:17:03 +0100 Don't try and place djinn corpses in nicolae_arrival_memento_mori But do place palentonga corpses since those do exist. -------------------------------------------------------------------------------- 4af0e254da | Kate | 2021-06-18 21:38:09 +0100 Update some monsters-behind-glass vaults To use accurate lists of player species monsters. -------------------------------------------------------------------------------- 830f50283a | Kate | 2021-06-18 21:22:54 +0100 Add dummy monsters for player djinn -------------------------------------------------------------------------------- c08437e49b | Kate | 2021-06-18 04:25:08 +0100 Replace Animate Skeleton with Call Imp in the tutorial Since summons should function better than raised undead due to the relatively quick expiry timer on the skeletons. -------------------------------------------------------------------------------- 1b31d702ef | Kate | 2021-06-18 04:12:36 +0100 Update tutorial some more (CanOfWorms) -------------------------------------------------------------------------------- fa6c21d646 | Kate | 2021-06-18 01:32:07 +0100 Fix Poisonous Vapours not working on rPois- monsters (Ham) -------------------------------------------------------------------------------- f33ce2d7c7 | Kate | 2021-06-17 22:54:45 +0100 Fix a tutorial/hints mode crash -------------------------------------------------------------------------------- 0d0f3e58c5 | Kate | 2021-06-17 22:49:50 +0100 Update tutorial Remove some more unused tutorial pads, replace a redefined monster with a real one, and replace the ratskin cloak so as not to give the player allies in an early lesson before allies are deliberately introduced in the later spellcasting tutorial. -------------------------------------------------------------------------------- 3f0e5c0cca | Kate | 2021-06-17 20:00:08 +0100 Rework Poisonous Vapours not to create clouds Mechanically, Poisonous Vapours is intended to apply a small amount of smite-targeted poison, but the fact that it was implemented by using a cloud ended up making it unnecessarily complicated. Almost all of the time the cloud would dissipate immediately, but at particularly high power it would stick around for a brief while, and using a cloud also prevented using it against targets that were already in clouds. Instead make it just directly apply poison, with the number of stacks applied scaling up at high power (to compensate for the fact that the cloud itself could previously deal some direct damage). -------------------------------------------------------------------------------- 7736ffe575 | Kate | 2021-06-17 17:27:55 +0100 Remove an unused tutorial pad -------------------------------------------------------------------------------- 128193abf8 | advil | 2021-06-16 10:19:54 -0400 fix: don't mark ash-cursed items as useless In various cases the player can put on items whose base ego is useless (e.g. faith), and then curse them, in which case they are no longer useless. The melding logic here relies on the rest of the code being right, which it probably isn't, but it looked ok in the cases I tested. -------------------------------------------------------------------------------- 08e866c54a | advil | 2021-06-16 10:19:54 -0400 fix: fully inactivate faith for ashenzari (u/Imaginationably) c9f47ef48ce0 disabled the piety gain effect of faith and marked it useless, but did not turn of the on-remove effect or messaging. (Possibly this code would be cleaner if all of these things were tied to uselessness, but I'm not sure enough how the other gods work to change that.) It's still possible to wear useless items (and in this case, even curse them -- in fact this maybe means that ash followers should collect useless amulets until they have something better to curse? Haven't played enough newash to know if this is a good idea.) -------------------------------------------------------------------------------- 1ab19c6527 | Nicholas Feinberg | 2021-06-15 22:22:12 -0700 Partially fix chain lightning death messages Still broken in a couple of ways, but this is all I've got in me for tonight. -------------------------------------------------------------------------------- 003aadc33b | Nicholas Feinberg | 2021-06-15 22:13:48 -0700 Display chain lightning damage in monster (again) -------------------------------------------------------------------------------- 5c463d0a3f | Nicholas Feinberg | 2021-06-15 22:09:42 -0700 Fix monster Oops -------------------------------------------------------------------------------- 8ece459b43 | Nicholas Feinberg | 2021-06-15 14:50:06 -0700 Add a fairly silly splash (ArbitUHHH) Much debate over this one, but the chicken won out in the end. -------------------------------------------------------------------------------- 0306a414db | advil | 2021-06-15 13:55:18 -0400 fix: remove chain lightning delays with no animations (Yermak) This extends the refresh option introduced in e645bd13c135 to be usable as a beam option, for callers who are not separating drawing and damage. It then applies it to chain lightning, fixing the lag when animations are off; this commit should also reduce the number of redraws with animations on (which is a factor in lag online). As one of the TODO notes says, I am still not entirely sure why there should still by default be an update per cell when draw_delay == 0, but this is preserving old behavior from before e645bd13c135, and I would need to do more investigation before simplifying. -------------------------------------------------------------------------------- 42bb9d4d07 | gammafunk | 2021-06-15 09:30:55 -0500 Fix a shop vault depth (nicolae) -------------------------------------------------------------------------------- 4180522d9c | gammafunk | 2021-06-15 09:19:36 -0500 Some shop vaults from nicolae (12593) No real changes from the original submission aside from a couple very minor bug fixes. -------------------------------------------------------------------------------- 165cb48cdd | gammafunk | 2021-06-15 09:14:06 -0500 Refactor and expand objstat statistics This commit reworks most of the internal data handling of objstat to be more consistent and to allow tracking of additional data. All item categories now track additional categories of whether the item was in a vault, held by a monster, or in a shop. Aspects like enchant/charges and brands are likewise tracked within these new categories. We also now track statistics for spells, as described further below. Artefact books are moved over to the spellbook tracking file, treating level artefact books and theme artefact books as two distinct book types. Additionally manuals now track by their associated skill instead of all together. Finally, objstat no longer produces redundant listings for "All Levels" when only one branch is tabulated, since that data is already in the branch summary. For items, the tracking categories of artefact, vault, shop, and held by monster are independent of each other. So one can't determine the number of items both held by a monster and in a vault, for example; tracking all combinations of these aspects would lead to too many statistics of marginal interest. Exception to this are the fact that an item can't be both held by a monster and in a shop and that all shop items are vault items, since shops place through vaults. Subtracting the values in these categories from the overall value will always give the count for the negation of that category. For example, subtracting NumArte from Num gives the number of non-artefact items. I've removed fields like "NumOrd" that can be calculated in this way to reduce the number of output statistics; these calculations can be easily made by a spreadsheet, once the data is imported. For spell tracking, we track overall counts by spell and within the new categories mentioned above, including artefact for spells in artefact spellbooks. Additionally we have "Chance" fields for spells in all categories. The Chance field gives the percentage of the time the spell was seen on a given level. This can be useful for determining the chance a spell would be seen by some depth, for example. Calculation of Chance fields could be extended to other item categories like Misc, Staves, or even all items, if that's later deemed useful. Internally it now uses map<> instead of vector<> for indexing statistics, which simplifies statistical initialization, since we can rely on default initialization of zero for most statistics. I've made these maps use enum types keys where that's possible, but in some cases like item sub_type we still need to use int keys, since item sub_types don't share a common enum type. -------------------------------------------------------------------------------- eefcff550b | Nicholas Feinberg | 2021-06-14 17:31:47 -0700 Rewrite new game spell setup In preparation for future changes, don't give new characters a spellbook and then immediately destroy it. Instead, give them a specific list of spells. -------------------------------------------------------------------------------- 15d3ce7508 | advil | 2021-06-14 09:54:04 -0400 fix: guaranteed source of digging in sprint_mu slime (Nivim) There is no code to remove the walls on TRJ death, and it is not easy to port the regular game code over. I'm guessing the intent was to break these walls somehow (they are rock, not stone). The sprint does place a source of digging, just not in slime, possibly because it would have been eaten. However, that is no longer an issue, so I'm just adding a guaranteed digging wand on the altar. If someone ever implements wall destruction here, remove this. -------------------------------------------------------------------------------- e5723c67b8 | advil | 2021-06-14 09:20:01 -0400 fix: prevent closets in `heliophobic_arrival_ceremonial_halls` Extends the fix in #1984. The biggest thing this vault needed was a `transparent` tag; I've also added the pathing from #1981 as it will help it place, and in addition to that added explicit @ tags. It could be good to randomize the outer pathing a bit, but let's keep it simple for now. Resolves #1973 Resolves #1984 -------------------------------------------------------------------------------- 0782e7eb64 | DreamDust | 2021-06-14 09:20:01 -0400 Fix: lemuel_upstairs_altar [Committer's note: ensure that this places where a downstairs can place] Resolves #1981 -------------------------------------------------------------------------------- ca74d27db6 | hellmonk3 | 2021-06-13 22:16:23 -0400 Merge pull request #1972 from hellmonk3/rollingrocks New spider minivault -------------------------------------------------------------------------------- fa2398d640 | hellmonk3 | 2021-06-13 21:39:57 -0400 Merge pull request #1971 from hellmonk3/zotshop New Zot:5 shop vault -------------------------------------------------------------------------------- 992921d2c4 | hellmonk | 2021-06-13 21:28:55 -0400 Return blade hands to level 5 While it's unlikely to return to the TM start book, blade hands works best at a lower level, where the option to cast it in heavy armour is more appealing. -------------------------------------------------------------------------------- 6cae3acc97 | Kate | 2021-06-14 00:22:28 +0100 Adjust Wereblood description -------------------------------------------------------------------------------- e233d83751 | Nicholas Feinberg | 2021-06-12 15:39:18 -0700 Add a Werewolf quote (Ge0ff, 12601) -------------------------------------------------------------------------------- 9d2d252d84 | Kate | 2021-06-12 19:33:39 +0100 Fix pluralisation Apparently both are valid, but "vortices" is what's currently used elsewhere. -------------------------------------------------------------------------------- 1a68546ab8 | advil | 2021-06-12 13:59:59 -0400 fix: remove some ancient mac debugging code This code originates from pre-version-controlled dcss or earlier. I can only imagine that at some point <2005 things were weird with intentional crash signals in MacOS to the point where accessing *nullptr seemed like a good idea, but on a modern mac this has been increasingly unreliable, and on an M1 / big sur device, it freezes with 100% cpu before timing out or needing kill -9, at least 2/3 of the time. As far as I can tell, sending abort works fine and doesn't do this. We'll see if this generalizes to other devices. -------------------------------------------------------------------------------- 6cbc8dfb29 | Nicholas Feinberg | 2021-06-11 21:26:29 -0700 Send DCSS straight to hell Welcome to the dev team, hellmonk! :) -------------------------------------------------------------------------------- 3808f8b1c9 | advil | 2021-06-11 15:42:53 -0400 fix: enable autofight for blinkbolt -------------------------------------------------------------------------------- 4e44252f3f | advil | 2021-06-11 14:55:34 -0400 refactor: better organization for animated objects take 2 These are still a bit all over the place, but this at least gives a slightly more unified API and uses it; small UI cleanups happened as a consequence, e.g. better labeling in ctrl-x, animated armour gets the dancing icon (I realize it isn't technically "dancing" but it's still useful I think). Hopefully haven't missed too much here. This reverts commit f925c23bd1a27674721db3c623a4d332f2cfaff7. -------------------------------------------------------------------------------- f925c23bd1 | advil | 2021-06-11 14:17:03 -0400 Revert "refactor: slightly better organization for animated objects" (fails to build on tiles, oops) This reverts commit 201ea1cf866eb8e85181b8f30b0fa74a58a99de0. -------------------------------------------------------------------------------- 201ea1cf86 | advil | 2021-06-11 13:55:32 -0400 refactor: slightly better organization for animated objects These are still a bit all over the place, but this at least gives a slightly more unified API and uses it; small UI cleanups happened as a consequence. Hopefully haven't missed too much here. -------------------------------------------------------------------------------- ec92ba881d | nlavsky | 2021-06-11 01:50:31 +0100 Don't put Refrigeration users under penance for tracer checks (#1978) After 73eefd5d, Ozocubu's Refrigeration users can get under penance for opening the z? or Q menus or just for having the spell on the quiver. It happens if they worship a god who cares about allies and if there are allies nearby. Fix this by skipping conducts when doing tracer checks. -------------------------------------------------------------------------------- 7c8ad2e407 | advil | 2021-06-10 17:09:11 -0400 fix: remove accidental debug messaging -------------------------------------------------------------------------------- 5a9c36edca | advil | 2021-06-10 17:05:35 -0400 build: reduce iterations for uniques testing This is one of the slower tests, and for something testing a basically unchanging mechanism, doing all of these iterations every time on CI doesn't seem to accomplish much to me. -------------------------------------------------------------------------------- 10283c2238 | advil | 2021-06-10 15:13:23 -0400 feat: tweak polar vortex glyph colours It's possible this is overcomplicating things, as it may make it slightly harder to identify terrain. However, the glyph colours were inconsistent with the tile colours, and also not very on-theme for how ice is usually depicted on console. (Of course, if Tornado had never existed, this might be less of an issue.) I ended up deciding that e.g. just using glaciate glyph colours didn't really work, it was too ugly, so this uses a bit more randomness for one of the phases to add some more subtle console ice colouring in. One phase is always stable, to prevent complete chaos. -------------------------------------------------------------------------------- 5d3a65c723 | advil | 2021-06-10 14:23:25 -0400 fix: more vortex removal for CI -------------------------------------------------------------------------------- dcd9d5d9b8 | advil | 2021-06-10 14:12:34 -0400 fix: remove an ENCH_VORTEX reference for CI Looks like it is safe to just remove this? -------------------------------------------------------------------------------- 90a9cae496 | advil | 2021-06-10 13:54:04 -0400 fix: get rid of "unable to find exits" error in bounce.lua test Tagging this with no_exits simply skips the placement code that generates this error. -------------------------------------------------------------------------------- 85dd5f356d | advil | 2021-06-10 13:54:04 -0400 build: shorten mut_species.lua test This is one of the slowest tests, and it has been a long time since it actually found anything; I think we can do with fewer iterations. -------------------------------------------------------------------------------- 738ad7bf98 | advil | 2021-06-10 13:54:04 -0400 fix: revert a debugging change This was for debugging itemspecs, but accidentally got committed in 1d930f0793d61. -------------------------------------------------------------------------------- e710ad149d | advil | 2021-06-10 13:54:04 -0400 fix: improve crashes for unrecoverable builder lua errors This isn't intended to be a full solution for lua errors at levelgen time, but tries to make the crash process smoother, both in terms of messaging, and efficiency. The builder for each map tries to run vault lua 25 times, and tries to build a level 50 times before bailing entirely with a crash. So if a vault has e.g. a broken itemspec that produces a lua error during levelgen, this can be repeated at least 25 times, and for wizmode force generation (&P), 25 * 50 times. The vast majority of errors of this category (though not all) will be deterministic, so there's no point to retries. In cases like this, on a debug build the lag for the crash is also pretty noticeable. So, implement some stuff to immediately bail (for &P) or veto (for regular levelgen). In addition, percolate the actual lua error up the messaging chain a bit better, so the it now is actuall visible directly from the command line. (It's probably a bit *too* redundantly printed now, though.) Implementation: this commit adds a state variable to signal that an error was fatal, and handling for it to improve the messaging and skip all these retries. This may be something that would be more naturally done with exceptions, but it's entirely possible that these exceptions would need to dance around the lua layer (which can't have exceptions thrown across it, see 091e5a1), and I don't want to mess with this. For regular levelgen, this does throw a veto exception, but from a place where that should be safe to do. -------------------------------------------------------------------------------- 6f2aa7e302 | Nicholas Feinberg | 2021-06-10 10:14:22 -0700 Let Storm Form go mano-e-mano (engine, Reeces) Oversight! Also sneakily revert the EV bonus from the last change. -------------------------------------------------------------------------------- 1b1a975c3d | Nicholas Feinberg | 2021-06-10 09:08:21 -0700 Rework Air Elementals Air elementals' use of Twister (a lesser Tornado/Polar Vortex) was intended to give them a more interesting gimmick than their old ones (submerging in air). However, it was quite complex, and tended to cause quite a lot of collateral damage to their own allies. That could be fun sometimes, but it could also result in victories that felt unearned. Instead, let's try a new spell: Stunning Burst, a weak electrical beam attack that can inflict a very brief (1 turn) paralysis on hit. rElec can resist it, as can dodging, stasis, or controlling line of fire, but Will has no effect. Let's see how higher-frequency, lower-impact Para feels. -------------------------------------------------------------------------------- 534494da46 | advil | 2021-06-10 09:30:55 -0400 fix: prevent save corruption on &P crashes This fixes a couple of ways that a save could become unloadable when it crashes with &P: (i) the force props didn't get cleared, so the game would try to regenerate exactly the failing levelgen process all over again (which might be ok for some crashes, but not e.g. a bad itemspec), and (ii) placeinfo would get corrupted in a way that doesn't get fixed up (now it gets corrupted in a way that does). -------------------------------------------------------------------------------- 27faaac778 | gammafunk | 2021-06-10 04:14:35 -0500 Checkwhite -------------------------------------------------------------------------------- de6c002c37 | gammafunk | 2021-06-10 04:13:51 -0500 Some Shoals vaults from nicolae (12593) A set of 7 decor vaults and a set of 18 monster vaults. Minor edits have been made to the original submissions to follow syntax ordering style and to reglyph monsters to use number glyphs where possible. Remove patrolling tag for vaults that use in-branch monsters and add it in other cases where out-of-branch monsters are placed in vaults with special themes. More substantive edits to a couple vaults described below: nicolae_shoals_hidden_pirate_stash: Make the possible rapier weapon loot be good_item and make the scroll 50/50 for magic mapping or any scroll, instead of having a weight of 4 for the latter. nicolae_shoals_pincushion_passage: Thin out the monster a count, turning a 2/3 chance into a 1/3 chance, since otherwise it's a bit high for placing so many upper tier monsters. Could go either way on this change, but a bit fewer monsters felt right. nicolae_shoals_raging_river: Use elemental wellsprings instead of a custom vault define, which was a permanently berserk water elemental. A cute idea, but ultimately not quite interesting enough to warrant a custom definition, and I think what wellsprings can do is ultimately more interesting. -------------------------------------------------------------------------------- a7538b3203 | gammafunk | 2021-06-10 04:13:51 -0500 Some cleanups for Shoals.des Fix a section header and reindent and reorder a bunch of lines in some vaults. -------------------------------------------------------------------------------- c40782c2da | gammafunk | 2021-06-10 04:13:51 -0500 A quote for scrolls of identification (nicolae, 12593) -------------------------------------------------------------------------------- ced786f65e | Nicholas Feinberg | 2021-06-09 19:24:13 -0700 Don't claim Okawaru cares about your friends (Ge0ff) Since, as of 08c3841fb2f98d06ca037a69b54f3ed05b193e84, Oka doesn't. -------------------------------------------------------------------------------- 0aef527cbc | Nicholas Feinberg | 2021-06-09 19:20:16 -0700 Storm Form tweaks Make it nonliving (not having this was an oversight) and double the EV bonus to improve defenses a bit. -------------------------------------------------------------------------------- 64d35965e2 | Nicholas Feinberg | 2021-06-09 19:20:16 -0700 Remove Absolute Zero Absolute Zero was a spectacular, memorable effect: instantly turn the closest enemy into a block of ice! Unfortunately, in play, it ended up feeling worse than it sounded. The targeting constraints were a bit less limiting than had been intended, and many otherwise dramatic fights against powerful foes felt like anticlimaxes. It's still not entirely clear whether the spell was "too powerful" relative to the investment required to cast it, but it didn't *feel* good. There have been many suggestions for improving Absolute Zero - for example, adding a delay to the effect and making it a L9 Poison (!!) spell. When we want to experiment with those, we can revert this commit. For now, though, let's toss it. (A small part of this change [targeter removal] is in the previous commit - sorry! Don't miss that if you revert this.) -------------------------------------------------------------------------------- ff5298d5c3 | Nicholas Feinberg | 2021-06-09 19:20:16 -0700 Move Chain Lightning to level 9 After moving Tornado to Ice as Polar Vortex, Air needed a new level 9 spell. Chain Lightning is a spectacular and fun effect, but the current version is a bit messy and hard to understand - recursive arcs result in notoriously mysterious damage numbers ("4-264"). This seemed like a great opportunity to fix both. The new, level 9 Chain Lightning is intended to be an extremely powerful, but situation-dependent, effect. It does massive damage to the nearest target (partially ignoring both rElec and AC), and then arcs from that target outward, dealing somewhat reduced damage on subsequent arcs. With the right setup, it can spread across the entire screen, or it can just hit a few enemies on one side, depending on how you're positioned. It's intended to be competitive with Fire Storm (and thus keeps the Conjuration school), but to play very differently. Monster Chain Lightning is also changed to match. Nikola now does 3d17 at max range and 3d45 at point blank (again, partially ignoring AC and rElec), which should make him a more comprehensible and interesting encounter about managing distance, rather than just quaffing a resist potion or tricking him into walking near a plant. We'll see how that works out! -------------------------------------------------------------------------------- 7141f643d0 | Nicholas Feinberg | 2021-06-09 19:20:10 -0700 Shift: Tornado (L9 Air) -> Polar Vortex (L9 Ice) Ice, as a school, is intended to be 'diffuse' and 'subtle', With a few exceptions (i.e. Freeze), it tends to be best at dealing damage gradually to many enemies. That provides it with a distinctive playstyle, and Tornado fits that playstyle perfectly. As such, we'll shift Tornado to be the new level 9 Ice spell. Subsequent commits will discuss the removal of Absolute Zero and the new level 9 Air spell further. Functionally, the main change here is that Polar Vortex does 33% more damage (3 more dice) but is 40% resistable by rC, as with Hailstorm. Otherwise, it's the same spell. -------------------------------------------------------------------------------- 4220d81b6a | Nicholas Feinberg | 2021-06-09 18:41:10 -0700 Move Freezing Cloud to level 5 Since clouds now dissipate out of LOS and Ozocubu's Refrigeration now deals heavy damae, it's hard to justify the investment in Freezing Cloud as a 3-school spell. Move it to level 5 to make it a bit more viable, and to add symmetry with Bolt of Magma as a L5 Fire/Earth/Cj. -------------------------------------------------------------------------------- a17f9a2f5c | advil | 2021-06-09 20:43:40 -0400 feat: add basic tele closet detection to placement.lua This code tries to find spaces that are isolated, contain no stairs or hatches, and aren't marked with the no_tele_into KPROP. There are some things where it gets false positives, e.g. spaces completely filled by monsters, feature mimics, probably more. Reuses existing connectivity checking code. -------------------------------------------------------------------------------- 1d930f0793 | advil | 2021-06-09 20:42:27 -0400 fix: a batch of tele closet fixes Many of these are false positives, in the sense that they are tele closets filled by monsters (skipped by the tele code except for wizard teleport). But, they quiet the scripts. -------------------------------------------------------------------------------- 57ac2eb73c | advil | 2021-06-09 12:25:28 -0400 feat: options for resuming placement.lua in the middle This lets you choose where to start by vault name, which is convenient for running large batches of placement checks. I also added an option to limit the number of vaults tested. -------------------------------------------------------------------------------- 7e0d850643 | advil | 2021-06-09 12:24:02 -0400 fix: a batch of vault opacity fixes Detected via the placement.lua script. Not all of these are perfect fixes, and several of these vaults will still trigger vetos under some circumstances. -------------------------------------------------------------------------------- 9baf572ecc | advil | 2021-06-09 11:52:01 -0400 fix: some vault opacity fixes from nicolae This fixes several vaults that could generate isolated regions, including merging the change in snakefix.des in https://crawl.develz.org/mantis/view.php?id=12590 . -------------------------------------------------------------------------------- 940ed4fa31 | advil | 2021-06-08 22:18:09 -0400 fix: expand opaque mask skipping for vault exits Since 080276f, the `@` glyph is never automatically masked as opaque, leading to some connectivity checks for non-transparent vaults that do have exits. However, many vaults with only one exit rely on `+`, `=`, or even ` ` (in the case of floats with no marked exits) being interpreted as an exit as well. Example: library_closet in https://crawl.develz.org/mantis/view.php?id=12591. This commit expands things so that anything that counts as an exit for a vault will not receive an opaque mask unless that glyph is explicitly masked, which will expand connectivity checks by quite a bit. This may over-veto, we'll see, but in my testing seems to work and fixes the issue in 12591 without otherwise disrupting the seed (will need to do some more automated testing). -------------------------------------------------------------------------------- cb30e825f4 | advil | 2021-06-08 22:14:22 -0400 fix: avoid vetoing islands in pf_hell_entry_tar_river Because any `w` tile could turn into `.`, this vault can often generate islands in the corners, which will veto. This tweak adjusts the corners to never convert to land; two of the optional spectral shrikes may place only in the corners. -------------------------------------------------------------------------------- 2a5033c031 | advil | 2021-06-08 21:55:49 -0400 fix: various vault transparency fixes Mostly for new-ish vaults; I'm a bit surprised if these placed. In most cases this is just adjusting the masking. For nemelex_altar_shiori the removal of the transparent tag may be awkward, as it means this will veto unless *both* doors link up, but masking this one would be a pain. -------------------------------------------------------------------------------- e70438ac7b | advil | 2021-06-08 17:02:09 -0400 fix: let `sword_in_stone` not choke on dancing singing sword e7febcc0c011a added singing sword to `sword_in_stone`. However, the dancing weapon spec parsing couldn't handle providing an unrand here, and so the 1/50 condition would just produce a lua error (even if the vault is placing at a depth where the non-dancing one would be used). This commit implements correct spec parsing for unrands, and so lets this vault work as intended. If singing sword is already placed, it places a dancing fallback unrand (which seems to work correctly). -------------------------------------------------------------------------------- 418a8ee560 | Nicholas Feinberg | 2021-06-08 12:36:48 -0700 Make Wereblood heal 1d3 on kill Wereblood is dangerous to use because it draws in more enemies, That's a good tradeoff to discourage players from using it all the time, but to encourage player to use it for some fights, give a small amount of healing on kills so that the player is more likely to be at high enough health to face later enemies. -------------------------------------------------------------------------------- 26df433047 | Nicholas Feinberg | 2021-06-08 12:16:40 -0700 Don't put a level 7 spell in a starting book ??oops -------------------------------------------------------------------------------- 59ac6f31e6 | advil | 2021-06-08 15:00:54 -0400 fix: fix fixes -------------------------------------------------------------------------------- e6c32ae999 | advil | 2021-06-08 14:57:15 -0400 fix: yet more hydraform removal I'm not sure if a straight replacement with storm form in changes is what was intended, but hydra form's presence there was causing crashes. Also removed it from the enum on upgrade. -------------------------------------------------------------------------------- b079ea8264 | advil | 2021-06-08 14:37:09 -0400 build: more fully remove hydraform and hopefully fix CI -------------------------------------------------------------------------------- c590d4a5df | Nicholas Feinberg | 2021-06-08 10:14:49 -0700 Storm Form to level 7 Discourage using it at low spellpower (where it's much less useful) and communicate that it's meant to be a top-tier tmut, comparable to Dragon Form. It becomes castable around 60-70 power now, which feels like a reasonable starting point. -------------------------------------------------------------------------------- 47a774193f | hellmonk | 2021-06-08 09:46:48 -0700 Replace hydra form with storm form Hydra form was intended to be a heavily power-scaling form that made up for its bad defenses with cleaving melee and heal on kill. In practice, it was hard to obtain enough power for hydra form to outdamage to other forms, let alone find situations in which its benefits made up for poor ac and awful evasion. Storm form will attempt to fill the same niche as a lategame form that rewards high spellpower, but hopefully do it a bit better. Storm form melds non-jewelery slots, provides 2 + power / 2.5 base damage elec branded cleaving melee (breakeven post-brand damage with dragon form at 90ish power), 10 + power / 10 AC, retains player size and adds a power / 10 ev bonus, provides flight and relec, and has an activatable "blinkbolt" ability that deals elec damage and blinks the player to the end of its path, but must target a monster and has a cooldown. The new spell is level 6 transmutation/air, which makes spellpower more expensive in terms of exp but does allow easier enhancement. It is probably still very niche, but should be better in its niche. Numbers are open to adjustment. Additionally, it needs cool tiles for the form and ability. -------------------------------------------------------------------------------- 85643e0b18 | hellmonk | 2021-06-08 09:46:48 -0700 Increase ice form's ac power scaling. Ice form became comparatively unattractive due to blade hands buffs in 0.20 and was somewhat niche. Combined with the blade hands nerf, buffing ice form ac somewhat should make it more appealing. AC is unchanged at 0 power and 5 higher at maximum (100) power. -------------------------------------------------------------------------------- ec9bb07eb8 | advil | 2021-06-08 10:07:59 -0400 build: update ci irc information -------------------------------------------------------------------------------- c6a4cbde82 | Nicholas Feinberg | 2021-06-07 20:57:37 -0700 Remove wandering mushroom/toadstool magic Wandering mushrooms were able to path through toadstools so that it wouldn't be annoying when you created a wandering mushroom, prayed on a corpse to get a toadstool, and then got stuck. That logic really isn't need anymore. Reverts b5de9b17133aa . (Sorry, Sage.) -------------------------------------------------------------------------------- 6c7882eca4 | Nicholas Feinberg | 2021-06-07 20:38:23 -0700 Allow silencing rolling charge (engine) Alternative solution would have made 'the rumble of your scales through the stone' (or whatever) alert victims. If this is the next high-level stabbing tech then maybe I'll do something about it, who knows. -------------------------------------------------------------------------------- fc7c993222 | Kate | 2021-06-07 17:02:01 +0100 Adjust elemental wellsprings Their self-damage on cast caused them to abjure their own summons, as well as being poorly documented as a special-case on top of a spell that doesn't normally create summons. Instead give them Summon Water Elementals as a normal spell and remove their self-damage on cast as well as their fast regen. Also give them a radius 1 water aura like water nymphs, rather than just affecting the tile underneath them. -------------------------------------------------------------------------------- 819d820658 | Kate | 2021-06-07 16:11:45 +0100 Shorten Gozag's distraction message It was a lot wordier than necessary for something that's often displayed multiple times a turn. The "dreaming of imaginary riches" part was intended to clarify that it doesn't require actual gold to be present on the floor or in inventory, but the new "golden aura" wording now covers that anyway. -------------------------------------------------------------------------------- fd60fd639a | Aliscans | 2021-06-06 18:33:09 -0700 Fix an error message when creating a malformed dancing/spectral weapon. Previously, if you using the wizard mode create monster command with "dancing weapon; stone" on a build with asserts compiled in, the game crashed with "ASSERT(wpn) in 'dungeon.cc' at line 5159 failed.". The same happens for any non-weapon, or even "nothing", and the same if a vault was created which included such a monster. With this change, it prints "Monster 'dancing weapon' requires a weapon." instead in wizard mode, and the game cannot start if any vault contains a monster like that. -------------------------------------------------------------------------------- 90fd9eff7f | l33t-d00d | 2021-06-06 18:31:04 -0700 Modify Grammar Sceptre of Torment Minor grammatical modification to the message when wielding the Sceptre of Torment. "Terribly searing pain" (adverb modifying adjective describing noun) becomes "Terrible, searing pain" (compound adjective describing noun). Both are correct, however, the latter flows and sounds better. -------------------------------------------------------------------------------- a8cc5da48b | Nikolai Lavsky | 2021-06-06 18:29:52 -0700 Tweak Ozocubu's Refrigeration usefulness check Currently, the UI incorrectly tells the player that the spell has valid targets when there are only plants, butterflies, or player allies nearby. This commit changes Refrigeration's usefulness check, so the spell is grayed out on the quiver if there are no hostile monsters in LOS. [Committer's note: I rewrote this to be a bit simpler.] Closes #1968. -------------------------------------------------------------------------------- 8976fa19b5 | dilly | 2021-06-06 18:16:24 -0700 WJC Sifu names change Deng Ai, Jiang Wei, Zhang Bao, Sun Luban(especially this one) are not appropriate for the masters of martial arts council. -------------------------------------------------------------------------------- 5437b2cd39 | hellmonk | 2021-06-06 18:15:50 -0700 Change the gozag gold distraction message. The previous messages implied that nearby gold piles or the player's carried gold caused the effect, which was confusing. -------------------------------------------------------------------------------- e8f9bb252e | Nicholas Feinberg | 2021-06-06 18:13:04 -0700 Don't let animated armour open doors They have no hands! -------------------------------------------------------------------------------- 8da17f8a6b | Nicholas Feinberg | 2021-06-06 18:12:31 -0700 Remove unrand animated armour crash Don't crash when saving if an animated armour drawn from an unrand is walking around. -------------------------------------------------------------------------------- ef78505d0f | Nicholas Feinberg | 2021-06-06 17:45:59 -0700 Fix Vampiric Drain messaging (Yermak, 12597) And do a bit of refactoring while I'm in the area. -------------------------------------------------------------------------------- 54dba09ff7 | Nicholas Feinberg | 2021-06-06 10:23:26 -0700 Remove Invis range listing (Undo) Misleading since 6385558a29ec6c . -------------------------------------------------------------------------------- 958d993ae5 | gammafunk | 2021-06-05 22:33:28 -0500 Update the history section of the manual I've rewritten the history section to hopefully better capture the origins of Linley's Dungeon Crawl and its progression to DCSS. Mention Moria instead of Angband, as the former is what Linley actually gave as his inspiration: "Crawl started out in about 1995 when, having played PCHack and Moria, I managed to get hold of NetHack 3.1.3. Although I liked the randomness and the humour of it, there were some things I really wanted to fix - the targetting system, for example - and I thought parts of it, like spellcasting, could be made much more interesting (NetHack still has very few spells which weren't wand/potion/scroll effects in Rogue). So I dusted off my old Turbo C++ box and set about teaching myself C, with only a rudimentary knowledge of Commodore 64 BASIC to get me started (I wasn't connected to the internet in those days)." (From https://web.archive.org/web/20060424060820/http://tvilsom.org/roguelike/50.html) Mention Hack instead of PCHack as the latter is a direct port of Hack, and curious readers will have an easier time finding info on the original game; I certainly did! The mention of traditional RPGs, specifically Ultima IV, is hopefully interesting to people who didn't realize that PC RPGs were also an direct inspiration, particularly the limited LOS/play area of a large map seen in games like Ultima IV. Moria does already have a similar play area compared to Crawl, but Linley highlighted the influence of PC RPGs aesthetics like of Ultima in a couple of interviews. Sadly I'm only able to find one online reference where he directly mentions them: httpe://quote-un-quote.tumblr.com/post/2178789666/interview-with-shmup-legend-li nley-henzell Hopefully this addition to the narrative won't be seen as unreliable original research! Internet archaeologists reading this who find additional sources, please send them my way. I've also moved the bit about Wizard's Castle and the Orb of Zot into this first paragraph. For describing the transition from Linley as lead developer to Brent Ross, to the founding of DCSS, I've cleaned up the timeline and mentioned the two project founders, Darshan Shaligram (aka greensnark) and Erik Piper, by name. I feel it's important to highlight their very important efforts in getting DCSS started and include some basic details about that from greensnark's excellent writeup, which I've also linked. Hopefully this new history section gives a clearer picture of how the project progressed. It's possible that we could describe the subsequent "eras" of DCSS development in this section, but that's arguably even more difficult to sort out. We could highlight the addition of major features like Tiles and WebTiles, perhaps some content milestones and notable fundamental changes. I'll leave that for a future writer, after further discussion. -------------------------------------------------------------------------------- 3745823196 | gammafunk | 2021-06-05 22:33:28 -0500 Update IRC and community information Now that we've completed the move to Libera IRC from Freenode, update all references to that network and the appropriate channels. I took the liberty of updating two very minor source comments in cc/DES files to refer to conversations as being on "IRC" instead of "##crawl", so anyone reading them without pior knowledge of the old channel won't be confused. I've also updated the Overview and section of the manual to refer primarily to the community resource listing on http://crawl.develz.org instead of just listing IRC. I've added a "Contact and community information" heading to the "License, contact, history" section and put the existing community info under this heading. I've also added the DCSS subreddit to the list of community resources and adjusted the language to be applicable to both it and Discord. I've updated the IRC info to mention #crawl-dev for development. History is moved to its its own heading and will be updated in a subsequent commit. For Hints and FAQs, again refer to the website for community resources instead of just listing IRC, and update IRC listing for hints in other languages. Ideally these hints would instead refer to the website, but that would need work by translators. I've also referenced the github issue tracker over mantis in a couple places where only mantis was mentioned and referring to both would be awkward. Possibly we need to consistently mention only the github tracker and only put information about mantis in somewhere like the contributor's guide. -------------------------------------------------------------------------------- 8a41f320e8 | Nicholas Feinberg | 2021-06-04 20:09:06 -0700 Nerf peacekeeper bands in Vaults Drop them from 2-3 pals to 1-2. Peacekeepers are supposed to be top-tier Vaults threats, but not mega-top-tier. -------------------------------------------------------------------------------- e08c5e17fd | Nicholas Feinberg | 2021-06-04 18:12:16 -0700 Make the Amulet of the Air enhance air (hellmonk) Why not? Remove the +5 EV to avoid clutter. (Isn't rMsl enough?) -------------------------------------------------------------------------------- 08c3841fb2 | Nicholas Feinberg | 2021-06-04 18:04:39 -0700 Remove Okawaru's friend conduct It had little actual impact on gameplay and little flavour - mostly it was an occasional surprising annoyance. I think there's room here for a much more interesting, stronger anti-ally conduct, but I don't know when we'll get to it, and there's no good reason to leave this around in the meanwhile. -------------------------------------------------------------------------------- 373bd8bca1 | Nicholas Feinberg | 2021-06-04 18:00:23 -0700 Fix more Lear/merfolk/form bugs Don't unmeld boots when in a form that melds boots if you exit the water as a merfolk, or if you exit the form while in the water. Lear's is a kind of large boot. -------------------------------------------------------------------------------- d0ff78f834 | Nicholas Feinberg | 2021-06-04 17:36:56 -0700 Don't allow wearing items over Lear's Previously, if Lear's Hauberk was melded, you could wear aux armour that Lear's normally blocks. Don't allow that. -------------------------------------------------------------------------------- 5b7f72125b | Nicholas Feinberg | 2021-06-04 17:28:20 -0700 Warn for a rare Ash/holy/necromut issue If casting Necromutation would cause you to shatter a cursed holy wrath weapon, prompt first. This is probably buggy in some other way. -------------------------------------------------------------------------------- 8faf1edda1 | Nicholas Feinberg | 2021-06-04 17:14:23 -0700 Add message for manual for maxed skill (Yermak) -------------------------------------------------------------------------------- c6d2f85da4 | Nicholas Feinberg | 2021-06-04 17:04:34 -0700 Rewrite cause fear code (vt) Don't let the Cause Fear targeter claim to affect undead. This was a weird rabbithole and I'm not very happy with the resulting code! -------------------------------------------------------------------------------- d1902e2d21 | Nicholas Feinberg | 2021-06-04 16:32:16 -0700 Fix missing dancing weapon / gozag death message (split) There was no message at all for dancing weapons being destroyed if you followed Gozag. -------------------------------------------------------------------------------- 6385558a29 | Nicholas Feinberg | 2021-06-04 16:21:15 -0700 Simplifiy Invisibility (Yermak) Make it self-targeted only, to reduce the number of keystrokes while casting. It was possible to use Invisibility on other targets, e.g. on allies as a buff or on enemies to trick enemies into shooting them, but in practice this happened fairly rarely. In future, we might add some other effect (perhaps an evocable or unrand) that encourages those fun interactions. -------------------------------------------------------------------------------- 72385e2e4b | Nicholas Feinberg | 2021-06-04 16:10:11 -0700 Fix pet AI / non-beam spells (ardl, dang3rdave) Airstrike, LRD and Freeze will now all set pet target correctly. Possibly Irradiate and Chain Lightning should too? I'm unsure. -------------------------------------------------------------------------------- 6342a01c75 | gammafunk | 2021-06-04 09:30:45 -0500 Update some guarded unrand vaults The guarded unrand vaults are a set of minivaults that place specific unrandarts. This commit updates many vaults in this set to use a common weight, to extend placement ranges to cover later Dungeon, where applicable, and to fix other issues, especially for the recently merged ones. The common weight of 3 will ensure that these vaults don't place too frequently, and there's generally no need to have certain vaults with higher or lower weight. Remove unnecessary transparent tags where a vault doesn't have multiple exits and a few other tags like no_item_gen where that's not necessary. Update the section comments to mention the common weight and that the motivation for this is balance; we generally don't weight vaults by subjective interest, as the old comment implied. Keep the suggestion for out-of-depth monsters that are escapable, but mention that runed doors or transporters are an option if nastier out-of-depth monsters are used. Don't mention not using overpowered/useless unrands since we're always reworking unrands to make sure none are useless, and even the more overpowered ones deserve a fun vault! For specific content changes, some details are described below: minmay_guarded_unrand_tortoise: Allow this vault to actually place in Vaults as intended by making it a hard room, applying the necessary substitution to make its walls general. minmay_guarded_unrand_staff_of_olgreb: Extend placement from D:5-10 to D:5- and have three sets monsters, scaling up the three spider/insect/snake monster definitions with placement depth. minmay_guarded_unrand_finisher: Extend placement from D:7-13 to D:7-, using two sets of monsters in two tiers. Have wraiths and a skeletal warrior before D:13 and skeletal warriors and a reaper afterwards. minmay_guarded_unrand_resistance: Extend placement from D:9-D:14 to D:9 without modifications, since the monsters it places are fine for D:15. chequers_guarded_unrand_ignorance: For Dungeon, extend placement from D:7-12 to D:7- (leaving Orc unchanged). This vault is certainly dangerous enough for late Dungeon without any changes. chequers_guarded_unrand_mask_of_the_dragon: Remove the no_tele_into markers. This is a Zot vault, so players can handle being teleported inside. hellmonk_guarded_unrand_starlight: Add placement for D:13- in addition to the existing Depths placement by using cherubs instead of angels and daevas. hellmonk_guarded_unrand_salamander: Add scaling for Dungeon that uses mystics and no tyrants before D:13 and adds tyrants after. hellmonk_guarded_unrand_cigotuvi: Extend placement from D:9-D:14 to D:9-. Make the skeletons/zombies pull monster types from later depths, and for D:13- use soul eaters instead of hellwings. hellmonk_guarded_unrand_staff_of_battle: Extend placement from D:8-13, to D:8-, adding a Tengu Reaver for D:13 onwards. hellmonk_guarded_unrand_dark_maul: For Dungeon, extend placement from D:8-12 to D:8-. Revamp the monster set to use less trivial monsters holding the maul and a better set for the accompanying threats. Scale monster count with depth of placement. hellmonk_guarded_unrand_gong: Extend placement to Vaults by adding logic to place the vault as a vault room. Add 9 spawns after D:13. hellmonk_guarded_unrand_night: Extend placement from D:7-12 to D:7- by introducing satyrs along with the dream sheep after from D:13 onwards. hellmonk_guarded_unrand_gyre_and_gimble: Extend Dungeon placement from D:6-D:10 to D:7- by making the 2-handed monster be an ettin and the spriggan be a spriggan berserker with a rapier. hellmonk_guarded_unrand_vines: Extend placement from D:7-11 and Lair:1-3 to D:7- and all of Lair. Have both a regenerating monsters as well as plant monsters, using Trolls and a single Hydra before D:13, introducing oklob plants in Lair and replacing trolls with hydra, scaled with depth of placement, before replacing oklobs with a single Swamp plant monster, either a shambling mangrove or a thorn hunter. hellmonk_guarded_unrand_frostbite: Extend placement from D:7-12 to D:7-, adding nastier ice demons for D:13 onwards. hellmonk_guarded_unrand_zhor: Extend placement from D:7-12 and Lair:1-3 to D:7- and all of Lair. Scale monster counts better with depth, adding an ice dragon for D:13 onward. Use a single runed door instead of clear doors, since the latter are still pretty confusing to players, especially in terms of auto explore. hellmonk_guarded_unrand_vitality_bloodlust: Extend placement from D:7-11 to D:7-, randomizing monster counts more and adding a deep troll shaman and higher deep troll count for D:13 onwards. Closes #1937. -------------------------------------------------------------------------------- 8ece3b8c5a | gammafunk | 2021-06-04 09:30:45 -0500 Some tweaks to a few large themed vaults Several god-themed vaults in large_themed.des had never been properly updates for the creation of Depths, having absdepth conditions that never applied or just didn't make sense. Other aspects of these vaults needed updating, including more appropriate monster selection and some generalization to let them place in late Dungeon, where they're also a good fit. Some content changes for four vaults are described below. All but evilmike_library_of_no_secrets now additionally place on D:13- as well as Depths: evilmike_library_of_no_secrets: Placement is unchanged at D:11- and Depths, but adjust monster lists in both branches. Use both summoning direct damage spellcasting monsters, but using only normal and out-of-depth branch monsters. Add and place an additional monster glyph for the top-end threats rather than using a set of weights with only two glyphs. evilmike_makhleb_hellhole: For Dungeon, use common demons, kobold demonologists, and a milder selection of tier 2 "greater servant" demons. Thin out monster placement relative to Depths. For Depths, remove the now-trivial common demons and kobold demonologist, fully replacing these with hell knights and deep elf demonologists, respectively. Use a brimstone fiend as the "boss" guarding the altar instead of another hell knight. Update the "prisoner" area to not not reveal itself head of time and to contain actual loot with a more appropriate set of guards. The prisoner loot as a demon weapon and some nice potions. Make the prisoner area have a grate instead of a runed door, so as not to clutter ctrl-o. Compassionate players may elect to free them with a dig charge if they wish! evilmike_halls_of_destruction: For Dungeon, use appropriate spellcasters for the two tiers, with the second including deep elf zephyrmancers as the top end. Make the unique spellcaster boss alternate between Nikola and Jorgrun, with a deep elf annihilator backup should the chosen unique be already generated. For Depths, likewise updates the spellcasters, going up to liches for the second tier, and alternating between Frederick and Boris with an ancient lich as backup. Replace the harmless fire vortexes with salamander tyrants. Scale monster placement by branch, placing fewer iood statues and tyrants in Dungeon compared to Depths. evilmike_negative_zone: Update the monster list to be a more appropriate set of necromancy-themed monsters. Don't use ancient/dread liches, as those have no actual necromancy spells. Place different loot types in a nice arrangement instead of using a heavily random SUBST. This commit also cleans various aspects of syntax for the above vaults and a couple other vaults in larged_themed.des. -------------------------------------------------------------------------------- 4ce4c228df | gammafunk | 2021-06-04 08:44:03 -0500 Clean up lua depth checks Use you.in_branch() instead of a comparison to the you.depth() string in order to check branch location, since the latter is error-prone. This batch of changes only caught one such error, but the string comparison is case-sensitive, and you.in_branch() correctly generates an error if the argument given is an invalid branch name. Also prefer use of you.depth() to you.absdepth() when only one branch is involved, as this is clearer. It would probably be best to just always use a combination of you.in_branch() and you.depth(), since its more clear and doesn't require DES readers to look up branch absdepth values. However this requires rewriting a lot of conditionals, and I've mostly only modified one related to the first part of this patch. -------------------------------------------------------------------------------- 6ab302a81b | hellmonk | 2021-06-03 06:02:40 -0500 New guarded unrand vaults. Guarded unrand vaults for amulets of vitality and bloodlust, cloak of starlight, seven league boots, salamander hide, robe of vines, robe of night, cigotuvi's embrace, skin of zhor, lear's hauberk, shield of the gong, damnation, staff of battle, dark maul, gyre and gimble, frostbite, and rift. Comitter's Note: Merged several commits into one and updated commit comment with a full list of unrands covered. -------------------------------------------------------------------------------- bc2d63fdf1 | hellmonk | 2021-06-02 23:10:12 -0400 New spider minivault Now you, too, can collect a star_item in 0.5 a presses -------------------------------------------------------------------------------- 74d5156d8b | hellmonk | 2021-06-01 13:07:00 -0400 New Zot:5 shop vault Idea in conjunction with nicolae; a shop that sells great gear for 1 gold, appearing only on Zot:5. -------------------------------------------------------------------------------- e72e49191c | Nicholas Feinberg | 2021-06-01 07:55:36 -0700 Fix mindburst/2h ogre lore (Also ettins and maybe a few others.) -------------------------------------------------------------------------------- cae1a64fa4 | Nicholas Feinberg | 2021-06-01 07:50:33 -0700 Improve Mindburst lore (dinky) You are huge! That means you have multiple heads! Burst those minds! -------------------------------------------------------------------------------- 94dc6ad4cf | gammafunk | 2021-05-29 06:01:34 -0500 Some cleanups for a Snake rune vault Minor DES cleanups and checkwhite. Closes #1963. -------------------------------------------------------------------------------- 6ea3bcaf3c | hellmonk | 2021-05-29 06:01:34 -0500 New snake end: quicksilver temple This snake end takes its monster theme from snake ziggurat floors, which eventually place quicksilver dragons. Two of them serve as the boss. Since those are rather dangerous compared to normal snake spawns, I tried to keep the total number of monsters relatively low compared to other endings. -------------------------------------------------------------------------------- 427f276c44 | gammafunk | 2021-05-29 06:01:28 -0500 A batch of Snake vaults from nicolae (12590) A set of decor vaults and a set of monster-placing vaults. Most changes are minor, with a few substantive changes to the monster-placing vaults described below: nicolae_snake_attic_fulla_snakes: Thin out snakes in the attic a bit. It still has a lot of snakes, just not quite so many. nicolae_snake_dead_anacondas: Combine the inner derived undead anacondas into one definition and favor the more interesting/stronger types of skeletons and zombies. Use a simpler distribution for monster placement. nicolae_snake_magic_snake_eye: Don't place loot in piles on the same square, using three loot glyphs for any that need to place multiple item. nicolae_snake_naga_rites: Thin out monster placement somewhat. One can take only so many ritualists. nicolae_snake_snakewalk: Used fixed loot classes. There are only 4 loot items here, so we can just put 4 higher quality items. Thin out the monster placement slightly. I elected to not thin out monsters in a similar vault using out-of-depth monsters in this batch, nicolae_snake_storage_room, since it places far richer loot. -------------------------------------------------------------------------------- 423d0e134b | gammafunk | 2021-05-29 00:49:39 -0500 Some DES file cleanups Move a multi-branch snake-themed vault to mini_monsters.des, move another vault in this file to the appropriate file section, and update the file header comments. -------------------------------------------------------------------------------- 3e9cee4cb2 | gammafunk | 2021-05-26 16:08:34 -0500 Reduce monster count in a vault (Ge0ff) The vault nzn_swamp_stair_ambush places 8 guaranteed monsters near stairs in a small area. While this is within acceptable bounds, it's on the hard side of things, and additionally there's no monster count randomization, which we like to have for monster-placing vaults. Remove three monsters on-average by adding appropriate chances for shallow water or floor instead of a monster in some places. -------------------------------------------------------------------------------- cd1846a45e | advil | 2021-05-26 16:11:58 -0400 fix: use correct quiver for lua items.fired_item() This was getting the item behind the primary action, which is either the wielded weapon or ammo used by the wielded weapon, but not in general what the quivered item is. The doc string was also only correct for an intermediate implementation of quivering. -------------------------------------------------------------------------------- 35abcb988c | gammafunk | 2021-05-26 02:05:59 -0500 Make a loot vault diggable (Mels) The vault minivault_21 is an old vault that places loot behind fully undiggable walls, but with escape hatches should the player land inside. The loot is inaccessible for a large majority of players, since they'd have no way to break stone walls. This commit makes the vault rock so that most players can eventually access the interior eventually (e.g. with digging). Also remove the allow_dup tag, since it places a good deal of high quality loot. There's not need to give such nice things more than once per game! -------------------------------------------------------------------------------- 8631133539 | advil | 2021-05-24 10:39:48 -0400 fix: don't overwrite (jobbed) draconian breath spells A draconian with a job usually has a spellbook, and this code would overwrite their breath weapon with that spellbook. This appears to be unintentional, and is pretty old. The bug was not apparent because the describe code doesn't actually use the monster spell list to show the breath weapon; see mon-util.cc `get_unique_spells` and describe-spells.cc `_monster_spellbooks`. (In general, this code is not what I expected and is probably ripe for bugs like this...) -------------------------------------------------------------------------------- 20e75d603b | Nicholas Feinberg | 2021-05-24 07:32:41 -0700 Fix quicksilver ooze AF desc (dinky) -------------------------------------------------------------------------------- 601b473118 | Nicholas Feinberg | 2021-05-22 20:03:37 -0700 Merfolk Long Blades title: Swordfish (hellmonk) -------------------------------------------------------------------------------- 813e06a757 | advil | 2021-05-22 18:11:55 -0400 fix: remove a likely unapropos weapon name Because "banish" has a specific meaning in crawl, "Banisher" as a weapon name is very likely to be inconsistent with the weapon flavor. (I spotted this while looking at learndb unapropos names, specifically, `+1 trident "Banisher" {holy, +Blink rPois MP+9}`.) -------------------------------------------------------------------------------- b8eb6cee8e | Kate | 2021-05-22 01:12:21 +0100 Simplify flaying Make it closer to torment-lite, dealing a fixed 25% of current HP instead of its previous fairly complicated damage calculation. -------------------------------------------------------------------------------- 73eefd5def | gammafunk | 2021-05-19 22:19:46 -0500 More cleanups for Ozocubu's Refrigeration The check for whether a target was vulnerable used some outdated logic, and the UI for players casting this spell didn't even perform the check in the first place. Hence players casting the spell with only rC+++ monsters in LOS would not get the usually prompt about a useless cast, even though all visible targets are immune. This commit fixes this logic, adds a tracer check, and refactors the LOS attack spell code slightly. -------------------------------------------------------------------------------- e80a49f48c | gammafunk | 2021-05-19 14:26:12 -0500 Fix spell -Potion application (AliasTheSpectator) If the player had rC+++ and cast Ozocubu's Refrigeration, their immunity to its damage accidentally prevented application of -Potion. The player spell doesn't damage the player even without the immunity granted by rC+++, but this bug emerged as a holdover from when the spell did self-damage. This commit applies the debuff unconditionally. -------------------------------------------------------------------------------- 8b4daa1eef | Nicholas Feinberg | 2021-05-18 17:18:53 -0700 Dart slug: nerf damage, buff cast rate (hellmonk) To have mercy on poor felids, decrease damage to 2d3 (from 2d4) and increase cast rate to 30% (from 20%). Given the existence of AC, this should more or less balance out. -------------------------------------------------------------------------------- a233589e6f | advil | 2021-05-18 13:03:34 -0400 refactor: clean up some vaults monspec code, document No behavior changes, but fix up a 9 year old stylistic choice I'm not a fan of and make the documentation/comments a bit clearer for people looking at this for the first time. -------------------------------------------------------------------------------- e86db4a01e | Nicholas Feinberg | 2021-05-17 20:15:30 -0700 Weaken early D vault OODs Cap 8s and 9s to only spawning monsters up to (depth * 2) until D:9. This roughly corresponds to the range for which chaff was removed in dd57cda9ea3d35 . -------------------------------------------------------------------------------- 18a14b5c60 | Nicholas Feinberg | 2021-05-17 20:15:29 -0700 Weaken early D OODs Removal of chaff from the D spawn pool made OODs much nastier than they were in the past. Let's have no more D:2 water mocassins or steam dragons. -------------------------------------------------------------------------------- ee19b5822f | Nicholas Feinberg | 2021-05-17 09:08:07 -0700 Revert Sacrifice Hand piety change Back to 65 piety, from 60. Sacrificing your hand is an iconic and very cool Ru experience - it's fine for it to be a little stronger than other sacs, since it's fun! -------------------------------------------------------------------------------- 5f64966fcc | Kate | 2021-05-17 00:31:58 +0100 Fix Yred/Beogh recall cancelling Ozocubu's Armour Recalling offlevel allies moved the player to 0,0 in order to silence messages about expiring enchantments on them. However, this movement also resulted in Ozocubu's Armour and Frozen Ramparts being cancelled. Use msg::suppress to silence any such messages instead. Cheibriados Time Step and Temporal Distortion do still move the player to 0,0 so have the same problem (and would need a different approach to fix it). -------------------------------------------------------------------------------- 7fc4abc71e | Kate | 2021-05-16 20:07:03 +0100 Give Chuck some more exciting rocks Since the returning brand doesn't do anything special for him with monsters getting infinite ammo. -------------------------------------------------------------------------------- d55d32fc2f | Kate | 2021-05-16 20:04:26 +0100 Adjust some monster ammo quantities Since monsters now have infinite ammo, remove some cases where they were given additional ammo to make them less likely to run out. Also reduce some quantities of rarer ammo (such as curare and branded javelins) to reduce the amounts handed out to the player. -------------------------------------------------------------------------------- 41d2c3503b | Kate | 2021-05-16 18:48:41 +0100 Remove unused cloud immunity mutations But leave their functionality intact for transferred games, rather than add more save compatibility hacks for old demonspawn. -------------------------------------------------------------------------------- 245c70e1c0 | Aliscans | 2021-05-15 11:35:43 -0700 Let a Kikubaaqudgha-worshipping wizard create endless gifts. The wizard mode "get a god gift" command now creates one first level spellbook (if you have had no gifts from Kikubaaqudgha yet), followed by any number of second level ones. -------------------------------------------------------------------------------- 81437c0335 | Aliscans | 2021-05-15 11:35:43 -0700 Simplify _give_kiku_gift(). Rather than have the game use variables such as "gift" and "success" to track whether to return true, return false as soon as something fails. Make the items() call always create a book of Necromancy. This should have no effect as make_book_kiku_gift() overwrites it. Return immediately if items() fails, rather than calling make_book_kiku_gift() on env.item[NON_ITEM] first. -------------------------------------------------------------------------------- b0971d1698 | Aliscans | 2021-05-15 11:35:43 -0700 Simplify _give_sif_gift(). Rather than have the game use the "success" variable to track whether to return true, return false as soon as something fails. -------------------------------------------------------------------------------- bc5ded6cda | Aliscans | 2021-05-15 11:35:43 -0700 Split _gift_sif_kiku_gift() into a function for each god. There wasn't much common code, and this makes the flow easier to follow. -------------------------------------------------------------------------------- 7b0c17a4f7 | Aliscans | 2021-05-15 11:27:28 -0700 Fix what happens when you try to read a spellbook. Make the game give a "You aren't carrying any scrolls." message if you try to read() when you have no scrolls in your inventory or on the floor, but there is a spellbook on the floor. The game had given an inventory prompt with no items on it instead. -------------------------------------------------------------------------------- 7c134c3035 | Nikolai Lavsky | 2021-05-15 10:09:15 -0700 Highlight Curl's AC boost on webtiles HUD (12567) Highlight boosted AC when palentongas curl up. -------------------------------------------------------------------------------- 5e56b55837 | Nicholas Feinberg | 2021-05-15 10:04:01 -0700 Fixup sac validity logic We already check whether a mutation is at max level; no need to double-check it. (This logic also turned off a bunch of other validity checks for skill/xp, probably unintentionally.) Closes #1916. -------------------------------------------------------------------------------- 3ec4c25e8c | Nicholas Feinberg | 2021-05-15 10:03:28 -0700 Checkwhite -------------------------------------------------------------------------------- 145365d198 | hellmonk | 2021-05-15 10:03:28 -0700 slightly increase ru sacrifice timer -------------------------------------------------------------------------------- 41ace87d0d | hellmonk | 2021-05-15 10:03:28 -0700 Account for spellcasting skill when sacrificing wizardry. Instead of just looking at int, account for any spellcasting training when calculating piety, since that's a good indicator the player is casting things. -------------------------------------------------------------------------------- eccaff0f4d | hellmonk | 2021-05-15 10:03:28 -0700 Allow multiple levels of sacrifice experience. Much like sacrifice skill, the mutation already allowed this but additional validity checks forbid it. Sac experience may now be taken up to three times for a total of -6 xl and the piety gain has been decreased somewhat. It would be ideal to make sacrifice experience directly reduce the player's level rather than stepping through xp (so that it's a relevant sacrifice at all stages of the game rather than only relevant briefly upon taking and very lategame) but that seems rather complicated to implement. -------------------------------------------------------------------------------- 4e7b9e3c90 | hellmonk | 2021-05-15 10:03:28 -0700 Adjust sacrifice skill. Allow the player to take it up to three times. The mutation already supported this, but a check in _sacrifice_is_possible prevented ru from offering it again once it was taken. I am not sure if this was intentional or not. This commit also adjusts the piety downward somewhat for the first sacrifice, but more piety is given if the player elects to take it multiple times. -------------------------------------------------------------------------------- 7f30ced503 | hellmonk | 2021-05-15 10:03:28 -0700 Adjust some sacrifice piety values. Nerf sacrifice resistance somewhat and sac hand slightly. Buff sacrificing willpower and love; those are more serious drawbacks than the old values indicated, especially when comparing sac willpower to sac resistance. -------------------------------------------------------------------------------- e960553459 | hellmonk | 2021-05-15 10:03:28 -0700 Add a piety bonus for sacrificing words and drink together. Taking this combination shuts down a lot of options, so award a little piety bonus. Mummies will also get a bonus for sac words now for the same reason. -------------------------------------------------------------------------------- 834f9addc8 | hellmonk | 2021-05-15 10:03:28 -0700 Don't give piety for evo skill when sacrificing mp. -------------------------------------------------------------------------------- c5a3f79286 | Nicholas Feinberg | 2021-05-15 09:20:46 -0700 Devilishly good new tiles (Sastreii) Makhleb altar and the Hellbinder. -------------------------------------------------------------------------------- 56a4fb2168 | Nicholas Feinberg | 2021-05-15 09:03:51 -0700 Deduplicate excommunication XP -------------------------------------------------------------------------------- c127bba4f6 | Nicholas Feinberg | 2021-05-15 09:00:55 -0700 Make Sac XP pricier Rather than just costing the player two XLs of XP, actually increase the cost for all future XLs as if the player was still at their original XL. This should make it a much more consistently meaningful sacrifice, rather than one which becomes mostly irrelevant for most of the game (due to how XP cost scaling works). No adjustment to piety right now, though I can imagine it going up slightly. (It was fairly over-valued before.) -------------------------------------------------------------------------------- fb435604d7 | Nicholas Feinberg | 2021-05-15 08:09:38 -0700 Fix GDR comment typo (nlavsky, goratrix) -------------------------------------------------------------------------------- aa87e14f67 | Nicholas Feinberg | 2021-05-14 11:19:34 -0700 DRR AC GDR (hellmonk) Remove weird breakpoints for GDR effectiveness at even-numbered AC values. This does not matter. -------------------------------------------------------------------------------- 40ce562a0f | Nicholas Feinberg | 2021-05-14 08:44:32 -0700 New wizlab tiles (Sastreii) Zonguldrok (antique lich + shrine), Moon Base (walls), and also a tweak to the new Murray tile. That's not a wizlab thing but no one told Murray. -------------------------------------------------------------------------------- c4ce80cea6 | Nicholas Feinberg | 2021-05-14 08:32:15 -0700 WIP -------------------------------------------------------------------------------- ff078d554e | Nicholas Feinberg | 2021-05-14 08:16:48 -0700 Simplify GDR Guaranteed damage reduction is intended to smooth out some of the nastiness in Crawl combat. It guarantees that your AC will never roll below some % of its max value when defending against melee attacks and mundane projectiles (not against spells, etc). This is a mostly reasonable idea, but it's implemented bafflingly: it uses your base AC OR a hodge-podge of special cases based on your species and/or form, meaning that it's both spoilery and weird. Some AC is effectively worth more than others. Not great! Instead, simplify it to be based purely on the player's current AC. (Specifically, AC^(1/4) * 16.) Previous example values: Robe: 0% Scale mail (ie Fi): 28% Plate: 39% New values: AC 6 (ie Fi): 25% AC 20: 34% AC 50: 43% This is a buff to some things (anything that didn't have GDR before) and a nerf to other things (early plate). It's all over the place. Chaos reigns. (But in practice I suspect the difference will be mostly unnoticable.) -------------------------------------------------------------------------------- fdeffcb720 | Kate | 2021-05-13 19:27:43 +0100 Fix meph chance display -------------------------------------------------------------------------------- 9a643b30eb | gammafunk | 2021-05-13 05:44:09 -0500 Adjustments to two volcano maps For hellmonk_zot_springs, thin out the upper-tier monsters in the main chamber, since it felt a bit too fierce in play-testing. The middle-tier molten gargoyles are pretty tough at this depth as it is, so multiple salamander mystics and the other higher tier threats compound the difficulty of this map with each additional placement. Make the upper-tier set not include molten gargoyles, so we won't place too many of those, since the middle-tier placement already places four on-average. For syntax, reglyph to use consistent glyphs for monsters and items and to use a linear glyph progression. Fix the middle-tier monster NSUBST of 3 to not use ':' when placing the next tier on 4, since this would place either six of such monsters or zero, which seems unintentional (and undesirable). Clean up water tile placement and reorganize statements. For hellmonk_pyromancer_palace, reglyph decorative lava so we can mark it no_tele_into without marking the non-decorative lava. Closes #1949. -------------------------------------------------------------------------------- 7c0e23aee5 | hellmonk | 2021-05-12 22:53:31 -0500 Fix an incorrect glyph in hellmonk_smoking_crater -------------------------------------------------------------------------------- 5e02258609 | hellmonk | 2021-05-12 22:53:31 -0500 Deep elf pyromancer volcano. Pyromancers galore; deep elf archer serves as the boss. -------------------------------------------------------------------------------- 58c629d5e2 | hellmonk | 2021-05-12 22:53:31 -0500 New volcano map: zot springs Based on the legendary zot vault. Places humanoids, steam clouds. No eruptions. -------------------------------------------------------------------------------- 4505690ab0 | Nicholas Feinberg | 2021-05-11 21:41:46 -0700 New monster tiles (Sastreii) Boulder beetle, black bear, polar bear, zombie dragon, and Mnoleg. -------------------------------------------------------------------------------- a92136e5f8 | Nicholas Feinberg | 2021-05-11 21:17:10 -0700 Tweak Dj apts (pubby) Increase XP apt by 1 (0 -> +1) and drop spcast 1 (-2 -> -3). The goal here is to increase the odds that new spells will require some investment by the time you get them, rather than being immediately castable. This could encourage strategic decisionmaking (is this new spell worth investing in?). It's also intended to make =wiz more useful for Dj. -------------------------------------------------------------------------------- b3d8e82157 | advil | 2021-05-10 14:54:44 -0400 feat: add a way to reset the !a warning without swapping (Yermak) This is a very minimal change to allow this, it resets the warning as a side effect of rewielding. This is not great UI and it's a bit of a hidden feature, but as Yermak pointed out, there are corner cases where you really want something like this (e.g. Ash, + accidentally hitting y or using it one-off for something like rampaging). I've at least documented the behavior. This flag is used for ranged weapons as well as !a-inscribed weapons. -------------------------------------------------------------------------------- e0cfffa631 | Kate | 2021-05-10 14:52:30 +0100 Update manual entry for grey draconians -------------------------------------------------------------------------------- 3f2173a928 | gammafunk | 2021-05-10 03:11:45 -0500 Fix dart descriptions (Goratrix) 0b7d3b79 updated the descriptions, but incorrectly changed the entry to one for needles. -------------------------------------------------------------------------------- 0b7d3b79db | Kate | 2021-05-10 02:52:05 +0100 Update needle descriptions -------------------------------------------------------------------------------- e7c6dc9676 | Kate | 2021-05-10 02:28:38 +0100 Let classed monster grey draconians swim Previously only base grey draconians could travel through water. -------------------------------------------------------------------------------- a3e552604e | Kate | 2021-05-10 02:21:07 +0100 Remove unbreathing (mostly) Unbreathing had a number of niche effects but was mostly redundant with rPois and undead/nonliving/plant holiness. Instead make the things that checked it just check holiness and rPois directly as appropriate. Affected mechanics are mephitic cloud confusion and curare damage (both now only check rPois, since all undead/nonliving/plant holiness creatures have rPois anyway), and spore confusion and water drowning damage (both now just check undead/nonliving/plant holiness). Very few monsters/species behave differently as a result - grey draconians, iron dragons, slimes, smoke demons and ophans are now fully affected by the above mechanics (unless their rPois grants them immunity in the cases of meph and curare). Grey draconians gain regular amphibiousness instead of the unbreathing flavour, removing the need for special-casing them in water. -------------------------------------------------------------------------------- a67198749c | Kate | 2021-05-09 18:45:20 +0100 Don't allow Wu Jian attacks or ripostes with nonweapons -------------------------------------------------------------------------------- 099f9bb0e8 | Nicholas Feinberg | 2021-05-07 15:58:35 -0700 New Sastreii tiles Mundane boots, Murray, Nergalle and Snorg, in that order. -------------------------------------------------------------------------------- 28e009f8a6 | gammafunk | 2021-05-06 12:36:34 -0500 Unrename a vault This vault was apparently intentionally renamed in 2394d0fb to change "ooze" to "endoplasm", but the vault never placed a monster that got renamed to endoplasm. It did place a death ooze, which got replaced with a quicksilver ooze, so the original name is still appropriate. In any case, renames should be avoided unless the old name would somehow generate confusion or a new naming format is used for a set of related vaults, neither of which is the case here. -------------------------------------------------------------------------------- 6ee8fce0c9 | gammafunk | 2021-05-06 06:37:52 -0500 Update a digging-themed vault (Lightli) The vault wad_dig_loot had a hidden diggable area with a nasty monster spawn and loot. We've moved away from having completely hidden spoilers like these, prefer our spoilery vaults to at least broadcast their uniqueness to some degree. This vault didn't do anything special with its secret area, so instead update the chamber to be visible, but introduce digging monsters at later depths. Also add Elf to the placement list, since we have a unique digging monster there, and scale the monster and loot count with depth. Now it places two 8 spawns from D:12-15, three 8 spawns in Elf, and four in Depths, with each new monster also generating another loot item. Also fix its teleport closet by marking the loot chamber no_tele_into. -------------------------------------------------------------------------------- 3ef0f4ec91 | Kate | 2021-05-05 18:47:26 +0100 Fix Ignite Blood mutation description -------------------------------------------------------------------------------- 0b992a5a9d | advil | 2021-05-03 19:40:49 -0400 fix: remove a duplicate BREATHE_POISON (12579) This led to cosmetic duplicates of this ability on the `a` screen. -------------------------------------------------------------------------------- 81dfa19a63 | dilly | 2021-05-03 17:12:53 -0400 Minor fix for gnrine It wasn't green enough. -------------------------------------------------------------------------------- 0b80122b6a | advil | 2021-05-03 15:23:26 -0400 Update sdl2-image for android builds Per #1892. -------------------------------------------------------------------------------- 0a9fa4a780 | advil | 2021-05-03 15:23:26 -0400 Update sdl2-mixer for android builds Per #1892. -------------------------------------------------------------------------------- a4d602e826 | advil | 2021-05-03 15:23:26 -0400 Bump lua contrib for android builds This updates lua and fixes some issues with android builds, per PR #1892. I'm merging this slightly differently than in that PR just to be a little more careful, these changes since other builds depend on these contribs as well. -------------------------------------------------------------------------------- 2a531a4d09 | Kate | 2021-05-03 15:52:38 +0100 Add some missing cloud descriptions -------------------------------------------------------------------------------- 715e165ca6 | Kate | 2021-05-03 15:52:38 +0100 Fix spelling -------------------------------------------------------------------------------- a7b940fc0e | Kate | 2021-05-03 15:52:38 +0100 Tweak portal timer wording They were fairly misleading - "nearby" portals were extremely close, and "distant" ones were also still quite close. Add an extra level of distinction, and use multiples of default LOS range for the differences between ranges. -------------------------------------------------------------------------------- 9b0c66ea95 | Kate | 2021-05-03 15:52:38 +0100 Make poison and miasma clouds affect unbreathing creatures again This was considered a bug when it was changed previously, however it was actually intended behaviour (and only mephitic clouds explicitly mention in their description that unbreathing creatures are immune). Unbreathing is a fairly complicated mechanic so reducing the number of things it effects is probably better, and the change also had some strange knock-on effects like making grey draconians immune to sickness, which doesn't fit flavour-wise. Revert to the original behaviour, and update some descriptions to hopefully make it clearer. This reverts commits e1f20c3b445d4e6f4d869a2e080ec252b498914c and 368d90fffdfadd77c1e5298e59cdf97a51697a67. -------------------------------------------------------------------------------- 564068e7f7 | Kate | 2021-05-03 15:52:11 +0100 Adjust potion of mutation probabilities It was very easy to reliably remove bad mutations with just a few potions of mutation due to them removing 2-4 mutations as their first effect, and to acquire a mostly or entirely positive mutation set due to the guaranteed good mutation at the end. While they should still be useful for clearing out bad mutations, the consistency was a little too high, so reduce the number of mutations removed to 2-3, and reduce the chance of adding a good mutation at the end from 100% to 50% (so that the overall number of mutations added/removed on average also remains the same). -------------------------------------------------------------------------------- 97766e7410 | Kate | 2021-05-03 12:56:04 +0100 Remove wispform's blinkitis and extra speed Random blinking was an especially annoying feature even for a form that's intended to be dangerous. The monster that the form was based on also no longer exists, so instead just make wispform standard speed (distinct from bat/pig badforms which are fast), keeping the existing downsides of most other badforms of melding equipment and preventing weapon or spell use. -------------------------------------------------------------------------------- 131cd56ac5 | gammafunk | 2021-05-03 03:40:42 -0500 Some tweaks to an ice cave map For ice_cave_azure_passage, some tweaks to the monster set and placement, and some DES syntax cleanups. For the monster set, remove shapeshifter simulacra, which are far too weak. Leave in the somewhat stronger glowing shapeshifter simulacra, and add in demonic crawler simulacra. The latter make decent lower-tier threats and fit the "aberration" theme. Also add in very ugly thing simulacra, but at half weight. These are somewhat nasty, but characters with some rC shouldn't find them too difficult. For the slime creature placement, the seven bands currently placed is excessive. Reduce this number by about half, replacing them with 2/3 chance for simulacra and 1/3 chance for quicksilver oozes. For DES syntax, reorganize to use normal monster slot glyphs where possible. Use a simpler SHUFFLE+SUBST instead of a more verbose lua conditional. Reindent statements and reorganize to have a consistent order. I've also renamed the map to ice_cave_hellmonk_azure_passage. Keeping the ice_cave prefix is good for consistency with other maps in this file, but we should include the vault author's name when possible. Closes #1933. -------------------------------------------------------------------------------- fa0a1138f8 | hellmonk | 2021-05-03 03:40:42 -0500 Slime themed ice cave. Places various Jiyva-adjacent simulacra, a few ice statues, slime creatures, and various high level slimes as the boss monsters (including a guaranteed azure jelly). -------------------------------------------------------------------------------- 2f9bb313c0 | Nicholas Feinberg | 2021-05-02 20:13:27 -0700 Zappify dispel undead (ardl) This removes a cap on damage that was added all the way back when dispel undead was first added in 0c7d47c22ef, but that, afaik, could never actually be hit except by very high HD panlords or player ghosts. -------------------------------------------------------------------------------- 2a214b436d | advil | 2021-05-02 12:09:58 -0400 fix: blanket no_tele_into for gammafunk_dig_for_victory We really need a better way to write no_tele_into KPROPs; in this case I think what probably happened is that the KPROP got out of sync with later changes to the vault, though I stopped trying to debug the details. Looking at the vault it seemed simpler to just blanket prevent teleporting into the whole thing. (Perfectly fine with me if someone wants to go back and fix the KPROP though.) I've also applied a similar tweak to passability as that in 3a4c58a182d1; while working on the tele fix I noticed that this vault would likely lead to similar connectivity issues as seen in #1909, because of the conditional CLEAR. Resolves #1812 -------------------------------------------------------------------------------- 4d8f0be3d4 | advil | 2021-05-02 11:41:47 -0400 feat: allow setting tiles window width by ratio On the previous defaults, the tiles window width was screen edge - 90 in both dimensions. This works fine on many screen ratios, but is kind of annoying (in my opinion) on an ultrawide screen. This commit provides an option to override the width setting using a ratio of the height, and makes it activated by default. When activated, the width setting is instead used as a maximum value. This has no impact on full screen mode. This can be disabled by just setting `tile_window_ratio` to 0 or a negative value, in which case the behavior is the same as before (including if you had custom values set here). I've used the golden ratio as the default value, so on a 4:3 screen you'd typically have the same default results as before, but on a wider screen the window default width will be capped. This looks (again, IMO) a lot better on an ultrawide ratio like 2:1 or greater. It would be ideal, eventually, to actually remember positioning and size. -------------------------------------------------------------------------------- 673ba79eab | advil | 2021-05-02 10:44:53 -0400 fix: cap Ashenzari scry radius at los A kobold with a scarf of shadows has a los of 3, but the ash scry radius would go up to 4 at full piety. This commit fixes at least two bugs for this case: * in all build targets, the "comes into view" messages would happen at los 4 instead of 3, even though the monster would not be fully visible (e.g. shown as a sensed monster) * in local tiles, radius 4 would be highlighted as if it were in los, but only the background tile would be drawn, not even monster memory or sensed monster icons. Resolves #1844 -------------------------------------------------------------------------------- bf574a6a6b | Kate | 2021-05-02 00:06:28 +0100 Don't allow cancelling forced blinks with Ozo's Armour (Psymania) -------------------------------------------------------------------------------- a84896973d | advil | 2021-05-01 17:17:33 -0400 fix: do hepl ancestor setup when receiving ancestor Before 9dc9f58f1f8, setting up the name prop and generating the ancestor itself were done together in _join_hepliaklqana, ensuring correct sequencing. After this commit, they were separated; this becomes an issue for monks, who get their piety bonus when joining (triggering the ancestor generation code) before the on_join function is called, leading to an empty name and crashes. Instead, ensure that the name and gender are set up any time the monster is instantiated, including the first, rather than in an on_join function. -------------------------------------------------------------------------------- 62a2e9f2fb | advil | 2021-05-01 13:04:27 -0400 fix: swap a mutation check for felids This doesn't really matter, because felids have both mutations and nothing else does, but it's good to be correct. (Also, a minor unrelated whitespace fix.) -------------------------------------------------------------------------------- 91b3acb402 | Neil Moore | 2021-05-01 01:19:45 -0400 Don't crash when the first of two ancestors dies Actually fixing up the second ancestor in tags.cc would be better, but that is tricky because one or both ancestors might be off-level, and the daction to handle that case would destroy them both. Instead, let the extra ancestor die normally, but without triggering DUR_ANCESTOR_DELAY. -------------------------------------------------------------------------------- 00726eb06d | Nicholas Feinberg | 2021-04-30 16:34:33 -0700 Fix: don't spawn hep ancestor until 1* Overlooked the code to respawn dead ancestors over time. Oops! -------------------------------------------------------------------------------- 6f521eb9b9 | Nicholas Feinberg | 2021-04-30 15:15:41 -0700 Only trigger spectral on melee (kingbuddyboy) Don't allow ranged attacks to re-trigger existing spectral weapons. -------------------------------------------------------------------------------- b2b6fe9c5e | Nicholas Feinberg | 2021-04-30 08:41:47 -0700 Show actual attack delay on @ It's not a secret! We display it in the inventory and every time that you swing your weapon - no need to add secret mystery adjectives. -------------------------------------------------------------------------------- e39799b483 | Nicholas Feinberg | 2021-04-30 08:34:29 -0700 Remove sInv from axes Pretty good targeter bug. I think ardl or dilly or someone reported this but I couldn't find the message when I looked for it again, sorry! -------------------------------------------------------------------------------- 9dc9f58f1f | Nicholas Feinberg | 2021-04-30 08:24:56 -0700 Move Hep frailty & ancestor to 1* Hepliaklqana was one of the last gods that provided a benefit at 1*. In general, the tension of having to worship for a little while before actually getting an upside from your god (assuming you haven't taken some other tradeoff, e.g. an ecumenical altar or a Monk start) tends to produce more interesting gameplay. Along with recent major Hep buffs, it seemed like it was finally time to make this change. -------------------------------------------------------------------------------- 4f6a661ab4 | Nicholas Feinberg | 2021-04-30 08:24:56 -0700 WIP hep nerf -------------------------------------------------------------------------------- 3e6434628b | advil | 2021-04-30 11:14:09 -0400 fix: reorder messaging for irradiate No need to give the blasting message for protected allies. -------------------------------------------------------------------------------- 4302cc2033 | advil | 2021-04-30 11:06:54 -0400 lint -------------------------------------------------------------------------------- 276f4da11a | advil | 2021-04-30 10:37:56 -0400 refactor: unify hepl and fedhas ally protection Historically, these allies were treated quite differently, but ab74d117c10 put them closer together by allowing some attacks to pass through ancestors. However, like the original fedhas protection implementation, this check is sprinkled all over the place leading to inconsistent behavior between special cases and reports like #1925 (deja vu for those who did the original fedhas bugfixing). This commit continues the trend by doing the checks in exactly the same places, leading to cleaner code and a more consistent set of religious ally protections. Unlike the previous commit that refactors fedhas, this commit is an expansion: hepl ally protections now cover a whole bunch of cases (various spells, clouds, etc) that weren't considered in previous commits, and hep allies should now be immune to all sorts of area spells like refrigeration. But it is much cleaner from the player's perspective, and code perspective, to give these two cases exactly the same protection, once shoot-through is allowed for ancestors in the first place. One awkward case I am still aware of is OoD behavior, where the ancestor is protected from damage but seems to block the orbs (with or without a shield). In the long run it would be nice to continue generalizing this code to cover demonic guardians, conj projectiles, etc., but the more general it is, the harder it is to get the messaging right for all cases, so I aborted trying to do that for now. Resolves #1925 -------------------------------------------------------------------------------- 7b2b3e46e3 | advil | 2021-04-29 18:13:46 -0400 refactor: abstract some common fedhas code The code to check whether Fedhas protects an ally is repeated in a number of places in a way that is a bit error-prone (in fact, most cases seem to not be handling all the attitude possibilities). This commit abstracts this into a common location with some relatively simple way to call it. This could be even more abstracted into something that covers non-god cases that often show up nearby fedhas checks (e.g. demonic guardian). I actually started to do this and it's trickier than it seems, though. -------------------------------------------------------------------------------- 946c659c87 | advil | 2021-04-28 11:35:29 -0400 fix: disable cleaving during fsim I'm not sure if this is new or old (but I'm surprised to see no reports about it if the latter), but right now, if you fsim with a cleaving weapon while adjacent to a real monster, the real monster takes damage (and may die, grant xp, etc). Probably it would be nice to somehow have a way to factor in cleaving to fsim, but this isn't it. So, simply disable it for now. -------------------------------------------------------------------------------- bc3fc7707e | advil | 2021-04-28 11:09:56 -0400 fix: disable decapitation during fsim 910b67f9770a fixed the main case for #1917, but it was still possible to trigger a crash by fsimming directly against a one-headed hydra. To handle this, disable decapitation insta-kills for simulated attacks. (Arguably, it might be better to accurately represent the damage involved in an insta-kill, but this is a lot simpler.) -------------------------------------------------------------------------------- 910b67f977 | advil | 2021-04-28 10:23:24 -0400 fix: save head count across fsim rounds This restores the head count after a single fsim round. It's possible that some people were using the simulation of head growth, but allowing head growth or cauterization makes the calculation across rounds against hydras pretty unreliable (and leads to crashes). It's of course possible to specify head count in the monster spec for people who want to test particular cases. Resolves #1917 -------------------------------------------------------------------------------- 38810cc1a4 | advil | 2021-04-28 10:12:12 -0400 fix: handle tab at weapon select menu This was simply missing a `break` in the custom menu code for handling the case; focus cycling was being correctly overridden. Resolves #1339. -------------------------------------------------------------------------------- e311f74bc8 | gammafunk | 2021-04-27 20:19:57 -0500 Some cleanups for a volcano map For hellmonk_smoking_crater, slightly increase the number of upper-tier monsters, adding one more on average over two locations. This map feels on the easier side unless you rush in quite recklessly, and it doesn't have the usual cloud gimmicks to try to "force" players to a particular area. Increase the chance of cloak of the thief to be something a player might actually see over the course of many games. Reglyph the vault to not override pre-defined glyphs, and clean up syntax and spacing. Closes #1929. -------------------------------------------------------------------------------- e4e9b07c1e | hellmonk | 2021-04-27 19:42:56 -0500 New volcano map with a smoke/steam theme. Places a highly variable number of monsters; lots of steam dragons. Loot includes a couple of fog scrolls or cloak of the thief (rarely). No eruptions. -------------------------------------------------------------------------------- 7f87ac42b0 | Kate | 2021-04-27 21:52:28 +0100 Remove some duplicated artefact checks Elyvilon being prevented from being named on */+Rage items was redundant since weapons aren't eligible to be named after Ely, and -Cast conflicting with rings of fire/ice/wizardry/MP was also redundant since -Cast can only appear on armour and amulets. Moves a couple of other checks back to _artp_can_go_on_item rather than _randart_is_conflicting. -------------------------------------------------------------------------------- f2daf0da32 | Kate | 2021-04-27 21:52:19 +0100 Adjust some more artefact restrictions Prevents -Cast and +MP on the same artefact, and prevents Trog from gifting items with +Int. Also adjusts which item types can be named after which gods - quick blades can now be named after Chei (since they're no longer a hated item), and non-weapons can't be named after Trog. -------------------------------------------------------------------------------- 71c9e0f10e | Kate | 2021-04-27 21:47:49 +0100 Mark a teleport closet as no_tele_into In onia_ninara_dug_in_and_dangerous. -------------------------------------------------------------------------------- 7bfb9e8c44 | advil | 2021-04-27 12:27:26 -0400 fix: correctly check antimagic brand conflicts for randarts The `get_weapon_brand` call here simply doesn't work, returning SPWPN_NORMAL. I think this is because the brand prop is not yet set up on `item` (past a point I stopped trying to figure out exactly what the problem was). Possibly this check should be in `_is_randart_conflicting` anyways? I was able to replicate this in 0.25.1 with the seed from @Goratrix in the issue: resolves #1322. -------------------------------------------------------------------------------- 7ea0e0ed02 | advil | 2021-04-27 12:04:48 -0400 fix: remove "Power" from rand_wpn.txt This is generally confusing with the unrand sword of Power, and can actually in rare circumstances generate e.g. "the great sword of Power" (I just saw this in a test game). -------------------------------------------------------------------------------- fbe13134a7 | advil | 2021-04-27 10:25:08 -0400 fix: always announce xom chaos branding The message ordering when Xom granted an item and "upgraded" it to chaos was confusing, because the item was announced before the brand took effect. (I suspect this changed at some point.) Rather than try to work out how to fix the message ordering, this commit leans into this effect and just announces the change after the item generates (still letting the player know what they would have gotten). It's still not very explicit about removing the old brand, but hopefully this will be clear enough. Also: * Standardize Xom's chaos upgrade using the same message as in regular branding. Possibly more boring, but also more predictable. * Clean up some code for Xom upgrading ally weapons. Resolves #1865 -------------------------------------------------------------------------------- 3287b30435 | advil | 2021-04-27 10:25:08 -0400 fix: check form in player::could_wield Other checks (e.g. size, handedness) mostly conspire to cover this case already, but this fixes some UI issues for giant forms when the player normally can't wield giant weapons. As a side effect, it does mark all weapons as useless when in a non-wielding form, but if this is a problem, the fix would be to adjust the ignore_transform parameter from the caller. (This might lead to other issues though if any forms narrow the wield restrictions. But I'm not sure they do.) Resolves #1889 -------------------------------------------------------------------------------- 6e592c6ea3 | advil | 2021-04-27 10:25:08 -0400 fix: annotate staves with {weapon} These are not technically weapons, which is why this has to be done manually, but from the player's perspective that distinction is not particularly helpful -- I think the player will expect anything that can be wielded, used in attacks, etc to show up when doing a stash search for "weapon". Resolves #1907 -------------------------------------------------------------------------------- 986d5f5408 | gammafunk | 2021-04-27 04:55:24 -0500 Rework the Jungle Book Lair ending The map due_jungle_book is memorable, but uses a spoilery lua death trigger. Killing the sole anaconda found on the map causes random green elephant statues to "come alive" as dire elephants. We do have lua spoiler vaults at various places in crawl, but it's best to not feature these in a common Lair ending. Furthermore this effect doesn't result in very interesting gameplay relative to how much of a spoiler it is. One of the most common tactics is grabbing loot, teleporting out, and ignoring most of the spawned monsters. This commit reworks the vault to have a strong undead theme, adding in the relatively underused necromancer monster and its Bind Soul ability to pull off "on death" effects with better gameplay and less spoilers. Necromancers get a band of living beasts, mostly elephants but with death yaks and cane toads mixed in. We also mix in bands of thematic skeleton, zombie, and spectral monsters throughout the vault, including a spectral version of the old "Kaa" anaconda. Monster encounters are now spread out so that none of the various vault chambers are empty, which was a problem with the old vault. Overall there are fewer dire elephants, since the previous vault placed too many, but they still feature prominently in the largest loot chamber and can appear in their derived undead forms elsewhere in the map. The guaranteed piece of loot that previously required burning trees is now guarded by an obsidian statue. This loot has a necromancy theme, being one of such items as a high quality pain or draining weapon, shadow dragon scales, an artefact ring of positive energy, an artefact amulet of regeneration, or a necromancy themed book. The necromancy-themed unrands Sceptre of Torment, Morg, Cigotuvi's Embrace, Sword of Zonguldruk, and Majin-Bo all have a chance to appear as this loot item, although each with low chance. -------------------------------------------------------------------------------- b115f176c6 | Nicholas Feinberg | 2021-04-26 17:47:03 -0700 Truly unique new tiles (Sastreii) Rupert gettin ripped and Frederick gettin mean. -------------------------------------------------------------------------------- 09c2292e34 | advil | 2021-04-26 19:26:14 -0400 fix: prevent -cast and +int (kate) This also seems like a case where these properties should conflict. Also, move the conflict check from a8074f5 to a more natural place. -------------------------------------------------------------------------------- a8074f570f | advil | 2021-04-26 18:02:10 -0400 fix: prevent RegenMP with -cast Inspired by: https://www.reddit.com/r/dcss/comments/myz00g/my_candidate_for_the_most_useless_ artifact_ever/ This combo is amusing but also pointless enough that I think it is worth filtering out, similar to antimagic + MP. -------------------------------------------------------------------------------- f39c287674 | Kate | 2021-04-26 21:00:15 +0100 Redraw agrid on gaining the silence aura mut (#12577) -------------------------------------------------------------------------------- 3a4c58a182 | advil | 2021-04-26 11:30:35 -0400 fix: adjust connectivity for gammafunk_its_a_trap This should only be marked `passable` in vaults; because of the conditional SUBST for - it is potentially one-way outside of vaults and can generate connectivity traps as well as actual traps. I replicated this behavior using seed 12239598491091230555 at version 407484c in Snake:3, from the game shown in #1909. Resolves #1909. -------------------------------------------------------------------------------- f0060e8222 | Kate | 2021-04-26 08:47:18 +0100 Make Repel Missiles unablatable Repel Missiles having a power-dependent chance of ending after repelling something was an important feature for the player spell, but not relevant on on the few monsters with rMsl (and would only trigger rarely even for them). With the player spell gone, remove that extra layer of complication. -------------------------------------------------------------------------------- 78b3836a5f | Kate | 2021-04-26 02:30:25 +0100 Refactor disease to be a standard duration Disease is no longer a widespread status effect and only shows up in the Abyss from ancient zymes, so doesn't need so much special handling. Turn it into a normal duration (with recovery rate no longer affected by the player's regeneration rate), and make it dispellable instead of being healable with potions of curing. -------------------------------------------------------------------------------- cf8293e1eb | Kate | 2021-04-25 22:55:09 +0100 Fix pluralisation of pieces from Xom's chessboard And any future things from other things. -------------------------------------------------------------------------------- 8197cbaaf9 | advil | 2021-04-25 13:37:03 -0400 fix: correctly handle hand names ending in `e` (celly00) Prevent "It is a one-tentacleed weapon". -------------------------------------------------------------------------------- e8a0a9c698 | gammafunk | 2021-04-24 21:31:59 -0500 Fix a typo (Yermak) -------------------------------------------------------------------------------- 99ddfe5caa | gammafunk | 2021-04-24 21:17:56 -0500 Don't have burned demonic trees release demons This behaviour creates a disincentive problem similar to the one that orcish idols had when destroying those caused smiting: it would practically never be worth it to intentionally burn a demonic tree. Although creating a chaos cloud doesn't do much in terms of gameplay, having that alone is better than creating destruction disincentives. This commit removes the demon summoning part, but keeps the chaos cloud aspect. There might be room for more monster-activated behaviour, similar to how Awaken Forest works (and that effect does work normally on demonic trees). The challenge with monster-activated behaviour will be that demonic trees have limited distribution, even in the abyss. -------------------------------------------------------------------------------- a652b1bed6 | gammafunk | 2021-04-24 21:17:56 -0500 Update visuals of an Abyss-themed ghost vault For gammafunk_ghost_abyssal_escape, incorporate the new demonic trees into the the vault border. Also randomize the border walls more, incorporating crystal and metal, similar to how Abyss wall ranomization happens. Add a "ruined" floor tiling around the vault for some nice visual effect and to help the glass and demonic trees have floor tiles that seem a bit more logical. Choose a floor color that blends with the the branch-specific floor tile color, when that's possible. The effect is subtle in most branches, but it's especially nice for Shoals, where the sand tile is somewhat bright, so we'd like to use a more matching color. Somewhat increase the trees used in walls for Swamp, since they're still pretty sparse for spriggan druids' purposes even though we replace some of the interior rock with trees. -------------------------------------------------------------------------------- 0d77da13b5 | Nicholas Feinberg | 2021-04-24 08:26:24 -0700 Salamander tweaks (Sastreii) - New tiles for base Salamanders, Mystics and Tyrants. - Remove tyrant weapon use; this wasn't used and wasn't displayed on tiles. -------------------------------------------------------------------------------- 246ed28529 | gammafunk | 2021-04-24 03:40:15 -0500 Fix up a Lugonu altar vault For the altar vault amcnicky_altar_lugonu_corruption, use rock instead of stone, since we're using Abyss rock tiles and recolouring stone stends to be more problematic. Don't use console colours that would confuse the features with other types of walls. Also, when the vault places in Swamp, use the newly introduced demonic trees instead of rock, for a more Abyss-themed feel. -------------------------------------------------------------------------------- ec5411427b | gammafunk | 2021-04-24 03:40:15 -0500 Add demonic trees (Sastreii) A new type of tree appropriate for the Abyss and Pan. When ignited, it releases a durably summoned hostile demon and leaves a clouds of chaos. The demon has a chance to be a greater demon based on the depth of tree placement. The chaos clouds are single tile chaos clouds with somewhat long duration, but don't spread like forest fires. We now place these as the default tree type in both Abyss and Pan. These trees work normally in terms of being awoken and susceptibility to fire/lightning bolts. They have a set of very creative tiles, courtesy of Sastreii, a description, as well as a description of their unique burning behaviour. -------------------------------------------------------------------------------- 6f9b4697ca | gammafunk | 2021-04-24 03:40:15 -0500 Describe burning mechanics in tree descriptions Put basic details about tree and mangrove burning in their descriptions, using a common entry for both types. -------------------------------------------------------------------------------- f074c5909a | gammafunk | 2021-04-24 03:39:39 -0500 Refactor descriptions of terrain modifiers Currently the awoken status for trees is handled as a pseudo terrain type in terms of descriptions by adding an "awoken" prefix to the feature name. This means each possible type of awoken tree needs its own unique description entry. This commit handles awoken and summoned (temporary terrain) descriptors similarly to how we handle icy walls. Now they print as descriptors after the main feature name, and can pull in a common entry for the detailed description show under x-v. -------------------------------------------------------------------------------- 76f056063d | gammafunk | 2021-04-24 03:38:09 -0500 Move mangroves back to their own feature type Mangroves were made normal trees in 7a9dbbb8 when trees were made fully opaque, instead of requiring two to break LOS. However multiple gameplay differences remain between trees and mangroves, namely they don't spread forest fires and they leave shallow water after destruction. Having them be normal tree features but with the behaviour conditioned on location complicates documenting these differences for the player. It also complicates their usage in other areas, since they'll be mangroves in appearance only, and will not do any of the usual mangrove things. It's far more straightforward to have features with gameplay differences be properly distinct feature types, hence this commit restores mangroves to their own type. The handling for flame clouds and leaving water is conditioned on the original feature being a mangrove, not its being a tree in Swamp. I've also added a mangrove feature description that mentions mangrove differences. This change does bring some complications. For vaults, we condition the default meaning of the 't' glyph by branch, so that mangroves are the default definition for any vault placing in Swamp. Vault authors can still use a KFEAT to get whichever type of tree they need. For save compat, we add a minor version that converts all normal trees to mangroves in Swamp. For vaults, I've gone through and modified the few vaults using mangrove tree tiles outside of Swamps to use proper mangrove trees. -------------------------------------------------------------------------------- c0a873f3f4 | gammafunk | 2021-04-24 02:03:48 -0500 Fix grammar handling of Zot trap descriptions Zot traps having an upper-case first character broke the description database lookup and gave inconsistency with other feature descriptions, showing "Zot trap" instead of "a Zot trap". Update the grammar function to have an option to ignore case, allowing articles to be added for upper-case phrases and use this for Zot traps. Also refactor some feature description code to no longer have special cases for mechanical traps and abandoned shops that are properly converted to distinct feature types. -------------------------------------------------------------------------------- a85bd9520d | advil | 2021-04-23 19:13:31 -0400 docs: Document force_more_message vs runrest_stop_message These work completely independently, but this was not a very obvious fact from the documentation. I think in the long run I'd prefer to change this, but it's non-trivial to do, so for now at least make the situation clear. -------------------------------------------------------------------------------- e4650c3cbe | advil | 2021-04-23 19:05:12 -0400 refactor: remove some more hunger references -------------------------------------------------------------------------------- 97754add85 | advil | 2021-04-23 18:28:02 -0400 Add portal alerts to default runrest_ignore These not being here is almost certainly one reason for reports of people missing these. -------------------------------------------------------------------------------- 1d5596e97f | advil | 2021-04-23 18:26:05 -0400 Add zot clock alerts to default runrest_ignore It seems that this is entirely independent of force_more_messages, so these need to be in both places. -------------------------------------------------------------------------------- 8b38eeb0f3 | advil | 2021-04-23 17:50:05 -0400 Force-interrupt all delays on zot clock messages One factor in the death in 12569 is that when you have `explore_auto_rest = true`, and start autotravel, it uses the delay interrupt options for `interrupt_travel` rather than `interrupt_run`, which does not include messages. It seems pretty reasonable that the zot clock alerts should just interrupt anything, regardless of configuration, which sidesteps this issue. -------------------------------------------------------------------------------- 29160eaed2 | advil | 2021-04-23 16:08:33 -0400 Mark diamond obelisks as not a threat The only effect of this should be allow ghouls / bloodless vp to heal with obelisks in sight. Their effect is via clouds, which should still prevent autotravel etc. Also, remove some tornado dprf spam. Easy enough for someone adding tornado to put in temporarily if needed later. Possibly resolves mantis 12569, but not any hepl bug (such as #1747). That is, I suspect 12569 was not actually hepl related, but that there is another similar hep bug. -------------------------------------------------------------------------------- e809cff456 | Edgar A. Bering IV | 2021-04-21 21:32:36 +0300 update CREDITS.txt -------------------------------------------------------------------------------- 0c245655db | Edgar A. Bering IV | 2021-04-21 20:55:09 +0300 Remove food(.des) food.des housed the guaranteed food vaults, which after the removal of food simply became a part of the minivault pool. This moves most of them to mini_monsters.des. The spriggan baker becomes the spriggan hatter, placing hats and occasionally a skinned spriggan corpse (yikes!). The "fruiting plant" subvaults are removed (they had a TODO asking for flavour without food). Vaults that use them are adjusted. One vault that was a notorious and spoilery autoexplore trap is removed. Another, with jelly flavour, is removed. The flavour wasn't strong without being able to place royal jellies, and without players eating at all the side-by-side jellies eating the door and a ration for the player is also lost. -------------------------------------------------------------------------------- a35ceff83e | Edgar A. Bering IV | 2021-04-21 19:59:13 +0300 Fixup some Nemelex overflows (Yermak) -------------------------------------------------------------------------------- 9982866e19 | Edgar A. Bering IV | 2021-04-21 17:01:56 +0300 Revert "Prevent bounced bolts from escaping LOS" This reverts commit 4a294289ab1eb94c2edadeffdf97aeacee0a300f. This approach to clamping had some weird unintended consequences for the fire/steam/water interaction. Addressing them correctly and consistently seems rather challenging from the current way the beam code is written. For now I'll roll this back, perhaps in the future a better solution to prevent out of LOS attacks will be found. -------------------------------------------------------------------------------- 781257ad05 | Edgar A. Bering IV | 2021-04-21 16:51:51 +0300 Reword Vampire regeneration (Shummie) -------------------------------------------------------------------------------- cb85b5eba1 | Edgar A. Bering IV | 2021-04-21 00:06:50 +0300 Don't crash when aimed_at_spot the player can't see -------------------------------------------------------------------------------- 88d13c5596 | Kate | 2021-04-20 21:31:45 +0100 Free Hepliaklqana ancestors from the gender binary And allow them to start out as GENDER_NEUTRAL in addition to it being selectable when recalling identity. -------------------------------------------------------------------------------- 079d617196 | Edgar A. Bering IV | 2021-04-20 23:14:54 +0300 Fix a Hepliaklqana message (12568) -------------------------------------------------------------------------------- 151369d6e4 | Nikolai Lavsky | 2021-04-20 22:58:36 +0300 Further fix webtiles display of defense boosts After fc3203cb, defense boosts provided by the "acrobat and divine shield are no longer coloured blue. This is because unlike other boosts, these two are handled separately in `tileweb.cc:_update_statuses()` and don't use `short_text` strings from duration-data.h. Fix this by updating `short_text`s in `_update_statuses()`. Also, fix colouring of corroded AC and weapons on the HUD. -------------------------------------------------------------------------------- 4a294289ab | Edgar A. Bering IV | 2021-04-20 22:31:56 +0300 Prevent bounced bolts from escaping LOS The targeter does a good job of guaranteeing player bolts don't have an initial target out of LOS, but bounced bolts can escape. Explosions can also explode in order to reach outside of LOS; clamping down on those would need to be done elsewhere. -------------------------------------------------------------------------------- 3be03a2e56 | AlexanderPosch | 2021-04-20 10:34:38 +0300 Don't reduce the bounce range of spells with items Resolves #1800. The code checks how long a bounced spell would have been if los had not been restricted and then increases the range of bounced the spell. (Kobolds nightstalker mutation does not count as a los restriction). [ Committer's note: Closes #1885. Squashed and rebased. Re-wrote some checks based on the change to how mutations interact with normal vision. Changed the range display to always display the normal-vision range (the symbol strings are rather cryptic, and the UI communicates things well enough with beam path highlighting). Re-wrote the commit message; adjusted style to fit our style guidelines. ] -------------------------------------------------------------------------------- 8b510267b1 | Edgar A. Bering IV | 2021-04-20 10:34:38 +0300 Reduce explicit species checks: barachi Create a MUT_DAYSTALKER as a + counterpart to MUT_NIGHTSTALKER to replace Ba's LOS fakemut. -------------------------------------------------------------------------------- 5a55d11bb6 | Edgar A. Bering IV | 2021-04-20 10:34:38 +0300 Make Nightstalker adjust base LOS This affects halo and umbra scaling only; everywhere else current_vision is used (which already applied nightstalker). These have always been species mutations but predate the concept of a variable base los. -------------------------------------------------------------------------------- 1420032b4b | Kate | 2021-04-20 07:41:44 +0100 Refactor immunity display on % Adds generalised handling for immunity to replace the current rPois special-casing, and uses it to also display infinite willpower (in shadow form) and infinite rampaging (with the seven-league boots). Closes #1920. -------------------------------------------------------------------------------- 288ea87c7c | Kate | 2021-04-20 06:59:06 +0100 Mark scarves of invisibility as useless with Sac Artifice (#12486) -------------------------------------------------------------------------------- 551b87177e | gammafunk | 2021-04-20 00:57:46 -0500 Have soul bound monsters always create simulacra The monster Bind Souls spell currently only creates simulacra if the monster rolled successfully for the chance to leave a corpse. This is an aspect of how the old version of the spell directly consumed corpses, which closely mirrored the player Simulacrum spell. However Bind Souls isn't trying to have symmetry with the player spell; in fact the two spells don't have same name. The corpse requirement only serves to weaken the most distinctive ability of the necromancer monster, which isn't very dangerous at the depths in which it appears. This commit has a simulacra always be created when a monster dies with the Bind Souls enchantment active, giving Bind Souls and by extension necromancers a buff. -------------------------------------------------------------------------------- 450f9b2e0d | gammafunk | 2021-04-19 19:14:50 -0500 Fix an artefact amulet equip crash (Skunz) Now that Regen+ can appear on amulets as of bf8bb431, the artefact equipment code needs an update to not assume an artefact with the regen artp must be armour, which results in a crash. This code is to prevent double messaging in cases of e.g. moon troll leather armour that also has a regen property. This currently can only happen for unrands, since the regen artp doesn't allow multiple levels for randarts. While there currently is no unrand regen amulet with regen++, this commit adds the relevant check for amulets in order to future-proof things. -------------------------------------------------------------------------------- 7ee7857c10 | Edgar A. Bering IV | 2021-04-19 19:09:15 +0300 docs: changelog through 0.27-a0-1047 -------------------------------------------------------------------------------- c940c042cb | advil | 2021-04-19 10:28:14 -0400 fix: check is_stationary in _can_movement_ability (alex1729) The practical effect is that this commit applies DUR_LOCKED_DOWN to rolling charge and hop, where before they were exempt despite being movement-like. I think this was just an oversight, rather than intentional? Before this duration existed, is_stationary just checked treeform, which would have disabled these abilities anyways. -------------------------------------------------------------------------------- 98bf31544f | Nicholas Feinberg | 2021-04-18 11:48:46 -0700 Make guardian golem inner flame trigger consistently Moderate buff to a spell generally considered weak. -------------------------------------------------------------------------------- 1e905a0851 | Nicholas Feinberg | 2021-04-18 11:48:46 -0700 Properly credit guardian golem explosions They were being attributed to the dead monster, not to the hexer, which resulted in the player not getting XP for kills from the explosion damage itself (though they did get credit for any cloud kills, oddly). -------------------------------------------------------------------------------- 2b6ed4f61c | RojjaCebolla | 2021-04-18 21:15:58 +0300 Add Poisonous Vapours to Veh's spell gifts table This helps ensure Ignite Poison can be put to use, and helps with the fact that there are extremely few 2nd-level spells for Vehumet to choose from. [ Committer's note: Closes #1880. This also gives Veh's wizardry bonus to the spell, which is fine because it is destructive! ] -------------------------------------------------------------------------------- c275e32347 | Edgar A. Bering IV | 2021-04-18 21:15:37 +0300 Nerf Makhleb heal-on-kill (cebolla, kate-) This passive is runaway strong and outshines Makhs shiny actives. On every kill that passes the piety threshold (random2(you.piety) >= 30) (at high piety more than 80% of the time) give up to 2 * monshd, on average 3/2 * monshd. In lair, when characters are often around 100 hp a death yak heals for an average of approximately 20% health(!). This commit halves the value of each heal replacing hd + random2(hd) with (1 + hd) / 2 + random2(hd / 2); rounding up always for the base so that something happens when the effect is triggered. [ Resolves #1878 ] -------------------------------------------------------------------------------- 1f2d7d2970 | RojjaCebolla | 2021-04-18 21:15:37 +0300 Improve Makhleb's Major Destruction Remove the non-bolt targeted zaps: the explosions (orb of electricity and fireball) could be unfortunate surprises not previewed by the targeter; the projectiles (sticky flame and iron shot) likewise could be surprises, though of a more subtle kind. In their place, in a parallel with minor destruction, add magma bolt and corrosive bolt zaps. Unlike minor destruction, where acid breath requires special power scaling, each of these zaps has a reasonably close damage averages (though the variances are all over the place; fine for a chaos spell). Major Destruction's power computation was exactly the same as Minor Destruction, topping out at a paltry 81 power on a max roll. Comparing the dice definitions for zaps, this meant Major Destruction was on average only approximately twice the damage of Minor Destruction. With the high variance (power randomization, zap randomization, then damage roll) it didn't feel worthy of the significantly higher cost in training, hp, and piety. This commit doubles the spell-power for Major Destruction zaps. With the exception of lightning bolt the Major Destruction zaps are all lower variance than the Minor Destruction counterparts, so this should feel much stronger at high Invocations. [ Committer's note: Re-wrote commit message; tweaked power formula and zap list. Closes #1879. ] -------------------------------------------------------------------------------- 8915be9327 | Edgar A. Bering IV | 2021-04-18 21:15:37 +0300 Describe the ancestor's special shoot through properties. -------------------------------------------------------------------------------- ccdeed5ca2 | Edgar A. Bering IV | 2021-04-18 21:15:37 +0300 Remember friendship (PleasingFungus) Allow the Hepliaklqana ancestor to shoot through the player, symmetric with the player's ability. -------------------------------------------------------------------------------- ab74d117c1 | sdynet | 2021-04-18 21:15:36 +0300 Allow projectiles to pass through ancestors This change will slightly break Hep's balance, but instead I expect that the player's management QoL will be much better. [ Committer's note: tweaked where the check goes. Closes #1835. ] -------------------------------------------------------------------------------- 2e39039ceb | Edgar A. Bering IV | 2021-04-18 21:15:36 +0300 Adjust demonic guardian protections Allow firing enchantments through them and protect them from chain lightning. Fedhas plants have (unintentionally) had these protections for 6 years without trouble, so it's better to extend them to guardians as well instead of changing the Fedhas behavior. -------------------------------------------------------------------------------- 74cc72d83b | Nicholas Feinberg | 2021-04-18 08:45:31 -0700 Don't give djinni stone/bone legs New tiles for lichform/statue form, irrespectively. -------------------------------------------------------------------------------- 8e1b44f6bd | Kate | 2021-04-18 04:48:17 +0100 Remove an unused ability description -------------------------------------------------------------------------------- c9ac73bf2f | Kate | 2021-04-18 04:48:17 +0100 Tweak Palentonga charge ability description To match wording of other abilities. -------------------------------------------------------------------------------- b38debd254 | Kate | 2021-04-18 04:48:17 +0100 Refactor Word of Chaos Fixes word of chaos being usable while silenced (via the quiver), and improves the timing for ability failure. Also improves behaviour around invisible monsters and monsters that would always be unaffected. -------------------------------------------------------------------------------- 943f6fbcab | Kate | 2021-04-18 04:48:17 +0100 Adjust descriptions for some DS mutations -------------------------------------------------------------------------------- 21ed115f35 | Kate | 2021-04-18 04:48:11 +0100 Simplify player torment immunity checks -------------------------------------------------------------------------------- 4f73a2ec51 | Kate | 2021-04-18 04:47:31 +0100 Simplify Demonic Will handling -------------------------------------------------------------------------------- 0ecb5ae1e9 | Kate | 2021-04-18 02:27:54 +0100 Fix Pan lord pronouns Currently the unique Pan lords all use they/them - the rune announcement messaging will need some extra handling if any of them are changed. -------------------------------------------------------------------------------- eef1433cc0 | Kate | 2021-04-18 02:27:54 +0100 Announce Pan floors with a guaranteed demonic rune The guaranteed demonic rune vaults are all easily recognised for spoiled players, and it's also a lot more fun to encourage getting the rune from one of them compared to a standard random pan lord, so add a message announcing their presence similar to the one that already exists for holy Pan. -------------------------------------------------------------------------------- 0ab3ac089c | advil | 2021-04-17 18:22:59 -0400 fix: extra qualifier for mutation check in 3cb69ffe5362 Shouldn't matter, just adds a bit of safety. -------------------------------------------------------------------------------- 3cb69ffe53 | advil | 2021-04-17 18:18:28 -0400 fix: more general code for species mutation fixup This will more consistently remove species mutations fixed up this way if they shouldn't be there, as well as add them if they should. This code is still not very general (in principle this should be readable off of the species def, but it's tricky to get that right for all cases), and doesn't handle ds muts. -------------------------------------------------------------------------------- bab068f60c | advil | 2021-04-17 17:35:15 -0400 fix: Add generic fixups for four dj innate mutations These are dj-specific so it should be safe to have these fixups. These mutations may be affected on a small number of games on cko impacted by the recent ds mutation bug. -------------------------------------------------------------------------------- c56cccb18a | advil | 2021-04-17 16:28:18 -0400 fix!: reorder demonspawn mutations added in #1852 Commits in that PR added new mutations to the middle of the enum; this has save compat consequences because this enum is serialized as an int. This is a bit of an emergency fix to prevent further breakage; the commit has already gone live on cko, and save compat will get even worse for impacted games, but we really need to keep this from impacting other servers. -------------------------------------------------------------------------------- 5bb4860596 | Neil Moore | 2021-04-17 15:48:53 -0400 Clarify that whitespace fixes should be separate from real changes [skip ci] -------------------------------------------------------------------------------- 72157e4a48 | Neil Moore | 2021-04-17 15:20:49 -0400 Link to coding conventions from contribution-process.md [skip ci] -------------------------------------------------------------------------------- fe178dfb49 | hellmonk | 2021-04-17 19:52:18 +0300 Clean up some facet selection checks. It would be nice to remove the gotos here. Alas, [ Committer's note: Closes #1852. Rebased, squashed some things, fixed up whitespace and braces. Used MUT_TORMENT_RESISTANCE instead of altering the behavior of STOCHASTIC and having a separate mutation. Tweaked the verb for word of chaos to not suggest divinity. ] -------------------------------------------------------------------------------- cd13395478 | hellmonk | 2021-04-17 19:52:15 +0300 New "Demonic Will" mutation for the damnation facet. This mutation provides Will+ and additionally deals a small amount of retaliatory damage whenever the player beats a monster's will check. This replaces rF+ as the first rank of the hurl damnation facet; the facet is now will/res torment/hurl damnation. The theme is something like becoming a brimstone fiend. -------------------------------------------------------------------------------- 496972007f | hellmonk | 2021-04-17 19:52:15 +0300 New corruption/chaos themed demonspawn tier 3 facet. The facet begins with two stages of MUT_CORRUPTING_PRESENCE, which has a small chance to apply corrosion (at either rank) or malmutate (at rank 2 only) any monster dealt damage by the player. It does not require the player to use melee to get the effect, but triggers less frequently than black mark. At rank 3, grants MUT_WORD_OF_CHAOS, an active ability that forcibly blinks away every monster in los and additionally may ensnare, slow, or fear them at the cost of medium draining and a cooldown. -------------------------------------------------------------------------------- 02609334a0 | Edgar A. Bering IV | 2021-04-17 19:52:14 +0300 Give torment resistance at level 2 of the damnation facet -------------------------------------------------------------------------------- 1916af9b50 | Edgar A. Bering IV | 2021-04-17 19:52:14 +0300 Remove the stochastic torment resistance mutation It's removed from the black mark facet and not slated to be added to any of the demonspawn facet re-works. hellmonk suggested making this mutation deterministic and give 50% resistance, to be used in future demonspawn. This is already done by MUT_TORMENT_RESISTANCE level 1 so there's no need to re-create the effect. For save compatibility the old mutation applies the new effect. -------------------------------------------------------------------------------- 7767df9f8c | hellmonk | 2021-04-17 19:04:58 +0300 Rework the black mark facet. Formerly negative energy themed, this facet was relatively weak. This rework keeps the most interesting mutation and tries to build something new around it. The new facet is debuff oriented and provides a hex enhancer, followed by black mark, then a permanent 1 tile silence "donut" aura, providing a wide variety of debilitating effects for the player. -------------------------------------------------------------------------------- aeb4ca5a24 | hellmonk | 2021-04-17 19:04:58 +0300 Rework the hurl damnation ability's power scaling. Previously, hurl damnation used experience level * 10 to determine power. Power is capped at 200, which was reached at xl 20 - frequently before the player had the mutation. The new formula is 40 + experience level * 6, which reaches 200 power at max level and is otherwise weaker unless received implausibly early. -------------------------------------------------------------------------------- fc7557d7ac | hellmonk | 2021-04-17 19:04:58 +0300 Add passive freeze to the generic mutation pool. Perhaps it would be interesting here, where it's not a facet payoff. I think it's worth a try, at least. -------------------------------------------------------------------------------- 53199a3a11 | hellmonk | 2021-04-17 19:04:58 +0300 Remove passive freeze facet. It was notoriously bad and had significant mechanical overlap with spiny. Not worth saving. -------------------------------------------------------------------------------- 066d056d8b | Goratrix | 2021-04-17 08:00:24 -0700 Add variety to boots tiles This adds back the boots tiles which were replaced in b2ee965 and enables variation between the tiles, same as already exists for robes and helmets. -------------------------------------------------------------------------------- 15b55ab828 | advil | 2021-04-17 10:59:39 -0400 docs: fix a typo -------------------------------------------------------------------------------- 9a371d6b8d | advil | 2021-04-17 10:57:51 -0400 docs: Document some commit conventions There's a bunch of pitfalls that I see coming up in PRs again and again to do with commit messages, and this tries to make them explicit. My aim here is to document conventions that we do have, but that are often unstated or only stated in chat / PR feedback -- but if anyone feels that I got things wrong or too prescriptive here I'm happy to be corrected! -------------------------------------------------------------------------------- ae19ba6e15 | advil | 2021-04-17 10:35:05 -0400 docs: convert coding conventions to markdown This is much more readable as markdown because of the many code blocks, and it also lets the document have a working table of contents. There were a number of minor formatting changes throughout, with some small content changes, including (i) adding a brief why/TLDR version towards the beginning, (ii) mentioning the checkwhite/unbrace scripts explcitly, (iii) documenting some of the more mechanical spacing rules. -------------------------------------------------------------------------------- f0a3ee54a8 | advil | 2021-04-17 09:30:34 -0400 fix(tiles): Skip pre-layout message rendering This is basically a followup to 5a74e75d8f72. Those crashes in local tiles revealed that the message window is getting rendered before tiles has a layout, so the message window is width 0; this is basically harmless but triggers pathological linebreaking behavior that it's better to skip (and has the potential to trigger rendering glitches, though I don't think it will currently). Re the removed comment there: I have verified that the current wrapcprint behavior should prevent infinite loops even with width 0, as long as linebreaks are correctly added; the loop will always abort if it runs out of y space. The bug in cfdca905f5 involved failing to correctly add a linebreak. So restoring the wrapcol ASSERT should be unnecessary. -------------------------------------------------------------------------------- 407484c6a7 | gammafunk | 2021-04-17 03:25:12 -0500 Rework monsters in a lemuel castle vault The vault lemuel_castle_with_subvaults has monster placement that's not much been updated, and still has logic based on Dungeon having 27 levels. This commit reworks the monster and loot placement, giving it better scaling with depth, with appropriately themed monsters at each location. It also cleans up the tagging and supporting lua code, organizing it similarly to our current DES standards. For monsters in Dungeon, we use the same scaling as ghost vaults, since this vault places over the same range. Previously it had a specific theme for each depth (e.g. gnolls then later orcs), but something so specific is more difficult to scale. Instead we use a mix of gnolls, orcs, kobolds, and other Bailey-loving humanoid monsters to give us good variety of monster classes. We introduce different types "guard dogs" as the depth changes, using hounds after jackals, and also adding in some howler monkeys, since those are great at rousing the castle army. In the late dungeon hell hounds and even raiju make an appearance at the back of the castle. For Depths, we keep the "giant" theme, since there are enough such monsters to choose from, and use mostly dragons as the guardian beasts instead of hound genus monsters, however one may found a shrike or X at the back of the castle moat. On Depths:5 it places the Zot entrance and draconian and dragon monsters as before, but with some tweaks to the composition of those. Keep the death drakes, but use real dragons instead of a bunch of low-level drakes. Don't thin out the number of "1" monsters drastically only for Depths:5, rather removing about 8 of these from the original lemuel subvault, since that one places so many more than the other subvaults. It still places the most monsters (and the most loot), just not so many more compared to the other subvaults. For loot, scale up the type and quality with depth instead of the thining out numbers earlier. We don't change the monster count with depths, so the overall loot count should likewise remain constant. -------------------------------------------------------------------------------- be84625216 | Kate | 2021-04-17 08:47:24 +0100 Don't allow Manifold Assault to attack projectiles -------------------------------------------------------------------------------- 1fd4cec11e | Kate | 2021-04-17 02:50:03 +0100 Simplify Cleansing Flame description (Yermak) -------------------------------------------------------------------------------- b2ee965f6f | Nicholas Feinberg | 2021-04-16 18:48:42 -0700 New Sastreii tiles Hydras + normal & randart boots. -------------------------------------------------------------------------------- 9da5d22180 | Kate | 2021-04-17 01:57:41 +0100 Update MUT_PAWS description (advil) -------------------------------------------------------------------------------- eb3bcc3169 | Kate | 2021-04-17 01:44:30 +0100 Adjust some stealth handling Fixes Merfolk and Octopodes not getting their bonus stealth when flying over water, makes the Jiyva-only translucent skin mutation always give a full pip of stealth, and removes the marginal stealth penalty and bonus from hooves and paws respectively. -------------------------------------------------------------------------------- 57dfabebf2 | Kate | 2021-04-17 01:40:43 +0100 Improve known/unknown staircase descriptions (#1621) Closes #1621. -------------------------------------------------------------------------------- b18e172e69 | Kate | 2021-04-17 01:40:25 +0100 Adjust Barachi mutation description -------------------------------------------------------------------------------- e6159548ff | Kate | 2021-04-16 23:37:54 +0100 Update Cleansing Flame description (#12200) -------------------------------------------------------------------------------- 3ad0f943fe | Kate | 2021-04-16 04:06:41 +0100 Remove the Random Bolt spell It was used only by Mnoleg, whose spellset is focused around spamming lots of summons so was unlikely to be notable there. -------------------------------------------------------------------------------- 4cfe56dd59 | Kate | 2021-04-16 01:18:13 +0100 Use ancestor pronouns in a transference message -------------------------------------------------------------------------------- b18131059d | Kate | 2021-04-16 01:18:10 +0100 Simplify a transference message (#1906) Since the grammar for correctly specifying different types of terrain would be very fiddly to handle. Closes #1906. -------------------------------------------------------------------------------- cdb93c67d5 | Kate | 2021-04-16 00:58:36 +0100 Make Serpent's Lash movement take priority over rampaging It's intentional that rampaging generally takes priority over Wu Jian attacks, but with Serpent's Lash active the expected behaviour is for movement to not take any time, so make the instant movements take priority over rampaging. -------------------------------------------------------------------------------- 31948d8415 | Kate | 2021-04-15 23:10:00 +0100 Shorten the shopping list header slightly To handle edge cases with very large and expensive shopping lists (10 or more items costing a total of 10000 gold or more would have slightly cut off the header message on an 80x24 terminal). -------------------------------------------------------------------------------- 5030419646 | Neil Moore | 2021-04-15 17:58:27 -0400 Be more clear about shopping-list total cost (Nivim) -------------------------------------------------------------------------------- 818bb6d2ef | Neil Moore | 2021-04-15 16:51:36 -0400 Add tests for uppercase and friends. Including a check (using the Turkish locale) that they handle ASCII as though we were in the C locale. -------------------------------------------------------------------------------- 3fb6992e63 | Neil Moore | 2021-04-15 16:20:11 -0400 Expand on comma_separated_* tests 1. Also test arrays of strings and arrays of const strings. 2. Also test comma_separated_fn with a non-trivial stringification function. 3. Also test alternative values of comma and andc. 4. Also (in a separate TEST_CASE) test comma_separated_fn with stringification functions that take a non-string parameter: both an actual function pointer, and a std::function. -------------------------------------------------------------------------------- bc1d1ccee9 | Aliscans | 2021-04-15 11:53:54 +0300 Let the arena create an ironbound beastmasters on request. Previously, the game terminated (with game_ended_with_error()) if the user attempted to create an arena with a M_REQUIRE_BAND monster which didn't create a band in the same dgn_place_monster() call. This change means that the monster is created as if the M_REQUIRE_BAND flag wasn't there. -------------------------------------------------------------------------------- 778c41be60 | Aliscans | 2021-04-15 11:53:54 +0300 Explain why wizard mode create monster fails for ironbound beastmasters. If the user tries to create a M_REQUIRE_BAND monster without a band, say "That monster can only be created with a band." instead of "Unable to place monster.". The request is still denied. -------------------------------------------------------------------------------- dafb6c8885 | RojjaCebolla | 2021-04-15 10:38:30 +0300 Create artefact_creation.md Basic documentation for artefact creation. Can be expounded on later if needed. [skip ci] -------------------------------------------------------------------------------- 25969acef8 | Nicholas Feinberg | 2021-04-14 18:48:11 -0700 Display chance to hit with spells (split) Not chance to miss. This is simpler and consistent with the behaviour of ranged attacks. -------------------------------------------------------------------------------- e9c4887cf0 | Nicholas Feinberg | 2021-04-14 18:43:23 -0700 Many many new tiles (Sastreii) Naga body tiles, ironbound frostheart & beastmaster, and Kryia's mail coat. -------------------------------------------------------------------------------- d4db56bea9 | CanOfWorms | 2021-04-14 21:38:33 -0400 Minor death yak tile edit (Sastreii) -------------------------------------------------------------------------------- 3ebc474583 | gammafunk | 2021-04-14 20:19:05 -0500 Adjust an overflow altar and fix syntax For beargit_hepliaklqana_dungeon_heroes, the spawns at Depth D:7-9 were a bit too nasty, since, starting at that depth, we both introduced potential gargoyle and vampire ancestor monsters and placed two ancestor monsters instead of one. Adjust this vault to only place one ancestor monster at that depth, placing two spawns on D:10-D:12, and placing all three starting with D:13. Also mix the spriggan "hexer" ancestor on D:7-9, as this is easier than the vampire. Down-weight the molten gargoyle at the earliest depth it can appear. Also fix the use of backup monster syntax for KMONS. The backup separator `,` is split first, meaning my `/` alternates were getting parsed incorrectly, instead being treated as duplicate alternates. -------------------------------------------------------------------------------- 00e00afbbc | gammafunk | 2021-04-14 14:56:40 -0500 Toke up the bong cloud Add a checkerboard pattern to the vault floor in console and tiles and make the xom's chess piece always appear in the spot of the bong cloud king. Also disallow traps, vault rotations, and vault mirroring. -------------------------------------------------------------------------------- 402bc293fc | hellmonk | 2021-04-14 20:54:44 +0300 Very important vault. -------------------------------------------------------------------------------- a1f0d90d03 | advil | 2021-04-14 11:14:16 -0400 Fix a missed .ico reference for windows installer builds -------------------------------------------------------------------------------- 64c96e512b | advil | 2021-04-14 10:43:11 -0400 Standardize app icon location/naming These were a bit scattered, leading to potential confusion for downstream packagers (and me!). I'm not sure if dat/tiles is really the best place for this, because that will get copied into installs, but it is at least a place where the most icons already existed. As a convenience, this pulls in the (currently unused) 48x48 icon from #464. The svg in that PR was identical to the one that was in util/ so no need for an additional copy (possible that the copy in util was simply missed, it was far from an obvious location). For downstream packagers in the future: rather than adding duplicate icons to the repo, the preferred process would be to copy them out of `dat/tiles` similar to how the mac and windows builds now work, and to add any new icons to this location -- though I think at this point we might have enough to cover every base! (Commit caveat: not tested yet on windows, I'm going to let CI do that...) -------------------------------------------------------------------------------- 931a06d827 | advil | 2021-04-14 09:57:53 -0400 Allow specifying GAME at the make command line This is sometimes requested by downstream packagers in one way or another, e.g. as in #464. That PR hardcodes a change for tiles, which would be pretty reasonable if one were writing this from scratch. But, there are many secondary build processes that assume the binary is named `crawl`, so it's a bit tricky to make that change as requested without a lot of followup pain. Instead, this allows e.g. packagers to invoke the build process as: `make TILES=y GAME=crawl-tiles` to have a one-step build process that produces a differently-named binary without touching `crawl`. -------------------------------------------------------------------------------- 9df88ad596 | mgdelmonte | 2021-04-14 09:29:28 -0400 Added lua item.description Similar to the recently added `spells.describe` function, this adds the string `description` to the Lua item object. The description is the same text one sees in the UI. Helpful for players using scripts to evaluate relative item values for damage, noise, etc. [Committer's note: fixed submodules, imported commit description from PR. Resolves #1894.] -------------------------------------------------------------------------------- 2aa4ecdaef | CanOfWorms | 2021-04-14 01:42:01 -0400 Improve readability of some new tiles The new yak and wolf tiles suffer from a lack of contrast, which can make it difficult to make out against specific floor tiles. They also have an added problem of looking suspiciously similar to zombies due to their colours. Similarly, the new death yak, catoblepas and hound tiles have contrast issues. The following edits attempts to fix this issue by adding some bright areas to each tile to improve visibility against any floor tiles, as well as tweaking their colours to look less like derived undead. There are also some silhouette tweaks to help differentiate similar monsters, e.g. hounds have a smaller tail compared to wolves, and death yaks have larger and spikier fur compared to regular yaks. -------------------------------------------------------------------------------- ec49774fc9 | Nicholas Feinberg | 2021-04-13 20:24:33 -0700 Swap Static Discharge and Swiftness (hellmonk) Static Discharge to level 2, Swiftness to level 3. The former should help AE early game and give Vehumet more options for L2 gifts. The latter seems fine for an already strong spell. No tweaks to either spell at present. We can adjust damage and duration respectively as we see fit, but it felt fine in playtesting. -------------------------------------------------------------------------------- b56dff0882 | Nicholas Feinberg | 2021-04-13 20:12:31 -0700 Fix Freeze death messages Instead of being blasted by endoplasms, you're now properly frozen. This may cause horrible bugs with very old high score files, since I'm re-using the death type from when you could commit suicide with Ozo's Fridge. I hope not! -------------------------------------------------------------------------------- 3d650569c9 | Nicholas Feinberg | 2021-04-13 19:59:00 -0700 Increase early D book variety Reduce the rarity threshold for books to spawn on D:1. This allows the following set to be chosen (without passing an additional 1% chance) BOOK_MINOR_MAGIC BOOK_MISFORTUNE BOOK_CANTRIPS BOOK_CHANGES BOOK_MALEDICT BOOK_CONJURATIONS BOOK_NECROMANCY BOOK_CALLINGS Previously, only minor magic, misfortune, and cantrips could spawn on D:1. (Previous to that, no books could spawn until D:3.) -------------------------------------------------------------------------------- 750d543db3 | Nicholas Feinberg | 2021-04-13 19:22:59 -0700 New Djinni title: Weightless Champion They're clearly not middleweights! They hover! -------------------------------------------------------------------------------- 30011c25a7 | Nicholas Feinberg | 2021-04-13 19:19:28 -0700 Don't let fleeing monsters aggress (sahdkjhfkaj) Check the escape flag, not emergency, and add it to a few more spells that are appropriate to use in a pinch. -------------------------------------------------------------------------------- d1521fd518 | Kate | 2021-04-12 19:59:01 +0100 Update a comment -------------------------------------------------------------------------------- 133ce1e8f8 | Kate | 2021-04-12 19:59:01 +0100 Fix handling of ARTP_REGEN on amulets (#12561) -------------------------------------------------------------------------------- e5e4f5c7a4 | advil | 2021-04-12 13:13:52 -0400 Fix sacrifice validity issues + document A number of crucial checks for sacrifice validity were being done in `_random_valid_sacrifice`, which it turns out is not used for all sacrifices (only for ones that involve multiple possible mutations). This commit abstracts those checks into a static function and also applies them to all the other sacrifice possibilities in _sacrifice_is_possible directly. In addition, I've tried to add a few commenting hints throughout to help this code be more easily understood. Probably this could use a more thorough refactor. I've also added another check to ensure that piety is always 0 for useless skills; I don't think this should do anything on top of the other checks but it does seem like a useful sanitizer. Fixes mantis 12545 as well as a similar bug on felids. This happened when c3fac4b18bf removed a sac armour-specific check into _random_valid_sacrifice. I'm not sure if anything else would have been affected, because some or all of the other checks maybe were only relevant to health/essence/arcana mutations? But this will future-proof the code a bit as well. -------------------------------------------------------------------------------- a1c40ef19e | Nicholas Feinberg | 2021-04-12 08:16:13 -0700 New Lich tile (Sastreii) It's ready to make friends. -------------------------------------------------------------------------------- 39e2d67666 | advil | 2021-04-12 10:41:55 -0400 Try to fix homebrew for mac CI runner Homebrew is migrating to github for storage, because their previous provider is shutting off service May 1. There's a brownout right now "to warn users about May 1st as sunset date for Bintray" (where the warning takes the form to downstream users of a completely uninterpretable 502 error, but ok). This has revealed that the default mac runner uses a version of homebrew that is not updated with the correct download location. There's various plausible ways to fix this but in absence of any official guidance I'm starting with just inserting the official homebrew setup action in hopes that this fixes things up. -------------------------------------------------------------------------------- d8b25303e3 | advil | 2021-04-12 09:52:02 -0400 Tweak mac universal build targets The x86 binary seems to build just fine with an earlier min version even on an OS 11 arm device, so keep it consistent with our previous build process. I've only tested actually opening the resulting app down to 10.13 though. -------------------------------------------------------------------------------- 4a88dd77dc | Kate | 2021-04-12 09:27:13 +0100 Update starting screen and manual species descriptions The manual entries in particular could probably use a larger rework, but this should at least correct most of the outdated information for that section. -------------------------------------------------------------------------------- bf8bb431c4 | Kate | 2021-04-12 06:30:48 +0100 Tweak randart property availability Attempts to simplify which properties can appear on which types of equipment. Some properties which shouldn't appear on quick-swappable items can now generate on amulets as well as armour (in particular Rampage, Harm, Regen, -Cast and -Tele). rCorr can now appear on any item that doesn't have *Corrode. +Invis can now only appear on armour and amulets, to limit swapping to activate it. Some handling for *Tele is removed since it doesn't generate randomly. -------------------------------------------------------------------------------- bca1fa7cf8 | Kate | 2021-04-12 06:30:48 +0100 Don't consider flight an active ability For the purposes of enabling evocations training. -------------------------------------------------------------------------------- 37fc20d06e | Kate | 2021-04-12 06:30:48 +0100 Don't cancel evoked invisibility on unequip Since evoked invisibility now has a maxHP cost and is only available on scarves and artefacts, make it just behave consistently with invisibility from the potion or spell. -------------------------------------------------------------------------------- d37565c9fb | Kate | 2021-04-12 06:29:49 +0100 Remove the ability to cancel Portal Projectile There's not really any reason to allow micromanaging it in this way. -------------------------------------------------------------------------------- 825125a692 | advil | 2021-04-11 22:22:55 -0400 Fix mac tiles packaging Also, restructure mac crosscompilation to use submake, so that parallelizing helps without creating a mess. (Otherwise, the previous scheme parallelized across targets, leading to arch incompatibilities.) -------------------------------------------------------------------------------- 86988a4770 | advil | 2021-04-11 22:22:55 -0400 Disable universal CI builds for now These will need an 11.0 runner, which should come sooner or later. Until then, disable. -------------------------------------------------------------------------------- 8de5b75ad1 | advil | 2021-04-11 22:22:55 -0400 Attempt to add mac universal builds to CI Not sure if this will work at all (tbd if github CI runners support cross-compilation with an arm64 target). But it would be nice if it does! -------------------------------------------------------------------------------- 62f9e41276 | advil | 2021-04-11 22:22:55 -0400 Fix mac console releases in 10.15+ The location of Terminal.app changed, meaning that the launcher script didn't work at all. (Guess the lack of reports says something about how much this release build is used?) -------------------------------------------------------------------------------- 50225284d2 | advil | 2021-04-11 22:22:55 -0400 Support for mac universal builds targeting apple ARM It turns out that apple clang supports cross-compiling in an extremely straightforward way for arm64 vs x86_64; building a universal binary amounts to cross-compiling and then merging binaries with the `lipo` utility. This also means that producing a universal build on an up-to-date x86 device should also be possible (perhaps even in CI?). However, one caveat is that this forces our back-compatibility hand a bit -- I'm not exactly sure how much since I don't have the devices to test, but the choice of 10.12 is based on apple docs. I haven't removed the non-universal app building scheme so we would have the option of distributing multiple builds. Because of the somewhat baroque Makefile setup that exists for mac builds (possibly in combination with my limited knowledge of what the best way to accomplish this build might be) this is a relatively ugly patch. I've also found rebuilds to be a bit flaky for reasons I don't fully grasp, e.g. sometimes a full clean or clean-contrib is needed when changing targets. Some other minor cleanups, removing files that (as far as I can tell) are no longer used. -------------------------------------------------------------------------------- e866cc41d3 | Nicholas Feinberg | 2021-04-11 17:20:19 -0700 New dread lich tile (Sastreii) -------------------------------------------------------------------------------- b57c80000f | Kate | 2021-04-11 22:24:10 +0100 Fix tag_upgrade builds Also fixes Xom chesspieces not displaying on \. -------------------------------------------------------------------------------- e33e995840 | Kate | 2021-04-11 21:41:22 +0100 Add tiles for the seven-league boots (CanOfWorms) -------------------------------------------------------------------------------- 496ac5bf5d | CanOfWorms | 2021-04-11 02:20:13 -0400 Fix typo -------------------------------------------------------------------------------- 395adb26f7 | Edgar A. Bering IV | 2021-04-11 09:00:56 +0300 Replace wands of random effects with Xom's chesspieces This commit moves random effects to an XP evoker, and makes it non-targeted. This is partly for flavour (in order to re-use the amazing chesspiece tiles), and partly for mechanical distinction. Random Effects' effect is not something that would be good to teach monsters (turning random goblins into possible malmutators/paralysis checks etc.); and random effects was the only remaining wand that monsters didn't know how to use. This gives a clear distinction between misc evockers (monsters don't know how to use) and wands (monsters do know how to use). The change is also an experiment in high-charge misc evokers, to get a broader feel for how they play. This is a warm-up for possibly converting all wands to xp-charging. -------------------------------------------------------------------------------- ae3e1deef5 | Edgar A. Bering IV | 2021-04-11 08:43:04 +0300 Movement-adjust Palentonga roll Apply Chei, swiftness, leda's, ponderousness, water, lightning scales, and frozen movespeed modifiers to the roll time. -------------------------------------------------------------------------------- 78274972cd | Kate | 2021-04-11 06:13:51 +0100 Consider rampaging attacks to be hasty with Chei Rampaging movement was already considered hasty, but not if it was a step that resulted in an attack (which meant that the seven-league boots were never considered hasty). -------------------------------------------------------------------------------- d1b44281ea | Kate | 2021-04-11 05:47:04 +0100 New unrand: the seven-league boots Inspired by discussion on mainiacjoe's Wrath of Trog PR and sdynet's suggestion of giving it infinite-range rampaging, add a new pair of unrand boots with the full-LOS rampaging property. To prevent full-LOS stabbing they also wake monsters up when arriving next to them. -------------------------------------------------------------------------------- ec3affb84e | gammafunk | 2021-04-10 18:25:23 -0500 Some Snake vault revamps Remove weak snakes genus monsters from older vaults, bringing in the relatively newer Snake branch serpents in their place and adjusting monster counts where appropriate. Below are notes on additional changes beyond this for specific vaults: minmay_snake_entry_six_corridors: For this entry we use only mambas and moccasins, since it places in Lair. Concentrate the density of mambas a bit more towards the center, but allow them to also place down the corridors. Simplify the placement substitutions. minmay_snake_pond: Also add in sea snakes, placing only amphibious snakes in deep water. minmay_snake_river: Use only anacondas and sea snakes, so the snakes aren't trapped. Also add loot, so the reward of exploring this long water cavern isn't just some snakes and empty space. nicolae_snake_lava_pool: Also and replace lava snakes with salamanders. Also add more types of salamander genus monsters to vaults that have a salamander theme: nicolae_snake_salamander_stairs: Bring in one monster that can either be a salamander mystic or a tyrant, with chance of the latter increasing by depth. Simplify the monster placement to use a more typical if blocks conditioned on depth instead of calculating based on depth. Balance the salamander placement so that it scales better with depth; the old setup was very conservative about number of extra salamanders placed. In addition to the guaranteed salamander "boss", place 2 extra salamanders on average on Snake:1, 3 extra on average on Snake:2, and 4 extra on average on Snake:3. cheibrodos_snake_lava_hold: Buff monster placement so it better reflects the amount of loot rewarded, which is substantial. Incorporate a guaranteed tyrant and mix in a few additional mystics. -------------------------------------------------------------------------------- 57c748b47e | gammafunk | 2021-04-10 18:24:58 -0500 Cleanups for snake.des Add sectioning like we have for other des files, moving decorative vaults to their own section, and use default-depth instead of having all vaults specify depth. Clean up some glyph usage and statement alignment, as well. -------------------------------------------------------------------------------- 0e2820b0bf | gammafunk | 2021-04-10 18:21:55 -0500 Cleanups for spider.des Remove decor tags that I added to vaults, since we currently have no mechanism to place vaults according to this tag. Might be nice to adapt, improve, and generalize logic in swamp.des to place these in other lair branches. -------------------------------------------------------------------------------- 5e7b979315 | gammafunk | 2021-04-10 18:21:55 -0500 Reorganize shoals.des Add sections like we have for other des files, moving decorative vaults to their own section, and using default-depth, so vaults don't have to specify Shoals depth. Some light syntax cleanup as well. -------------------------------------------------------------------------------- f450e38dac | Kate | 2021-04-10 23:46:25 +0100 Update Shadow form status description (Mintice) To match the updated ability description. Closes #1893 PR. -------------------------------------------------------------------------------- 91442b771c | Kate | 2021-04-10 23:46:25 +0100 Tweak Cigotuvi's embrace description -------------------------------------------------------------------------------- 7a51355724 | Kate | 2021-04-10 23:46:25 +0100 Make Hailstorm affect icy creatures It mainly had this exception so that player IE could use it alongside Summon Ice Beast without damaging their allies, but with ice beast no longer in the starting book it's more consistent to have it just deal its icicle-flavoured damage across the board. -------------------------------------------------------------------------------- 386ccf399c | Neil Moore | 2021-04-10 17:15:02 -0400 Checkwhite (doh) -------------------------------------------------------------------------------- 8df42ad0ea | Neil Moore | 2021-04-10 16:57:41 -0400 Add basic unit tests for comma_separated_line and join_strings It would be nice to also test comma_separated_line's optional parameters, as well as comma_separated_fn, but that can come later. -------------------------------------------------------------------------------- 8328ce2b06 | Neil Moore | 2021-04-10 16:57:41 -0400 Avoid a "no previous declaration" warning when building tests -------------------------------------------------------------------------------- 1b49dfe8c2 | Edgar A. Bering IV | 2021-04-10 23:10:39 +0300 Trade Ice Beast for Metabolic Englaciation in the IE Start (Nomi) Summons have a way of defining a book, especially the mid-level options like Summon Ice Beast. Lighting Spire was briefly considered and then removed from the Air Elementalist start for just this reason. While the positional-magic changes to the book of Frost have made the book a bit less "the book of SIB" the background still very much ends up leaning on the spell. Metabolic Englaciation is an interesting spell and a good fit for the starting background. AOE slow interacts well with the other starting spells, but the price is sufficiently high and there's no direct damage, so it shouldn't outshine in the way SIB does. -------------------------------------------------------------------------------- 420bc2496c | Nicholas Feinberg | 2021-04-10 10:55:46 -0700 Re-tweak dead tree description Remove a double period. -------------------------------------------------------------------------------- a5483dda36 | Edgar A. Bering IV | 2021-04-10 20:48:40 +0300 Some petrified tree ruins for the desolation When the realm was turned to salt some of the trees became petrified with sediment instead of dying outright. Heartier plants were also stoned, while weaker ones were reduced to pillars of salt. Practically petrified trees are added two ways, first a chance to place scattered petrified trees among the ruins (just as the statues). Second a few petrified forest ruins as well as a temple to the twin gods vaguely suggesting a duality between them using trees. Each places desolation normal monsters and loot. -------------------------------------------------------------------------------- 97c99b9d80 | Edgar A. Bering IV | 2021-04-10 20:48:40 +0300 A petrified tree ecumenical altar -------------------------------------------------------------------------------- 68d955cad3 | Edgar A. Bering IV | 2021-04-10 20:48:40 +0300 Generalize the dead tree description They slowly migrated out of crypt since the days of evilmike's Crypt:5 ending. -------------------------------------------------------------------------------- 9aecc562e6 | Edgar A. Bering IV | 2021-04-10 20:48:40 +0300 Implement petrified trees Instead of a vault recolour, let's make petrified trees a first class feature. The name implies that they should behave like rock in some ways (be valid LRD targets, be diggable). Implementing them as vault re-tiles and re-names of statues does this, at the expense of clarity for console players. The expense is even higher for screen-reader players, who might go looking for 't' with a reading cursor only to find '8' instead. As a first class feature, petrified trees can behave like their woody bretheren in some ways, be vulnerable to LRD instead of fire, and interact properly with our feature naming/colouring/glyphing systems. On the vault decorating side, tree_dead is now the variant tile for the brown colour of trees, and no living tree is assigned darkgrey in console. There are also vague future plans that might use such a feature: i-x's Elven Crypt sketch or expanding Desolation into a (rune?) branch. This feature is implemented in the spirit of "if you build it they will come". -------------------------------------------------------------------------------- 94b7631ddb | advil | 2021-04-10 12:33:29 -0400 Fix a Na mutation physiology check In https://crawl.develz.org/tavern/viewtopic.php?f=17&t=27105 a player reported a naga getting hooves. I think this could have happened because MUT_CONSTRICTING_TAIL can be suppressed by forms, and the physiology code only checked the current status of that mutation. So, change the foot check to check innate status (i.e. constricting tail = no feet under any circumstances). The other two mutations here aren't suppressed, but it is still safer to do the check this way. -------------------------------------------------------------------------------- 5a74e75d8f | Nicholas Feinberg | 2021-04-09 21:07:57 -0700 Remove a hairtrigger assert Too aggressive and caused consistent crashes in local dev. -------------------------------------------------------------------------------- f56c19cca7 | Nicholas Feinberg | 2021-04-09 20:44:12 -0700 New dead tree tiles (Sastreii) -------------------------------------------------------------------------------- 3b3f0a9232 | Kate | 2021-04-10 02:30:09 +0100 Update draconian knight description They haven't specialised in necromancy for a while. -------------------------------------------------------------------------------- 86d13463b7 | Kate | 2021-04-10 02:23:34 +0100 Remove monster Ozocubu's armour Giving a couple of monsters extra AC that's meltable by fire damage isn't really worth the extra complexity, especially as it now behaves significantly differently from the player spell since it persists through movement. Instead just give the two monsters that had it (Fannar and draconian knights) a slight boost to their base AC (4 and 6 respectively, a slight reduction from the meltable 7 and 9 that they had previously). -------------------------------------------------------------------------------- e2a9cca30b | Kate | 2021-04-09 23:29:57 +0100 Give monster purple draconians an extra point of AC For some reason they had 1 less than other colours. -------------------------------------------------------------------------------- 0e6d9124c6 | RojjaCebolla | 2021-04-09 10:40:54 +0300 Unmeld statueform merfolk boots when leaving water Changing the check for temporary forms to "true" when leaving water keeps the boots from falling off. Closes #1875. -------------------------------------------------------------------------------- 80ed8d6641 | RojjaCebolla | 2021-04-09 10:40:27 +0300 Allow detransforming over water if flying Even if you're [de]transforming into a non-flyer over dangerous terrain, that's okay if you're currently in flight form. Closes #1881. -------------------------------------------------------------------------------- 638403bedd | Edgar A. Bering IV | 2021-04-09 10:34:01 +0300 Further tweaks to the IRC doc Closes #1867 -------------------------------------------------------------------------------- 9b11d684df | RojjaCebolla | 2021-04-09 10:30:55 +0300 Remove reference to bugzilla ...which is no longer a thing. -------------------------------------------------------------------------------- d9e0fce532 | Edgar A. Bering IV | 2021-04-09 10:29:44 +0300 Correct a typo (Yermak) -------------------------------------------------------------------------------- 5a49628fc9 | hellmonk | 2021-04-09 10:19:34 +0300 A couple ecumenical altar vaults with monsters [ Committer's notes: Closes #1872. Toned down monster and item placement. ] -------------------------------------------------------------------------------- b2bd10914a | gammafunk | 2021-04-08 23:41:12 -0500 Add salamander genus monsters to Snake rune vaults Now that we have salamander tyrants as top-tier Snake threats and thus a full set of salamander genus monsters at differing strengths, this commit incorporate these monster types into all Snake rune vaults. At the low and middle tiers, salamanders replace some plain naga and salamander mystics replace some naga mages so there's a 3:1 ratio of nagas to salamanders of the corresponding types. At the high end, tyrants replace some nagaraja with a 2:1 ratio. These ratios are similar to those in the population lists, although we're using more salamander mystics relative to naga mages than the population list does, which is more like 6:1. So nagas will still get most of the attention, especially since there are other types like warriors, sharpshooters, and ritualists where we make no corresponding replacement, but salamander monsters now play a more significant part in guarding the rune. I've done some reglyphing, statement reorganization, and syntax cleanup for these vaults. Some content notes on specific vaults: snake_pit_salamanders_mu: I've reversed the ratios to place more of the salamander monsters than their direct naga counterparts, although plenty of naga still generate in this vault. grunt_snake_rune_pools: This is a water-themed vault, so I've added a fire theme that gets chosen 1/3 of the time. For the original water theme, no salamander monsters place. For the fire theme, it places salamander monsters with a ratio like snake_pit_salamanders_mu, places salamanders instead of sea snakes, and replaces deep water with lava. johnstein_snake_rune_scales: This had a simple nagaraja as an alternate of Vashnia or as a backup monster if Vashnia has already placed. Hence I made the alternate and replacement have a 1/3 chance to be a tyrant instead of a nagaraja. -------------------------------------------------------------------------------- 64c4f523a5 | Kate | 2021-04-09 02:45:20 +0100 Fix a missing TAG_MAJOR_VERSION check -------------------------------------------------------------------------------- cfdca905f5 | advil | 2021-04-08 21:26:16 -0400 Fix line_reader wide char wrapping (dilly) If the line_reader wrapping code hit a wide character on the wrap column, the wrapping code would go into an infinite loop, and the process would need to be killed. This could be triggered in search as well when the previous search was the exact right length to put the cursor for a following search (since it repeats the previous search) at the wrap column, and the first character of the new search was a wide character, then the bug would trigger. Because webtiles still uses the line_reader console ui behind the scenes, the bug was triggerable in webtiles this way by just having strings of the right length. This probably didn't come up for normal usage, but apparently people use the search box to chat to spectators. (Even worse, a webtiles game killed by the server in this state doesn't save, so the bug can be used to roll back a game on demand.) This commit fixes the infinite loop bug in a pretty straightforward way (and also tries to better guard against infinite loops there). It also fixes some fiddly issues with cursor positioning in the case where the last character of a line is a wide char. -------------------------------------------------------------------------------- 8836bdb7d9 | Kate | 2021-04-09 01:41:22 +0100 Update dispellable monster enchantments Makes lots of monster enchantments dispellable that weren't previously. Some could be dispelled on the player but not on monsters, and some were monster-only magical effects that didn't have any particular reason to not be dispellable. Also makes some effects non-dispellable: the frenzy effect from darts (for consistency with other darts), and silver corona, pain bond and idealise (for consistency with other player god abilities). In a rare case of favouring the player over monsters, this also makes monster priestly buffs generally be dispellable - on the player, god-granted buffs can't be dispelled, but on monsters this isn't feasible to do consistently, since spells can be either wizardly or priestly in origin. The previous implementation was very arbitrary (for example, the regeneration portion of Trog's Hand could be dispelled but not the willpower; Donald's priestly might and haste could be dispelled, but deep elf high priests' brilliance aura couldn't be). -------------------------------------------------------------------------------- e92a7396d4 | Kate | 2021-04-09 00:56:22 +0100 Adjust monster fear display So that the "scary" descriptor doesn't fall out of sync with whether a monster is actually causing the player to be afraid. -------------------------------------------------------------------------------- 23531dd7ba | Kate | 2021-04-09 00:26:09 +0100 Allow activating flight while on liquefied ground It was already possible to fly out of liquefied ground by equipping flight equipment, so allow it for potions and batform as well. -------------------------------------------------------------------------------- ce7b1123cd | Kate | 2021-04-08 22:58:22 +0100 Adjust more !cancellation status descriptions Fixes mesmerisation not displaying in !cancellation's description when it would be dispelled, and special-cases transformations (which had buggy descriptions such as "you will no longer be appendages") and flight (which incorrectly claimed flight would be cancelled when the player had permaflight). -------------------------------------------------------------------------------- c46935d415 | Kate | 2021-04-08 22:58:22 +0100 Adjust dispellability of some durations Flash freeze and sticky flame are now dispellable, and the hidden "sickening" duration (applied by ancient zymes) is no longer dispellable. -------------------------------------------------------------------------------- c738167b05 | Kate | 2021-04-08 22:58:22 +0100 Fix protection brand status light (sim) -------------------------------------------------------------------------------- facc31910f | Edgar A. Bering IV | 2021-04-08 23:24:43 +0300 Remove some weight from the dummy faded altar vault -------------------------------------------------------------------------------- b020930490 | hellmonk | 2021-04-08 23:09:51 +0300 Several more ecumenical altar vaults Includes some very small vaults as well as a couple larger ones. [ Committer's note: small tweaks to code layout and tagging, trimmed a few size-wize and some minor tweaks to randomizations. This is all of the non-monster placing submissions from #1872 ] -------------------------------------------------------------------------------- 0721f309d1 | Shapermc | 2021-04-07 23:58:08 +0300 New ecumenical altar vaults The ruins of Machu Picchu inspired these sites for ecumenical altars. I am aiming to make them feel attractive on the outside to explore, and unique and random on the inside. [ Committer's note: Closes #1868. Tweaked some NSUBST lines and ensured connectivity. ] -------------------------------------------------------------------------------- 3444a674c5 | ukdong90 | 2021-04-07 23:58:08 +0300 Just one Gnrine [ Committer's note: Closes #1874. Tweaked and added some tagging. ] -------------------------------------------------------------------------------- 9722c47da7 | Aliscans | 2021-04-07 21:31:45 +0300 Remove Maud from montitle.txt. Maud has gone, and her ghost cannot use this title, so it's just clutter. -------------------------------------------------------------------------------- 0a00ce863d | Kate | 2021-04-06 02:36:33 +0100 Update SPWPN_PROTECTION's duration short_name To be more descriptive and to prevent other statuses (like "protected from fire") matching the webtiles check for increasing AC. -------------------------------------------------------------------------------- fc3203cb9b | Kate | 2021-04-06 02:21:55 +0100 Fix webtiles display of defense boosts Some of them had fallen out of date with duration-data.h changes. Closes #1832. -------------------------------------------------------------------------------- 6cd11ba223 | Kate | 2021-04-06 02:21:55 +0100 Update and extend some duration descriptions To make them more consistently use an adjective form for the short_text, and to add long_text for some durations without it. -------------------------------------------------------------------------------- c0143cd162 | Kate | 2021-04-06 02:21:55 +0100 Adjust some descriptions -------------------------------------------------------------------------------- 22995d6073 | gammafunk | 2021-04-05 18:36:20 -0500 Hilbert curve vaults for Spider by nicolae (12539) Moved these to their own file, since it's a large series of vaults and subvaults. I removed the placement down-weighting, since it's not an extreme vault in any way, and it has a uniq tag to prevent it from placing more than once. These vaults can create large rectilinear areas when the layout embeds them in large areas of rock. To some extend this might be helped by adding a "fuzzed" CLEAR border to the map, but that would apparently introduce potential closet areas, and it wouldn't fully solve the issue. Seems to be a problem all larger vaults have with the cave-like layouts especially, and I'm not sure if there's an easy solution to that. -------------------------------------------------------------------------------- 8736458e1e | advil | 2021-04-05 11:32:25 -0400 CI: pin a pip version that will work with py27 Pip support for py27 has been dropped entirely in pip 21, so we can't unconditionally upgrade. This invocation that I found on the internet somewhere may help. -------------------------------------------------------------------------------- 263514a223 | Nicholas Feinberg | 2021-04-05 08:02:43 -0700 Revert guardgolem dj restrictions (Yermak) Per request, let players experience the joy of the walking bomb. -------------------------------------------------------------------------------- e2d0b17c59 | gammafunk | 2021-04-05 00:59:50 -0500 A watery jumping spider vault by nicolae (12539) Uses subvaults for randomizing the terrain layout. I put this in its own file as there are over a dozen subvaults. No significant edits other using of MONS instead of KMONS and statement rearrangement. -------------------------------------------------------------------------------- 810843a28d | Nicholas Feinberg | 2021-04-04 22:39:50 -0700 Add petrified trees (Sastrei) And a vault to use em. -------------------------------------------------------------------------------- 5cb13e721e | Nicholas Feinberg | 2021-04-04 22:39:50 -0700 Replace trees (Sastreii) Spring has sprung! -------------------------------------------------------------------------------- f01432ee17 | Nicholas Feinberg | 2021-04-04 22:39:50 -0700 Make the Axe of Woe blow stuff up (Don't leave as many corpses around, mostly since they don't have tiles matching the living versions.) -------------------------------------------------------------------------------- f93f10960d | Nicholas Feinberg | 2021-04-04 22:39:50 -0700 Improve useless manual messaging -------------------------------------------------------------------------------- 88e0368d9b | Nicholas Feinberg | 2021-04-04 22:39:50 -0700 Tweak sac XL bonus piety Give ds a little less and give dj the same bonus, since they tragically lose their l9 spell. Mu lose their second necro enhancer but their existence is always suffering, so it's hard to tell the difference. -------------------------------------------------------------------------------- 6585edb262 | Nicholas Feinberg | 2021-04-04 22:39:50 -0700 Ban guardian golem for dj w/o summons This means guardian golem will very rarely show up in dj spell pools, since they'd have to get one of the few low-level summons before it. Seems OK. -------------------------------------------------------------------------------- d1b0476733 | gammafunk | 2021-04-04 23:28:24 -0500 Some monster vaults for Spider by nicolae (12539) Changes from the submission were minor. Removing some chaff monsters and introducing some randomizations. Also some of the usual syntax cleanup and the removal of DEPTH Spider, since we use a default depth now. Substantive changes described below: nicolae_spider_acid_house: Use acid dragons instead of harmless jellies. Don't place as many of these as the vault had placed jellies, but randomize placement numbers. nicolae_spider_baby_got_redback: Use a simple binomial for placement here, trimming the randomized edge placement glyphs so that the average is about the same. This allows for greater variation in the number of spiders placed. nicolae_spider_bzzzt: Randomize monster counts. nicolae_spider_not_touching_you: Change the SHUFFLE that sometimes mixes in orb spiders to a subst roughly giving the same average. The shuffle has hard to parse in terms of what average monster numbers ended up being. nicolae_spider_paper_wasps: Don't place junk scrolls, instead placing any scroll for all item placement, which is less spoilery. Adjust scroll placement so that we're not giving too many relative to monsters we place. Also randomize monster placement counts. nicolae_spider_scorpion_nest: Don't place ordinary scorpions, as those are far too weak. Place only emperor scorpions, thinning out numbers of monsters, and introducing randomization of monster count. nicolae_spider_swamp_cousins: Randomize monster counts. Mark the vault patrolling, so the non-branch monsters tend to stay in the vault. -------------------------------------------------------------------------------- e335657cc0 | gammafunk | 2021-04-04 23:28:05 -0500 Some decorative Spider vaults from nicolae (12539) No major edits to this set, only removing the Swamp DEPTH, as that's now covered by a default depth. This commit also updates the existing nicolae_spider_cling_ruins to use better glyphs and cleans up some syntax. -------------------------------------------------------------------------------- ed2907cb04 | Kate | 2021-04-04 22:05:56 +0100 Display when boulder beetles are rolling in the monster list And on examining them, since the information wasn't displayed very clearly in console in console. -------------------------------------------------------------------------------- 13725f1865 | Kate | 2021-04-04 21:07:13 +0100 Adjust a canned message for Djinn (#12556) -------------------------------------------------------------------------------- 5e6d803879 | Kate | 2021-04-04 19:40:46 +0100 Refactor handling for convoker recall (#8839) Fixes convokers being immune to cloud damage while reciting recall, but should behave the same otherwise. -------------------------------------------------------------------------------- cab673c142 | sdynet | 2021-04-03 08:45:01 +0300 Simplify and rename the Foxfire card This card had a complicated function. There are many different types of monsters that appear on this card, but there was no reason to do so. And some of the summoned monsters appeared hostile. The name was also not intuitive, making it difficult for users to understand what the card was doing. The user had too many considerations to make this card useful. So I'm going to simply trim this card. The basic feature of this card is that it summons many fast monsters. Therefore, I want to emphasize this characteristic clearly. Now this card summons a very large swarm of bees. In addition, I will change the name to the Swarm to make it easier to understand what this card is summoning. If this change is not enough for cards to be useful, I think we can mix one or two queen bees. [ Committer's note: Closes #1864. Squashed, rebased, tweaked commit message. ] Update crawl-ref/source/decks.h Co-authored-by: Edgar A. Bering IV -------------------------------------------------------------------------------- bd7d8addc9 | Edgar A. Bering IV | 2021-04-03 08:44:35 +0300 Update Yred's description -------------------------------------------------------------------------------- 35c287b088 | Kate | 2021-04-03 02:34:42 +0100 Update a check for whether a monster has a body Used for miscast messages and seemingly nothing else, but this check had fallen out of date with death cobs no longer being on '%'. Ideally these kinds of checks shouldn't be based on monster glyph at all since it makes them very prone to breaking. Also add animated armours, tentacles, and Murray to the list of monsters without a body. -------------------------------------------------------------------------------- 2be9358107 | Kate | 2021-04-03 02:34:42 +0100 Rebrace -------------------------------------------------------------------------------- 39567a0c06 | Kate | 2021-04-02 22:47:00 +0100 Give player ghosts the correct hands and feet Since the hand/foot names were based on glyph, they were buggy for player ghosts. Also give non-classed draconians hands instead of claws. -------------------------------------------------------------------------------- 955cc887ef | Nicholas Feinberg | 2021-04-02 14:17:36 -0700 Gnerf gweapons (split) oops -------------------------------------------------------------------------------- 90918d6062 | Kate | 2021-04-02 21:01:39 +0100 Don't make Yredelemnul forbid statue form Since the nonliving conduct is supposed to be gone. -------------------------------------------------------------------------------- bac1ddba90 | Kate | 2021-04-02 21:01:39 +0100 Adjust some artefact autoinscriptions Use Fly instead of +Fly since it's now a passive effect rather than an evocable one. Also adjust *Contam and *Drain to be just Contam and Drain, so that * consistently indicates an effect that triggers randomly while equipped (*Noise, *Corrode, *Slow, *Tele etc). -------------------------------------------------------------------------------- cbadc6d218 | Edgar A. Bering IV | 2021-04-02 19:56:42 +0300 One more credit -------------------------------------------------------------------------------- 0090c0f15f | Edgar A. Bering IV | 2021-04-02 19:29:45 +0300 Update the changelog through 0.27-a0-877 -------------------------------------------------------------------------------- f2a7138e7e | Edgar A. Bering IV | 2021-04-02 19:28:47 +0300 Another credits update -------------------------------------------------------------------------------- 71947af8c7 | Nicholas Feinberg | 2021-04-02 08:56:29 -0700 Fixup _is_damage_threatening (vt) Correct some old comments and fix an inverted conditional. The previous logic made damage more likely to be considered threatening the *higher* your hp was, which was not intended. -------------------------------------------------------------------------------- fdfa2cc8df | Edgar A. Bering IV | 2021-04-02 18:39:42 +0300 Update the credits -------------------------------------------------------------------------------- 80d416ef6e | kippig | 2021-04-02 18:24:12 +0300 Remove d:1 adder in vault -------------------------------------------------------------------------------- 64e2b160fe | kippig | 2021-04-02 17:08:30 +0300 Add diablo chruch arrival vault adds a church based on the tristram cathedral from the first diablo game. To the sides of the church there is a crypt and through the windows the player can see the lust forest they leave behind. There's also a baptism font (usually dry) because why not. -------------------------------------------------------------------------------- 695312e83b | stahara | 2021-04-02 17:03:27 +0300 RST manual: escape the vertical bar key for layer toggle -------------------------------------------------------------------------------- 6d840ccb4b | Edgar A. Bering IV | 2021-04-02 16:40:36 +0300 New ecumenical altar vaults from ShaperMC -------------------------------------------------------------------------------- c4bfac4c02 | Edgar A. Bering IV | 2021-04-02 10:46:33 +0300 Correct exaggerated poison displays This is a 7 year old edge case that was being hit significantly more often and more dramatically by the acceleration of poison. -------------------------------------------------------------------------------- 165b36e3f0 | Kate | 2021-04-02 02:24:03 +0100 Make WJC Heavenly Storm grant bonus EV For such an expensive active ability, it was fairly difficult to use effectively, since it tries to encourage staying in combat against multiple foes for an extended time (while making a lot of noise) to gain its benefits. Grant it a defensive bonus alongside the offensive one to encourage that use, and slightly reduce the noise to the level of normal shouts. -------------------------------------------------------------------------------- f81f37f261 | Kate | 2021-04-02 01:36:49 +0100 Add a Jiyva mutation to engulf monsters in ooze Applies the engulf effect to applicable monsters (which is approximately "living/demonic/holy monsters which are the same size as the player or smaller") when dealing them damage in melee. As long as they remain adjacent to the player, engulfed monsters take asphyxiation damage over time and are silenced. -------------------------------------------------------------------------------- 4f44552337 | Kate | 2021-04-02 01:25:15 +0100 Allow engulfing constricted targets Engulf uses similar checks to constrict but should be able to be applied independently. Also allow actors which are already constricting something to engulf as well (not relevant for any existing monsters, but relevant for player engulfing in an upcoming commit). -------------------------------------------------------------------------------- 7aa06ce512 | Kate | 2021-04-02 01:25:15 +0100 Don't increase engulf damage against water-vulnerable creatures Since the damage is from being unable to breathe while engulfed (rather than than being explicitly water-flavoured damage like a Primal Wave for example), make it deal the same damage to any target that needs to breathe air. Also add a message when the damage is dealt. -------------------------------------------------------------------------------- 357e685177 | Kate | 2021-04-02 01:25:15 +0100 Improve some engulf handling Improve some messaging to apply more generally to both water and slime, and fix some checks being wrong for water-vulnerable creatures. -------------------------------------------------------------------------------- 801a00d0d6 | Kate | 2021-04-02 01:14:43 +0100 Adjust a potion message -------------------------------------------------------------------------------- ea5aba7016 | Kate | 2021-04-01 22:32:00 +0100 Add some mutation comments -------------------------------------------------------------------------------- b963882b24 | Kate | 2021-04-01 22:32:00 +0100 Reduce shoutitis and no potion heal from 3 to 2 levels Both of these are fairly noticeable bad mutations, but they don't gain much from having so many distinct levels. Reduce them both to 2 level mutations. Shoutitis 1 has the frequency of old level 1 (and the volume of old level 2), and level 2 is equivalent to old level 3. No potion heal now reduces healing by 50% per level instead of 33%. -------------------------------------------------------------------------------- 9529aa9bf3 | gammafunk | 2021-04-01 01:59:26 -0500 Reorganize and fix up Spider and Swamp DES Add sections to spider.des for entr/decor/monster/rune vaults, moving vaults to their appropriate sections. Set a default depth of Spider for non-entry vaults, removing this before the rune vaults, which use PLACE instead of depth. Remove DEPTH: Swamp from vaults that now no longer need this. Reglyph and clean up syntax in a few decorative vaults; others need this as well, but I've just done these few for now. Fix the section description for decorative vaults in swamp.des -------------------------------------------------------------------------------- af99fae3ca | Edgar A. Bering IV | 2021-03-31 21:20:45 +0300 Disable ood fuzzing for 8 and 9 spawns. 8 and 9 are specific requests by vaults for an out-of-depth monster with a certain depth modification. Fuzzing can, early on, turn a 9 into an 8. This was previously less noticable in early D because of the non-monster weight in the spawn table. With that removed a D:4 9 can get fuzzed into something worse than an 8 on a more frequent basis. 0 is not adjusted since it is supposed to be a "typical" spawn, so should behave just as if the dungeon builder is placing the monster. -------------------------------------------------------------------------------- 6cdc3c0863 | Edgar A. Bering IV | 2021-03-31 20:01:04 +0300 Check explosions separately from pathing for danger (12477) -------------------------------------------------------------------------------- 7f24984a57 | Edgar A. Bering IV | 2021-03-31 19:51:09 +0300 Trigger location effects after a wind blast (12474) -------------------------------------------------------------------------------- 37602865fa | Edgar A. Bering IV | 2021-03-31 18:50:38 +0300 Interrupt travel when blinked by a dispersal trap (12491) -------------------------------------------------------------------------------- dfebced566 | Edgar A. Bering IV | 2021-03-31 18:42:20 +0300 Don't prompt with a silenced singing sword (12549) -------------------------------------------------------------------------------- d46e367e5e | Edgar A. Bering IV | 2021-03-31 17:01:21 +0300 Grant wereblood bonuses in agreement with the description (12546) -------------------------------------------------------------------------------- 62f096ca86 | Edgar A. Bering IV | 2021-03-31 16:52:25 +0300 Add some transparency tags to ice cave entries (12503) -------------------------------------------------------------------------------- 031e6c2d63 | Edgar A. Bering IV | 2021-03-31 16:06:48 +0300 Remove a duplicate entry in zap-data -------------------------------------------------------------------------------- 6be897d7e5 | Implojin | 2021-03-31 13:48:14 +0300 Add some missiles to default autopickup Curare, atropa, dispersal, and throwing nets are all highly useful items that can save characters. This commit adds them to autopickup by default. (9 years ago, curare was removed from autopickup in e11df56, for reasons that have since been obviated. Everything old is new again!) Closes #1849 -------------------------------------------------------------------------------- b79eb4bb99 | gammafunk | 2021-03-31 04:04:04 -0500 More Swamp vaults from nicolae (12518) A set of decor vaults missed from the last round of merging nicolae's Swamp vaults, and a set of vaults that place monsters. There are some usual edits to syntax, but nicolae kindly reglyphed and made various other requested changes already, so these were not extensive. Below is a description of content changes to the monster vaults: nicolae_swamp_necromancer_hut: Remove the trivial zombies, such as swamp drake and water moccasin. nicolae_swamp_catching_bugs: For the bugs, replace the hornets with a small chance for spark wasps. nicolae_swamp_flooded_prison: Replace the trivial spectres with branch appropriate spriggan rider and spriggan berserker ones. Remove shadows and wraiths, opting for freezing wraiths and will-o-the-wisps, but placing fewer of them. nicolae_swamp_husk_halls: Randomize the number of husks so that we guarantee two but might place one in all four hallways, and put randomized 0 spawns in each hallway, a bit closer than the husk, so we the player can try to use the husk to their advantage. nicolae_swamp_necromancy_gone_wrong: Don't mark the hydra chamber as no_tele, since this is not a teleport closet, just a nasty area. Rework item placement to use more good_item and mix in better loot potions/scrolls in the relevant items, but make all but the necromancy book have a 50% chance to place. Spread any generated items out over the chamber instead of placing them in a big pile. nicolae_swamp_standing_stones: Make potions and scrolls loot of better types and spread out loot items instead of placing in a pile. nicolae_swamp_super_fun_site: Place miasma clouds over water instead of using toxic bog features, which players won't have seen outside of the spell. nicolae_swamp_spooky_pond: Mix in some spooky bog bodies to go with the spooky wisps. -------------------------------------------------------------------------------- 91c9f2ae56 | gammafunk | 2021-03-31 04:03:15 -0500 Remove unnecessary DEPTH statements These swamp vaults can use the default depth, which is Swamp, instead of setting it on their own. -------------------------------------------------------------------------------- 3f109eccf5 | Aliscans | 2021-03-31 11:55:46 +0300 Make acid walls "melt" icy monsters instead of burning them. Change the message when slime_wall_damage() affects an icy monster from (e.g.) "The wall burns the fire elemental shaped block of ice!" to "The wall melts ...". Ice doesn't burn. Remove the message for when acid walls affect the player, as you.splash_with_acid() hasn't used custom messages since 91b40731d1. -------------------------------------------------------------------------------- 9fcfa7f03e | Edgar A. Bering IV | 2021-03-31 11:18:58 +0300 Update altar vault guidelines -------------------------------------------------------------------------------- b608904985 | Edgar A. Bering IV | 2021-03-31 10:52:28 +0300 New ecumenical altar vaults We still need more of these, but this is a start. A collection of small vaults placing the faded altar plus a bit of decor, some of which suggests an old temple (webs, ruins, etc.) or place of worship. There still aren't enough, so to keep them fresh the weight of the basic vault is increased. Hopefully by the next release we'll have plenty of vaults. -------------------------------------------------------------------------------- 9d1eab6076 | Edgar A. Bering IV | 2021-03-31 10:51:54 +0300 Adjust existing ecumenical altar vaults Add a bit more randomization, fix global header style. -------------------------------------------------------------------------------- 634789ea28 | Edgar A. Bering IV | 2021-03-31 10:51:54 +0300 Move ecumenical altars to their own des file -------------------------------------------------------------------------------- b7e72e7e12 | Edgar A. Bering IV | 2021-03-31 10:51:54 +0300 Enforce overflow temple depth restrictions in the builder Overflow temples can place one of two ways: via the overflow temple placement mechanism and as depth-selected minivaults with the uniq_altar_FOO tag. This commit constrains overflow temples to be eligible for minivault placement only after the end of overflow temple depth. On the des side this makes vault specification cleaner and future robust; overflow vaults no longer need to know the specific overflow temple range. Not all overflow vaults could place as minivaults, and a minivault placement would override the later overflow placement, which meant some downweighted special vaults were extra rare (sad!). Now they work together a bit better For dungeon geography and gameplay, the combination of this change with the preceeding sequence adjusting altar placement means that each temple god gets exactly one guaranteed altar in the overflow range. This should give a bit more verve to the milestone of finding a god in the early game as well as equalize the chances of finding a given god by D:10, and make the chance early altar and early ecumenical altar feel more stand-out. -------------------------------------------------------------------------------- 594c3d14ea | Edgar A. Bering IV | 2021-03-31 10:51:54 +0300 Shift overflow temples deeper, increase ecumenical altars Ecumenical altars suffer from the fact that they don't always show up before identified altars; the choice becomes more about a conduct than the chance to gamble for a serious advantage. This commit moves all overflow altars to D:3-. Combined with the previous commits, this means that the only way for an altar to appear on D:1-2 is via the basic_altar vault, which is given an explicit chance of 33% on D:2. Ecumenical altars are given a 50% chance for each of D:1-3. This makes for an 87.5% chance of seeing one, and a 50% chance of seeing one before any identified altar. There is some concern that placing an ecumenical altar on D:1 will encourage startscumming, but a player who would quit on D:1 because they didn't like their ecumenical roll would probably also quit on D:2. -------------------------------------------------------------------------------- 6dff9fb094 | Edgar A. Bering IV | 2021-03-31 10:51:54 +0300 Fix some item specs in altar vaults -------------------------------------------------------------------------------- a37c644b7a | Edgar A. Bering IV | 2021-03-31 10:51:54 +0300 Fade the altars in serial_column_ruins It fits so well with the theme, and also the strict control over identified altar placement in D:1-10. -------------------------------------------------------------------------------- ef54952615 | Edgar A. Bering IV | 2021-03-31 10:51:54 +0300 Remove decorative altars from early D vaults This either adds conditional placement, simply deletes the altar, moves the depth range out of D, or turns the vault into a proper overflow temple depending on the vault tweaked. This is part of a sequence of commits giving the dungeon builder more control over the placement of early altars where they have a large strategic impact. -------------------------------------------------------------------------------- aef5f389f5 | Edgar A. Bering IV | 2021-03-31 10:51:54 +0300 Move non-overflow altar vaults out of D To give more fine-grained control over altar placement in D. Some generic vaults become overflow temples, the rest have their placement adjusted. This change is not applied to non-temple gods, who are special and can do their own thing. -------------------------------------------------------------------------------- 3f101e3ede | Edgar A. Bering IV | 2021-03-31 10:51:53 +0300 Place fancy overflow temples only as overflow temples Most of these were missing one of the two overflow tags, so could only place as minivaults (sad!). These are flashy, to keep them from getting over-used now that their tags are fixed I've made them all overflow-only for the time being. If they become depth-eligible again then the overflow_depth function in overflow.des will need to be moved into an accessible scope. -------------------------------------------------------------------------------- d615d5975c | Edgar A. Bering IV | 2021-03-31 10:51:53 +0300 Unify and overhaul depth and tags of overflow temples Some old overflow temples were incorrectly tagged, and weren't treated as overflows; or had DEPTH specifiers and interest checks as if they were aimed to place as mini-vaults but lacked the necessary tag to be eligible for placement. This commit adds a section to the vault guidelines explaining how to tag and annotate overflow temples and edits the existing temples to fix up some old ones and bring everything into compliance. It also adds some future proofing for overflow temples that include a DEPTH specifier, by having all of them call `: overflow_depth(_G)`. This allows for easier global changes to overflow altars (coming soon!). -------------------------------------------------------------------------------- fc908b8576 | Nicholas Feinberg | 2021-03-30 20:27:24 -0700 Flip turn dragons rightways (gammafunk) Also brighten up swamps and fires. -------------------------------------------------------------------------------- 365ecc8b8e | Nicholas Feinberg | 2021-03-30 20:13:52 -0700 Many new tiles (Sastrei) Destroyer, Rockslime, Lom Lobon, most dragons, and Crazy Yiuf. Plus a tweak to the hound tile, and I removed fire drakes while I was at it. I made minor cosmetic edits to some tiles. Sorry, Sastreii! -------------------------------------------------------------------------------- cb938e01ab | Nicholas Feinberg | 2021-03-30 19:50:08 -0700 Finish the preceding commit Oops. -------------------------------------------------------------------------------- 0ae26c12d3 | Nicholas Feinberg | 2021-03-30 19:45:59 -0700 Dehydrate quicksilver oozes Don't claim they engulf the player in water. -------------------------------------------------------------------------------- d5c7c66f0a | Nicholas Feinberg | 2021-03-30 12:42:53 -0700 Nerf hobgoblin damage a little bit Pulling back on very early-game lethality again. -------------------------------------------------------------------------------- 39f900b3a3 | Nicholas Feinberg | 2021-03-30 12:42:53 -0700 Remove D:1 halberd gnolls In line with removing d:1 gnoll bands and gnolls with nets, give players a little longer before experiencing the true, unadulterated terror of Gnoll. (Unless they're playing gnollcrawl.) -------------------------------------------------------------------------------- a1c911b16d | advil | 2021-03-30 10:40:16 -0400 Tweak the fsim test This test was using a mifi and is therefore impacted by shield skill in a way that is somewhat orthogonal to the point of the test (e.g. the results changed with 0b64aa269c0). Switch to a migl. -------------------------------------------------------------------------------- 6b54cd8ccd | advil | 2021-03-30 10:20:12 -0400 Fix a warning -------------------------------------------------------------------------------- 8289197e94 | Aliscans | 2021-03-30 08:16:52 +0300 Disable spellcasting skill gain for new berserkers. If automatic training was set, and the skills the player actually used all reached 27, the game would start to train the other skills, including the magic skills. This means that someone could offend Trog by training magic skills without casting a spell or visiting the skill management screen. This change turns magic skills off at the start of the game for a berserker (as already happened when you joined Trog at an altar), and avoids that possibility. -------------------------------------------------------------------------------- bb90f61fe4 | advil | 2021-03-29 19:33:39 -0400 sdl2 contrib: fix the build for ARM macs (12407) Basicaly just a missing include, seems to run fine with this fix. -------------------------------------------------------------------------------- 08ebd167ff | advil | 2021-03-29 19:02:23 -0400 libpng contrib: Force-disable neon optimizations on ARM (12407) This is apparently buggy, and preventing M1 builds from succeeding. -------------------------------------------------------------------------------- dbc16e4eb9 | Kate | 2021-03-29 23:07:23 +0100 Fix randart flight property not granting flight (MarcB) -------------------------------------------------------------------------------- ca8104f8d5 | Kate | 2021-03-29 21:20:09 +0100 Revert "Prevent draconians from getting armour troves" This commit didn't actually properly do the thing it claimed to do (trove_armour_1 could generate for draconians), and it also wasn't really necessary since draconians would still generally get lots of good aux armour from these troves. It also tried to prevent draconians from being asked for enchanted dragon armour as a trove toll, but this only worked on always flying, like Djinni. * Emergency flight and potions should be unchanged. * the abilities to start and stop flying are removed, as is ATTR_FLIGHT_UNCANCELLABLE and ATTR_LAST_FLIGHT_STATUS. The one remaining special case I know of (pointed out by Kate) is that Op and Mf have incentives not to fly; I'll deal with that in a separate commit. The old flying code had so many weird interactions that there may still be special cases that don't work right here... -------------------------------------------------------------------------------- be893936b8 | Edgar A. Bering IV | 2021-03-27 23:35:54 +0300 Another poison correction -------------------------------------------------------------------------------- 029fd2ff89 | Edgar A. Bering IV | 2021-03-27 20:45:29 +0300 Correct some poison magic numbers (12544) -------------------------------------------------------------------------------- 212f9d8316 | Edgar A. Bering IV | 2021-03-27 19:56:08 +0300 Correct static discharge resist message order -------------------------------------------------------------------------------- e6ed7f9ff8 | Edgar A. Bering IV | 2021-03-27 19:56:08 +0300 Correct Freeze messaging Correctly display attack punctuation for players and monsters, and appropriately print resist checking messages when players are hit with monster Freeze. -------------------------------------------------------------------------------- 0f416b50e7 | advil | 2021-03-27 12:41:04 -0400 Rename and document a #define for downstream use Downstream packaging targeting reproducible builds may set file mtimes to a stable value, e.g. 0; see #1702. Unfortunately .des cache invalidation relies on mtime, so this ends up breaking under these build conditions. This commit is aimed to refine and simplify the advice I gave in that issue thread: versioned des cache directories are now our (or at least my) official recommendation for dealing with this situation. This change makes it clearer that this option is not tied to DGL, and provides a hint about the option directly in the Makefile. I've tested this and it seems to work fine on its own. Resolves #1702 -------------------------------------------------------------------------------- 27d10ad80f | Nicholas Feinberg | 2021-03-26 18:35:05 -0700 New Iron Golem tile (Sastrei) Plus, de-rim Manticore. -------------------------------------------------------------------------------- f314fb5061 | Nicholas Feinberg | 2021-03-26 17:32:17 -0700 A bevy of new tiles (Sastrei) Goliath Frog, Manticore and Quicksilver Ooze. Get your mind out of the gutter! -------------------------------------------------------------------------------- e5c3fa52fd | Neil Moore | 2021-03-26 16:45:53 -0400 Use shrunken reencoded molluscs That is, convert the smaller version of title_anon_octopus_wizard.jpg to a .png. Not only does the Makefile assume .png for title screens, but client.html was already referring to the (missing) .png file. Also, remove the larger-resolution copy of the .jpg. -------------------------------------------------------------------------------- 38526b5af1 | Kate | 2021-03-26 20:43:44 +0000 Don't allow force-targeting spells when Xom is casting them Since it'd allow cancelling out of the spell. -------------------------------------------------------------------------------- d86de039f5 | Nicholas Feinberg | 2021-03-26 13:08:46 -0700 New octopus wizard title screen Source: https://crawl.develz.org/tavern/viewtopic.php?f=17&t=23228&p=308883&sid=73a8cc49 84fe0311df8fb40206007884#p308883 CC0'd by artist. Asked not to be credited. -------------------------------------------------------------------------------- 8e0dbb66be | advil | 2021-03-26 12:51:12 -0400 When force-swapping a ring, skip unequip effects (11879) Sacrifice hand, then there is a free ring slot, would apply unequip effects on the move, setting up an odd situation for players wearing only one ring on the sac hand target; they should have taken steps to get the ring on their other hand (e.g. by juggling rings, or setting jewellery_prompt = true). I had previously semi-resolved the most annoying point for this bug by making the default ring hand distinct from the default sac hand, but this led to display issues. This commit resolves the bug in a different way, by basically force-moving a ring in this situation while not applying penalties. It also doesn't prompt the player to rewear the ring if there is a bad inscription. Basically, this is intended to make sac hand have no effect on any scenario where a player is wearing one ring (though there is still some messaging). -------------------------------------------------------------------------------- a16a6a3dab | advil | 2021-03-26 12:51:12 -0400 Refactor some arm order stuff, again This changes how arm order is handled from efe1b4415. There, I tried to make things more consistent by providing the arm to be sacrificed as the last element of a vector. This unfortunately has run up against inconsistencies with display order, where it is better to show the left arm first (when there are two). Instead, localize the missing hand calculation to species.cc. It might be better to change the sac hand target, but I don't want to deal with the save compat involved. This commit is a regression for 11879; the default ring target is now once again the left hand (also the sac target). -------------------------------------------------------------------------------- 8ff0b3a6de | Nicholas Feinberg | 2021-03-26 07:42:44 -0700 Tweak Dj job recs Don't recommend berserker, do recommend transmuter. Might be fun? -------------------------------------------------------------------------------- 6bb3289e1e | gammafunk | 2021-03-26 00:16:58 -0500 checkwhite player.cc -------------------------------------------------------------------------------- dcf64ac7a9 | gammafunk | 2021-03-25 22:25:00 -0500 Updates to Hell entry and vestibule vaults In line with the removal of weaker Depths monsters, update the Hell entry vaults to place nothing worse than a tier 3 demon-wise and to update other monsters where appropriate. Likewise update the vestibule subvaults in a similar fashion, so that players coming from Depths won't be confronted with e.g. white imps. The Hells still place plenty of chaff monsters, but those at least have Hell effects and other much stronger monsters we don't use the in the vestibule. -------------------------------------------------------------------------------- cb5310748e | gammafunk | 2021-03-25 22:25:00 -0500 Updates to monsters in Depths encompass vaults Some changes to three Depths encompass maps in line with updates to vaults in 9d5772c0. This commit only handles encompass maps; future commits will address float and minivaults for Depths. map lemuel_river_lethe This vault has some idiosyncratic monster placement that's definitely due for an update. Replace the arrival hell hounds with spectral monsters, reinforcing the undead theme the map has, and replace weak spectrals and simulacra with spectrals drawn from the Depths monster set, which will generally be strong. Remove weaker monsters such as dancing weapons and skeletal warriors, giving suitable upgrades such is iron dragons, vampire knights, vampire mages, and deep elf death mages. Slightly buff loot in a couple places. Remove the guaranteed potion of brilliance under each orange crystal statue, which is not necessary and also a relic from when that potion granted Int. Reglyph certain symbols that override existing definitions and simplify shuffle/subst/nsubst. box_level_dp Update this map to have more coherent monster sets and loot distribution. For the outside area, instead of four monster themes of elves, tengu, spriggans, and a mashup of giants and humans, make two themes of elves+tengu and spriggans+giants. These new sets use only monsters appropriate for Depths, instead of pulling in lower-HD monsters from previous branches. Also update the bee area to have only meliai and a smattering of spark wasps, since killer and queen bees pose no threat. The meliai run the hive, but some wasps are raiding it! Update the potion loot in this area to not be only ambrosia, but any kind of potion, just with less instances. Also remove the guaranteed reflection amulet and scrolls of teleportation loot items in the central box. Both are vestiges of earlier versions of crawl where the teleport traps worked out of LOS to disperse monsters. I'm not sure that the teleport scrolls ever did anything meaningful, but the reflection amulet was actually stasis at one point, presumably to allow a (single) monster to be immune to the traps. In any case, neither need to be explicitly given as loot; the vault gives a high amount of loot as it is, including 16 superb_item. hangedman_crystal_crosses_colossus Minor updates to monster lists. Replace nagaraja, which didn't meet the flavor text's described theme of elemental magic, with the new salamander tyrant. Also replace lower-level elves with deep elf elementalists. Former can't use their awaken earth gimmick, but they can hit harder with fireball and likewise have freezing cloud. Replace weak simulacra with stronger ones, shock serpents with spark wasps, since we have those for Depths now. Remove mana vipers, since those are relatively weak and don't match the elemental theme. hangedman_spin_cycle Update the Depths and shared Dungeon/Depths monster sets. For the latter, replace boggarts with glowing orange brains, orc knights with spriggan berserkers, and naga mage with salamander tyrant. For the Depths-only sets, replace deep elf knights with deep elf death mages and orc high priests with spriggan air mages. Also replace death knights with liches and merfolk aquamancers with tengu reavers. Finally, move a lua block into braces. -------------------------------------------------------------------------------- a30e6d9879 | gammafunk | 2021-03-25 22:25:00 -0500 Rework an altar vault The vault due_chaos_kobolds placed kobolds with distortion or chaos weapons in late branches for flavor, but we're moving away from chaff monsters in late game areas. This commit reworks the vault to be a runed door vault that places in most of Dungeon, using depth-appropriate Kobolds with ugly thing monsters mixed in for later depths. -------------------------------------------------------------------------------- bcfb333f5d | gammafunk | 2021-03-25 22:25:00 -0500 Make some monster item functions more available The function ghost_monster_weapon() had been previously used only for ghost vaults, but this functionality is useful for any vault that wants to specify thematic monster weapons. This commit moves the function and associated table to dgn.monster_weapon() and fix up documentation of both the table and the function. Also rename random_item_def() to dgn.random_item_def(), to be consistent with use of the dgn namespace. Adapt all the vaults currently using these functions to the new names. -------------------------------------------------------------------------------- a1918b6f54 | kippig | 2021-03-25 22:25:00 -0500 Revamp Depths vaults to match the monster table Committer's Note: This commit updates some Depths vaults to replace relatively trivial monsters with more suitable ones, in line with recent changes to the Depths monster lists. I've cleaned up this commit's title, cleaned up a comment for grunt_enter_depths_giant_problem, and tweaked the monster list in hangedman_depths_entry_civil_slaughter in addition to what was done in the original commit. Subsequent commits make further updates to these vaults and other Depths vaults not covered by this commit. Closes #1791. -------------------------------------------------------------------------------- b2075fc2c6 | Nicholas Feinberg | 2021-03-25 20:04:18 -0700 Simplify Tutorial 2 Devolve the more complex endoplasm into a simpler ooze. -------------------------------------------------------------------------------- 3740f5f239 | Nicholas Feinberg | 2021-03-25 19:55:18 -0700 Improve dj msg order (rydianmorrison) Memorize the spell after telling the player about it, so that associated messages (e.g. rcfile remapping spells to another letter) print after you learn what the spell in question is. -------------------------------------------------------------------------------- d11a64c996 | advil | 2021-03-25 22:20:15 -0400 Don't generate .map files in normal circumstances These don't seem very useful these days; the code predates webtiles and also probably easy modern screenshotting. The underlying code is still used in various debug / crash scenarios. -------------------------------------------------------------------------------- eb8d7bc690 | Kate | 2021-03-25 22:46:58 +0000 Restore Majin-Bo's intended behaviour at low HP (PleasingFungus) Make it reduce HP to 1 if the full cost can't be paid, instead of preventing casting at all if HP is too low. -------------------------------------------------------------------------------- dc96bc62b2 | Kate | 2021-03-25 21:51:14 +0000 Fix compilation Whoops. -------------------------------------------------------------------------------- 3c0359225a | Kate | 2021-03-25 21:49:26 +0000 Don't allow paying more HP than you have with Majin-Bo equipped -------------------------------------------------------------------------------- 7beb378477 | Kate | 2021-03-25 20:28:52 +0000 Update Shadow Form description -------------------------------------------------------------------------------- df32bb633b | Nicholas Feinberg | 2021-03-25 12:22:37 -0700 Remove endoplasms' will Accidentally left in when they were turned into earlier-game monsters. Now Will:20 -> Will:0, matching other D:1 foes. -------------------------------------------------------------------------------- 37402fc473 | Nicholas Feinberg | 2021-03-25 08:57:23 -0700 Add good dogs (Sastrei) New tiles for hound, wolf, gnoll sergeant, gnoll shaman, and Grum. -------------------------------------------------------------------------------- 3e622ea735 | advil | 2021-03-25 08:43:02 -0400 Prevent crashes on unknown score species during death This should fully close the barn door behind the recent Dj score crashes (i.e. prevent these crashes from happening in the future if the old species enum ever again doesn't line up with what's on some server). -------------------------------------------------------------------------------- aaee5cf45b | Nicholas Feinberg | 2021-03-24 20:00:34 -0700 Many meat tiles (Sastrei) Bag of meat, meatzerker, large bag of meat, meat hydra, scourge, aaand... The Meatlord. -------------------------------------------------------------------------------- 49a6215e69 | Nicholas Feinberg | 2021-03-24 19:40:17 -0700 Raise Manifold Assault to level 5 It's a very fun spell and people have been putting it to great use, but it should require a little more investment to cast than it currently does. -------------------------------------------------------------------------------- dbedfec26c | Nicholas Feinberg | 2021-03-24 19:37:13 -0700 Buff gnolls (Sastrei) New tile! -------------------------------------------------------------------------------- 74b304f62e | advil | 2021-03-24 21:46:18 -0400 Improve automagic_stop behavior for Dj This lets this option work for Dj based on hp percentage, allowing players to set a distinct autofight threshold for autocasting vs general autofight on this species. Along the way I did fix automagic for Dj, deprecated though it is. But, automagic may eventually just get removed. Resolves #1851 -------------------------------------------------------------------------------- 2a0442d20d | advil | 2021-03-24 19:19:57 -0400 Save abyss on AK start Before this commit, this abyss was in a precarious state: generated, but not saved to disk. An AK start crash (of the kind that doesn't save the game) could load to a load that put the character in a featureless void, crashing immediately (except in wizmode). A previous commit does fixup for this scenario, but this commit should prevent it from happening for future games altogether. -------------------------------------------------------------------------------- f22881d5bd | advil | 2021-03-24 19:19:57 -0400 Fixup for unsaved abyss crashes If the game crashes without saving before an AK start has saved and while they are in the abyss, the abyss map is not saved, and they reload in an empty featureless void (that crashes). This fixup code simply adds a floor and moves the player to that position, as a very ad-hoc emergency measure so that the game will load. The results look weird but should allow the AK start to get out of the abyss (the position is also one that triggers an abyss shift immediately if they want to stick around). -------------------------------------------------------------------------------- 00efbec225 | Kate | 2021-03-24 20:53:32 +0000 Remove scrolls of random effects Replacing them entirely with scrolls of noise. Noise has a much better ability to do something meaningful when read-identifying, where scrolls of random uselessness would generally just cost a turn once per game. -------------------------------------------------------------------------------- 1b1bd85602 | Kate | 2021-03-24 20:07:01 +0000 Remove ants There are a large number of early-to-mid-game poison monsters, between the many types of snakes, spiders and bees. Ants didn't fill much of a gap and were barely used outside of anthill vaults (which weren't particularly distinct from beehives) and early Dungeon worker ants. Worker ants in D have their weight split between scorpions, hounds and iguanas, and in vaults are mostly replaced with scorpions. Soldier ants in vaults are mostly replaced with water moccasins or vampire mosquitos. -------------------------------------------------------------------------------- e4d627daa3 | Nicholas Feinberg | 2021-03-24 07:26:57 -0700 Unremove removed OLD_SP_DJINNI (kate, Implojin) It turns out this was still needed to avoid a crash. Oops! -------------------------------------------------------------------------------- 9892240997 | Nicholas Feinberg | 2021-03-24 07:10:00 -0700 Remove an insult to Centaurs Since they were removed ;) -------------------------------------------------------------------------------- 7101f7346d | Kate | 2021-03-24 11:30:02 +0000 Remove monster Freeze's ministun against other monsters This effect has long been gone from player freeze. -------------------------------------------------------------------------------- 2da19512c5 | Kate | 2021-03-24 10:21:55 +0000 Adjust some more player species-based vaults heliophobic_arrival_battle_scene tries to place player species skeletons, so Palentonga are fine (as they have a dummy monster), but Djinn caused vault errors. -------------------------------------------------------------------------------- a145f7f72e | Kate | 2021-03-24 10:19:39 +0000 Remove some more halfling remnants From a number of player-species-behind-glass vaults (most of which were also outdated from previous species removals/additions), and other vaults based on player species. -------------------------------------------------------------------------------- c38aae387d | Nicholas Feinberg | 2021-03-23 21:25:44 -0700 Remove irrelevant % lines for Dj Don't show MP or spell levels. -------------------------------------------------------------------------------- 6e9d80e302 | Nicholas Feinberg | 2021-03-23 21:22:30 -0700 Nerf a few more early orcs Still compensating for monster weapon buffs/simplification. Later game monsters can hopefully fend for themselves. -------------------------------------------------------------------------------- dd57cda9ea | Nicholas Feinberg | 2021-03-23 21:03:10 -0700 Make D spawn tables more sane Don't spawn monsters far beyond any depths they'd be relevant in. We'll miss you, D:11 quokka, but... not very much. Overall XP generally pretty close, both level-by-level and overall. Late D (D:10-15) has about 65-75% as many monsters as before. A few monsters now show up earlier than before, such as black bears and jellies. The baby dragons (steam/acid) are a bit more common. Quasits and soldier ants no longer spawn in D, in preparation for upcoming changes. -------------------------------------------------------------------------------- fceadbd91f | Nicholas Feinberg | 2021-03-23 19:11:29 -0700 Clarify !attraction (Pekkekke) -------------------------------------------------------------------------------- 2394d0fbd4 | Nicholas Feinberg | 2021-03-23 18:30:06 -0700 Rename ooze -> endoplasm To reduce confusion wrt their new freezy ways by giving em a new name. Also apply a gentle hint of frosty blue to their tile. -------------------------------------------------------------------------------- d7be90942d | Nicholas Feinberg | 2021-03-23 18:19:31 -0700 Fix Dj/Pa manual species order (|amethyst) -------------------------------------------------------------------------------- 7c41658a71 | Nicholas Feinberg | 2021-03-23 18:03:59 -0700 Ban Dj from Kiku and Veh I was undecided about this, but dev consensus seems to largely be behind the change. The goal is to reduce player confusion and to make ecumenical altars a bit less of a trap for Dj, since the 'spell gods' do extremely little for Dj. -------------------------------------------------------------------------------- 5a20dcc000 | Nicholas Feinberg | 2021-03-23 17:43:57 -0700 Fix monster Freeze damage display It was actually 1d5 but claimed to be 1d7, due to a difference between the monster casting code and the player casting code. -------------------------------------------------------------------------------- c3205288ea | Kate | 2021-03-23 22:03:28 +0000 Skip permanently useless potions with Gozag petition Specifically magic for Djinn, and lignification for Mummies/Ghouls. -------------------------------------------------------------------------------- 82d5626f1f | Aliscans | 2021-03-23 22:53:15 +0200 Sort items in a shop in a more predictable order when using ORDER_DEFAULT. As it was, ORDER_DEFAULT sorted items according to the order in which they were originally created by the game. This seems like an unhelpful default to me, and there is no option to control it. This change means that, when you go into a shop, items are sorted by DESC_DBNAME, and by DESC_PLAIN where this doesn't distinguish them. The exeception is known artefacts, which may not contain their DBNAME in the displayed item name (such as the mask of the Dragon, which is sorted with 'h'), so they use DESC_QUALNAME (which sorts it into 'm'). Similar items are together (all robes, all +0 robes, all wands, etc.), and most things are in alphabetical order. If you switch to "sort by price", this order is used for items which cost the same amount. Delete ORDER_TYPE. Change ORDER_DEFAULT to use its label. [committer's note: squashed all commits in the PR, and did some refactoring. Closes #1826.] -------------------------------------------------------------------------------- 10b8fb2fd0 | Goratrix | 2021-03-23 20:32:28 +0200 Supress a compiler warning on Windows -------------------------------------------------------------------------------- 4f19927427 | Nicholas Feinberg | 2021-03-23 08:39:26 -0700 Drop Dj weapon apts by 1 (nikheizen) Since their Spellcasting speciality means they have fewer things to skill, they have more XP sloshing around for hybrid builds. Make it slightly trickier to 'have it all'. Unarmed combat is untouched for now due to being pretty XP hungry anyway, but I might revise that later. -------------------------------------------------------------------------------- dd9af0c1c5 | Nicholas Feinberg | 2021-03-23 08:27:38 -0700 Fix Veh Dj power display bug Don't claim Veh can give Dj spells. -------------------------------------------------------------------------------- 32f27e8180 | Nicholas Feinberg | 2021-03-23 08:20:49 -0700 Gargoyle Jiyva max Invo title: Rockslime (hellmonk) -------------------------------------------------------------------------------- 1ccb5b4bd3 | Nicholas Feinberg | 2021-03-23 08:19:49 -0700 Dj: guarantee new spells on level up (ardl) Don't allow overlap between the random level-up spells and the starting book spells, if any. -------------------------------------------------------------------------------- fadad42f22 | Nicholas Feinberg | 2021-03-23 08:10:38 -0700 Display ooze freeze damage on xv -------------------------------------------------------------------------------- 2d21d9d4bd | Nicholas Feinberg | 2021-03-23 08:08:24 -0700 HACK: semi-fix Freeze death message Don't claim oozes "invoke" Freeze. -------------------------------------------------------------------------------- 2db2cc2744 | Kate | 2021-03-23 11:55:32 +0000 Add a message when equipping Wucad Mu as a Djinn -------------------------------------------------------------------------------- 8cfd13017f | Kate | 2021-03-23 11:36:11 +0000 Adjust formatting -------------------------------------------------------------------------------- 9bdce53276 | Kate | 2021-03-23 11:31:25 +0000 Don't let the staff of Wucad Mu activate for Djinn Since they'd only get the backfire effects and not the benefits. -------------------------------------------------------------------------------- 4d3ab90b7f | Kate | 2021-03-23 11:06:57 +0000 Let wisp/statueform players worship Yred (Yermak) -------------------------------------------------------------------------------- 640f5e82da | Kate | 2021-03-23 11:06:57 +0000 Don't let Djinn mutate poison resistance Since they're already immune. -------------------------------------------------------------------------------- 6942c2d063 | Edgar A. Bering IV | 2021-03-23 10:41:04 +0200 Changelog through 0.27-a0-737 -------------------------------------------------------------------------------- 0a99b990b4 | WhiteShark | 2021-03-23 09:09:18 +0200 Update to Blade Hands description The old Blade Hands description used the word "hands" regardless of the manipulator type for the species. In addition, it failed to mention that it would meld shields and gloves. A function was added to l-you.cc to get the hand type of the player species, and the Blade Hands description now checks hand type to determine the noun used for the player's manipulators. The description was also changed to say that shields and gloves are also melded. -------------------------------------------------------------------------------- af063e7127 | Aliscans | 2021-03-23 09:05:03 +0200 Change a comment to show the power of the warlock's mirror correctly. A comment in bolt::misses_player() states that a displayed SH of 20 gave a 50% chance of blocking ench-type effects, but the code gave the chance of blocking as SH*2 in SH*2+20; 2/3 for SH=20 and 1/2 for SH=10. Make the comment match. -------------------------------------------------------------------------------- 06f963a177 | Aliscans | 2021-03-23 09:05:03 +0200 Add a relevant debug statement for blocking AUTOMATIC_HIT bolts. Separate the "automatic hit" calculation from the "no automatic hit" check in bolt::misses_player(). Change the debug message for "automatic hit" to one which reflects the calculation it actually makes. -------------------------------------------------------------------------------- 3579b8c60d | Aliscans | 2021-03-23 09:03:58 +0200 Make autoexplore/travel wait for barbs to time out. As things stood, trying to travel with barbs stuck in you would see the game ask for confirmation, move a single square (if you accept) and then stop because of the HP loss. This change makes it so that the game waits for the spikes to time out before moving. You can't remove barbs if you are confused or asleep, but you can't travel then either, and player::is_sufficiently_rested() isn't used for anything else. -------------------------------------------------------------------------------- c3177a88c8 | bstrie | 2021-03-23 08:50:24 +0200 Use https rather than git protocol for submodules Fixes unexplainable breakage with `git submodule update`. As discussed with ebering on IRC. -------------------------------------------------------------------------------- a892ba84f6 | Nicholas Feinberg | 2021-03-22 19:30:46 -0700 Reflavor misleading engulf attacks (dinky) Starcursed masses and tentacled starspawns don't have the 'engulf' effect from e.g. water elementals, so they shouldn't claim to engulf. -------------------------------------------------------------------------------- 03f32850a8 | Neil Moore | 2021-03-22 22:26:30 -0400 Correct syntax in docs. [skip ci] <- supposedly this works now? -------------------------------------------------------------------------------- 9302c29d50 | Kate | 2021-03-23 02:23:50 +0000 Fix tag_upgrade builds -------------------------------------------------------------------------------- 6601e7f8fe | Nicholas Feinberg | 2021-03-22 18:55:04 -0700 Make dj crash less Accidentally deleted their flat HP mut in the merge. -------------------------------------------------------------------------------- 8f833cc6cc | Kate | 2021-03-23 01:44:24 +0000 Make Rupert's Berserker Rage a natural ability So it's no longer affected by antimagic, since that doesn't really fit the flavour. -------------------------------------------------------------------------------- 922fb1cf6a | Kate | 2021-03-23 01:44:24 +0000 Rework spell handling for silencable innate abilities Removes the MON_SPELL_NO_SILENT flag in favour of a new category of spell, MON_SPELL_VOCAL, for natural abilities that cannot be used when silenced. Fixes buggy spellbook display for various monsters (#12516). A few monsters are changed in functionality: Vault wardens' Seal Doors is wizardly instead of magical, so counts for Trog piety. Xtahua's Paralyse, Rupert's Paralyse and Confuse, and Geryon's Summon Hell Beast are vocal instead of magical, so are no longer affected by antimagic. -------------------------------------------------------------------------------- eb20345811 | Kate | 2021-03-23 01:44:24 +0000 Remove an obsolete special-case Natural spells are already silent unless specified otherwise. -------------------------------------------------------------------------------- 30b8c66569 | Nicholas Feinberg | 2021-03-22 18:31:35 -0700 Lizard vault fixes (r-i) -------------------------------------------------------------------------------- 098d8ac6d2 | Nicholas Feinberg | 2021-03-22 18:15:04 -0700 More Sastrei tiles Brighten up the yak and the balrug and add a new catoblep. -------------------------------------------------------------------------------- 53cd4ccad6 | Nicholas Feinberg | 2021-03-22 18:03:23 -0700 Remove Yred's nonliving ban It's neither an interesting gameplay twist nor a fun bit of flavour that Yredremnul bans nonliving players (i.e. gargoyles and djinn) from worship. Are you going to tell me that a 'Gargoyle Death Knight' is not cool? No, you aren't. Let the grdk soar once again! -------------------------------------------------------------------------------- c3fac4b18b | Nicholas Feinberg | 2021-03-22 17:47:19 -0700 New race: Djinni Djinn are intended to create a new and distinct 'caster' experience. Floating spirits formed from smokeless fire, they have no MP, instead casting spells using their HP. They also cannot learn spells from books; they instead get spells randomly and naturally, starting on XL 3 and continuing on every even level. The former mechanic is inspired by a design from kilobyte, who created another 'Djinni' species in 0.13. The latter comes from pubby, who created an 'Oni' race using it in various DCSS forks. I'm indebted to their ideas, though this implementation is somewhat different from both. Let's see if this new race does better than their predecessors! -------------------------------------------------------------------------------- 0520e8ecd4 | Nicholas Feinberg | 2021-03-22 17:47:19 -0700 Remove Halflings DCSS's philosophy on species is that they should provide meaningful choices and interesting, distinct play experiences. We originally had four types of elf, three types of dwarf, and gnomes, among others, but it really wasn't very interesting to try to win all of them, since they were fundamentally so similar to each other. Since then, we've moved towards species with much more distinct features than minor skill apt differences or dietary preferences, and the game has been better for it. Halflings had the following distinguishing features: - Small. (Couldn't use some weapons. Shared with kobolds.) - rMut. (Mostly irrelevant.) - Fantastic slings apt. (But slings are usable at 0 skill and take very little skill to reach mindelay, so how much did this really matter?) - Somewhat more 'fight-y' apts than Kobolds. (But other species do that better.) They weren't a *weak* species, they just weren't a very interesting one. Goodbye, Frodo... may you find happiness, off in that place where Gimli and Legolas went. -------------------------------------------------------------------------------- 3f424a255b | Edgar A. Bering IV | 2021-03-23 00:07:45 +0200 Give salamander tyrants bands -------------------------------------------------------------------------------- 02918e9f87 | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 New Monster: salamander tyrant (i-x) Salamander tyrants are meant to complement nagaraja as a top-tier threat in Snake, so that the latter don't have to do so much heavy lifting in end vaults etc. They're also meant to help depths lava salamanders have a bit more relevance. Snake has lots of melee bruisers, so the tyrant is a damaging spellcaster: flimsier but with some hard hitting spells it likes to cast a lot. The Tyrant is also fine with sitting back behind tougher Naga cousins: its spells don't require line of fire, only line of sight. Two spells play with terrain: Eruption fires the magma-themed upheaval flavour, hitting the player with partially-resistible BOM flavoured damage and creating temporary lava (constraining the player's movement). Pyroclastic Surge strikes foes of a tyrant that are above or adjacent to lava with pure fire damage. The third is a debuff weakening gaze, inflicting DUR_WEAK on the player. As a gaze attack it counts as instant and does not require line of fire, only line of sight. Combined with the terrain constraining attacks the gaze should make tyrants tough to fight in melee, but in a different way than the tankier Naga. -------------------------------------------------------------------------------- 4813a55755 | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Don't give new Naga Magi Haste Other (i-x) It takes away from the distinctiveness of salamander mystics. With the player under a hail of curare-spit and slowed that way, haste other was a bit overboard. -------------------------------------------------------------------------------- 6ecf17fd6c | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Turn Naga Mages into more supportive allies To give Naga better chances of catching a player, Naga Mages drop some of their attack spells (and teleport other) in exchange for haste other and a new spell: concentrate venom. Concentrate Venom enchants a target allied monster (either N or S type) and turns its poison spit or AF_POISON melee into curare. -------------------------------------------------------------------------------- 86023d4c85 | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Tweak Nagaraja spells Remove force lance (which gets the player away from Nagaraja's strong constrict) and replace teleport other with dimension anchor. Nagaraja are the top tier threat in snake and should be hard to escape, but being Naga even hasted most players can get away. -------------------------------------------------------------------------------- 8b94e06931 | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Give Naga Ritualists normal weapons (kate-) -------------------------------------------------------------------------------- db6eed0942 | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Make Naga Ritualists priests, remove force lance from their spellbook The priest change is mostly flavour, since they wrangle mana vipers it doesn't make sense that they'd be vulnerable to antimagic. Every spellcasting enemy except guardian serpents in snake has force lance, which works against getting snakes close to the player, so that's cut from their book. -------------------------------------------------------------------------------- e81c3644fc | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Give Naga Warriors battlecry Nagas are slow, so its easier for the player to avoid being hit by them. Battlecry will increase the consequences of being hit when Warriors are nearby. -------------------------------------------------------------------------------- 43b6169a3e | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Increase Naga and Naga Warrior damage Plain Naga are rather flimsy, don't hit that hard in terms of base dam, and have no fancy things to attack the player with. Naga Warriors are much tankier, but by the lair branches don't have a base dam appropriate to their designed threat level and tankiness, and also lack extra tools. Nagaraja base damage isn't tweaked, since they have spells and stronger constrict. -------------------------------------------------------------------------------- a7b8d12a86 | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Accelerate poison damage Poison damage afflicts the player with a known "damage debt" to be payed out over time. However, it ticks so slowly that the player can usually finish a poison fight and then rest before the poison becomes a serious tactical consideration. Accelerating poison will make it more relevant on shorter timescales; though the large number of curing potions spawned per game might also need to be trimmed. Specific number changes: Increase the speed cap to 5hp/aut, the speed minimum to 0.1hp/aut and the exponential speed from 1/15th of current poison per 10 aut to 1/5th of current poison per 10 aut. -------------------------------------------------------------------------------- e1682847c3 | Edgar A. Bering IV | 2021-03-22 23:58:59 +0200 Pull out some magic numbers in the poison formulas This will make tuning them easier. -------------------------------------------------------------------------------- 48170eeafe | Kate | 2021-03-22 21:44:09 +0000 Fix spelling -------------------------------------------------------------------------------- 265f56af43 | Kate | 2021-03-22 21:44:09 +0000 Remove a duplicated vault check -------------------------------------------------------------------------------- e0bb579ed7 | Kate | 2021-03-22 21:44:08 +0000 Remove antennae from Desolation of Salt humans -------------------------------------------------------------------------------- 780f848edf | advil | 2021-03-22 16:07:46 -0400 Mark manifold assault as a direct attack for autofight This allows CMD_AUTOFIGHT with autofight_throw=true to activate it when quivered, among other cases. -------------------------------------------------------------------------------- a0013940fb | Nicholas Feinberg | 2021-03-21 20:03:08 -0700 Lighten yaks up a bit (hellmonk) -------------------------------------------------------------------------------- c0f43fc05a | Nicholas Feinberg | 2021-03-21 19:53:54 -0700 Unleash a yak attack (Sastrei) New tiles that look less like sheep! Also death yaks. -------------------------------------------------------------------------------- ec79a4c0d2 | Nicholas Feinberg | 2021-03-21 19:48:31 -0700 Make oozes freeze (hellmonk) In the quest to make D:1 a bit more interesting without being enormously deadly or intimidatingly complex, give oozes a new gimmick: 1d7 Freeze at roughly 1/3rd cast freq. Halve their HP, reduce their base damage to 3, and place them in the D:1-3 range. Vaults are unchanged because old oozes didn't do anything anywhere, so there should be no issues with them being replaced by a monster that doesn't do anything after D:3. -------------------------------------------------------------------------------- 0b40708614 | Kate | 2021-03-22 01:31:47 +0000 Staticify some functions -------------------------------------------------------------------------------- c204baa176 | Kate | 2021-03-22 01:28:24 +0000 Fix display of stat rings on known items screen (particleface) -------------------------------------------------------------------------------- 26b8c838cb | Nicholas Feinberg | 2021-03-21 17:33:02 -0700 Unleash the python (hellmonk) Change ball pythons to only spawn in D:1-3 (instead of up to D:8!), and make them 4x as common in their range. Overall XP is unchanged from D:1-4. -------------------------------------------------------------------------------- fe1b84c61a | Nicholas Feinberg | 2021-03-21 17:26:14 -0700 Remove leopard geckos They were identical to quokkas, and the latter have a more entertaingly Australian flavour. https://www.pacificsciencecenter.org/wp-content/uploads/lydia-gecko-1920x1080.jp g -------------------------------------------------------------------------------- a572aaf4d4 | Nicholas Feinberg | 2021-03-21 17:01:04 -0700 Remove hobgoblin weapons, buff base damage (hellmonk) To differentiate them a little more from other early weapon users and also decrease the amount of early junk lying around. Beware the hob that does find a weapon, though! -------------------------------------------------------------------------------- 5910a5bdcb | Nicholas Feinberg | 2021-03-20 22:33:27 -0700 Remove early-game weaponless enemies Since the difference between enemies with weapons and those without is now so significant, stop spawning early-game enemies without weapons. This is a small player buff as well, since there's a greater chance of finding a venom dagger or such. -------------------------------------------------------------------------------- a52386242a | Nicholas Feinberg | 2021-03-20 22:32:32 -0700 Nerf early-game weapon user damage To compensate for the removal of 1d3 weapon damage reduction and also weapon delay removal, cut about 3 damage off many early game enemies. Also, split centaur damage into hit and kick, as a thematic way to nerf their ranged a little bit. -------------------------------------------------------------------------------- b4952372f7 | Nicholas Feinberg | 2021-03-20 22:13:04 -0700 Avoid a divide by zero -------------------------------------------------------------------------------- d01e12f17d | Nicholas Feinberg | 2021-03-20 17:49:47 -0700 Remove the rim of the moon (wheals) -------------------------------------------------------------------------------- fd0ee990f0 | Kate | 2021-03-21 00:45:17 +0000 Make Shatter deal bonus damage to toenails Toenail golems and rockslimes were on LRD's list of monsters that can be directly targeted, but not on Shatter's list of monsters that take bonus damage. Instead use the same list for both spells. -------------------------------------------------------------------------------- 01df23dd3f | Kate | 2021-03-21 00:45:17 +0000 Always consider ring pluses to be known Since they're always the same. Potentially they should no longer use item.plus at all to simplify the code, but currently some Sprint maps do still use redefined rings with different plus values (particularly for slaying in meatsprint). -------------------------------------------------------------------------------- 5d5f89c6df | Nicholas Feinberg | 2021-03-20 17:43:19 -0700 Update skill descriptions Many of these referenced mechanics and spells that have been gone for most of a decade. -------------------------------------------------------------------------------- f5bc2b81cb | Nicholas Feinberg | 2021-03-20 16:22:41 -0700 Show weapons on new Balrug tile ??oops -------------------------------------------------------------------------------- 830a91cb63 | Nicholas Feinberg | 2021-03-20 16:18:35 -0700 New Chei splash (Sastrei) -------------------------------------------------------------------------------- 0ad5b59bb0 | Nicholas Feinberg | 2021-03-20 16:18:21 -0700 New Balrug & Moon Troll tiles (Sastrei) -------------------------------------------------------------------------------- a58904a08d | Nicholas Feinberg | 2021-03-20 16:09:33 -0700 Mark Manifold Assault only temp useless Your currently wielded weapon is a temporary status, not a permanent condition, so it shouldn't prevent e.g. spell memorization. -------------------------------------------------------------------------------- aed091b46b | Nicholas Feinberg | 2021-03-19 19:40:43 -0700 Display Freeze damage in monster -------------------------------------------------------------------------------- d6162235be | Nicholas Feinberg | 2021-03-19 18:30:38 -0700 Remove rocksliem (RoGGa, 12540) -------------------------------------------------------------------------------- 359e429f13 | Edgar A. Bering IV | 2021-03-19 23:28:06 +0200 Describe curse boosts in chardumps (vt) -------------------------------------------------------------------------------- 86f87662fd | Nicholas Feinberg | 2021-03-19 08:32:58 -0700 New Geryon sprite (sastreii) -------------------------------------------------------------------------------- 7530f89582 | Edgar A. Bering IV | 2021-03-19 12:55:13 +0200 Fix ccache clang in CI? -------------------------------------------------------------------------------- 0c81a3c1c3 | Nicholas Feinberg | 2021-03-18 18:49:32 -0700 Swap Dr/Pa in NG (TheMeInTeam) Draconians are a somewhat fragile species with a wide set of different active abilities to learn (depending on which colour of draconian you become.) Palentongas are more durable (even after the nerf) and have a simpler playstyle to learn. Let's try this way out. -------------------------------------------------------------------------------- 3a15de6056 | Nicholas Feinberg | 2021-03-18 18:43:24 -0700 Pull back on Palentongas Think they got overtuned a bit during 0.26-a. Reduce their HP apt to the original +0. -------------------------------------------------------------------------------- 77a6b55cf3 | Kate | 2021-03-17 22:25:07 +0000 Update some item descriptions -------------------------------------------------------------------------------- d1c2c16caa | Kate | 2021-03-17 22:25:07 +0000 Don't allow targeting empty space with Poisonous Vapours Instead of letting it be aimed at empty space (but costing a turn and MP in case there's an invisible monster there), require a visible target for it to work. Also update some messaging and add a use of BASELINE_DELAY. -------------------------------------------------------------------------------- 8fc010af70 | Kate | 2021-03-17 22:25:07 +0000 Fix indentation -------------------------------------------------------------------------------- c1da3516c2 | Nicholas Feinberg | 2021-03-17 13:24:35 -0700 Make vampires mad (ShaperMC) -------------------------------------------------------------------------------- 6a6c47eaed | Nicholas Feinberg | 2021-03-17 08:44:07 -0700 Give hafi/kofi bucklers Since shield penalties are more meaningful now, and small races have higher penalties. -------------------------------------------------------------------------------- f18a54e897 | Nicholas Feinberg | 2021-03-17 07:41:07 -0700 Tune Ironbound Thunderhulk spellpower up slightly Player feedback suggested they weren't scary enough at range. This moves them from 3d18 to 3d21 damage, plus a lil accuracy bump. The buffs will continue until killcounts improve. -------------------------------------------------------------------------------- ea86b47111 | Nicholas Feinberg | 2021-03-17 07:19:13 -0700 New Green Death and Orange Demon tiles (Sastreii) -------------------------------------------------------------------------------- ac1c3f1d60 | Edgar Bering | 2021-03-17 04:14:57 -0400 Checkwhite -------------------------------------------------------------------------------- f435b565c8 | Nick Johnstone | 2021-03-17 09:21:24 +0200 Enable full screen PWA for WebTiles on iOS Currently, adding the webtiles interface to the desktop on iOS or iPadOS creates what is effectively a bookmark. It opens in the browser, with the domain displaying, and tabs available. By adding these meta tags, if a user creates a PWA for WebTiles on iOS, it will launch in full screen as a separate application to the browser, without the standard tabs interface. This should be a fairly low risk change, as users have to opt in to creating a PWA. The biggest issue is that this hides the browser navigation if you’re using a PWA, so you might theoretically be able to navigate to part of the site that you couldn’t easily return from. This might seem like an edge case, but it would be awesome to be able to play DCSS full screen on an iPad with a keyboard. -------------------------------------------------------------------------------- 0c9945aa31 | Edgar A. Bering IV | 2021-03-17 09:10:29 +0200 Elaborate on some clua documentation -------------------------------------------------------------------------------- 330a3fb6b6 | mgdelmonte | 2021-03-17 09:10:29 +0200 New clua function spells.describe Add the spells.describe function, which provides the same description one can find by accessing a particular spell in the memorised spells list. Useful for evaluating a spell's current damage, accuracy, and other attributes, within a script context. [ Committer's note: Rebased, reworded commit message. Closes #1813 ] -------------------------------------------------------------------------------- b5737ff2c0 | hellmonk | 2021-03-16 20:28:56 -0700 Allow quokkas on D:1. They're not that much different from leopard geckos. Slightly lowered their spawn rate overall - I think this is fine but it probably increases early exp a little bit. -------------------------------------------------------------------------------- 87fe7d4a8f | hellmonk | 2021-03-16 20:28:56 -0700 reduce item generation in early dungeon -------------------------------------------------------------------------------- 9dbe4339e4 | hellmonk | 2021-03-16 20:28:56 -0700 increase ball python melee damage by 1 -------------------------------------------------------------------------------- 69cf137300 | hellmonk | 2021-03-16 20:28:56 -0700 Adjust weapon subtype selection. Allow higher basetype weapons to spawn (with low probability) on early floors. Adjust their spawn rate downward overall to compensate. Note: I'm very unsure about the numbers on this, but a quick objstat seemed to indicate that it would be acceptable for D:1. Further adjustment may be required. -------------------------------------------------------------------------------- 0dccfbd8cf | hellmonk | 2021-03-16 20:28:56 -0700 Allow earlier book, manual, and staff generation. Removes a couple checks preventing books, staves, and manuals from generating on early floors. Many of these were replaced with scrolls or potions, so it's probably a nerf overall. -------------------------------------------------------------------------------- c2beb70d14 | hellmonk | 2021-03-16 20:28:56 -0700 Legalize early rare scrolls. This removes the depth_mod check for scrolls of acquirement, summoning, vuln, silence, brand weapon, torment, and holy word. Scroll weights for those scrolls were decreased slightly (except for vuln, which was increased) to compensate and to make the total scroll weight nicer. I could see dropping weight further if needed, and there is some concern about startscumming with ?acq. Coincidentally, this despoilers scroll id; there is no longer a reason to track the floor you found a scroll on. -------------------------------------------------------------------------------- f8ad8ab245 | hellmonk | 2021-03-16 20:28:56 -0700 Allow shop placement on D:1-3 Let the player see some exciting shop items earlier. This is not as much of a power buff as it seems, since the player won't have enough gold to buy things in most cases (though I could see banning consumable shops or raising prices, perhaps). Shop rate per floor of D is nerfed so that the total number of dungeon shops is slightly lower overall. -------------------------------------------------------------------------------- ca034ae587 | Kate | 2021-03-16 19:15:24 +0000 Fix a crash when trying to enslave a Mara clone -------------------------------------------------------------------------------- 90476cec82 | Kate | 2021-03-16 03:45:04 +0000 Give quicksilver oozes acid immunity As with the majority of high-level slimes. Rockslimes are left without it since they're primarily made from rock. -------------------------------------------------------------------------------- 31e422a34a | Kate | 2021-03-16 03:45:04 +0000 Fix grammar in horn of Geryon description -------------------------------------------------------------------------------- 0a03284674 | Nicholas Feinberg | 2021-03-15 20:37:38 -0700 Remove chilling breath from monster white draconians The knockback isn't particularly needed for their design. The implementation in mons-cast is a bit of a hack, alas... -------------------------------------------------------------------------------- 87aa48b03e | Nicholas Feinberg | 2021-03-15 20:25:06 -0700 s/Leech/Vampire's Tooth/ Too many vamp unrands! -------------------------------------------------------------------------------- b8a12bb016 | Nicholas Feinberg | 2021-03-15 20:23:36 -0700 Make Vaults wizards a bit uglier 2-4 ugly thing bands, instead of 1-3. A single ugly thing pal was just sad. -------------------------------------------------------------------------------- 7c350831d9 | Nicholas Feinberg | 2021-03-15 20:23:04 -0700 Gently nerf Leech to +5 Mega-Vamp is an extremely strong property, and with a high enchantment, Leech isn't just good, it's a bit absurd. Tone down its enchantment by 3 points, from +8 to +5. -------------------------------------------------------------------------------- 5244db0575 | Kate | 2021-03-16 02:05:45 +0000 Adjust some reanimation handling Fix messaging for animating skeleton-only monsters with the sword of Zonguldrok, and remove an obsolete autopickup check with Animate Skeleton. -------------------------------------------------------------------------------- f1ce4671d2 | Kate | 2021-03-16 02:05:45 +0000 Reword a monster description To be a little shorter, rather than duplicating the spell description. -------------------------------------------------------------------------------- 2d5cf1dcd3 | advil | 2021-03-15 11:06:05 -0400 Update an outdated file extension in Makefile -------------------------------------------------------------------------------- f7bc8fed1b | Nikolai Lavsky | 2021-03-15 07:25:10 -0700 Fix ?/m entry for rockslimes Because of a missing delimiter, `?/mrockslime` showed the river rat's description. -------------------------------------------------------------------------------- 8dd3ea4f36 | Nicholas Feinberg | 2021-03-14 21:43:00 -0700 Reduce convoker & preserver frequency It's a bit much. Switch out for various other monsters. Lower overall monster count to compensate for the increased XP. -------------------------------------------------------------------------------- 9c408523ab | Nicholas Feinberg | 2021-03-14 21:31:21 -0700 Give frosthearts sInv To balance out various new monsters added to Vaults without sInv, give a wizardy monster a little better vision. Improve their prescription. You know. -------------------------------------------------------------------------------- a011b72ad2 | Nicholas Feinberg | 2021-03-14 21:29:21 -0700 Animate creeping frost -------------------------------------------------------------------------------- 7c5cdd226b | Nicholas Feinberg | 2021-03-14 21:06:01 -0700 Ogreify thunderhulk weapons again Big monsters need big weapons. Rip and tear! -------------------------------------------------------------------------------- 8141940efc | Nicholas Feinberg | 2021-03-14 20:56:31 -0700 Nerf a few other slow weapon-wielding mons Numbers chosen arbitrarily and unscientifically. Closes #1827. -------------------------------------------------------------------------------- b80fe6c15e | hellmonk | 2021-03-14 20:50:04 -0700 Nerf ogre and Sigmund base damage. This partially compensates for the monster weapon damage changes. I'm hitting these guys since they are notorious early game monsters that always spawn with a high base damage, high delay weapon. Other monsters might need to be adjusted later; in particular, club hobgoblins, goblins, (halberd) gnolls, centaurs, and early 2h ogres are worth monitoring. Some later monsters like yaktaurs may also need compensatory damage changes, but with luck this level of player nerf will be acceptable without too much further adjustment. -------------------------------------------------------------------------------- d9c6a3bf67 | hellmonk | 2021-03-14 20:50:04 -0700 Don't decrease monster weapon damage by 1 + random2(3). -------------------------------------------------------------------------------- 09634a79bb | hellmonk | 2021-03-14 20:50:04 -0700 Fix a > 10 year old monster weapon damage bug. Monsters with positively enchanted weapons now roll slaying properly. -------------------------------------------------------------------------------- 581982f5c1 | hellmonk | 2021-03-14 20:50:04 -0700 Rework monster weapon delay. Previously, monsters had weapon delay equal to the average of their weapon base delay and 1.0. This was fairly esoteric knowledge; it wasn't displayed in xv, for example, and also didn't make a whole lot of sense. Even powerful, high hd monsters attacked much slower with a high delay weapon. Additionally, DCSS has a parameter (attack_energy) that adjusts monster attack speed and is displayed. This commit sets monster attack delay to 10 regardless of base weapon type. In the extreme cases, a monster with a quick blade will attack about 10% slower than before, and a monster with a scythe will attack 50% faster. Overall it's a pretty substantial damage buff for monsters with heavy weapons. Particular outliers can be adjusted later through attack_energy or changes to base damage. -------------------------------------------------------------------------------- aabfd21ae0 | Kate | 2021-03-15 01:12:19 +0000 Identify guaranteed ambrosia in bee special rooms -------------------------------------------------------------------------------- 2cd41d7273 | Kate | 2021-03-15 00:59:20 +0000 Consider corpses as useless items for Jiyva piety -------------------------------------------------------------------------------- 337aa9fb86 | Kate | 2021-03-15 00:52:45 +0000 Let Chilling Breath knock back non-fliers And make Wind Blast knockback the same against fliers and non-fliers, so that flight sources can eventually be made permanent without there being places that the player would want to keep toggling it off. -------------------------------------------------------------------------------- 70b080b6ed | Kate | 2021-03-14 21:34:01 +0000 Update a comment -------------------------------------------------------------------------------- 3a9f0a9c12 | Nicholas Feinberg | 2021-03-13 12:54:53 -0800 Flip thunderhulk tile lightning (lici) Try to avoid confusion with Haste status. -------------------------------------------------------------------------------- 56d34f704d | Nicholas Feinberg | 2021-03-13 08:15:08 -0800 Thunderhulks are ogre I just extremely enjoy the ogrish theme. Expect this to be reverted again soon! -------------------------------------------------------------------------------- 7536a348d8 | Nicholas Feinberg | 2021-03-13 07:13:53 -0800 Preemptively tune quicksilver oozes down Let's try em at somewhat lower HP and see what they do. -------------------------------------------------------------------------------- e79d73bdd1 | Nicholas Feinberg | 2021-03-13 07:10:58 -0800 Simplify -------------------------------------------------------------------------------- c6addc0a40 | Edgar A. Bering IV | 2021-03-13 08:19:38 +0200 Reduce Ash skill boost This was still a bit overtuned. Getting to 2 curses in a category got to the same skill boost as "fully bound" under old Ash; early on this could already get ahead of the power curve. In the long run, since the number of curses is uncapped, a player could potentially reach double the boost of old Ash in a particular curse category. Taking the time to craft focused curses is a strategic tradeoff, and players are enjoying it so I don't want to put a hard cap on the boost. -------------------------------------------------------------------------------- 6becf1495a | Edgar A. Bering IV | 2021-03-13 08:13:21 +0200 Text tweaks for beastmasters -------------------------------------------------------------------------------- 2d681adce0 | Nicholas Feinberg | 2021-03-12 21:29:03 -0800 Impart the importance of friendship Make sure beastmasters always come with company. (Ban unbanded vault beastmasters.) -------------------------------------------------------------------------------- df28dd9bf2 | Edgar A. Bering IV | 2021-03-12 21:27:57 -0800 New monster class flag: M_REQUIRE_BAND Some monsters really don't work well without their bands. This flag prevents vaults from placing a monster with this flag (even via 098 and friends) unless the placement calls for a band. -------------------------------------------------------------------------------- cffcca8328 | Nicholas Feinberg | 2021-03-12 21:14:10 -0800 Reduce Vaults spawns Compensate for the removal of chaff & the new monsters. Total XP is essentially unchanged. -------------------------------------------------------------------------------- 0b001bae98 | Nicholas Feinberg | 2021-03-12 21:14:05 -0800 Vaults monsters reworks! Unify ironheart and ironbrands into ironbounds, per request. Hopefully this won't cause too much confusion. Ironbound Frostheart: Spellcasting monsters with a new Creeping Frost spell, which deals cold damage to and flash-freezes all enemies adjacent to walls. They also have an AF_COLD touch attack. Overall, they're intended to be a mid-tier threat which plays with the terrain of Vaults (where there tend to be a lot of walls around!) and which fills a gap in rC-checking monsters there. Ironbound Thunderhulks: Playing around with new targeting constraints, this imposing Vaults foe tosses smite-targeted lightning at its foes. Just one catch - it can't hit the player if they get within 1-2 tiles of it! Seems like a fun way to play with the mobs and spaces of Vaults. Ironwhip Beastmaster Instead of having beasts spawn in the vaults on their own, let's add on a Vaults thematic strength: bigger fights with synergizing bands. The Ironwhip Beastmasters are the ones who have taken the late, rare Lair monsters to the Vaults. Beastmasters come with a "Goad Beasts" natural ability, which gives all beasts in LOS a bonus to energy equal to one EUT_MOVE. This is less pronounced than haste other or a torpor snail aura for basic combat; however they come with bands of trampling dire elephants or fire breathing lindwurms. Here the goad helps the monsters in the band manouver around one another to better get to the player. For trampling monsters this does have a different mechanical impact than a torpor snail aura: after a successful trample that moves the player the remaining goaded elephants have a better chance at getting a hit. Beastmasters also spawn with nets, because what's a good beast master without a net. Move ugly things to wizard bands in Vaults This is more for Lore than for mechanics. Having plain ugly things appear either with wizards in small bands or with very ugly things in larger bands combined with their description is a subtle storyline of "creation killing creator". -------------------------------------------------------------------------------- c5cd5cfaf1 | Nicholas Feinberg | 2021-03-12 21:09:31 -0800 Add dire elephant bands to Vaults Again recontextualizing a late, rare Lair monster and replacing the trampling dragons that have been removed from Vaults, dire elephants should hopefully be a fun threat. I'm very uncertain about where to categorize them in terms of threat tiers. -------------------------------------------------------------------------------- 08f024a8fe | Nicholas Feinberg | 2021-03-12 21:09:31 -0800 Add lindwurm bands to Vaults Replacing the fire dragons that have soared away from Vaults, lindwurms are a weaker threat that spawn in bands of 2-4. It'll be fun to see them in a different context from their rare appearances in Lair, and they should still be able to do some damage. -------------------------------------------------------------------------------- 29c3982eda | Nicholas Feinberg | 2021-03-12 21:09:31 -0800 Remove chaff orcs from Vaults Orc warlords deserve better friends :) A loyal circle of orc knights only! -------------------------------------------------------------------------------- 262705bbc8 | Nicholas Feinberg | 2021-03-12 21:09:31 -0800 Remove basic centaurs from Vaults Far too weak to be relevant. Centaur warriors only here! -------------------------------------------------------------------------------- 1fe5a257b9 | Nicholas Feinberg | 2021-03-12 21:09:31 -0800 Add peacekeepers to Vaults Peacekeepers (manticores that buff nearby golems' damage) are a fun monster that plays well with Vaults' themes. I don't believe sharing these from Desolation will dilute the latter's uniqueness too much, and it's neat to have a monster re-used in a somewhat different context. -------------------------------------------------------------------------------- 2c6b4450c0 | Nicholas Feinberg | 2021-03-12 21:09:31 -0800 First pass on new V:1-4 spawn tables Cut out chaff and monsters that heavily duplicate D/U/E. Focus on monsters that work well with Vaults' terrain: wide-open spaces with frequent door chokepoints, few corridors. (Great for big mobs and ranged enemies.) -------------------------------------------------------------------------------- 48f24ef436 | Nicholas Feinberg | 2021-03-12 21:09:31 -0800 WIP Vaults:5 re-layout Trying to approximate the status quo pretty closely. XP is slightly higher now, but less than a 2% increase. -------------------------------------------------------------------------------- 9a45c12a61 | Edgar A. Bering IV | 2021-03-12 21:09:09 -0800 Move desolation humans to 'a' For "ancients" since they're ancient cultists; this frees up some space on p for the new vaults monsters. They're still human genus and species -------------------------------------------------------------------------------- e6a60533fa | Nicholas Feinberg | 2021-03-12 19:10:08 -0800 More Donald lines -------------------------------------------------------------------------------- 52eb5d5579 | Nicholas Feinberg | 2021-03-12 19:10:08 -0800 Remove death oozes Death oozes are slimes that aren't a great threat almost anywhere they appeared. They're essentially a midpoint between necrophages and ghouls that's slightly faster than either, which isn't an extremely exciting or distinctive monster design. Their best feature, by far, is their sprite. Undead monsters now just get slimified into normal slimes. It's fine! Once you liquify something, it shouldn't really matter that much whether it was alive or dead when you started. -------------------------------------------------------------------------------- a8652a641c | Nicholas Feinberg | 2021-03-12 19:10:08 -0800 Add new slimes to J wrath -------------------------------------------------------------------------------- 049c24a4b6 | Nicholas Feinberg | 2021-03-12 19:10:08 -0800 Remove Eyes of Draining It's very hard for monsters that do nothing without friends to work well in DCSS. Eyes of Draining not only do nothing alone, they have a pretty hard time doing anything even with friends. It's rare that they manage to really 'get' a spellcaster. Ghost moths cover their 'drain magic' gimmick a bit better, and quicksilver oozes cover 'antimagic ooze' in reasonable fashion, so let's clean up some cruft. The Depths ophan added in this commit is pretty weird; possibly there's a better fit for that slot. -------------------------------------------------------------------------------- eda80042b2 | Nicholas Feinberg | 2021-03-12 19:09:57 -0800 Remove Death Oozes from Slime Just not that threatening or interesting there, sadly. Tentatively not removing them from the game, since they do work well in Gauntlet, but they might get axed from there a little later. Also remove them from TRJ's palset. -------------------------------------------------------------------------------- 2cf77163c2 | Nicholas Feinberg | 2021-03-12 19:09:57 -0800 Remove dead weights from Slime gen Overall monster & xp count is roughly similar. -------------------------------------------------------------------------------- d1418992ea | Nicholas Feinberg | 2021-03-12 19:09:57 -0800 Remove azure jelly rElec It has no obvious thematic basis and, with rockslimes' appearance, it seems unecessarily cruel for multiple Slime monsters to be rElec. (Trivia: the rElec on azure jelly is pre-Stone Soup.) -------------------------------------------------------------------------------- 433ef79eb3 | Nicholas Feinberg | 2021-03-12 19:09:57 -0800 New Slime monster: quicksilver ooze Quicksilver oozes are antimagic oozes. They move fast, hit for AF_ENGULF and AF_ANTIMAGIC, and are totally immune to magic. They're intended to be lower threat than azure jellies but higher than death oozes. -------------------------------------------------------------------------------- b0a88528cb | Nicholas Feinberg | 2021-03-12 19:09:57 -0800 New Slime monster: Rockslime Rockslimes are slimes that trample you, perhaps into the nearest slime wall. They have high AC, rF++ and rElec, since they're made of rock, and wallop for a hefty 50 per hit. They're intended to be on par with azure jellies and a bit lower-threat than acid blobs (they have lower HP than either), and to play with the Slime terrain in a fun way. -------------------------------------------------------------------------------- 81e9af5d04 | advil | 2021-03-12 18:28:15 -0500 unbrace -------------------------------------------------------------------------------- 867ec2bfdb | advil | 2021-03-12 18:14:28 -0500 Show form info on the `A` screen A lot of information about forms is the same kind of thing that would already be shown on the `A` screen (I could even imagine reimplementing a big chunk of this as actual mutations, there's already a fair bit of overlap). Some form-based / non-permanent (but non-tempmut) info was already shown here, including Mf/Vp form info, beastly appendage, and a few random religious properties. This commit generalizes this to always show key pieces of info for forms. I haven't tried to be exhaustive here; many things that are already shown in the `%` screen somehow don't get their own entry. This is implemented basically by extending the fakemut concept to forms; there's a mix of programmatically-generated fakemuts and custom ones. As noted above, for at least some of these properties it might be worth considering how to generalize the beastly appendage approach. -------------------------------------------------------------------------------- 2d96b4cbf3 | advil | 2021-03-12 18:14:28 -0500 Refactor mutation listing Previously this was handled in two separate but parallel places: a function in output.cc used for the `%` screen, and a more developed version in mutation.cc that produces the long list for `A` (with a more interpretable order that doesn't just go by the mutation enum). This commit unifies the two by merging in the short-form listing to the existing code in mutation.cc, leading to more consistency across the two displays and less likelihood of them getting out of sync. The order of display for `A` is now used for `%`. I have further tweaked the order to consistently show temporary effects first, and made a few other small changes mainly to terse mutation description special cases. -------------------------------------------------------------------------------- 1ad3dbde53 | gammafunk | 2021-03-12 12:58:09 -0600 Some tweaks to a vault Adjust the threats and "elven" equipment to more appropriately scale with depth of placement. Check for depth in Dungeon, upgrading things for post D:13. Remove the conditional "the elves died" theme that previously happen in any branch. I'm afraid the theme won't be well communicated with just random monsters and some elven skeletons around. The placement in Crypt covers a similar theme, with the elves becoming spectral, and the vault poses a substantial threat in that branch. In the case of Crypt, also add the elven gear as loot underneath the respective spectral elves and fix up the dead trees. Also add transparent, no_trap_gen, and no_monster_gen tags to this vault. Closes #1811. -------------------------------------------------------------------------------- 0ea1dd9b86 | kippig | 2021-03-12 12:55:28 -0600 Add an elvish explorers vault This vault adds an elvish couple exploring the dungeon with their mounts and their pet dog. Sometimes they have starved to death since they can't find enough rat to skewer. In crypt they have succumbed and been raised. Commiter's Note: Clean up commit message and squashed commits. -------------------------------------------------------------------------------- 702cc3688f | Nicholas Feinberg | 2021-03-12 08:32:46 -0800 Refactor mon generation die size Dataify it! (Some argument for making this an enum instead, as with branch noise?) -------------------------------------------------------------------------------- 29a88b33a7 | Neil Moore | 2021-03-11 15:58:07 -0500 Don't consider shafts untraversable for connectivity Stepping on shaft traps hasn't been a thing for quite some time. -------------------------------------------------------------------------------- 95abfb2b7d | advil | 2021-03-11 15:04:26 -0500 Refactor mertails as a mutation Once again I wasn't sure how worth the effort this would end up being and it turned out to be cleaner to use a mutation: standard form suppression handling can be used in various cases that were special-cased. This commit doesn't mess too much with you.fishtail calculation itself though. This commit also fixes emergency_untransform, which was broken for aquatic species. -------------------------------------------------------------------------------- b7d4903799 | advil | 2021-03-11 11:55:49 -0500 Mark nimble swimmer as inactive for merfolk on land This is entirely cosmetic, as the mutation doesn't do anything when not in water, but makes the `A` display more consistent with the merfolk form change. (Op still show this mutation always.) -------------------------------------------------------------------------------- 73614ed2d8 | advil | 2021-03-11 11:40:36 -0500 A few minor SP_NAGA cleanups -------------------------------------------------------------------------------- 8d3ced5a34 | advil | 2021-03-11 10:02:34 -0500 Remove a food reference -------------------------------------------------------------------------------- 164d68d9e5 | advil | 2021-03-11 09:41:48 -0500 Dataify bonelessness, barding-wearing These are implemented as species flags. SPF_BARDING is actually coextensive with SPF_SMALL_TORSO, not sure if that's an accident? -------------------------------------------------------------------------------- 48756fc93d | advil | 2021-03-11 09:22:36 -0500 Remove SPF_ELVEN, SPF_ORCISH These each uniquely identify a species. Also, convert the species generation script to take species flags directly; this extra layer of indirection just makes it harder to do changes like this. -------------------------------------------------------------------------------- 524d869a0f | advil | 2021-03-10 21:47:11 -0500 Refactor vampirism as a mutation This commit is part of a series that attempts to more cleanly treat species as bundles of traits/behaviors that have their own well-defined semantics, and minimize the use of explicit species checks in the code. This commit refactors vampirism into a two-level mutation; level 1 gives the base set of vampiric abilities that were previously conditioned on species checks, and level 2 gives batform as well. I wasn't sure if this would be worth the effort, but I think in the end it's a much cleaner design than before. There's a few small related cleanups here, including to mutation display and to item annotations. One thing of note is that I marked torment as a good_item when you are torment immune, which may be initially confusing to people, because the only thing that previously got this color is acquirement and they don't exactly form a natural class. (Emergency items are colored yellow, which preempts good_item.) -------------------------------------------------------------------------------- 70eae99092 | advil | 2021-03-10 21:47:10 -0500 Clean up some vampire checks * In some cases is_lifeless_uundead is more appropriate than a direct vampire check. (Minor change: berserkitis will now be suppressed in lichform.) * Formatting * Clean up a json field for the vampire info screen * Comments re the confusing treatment of `temp` for vampires -------------------------------------------------------------------------------- 6a3fe64ed6 | advil | 2021-03-10 21:47:10 -0500 Generalize a ghoul check -------------------------------------------------------------------------------- 2aaa8dbbc2 | kippig | 2021-03-10 17:25:09 +0200 This vault was designed when spiders could cling to walls, updated it so the monsters at the back are more than pincushions -------------------------------------------------------------------------------- 27d45072b4 | Skrybe | 2021-03-10 16:33:43 +0200 Update trove.des Fix a couple of typos on my part. -------------------------------------------------------------------------------- 0306a34022 | Edgar A. Bering IV | 2021-03-10 08:48:01 +0200 Clarify acrobat description Be explicit that stairs don't count as moving. Closes #1816 -------------------------------------------------------------------------------- b9b556f605 | Edgar A. Bering IV | 2021-03-10 08:44:54 +0200 Add transparency/opacity information to poisonous_passages Closes #1818 -------------------------------------------------------------------------------- 94244163b4 | Nicholas Feinberg | 2021-03-09 20:05:48 -0800 Simplify Airstrike damage Remove the effects of empty surrounding spaces on variance. The effects on mean/max damage are unchanged. -------------------------------------------------------------------------------- a811992cb3 | Nicholas Feinberg | 2021-03-09 17:10:29 -0800 Make stealth ego work on any slot Also make it work while flying, heh. Closes #1815. -------------------------------------------------------------------------------- f99593c837 | advil | 2021-03-09 19:23:17 -0500 Swap L/R ring in % display order efe1b44 accidentally changed which finger the first ring goes on. This is actually good, because it resolves 11879 -- the first ring and the sacrifice hand are drawn from a consistent order where they are always different. However, now the order in % with only one ring looks odd. This prints the right ring first. (Sorry lefties..) -------------------------------------------------------------------------------- 3569856083 | advil | 2021-03-09 19:18:52 -0500 Condition a physiology check on bonelessness rather than species This is a minorly substantive change: it prevents formicid from getting thin skeletal structure. (Presumably the mut itself could be reflavored if anyone is bothered by this, it's sort of a weird special case anyways.) -------------------------------------------------------------------------------- 7488d4e55c | advil | 2021-03-09 19:15:00 -0500 Convert octopode tentacles to a real mutation These were a mess of special cases and custom form checks, so it's cleaner to have these as a real mutation. There's a minor loss of info in the % screen as "constrict 8" is replaced by just "tentacles", but this custom status could be readded if it's too missed. This leaves only the Op armour gimmick (restrictions + mantle) as hard-coded for this species. -------------------------------------------------------------------------------- 945025970d | advil | 2021-03-09 16:47:40 -0500 More hand name cleanup This cleans up two issues: * Some @crawlcode-worthy code to get "fist(s)" in some cases for statue form. This gets moved back into core hand name code, similar to how blade hands are done. * Going back on an immediately preceding commit, change again how plurality is handled for octopodes. It turns out that (per the manual) two tentacles are roughly equivalent to one hand, so even "one-handed" attacks with blade hands/statue form up still notionally involve multiple tentacles. -------------------------------------------------------------------------------- 3bd3a8edd8 | advil | 2021-03-09 16:00:22 -0500 Remove some direct conditioning on missing hand For cosmetic cases, use arm_count() instead. This has different behavior for octopodes with sac hand than the direct check, so still don't use it e.g. for form unarmed weapon labeling. Otherwise, MUT_MISSING_HAND is mainly now checked directly only for weapon handedness and shield cases. -------------------------------------------------------------------------------- efe1b44157 | advil | 2021-03-09 15:32:13 -0500 Refactor some eq slot checks This abstracts hard-coded species-based eq slot checks (that don't involve a mutation) to species.cc, and generally tries to clean up various handling of ring/arm counts. There was a lot of special casing around MUT_MISSING_HAND, custom octopus code, etc., that should at least be better now. -------------------------------------------------------------------------------- 4fbd9c9eec | Edgar A. Bering IV | 2021-03-09 10:25:43 +0200 Don't skip inventory items with Ashenzari pack-id Closes #1739 -------------------------------------------------------------------------------- 3872a02503 | Edgar A. Bering IV | 2021-03-09 10:25:43 +0200 Remove the holy word effect from Sanctuary Zin's Sanctuary did two things: 1. blast holy word and 2. create a sanctuary with strict non-agression conduct (even for evil things). Which mean that beyond flavour, the player couldn't take advantage of 1, and in any case this was never mentioned in the description in-game. Sanctuary is a defensive ability, so instead of also doing damage (that if non-lethal can't be followed up on sensibly) just create the sanctuary. As an added benefit, Closes #1703 -------------------------------------------------------------------------------- a093fd074c | Edgar A. Bering IV | 2021-03-09 10:25:43 +0200 Really don't print a resist message when the player casts fridge Closes #1814 -------------------------------------------------------------------------------- 6b246bc234 | Implojin | 2021-03-09 09:33:12 +0200 Document a clua TODO -------------------------------------------------------------------------------- ffa14badcf | Implojin | 2021-03-09 09:33:12 +0200 Replace a magic number in spl-cast.cc -------------------------------------------------------------------------------- e2a43ba0c9 | Edgar A. Bering IV | 2021-03-08 23:36:11 +0200 Adjust some Xom dialog Xom hasn't produced hostile dancing weapons in a very long time now. Closes #1731 -------------------------------------------------------------------------------- e9d3877a2d | Edgar A. Bering IV | 2021-03-08 23:23:39 +0200 Don't aim battlespheres at firewood Closes #1759 -------------------------------------------------------------------------------- 55242dfd9f | Edgar A. Bering IV | 2021-03-08 23:23:39 +0200 Don't leak invisible monster locations with Ignition Closes #1798 -------------------------------------------------------------------------------- ae615a3c3a | Edgar A. Bering IV | 2021-03-08 23:23:39 +0200 Don't prompt for Fedhas protected plants when using IMB Closes #1801 -------------------------------------------------------------------------------- bcb41fda2d | Kate | 2021-03-08 20:23:51 +0000 Adjust some duration short/wizmode names -------------------------------------------------------------------------------- 911d1a7525 | Kate | 2021-03-08 20:23:51 +0000 Add a debug message -------------------------------------------------------------------------------- a35e2b3484 | Kate | 2021-03-08 20:23:29 +0000 Further simplify the Elixir Merge the durations of HP and MP regen so that they expire together. -------------------------------------------------------------------------------- c41e867b77 | Kate | 2021-03-08 19:03:25 +0000 Give black draconians increased breath power in dragon form Other draconian breath weapons already get a breath power boost, and the spell description also claimed that this applied for black draconians too. -------------------------------------------------------------------------------- 328d1db4bd | Implojin | 2021-03-08 19:40:11 +0200 Fix shop purchase potion/scroll stacking This was broken in 83025b5. It turns out that items_stack() has some fairly particular conditions that don't necessarily match ISFLAG_IDENT_MASK, due to a potential lua info leak. For some background on this, see: crawl-dev-20151123.lg If this commit somehow breaks identify again, I apologize in advance. -------------------------------------------------------------------------------- 6f54807a0a | sdynet | 2021-03-08 19:25:44 +0200 Simplify the Elixir Grant both ELIXIR_HEALTH and ELIXIR_MAGIC at each tier, with duration scaling with power_level; no longer heal allies. [ Committer's notes: Closes #1751. Tweaked formulas. Updated card description. Removed ally heal. Edited commit message. ] -------------------------------------------------------------------------------- 36c66b7062 | Edgar A. Bering IV | 2021-03-08 18:47:51 +0200 Clarify Recite's description Recite scales with both piety and Invocations skill, so we should say so in the description. [ Closes #1711. ] -------------------------------------------------------------------------------- dab5b5aff9 | Implojin | 2021-03-08 18:48:07 +0200 Fix a wizmode shop placement crash At present, trying to place a gadget shop or a food shop will cause the game to crash. This commit adds a missing TAG_MAJOR_VERSION == 34 for gadget shops, and adds a guard against placing either gadget or food shops. -------------------------------------------------------------------------------- 089230926e | Nicholas Feinberg | 2021-03-08 08:44:10 -0800 Grant players a bounty of information Explicitly spell out each of Ash's passives. I tested on 80x24 - there's loads of space. Also clear up what exactly a 'cursed item' is and what it does, since that's an Ash-only thing now. -------------------------------------------------------------------------------- 711278a2bf | Nicholas Feinberg | 2021-03-08 08:44:10 -0800 Mark Lear's Hauberk useless for palentongas (Beargit) This was only being cheked with !ignore_temporary set, meaning that players weren't able to wear it (good!) but still showed it marked useful (bad!). -------------------------------------------------------------------------------- 2535176e0c | kippig | 2021-03-08 09:25:36 +0200 New kiku swamp vault Also correct some comments in swamp.des [ Committer's note: Closes #1781. Tweaked some glyphs, dropped some branch guests from the zombie list. Squashed and rebased. ] -------------------------------------------------------------------------------- 0d39f094a4 | gammafunk | 2021-03-07 22:57:41 -0600 Some Swamp decor vaults by nicolae (12518) Changes made by me are mainly to remove DEPTH: Swamp, which isn't necessary due to that being default depth, and to clean up spacing for multiline SHUFFLE. -------------------------------------------------------------------------------- 16b4af076a | gammafunk | 2021-03-07 22:45:25 -0600 Reindent and reglyph some Swamp vaults Reglyph to use undefined glyphs instead of T. -------------------------------------------------------------------------------- 6bc07cd232 | gammafunk | 2021-03-07 22:45:25 -0600 Add some sections to swamp.des -------------------------------------------------------------------------------- 7185523a23 | Kate | 2021-03-08 04:42:17 +0000 Fix fail_severity options The max value was set too low for both, since fail_severity now goes up to 5 for potentially lethal spells. -------------------------------------------------------------------------------- f249a0bc35 | Kate | 2021-03-08 03:33:41 +0000 Update monster for AF_ACID damage Since it was changed just recently in 2553e725d5b8. -------------------------------------------------------------------------------- 132d4964b8 | Kate | 2021-03-08 03:17:54 +0000 Update a default option -------------------------------------------------------------------------------- d03afb0eaa | Kate | 2021-03-08 01:03:00 +0000 Fix typo in a mutation desc -------------------------------------------------------------------------------- 25d98068a6 | Kate | 2021-03-07 23:07:42 +0000 Randomise the duration of scrolls of vulnerability Instead of fixing it at 400 aut for all targets. -------------------------------------------------------------------------------- 6c39d01e8d | Kate | 2021-03-07 23:05:09 +0000 Improve a Zot trap effect Don't allow applying 0 turns of -WL, and change the messaging to match other sources of temporary -WL. -------------------------------------------------------------------------------- e0ab5a2769 | Kate | 2021-03-07 17:41:31 +0000 Adjust some god conduct wording for consistency -------------------------------------------------------------------------------- 843053f431 | MinticePIU | 2021-03-07 18:44:08 +0200 god-conduct.cc trog line doesn't appreciate that you’re training magic -------------------------------------------------------------------------------- 98a349ffca | RojjaCebolla | 2021-03-07 18:43:19 +0200 Remove one of your -------------------------------------------------------------------------------- e92ec0ca06 | Neil Moore | 2021-03-06 22:49:22 -0500 Add a new Jiyva message. Death to Videodrome! -------------------------------------------------------------------------------- 79e8bcd247 | Nicholas Feinberg | 2021-03-06 18:32:57 -0800 Bump Psyche's Willpower Give her a better chance of accomplishing something at the depths she spawns. Her killratio is a piddling 1.3% in recent versions - do better, Psyche! -------------------------------------------------------------------------------- ea54bc4844 | Nicholas Feinberg | 2021-03-06 17:52:57 -0800 Ban quaffing known useless !cancel To save players less familiar with the long and somewhat arbitrary list of which effects are cancellable / not from completely wasting their time. (They can still cancel useful effects while not hitting useless ones, but...) -------------------------------------------------------------------------------- 113d0485ee | Nicholas Feinberg | 2021-03-06 17:45:18 -0800 Don't mark cancel useless Too confusing in the inventory UI. -------------------------------------------------------------------------------- 7bfaeff07b | gammafunk | 2021-03-06 19:26:24 -0600 Some overflow altar vaults by nicolae (12500) Edits on my part are mostly to reindent, simplify syntax, and to remove no_monster_gen and no_item_gen tags when possible. -------------------------------------------------------------------------------- 5ccdf786d2 | gammafunk | 2021-03-06 19:25:44 -0600 Reindent some vaults -------------------------------------------------------------------------------- 0983b4dd01 | gammafunk | 2021-03-06 19:25:28 -0600 Adjust ghost vault allow_dup tagging Previously we marked all ghost vaults as allow_dup, which meant they could all place multiple times. This was mostly a relic of when there were fewer ghost vaults and we didn't want games to be stuck without a ghost vault available. Now we have a wide variety of ghost vaults, including a reasonable set with both wide placement and generic enough theme that we can designate with allow_dup to prevent ghost vault shortages. This commit removes allow_dup as a default ghost vault tag, explicitly giving it to a small number of ghost vaults instead. -------------------------------------------------------------------------------- d81048afd2 | Edgar A. Bering IV | 2021-03-06 19:09:30 +0200 Remove an outdated bribe (dinky) -------------------------------------------------------------------------------- bbbe490cb5 | Nicholas Feinberg | 2021-03-06 09:12:09 -0800 Fix lucy bribe (dilly) It's 2021. Quick blades are on the menu! -------------------------------------------------------------------------------- 8b806e2825 | hellmonk | 2021-03-06 11:52:38 +0200 Allow Chei followers to use quickblades. This was a very silly thematic restriction that eliminated a potentially interesting character choice. The weapon of speed restriction is pretty silly too, but those are at least supposed to be magically fast or something; quickblades are just a weapon type with low attack delay. Chei does not care about the player reducing their attack delay by gaining weapon skill, nor does Chei care about the player taking quick actions like removing a ring or unwielding a weapon, so there is no reason to ban a weapon type merely because it has low delay. -------------------------------------------------------------------------------- de416216be | Edgar A. Bering IV | 2021-03-06 10:54:11 +0200 Dereference the correct pointer -------------------------------------------------------------------------------- 1a53e8493b | Edgar A. Bering IV | 2021-03-06 10:43:05 +0200 Don't shatter nonexistant curses (12534) -------------------------------------------------------------------------------- 15ff5c5295 | Nicholas Feinberg | 2021-03-05 18:14:19 -0800 Quiet husks down Even after raising Swamp ambient noise, they're still very loud. Add a slightly hacky special case for em. -------------------------------------------------------------------------------- 817a5d48fc | Nicholas Feinberg | 2021-03-05 17:53:59 -0800 Make Swamp loud The recent compression of Swamp, along with the addition of noisy bunyips and bloated husks, has meant that fights tend to end up drawing in the entire level at once. That's fun sometimes, but it probably doesn't need to happen all the time. To compensate, increase Swamp's ambient noise. This reduces the distance that noise travels, meaning noise from melee attacks, spells, and the aforementioned noisy enemies won't travel as far. Neither bunyips nor bloated husks were *intended* to call the entire level in on the player. Husks are mostly intended to be a tricky-to-detonate bomb, and bunyips' cry was intended to dilute their actions by making them spend less time rushing towards and pummeling you. So, this should move them closer to their original design purpose. -------------------------------------------------------------------------------- 4bdaa1e8ba | Nicholas Feinberg | 2021-03-05 17:52:58 -0800 Remove a shopless bazaar (beargit) I think that all of these old minmay `? = any shop / T` bazaars should be using NSUBST instead, but I'm too rusty to do the conversion properly. -------------------------------------------------------------------------------- 7eaf864cf9 | advil | 2021-03-05 13:35:29 -0500 Partially revert "Remove some miasma save compat" This commit was too aggressive; restore part of the Vs save compat it removed. This partially reverts commit 1d33414dbe85f26d31a52569107cbe4ec1205d62. -------------------------------------------------------------------------------- 117a7a4151 | advil | 2021-03-05 13:26:56 -0500 Clean up rTorment muts a bit This converts MUT_TORMENT_RESISTANCE to a two-level mutation. Level 1 is 50% damage reduction, previously hard-coded to gargoyles. The Gr fakemut becomes this. Level 2 is previous level 1, and so mummies/ghouls move to level 2. MUT_STOCHASTIC_TORMENT_RESISTANCE independently exists as a somewhat weird and unusual resistance mechanism that on balance seems to me to be a bit worse than just simple level 1 as it now exists, though it allows for getting lucky. I'll leave it alone for now though. -------------------------------------------------------------------------------- 1d33414dbe | advil | 2021-03-05 13:26:56 -0500 Remove some miasma save compat I'm pretty sure all this is unnecessary, and generic removed-mut code should clean up this mutation where it still exists. -------------------------------------------------------------------------------- cc1c95e81f | advil | 2021-03-05 13:26:56 -0500 Clean up miasma immunity * Remove the redundant and now inert (after 7c3aafa790) MUT_MIASMA_IMMUNITY from gargoyles and from the game. * Simplify the way unbreathing interacts with rMiasma, by just moving it straight into that code. (This doesn't affect gargoyles, because they are also non-living, but may affect grey draconians.) The fact that gargoyles are non-living isn't really cued anywhere, but the unbreathing part is shown in `A`, and since this now absolutely entails rMiasma also, it's probably ok to not directly show that effect in `A`. The wording of non-breathing could be tweaked if its cloud immunities aren't clear enough. (It's possible there's not even a need for non-living as such to prevent miasma now?) -------------------------------------------------------------------------------- b72ec1a1b6 | Nikolai Lavsky | 2021-03-04 19:24:15 +0200 Add spell damage info to the `I!` menu and morgues A third of player spells have damage info, but this information is well hidden. This commit adds a quick way to compare spells and to see all the numbers at once. -------------------------------------------------------------------------------- c2e2f7f19a | Nicholas Feinberg | 2021-03-04 09:03:39 -0800 Remove forxfire -------------------------------------------------------------------------------- 46cce82728 | Edgar A. Bering IV | 2021-03-04 18:57:16 +0200 Abort foxfire if it would obviously have no effect (AdamPG) Check if there's a visibly open space and abort the spell if there isn't one. This check happens before spell failure; if foxfire fizzles after this check it reveals an invisible foe, which the player should be charged for. Detected invisible foes currently don't count which is an edge case in a variety of ways in crawl, but a fix out of scope for this small tweak. Closes #1790 -------------------------------------------------------------------------------- 159f12dd07 | Aliscans | 2021-03-04 18:10:57 +0200 Stop explore from reporting a level as explored if there is an object on an excluded square. _explore_find_target_square() now rejects the first pathfind() call if it returns a "hostile" target. check_square_greed() no longer does anything similar. The latter change reverses e99fe26798. This means that an item in/behind an excluded area triggers a "partly explored" message. If an item/space is behind a runed door, explore continues to target it. -------------------------------------------------------------------------------- da5465ab1e | Aliscans | 2021-03-04 18:10:57 +0200 Allow excluded squares in _is_travelsafe_square() if ignore_hostile is set. This means that explore reports the search as being incomplete if an excluded area blocks off the only access to the explore_horizon. -------------------------------------------------------------------------------- 5993a9cae7 | Aliscans | 2021-03-04 18:10:57 +0200 Make _is_reseedable(c, false) return false for walls and trees which are in an exclusion. This stops the game from incorrectly assessing a level as not being completely explored when an excluded area reaches a wall which has an unexplored square beyond. -------------------------------------------------------------------------------- 16523e7f5b | hellmonk | 2021-03-04 17:58:29 +0200 Nerf the dex meta Feedback has made it clear that it's a bit too easy to reach high levels of ev. This commit reduces the dodging*dex factor by 20%. High levels of dex and dodging should remain rewarding, but a little less so, and will be worse until the player gets there. To compensate the very early game, the flat portion of dodge_bonus increases slightly. [ Closes #1784. Committer's note: squashed and rebased. ] -------------------------------------------------------------------------------- 7e0ef7a368 | Skrybe | 2021-03-04 17:12:33 +0200 New Trog-themed weapon trove New trove: an abandoned arena once used by reveling Trog worshipers. Loot is similar to other weapon troves, but some Trog acquirements (lower chance of rare base types, but higher enchantment and increased chance for antimagic) are mixed in with the standard acquirements. The results are distinct from other weapon troves while still providing some solid loot. I took 5 weight from both trove_weapon_1 and 2, to keep the overall weight of weapon-only troves the same. Also noticed that trove_weapons_four_rooms was missing the skill-based veto chance other weapon troves have, which I assumed was an oversight, so I added that as well. -------------------------------------------------------------------------------- 88e10a6b4d | Skrybe | 2021-03-04 17:12:33 +0200 Edit skrybe_vaults_entry_preservation Tweak a Vaults entry of mine to use either stone or metal walls, instead of always metal. Also remove an unused monster definition. -------------------------------------------------------------------------------- 46bbb28828 | advil | 2021-03-03 20:16:20 -0500 Refactor some swimming fakemuts * Standardize printing of an amphibious fakemut based on habitat (each of Ba, Op, and Mf took a different strategy for this). * Add a two-level mutation MUT_NIMBLE_SWIMMER. Level 1 is stealth only (Op), and level 2 is stealth + Mf EV/movespeed bonuses. (This packs a lot into level 2, but I think this design is a bit cleaner than having a distinct mutation for EV/movespeed.) I've removed some fishtail checks here, in way that I'm *pretty* sure is safe. -------------------------------------------------------------------------------- 61e7d874a1 | Neil Moore | 2021-03-03 18:30:31 -0500 Don't make the -Potion light always darkgrey (Yermak) If the inability to drink is temporary, it's because of this duration, so keep the light red in that case. -------------------------------------------------------------------------------- b83adbd1c9 | Edgar A. Bering IV | 2021-03-03 19:43:51 +0200 Add a monster info bit for susceptibility to vampirism Closes #1725 -------------------------------------------------------------------------------- 10c448b48d | Ebonnov | 2021-03-03 19:43:51 +0200 Targeter describes if monster is susceptible to Vampiric Draining Now that susceptibility is determined by rN, the targeter can sanely distinguish if vampiric draining would do nothing to the target or vampiric draining would gain no HP from the target. -------------------------------------------------------------------------------- c0d12b3c5c | Ebonnov | 2021-03-03 19:43:51 +0200 Remove selfench flag from Vampiric Draining This allows the range display to work automatically. _ms_ranged_spell() gains a special case, if monsters gain many more range-1 spells this function will need to check spell range. [ Committer's note: reworded message. ] -------------------------------------------------------------------------------- d5a6684c90 | Ebonnov | 2021-03-03 19:38:43 +0200 Make Vampiric Draining a zap and a beam Creates a zap and an enchantment beam flavor (mimicking Malign Offering among other damage-dealing enchantment beams) for Vampiric Draining, replacing existing separate implementation of player version and monster version. Coming from the technical conversion are the following gameplay changes: - monster version can now deal more damage than caster's missing HP (i.e. getting player version treatment of 4e331d2). - damage formula changed from 2d5+1d(pow/7) to 2d(6+pow/14), with similar expectation and max, and increased chance to roll close to bottom and top ends. And as an immediate gain: - monster version shows damage. - quiver is now enabled only when visible non-susceptible target is in range. One wart: - casting on non-susceptible target no longer aborts the spell. This means that casting with autofight (shift-tab/p) can now fizzle (outside living rN+++ monsters). This is consistent with the behavior for hexes and pain; a solution to this issue would be a wide-reaching improvement to crawl. [ Committer's note: Reworded commit message. Didn't include all of the submitted gameplay changes; the beam only works on vampirism susceptible targets. This specific vulnerability gets revealed to monster_info in a later commit. ] -------------------------------------------------------------------------------- 4ea69e3b24 | advil | 2021-03-03 10:37:40 -0500 Mark steam resistance as suppressed by forms This is for consistency with other draconian types; the breath ability is already suppressed as well. -------------------------------------------------------------------------------- bac44d21f1 | advil | 2021-03-03 10:37:12 -0500 Reduce explicit species checks: gnoll All that was needed for this is to convert distributed training from a fakemut to a real mutation. This was fairly straightforward overall. `_player_is_gnoll` from e00f04a389b562 becomes a direct mutation check; it looks like this helper function was added to make the code overall more readable/systematic (probably to avoid bugs when modifying this code) so I think checking a mutation in a systematic way accomplishes this goal as well. -------------------------------------------------------------------------------- fb3425029c | Edgar A. Bering IV | 2021-03-03 16:05:29 +0200 Mark a vault as transparent -------------------------------------------------------------------------------- 46ec449faf | Aliscans | 2021-03-03 09:17:08 +0200 Don't make a note when the player finds an altar for a god the character can't worship. Add a "temp" parameter to player_can_join_god() and player::undead_or_demonic(). If false, the functions ignore temporary effects from mutations and spells, and only consider permanent barriers such as the player's species and Ru sacrifices. Use this to stop the game from making a note on finding an altar for a god the character will never be able to worship. -------------------------------------------------------------------------------- 57cc695410 | Nicholas Feinberg | 2021-03-02 21:36:03 -0800 Reword Forlorn mut I couldn't resist, sorry. -------------------------------------------------------------------------------- c95325c382 | Nicholas Feinberg | 2021-03-02 21:23:51 -0800 Improve manifold/unrand messaging (dilly) Be clearer about why you can't manifold with singsword right now. -------------------------------------------------------------------------------- 0df57e7cfc | Nicholas Feinberg | 2021-03-02 18:52:03 -0800 Give Wyrmbane a glow up (Wensley) Print a message when a dragon with high enough HD to give Wyrmbane an upgrade comes into view. (This is a semi-despoiler of HD mechanics.) -------------------------------------------------------------------------------- 818f26b0ed | advil | 2021-03-02 20:05:27 -0500 Fix behavior of `species_mutation_level` I had misunderstood how level gains were represented when I first wrote this; fix it to use the total mutation level at an xl rather than the change at an xl. -------------------------------------------------------------------------------- 3920f8e293 | advil | 2021-03-02 19:58:40 -0500 Reduce explicit species checks: naga * MUT_CONSTRICTING_TAIL becomes two level, where the first level is mainly cosmetic and prevents boots. The old boot fakemut is no longer needed. * Some tweaks to how walking verbs are used; Naga is standardized on "slither" (this was hard-coded in one place, but the yaml used "slid"). This will change some lugonu titles. This commit also slightly generalizes species fixup code to handle multiple levels of a mutation. There's some flavor code that I didn't figure out a good way to generalize. -------------------------------------------------------------------------------- 96d86173be | advil | 2021-03-02 19:58:28 -0500 Remove an extraneous function -------------------------------------------------------------------------------- 2188dfaaa0 | advil | 2021-03-02 16:52:43 -0500 Fully unremove forlorn -------------------------------------------------------------------------------- 84b802d940 | advil | 2021-03-02 15:29:46 -0500 Reduce explicit species checks: demigod This commit is part of a series that attempts to more cleanly treat species as bundles of traits/behaviors that have their own well-defined semantics, and minimize the use of explicit species checks in the code. * Repurpose old MUT_FORLORN to indicate Dg's atheist conduct. (I'm not sure if the short-form "forlorn" flavor quite works?) * Abstract/generalize the stat gain stuff into species.cc a bit. I'm sort of torn about whether it makes sense to even bother doing this except for the principle of the thing. I did decide this was good to add to the ability screen, but it's implemented as a programmatic fakemut based on the stat gain multiplier rather than a realmut. -------------------------------------------------------------------------------- 658772aece | advil | 2021-03-02 12:00:13 -0500 Actually add MUT_MULTILIVED to felid ... tested save compat but not actually making a new character... -------------------------------------------------------------------------------- 39af0f7025 | advil | 2021-03-02 11:56:17 -0500 Reduce explicit species checks: felid part 3 This is the change for felids I'm least sure of (in the sense of, is it worth being principled to this degree): convert the hard-coded life-gaining ability to a species mutation. This does get some minor UI gains in that the ability shows up in the mutation list now. -------------------------------------------------------------------------------- 9f681435c2 | advil | 2021-03-02 11:56:17 -0500 Reduce explicit species checks: felid part 2 This commit covers many things: * no weapons/ammo is converted from a fakemut to MUT_NO_GRASPING. * no armour is converted from a fakemut to MUT_NO_ARMOUR (the Ru sac mut is renamed). For these two changes I alternatively considered lumping them into one mutation, or lumping both of them into MUT_PAWS. However, it seemed cleanest / most readable to keep them distinct, even though these three mutations don't ever appear separately. Also: * Refactor skin flavor some more, add code to get the noun forms, add felid to this. I also tweaked a few flavor messages around this. * A few more misc paw-related tweaks that I had missed. * Refactor species scream verbs; these get moved into species.cc with a few tweaks. (e.g. add growling to gnoll directed 0-level shouts.) -------------------------------------------------------------------------------- e23dd17498 | advil | 2021-03-02 09:15:33 -0500 Fix sac drink preconditions Flipped in 9b28f76f3da3. -------------------------------------------------------------------------------- fc1ad161a1 | advil | 2021-03-02 09:15:33 -0500 Reduce explicit species checks: felid part 1 Refactor some remaining paw-related issues (60a0ea410 addressed some of these already). Mainly: Consolidate MUT_PAWS with the stealth fakemut, and finish conditioning various felid stealth-related checks on this mutation instead of the species. This lightly reflavors MUT_PAWS to mention both stealth and pouncing, and leaves the sharp claw stuff to the co-existing MUT_CLAWS. The fakemut is gone altogether, and some form interactions are more standardized, so the mutation screen will more accurately display with the stealth bonus is suppressed. -------------------------------------------------------------------------------- d4c891490c | Edgar Bering | 2021-03-02 07:40:59 -0500 Changelog through 0.27-a0-498 -------------------------------------------------------------------------------- 7ecbb0a48f | hellmonk | 2021-03-01 20:08:35 -0800 Make *slow stack in the same way as *corrode. Instead of being slightly different for no reason. Closes #1785. -------------------------------------------------------------------------------- 5f1ef305e6 | Aliscans | 2021-03-01 19:54:17 -0800 Rename local variables in spectral_weapon_fineff::fire(). The following compiler warning was given by gcc 10.2.0. Renaming def removes the warning. I also renamed atk, but only for consistency. fineff.cc: In member function ?virtual void spectral_weapon_fineff::fire()?: fineff.cc:721:12: warning: declaration of ?def? shadows a member of ?spectral_weapon_fineff? [-Wshadow] 721 | actor *def = defender(); | ^~~ In file included from fineff.cc:9: fineff.h:30:16: note: shadowed declaration is here 30 | mid_t att, def; Closes #1792. -------------------------------------------------------------------------------- 18f1c7c63f | Nicholas Feinberg | 2021-03-01 19:31:16 -0800 Don't make monster refrig affect the caster Symmetry with the player version. -------------------------------------------------------------------------------- 905266d83c | Nikolai Lavsky | 2021-03-01 18:54:45 -0800 Describe Ozocubu's Refrigeration and Drain Life in monster The spells weren't handled by ``mons_spell_beam()``, so the monster utility wasn't showing their damage. Unlike monster, xv can already show the damage for these spells, since it gets the numbers in a different way. (Committer's note: moved this into the nicer struct.) -------------------------------------------------------------------------------- e178da98d6 | Nicholas Feinberg | 2021-03-01 18:44:21 -0800 Cancellation descr improvements (12531, Yermak) - Don't print empty statuses - Don't print (expiring) - Further clarify when it'll have no effect -------------------------------------------------------------------------------- 85c0b4d56b | Kate | 2021-03-02 02:23:34 +0000 Fix a vault randart Randart armour isn't supposed to be given egos, and doing so can generate buggy items (like boots with double rampaging in this case). -------------------------------------------------------------------------------- a4bb394fd4 | Edgar A. Bering IV | 2021-03-01 22:12:40 +0200 Allow Ash boosts to adjust max hp, mp and spell levels Ashenzari boosts are long-lived and intended to be functionally equivalent to having the extra skill levels. Heroism still does not give a boost to maxhp, partly because it seems like a technical headache because of how heroism is implemented. -------------------------------------------------------------------------------- 2427743e6d | Edgar A. Bering IV | 2021-03-01 22:12:40 +0200 Don't grant curse skill boosts for melded equipment (PleasingFungus) Since the curse boost is an equipment property and the rest of those are suppressed by transmutation, let's be consistent and withdraw transformed bonuses. So players can see what has happened this is reflected in the ^ screen. -------------------------------------------------------------------------------- 656fa3bc60 | advil | 2021-03-01 11:43:49 -0500 Reduce explicit species checks: draconian This commit is part of a series that attempts to more cleanly treat species as bundles of traits/behaviors that have their own well-defined semantics, and minimize the use of explicit species checks in the code. Red draconians: fix up a manual zap conversion. Pale draconians: convert steam resistance to a real mut (before it wasn't shown at all, perhaps because it seems not-very-important?) Grey draconians: * There's still a hard-coded ac bonus in player::racial_ac, wasn't obvious to me that there is a clean way to abstract this one. * Their relationship to water was very confused; I have (maybe) cleaned this up a bit. Previously, they had MUT_UNBREATHING, a fakemut about walking through water, can_swim=True, and a hard-coded check in player::extra_balanced. The latter, I'm pretty sure, is currently redundant with swimming (it probably wasn't in the past). I have consolidated these by making MUT_UNBREATHING two levels, where the second level is flavored like the old fakemut. The fakemut is gone, they aren't specified as swimming (though the mut is still checked in swimming code), and extra_balanced has been refactored, including some unrelated cleanups. -------------------------------------------------------------------------------- 24c7b1a3ef | Edgar A. Bering IV | 2021-03-01 08:05:44 +0200 Nerf new Ashenzari skill boost Making it easier to get multiple of the same curse and also doubling the boost formula was effective in making it more powerful. Too powerful. Two curses of the same type still give a multiplier equal to the "fully bound" level of old Ashenzari, so hopefully this lands on a good power level. -------------------------------------------------------------------------------- 88baaf19db | Nicholas Feinberg | 2021-02-28 21:12:16 -0800 Preview !cancel in its description List the effects that will be removed. -------------------------------------------------------------------------------- fad94b14d9 | Nicholas Feinberg | 2021-02-28 21:01:22 -0800 Make duration data short text consistent If my next commit is going to work, all of these have to be in adjective form, not just some! -------------------------------------------------------------------------------- ed9a95061b | Nicholas Feinberg | 2021-02-28 20:23:11 -0800 Mark !cancel useless when appropriate (If neither contaminated nor buffed.) -------------------------------------------------------------------------------- 83795c0764 | Nicholas Feinberg | 2021-02-28 19:40:44 -0800 Deduplicate animals Now that our favourite +8 unrand rings have been renamed. -------------------------------------------------------------------------------- 5fc3b572a5 | Kate | 2021-03-01 02:41:27 +0000 Prevent entering pre-existing piety troves under Ashenzari In the weird edge case where you find a piety trove and then convert to Ashenzari, don't allow entry at all, since reducing piety is tied to shattering cursed items (and causes buggy behaviour if reduced normally). -------------------------------------------------------------------------------- 7290ec1f24 | Nicholas Feinberg | 2021-02-28 17:31:16 -0800 Reduce Ash join spam Don't ID things you've already ID'd! -------------------------------------------------------------------------------- 278a1cfa91 | Nicholas Feinberg | 2021-02-28 17:23:13 -0800 Ban piety troves under New Ash They don't work properly (your piety resets once you reload or curse another item) and it's not very clear what making them work properly would even mean. -------------------------------------------------------------------------------- e66e4f1fd0 | Nicholas Feinberg | 2021-02-28 17:10:44 -0800 Simplify spellforged servitor energy (hellmonk) De-randomize them: instead of taking 10-25 energy to cast a spell, take 18 consistently. This appears on their xv, which is nice. Further context: - 3595075b7f7 - f37f6fb1095 -------------------------------------------------------------------------------- 190982bc61 | advil | 2021-02-28 20:04:06 -0500 Reduce explicit species checks: palentonga This commit is part of a series that attempts to more cleanly treat species as bundles of traits/behaviors that have their own well-defined semantics, and minimize the use of explicit species checks in the code. Only minor things here: * condition MUT_ROLL upgrades on having the mutation innately * refactor/simplify some tail code (no changes to behavior) * move the barding code to species.cc, perhaps for later dataification -------------------------------------------------------------------------------- 11248dd59e | Nicholas Feinberg | 2021-02-28 16:11:00 -0800 Don't trigger spectral weapon on all attacks (particleface) (oops) -------------------------------------------------------------------------------- c496030317 | advil | 2021-02-28 19:00:44 -0500 Reduce explicit species checks: minotaur This commit is part of a series that attempts to more cleanly treat species as bundles of traits/behaviors that have their own well-defined semantics, and minimize the use of explicit species checks in the code. Minotaurs were in reasonable shape, only two tweaks: * Convert retaliatory headbutt to a real mutation. This allows removing some custom mutation suppression code. * Tweak some hints mode tips to talk about horns, rather than species. (Also, one hopefully cosmetic fix for the mutation data structure..) -------------------------------------------------------------------------------- b294f25f7b | Nicholas Feinberg | 2021-02-28 15:44:08 -0800 Trigger spectral weapon on all attacks Including misses & blocked attacks. This should bring it closer to the design goals/tradeoffs described in e6bb7ee78e63. -------------------------------------------------------------------------------- 757c4c4f7f | Nicholas Feinberg | 2021-02-28 15:34:08 -0800 Drop Depths monsters count again XP down 4% from 0.26, which seems a-ok. Goal is to make overall difficulty closer to what it was before the removal of chaff. -------------------------------------------------------------------------------- 4587593e40 | Edgar A. Bering IV | 2021-02-28 21:28:33 +0200 Don't allow shattering melded items (12528) -------------------------------------------------------------------------------- 60b1cd0c92 | Edgar A. Bering IV | 2021-02-28 21:28:33 +0200 Don't offer Ash monks the second curse too fast Give them a chance to apply the first curse, and just set the progress timer to most of the way to the second curse so it will appear quickly. Closes #1782 -------------------------------------------------------------------------------- 585d864186 | advil | 2021-02-28 14:18:04 -0500 Reduce explicit species checks: vinestalker Vinstalkers are in good shape, this is the only obvious change I found. -------------------------------------------------------------------------------- 9b28f76f3d | advil | 2021-02-28 14:18:04 -0500 Reduce explicit species checks: mummy This commit is part of a series that attempts to more cleanly treat species as bundles of traits/behaviors that have their own well-defined semantics, and minimize the use of explicit species checks in the code. For mummies: * convert a hardcoded adjustment to rF + fakemut to use MUT_HEAT_VULNERABILITY. I can't find any reason this wasn't done in the past except that it was very old code. There is a minor flavor difference in the wording of the mutation. * add a real mutation for non-drinking. I also did a bunch of cleanup and refactoring of the drinklessness checks (you_drinklessness -> you.can_drink). * for some flavor stuff, use the skin adjective string added in a previous commit. Not sure if this is ultimately the best way, but it seems to me to still be an improvement in that this flavor logic is better consolidated. * clean up player::can_bleed; should have no behavior changes. * Generalize player::can_smell (which is for flavor only): no lifeless undead can smell after this commit. -------------------------------------------------------------------------------- fef436477a | advil | 2021-02-28 14:15:52 -0500 Rename (internally) two Ru mutations No user-facing changes, but the mut names were somewhat misleading. -------------------------------------------------------------------------------- 07dbac4f64 | advil | 2021-02-28 14:15:52 -0500 Reduce explicit species checks: tengu This commit is part of a series that attempts to more cleanly treat species as bundles of traits/behaviors that have their own well-defined semantics, and minimize the use of explicit species checks in the code. Tengu are easy. A previous commit cleaned up some superficial code, and this one uses the tengu flight mutation for a bunch of cases rather than checking the species directly. -------------------------------------------------------------------------------- 009b781653 | advil | 2021-02-28 14:15:52 -0500 Convert hands to fists for UC forms name Separating this bit out because it is kind of hacky... -------------------------------------------------------------------------------- 60a0ea410a | advil | 2021-02-28 14:15:52 -0500 Consolidate and clean up some body part name code This tries to reduce a bunch of code duplication while making some body part name cases more consistent, and also reduce reliance on species-specific checks. Biggest changes to blade hands code, which is/was fairly involved, but hopefully all changes are improvements. The commit removes the general blade hands name ("scythe-like blade") that was used in various cases, awkwardly, and uses a clean version of the regular hand name. For ice form, we use "Ice paws" (instead of "Ice fists") in the UI -- the form data already used "paws" as the hand name (for e.g. ring wearing), so this improves consistency. For statue form, I used the regular hand name instead of "fists"; maybe this should still be customized for the "hand" case (but it reduces duplication of similar code). This stuff was all complex enough that there may well be corner cases that this commit breaks... -------------------------------------------------------------------------------- b314f132a3 | advil | 2021-02-28 14:15:52 -0500 Reduce explicit species checks: formicid This commit is part of a series that attempts to more cleanly treat species as bundles of traits/behaviors that have their own well-defined semantics, and minimize the use of explicit species checks in the code. For formicids: * use you.stasis() instead of a species check. This might be even better converted from a fakemut to a realmut, but since this call already existed (for actor even) I repurposed it. If anyone ever adds back in non-perma-stasis, that would be a good time to turn this into a mut. * Lump formicid dig in with monster burrowing (since they have the same behavior) and add an actor call. Again, for players this could be turned into a realmut eventually, similar to the monster bit. This ties player self-shaft in with this check too. * Convert four-handedness from a fakemut to a real mutation (MUT_QUADRUMANOUS). * Use innate_sinv() instead of species checks; this may change some semantics for physiology conflicts (but probably in a good way). * For cosmetic reasons add a minor species check for bonelessness (Op and Fo). -------------------------------------------------------------------------------- 171c57d503 | Edgar A. Bering IV | 2021-02-28 20:47:19 +0200 More Ash randnames (nicolae) -------------------------------------------------------------------------------- f192cf5699 | Kate | 2021-02-28 18:01:19 +0000 Reword some Ashenzari curse names -------------------------------------------------------------------------------- f1db142f3a | Kate | 2021-02-28 17:46:43 +0000 Assign Ashenzari abilities to uppercase letters As with Ru sacrifices. They could also potentially just be assigned to 'a' and 'b' like other god invocations, but either way shouldn't use the current assignments of 'f' and 'g' which are for non-invocation abilities. -------------------------------------------------------------------------------- ec7707c53d | Neil Moore | 2021-02-28 01:27:53 -0500 Staticalise a function -------------------------------------------------------------------------------- 2bdad01aa9 | Neil Moore | 2021-02-28 01:25:53 -0500 Refactor into set_artefact_brand() -------------------------------------------------------------------------------- 2a051d674a | Neil Moore | 2021-02-28 01:09:14 -0500 Preserve brands when Ash-cursing items (#12527) -------------------------------------------------------------------------------- 297a19dbdb | Nicholas Feinberg | 2021-02-27 18:15:50 -0800 New Nemelex skill titles (hellmonk) Very cute. -------------------------------------------------------------------------------- 0891b3a2b8 | Nicholas Feinberg | 2021-02-27 17:20:54 -0800 Finish removing Depths chaff As the prelude to Vaults changes, remove some weak monsters present in both Depths and Vaults. Reduce total Depths spawns by roughly 8% to compensate. Total XP remains unchanged. The first part of this commit was inadvertently included in fdd91fc31 . -------------------------------------------------------------------------------- fdd91fc31c | Nicholas Feinberg | 2021-02-27 17:01:21 -0800 Temporarily tweak Tengu Reaver's spells Lightning Spire doesn't quite work yet as a monster spell. I like the idea of it, but don't currently have the time to fix it up. Instead, give reavers a pile of elemental bolt spells to really simulate the classic cj experience. Total spell weight equal to the old MST_TENGU_REAVER_III. -------------------------------------------------------------------------------- ba82baf56e | Edgar A. Bering IV | 2021-02-27 19:39:17 +0200 Fix a crash -------------------------------------------------------------------------------- 8b5a972acc | Edgar A. Bering IV | 2021-02-27 18:42:53 +0200 More Ashenzari artefact names (nicolae) -------------------------------------------------------------------------------- 6169cafb0b | Edgar A. Bering IV | 2021-02-27 18:19:34 +0200 Increase the skill boost contribution of piety Even after consolidating curses into bins, getting three curses of the same type is rare (less than 8% of 10-curse rolls will have any triple at all; less than 1% of 10-curse rolls will have a chosen triple). Over the longer run, if the player is willing to make gear sacrifices or wait for more curse re-rolls these odds can be increased, of course, but at a cost. New skill boosts scale with the number of curses, so it's hard to get the multiplier up to the range of old skill boosts without luck. This commit increases the contribution from piety, which should both make foregoing curses more noticable and the impact of adding "irrelevant" curses. -------------------------------------------------------------------------------- b9714ae4ff | Edgar A. Bering IV | 2021-02-27 17:17:57 +0200 Reforge the Chains VII: Grouped skill bonuses After initial playtesting feedback, completely random skills had some interesting upsides (when the stars aligned and a triply-cursed skill could also be utlized it was a good moment) they were also frustrating and had bad gamefeel: - multiple melee skills when a player is probably only using one (maybe two) - hard to roll relevant magic skills - occasionally taking a "useless" or "not that useful" curse was fun but it was happening too often. This commit changes the skill bonuses to be granted in the following skill groupings, more fine grained than the old ash skill categories but not as broad as totally random skilling: Melee: all melee combat skills Ranged: all ranged combat skills Fortitude: Armour and Shields Cunning: Dodging and Stealth Elements: Air, Earth, Fire, and Ice Magic Alchemy: Transmutations and Poison Magic Beguiling: Conjurations, Hexes, and Translocations Companions: Necromancy and Summonings Self: Fighting and Spellcasting Evocations: Evocations. Each curse offers two out of these ten categories chosen at random and without weight. This will hopefully allieviate some of the bad feelings from totally random skill boosts while retaining the character shaping aspects of the narrower bonus granting. In lieu of save compatibility, since this has only been live on trunk briefly, this commit just switches to a new prop key for the new curses. -------------------------------------------------------------------------------- f5a408906c | Edgar A. Bering IV | 2021-02-27 16:52:52 +0200 Remove a now-unused enum type -------------------------------------------------------------------------------- 9f69345686 | Edgar A. Bering IV | 2021-02-27 11:46:48 +0200 Change weapon abbreviations to match aptitudes.txt -------------------------------------------------------------------------------- c9da168cd4 | Edgar A. Bering IV | 2021-02-27 11:11:24 +0200 Always reset curse progress when shattering Otherwise, the player is incentivized to shatter "just before" the curse timer times out, which means tracking the timer, to minimize the time spent at lower piety. -------------------------------------------------------------------------------- e8ee47db1e | Edgar A. Bering IV | 2021-02-27 11:03:24 +0200 Tweak some Ash god power messaging -------------------------------------------------------------------------------- 68ea36cf6f | Edgar A. Bering IV | 2021-02-27 11:03:07 +0200 Increase curse frequency in various ways This decreases the curse delay from 50 to 20, making curses more plentiful. The curse delay was copied from Ru, but Ru sacrifices offer far more benefit than a single curse. The delay was also re-set upon accepting a curse, this behavior was somewhat opaque; curses now come at the same rate regardless of whether they're accepted or ignored. This commit also arranges for monks to be offered two curses shortly after joining, instead of one. -------------------------------------------------------------------------------- ace5c5693b | Edgar A. Bering IV | 2021-02-27 02:01:24 +0200 Don't offer to shatter the chains uncursed (12524) -------------------------------------------------------------------------------- 443c4d33a9 | Edgar A. Bering IV | 2021-02-27 01:51:14 +0200 Tweak Ash curse randart names (nicolae) -------------------------------------------------------------------------------- 889b946b96 | Edgar A. Bering IV | 2021-02-27 01:50:09 +0200 Fix save compatibility props initialization -------------------------------------------------------------------------------- be96e517c0 | Edgar A. Bering IV | 2021-02-26 23:03:48 +0200 Fix a db lookup regression (PleasingFungus) -------------------------------------------------------------------------------- 40f7080bd1 | Goratrix | 2021-02-26 22:59:20 +0200 Add the AK splash screen to webtiles File was added with 7ddf969 but needs to be added here to appear in webtiles. -------------------------------------------------------------------------------- 85b7f54256 | AdamPG | 2021-02-26 22:58:03 +0200 Fix a typo in geoelf_rooms.lua -------------------------------------------------------------------------------- e386880645 | Nikolai Lavsky | 2021-02-26 22:57:02 +0200 Refactor a conditional in `spell_uselessness_reason` Also, fix a colour tag in `_player_spell_desc`. -------------------------------------------------------------------------------- ed6ad04f2f | Nikolai Lavsky | 2021-02-26 22:57:02 +0200 Don't waste time casting Sublimation of Blood when at max MP After 4502bb1e, the player can cast Sublimation when at max MP. The description still has the "This spell would have no effect right now" warning, and the spell is correctly greyed out on the quiver in this situation, though. Fix this by moving Sublimation's MP check into a function that is called before subtracting the MP cost. This adds a spell-specific check to casting-specific ones, but it's good to have all MP-related checks in one place. Also, it's clearer than temporarily refunding the spell cost, as it was before 4502bb1e. -------------------------------------------------------------------------------- 4d387a3930 | Edgar A. Bering IV | 2021-02-26 22:40:52 +0200 Tweak Ashenzari piety gain Ensure all species get to 1* piety with at most two curses. Save poor little octopus. -------------------------------------------------------------------------------- cc4f045668 | Edgar A. Bering IV | 2021-02-26 22:18:31 +0200 Activate Ash skill boost from 0* (mdonais) The skill boost requires curses to take advantage of; at 0* and only one curse the skill point multiplier is 4. Compared to 24 for one curse at 6* this isn't that noticable. In exchange, the play experience is clearer: all of the messages about curses being tied to skills don't have to have caveats, and a Monk actually gets something immeidate out of using their first curse. -------------------------------------------------------------------------------- 904f624fcb | Edgar A. Bering IV | 2021-02-26 22:17:41 +0200 Mark ?id useless for ash followers (mdonais) -------------------------------------------------------------------------------- edbb297545 | Edgar A. Bering IV | 2021-02-26 22:10:09 +0200 Default force_more for curse offering (mdonais) -------------------------------------------------------------------------------- d758f4ad8f | Edgar A. Bering IV | 2021-02-26 22:01:16 +0200 Describe curse exploration (mdonais) -------------------------------------------------------------------------------- ba0159d6e4 | Nicholas Feinberg | 2021-02-26 08:24:22 -0800 Fix unused variable warning -------------------------------------------------------------------------------- 1c28abb116 | Edgar A. Bering IV | 2021-02-26 17:30:49 +0200 Canonical skill abbreviations for display Currently used for Ru and Ashenzari ability menu display, and Ash curse inscriptions. -------------------------------------------------------------------------------- fcfbbb0451 | Edgar A. Bering IV | 2021-02-26 17:30:49 +0200 Create a new vision_iterator (PleasingFungus) A handful of places in the code performed a radius_iterator iteration over LOS_NONE and then immediately filtered for you.see_cell to respect scrying and wizard xray vision effects. This iterator encapsulates the idiom of iterating over an actor's vision (permitting actor::see_cell to override the considerations of LOS checks). -------------------------------------------------------------------------------- cf6be6ae82 | Edgar A. Bering IV | 2021-02-26 17:29:57 +0200 Reforge the Chains VI: Randartify cursed items To make the curses more permanent, cursed items are made into randarts if possible, locking in their brand and enchantment. No randart props are granted (other than the skill boosts!). Randart names are generated from a special Ashenzari keyword in the database for a thematic name. Thanks to CanOfWorms,hatsuma, Lici_the_Crawler, nicolae, and PleasingFungus for curse name suggestions. -------------------------------------------------------------------------------- 6c61df32c5 | Edgar A. Bering IV | 2021-02-26 17:25:03 +0200 Code cleanup of old curse code -------------------------------------------------------------------------------- b19e37cef9 | Edgar A. Bering IV | 2021-02-26 17:25:03 +0200 Save compatibility for new Ashenzari -------------------------------------------------------------------------------- 6fc834afe4 | Edgar A. Bering IV | 2021-02-26 17:25:03 +0200 Reforge the Chains V: Bind skill knowledge to curses This commit reimagines Ashenzari curses to offer specific knowledge (in exchange for binding the slot). Currently Ash picks two skills and the player can either take the curse and the knowledge, or ignore it. Ash will eventually offer a new curse. This choice can hit the player in a variety of ways: are the skills offered too good to pass up, thus ending up on an otherwise not great item for a long time? Are the skills not ones the player anticipates using but they're desparate for piety so they'll put a not great curse on a great item? Both are good, and occasionally the player will delight in getting the opportunity to put a good curse on a good item they want to keep! With the variety of curses, it remains possible for an Ash character to be a jack of all trades, but also to become highly focused in something that might otherwise be hard for their species! Exciting possibilities abound, that will need some further number tuning. -------------------------------------------------------------------------------- 0b9efa778e | Edgar A. Bering IV | 2021-02-26 17:25:02 +0200 Remove an XXX; startup.cc handles the issue in question -------------------------------------------------------------------------------- da19f9da44 | Edgar A. Bering IV | 2021-02-26 17:24:45 +0200 Reforge the Chains IV: Shatter the Chains To go with the new curse scheme, uncursing becomes available to any cursed Ash worshipper. Uncursing removes and destroys the item (triggering all on remove effects, no secret disto unwield tech). It also forgoes the currently offered curse and re-sets the curse timer (to make sure uncursing is felt). -------------------------------------------------------------------------------- c9f47ef48c | Edgar A. Bering IV | 2021-02-26 17:22:30 +0200 Reforge the Chains III: Curse piety Tying Ashenzari's curses to scrolls was always a bit awkward. With the removal of other curses and the rc scroll this mechanic is untenable. Since Ash's introduction Crawl gained another god: Ru, who periodically offers something which grants piety through an alternate mechanism. As part of an overhaul of Ashenzari, this commit changes Ash piety to scale directly with bondage level: it takes two curses for a Human to reach 1*, and they arrive at 6* when all slots are bound. The exact formula scales with slots, so Felids have a much easier time reaching 6*; the formula is: piety = 2 + ( num_cursed * 160 ) / num_slots This applies to current slots, so if a slot is lost due to mutations the player isn't penalized. Coupled with this: Ashenzari no longer applies curses in exchange for items. Instead, players are occasionally invited to curse an item. Accepting a curse re-starts the curse timer; ignoring it simly lets it sit there. -------------------------------------------------------------------------------- bff98f8d11 | Edgar A. Bering IV | 2021-02-26 17:21:54 +0200 Reforge the Chains II: Adjust Ash passives Grant Ashenzari's passives earlier, with skill boost arriving at 1*, see invisible at 2*, and clarity at 3*. Starting at 4*, also grant perma-scrying with a radius of 2, the radius grows with piety stars until reaching radius 4 at 6*. -------------------------------------------------------------------------------- 0aebcb437f | Edgar A. Bering IV | 2021-02-26 17:21:53 +0200 Reforge the Chains I: Remove old Ash actives Remove Scrying and Skill Transfer, the new Ash will only have passive effects. -------------------------------------------------------------------------------- f312af23e9 | Nicholas Feinberg | 2021-02-25 22:23:13 -0800 Tweak spell descriptions (ShaperMC) Increase clarity, decrease poetry. -------------------------------------------------------------------------------- 642ebbb733 | Nicholas Feinberg | 2021-02-25 22:09:54 -0800 Simplify Make prefer_ranged do something other than 'prefer shooting to attacking with reach weapons' if it's not on a monster with the 'archer' flag. At present, it always *is* on monsters with the archer flag, so this commit does nothing, but it seems like nice future proofing. -------------------------------------------------------------------------------- 7ddf969dea | Nicholas Feinberg | 2021-02-25 17:46:40 -0800 New AK splash screen from E.M. Fields The artist (https://mobile.twitter.com/EMFields_Art) has agreed to license the art under CC0. Many thanks to him for the fantastic piece! The original can be seen here: https://lexiconmegatherium.tumblr.com/image/126515730356 -------------------------------------------------------------------------------- 83025b51d3 | Implojin | 2021-02-25 17:12:23 -0800 Fix equipment identification bb19ded didn't properly identify items that were already in the player's inventory. This commit restores equip identify behavior, to fix this and handle any unforeseen cases of items being placed directly into the player's inventory. Closes #1777. -------------------------------------------------------------------------------- 7a85846853 | Nicholas Feinberg | 2021-02-25 09:23:53 -0800 Fix @player_only@ messages (#9201) When printing monster spell messages, we never checked to see if we they were valid. As a result, unseen ghost moths casting Draining Gaze on other monsters would print the literal string "You feel something watching you. @player_only@". This bug was introduced in e143a0ad5d2 (October 2014) and first reported by johlstei a month later. I managed to reproduce it in March 2015 but was unable to figure out the root cause, because the monster speech code is absolutely insane. But this is it! -------------------------------------------------------------------------------- 5110eb77c4 | Nicholas Feinberg | 2021-02-25 08:34:55 -0800 Fix ID notes (dinky) Broken in bb19ded6d30e696c234aeda7060a468f3fc7a340 . -------------------------------------------------------------------------------- 317cea8a3c | Nicholas Feinberg | 2021-02-24 18:28:27 -0800 Fix more cursed item descs (Nomi) See 52645efa069834ac9ca1066c78a845ef7baba59d . -------------------------------------------------------------------------------- ca2cecf3c0 | Nicholas Feinberg | 2021-02-23 21:56:14 -0800 Tweak animated armour scaling (gammafunk) To avoid confusion between the summoned armour's plus and the worn armour it comes from, buff HD with power instead. -------------------------------------------------------------------------------- e3bbeeb173 | Nicholas Feinberg | 2021-02-23 21:55:35 -0800 Tweak permasummon desc Replace an awkward "and" about stairs. It keeps happening. -------------------------------------------------------------------------------- bb19ded6d3 | Implojin | 2021-02-23 21:43:23 -0800 Turn wear-id into floor-id Following much the same reasoning as in f6d4cf81. Especially now that curses are gone (RIP), there's very little incentive not to wear-ID items. (This was mostly true before too, but it's extra obvious now.) Instead, just identify equippable items when you step on them. This does remove certain categories of surprise from randarts (it's *Contam!), but players will live. No comp for this in terms of ?id drops, since that item was better spent on consumables for the period of the game in which ?id is in finite supply. (So no difference.) Closes #1770. -------------------------------------------------------------------------------- 4a2567b755 | Nicholas Feinberg | 2021-02-23 21:36:06 -0800 Fix monster quiver desc (vt) -------------------------------------------------------------------------------- 8dd771eca2 | Nicholas Feinberg | 2021-02-22 17:55:06 -0800 Simplify ghostly spectral weapon code It was only ever being cast at one power. (dungeon.cc doesn't count, since that code will never be hit.) -------------------------------------------------------------------------------- e6bb7ee78e | Nicholas Feinberg | 2021-02-22 17:29:49 -0800 Simplify spectral weapons Simplify the effect. The weapon pops out when you attack, immediately follows up, and then sticks around until the end of your next turn. If you hit again, everything repeats. Otherwise, it vanishes. The design here is of an ego with great damage but that has some positioning constraints, and that still has the potential drawback of damage sharing. (If the positioning constraints turn out to be enough to make it interesting, we can junk the damage sharing.) I've just removed monster spectral ego for now, but it'd be nice to have it back eventually. -------------------------------------------------------------------------------- 72e693e10d | Nicholas Feinberg | 2021-02-22 17:16:23 -0800 Make spines trigger on manifold assault attacks This is 100% impossible to trigger right now, but it's good to future-proof. -------------------------------------------------------------------------------- d57800a693 | advil | 2021-02-22 17:53:20 -0500 Fix another changelog typo Turns out there were two! -------------------------------------------------------------------------------- d488d78fa8 | Neil Moore | 2021-02-22 16:45:18 -0500 Fix a typo in the changelog skip ci -------------------------------------------------------------------------------- 56c411f157 | Nicholas Feinberg | 2021-02-22 12:04:43 -0800 Manual updates (nicolae) -------------------------------------------------------------------------------- 23f261fbd2 | Nicholas Feinberg | 2021-02-21 16:17:38 -0800 Make zigs grant zot immunity (hellmonk, etc) If you can clear an entire zig, you're well past the point in the game where the zot clock (as it currently exists) is relevant. It's fairly hard to imagine a version of the zot clock that co-exists with ziggurats, really. -------------------------------------------------------------------------------- dc27087bfa | Kate | 2021-02-21 23:01:43 +0000 Fix LRD not hitting monsters standing on open doors (#12515) Caused by reversed logic in e2d8f9cc. -------------------------------------------------------------------------------- 4390dbc5be | Kate | 2021-02-21 19:55:56 +0000 Fix some skill training display interactions (#12514) Make evocations show up as a trainable skill by default with the staff of Wucad Mu carried, make necromancy visible with a pain weapon, and fix evocations being visible with spectral weapons and the salamander hide armour. -------------------------------------------------------------------------------- f2f63bf033 | Kate | 2021-02-21 19:54:39 +0000 Prevent unwielding the obsidian axe while mesmerised To make it more of a real commitment (while still keeping the *Drain penalty to prevent swapping it freely between combats). -------------------------------------------------------------------------------- fadf0348f2 | advil | 2021-02-21 11:40:04 -0500 Fix the build for ancient perl versions? This is breaking CAO (and also PF). -------------------------------------------------------------------------------- ea03ee85fd | Nicholas Feinberg | 2021-02-20 20:10:21 -0800 Revert "Add one more draconian skill title (hellmonk)" This reverts commit d82557afd8e216d667967f927f2beb04dc6b3180. Duplicates a WJC title. -------------------------------------------------------------------------------- d82557afd8 | Nicholas Feinberg | 2021-02-20 19:56:03 -0800 Add one more draconian skill title (hellmonk) Other suggestions I haven't added: - Pearl Dragon (TSO) - Shadow Dragon (Stealth) - Bone Dragon (Necromancy) -------------------------------------------------------------------------------- 57bad1e98f | Nicholas Feinberg | 2021-02-20 19:50:47 -0800 Re-rename KILLED_BY_EXPLOSION It's not just any explosion, it's a death explosion specifically. Fireballs need not apply. Closes #1765. -------------------------------------------------------------------------------- 75c20cf7c0 | Hatsuma | 2021-02-20 19:48:52 -0800 Fix inner flame explosion death messages (Committer's note: Turning death explosions into a fineff broke the messaging for inner flame explosions. This commit should hopefully fix them.) -------------------------------------------------------------------------------- a62f12ae83 | Hatsuma | 2021-02-20 19:48:40 -0800 Rename KILLED_BY_SPORE to KILLED_BY_EXPLOSION -------------------------------------------------------------------------------- 03f4e8edb7 | Aliscans | 2021-02-20 12:45:42 +0200 Make the "1 corona" status message grammatically correct, and other bugfixes. 1. Fix the handling of singulars and plurals in _condition_string(). It had been saying "(1 reflect damage)", where it should have been "reflects". 2. Fix a typo in a flag name in monster_info_flag_names. 3. Fix a copy/paste error in mons_conditions_string() which prevented missile-wielders from being reported correctly in the monster list. -------------------------------------------------------------------------------- 982d447839 | Edgar A. Bering IV | 2021-02-20 12:35:52 +0200 Silence a GCC type warning Closes #1758 -------------------------------------------------------------------------------- 49c82dfaf2 | Kate | 2021-02-20 01:09:42 +0000 Fix monster airstrike messaging (shummie) Closes #1762. -------------------------------------------------------------------------------- ba1aca71f1 | Kate | 2021-02-19 22:18:22 +0000 Fix Ozo's Armour allowing cancellation of dispersal traps Closes #1743. -------------------------------------------------------------------------------- 479c5223a7 | Kate | 2021-02-19 22:18:22 +0000 Rename and staticify a function -------------------------------------------------------------------------------- 8719b9d021 | Kate | 2021-02-19 22:16:16 +0000 Remove Airstrike's bonus damage against fliers Against monsters, it was just another type of elemental vulnerability, but against players, it was almost never tactically interesting and heavily penalised forgetting to toggle permanent sources of flight off. Rather than make it behave inconsistently against monsters, remove the bonus entirely - the increased damage against targets in open space is a more interesting bonus to focus the spell on (although the way it works should probably be adjusted/simplified). -------------------------------------------------------------------------------- c01e420030 | Jeffery Stager | 2021-02-19 17:08:23 -0500 fix typo in crawl_manual.rst -------------------------------------------------------------------------------- 622eac400c | advil | 2021-02-19 16:59:43 -0500 Add a scale to one missed describe call missed in 236002575ef -------------------------------------------------------------------------------- fbcf811447 | advil | 2021-02-19 16:44:35 -0500 Remove a debug call -------------------------------------------------------------------------------- 236002575e | advil | 2021-02-19 16:43:54 -0500 Double-size main tiles in (webtiles) describe popups This is for purely aesthetic reasons, but we'll see if others agree. It gives a nice pixelly look on default settings (though some tiles look better than others). If the ultimate judgment on this is positive, it can be ported to local tiles also. -------------------------------------------------------------------------------- 855979065c | Kate | 2021-02-19 18:32:06 +0000 Adjust wall jump interaction with mesmerise (#12205) Make mesmerise restrict wall jumps based on the landing location instead of the targeted wall, so that jumping away from mesmerising enemies is prevented and jumping towards them is allowed, not the other way around. -------------------------------------------------------------------------------- 3208abaabc | Edgar A. Bering IV | 2021-02-17 22:37:41 +0200 Buff Boris on the orb run Boris has been spawning on the orb run for about a year now and hasn't bagged a player. That simply will not do, so in this commit we give our boy a hand. If Boris sees the player with the orb he gains permanent haste and permanent brilliance aura effect. The former will help him chase players and sling spells at them; the latter will give him Ancient Lich spellcasting HD for greater lethality. -------------------------------------------------------------------------------- 6612197ff9 | Edgar A. Bering IV | 2021-02-17 18:20:57 +0200 Further tweak Lich spell sets By popular demand for more cold threats after the spell overhaul, as well as for liches with OOD and Petrify, this commit splits the Lich/Ancient Lich spell sets. Liches get Bolt of Cold, OOD, Slow, Haste, and Invis. Ancient Liches keep their new spell set but trade Slow for Petrify. -------------------------------------------------------------------------------- 9b90508cd1 | gammafunk | 2021-02-17 09:17:02 -0600 Clean up trove syntax Reorganize statements for consistency with the rest of DES, group ITEM statements, and reindent the veto clause. Closes #1755. -------------------------------------------------------------------------------- 79effa3b09 | Goratrix | 2021-02-17 09:17:02 -0600 Rework evocations-themed trove Since some of the misc evocables have been removed and the remaining six were changed to xp-rechargable, this trove has been often disappointing, placing on average 10 of misc evocables out of the total 14 items, with multiple useless copies of each. This changes the trove to guarantee exactly one of each of the 6 misc evocables, plus 8 wands/staves, weighted as average 6 wands and 2 staves. -------------------------------------------------------------------------------- d70e203ec9 | advil | 2021-02-17 09:00:36 -0500 Fix an ability description typo -------------------------------------------------------------------------------- 150de4c316 | Nikolai Lavsky | 2021-02-16 20:07:03 -0800 Don't assault firewood Also, fix an overlap between ``wont_attack()`` and ``neutral()`` in a condition. The former means ``ATT_FRIENDLY || ATT_GOOD_NEUTRAL || ATT_STRICT_NEUTRAL``, the latter means ``ATT_NEUTRAL || ATT_GOOD_NEUTRAL || ATT_STRICT_NEUTRAL``. -------------------------------------------------------------------------------- 34d631faf5 | advil | 2021-02-16 16:44:23 -0500 Memoize some terrain functions This fixes up a bunch of existing small hotspots by using the built in memoize code; somewhat redundant with the previous commit, which dealt with a stair direction call in a different way already. Really, the consequential change here is the feat_is_altar change, but I've also memoized a few key things that were downstream from this just because it's easy to do. The suppress blood check is heavily called on a webtiles build, so seems to merit converting to a more standard terrain function and memoizing as well (though really it was a hotspot because of the altar check). -------------------------------------------------------------------------------- 3e7e21a061 | advil | 2021-02-16 16:44:23 -0500 Limit stair exclusions to stairs Altars and shops also have stair directions, but stair exclusion semantics doesn't make any sense for them (and regular exclusions should still work if you want that). Also, because this is called a lot in rendering, checking the stair direction of altars was a weird little hotspot because it has to iterate through possible altar features (2% of weight during an early game qw run with a profiler attached, which is comparable to all of console rendering). Is there a use case for stair exclusion semantics acting on transporters? I'm not sure if that even worked but this probably prevents it if it did. If people complain I'll add them back. -------------------------------------------------------------------------------- 184f3a1eb7 | Aliscans | 2021-02-16 21:19:27 +0200 Move some text for some artefacts to art-data.txt. Create DESCRIP and DBRAND fields in art-data.txt. These fields are used in the description of an artefact. DBRAND extends the brand description and should be used for special brands. DESCRIP is used for sundry properties. The staff of Olgreb, Storm Bow, Maxwell's Thermic Engine, salamander hide armour, macabre finger necklace, and the glaive of the Guard are all adjusted to use these new data fields. I've put this in the description below the "excrutiating wounds" description, but this doesn't matter as the spell cannot be used on artefacts. I haven't moved the Warlock's Mirror description, as this field only works if the text to insert is fixed. Add + as a "start of line" character to show that the contents of a line in art-data.txt continues the preceding (string) field. Where, with whitespace, a space is added between the old line and the new one, with +, a newline is added. Add a description of the fields to the top of art-data.txt. [ Committer's note: Squashed and rebased, revised the commit message, tweaked some documentation and moved formatting newlines to describe.cc only (no extra newlines from art-data.pl). Closes #1717 ] -------------------------------------------------------------------------------- accac60908 | Aliscans | 2021-02-16 20:00:27 +0200 Make travel_pathfind::points a local variable. points is only used as the iterator for one loop in travel_pathfind::pathfind(), so it doesn't need a wider scope. -------------------------------------------------------------------------------- b98e92b636 | Aliscans | 2021-02-16 20:00:27 +0200 Delete some unnecessary functions from travel_pathfind. Delete set_annotate_map() and set_distance_grid(), which were never used. Replace travel_move() with travel_move in travel_pathfind. It was only called by pathfind(), which could access both. Move _find_explore_status() into travel_pathfind (now called explore_statu()). As its purpose is to interrogate a travel_pathfind, it seems like a good fit. Replace greedy_square(), unexplored_square() and get_unreachables() with the underlying variables. _find_explore_status() was the only function which read them, and it can now read the variables directly. -------------------------------------------------------------------------------- 5b2ef45498 | Aliscans | 2021-02-16 19:56:53 +0200 Delete the redundant rmode variable from _find_travel_pos(). -------------------------------------------------------------------------------- 76aa1ed959 | Aliscans | 2021-02-16 19:56:53 +0200 Remove a pointless travel_pathfind::pathfind() call. pathfind() always returns (0,0) without a target, so fill_travel_point_distance() no longer checks this. pathfind() clears travel_point_distance as it starts, so fill_travel_point_distance() no longer calls it twice if features hasn't been provided. It changes the order of *features, so I still call it twice if it is set. -------------------------------------------------------------------------------- a84d769ad4 | Aliscans | 2021-02-16 19:56:53 +0200 Split find_travel_pos(). _find_travel_pos() handles the case where move_x and move_y are set. fill_travel_point_distance() handles the cases without them. This change just removes the code which isn't run in each case, and puts _find_travel_pos() above the function which calls it. -------------------------------------------------------------------------------- dae97dfda2 | shummie | 2021-02-16 09:04:31 -0800 Replace running with rampaging in wizlabs Two vaults - Cloud Mages' Chambers and Roulette of Golubria have boots of running as possible rewards. With the removal of boots of running, these were missed. Replace these with boots of rampaging since they still fit the intended theme/reward of the wizlab. -------------------------------------------------------------------------------- 5931744824 | wheals | 2021-02-16 18:36:59 +0200 Fix polearm titles (#12507) -------------------------------------------------------------------------------- 82400c8b53 | advil | 2021-02-16 10:14:12 -0500 Convert traversability memoization to an array a42c0fa56e7 did get noticeable speedups in world_reacts bad cases, but it turns out that lookup time for unordered_map on this scale is still surprisingly bad because (it seems) of weird stdlib implementation constraints that lead to high layers of abstraction surrounding the constant lookup. So, just use an array, like most other member functions for this class. -------------------------------------------------------------------------------- b5b73b6894 | gammafunk | 2021-02-16 05:41:28 -0600 Some fixes for three Swamp vaults cheibrodos_swamp_witchery: Remove the unnecessary downweight, as it's a simple vault that places a single, normal-depth monster. Add some glass to make this not an autoexplore trap, since fenstriders do have paralyse. Make the special loot more appropriate to what the monster is thematically. Also clean up vault syntax. cheibrodos_swamp_pet_leeches: Make the corpse closet have a door; there's no reason for this to be accessible only with dig. Also remove the no_tele_into portions, as it's not necessary. For all three of these vaults, remove unnecessary range restrictions for Swamp:4, as they work just fine on that level. Also remove no_item_gen, as there's no problem with items generating in these. Vault makers tend to use this when they place their own loot, thinking they don't want the layout to place more loot on the level. But this tag doesn't affect the amount of loot generated as level items, just what places are eligible. Likely we'll need to make another pass through swamp.des to fix up other issues related to the Swamp changes. -------------------------------------------------------------------------------- 54d06ca096 | AdamPG | 2021-02-16 09:41:00 +0200 Tweak some Swamp witch vaults to better fit their creators' intentions grunt_witch_cave gets a real witch now that they exist. cheibrodos_swamp_witchery seemingly wanted to place exactly one witch in one of the huts randomly, but actually placed zero to two witches. Replacing SUBST with NSUBST leads to the intended behaviour. -------------------------------------------------------------------------------- 8badd94918 | Edgar A. Bering IV | 2021-02-16 08:54:07 +0200 Update the changelog through 0.27-a0-365 -------------------------------------------------------------------------------- ed15d12607 | Edgar A. Bering IV | 2021-02-16 08:53:32 +0200 Update the changelog for 0.26.1 (cherry picked from commit d7a4d63c155831395aa76a5b27c080510dfb948e) -------------------------------------------------------------------------------- 31b3477d74 | advil | 2021-02-15 22:54:29 -0500 Calm down pathing for lost batty band leaders (12505) When a band leader is inaccessible and far away, what's supposed to happen is that the range check in _band_ok keeps a new path calculation attempt from happening while band members move between random wander targets. However, if the band consists of batty monsters, this logic was being overridden; apparently batty monsters get a new wander target each turn no matter what (??). This was leading to a pretty massive cpu spike when scarab beetles lost their band leader in tomb, as seen in the save in 12505. This commit causes batty band members to use the _band_ok logic rather than blanket recalculating every call. I'm not sure if there will be any weird side effects to this, e.g. they might move around less when wandering. Possibly affects only scarab beetles. -------------------------------------------------------------------------------- a42c0fa56e | advil | 2021-02-15 22:54:29 -0500 Memoize traversability checks in pathfinding In extreme cases, pathfinding with a large range on an open level calls this ~7-8 times per square, so it can be a noticeable speedup to not recalculate traversability constantly. -------------------------------------------------------------------------------- 8331d791d5 | Nikolai Lavsky | 2021-02-15 22:20:20 +0200 Update the des syntax doc This commit updates examples and removes mentions of obsolete/deprecated item types, glyphs, and modifiers. -------------------------------------------------------------------------------- 8f6b0cd894 | advil | 2021-02-15 15:10:51 -0500 Restructure some wizmode help commands I can never find what I'm looking for in this menu, and this commit is an attempt to have slightly easier ordering and sections for level/builder/feature-related commands. -------------------------------------------------------------------------------- aa8612f87b | advil | 2021-02-15 14:25:01 -0500 Improve some divine exegesis menu issues * e12f10fa2d7f24c87a used ' ' as the hotkey for uncastable spells in divine exegesis as a display hack, following code for unmemorizable spells from before that commit. Previously this was the only (maybe even standard?) way to mix hotkeyed and non-hotkeyed MenuEntrys in a menu with reasonable formatting. However, space is a valid hotkey that the menu code will handle as such, and for unrelated reasons dd83002478 changed how this hotkey renders, leading to weird effects for DE in particular. (I'm not actually sure under what conditions the memorise case here gets triggered..) This commit adds a fairly brute-force way of fixing the formatting for actually non-hotkeyed entries. Possibly should be the default on everything, but the way hotkeys are rendered generally needs a bigger refactor. * Fix header spacing in the (Cast) version of the menu. * Show some DE-specific text + current MP in the footer; the fact that the player needed MP for the spell seems to have been tripping people up in combination with the "Space" bug, so showing it explicitly will make clear why some spells are disabled. There's still an issue with this menu when the player has >52 spells memorized. -------------------------------------------------------------------------------- b719701251 | Nicholas Feinberg | 2021-02-15 11:04:24 -0800 Fix tests? -------------------------------------------------------------------------------- 46a10ce11a | Nicholas Feinberg | 2021-02-15 10:51:21 -0800 Let dancing launchers shoot -------------------------------------------------------------------------------- 7e98f454ed | Nicholas Feinberg | 2021-02-15 10:47:17 -0800 Give dancing launchers ammo -------------------------------------------------------------------------------- bf771cdeb5 | Nicholas Feinberg | 2021-02-15 10:23:27 -0800 Make dancing launchers not crash the game -------------------------------------------------------------------------------- 57b6be6a68 | Nicholas Feinberg | 2021-02-15 10:00:12 -0800 New spell: Manifold Assault (L5 Translocations) Manifold Assault launches melee attacks with against 2-4 random enemies in LOS, depending on spellpower. It's themed as warping space so that one attack can, paradoxically, hit many enemies. This spell is intended to give melee-focused characters more reason to consider investing in spellcasting, It's fun to try to skill toward a 'hybrid' build, and a spell that mostly scales off your melee attack, rather than your spellpower, helps encourage that. This being a L5 spell helps avoid it being a truly free 'gimme', and allows it to hit many enemies at once. The lack of targeter should hopefully avoid it being annoying to use, by making it just a single press to cast. It also gives the player more reason to keep normally hitting things in melee sometimes, when it's important to kill a specific target. Cleaving doesn't work with this spell since it seems overly confusing, and since reach and riposte don't work with it either. (Thus, it's 'fair'.) All stabs are also currently banned, though I do wonder if we might want to allow non-sleep stabs. -------------------------------------------------------------------------------- d46515b8de | Nicholas Feinberg | 2021-02-15 09:45:49 -0800 Display monster to-hit percentages in xv Accounting for both EV and SH. These calculations are a bit clunky, but they line up with the underlying rolls and with fsim. -------------------------------------------------------------------------------- b2377c9954 | advil | 2021-02-15 11:58:35 -0500 Partial refactor of throw_item_no_quiver (12488) The end goal is to have this better integrated with quiver code, but this commit only moves a bit towards this. The main target of this commit, convulated though it may seem, is to prevent `F` from updating the global quiver history and avoid the issue in mantis 12488 altogether. This commit does it by using a custom action_cycler for throwing via `F`, which indirectly keeps the history from being updated and minorly improves the interface for `F` targeting (and then most of the commit is restructuring so that this can be done more easily). -------------------------------------------------------------------------------- 3253a67a23 | advil | 2021-02-15 11:58:35 -0500 Rein in some autoswitch logic In particular, don't apply autoswitch logic to ammo gain/loss unless it is an entire stack of ammo. This partially addresses 12488: what is happening there is that because firing changes stack size, the autoswitch code was getting called on any firing event. It's not a complete fix because `F` should still never affect the fire history for autoswitch purposes. -------------------------------------------------------------------------------- 775e467c85 | advil | 2021-02-15 11:58:35 -0500 Update qw copy Possibly this should be removed from the repo, or turned into a submodule, but until that happens, here's a more up-to-date version. -------------------------------------------------------------------------------- db36ff0be9 | Implojin | 2021-02-15 17:15:11 +0200 Add another species title Ashenzari warns you: it is. -------------------------------------------------------------------------------- 77ac2e9d3a | Aliscans | 2021-02-15 09:30:46 +0200 Distinguish between "1 poisoned" and "all poisoned" in the monster list. Previously, if there were 6 sheep, the monster list would show: (poisoned) if 1 had been poisoned; (2 poisoned) if 2 had; and (poisoned) if all had. This changes the first case to (1 poisoned). It displays (poisoned), as now, if only one sheep is left. This makes it easier to see when (in this case) a sheep needs more poison. -------------------------------------------------------------------------------- d820fc0954 | Aliscans | 2021-02-15 09:28:01 +0200 Keep "[Y]es or [N]o only, please" messages out of the log. Move the "[Y]es or [N]o only, please" message from MSGCH_PLAIN to MSGCH_PROMPT in yesno() and yesnoquit(). This has two effects. 1. The message no longer appears in the previous message list. The original yes/no question does not appear here, so this message previously appeared in the log with no context. 2. The message is blue rather than white by default. This could be changed, but it would take more work. -------------------------------------------------------------------------------- 1cc477e9f5 | AdamPG | 2021-02-15 09:25:21 +0200 Make amulets of reflection actually grant monsters SH Currently the SH returned is negative when a monster has an amulet of reflection equipped without a shield. -------------------------------------------------------------------------------- a689d4a613 | Nicholas Feinberg | 2021-02-14 19:41:43 -0800 Restore old Fedhas piety message Purely for flavor, let's appreciate some contributions to the ecosystem. -------------------------------------------------------------------------------- 7370b58738 | advil | 2021-02-14 14:45:45 -0500 Remove an obsolete autopickup exception (12497) Books are now marked as useless if they wouldn't add any spells, so there doesn't need to be a custom autopickup rule for them. In addition, since b8f8a8f698407 and bd089401bb, this rule broke autopickup for ash, because books are all fully ID'd. -------------------------------------------------------------------------------- ae24eb62ac | Kate | 2021-02-14 09:54:31 +0000 Fix some typos Closes #1719 -------------------------------------------------------------------------------- fcad680f63 | Nicholas Feinberg | 2021-02-13 16:24:56 -0800 Partially compensate VS regen Remove their second level of MUT_REGEN, now that each level gives 1 HP/dAut instead of 0.4. This still makes them strictly stronger than before - could perhaps shift the first MUT_REGEN a bit later? Another interesting idea would be to give them another -1 hp, +10% mp, and super regen (hellmonk), but don't feel strongly. -------------------------------------------------------------------------------- 5810d18f4b | Nicholas Feinberg | 2021-02-13 16:20:29 -0800 Make trolls more thin-skinned In compensation for their extra 0.6 hp/turn, turn their tough skin mut down from level 3 to level 1. -------------------------------------------------------------------------------- 40fdf68bc5 | advil | 2021-02-13 17:08:25 -0500 Continue fixing CI -------------------------------------------------------------------------------- 029c345baf | advil | 2021-02-13 16:48:00 -0500 Actually update requirements files for the CI error -------------------------------------------------------------------------------- df26f997a6 | advil | 2021-02-13 16:38:16 -0500 Fix more build issues * one more upgrade issue for the running brand * disable a flake8 package that seems to have stopped working in py27 -------------------------------------------------------------------------------- 9cfa79e74d | advil | 2021-02-13 16:23:24 -0500 Fix an upgrade build issue for running removal -------------------------------------------------------------------------------- c8f691b2cc | Nicholas Feinberg | 2021-02-13 11:15:15 -0800 Buff regen properties (Lici) Items that grant regeneration gave 0.4 HP/turn (0.04/aut), which was not enough to make them a significant tactical factor. Since the vast majority of the game doesn't have enough strategic time pressure to make regen speed outside combat very meaningful, this meant that the regen property was misleadingly weak. Increasing the regen rate by 2.5x to 1 HP/turn (0.1/aut) should give it some chance of being a relevant factor for equipment decisions in a 3-rune game. I don't believe this significantly buffs players overall, since most sources of regeneration still aren't that strong. -------------------------------------------------------------------------------- e8094add7c | Nicholas Feinberg | 2021-02-13 10:52:21 -0800 Remove boots of running Boots of running were extremely strong items, which isn't at all a problem. It's great for the game to have rare and powerful items - it creates exciting variance. However, runboots didn't create fun and exciting gameplay. They drained tension from the game by allowing the wearer to (over ~1-10 turns!) walk away from any normal speed enemy, which is powerful, but not that fun. So, farewell. Lightning scales remain as the last holdout, though maybe they should be restricted for naga only. Maybe we can finally have that scroll of brand armour now...? (: -------------------------------------------------------------------------------- dc303548b9 | Nicholas Feinberg | 2021-02-13 10:52:13 -0800 Rewrite lightning scales' description Be slightly coyer about which species can use them (for aesthetics), and clarify that they improve movement speed, not action speed. -------------------------------------------------------------------------------- 52645efa06 | Nicholas Feinberg | 2021-02-12 14:55:01 -0800 Fix cursed item descriptions (12492) Broken sometime around 8bf7259e65b6b6a6ca . Oops! -------------------------------------------------------------------------------- fa571bf19a | advil | 2021-02-11 15:27:05 -0500 Fix header build -------------------------------------------------------------------------------- d6963574d8 | advil | 2021-02-11 13:16:17 -0500 Explicitly show ally foes This shows ally targeting info: (i) on the ally, (ii) on the target monsters, and (iii) as a mi flag on the short description (without specifics). For simple cases this won't show anything surprising at all to experienced players, but I think it still is useful info to new players. For complex cases, it may be useful to see e.g. that an ally is pathing through a monster that's not what you'd hope it to be targeting. I suspect this hasn't been done before because of information overload issues. And monster descriptions definitely have been accruing information overload for the last few versions! However, I think I have converted to team info, and I do think this specific bit of info is useful for many cases. It also may have not been done before because there are cases where what is shown is weird and confusing. However, this reflects weird and confusing ally *behaviour*, which is still frustrating to players when it is detected. This commit may make it easier to detect, which is perhaps the path towards less confusing ally behavior. I won't be surprised if it turns up some bugs too... It doesn't seem impossible to me that this could turn out to be a bad idea to show after all, but we'll see. -------------------------------------------------------------------------------- 70b395f35d | Nicholas Feinberg | 2021-02-11 09:25:27 -0800 Spelling -------------------------------------------------------------------------------- 75073f8639 | Nicholas Feinberg | 2021-02-11 09:23:55 -0800 Two more titles (hellmonk, ebering) -------------------------------------------------------------------------------- ccc5534d49 | Nicholas Feinberg | 2021-02-11 09:14:21 -0800 Add more per-species titles Seems fun! All of these are intended to be not too annoying to get for folks who like to collect titles, but they're not in general designed as something to steer folks towards a race's strengths - just fun little acknowledgements of something the player's done. I desperately wanted the formicid title to be 'transdimensional tunneler', but it was far too long... -------------------------------------------------------------------------------- 7f782ed93a | Implojin | 2021-02-10 23:31:44 +0200 Update copyright date in LICENSE -------------------------------------------------------------------------------- 433c55acf3 | Nicholas Feinberg | 2021-02-10 12:51:43 -0800 Remove a semicolon -------------------------------------------------------------------------------- 81277dbfc4 | hellmonk | 2021-02-10 12:51:43 -0800 Change demigod stats and exp apt. Lean into the stat gimmick by reducing starting stats by 2 each and doubling stat growth. -------------------------------------------------------------------------------- da14cb0413 | advil | 2021-02-10 15:45:47 -0500 Fix some uselessness grammar (gammafunk) The main point of this commmit is to fix the wording, shown in spell descriptions, "This spell would have no effect right now because you don't have enough magic to cast that spell." It does this by formatting more general casting useless reasons separately from spell-specific uselessness reasons (they are shown in red without any extra text). Along the way: * change "that" to "this" in the low MP uselessness reason -- "this" is used elsewhere and is less awkward in most cases. (Even if it no longer matters here.) * refactor Ru spell bans to all be handled as casting uselessness reasons, not spell-specific uselessness reasons; before they were in multiple places. Hopefully the weird previous ordering didn't cause any side effects that this eliminates. -------------------------------------------------------------------------------- 75ad407e7c | wheals | 2021-02-10 17:40:21 +0200 Remove some extraneous uses of auto_id_inventory Unused since 20b3437a0c1 -------------------------------------------------------------------------------- bd089401bb | advil | 2021-02-10 10:21:36 -0500 Further fix ash id (wheals) cf. b8f8a8f69840 -------------------------------------------------------------------------------- b8f8a8f698 | advil | 2021-02-10 10:01:43 -0500 Quick ash id fix Accommodate the presupposition in fa4e0b4b0e52 that ash identifies all items; otherwise, ash players are a bit out of luck right now. Not well tested for id special cases... Resolves #1735 -------------------------------------------------------------------------------- 42d3f6298c | Edgar A. Bering IV | 2021-02-10 15:58:41 +0200 Weight random effects So that the "bad for the player" effects happen only 15% of the time. -------------------------------------------------------------------------------- 81d27af2d4 | advil | 2021-02-09 22:22:27 -0500 Pre-identify acquirement manuals (12485) This comes up for troves, e.g. trove_library as in the linked save. Regular manual generation has done pre-identification since 2c9a30dacb1b69, but I suspect there was also somewhere a step where an acquired manual was id'd once it was actually picked up. Now that manuals never get picked up, unless the manual is id'd in advance there is an extremely useless message. I've also added (redundant?) id'ing in the new pickup code. This shouldn't be necessary except for games with troves that generated before this fix. -------------------------------------------------------------------------------- b975c0971c | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Remove a mystifying comment from the last millenium -------------------------------------------------------------------------------- a3e463392d | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Remove the extra bad weapon randarts Just because. -------------------------------------------------------------------------------- 9fd62742f6 | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Make jewellery generation more sane -------------------------------------------------------------------------------- 8372c9b158 | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Reduce jewellery generation a bit To compensate for the removal of 3 rings, 1 amulet, and negative enchantment jewellery. No adjustment to overall item generation, since we overshot a little bit with the compensation for ?rc removal. -------------------------------------------------------------------------------- 6b4f085fcf | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Teleport rings of teleportation away Tragically, in their current form, they have little to offer in a curseless world. Farewell! -------------------------------------------------------------------------------- 303758149e | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Re-add useless jewellery -------------------------------------------------------------------------------- d58e3d690f | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Remove more bad things -------------------------------------------------------------------------------- 68f27ed3b0 | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Remove very bad weapons (ebering) These were uncommon enough that I don't we need to comp generation further. -------------------------------------------------------------------------------- 0bbf9b5c7d | Nicholas Feinberg | 2021-02-09 16:36:09 -0800 Remove an inaccurate hint -------------------------------------------------------------------------------- bc12fde1e9 | Nicholas Feinberg | 2021-02-09 16:35:56 -0800 Recolour weapon/armour egos As before, un-id'd glowing weapons/armour are blue. Ego weapons/armour: green. Enchanted but non-ego weapons/armour: green. (Previously used for known-uncursed items.) Un-id'd magical staves: blue. ID'd magical staves: green. I suspect we'll want to tweak some of this, but it's a start. -------------------------------------------------------------------------------- d83380fbf1 | Nicholas Feinberg | 2021-02-09 16:35:42 -0800 Update docs for curse removal -------------------------------------------------------------------------------- 3ce31fd4f6 | Nicholas Feinberg | 2021-02-09 16:35:42 -0800 Reduce non-vault item gen by 5% To compensate for ?rc removal and keep overall item count roughly the same as it was before. -------------------------------------------------------------------------------- 880a64342f | Nicholas Feinberg | 2021-02-09 16:35:28 -0800 Remove remove curse Useless now that random curses no longer exist. -------------------------------------------------------------------------------- f16e07f070 | Nicholas Feinberg | 2021-02-09 16:35:28 -0800 Fix a hint -------------------------------------------------------------------------------- c026bc2f57 | Nicholas Feinberg | 2021-02-09 16:35:21 -0800 Uncurse all items Except for those in the inventory of Ash-worshippers. -------------------------------------------------------------------------------- 583d5e20f2 | Nicholas Feinberg | 2021-02-09 16:35:18 -0800 Don't generate items cursed The future approacheth. -------------------------------------------------------------------------------- 8bf7259e65 | Nicholas Feinberg | 2021-02-09 16:35:18 -0800 Make curse status always known Since Ash will soon be the only source of curses. Don't ever describe items as 'uncursed', since that's trivially true if you're not with Ash. -------------------------------------------------------------------------------- 8bc936e012 | Nicholas Feinberg | 2021-02-09 16:35:18 -0800 Don't glow up cursed items Irrelevant soon. -------------------------------------------------------------------------------- e2017fbedb | Nicholas Feinberg | 2021-02-09 16:35:18 -0800 Remove cursed vault items Begone, gammacurses! -------------------------------------------------------------------------------- c22e62d8df | Nicholas Feinberg | 2021-02-09 16:35:18 -0800 Remove negative-plus jewellery Made no sense with curse removal. This increases the number of real (non-negative) jewellery items by very roughly 5%. (6/26 jewellery types could be generated with a negative plus, and those had a 20% chance of being negative.) No comp is provided. -------------------------------------------------------------------------------- e57382988b | Nicholas Feinberg | 2021-02-09 16:35:18 -0800 Uncurse everything when leaving Ash Again, a placeholder. -------------------------------------------------------------------------------- fa4e0b4b0e | Nicholas Feinberg | 2021-02-09 16:34:57 -0800 Make Ash use ?id instead of ?rc Placeholder for a broader rework. It's sort of elegant, IMO - since ID is pretty useless with Ash otherwise (since the god already IDs everything), it's a reasonable resource. -------------------------------------------------------------------------------- 01f12845e7 | Nicholas Feinberg | 2021-02-09 16:34:54 -0800 Remove amulets of inaccuracy Part 1 of the Curse Removal Saga. -------------------------------------------------------------------------------- a3f61025e6 | Nicholas Feinberg | 2021-02-09 16:31:54 -0800 Fix tloc miscast description -------------------------------------------------------------------------------- e1136d6ca4 | advil | 2021-02-09 16:57:43 -0500 Fix some bitwise operators (geekosaur) -------------------------------------------------------------------------------- ead3b1d052 | advil | 2021-02-09 16:08:45 -0500 Double default dump_message_count In more spectacular endings, 20 is often not nearly enough to see what happened. Let's try a bigger default. -------------------------------------------------------------------------------- ff613de66b | sdynet | 2021-02-09 22:02:58 +0200 Hexify of wand of random effects The immediate effect of damaging the enemy is provided by the other wands. The old effect list was at one point the union of wand effects, but that is long gone and far from true, which makes it a bit of a spoiler trap. The new effect list is entirely buffs and debuffs, and listed in the wand description. If the power level isn't right the effects can be weighted and tuned. [ Committer's note: Closes #1310. Revised the effect list, re-worded the commit message. ] -------------------------------------------------------------------------------- 97e392b7e8 | Nikolai Lavsky | 2021-02-09 20:37:17 +0200 Remove some water from mumra_spider_spiderweb The vault has several spiders trapped behind deep water, as they can no longer cling to walls. This commit frees the spiders and reduces the number of water and deep water tiles in the vault. Also, it removes an escape hatch in the inner area, since the vault is not a teleport closet anymore. -------------------------------------------------------------------------------- d9602db6ee | advil | 2021-02-08 15:38:40 -0500 Skip some unique fineff messaging on turn 0 (12346) This is for the case where a delver lands in los of a pikel/kirke, where it doesn't make sense to do the messaging related to freeing the follower band. I haven't tested this case very directly because the seed in mantis 12346 doesn't place pikel any more (and I haven't tried to go back to a version where it does), so it's possible there's more tweaking needed. In principle, the bands should get zapped too (like dowan and duvessa) but I don't *think* this is happening right now. -------------------------------------------------------------------------------- b28db10d6f | advil | 2021-02-08 15:38:40 -0500 Skip elven twin stuff on dismissal/reset On a delver start, if the los zap wipes out one elven twin, the other is supposed to go too. But, the code in elven_twin_died still ran on the first to go and caused the second one to be woken and berserked etc; depending on the timing this could lead to messaging as in mantis 12480. I'm pretty sure that there's no natural way for these kill types to apply, so this should affect only the delver start case. -------------------------------------------------------------------------------- 715ed11b31 | advil | 2021-02-08 15:38:40 -0500 Don't allow delver-zapped uniques to regenerate Doing this will lead to potential seed differences between delver starts and regular starts on the same seed number. (An alternative option would be to force los uniques somewhere else in the level, after the level has fully generated.) -------------------------------------------------------------------------------- daa8bd6ff3 | Edgar A. Bering IV | 2021-02-08 22:08:00 +0200 Quiet down storm clouds Storm clouds are loud (lightning bolt loud!) because Grunt made them that way in February 2014 and there wasn't much other commentary about it at the time. They're the only cloud that makes noise, and appear in five places: - Around Bai in second form in her cloud ring - Random panlord cloud rings - Robe of Clouds clouds - Condenser vane clouds - Qazlal clouds For monsters, r-i indicated that the loudness of Bai was mildly desired but not a primary part of the design; with randlords the cloud rings are very much a "don't melee me" effect and not for noise. For the two evoked player sources of clouds, the condenser vane has skill training and xp gating to balance it. The Robe of Clouds probably needs another re-work, it does rely on storm cloud noise for balance somewhat. Finally, Qazlal stormclouds have made Q much louder than designed, even very early on, making the noise conduct much harsher than it should be. Q's rumble is min ( piety / 10, 16 ) noise, lightning bolt is 25. 1* Q followers weren't supposed to be so loud. Making all clouds quiet will make it easier to attach appropriate noise (or other cost or drawback) to their source according to mechanical niche, instead of this one cloud type being SO LOUD. -------------------------------------------------------------------------------- d4424db430 | advil | 2021-02-07 19:29:05 -0500 Mark willpower/magical power rings as stackable (12484) 12484 reports this as a recent change, but as far as I can tell MR/willpower has never been marked as stackable in any way; I also noticed that magical power is not marked this way. Any other rings missing here? -------------------------------------------------------------------------------- 37e0bc138e | advil | 2021-02-07 17:31:18 -0500 Fix a bitwise operator used for fire order (12481) This is supposed to keep classes from being added to the vector multiple times, but with & it obviously wouldn't do this correctly, leading to somewhat unpredictable results for custom fire orders. (This whole use of bitmasks for the fire order is one of the last vestiges of oldquivers and could use a complete refactor.) -------------------------------------------------------------------------------- f42357c144 | Kate | 2021-02-07 21:31:54 +0000 Update skill training docs -------------------------------------------------------------------------------- 240d7df7c7 | gammafunk | 2021-02-07 11:09:23 -0600 Some vault adjustments for kobold brigands For vaults that give kobold brigands custom equipment, also give them darts in line with their new "underhanded tactics" theme, unless doing so was counter to the vault's theme somehow. All changes below give brigands darts with a 2/3 chance for poison and 1/3 chance for curare: due_exit_kobolds: An Abyss exit vault. Characters exiting the abyss can handle a dart or two. blue_anna_alchemist: An alchemist would be good at crafting poison! Also pre-identify the guaranteed degeneration and ambrosia potions. cheibrodos_thug_alley: There's only 1-2 brigand "bosses" at the end of this vault, so it won't be anything too nasty. Also clean up NSUBST statements. minmay_goblin_kobold_castle: Perhaps the most significant change, since this vault is pretty iconic. Remove the brigand's custom equipment definition, thus allowing it to have darts, but also mix in gnolls to down-weight brigand placement. This vault describes itself as a castle of kobolds and goblins, but it's actually a castle of kobolds *or* goblins, since you either get a kobold set or a goblin set. The goblin set has (non-throwing) gnolls mixed in, but the kobold set did not. The switch from big kobolds to kobold brigands adds dart throwing jerks, so we upweight ordinary kobolds and add non-throwing gnolls to thin out dart throwers a bit. We now get 2 brigands on-average per map placement for the kobold set, which is reasonable for large, challenging vault on D:3-6. Closes #1709. -------------------------------------------------------------------------------- 7af2214585 | gammafunk | 2021-02-07 08:51:12 -0600 Kobold fixes for a ghost vault Adapt the vault gammafunk_ghost_nasty_kobolds for the change of big kobolds to kobold brigands. Give all brigands darts, simplify weapon setup, remove a definition no longer necessary, since brigands always have darts, and reglyph. Composition-wise, don't mix in special dart-throwing kobolds after we've switch from ordinary kobolds to brigands (post D:5). This vault presents a lot of darts offensively and as loot post D:5, but not to any point that's a concern. -------------------------------------------------------------------------------- 50fcd4f5b3 | Nicholas Feinberg | 2021-02-07 06:20:59 -0600 Turn big kobolds into kobold brigands Big kobolds didn't really have a defined role or any particular threat, and non-big kobolds spawning with curare created some pretty unecessarily vicious difficulty spikes. Remove curare darts from normal kobolds and move them onto big kobolds, which are renamed to 'kobold brigands'. Some vaults are tweaked somewhat; no other changes. This increases the average amount of curare generated in D from about 4 to about 5.5 per game. -------------------------------------------------------------------------------- d22cd1d61d | Edgar A. Bering IV | 2021-02-07 09:48:56 +0200 Apply Gell's gravitas in near-to-far order To the extent that crawl has a coherent physics, players expect gravity to pull everything towards the attraction point, without sorting a further away monster can get pulled first, followed by a closer monster, which is optically a bit weird. The unsorted pull did have an order: internal monster array order, which made the spell hard to reason about and also possibly introduced some weird biases or information leaks. -------------------------------------------------------------------------------- e33754e197 | Hatsuma | 2021-02-07 09:48:03 +0200 Sort potion of attraction pulls [ Committer's note: Closes #1724. Squashed, rebased, tweaked commit message and comments. ] -------------------------------------------------------------------------------- dfb9265905 | advil | 2021-02-06 22:20:13 -0500 Use `catpath` instead of string + for some path combination This should fix 12489, where the use of string concatenation was leading to part of the path without an unterminated directory turning into part of the filename. -------------------------------------------------------------------------------- 7d165411bc | Nicholas Feinberg | 2021-02-06 16:00:09 -0800 Remove a secret accuracy malus (sentei) Added in 7d9c2931b71, 14 years ago (DCSS 0.3). Was not properly displayed in targeters and, also, had no real reason to exist. Clouds do plenty without a secret accuracy penalty! -------------------------------------------------------------------------------- 024f7ef292 | Edgar A. Bering IV | 2021-02-04 23:29:02 +0200 Remove gadget shops In 0.26, all misc evokers became XP gated, so the player only needs one. With wand stacking changes, players still amass a great many wand charges (themselves exacerbated by the reduction in the number of wand types with scattershot and clouds replaced by misc items!). An easy to find and remove source of this heaping pile of riches are gadget shops, which made a lot more sense when gadgets were more consumable (but even then were quite nice shops). Currently wands and evokers can still appear in general stores, perhaps that could also change, there are still a lot of them spawning. Certainly, misc evokers could stand to see further drop reductions. This commit sticks to gadget shops for now. Some specific numbers from a 3-rune 100 iteration objectstat run, compared to the same run for 0.26. Wand | Avg-26 | Avg-new | Min-0.26 | Min-new | Max-0.26 | Max-new ---- | ------ | ------- | -------- | ------- | -------- | ------- flam | 10 | 7.8 | 3 | 3 | 17 | 19 para | 7.7 | 6 | 2 | 2 | 18 | 14 dig | 6.5 | 4 | 1 | 1 | 14 | 13 iceb | 10.5 | 8.3 | 4 | 2 | 22 | 15 poly | 7.8 | 6.1 | 2 | 0 | 15 | 13 char | 4.9 | 3.8 | 1 | 0 | 12 | 10 acid | 8 | 5.9 | 2 | 1 | 18 | 14 rand | 7.8 | 5.9 | 2 | 1 | 20 | 16 mind | 5.7 | 4.6 | 1 | 1 | 13 | 11 Misc | Avg-26 | Avg-new | Min-0.26 | Min-new | Max-0.26 | Max-new ---- | ------ | ------- | -------- | ------- | -------- | ------- box | 7.4 | 4.9 | 1 | 1 | 19 | 12 rod | 7 | 4.6 | 2 | 0 | 14 | 12 phia | 8 | 4.5 | 1 | 0 | 18 | 11 mirr | 7 | 4.4 | 1 | 0 | 17 | 12 tin | 8 | 4.9 | 2 | 0 | 14 | 12 vane | 8 | 4.6 | 1 | 0 | 20 | 11 -------------------------------------------------------------------------------- 67906b0434 | Aliscans | 2021-02-04 20:17:31 +0200 Make _ability_quiver_range_check() static. The following compiler warning was given by gcc 10.2.0. Making _ability_quiver_range_check() static removes the warning. The function is only used in quiver.cc. quiver.cc:1231:10: warning: no previous declaration for ‘bool quiver::_ability_quiver_range_check(ability_type, bool)’ [-Wmissing-declarations] 1231 | bool _ability_quiver_range_check(ability_type abil, bool quiet=true) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -------------------------------------------------------------------------------- fa7a5ec6c4 | Aliscans | 2021-02-04 20:17:31 +0200 Rename lua_persist::string as lua_persist::text. The following compiler warning was given by gcc 10.2.0. Renaming lua_persist::string removes the warning. The name used is immaterial, and the enum is only used in two functions. l-file.cc:93:5: warning: declaration of ‘string’ shadows a global declaration [-Wshadow] 93 | string, | ^~~~~~ In file included from /usr/include/c++/10/iosfwd:39, from /usr/include/c++/10/memory:74, from externs.h:16, from AppHdr.h:315, from l-file.cc:1: /usr/include/c++/10/bits/stringfwd.h:79:33: note: shadowed declaration is here 79 | typedef basic_string string; | -------------------------------------------------------------------------------- b5755f8d7c | advil | 2021-02-04 12:33:56 -0500 lint -------------------------------------------------------------------------------- dc19187ef5 | advil | 2021-02-04 12:31:39 -0500 One more ring of stealth (fix CI) -------------------------------------------------------------------------------- 40f84a5caa | advil | 2021-02-04 12:27:38 -0500 Update some 13 year old docs with current build info (12482) This text was written probably around 0.3 so isn't very applicable to the way things are currently set up; the implementation of DEBUG_MONSPEAK has drifted quite a bit. If there's actually demand for a monspeak-only build (which was possible before bc841a2a9115e3), then the dprfs in mon-speak.cc should be switched back to mprfs. I made one small change so that DEBUG_MONSPEAK isn't completely inert if defined on its own. Also, remove an obsolete DEBUG def. -------------------------------------------------------------------------------- 03888ab0b0 | wheals | 2021-02-04 19:14:30 +0200 Rule of three fix -------------------------------------------------------------------------------- a82526b2db | Nicholas Feinberg | 2021-02-04 09:13:37 -0800 Enable stealth hats and gloves To compensate for the loss of our late, lamented stealthy rings. -------------------------------------------------------------------------------- ccae488368 | Nicholas Feinberg | 2021-02-04 09:05:25 -0800 Mostly remove rings of stealth (various) Rings' mechanical niche is as a swappable slot: items that provide you with tactical decisions to make about gear loadout within a given combat. Do you want rF or Slaying while fighting the lindwurm? Is it worth the extra half a turn to swap? There's some argument over how often ring swapping creates interesting decisions vs busywork, but if rings should exist, that's why. There's no combat where you want to be wearing =Stealth, You want to wear =stealth *outside* of combat, and something else inside. Essentially, if you care about optimizing, you'd want to swap away from =stealth at the start of each combat, which is... not very exciting! So, rings of stealth will no longer generate. They're still around as a base type for the Ring of Shadows, but should probably be refactored into a 'ring of nothingness' at some point. Octopus King now gets +flight instead, for all those pesky lava moments. -------------------------------------------------------------------------------- fa1d4835b4 | Nicholas Feinberg | 2021-02-04 08:58:18 -0800 Pay more attention to removing rings ??doh -------------------------------------------------------------------------------- 0e4e36e7b5 | Nicholas Feinberg | 2021-02-04 08:37:58 -0800 Remove rings of attention These were added to replace rings of hunger, but like their predecessors, they never really had much impact on the game. The potential downside isn't nearly large enough to discourage players from wear-IDing rings, and if it were larger, the resulting cautious gameplay wouldn't be especially fun in a game of Crawl's scale. -------------------------------------------------------------------------------- e61c0dba20 | Nicholas Feinberg | 2021-02-04 08:11:56 -0800 Remove food and chunks - redux! (from objstat) -------------------------------------------------------------------------------- 4b4afb4849 | Nicholas Feinberg | 2021-02-04 08:07:18 -0800 Reduce husk bloat Don't spawn a vast army of bloated husks in swamp_pestilence. -------------------------------------------------------------------------------- 0178f6a2e2 | Nicholas Feinberg | 2021-02-03 23:15:58 -0800 Remove *Curse Random curses on equip existed on exactly three unrands (and no randarts). It was on Scythe of Curses purely for theme, on Obsidian Axe to make it not a complete no-brainer to swap off the weapon when mesmerized, and on the Necklace of Bloodlust to discourage swaps when you'd rather not be randomly berserked. *Curse wasn't an extremely great mechanism for limiting the latter two. The randomness of how many scrolls of remove curse were generated meant that the restriction was sometimes tight and sometimes irrelevant, and there wasn't any real tactical element to the cost. So, let's remove it. Amulets are now slow to swap, so the Necklace of Bloodlust no longer has a *Drain downside at all. The Scythe of Curses is now {drain, *Drain}, which seems very thematic if not mechanically necessary, and the obsidian axe likewise gets *Drain. (It could be fun to have a 'Compel' or 'Sticky' property that makes these weapons slow to swap, compelling the user like the One Ring... but not right now.) This should hopefully provide a more interesting set of tactical choices. Curses! -------------------------------------------------------------------------------- c8dee61f84 | Nicholas Feinberg | 2021-02-03 22:50:47 -0800 Show melee accuracy on v (vt) Matching the xv EV display. (Is this enough cryptic letters..?) -------------------------------------------------------------------------------- c50aac273e | Edgar A. Bering IV | 2021-02-03 21:15:41 +0200 Defang bunyips (hatsuma) Closes #1705; fixing history with binary files made git rebase angry. -------------------------------------------------------------------------------- b9655bc238 | gammafunk | 2021-02-03 12:41:33 -0600 Rework monster placement in a minivault The vault called simply "pond" places over D:10- and all of Lair, but has pretty unambitious monster placement. Except for the fact that its insubstantial wisps got replaced with will-o-the-wisps! Aside from this unfortunate wisp storm, the monster list didn't scale well with placement. This commit reworks the placement, conditioning it on depth and refining the two Lair and Swamp themes it has. Lair and Swamp monster sets are used for D:10-12 and Lair, but only the Swamp set is used for D:13-, since the amphibious Lair monsters aren't an interesting enough set by that point. The Lair set starts from D:10 mostly easier Lair spawns, but ramps this up through Lair and throws torpor snails into the mix by Lair:4. The Swamp set starts as just vampire mosquitoes with light swamp drakeage on D:10, but as depth increases adds swamp dragons, hydra, and eventually will-o-the-wisps. -------------------------------------------------------------------------------- 2393aa7757 | Edgar A. Bering IV | 2021-02-03 20:03:27 +0200 Revert "Increase broad axe delay" This reverts commit 81720017eba9a398c36b19f0d9c4cbe01de8cb61. In the commit message for 81720017eb, its pointed out that broad axes are too cheap relative to battle axes for their rarity. Part of the issue on later analysis of skill points required, is that *shields* were too cheap to add on in a penalty-free way. Commit 0b64aa26 increased the shield penalty. To swing a 20 skill broad axe at min-delay with a kite shield now takes 21,000 skill points on a human; compared to the 13,950 of a battle axe. For an 18 skill broad axe the cost is 17,850; still more than the battle axe (since the trade is for -2 base damage in exchange for the defenses of a shield, it should cost more), but not 1.5 times more expensive. To repeat some of the discussion from 0b64aa26, prior to that commit the cost to swing an 18 skill borad axe at min-delay was 12,200, cheaper than the broad axe. Addressing the disparity via broad axe delay was one solution, but made broad axes a non-use nobrainer for small species (the same base damage is available 1-handed at 16 skill from a morning star for them!); broad axes are still pretty expensive for a small species, but should be more attractive at 18 delay when the shield changes are also considered. -------------------------------------------------------------------------------- bbe54867f3 | hellmonk | 2021-02-03 20:03:27 +0200 Gently nerf spriggans Since they're the most likely to get out of control with stepdown removals, they lose 1 base dex and 1 dodging apt. [ Comitter's note: Closes #1715. Reformatted commit messages ] -------------------------------------------------------------------------------- 24d3c0a44a | hellmonk | 2021-02-03 20:03:27 +0200 Remove the EV stepdown This was an extremely hidden mechanic and I suspect that most players didn't know about it. No change for "natural" evasion 30 or less, which is everything except high dodging high dex characters and spriggans in practice. -------------------------------------------------------------------------------- 6fe205ebb7 | hellmonk | 2021-02-03 20:03:27 +0200 Remove the dex stepdown This commit removes the hidden stepdown to bonus EV from dodging. No change for characters with 18 dex or less, but high dex characters will receive better returns on dodging skill. -------------------------------------------------------------------------------- cd1b0857f5 | Alex Jurkiewicz | 2021-02-03 20:03:27 +0200 Simplify strength damage modifier Previously, the strength damage modifier had three forms depending on your strength, from 0-9, 10, and 11+. The formulas were almost but not quite the same, damage growth was fastest in the 0-9 range with +7.6% per str compared to +5.12% per str in the 11+ range. (Note: these +% figures are the max increase, since the algorithm includes random2 the average increase is about half the quoted numbers.) The way this formula changes based on strength isn't great because either: 1) If it should affect attribute increase choices, it's a non-continuous breakpoint and therefore spoilery. 2) If it's too subtle to change attribute increase choices it's probably pointless. Change the damage modifier calculation to use a single continuous formula for all strength values. Rather than bothering with randomising the multiplier each attack, use a non-random formula suggested by advil. Strength modification is 100% at 10 strength, with +2.5% for each additional point of strength (-2.5% for each point below). Derandomizing the formula reduces the variance of melee combat slightly (there are plenty of other factors that keep the rolls high variance), and reduces the maximum possible damage at high strength values. The new formula increases damage delt at very low strength slightly in absolute terms, since at low strength the damage for most typical weapons is low enough that percentage changes aren't very noticable. At very high strength the new formula doesn't exactly approximate the average benefit of the old formula (the extra .06 of a percentage point of bonus per strength point over 10 becomes noticable in absolute terms at around 40 strength). For typical strength values the average damage tracks to within the measurement error of fsim, and the reduction in maximum damage (used as a proxy for variance) is small (for example at most 1 point of damage for a war axe at each of 10, 15, 20, and 25 str). In exchange for this slight number shift, derandomization should make the effect of high strength easier to "feel" for players (at least those using high base damage weapons). [ Committer's note: Closes #581. Squashed and rebased, added commentary from fsim analysis. ] -------------------------------------------------------------------------------- 0525f28e48 | advil | 2021-02-03 13:01:41 -0500 Don't let tabbing throw nets with autofight_throw/nomove I'm not sure it's the best path to go down to keep adding small hard-coded exceptions like this, but this change brings nets in line with other quiver actions affected by 006ef2cfcc4; they won't be triggered by autofight commands that may fire the quiver. The biggest case where this matters is on a Gl start with one of the relevant options set. In a very small poll of players it seems like most people have been using autoinscriptions for this and don't want these commands to ever auto-shoot nets anyways. As with that previous commit, CMD_AUTOFIRE itself will still work. It's less clear what to do with other ammo starts where players may not want to tab-fire, e.g. poison darts, dispersal boomerangs. Autoinscribing `!Q` or `!f` is currently an option but that's very fiddly and more for advanced rc file users. -------------------------------------------------------------------------------- 7b68f31d6f | Nicholas Feinberg | 2021-02-03 09:25:33 -0800 Spawn OODs in swamp These were accidentally disabled (by default). Objstat suggests this will increase Swamp XP on average by about 5% (82k -> 86k), and will result in weaker monsters being replaced by an average of: - 0.6 tmons - 0.5 ghouls - 0.5 fenstrider witch - 0.4 spriggan air mage - 0.3 thorn hunter - 0.2 spriggan zerker This seems OK. If players die too much, we can do something else. -------------------------------------------------------------------------------- 486a53e333 | advil | 2021-02-03 09:25:29 -0500 Fix some locale issues with skill targets This commit (i) lets players enter numbers using the locale decimal separator in the skill menu (since atof needs this for parsing unless we were to override the numeric locale), and (ii) uses this separator instead of a hardcoded `.` in skill targets -- this is for consistency with the rest of the menu, which already does this. -------------------------------------------------------------------------------- 2708c90bdf | Nikolai Lavsky | 2021-02-03 13:40:43 +0200 Correct a change log entry The player is notified about the Zot clock when there are 1000 turns left. The notification schedule is in `_bezotting_level_in()`. -------------------------------------------------------------------------------- d447f0f5e7 | Edgar A. Bering IV | 2021-02-03 13:34:37 +0200 Checkwhite -------------------------------------------------------------------------------- a34dcf4e91 | Aliscans | 2021-02-03 13:09:30 +0200 Stop art-data.pl from rewriting files which haven't changed. Before writing to an output file, art-data.pl now reads the file, and only writes it if the new version is different. This should reduce the number of files make rebuilds when art-data.txt is changed. In particular, many files depend on art-enum.h, but this only stores the names and ID numbers of artefacts. -------------------------------------------------------------------------------- 74f53ef629 | advil | 2021-02-02 22:24:48 -0500 Update lightning scale description for Pa (u/tom_yum_soup) This is not a very flavorful description, but at least it's accurate. -------------------------------------------------------------------------------- 4e57ec5eb2 | Nicholas Feinberg | 2021-02-02 18:58:48 -0800 No treeporting into summoned trees (vt) This caused crashes, actually! -------------------------------------------------------------------------------- dc854216a7 | Nicholas Feinberg | 2021-02-02 18:22:45 -0800 Fix eleio tree-a-port (12478, gammafunk, Yermak) Don't let them go through glass. -------------------------------------------------------------------------------- 41607c7541 | Nicholas Feinberg | 2021-02-02 18:14:40 -0800 Fix manual display bug (12476) The relevant skill wouldn't be marked visible in your skills list until you reloaded the game. -------------------------------------------------------------------------------- 075faa5519 | advil | 2021-02-02 15:27:42 -0500 `channel` -> `*channel` on wucad mu to indicate that it is a passive effect. -------------------------------------------------------------------------------- b07c51db7e | advil | 2021-02-02 13:03:36 -0500 Reorder checkwhite and unbrace in CI Also, fix a checkwhite error that was showing up as an unbrace error in CI because of the order. -------------------------------------------------------------------------------- 0dd03a7ff8 | advil | 2021-02-02 12:41:32 -0500 Refactor targeting to minimize console redraws 38af612a8a cleaned up the direction chooser code-wise quite a bit, but it had unintended side-effects for console. In particular, after this commit, the entire window was fully cleared and redrawn on every keypress. This isn't very noticeable on local builds, but it is extremely heavy over ssh and can (especially with lower ping) cause bad flicker when targeting while playing online. (It also is going to have a non-trivial impact, in aggregate, on ttyrec size.) This commit refactors the widget wrapping so that most of the time a full screen redraw is not needed; only the parts of the view that need to be redrawn get redrawn, the message window is only redrawn if there are messages, and the sidebar is only redrawn when a full screen redraw is triggered (e.g. initially, or by opening and closing the help window). This code may or may not be a bit hacky relative to more normal Widget classes. This should involve no change for local tiles. However, as far as I can tell the new OverlayWidget class works fine in local tiles, if doing all this redrawing were to be a problem there. Should also not impact webtiles targeting. -------------------------------------------------------------------------------- e0fc76b88b | Nicholas Feinberg | 2021-02-01 17:37:22 -0800 Don't let phantoms blink away from formicids You can't dance without a partner. -------------------------------------------------------------------------------- ee7b36d103 | Nicholas Feinberg | 2021-02-01 17:34:09 -0800 Display meph chance on targeter Some code duplication here, but whaddya gonna do. -------------------------------------------------------------------------------- 0dbb1cdb06 | Nicholas Feinberg | 2021-02-01 17:18:40 -0800 Refactor targeter desc code -------------------------------------------------------------------------------- d744f4be51 | Nicholas Feinberg | 2021-02-01 17:10:45 -0800 Rename mr to wl In a single variable name. -------------------------------------------------------------------------------- 48b565bfe2 | Nicholas Feinberg | 2021-02-01 17:08:50 -0800 Refactor dazzle chance To avoid drift between the targeter and the effect. -------------------------------------------------------------------------------- 52650a7530 | Edgar A. Bering IV | 2021-02-01 23:51:49 +0200 Correctly describe stair behavior of durable summons These have always been able to use stairs, but at some point describe.cc lost the memo. Closes #1618 -------------------------------------------------------------------------------- 54cb51f372 | Edgar A. Bering IV | 2021-02-01 23:51:49 +0200 Mark monster equipment as "SEEN" after we id it This affects note-taking only, as set_ident_flags doesn't care about seen for item knwoledge. Closes #1580. -------------------------------------------------------------------------------- 3ba7187429 | Edgar A. Bering IV | 2021-02-01 23:51:49 +0200 Defer a terrain check for rampage Only check for passable terrain for cells that don't contain our rampage target, so that monsters in impassible terrain can still be rampaged at if they're adjacent to a safe square for the player. Closes #1632 -------------------------------------------------------------------------------- 56efc2da1b | Edgar A. Bering IV | 2021-02-01 23:51:49 +0200 Restore a bit of smarts to autoexplore (Aliscans) Since possibly a long time (I didn't archaeology) autoexplore has had a non-executing guard against moving adjacent to unknown territory when it doesn't have to. This commit restores the check. Closes #1595 -------------------------------------------------------------------------------- b03138de70 | Edgar A. Bering IV | 2021-02-01 23:51:49 +0200 Properly initialize configurable dirs Options.shared_dir is the storage location for a build-condfigured SHARED_DIR_PATH option, and otherwise is a synonym for Options.save_dir (which has sane defaults and is forced to the configured global default in DGAMELAUNCH builds); However, it only gets correctly set to Options.save_dir after the call to Options.reset_options for the second load of the user's rc file after game start. Consequently, the High Scores display doesn't respect Options.save_dir, even though the main menu otherwise does. This commit implements some custom handling for save_dir to behave correctly on builds without customization. Closes #1694 -------------------------------------------------------------------------------- 9234712022 | Edgar A. Bering IV | 2021-02-01 23:51:49 +0200 Remove ball lightning from arena sprint Closes #1713 -------------------------------------------------------------------------------- 9b2ddefb56 | advil | 2021-02-01 13:57:52 -0500 Restore 0.24 console map scrolling behavior In 2fe5a39f5e4 code that was only used to initialize the map view, prior to the commit, was converted to set the region and cursor position on every render. The result was a change in behavior, where previously scrolling only moved the viewport when it hit the edges of the map, after this commit it effectively scrolled the viewpoint on any movement on big enough maps, keeping the cursor in the center. It's possible this was even intentional, not sure, because the new behavior resembled what happens in local tiles and webtiles in the map view (this would at least make it easy to miss relative to non-console map view). However, this behavior is not a good fit for the console map view; The map changing on any movement of the cursor is (IMO) much harder for the user to process than just changing the cursor position, and the required full-screen redraw every step is slower over ssh. (To be clear, I actually think this first point applies to the other two UIs as well, but one step at a time.) This commit restores the 0.24 behavior with (what I think is) a small improvement: scrolling within a few squares of the edge rather than at the edge will trigger movement of the viewport on the map, always keeping a 3 tile margin. (0.24 and earlier scrolled at the edge.) -------------------------------------------------------------------------------- b15c29f0ac | Nicholas Feinberg | 2021-02-01 08:48:23 -0800 Goldify manuals Move manuals from the inventory to being automatically applied to skills after pickup, somewhat similarly to spellbooks. (There weren't any interesting decisions about holding manuals vs consumables.) This also makes them useful for gnolls again, because the UI hassle is gone and because getting different skill titles is fun. -------------------------------------------------------------------------------- 6b030e5e4e | Nicholas Feinberg | 2021-02-01 07:55:01 -0800 Don't auto-exclude summoned spires -------------------------------------------------------------------------------- 4d1656c070 | Alex Jurkiewicz | 2021-02-01 10:04:33 +0200 Migrate to actions/cache v2 (was v1) No breaking changes. Several minor improvements to performance. Will hopefully reduce incidence of spurious errors. -------------------------------------------------------------------------------- 3bf7917939 | wheals | 2021-02-01 09:18:47 +0200 Fix the prompts on the Q/Q* menus -------------------------------------------------------------------------------- 47d50fa972 | wheals | 2021-02-01 09:18:47 +0200 Don't print the menu prompt in the message port This applies to all auto_list menus (i.e., all of them but the second part of the adjust items prompt). This is more consistent with the q, r, etc. menus which already didn't print a prompt outside the menu itself. -------------------------------------------------------------------------------- 7d305d30b1 | wheals | 2021-02-01 09:18:47 +0200 Add a missing space -------------------------------------------------------------------------------- 95f23adaf7 | wheals | 2021-02-01 09:18:47 +0200 "throw a tremorstone" -> "release a tremorstone" "Throw" seems like an odd term both flavor-wise and mechanically. It made sense when the evokable was targeted, but now is inconsistent with throwing any other item, which lets you target. -------------------------------------------------------------------------------- e082b6e869 | advil | 2021-01-31 12:41:52 -0500 Adjust some empty quiver cycle messaging This gets rid of the vestiges of oldquiver error messages, and rewrites things to use the newquiver code in a more straightforward way. This removes some of the hints that the old errors gave about inscriptions etc, but I think the simplification her targets everything that will be likely to apply to newer players who need the hints in the first place. -------------------------------------------------------------------------------- 967dceb2f5 | Nicholas Feinberg | 2021-01-31 09:05:59 -0800 Fix monster magic 2ee872d4bda only fixed one of the two cases where the magic resistance (now willpower) string appears in monster. -------------------------------------------------------------------------------- 39035a7bb1 | Nicholas Feinberg | 2021-01-31 09:03:24 -0800 Rejigger phantoms Phantoms are well known for being notorious time-wasters. They blink frequently, which makes it very easy to escape them, but very hard to kill them. They're not very fun! This commit removes their Blink spell and replaces their AF_BLINK melee attack with AF_BLINK_WITH, which transports the target along with the victim. Since this interacts very badly with Haunt, phantoms have been removed from that summon set. Along with the recent removal of hungry ghosts, Haunt's monster set has gotten significantly more consistent - someone should probably take a look at that and see if any compensating changes are needed to weaken it. This commit also drops phantom HP by about 30%, to bring their defenses more in line with other threats in the same area like iguanas and ogres. -------------------------------------------------------------------------------- 290af4607b | Nicholas Feinberg | 2021-01-31 09:03:24 -0800 Fix attack flavour descriptions Fix a compiler warning in util/monster and remove support for removed flavours. -------------------------------------------------------------------------------- e4214ee863 | advil | 2021-01-31 10:03:10 -0500 Fix =f,=F,!Q inscriptions The behavior of =f/=F was unintentionally flipped, and also broken for ammo items in another way I think. !Q hasn't been working for a while; I think this was broken by moving quiver selection away from an inventory menu. Here I have slightly changed the behavior, by making !Q entail =f and =F, and therefore be a quick shortcut for "really don't ever quiver this thing". -------------------------------------------------------------------------------- 29c5ad5b46 | advil | 2021-01-31 10:03:10 -0500 Don't use fire_order for Q menu inclusion This affected only ammo, and was more confusing than helpful. A better candidate for the menu itself (tbd) might be something more like the spell library hide/show feature. -------------------------------------------------------------------------------- cee7053d2b | Josh Gelbard | 2021-01-31 11:19:22 +0200 Don't try to spawn spiny frogs in arena sprint -------------------------------------------------------------------------------- 1fbed8a51c | advil | 2021-01-30 22:05:34 -0500 Improve some comments re ability ranges when quivered -------------------------------------------------------------------------------- 68775813e2 | wheals | 2021-01-30 23:56:06 +0200 Remove armour corpses Fixes the mon-data test -------------------------------------------------------------------------------- 539a43b7bd | advil | 2021-01-30 16:10:01 -0500 Add a better UI range check for minor destruction (12451) Minor destruction did not have a range check except on activation, leading to bad behavior with autofight_throw=true when quivered. This commit follows the same strategy in 0579ed41f9 for rolling charge. The background problem is that the ability API is still somewhat impoverished, and we don't want to fully disable the ability with no enemy in range (because there is no way to force-activate it equivalent to casting `Z`). However, for quiver and autofight purposes the quivered ability needs to be marked as disabled in this scenario. Eventually it would be nice if spells and abilities had a more uniform interface for these issues. -------------------------------------------------------------------------------- 610fdbd41d | Nicholas Feinberg | 2021-01-30 12:27:24 -0800 Remove unused params (geekosaur) -------------------------------------------------------------------------------- 7a72b21653 | Nicholas Feinberg | 2021-01-30 12:19:49 -0800 Re-remove hyperactive ballistomycetes (lici) Removed in 7da3b9efa77 the first time. -------------------------------------------------------------------------------- 989026e53a | Nicholas Feinberg | 2021-01-30 12:15:11 -0800 New spell: Animate Armour L4 Earth/Summoning. Call forth the spirit of your armour, bringing forth a slow-moving ally that hits harder the heavier your armour is. Casting this in robes creates a 40 HP, 4 AC ally that hits twice for 4 damage. In plate armour, you get a 40 HP, 20 AC ally that hits twice for 60 damage. Wham, pow! (Summon limit is 1, as with CCF.) The design goal here is to help provide some incentives for heavier armour characters to delve into spellcasting. Historically, spells like Haste and Phase Shift tempted players in this direction. Those spells had their own problems, but the 'hybrid' skilling they encouraged was fun. This spell will still be inappropriate for many characters, but if it brings a few 'melee' characters to dabble in spellcasting or 'caster' characters to put on heavier armour, I think that'll be great. Numbers are very much a first draft. I can easily imagine that the damage should scale differently or that HP should vary by armour type, for example. Many thanks to everyone who helped with this. Special thanks to hellmonk for balance suggestions, ebering for code and balance suggestions, mesh and rojja for German advice, and canine for the final name. -------------------------------------------------------------------------------- 22a811f1fd | Edgar A. Bering IV | 2021-01-30 21:02:08 +0200 Adjust a check for hazardous statuary Closes #1670. The want_move parameter would treat statues as one tile closer in i_feel_safe for travel purposes, even if there was a wall in the way. This resulted in an edge-case where the player would feel unsafe even though no hazard existed, see the related issue for an example. -------------------------------------------------------------------------------- 1a8b9f50bf | Edgar A. Bering IV | 2021-01-30 16:45:58 +0200 A bit more /charming renaming -------------------------------------------------------------------------------- 7879cab74d | Edgar A. Bering IV | 2021-01-30 16:29:03 +0200 Quote and description database cleanup Removing old and oudated translations -------------------------------------------------------------------------------- 2f42aecd5e | Edgar A. Bering IV | 2021-01-30 16:17:50 +0200 Further /charming rename (randomMesh) -------------------------------------------------------------------------------- 7ee54fca44 | Nicholas Feinberg | 2021-01-30 10:35:37 +0200 Remove harpies from Monstrous Menagerie Harpies caused several issues for Menagerie: - They weakened the mechanical identity of the spell. Menagerie stands out among other Summoning spells of a similar level for summoning primarily ranged allies, but harpies, of course, are melee fighters. - They confused players. The summon cap applies per-harpy-band, not per-harpy, but that's not at all obvious from the description or in-game. Plus, the number of harpies per band varies randomly, so how close are you to your summon limit at any given time? It takes some tracking! - They exacerbated weird spellpower behaviours. Harpies were generally the strongest result you could get from the spell, better than the notionally-higher-level sphinxes, so it wasn't really much of a plus to increase your spellpower as you'd hope. Not great incentives! This change should, hopefully, preserve the distinctiveness and power of this lovely classic spell. -------------------------------------------------------------------------------- d326f4184a | Edgar A. Bering IV | 2021-01-30 10:30:17 +0200 Silence a warning -------------------------------------------------------------------------------- 0e2341561c | Nicholas Feinberg | 2021-01-30 09:45:27 +0200 Rename wands of enslavement to charming Now that the charms school is no more, we can re-use that pleasant and classic name (of D&D fame) for this classic wand. -------------------------------------------------------------------------------- d48b2df3c9 | Kate | 2021-01-30 00:37:40 +0000 Reword DS magic regen mutation The old message no longer made sense with it being the first mutation of the facet. -------------------------------------------------------------------------------- dcb3803577 | advil | 2021-01-29 16:39:40 -0500 Halve the impact of map scaling on glyph mode Because the base value (e.g. the text size at 100) is so much smaller than regular tiles, zooming out from 100 has an outsized impact. An alternative to this commit would have been to change the default map mode scale value to something less zoomed out, but doing things this way also correctly handles the case where a glyph mode player is spectating a tiles player at the regular zoom levels. -------------------------------------------------------------------------------- d047dbe480 | Edgar A. Bering IV | 2021-01-29 14:26:02 +0200 Don't crash on randbook Wn start (12470) -------------------------------------------------------------------------------- 8ba017916c | advil | 2021-01-28 19:02:17 -0500 Limit printable keycodes in webtiles to ASCII This was (I think) impacting non-US keyboards, where keycodes corresponding to invalid UTF-8 were causing the webserver to choke, and the macro menu not to get forwarded to the client (keycode 169, which *may* result from a closing paren on AZERTY, is one example). It possibly also affects some unusual keys on certain keyboards. There must be a more elegant solution but for now this will just show the keycode directly in the macro menu. Better would be to somehow figure what keys are involved, and print their names, but this seems a bit of a hopeless task for webtiles. It's possible that console needs a similar fix as well, but there (at least in my testing) the result is not that the menu fails altogether -- though it's not very usable. But this would be better tested by someone with a different locale / keyboard layout. SDL should be handled by SDL code, so if it fails on this stuff, it's at least not a crawl bug. -------------------------------------------------------------------------------- dd83002478 | advil | 2021-01-28 19:02:17 -0500 Use a name for ' ' when a name is called for This is a printable char, but isn't apparent in most circumstances when it would be printed directly, so ' ' is not useful as the character description. Therefore, use "Space". Impacts only menu hotkeys, and probably only in the macro menu. -------------------------------------------------------------------------------- 1307ea1511 | AdamPG | 2021-01-28 23:15:45 +0200 Add prompts to various types of movement This commit adds a prompt to several forms of movement that previously did not end Ozocubu's armour or frozen ramparts. This commit also adds barb damage and a prompt to several physically-flavoured forms of movement (such as barachian hop) that previously did not trigger barb damage, and removes braces that were made unnecessary by a previous commit. -------------------------------------------------------------------------------- 88da7fdab6 | AdamPG | 2021-01-28 23:15:45 +0200 Change the colour of the message displayed when frozen ramparts ends Currently, Ozocubu's armour uses the MSGCH_DURATION colour (blue) and frozen ramparts uses the default colour (white) upon ending. This commit makes these messages consistent. -------------------------------------------------------------------------------- 8403051451 | AdamPG | 2021-01-28 23:15:45 +0200 Make icy spells end whenever the player's position changes Currently, many forms of movement (such as barachian's hop, Uskayaw's line pass and all forms of blinking) do not break frozen ramparts or Ozocubu's armour. Since the location of frozen ramparts is tied to the player's position at the time of casting, any change to the player's position should break the spell. Arguably Ozocubu's armour should break only for voluntary movement, as the effect is not tied to the player's initial position, but for consistency we make it break under the same conditions as frozen ramparts. -------------------------------------------------------------------------------- f34d913ce3 | Kate | 2021-01-28 20:35:44 +0000 Remove unused code -------------------------------------------------------------------------------- da3435bf36 | Kate | 2021-01-28 19:59:30 +0000 Upgrade the sceptre of Asmodeus Considering that it requires killing Asmodeus to get hold of (and the summons always turn hostile with no easy abjuration), it seems fine to just give it a straight upgrade to match Asmodeus's new summon list. -------------------------------------------------------------------------------- ac52ab2824 | Kate | 2021-01-28 19:38:36 +0000 Reword a Wyrmbane message The joke on-equip message for draconians wasn't a very good one. -------------------------------------------------------------------------------- cd1702ac4d | Edgar A. Bering IV | 2021-01-28 21:23:15 +0200 Downweight a Lugonu altar vault This altar vault has a very large place range, and so was appearing quite frequently (I didn't run mapstat, but it was in 1/3rd of my tournament games!). Lower the weight so it doesn't get old. -------------------------------------------------------------------------------- fb5ce4e607 | Edgar A. Bering IV | 2021-01-28 20:02:56 +0200 A tile for dread liches A recolour of ancient liches to give them spiffy magenta robes instead of blue. -------------------------------------------------------------------------------- 3b45c41056 | Edgar A. Bering IV | 2021-01-28 20:02:56 +0200 Tiles for Deep Elf Zephyrmancers and Pyromancers Zephyrmancers just use the mage tile (which already had a blue robe), and Pyromancers are a red robe recolour. -------------------------------------------------------------------------------- 3d1ca0d2d8 | Edgar A. Bering IV | 2021-01-28 20:02:56 +0200 Simplify monster spellbook description code Now that monsters only have one spell book, we no longer need to infer their book from seen spells, which really simplifies a lot of the display. -------------------------------------------------------------------------------- 97bf95f3a4 | Edgar A. Bering IV | 2021-01-28 20:02:56 +0200 Split Deep Elf Mages into two monsters Deep Elf magi had 6 (!) spellbooks, intending to represent the four elemental schools, conjurations, and summonings. The most impactful of these books were the lightning bolt book and the fire book; the other elemental schools are represented in various ways by other elf monsters. This commit creates two new monsters: deep elf pyromancer and deep elf zephyrmancer, to carry the fire and air books repsectively. Both have the same stats. Additionally, this moves the console glyphs around (since 'e') is a bit crowded; knights move to blue (matching naga warriors and Duvessa), pyromancers go on red (matching their elemental colour and Dowan), and zephyrmancers go on cyan (again an elemental colour match). The Dowan/Duvessa collision is a bit unfortunate, but they occur at different depths and with this convention they roughly mimic the behavior of their glyphmates. As with the lich split, I've split up the usage in various vaults, mostly balancing the weight. In the spawn tables I did similarly, except for dungeon, where pyromancers come earlier than zephyrmancers, and for abyss, where these lower elves are removed (they were very rare anyhow). -------------------------------------------------------------------------------- a69ff2a406 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 New Monster: Dread Lich (Name is TBD) To keep some more iconic Lich spells around in this single book world, the Dread Lich is the lich of demon summoning, with a book consisting of Haste, Summon Greater Demon, Paralyze, and Invisibility. Dread liches have the same stats as ancient liches, and appear in the same places. In vaults they either increased the total lich weight (where the vault seemed weak), or split weight with ancient liches, except in those cases when the vault designer seemd to specifically be using ancient liches in their summoner or their conjuror role. -------------------------------------------------------------------------------- 4c84cb8321 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 New Lich spellbook Liches and Ancient Liches have several iconic spells, conjurations, hexes, and summon greater demon (espeically notable on ancient liches who are tough enough to keep their demons around!). So many that making a single book that covers all of the roles leaves a book that steps on its own toes. This commit creates a conjurations focused spellbook for Liches and Ancient Liches consisting of Corrosive Bolt, LCS, Slow, Haste, and Invisibility; this is basically the old LCS book, but with Slow and Invis instead of Petrify. A subsequent commit will introduce a new 'L' monster to take up the summoning Lich role. -------------------------------------------------------------------------------- ff29be1aa7 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Replace Dispater's Summon Greater Demon With Summon Hell Sentinel. For the same reasons that Ereshkigal was changed to summon a specific demon, Dispater's call now goes only to the Hell Sentinels. -------------------------------------------------------------------------------- f4ffc1b5e2 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Replace Ereshkigal's Summon Greater Demon With Summon Tzitzimitl. SGD is a generic spell, and while it's maybe ok for a Pandemonium lord to call up whichever demons, the Hell lords should really only be calling flavorful demons, if any, since they're not lords of all demons! -------------------------------------------------------------------------------- ae91e92f12 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Change Cerbov's summon Summon Greater Demon is of course something a lord of Pandemonium should be able to do, but it seems a bit silly flavour-wise for the firey lord of Pandemonium to summon a blizzard demon. This replaces Cerebov's SGD with the buffed Fire Summon spell of Asmodeus, so he now only calls Balrugs, Hellions, and Brimstone Fiends. It's not completely clear that Cerebov even needs summons, since he's the Fire Storm monster, but summons do prevent a player from isolating the boss monster completely and Cerebov seems to work well with them, so let's try it. -------------------------------------------------------------------------------- 03f7137ab2 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Buff Asmodeus' Fire Summon Effreets and Sun demons aren't good threats at his depth, they're removed from the spawn table for the spell fire summon. -------------------------------------------------------------------------------- 61ce20c919 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Remove some demon summoning Demon summoning is overused on many monsters. Some could still use a summon, but a more flavorful specific summon. For neqoxecs and shadow demons, the summoning spell wasn't that notable. Shadow demons already mostly appear in places with demonic spawn lists, where shadow creatures will fetch plenty of demons; neqoxes demon summoning got in the way of their other line of fire spells and didn't enhance them much. -------------------------------------------------------------------------------- c6c22aa4fb | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Remove Bolt of Cold from tzitzimitls While there is a certain ammount of cold/undead theming, as a "fiend" type monster it'd be better if their spells didn't overlap with Ice Fiends. They still have plenty of tools to threaten a living rN+++ player character, and dispel undead for undead players. -------------------------------------------------------------------------------- fd204b979a | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Remove some Level 1 spells from high level monster books They don't do much other than add to cognitive load. Casting frequencies are a better way to adjust this sort of thing. -------------------------------------------------------------------------------- b39fecbb77 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Remove Twisted Resurrection This spell lived on in a rather meager twilight existence on some high tier elves. However, like other monster necromancy spells, it was rarely impactful: even when there were a large number of corpses they rarely could amalgamate together to make enough large abominations to threaten the player. -------------------------------------------------------------------------------- 760eeed2df | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Give Khufu Scarabs instead of Undead In line with the other Royal Mummy changes. -------------------------------------------------------------------------------- bc7614a589 | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Make most monsters single spellbook Monster spellbook variation was used for a mix of two reasons: flavour and threat variance akin to monster item use. Unlike monster items, which are easy to display in the UI, spell books are potentially long, so tracking which ogre mage on screen is the one with Paralysis was a serious UI screw which can't be quickly addressed by adding a HUD indicator. This UI screw plus cognitive load is not worth it: for most multi-book monsters the book variations lack enough focus to build flavour and are rather balanced in their threat levels. This commit changes every multi-book monster except deep elf mages and (ancient) liches to have a single book. Specific monsters and the reasoning behind their new books follow. The general guiding principle I've followed when assembling the new book is to try to follow the "feel" of the old book sets that a player would get if they weren't checking each monster's book carefully. Faun ---- The old Faun spellbooks were corona + another hex. There are a mix of Will checking threats in shoals, but often players arrive with lots of Will gear stacked up. Fauns show up in packs and their Corona+Hex book was designed to make them amplify other ambient ranged threats. The new book gives them Strip Willpower in place, for helping one another and other ambient monsters hex the player. New Faun book: - Corona - Strip Willpower Deep Elf Knight --------------- Deep Elf Knights had one book with Icicle, Haste, and Invisibility, and a second which had Stone Arrow, Force Lance, and Invisibility. The positional implications of Force Lance are great to keep around, so it's added to the rest of the first book. New Deep Elf Knight book: - Throw Icicle - Force Lance - Haste - Invisibility Orc Wizard ---------- Orc Wizards had three(!) distinct books, but their most iconic behavior was confusing the player and going invisible. This is book II, shared with Sigmund, and this is made into the single Orc Wizard book. New Orc Wizard book: - Magic Dart - Throw Flame - Confuse - Invisibility Blork ----- Blork the Orc used Orc Wizard book III, this is basiclly preserved but emergency invisibility is removed from the book since it was quite long. New Blork book: - Cantrip - Magic Dart - Throw Flame - Throw Frost - Haste Necromancer ----------- Necromancers had two books which differed only in the choice of bolt spell. In a large fight where Bind Souls has produced many simulacra, the player could hide from either bolt by using the simulacra to block LOF. The new book gives Necromancers Bolt of Draining, which works better with their mechanic. New Necromancer book: - Bolt of Draining - Agony Range - Bind Souls - Invisibility Wizard ------ Wizards' book assortment conveyed a mix of magics, to imply a mastery. Based on the D&D class as far as I can tell. To keep that flavor I picked a range of spells from their books that produced the same "mixed magic" feel. They share depth with Ogre Magi but don't come in packs, so I went with fireball and banishment here to differentiate the two spell sets. New Wizard book: - Fireball - Banishment - Blink - Invisibility Hell Knight ----------- Hell Knights are one of a couple of late game monsters that cast Pain, which at their depth isn't much of a threat even when it can beat the player's Will. Bolt of Fire is good for them, they can just use that. Perhaps blink should be made non-emergency, but because Hell Knights come in packs an injured HK blinking away to let a fresh one attack the player is a nice touch. New Hell Knight book: - Bolt of Fire - Blink (emergency) - Haste Ancient Champion ---------------- Another late game monster with Pain. Since they often come in bands with undead, retaining Bolt of Draining might be good but for now I went with short and sweet. New Ancient Champion book: - Iron Shot - Haste Royal Mummy ----------- Each of the four Royal Mummy books had Smite and Torment, the remaining mixed Summon Demon, Summon Undead, Summon Mana Viper, Summon Emperor Scorpions, and Summon Death Scarabs in some combination. Plain Summon Demon doesn't do much for RMs, Vipers are also quite fragile at the time Royal Mummies appear and vulnerable to torment, and Mummy Priests already summon undead. Scorpions are vulnerable to torment, so they're not the best here, but the flavour is good. Perhaps we could give emperor scorps rTorm. This is the old Book IV, which has the strongest Mummy flavour. New Royal Mummy book: - Smite - Symbol of Torment - Summon Emperor Scorpions - Summon Death Scarabs Ogre Mage --------- Ogre Mages typically come in packs with other Ogres and are notable for hasting them. Beyond that they have a sort of wizard flavour to their book set; this consolodation picks Bolt of Magma and Parlayse to round out the set to differentiate them from Wizards which appear at overlapping depth. New Ogre Mage book: - Bolt of Magma - Haste Other - Paralyse - Invisibility Tengu Conjurer -------------- The different Tengu spellcasters have a hodgepodge of "battlemage" spells. Flavour wise Tengu are supposed to be good at Conjurations and Air magic, so I settled on the air book from the four book choices. New Tengu Conjurer book: - Lightning Bolt - Battlesphere - Blink Tengu Reaver ------------ In keeping with the air theme (though less so conjurations), the new Tengu reaver book attempts to give them a pair of spells that force a player trying to melee them to reposition. The monster AI change when it comes to blocking ranged allies means that the reaver won't block its lightning spire if it can step aside, so this should interact well. It might need spell logic to prevent the reaver from summoning 10000 spires since monsters don't have summon caps, let's see how it plays. New Tengu Reaver book: - Freezing Cloud - Summon Lightning Spire -------------------------------------------------------------------------------- e00c81aa3c | Edgar A. Bering IV | 2021-01-28 20:02:55 +0200 Revamp Psyche's spellbook The Orc Wizard III book isn't that exciting. Psyche's defining characteristics as a unique are her dagger brand and chaos theme, so I've leaned into that. The new book is: Cantrip, Polymorph, Chain of Chaos, Invisibility. At Psyche's depth Chain of Chaos is rather scary, but can be mitigated by having other monsters around. Since she arrives at a depth where many characters won't have a ready source of allies, this puts pressure to engage Psyche with other hostiles around. Polymorph is also in the mix, partly to thin out the CoC terror with something chaotic in the casting weight, and partly because polymorph aimed at the player is a rather rare effect and a good "signature spell" for a chaos unique. -------------------------------------------------------------------------------- de412597e9 | Neil Moore | 2021-01-28 12:57:45 -0500 Slightly improve a citation. [skip ci] -------------------------------------------------------------------------------- d2cd6250da | Edgar A. Bering IV | 2021-01-28 11:39:54 +0200 Consistently indent quotes in quotes.txt Closes #1700 -------------------------------------------------------------------------------- 5b54ba61a2 | Edgar A. Bering IV | 2021-01-28 11:05:17 +0200 Fix some KJV citations -------------------------------------------------------------------------------- 8fd39cdef8 | Edgar A. Bering IV | 2021-01-28 10:57:32 +0200 Don't mark unkown books useless for gnolls Closes #1707 -------------------------------------------------------------------------------- 607d9e9d85 | Nicholas Feinberg | 2021-01-27 18:57:25 -0800 Mention diggability on xv (hellmonk) -------------------------------------------------------------------------------- d3d0dda1a4 | AdamPG | 2021-01-28 00:15:29 +0200 Prevent Ozocubu's Armour from breaking when equipping heavier armour -------------------------------------------------------------------------------- a1f732d4ef | Goratrix | 2021-01-28 00:11:00 +0200 Replace travis build badge with github badge in README.md -------------------------------------------------------------------------------- 36043c2b5f | Edgar A. Bering IV | 2021-01-27 23:28:57 +0200 Adjust a misleading description (12374) -------------------------------------------------------------------------------- 13c09b7e0e | Edgar A. Bering IV | 2021-01-27 22:38:39 +0200 Remove an extra space (Yermak) -------------------------------------------------------------------------------- 1f8c70d38d | Edgar A. Bering IV | 2021-01-27 22:37:04 +0200 Remove an unused parameter and simplify -------------------------------------------------------------------------------- f9d094ba99 | Edgar A. Bering IV | 2021-01-27 22:03:50 +0200 Don't leak stash info with Gozag gold detection (12413) This makes gold detection work more like item detection, in that the detected gold does not appear in stash search as it did previously. This is a bit unfortunate, but this is the lone edge-case remaining where a stash pile is revealed partially. It shows that the detected thing is gold versus an item for a gnoll on the map, which suffices. -------------------------------------------------------------------------------- e9b1cf51b5 | Edgar A. Bering IV | 2021-01-27 21:21:54 +0200 Don't hide Bows for one hand-paired ants -------------------------------------------------------------------------------- 78287705fb | Edgar A. Bering IV | 2021-01-27 20:59:54 +0200 Hide Bows when a hand is sacrificed (12398) -------------------------------------------------------------------------------- bd0f0ea6ff | Edgar A. Bering IV | 2021-01-27 20:22:48 +0200 Make manuals useless for gnolls Gnolls inability to focus skills makes manuals last an inordinate amount of time, and also create weird incentives around manipulating acquirement results versus getting technical advantages. The lore says they can't focus, so let's extend that to focusing on whats on the page in a manual and make them useless. -------------------------------------------------------------------------------- 66c4918636 | Edgar A. Bering IV | 2021-01-27 20:03:31 +0200 Remove an inappropriate sanctuary check -------------------------------------------------------------------------------- 0faeb86a01 | Edgar A. Bering IV | 2021-01-27 19:50:05 +0200 Don't look for clouds in the wrong places (12459) -------------------------------------------------------------------------------- 36630e8e57 | Nicholas Feinberg | 2021-01-27 07:42:46 -0800 Partially restore monster ranged AI Due to a misreading, 4e0205b1fca8 removed the chance for monsters with ranged weapons to do something with their turn other than shoot their target. Oops! The new logic is: - Master archers (e.g. deep elf master archers, merfolk javelineers) have a 90% chance to shoot. - Non-master-archers with ranged weapons have an 80% chance to shoot. - Non-master-archers with throwing weapons have a 33% chance to shoot. This should get us back roughly where we were before, but with less throwing than after the infinite ammo change. -------------------------------------------------------------------------------- 832131d6ac | Edgar A. Bering IV | 2021-01-27 09:43:04 +0200 Make trove entries transparent -------------------------------------------------------------------------------- bcd94eb011 | Nicholas Feinberg | 2021-01-26 22:07:12 -0800 Remove banana bunyips (hatsuma) The end of an era... -------------------------------------------------------------------------------- 177a798329 | Nicholas Feinberg | 2021-01-26 21:52:33 -0800 Make monsters less throw-happy Similar to wand logic, make monsters with throwing weapons only use them some of the time. Instead of throwing every single turn while not in melee, now they'll only throw their held item at you 1/3 turns. Master archers (e.g. merfolk javelineers) and enemies with actual launchers (e.g. centaurs) are exempted. -------------------------------------------------------------------------------- 4e0205b1fc | Nicholas Feinberg | 2021-01-26 21:45:30 -0800 Simplify monster throwing/launcher AI Remove very complex and fairly pointless interactions with Leda's Liquefication. That spell is not nearly powerful enough to require making the AI play around it intelligently! The player should be allowed to feel smart and to take advantage of dumb monsters with their expensive situational spell! -------------------------------------------------------------------------------- cb3516073f | Nicholas Feinberg | 2021-01-26 21:37:48 -0800 Don't summon demonic guardians from poison Placeholder until/unless a cleverer approach is found. -------------------------------------------------------------------------------- 6fc33f2424 | advil | 2021-01-26 20:15:49 -0500 Don't do zone filling in the abyss Unlike normal builder scenarios, connectivity checks are only rarely triggered in the abyss, by the placement of a minivault it seems. (I'm surprised they happen at all, and wonder what they accomplish.) In this case, it seems wrong to do any fills, as the abyss is supposed to allow temporarily disconnected zones. In mantis 12442, 12416, as well as #1680, it was reported that this scenario could lead to errors, because the fill code assumed that no items had been placed yet. As far as I know this is mostly true, just not for the abyss, which does most of its building before minivaults have the chance to place. I've also added a guard against filling over items, even though the main fix in this commit prevents the specific case from coming up. Interfering items just get nuked, to prevent vetos. Resolves #1680. -------------------------------------------------------------------------------- 9286b66fa0 | Edgar A. Bering IV | 2021-01-26 22:43:02 +0200 Sort the book of Ice -------------------------------------------------------------------------------- 4a2642d2bd | Edgar A. Bering IV | 2021-01-26 22:25:08 +0200 Don't print resist messages when casting Ozocubu's refridgeration Closes #1693 -------------------------------------------------------------------------------- 562fce5957 | Edgar A. Bering IV | 2021-01-26 22:21:24 +0200 Increase the level of Ozo's fridge to 7 The changes to remove self-damage and the damage formula for Ozo's led to a very strong spell. While nerfing the spell damage is also a possible route here, Ice magic currently has no level 7 or 8 spells, so let's try the level bump as a balance knob. -------------------------------------------------------------------------------- 9515ab555c | Nicholas Feinberg | 2021-01-25 22:25:20 -0800 Fix the build? This code is extremely bad! -------------------------------------------------------------------------------- da0e56a6ef | Nicholas Feinberg | 2021-01-25 20:39:53 -0800 Bring Hellbinding back By popular demand, make evil god-following summoners use the old titles. -------------------------------------------------------------------------------- d3d65450af | Nicholas Feinberg | 2021-01-25 19:15:24 -0800 Integrate palentonga sprites And add new palentonga lichform and 8form sprites. Cloaks look sort of awful here, but not sure what can be done! -------------------------------------------------------------------------------- 2a9d61b3d9 | Hatsuma | 2021-01-25 19:15:22 -0800 donger sprites -------------------------------------------------------------------------------- b7e3dba119 | Nicholas Feinberg | 2021-01-25 17:20:47 -0800 Remove item destruction (minmay) Don't make fleeing enemies use scrolls of teleportation or blinking. It doesn't create interesting tactical situations or decisions, and it does cause annoyances and strange incentives for spoilered players. -------------------------------------------------------------------------------- 7528ca199a | Nicholas Feinberg | 2021-01-25 17:12:58 -0800 Mostly remove stone giants from Orc:2 Way, way, way too nasty compared to literally everything else. Orcs should be the star of the show in Orc, imo, not some silly giants! They can still spawn as OODs or in vaults. It looks like empirically they'll show up about 40% as often as before. At some point I should go over these spawn tables more thoroughly... -------------------------------------------------------------------------------- 6522fa7714 | Nicholas Feinberg | 2021-01-25 17:07:21 -0800 Revert "Add a trunk reminder for the 0.26 tournament" This reverts commit 4bfc8a49e17f9a62c58050e8347afbcd08fc21f7. So long, t0.26! -------------------------------------------------------------------------------- 0b64aa269c | Edgar A. Bering IV | 2021-01-26 00:44:09 +0200 Adjust and derandomize shield delay penalty The old formula was approximately an extra min(1d adjusted shield penalty, 1d adjusted shield penalty) delay. However, this was calculated at a scale of 20 to allow die with penalty less than 1, since for a human-sized player the adjusted shield penalty of a buckler at 0 skill is 1. With scaling, the formula was: min ( 1 d (20 * penalty), 1 d (20 * penalty) ) / 20 randomly rounded. As a result, at 0 skill a buckler did not have a delay penalty of 0.1, but in practice was something that was 0 with a pretty high probability. To get a very good chance of a delay penalty of 0, 7 skill was sufficient for a kite shield, and 12 for a tower shield. 7 skill costs a human 1,400 skill points; 12 skill costs a human 4,200 skill points. 2 hand maces (excluding dire flails), pole arms, and swords, all require 20 skill (or more) for min-delay; at the probability of penalty achieved for the above shield skill values, this is a better comparison point than the skill required for min+0.1 delay. 20 weapon skill costs 13,950 skill points, compared to 9,600 for 16 skill and the 7 shield skill; the difference in base damage is not sufficient compensation for enough skill points to raise a 0-apt skill to 10! This commit changes the formula to something less random and stiffer, namely: random_round(penalty) At 0 skill, a buckler has a flat constant delay penalty of 0.1, eliminated at 4 skill. At 10 skill a kite shield gives a delay penalty of exactly 0.1, and the old probability is achieved at a skill level between 14 and 15. To get a delay penalty of 0.1 with a tower shield, 20 skill is required. With these skill training targets, achieving a delay of min+0.1 for a 16 skill 1-hander while using a kite shield costs 11,000 skill points, compared to the 10,800 skill points for 18 skill to get the same swing speed with a 20 skill 2-hander. For min-delay, the 16 skill 1-hander + kite costs 15,250, compared to 13,950 for a 20 skill 2-hander. This is a better alignment of strategic costs, which will hopefully make the "1h vs 2h" a more interesting strategic decision based on game context. The increase to broad axe delay in 81720017eb when combined with this change might make broad axes too expensive; that is easily fixed if it turns out to be the case. -------------------------------------------------------------------------------- aa1b0a69e5 | wheals | 2021-01-25 12:16:27 +0200 Fix the build (doh) -------------------------------------------------------------------------------- 8898b9ca26 | wheals | 2021-01-25 11:51:24 +0200 Clarify a parameter name -------------------------------------------------------------------------------- a59c3b2a1c | wheals | 2021-01-25 11:51:24 +0200 Clarify that malevolent magic applies only to wands (kate-) -------------------------------------------------------------------------------- ef21787582 | hellmonk | 2021-01-25 11:51:24 +0200 Properly handle elemental and cloud producing facets. These mutations are meant to exclude each other so that the player gets at most one elemental and at most one cloud facet. Formerly, this took advantage of mutations with a single mutlevel to handle the check, but that doesn't work anymore. This is as quick and dirty a fix as I could manage, since I plan on looking at this again for the tier 3 mut pr. -------------------------------------------------------------------------------- b44e02ef28 | hellmonk | 2021-01-25 11:51:24 +0200 New tier 2 demonspawn facet, malevolent magic. When a demonspawn with this facet casts a spell, they also try to paralyze enemies in a radius equal to the mutation level around them. The effect's power increases with spell level and checks magic resistance, and evocables will also trigger the effect once the player reaches the final rank of the facet. With luck, this should encourage some interesting spell positioning and use (without encouraging players to use very low level spells exclusively for the proc chance too much). Rank 3 includes evocables so it isn't a completely worthless facet for berserkers. I think it probably feels too bad to lose an entire T2 facet for a choice made at game start. Aside from that, there are lots of balance knobs that can be tweaked. I'm very unsure of how good the effect ends up being across a full game, but it's very simple to adjust the paralysis power or duration, or the effect radius, if necessary. The flavor's kind of thin, too, so feel free to change that. -------------------------------------------------------------------------------- afa7a0f0fe | hellmonk | 2021-01-25 11:51:24 +0200 Adjust the icemail facet. While the icemail itself was very cool and powerful, the previous two ranks of the facet were relatively boring, and freezing cloud immunity was an especially odd choice given that the facet did not create clouds. This rework splits icemail in half across ranks 2 and 3 of the facet and reduces the total AC to 8. A new mutation, Condensation Shield, is added for the first rank, providing 4 SH that dissipates under the same conditions as icemail. This should keep the facet's role relatively intact without buffing it too much lategame; total defenses provided are 4 SH and 8 AC at rank 3. Because the monster enchantment for icemail also uses ICEMAIL_MAX, I buffed gelid demonspawn base AC by 2 to compensate for their reduced icemail AC. -------------------------------------------------------------------------------- 5cca49f90c | hellmonk | 2021-01-25 11:51:24 +0200 Remove convection. Don't melt icemail or ozocubu's armour when flying over lava. This incredibly niche interaction was, as far as I can tell, the only non-damage source that melted icy enchantments. There's not really a compelling gameplay reason for it to do that. -------------------------------------------------------------------------------- eb50e5d1e3 | hellmonk | 2021-01-25 11:51:24 +0200 Revisit the spiny damage formula. It's not worth making the formula that much more complicated. Here is a simpler one that should still be acceptable earlygame and is slightly worse at high experience levels. -------------------------------------------------------------------------------- 5fc36510a5 | hellmonk | 2021-01-25 11:51:24 +0200 Rework Demonic Guardian. Previously, this facet used an extremely bad tension formula to determine whether or not to summon a guardian. It also had a unique time schedule that practically guaranteed the first rank of the mutation very early and usually pushed the second and third ranks very late. The result was an easily gamed mutation that turbo stomped early dungeon and then kept summoning imps until vaults or later. This rework ignores tension altogether; instead, the mutation has a chance to activate whenever the player takes damage (guaranteed if the damage is greater than half max hp or if the player's health is critically low) and summons a demon whose tier is partially based on experience level. The variety of potential guardians is expanded a bit as well. Finally, the time schedule is brought into line with every other tier two facet in the game. -------------------------------------------------------------------------------- 9e10844823 | hellmonk | 2021-01-25 11:51:24 +0200 Rework Ignite Blood. The third rank of the ignite blood facet is very cool, but the first two ranks are boring. Split the power of the actual blood igniting part over all three ranks of the facet - an increasing chance to ignite blood and longer duration flame clouds with each rank. Any rank of ignite blood also confers flame cloud immunity, since that's kind of necessary to use the mutation. -------------------------------------------------------------------------------- 93b95dc60d | hellmonk | 2021-01-25 11:51:24 +0200 Rework Spiny. The previous spiny rework scaled its damage heavily with xl to reduce earlygame damage. While that change was well-intentioned, it made spiny 2 and 3 feel underwhelming. This commit puts a little power back into the upper mutation levels and reduces the level scaling somewhat, at the expense of making the formula messier. -------------------------------------------------------------------------------- 7c3aafa790 | hellmonk | 2021-01-25 11:49:40 +0200 Rework the foul stench facet. This facet had a notoriously useless-on-receipt rank 1 mutation and some very strange mechanics under the hood. This commit takes the rrot mutation out of the facet. The facet will now provide foul stench at every rank, with activation chances rescaled accordingly. Since the player needs to be immune to their own clouds, any rank of foul stench confers rot immunity. The facet no longer makes attackers sick and can now place miasma on any attack that deals damage, not just ones that hit for more than 4 dam. [committer's note: rrot was removed in the meantime anyway, so substitute "miasma immunity" for "rot immunity/rrot".] -------------------------------------------------------------------------------- 2d7ca500d8 | hellmonk | 2021-01-25 11:43:15 +0200 Reorder the mana link facet. Provide boosted mp regeneration first, when it's most likely to matter, then give spirit shield second. Mp regen earlier might make it more useful as mp regen rather than as pseudo hp-regen, though overall the change should be and is intended to be a nerf. The third rank of this facet still leaves something to be desired and has a bad interaction with posion damage (specifically, can kill the player at "safe" levels of poison by redirecting their hp regen), but cannot be moved before spirit shield for obvious reasons. I hesitate to replace it with either additional mp regen or a mana vamp effect because that gives this facet even more overlap with other regen boosting facets. Someone should make gspirit work on poison damage, but that is out of scope for this rework. -------------------------------------------------------------------------------- 8aa0e2c87f | wheals | 2021-01-25 11:42:59 +0200 The future -------------------------------------------------------------------------------- 405e40da7a | ukdong99 | 2021-01-25 11:09:43 +0200 Mark an assuary enterance as transparet 2 Resolves another vault which has the same issue in #1639 -------------------------------------------------------------------------------- 37ff1ca61a | Nicholas Feinberg | 2021-01-25 09:59:57 +0200 Remove Evocation scaling from Spectral Currently, the spectral brand is the most complex weapon ego in the game. It has two significant drawbacks: 1. It can significantly increase the damage the wielder takes, since the spectral weapon shares damage with the player. 2. It requires Evocations training to use. Both due to the overall complexity and the perceived weakness of this brand, I'm inclined to simplify by removing one of these effects. Pain sharing makes the brand a bit harder to evaluate, since most brands have no downside at all vs an unbranded weapon (chaos being the notable exception). Evocations scaling has several other problems, though: - It confuses players on a regular basis. People miss the subtle messages about 'ineptitude' and fail to understand why the spectral weapon isn't triggering - 'is it broken?' Some of them ask other players and get the confusion sorted out but others, presumably, just continue thinking it's bugged! - It's the only effect where Evocations training gives benefit to a passive effect, rather than an evocable item or ability. This isn't the end of the world, but it is an odd exception. - Evocations skill is currently very useful for most characters even without this - most games present a large number of powerful, Evocations-scaling items that strongly incentivize Evocations training. It's somewhere between unuseful and counterproductive to add one more. It's possible that the damage sharing effect should also go away or be reduced in magnitude - the downsides of "need to mess with positioning" and "don't have another brand" might be enough to balance spectral. We'll see! -------------------------------------------------------------------------------- 19cb506db8 | Nicholas Feinberg | 2021-01-24 18:19:12 -0800 Tweak summoning titles Now that the high-level demon summoning spells are gone, get rid of the summoning titles that referenced them in favor of the agnostic alternatives. -------------------------------------------------------------------------------- eb620a3345 | Nicholas Feinberg | 2021-01-24 18:19:12 -0800 Remove Summon Demon As with Summon Greater Demon (see previous commit, true believers!), there are quite a lot of summoning spells around level 5, and this is the only one that duplicates a Makhleb invocation. For the sake of fun choices and variety between games, let's send this one straight to Hell. -------------------------------------------------------------------------------- 58b3cc3132 | Nicholas Feinberg | 2021-01-24 14:00:43 -0800 Checkwhite -------------------------------------------------------------------------------- ed86a5fd00 | Nicholas Feinberg | 2021-01-24 13:54:03 -0800 Make nets finite again Too brutal to give gnolls infinite nets, probably. -------------------------------------------------------------------------------- d7dd4bcd53 | Nicholas Feinberg | 2021-01-24 13:53:23 -0800 Give monsters infinite ammo Don't allow running monsters out of ammo, and make their projectiles always mulch. Remove extremely spammy 'returning' boomerang animations from monsters. This is a buff to cyclopes and stone giants; we can nerf them again in various ways if it proves to be too much. -------------------------------------------------------------------------------- 68f98bdfd7 | Nicholas Feinberg | 2021-01-24 13:47:09 -0800 Retheme /disintegrate -> /mindburst Disintegration is a fun effect (everyone loves things blowing up), but it's always been a weird exception in certain ways. MR (now Will) was always the stat that resisted debilitating effects "plus Disintegrate", and there was never any real flavour justification for that. Why could you resist Disintegrate but not, say, Energy Bolt? It makes it hard for players to develop intuitions about what affects what. So let's retheme. Instead of an abstract Disintegration, Mindburst specifically launches a psychic attack on the target's brain, attempting to blow them apart from the inside. It should be a bit more intuitive why this is affected by Willpower (since it's a mental attack), and it still preserves all the explosive fun of the original. For the sake of intuition, the new Mindburst does *not* affect mindless creatures. This mostly shouldn't matter - there aren't that many mindless creatures that you wouldn't want to disintegrate anyway. (It might be a bit rough if you're up against an early centaur skeleton, maybe.) Great Orb of Eyes' Disintegrate spell has been changed to use Mindburst as well. -------------------------------------------------------------------------------- b3a650cb6a | Nicholas Feinberg | 2021-01-24 13:44:20 -0800 Increase Stone Arrow damage by 2 Stone Arrow's damage compares very poorly to other spells of the same level or below. Even compared to Sandblast, Stone Arrow (a level 3 spell) does similar or less damage against most monsters. Rocks aren't that high a cost! -------------------------------------------------------------------------------- ab96107f46 | Nicholas Feinberg | 2021-01-24 13:41:49 -0800 Reduce gnolls attributes to human The first several attempts at creating a gnoll species ended up making something that was both weak and unfun. When the modern gnoll was created (see d2df3b7b5 / 8a4a258fa7 ), they were pushed to be significantly stronger - and it worked! A bit too well, in fact. Gnolls are currently powerhouses from D:1 to Z:5. Let's pull them back a bit, reducing their strength, intelligence and dexterity to human baseline. I expect they'll still be quite strong, but perhaps just a notch less ridiculous. I'm not averse to weakening them further in future, but this seems like a simple way to start. -------------------------------------------------------------------------------- 19610a9a0c | Nicholas Feinberg | 2021-01-24 13:40:43 -0800 Un-de-enhance Scarf of Shadows spells Per the original commit (bf280b6766): This gives 1 spell de-enhancer, since reduced LOS is very strong and allows more spells to be in range at the edge of LOS. If that makes this item too weak it can be removed. The scarf of shadows effect is as strong or stronger for non-casting characters as for casters, which made it odd that only the latter were penalized for using it. Overall, after the scarf was changed to only reduce LOS by 1 instead of 2, the effect was usually not strong enough to justify both the loss of several AC (vs an enchanted cloak) *and* a spell de-enhancer. Removing the latter should help make this a more viable equipment choice. -------------------------------------------------------------------------------- ee1497a637 | Nicholas Feinberg | 2021-01-24 13:39:10 -0800 Show cloud damage for player spells This is experimental. It's weird in that it's sort of asymmetric with the monster versions (e.g. fire crab's flaming cloud), since those show the impact damage instead. Maybe it's helpful, though? -------------------------------------------------------------------------------- 3644e03777 | Nicholas Feinberg | 2021-01-24 13:38:18 -0800 Display accuracy on ranged targeters This was an oversight. Oops! -------------------------------------------------------------------------------- d412354acc | Nicholas Feinberg | 2021-01-24 13:37:37 -0800 Reduce net trap trigger chance Since making net traps not run out of ammo, they've become more vicious than was intended. To mitigate this, give them a 2/3 chance of *not* triggering when a monster enters them. It'd be interesting to make them require LoF to hit the player, but that's an experiment for another day. -------------------------------------------------------------------------------- f16e6d0322 | Nicholas Feinberg | 2021-01-24 13:34:21 -0800 Remove Summon Greater Demon There are 6 different level 7 Summoning spells: Summon Hydra, Monstrous Menagerie, Malign Gateway, Haunt, Spellforged Servitor, and Summon Greater Demon. As one might expect, there's considerable overlap between those. In the interest of providing players with meaningful, distinct choices, we generally prefer to limit overlap between spells. Summon Greater Demon closely duplicates a Makhleb invocation, reducing the distinctiveness of both effects. That puts it high on the chop list. In combination with the removal of the old aura of abjuration -> SGD synergy minigame, SGD seems like the best spell to cut. To keep book balance, Haunt moves from the Necronomicon to the Grand Grimoire. Now every high level book has 4 spells, which seems nice. -------------------------------------------------------------------------------- b6a8d6b5b3 | Nicholas Feinberg | 2021-01-24 13:31:28 -0800 Refactor further -------------------------------------------------------------------------------- e2d8f9ccf3 | Nicholas Feinberg | 2021-01-24 13:30:51 -0800 Rewrite LRD setup I believe the only functional change here should be that monsters won't directly LRD non-player enemies they can't see (which they probably couldn't anyway?), but there's lots of room for bugs in a change this big. -------------------------------------------------------------------------------- 416527ed24 | Nicholas Feinberg | 2021-01-23 11:51:41 -0800 No Marshlight out-of-sight messages (Yermak) -------------------------------------------------------------------------------- 4d92ddfd83 | Nicholas Feinberg | 2021-01-23 08:57:48 -0800 Display Glaciate damage on xv And remove support for player-cast Glaciate, since that's long-gone! -------------------------------------------------------------------------------- 2451fdf569 | Nicholas Feinberg | 2021-01-23 08:11:47 -0800 Make fenstriders evil (Snakku) Oversight - I was used to this being auto-set from spells! -------------------------------------------------------------------------------- 0bfbe0ea93 | Nicholas Feinberg | 2021-01-23 08:10:49 -0800 Add missing roll icon (hatsuma) -------------------------------------------------------------------------------- 96f8838c2c | Nicholas Feinberg | 2021-01-23 08:05:21 -0800 Fix death explosion messages Broken by 3dd439832fe0f5fe295caad1a2fe3e479a757cda - we'd claim that players were 'hit from afar by a bloated husk' instead of 'killed by an exploding bloated husk'. Oops! From that commit's final line: > Overall, this code is very bad and probably buggy. I'm sorry. -------------------------------------------------------------------------------- e71ae6e9b5 | gammafunk | 2021-01-23 07:43:00 -0600 Fix the depth of a ghost vault (Mantis 12464) In Dungeon it was only ever placing on D:8, instead of on its intended depth of D:8-D:$. -------------------------------------------------------------------------------- 6cd7b45605 | advil | 2021-01-21 12:41:38 -0500 Fix some error handling for lobby save info This info was collected asynchronously, but the code didn't do anything to handle the case where the socket closed before the save info was fully collected, leading to uncaught exceptions in the logs. -------------------------------------------------------------------------------- 12357ec85a | advil | 2021-01-21 11:29:45 -0500 Remove item_info This type was just a typedef to item_def. It was added in 8f49829c0752, apparently with the idea that item_info would be used for item_defs that represented id info, and item_def otherwise. However, this convention wasn't even documented, let alone enforced by an actual type distinction (and c++ never added a strict typedef), so it has undergone drift and largely now exists to confuse people. I could imagine redoing this so that the type checker will do something, but the id system is also much less important now than it was at the time of the original commit, so it seems cleaner just to simplify. -------------------------------------------------------------------------------- 3cb999cee2 | Andrew O'Neill | 2021-01-20 23:52:11 -0600 remove CMD_EAT from colemak This is no longer needed since eating is out. -------------------------------------------------------------------------------- f312352147 | advil | 2021-01-20 15:40:21 -0500 A bit of 288a49279187 that got lost in editing oops -------------------------------------------------------------------------------- a89a457576 | advil | 2021-01-20 15:26:35 -0500 Clean up logging for full socket buffer When holding down a key in webtiles for something that takes a long enough time to outpace the key repeat (either because it is cpu-intensive or just because it imposes a delay), the buffer used to communicate with the crawl instance can fill up, which triggers an exception (and drops the key). When this happens, it is quite spammy in logs on live servers. Ideally this could be prevented from happening in the first place (e.g. any time this can happen on autofight/autofire is a case that should be better optimized), but it will inevitably happen from time to time, and doesn't need to fill up the logs quite so much when it does; the stack trace is not informative. For future reference, the full stack trace for a single case of this will look something like (with minor differences between OSs): 2021-01-20 14:05:25,059 WARN: #0 Error while handling JSON message (''{"msg":"key","keycode":9}'')! Traceback (most recent call last): File "/Users/advil/repos/crawl/crawl-ref/source/webserver/ws_handler.py", line 869, in on_message self.process.handle_input(message) File "/Users/advil/repos/crawl/crawl-ref/source/webserver/process_handler.py", line 897, in handle_input self.conn.send_message(utf8(msg)) File "/Users/advil/repos/crawl/crawl-ref/source/webserver/connection.py", line 109, in send_message self.socket.sendto(utf8(data), self.crawl_socketpath) OSError: [Errno 55] No buffer space available -------------------------------------------------------------------------------- 288a492791 | advil | 2021-01-20 12:38:37 -0500 Reduce webtiles redraws per key input by 2 The previous behavior stems for a fairly old (729eb1357d24d1d5) decision to send a redraw on each input mode change. Since every keypress swaps between MOUSE_MODE_NORMAL and MOUSE_MODE_COMMAND, holding down a key could trigger a lot of unnecessary redraws, and for example with no ammo could max out the process's cpu usage (at least on a `make profile` build). I'm not actually sure why a webtiles redraw (which mainly send the map and the player) is needed on any case of changing input mode, but for now I'll be conservative -- and this is the case that shows up in profiling. As it happens, there's still at least one webtiles redraw per key input, in getch_ck. But, the profiling with just this one doesn't seem like a problem by itself. It's possible that redraw() itself has some issues that could be addressed -- sending both the player and the map equally eat up a lot of cpu with repeated calls. -------------------------------------------------------------------------------- 66375cd4da | advil | 2021-01-19 16:41:12 -0500 Refactor write_dgl_status_file Just a code cleanup. -------------------------------------------------------------------------------- b51a1d6fd6 | Nicholas Feinberg | 2021-01-18 09:36:51 -0800 Don't auto-drop ?tele in Gauntlet (Yermak) For purposes of auto-selecting items for drop with `d,`, ignore temp conditions such as 'being in Gauntlet'. This should discourage accidents. -------------------------------------------------------------------------------- 5a9077b8ae | Kate | 2021-01-17 03:39:46 +0000 Adjust timing for evoked unrand HP/MP costs As with the Majin-Bo in 0fe236c, reduce HP and MP as a cost before activating the ability, and refund it if the ability is aborted. -------------------------------------------------------------------------------- 65cebae1ba | Nicholas Feinberg | 2021-01-16 16:08:25 -0800 Don't show Fridge accuracy (lici) Since it always hits! -------------------------------------------------------------------------------- 19769c27d7 | Edgar A. Bering IV | 2021-01-15 17:44:33 +0200 Add a missing of (Aliscans) -------------------------------------------------------------------------------- 39ad13b146 | Edgar A. Bering IV | 2021-01-15 07:43:18 +0200 Don't remain curled while delayed (12443) -------------------------------------------------------------------------------- 4f573a835d | Edgar A. Bering IV | 2021-01-14 20:37:32 +0200 Fix a teleport closet (MakMorn) -------------------------------------------------------------------------------- 33242fe616 | Edgar A. Bering IV | 2021-01-14 20:07:06 +0200 Prevent trampling a constricted actor (12432) The other option would be to have constriction broken on trampling. However, I went with this resolution because either: - the player is being trampled and constricted, don't make their life easier - or the player has allies and is trying to do both things to a target, creating an ally-micromanagement encouraging edge case -------------------------------------------------------------------------------- 897d3da516 | Edgar A. Bering IV | 2021-01-14 19:44:25 +0200 Don't update constriction when testing door seals The vault warden AI check to see if it should seal a door was using move_to_pos to evaluate the tension of actor moves, but move_to_pos handles updating constriction information of the constrictor. The result was that if the check needed to test if pushing something through a door in a way that would break constriction was a good idea, the constriction would actually break, even if the monster ultimately decided to not close the door! Closes #1566 -------------------------------------------------------------------------------- ea5d59904d | Edgar A. Bering IV | 2021-01-14 19:22:03 +0200 Fix a tension check for runic seals (8085, 10542) The previous tension check for closing doors had an incorrect conditional, so that if tension were *increased* by the closure, the warden would not decide to close the door! Additionally, this check returned true in situations where the tension was 0 before and after the closure. The result of the latter behavior was often locking the player in with their allies away from the warden. Closes #1534 -------------------------------------------------------------------------------- 0fe236cf81 | Edgar A. Bering IV | 2021-01-14 18:55:36 +0200 Adjust the charging of Majin-Bo's hp cost Don't send it through ouch, it should be treated like an ability hp cost, not damage (so no harm scaling!). Also, dec the hp at the same place as the mp cost of the spell, for appropriate sequencing of the effect and to give the player a preview of the cost while targeting. Closes #1578 -------------------------------------------------------------------------------- f40771be7f | Edgar A. Bering IV | 2021-01-14 17:52:12 +0200 Remove an obsolte comment -------------------------------------------------------------------------------- 28f6fc2273 | Edgar A. Bering IV | 2021-01-14 17:26:14 +0200 Anger monsters who block player attacks Consistent with dodged attacks that the monster is awake to notice. Closes #1612 -------------------------------------------------------------------------------- b0dbf93ca2 | Edgar A. Bering IV | 2021-01-14 17:12:25 +0200 Simplify Tornado interactions with distance movement Prior to this commit, if the player moved by translocating (or Ba hop) multiple tiles while under the effects of tornado, the tornado was cancelled, without requiring cooldown, UNLESS the translocation landed the player in a tornado cloud, in which case the tornado duration was decremented by a translocational penalty. No change to duration was incurred on taking a passage of golubria or transporter. On taking stairs the tornado was cancelled with no cooldown. This commit changes the behavior to: blinknado is ok, but all other long distance changes end tornado and give the cooldown. Closes #1611 -------------------------------------------------------------------------------- 80642e47cc | Edgar A. Bering IV | 2021-01-14 14:40:54 +0200 Don't offer conjured things god blessings Closes #1648 -------------------------------------------------------------------------------- 0c344bb9d3 | Edgar A. Bering IV | 2021-01-14 14:18:25 +0200 Restore Zyme sickness Incorrectly changed an undead state check when rot changes were made in 4cbea82fa3. US_ALIVE is tragically false. Closes #1677 -------------------------------------------------------------------------------- 768c70b9d4 | Edgar A. Bering IV | 2021-01-14 13:57:41 +0200 Fix a teleport closet Closes #1681 -------------------------------------------------------------------------------- 58ad9d9fa3 | wheals | 2021-01-14 10:22:07 +0200 Quiet down Irradiate (#12446) I'm guessing, based on loudness being set to 0, that it was never expected to have the explosion noise. However, explode() reset the loudness anyway, so setting it manually had no effect. -------------------------------------------------------------------------------- caaa221d37 | advil | 2021-01-13 20:36:46 -0500 Fix webtiles rendering of ctrl keys I honestly have no idea how these were displaying in console, but they were, so I assumed they would work in webtiles as well. But something low-level that I haven't found must have been doing the actual rendering in a way that didn't convert them to readable strings in webtiles. This is a quick patch to render them correctly in the macro menus. -------------------------------------------------------------------------------- 75406f0b48 | advil | 2021-01-13 14:10:38 -0500 Suppress DGL clrscr escape code during targeting On a USE_DGAMELAUNCH=yes build, clrscr calls send an escape code that is interpreted by dgamelaunch as a clrscr command, and is also apparently used to synchronize ttyrecs (??). This happens at the same time as regular ncurses clrscr, but it seems that it is likely sent and processed immediately, whereas clrscr has no effect until a refresh(). Since 38af612a8a6b923, while targeting, the entire console display is fully cleared and redrawn on every key (via the call chain UIDirectionChooserView::_render() -> redraw_screen -> draw_border -> clrscr). I have not been able to fully understand either why this does happen or why it needs to happen (the screen is actually cleared by a call to ui.cc::clear_text_region that wipes out everything during the ui render chain, making a full redraw necessary), but the net effect is that this causes a lot of blinking when playing in console through dgamelaunch, especially with a low ping. As an interim solution, in this commit I've simply suppressed all dgl clear codes during targeting. They happen often enough otherwise that hopefully this wouldn't cause any synchronization problems, if anything is even using these codes any more. -------------------------------------------------------------------------------- d04b7445b5 | advil | 2021-01-12 20:03:02 -0500 Remove some console blinkiness in map view As far as I can tell, this update_screen call is guaranteed to force an update on a blank screen, and since it is triggered on every refresh in map view, it is making map view extra blinky (especially over ssh). I can't find any negative consequences of just removing it. -------------------------------------------------------------------------------- a51d4ba9de | Nicholas Feinberg | 2021-01-12 08:24:42 -0800 Fix more net trap bugs Don't allow players to collect infinite nets by either (a) being in dragon/tree form or (b) just being already in a net when another net drops. -------------------------------------------------------------------------------- 9f9dfd16e9 | advil | 2021-01-11 17:25:53 -0500 Fix a console hud issue at high turncounts (gressup) This code used a constant number of spaces to clear the rest of the turncount line, but didn't factor in the fact that cprintf wraps; at high turncounts (6+ digits) on long autoexplore/autotravel spans (>10.0 auts) it could therefore overwrite 1-2 letters of the weapon display. Recent changes reduce how often the weapon redraws, so this has probably become more visible lately. Despite that, this is a vintage bug, originating from ce229f1793ccd. -------------------------------------------------------------------------------- ebd156f8b4 | Edgar A. Bering IV | 2021-01-11 00:00:49 +0200 Fix monster tracers for Call Down Damnation The tracer behavior was inadvertently changed in 2f2a4d8ed992e13 which refactored CALL_DOWN_DAMNATION into a zap. In doing so no longer failed to set the explosion size for the tracer. Closes #1678 -------------------------------------------------------------------------------- da163c7f71 | gammafunk | 2021-01-10 10:02:22 -0600 More insubstantial wisp removal Remove descriptions and quotes in various languages. -------------------------------------------------------------------------------- 3544c24705 | advil | 2021-01-09 22:39:14 -0500 Update keybind.txt for 0.26 changes ...missed this. -------------------------------------------------------------------------------- 838eb4c31e | advil | 2021-01-09 18:35:37 -0500 Fix confused ctrl-attacks The code that handles this case got elided in 6b3f3ad2d24f (possibly I was assuming it was handled elsewhere, but it isn't, because of treeform). -------------------------------------------------------------------------------- 58928b186a | Kate | 2021-01-09 22:41:30 +0000 Update monster disintegrate description -------------------------------------------------------------------------------- f4412e357a | Kate | 2021-01-09 22:41:30 +0000 Fix grammar in miscast descriptions -------------------------------------------------------------------------------- def486af7f | Nicholas Feinberg | 2021-01-09 12:37:37 -0800 Fix various will-o-the-wisp vaults Replacing insubstantial wisps with the much more threatening will-o-the-wisps 1:1 produced some unintententionally deadly results. -------------------------------------------------------------------------------- 4bfc8a49e1 | Edgar A. Bering IV | 2021-01-08 21:31:42 +0200 Add a trunk reminder for the 0.26 tournament -------------------------------------------------------------------------------- 3fd14906f5 | Edgar A. Bering IV | 2021-01-08 18:44:07 +0200 Final credit roll for 0.26 -------------------------------------------------------------------------------- fb268537a3 | gammafunk | 2021-01-08 10:06:50 -0600 Final changelog update for 0.26.0 Oops! Forgot to do this before tagging. -------------------------------------------------------------------------------- e07e2c7cd4 | gammafunk | 2021-01-08 09:45:41 -0600 Update the Debian changelog for 0.26 -------------------------------------------------------------------------------- ee53873d45 | advil | 2021-01-08 10:38:27 -0500 Better handle a webtiles error case I think this probably results from something being misconfigured with socket paths; it's being triggered on CBR2 currently by connecting via ssh. -------------------------------------------------------------------------------- 2af701fde4 | Edgar A. Bering IV | 2021-01-08 11:51:34 +0200 Tweak lua documentation and get it to build The internal ldoc error was not, as had been suspected by me, a version problem, but a lack of good error messages from ldoc! After some tweaks, `make api` now runs again under ldoc 1.4.6-2 in lua5.3 (I'm not going to figure out how to make this work with contribs becuase that would surely require vendorizing ldoc...). Some typos and type-os (misuses of tparam) are also corrected. -------------------------------------------------------------------------------- 21144fbd99 | Nicholas Feinberg | 2021-01-07 22:29:36 -0800 New Fenstrider Witch tile (canofworms) -------------------------------------------------------------------------------- 238fa4abc0 | Nicholas Feinberg | 2021-01-07 22:29:16 -0800 Replace Bloated Husk tile Look familiar? (It's a recolour of the very old Plague Shambler tile.) -------------------------------------------------------------------------------- fbafd837a3 | advil | 2021-01-07 21:14:45 -0500 Attempt to handle WebSocketClosedError in Tornado 6 Under high load conditions (I think, I haven't replicated this) in current versions of Tornado, write_message can return non-trivial Futures. Our code has assumed that these are always trivial, and therefore, did not do any exception handling; a timeout under these conditions causes a *lot* of annoying log messages, coinciding with server lag/thrashing, though I'm not sure of the causal direction. We've been seeing this specifically on CBR2. This commit adds an exception handler for the async part of write_message, using a callback (in a kind of ugly fashion). I haven't locally replicated the exact issue, but I have tested this callback by modifying Tornado. Some day, maybe this code can all be made to use async directly. At worst, this fix will make the log messages a lot cleaner; I do suspect it won't do more than that for the deeper problem, but it will also hopefully provide some clues as to what is going on. -------------------------------------------------------------------------------- 0ec5f8ab93 | advil | 2021-01-07 16:59:46 -0500 Fix some oddnesses with fire order from invalid quivers This isn't a very general fix, and will lead to odd behavior if launchers are not first in the player's fire order, but I don't want to mess with this too deeply given the release timing. -------------------------------------------------------------------------------- 216b6189a3 | advil | 2021-01-07 16:59:46 -0500 Prioritize sandblast over throwing stones for EE start (ardl) This is extremely special-case-y, but EE players will almost certainly want to do this right away anyways, and it better matches other elemental starts. I at least made it check fire order first. -------------------------------------------------------------------------------- e4986e83c0 | advil | 2021-01-07 16:59:46 -0500 Missed hailstorm animations from 64bdb92e382d -------------------------------------------------------------------------------- e8fdfcfcf6 | gammafunk | 2021-01-07 11:25:18 -0600 Remove references to Charms magic (split) In the manual and in the aptitude list templates. -------------------------------------------------------------------------------- 64bdb92e38 | advil | 2021-01-06 17:21:00 -0500 Improve coverage of disabling beam animations (12356) This gets lightning rod, tremorstones, glaciate, ignition, hailstorm, and static discharge. -------------------------------------------------------------------------------- 054287de91 | advil | 2021-01-06 16:07:57 -0500 Don't process click_to_travel minimap clicks in map mode If you left-clicked the minimap while in map (`X`) mode, this would start autotravel, and then "continue" it when exiting map mode in any way including escape. In #1508 it was also reported that this sequence of actions caused a crash on windows; it isn't surprising to me that activating click_to_travel without leaving map mode would crash, though I didn't get it to crash on mac. In any case, this behavior doesn't make sense (escape should abort), so remove it, and hopefully fix the crash on windows as well. -------------------------------------------------------------------------------- 1c918b713c | advil | 2021-01-06 15:28:28 -0500 Don't crash with extreme game_scale values These can lead to bad memory corruption and crashes if they result in regions having size 0. Instead of crashing, print an error message to the player and abort. -------------------------------------------------------------------------------- 23abb52f8e | advil | 2021-01-06 14:02:04 -0500 Fix a glyph size issue (powerbf) I *think* what was happening here is an off-by-one error; if the glyph size is exactly the max advance the stored version was failing to be doubled, and was short one column; this column was getting overwritten by an adjacent glyph. Huge thanks to powerbf in #1482 for doing the bisection + debugging to figure out the source of the problem. I wont' auto-close that PR as I'd like to get this tested on other OSs. -------------------------------------------------------------------------------- 72ac391492 | advil | 2021-01-06 09:47:53 -0500 Revert "Explicitly set window opacity" This commit probably didn't do anything (or so I was convinced by discussion in #1562), and will prevent building against xenial, which we are currently targeting for debs. This reverts commit 613af4b37b82d0001911d91b8d37d4153b36e1ad. -------------------------------------------------------------------------------- 8be3b22871 | Goratrix | 2021-01-06 09:40:03 -0500 Update changelog for 0.25.1 This changelog entry was only commited in 0.25 branch when 0.25.1 was released, not to master, so it's missing now from 0.26 and master changelog file. -------------------------------------------------------------------------------- 54a7bdf380 | advil | 2021-01-06 09:38:56 -0500 Remove travis -------------------------------------------------------------------------------- bd5e5ef833 | advil | 2021-01-06 09:35:25 -0500 Tweak autofire description in key help ... to make clear that untargeted actions are activated. -------------------------------------------------------------------------------- 34d46f0a3f | advil | 2021-01-05 14:27:49 -0500 Changelog updates * More on newquivers * add a bunch of smaller options/lua/ui features mostly from outside contributors * Put all key combos for this version in `` (I realize this isn't md but it's still easier to read that way.) -------------------------------------------------------------------------------- 1ca9eea3f7 | advil | 2021-01-05 10:53:26 -0500 Fix quiver redraw issues on delay interrupt Depending on the exact timing, a stat redraw sometimes wouldn't happen immediately after a delay interrupt, leading to incorrectly showing a quiver as disabled. This commit adds some delay-related checkpoints to ensure that the quiver info is up-to-date, and forces a stat redraw on runrest delay end. (This could come up for other interrupted delays?) This is somewhat delicate to debug/replicate because messaging can force a stat redraw itself. -------------------------------------------------------------------------------- 753e386513 | advil | 2021-01-05 10:28:05 -0500 Fix target check for LRD This spell is LOS range so there's no impact wrt the spell's effect, but this fixes quiver status and messaging. I think the manual special-casing in the range check originates from when this spell could destroy walls. -------------------------------------------------------------------------------- d6d4955b76 | advil | 2021-01-05 10:23:04 -0500 Fix autofight messaging for spells with no target in range Not sure exactly when this got broken, but this commit cleans up a few issues with how this was previously implemented. -------------------------------------------------------------------------------- 021c985bc4 | advil | 2021-01-05 09:07:47 -0500 Remove some debug code -------------------------------------------------------------------------------- bdec46a1ea | nikheizen | 2021-01-05 04:25:14 -0600 Fix nzn_winding_woodlands_15x15_boxy_spiral This subvault was only 14 cells wide instead of 15. This commit fixes it and makes the central vault slightly more resilient to vault burning. -------------------------------------------------------------------------------- 5f2be0e231 | advil | 2021-01-04 16:36:37 -0500 Disallow throwing stones while wielding a sling There's nothing wrong with this per se, but it doesn't have much in the way of benefits that I can come up with and is fairly confusing to the player. This was disallowed before e42c0a68 anyways. -------------------------------------------------------------------------------- bd55b0887b | advil | 2021-01-04 16:26:48 -0500 Restore switch-on-autopickup behavior from pre-0.26 When you ran out of one type of ammo, autoswitched to another, and then picked up the first type, oldquivers would switch you back. It got removed in the quiver rewrite because the code was kind of messy. This commit restores that behavior, by popular demand. I'm not super happy with the implementation (which unfortunately relies on a bunch of weird legacy code) but after thinking about this for a while, I'm not sure there's a clean way to implement this behavior. -------------------------------------------------------------------------------- 1d1f4c8ba3 | advil | 2021-01-04 12:04:26 -0500 Add a note about sub-ordering for fire_order -------------------------------------------------------------------------------- 08524f53dc | advil | 2021-01-04 10:44:11 -0500 Tweak targeting help Make it clearer that the quiver commands are mode-specific, also use correct mapping for `()`. -------------------------------------------------------------------------------- 6ed78dee3f | advil | 2021-01-04 10:36:28 -0500 Add a fallback targeter heading for firing This mostly impacts targeted abilities that don't have any labeling in targeter mode at all (mainly old ones). It would be a good idea to do something more comprehensive / consistent, but ability targeters are implemented in a fairly piecemeal way (unlike e.g. spell_direction). -------------------------------------------------------------------------------- 405e3faaac | advil | 2021-01-04 10:21:34 -0500 Simplify quiver verbs for misc evokables I tried a few times to make these flavorful + non-confusing, but never really got the second part down. Just use "Evoke". -------------------------------------------------------------------------------- c18c9092ac | advil | 2021-01-03 20:40:11 -0500 Clean up + simplify "Powers" tab Invocations info The original form of this message ("piety instead of invoc") was already kind of confusing, because most invoc gods are affected by *both* piety and invoc (and this is described for specific powers on the Overview tab too). In addition, it just left out gods where the "piety" part wasn't appropriate or was too involved. This commit simplifies the skill message to only describe the non-impact of Invocations, and shows this message for all gods that aren't affected by invoc. Contra the now-removed comment, there would be space to describe any additional effects that this doesn't cover, but it's not actually that obvious to me what this comment was talking about that is missing. (For Gozag, the effect of gold is well-described, and the comment about WJC seems outdated?) Resolves #1662 -------------------------------------------------------------------------------- 7ddcfd5ad1 | advil | 2021-01-03 20:18:06 -0500 Set default startup name from -name at command line This lets a name set at the command line persist to the main menu if the player hits esc at character selection. Resolves #1510 -------------------------------------------------------------------------------- 443bf2d2ca | advil | 2021-01-03 15:58:42 -0500 Don't double !f warning for `F` Resolves #1669 -------------------------------------------------------------------------------- 353b9ea00c | advil | 2021-01-03 15:41:42 -0500 Fix launcher autoswitch issues (ardl) launcher_action_cycler autoswitch was broken in some cases (most obviously when picking up a launcher for the first time with none of its ammo in inventory) because its default initialization was with an ammo_action, not a launcher_ammo_action. While debugging this I found a bunch of related issues and cleaned up some of the code slightly. -------------------------------------------------------------------------------- 2edb794d0a | gammafunk | 2021-01-03 11:14:02 -0600 Make player drain fully proportional and buff it I originally made max HP drain split power into two components, one used for a randomized cost and one for a proportional cost. This was to balance the effect between low HP characters and high HP characters. Low HP characters get penalized more an effect based on a fixed value compared to one that's based on a percentage of max HP. Making it fully percentage-based hurts high HP characters more, but elliptic pointed out that this is how other max HP reduction effects like frail work. Based on play-testing, the current drain effect is a bit weak for both monster attacks and ability drain costs, and we'd like to buff it. Making the effect fully proportional will let us do this without harming low HP characters quite so much. Yes, we actually care about the poor felids (no we don't). This commit makes the effect fully based on the player's current max HP and increases its strength by 33%. Now the final HP drained is simply: 1 + div_rand_round(power * max_hp, 750) with the division being randomly rounded in the usual way. Hence we always drain 1 MHP if our power was non-zero. Drain power is still 1 + damage for monster attacks or a fixed cost value for abilities, as before, Some quick play testing has shown early wight packs to be a bit more effective at getting the player into lightred drain and e.g. Ru Apocalypse to be a bit nastier. If this proves to be not enough, it's easy to adjust that 750 divisor. -------------------------------------------------------------------------------- 2d0a2396b0 | advil | 2021-01-02 20:43:43 -0500 Improve tremorstone + summons warning checks (12409) This is a fairly minimal approach, in contrast to the potential for refactoring: there's a lot of related code that could be consolidated here, and it looks to me like shoot_through_monster does a bunch of checks that doesn't need the full beam. Various other cases have the same code duplication issue, see e.g. b68aede. However, I don't want to mess with this stuff in a general way during feature freeze. Partial revert of 105bc0f7bc0538ce0380fe774c2a35860f9f7c17. -------------------------------------------------------------------------------- 0579ed41f9 | advil | 2021-01-02 20:43:29 -0500 Fix a butterfly+charge+quiver interaction (12410) Palentonga charge can target butterflies, but autofight code has its own check that ignores butterflies. With autofight_throw=true, when a butterfly was in charge range the quivered ability would therefore be enabled, but autofight would select movement towards the distant target. However, autofight relies on a quivered ability to be disabled to know when to trigger movement; the net result was that it passed a distant target through to activate the ability and gave an error. On the assumption that players won't usually want to roll towards a butterfly, this commit disables charge with non-threatening monsters in range. However, charge can still be triggered towards a non-threatening monster by using the `a` menu. As noted in the comments this is a somewhat hacky solution, and a more general solution along the lines of spells + non-threatening monsters would be less hacky. -------------------------------------------------------------------------------- 105bc0f7bc | advil | 2021-01-02 18:26:21 -0500 Revert "Improve tremorstone + summons warning checks (12409)" This reverts commit 91735a3152ac1321536d30bc7ca0037caf38fc6b. -------------------------------------------------------------------------------- 91735a3152 | advil | 2021-01-02 18:19:29 -0500 Improve tremorstone + summons warning checks (12409) This is a fairly minimal approach, in contrast to the potential for refactoring: there's a lot of related code that could be consolidated here, and it looks to me like shoot_through_monster does a bunch of checks that doesn't need the full beam. Various other cases have the same code duplication issue, see e.g. b68aede. However, I don't want to mess with this stuff in a general way during feature freeze. -------------------------------------------------------------------------------- 087482e4d5 | Edgar A. Bering IV | 2021-01-02 16:26:37 +0200 Don't perform a range check for Noxious Bog -------------------------------------------------------------------------------- 086eb55de8 | Edgar A. Bering IV | 2021-01-02 15:57:39 +0200 Tone down Ignite Poison's effect on bog The previous interaction was bugged, since place_cloud takes a number of turns, not a number of auts, so a duration 10x as long was being used for the flame clouds created when igniting bogs. Additionally, igniting every tile was left-over from the trail-style bog. New Noxious bog places many more bog tiles instantly, which even with the originally intended cloud duration allows the player to surround themselves with flame-cloud covered bog (and keep the flame clouds for a while after the bog ends at high power). This commit reduces the flame cloud duration to a reasonable length (2-5 dAuts at max power) and only places flame clouds over a bog cell with a one in three chance. -------------------------------------------------------------------------------- 63decd6869 | Edgar A. Bering IV | 2021-01-02 15:15:31 +0200 Clarify a prompt message -------------------------------------------------------------------------------- c91146610e | Edgar A. Bering IV | 2021-01-02 15:15:07 +0200 Describe dazzle chance in the Dazzling Flash targeter -------------------------------------------------------------------------------- 7e5a9cbe55 | Edgar A. Bering IV | 2021-01-02 14:59:06 +0200 Add a static targeter for ignite poison -------------------------------------------------------------------------------- c93d6a9b7e | Edgar A. Bering IV | 2021-01-02 13:44:33 +0200 Re-refactor targeter_multiposition Commit 464169c878 fixed some of the monster checking that targeter_multiposition does, and subsequent commits used targeter_multiposition as a base class for static targeters for various LOS-enchantment effects. The implementation of 0242afd26b had some order-of-execution finesse to ensure that a virtual method called by the targeter_multiposition constructor was correctly initialized. In that commit and the comments in it I remarked there was probably a better way. Indeed, the design smell of the constructor pointed out the following: multiposition and multimonster targeting, while appearing similar in the ui, are semantically different. This commit splits up users of the class: targeter_multiposition is used when the targeted cells depend non-locally on the monster occupying the cell, and a new targeter class targeter_multimonster is introduced for targeting monsters in los on a monster-by-monster basis. The result simplifies targeter_multiposition nicely. -------------------------------------------------------------------------------- 3d81cda750 | Edgar A. Bering IV | 2021-01-02 11:05:32 +0200 Allow static-targeter preview of Confusing Touch By enabling these two spell flags the recently implemented static targeter interface Just Works to allow a preview of Confusing Touch success chances. The highlighting intentionally highlights only the player, which might make this behavior a bit hard to discover, but it feels less misleading than "targeting" all visible monsters. The wording could be improved, but currently the success chance display does not allow verb customization. Because this targeter is a bit of a kludge, I haven't made it a default force targeter. -------------------------------------------------------------------------------- 0242afd26b | Edgar A. Bering IV | 2021-01-02 11:05:31 +0200 Add detailed static targeters for LOS enchantments To round out the new quiver and collection of static targeters, this commit adds detail to the static targeters for: Cause Fear, Discord, Alistair's Intoxication, and Metabolic Englaciation; also added is a static targeter for the pseudo-spell Drain Life. Each now highlights the monsters that will be affected (or at least not outright immune). Additionally, success chance displays have been added, so that the chance of affecting each target is available. In an ideal world these spells would be further re-factored so that the targeter behavior is unified with the casting behavior, the affect logic encapsulated in beam or zap data, and the different targeting classes unified in a single targeter_multiposition_enchantment. For now, I am content with the UI clarity. -------------------------------------------------------------------------------- cc8eda8a42 | Edgar A. Bering IV | 2021-01-02 11:05:31 +0200 Adjust Metabolic Englaciation Simplify the formula slightly to only randomize on power and not also on monster HD. The change uses the midpoint of the previous roll so the power level should stay about the same, with aa slightly narrower distribution of durations. -------------------------------------------------------------------------------- 1589ab1335 | Edgar A. Bering IV | 2021-01-02 11:05:31 +0200 Fix a targeting information leak in Absolute Zero (12415) -------------------------------------------------------------------------------- 464169c878 | Edgar A. Bering IV | 2021-01-02 11:05:31 +0200 Refactor targeter_multiposition Clarify the usage of can_affect_unseen, improve visibility checks, re-name a parameter, and support child class overrides of affects_monster. -------------------------------------------------------------------------------- 0db6f627e1 | Edgar A. Bering IV | 2021-01-02 11:05:31 +0200 Rename a function for clarity desc_success_chance -> desc_wl_success_chance -------------------------------------------------------------------------------- 87abb2d9eb | Neil Moore | 2021-01-02 00:10:24 -0500 Add a quote (that will rarely be seen) Same as it ever was. [skip ci] -------------------------------------------------------------------------------- 5dcdf963e0 | Nicholas Feinberg | 2021-01-01 14:52:07 -0800 Don't spawn 8 will-o-the-wisps in Lair (Goratrix) One will-o-the-wisp is a significant threat in Lair. 8 is death. -------------------------------------------------------------------------------- c4307f12cd | advil | 2021-01-01 16:17:45 -0500 Fix `F`+pproj logic (10804) This was inverted, and I think it also shouldn't ever set MB_TRUE for this code path. -------------------------------------------------------------------------------- fb19f2a25f | advil | 2021-01-01 16:02:23 -0500 Add lua support for targeted CMD_THROW_ITEM_NO_QUIVER This is a partial revert of d0772dbefd; this parameter was waiting for a case to be added in l-crawl.cc. -------------------------------------------------------------------------------- 92626205c4 | advil | 2021-01-01 15:55:01 -0500 Simplify throw_it (PleasingFungus) This code path has become progressively refactored so that it is only ever called from one place, and a quiver::action object provides the full context needed to do throwing/launching; so, use that. -------------------------------------------------------------------------------- 18013ae1f5 | Nicholas Feinberg | 2021-01-01 11:27:32 -0800 Remove unused variable (Mesh) -------------------------------------------------------------------------------- 2922b9e743 | Nicholas Feinberg | 2021-01-01 09:50:02 -0800 More throwing code cleanup Remove a very long-unused return variable and some other unused cases. This whole use of `dist target` is much more complex than it needs to be (we never pass a meaningful target in), but... -------------------------------------------------------------------------------- e5df516c99 | Nicholas Feinberg | 2021-01-01 09:42:40 -0800 Ban shift-dir pproj (12422) Recent quiver changes caused shift-direction aiming (which fires projectiles in a cardinal direction) to crash the game, but it never worked correctly. In older versions, it would aim at the map border, causing fun messages in e.g Shoals of "There is a water there". There's really no situation in which shift-aiming with pproj makes sense, unless some more complex behaviour of 'aiming at the nearest enemy in that direction' was added. Barring that, let's ban it. -------------------------------------------------------------------------------- f342683475 | Nicholas Feinberg | 2021-01-01 09:03:58 -0800 Rename a mysterious 15-year-old variable -------------------------------------------------------------------------------- d0772dbefd | Nicholas Feinberg | 2021-01-01 08:58:02 -0800 Remove an unused parameter -------------------------------------------------------------------------------- cf006a40f5 | Nicholas Feinberg | 2020-12-31 10:17:33 -0800 Don't make Hurl Sludge also cast Blinkbolt (vt) Why are C-style switch/case statements so bad. -------------------------------------------------------------------------------- 135aecce3f | gammafunk | 2020-12-31 11:36:06 -0600 Have Vehumet support Eringya's Toxic Bog (Lici) A direct damage spell, just not one using conjurations, so add it to the special list. -------------------------------------------------------------------------------- 6edc4d6507 | Alan Malloy | 2020-12-31 03:56:09 -0800 Record origin of clouds that petrify the player (Tungsten) -------------------------------------------------------------------------------- b6e4b569e3 | wheals | 2020-12-31 12:44:09 +0200 Remove an unused spellbook -------------------------------------------------------------------------------- 930a39183f | Edgar A. Bering IV | 2020-12-31 12:10:59 +0200 Remove insubstantial wisps Insubstantial wisps aren't great monsters. Mechanically annoying, rarely threatening in their vault usage, and not loreful enough to keep as a rare vault decorating monster (compare toenail golems, which aren't annoying and are very loreful). After the Swamp overhaul these continued to appear in: - assorted vaults (where they were generic electric/translocations theme or a now incorrect Swamp monster) - the Foxfire card's effect list - in the Abyss spawn list (as a Swamp guest) None of these usages were particularly inspiring as the monster is not great, so wisps are finally dissapated by this commit. The tile and glyph info are retained to use as a dummy for player Wisp form. For vaults: - in Swamp and where they are a Swamp guest, they are replaced with will-o-the-wisps, - in places where they are a generic electric threat, they are either removed or replaced with ball lightning (as appropriate), - in places where they are a translocation theme piece, they are removed. The Foxfire card no longer summons wisps, and just has a shorter list. The Abyss spawn has been replaced with will-o-the-wisps. -------------------------------------------------------------------------------- 14533b3512 | Edgar A. Bering IV | 2020-12-30 20:34:31 +0200 Fix some zap glyphs Commits 2f2a4d8, f75564e, and 17de90a zapified more monster spells and abilities, but in moving them to zap data didn't preserve the default DCHAR_FIRED_ZAP beam glyph from mons_spell_beam. This resulted in console animations for the affected abilities using null as the glyph, hiding the beam. -------------------------------------------------------------------------------- 7079f50010 | Goratrix | 2020-12-30 20:10:21 +0200 Clarify annotations in Ctrl+O and in the manual After commit 8436896, any level can be annotated. Update instructions in Ctrl+O and in the manual accordingly. -------------------------------------------------------------------------------- 56d4af09c2 | wheals | 2020-12-30 20:06:53 +0200 Fix the build With the rename, the flavor connection to the vault is more tenuous than ever, but I'll allow it. -------------------------------------------------------------------------------- d7b2425749 | Nicholas Feinberg | 2020-12-30 09:54:36 -0800 Remove Robustness (; -------------------------------------------------------------------------------- adef21051d | Edgar A. Bering IV | 2020-12-30 19:44:13 +0200 Rename two unrand rings (CanOfWorms, hellmonk, PleasingFungus) Robustness -> the Tortoise Phasing -> the Hare 1. Robustness has the same name as the mutation, but a completely different effect. 2. Tortoise / Hare pairing is good Lore that links the two rings. 3. I got to the bikeshed with the paint colour I like before PF did (alternate suggestion was Robustness -> Invincibility). -------------------------------------------------------------------------------- 05fc5f520a | Nicholas Feinberg | 2020-12-30 09:05:55 -0800 Fix gargoyle statue form LRD damage See 25521206441 for reasoning. -------------------------------------------------------------------------------- f2e91f3db1 | Nicholas Feinberg | 2020-12-30 08:55:48 -0800 Warn before entering a bezotted branch To help players notice when they're short on time? -------------------------------------------------------------------------------- 35eea5b30a | Nicholas Feinberg | 2020-12-30 08:44:34 -0800 Refactor stair warnings -------------------------------------------------------------------------------- 220361c043 | Goratrix | 2020-12-30 10:24:53 +0200 Small update in options guide Eringya's Noxious Bog has a default force_targeter now, so update options guide accordingly. Also fix two stray rows which were longer than 80 characters. -------------------------------------------------------------------------------- d52f5182fe | Nicholas Feinberg | 2020-12-29 08:24:35 -0800 Rename art-data MAGIC->WILL MAGIC was always an extremely confusing property name. -------------------------------------------------------------------------------- 0de2e1c0f6 | gammafunk | 2020-12-29 06:58:43 -0600 Fix a changelog entry (ebering) -------------------------------------------------------------------------------- 66cac9c236 | gammafunk | 2020-12-29 06:14:40 -0600 Update the changelog Through 0.26-a0-1210-gada54dbd18. -------------------------------------------------------------------------------- ada54dbd18 | gammafunk | 2020-12-29 06:06:41 -0600 Restore the Glaive of the Guard's enchantment (curatorofearth) Make it +8 again, since its spectral weapon ego is good, but not good enough to also have bad enchantment. This was an apparently unintentional change made when ebering was testing a version with multiple spectral weapons (!!). -------------------------------------------------------------------------------- 49d2223b27 | gammafunk | 2020-12-29 05:11:49 -0600 Tweak boulder beetle rolling AI Boulder beetles currently continue rolling even if they don't have a viable move, which leads to them rolling in-place behind monsters or damaging clouds. This does confer a benefit to the monster should a viable path open up before the roll enchantment expires, but is counter to the player expectation that rolling implies to movement. This commit has boulder beetles stop rolling if they have no viable move, and likewise prevents them from attempting to roll if there is no viable move. Although this is a slight nerf to boulder beetles, they're quite worthy foes already. This implementation uses the monster tracking info use by thorn hunters, specifically tracking what our next viable move is. It would be ideal to have better fidelity about this move information, since it doesn't necessarily contain the move a monster would end up choosing. A later codepath ends up trying a backup move location if current choice proves unviable, but we don't have access to this data. -------------------------------------------------------------------------------- 978f32097b | wheals | 2020-12-29 13:03:34 +0200 Clarify AF_CONFUSE's confusing flavour AF_CONFUSE, when combined with AT_SPORE, represents a cloud of confusing spores that cause confusion when breathed in. Otherwise, it is simply a magical effect that causes confusion. Fixes #1385 -------------------------------------------------------------------------------- dd5fdbaec6 | wheals | 2020-12-29 12:58:38 +0200 Remove a confusingly redundant function. -------------------------------------------------------------------------------- 814068fe0c | wheals | 2020-12-29 12:27:21 +0200 Add some periods. -------------------------------------------------------------------------------- 4083c211ab | advil | 2020-12-28 14:38:29 -0500 Mark an ossuary entrance as transparent Resolves #1639 -------------------------------------------------------------------------------- 6fff606423 | advil | 2020-12-28 14:13:37 -0500 Transparency fixes for a kennysheep vault (12426) It lacks an @, so when marked as opaque could generate with the single door not connected. -------------------------------------------------------------------------------- 3ff7017067 | paul | 2020-12-28 20:27:40 +0200 Add a flashy Wu Jian overflow altar vault This vault is a nod to a classic 70's Kung Fu flick called Five Deadly Venoms. The titular characters of the movie have nicknames and martial arts styles that are reasonably well-represented by existing monsters and tiles in DCSS and thought Wu Jian deserves a fancy Lua'd up altar like some other deities! [ Committer's note: Closes #1660. Set overflow depth appropriately. ] -------------------------------------------------------------------------------- 4dcb31f9f6 | advil | 2020-12-28 13:12:40 -0500 Re-conditionalize quiver redraw (wheals) I'm not sure why this `if` got removed, but it might have just been an accident during testing. -------------------------------------------------------------------------------- b0746d5dc1 | advil | 2020-12-28 13:01:16 -0500 Fix macro menu handling of unprintable keycodes This is an attempt at some minimal fixes for this menu; anything more ambitious will need to happen not during a feature freeze. Keycode munging under the hood is a complete mess; this commit tries to work around what's there with only minimal changes, rather than rewriting everything. Main changes: * Print readable names of many unprintable keycodes as menu hotkeys and in macro editing. * Fix an issue where some ancient numpad handling code would interfere with ncurses handling of F1-F4. This has been wrong for a very long time and was hard to address without knock-on effects; for now webtiles still uses the wrong keycodes (which mistakenly got reified in key-conversion.js) and they are translated internally. There's also fixup code which translates wrong keycodes in a macro file into the correct ones. * Add a macro editing mode where you can enter a keycode by number, as a last resort for console keycode editing. (This menu should be changed to let arrow keys select an item as a better alternative to this.) This is triggered by hitting \ at the entry prompt (so to set a macro for `\` you now need to do this at the menu or by keycode). * More consistently print keycodes along with whatever printable symbol there might be for a keycode. * Add a bunch of comments documenting weirdnesses in this underlying code. Some remaining flaws: no handling for alt in SDL. Keycodes for many keys are inconsistent across build targets and should possibly be normalized. For weird keycodes, SDL sometimes prints surprising character names. The windows code here is a shot in the dark (but I will test before release). The macro menu followup UI is now even more complicated. -------------------------------------------------------------------------------- da768c6ff3 | amcnicky | 2020-12-28 19:50:47 +0200 New mini vaults Vaults in this collection: amcnicky_mini_pool_small A decorative minivault containing a small randomised pool amcnicky_mini_rare_corridor_liquid A rare vault which allows the dungeon generator to, on occasion, produce a corridor surrounded on either side by liquid, perhaps to be read as either a bridge over liquid below, or as a passageway between the liquid's depths. amcnicky_mini_corridor_feature A decorative minivault containing a feature lined corridor amcnicky_mini_pool_medium A slightly larger version of pool_small that can generate monsters, and also appear ruined when generated within Depths. [ Committer's note: Closes #1544. Tweaked and trimmed, dropped the beach vault submitted with this patch, adjusted depths and weights. ] -------------------------------------------------------------------------------- 2f95e4c8fc | amcnicky | 2020-12-28 19:50:47 +0200 New simple and small arrival vaults Vaults in this collection: amcnicky_arrival_double_pillar A medium sized arrival vault featuring two highly randomised pillars and a selection of entrance/exit possibilities amcnicky_arrival_single_pillar As above, but on a smaller scale amcnicky_arrival_feature_with_door A double-entrance arrival vault with the potential for many different hints of flavour in the feature tile amcnicky_arrival_flooded_fountain The player enters the dungeon through an entry room containing a number of fountains. The downstairs of an abandonned bath house? A door in the back of an ancient fountain temple? One of the fountains is broken, and the player sees a corresponding pool of water amcnicky_arrival_choice A vault intended to off the chance for an interesting tactical choice. Should the player be chased back into this room by an early enemy, there are no pillars to dance around. Instead, the player must either stand and fight, or take a risk with the shaft to escape. amcnicky_arrival_underground_garden A more decorative vault, the player enters the dungeon by passing through an underground garden. Was the dungeon entrance hidden within a forbidden forest? amcnicky_arrival_blooded_trapdoor The player is presented with a randomised pillar, two possible connections to the dungeon, and large smears of blood surrounding a solitary trapdoor. What became of the last player who tried to use that trapdoor? amcnicky_gap_in_the_tavern_cellar The player enters the dungeon via a secret room behind one of the water features in an unspecified room. The vault tiles make this connection through to the dungeon of zot appear almost intentional? amcnicky_arrival_wind_blow Which entrance to choose to the great dungeon of Zot? Which way does the wind blow? amcnicky_arrival_abandoned_market The player enters the dungeon of zot through a mysterious back alleyway amongst an abandonned marketplace. [ Committer's note: Closes #1542. Small tweaks to shrink some sizes, get the "story" of the vault in view on spawn, tactical checks, redundant doors. ] -------------------------------------------------------------------------------- 58195e7017 | amcnicky | 2020-12-28 19:50:47 +0200 Two new altar vaults The vaults added are as follows: amcnicky_altar_gilded A simple altar layout with (the potential for) a nice monetary surprise. amcnicky_altar_lugonu_corruption Lugonu has entered the dungeon! This vault iterates on the initial submission idea of 'dungeon corruption' which could generate in many branches and represents the fist of Lugonu smashing into the terrain. Current monster spawns use Lurking Horrors to bring their fairly novel tactical implications beyond just the abyss. [ Committer's note: Closes #1538. inner_sanctum not taken as altar vaults are meant to place altars. It might be ok as a float/mini monsters type vault since the altar is more decorative. Tweaked lugonu_corruption to tone down the number of lurking horrors, have more variability in its 'corruption', and be approachable and connected from all sides. ] -------------------------------------------------------------------------------- d68fa41eda | wheals | 2020-12-28 13:14:11 +0200 Defer redrawing the wield display if travel_delay = -1 (#1626) Rather than cancelling the redraws entirely. Does the same thing with the other displays as well, in case similar bugs happen in the future. Fixes #1626 -------------------------------------------------------------------------------- d8756d56bc | Aliscans | 2020-12-28 13:04:26 +0200 Forbid DEBUG_TRAVEL without DEBUG_DIAGNOSTICS Put a "#ifdef DEBUG_DIAGNOSTICS" statement around the #define for DEBUG_TRAVEL, as this only does anything useful when DEBUG_DIAGNOSTICS is set. [ Committer's note: Split up code-review revisions and squashed them into the relevant commits. Made a few small tweaks also. Closes #1608 ] -------------------------------------------------------------------------------- fec9e0e4c5 | Aliscans | 2020-12-28 13:04:26 +0200 Don't set greedy_place for items in hostile areas As things stood, if autopickup was off and there was an unexplored space behind a runed door, _explore_find_target_square() called pathfind() once to no avail, called it a second time with try_fallback set, and made that the target. If autopickup was on, it called pathfind() once, cleared it (because it had a negative travel_point_distance[] value), and printed a "Partly explored" message. This patch prevents greedy_place from being set if travel_point_distance[x][y] is negative, so the square containing the item can become the target. -------------------------------------------------------------------------------- e99fe26798 | Aliscans | 2020-12-28 13:04:26 +0200 Expand the behavior of travel_open_doors Add a value for the travel_open_doors option which means that autoexplore & travel plan routes which don't go through closed doors where possible (in the same way it always does for runed doors). The "actually stop travelling" code has moved from movement.cc to travel.cc. travel-open-doors-type.h lists the values, with "true" and "false" mapped to more descriptive words for the previous behaavior. A new template MultipleChoiceGameOption is implemented to support this behavior, old multiple choice options should consider being ported to it. -------------------------------------------------------------------------------- 8d272cd76c | wheals | 2020-12-28 12:20:23 +0200 Fix a stray text cursor showing up on local tiles The root cause of most of these problems is using the same construct both for text prompts and for highlighting squares on the map. Untangling the uses, however, is not simple. -------------------------------------------------------------------------------- 224bf8e84e | wheals | 2020-12-28 12:20:23 +0200 Unify the two cursors on local tiles X somewhat. Clicking on a place on the map will move the map cursor to there. Clicking on the map cursor will travel to there. It would be nice to unify them entirely, but the problem is that X automatically centers the map around the map cursor, so moving the mouse will shake around the view erratically. -------------------------------------------------------------------------------- e2a0e31ab3 | Nicholas Feinberg | 2020-12-27 16:51:13 -0800 Show LRD damage -------------------------------------------------------------------------------- d4ea5fece3 | Nicholas Feinberg | 2020-12-27 16:42:15 -0800 Hackily fix Zot status description (vt) Don't claim Zot is about to consume you when it's 15k turns away. -------------------------------------------------------------------------------- 2022570bc9 | nikheizen | 2020-12-27 18:05:51 -0600 Slightly increase density of winding_woodlands Increase the density of 5x5 rooms from averaging slightly less than one 0 per room, to 1.5. Increase the density of 5x15 rooms from averaging two 0 per room to three. winding_woodlands vaults would often spawn with very few monsters in the connector rooms, and most of the threat would be spilling out from the center subvaults. This makes them a little denser, while still allowing the possibility of empty connector rooms occasionally. -------------------------------------------------------------------------------- d90998e373 | nikheizen | 2020-12-27 18:05:51 -0600 Fix a couple subvault errors The 5x15_jagged subvault was 5x14, and thus could create some vaults where part of the vault was only accessible by stairs, if the whole vault wouldn't be vetoed. The 15x15_boxy_spiral subvault had one of its exits misaligned by 1, causing it to have buggy placement occasionally. -------------------------------------------------------------------------------- c6dd0926df | gammafunk | 2020-12-27 16:53:23 -0600 Reimagine Eringya's Noxious Bog (hellmonk,ebering) The combined damage and movement/combat debuff of the bog is interesting, but the spell's current approach of applying it in the caster's wake makes the spell ineffective and somewhat difficult to use. The additional turns spent moving to set up the effect incurs another cost for a spell that's already damage over time. Obviously we could increase the strength of the effect, but an alternative was proposed by hellmonk: have the spell affect many cells, but only those not adjacent to solid features. Being next to a lot of walls is generally helpful for the player, so this requirement adds a different kind of cost, which is that the player has to be near comparatively open areas. This is positional, giving the spell a natural power scaling based on how open the player's position is, and doesn't require kiting-like movement. This commit changes the spell to transform all areas into bog that are within a range of 4 and not adjacent to solid features, also excluding the player's position. The transformation happens instantly and reverts when the duration expires, with recasting not allowed until then. The requirement that the feature have a solid floor remains (e.g. no deep water or lava, but shallow water is fine). Additionally, only cells visible via not-translocation-blocking LOS can be transformed, and likewise we require that any transformed cell have all its adjacent cells be visible. The second requirement is to prevent an information leak by either using the targeter or casting the spell, either of which would be a tedious exploit. The duration is unchanged from before, as it seems reasonable for a damage-over-time spell like this, but both this and the range of effect of four will be reevaluated after more play-testing. If we want to incorporate spell-power more, we one possible change is to increase the range with spell-power, starting from a lower range at low power. We have to strike a balance between the high level of the spell and its need to be sufficiently strong and the fact that it can affect so many more cells as we increase the range. The spell has a static targeter showing potentially affected cells. I've updated the casting noise from 2 to 6, which I assume was unintentional, since we generally always have this noise value be the spell level. The spell description is also updated. I've moved the spell from spl-selfench.cc to spl-damage.cc, since this spell is really a damage spell at its core, is similar to spells like Frozen Ramparts or Summon Forest that not in spl-selfench.cc. -------------------------------------------------------------------------------- 055914a7a2 | wheals | 2020-12-27 21:16:43 +0200 Make X on local tiles slightly more useful Make the cursor automatically move around with your mouse. Also, show descriptions of features that are outside LOS_RADIUS but in your map knowledge. -------------------------------------------------------------------------------- 98a0ced166 | wheals | 2020-12-27 21:16:43 +0200 Restore the cursor on offline windows tiles targeting (#12424) -------------------------------------------------------------------------------- 95e395e029 | Nicholas Feinberg | 2020-12-26 07:59:20 -0800 Don't blink after death (nee) God bless Felids. -------------------------------------------------------------------------------- 447262cd64 | gammafunk | 2020-12-26 09:33:48 -0600 Fix a typo (Renan) -------------------------------------------------------------------------------- 197f7f9d65 | Neil Moore | 2020-12-26 09:15:08 -0500 Fix no longer fix grammar (realallion) -------------------------------------------------------------------------------- d376ed14c5 | advil | 2020-12-24 16:26:56 -0500 Add a bit more control to fire_order This is a bit of a filler commit; I think fire_order needs to be restructured in a more general way, but for now at least provide some coarse control over the order of action types when cycling the quiver. This commit also lets players remove an entire type from the cycle order (which has been particularly requested for abilities). Because game start autoquivering uses `cycle()`, this commit also affects that, so for the people who find it objectionable that Berserk autoquivers on a Be start, this gives them a way to prevent that. Eventually I think this would be *much* better as an in-game interface along the lines of spellbook hide/show. -------------------------------------------------------------------------------- 510840ca0f | Nicholas Feinberg | 2020-12-24 10:02:05 -0800 Make Irradiate check AC and bump damage Not checking AC was an oversight in the initial implementation that slowly transmuted into a feature. Well, let's transmute it back. I've made the damage a bit higher to compensate. Per a suggestion from hellmonk, I've also reduced the number of dice that are rolled, which reduces the predictability of the spell a bit. -------------------------------------------------------------------------------- 5ef3bed4d9 | advil | 2020-12-24 12:45:34 -0500 Add an action inventory selector for Q* Now, only the the non-tossing actions are shown on Q*, with an extra * to toggle the full inventory. This commit also: * handles a bunch of corner cases with few or no actions better, especially for felids * adds % as a secondary shortcut for items. This is because macroing Q* can lead to weird cases when there are no quiverable items, because * doubles ctrl; in the worst case if you macro Q to Q* and press QQ you get a quit prompt. -------------------------------------------------------------------------------- ab5e8f747a | advil | 2020-12-24 11:29:29 -0500 More eating remove -------------------------------------------------------------------------------- 1209ec82b9 | nikheizen | 2020-12-24 00:31:24 -0600 Don't guarantee nzn_prometheus_bound The map was a PLACE: instead of a DEPTH:, fix this, and move the vault to shoals.des, since it only appears there anyhow. -------------------------------------------------------------------------------- 060ceda6a5 | wheals | 2020-12-23 17:49:54 +0200 Unify movement checks for barbs/ice spells Incidentally fixes #1647 by putting them in the same code path as checks for traps/dangerous terrain/etc. -------------------------------------------------------------------------------- ad6db7abb9 | wheals | 2020-12-23 16:59:29 +0200 Give centaur enemies their bardings back (#12420) Now that barding is adaptable enough for two species, why not three? -------------------------------------------------------------------------------- 32fcee6e61 | wheals | 2020-12-23 16:53:53 +0200 Fix Zin wrath Accidentally broken when the hunger effect was removed. The situation remains where you get slightly less bad wrath by having only bad mutations. This seems like its own punishment. Fixes #1643 -------------------------------------------------------------------------------- 09726b21b3 | wheals | 2020-12-23 16:39:38 +0200 Show correct cast messages when a spell is redirected against the caster The second clause didn't seem to be doing anything, and I tested a bunch of different monsters and didn't notice issues. Still, it's worth keeping an eye out to make sure this doesn't cause other monspeak issues. Fixes #1652 -------------------------------------------------------------------------------- 792193eb12 | wheals | 2020-12-23 16:11:11 +0200 Grammatrise a Frozen Ramparts message Fixes #1635 -------------------------------------------------------------------------------- 895fbd4b88 | Nikolai Lavsky | 2020-12-23 16:07:02 +0200 Display threat levels on the /polymorph targeter As a followup to 6ee96136, this commit colourizes the names of monsters on the /polymorph targeter to show their potential threat level. This gives the player a quick way to see if polymorphing a monster is a good idea. -------------------------------------------------------------------------------- ae853a1889 | wheals | 2020-12-23 15:46:08 +0200 Even more food removal (#1654) Featuring bonus rod removal and carrying corpses removal! Fixes #1654 -------------------------------------------------------------------------------- 311257cc98 | wheals | 2020-12-23 15:39:20 +0200 Checkwhite -------------------------------------------------------------------------------- 1cd98bb67f | wheals | 2020-12-23 15:39:20 +0200 Put the cursor back in the X menu on Windows (#1536) See the comments on the PR. As aidanh mentions, cursor_control is a blunt force instrument that needs to be manually turned on and off here, but my naive attempts to enable the cursor only when the map cursor is being drawn didn't work -- it seems that it gets redrawn at odd moments, and that ends up wiping the cursor away. I didn't bother to make use_fake_cursor work here, because it already was broken for the direction chooser anyway. If we ever hear about someone using it on Windows, we can fix it, but it seems like it only fixes a Unix-specific problem. I'd wait for a more thorough fix, but this is a game-breaking bug on Windows console and we have a release coming up. Fixes #1536 This also incidentally fixes a related problem where the cursor appeared when opening up sub-menus from the direction chooser. -------------------------------------------------------------------------------- f5cede1358 | wheals | 2020-12-23 15:39:20 +0200 Fix a warning when compiling for Windows -------------------------------------------------------------------------------- b26aebe080 | Nikolai Lavsky | 2020-12-23 14:05:50 +0200 Update Drain status description After 4cbea82f, Drain temporarily reduces max HP instead of skills. -------------------------------------------------------------------------------- d3bf34ba6f | Quipyowert2 | 2020-12-23 11:00:08 +0200 Pass some parameters by reference According to Cppcheck, this is "usually faster" than passing by value and "recommended in C++." -------------------------------------------------------------------------------- 1a551d6a14 | advil | 2020-12-22 19:05:21 -0500 lint -------------------------------------------------------------------------------- bed68805ea | advil | 2020-12-22 18:45:59 -0500 Refactor quiver redraw state This fixes some bugs where the launcher quiver wasn't getting properly redrawn, but also provides some abstraction over the raw booleans stored on `you`. -------------------------------------------------------------------------------- 4a6b093f05 | advil | 2020-12-22 18:45:59 -0500 Add a basic menu to macro/keybind editing Especially for online play, it's extremely annoying that there's no way to view current macro/keymap mappings without going key by key. This commit solves that by putting a real submenu behind the `~` options, letting you see all current macros/keybinds (of the same type) at once. It also does some light refactoring of how some of the options are chosen, and will involve an extra keypress for new macros (or more for keys that are used in the menu ui). This menu is very much at the minimal viable ui state: I didn't widgetify anything except the key/macro selection part, and there's a *lot* more one could do with this to give it a real ui. However, for now it's a net improvement. -------------------------------------------------------------------------------- 0398aca569 | gammafunk | 2020-12-22 11:23:57 -0600 Some fixes and cleanups for winding_woodlands Fix the glyphing for nzn_winding_woodlands_large and nzn_winding_woodlands_stair_trap, which had some incorrect subvault glyphs that would never let the maps successfully place. Empty the default-depth before the subvaults are defined so they won't inherit the prior default depth used by the parent vaults. Parent vaults that tried to place in Swamp weren't able to find viable subvaults, since the default depth doesn't include the Swamp branch. Having an empty depth will allow the subvaults to place anywhere the parent map requires, and the parent map will still be subject to the restrictions of the previous default depth at the beginning of the file. Finally, clean up some NSUBST and SUBST syntax. Closes #1610. -------------------------------------------------------------------------------- 0da4609bc0 | gammafunk | 2020-12-22 11:22:51 -0600 Some minivault adjustments For nzn_sisyphean_effort and nzn_prometheus_bound, have the placed corpse on a delayed decay instead of never decaying. For the Prometheus vault, place a Book of Fire instead of a Book of Flames, since the former is a more appropriate reward in Shoals and just as thematically appropriate. For nzn_life_drinkers, simply clean up some SUBST. This vault could place as an overflow altar with low weight for D:8-9. In Vaults, ideally it would be tagged as a vaults room so that it could place successfully more often. It works fine as a standalone altar vault altar and can successfully place in Vaults per wizmode tests, so I can save both potential changes for some time before the 0.26 release. -------------------------------------------------------------------------------- 7ffe4a26f1 | gammafunk | 2020-12-22 11:18:06 -0600 Some adjustments to new overflow altars For nzn_hepliaklqana_mist_gate and nzn_wu_jian_contemplation some minor simplifications and spacing cleanups. For nzn_makhleb_speed_demon, replace the executioner with a sixfirhy, since an executioner is basically worse than any possible 8 spawn for D:7-D:11. A sixfirhy is quite fast and dangerous for these same depths, but not so much that no character would reasonably open the vault to get to the Makhleb altar. For nzn_overflow_gifts_of_might_and_magic, revamp the Trog-themed weapon to add enchant at the earliest depth and have Trog-themed brands (so vorpal, flaming, or antimagic) but no enchant at subsequent depths. This way the Trog item offering isn't so meagre compared to the Sif item, which gifts a small number of low-level spells. -------------------------------------------------------------------------------- 03f78f3749 | gammafunk | 2020-12-22 11:18:06 -0600 Some changes to the new Swamp end vault For nzn_swamp_witches_coven, add deep elf mages to the "wizard" set and reduce the weighting for spriggan druids, giving their previously double weight to the mages and to the wizards that previously had half weight. Druids have a somewhat harder time in this vault since there are so few trees, so it's best to not place so many of them. For the inner areas that randomly get shallow water, land, or monsters, increase the amount of land by 50% and decrease the amount of water. This vault previously placed an awful lot of water without very much land. Some tests with the new weight shows that there is still mostly water with relatively few tiles safe from trees, but it's not going to be quite so hard to find an area to fight inside the vault. Otherwise the incentive is to clear nearly all of the vault from outside. Also, make the inner pentagram walls use special dark stone wall tiles that more strongly suggest a demonic theme, using magenta for these walls in console. This is purely a cosmetic change with no affect on gameplay. Finally, make the central granite statue always use a demonic-themed tile. -------------------------------------------------------------------------------- 0369a3af90 | gammafunk | 2020-12-22 11:18:06 -0600 Some Swamp vault fixes and cleanups Make vault statements in a number of vaults have aligned spacing, and remove no_item_gen where not necessary. Although placing additional level monsters in a vault can make it harder and dilute its theme in some cases, no_item_gen doesn't generally affect these aspects. It's better to allow level item generation to be natural when possible and have fewer spoilers. For nzn_swamp_weyward_sisters, expand its placement from Swamp:3- to Swamp:2 and give it normal weight. Although a few fenstrider witches is scary, these monsters place with decent weight from Swamp:1 as it is. Put the peaceful human behind a runed door, since otherwise it will open the door and probably die while attacking one of the witches. Make the placed corpses and skeletons all have a delayed decay like we usually do for these vault corpses. Finally make some slight syntax cleanups. For nzn_swamp_blast_mining, reglyph to use no predefined glyphs and simplify the monster placement logic. The previous logic was more complicated didn't quite agree with the stated averages in the comments. Use two NSUBST to simplify the logic instead of a SHUFFLE and two SUBST. For nzn_swamp_dancing_lights, remove the down-weighting, as this is not a particularly nasty vault, and simplify syntax. -------------------------------------------------------------------------------- 52eb5f666a | gammafunk | 2020-12-22 11:17:59 -0600 Some cleanups to a ghost vault For nzn_ghosts_randoct, rename it to nzn_ghost_randoct for consistency with our other vaults and reglyph it to not use any predefined glyphs. Simplify some shuffles into substs, then combine related statements into one line. -------------------------------------------------------------------------------- 645eec8e50 | nikheizen | 2020-12-22 11:09:47 -0600 Add one (1) ghost vault Per request of gammafunk, a nasty ghost/transporter vault which becomes nastier and deeper depending on branch/depth. -------------------------------------------------------------------------------- 23317d3c2e | nikheizen | 2020-12-22 11:09:47 -0600 Adjust the weight of a couple nzn vaults speed_demon should be vanishingly rare since most folks won't be opening it. the swamp exclusive winding_woodlands center vault has been made twice as likely to accomodate for how rarely a valid vault for it to be selected in will even place. -------------------------------------------------------------------------------- 11aabd67dd | nikheizen | 2020-12-22 11:09:47 -0600 Add 4 swamp vaults and one new swamp endvault weyward_sisters: A trio of witches. One captures the men, one cooks them, and one gives their bones so that the mushrooms may grow. stair_ambush: Does what it says on the tin. blast_mining: Bloated husks have some practical applications. dancing_lights: A trio of will-o-the-wisps with accompanying fog machines for that spooky swamp feeling. All of these aside stair_ambush are weighted 5 either because they are gimmicky (blast_mining) or are quite deadly. witches_coven: A standard coven (or baker's dozen) of witches, congregating around the decaying rune and summoning demons in an inverted pentagram-shaped facility. -------------------------------------------------------------------------------- 3f1a12a7b5 | nikheizen | 2020-12-22 11:09:47 -0600 Winding Woodlands: forest-themed subvault maps Winding Woodlands are a set of maps which heavily utilize subvaults and have a woodland/forest theme (when the subvaults aren't simple geometric shapes). As of this commit there are 8 maps with 41 subvaults for said maps to draw from. -------------------------------------------------------------------------------- 5f9ebbf6ab | nikheizen | 2020-12-22 11:09:47 -0600 Add two vaults based off of Greek Myth (Silurio) The two myths referenced are Prometheus Bound and Sisyphus. Even if the intention of the flavour misses, these still have enough "anonymous" flavour to be somewhat interesting. -------------------------------------------------------------------------------- d5a4c4202e | nikheizen | 2020-12-22 11:09:47 -0600 Add 7 altar vaults - hepliaklqana_mist_gate: simple thematic hep vault where the player must peer into the past - makhleb_speed_demon: only the quickest warriors deserve makhleb's favour. bit of a meta reference to speedrunning the game. idea stolen from hellmonk - wu_jian_council_hall: simple wjc vault where the likeness of the council members look down upon their altar - wu_jian_contemplation: an idyllic shrine whose maintainer is now absent - overflow_gifts_of_might_and_magic: dual trog/sif overflow lightly themed on their shared attribute of gifting - overflow_masters_of_martial_movement: dual WJC/uskayaw mini. prove your worthiness by dancing around this boulder beetle - life_drinkers: vampiric philosophers have long pondered on makhleb and the shining ones penchant for healing devout worshippers when they kill -------------------------------------------------------------------------------- 1e22815bdb | gammafunk | 2020-12-22 11:09:47 -0600 Make a lua vault function more widely available Move random_item_def() to dungeon.lua, so it can be used by vaults other than ghost vaults. A subsequent commit will use this function for an overflow altar vault. -------------------------------------------------------------------------------- 660b328956 | gammafunk | 2020-12-22 11:09:37 -0600 Don't let Gauntlet room monsters pickup loot (Yermak) Now that all monsters generate awake in Gauntlet, certain intelligent monsters might pick up the loot they find before the player first sees it. This was also possible before they generated awake, for example if noise from combat woke up monsters in other rooms, but now it's especially common. In any case, it was always intentional that players would get full information about the loot in rooms for decision-making purposes and that they'd get access to those rewards without e.g. monsters using consumables. This commit marks all room loot as no_pickup. The minotaur's loot pile does not have this tag, so this monster still has its access to some choice gear. It would be ideal if no_pickup could be set vault-wide for items and possibly also using KMASK. For now, I've modified all item statement to programmatically add "no_pickup" in a way that should be pretty resistant to breakage. I had to redefine * and | as "star_item no_pickup" and "superb_item no_pickup" using KITEM, and have likewise done this for the % and $ glyphs, even those are not currently used. -------------------------------------------------------------------------------- 3780a7a11b | advil | 2020-12-21 21:45:05 -0500 Remove an island from due_jungle_book (12364) This island is kind of pointless as far as I can tell, because the anaconda can travel through water. Is it possible that this vault precedes b98e291e80b1? -------------------------------------------------------------------------------- 0dbc5c1aff | advil | 2020-12-21 20:39:43 -0500 Don't feel safe on hexers trapped in grates (12371, #1651) If a monster had only non-damaging ranged spells and was trapped in grates (or water, etc), this code would register that the monster could not hurt the player. This is narrowly true, but because this function is used for i_feel_safe, the monster would not count as a threat for the player under various broader conditions, notably, autotravel. The specific buggy case that has come up in several reports is draining eyes, which don't damage the player but do of course drain mp; in other circumstances they register as dangerous by having a foe path to the player. In 0.25, `explore_auto_rest` became default true, and so if the player autotraveled into los of a trapped draining eye, they would enter a perpetual rest + drain cycle because i_feel_safe returned true, running up the clock until they interrupted it. This is even worse for players who have a force_more on the drain message (e.g. ones using HDA's rc as in #1651) because it is hard to interrupt the loop. It's also compounded by the lack of hunger: in 12371 the player got out of the autoexplore loop when they became hungry, which can't happen any more. The change is to construe "hurt" for this function's purposes more broadly, to include any dangerous ranged spells regardless of whether they are attacks; it's used only for autoexplore and as a minor check on tension. It's possible this will stop autoexplore incorrectly in some cases I haven't thought of, but it can be fine-tuned from here. Resolves #1651 -------------------------------------------------------------------------------- f5f8a83f67 | advil | 2020-12-21 14:46:09 -0500 Change the quiver verb for tremorstones "Throw" was more consistent with a previous version of tremorstones' flavor, and also confusing together with actual throwing. -------------------------------------------------------------------------------- 0927c67384 | advil | 2020-12-21 14:46:09 -0500 Allow quivering evokables from inventory -------------------------------------------------------------------------------- d6649fcddf | advil | 2020-12-21 14:46:09 -0500 Fix some ammo_to_action logic (12414) -------------------------------------------------------------------------------- fb7421ae72 | wheals | 2020-12-21 21:16:06 +0200 Avoid a crash when using OTR and worshipping Beogh -------------------------------------------------------------------------------- 244d27527d | advil | 2020-12-21 13:31:14 -0500 Remove some broken local tiles clicking stuff This has been broken in an unusable way since c3daa31c0c (about two years) because of the incorrect use of testbits, and even fixing that these features are still pretty unusable in my testing. They are also now somewhat redundant with the quiver features. I think something like the previous behavior of ctrl-click and alt-click could be a good thing to have, but it needs to be rewritten (perhaps using the actions api) and restructured to be less redundant. One idea in the long run might be to have these extra click combos access more quivers, or quivers that are spell and evocable specific (similar to the launcher quiver). Given how broken this has been, I'm just removing for now, the main place to notice a difference will be that ctrl-click on the player will now not lead to broken/confusing behavior with targeted spells. There's shift-click to cast/evoke from the new quiver, and also still a click-to-cast interface in the sidebar for local tiles. -------------------------------------------------------------------------------- 5068850a46 | advil | 2020-12-21 13:20:18 -0500 Fix a bunch of local tiles clicking stuff We got a report that e42c0a684a0 broke click-to-throw. I'm still not sure what this report was about, but on looking into this, I found any number of things broken about clicking-related stuff. Some of this is related to quivers, some is older. This commit fixes at least the following bugs: * The tooltip info was a mess and often wrong * Some of the conditions for whether to report "Travel" tooltips were out of sync with the travel code * open door tooltips were being calculated wrong * quivers were being triggered, but by passing key commands to the fire interface, rather tha by setting a target directly * On shift-click to cast with too low mana, a bunch of key errors were printed * primary attacks with launchers weren't handled correctly, and only triggered movement -------------------------------------------------------------------------------- 7d2dc893a1 | advil | 2020-12-20 19:49:18 -0500 Do basic deduplication when rendering tile overlays This is very minimal: it just prevents stacking completely adjacent identical overlays. This is intended to handle cases with large numbers of bennus (e.g. in a zig) where many, many explosions can get stacked on top of each other; in these cases, the number of overlays was easily reaching the cap (20) which causes a crash. Since layering these overlays does nothing, simply prevent it. If this system is ever used to layer overlays with alpha values, this may have unexpected effects, but to my knowledge it isn't. -------------------------------------------------------------------------------- ef23d1325b | gammafunk | 2020-12-20 13:51:32 -0600 Incredibly, another food removal cleanup Need a TAG_MAJORed removal of the food glyph for the other character set. -------------------------------------------------------------------------------- 35d1ec1c0b | gammafunk | 2020-12-20 12:36:32 -0600 More food removal cleanups The previous commits missed food items in header files needing removal or TAG_MAJOR. Comments related to chunks cleaned up to avoid implying that the chunk item still exists, however leave in terminology using "chunks" for calculations based on monster size for purposes of blood and gozag gold splatter. I've updated MSVC, Xcode, and Android project files to remove references to food-related source files that no longer exist. Hopefully these have been done correctly, but that will need confirmation from people who use these files. -------------------------------------------------------------------------------- b172a1b426 | gammafunk | 2020-12-20 07:44:43 -0600 Add a TAG_MAJOR for a food-related enum value -------------------------------------------------------------------------------- 8e97bb7ff4 | gammafunk | 2020-12-20 07:02:48 -0600 Make a function static -------------------------------------------------------------------------------- bb79e0bfc8 | gammafunk | 2020-12-20 06:53:18 -0600 Some cleanup related to food removal Remove food as a choice for the &o command, update comments to remove references to food, and add TAG_MAJOR to various bits of food code. -------------------------------------------------------------------------------- e73896bf99 | randomMesh | 2020-12-20 03:52:37 -0800 Fix link to quickstart.md -------------------------------------------------------------------------------- e9770dfcb6 | Nicholas Feinberg | 2020-12-18 21:46:06 -0800 Show wand damage in item descriptions -------------------------------------------------------------------------------- 5f66e2dd50 | advil | 2020-12-18 13:37:49 -0500 Skip `cancel_ice_move` prompt with no monsters in los This simplifies one case where this prompt is a bit annoying; I guess these prompts could alternatively be made configurable. -------------------------------------------------------------------------------- 3ccbe7bdff | Nicholas Feinberg | 2020-12-18 09:51:50 -0800 Fix Chei's Zot slowing (Ge0ff) -------------------------------------------------------------------------------- c5df7fbe6a | Edgar A. Bering IV | 2020-12-17 11:31:41 +0200 Revise the sword of Power (kate-) The variable plus of the old SoP encouraged swapping at low health, and while getting a giant plus (+27!) could be fun with berserk or Ely, the lack of a brand and declining plus at lower health made it not that attractive. Instead, the sword becomes a fixed plus +5 vorpal greatsword that fires a "sword beam" reminiscient of the old bolt of inaccuracy on a chance depending on the wielder's current health. While this still falls off at low HP, ones HP must be very low indeed for this to become a bad weapon. The numbers could probably use some further tweaking. -------------------------------------------------------------------------------- ff409d549a | Edgar A. Bering IV | 2020-12-17 11:31:41 +0200 Tweak some use of second person -------------------------------------------------------------------------------- 3270b6ecf3 | Edgar A. Bering IV | 2020-12-17 11:31:41 +0200 End the glaive of the Guard's specter on unwield -------------------------------------------------------------------------------- 3318b609a0 | Goratrix | 2020-12-17 07:19:20 +0200 Small corrections in the manual Replace Centaurs with Palentongas in size description, change WL to Will, remove note about ghosts not using stairs, clarify traps, add max hp to monster description. -------------------------------------------------------------------------------- 8117e51712 | advil | 2020-12-16 22:08:42 -0500 Improve a corner case for `F` When `F` is pressed with no throwables, the game opens the full inventory. This seems (maybe) sensible, but it doesn't really cue that it's done anything out of the ordinary, so this commit removes the special case from invent.cc and changes the menu prompt to try to indicate this. -------------------------------------------------------------------------------- e42c0a684a | advil | 2020-12-16 22:08:42 -0500 Separate launcher from throwing actions The main reason for this is so to differentiate throwing stones from launching stones, leading to better behavior on switching between a sling and melee weapon. It has the slightly odd result that you can quiver stones for throwing while wielding a launcher, which used to be impsosible, but this seems mostly harmless? This commit also removes the ranged side of auto_switch. As far as I can tell, this only ever worked when the quiver was empty, making it almost entirely useless even before the quiver improvements to launching. Now, there's always a way to fire a wielded launcher regardless of quiver state. If someone can tell me there's a use case I am missing I can try to restore it. This option still works as before for melee weapons. -------------------------------------------------------------------------------- 46f0d4f399 | Nicholas Feinberg | 2020-12-16 17:32:09 -0800 Tweak a Ru message again (Dug) Probably someone else will come by in a moment and change this again. -------------------------------------------------------------------------------- 92de7bf30a | Nicholas Feinberg | 2020-12-16 17:21:27 -0800 Remove Ru's will (gressup) Rephrase a Ru message to avoid confusion with the Will stat. Missed this one in ebc406137e . -------------------------------------------------------------------------------- e913e73dd2 | Nicholas Feinberg | 2020-12-16 16:57:50 -0800 Add power_perc to lua table (advil) -------------------------------------------------------------------------------- a1b6d6fda9 | advil | 2020-12-16 17:29:20 -0500 Handle lack of quiverable actions better Don't let submenus work if they would be empty, and in the extreme limiting case, don't let the main Q menu work either. -------------------------------------------------------------------------------- b8f0b9b9d7 | advil | 2020-12-16 17:29:20 -0500 Allow quivering usk abilities with low piety This is very special case-y, but otherwise the non-stomp ones might as well not be quiverable. Possibly most religious abilities should work like this? -------------------------------------------------------------------------------- 624b3b4e76 | Edgar A. Bering IV | 2020-12-16 22:55:23 +0200 Give the cloak of Starlight a dazzling effect (amcnicky) This is a different take on the submission in #1572 to make the cloak of Starlight more interesting than a cloak with a few artefact properties and a nice tile. This commit removes the resist stack, but keeps the stealth malus and EV. In exchange it now grants a passive "Dazzle" effect: on one out of 5 dodges it attempts to blind the attacker, using the same code path and roll as dazzling flash at power 100. This puts it in contrast to the other unrand cloaks which grant their passive effect on hit. Closes #1572 -------------------------------------------------------------------------------- f92616641d | sdynet | 2020-12-16 22:55:23 +0200 Add spectral to the glaive of the Guard and adjust There are already two dual-brand unrands, but spectral is a mechanically distinct enough brand that a spectral+brand weapon doesn't crowd the space too much. Additionally, it's a nice throwback to old spectral weapon which worked on just about everything. This commit also strips the extra properties (other than AC) from the Glaive and lowers its plus. [ Committer's note: Closes #1598. Revised the patch to do the dual-brand and re-wrote the commit message. ] -------------------------------------------------------------------------------- d46cc9e92b | advil | 2020-12-16 14:07:03 -0500 Refactor your_talents somewhat Previously, to check if the player had an ability, you needed to construct the entire talents list and see if the ability is there. This separates out code that checks whether a player has an ability from your_talents so that it can be directly called in a less overkill fashion. There's further refactoring along these lines that would be possible, for god abilities in particular. This commit also tweaks some flight logic in a way that hopefully doesn't break it, but it seemed to be subtly wrong before. -------------------------------------------------------------------------------- c8f2f48a6c | advil | 2020-12-16 14:07:03 -0500 Add a hint about `f` for untargeted direction choosers I think it's otherwise not entirely obvious that you trigger these in the same way as targeted direction choosers. (Especially unclear for abilities that don't have a targeter yet.) -------------------------------------------------------------------------------- 80e58933c0 | Nicholas Feinberg | 2020-12-16 09:45:53 -0800 Display Frozen Ramparts damage Since this doesn't check AC, I think the delay scaling doesn't matter much. The displayed number being low hopefully won't mislead people too much... -------------------------------------------------------------------------------- faeb9f6368 | Nicholas Feinberg | 2020-12-16 09:45:44 -0800 Remove an unused function -------------------------------------------------------------------------------- 1040278a39 | Nicholas Feinberg | 2020-12-16 09:21:05 -0800 Replace spellpower bars with %s Spellpower bars are notoriously complex and unintuitive. They follow a hand-calibrated, strongly nonlinear scale (0, 10, 15, 25...?), which isn't particularly helpful to players. Why should anyone expect that going from .... ..... to #### ###.. would have the same effect on a spell's, well, power as going from #### ###.. to #### #####? One big reason for the nonlinear scale is to allow players to see progress at low spellpower without blowing up to a huge number of bars at high power, but there's a much simpler way to represent that. Let's just show the % of max spellpower instead. -------------------------------------------------------------------------------- be8bfa9c7c | Nicholas Feinberg | 2020-12-16 09:21:05 -0800 Remove rotten meat Farewell, obsolete message channels! -------------------------------------------------------------------------------- e48705eb17 | Edgar A. Bering IV | 2020-12-16 11:38:44 +0200 Make frozen ramparts end on movement Frozen Ramparts' combination of damage over time and area of effect made it one of the most powerful single school L3 spells. On its own, this isn't necessarily a bad thing as it is not overpowered as a L3 spell. However, FR encourages motion, which is an anti-synergy with another low level Ice spell: Ozocubu's Armour. This tension combined with FR's high power-level and the average overall high power-level of Ice spells motivates changing FR to end on movement (the exact rules are the same as Ozocubu's armour: blinking and getting trampled don't end it). -------------------------------------------------------------------------------- 01e01ebfeb | Edgar A. Bering IV | 2020-12-16 11:22:37 +0200 Make shaft self consistent with '>' on a shaft Formicids could shaft themselves with the ability and not apply barbs or break Ozocubu's armour, even though the ability description states they should be equivalent. This commit also re-orders barbs application and ice armour breaking for any floor_transition that triggers them, so that messaging is consistent with the message order when moving. -------------------------------------------------------------------------------- b90401cf1a | Edgar A. Bering IV | 2020-12-16 10:48:22 +0200 Prompt before ending Ozocubu's Armour (gammafunk) From conversations with gammafunk and also other players and my own experience, my cancellation of Ozo's armour by movement is more often inadvertent than an intentional decision. Add some ui ergonomics for this. I didn't add an rc option for whether or not to prompt: we already have the answer prompt lua callback, and from that players who want the prompt auto-answered one way or the other (or in a context-sensitive way) can configure the behavior to their hearts delight. -------------------------------------------------------------------------------- 6118521029 | advil | 2020-12-15 19:24:26 -0500 Cache quiver spell colors This is fixing the same issue as 64875d052978. Like enabled status, quiver color indirectly calls spell_uselessness_reason, which for beam spells, can have weird side effects if triggered at the wrong time. In the particular crashes I was looking at it appears that there was a fairly complex sequence of side effects roughly like, explosion -> redraw -> quiver description -> quiver color -> tracer -> messaging (??) -> more -> quiver description -> tracer -> crash on an invalid monster. (https://crawl.kelbi.org/crawl/morgue/AlmondAAA/crash-AlmondAAA-20201215-234651. txt) -------------------------------------------------------------------------------- 6dfc622489 | advil | 2020-12-15 15:28:34 -0500 Fix LO/Djinn upgrade prompt Broken since 2ba9a4ce9b5bfb, I think. `yes_or_no` no longer will work before game start, so reimplemented as a yesno popup. -------------------------------------------------------------------------------- 4387980181 | advil | 2020-12-15 15:05:20 -0500 Fix a bunch of static targeter + invis issues This also fixes an earlier bug where absolute zero could be used to reveal whether there were invisible monsters, just not their location. Resolves #1641 -------------------------------------------------------------------------------- f3604ea6ed | advil | 2020-12-15 09:57:06 -0500 Fix launcher ammo starts (12405) Something about the ng-setup order is causing this that I still don't quite understand, but explicitly setting the launcher quiver works. -------------------------------------------------------------------------------- 6f3817b27c | advil | 2020-12-15 09:57:06 -0500 Make some zot messages less flavorful but more direct -------------------------------------------------------------------------------- 347fe5baa7 | Edgar A. Bering IV | 2020-12-15 08:32:48 +0200 Update the credits -------------------------------------------------------------------------------- 8f9f7f7418 | advil | 2020-12-14 11:55:28 -0500 Fix webtiles tooltips for statuses with counts Statuses like "Flay (-7)" and "Zot (999)" had their tooltips broken, because the lookup was using this full string. Instead, split at the space. This commit also adds some text when there is no description so that it is more apparent that there should be a tooltip (before, a tiny empty box was displayed). -------------------------------------------------------------------------------- 5cc43298a2 | Nicholas Feinberg | 2020-12-14 08:23:46 -0800 More WL -> Will (Goratrix) Consistent terminology for player-facing messaging. I'm intentionally leaving the player -> monster hex targeter with a different message ('chance to affect') than the monster -> hex messaging ('chance to defeat your Will'). The latter feels quite awkward in the targeter, and I think it's maybe OK to be a little less specific on what's going on under the hood. We'll see! -------------------------------------------------------------------------------- 76350e28a0 | gammafunk | 2020-12-14 09:00:01 -0600 Some ghoul updates for the manual -------------------------------------------------------------------------------- aeb50157f9 | Edgar A. Bering IV | 2020-12-14 16:59:46 +0200 Update credits -------------------------------------------------------------------------------- 2a23cb0dbd | AdamPG | 2020-12-14 16:57:03 +0200 Update species creation documentation to remove hungry undead [ Committer's note: Closes #1642. Remainder of the PR was handled in earlier commits. ] -------------------------------------------------------------------------------- 3b44033db3 | gammafunk | 2020-12-14 08:46:18 -0600 Fix some outdated references to hungry ghouls In source comments, our species code generation script, and in objstat. -------------------------------------------------------------------------------- 0998834371 | gammafunk | 2020-12-14 08:35:00 -0600 Fix ghouls not being able to use potions (PR 1642) The removal of the notion of "hungry undead" didn't update the logic that assumed all "pure" undead can't use potions. Such undead were previously only mummies or temporary lich form, but now it includes ghouls. This commit fixes the logic in the obvious way for now, but the undead-state-type likely enum needs a refactor, as its not doing a great job of giving proper undead knowledge at present. I'm not working with the referenced PR given the source, but will leave it open should anyone else wish to. -------------------------------------------------------------------------------- db0aba6efe | gammafunk | 2020-12-14 07:41:52 -0600 Hopefully fix an HP display bug (elliptic) A bug in the HUD display of HP can occur when restoring maximum HP from drain by gaining XP. I couldn't recreate this bug, but it can be seen at frame 2125 of this ttyrec: https://crawl.kelbi.org/crawl/ttyrec/elliptic/2020-12-13.23:29:18.ttyrec.bz2 It likely happens because the code to handle restoring drained MHP from XP gain first calls calc_hp() to recalculate max HP but then only zeros the max HP adjustment after this recalculation. Hence max hit points will have an incorrect value until it is recalculated again. This commit moves the recalculation after any change to the drain mhp adjustment, which should fix the bug. -------------------------------------------------------------------------------- 8436896e56 | Peter Gerlagh | 2020-12-14 14:41:16 +0200 Allow any floor to be annotated with ! Improve the Annotate interface such that any dungeon floor can be annotated from anywhere. From the main view and the dungeon-overview, pressing ! will bring up a menu allowing you to choose which floor to annotate. From the control-X view, ! will cause you to annotate the level you are currently looking at. ! has a functional help menu. The shortcuts are . and Enter for the current level, < and > for the level above and below respectively, and control-P in annalogy with inter-level travel. The list of dungeon branches (with abreviations) is only shown when the player presses ! a second time. You can only annotate dungeon branches of which you have found the entrance, to prevent information leaking. do_annotate(level_id) has been renamed annotate_level, and annotate_level() has been renamed do_annotate. [ Committer's note: Closes #1369. Squashed and rebased, tweaked some assert logic. ] -------------------------------------------------------------------------------- f5ace97b37 | paul | 2020-12-14 12:49:57 +0200 A new overflow vault for Gozag and Zin This vault is an idea inspired by zin_treasury that I thought could be an amusing play on the contrast between Zin and Gozag. Gozag tempts the player with a single-charged wand of digging to steal a negligible amount of gold from Zin's treasury just for the sake of it. [ Committer's note: Closes #1627. Tweaked commit message. ] -------------------------------------------------------------------------------- 195573c5ca | Marcelo Henrique Cerri | 2020-12-14 10:15:58 +0200 Add options to control display of the message window overlay Add two new options, tile_overlay_col and tile_overlay_alpha_percent, to control the background of the message window overlay. The default color follows the same hard coded value used before while alpha was rounded to the closest round percentage number. The previous alpha value was 100 (in the 0-255 range), while the 40% new default should be equivalent to 102. [ Committer's note: Closes #1557 ] -------------------------------------------------------------------------------- b926618e39 | mgdelmonte | 2020-12-14 10:06:03 +0200 Add c_message lua hook This hook is called for each message sent to the message window, as an alternative to fetching the last n messages (where n is a guess) with `crawl.message`. [ Committer's note: Closes #1563. Tweaked commit message and elaborated documentation. ] -------------------------------------------------------------------------------- 9a8e32e9ec | Nikolai Lavsky | 2020-12-14 09:41:38 +0200 Correct some typos -------------------------------------------------------------------------------- 7ac5835353 | Nikolai Lavsky | 2020-12-14 09:41:38 +0200 Remove obsolete ability and status descriptions -------------------------------------------------------------------------------- 129ca1ddcb | Nikolai Lavsky | 2020-12-14 09:41:05 +0200 Remove obsolete stash search prefixes -------------------------------------------------------------------------------- 9010512d90 | Nikolai Lavsky | 2020-12-14 09:08:44 +0200 Fix Shaft Self description Shaft Self has an equal chance of taking the player 1, 2, or 3 levels down. -------------------------------------------------------------------------------- 18a83ce318 | Nikolai Lavsky | 2020-12-14 09:06:22 +0200 Fix autofight not prioritizing petrified enemies After 9c76b8a6, there are only two stabbing tiers. Also, the player gets a top-tier stab bonus when attacking petrified enemies. This commit updates autofight rules so petrified enemies get the same priority as sleeping or paralysed ones. -------------------------------------------------------------------------------- fb05d25666 | Heinrich Ody | 2020-12-14 09:02:36 +0200 Add details for playing sounds via regular expressions Clarify sound documentation. [ Closes #1630 ] -------------------------------------------------------------------------------- ce247c04e0 | Nikolai Lavsky | 2020-12-14 08:59:30 +0200 Actually stop the Zot clock when it should be paused or stopped The Zot clock ticks even when in the Abyss, during the orb run, and in Sprint mode. It cannot kill the player, but `turns_until_zot()` showing a negative number of turns left in `E` looks like a bug. Also, this commits tweaks the messaging about the Zot clock in `E`. [ Committer's note: Closes #1634. Tweaked some style. ] -------------------------------------------------------------------------------- 0a719521bf | Nikolai Lavsky | 2020-12-14 08:59:02 +0200 Add a wizard command to set the Zot clock Even though it is already possible to get more Zot time using the `&H` command, a wizard command to set the number of remaining turns still might be useful. -------------------------------------------------------------------------------- a2fc0b5f9f | Edgar A. Bering IV | 2020-12-14 08:44:16 +0200 Use references in some ranged fors This silences a clang warning and also prevents unneccessary copying of coord_defs in ranged for constructions. -------------------------------------------------------------------------------- 4c0aae810e | Nicholas Feinberg | 2020-12-13 18:26:57 -0800 Fix Irradiate damage (Midn8) Broken in 4140fda2ff28. -------------------------------------------------------------------------------- 3a4175ecf3 | gammafunk | 2020-12-13 15:09:05 -0600 Some more changelog updates -------------------------------------------------------------------------------- d9a99272a7 | gammafunk | 2020-12-13 15:02:17 -0600 Remove unused hint code instead of using TAG MAJOR The enums aren't marshalled and these hints can't be triggered (and hints mode would ignore them even if they could be triggered). -------------------------------------------------------------------------------- 4cbea82fa3 | gammafunk | 2020-12-13 15:02:02 -0600 Rework player drain to temporary max HP reduction The UI cost of player drain is high, since not only might you need to check your skills after each drain and restoration of drain, you might also have to check spellcasting and ability fail rates. It's also relatively complex for the player to reason about the impact of draining all skills some fixed amount of skill levels, since the effects of level changes vary widely by skill and there are so many skills. This isn't a great design for a player debuff that's frequently applied and restored over fairly short numbers of turns. Max HP reduction has a natural spot on the HUD, requires no menu checks, is much easier for the player to reason about, and is a universally effective cost. Hence this commit reworks player drain to temporarily reduce max HP instead of skills. The drained max HP is restored as the player gains experience, just as before with the old system. Drain applied to monsters is unchanged, with that effect remaining as a stackable HD reduction applied in the same fixed amount regardless of damage. For player drain from melee or beams, I've made the formula more directly use damage done, but still applying at least one point of MHP drain for any non-zero drain power. These attacks always apply a drain power of one even if no damage is dealt. Other drain costs use the same cost values as before (e.g. Ru Apocalypse is still 100), since the formulas scale such values appropriately. The formula for converting drain power to max hp reduction divides the power by six (using random rounding), then splits the resulting power into into two equal parts (up to rounding), one of which is used for a fuzzed component and the other for a component based on the player's current max HP. This is a balance between having a cost that doesn't consider MHP, which would be relatively stronger versus low MHP players and one that only uses MHP, which would be relatively stronger versus high MHP players. In my tests of melee, beam, and fixed costs abilities, the MHP reduction rates seem reasonable, but further play-testing might lead us to tweak the relevant formulas or ability drain costs. The new drain effect replaces the old rotting mechanic, and that mechanic is removed. Curing and heal wounds potions no longer have a secondary rot restoration effect. Miasma clouds lose the rotting portion of their effect, with the poison and slowing remaining unchanged. Monsters and players that permanently or temporarily had rot resistance now have miasma resistance instead. One exception to this is vinestalkers, which simply lose the rot resistance with no replacement, since they were only given it due their potion limitations. Monsters that had rotting melee attacks now have draining attacks instead. The cases of this are not notable aside from necrophages, which might need a rethink since they are not very effective monsters and we have so many monsters with af_drain. Zin Recite can no longer rot monsters, with the weight for that effect appropriately spread to other effects. I've updated all descriptions, references, and source comments to no longer reference rot, but as usual some may have been missed. -------------------------------------------------------------------------------- 1fec4fe3f8 | gammafunk | 2020-12-13 14:51:37 -0600 Remove the hungry dead undead type This was previously used for player ghouls when those rotted over time and required chunks to cure this. Now ghouls no longer rot, nor do they eat to restore HP, gaining XP from kills instead. Hence we reclassify ghouls as normal undead and remove their special undead subtype. -------------------------------------------------------------------------------- 7ab0d7dac8 | gammafunk | 2020-12-13 14:51:37 -0600 Remove an unused actor method argument -------------------------------------------------------------------------------- 89b3258002 | advil | 2020-12-13 11:36:45 -0500 Mention seeds in the issue template -------------------------------------------------------------------------------- 61de54256c | advil | 2020-12-13 10:56:56 -0500 Provide a way to use pkg-config on mac This commit adds a build setting `FORCE_PKGCONFIG` that if defined, overrides the default `NO_PKGCONFIG` setting for mac builds. Previously, doing something like this required editing the Makefile. This setting should be useful for things like homebrew that repackage crawl and patch the Makefile (see #1367). It may also be helpful for people trying to build on new apple ARM devices where our contrib version can't be updated far enough to provide direct support (though this is a bit speculative). A commit in #1367 suggests just always using pkg-config if available, but I don't think this is yet a good idea on mac. Because Apple doesn't itself provide it, there are at least 4 distinct ways that I know of to (often accidentally) get pkg-config installed, none of them are very standard or compatible, it is possible to get more than one version which interact badly (e.g. if you have both macports and anaconda, or homebrew and anaconda), and in my past testing they are just quite unreliable overall, probably exactly because they aren't widely used. In testing this current commit, I do seem to have succeeded in getting a succesful pkg-config build, but this is the first time. The contribs for mac builds, on the other hand, are extremely well-tested and reliable, and not at all sensitive to the various package managers that a mac user could have installed. So I think until this situation becomes a bit more stable (if ever), it is better to default to NO_PKGCONFIG and require the user to be aware that they are taking action to override using contribs. -------------------------------------------------------------------------------- cd3bf97d0b | Edgar A. Bering IV | 2020-12-13 17:27:06 +0200 Remove no_submerge from docs and des syntax highlighting -------------------------------------------------------------------------------- c6392dc34d | Edgar A. Bering IV | 2020-12-13 17:06:32 +0200 Remove the anti-cannibalism conduct (12368) With eating gone it looks weird and out of place. It still had an effect in what one could devour with hydra form while worshipping a good god. A lot of code for a small effect. Beoghites still don't eat fellow orcs, on accounnt of the corpse violation conduct and also the practical desire of preserving an orc corpse to resurrect them. -------------------------------------------------------------------------------- 320aac65f4 | Edgar A. Bering IV | 2020-12-13 16:52:39 +0200 Remove a reference to food (12368) -------------------------------------------------------------------------------- 0e109d3507 | Edgar A. Bering IV | 2020-12-13 16:30:25 +0200 Fix the organization of dc-mon.txt (12306) -------------------------------------------------------------------------------- 6b7d0433bc | Edgar A. Bering IV | 2020-12-13 16:30:25 +0200 Preserve Erica's custom scimitar (12199) Erica's tile has a custom firey scimitar, keep it even if she's managed to get an artefact. -------------------------------------------------------------------------------- 7c2e7382c0 | Edgar A. Bering IV | 2020-12-13 16:30:25 +0200 Source code cleanup (bcadren) Addresses mantis tickets: 12280 12281 12301 12358 12400 12404 removing dead or redundant code, simplifying execution, and correcting comments. -------------------------------------------------------------------------------- 2c94d5e1d5 | Edgar A. Bering IV | 2020-12-13 16:30:15 +0200 Vault cleanup (bcadren) Closes mantis tickets: 12251 12252 12253 12263 12271 12272 12369 These vaults had conditions on depth that no longer made sense, missing tags, or in one case the syntax suggested an altar placement that was missing. -------------------------------------------------------------------------------- 58b0234282 | Edgar A. Bering IV | 2020-12-13 16:25:46 +0200 Use feat_eliminates_items appropriately (12258, 12402) -------------------------------------------------------------------------------- b609fa9e76 | Edgar A. Bering IV | 2020-12-13 16:20:03 +0200 Remove the no_submerge fprop (12309) The only remaining submerging monster is the Kraken tentacle segment. This could also be removed but this batch of commits is collecting only small source cleanups. -------------------------------------------------------------------------------- ed47246d56 | Edgar A. Bering IV | 2020-12-13 16:20:03 +0200 Ground out retaliatory shocks (10990) -------------------------------------------------------------------------------- 00aba192f2 | Edgar A. Bering IV | 2020-12-13 13:20:34 +0200 Update the credits -------------------------------------------------------------------------------- d2882a9c4f | Edgar A. Bering IV | 2020-12-13 13:20:08 +0200 Update the changelog -------------------------------------------------------------------------------- 086102a3f0 | Nicholas Feinberg | 2020-12-12 18:38:56 -0800 Remove a redundant QSDA line Don't note that it can be enchanted to +0, because that's not very useful. -------------------------------------------------------------------------------- 78becf55bb | advil | 2020-12-12 18:34:09 -0500 Various tweaks to monster and spell descriptions This fixes a few apparent mistakes, and more cleanly aligns fields in both of these description popups. (The unifying factor is the internal use of `_print_bar`.) This commit involves a rather alarming nbsp replace on the javascript side to get these tweaks to render in webtiles, but on the other hand it does seem very plausible to me that any leading spaces in one of these popups will be intentional. -------------------------------------------------------------------------------- 8dc6ce00ff | advil | 2020-12-12 16:21:14 -0500 Implement -= for force_targeter (elliptic), consolidate options -= simply wasn't implemented before (and I didn't realize that unless you explicitly check for it it calls the += code). This commit also removes the `always_use_static_targeters` and replaces it with the possibility of passing `all` to `force_targeter`. For reasons of simplification I didn't for now implement -= working to whittle down spells after `all`. -------------------------------------------------------------------------------- 5b34608550 | advil | 2020-12-12 14:06:21 -0500 Try to fix the renounce to `X` mapping (10637) This can happen because `your_talents` is extremely side-effect-y, and if it can get called before `set_god_ability_slots`, it will actually set lettering for whatever god abilities appear to be available at 0 piety. There are various ways that this might happen, centering around the messaging on join. I suspect the original version of 10637 involved local tiles (where the ability buttons are constructed by calling `your_talents`), but the modern version of this is triggered by having an ability quivered when joining the god; a redraw on the messaging also calls `your_talents` when checking quiver enabled status. The best fix would be a more sane refactoring of how to check if the player has an ability, but this quick fix should prevent this particular problem. I won't be too shocked if this leads to crashes, because of weird join religion ordering effects; this is not unrelated to the crash fixed by ca8e9911413a. -------------------------------------------------------------------------------- 60470c10af | advil | 2020-12-12 13:26:52 -0500 Fix/improve programmatic spell memorisation Spell memorisation from lua has been semi-broken since the spell library, because it didn't correctly handle hidden spells or libraries greater than 52 elements. In addition, you previously needed to use sendkeys to memorise spells going by letter. This commit fixes you.mem_spells to just return a list of memorisable spells, no letters involved, and adds a lua function to memorise spells by name. Not sure whether this should be under `spells` or `you`, but I chose the latter. Resolves #1360 Resolves #1602 -------------------------------------------------------------------------------- 2c461ccb5f | Nicholas Feinberg | 2020-12-12 09:00:57 -0800 Clarify damage dice I'm not sure how helpful this is to people who aren't familiar with summing dice for damage, but maybe it's better than nothing...? Might be better to show mean/max, but we'd need a new format for that. -------------------------------------------------------------------------------- 95e0c7ddb8 | Nicholas Feinberg | 2020-12-12 08:25:08 -0800 New Swamp tiles, pt 1 (CanOfWorms) -------------------------------------------------------------------------------- aff5f71418 | Nicholas Feinberg | 2020-12-11 20:32:52 -0800 Display Mara's weapon in tiles (lici) This will probably cause some graphical glitches, but it seems better than nothing. -------------------------------------------------------------------------------- 4140fda2ff | Nicholas Feinberg | 2020-12-11 20:22:15 -0800 Make described spell damage deterministic (Midn8) For player and monster spells. -------------------------------------------------------------------------------- e0427eb064 | Nicholas Feinberg | 2020-12-11 19:57:07 -0800 Don't claim invis scarf makes you hungry (ParallaxScroll) -------------------------------------------------------------------------------- fd6a22a7ff | Nicholas Feinberg | 2020-12-11 15:17:28 -0800 Partially uncap displayed stealth (hellmonk, etc) Previously, displayed stealth was capped at 500, regardless of the player's actual stealth. It now displays much higher values, using this insanely and senselessly cryptic system: +......... = 1-50 ++........ = 51-100 ... ++++++++++ = 451-500 *+++++++++ = 501-550 **++++++++ = 551-600 ... ********** = 951-1000 ... ... !!!!!!!!!! = 1951+ With 27 armour + stealth, 120 SID, shadow dragon armour, full Dithmenos piety, and Shadow Form, I was able to hit the full !!!!!!!!!! stealth. Can you? -------------------------------------------------------------------------------- 242049e08c | Nicholas Feinberg | 2020-12-11 14:52:37 -0800 Add Woodweal synergy (canofworms) It seems very funny for them to be able to heal while adjacent to any tree, including shambling mangroves. Not *useful*, not particularly exciting game design, but funny! -------------------------------------------------------------------------------- e81342393e | Nicholas Feinberg | 2020-12-11 14:43:02 -0800 Add back-compat for MR search -------------------------------------------------------------------------------- 00712748bd | advil | 2020-12-11 17:06:58 -0500 Use bigger long brackets for lua rc parsing After parsing lua, it seems that this code just wraps non-lua code in long brackets. This causes problems when someone tries to use a keybind with `]` following some rc lua code, which involves writing `[]]`, which will close any long brackets in play. Using `[==[` should make it less likely that the closing bracket accidentally shows up. Resolves #971 -------------------------------------------------------------------------------- 368d90fffd | advil | 2020-12-11 15:50:47 -0500 Also protect unbreathing creatures from miasma (following e1f20c3b445d4e) -------------------------------------------------------------------------------- e1f20c3b44 | Heinrich Ody | 2020-12-11 15:48:13 -0500 Fix unbreathing bug Now, when it is checked whether an actor is immune to a cloud, for poison cloud we check for unbreathing. [Committer's note: resolves #1564] -------------------------------------------------------------------------------- 361d76ed6f | advil | 2020-12-11 15:32:15 -0500 Remove jiyva_slurp_result::food This was entirely cosmetic at this point. passive_t::slime_feed remains also for cosmetic reasons, it is used to color the powers display once the player's piety increases a bit. But this could perhaps be simplified... Resolves #1555 -------------------------------------------------------------------------------- 5006177544 | advil | 2020-12-11 13:18:34 -0500 Never mulch tossed items This specifically comes up for launcher ammo, which has a mulch rate, so it could previously get destroyed even when being tossed. I do think this could go either way per discussion in #1505, but i ended up deciding to change it because I think it's overwhelmingly likely that (barring weird speedrun things I haven't though of) the only reason anyone would ever toss launcher-only ammo is by accident, in which case it's pretty annoying to see it mulch. Resolves #1505 -------------------------------------------------------------------------------- 613af4b37b | advil | 2020-12-11 12:22:55 -0500 Explicitly set window opacity May or may not help with #1562 -------------------------------------------------------------------------------- 775ca3dcd3 | advil | 2020-12-11 10:14:49 -0500 Improve error messaging for int options * handle color tag escaping correctly * make the error message slightly more interpretable Resolves #1623 -------------------------------------------------------------------------------- be3abf3417 | advil | 2020-12-10 20:58:12 -0500 Don't do a weapon check on autofight movement for launchers When an enemy was visible but fire was blocked, a wielded launcher would trigger a "really attack while wielding" message before allowing movement towards the enemy. This old behavior was strictly in keeping with the documentation for autofight_prompt_range, but I think still unexpected, and with confusing messaging (referencing attacking) on top of that. So just skip the wielded weapon check altogether if wielding a launcher. This does obscure corner cases where a launcher has an inscription, but since all launchers have full range, it's pretty restricted. Resolves #1614 -------------------------------------------------------------------------------- 5722f2f28d | advil | 2020-12-10 19:45:25 -0500 Copy .md files on install I think that before bf3a5c7, this is what was causing various crashes in circumstances that aren't what we usually test. This commit isn't strictly necessary after bf3a5c7, but it paves the way for converting other docs to md, and also heads off this gotcha for the future. Resolves #1609 -------------------------------------------------------------------------------- fb849e850a | advil | 2020-12-10 17:05:16 -0500 Fix a thunderbolt crash Thunderbolt was not correctly handling the case where a player moved instantaneously or during the firing turn into the position that they had just targeted, resulting in a ray crash on a length 0 ray. This could happen easily in wizmode but also in a few ways during a game, including mesmerise, serpent's lash, and probably knockback. This commit guards against the specific case, though not for non-crashing cases of the player moving in one of these ways (which might lead to bizarre thunderbolt shapes). For fully correct behavior, it should probably check not just the turncount of the previous firing, but the position the actor was at at the previous time of firing. -------------------------------------------------------------------------------- 6118fa9711 | advil | 2020-12-10 15:03:07 -0500 Add some sanity checks to IMB The effect of this spell when one of the actors was knocked into a dispersal trap was fairly odd, and these changes make it slightly less odd. (They may or may not interact with crashes we've been seeing.) It's possible that for knockback specifically, dispersal should act as a fineff, but this isn't a good approach for dispersal in general. -------------------------------------------------------------------------------- bf79f71511 | advil | 2020-12-10 12:30:41 -0500 Add another test monster and generalize some references to MONS_TEST_STATUE. -------------------------------------------------------------------------------- 76280ab330 | advil | 2020-12-10 11:38:52 -0500 Fix grammar error for misc evokables -------------------------------------------------------------------------------- 34db2bcb1b | advil | 2020-12-10 11:36:11 -0500 De-futurize various descriptions I realize this is in principle a ridiculous solution to searches for "will" over-accepting, but when I went through these cases I realized a lot of them are clearer as non-future anyways, and nothing I changed reads worse to me. -------------------------------------------------------------------------------- d598b01645 | Nicholas Feinberg | 2020-12-09 08:34:38 -0800 Add a note of poignancy (12401) To avoid players being trapped in a side area in lost_world, add an exit... just behind a plant... so close for the poor skeleton there, but so far...! -------------------------------------------------------------------------------- 581f5be5db | advil | 2020-12-09 09:08:58 -0500 Improve tossing non-evokable unrands (vt) Also, better handling messaging for trying to quiver equipped items for tossing. -------------------------------------------------------------------------------- 4787bd3075 | wheals | 2020-12-09 14:18:31 +0200 Fix infinite gold exploit (#12395) -------------------------------------------------------------------------------- f6fec0c0d4 | wheals | 2020-12-09 14:18:31 +0200 Don't let Maurice steal stuff being worn See https://crawl.kelbi.org/crawl/morgue/Prakerore/crash-Prakerore-20201124-060246.t xt for a crash caused by this. -------------------------------------------------------------------------------- 83fea8793d | wheals | 2020-12-09 14:18:30 +0200 Fix _actor_apply_cloud_side_effects return value for miasma (#12399) May cause the clouds to (correctly) anger monsters that they hurt. -------------------------------------------------------------------------------- 26f530f025 | wheals | 2020-12-09 14:18:30 +0200 Refactor Hailstorm's range handling a bit -------------------------------------------------------------------------------- d1b18c6681 | wheals | 2020-12-09 14:18:30 +0200 Fix typo -------------------------------------------------------------------------------- 544776af23 | advil | 2020-12-08 19:44:11 -0500 Mark minmay_two_paths as transparent (u/yigaxab397) It's possible that other vaults lacking @ will have similar issues. -------------------------------------------------------------------------------- 006ef2cfcc | advil | 2020-12-08 14:17:17 -0500 Improve autofight_throw and CMD_AUTOFIGHT_NOMOVE The main content of this change is to allow autofight commands (as opposed to CMD_AUTOFIRE) to only trigger actions that do direct damage of some kind. Several people have pointed out to me that their behavior with something like Berserk quivered, vs. how players used them before quivers, was not very coherent. Now, any autofight command will act as if the quiver is empty when an action that doesn't do direct damage is quivered. This will also hopefully make the quiver more usable when CMD_AUTOFIGHT_NOMOVE is used as the Tab binding. As a bonus, autofight_throw=true now correctly handles the case where a spell is out of range, moving towards the nearest target or falling back to melee depending on range. This is fairly useful for many spells, but especially for something like hailstorm. There was no existing code to make this distinction, so I mostly ended up hardcoding it. Unfortunately this may mean that there are missed cases. -------------------------------------------------------------------------------- 72e26ac4d7 | advil | 2020-12-08 14:17:17 -0500 More manual updates for quivers * Add a section on combat, which was missing entirely * Refactor the key commands to group attacking and firing together, as well as move a few other things around -------------------------------------------------------------------------------- 48550f608a | Nicholas Feinberg | 2020-12-08 07:47:51 -0800 De-invert the hex success targeter Probably nicer to show success chance when possible, not failure chance. -------------------------------------------------------------------------------- 0dd55e01dc | gammafunk | 2020-12-08 06:21:37 -0600 Mark a function as static -------------------------------------------------------------------------------- da264ca44c | Nicholas Feinberg | 2020-12-07 17:17:11 -0800 Rephrase Shadow Form description Use a consistent tense and tweak the phrasing around willpower. -------------------------------------------------------------------------------- e47f559bc5 | Nikolai Lavsky | 2020-12-07 17:16:40 -0500 Don't show a bigger targeter for Hailstorm when worshipping Vehumet `spell_range()` can return 4 instead of 3 for Hailstorm, because Vehumet supports the use of this spell. But Hailstorm's range never changes, since it's hardcoded as 3 in `cast_hailstorm()`. -------------------------------------------------------------------------------- d92d85930f | Nicholas Feinberg | 2020-12-07 12:31:47 -0800 Fix conjured friends' damage (bhauth) maybe_random_div and div_rand_round are very different. Fixes displayed and dealt damage by Fulminant Prism, Battlesphere and Conjure Ball Lightning, all broken in recent commits. -------------------------------------------------------------------------------- 185e2d3a23 | advil | 2020-12-07 12:43:29 -0500 Fix the header build -------------------------------------------------------------------------------- c50dc45249 | advil | 2020-12-07 11:16:28 -0500 Add icons to the revamped quiver menu -------------------------------------------------------------------------------- 29ed428ae2 | advil | 2020-12-07 11:16:28 -0500 Improve marking of quivered items in a few menus -------------------------------------------------------------------------------- c70d32b774 | advil | 2020-12-07 11:16:28 -0500 Fix inventory marking of invalid quiver items -------------------------------------------------------------------------------- 6dfd076335 | Nicholas Feinberg | 2020-12-07 07:42:27 -0800 Yet another WL -> Will -------------------------------------------------------------------------------- f6ffb0d6bd | Nicholas Feinberg | 2020-12-06 17:39:53 -0800 Remove William To disambiguate and shorten the hex targeter, refer to the resist chance rather than the "chance to beat". -------------------------------------------------------------------------------- edcf9b2963 | Nicholas Feinberg | 2020-12-06 14:22:02 -0800 More willpower wording tweaks Describe MR-immune enemies as having infinite will, matching the display on xv (not 'invulnerable'), and replace a few more WL references. -------------------------------------------------------------------------------- 390cb15686 | Nicholas Feinberg | 2020-12-06 14:10:26 -0800 Update more missed MR -> WL conversions -------------------------------------------------------------------------------- ffdf6f7e0c | Nicholas Feinberg | 2020-12-06 14:10:26 -0800 WL -> Will (dinky, advil) Reads a bit more clearly. -------------------------------------------------------------------------------- 0a7728c5f8 | advil | 2020-12-06 15:54:18 -0500 Improve weapons check wording for roll/rampage Helps with the scenario where a hypothetical player (*cough*) cannot figure out why there might be attacking going on and spends time trying to diagnose quiver bugs instead. -------------------------------------------------------------------------------- 2e65f7e828 | advil | 2020-12-06 15:34:51 -0500 Fix some ways of skipping the autofight hp check (dinky) This check was being skipped in some cases because at the time of calling, it was possible for the dist object to not be fully set up for automatic targeting. -------------------------------------------------------------------------------- 803384b024 | advil | 2020-12-06 15:19:59 -0500 Fix autofight_fire_stop Broken because the lua code was using the wrong variable name. This commit restores the previous default behavior of shift-tab/p acting like `ff` instead of `f.`, lets this be configured again in the rc via `autofight_fire_stop = true`, and also has all quiver actions consistently respect this option. I've gotten some feedback from players suggesting that this might actually be better with a default of false (from players interpreting the bug as a new default), but for now I'll leave it as it was before the quiver rewrite. -------------------------------------------------------------------------------- e62661cac4 | advil | 2020-12-06 14:41:03 -0500 Improve handling of some weapons checks * on `v`, do weapons checks before targeting instead of after * fix a bug with out-of-ammo launchers and `V` pointed our here: https://www.reddit.com/r/dcss/comments/k7qypb/cannot_open_evoke_menu_if_i_have_a _ranged_weapon/ * don't allow melee attacks via `v` with out-of-ammo launchers. This isn't because it is disallowed, you can still do it with bump attacks, but in testing allowing this seemed more confusing than not. * standardize some checks of whether the player is wielding a launcher -------------------------------------------------------------------------------- 7af7f965e9 | Nicholas Feinberg | 2020-12-06 08:09:39 -0800 Display battlesphere damage For some reason I thought this wasn't still a player spell? -------------------------------------------------------------------------------- d31957873b | Nicholas Feinberg | 2020-12-06 08:06:39 -0800 Rephrase Ru stunned message again (Lici) Punch it up a bit. Thanks to all who voted in the poll! -------------------------------------------------------------------------------- 165cf102c4 | advil | 2020-12-06 10:39:38 -0500 Darken out of range tile The range distinction was extremely subtle on many dungeon backgrounds, because tiles shows both range and los in the targeter. This makes the range distinction much sharper, at the cost of making the oor vs oos distinction fairly subtle. However, this isn't very important in the targeter, so I think this is probably an improvement. True confessions: I couldn't find a good free sprite editor that could correctly handle the alpha channel in this file, so this is actually just the old out_of_sight.png from before 010c0ec4c0e. I kept the lighter version around in thee repo in case someone wants to play around with this in more detail. However, we really should be doing this kind of darkening programmatically. -------------------------------------------------------------------------------- 7355149c4d | Nicholas Feinberg | 2020-12-05 21:29:09 -0800 Fix the build Oops! -------------------------------------------------------------------------------- 55990c9dca | Nicholas Feinberg | 2020-12-05 21:09:15 -0800 Make Hailstorm always hit It effectively did anyway - its accuracy was accidentally made very very high. The accuracy could be nerfed, but it seemed better to simplify the spell. -------------------------------------------------------------------------------- ebc406137e | Nicholas Feinberg | 2020-12-05 21:05:59 -0800 Rephrase Ru's 'stunned by your will' To avoid confusion with the new willpower stat, use 'power' instead. (Per "You now exude an aura of power that intimidates your foes".) I'm not entirely happy with this - perhaps "by your aura" would be better, or something else? -------------------------------------------------------------------------------- 2ee872d4bd | Nicholas Feinberg | 2020-12-05 21:03:58 -0800 Rename magic resistance to willpower Magic resistance is a stat that covers a very wide gamut of effects, from hexes (Slow, Confuse) to vaguely hex-like things (Teleport Other, Siren Song) to things that very clearly aren't hexes at all (Disintegrate). Of course, it doesn't cover other hexes, like Metabolic Englaciation and Dazzling Flash, and it definitely doesn't cover all 'magic' - it provides no resistance to a magical fireball or a magic sword. In short, it's a name that's both unspecific and *too* specific. It actively misleads players. It has negative value! It's impractical and undesireable to change the game's systems to match the literal meaning of 'magic resistance', and there's no more precise term that matches the actual function. You could say something like 'hex resistance', but again, you run into the issue of hexes that aren't resisted by hex resistance and non-hexes that are resisted by hex resistance. So, instead, let's rename magic resistance to 'willpower'. This is a vaguer term, which means that it shouldn't mislead players in the same way, but it's entertainingly flavourful - it's fun to talk about Trog's influence making you strong-willed or Ru's sacrifices making you weak-willed. (Credit to Midn8 for "force of will" inspiring this.) One weird note about this name is that Disintegrate will be willpower-resisted. I've added a cute little bit of flavour to the item description as justification, and that wand might not be long for this world in any case, so it seems fine. There's no save compat code here, so this is easy to revert or tweak further as needed. -------------------------------------------------------------------------------- 1f2658d0d0 | Nicholas Feinberg | 2020-12-05 16:16:56 -0800 Reduce !attraction duration (dinky) Formerly: 35-75 turns. Now: 20-40 turns. -------------------------------------------------------------------------------- 71edfde6b2 | Nicholas Feinberg | 2020-12-05 16:02:13 -0800 Attract monsters later While under the effects of a potion of attraction, pull monsters toward the player after their turn and before the player's next turn, rather than the other way around. This should make the potion more powerful in various circumstances. -------------------------------------------------------------------------------- 6b303dbc09 | Nicholas Feinberg | 2020-12-05 12:05:34 -0800 Display Mystic Blast damage The spell still had 'accuracy' but never checked it. -------------------------------------------------------------------------------- e22e22b3db | Nicholas Feinberg | 2020-12-05 12:04:15 -0800 Refactor zap_to_hit -------------------------------------------------------------------------------- bc0167d404 | Nicholas Feinberg | 2020-12-05 11:39:01 -0800 Remove redundant origin spells They should be initialized in zappy now. -------------------------------------------------------------------------------- 65c7e3695e | Nicholas Feinberg | 2020-12-05 11:26:38 -0800 DIsplay Vampiric Draining damage Boy, what a weird formula. -------------------------------------------------------------------------------- 5781f4c211 | Nicholas Feinberg | 2020-12-05 11:18:48 -0800 Display Hailstorm damage and accuracy Boy, this is very accurate... -------------------------------------------------------------------------------- 72e8e842c1 | Nicholas Feinberg | 2020-12-05 10:44:32 -0800 Show ball lightning damage -------------------------------------------------------------------------------- a60655dfc3 | Nicholas Feinberg | 2020-12-05 10:39:02 -0800 Show Fulminant Prism damage -------------------------------------------------------------------------------- ebe0143811 | Nicholas Feinberg | 2020-12-05 10:20:09 -0800 Show Searing Ray damage & unbrace -------------------------------------------------------------------------------- 789247db7f | Nicholas Feinberg | 2020-12-05 09:39:13 -0800 Show Freeze and Absolute Zero damage -------------------------------------------------------------------------------- 5d12d2fb9f | Nicholas Feinberg | 2020-12-05 09:33:07 -0800 Show Shatter and Fire Storm damage -------------------------------------------------------------------------------- 026c722f6f | Nicholas Feinberg | 2020-12-05 09:10:04 -0800 Display Yara's Unravelling damage Very unsure whether this will cause bugs or not. Life is exciting! -------------------------------------------------------------------------------- 7deb57bc63 | Nicholas Feinberg | 2020-12-05 09:04:34 -0800 Display Irradiate damage -------------------------------------------------------------------------------- c9bf407737 | Nicholas Feinberg | 2020-12-05 08:54:34 -0800 Describe Ignition damage -------------------------------------------------------------------------------- 82ca2f83e3 | Nicholas Feinberg | 2020-12-05 08:40:00 -0800 Describe Starburst damage & accuracy -------------------------------------------------------------------------------- 8c6fb62fe6 | Nicholas Feinberg | 2020-12-05 08:34:48 -0800 Tweak Lightning Bolt description RIP "other similar bolts". -------------------------------------------------------------------------------- 488e41826d | Nicholas Feinberg | 2020-12-05 08:30:42 -0800 Show player spell accuracy As + pips, since a raw accuracy number means very little. Ranges from about 2 pips for some 0-power spells to 7 pips for max-power LCS. Should be a nice complement to the damage numbers. -------------------------------------------------------------------------------- 0fe3eaa9ac | Nicholas Feinberg | 2020-12-04 22:35:34 -0800 Remove an accidental newline Classic copy-paste error. -------------------------------------------------------------------------------- 392c82fb87 | Nicholas Feinberg | 2020-12-04 21:27:19 -0800 Show player spell damage In spell descriptions, similar to monster spell damage, weapon damage, etc. -------------------------------------------------------------------------------- f74a8dc463 | advil | 2020-12-04 21:31:13 -0500 Don't recalculate quiver on autotravel, again -------------------------------------------------------------------------------- 1a1fd2e980 | advil | 2020-12-04 18:14:31 -0500 Initialize sockaddr_un before initial recvfrom This is a weird one. Under some circumstances that I cannot fully determine, the socket address in srcaddr after the recvfrom call is not getting 0-terminated, leading to an invalid pathname (with garbage characters after the end of the actual file name) and ENOENT on the first sendto immediately after the attach message. This leaves the crawl process with no listening clients; the way this appears from the user's end is that webtiles just hangs on the loading screen. Memsetting the structure before recvfrom fixes it, and is good practice anyways. *However*, this seems to be Tornado version specific: I get this issue almost deterministically on Tornado 6.1.0, often on Tornado 6.0.4, and sporadically on 6.0.3 (but I have seen it happen). This makes me suspect that there is some kind of race condition where the socket may not be set up on the client end quite in time for the recvfrom call, and this weird behavior is just a symptom of the race condition. However, it isn't at all obvious why this could happen on the python side, and there's no async code I can detect that would be interfering. So I'm not really sure what is going on here. It's also possible this issue, or at least the particular symptom I'm fixing here, is mac specific, since I think we would have heard about this if one of the tornado 6 servers were having this problem. -------------------------------------------------------------------------------- d3b5134375 | advil | 2020-12-04 11:43:55 -0500 Forward compatibility for tornado 6.1.0 This gets it to run. (There are still some issues that I haven't fully tracked down.) -------------------------------------------------------------------------------- f0e3ce9185 | advil | 2020-12-04 11:03:32 -0500 Simplify some direction targeter messaging As far as I can tell, this extra messaging as a side-effect of `select` is currently redundant, just leading to extra duplicates of whatever error message is also printed in `print_target_description`. Possibly this wasn't true in the past before the direction chooser was widgetified? -------------------------------------------------------------------------------- f98bc5018b | advil | 2020-12-04 10:21:44 -0500 Improve tracer behavior for melee targeting (dinky) Two fixes: * don't show tracers for regular melee weapons * for reaching, don't show the tracer when the attack point is beyond range. I'm not sure if this was intentional but right now to me it seems more confusing than not. -------------------------------------------------------------------------------- 5dabc5fedb | advil | 2020-12-04 10:21:44 -0500 Let `launcher_autoquiver` affect evokable artefacts And make them autoquiver their effect like launchers. This is a slightly different case since they can't be evoked via `v` (any more) but this behavior makes them more consistent and predictable at least. These items, when wielded, can still always be evoked with `V` even if autoquivering is off. -------------------------------------------------------------------------------- e3d1176a8d | advil | 2020-12-04 10:21:44 -0500 Make some messaging more consistent (dinky) -------------------------------------------------------------------------------- 1d9d62bb61 | Nicholas Feinberg | 2020-12-03 17:11:26 -0800 Remove entropy weavers' arms The weapons, that is. It's not important to their design and the tiles didn't support them. -------------------------------------------------------------------------------- 9442c5bf0f | Nicholas Feinberg | 2020-12-03 17:09:47 -0800 Don't drain with "invisibility Fix sprint 4, sort of. -------------------------------------------------------------------------------- 2c58977ddd | advil | 2020-12-03 17:27:04 -0500 Re-simplify quivering effect of wielding a launcher b220303a8 tried to improve autoquivering on wield but instead (for most people) just made it more confusing. After this commit, by default wielding a launcher will always change the main quiver as well, regardless of what is quivered. This works reasonably well with the other change in b220303a8 that switches to the last used quiver on quiver invalidation, so switching away from the launcher (except for slings+stones) usually does something intuitive. This behavior (in contrast to the behavior before b220303a8) can now be disabled entirely; if you set `launcher_autoquiver = false` wielding a launcher will never set the quiver. This will be useful at least for characters that are using both launchers and spells. -------------------------------------------------------------------------------- d330659c95 | advil | 2020-12-03 13:58:36 -0500 Add a quiver swap command This new command swaps between the current quiver action and the most recent valid quiver action. Default bound to `]`. Since quiver actions don't have stable lettering, it's a bit hard to see exactly how to do this, but I wonder if something more controllable along the lines of `'` for weapons might eventually be in order? -------------------------------------------------------------------------------- 64875d0529 | advil | 2020-12-03 09:55:25 -0500 Do some caching for spell quiver enabled checks For beams (and especially explosions) this is a pretty heavy call, because it checks if there are enemies in range, and it isn't ideal that it gets called every time the quiver gets redrawn; I've already fixed some cases where this call was leading to noticeable slowdowns. Moreover, this call has been revealing a lot of cases where a redraw (or webtiles _send_player) happens as a side effect at a time where there is some invalid state for calculating nearby enemies, causing crashes. I've been able to fix up some of these on a case by case basis, but others I haven't even been able to replicate (e.g. https://webzook.net/soup/morgue/trunk/eld/crash-eld-20201128-170107.txt, which seems to involve a more() triggered in the middle of monster_die on vehumet MP gain, where there is a partially dead monster at that point in the call, triggered by some kind of complex fireball+inner flame scenario). So, for both of these reasons, this commit changes things so that the spell quivered enabled status is only updated once per input cycle. This could be extended to other quiver actions needed but right now as far as I know (beam) spells are the ones that are causing issues. -------------------------------------------------------------------------------- d078a86f14 | advil | 2020-12-02 10:51:20 -0500 Better handle invalid lockfiles After CBR2 lost power the other day, it left a bunch of empty lockfiles, which aren't being handled very well. This will simply clear a lockfile if it is empty or otherwise contains something not convertable to an int. (The case where it contains a stale process number is already handled.) -------------------------------------------------------------------------------- 4c2be1ac84 | advil | 2020-12-02 10:15:08 -0500 CLI for setting password reset tokens I had qualms about enabling the admin panel version of this on a server with a very long admin list, so in lieu of adding a second DGL permissions tier (for now) I'm adding a CLI version of this to simplify password resets a little bit. Not yet tested in a chroot setting. This change enables servers accepting reset tokens unconditionally; but unless one of the other two options is enabled they can still only be set via the command line. -------------------------------------------------------------------------------- 69f9a3b9e2 | advil | 2020-12-01 20:48:56 -0500 Set you.on_current_level to false during load This has the effect of suppressing certain UI things, and keeping quivers from crashing in case UI updates during load force webtiles to call send_player early. This was in particular happening for skill menu on load cases. I've also adjusted where the skill menu is called from in these early game cases; this didn't prevent the crash or anything but it seemed wildly odd to open the skill menu when the game is in the middle of restoring. -------------------------------------------------------------------------------- 701b36d813 | advil | 2020-12-01 18:23:03 -0500 Add an admin panel tool for password resets For servers that can't set up password resets by email, this allows admins to manually generate reset tokens. I implemented it because handling manual password resets on CAO is extremely annoying, but setting up the email mode is unlikely to happen. This feature is very much off by default because it's a drastic increase in privileges for the way admin users are set up on many servers -- right now, the admin flag is mainly for identifying who can do rebuilds / use wizmode, i.e. almost nothing that can affect other users. So I don't think server owners will obviously want to enable a way of changing arbitrary passwords (if you have the reset link, you can change the password) for anyone who can rebuild. Really this calls for multiple tiers of permissions, but that's pretty involved to figure out how to do. TBD. -------------------------------------------------------------------------------- 9b92081034 | advil | 2020-12-01 16:13:55 -0500 Prevent unnecessary redraws during autotravel (Goratrix) This gets quivers and a few other things that shouldn't be updated in fast autotravel modes. (In testing this I noticed that console, but not tiles, still prints messages with these modes, should maybe be fixed too.) -------------------------------------------------------------------------------- f5feefdc77 | advil | 2020-12-01 15:47:11 -0500 Exclude userdb.py from lint -------------------------------------------------------------------------------- fcd0102f59 | advil | 2020-12-01 15:38:56 -0500 Better document a tiles option (u/Social_Knight) This tab names are set in a slightly odd way so it's possible I missed a few here. -------------------------------------------------------------------------------- 1ef1181187 | advil | 2020-12-01 15:32:07 -0500 Add webtiles password change I'm not sure if there's some good reason that I'm missing why this was never implemented, but here it is. Previously the player needed to log in to ssh to do this on most servers, and it may even have required an admin on others. -------------------------------------------------------------------------------- f3041fb45f | advil | 2020-11-29 15:05:57 -0500 Show quiver for felids in webtiles -------------------------------------------------------------------------------- 201e65fd49 | advil | 2020-11-29 13:27:30 -0500 Improve flavor of explosions after death -------------------------------------------------------------------------------- f9a3951816 | Nicholas Feinberg | 2020-11-29 08:57:11 -0800 Shift nrook's guardian serpents deeper D:9 is a bit earlier for guardian serpents. So is d:11, really, but what's life without a *little* excitement? nrook_guardian_serpent_double might be too spoilery to exist (unrelatedly) but I don't have the heart to change it. (And as spoilery vaults go, the trick in this one is pretty obvious.) -------------------------------------------------------------------------------- f919d8e910 | Nicholas Feinberg | 2020-11-29 08:57:11 -0800 Adjust worldbinder Swamp set (12391) Since insubstantial wasps no longer spawn in Swamp, replace them with bog bodies. (We don't want any of the really nasty creatures in this set!) Planerend set still seems fine. -------------------------------------------------------------------------------- 1642dc5553 | Nicholas Feinberg | 2020-11-29 08:57:11 -0800 Make evokable invisibility drain skills Evocable invisibility is a very powerful and potentially quite fun effect. It has a correspondingly high Evocations skill requirement to remove its failure chance. However, that failure chance rarely mattered in practice. There was no real cost to repeatedly evoking invisibility at 70% failure while around the corner from enemies. That was strong, but not particularly fun. Evoking invisibility now applies moderate skill drain to the player, regardless of whether the evocation succeeds. This both discourages high-failure-rate evocation and makes the ability *slightly* weaker in general. (Of course, as Ru shows, one mustn't overestimate the impact of drain!) The current drain value is a first pass - it should be adjusted as appropriate per player experience. -------------------------------------------------------------------------------- f18ecd8a5b | advil | 2020-11-29 11:54:56 -0500 Support backslash notation in rc keybinds This is handled correctly in macros.txt, but there was no way to do this that I can identify in rc files, making it impossible to bind keys like tab or shift-tab. Now you can type things like: bindkey = [\{9}] CMD_AUTOFIGHT_NOMOVE directly into an rc file. -------------------------------------------------------------------------------- 76694b35de | advil | 2020-11-28 19:35:02 -0500 Prevent most quiver autofilling This commit effectively restores oldquiver behavior: running out of ammo will autoquiver other ammo using the settings in fire_order, but nothing else. The only other action type that can run out is wands, and these result in an empty quiver. Dropping items will also lead to an empty quiver, which I'm less sure of. This commit is likely not the last word on quiver autofilling, but it does solve one of the more annoying sets of interactions, which is when running out of ammo and hitting autofire triggers something extremely different, such as invoking berserk. Because wands can no longer be accidentally triggered by running out of ammo (see f7e0b5f77) I've added them back in to the cycle order. -------------------------------------------------------------------------------- b220303a8a | advil | 2020-11-28 17:52:46 -0500 Tweak quiver on wield behavior * If the player wields a launcher, and the current quivered action involves ammo, the main quiver will switch to the appropriate ammo for the launcher (the last used of the relevant type). This is an exact match for 0.25 behavior. I'm not sure whether it's really the best in the end, but it's at least consistent. * If the player wields a launcher, and the current quivered action is valid and non-ammo, no autoswitch will be triggered. The player can still fire the launcher via tab/`v`. This smooths out a lot of switching cases that were annoying (e.g. spell+launcher+melee combos). * If the player wields a non-launcher that results in an invalid quiver action, instead of emptying the quiver, the game will try to find a valid recently used action. This should cover at least some use cases I've discussed with players, but needs some testing in practice. All this is slightly more complicated that what was happening before, so it may need more tweaking. In principle I could add options for some of this as well, but I need to have a better sense of the use cases. -------------------------------------------------------------------------------- 52035dc9a5 | advil | 2020-11-28 11:20:35 -0500 Guard against crashes in god_hates_killing Also, standardize some indentation. -------------------------------------------------------------------------------- a0cc1ef5f6 | Kate | 2020-11-28 04:26:34 +0000 Improve stairs documentation -------------------------------------------------------------------------------- 5126ae9156 | Kate | 2020-11-28 04:19:17 +0000 Remove some semicolons -------------------------------------------------------------------------------- 687c0233df | Midn8 | 2020-11-28 04:19:08 +0000 Fix "The Exile" Description (#1617) The card is no longer capable of banishing the user (and hasn't been for quite some time). -------------------------------------------------------------------------------- 9485abf61d | advil | 2020-11-27 17:04:27 -0500 Fix autofire targeted abilities with no enemies (yesno) This change prevents the yesno (ha) dialogue from happening when the direction chooser is opened non-interactively, simply failing silently. This is immediately targeting some abilities that were targeted but use spell_direction (e.g. naga spit), we'll see if it has bigger side effects. Most spells should handle this before getting to the direction chooser. -------------------------------------------------------------------------------- 36fc42b6d5 | advil | 2020-11-27 17:04:09 -0500 Standard indentation in ability.cc -------------------------------------------------------------------------------- 2bc0b21477 | advil | 2020-11-27 15:02:40 -0500 Add fine-grained rc control over static targeters I've gotten a variety of feedback on this now; some people find them extremely useful, some people find them confusing or unnecessary, and some people find them useful only for certain spells. This new option lets you force a targeter on named spells when casting, allowing full customization. The default list is relatively short and includes only a few of the more unique targeters; there are some others that could be useful here (e.g. raise dead spells that show corpses, etc), but I'll wait on more feedback to see how this goes. This supports the usual "+=" and "=" syntax for list options. -------------------------------------------------------------------------------- 49005422be | advil | 2020-11-27 13:10:25 -0500 Don't show static targeters for `Z` People seemed confused by this, so I'm removing them for now. I can't tell whether this confusion is because of change or intrinsic confusion. It's true that many static targeters are extremely boring (e.g. self-targeted ones and summon ones that just show range 2). I'm leaving them for the fire interface, because even though I've also seen this described as "weird" it's pretty important for consistency, and if you want to skip the targeter you can just use `p` or shift-tab in this mode. (Also, I do really think these targeters are extremely useful for new players.) What might be best is if z/Z both had a toggle that let you choose to see the static targeter if you want to check range. -------------------------------------------------------------------------------- ccb988d4e7 | Nicholas Feinberg | 2020-11-27 07:57:31 -0800 Give meliai a weapon offset -------------------------------------------------------------------------------- d41f7fe8a7 | Goratrix | 2020-11-27 07:57:31 -0800 Give atropa and datura darts distinct color tiles Currently both atropa and datura are using default branded dart tile, which is dark blue. This gives them distinct colors, orange for datura and lighter blue for atropa. The default branded tile (not used) is changed to grey/silver instead of blue. -------------------------------------------------------------------------------- f7e0b5f775 | advil | 2020-11-26 21:58:41 -0500 Don't include wands in quiver autofill/cycling This seems like it should eventually be configurable, but remove this for now: it seems like it makes it too easy to waste wand charges. (Possibly applies to misc evokers, abilities, as well?) -------------------------------------------------------------------------------- 1c1f9fb145 | advil | 2020-11-26 20:07:56 -0500 Let throwing ammo be quivered with a launcher -------------------------------------------------------------------------------- 3f418897a6 | advil | 2020-11-26 20:03:24 -0500 Fix a build issue for cao `set::emplace` is not available on this compiler, apparently. -------------------------------------------------------------------------------- 67df3f2acb | Nikolai Lavsky | 2020-11-26 12:33:30 -0800 Colourize beam damage descriptions in WebTiles As a followup to 930a2b7a, this commit colourizes beam damage descriptions on the xv screen. -------------------------------------------------------------------------------- 5c0f344105 | advil | 2020-11-26 13:19:17 -0500 Show inert evokers in `V` menu (Lici) This restores previous behavior, and marks inert evokers as dark grey in inventory menus in general (basically so that they'll show up that way in `V`). Not sure if there are other things that could be marked dark grey following this, or if there's a convenient way to do that. But this makes the appearance of `V` match the quiver menu. -------------------------------------------------------------------------------- 3624241d3c | advil | 2020-11-26 12:57:01 -0500 Remove a debug message -------------------------------------------------------------------------------- 35fe432003 | advil | 2020-11-26 12:54:23 -0500 Fix a bunch of inscription logic errors These were keeping every ammo not inscribed with =F from getting quivered -------------------------------------------------------------------------------- 9503ff51b6 | advil | 2020-11-26 12:45:51 -0500 Fix cleave+reaching I had assumed this wasn't possible, but it is via Xom. This fix prioritizes the reaching targeter over the cleave targeter. -------------------------------------------------------------------------------- bf3a5c7d0a | advil | 2020-11-26 11:04:28 -0500 Generate a quickstart.txt 23cac7494c converted the quickstart guide to markdown, but at the time of merge I don't think anyone fully realized that this was loaded in-game. This fact has caused a bunch of havoc. This commit generates a .txt by simply copying the md file, which should eventually be substituted for better rendering. Two reasons for doing this: (i) for in-game use, a .txt version would be better since we don't have any markdown rendering in-game, and (ii) on some servers (perhaps just CWZ) the .md file is not getting copied into the game data directory, which is causing a ton of crashes. This could be fixed on the server, but given (i) it also seems reasonable to fix it on our end. -------------------------------------------------------------------------------- 326f72de0d | advil | 2020-11-25 22:48:50 -0500 Fix an autofight / throw interaction (vt) This simplifies this code path to only use the targeting in throw_it, rather than adding an extra layer of targeting around CMD_THROW_ITEM_NO_QUIVER. This layer was here for historical reasons and everything seems to work fine without it. The specific bug this is targeting is that because the action treated this as a case of non-interactive targeting it would apply the autofight threshold. This commit also fixes a bug where you could use `f` to fire ammo into walls with portal projectile, probably causing a crash. -------------------------------------------------------------------------------- a1d07f6d9d | advil | 2020-11-25 22:48:50 -0500 Improve handling of =f inscriptions This commit allows =f to work beyond ammo, and still shows =f items in the `Q`uiver menu (following previous behavior). Some cases of +f still don't work. -------------------------------------------------------------------------------- c4484e65ce | Nicholas Feinberg | 2020-11-25 19:04:36 -0800 Ban missed net farming (Misc) I'd forgotten about the case where nets miss you. Oops! -------------------------------------------------------------------------------- ca8e991141 | advil | 2020-11-25 20:30:28 -0500 Fix a potential crash while joining ru This is a quick fix that I'm not sure is ideal, but what seems to be happening is that your_talents can be triggered as a side effect of messaging while joining a god, which then trips a Ru ASSERT before the god is fully set up. Changing the order of calls in join_religion might be better, but that sequence looks very delicate. -------------------------------------------------------------------------------- 1b567f25a9 | advil | 2020-11-25 18:54:22 -0500 Don't mark newgame spells as useless The player is not yet placed when they receive their initial spells, so spell_uselessness_reason needs to be able to work in that case. -------------------------------------------------------------------------------- 43279f1ce9 | advil | 2020-11-25 16:16:20 -0500 Fix !f inscription checks (vt) This moves inscription checks to triggering; the earlier implementation was only tested on a much older version of newquivers. This commit also lets !f inscriptions work on any item that can be fired from quivers. -------------------------------------------------------------------------------- 62de122f19 | advil | 2020-11-25 13:59:00 -0500 More spell quivering fixes, this time for excursions 81e999faa9 was specifically triggered by checking spell uselessness of a quivered spell while doing levelgen. Crashes can also happen if this is checked during an excursion. Before, none of this code would have a way of being called, but when a spell is quivered on newquivers, this code is used to figure out whether to gray out the spell, so it is triggered by ui redraws as well as sending player info in webtiles. I've added another sanity check to `spell_no_hostile_in_range`, but also just headed this off at the outset in `spell_uselessness_reason`. -------------------------------------------------------------------------------- 81e999faa9 | advil | 2020-11-25 12:53:58 -0500 Don't crash on a spell uselessness check when entering zigs I'm still not sure of why exactly this is called when the player is out of bounds while entering zigs, but it is, so handle this case a bit more gracefully in general. -------------------------------------------------------------------------------- 0a1e5404e9 | advil | 2020-11-25 09:11:01 -0500 Handle randomization correctly in absolute zero targeter Before, I had assumed that this wasn't randomized. However, it is, inside distance_iterator. So, this commit changes the targeter to show AFF_MAYBE on the closest targets when there is more than one at the same distance. The visual difference is a bit subtle, so it may be that this will be confusing, but this still seems the best way to handle it. -------------------------------------------------------------------------------- a5061f1e94 | advil | 2020-11-25 09:11:01 -0500 Lua api for targeted fire of spells, items, abilities Before, these needed to be triggered by sending keys; this change uses the actions API to directly trigger actions and supply a target where necessary. This code is not extremely well tested... -------------------------------------------------------------------------------- c7d50104ff | advil | 2020-11-25 09:11:01 -0500 Simplify and document the actions/quiver API somewhat Mixing shared_ptr and references was too confusing, with some awkward pitfalls. Given that the whole point of action_cycler is to ensure non-null, this commit just switches things over to use only shared_ptrs, and makes explicit this (and cases where nullptr may be returned) in the doc comments. Also, a few other tweaks/fixes that I noticed along the way. -------------------------------------------------------------------------------- 568033eebc | advil | 2020-11-25 09:11:01 -0500 Name some special numbers in autofight (PleasingFungus) -------------------------------------------------------------------------------- 6b3f3ad2d2 | advil | 2020-11-25 09:11:01 -0500 Refactor and consolidate melee attacks This commit refactors melee attacks, including CMD_ATTACK_... and reaching attacks, into a single action type. This action supports targeting not just for reaching attacks but for regular melee attacks, leading to a more uniform behavior (as well as allowing you to examine enemies directly from an attack interface for all attack types). This class supports all the bells and whistles of other action commands, e.g. it will do noninteractive attacking if a target is pre-chosen. It's currently not used in a quiver at all, but created on the fly as part of an attack. For backwards compatibility I have left the behavior of CMD_EVOKE_WIELDED intact, but `v` is now bound to a new CMD_PRIMARY_ATTACK that activates targeting for any wielded weapon, be it regular, reaching, or ranged. Historically, there were various types of things triggered with this key while wielded, but more recently `v` is used almost entirely for reaching except for some special cases: two artefacts (staff of olgreb and staff of dispater) as well as unusual techniques like wielding a wand. Since all of these special cases now can be accomplished via the quiver, it doesn't seem so necessary to keep to the old scheme as a default. There's still unfortunately a bit of scaffolding in the evoke code because of this compatibility issue, but it's at least less intrusive. Additional notes: * targeter_cleave is upgraded to support changing aim, and used for `v` on axes. * Rift targeting is simplified and now correctly shows range. * Bump attacking is unchanged, i.e. doesn't use this code path. * If someone's really bothered by having to quiver staff of olgreb's OTR ability to trigger it, they can rebind `v` back to CMD_EVOKE_WIELDED. `V` will also continue to work. * It is still possible to use `V` to evoke a reaching weapon. -------------------------------------------------------------------------------- ab14b95593 | advil | 2020-11-25 09:11:01 -0500 Change/improve some default quiver filling cases A bunch of issues that showed up in testing * use invalid, rather than just empty, quivers for initialization cases. This autofills early game quivers more appropriately. * on memorising a spell, fill an invalid quiver. * when wielding a launcher, if that launcher has ammo fill the main quiver unconditionally. Previously I had only done this on an invalid quiver, but on testing I'm not sure that this would be the best general behavior. (And in tutorial 2, it definitely complicates things in a case that would be confusing for newer players.) The main case where this could be annoying is if a player wants to swap between ranged and melee weapons, but keep a spell or ability quivered. -------------------------------------------------------------------------------- 1040668b95 | advil | 2020-11-25 09:11:01 -0500 Documentation, tutorial updates -------------------------------------------------------------------------------- 69e7df3edd | advil | 2020-11-25 09:11:01 -0500 Refactor and improve some autofight checks This commit slightly restructures how autofight is called, cleaning up the code in main.cc and moving the hp/mp checks at least partly into quiver::action (though still using clua bindings to perform the checks). The main substantive change here is that the `automagic_stop` option now works for quivered actions that consume mp similarly to how it worked on old automagic. -------------------------------------------------------------------------------- 1112c698d6 | advil | 2020-11-25 09:11:01 -0500 Change the behavior of the CLUA_BINDINGS #define This commit changes things so that what gets compiled out by removing this define is only the ability to run clua from the rc file and macros. Default clua bindings in dat/clua are called, as are all hooks etc. (Most will be unable to do anything, but this would allow someone to set a default value for any hooks in dat/clua code.) *Motivation.* The main use case for this that I can think of is security: a security-conscious server admin may prefer their users to not be able to run clua in their rc file. However, this use case has been severely broken for some time, because the following were also disabled by undefining this variable: autofight, stash tracker annotation, delay interruption, kill annotation, and a few other minor things. Realistically no one is going to want to play modern crawl without at least the first two of these. Because of the (potential) security application, I don't want to remove it entirely, but if it is going to be usable for that, it needed some work. In addition, the existence of this #define required anyone implementing a clua binding to get the preprocessor setup right, and if they really wanted to do that, to test on two builds (one of which required editing the Makefile). Nearly every dev comment I can find about CLUA_BINDINGS going back to 2011 is basically asking why it exists. So this commit is an attempt to provide some value. One awkwardness: there is a bunch of lua code in dat/defaults/autopickup_exceptions.txt. Because this is treated as an rc file, it will error (and not work) on a non-user-clua build. This is all a bit hypothetical now but possibly it would be better for this code to be implemented in a dat/clua file rather than a default rc include. -------------------------------------------------------------------------------- 4c303a47fc | advil | 2020-11-25 09:11:01 -0500 Don't show item letters for actions in quiver I had these in as an extension of previous behavior for ammo, but in practice I've found the letters more confusing than helpful. If people do want these, it could go back in. -------------------------------------------------------------------------------- aeda7b1d4a | advil | 2020-11-25 09:11:01 -0500 add CMD_AUTOFIRE to `p` I'm not sure `p` is the best choice, and it really doesn't stand for anything relevant, but there was some consensus that people wanted a thing besides shift-tab. So try this for now. -------------------------------------------------------------------------------- 562f6ed73d | advil | 2020-11-25 09:11:01 -0500 Fix a tag upgrade issue -------------------------------------------------------------------------------- 281963b6d2 | advil | 2020-11-25 09:11:01 -0500 Let staff of olgreb use the static targeter when needed -------------------------------------------------------------------------------- bb0a9072ea | advil | 2020-11-25 09:11:01 -0500 First-pass implementation for quivering abilities There's a lot of idiosyncracy in the ability list, but this commit gets the main points and works for everything I've tested directly. Probably further tweaking is required for some special cases, and this may require some iteration with actual player testing to really shake out the use cases. (And the