--------------------------------------------------------------------------------
5716139 | advil | 2019-05-25 16:18:03 -0400

Some cosmetic fixes for the seed explorer

--------------------------------------------------------------------------------
0dde086 | advil | 2019-05-25 15:37:32 -0400

Add a basic lua seed explorer
This prints out information about vaults, monsters, and items so far; it
is packaged as a test that prints these for the first 5 seeds (replacing
a less interesting test), but is fairly configurable if you're willing
to edit the lua. To run it directly, you'll need to use util/fake_pty
(which may need to be built), e.g.:

    util/fake_pty ./crawl -test seed_explorer.lua

This also introduces a few lua support things that were missing that
might be of general interest, especially monster inventory (which is
easy now that all monster items are id'd).

--------------------------------------------------------------------------------
bc69b92 | NormalPerson7 | 2019-05-25 20:23:40 +0100

Don't allow players to stop monster monstrous menagerie with OTR (11990) (#1073)
The code for monsters casting monstrous menagerie uses the same code
path as for players, which means an extra check that the caster is the
player is required before asking the player whether they want to cancel
the spell.
--------------------------------------------------------------------------------
53aee78 | Edgar A. Bering IV | 2019-05-24 14:13:09 -0400

Remove vestigal references to needles (11986)

--------------------------------------------------------------------------------
793c10c | advil | 2019-05-24 11:30:38 -0400

Better messaging when hep ancestor gets lost in abyss (11973)
Addresses something mentioned in 11973: On abyss teleport (and some
other cases that I don't fully understand; this happens sometimes but
not often on abyss area shifts as well) the ancestor gets banished for a
short period of time, but there was no messaging for this. In other
cases the ancestor gets put into transit and there's also no messaging
for this case; the only difference was that for the former recall isn't
available.  This commit ensures messaging if the banish case happens,
and no messaging otherwise. This does the messaging at a relatively
low-level point, so it could be that there will be cases of double
messaging (but I have not found them in my testing).

N.b. I'm not actually sure it makes gameplay sense to banish the
ancestor on abyss teleport or even sure if this is intentional, so it
might be worth trying to put the ancestor in transit for that case too.
But it does fit with the randomness flavor of the abyss, I guess. But
even with that change this lower-level code might still be triggered in
complicated circumstances, and the ancestor really shouldn't ever be
banished without messaging.

--------------------------------------------------------------------------------
0de8e75 | advil | 2019-05-24 11:22:44 -0400

Test a theory about hep abyss crashes
This is a conceivable way for hep ancestor items to get copied to the
grid, if somehow the ancestor becomes invalid before this call but
cleanup of the ancestor hasn't happened yet (since held_by_monster will
return false if the monster that was holding the item isn't valid). If
it trips, this ASSERT will give a more direct line on what the setup
conditions for this situation might be, which I still don't understand.

--------------------------------------------------------------------------------
be4061d | advil | 2019-05-23 17:17:56 -0400

Fix another abyss gozag gold detection case

--------------------------------------------------------------------------------
4488db6 | advil | 2019-05-23 16:27:19 -0400

Clean up and improve gozag gold detection
This consolidates a bunch of gozag code and removes an ASSERT that I
think was over-eager, firing when update_item_at doesn't lead to a gold
pile in the stash tracker. There had previously been two versions of
this code, and only one had the check, but it doesn't seem so obvious to
me that update_item_at should really be expected to make any arbitrary
gold pile visible in the stash.

This commit also makes gold detection work in the abyss beyond the
initial levelgen.

--------------------------------------------------------------------------------
ff863c2 | advil | 2019-05-23 10:39:30 -0400

Don't crash on gozag + gold in grunt_nemelex_the_gamble
Unobtainable items don't appear in the stash tracker, and calls that try
to add them to it silently fail.  The only remaining "unobtainable"
items are in grunt_nemelex_the_gamble; these are marked unobtainable so
that if the player rolls the peril room they don't show up in the stash
tracker. However, Gozag's gold detection code didn't take this flag into
account, triggering an ASSERT on the expectation that any gold generated
at all would be trackable.

This isn't the most elegant solution, but it fixes the crash. I think
what would be better is for (i) "unobtainable" to be removed, since it
appears to have been deprecated for everything except this vault some
time ago, and (ii) for this vault to do something like destroy the items
if the player lands in the peril room.

--------------------------------------------------------------------------------
1cdb867 | cut1less | 2019-05-23 10:18:09 -0400

Don't fully describe unthrowable missiles

--------------------------------------------------------------------------------
4011b8c | cut1less | 2019-05-23 10:18:09 -0400

Simplify missile description cases
Previously, descriptions for projectiles were based largely around
whether they had a damage value associated with them, under the logic
that "inherent missile damage => throwable missile". This made life easy
in dealing with the old needles and with regular launcher missiles.

However, it led to:
* the sling bullet description having lots of throwing information
  (despite sling bullets not being throwable) and
* the throwing net description lacking the fact that a net's delay is
  lowered with Throwing skill

With the changes to throwing missiles, we can now just focus on
throwable-ness to fix these issues and more.

--------------------------------------------------------------------------------
5b3daab | Edgar A. Bering IV | 2019-05-22 21:45:50 -0400

Don't place traps under vault placed items and monsters (11983)
Randomly placed monsters and items do not place on traps, however the
dungeon builder was placing random traps under vault placed items and
monsters occasionally. This led to runes on dispersal traps as the worst
outcome, but the asymmetry was occasionally noticed for other trap types
too. Vaults that wish to have monsters or items start on a trapped grid
will need to request this explicitly.

--------------------------------------------------------------------------------
b8b2abe | Alan Malloy | 2019-05-22 17:10:14 -0700

Make it harder to accidentally waste ?amnesia (Jarrodb, #11985)

--------------------------------------------------------------------------------
4006481 | Alan Malloy | 2019-05-22 17:10:14 -0700

Simplify item weights

--------------------------------------------------------------------------------
1a3e1d3 | Alex Jurkiewicz | 2019-05-21 18:21:40 -0400

Remove vestigial duplicate wrath timer

--------------------------------------------------------------------------------
e062c78 | Edgar A. Bering IV | 2019-05-21 16:31:06 -0400

Remove mentions to obsolete items from options_guide.txt

--------------------------------------------------------------------------------
4452427 | Chris Campbell | 2019-05-21 21:28:34 +0100

Allow holy wrath weapons to be cursed
It was an almost invisible piece of flavour, since no external sources of
cursing still exist other than initial generation, and it resulted in them
being unable to be cursed under Ashenzari without any feedback as to why.

--------------------------------------------------------------------------------
13fca18 | NormalPerson7 | 2019-05-21 16:11:41 -0400

Fix a default note_messages

--------------------------------------------------------------------------------
48f6bce | NormalPerson7 | 2019-05-21 16:11:41 -0400

Fix a default force_more_message
This was broken by the shaft message change in 52ca42d.
--------------------------------------------------------------------------------
ad4687c | Edgar A. Bering IV | 2019-05-20 09:54:54 -0400

Replace a missing word

--------------------------------------------------------------------------------
52ca42d | Alex Jurkiewicz | 2019-05-19 22:59:41 -0400

Improve shaft messaging
Always print the number of floors, so the message is consistent between falling 
one or multiple levels.
--------------------------------------------------------------------------------
6f6d0e6 | Doesnt | 2019-05-19 22:42:58 -0400

Fix Avatar Song displayed success rate

--------------------------------------------------------------------------------
442a7a2 | Joshua Gelbard | 2019-05-19 20:40:20 -0400

Add misc. evocables section to known items menu
Steal the space on the '\' menu formerly taken up by known spellbooks
and give it to misc. evocables (previously grouped under "Other").

Now that the spell library exists, a list of your already-recognized
books is pretty useless. Individual switches for evocables like lamps
of fire will make much better use of that space.

"Unknown items mode" is untouched -- evocables still won't appear
there, and unknown spellbooks will still get their own category.

Issues: check_item_knowledge() has received patchwork additions over
the years and is creaking with duplicated code. This commit doesn't
help, but it doesn't make it that much worse -- there were already four
seprately-treated vectors of item_def pointers; now there are five. (My
first attempt at making this change started with a refactor, but the
result wasn't enough of an improvement to justify the diff, so I've gone
with the polar opposite and followed the existing pattern exactly.)

[Closes #1025]

--------------------------------------------------------------------------------
faf41a3 | Joshua Gelbard | 2019-05-19 20:23:57 -0400

Let players disable autopickup from the drop menu
Add a new "drop-and-disable-autopickup" mode for the drop menu, toggled
with '\'. Items selected in this mode are marked with a '*' instead of a
'+' and have their autopickup disabled when the menu is exited.

This turns "drop unwanted item; disable autopickup for unwanted item"
from a two-menu operation into a one-menu operation and makes the
most vital bit of the '\' menu available in a more convenient
location.

InvEntry and SelItem each get a new field to record whether they're
selected "normally" or in this new special way, and InvMenu gets a
field recording which selection mode it's in.  InvMenu now overrides
::pre_process() and ::select_item_index() to handle the new mode.

Also, assorted cleanup/bugfixes:
* Fix '_' on the drop prompt not actually bringing up the help menu.
* _invent_select can't return PROMPT_GOT_SPECIAL, so don't check for it.
* Replace anonymous you.force_autopickup ints with an enum
* Add helper functions for easier access to you.force_autopickup
* Demystify magic -1 to OSEL_ANY in a few places
* Remove unused define PROMPT_INAPPROPRIATE

--------------------------------------------------------------------------------
97e3104 | Joshua Gelbard | 2019-05-19 20:12:24 -0400

Fix '+' and '-' not being PGDN and PGUP as claimed
Previously, menus using the default more prompt all claimed that
'+' was pagedown and '-' was pageup, which was mostly false. This commit
changes that to be mostly true and alters the prompt where it's not.

On the drop, pickup, quiver, item knowledge, and wield menus, '-' has
some other meaning, so those are the ones where '-' isn't listed as a
usable pageup. '+' as pagedown should work everywhere.

[Closes #1013]

--------------------------------------------------------------------------------
fcedfb3 | Joshua Gelbard | 2019-05-19 19:37:41 -0400

Add a menu shortcut to select last unequipped item
In equipment-related menus and prompts, make ';' (semicolon) an alias
for the letter of the player's most recently unequipped item. The goal
of this change is to reduce the amount of time the player spends
scanning through menus to remember which item is where. Examples:

* Wear-IDing a good cloak ('f') and dropping your old one: Wfd;<Enter>
* Wear-IDing a bad cloak ('f') and re-equipping the old: WfW;d;<Enter>
* Swapping to a utility ring ('g') for a certain enemy, then going back
to your usual ring: Pg<P;<

In those examples, we saved a little mental effort by not having to keep
track of the location in inventory of the old cloak and ring.

Notes/possible issues:

The semicolon key is losing existing, though undocumented, behavior as
one of several ways send a page-up key (besides '<', PGUP itself, and
inconsistently '-').

The fact that this alias is usable on the (d)rop menu is documented both
in crawl_manual.txt and on the d_ help screen, but for i, w, W, and P
it's manual-only. (Those other help screens don't yet exist.)

--------------------------------------------------------------------------------
06ca16a | Chris Campbell | 2019-05-17 20:51:56 +0100

Fix spacing in a quote

--------------------------------------------------------------------------------
5a7c772 | Chris Campbell | 2019-05-17 16:44:15 +0100

Don't generate randart rings with rCorr and *Corrode
Also fixes their descriptions missing information on the rCorr base type.

--------------------------------------------------------------------------------
864f2b5 | Josh Braden | 2019-05-16 16:17:55 -0400

Stop constriction when Bai Suzhen transforms into a dragon (11954)

--------------------------------------------------------------------------------
49c61e0 | Josh Braden | 2019-05-16 16:17:55 -0400

Check and clear emergency flight if transforming into something that can fly 
(11965)

--------------------------------------------------------------------------------
ea32a60 | Josh Braden | 2019-05-16 16:17:55 -0400

Don't place a wall if a monster is in the way (11967)
Noticed in bug 11967, monsters are able to exist in walls if a floor is turned 
into a wall via dungeon_terrain_changed()
Done in two parts:
1. Make _dgn_check_terrain_monsters return bool if a monster is present
2. Don't continue with wall placement if a monster is present

--------------------------------------------------------------------------------
6e2f17f | NormalPerson7 | 2019-05-16 15:21:57 -0400

Trigger ally conducts on casting Olgreb's Toxic Radiance
Firstly, reduce the duration of the Toxic status by 1 turn and have OTR
poison monsters on the turn it is cast, rather than starting the turn
after it is cast. This means calling toxic_radiance_effect in the
cast_toxic_radiance function. This keeps the damage from Olgreb's the
same, and reduces the delay in dealing the damage by 1 turn.

Secondly, with the help of this new call to toxic_radiance_effect,
trigger ally conducts on casting Olgreb's Toxic Radiance when there are
allies without rPois in line of sight, but don't trigger conducts when
allies are hurt by the Toxic status on subsequent turns.

This fixes the previously inaccurate penance warning on casting OTR with
allies around (this penance warning is now correct), and prevents OTR
being used to turn allies hostile on demand without penance with gods
that give ally penance. This also prevents the player being placed under
penance inadvertently through no/little fault of their own when allies
walk into line of sight at the wrong time.

For consistency's sake, this also means that, should the player summon
non-rPois allies during OTR, the player won't receive penance. I don't
think this is a problem, because the ally will still turn hostile and
there is now a warning about summoning non-rPois monsters, so doing so
would be ill-advised anyway.

[Closes #999]

--------------------------------------------------------------------------------
0b8c503 | NormalPerson7 | 2019-05-16 15:21:56 -0400

Add a warning for summoning/enslaving monsters under OTR (11181, 11913)
Add a prompt when casting a summoning spell that can create monsters
that do not resist poison while under the Toxic status, and use this
prompt for all summoning spells with the potential to create non-rPois
monsters, as well as when enslaving non-rPois monsters. Note that this
is never a penance prompt; a subsequent commit will make it so that
Olgreb's Toxic Radiance triggers ally conducts when cast but not on
subsequent turns (to avoid inadvertent penance).

This commit also prevents Beogh from gifting orcs while OTR is active,
which would cause the orcs to become hostile immediately (but not cause
penance).

--------------------------------------------------------------------------------
55afeb9 | Umer Shaikh | 2019-05-16 14:47:28 -0400

Minor cleanup in stash search help screen
Adjust some long lines, remove reference to an obsolete feature, change
the example trap to a more currently relevant type of trap.

[Closes #1051]

--------------------------------------------------------------------------------
c6a89e5 | Umer Shaikh | 2019-05-16 14:47:28 -0400

Allow stash search deduplication to do its magic for features
This commit allows trap features to be collapsed in the stash search
results screen, as is the case for items. The commit should make it easy
to extend that capability to other feature types, if it's decided that
more features should be exposed to stash search.

--------------------------------------------------------------------------------
319a8a0 | Umer Shaikh | 2019-05-16 14:47:28 -0400

Make stash searching for a place abbreviation pull up features
Prior to this change, searching stashes with the search term '.' while
on D:2 and searching for 'D:2' while on D:2 had different results. This
was because the search term was matched against a location prefix for
items but not for features.

According to the search help screen the search term '.' should list
everything on the current level, so I conclude the difference here is
unintentional.

--------------------------------------------------------------------------------
8f53b65 | Umer Shaikh | 2019-05-16 14:47:28 -0400

Add data about object matched to stash search result

--------------------------------------------------------------------------------
7b9fd84 | Umer Shaikh | 2019-05-16 14:47:28 -0400

Detach matching features in stash search from items on feature
Prior to this change, this line meant that if you had a findable
feature (e.g., a portal entrance) you would only see it in a stash
search if you weren't also matching any of the items on top of it. I
don't see why the player would reasonably expect this behaviour.

--------------------------------------------------------------------------------
98db4a9 | Umer Shaikh | 2019-05-16 14:47:28 -0400

Make StashTrack pay attention to traps
When updating stashes in LOS, take traps seriously enough as a feature
to add a stash for them.

Something like this may have been already intended, since stashes have a
trap field that is supposed to be set to a non-trivial value in
Stash::update. This part of the code wasn't reached since
is_boring_feature(feat) is false when feat is a trap. (See also commits
23c5277317de657f8376d1b5f33144948a811a42 and
cbc0dd1c0e73770878e9a6df1b455e57995ef921.)

This change has traps added to the stash tracker as the player comes
upon them. Unfortunately players of ongoing games will not be able to
search for traps they have encountered that are no longer in LOS.

--------------------------------------------------------------------------------
c2ce883 | Umer Shaikh | 2019-05-16 14:47:28 -0400

Minor style cleanup
Fix some typos, break some long lines, and adjust some indentation.

--------------------------------------------------------------------------------
3e705ed | Edgar A. Bering IV | 2019-05-16 14:45:57 -0400

Fix the build

--------------------------------------------------------------------------------
b207fdf | Edgar A. Bering IV | 2019-05-16 14:11:06 -0400

Always trigger net traps when a player steps on them
Previously nets triggered on a one-chance-in-three like webs, but not
symmetric with monsters interaction with net traps. The chance annoyed
players attempting to disarm net traps and didn't otherwise contribute
much.  Making them always trigger is more consistent, less frustrating
behavior.

--------------------------------------------------------------------------------
827b87a | advil | 2019-05-16 10:56:57 -0400

Better handle webtiles messaging on game_exit::abort
Some messaging on certain rare abort cases wasn't showing up in
webtiles; most of these in practice only happen in offline settings.

--------------------------------------------------------------------------------
99e5aa4 | advil | 2019-05-16 10:38:24 -0400

Clean up some exit reason handling (alexjurkiewicz)
Always send a tiles "cancel" message on game_exit::abort -- before, this
was done manually on each game_ended call, and the seed menu was missing
it.

--------------------------------------------------------------------------------
5cb8de4 | advil | 2019-05-15 16:41:33 -0400

Don't send invalid json to spectators when a popup is open (#1065)
This prevents a trailing comma for the ui stack, which is not valid json
(though it is valid javascript). Not sure if this had a practical impact
on the main browsers in use, but there are definitely parsers that care,
so this might matter for bots.

Resolves #1065

--------------------------------------------------------------------------------
cf8e976 | Chris Campbell | 2019-05-15 20:10:48 +0100

Fix more capitalisation (NP7)

--------------------------------------------------------------------------------
49f49b0 | Chris Campbell | 2019-05-15 19:07:03 +0100

Re-brace

--------------------------------------------------------------------------------
9a7f692 | Chris Campbell | 2019-05-15 19:07:03 +0100

Use consistent capitalisation for DDoor messages

--------------------------------------------------------------------------------
4517bf7 | Chris Campbell | 2019-05-15 19:07:02 +0100

Don't change max HP during DDoor (#11933, #11976)
Changed in 1406302de, which broke DDoor's interaction with Revivification and
HP-costing abilities.

--------------------------------------------------------------------------------
16217b4 | Edgar Bering | 2019-05-14 13:08:17 -0400

Display dart delay and base damage (Yermak)

--------------------------------------------------------------------------------
6b9ea3d | Doesnt | 2019-05-14 13:07:06 -0400

Let draconian scorchers and Azrael call down damnation when not at low hp

--------------------------------------------------------------------------------
89f717d | Edgar Bering | 2019-05-14 11:48:39 -0400

Update javelin description (Yermak)

--------------------------------------------------------------------------------
1095bca | advil | 2019-05-13 13:11:12 -0400

Clear mon_acting on _reset_game (11971)
If the player is killed at the same time as other monsters under certain
conditions (I replicated it with inner flame), mon_acting would not get
cleaned up. This could lead to a crash when starting a new game without
exiting the program, as long as a monster would spawn in los.

--------------------------------------------------------------------------------
e86a0cf | advil | 2019-05-13 10:28:00 -0400

Prevent deep water teleport closets in swamp (9880)
This was recently reported here:
   
https://www.reddit.com/r/dcss/comments/bn20bv/ive_never_seen_this_before_is_it_n
ormal_to_have/

and thanks to seeding I was able to reliably replicate this bug from the
morgue posted in that thread. I'll upload a save file to 9880 for
posterity. (I'm assuming that 9880/11519 is the same bug and that
players will tend not to notice/report these cases unless there's a
monster in the closet.)

Basically, what happens is this: there were two connectivity passes for
swamp. The first was via zonify, and it finds and successfully fills in
any teleport closets existing at the time with trees -- but does not
check for overall level connectivity involving deep water. Then there's
a c++ pass in dungeon.cc:_build_vault_impl that is swamp-specific. This
pass handles connectivity issues involving deep water. Unfortunately,
because it treats deep water as impassable, it does not fill in deep
water squares, creating teleport closets of the kind that the zonify
pass fixes. (Also, I've verified that these are teleport closets for
flying/swimming chars.)

To fix this I have inelegantly added a *third* pass on the c++ side,
that finds and fills in any resulting deep water tele closets. It might
be possible to do without the zonify pass now, since this (now) third
pass would handle these cases, but I'm worried about kicking the tower
of cards. Ideally, this would all be handled by zonify, but right now I
don't understand zonify well enough to get this to happen.

--------------------------------------------------------------------------------
f989941 | Edgar A. Bering IV | 2019-05-11 17:26:22 -0400

Add darts to item knowledge screen (gressup)

--------------------------------------------------------------------------------
42b690e | advil | 2019-05-11 17:05:28 -0400

Add a few missing TAG_MAJOR checks

--------------------------------------------------------------------------------
9898fdd | advil | 2019-05-11 16:50:47 -0400

Remove an obsolete ASSERT

--------------------------------------------------------------------------------
41c1c16 | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Add sdynet to CREDITS.txt

--------------------------------------------------------------------------------
57add1a | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Boomerang item tiles (CanOfWorms)
Thrown boomerangs are animated on the beam path.

--------------------------------------------------------------------------------
bae0703 | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Throwing Overhaul VI: Adjust brand weights
Based on objstat runs, the initial weights for the new silver brand was
too high, as was the relative frequency of datura darts.

--------------------------------------------------------------------------------
46bf112 | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Throwing Overhaul V: Save Compatibility
Old needles are converted to darts. Old brands are stripped or converted
according to the following table.

|  old brand  | new brand |
| ----------- | --------- |
| penetration | none      |
| returning   | none      |
| exploding   | none      |
| poison*     | none      |
| steel       | silver    |
| sleep       | atropa    |
| paralysis   | atropa    |
| confusion   | atropa    |

* poison is removed from boomerangs and javelins, darts retain it

--------------------------------------------------------------------------------
48e52eb | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Rename Tomahawks Boomerangs
Now that they always return. And besides, the new name is significantly
more Australian.

--------------------------------------------------------------------------------
ba011c8 | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Throwing Overhaul IV: Returning and Penetration
To differentiate the different types of throwables, javelins now always
penetrate. This overlaps some with crossbows, which provide a
penetrating brand, but a crossbow user can choose from many brands and
has access to weapon enchantment.

Tomahawks always return. This is more a QoL change than anything, and a
step towards a broader ranged reform. In terms of ammo availability, the
mulch rate remains the same, so throws per tomahawk at on strategic
timescales are static. On tactical timescales, a player relying on
tomahawks for damage will for the most part not be limited by ammo; a
player 0-skill throwing tomahawks will get a few extra throws in the
early game, but the damage from these extra throws isn't that much.
Since this effect applies to monsters also, giving them a comparative
buff, it should be a wash.

--------------------------------------------------------------------------------
6ea07b3 | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Remove some unneeded TAG_MAJORs

--------------------------------------------------------------------------------
1701b1f | sdynet | 2019-05-11 14:06:22 -0400

Throwing Overhaul III: Remove most tomahawk and javelin brands
Now that blowguns are removed, throwing users do not need three ways to
poison a monster.

Steel is removed; silver now gets both bonuses, to be a "rare extra
damage throwable" that fits a niche not available with other weapon
types. This might be too good, which can be addressed in a couple of
ways.

Exploding, while "neat" was rarely different from yet another bonus
damage throwable.

Returning and penetration are removed, these effects will return in a
different way in subsequent commits.

[Committer's note: Closes #1048. Significant expansion of the original
 patch]

--------------------------------------------------------------------------------
193025e | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Rename frenzy and blinding darts
This commit is separate as renames tend to be controversial. All changes
are cosmetic.

Darts of frenzy become "datura-tipped darts" after the genus of toxic
plant that can cause psychosis and darts of blinding become
"atropa-tipped darts" after the genus of toxic plant that can cause
visual distortion and confusion.

Players aren't likely to know this (unless they're a botanist), but they
probably also don't know that curare is (in addition to being a generic
name for blowgun poisons) a genus of toxic plant. So it fits the
"exotic" dart poisons into a nice family.

--------------------------------------------------------------------------------
a4302a1 | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

New dart tiles (CanOfWorms)

--------------------------------------------------------------------------------
9adfa93 | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Throwing Overhaul II: Darts brand consolidation
The hex darts (paralysis, confuse, and sleep) are redundant in several
ways: mutually as a way for needles to generate stabs, with hexes, and
with wands. The result is a clutter of darts.

This commit removes these brands, replacing them with a single new
brand: blinding. In addition to blinding the target for a long duration
(depending on throwing skill) this brand also confuses the target for a
shorter duration. The effect was chosen to be distinct from hexes
(compared to dazzling spray's 4-8 turn blindness and invisibility) and
hex wands.

--------------------------------------------------------------------------------
25935dc | Edgar A. Bering IV | 2019-05-11 14:06:22 -0400

Throwing Overhaul I: Remove blowguns, needles become darts
The presence of a *launcher* modified by throwing skill is a wart left
over from the 0.6 ranged reform. The rarity of blowguns limited the use
of needles early on to some extent, the balance impact of this will be
addressed in a subsequent needle-brand-consolidation commit. In exchange
for this limit, the interaction of blowgun enchantment with success
chance made finding an enchanted blowgun a 0-skill no brainer: it was
always better to use it.

This commit removes blowguns. Needles are replaced with darts which are
thrown. Darts have the same brands as needles. To replace blowgun
enchantment, hex dart succes scales as (2/3) * (throwing + stealth),
preserving the ability to land hex darts against high HD targets, but
requiring a strategic cost to do so.

As a bonus, no more stories about bladders or bellows for mummies are
required.

--------------------------------------------------------------------------------
5c6fb1c | Chris Campbell | 2019-05-09 18:30:35 +0100

Update CREDITS.txt

--------------------------------------------------------------------------------
79c1ce7 | ByrelMitchell | 2019-05-08 10:34:34 -0700

Remove reference to Akashic Record in wizlab.des (Mintice) (#1058)

--------------------------------------------------------------------------------
bb66a67 | Chris Campbell | 2019-05-07 19:18:25 +0100

Update manual for wand and spell library changes

--------------------------------------------------------------------------------
80dedec | Michael Nowack | 2019-05-07 18:42:50 +0100

Update wand information in manual (#1050)
* Wands have an other behavior since the wand merge

I have used texts from https://crawl.develz.org/trunk/changes.txt

* Integrated feedback

1. Lines should not be longer than 80 characters.
2. grammar mistake fixed.
3. use Australian English spelling.

--------------------------------------------------------------------------------
2392399 | Chris Campbell | 2019-05-07 18:33:38 +0100

Remove an unused monster flag
M_ALWAYS_CORPSE was obsoleted with the removal of putrid demonspawn.

--------------------------------------------------------------------------------
312109b | Chris Campbell | 2019-05-07 18:33:38 +0100

Don't let Pikel slaves drop corpses or items
Remove their animal skins and increase their base AC instead, and prevent them
from dropping corpses.

--------------------------------------------------------------------------------
9f7f258 | nlavsky | 2019-05-07 18:28:49 +0100

Remove some traces of the tome of Destruction (#1053)

--------------------------------------------------------------------------------
3c078ff | advil | 2019-05-06 22:20:20 -0400

Fix sprint inheriting seed from persistent options
After regular game end, sprints were accidentally picking up the seed
from the previous game. This commit still allows their seed to be set
explicitly from an rc file, but otherwise causes them to ignore the seed
UI. Also affects hints mode and tutorial, and will show an rc-set seed
in the menus for sprint ant tutorial.

--------------------------------------------------------------------------------
9fb9971 | Edgar Bering | 2019-05-03 16:27:16 -0400

Add a security warning to the comments (CanOfWorms)

--------------------------------------------------------------------------------
7ba0370 | floraline | 2019-05-03 16:01:03 -0400

Log IPs correctly when behind a reverse proxy
This change allows webtiles to accurately log IP addresses when it is
running behind a reverse proxy.

Webtiles logs IP addresses when users connect to the server. This is
done by looking at the value of 'request.remote_ip', provided by
Tornado. When webtiles is running behind a reverse proxy, the value
returned by Tornado is the IP address of the proxy itself. This does not
uniquely identify users and results in a mostly useless log file.

This commit looks for the new setting 'http_xheaders' in config.py and,
if it is found, passes it along to Tornado.HTTPServer. When HTTPServer
is initialized with this setting, request.remote_ip will instead return
the value of header X-Real-IP if it is present. This header can be set
by a reverse proxy to indicate the actual IP of the real client.

Be warned that enabling this option when webtiles is NOT protected
behind a reverse proxy introduces a security risk. An attacker could
inject a false address into the X-Real-IP header. Do not enable this
option if the webtiles server is directly exposed to users.

--------------------------------------------------------------------------------
1a68c91 | Eino Keskitalo | 2019-05-01 17:44:45 +0300

Merge pull request #1049 from syranez/patch-1
There are two tournaments per year.
--------------------------------------------------------------------------------
7cec4da | Alex Jurkiewicz | 2019-04-30 21:16:18 -0700

Improve create_enum docs (#1052)

--------------------------------------------------------------------------------
a7546fe | advil | 2019-04-30 08:38:07 -0400

Replace some lingering instances of piercer
Piercer was merged into storm bow in 3ca0c319c68e.

--------------------------------------------------------------------------------
efa1973 | NormalPerson7 | 2019-04-28 09:44:11 -0600

Add bolt range behaviour to bolt spell descriptions
Add a one-line description of how bolt spells' range is reduced by one
for each monster the bolt strikes, to all relevant bolt and bolt-like
spells and abilities. Until now, this information wasn't documented
anywhere. The description is:

"The range of the [bolt/blast/jet/ball] is decreased by one for every
creature it strikes."

The spells whose descriptions are changed by this commit are:
  Breathe Dispelling Energy
  Breathe Frost
  Breathe Steam
  Breathe Noxious Fumes
  Bolt of Cold
  Bolt of Draining
  Bolt of Fire
  Bolt of Magma
  Chilling Breath
  Cold Breath
  Corrosive Bolt
  Crystal Bolt
  Energy Bolt
  Fire Breath
  Metal Splinters
  Quicksilver Bolt
  Steam Ball
  Venom Bolt.

The bolt-like spells and abilities whose descriptions are not affected
by this commit are:
  Breathe Fire (I'm not actually sure what uses this ability, apart from
                red draconian players, for whom the ability is
		different anyway.)
  Random Bolt
  Shadow Bolt (used for Dithmenos worshippers).

The five lightning-type bolt spells' ranges are not affected in this way
and hence not changed. They are:
  Breathe Lightnng
  Blinkbolt
  Electrical Bolt
  Lightning Bolt
  Shock.

--------------------------------------------------------------------------------
81e821a | Michael Nowack | 2019-04-28 10:19:15 +0200

There are two tournaments per year.
Actually, after each release a tournament will be held, but I do not think, it 
is relevant at this point.
--------------------------------------------------------------------------------
67e6301 | CanOfWorms | 2019-04-28 02:19:05 -0400

Actually remove evilmike_surprise_oklob

--------------------------------------------------------------------------------
8fb62da | CanOfWorms | 2019-04-28 02:17:55 -0400

Remove a vault with an obsolete gimmick
The design of this vault forces players to dig through walls to obtain loot,
revealing an oklob hidden behind an opaque diggable wall. On top of
encouraging spoilers, the change to wand targeting allows players to safely
dig the walls without revealing the oklob, neutering the gimmick. The idea
still exists in other vaults, e.g. minmay_lair_oklob_items, so there's no need
to keep it around.
--------------------------------------------------------------------------------
6f7e2cb | advil | 2019-04-26 17:50:56 -0400

Fix signed casts causing build-specific behavior in random names
Random letter choices in make_name were casting a pseudo-random unsigned
32bit integer to int and then modding it with something of type size_t,
which will usually implicitly cast it back to size_t (which is unsigned
and may vary across platforms; the cast is triggered because it
typically is bigger than the int type so has a higher rank). If the int
value ended up as negative in the first cast, the implicit cast to
size_t was coming out differently on different platforms, leading to
different random names (basically depending on whether it was a 32bit or
64bit build).  This change maintains unsignedness throughout for more
stable behavior.

Because random naming uses its own rng objects, the effect of this was
partitioned off from anything else in levelgen, leading to identical
properties on randarts with different names across platforms in gotm 2
(since windows is a 32bit build).

--------------------------------------------------------------------------------
b3763e6 | advil | 2019-04-25 10:52:18 -0400

Revert "Revert "Better separate level generation from level loading/entry" 
(NP7)"
This reverts commit 14115134c206528439226e57c192850df5666347.

--------------------------------------------------------------------------------
1911a96 | advil | 2019-04-25 10:52:18 -0400

Properly delete visited marker when a level is deleted
and also clarify the semantics of level_visited. This fixes weird
behavior when revisiting pan levels (it will also affect zigs, and
revisiting portal vaults in wizmode) where state was not correctly
initialized when entering a newly generated level, because the player
had visited a level with that level_id before.

If there's any games still saved in pan with the broken state, after
upgrading to this they can fix with a save and reload.

--------------------------------------------------------------------------------
1411513 | Alan Malloy | 2019-04-24 09:47:09 -0700

Revert "Better separate level generation from level loading/entry" (NP7)
This reverts commit a0fc33f7246dc8e3f7e9bd647f78399882ea6478.

It was causing serious graphical issues in Pandemonium for
local tiles and webtiles builds.

--------------------------------------------------------------------------------
a0fc33f | advil | 2019-04-22 16:31:50 -0400

Better separate level generation from level loading/entry
These were previously completely intertwined. Before 0.23, level
generation was only ever done on an attempt to enter a new level. For
0.23, level generation was a special case load mode for the call to
load_level, with complicated shared setup code for the generation call.
This commit pulls the relevant setup and cleanup out of load_level so
that a level can be generated without needing to call load_level at all.
There is a small cost in code duplication, but the comprehension cost
for doing this together with level loading was much higher.

--------------------------------------------------------------------------------
bc55a45 | advil | 2019-04-22 16:31:50 -0400

Eliminate some spurious messaging on wizmode level change
If you enter a monster's los, and then exit it off level (e.g. via &d)
instantaneously, and the monster's slot is taken up by a new monster on
the new level, you would be told that this new monster had moved out of
view. This change causes the queue of just seen monsters to be cleared
on a level change, otherwise it required a world_reacts cycle. It's hard
to get this bug to happen without wizmode, but it might have been
possible with serpent's lash and very specific stair placement.

There's still some cases where this messaging interacts badly with
0-turn actions, e.g. serpent's lash on the same level, but there at
least it prints a message about the correct monster.

--------------------------------------------------------------------------------
32ec7ca | Joshua Gelbard | 2019-04-20 23:01:43 -0400

Don't assume some identified jewellery is boring
Make some autopickup-related lua code less eager to forget about
potentially-useful jewellery.

Old defaults for autopickup_exceptions would remove some items (e.g.
ring of poison resistance) from autopickup as soon as the subtype was
known, since you only ever need one. Now that it's possible to learn
what an rPois ring looks like by seeing a monster wear it, that behavior
occasionally leads to useful rings and amulets being left unnoticed on
the ground. To prevent that, don't assume such only-need-one items are
safe to ignore unless the player is actively carrying one around.

--------------------------------------------------------------------------------
2aa1166 | Chris Rendle-Short | 2019-04-20 22:54:27 -0400

Use high-res app icon on all platforms
Previously the 512x512 app icon was only used on MacOS, and all other
platforms used the 32x32 icon. This change is to use the 512x512 icon on
all platforms.

--------------------------------------------------------------------------------
3a7c41b | mgdelmonte | 2019-04-20 22:53:29 -0400

Add more monster info to Lua
Expose AC, EV, MR, and MaxHP in the CLua monster.info class.

Provide an optional "full description" string from desc().

Add a function defeat_mr(spell, evoked) that returns the chance for the
provided spell (from the spells module) to defeat the monster's MR. The
parameter evoked indicates if the spell is fired from a wand.

All of this information is provided to the player, so there are no
information leaks.

[Committer's note: Elaborated in the commit message, Closes #970]

--------------------------------------------------------------------------------
1edb078 | gammafunk | 2019-04-20 14:40:14 -0500

Add the polymoth tile as a player tile (laurel)
This fanciful monster never made it to the 0.13 release, but it had an
especially nice tile:

http://crawl.chaosforge.org/Polymoth

Re-add the tile as a player tile option, which you can use by adding
something like the following to your RC:

```
tile_player_tile = tile:mons_polymoth
```

--------------------------------------------------------------------------------
528a52d | Edgar A. Bering IV | 2019-04-20 10:55:16 -0400

Update CREDITS.txt

--------------------------------------------------------------------------------
f46a388 | Edgar A. Bering IV | 2019-04-19 07:52:03 -0400

Don't crash when a monster attempts to use Random Effects
The spell is not implemented as a monster spell at present, which led to
crashes. This is the quick fix to prevent those crashes. The XXX: teach
monsters to use random effects remains outstanding.

--------------------------------------------------------------------------------
bee43f9 | olowin | 2019-04-18 23:25:19 -0400

Update Gyre and Gimble
Remove the -3 Dex and add the protection brand which is not currently
used by any unrand and compensates somewhat for locking out a shield.
The enchantment is bumped to make the effective damage roughly the same
as with the piercing brand. According to fsim, +7 gives slightly more
and +6 gives slightly less than the orginal.

[Closes #1026]

--------------------------------------------------------------------------------
6d359e7 | kitchen-ace | 2019-04-18 23:12:54 -0400

Add second brand to description for Thermic Engine and Storm Bow

--------------------------------------------------------------------------------
13415af | Joshua Gelbard | 2019-04-18 23:07:34 -0400

Fix a couple Engulf-related bugs
Fix a bug where Engulf status wouldn't update on time if the player
escaped via an instant action like Serpent's Lash movement or a
retaliatory headbutt. (Instead of setting the remaining duration to
one aut and waiting for the enchantment decrement step to finish it
off, just clear it on the spot.)

Also remove buggy immunity to engulf. Escaping from being engulfed was
supposed to have been conferring one turn of immunity, but the amount
given has always been effectively zero. Since no one seems to have
noticed, it's probably fine to just remove it.

--------------------------------------------------------------------------------
7384745 | Edgar A. Bering IV | 2019-04-18 22:36:04 -0400

Teach monsters to use scattershot, cloud, and iceblast wands
This refactors monster wand usage to deduplicate some of the beam and
tracer codepaths for wands and other beams.

Specifically monster wand evocations now go through the mons_cast
codepath. This has the unfortunate need of adding a spell flag to
indicate an evoked spell; however the benefit is that monster wands now
pass through the more sophisticated monster casting code that previously
handled the rod versions of scattershot and cloud. As a result monsters
now know how to use scattershot, cloud, and iceblast wands.

The monsters use the new wands with a power of 30 + hd, identical to the
power used for existing wands. This is a flatter power curve than the
old rod spells, making them more dangerous on low HD monsters. However,
some playtesting indicates that these are not worse than an early acid
wand in damage level.

--------------------------------------------------------------------------------
c7211da | Chris Campbell | 2019-04-18 23:30:51 +0100

Remove some dead Cigotuvi's Embrace code

--------------------------------------------------------------------------------
b86c0f7 | Chris Campbell | 2019-04-18 21:59:59 +0100

Clean up more default force_more_messages

--------------------------------------------------------------------------------
927fd9e | kitchen-ace | 2019-04-18 21:53:18 +0100

Minor changes to default force_more_messages (#1037)
"Careful!" was being triggered by allies that sometimes said
"Be careful!".
--------------------------------------------------------------------------------
86c1934 | Chris Campbell | 2019-04-18 21:38:42 +0100

Fix a message colour entry

--------------------------------------------------------------------------------
1d4c5a4 | nlavsky | 2019-04-18 20:59:34 +0100

Fix local tiles monster panel showing summoner halo for all enemies (#1038)
This was happening because the packed_cell constructor was not
initializing `is_highlighted_summoner`.
--------------------------------------------------------------------------------
f493760 | advil | 2019-04-17 17:18:38 -0400

Prevent messages from impacting non-UI generators
This may be overkill, but a lot of things can happen during messaging in
crawlcode, so this will ensure that none of those things will ever
affect the levelgen (or gameplay) rng.

--------------------------------------------------------------------------------
26cb771 | advil | 2019-04-17 17:03:11 -0400

Don't use div_rand_round for noise values
In wizmode, this could have the following effect: in a non-pregen game,
when a noise happened before descending to a new level, as long as
levelgen triggers a more, drawing the wizmode noise bar could cycle the
levelgen rng while rerendering the hud during that more. (I hope there
aren't more things like this, but there might be, as quite a lot of code
gets called on a more. So it may be worth just forcing the ui rng for
doing mores.) Luckily, non-wizmode noise rendering doesn't call this
code path.

--------------------------------------------------------------------------------
5076262 | advil | 2019-04-16 22:39:55 -0400

Remove some unused arguments
These were used in placing stair mimics, but those haven't placed since
434df5b33ac1.

--------------------------------------------------------------------------------
44e327e | ufshaikh | 2019-04-15 10:38:40 -0700

Show traps in ctrl-x screen (#1035)
This commit exposes traps along with features in the ^X display of
what is in LOS. This should cut down on manual movement of the cursor
with xv to discover what type a trap is, and allow the player to
quickly distinguish which types are currently in LOS in areas with many
traps.
--------------------------------------------------------------------------------
6074511 | advil | 2019-04-13 09:58:29 -0400

Initialize `you.trapped` to false
Previously, this was uninitialized, so on some builds the first
time-taking action after loading the game could roll random trap
effects, regardless of whether a new square was revealed. The exact
behavior would be implementation/compiler-dependent, but on OS X it was
getting a random-ish value presumably determined by whatever was in
memory before, and I suspect this would be the typical behavior.

--------------------------------------------------------------------------------
2af7e83 | advil | 2019-04-12 12:25:42 -0400

Prevent wand of enslavement from being used under sac love
Before this commit, despite being grayed out, this wand worked just
fine. The implementation, in order not to waste turns, just makes it
completely unevokable with sac love. For the sake of consistency I
applied this change to all evokers that are useless in this case. An
alternative for enslavement might be to prevent it in targeting, which
is how phantom mirror previously worked, but the present approach seemed
cleaner and wastes the players time less. It might also be good to make
a note in the item descriptions that they can't be used so this isn't
indicated only by inventory color.

In general, enslavement still works under other god conducts that
otherwise prevent some but not all summons. This probably could use some
thinking, because as NP7 pointed out in chat, it leads to confusing and
variable behavior e.g. for spellcasters enslaved under Trog. However, to
implement this without taking turns in the general case is a bit tricky.
See also 706f6395352a.

--------------------------------------------------------------------------------
e44751f | advil | 2019-04-12 12:25:42 -0400

Better messaging for when phantom mirror fails (Yermak)
This now prints a specific message for every case, not just sac love.

--------------------------------------------------------------------------------
369f6e7 | Chris Campbell | 2019-04-12 16:38:15 +0100

Improve description of protection brand

--------------------------------------------------------------------------------
b963c9a | Nikolai Lavsky | 2019-04-11 23:06:12 -0400

Always display the duration of the last action on the HUD (Yermak)
Because of how the score is calculated, it might be more useful to have
player turns instead of elapsed time on the HUD.
`show_game_time = false` replaces time with player turns, but also
hides the duration of the last action. The HUD is the only place that
shows this duration, so players who care about their score have to use
the default value for show_game_time and have to regularly check their
turns via the E or % commands.

After this commit, the HUD will display the duration regardless of the
show_game_time's value.

--------------------------------------------------------------------------------
b507512 | Chris Campbell | 2019-04-11 20:17:44 +0100

Fix typo

--------------------------------------------------------------------------------
a6a6ab7 | gammafunk | 2019-04-09 16:15:05 -0500

Use the correct LOS for Sacrifice Courage (Reeces)
Before this commit, monsters behind glass would cause the Horror debuff
from Ru's Sacrifice Courage to apply. This is annoying due to the
interruption and messaging it causes, and these monsters aren't actually
dangerous. This commit has Sacrifice Courage consider monsters behind
transparent walls as safe and uses an appropriate monster iterator
instead of a distance-based one.

--------------------------------------------------------------------------------
8f5f5cd | gammafunk | 2019-04-08 19:15:26 -0500

Don't use a more() for LOS spells (kitchen_ace)
Currently LOS attack spells use a more() prompt every time they fire.
This may be so that the flash animation they use can actually have time
to display. The more() prompt is not removable by the player and is
especially annoying for frequent LOS spells under e.g. the Singing
Sword. This commit removes the more() and instead uses a delayed flash
animation of 300ms, like we do for many other LOS-based spells.

--------------------------------------------------------------------------------
9885673 | gammafunk | 2019-04-08 19:15:26 -0500

Fix a comment typo

--------------------------------------------------------------------------------
870ddcc | Higor Eurípedes | 2019-04-08 18:27:28 -0400

Let the player know that the gauntlet effect isn't permanent
Let the player know that the gauntlet effect isn't permanent

--------------------------------------------------------------------------------
6e284d2 | Higor Eurípedes | 2019-04-08 18:27:28 -0400

Show NoTele warning every time the player enters gauntlet
Now the message will be displayed when the player returns from the
abyss.

--------------------------------------------------------------------------------
aa57d61 | Higor Eurípedes | 2019-04-08 18:27:28 -0400

Warn the player that teleportation doesn't work in gauntlet
Gauntlet prevents long distance translocations from happening (NoTele),
but the user won't know about this until they check the % screen,
read a scroll of teleportation or notice that teleportitis hasn't
triggered since they entered the branch.

--------------------------------------------------------------------------------
ece4408 | NormalPerson7 | 2019-04-08 18:24:29 -0400

Turn off skill targets when aptitudes change from level up (11943)
Add a call to check_training_targets() into the function
check_skill_level_change(). Also, update an inaccurate comment about
this function.

--------------------------------------------------------------------------------
81a6c4f | Alan Malloy | 2019-04-08 15:20:50 -0700

Remove an old die() that's been replaced by an ASSERT

--------------------------------------------------------------------------------
38e41d7 | Alan Malloy | 2019-04-08 15:20:49 -0700

Don't message about tormented monsters outside LOS (Yermak)

--------------------------------------------------------------------------------
3f03afc | advil | 2019-04-04 13:34:27 -0400

Don't let unarmed skill when unarmed determine delay of fumble-throwing
Probably fixes 11942.

--------------------------------------------------------------------------------
4d52153 | advil | 2019-04-04 09:57:04 -0400

Remove __DATE__ and __TIME__ from compilation info
See https://reproducible-builds.org/docs/timestamps/

While looking at various downstream packaging setups, I noticed that
they all have to patch this out anyways for reasons in the above link.
If anyone has ever actually used this information for debugging (over
and above the version info) I'm happy to rethink, but including this
seems unnecessary to me.

--------------------------------------------------------------------------------
aef371a | advil | 2019-04-04 09:29:12 -0400

Fix a Makefile typo
I noticed this reported in the following debian bug, it may be fixed
downstream already:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871419

--------------------------------------------------------------------------------
49d9ff8 | advil | 2019-04-02 20:00:26 -0400

Force SSE2 (again) for win32 builds
This is a much more restrained version of 3d66cf40a65a. As discussed in
with windows being the exception: we (apparently) need to keep building
windows as i386, which does not imply sse, but as of 2018 all windows
versions >=7 require CPUs with SSE2 support. Since the revert in
6492a9889c, floating point issues on windows builds have continued to
crop up, where x87 calculations return different values (because of
intermediate 80 bit precision) than regular SSE-based calculations in
some cases. It also turns out that x87 issues are exacerbated by
building with -O2, which debug builds don't use (so I'd missed a bunch
of cases until discovering this).

It's possible that there are more specific / other compiler flags that
could help mitigate these issues, but none of them seem very reliable or
guaranteed. -ffloat-store reportedly works sometimes. If we were using
C, then -fexcess-precision=standard might be an option, but as far as I
can tell this still doesn't work for c++. Better to just avoid x87
entirely.

(The real solution is to remove all floating point calculations...)

For backstory, see:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=323
  
https://stackoverflow.com/questions/7517588/different-floating-point-result-with
-optimization-enabled-compiler-bug
  
https://yosefk.com/blog/consistency-how-to-defeat-the-purpose-of-ieee-floating-p
oint.html

--------------------------------------------------------------------------------
9da92b9 | advil | 2019-04-02 19:33:11 -0400

Add a warning to the seed dialog for x87
x87 calculations in gcc, at least with -O2, lead to known differences
from sse-based floating point calculations, and this will continue to be
true until we get rid of floating point altogether. (This has mostly
been rearing its head in dealing with the windows builds, for which I'm
going to take a different approach, but can also come up for 32bit linux
builds.) So, indicate that we don't fully support seeding on builds that
use x87 math. (Where x87 math is assumed to happen on an x86 build that
does not use SSE of some kind.) This *might* be solvable by messing with
more fine-grained options on gcc, but if so I haven't figured it out.

(This commit isn't meant to imply that x87 is the *only* thing like this
that could lead to floating point instability, but it is the one that
I've tested the most carefully.)

--------------------------------------------------------------------------------
536ed4e | advil | 2019-04-01 15:43:25 -0400

Don't remain in % menu after dropping, etc.
This menu lets you view items, and from there you drop them, take them
off, etc. Before this commit, the player could trigger these arbitrary
numbers of times from the % menu, lining up multiple armor-off delays
for when they exit the menu, which would then crash. This change simply
respects the return value for describe_item.

--------------------------------------------------------------------------------
3ce5c5b | advil | 2019-04-01 10:10:39 -0400

Fix rng independence issues with setup_xom_dancing_weapon
Because these variables were not set up as `locals` (so were part of the
global state), and not every case in the if sequence initialized every
call, subsequent calls to this could be affected by earlier calls in a
non-intended way. As long as the calls were done in the same order this
won't affect seed stability per se, but it shows up as a stability error
in the test, and it's better not to do this with global state.  This
code *is* still dependent on global state in that it's affected by
whether the mace of variability has spawned, but otherwise it should act
independently on repeated calls.  I've also pulled out the roll for
variability so that it happens regardless of whether the mace has
previously generated; this way the number of rng draws is independent of
this global state.

Ironically, the biggest problem here on the seed where this came up
(185349672) was the mace of variability variable being global.

--------------------------------------------------------------------------------
05560da | advil | 2019-03-31 17:04:39 -0400

Update credits
Noticed in a wordpress comment: 
http://crawl.develz.org/wordpress/crawl-0-23-nemelex-needs-traps-badly/comment-p
age-1#comment-3015

The comment didn't express a preference as to use, so I went with real
name.

--------------------------------------------------------------------------------
1a43be2 | NormalPerson7 | 2019-03-31 10:46:02 -0400

Fix spurious message on moving into door with wall_jump_move (11940)
When attempting to move into a closed door with the wall_jump_move
option set to true, the function wu_jian_can_wall_jump was being called,
which meant spurious messages describing why wall jumping was impossible
in the current situation were being printed to the message log.

To fix this, move the check for moving into a closed door (a situation
where it is not possible to wall jump by moving) to inside the
definition of bool can_wall_jump, before the function
wu_jian_can_wall_jump() is called.

Also remove an unnecessary variable (targ_grid) and replace it with
grd(targ) everywhere.

--------------------------------------------------------------------------------
ca05e9d | advil | 2019-03-30 20:42:24 -0400

Update changelogs from 0.23 branch

--------------------------------------------------------------------------------
7109231 | advil | 2019-03-30 20:34:12 -0400

Sync changelog with 0.22 branch

--------------------------------------------------------------------------------
df45623 | advil | 2019-03-30 20:32:08 -0400

Update debian changelog for 0.22.2
(cherry picked from commit e965b3aba33ea031970dc6c595116b0a96a5b81e)

--------------------------------------------------------------------------------
ca93661 | advil | 2019-03-30 19:11:10 -0400

Update sdl2 contrib with mac resize fix (11895)
See the SDL2 commit message for details:
  
https://github.com/crawl/crawl-sdl2/commit/07f787c0da7df6e37bd71a71b6e833fd9b88a
dea

--------------------------------------------------------------------------------
1ac5efa | Edgar A. Bering IV | 2019-03-30 14:19:28 -0400

Update CREDITS.txt

--------------------------------------------------------------------------------
0b285d4 | Koen De Groote | 2019-03-30 12:12:42 -0400

Update religion.cc
Typo
--------------------------------------------------------------------------------
0142750 | advil | 2019-03-30 09:54:48 -0400

Linebreak level annotations in chardumps (11904)
This isn't really a complete solution: in general, the chardump doesn't
fully respect 80 chars, this was just the most egregious example. ?# on
tiles is fine with everything else I tested, in that it typically
doesn't expand past the end of the screen, but ?# on console truncates
on the right rather than centering, so still has a bunch of issues. I
think a complete solution needs: (i) on tiles, prevent
formatted_scroller from being wider than the displayable area, (ii)
implement left-right scrolling in formatted_scroller, and (iii) take
another pass to see what can be truncated at 80 characters. (For
some things, like the action table, this probably isn't possible, but
long equipment names for example could be better managed.) I did
consider truncating the entire main chardump at 80 characters but this
tends to look kind of bad in a lot of cases.

This commit also tweaks some wizmode formatting for vault lits so it's
readable in console in ?#.

--------------------------------------------------------------------------------
9656df7 | Nikolai Lavsky | 2019-03-30 02:00:11 -0500

Don't try to generate any removed branches in mapstat
As a followup to 17bec22d, this commit prevents mapstat from generating
the other removed branches: the Dwarven Hall and Hall of Blades.

It affects only the latter though, because the Dwarven Hall doesn't have
any maps and cannot be generated anyway.

--------------------------------------------------------------------------------
a595e75 | advil | 2019-03-29 20:11:03 -0400

Place transporters consistently in abyss
Before, they were placing correctly when first entering an abyss level,
because that code used the builder; they were also shifting correctly.
But when a transporter vault placed as part of tele/movement-based
generation, transporters were not being placed on the markers correctly
because this code path *doesn't* use the builder. So, call the
transporter conversion function directly after placing new vaults.

--------------------------------------------------------------------------------
1152973 | Umer Shaikh | 2019-03-28 23:09:35 -0400

Check trap effects' validity before choosing effect
The current flow is to decide whether the player is trapped when
revealing a tile (player_view_update_at calls roll_trap_effects); if so,
you.trapped is set to true. The next time the world reacts,
do_trap_effects is called and then you.trapped is cleared back to false.
Currently do_trap_effects rolls for which trap effect will happen and
then checks to see if it is allowed to happen in that place; if not,
nothing happens. This has the result that, all else equal, the player is
less likely to suffer any trap effect on floors where one of the effect
types is ruled out, e.g., the player is less likely to get trapped on
Snake:3 than Snake:2.

This commit changes do_trap_effects to first find the valid trap effects
for the location and then choose among them. So, all else equal, the
player will be just as likely to get trapped on a floor where shafts
cannot be placed---the other trap effect types will pick up the slack.
(In general all else is not equal, since trap effect rate depends on
depth; see trap_rate_for_place. But probably this means that code
affecting rate of triggering trap effect should be there, and not rolled
in with code choosing the effect in do_trap_effects.)

[Committer's note: simplified using a random_iterator, Closes #1009]

--------------------------------------------------------------------------------
b3ba8b5 | Umer Shaikh | 2019-03-28 23:09:35 -0400

Refer to function by name, not position, in comment
This makes the comment a little less likely to go out of date if someone
starts moving things around in the future.

--------------------------------------------------------------------------------
494fbac | Umer Shaikh | 2019-03-28 23:09:35 -0400

Use a function instead of duplicating logic
The function do_trap_effects duplicates logic from
is_valid_shaft_effect_level. The latter function is apparently never
called. I suspect the intention was for do_trap_effects to call
is_valid_shaft_effect_level and the author forgot to make the change. In
any case, this commit removes the logic from do_trap_effects and inserts
a call to is_valid_shaft_effect_level.

--------------------------------------------------------------------------------
cd7e529 | Umer Shaikh | 2019-03-28 23:09:35 -0400

Remove use of testbits in is_valid_shaft_effect_level
Testbits isn't necessary here; it's sufficient to use & to see whether
the branch has the dangerous_end flag. This is at least as easy to read
and removes an unnecessary equality test. Note that this is what
do_trap_effects already does in its version of this logic.

--------------------------------------------------------------------------------
3ca0c31 | kitchen-ace | 2019-03-28 22:51:08 -0400

Merge Piercer into the storm bow
The storm bow is functionally the same as a +8 elec longbow; fairly
strong, but unremarkable. Piercer is a little better since it's a bow
user's only way to get a penetration weapon, but that's still not too
special.

Adding a penetration effect to the storm bow makes it much more
exciting, fits the electric/lightning theme, and puts it almost on par
with the other unrand bow Zephyr. This also makes Piercer obsolete.

--------------------------------------------------------------------------------
90687ab | Joshua Gelbard | 2019-03-28 22:27:33 -0400

Add new message for re-corroding a corroded foe
When reapplying ENCH_CORROSION on a monster, make it clearer in the
printed message that it's just a duration increase and not a stacking
effect.

Old: zap wand of acid -> The acid corrodes the death yak! -> zap -> The
acid corrodes the death yak!

New: zap wand of acid -> The acid corrodes the death yak! -> zap -> The
death yak seems to be corroded for longer.

--------------------------------------------------------------------------------
51c60a9 | Joshua Gelbard | 2019-03-28 22:27:01 -0400

Don't ignore autopickup settings after autobutcher
Food generated by autobutchery was being allowed to re-use the
item_needs_autopickup result from back when it was a corpse. Force it
to be re-checked after creation instead.

--------------------------------------------------------------------------------
bac502f | Andrew O'Neill | 2019-03-28 22:26:24 -0400

Fix CMD_MAP_UNFORGET in colemak keybindings
CMD_MAP_UNFORGET is overwritten in colemak_command_keys.txt
I propose setting it to F since it is similar to CMD_MAP_FORGET [^F]
--------------------------------------------------------------------------------
0fa666e | NormalPerson7 | 2019-03-28 22:21:38 -0400

Let formicids dig statues (Yermak)
Previously, the types of walls that formicids could dig was hardcoded in
move_player_action. This commit changes the check to use the function
feat_is_diggable, the same check that is used for digging wands, to make
formicid digging exactly equivalent to the wand form.

--------------------------------------------------------------------------------
17bec22 | gammafunk | 2019-03-28 16:20:51 -0500

Don't try to generate Labyrinths in mapstat (vt)
When running mapstat without any level specification, which implicitly
means "all dungeon levels", don't include Labs. Labs no longer have a
layout, so trying to generate the branch will crash.

--------------------------------------------------------------------------------
c779bbd | advil | 2019-03-28 14:29:12 -0400

Don't let overwrite_floor_cell place on transporter markers (11936)
This crash was happening because the abyss entry portal for depths 4
placed on top of a transporter map marker, and those markers get turned
into transporters fairly late in levelgen in a way that unconditionally
overwrites whatever features are there. Then the game crashed on the map
debug scan because a portal is supposed to be guaranteed on this level.

This fix explicitly checks for this kind of marker when placing vaults
that have overwrite_floor_cell; this tag is used for all the fallback
entry vaults for depth, as well as uniq vaults (where this issue doesn't
matter). This solution fixes this exact problem but does point towards
other potential levelgen issues, in that transporters are treated as
floor terrain until the very last minute. I wonder if it might work
better to place transporter features with the markers, and then only do
the connection part at the end of levelgen? But it's also possible that
this won't come up too much, since aside from this case I don't think
there's a way to overwrite any transporter vaults.

--------------------------------------------------------------------------------
696e1f2 | NormalPerson7 | 2019-03-28 12:58:29 -0400

Don't place shafts in ebering_ghost_disaster_area (11926)
This commit prevents the vaults ebering_ghost_disaster_area and
ebering_vaults_ghost_disaster_area from placing shaft traps, instead
placing only water and lava tiles, implementing option 2 in 11926.
This change is to prevent ghosts in these vaults from being shafted
immediately when they enter line of sight of the player, before the
player can do anything to stop this.

These vaults were introduced by commits bb431e2 and a6a7277
respectively, and appear to have been introduced with the idea that
ghosts cannot be shafted. Ghosts can now be shafted, as of 8c2e593, and
this means that these vaults in particular could cause ghosts to be
shafted to lower floors, leaving behind an empty (or mostly empty) ghost
vault for the player to raid, and allowing the ghost to be encountered
outside of its vault on a lower floor, with the player then unable to
choose whether to fight the ghost.

--------------------------------------------------------------------------------
1d96822 | gammafunk | 2019-03-27 22:54:49 -0500

Remove a digging Trove
The map trove_dig had the player individually dig out 20 items with dig
wands, but this is very tedious. The items in this trove are just
typical trove items, so the map isn't otherwise bringing anything
interesting to the portal.

--------------------------------------------------------------------------------
6c8b4eb | Kyle Rawlins | 2019-03-27 22:06:54 -0400

Small tweaks to the .deb guide
[skip ci]
--------------------------------------------------------------------------------
f0bc1e9 | CanOfWorms | 2019-03-25 15:28:06 -0400

More tweaks to tgw_lugonu_bribe
More adjustments to bribes:

* Remove Pakellas from the bribe list.
* Beogh's "bribe" is changed to an orc corpse.
* Remove the book from Kiku's bribe, since the library makes it
  unlikely that the player will see the contents.
--------------------------------------------------------------------------------
19c84a8 | CanOfWorms | 2019-03-25 04:03:40 -0400

Update tgw_lugonu_bribe
Fix some bribes that are no longer relevant due to changes in
god conduct, and adjust some to match flavour better.

* Dithmenos bribes are useless items that may be unsuitable
  for high stealth characters.
* Jiyva bribes are removed now that jellies can eat stones.
* The Shining One bribes are weapons with evil brands instead
  of a Poison book.
* Zin bribes are changed to focus on the dislike for chaos and
  transmutations. Lignification potions replace evil weapons,
  which have been moved to the Shining One.
--------------------------------------------------------------------------------
f205589 | advil | 2019-03-18 18:30:55 -0400

Better newgame messaging when a game already exists
Before, if a game already existed under the name, any menu option that
would start a game with that name prefilled (from prefs) would just load
the existing game, regardless of game type. Before seeded games, this
only affected tutorial vs. regular games, but it's now even more
confusing with seeded games. These menus are still a bit of a mess, so
this could use some more work (it might be better to prompt for a
different name from the seed menu, or do the check before opening that
menu).

--------------------------------------------------------------------------------
aac6ce0 | advil | 2019-03-18 18:30:55 -0400

Add version number to seed selection menu
To try to more clearly cue that this is version-specific.

--------------------------------------------------------------------------------
c186064 | Chris Campbell | 2019-03-18 20:22:52 +0000

Don't highlight summoners that are out of LOS
Fixes a crash when the summoner is entirely off-screen.

--------------------------------------------------------------------------------
76deb67 | Chris Campbell | 2019-03-18 16:38:45 +0000

Don't highlight the summoner of rakshasa illusions
And additionally don't highlight the source for perma-summons (such as Twisted
Resurrection abominations), since they're not abjured by killing the summoner.

--------------------------------------------------------------------------------
62cde1d | advil | 2019-03-18 12:00:39 -0400

Fix meatsprint (11834)
Meatsprint distributed monsters by placing them in a secret room, and
then letting them walk into permanent teleport traps. The trap changes
in 0.23 broke I think several of the assumptions this strategy made,
most importantly that tele traps work out of player los (66906bf02876).
This commit uses fundamentally the same approach, but instead of
teleport traps, uses a dlua call to teleport monsters immediately on
placement. It might be even simpler to do some kind of random placement
off the bat, but using the teleport code has various nice consequences
in terms of finding free spaces, etc. I also didn't put much effort into
seeing if there's a simple way to do this without the secret room.

It turns out that the previous implementation was letting some degree of
rate-limiting via monster random movement happen (I believe placement
could fail in cases where a monster didn't move off the spawn point). I
have done a rough rebalancing accordingly. With two spawn points instead
of 4, the overall spawn numbers are very closely matched; I would guess
that there's a slight increase in some of the higher-xp categories on
average, but there's plenty of variance so I'm not sure. This may need
more rebalancing based on feedback from people who have more experience
playing this sprint.

Here are some representative spawn numbers at turn 150:

0.23 with 2 spawn points:
Monsters: The Meatlord, 25 meat beasts, The Captor, The Defiler, The
Servant, 20 eight-headed meat hydras, 23 observers, 13 tyrants, 16
accurseds, 67 meat berserkers, 17 large bags of meat, 16 scourges, 33
destroyers, 13 wretched souls, 20 dreads, 161 bags of meat, 36
fleshlords, and 16 sculptors of flesh.
480 monsters, 35685031 total exp value (33124737 non-uniq)

(with 4 spawn points in 0.23 you hit the monster limit so it's more
annoying to compile the numbers, but they are unsurprisingly about
double this.)

0.22, with 4 spawn points:
Monsters: The Meatlord, 21 meat beasts, The Captor, The Defiler, The
Servant, 21 eight-headed meat hydras, 14 observers, 18 tyrants, 17
accurseds, 70 meat berserkers, 14 large bags of meat, 18 scourges, 37
destroyers, 21 wretched souls, 16 dreads, 170 bags of meat, 31
fleshlords, and 15 sculptors of flesh.
487 monsters, 32820392 total exp value (30260098 non-uniq)

--------------------------------------------------------------------------------
3dc15b6 | advil | 2019-03-18 10:05:10 -0400

Don't save seed pref for sprint, tutorial

--------------------------------------------------------------------------------
6c5f6a5 | advil | 2019-03-18 09:16:11 -0400

Disable seed .pref saving for DGL builds (11928 / kitchen_ace)
I didn't do this before because it doesn't actually affect anything
about starting a game, but I forgot that .pref reading uses regular
options reading, which will trigger an error for dgl builds if game_seed
is set. (There may be some harmless instances of this error remaining
that will only be visible to server admins until .pref files get
rewritten.)

--------------------------------------------------------------------------------
9bee6eb | advil | 2019-03-17 21:13:22 -0400

Save seed number in startup prefs on game end
The effect of this change is to autofill the seed selection box with the
seed from the last ended game. This saves only the seed in a kind of ad
hoc way. However, the alternate behavior, which would be to repopulate
the entire prefs file from the ended game, isn't trivial -- since it
doesn't seem that all startup prefs are actually recoverable from a game
save. (That ultimately still may be the most sensible behavior though.)

--------------------------------------------------------------------------------
dbdffe5 | Edgar A. Bering IV | 2019-03-17 19:25:57 -0400

Tiles for summoner highlighting
I went with cyan to match console.

Closes #801

--------------------------------------------------------------------------------
6afd290 | Edgar A. Bering IV | 2019-03-17 16:52:49 -0400

Simplify and rename a variable (aidanh)

--------------------------------------------------------------------------------
f5976a5 | Martin Aigner | 2019-03-17 13:54:31 -0400

Highlight summoners when the cursor is over a summon in targeting mode
As suggested by Antares on tavern.

--------------------------------------------------------------------------------
063869c | advil | 2019-03-17 13:52:06 -0400

Run dactions on entering any level, fixing gozag+pregen (Goratrix)
Previously, dactions run only on re-entering a level, and not on
entering a generated level. For bribe branch, this was dealt with by
having the builder set the relevant monster flags when generating a new
level. For pregen, this needs to be done on entering the level, and the
simplest way was to just run dactions when entering any level; this
seems like a cleaner approach they way dactions are thought of anyways.
There might actually be a few wrath-related actions that weren't being
run as well. I don't *think* there will be unexpected consequences of
this, and most dactions won't do anything on a new level. But, it's not
impossible that this won't have some strange side effect I missed.

--------------------------------------------------------------------------------
5d897e9 | Nikolai Lavsky | 2019-03-15 09:19:11 -0400

Prevent allied Shambling Mangroves from constricting themselves (11877)

--------------------------------------------------------------------------------
395302c | Umer Shaikh | 2019-03-15 09:03:23 -0400

Correct a comment
Lua function you.contaminated returns a number, not a boolean.

--------------------------------------------------------------------------------
2784ca5 | Umer Shaikh | 2019-03-15 09:03:23 -0400

Correct a comment
The comment misdescribes when the parameter auto_wield is true or false;
this commit brings it in line with the code.

--------------------------------------------------------------------------------
40992d5 | Joshua Gelbard | 2019-03-15 09:02:12 -0400

Fix splash noises when dropping item into water
Added a missing `!`. Behavior was reverse of intended: instead of
swimming characters being the only ones exempt from item splash sounds,
they were the only ones making them.

--------------------------------------------------------------------------------
c02bd79 | NormalPerson7 | 2019-03-15 08:38:53 -0400

Fix cut-off ability cost description (11893)
When the Sacrifice Purity ability is granted to the player with the
inhibited regeneration mutation, the ability's cost description is
  Purity (inhibited regeneration)
which is 31 characters, however the cost string was only allocated 30
characters, so the last parenthesis was being cut off.

Hence, extend the string length for the ability cost description to 32
characters, and adjust the ability screen's title line accordingly.

--------------------------------------------------------------------------------
cb5ae2c | Josh Gelbard | 2019-03-15 00:05:15 -0700

Start new wanderers with weapon in slot 'a' (#1006)
All new characters who start with a weapon wielded will now
find that weapon in slot 'a'. This was already true for all
backgrounds except wanderer.
--------------------------------------------------------------------------------
8902462 | Josh Braden | 2019-03-14 19:24:02 -0700

Use & instead of equal for holiness check (11909) (#1001)

--------------------------------------------------------------------------------
c7eaa07 | advil | 2019-03-14 15:20:27 -0400

Improvements to the seed selection ui
* make game_seed a sticky preference. This won't override rc preferences
  or CLI seed selection, but makes it a lot more convenient to dispense
  with ever setting it in an rc. The main effect is that this autofills
  the text box in the seed selection sub-menu; it doesn't affect
  the regular game start button (in contrast to selecting a seed in the
  regular rc).
* Fix a bug where a non-seeded game type could be started with a custom
  seed, if the game restarted after ending a seeded game started in the
  same session.
* add - as a shortcut to clear the seed input

--------------------------------------------------------------------------------
d121a6d | advil | 2019-03-13 14:27:20 -0400

Make search_astar more stable across platforms
This function is used by slime levelgen in order to ensure level
connectivity that doesn't require touching slime walls, and because of
this use matters for seeding in slime (both because its behavior impacts
what wall squares get removed, and because this astar implementation
draws heavily on the rng. The implementation was behaving differently
across platforms.  Because slime is pretty independent of other
branches, the instability was localized to that branch, but usually
affected the entire thing.

The basic problem is that the search fringe was sorted only by distance
in the priority queue, so if two coordinates were the same distance,
their ordering in the queue was implementation-dependent (and was
differing on mac vs linux builds at least). This fix makes the sort
stable in such cases by comparing coordinates as well. This won't
necessarily do anything for the speed of the search (perhaps LIFO
behavior would be better)...

I wonder if this overall approach is really the best way to ensure
connectivity in slime? And why does this algorithm need randomization
(classic a-star doesn't)? But this code is complicated enough that I'm
not going to mess with it further right now.

--------------------------------------------------------------------------------
654ca03 | gammafunk | 2019-03-12 23:40:16 -0500

New transporter and Golubria tiles (CanOfWorms)
Transporters, transporter landing sites, and Golubria passages get tiles
that better communicate how they are portals that take you to another
location.

--------------------------------------------------------------------------------
7a2c91a | advil | 2019-03-12 21:12:50 -0400

Add a debugging rng call
Lets you look one step ahead.

--------------------------------------------------------------------------------
5963e8c | advil | 2019-03-12 19:11:27 -0400

Convert some floating point math to better fixed point math
This math was leading to instability across seeds depending on the
particular way in which floating point math was done on a build and
system.

This uses a suggestion from |amethyst - since callers always use
`percent` values that are divisible by 10, can just do the math with a
single decimal point rather than two, which takes up a lot less space.
This makes the calculation more accurate than what it replaces (though
it still truncates, rather than rounds).  For that reason, I have put in
a temporary stopgap with the quirks of the previous implementation when
run using the SSE version of the old floating point calculation. I will
remove this at some point after 0.23.2 is tagged.  (But for now, this
keeps the gotm stable.)

--------------------------------------------------------------------------------
4d90231 | advil | 2019-03-12 09:17:31 -0400

Fix build try 2

--------------------------------------------------------------------------------
c3651c4 | advil | 2019-03-11 21:32:55 -0400

maybe fix the build

--------------------------------------------------------------------------------
e201941 | advil | 2019-03-11 21:11:48 -0400

Un-revert a Makefile fix
This was lumped in with the sse change, doesn't need to be reverted.

--------------------------------------------------------------------------------
1e70621 | Alan Malloy | 2019-03-11 16:02:37 -0700

Don't return NaN from prompt_for_float

--------------------------------------------------------------------------------
c15b636 | advil | 2019-03-11 16:32:50 -0400

Revert "Build for SSE2 on all systems, including 32bit targets"
No longer necessary. Results #996 (and #992 in a different way).

This reverts commit 3d66cf40a65a3843061e5a6d1106f9fa5d2b0bdb.

--------------------------------------------------------------------------------
c07d39d | advil | 2019-03-11 16:32:23 -0400

Revert "Add a build option to not use SSE"
No longer necessary.

This reverts commit fc1eed5d34c6ec5942309776f806e12eb0ccc867.

--------------------------------------------------------------------------------
9dfec57 | advil | 2019-03-11 16:17:44 -0400

Fix cross-platform lua number->int conversion the hard way
Lua 5.1 doesn't distinguish integers from numbers generally, and stores
numbers as doubles, but on the c++ side we very often want ints. In
3d66cf40a65a384 I discovered that, depending on where the lua library is
compiled, it may use different conversion methods in its conversion
calls, which have different truncation behavior, leading to seed
instability across systems (where it uses a specific hack on 32bit
non-sse builds, a different one in msvc, and a regular cast otherwise).
This behavior is determined at compile-time in luaconf.h, and the first
attempt at a fix tried to prevent contrib lua from being built with the
alternate behavior, always using a cast. This didn't generalize for at
least two reasons: it creates problems trying to compile on other archs
(see #992, #996), and it doesn't even cover all the problem situations:
linux will typically build with system lua, and then we are at the mercy
of whatever arch the system lua was built on anyways. (I have replicated
the problem in a 32 bit ubuntu container, for example, even with the
compilation fix.)

This commit moves away from using lua's default calls for converting to
ints, to conversion functions that we control in crawlcode. It's overkill
to convert everything, only the dungeon and related calls are really
needed, but converting everything was the most robust way to do it. Note
that this *doesn't* address any instances of this call in the lua lib,
with the hope that they won't matter.

The only alternative that I can think of to a change like this would be
to require building with contrib lua, and then fix the problem there,
but this would seem to go against the spirit of our current build
system.

--------------------------------------------------------------------------------
d8427f5 | advil | 2019-03-07 09:26:25 -0500

Add a warning for setting `game_seed` online
Before, this failed silently, which in at least one case seems to have
confused a player into thinking that they succesfully set the seed.

--------------------------------------------------------------------------------
71aafec | advil | 2019-03-06 22:59:38 -0500

unbrace

--------------------------------------------------------------------------------
8aad8c4 | gammafunk | 2019-03-06 19:15:38 -0600

Updates to the debian package guide
Reorganize and rewrite sections to get the order of steps right and make
the individual steps clearer. Also fix some typos and errors.

--------------------------------------------------------------------------------
029c7ce | advil | 2019-03-06 16:32:48 -0500

Don't change game chapter on a level excursion from abyss (11922)
Level excursions can be used in the abyss to pull in ruined versions of
terrain from regular connected levels. This bug didn't come up before,
because if no levels have been explored (as is the case for an AK
start), there is no level excursion. But with pregen, the builder can
use terrain from levels the player hasn't seen yet, and if it chose to
do this, the level excursion was resetting the chapter for an AK start
to CHAPTER_ORB_HUNTING (for some seeds on turn 0). This generates an
error message when leaving the abyss for wizards, a crash for
non-wizards, and also would impact item/monster generation, because an
AK character is no longer in the pocket abyss, for seeds that are
affected. (But since AK starts that trigger this bug are just broken,
that last part is not too big a deal.)

This commit doesn't include save compat, because as far as I know this
is rare, but save compat could be added if I'm wrong about this.

--------------------------------------------------------------------------------
8c2e593 | Doesnty | 2019-03-06 13:05:44 -0800

Let player ghosts be shafted (#1003)
This was an artifact from when player ghosts were totally unable to leave the 
floor they started on by any means. Now that they don't have this trait, and 
don't broadcast it in their descriptions, there isn't any reason for them to be 
special-case immune to shafts, or for them to destroy shafts uselessly on 
moving over them.
--------------------------------------------------------------------------------
1b465fe | advil | 2019-03-06 00:12:07 -0500

Don't crash when there are game types from the future
The save browser was crashing immediately on starting up in this case,
which is triggered by the presence of seeded games from 0.23. This
future-proofs a bunch of calls used by the save browser so that these
games behave just like any other incompatible future-versioned save game
in the main menu.

(if you want to cherry-pick this to a past version, it is probably
easier to use b7382820b72 from 0.22.)

(cherry picked from commit b7382820b7259ae5d2ffec6fa48112b66c2509ab)

--------------------------------------------------------------------------------
56e1b8f | advil | 2019-03-05 21:53:08 -0500

Don't let explore options impact connectivity checks
This was impacting seed stability: this code is called in various
contexts, including stair checks / vault exit checks, plus from some lua
code. The returned coordinate could be different depending on these
options. The options that could potentially matter are
`explore_wall_bias` and `explore_item_greed`, though I suspect the
latter won't. The former I have verified to matter on seed
18127138284784505733 (UV4's game of the month seed right now), where
setting it to 1 prior to this commit produces a different dungeon than
the default value of 0.  Thanks to u/kitchen_ace for noticing that
deleting their rc file changed the dungeon, otherwise I'm not sure I
would have ever found this bug.

--------------------------------------------------------------------------------
64c5a76 | Alan Malloy | 2019-03-05 14:26:30 -0800

Don't feel safe while emergency-flying (/u/StairDancer)

--------------------------------------------------------------------------------
b74a2b4 | Alex Jurkiewicz | 2019-03-05 10:10:31 -0800

TAG_MAJOR_VERSION improvements (#955)
The program now almost compiles with TAG_MAJOR_VERSION=35.

"Almost" because there are some changes that cannot be made compatible
to both the current and the upcoming version.
--------------------------------------------------------------------------------
3f7990a | advil | 2019-03-05 00:14:06 -0500

Save game seed properly
This was broken in 372e6d594387f, which caused the seed to save as 0
because of the timing of the call to the `player` constructor.  After
initial rng setup this value isn't used for anything meaningful (since
what matters is the rng state itself), so its disappearance was entirely
cosmetic -- but also very confusing to players.

--------------------------------------------------------------------------------
fa3a8d6 | advil | 2019-03-04 23:30:10 -0500

Add a paste option to the seed ui for local tiles
This is very ad-hoc and specific to the seed menu, but it'll do for now.
Needs testing on windows/linux, but it's relying on SDL code so should
work if that does.

Also restrict text input for the seed text box to digits.

--------------------------------------------------------------------------------
f1ee1cd | advil | 2019-03-04 17:24:35 -0500

Allow debug.reset_rng to take a string for 128 bit seeds
This isn't very elegant, but it gets around lua big number handling
issues that I was otherwise having.

--------------------------------------------------------------------------------
7c82874 | advil | 2019-03-04 09:29:46 -0500

Add an extra digit to the seed choice input box (Siegurt)
Until this is in stable, use the rc option `game_seed` or the command
line option `-seed` to select a seed that needs the extra digit.

--------------------------------------------------------------------------------
36218c0 | NormalPerson7 | 2019-03-04 00:49:27 -0500

Convert `enum confirm_butcher_type` to an enum class
The enum class retains the same name. It would be preferable to use
something shorter, such as confirm_butcher, but this is already used as
a member of Options, and changing this seems unnecessary.

This change includes changing CONFIRM_AUTO to
confirm_butcher_type::normal, because `auto` is a type and shouldn't be
used for enum class members.

[Committer's note: Closes #951]

--------------------------------------------------------------------------------
b23cc65 | NormalPerson7 | 2019-03-04 00:49:06 -0500

Change `enum activity_interrupt_payload_type` to `enum class ai_payload`
Significantly shorten the enum class name in the process to make
identifier names a reasonable length. AIP_INT and AIP_STRING are
converted to ai_payload::int_payload and ai_payload::string_payload to
avoid conflicting with type names.

--------------------------------------------------------------------------------
bbb2dcf | NormalPerson7 | 2019-03-04 00:49:06 -0500

Convert `enum confirm_level_type` to `enum class easy_confirm_type`

--------------------------------------------------------------------------------
5908fba | NormalPerson7 | 2019-03-04 00:49:06 -0500

Rename confirm-level-type.h to easy-confirm-type.h
The following commit changes the enum to an enum class and its name to
easy_confirm_type. These are done in separate commits because otherwise
git pretends confirm-level-type.h and easy-confirm-type.h were deleted
and created, respectively, rather than it simply being a rename.

--------------------------------------------------------------------------------
24134c8 | NormalPerson7 | 2019-03-04 00:49:06 -0500

Convert `enum tide_direction` to `enum class tide_dir`

--------------------------------------------------------------------------------
c5fff3c6 | NormalPerson7 | 2019-03-04 00:49:06 -0500

Convert `enum confirm_prompt_type` to an enum class
The enum class retains the same name, in line with confirm_butcher_type.

--------------------------------------------------------------------------------
176abe6 | NormalPerson7 | 2019-03-04 00:48:57 -0500

Convert `enum cleansing_flame_source_type` to an enum class
Turn this enum into the enum class cleansing_flame_source.

Also convert the functions cleansing_flame and
setup_cleansing_flame_beam to use type cleansing_flame_source instead of
type int, as this is now mandatory.

--------------------------------------------------------------------------------
6e62631 | NormalPerson7 | 2019-03-04 00:48:57 -0500

Convert `enum branch_flag_type` to `enum class brflag`
The name of the enum class changes to be significantly shorter, so that
references to members of the enum class are of a similar length to
before. Additionally, add a new bitfield type to use for the member
variable Branch::branch_flags - this type is called branch_flags_t.

Convert some uses of bitwise and to use testbits, where the raw bitwise
and will now fail to compile (in return statements and variable
definitions).

--------------------------------------------------------------------------------
5d75ef2 | NormalPerson7 | 2019-03-04 00:48:57 -0500

Convert `enum area_centre_type` to an enum class
The enum class retains this same long name. Ideally we would shorten the
name of this enum class: area_centre is already taken by a struct though.

--------------------------------------------------------------------------------
1735f9d | NormalPerson7 | 2019-03-04 00:48:56 -0500

Convert `enum ac_type` to an enum class
The enum class retains the same name, because anything shorter (such as
`ac`) risks being used somewhere else.

--------------------------------------------------------------------------------
b51ee14 | NormalPerson7 | 2019-03-04 00:48:56 -0500

Convert `enum ev_ignore_bit` to `enum class ev_ignore`
...and change a couple of bitwise ands to use the testbits method, where
required.

--------------------------------------------------------------------------------
9ae989b | NormalPerson7 | 2019-03-04 00:48:41 -0500

Change `enum activity_interrupt_type` to `enum class activity_interrupt`
Convert the activity_interrupt_type enum to an enum class and rename the
enum class to activity_interrupt to shorten identifier names somewhat.
Also define NUM_ACTIVITY_INTERRUPTS as a `constexpr int` rather than it
being inside the enum class definition and thereby taking the
activity_interrupt type.

--------------------------------------------------------------------------------
c27245e | NormalPerson7 | 2019-03-03 19:39:15 -0500

Convert `enum menu_type` to an enum class

--------------------------------------------------------------------------------
0e0ca4a | NormalPerson7 | 2019-03-03 19:39:15 -0500

Convert `enum branch_iterator_type` to an enum class
The enum class retains the same name.

--------------------------------------------------------------------------------
dcab4b9 | NormalPerson7 | 2019-03-03 19:39:15 -0500

Convert `enum branch_noise_level` to `enum class branch_noise`

--------------------------------------------------------------------------------
e9c4e45 | NormalPerson7 | 2019-03-03 19:39:15 -0500

Convert `enum passage_type` to an enum class
The enum class has the same name as the original enum. Also split lines
in the enum class definition so that each identifier gets its own line.

--------------------------------------------------------------------------------
9a4444a | NormalPerson7 | 2019-03-03 19:39:15 -0500

Convert `enum shadow_step_block_reason` to an enum class
The name of this new enum class is shadow_step_blocked.

--------------------------------------------------------------------------------
caa6c10 | NormalPerson7 | 2019-03-03 17:51:45 -0500

Let barachim use grand finale at range 8 (11917)
The range of grand finale was hardcoded as 7 rather than using
LOS_RADIUS, so when barachim were added, this wasn't updated.
This commit changes the grand finale targeter to use targeter_smite's
default parameters, which include range = LOS_RADIUS.

--------------------------------------------------------------------------------
eb6712d | advil | 2019-02-28 22:22:17 -0500

Quiet some gcc warnings

--------------------------------------------------------------------------------
b31aada | gammafunk | 2019-02-28 17:49:03 -0600

Update changelogs for 0.23.1
(cherry picked from commits eed6394480af98da628bc1a7c7918dbbe1e38c16 and
d6e21ad81dcba7f7f8c15336e0e985f070ce85fb)

--------------------------------------------------------------------------------
d96d3d6 | NormalPerson7 | 2019-02-28 13:29:47 -0500

Fix dancing weapon description on hover (11887)
Previously the dancing weapon's name was being duplicated because there
weren't proper checks for dancing weapons in the second half of
get_monster_equipment_desc. This was broken in f44d0c5.

--------------------------------------------------------------------------------
ad582e5 | gammafunk | 2019-02-27 19:41:00 -0600

Add Debian changelog entries for past releases
Entries for bugfix releases from 0.22, 0.21, and 0.20 that are missing
from the current Debian changelog.

--------------------------------------------------------------------------------
ff85673 | gammafunk | 2019-02-27 19:35:56 -0600

Add the changelog for 0.22.1

--------------------------------------------------------------------------------
d0b080c | gammafunk | 2019-02-27 01:56:30 -0600

Correct a comment

--------------------------------------------------------------------------------
8d2b5ac | gammafunk | 2019-02-27 01:56:30 -0600

Lower the chance for Boris to respawn
Boris has a flat 1/3 chance to respawn in relevant branches as of
4636eb8. This has effectively doubled the total rate at which Boris
spawns when comparing boris kills between the 0.23 and 0.22 tournaments.
This commit lowers the chance to 1/6 to bring the respawning rate closer
to the previous one.

--------------------------------------------------------------------------------
e4b1dce | advil | 2019-02-26 23:00:27 -0500

Change error reporting for post-place hook failures
When a post-place hook tries to place a map, the main reason to set
die_on_failure is just to trigger a veto in a sensible way. However, the
way this was implemented inevitably printed an error message about the
placement failure to the user, causing bug reports and confusion. This
situation was expanded by 56b24058a9 and 091e5a18fee, after which the
proper way for a post-place hook to trigger a veto when placing a map is
exactly to set die_on_failure. This commit makes any lua error during a
hook with a specific string indicating that it is a failure to place a
subvault silent, but still vetoing.

Conveniently, this will clean up the infamous "Failed to place map
'shoals_ilsuiw_ice'" errors too (10080, 10262), as this is one of the
cases where previously a post-place hook correctly set die_on_failure. I
should note that I don't know why it is specifically this map of the
`shoal_guardian`-tagged maps that tends to fail to place, but from the
debug build output when this failure happens I think it is just normal
subvault placement failure; there must be *something* about it that is
more likely to accrue placement failures than the others with this tag.

--------------------------------------------------------------------------------
11e5bb6 | Josh Braden | 2019-02-26 16:53:08 -0500

Remove incorrect fake_mutations from vampire (11870)

--------------------------------------------------------------------------------
a3c21ff | advil | 2019-02-25 19:52:16 -0500

Improve behavior of local tiles Text, especially on hidpi displays
This commit ends up doing a number of things:

1. (most important) fix a bug on retina (and other hidpi) displays where
the height of Text widget contents was not calculated correctly, because
the code didn't handle fractional y advances. This resulted in ctrl-p
dropping several lines at the end, among other things.
2. Fix handling of fractional y advances when drawing highlights, again
a potential issue in long Texts (though less important, as highlighting
is almost never used right now).

In the course of this, I needed to understand how the highlight code
worked and this forced me to add a lot of comments and do some code
formatting, as well as address the following bugs:

3. Don't highlight lines more than once in hl_line mode, this results
in unreadable text.
4. Handle the case where the end of a string coincides exactly with the
end of the window and is highlighted, which was leading to glitches in
my testing.
5. Better handling for cases where a highlight spans multiple slices of
the formatted string. I'm not 100% sure if this was really broken before
my fix of 4, but it works now.

I'm still not entirely sure about all this highlighting code, and it's
pretty complicated and monolithic, so it could probably use some more
work and refactoring.

--------------------------------------------------------------------------------
db70d5e | Alex Jurkiewicz | 2019-02-25 13:29:50 -0800

Expose MR and Stealth to Lua
Two new functions return the number of pips for each of these
resistances.

--------------------------------------------------------------------------------
1e4b560 | Umer Shaikh | 2019-02-25 09:51:29 -0800

Clean up god gifts' interaction with delays (11825)
Getting a Nemelex gift at the end of a successful passwall that revealed
new cells caused the message "Your meditation is interrupted." to be
printed. This is because do_god_gift interrupted running and resting in
a way that interrupted and removed the passwall delay. We now call
stop_running with the clear_delays parameter set to false in order to no
longer clear delays. We also call stop_running instead of directly
reaching down to you.running.stop.

--------------------------------------------------------------------------------
fc1eed5 | advil | 2019-02-24 21:10:36 -0500

Add a build option to not use SSE
This is in response to #992. To use this, do e.g.

    make TILES=y NOSSE=y

--------------------------------------------------------------------------------
3f76249 | gammafunk | 2019-02-24 17:12:08 -0600

Remove the trunk reminder for the 0.23 tournament
This reverts commit 7d8ec5708864d2872871cd49295b12a5b291238d.

--------------------------------------------------------------------------------
df02491 | Chris Campbell | 2019-02-22 19:26:12 +0000

Fix character creation highlighting in console
Darkgrey doesn't function in some terminals, so instead use the same colouring
as webtiles builds.

--------------------------------------------------------------------------------
2bff182 | Chris Campbell | 2019-02-22 17:06:56 +0000

Update a file path in git docs

--------------------------------------------------------------------------------
a2403f3 | advil | 2019-02-19 17:35:45 -0500

Quiet a gcc warning
(signed vs unsigned comparison)

--------------------------------------------------------------------------------
e09df05 | advil | 2019-02-19 17:24:26 -0500

Fix PlaceInfo fixup more (11890)
...

--------------------------------------------------------------------------------
ab847a3 | NormalPerson7 | 2019-02-19 14:08:39 -0800

Fix Ozocubu's Refrigeration (11885)
Since fb95405, the damage of both the player and monster versions of
Ozocubu's Refrigeration has been one third of what it should be,
specifically 3d((5 + power/10)/3), leading to a very underwhelming
level 6 spell.

This was because fb95405 converted the original dice_def that was used
to calculate the damage from this spell into a calcdice_calculator,
without adjusting for the fact that the calc_dice function divides the
number of sides on each die by the number of dice.

One way to fix this would be to use a dicedef_calculator instead;
however a calcdice_calculator is preferred for the fact that it randomly
rounds power/N instead of always using integer division (which creates
minor breakpoints). Therefore this commit instead fixes the damage by
tripling the inside of the dice roll bracket, leading to a
3d((15 + 3*power/10)/3) dice roll which is equivalent to the old
3d(5 + power/10).

--------------------------------------------------------------------------------
429d40e | advil | 2019-02-18 22:36:17 -0500

Set the branch depth correctly in 107517c6e49a
...

--------------------------------------------------------------------------------
107517c | advil | 2019-02-18 22:26:53 -0500

Prevent a PlaceInfo miscalculation and fix the resulting crash
The level entry code (for purposes of pregeneration) assumed that 0
turns on level = the level hasn't been entered. There are in fact at
least three ways to break this assumption: wizmode movement (e.g.
&u,&d), taking an escape hatch and being shafted immediately, and being
banished by something fast enough to move when you first enter the level
(at least, ebering says this is possible). When this happened, the
PlaceInfo accounting would be run twice, and so the level would get
double-counted, leading to a crash deeper in the branch. Luckily I added
the level_entered code towards the end of the project, and this does
what this code needs.

This commit also includes some save compat since there may be ongoing
games during tournament that have this crash.

--------------------------------------------------------------------------------
3d66cf4 | advil | 2019-02-18 00:09:46 -0500

Build for SSE2 on all systems, including 32bit targets
Believe it or not, this is a seed stability fix. On 32 bit targets where
SSE2 is not defined, Lua uses a different method for converting from
numbers (doubles) to ints (see `lua_number2int` in `luaconf.h`), than
what happens on other targets (which is just a regular cast). The two
methods have different rounding behavior, which is leading seeds that
involve layout that passes non-integer values to c++ code into trouble;
for example, layout_rooms does this during its join_the_dots calls (see
11884, seed 5313719195296785585). In practice, the non-standard rounding
was happening only for cross-compiled windows builds that I know of, but
perhaps some linux builds are also 32bit; there's also a code path that
might affect msvc. Using -msse2 should prevent lua from ever using the
non-standard conversion code.

This fix should have the added benefit of preventing x87 from ever being
used. We'll see though if this will bring people out of the woodwork who
are building on very old devices...

This commit also includes an unrelated tweak to some ordering in the
Makefile so that AUTO_OPT can be used.

--------------------------------------------------------------------------------
53b5160 | gammafunk | 2019-02-16 23:36:54 -0600

Tidy up a monster class method
In monster::is_summoned(), remove checks for derived undead spells that
no longer apply, since those use fake abjuration now, and clean up
comments.

--------------------------------------------------------------------------------
d3e027d | gammafunk | 2019-02-16 23:36:54 -0600

Don't let vampirism drain temporary monsters (blorx1)
Temporary monsters created with a "fake abjuration" timer are considered
non-summons, since they're created from some object, e.g. Sticks to
Snakes, Animate Dead, and Tukima's Dance. Natural holiness monsters
created this way are currently susceptible to vampirism from Vampiric
Drain and vampiric melee attacks. This is a problem since these
temporary monsters can be created by the player cheaply and killed with
vampiric effects to restore HP and satiation (in the case of player
vampires).

Vampirism of temporary summoned monsters is already prevented, so this
commit prevents it for these other temporary monsters as well. The main
things effected are Sticks to Snakes and the Ratskin Cloak. Other
differences between these temporary allies and normal summoned allies
(e.g. the former allow Inner Flame) are unchanged. Durably summoned
monsters are likewise unchanged, since these are not player-created.

--------------------------------------------------------------------------------
d155597 | advil | 2019-02-15 10:09:00 -0500

Don't try to describe off-level orc gifts (11881)
Instead just say that the orc is off-level. Better would be to describe
both the item and where they are, but the the way off-level followers
are implemented means that it's basically impossible to get the item
information without either a level excursion or a major rewrite.

One option might be to save the item string as a prop?

--------------------------------------------------------------------------------
5d539f0 | advil | 2019-02-14 23:14:02 -0500

shorten test again

--------------------------------------------------------------------------------
597dbe2 | advil | 2019-02-14 21:41:12 -0500

Fix a math error in a test

--------------------------------------------------------------------------------
3372e67 | advil | 2019-02-14 14:46:16 -0500

Uncomment an accidentally commented vault call

--------------------------------------------------------------------------------
fd6172a | advil | 2019-02-14 14:16:31 -0500

Fix Beogh crash for polymorphed followers (11880 / reaverb)
If an orc gets turned into something that cannot hold items (e.g. via a
chaos cloud shapeshifter effect) it will drop its gift, but the gift
prop does not get cleared, something the new ^ extra screen was not
checking for. This commit fixes things at the point of the crash; it's
possible that the prop should get cleared when the item is dropped in
the first place.

--------------------------------------------------------------------------------
f57072b | advil | 2019-02-14 11:49:56 -0500

Fix a couple of des cache random tag bugs
Because lua code is run during des cache validation, any random
decisions made during validation may be incorporated into the cache. I
*think* this is mostly harmless but there are at least two problems that
arise when it applies to vaults tags. First, random choices when
selecting maps can be impacted by the number of tags *in the cache*, so
seeds will potentially behave differently depending on choices made when
first building the cache. Second, because tags are strictly additive, a
tag choice made during cache building will never get removed; for
example in `lemuel_altar_in_water` before this commit, if the cache
rolled no_pool_fixup, this would be present in all instances of this
vault regardless of rolls when actually placing the vault.

It's possible that tags should be cleared when rerunning vault lua for
placement, but that seems like a change that could potentially impact a
lot of things and will require some testing, so I'm going to postpone
it.

In general it would probably be best to eliminate *all* randomization
from the cache, but I'm not yet sure what the best technical solution to
that is (there are quite a few vaults that use random calls like this to
set SUBST or monster values, it doesn't seem ideal to impose
is_validating checks on all of them).

--------------------------------------------------------------------------------
9a59f91 | advil | 2019-02-14 09:19:22 -0500

Improve a very old fixup

--------------------------------------------------------------------------------
011bc4b | NormalPerson7 | 2019-02-13 15:35:58 -0800

Fix yellow draconians' rAcid mutation not being applied (malacante)

--------------------------------------------------------------------------------
431b8d2 | advil | 2019-02-13 16:21:50 -0500

Change behavior of multiple DEPTH: lines, fixing some uniques (ebering)
Previously, multiple DEPTH: lines would be interpreted as the last
overriding any previous ones. This changes them to be additive, similar
to how TAGS: lines work. It also removes an apparently vestigial
function intended to do something with default depths that relied on the
previous behavior; in fact, the `default-depth:` .des syntax is
implemented in a different way using the `dgn.set_default_depth` call,
not affected by this commit.

This change fixes the placement of uniques touched in 402804a59a51,
which accidentally have a fairly restricted placement in 0.23.0. (This
fix will be in trunk and in a future point release of 0.23, but not
during the tournament -- so anyone looking for Aizul etc may need to
look in unexpected places!)

This commit will likely affect many seeds.

--------------------------------------------------------------------------------
cea5463 | Alan Malloy | 2019-02-12 09:35:40 -0800

Handle temporarily-changed terrain when asserting level validity (#11876)

--------------------------------------------------------------------------------
3d167c7 | advil | 2019-02-12 10:39:38 -0500

semicolon + checkwhite

--------------------------------------------------------------------------------
e20b4fc | advil | 2019-02-12 09:38:31 -0500

Restructure PlaceInfo fixup to handle gauntlet upgrades
Saves upgraded to 0.23 on windows are crashing, because you.branch_info
was not correctly initialized on mingw builds (see e13aadb210) and
gauntlet was saved with a global PlaceInfo. This commit handles save
compat for these files.

This change makes the fixup slightly more generic and removes a save
version check, which I don't think is really necessary here (the
desolation fixup was one of the first things I did, before even being on
the devteam, so I think I was being ultra-cautious with save compat).
I've left the branch check though, so this will cause crashes if a new
variant of this bug appears in the future, or if something else goes
wrong with PlaceInfo.

--------------------------------------------------------------------------------
372e6d5 | advil | 2019-02-12 09:11:30 -0500

Revert "Revert "Eliminate some more dependencies on globals from 
player::player""
On further inspection, this should be ok: I was concerned about save
compat, but the save order for place_infos is entirely independent of
the storage order.

This reverts commit 7635c99b35658e33562b239784f4f9876285a6a8.

--------------------------------------------------------------------------------
7635c99 | advil | 2019-02-11 23:13:46 -0500

Revert "Eliminate some more dependencies on globals from player::player"
bad branch order assumptions

This reverts commit e13aadb210ac7751cfb85537baaca10534c22d3b.

--------------------------------------------------------------------------------
e13aadb | advil | 2019-02-11 22:29:34 -0500

Eliminate some more dependencies on globals from player::player
On mingw builds, branch_info was not getting initialized correctly here
because branch_iterator depends on a global, `branches`, which was not
initialized before the constructor is called for the global `you`. Use
the enum order instead of anything fancier to initialize `branch_info`.

Also don't set the seed here, it isn't need and leads to another
potential order issue.

--------------------------------------------------------------------------------
3339647 | advil | 2019-02-11 21:50:13 -0500

Simplify levels_visited
This was overly complicated because I didn't understand how
CrawlStoreValue works; the necessary hash table is automatically created
on the get_value() call. This also has the bonus of removing a
dependency on a global from player::player().

--------------------------------------------------------------------------------
e52b27f | advil | 2019-02-11 11:13:18 -0500

Place AK start in abyss with pregeneration on (11871)
The chapter check was basically in the wrong place; moved it up to
outside the builder call. Also, just in case, unwind the chapter
variable while doing pregeneration so that nothing can condition on it
incorrectly.

--------------------------------------------------------------------------------
1c07cc1 | advil | 2019-02-11 10:50:30 -0500

Small tweak to vault_catalog.lua
Really, really clear everything before regenerating.

--------------------------------------------------------------------------------
60e8692 | advil | 2019-02-11 10:37:54 -0500

Deprecate acquire item specs for regular dungeon generation
Conditioning level generation on the player is generally now deprecated
(I think there's consensus that this is bad for various reasons, but the
reason I care about is that it interferes with seeding). This is the
latest case of this that I have run across. These item specs directly
call the acquirement code, which has a bunch of conditioning on the
player to try to make the generated item more usable or appropriate. For
non-pregenerated games this can affect randomization afterwards, and for
pregenerated games it simply doesn't make much sense given that the
player is mostly a blank slate when the acquirement is run. If you
really want the player to have an item generated by this code, just drop
a scroll of acquirement. In very special cases, it is possible in
principle to generate an item on the fly with this item spec (several
sprint maps do this).

I've done somewhat arbitrary choices of replacements depending on my
mood and what the vault appeared to intend, trying to get equivalently
good and appropriate items, but these might need further refinement.
Vault designers can consider `superb_item`, `any good_item`, and
`star_item` when their intent is, place something potentially great but
fairly random.

There are some rarely used special cases of this syntax that are still
in the code, e.g. the god syntax: there was all of one non-trove
instance of this syntax left, and it was using a god (TSO) that has
barely any acquirement special casing; I changed this one to something a
bit more specific. Possibly this syntax should just be removed.

This commit leaves only a few instances of this item spec, mainly in
troves (where it is not deprecated). There are a couple calls in abyss
that seemed ok, but possibly should be changed, as well as some uses in
sprints as mentioned above.

--------------------------------------------------------------------------------
88f18ea | advil | 2019-02-11 10:26:51 -0500

constify a bunch of instances of PlaceInfo
This didn't actually fix anything, but made me feel better.

--------------------------------------------------------------------------------
4f8aab8 | advil | 2019-02-11 10:23:25 -0500

Add a debugging hook
This is kind of dumb but I can tell I'm going to need this again. This
is aimed at debugging generation that may be happening deep in some test
sequence: toggle this on to echo all dprfs to stderr for some window of
time. (E.g. in a recent episode I used it to print all DNGN_DIAG
messages while the builder was generating Lair:6 for a particular seed
in vault_catalog.lua.)

--------------------------------------------------------------------------------
13aa1b5 | advil | 2019-02-11 10:19:02 -0500

Clear even more state for tests
As long as `acquire` is a possible item spec, then the builder can have
some dependency on what items the player has seen before, and so this
needs to be cleared. In a future commit I will limit the use of
`acquire` to portals, but we still want to clear this for better control
in tests. Also, reorganize this function a bit, and add yet more
DIAG_DNGN spam (sry).

--------------------------------------------------------------------------------
e1bfdf8 | advil | 2019-02-09 15:20:53 -0500

Fix a shopping list crash
This commit actually initializes the member variables for ShoppingList,
most importantly `list`, and resets the global shopping_list object in
_reset_game(). When a game had a shopping list and reset_after_save was
true, then saving that game and opening a new one would lead to a stale
pointer to the first game's deallocated shopping list prop.

Having this object work by a live pointer to a member of you.props is
probably not a great idea, all around...

--------------------------------------------------------------------------------
7d8ec57 | gammafunk | 2019-02-08 14:06:34 -0600

Add a trunk reminder for the 0.23 tournament
[skip ci]

--------------------------------------------------------------------------------
4e4936a | advil | 2019-02-07 20:26:43 -0500

fix the fix

--------------------------------------------------------------------------------
a7c8294 | advil | 2019-02-07 20:24:26 -0500

Improve save compat for visited level tracking
What I had written before wouldn't work for a turn 0 save, and it
appears that the default constructor isn't necessarily getting called so
the fixup needs to initialize the prop.

--------------------------------------------------------------------------------
ce0dbf4 | advil | 2019-02-07 12:32:31 -0500

Fix vault printing in morgues after game end (NP7)
It turns out that the save is already deleted at this point, so some of
the checks I was using for level existence weren't working right.

--------------------------------------------------------------------------------
b3eb09e | gammafunk | 2019-02-07 11:07:09 -0600

Final changelog for 0.23
Some wording tweaks and typo corrections.

[skip ci]

--------------------------------------------------------------------------------
f756fb0 | gammafunk | 2019-02-07 10:17:59 -0600

Update the Debian changelog for 0.23
(cherry picked from commit 195ea7e421b6cb7e468f0b6391be23ac66777778)

--------------------------------------------------------------------------------
56b2405 | advil | 2019-02-07 10:40:41 -0500

Adjust one post_place hook
After auditing the post_place calls, I see some potential issues, but
not many that are made worse by 091e5a18feeb (mostly cases where
persistent dungeon state is probably not handled correctly if map
placement fails). This is the only vault I found that really doesn't
make sense unless the map placement works, and wasn't already set up to
abort on failure. I didn't adjust any serial vaults, so it's conceivable
that these could now place without any post_place placements working in
rare cases, so they may need tweaking if this comes up a lot.

The awkward thing about die_on_failure is that it (probably) prints a
lua error to the player. However, the only reason why the old code
didn't print a (more cryptic) error on a veto was because the error
handling code was buggy in the face of an exception. It may be that we'd
want a way of having a silent die_on_failure though.

--------------------------------------------------------------------------------
091e5a1 | advil | 2019-02-07 09:29:45 -0500

Catch dgn_veto_exception when placing maps from lua
When an exception is thrown across lua code, it severely messes with the
lua stack and lua's use of setjmp/longjmp, at least for the way we have
it configured. This was causing pretty bad crashes on post-place hooks
when run from tests: the exception was thrown in c++ called from lua
called from c++ called from lua called from c++, and caught in the
intermediate c++ black, and basically treated as a lua error (I think),
but just clobbered the lua stack, so the outer calling lua was left in
an indeterminate state and any error there (which would happen
immediately, as variables were shuffled) would cause a longjmp failure.
This didn't go quite so badly in practice when there wasn't the outer
test lua layer, but I still think it's pretty risky to allow throwing
this, unless we shift lua to itself use try/catch.

This commit *changes the behavior* of post-place hooks. Previously, they
would implicitly veto the entire map if a post-place hook map placement
call failed. Now, they will only veto if the post-place hook sets
die_on_error (which none do). In practice, this probably comes up for
serial vaults (e.g. serial_forest) which can place many subvaults, where
some of the later tries fail on a crowded level. I have left a note in
However, it may have bigger implications. The quick fix for any maps
that really need the old behavior would be to call lua `error()`, though
this will print an error message to the player.

(cherry picked from commit 72689e85ba0b1ffd4eac588e90b4b83a4ce88d4b)

--------------------------------------------------------------------------------
25a2d9f | Edgar A. Bering IV | 2019-02-06 22:11:47 -0500

Update CREDITS.txt
[skip ci]

--------------------------------------------------------------------------------
f005ca4 | gammafunk | 2019-02-06 20:19:37 -0600

Decorations for 9x9 Gauntlet maps
Use a consistent statue display wall motif for all four 9x9 Gauntlets.
Also add various statues and lava tiles throughout the maps. This helps
give these 9x9 maps a common feel, similar to how the 7x7 and mixed
7x7/9x9 map sets each have their own decorative themes.

--------------------------------------------------------------------------------
cb1519b | advil | 2019-02-06 18:12:29 -0500

checkwhite

--------------------------------------------------------------------------------
d227540 | advil | 2019-02-06 17:44:09 -0500

Fix progress bar webtiles behavior
Not sure what happened here.

--------------------------------------------------------------------------------
e8a6cd6 | advil | 2019-02-06 17:44:09 -0500

Improve webtiles support for seeding/pregen
This adds a new command line option `-pregen`, as well as an
argument-less version of "-seed" that triggers the seed choice menu and
sets the right game type. Bothing seeding and pregen are usable from
the command line in DGL builds, though rc file options that set these
are still disabled in DGL builds so that server owners have some
control. So calling "./crawl -name asdf -seed" will pop up the seed
choice menu before starting the game, and (if a user picks a non-0 seed)
will start a game of type "Seeded", and "./crawl -name asdf -seed 1
-pregen" will force pregeneration of seed 1 after character selection.

This is pretty simple to set up in vanilla webtiles, I've included an
example in config.py (which of course no one merges). One awkwardness
(also for tutorial) is that these options will load a non-seeded game if
there is one under the right name, which is logical but not very
intuitive as a UI thing (you'd probably want to give an error).

caveat emptor: nothing else in the crawl infrastructure (especially
sequell) has been set up to handle the new game type, and I have no idea
what would happen if you try to publish milestones using it. So if you
are thinking about using this in a live server, test it out carefully...

--------------------------------------------------------------------------------
c81a885 | advil | 2019-02-06 17:44:09 -0500

Pregenerate the vestibule
I'm beginning to think that this is_valid() check isn't very good...

--------------------------------------------------------------------------------
6670cd2 | advil | 2019-02-06 17:44:09 -0500

Explicitly track visited levels
My previous pregen-related commits tried to avoid this, but I don't
think it can be avoided. The basic problem is that this information is
also present in the turncount on a level, but that information is saved
with the level chunk, and it turns out to be kind of useful to have in
many cases where the player isn't on the level in question. Previously,
whether a level was generated (which is tracked in a simple way in the
save package) was synonymous with whether the level had been visited, so
most code just used that. The new implementation uses a CrawlHashTable
as a prop on the player.

This commit specifically fixes three pregen bugs: (i) rune locks were
broken (would always open), (ii) jiyva would eat items on all levels,
not just levels you'd visited, and (iii) one of the perennial problems
with pregen implementations, X] shows a blank screen. It also further
cleans up the morgue vault listing code, and provides more information
for a wizmode morgue. If there are any pregen games in the wild yet,
this fix won't do save compat for them and they'll still have these
bugs, but it will do save compat for regular games.

--------------------------------------------------------------------------------
9ff4135 | gammafunk | 2019-02-06 11:57:52 -0600

Fix some Gauntlet decorations
I ended up not using flame cloud decorations on this map, but didn't
replace the glyphs. Use lava to surround the statues instead.

--------------------------------------------------------------------------------
748db23 | Edgar A. Bering IV | 2019-02-06 11:42:57 -0500

Only check for adjacent friendlies with exploding ammo (11857)
Commit 853fe2ed08 added a friendly fire check for portal projectile
fired exploding ammo; however it did not restrict this check to
exploding bolt types.

--------------------------------------------------------------------------------
dd71560 | advil | 2019-02-06 09:33:30 -0500

Initialize int member variables of formatted_scroller (11838)
For many scrollers, the initial position was being determined by the
uninitialized m_scroll, leading to fairly random behavior (probably
compiler-dependent, too). For good measure, I initialized all three.
This also fixes a bug in the way FS_START_AT_END was handled for this
class, where in some cases (maybe most cases) a scroller position would
be set but then overrided by the uninitialized value of m_scroll. Since
this value would usually be a large number, the scroller very often did
start at the end.

Did not track down why this behavior appears to have changed recently,
since this bug is months old, but it could be to do with something about
how uninitialized values are handled that we don't directly control.

--------------------------------------------------------------------------------
cfe09e8 | achuah | 2019-02-06 08:36:21 -0500

Update crawl_manual.rst

--------------------------------------------------------------------------------
81bb1ad | gammafunk | 2019-02-05 23:20:50 -0600

Shorten the path of a Gauntlet exit area
In gammafunk_gauntlet_one_two_three, move the landing sites leading to
the minotaur's vault closer together. This way there's less walking when
taking transporters in the paths on the outer edges of the map.

--------------------------------------------------------------------------------
e688737 | gammafunk | 2019-02-05 23:20:50 -0600

Add more exits and statues to some Gauntlets
Add a second exit to the other end of the 9x9 gauntlet maps so it's more
convenient to exit as well as symmetric on the map. Also add a few
statues. I'll be revamping the wall decorations in a subsequent commit
to use a common motif for these 9x9 maps. That change might not be ready
for release, so these changes will do for now.

--------------------------------------------------------------------------------
ac12a55 | gammafunk | 2019-02-05 23:20:50 -0600

Fix loot in a Gauntlet exit vault
The FeTm adventurer loot pile was missing a potential item.

--------------------------------------------------------------------------------
f44d0c5 | NormalPerson7 | 2019-02-05 23:32:29 -0500

Fix dancing weapon description when multiple monsters enter LOS (11843)
When multiple enemies entered line of sight at once including at least
one dancing weapon, the message "There is." was being printed. This is
because there was an unnecessary check for enemies not being dancing
weapons in get_monster_equipment_desc. Remove this check, and add a
special case to the helper function _describe_monster_weapon to prevent
these messages being printed as "There is wielding a +4 trident."

These messages should now properly print as e.g.
"There is a +4 executioner's axe of electrocution."

--------------------------------------------------------------------------------
55f8356 | advil | 2019-02-05 16:49:14 -0500

Invalidate LOS properly for level pregeneration
It turns out that monster band placement checks LOS when placing the
followers, and so if LOS is not properly invalidated, the builder will
use the cache for the wrong level, leading to seed divergence. This
moves a few other cleanups up that I think will matter a bit less.

--------------------------------------------------------------------------------
d6fbd69 | advil | 2019-02-05 12:58:11 -0500

For pregen morgues, only show visited levels (alexjurkiewicz)
I did this by moving the code that saves vault names a bit later in the
process, so that they only get entered into you.vault_list when the
player actually enters the level, rather than during the level builder.
This also unifies code for collecting vault names. For now I've also
changed this to show layout names, which are useful for debugging.

(cherry picked from commit 643a44d428fe4e8a720b83b0394e1465a4e5bddb)

--------------------------------------------------------------------------------
a78bd38 | gammafunk | 2019-02-04 16:52:03 -0600

Merge pull request #976 from Floodkiller/gn_jiyva_fix
Re-enable stat shifting for Gnolls worshipping Jiyva
--------------------------------------------------------------------------------
508cf82 | Floodkiller | 2019-02-04 17:12:22 -0500

Re-enable stat shifting for Gnolls worshipping Jiyva
Re-enables the stat shifting passive for Gnolls who are worshipping
Jiyva. This is a leftover fragment from the static attribute iteration
of Gnolls.

--------------------------------------------------------------------------------
0956303 | Umer Shaikh | 2019-02-04 16:39:09 -0500

Make unassigned keys exit macro reassignment menu
This makes the menu's behaviour more consistent with other crawl menus.

[Commiter's note: Closes #974]

--------------------------------------------------------------------------------
f9871eb | Umer Shaikh | 2019-02-04 16:39:02 -0500

Escape angle brackets in macro assignment
Closes #687

--------------------------------------------------------------------------------
50940db | NormalPerson7 | 2019-02-04 16:26:44 -0500

Fix message order when a player resists damage from an elemental bolt
Previously, the "You resist" message (and other messages such as "You
feel a terrible chill" that are to do with resistances) were being
printed before the message to say the bolt had hit.

Hence, fix this with a second call to check_your_resists specifically
for printing these messages, and change the first call to be called with
doEffects = false. In order to do this, it's necessary to save the
pre-resist damage as a separate identifier. In doing so, a debug message
is simplified.

--------------------------------------------------------------------------------
a006759 | gammafunk | 2019-02-04 15:25:08 -0600

Fix the area grid for klown pie silence
When applying silence from a Klown pie, we weren't invalidating the area
grid. This meant that silence wouldn't actually apply until something
else updated the area grid, which might not be until the end of the next
turn.

--------------------------------------------------------------------------------
27fda53 | Edgar Bering | 2019-02-04 15:47:42 -0500

Don't target net traps through glass (NormalPerson7)

--------------------------------------------------------------------------------
cf4bcd2 | advil | 2019-02-04 11:35:14 -0500

Add a hacky but functional newgame menu for seed / pregen
The way I implemented this is fairly wince-inducing, but also fairly
consistent with the current state of how these menus are done.

This commit also adds a new game type for when a custom seed has been
chosen; this game type should (I think) be basically inaccessible in DGL
for now and require no save compat. Hopefully it can be used to include
seeded games in sequell (similar to how sprint games are treated).

--------------------------------------------------------------------------------
c4a3eeb | advil | 2019-02-04 01:31:38 -0500

Move seeded rng initialization later
Previously, I was doing this at the game start. This means that setting
a seed in an rc file impacts random choices at the newgame menu, and
also that the gameplay rng is advanced by any randomness that happens
here. Now, only initialize the rng from a chosen seed, or choose a seed,
during newgame setup.

--------------------------------------------------------------------------------
c8b47a3 | gammafunk | 2019-02-03 23:15:22 -0600

Tiles for the Rift unrand (CanOfWorms)
Both item and doll tiles for the unrand demon trident "Rift".

--------------------------------------------------------------------------------
ac335f2 | Edgar A. Bering IV | 2019-02-03 23:15:03 -0500

Display bazaar items at the top of the shopping list (11649)
A player in a Bazaar might wish to comparison shop, but it is helpful
for the immediately relevant information to be displayed first. This
changes the comparison function used to always sort items in a Bazaar
before those not in a Bazaar.

--------------------------------------------------------------------------------
8f19387 | gammafunk | 2019-02-03 18:29:01 -0600

Updates to the changelog
Add release highlights, simplify wording to decrease length,
reorganizing listings in each section roughly in order of importance,
and give the seeded play details its own indented list. This should
bring the changelog close to a state that's ready for the release.

--------------------------------------------------------------------------------
853fe2e | Edgar A. Bering IV | 2019-02-03 18:28:56 -0500

Give a friendly fire warning for exploding portal projectiles (11315)

--------------------------------------------------------------------------------
776a217 | Edgar A. Bering IV | 2019-02-03 16:33:18 -0500

Display the SEEN_RANDART hint only for randarts

--------------------------------------------------------------------------------
687177d | Edgar A. Bering IV | 2019-02-03 16:33:12 -0500

Add cost and training targets info to hints mode

--------------------------------------------------------------------------------
b1230d1 | NormalPerson7 | 2019-02-03 13:40:30 -0500

Update tutorial, fix tutorial/hints mode skill menu text (11851)
Update a traps message that stated traps aren't always revealed, and a
berserk hunger message that stated you can't berserk while very hungry;
this restriction is now limited to near starving or worse.

Shorten the "Read skill descriptions" button description to "Skill
descriptions" to avoid this overlapping the text on the following line.

--------------------------------------------------------------------------------
a7f21a4 | advil | 2019-02-03 11:23:01 -0500

Update copyright date

--------------------------------------------------------------------------------
fe1993f | advil | 2019-02-03 10:47:01 -0500

Update seeding notes on changelog

--------------------------------------------------------------------------------
542e47c | advil | 2019-02-03 10:45:19 -0500

Update the "seeded play" section of the manual

--------------------------------------------------------------------------------
0ecae65 | Edgar A. Bering IV | 2019-02-02 23:34:34 -0500

Convert mummy death curses to a fineff (11758)
This ensures that when a monster is killed by Grand Finale the death
curse effects all land on the killer.

--------------------------------------------------------------------------------
8d21aed | advil | 2019-02-02 22:55:59 -0500

Remove accidental debug message

--------------------------------------------------------------------------------
a65fc5f | advil | 2019-02-02 22:54:09 -0500

Avoid a few cases of random tags in the .des cache
These tags are set at builddb time, and saved in the cache, which
probably isn't what anyone wants. They also impacts seed stability:
these pan entry maps were either tagged with
`luniq_hellpanabyss_threat_entry` in the cache or not depending on a
random choice when the .des cache was first built, which then causes
seed divergence between systems depending on what decision was initially
made.

This is far from the only kind of case where random decisions appear to
be made during validation that might be getting saved in the cache, but
it's the only one I've seen so far that's actually leading to
divergence. Another kind of case is exemplified by
`lemuel_altar_in_water`, where the tags are chosen randomly; but what
seems to be happening for the cache is that the vault is parsed without
running the lua and the initial tag set is drawn from this. I don't have
a lot of confidence that what would happen with this map is correct, but
at least it wouldn't lead to seed divergence.

--------------------------------------------------------------------------------
a05850b | gammafunk | 2019-02-02 17:51:14 -0600

Add monsters to a Gauntlet arena
Oops, forgot the monsters!

--------------------------------------------------------------------------------
0b2a0bf | gammafunk | 2019-02-02 17:23:27 -0600

Don't allow multiple placements of Gauntlet arenas
The commit removes the allow_dup tag from arena subvaults so that no
subvault will be used more than once in a Gauntlet. Both 7x7 and 9x9
sets have over twice the number of vaults needed for all arenas in any
Gauntlet map, so it's not necessary to allow reuse. Use of allow_dup
dates from earlier in development of the portal when there weren't as
many vaults available.

--------------------------------------------------------------------------------
483b6fb | gammafunk | 2019-02-02 17:16:30 -0600

Incorporate net traps into Gauntlets
When an arena rolls the chance to place traps, make each trap placed
have a 50/50 chance between dispersal and net trap instead of 100%
dispersal.

--------------------------------------------------------------------------------
330989f | gammafunk | 2019-02-02 17:15:52 -0600

Two 9x9 Gauntlet arenas
One with plants arranged in an arrow pattern, and another with a double
spiral having the loot at one end and the exit transporter at the other
end. This brings the number of 9x9 arenas to 20, giving us a sizeable
set in terms of variety.

--------------------------------------------------------------------------------
f098211 | advil | 2019-02-02 22:04:18 +0000

Fix a pre-c++17 compilation issue
This would be ok in c++17, but technically isn't before that. See:
https://stackoverflow.com/questions/7411515/why-does-c-require-a-user-provided-d
efault-constructor-to-default-construct-a
http://open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#253

I guess our usual compilers aren't picky, but clang 6 on linux is.

--------------------------------------------------------------------------------
d71c066 | advil | 2019-02-02 16:17:16 -0500

Shorten vault_catalog.lua test
To try not to have to raise the timeout limit further.

--------------------------------------------------------------------------------
72233a7 | advil | 2019-02-02 15:42:37 -0500

Better handle player position for debug/test levelgen
This is another case of a bug in the tests, but not one that impacts
actual levelgen.

--------------------------------------------------------------------------------
c4805aa | advil | 2019-02-02 13:37:30 -0500

Don't count gold as part of the level builder (joemaro)
This was artificially inflating the prices of gozag for level
pregeneration. It now runs when entering a level, if that level counts
as just created (either by pregeneration or not).

Resolves #972

--------------------------------------------------------------------------------
23bff18 | advil | 2019-02-02 13:09:46 -0500

More documentation and notes on seeding
Some of this might be fodder for a blog post too; writing this all down
because eventually someone else might want to do some seed debugging,
and there are a *lot* of blind alleys I've found while doing this.

[skip ci]

--------------------------------------------------------------------------------
f1fd2d0 | advil | 2019-02-02 01:27:40 -0500

Update the tags API to use sets
This previously just used raw strings in rather hacky ways. The main
reasons I'm updating this now are because (i) tag ordering was affecting
randomness in some cases, and (ii) the lack of any uniqueness checking
was causing weird effects where some lua code would just keep on adding
duplicates of the same tag (which again, interacted with the random
number generation because it changed the size of what was being drawn
from in some cases). But, it also was a pretty creaky API with a lot of
things that were strange and ad-hoc. This new version is definitely a
bit heavier, but I'm not sure that will impact anything in a major way.

--------------------------------------------------------------------------------
e6a5663 | advil | 2019-02-02 01:27:40 -0500

Simplify test slightly
Also, increase the timeout for `make test`; possibly this means that
some of these tests could be pared back a bit, but for now I'll keep
them slow.

--------------------------------------------------------------------------------
59e0e63 | advil | 2019-02-02 01:27:40 -0500

Further isolate ghost generation from levelgen rng
The properties of a ghost can lead to variation in the number of random
draws needed when placing it; for example, if a ghost knows certain
enchantments, these will be applied immediately with a random duration,
leading to an extra random draw relative to ghosts without an
enchantment. This can lead to seeds diverging depending on what ghosts
are in the local bones file. Isolate the entire placement process from
the levelgen RNG so it won't impact seeds.

--------------------------------------------------------------------------------
2941439 | advil | 2019-02-02 01:27:40 -0500

Further updates to rng development docs
[skip ci]

--------------------------------------------------------------------------------
b2a911e | advil | 2019-02-02 01:27:40 -0500

Print test names to stderr as they run
This lets there be visible progress during `make test`. It might be
slightly annoying when some tests are not running headless, but then the
user can just redirect stderr somewhere.

--------------------------------------------------------------------------------
4264f9c | Edgar A. Bering IV | 2019-02-02 01:15:33 -0500

Simplify a reaching check, actually fix 11704 (gammafunk)
Commit 0f9db6f4df modified the function mons_has_ranged_attack; however,
this was not checked by i_feel_safe, which instead checked
mons_has_known_ranged_attack. The latter function is a relic from when
monster equipment was not identified on sight and has been removed.

--------------------------------------------------------------------------------
0f9db6f | Edgar A. Bering IV | 2019-02-02 00:05:22 -0500

Check for monster polearms and wands in i_feel_safe (11704, 11782)

--------------------------------------------------------------------------------
43a6aff | Edgar A. Bering IV | 2019-02-01 22:49:42 -0500

Disable mores during targeting (11717)

--------------------------------------------------------------------------------
788b6e3 | Edgar A. Bering IV | 2019-02-01 21:01:51 -0500

Extend Fedhas' protection to non-beam spells (11310)
Fedhas now protects plants from LOS damaging spells that don't use
beams, as well as static discharge and irradiate. Additionally, attack
prompts have been adjusted to account for Fedhas' plant protection.

Finally, Fedhas prevents shatter from destroying trees.

"Fire-through" is not a completely coherent notion for player spells,
these inconsistencies were not always accompanied by a prompt, or had an
erroneous prompt. Hopefully this change will clarify the situation.

--------------------------------------------------------------------------------
ca774cb | Edgar A. Bering IV | 2019-02-01 14:08:45 -0500

Give a more helpful message for 'G>' at branch end (3734)

--------------------------------------------------------------------------------
4429137 | advil | 2019-02-01 09:53:28 -0500

Fix potential iteration order issue for autofight
This is unrelated to my current randomization woes, but something I
noticed while auditing lua/crawl interactions for iter order issues. The
iteration order for lua_next is *not* in general guaranteed, even if the
table is an array, and what I have noticed is that eventually, in a long
execution session, it will start diverging. So this may have been the
source of some of our more obscure reported autofight bugs.

I'm not sure if this solution using `map` is absolutely the best way to
deal with it; lua 5.3 has much better support for doing ipairs-style
iteration in C than lua 5.1, and this was the easiest fix without me
actually figuring out how that's supposed to work in lua 5.1 (which is a
bit tricky from everything I've read).

--------------------------------------------------------------------------------
8489be9 | advil | 2019-02-01 00:36:03 -0500

Add a new lua test for seed stability
May need some adjusting so it doesn't add too much time to the travis
build by default. It isn't impossible that this test will fail...

--------------------------------------------------------------------------------
12d111d | advil | 2019-02-01 00:32:47 -0500

Fix some typos and lua mistakes

--------------------------------------------------------------------------------
193e081 | advil | 2019-02-01 00:20:54 -0500

Randomness fix for swamp / pools

--------------------------------------------------------------------------------
2a401c0 | advil | 2019-01-31 23:40:22 -0500

Clear more global state for tests

--------------------------------------------------------------------------------
e4bce67 | advil | 2019-01-31 23:01:03 -0500

Allow shafts in tests
I'm not sure why these were disallowed, but it was 8 years ago and
didn't break anything for me. Plus, disallowing this messes up seed
testing.

--------------------------------------------------------------------------------
05a21ba | advil | 2019-01-31 21:49:18 -0500

Various fixes for more stable lua iteration order
I ended up auditing every instance of `pairs`; these are the ones that
potentially interact with dungeon generation / randomness. Basically,
the use of `pairs` is now dispreferred for anything like the code being
touched here. I added a few utility functions for dealing with weight
tables in various ways (would have made my life easier to add these
before...)

--------------------------------------------------------------------------------
0b81bb8 | advil | 2019-01-31 17:46:53 -0500

Reset temple vault tags when doing temple setup
This load() call was just adding in new tags to the previously loaded
list each time a game was started, leading to seed instability both in
tests and when a new game was started without exiting the program for
temple vaults with variable numbers of altars. (Because the length of
the list of tags changed, which leads to different behavior of the
random draw as the list gets longer even for the same seed.)

Possibly tags should be treated as a `set` or something, rather than
just a raw string that is split on demand?

--------------------------------------------------------------------------------
cd3d6b9 | gammafunk | 2019-01-31 15:07:39 -0600

Update documentation of a function

--------------------------------------------------------------------------------
2c779b6 | gammafunk | 2019-01-31 15:07:39 -0600

Prevent use of Passage of Golubria in Gauntlets (Yermak)
Like use of teleport, Golubria passages can bypass the Gauntlet's usual
one-way structure. Players can create a passage in the starting area,
enter and quickly loot a chamber, then return back to start to gain
access to other areas. This commit prevents casting the spell in
Gauntlets entirely.

--------------------------------------------------------------------------------
0a484b6 | gammafunk | 2019-01-31 10:20:55 -0600

Tweak the no-teleport message for Gauntlets
Add a little bit more flavor in the message. The old one was mostly
copied from Dungeon Sprint, which disables teleports as part of the game
mode itself.

--------------------------------------------------------------------------------
e63ed06 | advil | 2019-01-31 08:26:10 -0500

More RNG initialization improvements
Better reset for tests, initialize item descriptions with levelgen rng.
Also add a bit more fulldebug spam.

--------------------------------------------------------------------------------
542fcb7 | advil | 2019-01-31 08:26:10 -0500

Don't use ui_random for bones file choice

--------------------------------------------------------------------------------
18b6515 | advil | 2019-01-31 08:26:10 -0500

Remove crawl.random_element and replace with something more stable
Because lua iteration order, including at the C level, is not stable,
this was leading to seed variation in parts of the dungeon that heavily
use layout code. I've replaced it with a pure lua implementation of
random_choose_weighted (that parallels the C++ version); in principle
one could call into the C++ version, but it wasn't clear that there was
much of a point to that amount of effort. This version is stable because
it uses an array of pairs for the weight table; `ipairs` gives a stable
iteration order. Notationally it's not any more effortful.

--------------------------------------------------------------------------------
a9077f9 | advil | 2019-01-31 08:26:10 -0500

More improvements to randomization
* don't use math.random for bazaar tiles
* clean up rng and early D vault tests

--------------------------------------------------------------------------------
46ee55f | Edgar A. Bering IV | 2019-01-31 00:36:45 -0500

Don't use player spell colours for monster spellbooks

--------------------------------------------------------------------------------
b84795d | Edgar A. Bering IV | 2019-01-30 23:24:57 -0500

Describe tree form in potion of lignification (damerell)

--------------------------------------------------------------------------------
b30acc4 | Edgar A. Bering IV | 2019-01-30 22:59:10 -0500

Prompt before using bad or dangerous consumables (11836)
This covers immolation, vulnerability, noise, mutation, lignification,
and degeneration, as well as torment and holy word when applicable.

The new behavior can be disabled by setting an option `bad_item_prompt`
to false.

--------------------------------------------------------------------------------
bed441b | Edgar A. Bering IV | 2019-01-30 18:59:35 -0500

Dissapate Guardian Golem clouds out of LOS (11701)
Change guardian golem's inner flame actor to MID_YOU_FAULTLESS (from
nullptr), and disappate clouds owned by MID_YOU_FAULTLESSS when out of
LOS.

--------------------------------------------------------------------------------
1bb0902 | advil | 2019-01-29 23:39:09 -0500

Clear unrand state for relevant tests
This was impacting generation and causing a false positive for seed
inconsisticies.

--------------------------------------------------------------------------------
964d818 | advil | 2019-01-29 22:18:59 -0500

Use a separate rng for ghosts
The most recent set of seed instabilities I've been seeing are because
the ghost loading code makes a different number of random number draws
depending on whether it loads from the permastore or not, and in a clean
setup it was guaranteed to draw from the permastore on the first run,
but not thereafter, for some seeds. (Because even a permastore ghost
gets resaved as an ephemeral ghost if a level is vetoed - something that
is perhaps a bug itself.) In general, it seems risky to use levelgen rng
for something that may depend on what's on a particular file system, so
separate this off into its own rng for cases like this, distinct also
from the gameplay rng.

Also, fixed a bug in loading of ephemeral ghost files where if there was
more than one ghost in the file, the wrong one would be removed after a
ghost was selected for use.

--------------------------------------------------------------------------------
797c3c0 | advil | 2019-01-29 19:53:42 -0500

Fix accidental cursed slaying nerf (gammafunk)

--------------------------------------------------------------------------------
4a9ad93 | advil | 2019-01-29 19:32:52 -0500

Another batch of randomization sequence fixes
mostly to do with items this time.

--------------------------------------------------------------------------------
5a19998 | advil | 2019-01-29 15:34:46 -0500

checkwhite

--------------------------------------------------------------------------------
cdddf7c | advil | 2019-01-29 15:14:31 -0500

Sequence many, many random calls whose order was undefined
Also add some documentation about these issues for other developers.
Basically, the call order for functions that are present in an
arithmetic expression or a constructor is undefined and can vary
(leading to different effects of seed).  It would be foolish to think
that this got everything, but I hope that this did get everything for
dungeon generation per se; given the complexity of this problem getting
real seeding for the gameplay UI may be a bit far off.

Two areas of concern:
* random_var is clever and fun, but also inherently not a good fit for
  wanting well-sequenced rng calls, because operators inherit this
  undefinedness.
* I didn't really try to address div_rand_round in this commit, which is
  all over the place and potentially hidden in many return calls.

--------------------------------------------------------------------------------
14c3f58 | advil | 2019-01-29 15:14:31 -0500

Expand out the seed vs generation test for a few more levels

--------------------------------------------------------------------------------
1e53798 | GenericPseudonym | 2019-01-29 00:49:11 -0500

Quiet confirm_action in the ability menu (11738)
The confirm prompt was still being generated when
_check_ability_possible was called in "quiet" mode, though it shouldn't
have been.

[Committer's note: Closes #969]

--------------------------------------------------------------------------------
a39c873 | Edgar A. Bering IV | 2019-01-29 00:18:18 -0500

Changelog through 0.23-a0-899-gbbae0a335a

--------------------------------------------------------------------------------
bbae0a3 | Martin Staffa | 2019-01-28 21:37:41 -0500

Further distinguish light skill drain
This should make it easier for the player to judge how heavily he
is drained in the early game, and when using Ru's powers.

For monsters, the drain of a wraith is 25, and a hit from a draining
wand is a minimum of 75, but currently both give you the same status.

The same is true for Ru's Draw out power and Apocalypse: 30 vs 100,
but both give you the same status (and have the same "skill drain"
description in the god ability menu). For Ru it is quite important to
manage your skill drain, and introducing a new threshold should help
with that.

[Committer's note: Adjusted the colour scale; Closes #963]

--------------------------------------------------------------------------------
0a62fed | NormalPerson7 | 2019-01-28 21:11:21 -0500

Use keys for paralysed_by and petrified_by player props (ebering)

--------------------------------------------------------------------------------
779a845 | NormalPerson7 | 2019-01-28 21:11:21 -0500

Include petrification information in death messages (11374)
Display "Slain by X ... while petrified [by X]" on the death screen when
the player was killed while petrified, in the same way as paralysis.

This applies only when fully petrified, not when petrifying, and the
monster that first applied the petrifying status is used in the death
message, even if the player is hit again with the petrify spell by a
different source on the following turn and this accelerated the
petrification process.

--------------------------------------------------------------------------------
250879e | gammafunk | 2019-01-28 04:02:16 -0600

Adjustments to a runed door vault
In mikee_hates_you, the runed door has a special warning text, but this
isn't necessary. The vault shows what monsters you'll be facing, and the
avatar's mesmerize ability can be seen through x-v. Since the runed
doors are transparent now, move the loot item behind the final door
instead of putting it under the merfolk with no_pickup. Adjust the
windows to allow seeing the monsters as well as the loot item.

The vault places an escape hatch for exit, but allows placement on D:$
where this hatch can't place. Disallow placement on D:$, allowing the
vault to place one level earlier. D:12 is fine for a vault of this kind.
Finally, use the default glyph for runed clear doors instead of a custom
one.

--------------------------------------------------------------------------------
27a1b2c | gammafunk | 2019-01-28 03:57:26 -0600

Adjustments to a Lair end vault
In cheibrodos_lair_end_hotspot, use default symbols for the runed door
and simplify NSUBST statements.

--------------------------------------------------------------------------------
c028996 | gammafunk | 2019-01-28 03:57:26 -0600

Adjustments to a Lair vault
The vault gammafunk_lair_enchanted_lake currently has an opaque runed
door with spoilery encounters behind it. Make this vault use a runed
clear door and provide a couple carefully placed windows into the
interior of the vault. Now that it better reveals its contents, allow it
to place on Lair:1. Finally, slightly adjust the monster set to use
better flying monsters and simplify some NSUBST statements.

--------------------------------------------------------------------------------
5d1f0fd | gammafunk | 2019-01-28 03:48:24 -0600

Remove a placement limitation on a Lair vault
This vault is fine as a float vault for Lair:$.

--------------------------------------------------------------------------------
479ecb9 | gammafunk | 2019-01-28 03:48:24 -0600

Adjust an Okawaru altar vault
In the vault okawaru_arena_lexackson, use clear runed doors instead of
opaque ones. Don't use non-standard colors on lava, doors, and down
hatches. Also don't use a special quality level on loot where good_item
would suffice. This vault might predate the availability of that tag,
but the issues described in the now-removed comments are no longer
relevant.

This vault in general should see a rework. It has a spoilery mechanism
to release monsters and block your exit as you move into the vault. It
also has a special "loot choice" mechanism that isn't necessary given
the number of monsters. A transporter vault would be a good fit for the
basic concept, but it would be a little plain if converted to a simple
room with 4 "warrior" monsters. I'll look to rework the vault in a
future commit once I have a good idea.

--------------------------------------------------------------------------------
16004d8 | NormalPerson7 | 2019-01-28 01:14:13 -0500

Make yellow draconians' rAcid a true mutation (11381)
Previously, yellow draconians' rAcid was hardcoded into the game and
they were given a fake mutation description in the species yaml file.
This had the problem that when transforming into statue or lich form,
the fake mutation description was greyed out on the A screen despite
continuing to function.

Therefore, add a new acid resistance mutation, MUT_ACID_RESISTANCE, and
give it to yellow draconians. Remove the special-casing for yellow
draconians' rAcid at the same time, and add a new minor version to
manually give yellow draconians in progress their rAcid mutation.

Additionally, add back "(rCorr)" to the mutation description on the A
screen. This was lost when species definitions were converted to yaml
files.

[Committer's note: Closes #965]

--------------------------------------------------------------------------------
c183402 | advil | 2019-01-27 23:49:51 -0500

swap true and false (vt)
[skip ci]

--------------------------------------------------------------------------------
6b46e92 | advil | 2019-01-27 23:13:21 -0500

Actually use a function added earlier
Was added to consolidate debug code with real setup code, but then only
used for debug code.

--------------------------------------------------------------------------------
72c9835 | advil | 2019-01-27 23:13:21 -0500

Finish sentence (switch__)

--------------------------------------------------------------------------------
4f7982c | advil | 2019-01-27 23:13:21 -0500

Webtiles implementation for the progress bar
Pregen is still disabled in DGL builds, but with this commit it now
works exactly the same as tiles/console.

--------------------------------------------------------------------------------
5e79892 | advil | 2019-01-27 23:13:21 -0500

checkwhite

--------------------------------------------------------------------------------
6caef08 | advil | 2019-01-27 23:13:21 -0500

Two sanity-check fixes
Both of these, I think, were leading to memory corruption. In the case
of the tileweb.cc change, if you were to set the number of ui state
channels to 0, and then try to push a ui update to channel 0, this could
lead to memory corruption if your stdlib let it happen. In the case of
the formatted_string change, what's being pushed back is really an
fs_op, and so the constructor needs to be called, in which case it is
really better as an emplace_back; I'm not 100% sure that this would be
bad on all (or any) stdlib implementations (since it might rely on an
implicit copy constructor or something), but I definitely got an lldb
backtrace with a crash inside this call.

--------------------------------------------------------------------------------
568795b | advil | 2019-01-27 23:13:21 -0500

More documentation for seeding

--------------------------------------------------------------------------------
4636eb8 | advil | 2019-01-27 23:13:21 -0500

Make Boris compatible with pregeneration
This (in a kind of ad-hoc way) simple regenerates Boris with a fixed
probability on appropriate levels, as long as he is dead and has been
killed at least once.

--------------------------------------------------------------------------------
62981b3 | advil | 2019-01-27 23:13:21 -0500

Fix some state bugs with pregeneration

--------------------------------------------------------------------------------
c02791a | advil | 2019-01-27 23:13:21 -0500

Fix some mod math in the progress bar display

--------------------------------------------------------------------------------
641d409 | advil | 2019-01-27 23:13:21 -0500

Use a stable order for loading vault files
It turns out that all the deterministic RNG in the world doesn't help if
you are choosing among things whose initial order is at the mercy of the
file system.

This commit isn't necessarily a full and complete solution to this
issue, more of a minimal first step; it would be nice to have an even
more stable way of getting vault indices.

--------------------------------------------------------------------------------
4066ec4 | advil | 2019-01-27 23:13:21 -0500

More rng diagnostics for travis
Show exact internal rng state, temple vault choice

--------------------------------------------------------------------------------
30f140d | advil | 2019-01-27 23:13:21 -0500

Print some random numbers in the rng test for diagnostic purposes
Kind of stretching for anything here...

--------------------------------------------------------------------------------
31e2f47 | advil | 2019-01-27 23:13:21 -0500

Explicitly cast rng constants to uint64_t
I have no idea if this will matter at all, since `unsigned long long` is
apparently >64bit on some systems, this might(?) contribute to more stable 
behavior
across builds.

--------------------------------------------------------------------------------
6050340 | advil | 2019-01-27 23:13:21 -0500

checkwhite

--------------------------------------------------------------------------------
f44c623 | advil | 2019-01-27 23:13:21 -0500

Add a test that prints D:1 vaults for various seeds
This is not a test that is necessarily likely to crash, but more of a
way of detecting changes. (Also, this is the beginnings of one way of
implementing a seed catalog a la brogue.)

--------------------------------------------------------------------------------
087f7eb | advil | 2019-01-27 23:13:21 -0500

Show seeds for dead online chars

--------------------------------------------------------------------------------
3e876b1 | advil | 2019-01-27 23:13:21 -0500

Don't do pregeneration for sprints, etc.
They are all one level and the pregen code doesn't handle them anyways.

--------------------------------------------------------------------------------
424b21a | advil | 2019-01-27 23:13:21 -0500

Use correct cross-platform format specs for uint64_t
since 64bits can be `long long int` or just `long int` depending on
platform.

Also, fix a bunch of warnings.

--------------------------------------------------------------------------------
b90a470 | advil | 2019-01-27 23:13:21 -0500

Add a rudimentary progress popup to run during pregeneration
Since this can take up to a minute, it's nice to show the user that
something is happening. This replaces the "hit <space> to ..." interface
from bel's patch. It does not yet have a webtiles implementation, which
is ok because pregeneration is disabled on webtiles.

--------------------------------------------------------------------------------
8f561c4 | advil | 2019-01-27 23:13:21 -0500

Fix a build error

--------------------------------------------------------------------------------
40d72c2 | advil | 2019-01-27 23:13:21 -0500

Add some spare RNGs before the branch ones
Given the save compat implications, it would be a lot less annoying to
allocate these now than later.

--------------------------------------------------------------------------------
de1184c | advil | 2019-01-27 23:13:21 -0500

Document seeding options better, allow rc file seeds
This change also lets offline players view their game seed, and shows it
in the chardump. Yes, this can be used to "cheat" but no more so than
savescumming (in fact, less-so), and based on experience with brogue and
seeded games, this feature will work best if players can view it. It is
impossible to access seeds in online games, and I didn't even put it in
the crash dump on the grounds that this would be a pretty big
information leak - to see a seed for an online game, one would need to
get a save backup and load it offline.

--------------------------------------------------------------------------------
443bbbd | advil | 2019-01-27 23:13:21 -0500

Allow saving ghosts when a seed is set
This check was intended to prevent test code (e.g. qw runs) from
generating ghosts, but it doesn't make sense any more in the context of
seeded crawl.

--------------------------------------------------------------------------------
d59c169 | advil | 2019-01-27 23:13:21 -0500

Implement dungeon pregeneration (bel)
In order to improve deterministic dungeons (given a seed), allow
pregenerating the entire dungeon in a stable order. This is originally
based on an implementation by bel, that can be found at:
    https://github.com/belrogue/crawl/compare/master...belrogue:seeded_crawl

That approach relied on the player actually entering each level, which
had a number of weird side-effects, and relied on wizmode code (not
available in all builds). This commit attempts to separate out
generation and entering of a level, where a non-visited level will have
0 turns spent on it. It also simplifies the generation order from bel's
version. To enable this, set the option `pregen_dungeon` to true.
Pregeneration is disabled for DGL builds, for two reasons: I'm assuming
seeded runs won't be a thing any time soon for server play, and
pregeneration is a heavy initial CPU hit that might impact server
performance in any case.

There are still a bunch of UI issues after this commit, and it's not
super well tested.

Other side effects:
 * Added an initialization phase for map markers that can run when a
   level is generated - activation happens when a player enters the
   level.

--------------------------------------------------------------------------------
2dd0f10 | advil | 2019-01-27 23:13:21 -0500

Use dungeon RNG for initial dungeon setup
Missed this in a previous commit.

--------------------------------------------------------------------------------
236e7cc | advil | 2019-01-27 23:13:21 -0500

Move seed / version history out of ?V title
This works less well as this string gets longer.

--------------------------------------------------------------------------------
7a91997 | advil | 2019-01-27 23:13:21 -0500

Up the seed size to uint64_t
These is probably overkill, but it's easier to do this now than later.

--------------------------------------------------------------------------------
cb93d8a | advil | 2019-01-27 23:13:21 -0500

Improve behavior of seeding
Two main changes in this commit:
1. add additional per-branch RNGs with separate state, so that level gen
randomization doesn't interact with gameplay RNG, and levels interact
less with each other.
2. save RNG state with the player, and restore it on reload, so that the
choice of seed is not just per game session.

This is not a fully seeded crawl in the sense that most people would
want: level generation out-of-order within a branch will still advance
that branch's RNG, and dependencies on order (e.g. uniques, vaults) are
still present. However, it is much closer, in that if levels are loaded
in the same order, the same game seed *should* guarantee the same
dungeon with a few minor caveats (things like Boris, pan lords). For
some discussion of the issues, see:
https://crawl.develz.org/tavern/viewtopic.php?p=306334

Right now seeds are 32 bits, and the seed initializes gameplay rng too,
which may or may not be desireable. Every game is seeded (which is
rather different than the old behavior - games not explicitly seeded
used a pseudorandom 128 bit seed to initialize the rng states.)

Per-branch RNG is perhaps overkill, but relatively simple.

--------------------------------------------------------------------------------
0c83f0c | NormalPerson7 | 2019-01-27 17:45:43 -0500

Fix AC calculation in item description with deformed body (Monsterracer)
Previously, the AC granted by armour when the player has deformed body
was sometimes lower than that indicated in the item description's
"Wearing mundane armour of this type will grant the following:" line.

This was because:
  - player::base_ac_from calculates the AC reduction from
    deformed body as `AC - baseAC / 2`;
  - the description called the player::base_ac_from method with scale
    parameter 1, resulting in the AC being rounded up;
  - the actual AC calculation called the method with scale parameter 100
    and then performed integer division on the final result, resulting
    in the overall AC being rounded down.

Fix this by calling base_ac_from with scale parameter 100 and then
dividing by 100, so that the maths here is equivalent to that in the
real AC calculation.

--------------------------------------------------------------------------------
8ff03fb | gammafunk | 2019-01-26 17:44:11 -0600

Update vaults to not overwrite a default glyph
These vaults all set '=', which is a runed door by default, to some
other definition. In all cases they had plenty of symbols available.
Although it's fine to override default glyph meanings when more symbols
are needed, it's best not to do so for commonly used symbols like '='.
This commit updates many such vaults to not use '=', using 'a' or
another symbol where appropriate. The remaining vaults that do this can
be changed in subsequent commits.

This commit also simplifies various NSUBST statements in these vaults.

--------------------------------------------------------------------------------
d608b80 | gammafunk | 2019-01-26 17:44:11 -0600

Rework glyph usage in some door vaults
These vaults put doors on different glyphs from '+', presumably because
they apply a marker. It's not necessary to use a custom glyph, so use
'+' instead.

We want these vaults to be a surprise, so they should still use the
classic runed opaque door for now. Use a different glyph from '=', since
that is now used specifically for runed clear doors.

--------------------------------------------------------------------------------
fa4f36b | gammafunk | 2019-01-26 17:44:11 -0600

Rework a loot item in a vault
Replace the "acquire any" items in evilmike_wizard_prison with nice
randart artefact jewelry, randart aux armour, or acquirement scrolls.
The scroll is a better way to give player loot that's based on their
character, since the choice aspect makes it more likely to be useful.

Also fix the wrong usage of a substitution operator and simplify terms
in some NSUBST.

--------------------------------------------------------------------------------
a8f1c90 | gammafunk | 2019-01-26 17:37:52 -0600

Remove unneeded KFEAT from some vaults
These vaults define runed doors as a KFEAT on '=' despite that glyph
already having this meaning. Also simplify NSUBST syntax in one of these
vaults.

--------------------------------------------------------------------------------
041552f | gammafunk | 2019-01-26 17:37:52 -0600

Rework and simplify some aspects of a vault
The vault hangedman_eye_storm had a normally accessible area flagged as
no_tele_into. This area has only one access out and a few eye monsters,
but has no teleport closets, so the flag is not needed here. It also
sometimes used runed doors in the Abyss, but is not an especially nasty
vault, especially not for that branch. Use normal doors instead.

--------------------------------------------------------------------------------
b3145dc | gammafunk | 2019-01-26 17:37:52 -0600

Make runed clear doors the default runed door type
Rune door vaults generally work best without major spoilers. To some
extent players will always have some encouragement to read vault
spoilers even for vaults that are not sealed with runed doors or
transporters. For unspoiled players taking on challenge vaults, however,
it generally works best if they can reason about whether the risk is
worth the reward. At a minimum it's good for players to know what
they'll find when they first open the door. If this basic information
isn't available, players need to assume the worst and will visit the
vault long after they first find it.

This commit makes the recently introduced runed clear door the default
type of runed door used in vaults. It does this by changing the default
DES mapping of the '=' glyph to runed_clear_door. Vaults that defined a
special symbol for runed_clear_door have been updated to remove that
definition and simply use '=' instead.

Spoilery vaults that hide surprises behind opaque runed doors still have
a place, provided that what they do is memorable enough. These vaults
work best if they appear later in the game, so that the player has
enough resources to survive or escape arbitrary threats.

--------------------------------------------------------------------------------
dd7946d | Edgar A. Bering IV | 2019-01-26 17:49:32 -0500

Fix ball lightning stair behavior (11812)
First, prevent ball lightnings from taking stairs. Second, disappate
player ball lightnings left behind. While technically monsters, these
should behave like conjurations from a gameplay point of view.

--------------------------------------------------------------------------------
fe5b60b | Edgar A. Bering IV | 2019-01-26 17:13:47 -0500

Make Jiyva slime neutralising like Fedhas' (11792)
Changing god conversions to run exactly once, and on first sight
resulted in unkillable slimes for a Jiyva player. This moves slime
conversion to run in the same place as Fedhas' plant neutralising,
making it global and independent of player LOS.

This has the effect of waking up slimes on a level so they start eating
items sooner; however awake slimes that hadn't been converted would
start eating already, so the net effect isn't that large.

--------------------------------------------------------------------------------
83ee88d | Edgar A. Bering IV | 2019-01-26 16:37:48 -0500

Use env.map_knowledge to check moveto prompts (11806)
Prevent information leaks when far movement effects (shadow step, hop,
etc.) have the possiblity of landing in the explore horizon.

--------------------------------------------------------------------------------
1f260a4 | Edgar A. Bering IV | 2019-01-26 16:17:29 -0500

Consistent interpunctuation for damaging spells
Freeze, Airstrike, Irradiate, Static Discharge, Awoken Forest attacks,
and some LRD and Shatter damage do not occur via a `struct bolt`, and
need their interpunctuation set separately to consistently reflect
damage done.

--------------------------------------------------------------------------------
4a3ee90 | Edgar A. Bering IV | 2019-01-26 15:31:01 -0500

Make damaging enchantments obvious effects, punctuate (11814)
Pain, Dispel Undead, Agony, and Disintigration all do damage to a
monster, even though they are MR checking enchantments. Every other
single target damaging spell gives feedback when something is hit. The
lack of feedback is especially noticable for the three of these spells
that can kill: "Nothing appears to happen." is followed by "You feel a
bit more experienced!" which is an oddity.

This commit changes these spells to always give a message if damage is
done.

While adjusting the visibility of the messages, this commit also adds
consistent interpunctuation to Pain, Dispel Undead, and Disintigration;
bringing these spells in line with other damaging spells.

--------------------------------------------------------------------------------
0551b70 | Edgar A. Bering IV | 2019-01-26 13:58:25 -0500

Respect monster special monster polymorph rules (11840)
Several polymorph effects used monster_polymorph directly, but ended up
calling it on ugly things, which should instead have their colour
change. These have been replaced with mons.polymorph(), which has a new
signature that accepts a polymorph power type. This also ensures that
these effects respect slime creature's split-then-poly mechanic.

This affects Xom polymorph and Nemelex degeneration.

--------------------------------------------------------------------------------
c8dc575 | Edgar A. Bering IV | 2019-01-26 12:59:53 -0500

Give Tengu permanent flight at XL 5
This was suggested on Mantis as 10707 and a patch was included,
unfortunately the patch had aged poorly and couldn't cleanly apply, so
this is a re-implementation.

Tengu racial flight starts at XL 5, as an activated ability. The
activation gives flight (with its Tengu bonuses) for 25 + random2(xl*4)
+ random2(xl*4) turns. In practice, this meant that a low XL Tengu
effectively had permanent flight, provided they remembered to activate
it. The MP cost takes at most 38 turns to recover (regen to full with 3
MP). The duration of Tengu flight averaging 45 turns when first
acquired, rising to 77 at XL 13. The Tengu player with more than 3
total MP that was willing to do a lot of tedious waiting and re-casting
could enter any encounter flying and with full MP.

Removing the interface screw shouldn't affect optimal balance, but it
might turn out to be a practical buff. If that haappens to be the case a
nerf that is not an interface screw can be applied.

--------------------------------------------------------------------------------
3ad9d5a | NormalPerson7 | 2019-01-26 12:22:35 -0500

Make the polymorph targeter more informative (11706)
This commit changes the polymorph targeter to display "not susceptible"
for undead and nonliving monsters that cannot be polymorphed. It also
now displays "will change shape" and "will change colour" instead of the
chance to hex, when targeting known shapeshifters and (very) ugly
things, respectively, to make this special effect somewhat better
described.

--------------------------------------------------------------------------------
ec06c1a | NormalPerson7 | 2019-01-26 11:32:38 -0500

Don't scale EV bonuses when a flying Te/swimming Mf/petrifying (11463)
Previously, the effects of flat evasion bonuses such as rings of
evasion, the amulet of the acrobat, mutations, and potions of agility,
were scaled up by the effects of flying as a tengu, and swimming as a
merfolk, and halved by the petrifying and held statuses.

This led to weird behaviour where flying as a tengu meant acrobat
actually gave 18 EV, and other oddities, which are inconsistent with how
flat bonuses generally function.

Therefore, this commit makes it so that the evasion bonuses are added to
the post-scale evasion, rather than the pre-scale evasion.

There is a remaining inconsistency in paralysis, full petrification,
tree form, and most notably, dexterity stat zero, where these evasion
bonuses are not accounted for at all. In the case of paralysis and full
petrification this probably makes sense, whereas for clumsy and tree
form, where you can still act, this behaviour is somewhat arguable,
because it is not obvious here that rings of evasion etc are rendered
useless.

--------------------------------------------------------------------------------
372ee70 | Nikolai Lavsky | 2019-01-26 11:20:15 -0500

Don't add unique annotations for an illusory unique (u/kitchen_ace)
After commit eddfa9bf, if an illusionary unique created by phantom
mirror outlives the original, the corresponding unique annotation
won't be removed.
Fix this by not adding annotations for illusions.

--------------------------------------------------------------------------------
dc03e01 | gammafunk | 2019-01-25 18:45:35 -0600

Don't give brown as an XL7 draconian colour (blorx1, ebering)
The random_draconian_colour() function merged as part of the datafiles
branch didn't properly exclude base draconians as a colour to award at
XL7. Rewrite this function in a way that uses random_range() for the
non-base colours, but so that it can also exclude removed/unviable
colours.

--------------------------------------------------------------------------------
547f200 | stenella | 2019-01-25 11:48:28 -0800

Move a MSVC property to a property file
Rather than defining __STDC_LIMIT_MACROS for every single build type, move it 
to common.props.

At the moment it's only defined in one build type, which is due to lack of 
completeness (on my part) in the past.

--------------------------------------------------------------------------------
739d080 | Edgar A. Bering IV | 2019-01-25 11:17:28 -0500

Update CREDITS.txt, fix an alphabetization

--------------------------------------------------------------------------------
41928f0 | dcandido | 2019-01-25 01:44:09 -0500

Add petrify to the enchantment susceptibility check (10659)
[Committer's note: in addition to the mantis patch, bolt.is_harmless
 had a separate case for petrify, which wasn't being reached because
 petrify is an enchantment.]

--------------------------------------------------------------------------------
df0a61e | Edgar A. Bering IV | 2019-01-25 00:22:05 -0500

Adjust spacing in x-v spell descriptions
Spells that had both a hex chance and a range had an extra space between
the two indicators.

--------------------------------------------------------------------------------
6d2b917 | advil | 2019-01-24 21:02:58 -0500

Don't build for checkwhite/unbrace travis tests
Also, don't try both compilers, since there's no compilation needed.

--------------------------------------------------------------------------------
3073675 | stenella | 2019-01-24 11:40:54 -0800

Update gen-all.cmd
Mirroring changes made earlier to generation of species-type.h

--------------------------------------------------------------------------------
a3e6480 | Edgar A. Bering IV | 2019-01-23 22:33:26 -0500

Correct a typo in Sif's description (damerell)

--------------------------------------------------------------------------------
152313e | Edgar A. Bering IV | 2019-01-23 20:23:47 -0500

Two quotations (Can-ned Food)
Quotes for ring of intelligence and scroll of silence.

--------------------------------------------------------------------------------
ae04d92 | Edgar A. Bering IV | 2019-01-23 19:08:31 -0500

Scale net trap to-hit with absdepth
Legacy net traps had a fixed to-hit chance; with the change to make them
always player targeted it is readily apparent that their ability to hit
falls off in the late game, making them more a free source of nets than
a relevant tactical threat. They now scale with approximately the
throwing abilities of a non-archer see-invisible monster with HD absdepth/3.

--------------------------------------------------------------------------------
16358f6 | Alan Malloy | 2019-01-23 15:15:38 -0800

Fix undefined behaviour when applying elec brand (Laret, #11837)

--------------------------------------------------------------------------------
31c0f47 | gammafunk | 2019-01-23 07:06:54 -0600

Prompt when entering excluded transporters
Currently when entering an excluded transporter, the transporter is
entered with no prompt is given. This commit adds a yes-or-no prompt
similar to the one used when taking excluded stairs.

--------------------------------------------------------------------------------
2dcc7d9 | gammafunk | 2019-01-23 07:06:54 -0600

Don't travel through excluded transporters (EN0N)
Currently exclusions made on transporters do nothing to limit travel.
Travel handles transporters like stairs in terms of allowing the player
to move onto the excluded transporter if the entire exclusion is a
single square. This is good, since just as we do for single-square
exclusions on stairs, we want to prevent travel from taking the
transporter but allow standing on it. However travel didn't actually
prevent taking the transporter, and with this commit it now does.

--------------------------------------------------------------------------------
5da158a | Umer Shaikh | 2019-01-22 22:29:07 -0500

Unify exit paths from show_terrain view
We make pressing any unassigned key in the show_terrain view behave the
same way as pressing |.

Pressing | restores all layers and exits the layers menu; pressing an
unassigned key exits the menu without restoring layers, and layers are
restored on the next action. However this latter is undesirable.
Currently the menu primarily acts like a way to interactively and
temporarily change the view, so it is surprising that dismissing the
menu should not dismiss the effect. The player is about to act, so they
usually want all layers back anyway. It is a pretty baroque behaviour in
an already baroque menu.

(If it is desirable to allow players to act without all layers visible,
then there should be some way to set a semi-permanent option to do
so---the player shouldn't be required to use CMD_SHOW_TERRAIN each
turn.)

--------------------------------------------------------------------------------
2495da7 | Umer Shaikh | 2019-01-22 22:29:07 -0500

Let ESC clear/toggle layers in show_terrain view (amalloy)
We make it slightly more convenient to manipulate layers in show_terrain
view. Escape clears all layers if any layers are active, and activates
them all if none are active.

--------------------------------------------------------------------------------
e13c4b7 | Alan Malloy | 2019-01-22 11:11:18 -0800

Remove comment about creating homogenous hash tables
This feature was removed in 75921593c, and the remaining comment is
just confusing.

--------------------------------------------------------------------------------
036b721 | gammafunk | 2019-01-22 08:28:14 -0600

Fix a debug warning message
This debug message wasn't properly updated in a6713cf8 and causes a
compilation warning due to implicit conversion of an enum class to
unsigned int. Use a static cast and have the message attempt to also
display the spell school's long name. It might be better to just use an
ASSERT here, but I haven't looked at what all the callers are doing with
this function.

--------------------------------------------------------------------------------
53669af | gammafunk | 2019-01-22 07:28:58 -0600

Fixes for player doll tiles
Add the placeholder tiles for Rift and group together tiles for removed
unrands with a comment to remove their entries upon major version
change.

--------------------------------------------------------------------------------
52100fa | gammafunk | 2019-01-22 07:10:11 -0600

Generalize a check for reach attacks
For the range limit, don't specifically check for the Rift unrand, but
rather check the reach type directly.

--------------------------------------------------------------------------------
8c0a028 | gammafunk | 2019-01-22 06:36:43 -0600

Update the description of the Rift unrand
Make it clear that Rift doesn't have the usual limitations of reach
attacks.

--------------------------------------------------------------------------------
5f40c2e | gammafunk | 2019-01-22 06:32:45 -0600

Fix autofight for reach attacks
Properly apply checks for the capability to use a reach attack when
using a normal polearm. The implementation in #949 applied los_no_trans
to every kind of reach attack, when that's only appropriate for the Rift
unrand.

--------------------------------------------------------------------------------
efd6b3f | gammafunk | 2019-01-22 06:32:45 -0600

Implement reach support for the Rift unrand
The commit in #949 originally used the targeter_reach class with
additional range and generalized the logic in _reach_weapon_attack().
These aspects were part of an earlier design of Rift and are no longer
necessary. This commit implement's Rift's reach attack using
targeter_smite instead.

--------------------------------------------------------------------------------
7c2441a | olowin | 2019-01-22 06:17:08 -0600

The unrand demon trident "Rift" with distortion and extended reach
There are no existing distortion-based unrands and distortion is an
interesting and powerful brand but the blinking effect makes it somewhat
annoying to use. By extending the reach of a polearm the annoyance
factor is reduced since it's unlikely the player will need to reposition
just to hit their target.

The extended range is defined in reach-type.h. autofight.lua changes
allow extended reach tabbing, without which combat becomes quite
tedious.

Committer's Note: Rift is a +8 demon trident of distortion with a range 3
reach that's smite targeted. Any monsters or translocation-allowing
features between the attacker and the target have no affect on the
weapon's accuracy or ability to hit. In the original commit in #949,
Rift had a reach range of 4, +4 enchant, and +Blink. The range reduction
to 3 balances the weapon a bit and the enchant increase make it less
likely that Lugonu worshipers will want to swap weapons when their
target becomes adjacent.

Additionally, changes to evoke.cc that were part of the original commit
are not included. Those changes implemented support for extended reach
that will be implemented in a simpler way in a subsequent commit. I've
also added some quick placeholder art for Rift. We'll hopefully have
proper tiles before the 0.23 release. Closes #949.

--------------------------------------------------------------------------------
ecd3555 | Edgar A. Bering IV | 2019-01-22 00:43:36 -0500

Don't allocate extra space for a vector

--------------------------------------------------------------------------------
86364c1 | Alex Jurkiewicz | 2019-01-22 00:28:15 -0500

Revise storm card (minmay, ebering)
Storm's old effect (wind blast + storm cloud ring + air elemental)
didn't fit in well with the rest of the deck of desctruction, and wasn't
that great anyway. Revise to be more purely about AoE electrical damage.

New effects are: wind blast plus up to nine electrical explosions
(depending on power).

The explosion targets are chosen randomly at a distance so that they
don't damage the player, firing only one explosion per cell. As a
result, using this card in a corridor or near a corner will likely not
hit the intended target---particularly at low power.

In terms of balance, the explosions do slightly less damage than power
zero conjure ball lightnings at low power, scaling to be comprable to
high power CBL at high power. This isn't too out of line with the other
destruction cards, considering the terrain limitations and noise; but
will need some playtesting feedback to be certain.

[Committer's notes: re-wrote the patch to use random sampling of targets
 based on a radius iterator; adjusted damage formulas; added flavour
 messaging. Closes #942]

--------------------------------------------------------------------------------
6debee6 | Edgar A. Bering IV | 2019-01-21 01:30:25 -0500

Really remove High Elves
Their retention of starting jobs was causing them to incorrectly appear in
-playable-json.

--------------------------------------------------------------------------------
00444ac | Edgar A. Bering IV | 2019-01-21 00:13:53 -0500

Tormenting allies turns them hostile
Previously, allies would gladly accept player torment, though only in
the form of torment and not the form of agony. It's unclear why a player
would want to torment their allies, but but they're done putting up with
it in any case.

--------------------------------------------------------------------------------
40270af | Edgar A. Bering IV | 2019-01-21 00:13:37 -0500

Better grammar for LOS spell attack prompts
Print a sensible message instead of "Really harm near your..." when
handling LOS spell prompts. Now get a more meaningful "Really
refrigerate near your..." or other verb as appropriate.

--------------------------------------------------------------------------------
81dc5fd | Edgar A. Bering IV | 2019-01-21 00:13:31 -0500

Refactor scroll and sceptre of torment prompts
Refactor the prompts (torment and holy word) to use the
general `stop_attack_prompt` function with a los targeter. Closes #953.

--------------------------------------------------------------------------------
48644e5 | 1Hyena | 2019-01-21 00:08:29 -0500

Check and set conducts for holy word and torment (11821)
Create a general purpose `_scroll_will_harm` function that can
be used to determine if a particular monster would be harmed as
a result of reading a certain scroll.

In the `read` function for scrolls, check `god_hates_item`.  Also, add
warnings about regular friendly fire, and if hurting the victim of our
scroll could put us under penance. The warning about penance uses
"could" instead of "would" because by the time we finish reading the
scroll it may not be dangerous any more (can happen with blurry vision).

The friendly fire checks for torment are also extended to the sceptre
of torment, using similar logic to the singing sword.

God conducts are now checked when delivering a holy word or a
torment effect to monsters. Previously, the good gods would give penance
for using a scroll of torment, but gods with ally conducts were
indifferent to torment and holy word, contrary to the conduct.

[Committer's note: formatting cleanup, squashed, reworded commit message,
 closes #941]

--------------------------------------------------------------------------------
91b4073 | Edgar A. Bering IV | 2019-01-20 21:13:29 -0500

Remove an extra acid message, braces, and some logic
Closes #952.

--------------------------------------------------------------------------------
440a6e3 | NormalPerson7 | 2019-01-20 20:59:50 -0500

Use exclamation marks to indicate damage for all brands
Exclamation marks were previously only used to indicate the damage
dealt by freezing, flaming and holy brands. This commit converts all
brands that deal additional damage to use exclamation marks calculated
by attack_strength_punctuation, with the exception of chaos, which uses
beams and was therefore dealt with by the previous commit.

This affects the electrocution, pain, distortion, draining and acid
brands, and as a consequence of the latter, also acid splash damage from
other sources.

--------------------------------------------------------------------------------
8471db9 | NormalPerson7 | 2019-01-20 20:59:50 -0500

Indicate spell damage with exclamation marks and "...but does no damage"
Use varying numbers of exclamation marks to indicate the amount of
damage done by direct-damage spells that pass through zapping(), in the
same way as is done for melee and ranged attacks, and print
   "<beam> hits <actor> but does no damage."
to the message log when a beam does no damage, in the same way as is
done for melee attacks.

This behaviour was previously inconsistent: some beam types printed
"%s appears unharmed" for monsters when they were hit for no damage,
others simply printed nothing, and this message was never printed
when the player was hit by a beam for no damage. These inconsistent
"%s appears unharmed" messages are removed in this commit.

This largely eliminates a long-running inconsistency in the output of
spells vs melee attacks.

There are various other instances of spell damage messages scattered
throughout the code that should also be converted in the future.
These include torment effects, damage-over-time effects, and clouds.

Also remove the "Helpless, you fail to dodge..." message for when you're
paralysed, because there is no clean way to include this in the new
system, it doesn't say anything especially meaningful (the player knows
they're paralysed), and it also awkwardly triggered when in tree form.

Finally, remove an unnecessary variable and replace it with explicit
return true; / return false; statements where it was used.

--------------------------------------------------------------------------------
f4b81dc | floraline | 2019-01-20 15:55:40 -0500

Add webtiles form to change user email
This commit adds a form to the webtiles lobby for logged in users
to change the email address associated with their account.

[Committer's note: closes #791, closes #800, closes #910]

--------------------------------------------------------------------------------
b20feef | floraline | 2019-01-20 15:35:29 -0500

Add option to disable gzip in webtiles

--------------------------------------------------------------------------------
5904884 | floraline | 2019-01-20 15:33:35 -0500

Use X-Forwarded-Proto header for websocket protocol
If the webtiles server is running behind a proxy server
which terminates SSL connections, and http is used between
the proxy and webtiles, the X-Forwarded-Proto header can be
set by the proxy to indicate to the webtiles server that the
client is using a secure connection. This allows webtiles to
generate the correct protocol wss:// even it sees http.

--------------------------------------------------------------------------------
d21de94 | Edgar A. Bering IV | 2019-01-19 23:18:53 -0500

Correct yaml aptitudes and stat gains
More errors than I expected. I merged datafiles without looking closely,
thinking that previous reviewers had done a more thorough check. This
time I didn't leave it to chance, and diffed the aptitude table as
reported by crawl from 0.22 to post merge. The aptitudes are now
reported faithfully. I did a hand double check on the stat-ups, flags,
and mutations; I'm confident in them but not as certain. Additional eyes
would be appreciated.

--------------------------------------------------------------------------------
d38242e | Edgar A. Bering IV | 2019-01-19 20:00:25 -0500

Correctly choose draconian colour
The initial datafiles implementation was searching for a starting
species that was not base draconian and was a draconian; there are no
such species, which caused an infinite loop on level up. Instead of
ad-hoc methods, species.cc now includes a specific draconian colour
chooser.

--------------------------------------------------------------------------------
2e5916d | Edgar A. Bering IV | 2019-01-19 19:00:00 -0500

Fix an ASSERT when generating playable-json

--------------------------------------------------------------------------------
c1268f8 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Update control
python dependency is implicit
--------------------------------------------------------------------------------
30cc324 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Add python deps to debian build dependencies

--------------------------------------------------------------------------------
5dd6e8c | advil | 2019-01-19 16:49:04 -0500

Fix up an error message I missed

--------------------------------------------------------------------------------
0781eb4 | advil | 2019-01-19 16:49:04 -0500

Relax python version requirements
This runs safely on anything that can handle the from __future__ call,
so no need to be picky.

--------------------------------------------------------------------------------
a3ee95e | advil | 2019-01-19 16:49:04 -0500

Handle levelup stats in a cleaner way
Now, the empty list gives you the empty list, and the default value is a
string (`default`), not a list. This also changes the species levelup
code to check that the iterator is safe to use.

--------------------------------------------------------------------------------
822cbb9 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Simplify MSYS2 pyyaml instructions (gammafunk)
[skip ci]

--------------------------------------------------------------------------------
eec6720 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Add PyYAML install instructions for MSYS2

--------------------------------------------------------------------------------
3e18421 | Kyle Rawlins | 2019-01-19 16:49:04 -0500

Doc updates

--------------------------------------------------------------------------------
10df540 | advil | 2019-01-19 16:49:04 -0500

Warn on unknown fields in the main list of species properties
This would have partially caught the undead thing, since mummy was using
the wrong field name relative to the python code. This implementation is
not very elegant, but it works for now.

--------------------------------------------------------------------------------
24c7ebc | advil | 2019-01-19 16:49:04 -0500

Handle demigod stats properly
Also, I changed the formatting for lists to match what species-data.h
currently does. I actually think the indented version looks a bit
better, but keeping it this way for now makes debugging a lot easier.

--------------------------------------------------------------------------------
cb8200b | advil | 2019-01-19 16:49:04 -0500

Add walk/pray verbs to SP_UNKNOWN and deprecated species
A little surprised this compiled without these, but given that it did
this change may be cosmetic.

--------------------------------------------------------------------------------
f84f214 | advil | 2019-01-19 16:49:04 -0500

Fix undead type
This was broken/incomplete for all three undead species

--------------------------------------------------------------------------------
cbc76c4 | advil | 2019-01-19 16:49:04 -0500

Don't set recommended weapons for non-starting species
Matches current practice in non-generate species-data.h

--------------------------------------------------------------------------------
e614946 | advil | 2019-01-19 16:49:04 -0500

Add entry format description to header for species-data.h
Still want this to be there for debuggin purposes

--------------------------------------------------------------------------------
c13e1a1 | advil | 2019-01-19 16:49:04 -0500

Handle empty mutation lists a bit better

--------------------------------------------------------------------------------
e5a3aee | advil | 2019-01-19 16:49:04 -0500

Make build dependencies more specific

--------------------------------------------------------------------------------
09c36ad | advil | 2019-01-19 16:49:04 -0500

Don't inherit from dict, use constructor instead of factory function
There's various reasons why inheriting from dict can be a bad idea, but
the basic issue is that you get a ton of weird internal stuff in your
subclass, leading to long-term maintainability issues. Here's a useful
summary: 
http://www.kr41.net/2016/03-23-dont_inherit_python_builtin_dict_type.html

Also, especially with this change I couldn't see any reason to prefer a
factory function over a constructor, and it's more pythonic to use the
latter when possible.

--------------------------------------------------------------------------------
8f32865 | advil | 2019-01-19 16:49:04 -0500

Format/refactor for 80 columns
Also prefer @classmethod to @staticmethod, a few other misc changes.

--------------------------------------------------------------------------------
9c501a8 | advil | 2019-01-19 16:49:04 -0500

Change species generation to python 2.7
Seems to work unchanged. May or may not force pyyaml dependency to be
explicit.

--------------------------------------------------------------------------------
0008194 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

more fixes
* move filter_enum to its own file
* random_species -> random_starting species (and ditto for job)
* Don't pick non-starting species/jobs for random/viable selection

--------------------------------------------------------------------------------
9f4de6a | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

various bug fixes to newgame species/job selection

--------------------------------------------------------------------------------
c914ae4 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

De-duplicate VIABLE/RANDOM newgame species/job logic

--------------------------------------------------------------------------------
5865f6a | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Use filter_enum instead of do-while loops.

--------------------------------------------------------------------------------
65b99ee | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

species: Make difficulty mandatory

--------------------------------------------------------------------------------
57a5c52 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Document species/jobs missing recommendations
No recommendations = not available on the starting screen.

--------------------------------------------------------------------------------
3f38706 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Clean up random/viable character selection
Simplify the selection logic and make it consistent between species and
background.

--------------------------------------------------------------------------------
bb98c16 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Generate species data from YAML files
This converts the following files from hand-written to auto-generated:

* aptitudes.h
* species-data.h
* species-groups.h (was previously hardcoded in newgame.cc)
* species-type.h

Species definitions are found in `source/dat/species/*.yaml`.
Documentation is in the (rewritten) `docs/develop/species_creation.md`.

--------------------------------------------------------------------------------
1e5a400 | Alex Jurkiewicz | 2019-01-19 16:49:04 -0500

Simplify XL7 draconian randomisation
Removes SP_FIRST/LAST_NONBASE_DRACONIAN. These are only used in two
places, when a draconian species flag can serve the same purpose.

--------------------------------------------------------------------------------
30113ee | Edgar A. Bering IV | 2019-01-19 12:56:48 -0500

Nothing is not permitted in kfeat

--------------------------------------------------------------------------------
9eba094 | Edgar A. Bering IV | 2019-01-19 12:37:44 -0500

A circus upstair vault
A grouping of three circular arenas, each placing a stair in the center
surrounded by themed choices from the Zot monster set to suggest a
circus. The theme sets are:

- Firebreathers: red draconians and red draconian scorchers
- Strongman and contortionists: one juggernaut and tentacled
monstrosities
- Magic act: an ancient lich and electric golems
- Acrobats: grey draconians, grey draconian monks, and nets
- Beasts: moths and dragons
- Freakshow: death cobs and possibly a curse toe
- Jugglers: draconian shifters and draconians (being juggled!)
- Killer Klowns, what would be a circus without them

--------------------------------------------------------------------------------
b55f120 | Edgar A. Bering IV | 2019-01-19 12:37:44 -0500

A klown carousel stair vault
A circular vault featuring klowns, dispersal traps, and Skrybe's
coloured glass. A carousel of madness, the entry is so that a
mistake pulling monsters out could get the player blinked in. Inside
there are places to take cover from the onslaught of pies, but the
dispersal traps remain an issue for the player. The vault can place as
either a downstair vault or an upstair vault. As an upstair vault the
player starts in the place of one of the carousel seats.

--------------------------------------------------------------------------------
1815e75 | Edgar A. Bering IV | 2019-01-19 12:37:44 -0500

Rename a lua function

--------------------------------------------------------------------------------
e8b0c57 | gammafunk | 2019-01-19 09:48:09 -0600

Rework trap placement on Tomb:3
In the large central Tomb:3 vaults, place about 12 traps on-average.
This is enough to add some hindrance for the player as they move and fight
through the central area without being overwhelming.

Mechanical traps were removed from the treasure rooms on Tomb:3, but
numbers of traps as a whole weren't changed, so alarm/dispersal/zot
traps became 2.5 times as common. This commit reduces numbers of traps
in the treasure rooms overall, still leaving a higher trap density
compared to the central rune areas. This trap placement can now also
occur in the initial hallway where the player arrives on Tomb:3.

Also use normal '.' glyphs for the treasure room and refactor DES of the
main map.

--------------------------------------------------------------------------------
9c7b33d | gammafunk | 2019-01-19 09:48:09 -0600

Reduce trap placement on Tomb:2
Tomb:2 currently places about 40 traps randomly in the first section of
rooms that lead back to Tomb:1 and about 47 in the smaller section of
rooms that lead to Tomb:3. When mechanical traps were mostly removed
from Tomb:2, these numbers weren't adjusted, so the more impactful
alarm/dispersal/zot trap types went from being 30% of traps to being 75%
of traps. This made Tomb:2 very chaotic.

This commit halves the trap placement rate in the first section, getting
us down to about 20 traps on-average, and reduces it by about 55% in the
second section, getting us down to about 21 on-average. These numbers
give a few traps in each room and won't overwhelm all other tactical
considerations.

Additionally we now handle trap placement in the central ambush vault
directly, placing about 8 traps on-average in these areas. These vaults
are large, but have lots of monsters with exits and good cover not being
close by, so relatively few traps is appropriate here. Finally, disable
level trap generation on Tomb:2, since we control trap placement in all
areas of the map.

--------------------------------------------------------------------------------
abe354a | gammafunk | 2019-01-19 09:43:56 -0600

Add trap placement to Tomb:1 hallway end vaults
The Tomb:1 hallway end vaults contain the arrival hatch into the Tomb:1
hall from Tomb:2 at one end and the exit hatch into the second section
of Tomb:2 on the other end. In these vaults add small numbers of traps
as appropriate for their smaller size, about 6 on average. Also reglyph
the vaults to use the usual '.' for floor, as there's no need to use a
special glyph.

--------------------------------------------------------------------------------
cd6f52c | gammafunk | 2019-01-19 09:35:46 -0600

Rework trap placement in Tomb:1 central vaults
For the center vaults on the Tomb:1 map that contain the hatches to the
Tomb:2 ambush, add some limited trap placement. We add about 12 traps
on-average, which is a reasonable number for the large size of these
vaults. Alarm traps get lower weight, since having a lot of these traps
makes it easier to empty monsters out of the vault into safer areas of
the level.

In tomb_1_centre_old, don't have an extra chance to block single-tile
passages with traps, but put some traps in corners where they can be
walked past. Also rework the placement of monsters in this vault to not
use many scattered fixed locations. Randomize placement of all but the
highest tier guardians, keeping the monster counts the same.

--------------------------------------------------------------------------------
a5e88f8 | gammafunk | 2019-01-19 06:56:08 -0600

Add traps to the Tomb:1 hallway and reorganize
This commit adds small numbers of traps to the Tomb:1 "gauntlet" reached
from Tomb:2 after the ambush, about 6 on-average. Also reorganize
sections and update comments for the main Tomb:1 map.

--------------------------------------------------------------------------------
adbfc09 | gammafunk | 2019-01-19 06:42:30 -0600

Add organizational headers to tomb.des

--------------------------------------------------------------------------------
dc19b93 | advil | 2019-01-18 15:45:42 -0500

Fix two problems in unrest.pl
1. The script didn't support non-numbered links.
2. The regex for numbered links, because it has an s flag, matched a
non-numbered link that is at the end of a sentence. Very ad-hoc
solution: prevent a match on _ as the first character of a link.

This script goes back a long ways but really we shouldn't have our own
rst "parser" in 2019...

--------------------------------------------------------------------------------
6cd010e | Alan Malloy | 2019-01-18 12:29:42 -0800

Fix typo (NormalPerson7)

--------------------------------------------------------------------------------
73c39a4 | Alan Malloy | 2019-01-18 12:14:59 -0800

Copy edit background section of the manual

--------------------------------------------------------------------------------
46380d4 | Alan Malloy | 2019-01-18 12:06:51 -0800

Copy-edit changes to species description section

--------------------------------------------------------------------------------
1fcf643 | advil | 2019-01-18 14:49:08 -0500

Editing/reorganizing pass through backgrounds
This brings the background appendix to the manual in line with the order
and categories in the newgame menu (in this case, the previous version
was actively inconsistent with it). I also tried to ensure some minimal
standard level of completeness in terms of describing starting equipment
for each background. (Remaining inconsistency: starting spell isn't
always made explicit, though the book is.)

--------------------------------------------------------------------------------
3cc1399 | advil | 2019-01-18 14:20:23 -0500

Editing/reordering pass for the species appendix of the manual
I'm not sure what previously determined the order of species in this
section, but it was kind of idiosyncratic. I have reordered the species
to match the order on the newgame menu, and explicitly included the
categories used in selecting a new character. I also took an editing
pass over the text and made a few tweaks that hopefully will address
common questions about species selection, including the misconception
that order on that menu is about difficulty of winning.

(An alternative would have been to simply alphabetize this section, but
probably the most likely case where players will look at it, at least
after the fix in 146c4415506c6f, is when hitting ? from this menu.)

--------------------------------------------------------------------------------
7db0834 | advil | 2019-01-18 13:10:25 -0500

Show sprint manual section in sprint newgame menu

--------------------------------------------------------------------------------
aaf14ca | advil | 2019-01-18 12:42:43 -0500

Show version history in `?v` if a save has been upgraded
Otherwise, to see this you previously needed to either crash the game,
or piece together the upgrade steps from milestones.

--------------------------------------------------------------------------------
a1c2b65 | advil | 2019-01-18 12:42:43 -0500

Fix a help bug that isn't triggered
`show_help` takes a section argument that is supposed to basically do
what hitting a key from the main help menu would accomplish. There was
untested code for the special case section keys that didn't actually
work, leading to a blank screen. This lets `show_help` handle these
section arguments (e.g. `v`) correctly, in case someone ever wants to do
this.

--------------------------------------------------------------------------------
4cc9efd | advil | 2019-01-18 12:42:43 -0500

Show item help in newgame weapon menu
instead of the key quick reference? This would be better if it scrolled
directly to the weapons subsection but there's no quick way to do that
yet.

--------------------------------------------------------------------------------
146c441 | advil | 2019-01-18 12:42:43 -0500

Handle pre-scrolled help screens correctly
This fixes the bug where help in character selection is not going to the
correct help subsections (for species/background info).

--------------------------------------------------------------------------------
517b432 | mgdelmonte | 2019-01-17 22:00:02 -0500

Create a CLua function for spell targeter access
This commit adds a clua function spells.path to report the path taken by
a spell. Crawl's spell targeting mechanics are very complex, and
without a function like this, proper Lua spell-casting assistance is
hampered by the fact that it's impossible to know whether you can
actually hit any given target, or what monsters will be hit by a spell.

Given a spell name and target x,y in player-centered coordinates, this
function returns the actual path that the spell would take, in a table
of pairs { {x1, y1}, {x2, y2}, {x3, y3} } (also in player-centered
coordinates). This makes it possible to know whether the spell will hit
its target, and (for bolt spells) what monsters it might hit along the
way.

The function also takes an optional source coordinate, to assist in
automating reasoning about monster spells.

[Committer's note: Closes #939]

--------------------------------------------------------------------------------
db21e03 | Edgar A. Bering IV | 2019-01-17 20:28:49 -0500

Reduce silence radius from Klown pies
Monster silence is replaced with mute, as monster silence is full radius
(5) for all but the last 3 turns of its duration. Player silence is
reduced to 4+random2(7) turns, with a cap of 10. This means the player
will have at most four turns with a silence radius of 1, followed by 6
turns of radius 0.

The silence effect is strong, and primarily aimed at disabling the
player. The monster silence effect meant that instead of being able to
use a consumable or be stuck a player could be left in an awkward
situation of wanting to kill an ally to break the silence. On the flip
side, silence is strong against ancient liches and the draconian
spellcasters in the zot monster set. The anti-synergy between klowns and
these monsters hass the potential for if not abuse, at least strange
incentives.

Reducing the silence duration is also a nerf to the new klown pie
effect; maintaining the old duration without having a large silence
radius would require a new status effect.

--------------------------------------------------------------------------------
f2270e3 | Edgar A. Bering IV | 2019-01-17 19:39:01 -0500

Enable god Extra in describe_god_with_join
The describe_god_with_join pane has a distinct implementation from the
standard describe_god ui, which assumed that there were always only 3
god panes. This is generalized to support displaying the Extra pane when
kneeling at an altar if relevant.

--------------------------------------------------------------------------------
809c088 | Edgar A. Bering IV | 2019-01-17 19:39:01 -0500

Hide some god Extra panes from non-worshippers
Every god Extra pane except Wu Jian's currently provides worshippers
with information about their religious practice that is not helpful to a
potential follower.

--------------------------------------------------------------------------------
2dd2dce | Edgar A. Bering IV | 2019-01-17 19:39:00 -0500

Only list seen branches in Gozag's Extra pane (advil)
This matches the display of branches in the Overview screen. The
previous behavior, of only hiding the Lair branches until they've been
discovered, was a bit awkward.

--------------------------------------------------------------------------------
c05403b | advil | 2019-01-17 19:39:00 -0500

Code formatting
Missed some unbracing.

--------------------------------------------------------------------------------
8732018 | advil | 2019-01-17 19:39:00 -0500

Remove commented code
Missed this on the earlier commit.

--------------------------------------------------------------------------------
6f75a6c | advil | 2019-01-17 19:39:00 -0500

Code formatting, wording

--------------------------------------------------------------------------------
5b2007c | advil | 2019-01-17 19:39:00 -0500

Add god extra pane to webtiles
Would be nice someday to not have to hardcode every pane.

--------------------------------------------------------------------------------
f2a872a | Edgar A. Bering IV | 2019-01-17 19:39:00 -0500

Add a god Extra pane for Wu Jian
Move the description of martial attacks to the Extra pane.

--------------------------------------------------------------------------------
710303d | Edgar A. Bering IV | 2019-01-17 19:39:00 -0500

Add a god Extra pane for Nemelex
Lists the quantity of cards in each deck plus the stack contents.

--------------------------------------------------------------------------------
550063b | Edgar A. Bering IV | 2019-01-17 19:39:00 -0500

God Extra panes for Ash, Gozag, and Hep
Move information about skill boosts, bribeability, and ancestor
information; previously in _get_god_specific_table and included on the
Powers pane to the newly created Extra pane in the god description menu.

--------------------------------------------------------------------------------
bfe4a4d | bjobae | 2019-01-17 19:39:00 -0500

Future proof Beogh gift monster props

--------------------------------------------------------------------------------
509b01f | bjobae | 2019-01-17 19:39:00 -0500

List named followers for Beogh worshippers
The 'Extra' pane of Beogh's god info screen lists all named
followers and those items which were gifted to them by the player.

--------------------------------------------------------------------------------
1a98732 | bjobae | 2019-01-17 19:39:00 -0500

Add support for an 'Extra' pane in religion screen
For those gods for which '_god_extra_description(god_type)'
returns a nonempty string, a pane called 'Extra' is made
available in the religion screen, displaying the content of
that string.

--------------------------------------------------------------------------------
38971ea | gammafunk | 2019-01-17 16:06:33 -0600

Change the Singing Sword's power for monsters (ebering)
Don't base it on tension, since that's information about the player, and
the player may not even be in LOS. Just use the first power tier
instead.

--------------------------------------------------------------------------------
2dde14e | NormalPerson7 | 2019-01-17 17:05:34 -0500

Add a note to docs/obsolete/cut_spells.txt
This commit adds a note to the top of the file to outline the changes
made to spell definitions since the spells in this file were cut from
the code - the most recent of which occurred in 2012 when
TAG_MAJOR_VERSION was last incremented.

--------------------------------------------------------------------------------
c3062a4 | NormalPerson7 | 2019-01-17 17:05:34 -0500

Convert `enum recall_t` to an enum class

--------------------------------------------------------------------------------
76aa57b | NormalPerson7 | 2019-01-17 17:05:34 -0500

Convert `enum miscast_source` to an enum class
Convert the enum `miscast_source` to an enum class. The name of the enum
is unchanged. Wrap all lines made too long, as always.

--------------------------------------------------------------------------------
c88e511 | NormalPerson7 | 2019-01-17 17:05:34 -0500

Add a struct to use for MiscastEffect::special_source
Create a new struct miscast_source_info to use for passing a miscast's
source and if the source was miscast_source::god, the god that caused
it, instead of the previous system of using one int member variable for
two meanings. Update all calls to MiscastEffect, all uses of the
special_source variable inside the MiscastEffect methods, and the
MiscastEffect::MiscastEffect initialisation function and class
declaration, to use this new struct.

This should be no less obvious than in the previous implementation while
ensuring type security; intentionally adding enum values of two
different types as in the previous implementation is poor.

This is necessary in order to convert the miscast_source enum to an enum
class, since adding an int (god_type) to an enum class type causes
compilation errors. This conversion takes place in the following commit.

--------------------------------------------------------------------------------
b067b0d | NormalPerson7 | 2019-01-17 17:05:34 -0500

Convert `enum nothing_happens_when_type` to `enum class nothing_happens`
Convert the nothing_happens_when_type enum to an enum class and shorten
its name to nothing_happens. This continues the conversion of several
spell-related enums to enum classes.

This enum is quite small and the effect of changing it is similarly
small. No change in logic was required in this commit; only a couple of
line breaks were made where lines were made longer.

The enum class' member names remain capitalised for this enum class
because if made lowercase I am worried about `default`, a keyword in
C++, being redefined.

--------------------------------------------------------------------------------
a6713cf | NormalPerson7 | 2019-01-17 17:05:34 -0500

Convert `enum spschool_flag_type` to `enum class spschool`
Convert spschool_flag_type to an enum class and rename it to a much
shorter name `spschool`, which adequately describes the enum's contents.

Note that the LAST_SCHOOL value in this enum class is capitalised as it
is designed to be a constant value and so we capitalise it in accordance
with other constants.

Fix all errors caused by attempting to implicitly cast spschools to
integers: either use static_cast or an explicit C-cast in these cases.

Wrap all lines that were made too long by this commit and the
lengthening of enum values from e.g. SPTYP_NONE to spschool::none by 4
characters. Realign variable definitions spanning multiple lines whose
alignment was interfered with by the changing of the enum class name,
and de-wrap some of these that will now fit on one line.

This commit does not update SPTYP_s in
crawl-ref/docs/obsolete/cut_spells.txt. In a future commit, I will add a
note referring to these outdated enum values to the header of this file.

--------------------------------------------------------------------------------
c3daa31 | NormalPerson7 | 2019-01-17 17:05:34 -0500

Convert `enum spflag_type` to `enum class spflag`
Change spflag_type to an enum class and rename it to spflag in
accordance with other such enum -> enum class changes (for example
abflag_type -> abflag, spret_type -> spret).

Add a new bitfield type called `spell_flags`, which is to be used for
bitfields composed of the various spflags in place of the previous
system which was using unsigned integers. This is a significant
improvement to Crawl's type safety.

Fix all issues related to implicit casting of (spell_flags & spflag)
to a bool in a return statement or variable definitions, by either
explicitly casting to a boolean or, more preferably, using the testbits
function - these would otherwise cause compilation errors now.

Wrap all spell_flags lines in spl-data.h that now exceed the line limit
of 80 characters due to the additional character (caused by changing _
to :: in enum value names) per enum value.

This commit does not change SPFLAG_... to spflag::... in comments
referring to removed enum values in the spflag enum class definition,
nor does it change SPFLAG_s in crawl-ref/docs/obsolete/cut-spells.txt.

--------------------------------------------------------------------------------
e7febcc | gammafunk | 2019-01-17 06:42:07 -0600

Sometimes place the Singing Sword in a vault
The classic sword_in_stone vault places a sword "sealed" in stone
(actually diggable rock), with the sword being a dancing one in later
levels. Have a 1/50 chance of this sword being the Singing Sword, making
it dance when appropriate.

--------------------------------------------------------------------------------
5913316 | gammafunk | 2019-01-17 06:42:07 -0600

Allow monsters to use the Singing Sword
It's not necessary to prevent them from using this weapon now that the
spell code has been refactored. Although they'll damage other monsters
in LOS with the sword's spell damage, this damages the player as well.
This is still a weapon the player wouldn't want to use with Spectral
Weapon, since the spectral sword's Sonic Wave will damage the player.

--------------------------------------------------------------------------------
cf8a540 | gammafunk | 2019-01-17 06:42:07 -0600

Revamp the Singing Sword again
The current sword has tiers derived from tension to determine the chance
to cast its Sonic Wave spell. There are four tiers, with the sword's
spell only being cast starting at tier 3, which corresponds to at least
40 tension. It's less common to be at tier 3 during combat, since this
needs many difficult monsters to be in view. Since the sword's spell
isn't cast below tier 3, its damage is equivalent to a +7 vorpal double
sword in most fights. While doing the rework in 2a92f5cd, fsim lead me
to overestimate the sword's damage below tier three, since it was
setting high tension regardless of what was in LOS at the time.  This
commit changes how the tiers are calculated, how frequently Sonic Wave
is cast, and increases Sonic Wave's damage.

The tiers are now calculated as max(1, min(4, 1 + tension / 20)),
meaning that they increase every 20 tension with tier 1 being tension
less than 20 and tier 4 being tension 60 or higher. This makes tiers
above 1 easier to reach in typical combat situations. Previously tier 4
could only be reach if tension was at least 40 and a random roll
succeeded. Most importantly, the sword will now cast its spell below
tier 3, doing so with 1/4 chance at tier 1 and 3/8 chance at tier 2. It
casts 50% of the time at tiers 3 and 4, just as it was before.

The damage die for Sonic Wave are increased and small bonuses are given
for the sword's spell-power at each tier, instead of only at tier 4.
Tier 4 receives a large additional bonus, as it did before. Collectively
these changes make the sword do about -10%, +0%, +10%, and +20% damage
at tiers 1 through 4, respectively, compared to a +9 double sword of
speed. The noise levels at each tier are unchanged, with tier 4 being as
loud as the shield of gong.

--------------------------------------------------------------------------------
0b75920 | Edgar A. Bering IV | 2019-01-16 23:09:16 -0500

checkwhite (Stenella)

--------------------------------------------------------------------------------
94ec030 | NormalPerson7 | 2019-01-16 16:14:31 -0500

Fix monsters not being woken when hit by animated trees (11819)
This commit adds a call to behaviour_event to, among other things, wake
sleeping monsters, when they are attacked by an animated tree from
summon forest and the attack hits (regardless of any damage dealt).

--------------------------------------------------------------------------------
06a100f | NormalPerson7 | 2019-01-16 13:49:33 -0500

Don't let battlespheres be blinded (11827)
Battlespheres are insubstantial magical constructs, and thus do not see
with eyes. It therefore makes no sense for them to be able to be
blinded. Therefore, add the M_UNBLINDABLE monster flag to their
mon-data.h entry.

--------------------------------------------------------------------------------
19699f6 | NormalPerson7 | 2019-01-16 13:40:19 -0500

Fix death channel duration leak when cast at max duration (11828)
Simply remove the check in cast_death_channel for returning spret::abort
when at max duration. The information that the player has maxed out
their duration is not given to the player for other spells, and so
should not be given for death channel.

--------------------------------------------------------------------------------
9fa1570 | advil | 2019-01-15 18:30:54 -0500

Fix a bug in util.formatted_string_to_html
This would appear to be a >5 year-old bug that appends an extra </span>
any time a color is correctly terminated. (Luckily it seemed to mostly
be getting fixed up on append calls? I found it because the fixup will
eat whitespace, potentially messing with preformatted text.)

--------------------------------------------------------------------------------
0a1bb4f | advil | 2019-01-15 18:30:54 -0500

Handle ?/ better, generalize range "key" to webtiles
From previous commit messages for this change, I gather that the
assumption was that if mon_owner is null, there is not an actual
corresponding monster. This doesn't seem to be correct -- mon_owner is
null if this codepath is called on an item (does this ever happen?). The
best check for whether this mons_info corresponds to a real monster is
whether the position is in bounds (and crawl_state.need_save for whether
the player is in a game).

I moved the text explaining the hex percent and range out of
describe_spellset, so that it is visible on webtiles. I *think* that
this is the only way this code path is called when showing monster
spells; otherwise, describe_spellset is (or maybe isn't any more?)
called on items.

--------------------------------------------------------------------------------
0b8caf7 | advil | 2019-01-15 18:30:54 -0500

Generalize range string logic for webtiles
This computation got complicated enough that it should only be done in
one place.

--------------------------------------------------------------------------------
4d4c92e | advil | 2019-01-15 18:30:54 -0500

Various small tweaks
* explain red coloring in the key
* don't show range for spells with SPFLAG_SELFENCH, which are
  basically not treated as ranged on monsters. In practice, this may
  exclude only invisibility. (N.b. all monster spells that have this
  flag and could in principle be cast on allies have an _OTHER
  counterpart anyways. SPELL_INVISIBILITY_OTHER doesn't seem to be
  used.)
* code formatting

--------------------------------------------------------------------------------
99592df | Edgar A. Bering IV | 2019-01-15 18:30:54 -0500

Remove ranges from Haste and Might
Monster AI always uses these spells as self enchants, with Haste Other
and Might Other existing for monsters to affect allies. The ranges are
vestigal from when these were player spells, and cause bogus displays of
spell range for monsters with these spells.

--------------------------------------------------------------------------------
8ac9f62 | Edgar A. Bering IV | 2019-01-15 18:30:54 -0500

Add spell ranges to monster info in webtiles

--------------------------------------------------------------------------------
32e1316 | Edgar A. Bering IV | 2019-01-15 18:29:16 -0500

Only display ranges in monster descriptions
They're not needed in book descriptions, a player who is unfamiliar with
a given spell and considering a book item will want to know all about
it, not just its range.

--------------------------------------------------------------------------------
e15ba66 | Edgar A. Bering IV | 2019-01-15 18:29:16 -0500

Improve colour handling for spell ranges
The first implementation did not parse the colours into the formatted
string at the moment of adding (a gotcha with
formatted_string::cprintf). Here we replace the formatted_string::cprintf call
with an operator += concatenation. This makes spell displays render in
webtiles again.

--------------------------------------------------------------------------------
c9aa113 | Aidan Holm | 2019-01-15 18:29:16 -0500

Right-align hex-chance in monster spell list

--------------------------------------------------------------------------------
d70207d | Aidan Holm | 2019-01-15 18:29:16 -0500

Use colour to differentiate in/out-of-range

--------------------------------------------------------------------------------
6d93017 | Aidan Holm | 2019-01-15 18:29:16 -0500

Add hex-chance and spell-range explanatory text

--------------------------------------------------------------------------------
ab26df7 | Sandman25DCSS | 2019-01-15 18:29:16 -0500

Display range for spells in monster description (aidanh)
Please see
https://crawl.develz.org/tavern/viewtopic.php?f=8&t=23901
No colors yet, I am not sure how to do it properly.

--------------------------------------------------------------------------------
00c90a0 | Edgar Bering | 2019-01-15 13:01:39 -0500

Save compat for c89a89d9 (11829)

--------------------------------------------------------------------------------
e59bbb1 | Edgar A. Bering IV | 2019-01-15 00:29:11 -0500

Display (immune) in monster hex chance in webtiles
Commit b5b85be8 added this functionality to console and local tiles.

--------------------------------------------------------------------------------
3a644c0 | Edgar Bering | 2019-01-14 18:30:48 -0500

Remove grate traps
Now that traps are revealed grate traps do less than what they previously
did, in that a spoiled player knows to simply take another stair. Spoilers or
not, once the grate is down a player can use the grate and a smite targeted
spell to kill monsters at no risk to themselves.

--------------------------------------------------------------------------------
c89a89d | Edgar Bering | 2019-01-14 18:27:38 -0500

A Klonw Kar trap for Zot
Generalize the basket of spiders trap to be a monster-drop trap.
Then add the trap to Zot but have it drop Killer Klowns. Also change the
snake version to drop a mix of mambas and mana vipers.

The basket traps work ok as tactical terrain even with traps revealed,
since a monster triggering the trap will still release a player-targeting
effect (more monsters).

--------------------------------------------------------------------------------
aad00d0 | gammafunk | 2019-01-14 15:54:16 -0600

Changelog through 0.23-a0-709-gaefc81b7b9

--------------------------------------------------------------------------------
aefc81b | gammafunk | 2019-01-14 02:30:37 -0600

Update loot in a Gauntlet exit vault
The vault nicolae_gauntlet_exit_dead_adventurers is themed as having the
corpses and loot of four dead adventurers that failed to defeat the
minotaur. The loot items are appropriate for the archetypes character
represented by the given corpse. For example, a spriggan stabber
with a short blade weapon and a hexes randbook. Unfortunately the
current version of this vault doesn't place very good loot, despite
placing more items on-average compared to the other Gauntlet exit
vaults. It uses mostly normal quality, common items with only a few
choices to represent weapons and armour, and with few consumables
on-average.

This commit revamps the loot to place better quality items with much
more variety, but still keeping the theme of each adventurer to the best
extent possible. Item quantities are randomized so that the min, max,
and average numbers of items placed are very similar to the other
Gauntlet exits. More consumables, jewellery, evokables, and aux armour
items are also introduced. The Dwarf Earth Elementalist in heavy armour
corpse became a Felid Transmuter corpse with items appropriate for
Transmutations and unarmed combat, since heavy armour was already very
well represented in the loot.

--------------------------------------------------------------------------------
b957dac | gammafunk | 2019-01-14 02:30:37 -0600

Use runed clear doors in Gauntlets
For arenas that use rune doors, make these transparent. They especially
make sense in the Gauntlet, where the rune doors are meant to be used by
the player to control monster movement.

--------------------------------------------------------------------------------
4e6f924 | gammafunk | 2019-01-14 02:30:37 -0600

Four 9x9 arena vaults for Gauntlets
These are subvaults used as 9x9 arenas. I'm hoping to have at least 20
of these before release, and this puts us at 18.

One vault with a narrowish two-way passage that has lots of corners to
maneuver around, one with three porous chambers, and two mazey arenas
with randomized pathways.

--------------------------------------------------------------------------------
c92f3ec | gammafunk | 2019-01-14 02:02:01 -0600

Decouple chances for Gauntlet loot upgrades
Make two independent chances for upgrading the aux armour and jewellery
loot item slots instead of one chance used for both. Add some comments
to the loot setup function.

--------------------------------------------------------------------------------
0e654d2 | Edgar A. Bering IV | 2019-01-14 02:23:19 -0500

Really remove Labyrinths (11820)
Mark labyrinths as "unfinished" in the branch_is_unfinished function,
joining Dwarf, Blade, and Forest on the list of removed branches. This
prevents a crash when lookup-help attempts to display an entry for the
removed branch.

--------------------------------------------------------------------------------
7fdf9c5 | Edgar A. Bering IV | 2019-01-13 21:36:35 -0500

Add clear doors to some Elf layouts.
A longtime TODO of infiniplex's, now implemented.

This commit adds them on the '~' glyph with a KFEAT; it is hoped that in
the near future the KFEAT line can be deleted and '~' made to default to
closed_clear_door.

--------------------------------------------------------------------------------
df2d5e0 | NormalPerson7 | 2019-01-12 12:29:28 -0500

Improve text when gaining/losing god abilities and on ^ screen
Improve the text printed to the message log when gaining or losing a
piety level and the text displayed on the god overview screen (^) such
that:
 - all text printed when the player gains a piety level contains the
   word "now", and is written either with "can", "will" or similar,
   or in the continuous present tense,
   e.g. "Kiku is now protecting you from torment";
 - all text printed when the player loses a piety level contains the
   words "no longer", and is written with either "can" or "will" or
   something similar,
   e.g. "Kiku will no longer protect you from torment"
 - all text on the ^ screen uses either "can" or the present tense,
   e.g. "Kiku protects you from torment".

This removes all poor constructions involving the use of the
continuous present on the ^ screen, and the continuous present without
the word "now" on gaining abilities - an example of this was
  "Vehumet is aiding your destructive magics", which becomes
  "Vehumet is now aiding ..." on gaining 2* of piety, and
  "Vehumet aids ..." on the ^ screen.

This is done by adding a new variable "general" to the god_power struct,
to differentiate between the text on the ^ screen and the text on
gaining the ability, which were previously the same unless the
"You can " construction was being used.

Also add messages for when Trog begins granting ammunition gifts and
when Jiyva begins granting corrosion resistance.

Also break several lines in the definition of the god_powers vector that
went beyond 80 characters because multiple parameters were placed on a
single line, or that did or did not go beyond 80 characters and had more
than two parameters split over two lines. This aims to improve
readability.

Finally, add a description of the "You can [now /no longer ]"
construction used for some god abilities, that is implemented in a
different way, to religion.h.

--------------------------------------------------------------------------------
d214142 | gammafunk | 2019-01-11 23:31:35 -0600

Stop dragon cruelty in a vault (howmanybefore)
Dragons were sealed behind clear stone walls in orc_legates. Items could
generate there and it was a teleport closet. We could mask this area
with no_tele_into and no_item_gen, but it's more interesting to add
clear runed doors and spruce up the dragon collection a bit, so do that
instead.

--------------------------------------------------------------------------------
d76f34b | Edgar A. Bering IV | 2019-01-11 22:24:16 -0500

Remove an extraneous article
Zap names are not expected to contain an article, so duplicate articles
were appearing.

--------------------------------------------------------------------------------
01d8f91 | gammafunk | 2019-01-11 20:18:42 -0600

Increase killer klowns' club enchantment
Setting the plusses of a mon_weapon_spec disables further property
settings for the given weapon, so these were getting fewer enchantment
than intended. Even with the usual chance for extra enchantment, it
would have been a low average with a high max. Instead set the enchant
range from 8 to 12 using one roll.

--------------------------------------------------------------------------------
ba807d0 | gammafunk | 2019-01-11 20:18:35 -0600

Slightly more klown pies
Increase the chance of a klown throwing a pie on one of its normal
actions from 8% to 12%. Play-testing has shown them to be pretty stingy
with pies, which, honestly...they should be more willing to share.

--------------------------------------------------------------------------------
260fa77 | gammafunk | 2019-01-11 19:21:18 -0600

Use the right spell flags for Throw Klown Pie
This previously used flags appropriate for a smite targeted spell, which
would have Klowns throw pies without the knowledge gained from using a
tracer.

--------------------------------------------------------------------------------
39acc7a | gammafunk | 2019-01-11 18:01:36 -0600

Rework trap and monster placement on Zot:5
This commit changes the hall_of_Zot vault on Zot:5 to rework some
placement distributions and logic. The monster count is unchanged and
the monster distribution is very similar to before, but a lot of the
placement logic is refactored. The changes to trap placement are more
substantial, as described below. In general, glyph usage and DES
statements have been refactored and comments have been updated.

Previously, the vault placed about 36 mechanical traps on-average,
additionally placing around 7 each for alarm, dispersal, teleport, and
Zot traps, for an average of 64 traps in total. After this commit, the
newly reworked net traps are the only mechanical traps to place in the
vault, and their numbers are brought inline with the non-mechanical
traps. We increase the number of traps for the remaining types to about
9 on-average for dispersal, net, teleport, and Zot, reducing the number
of alarms traps to about 5.5 on-average. Alarm traps have a big effect
on the vault as a whole when activated, so it's good to keep numbers of
these relatively small. The total average number of traps is now about
41.5.

The trap and monster placement logic has been changed to not rely on
fixed locations. In the old system, traps were scattered over many fixed
locations throughout the lower wings. In the upper wings, monsters sets
and traps were likewise scattered over fixed locations, but these were
fewer and more central. The new placement works similarly for placing
monsters, just without relying on fixed locations, and traps are allowed
to place in more locations in general. For the upper wing, we use a
large central square over which we place the guaranteed monsters and
monster sets. In each upper and lower section of both wings and in the
orb chamber, we now guarantee a minimum number of traps.

Previously, there was about a 33% chance to have a difficult trap
(alarm, dispersal, teleport, Zot) in both single tile passages leading
to the two lower wings. With the new trap placement, this chance of
having both entrances blocked by such traps is reduced to about 21%.

There was previously a 19% chance to get one or more orange crystal or
obsidian statues on the two outermost tiles of the line of floor
connecting a lower wing to its upper wing. This could only happen in one
wing and was based on another random roll used to determine the trap
chances for the lower wing entrances. This logic has been simplified, so
there's now a lower but independent chance for generating statue
monsters each wing. This makes the overall chance of seeing at least one
statue monster at any of these locations be 29%. Additionally traps can
now place at these locations as alternates to the statue monsters, using
the same low chance. Finally, since we carefully control trap placement,
I've disabled level trap generation inside the vault that would place
additional traps.

For the monster sets, the set for killer klowns has been updated to give
them all of the extra weight, as is already done for the ancient lich
and orb of fire sets. Previously some of that extra weight was given to
0 (normal level) spawns. Hence the number of klowns placed on-average in
the vault is up by a bit more than one, but the overall monster count is
the same.

--------------------------------------------------------------------------------
f95311e | Edgar Bering | 2019-01-11 16:48:26 -0500

Remove a possible teleport closet (11823)

--------------------------------------------------------------------------------
7bcdfeb | Edgar Bering | 2019-01-11 11:58:49 -0500

Correct a typo in monster pie effects

--------------------------------------------------------------------------------
178e528 | Edgar A. Bering IV | 2019-01-11 00:35:40 -0500

Remove mechanical traps from Tomb
Tomb used the '~' des glyph, one of the last places it is used
regularly. All uses have been replaced with kfeats, chosing
player-targeting traps (alarm, net, zot, and dispersal)
exclusively. The corridor blocking traps in Tomb:1 do not include
dispersal traps in their list for sanity's sake.

--------------------------------------------------------------------------------
2124650 | Edgar A. Bering IV | 2019-01-11 00:35:08 -0500

Adjust ossuary_the_hunt_dpeg
This ossuary has not worked for some time: zombies can't open doors. The
revelation of traps has made it even worse, as the "nasty" trap mode can
just be avoided by stepping around them.

The doors are removed and trap selection is revised, removing most of
the mechanicals. Net traps are now player-targeting, so are the lone
mechanical trap that is kept.

--------------------------------------------------------------------------------
0aaec43 | Edgar A. Bering IV | 2019-01-11 00:35:08 -0500

Adjust trap usage in some ossuaries
Now that traps are known, decorative traps can be removed. Corridor
mechanical traps are kept, since at the depths ossuaries generate they
provide obstacles to retreat.

--------------------------------------------------------------------------------
b058042 | Edgar A. Bering IV | 2019-01-11 00:31:32 -0500

Zot-ify net traps
Part of an incremental push to fully phase out mechanical traps. The
other mechanical trap effects don't make much sense to convert to
tactical terrain (flavoured damage), but nets do.

This commit does not return nets to dungeon generation, so these are
currently limited to the vaults that place traps.

--------------------------------------------------------------------------------
0a1fc62 | advil | 2019-01-10 17:10:46 -0500

Prevent recursion for `viewwindow`
Because this function resets a lot of display state, any recursion is
potentially bad news since the lower code on the stack than the
recursive call may have references that become invalid. However, it is
hard to call it a bug that this function can occasionally be called
recursively, since there are many ways to trigger it and they tend to be
necessary for some corner case or other. (It perhaps suggests some kind
of radically different approach to redraws, though.)

This change was specifically provoked by a series of crashes like:
https://underhound.eu/crawl/morgue/Skull/crash-Skull-20190109-202350.txt

More precisely, what was happening here is the following:
Preconditions: (a) the player had a custom autopickup function in their
rc that had a bug (and so caused a lua error, related to trying to check
if trunks were rotten in 0.22) when hungry. (b) they trigger a runrest
delay, e.g. by 5. (c) there is some pickup-able item in los. (d) tiles.

1. `viewwindow` is called normally during an `_input` cycle.
2. In order to render the tile with an item during this call, the game
needs to know if the object should trigger autopickup.
(`_tile_place_item` calls `item_needs_autopickup`.) It gets this
`item_def` from the global map (env.map_knowledge), and starts passing
it around by reference.
3. The autopickup hook errors, and crawl prints the error with mprf.
4. The printing of an error (immediately) interrupts the delay, which
eventually calls `runrest::stop`, which calls `viewwindow` again.
5. During this second call to `viewwindow`, `show_init` is called, which
clears out the (global) map. Somewhere along the line, on the tile with
the item on it, `update_tile_at` causes `map_call::clear` to be called
on that tile, which deletes any cloud/monster/item info stored in that
tile.
6. When flow gets back to the autopickup code, there is now an item_def
reference that is invalid (because it is a reference to something that
has been deleted). If this memory has been re-used, at this point, a
check on the item type will fail, leading to the crash seen in the log
above. (This in practice happens maybe 1 in 10 calls, and is quite
random.)

Morals? Side-effects are bad, and side-effects involving global state
are especially bad, but this sequence of events is so complicated and
involves so many core bits of crawlcode that I couldn't come up with a
reasonably-scoped, principled solution. Since some version of this has
potential to happen any time there is this recursion, I just prevented
the recursion altogether.

--------------------------------------------------------------------------------
3016822 | advil | 2019-01-10 17:10:46 -0500

Don't chop messages at 80 chars for chardumps/crashes
This probably comes up mainly for things like lua error messages. (An
alternative would be to not bother with 80 chars, which would make sense
for crashlogs, but not necessarily chardumps.)

--------------------------------------------------------------------------------
e64fb27 | Edgar Bering | 2019-01-10 15:42:45 -0500

unbrace and checkwhite

--------------------------------------------------------------------------------
b50ad93 | Jacob Meigs | 2019-01-10 13:37:28 -0500

Decouple hi-score logic from ouch (11431)
Update to print logic to pull from the hi-scores already in memory.
All entries are added to memory from the read when attempting
to add the entry.

[Committer's note: Closes #742]

--------------------------------------------------------------------------------
0964cf1 | Umer Shaikh | 2019-01-10 13:15:22 -0500

Fix information leak for invisible monsters (11815)
If the player wielded certain unrands that do damage to nearby actors on
attack, and had allies nearby, then they got a prompt for confirmation
when attacking. This prompt happened even if the player could not see
the enemy. So the location of the enemy was revealed, in no time, by the
player's trying to move into the cell. This commit changes that: the
player trying to move into a cell with an unseen monster will attack
without a prompt.

NB: now characters walking around with one of these weapons equipped and
without SInv may inadvertently anger their allies or their god.

--------------------------------------------------------------------------------
fe0cbb1 | Edgar A. Bering IV | 2019-01-10 08:46:44 -0500

Add Ge0ff to CREDITS

--------------------------------------------------------------------------------
b3bac08 | Edgar A. Bering IV | 2019-01-10 08:45:52 -0500

More permanent MP display (Ge0ff)
Adds the real max MP on the Abilities screen. This way the Cost column
will have, for example, "Permanent MP (10 left)" instead of just
"Permanent MP."

--------------------------------------------------------------------------------
80e34f1 | Edgar A. Bering IV | 2019-01-10 08:45:32 -0500

Fix coloring for current MP in Webtiles (Ge0ff)
The mp_colour .rc option has no effect in Webtiles due to a bug in the
percentage_color() function. The function wrongly assumes that the
player object has the real_mp_max property and tries to calculate MP
percentage using its undefined value.

--------------------------------------------------------------------------------
68c7d63 | Edgar A. Bering IV | 2019-01-10 08:44:50 -0500

Display real MP for Deep Dwarves when necessary (Ge0ff)
Deep Dwarves' Heal Wounds ability is the only one that requires real MP.
Even if the maximum MP is 0 because of an antimagic weapon or -MP items,
the player can still use the ability. Similarly, if the player has no
real magic points, but has +MP items, the ability cannot be used.

Currently it is not possible to check the real MP without taking
actions. Taking off items with +MP and -MP or switching weapons takes
time, and unequpping some items, e.g. Maxwell's etheric cage, has side
effects.

This patch adds real MP to the %-screen/morgue and to the HUD (only for
Deep Dwarves and only when real MP != max MP).

--------------------------------------------------------------------------------
26ad783 | Alex Jurkiewicz | 2019-01-09 20:08:09 -0500

Add unbrace and checkwhite to Travis
Also improves the output of `checkwhite -n`, using `unbrace -n` as a
guide. This should make it more informative for new contributors reading
Travis CI failed build logs.

[Closes #754]

[skip ci]

--------------------------------------------------------------------------------
356c24d | Edgar A. Bering IV | 2019-01-09 18:39:57 -0500

List johnstein under contributors also
Already in credits for running CBRO, give credit also for development
contributions.

--------------------------------------------------------------------------------
1a62673 | John Boyle | 2019-01-09 18:28:52 -0500

Remove an unused parameter from a function.
Based on some minor code archaeology, looks like there was a
big refactoring of the stairs logic in commit:

09e009602f11412cbc18de77043e78e84103c371

It appears that's when 'whence' appeared, basically a rename of the
'old_feat' variable.  Also appears that the closely related variable,
how, also made its appearance here (renamed from 'stair_find').

Here's a helpful docstring on the diff between the two variables:
 * @param how The type of stair/portal tile the player is being conveyed through
 * @param whence The tile the player was on at the beginning of the transition
 *               (likely the same as how, unless forced is true)

Looks like when the old code was broken up into several functions,
'whence' got superflously added and didn't actually belong in
_travel_destination().

[Committer's note: Closes #615]

--------------------------------------------------------------------------------
34ce6ba | John Boyle | 2019-01-09 18:27:52 -0500

Don't let confused players win by tripping
Previously, confused players who tripped up the stairs could actually win,
despite getting a message saying they tripped back down.

This update modifies the returned travel destination after tripping if
the player is standing on the dungeon exit. Before, the destination
returned was the default branch with a depth of -1, which would be an
invalid destination. This was ok since this invalid destination would be
interpreted later to prevent going up-stairs after tripping.
However, there was special casing for standing on the dungeon
exit to skip being blocked from transitioning to the destination. This
logic was also updated.

--------------------------------------------------------------------------------
07611c5 | gammafunk | 2019-01-08 20:37:54 -0600

Allow Vertigo status to show up in status displays
This allows it to show in the '@:' listing on the status screen as well
as in logfile and milestone entries.

--------------------------------------------------------------------------------
03697e9 | Edgar A. Bering IV | 2019-01-08 20:12:26 -0500

Correct a feature description to match a tile

--------------------------------------------------------------------------------
184aec9 | Edgar A. Bering IV | 2019-01-08 20:11:05 -0500

Adjust the shape of a Bailey entry

--------------------------------------------------------------------------------
e8b2c15 | Edgar A. Bering IV | 2019-01-08 20:05:33 -0500

New axe and polearm statue tiles (CanOfWorms)
Replacing the unobtainable axes used as decoration in Bailey entrances.

--------------------------------------------------------------------------------
3803c42 | NormalPerson7 | 2019-01-08 14:45:54 -0500

Rename spret_type to spret
This shortens the name to reduce the number of lines that were made too
long by the previous commit, and so that the previous enum values
(e.g. SPRET_ABORT) now easily correspond to their new class values
(e.g. spret::abort).

--------------------------------------------------------------------------------
fb80274 | NormalPerson7 | 2019-01-08 14:45:54 -0500

Convert spret_type to an enum class
This commit converts spret_type to an enum class and replaces all
instances of SPRET_ABORT, SPRET_FAIL, SPRET_SUCCESS and SPRET_NONE to
spret_type::abort, spret_type::fail, spret_type::success and
spret_type::none, respectively, to improve the type security of spell
return values.

This commit also fixes some intentional but nevertheless unnecessary
casting of SPRET_ABORT return values to booleans in _do_ability
(ability.cc), and a clear mistake of returning SPRET_ABORT in the
boolean function uskayaw_line_pass (god-abil.cc), which would now cause
compile errors.

--------------------------------------------------------------------------------
42e8185 | advil | 2019-01-08 12:48:11 -0500

Use window hidden API properly
This probably disabled delays altogether on servers that updated since
a036e810d7e9c886.

--------------------------------------------------------------------------------
edc2041 | advil | 2019-01-08 12:48:11 -0500

Don't create a new TextDecoder for each message
This may have been contributing to perception of choppiness, as it
seemed to be triggering periodic gc that I'm not otherwise seeing. (I
wouldn't have expected the old method to have any different effect, but
who knows.)

--------------------------------------------------------------------------------
eb4e2cb | Edgar A. Bering IV | 2019-01-08 12:14:33 -0500

Adjust Deal Four
Clearing the deck made the cost practically too high. During playtesting
there was a period where the deck was not cleared (a bug at the time)
but the playtesters did not report that it was too overpowered.

A piety cost of zero would be too low, so deal four gains a piety cost
again.

--------------------------------------------------------------------------------
079dcdc | Edgar A. Bering IV | 2019-01-08 11:48:18 -0500

Adjust deck size and card dealing
Increase the size of destruction decks to 26 and change the deal
frequency to favor destruction more.

Compared to the effects in summoning and escape, destruction effects
tend to be a single turn conjuration (Storm and top tier Pain need
adjustment here) which makes them comparatively weaker; giving the
player more to work with should help equalize the decks in power.

Compare this to old Nemelex's higher weighting of destruction decks.

--------------------------------------------------------------------------------
c184e93 | gammafunk | 2019-01-07 19:11:02 -0600

Properly handle LOS for closed clear doors
The LOS test for things that block translocations previously only
considered features as blocking if they were opaque or walls. Close
clear doors are neither but should block these effects. All forms of
closed doors should prevent both effects and actors from passing through
as long as the door remains closed.

Add a feat_is_closed_door() check to the relevent "no_trans" LOS testing
function.

--------------------------------------------------------------------------------
28d4f2f | Edgar A. Bering IV | 2019-01-07 15:35:03 -0500

New Nemelex Draw icons (ontoclasm)

--------------------------------------------------------------------------------
376580a | Edgar A. Bering IV | 2019-01-07 15:32:24 -0500

New dispersal trap tile (CanOfWorms)

--------------------------------------------------------------------------------
a036e81 | advil | 2019-01-07 09:43:23 -0500

Don't run delays for webtiles windows that are hidden (11657)
at least, according to the page visibility API, which is at proposed
recommendation level and widely supported. (For older browsers, this
should just fall back on the older behavior.)

The problem in 11657 is that most browsers throttle setTimeout to use a
minimum timeout of 1000ms for non-visible windowsr.  So, long travel
sequences that are supposed to have a 1ms delay in between each step
instead have a 1s delay in between each step, and so run extremely
slowly while the window is backgrounded and pick up speed to the regular
timeout length once the window gets refocused.

--------------------------------------------------------------------------------
304f35b | gammafunk | 2019-01-07 02:01:20 -0600

Rework some areas of a ghost vault
For gammafunk_ghost_gnarly_gnolls, always add the pair of doors closest
to the landing area, using the newly introduced clear doors. Use clear
doors elsewhere in the vault, and simplify the DES glyph usage.

--------------------------------------------------------------------------------
7e67e01 | gammafunk | 2019-01-07 02:01:20 -0600

Add clear doors to some vaults (minmay)
These vaults have a more pressing need for clear runed doors due to
their layout or being especially spoilery. We will probably have the `=`
DES glyph default to runed clear door in the future, but that will
require that we go over vaults a bit more systematically. After that,
some of this commit can be reverted.

--------------------------------------------------------------------------------
7832a39 | gammafunk | 2019-01-07 02:01:20 -0600

Update list of past and present server admins
in CREDITS.txt

--------------------------------------------------------------------------------
5cfbae5 | gammafunk | 2019-01-07 02:01:20 -0600

Add Matthew Ludivico to CREDITS.txt
Move his name properly into the credits instead of having it in various
comments for vault files. His name is also credited in the names of the
vaults themselves.

His name was listed in comments at the top of several vaults in addition
to his handle being in the names of said vaults.

--------------------------------------------------------------------------------
1cc19cd | gammafunk | 2019-01-07 02:01:20 -0600

A 9x9 Gauntlet arena using runed doors
This arena can be used now that clear runed doors exist.

--------------------------------------------------------------------------------
22e01ae | gammafunk | 2019-01-07 02:01:20 -0600

Tiles and tile logic for translucent doors (minmay)
This commit adds clear door tiles made by minmay and updates tile
handling logic to properly show these tiles.

We have tiles for single closed, open, runed, and sealed clear doors as
well as gated tiles. No Crypt-specific variants for these like the
opaque doors have, but those shouldn't be necessary. Crypt has no
special clear wall tiles that we're trying to blend with.

--------------------------------------------------------------------------------
9cb7e94 | gammafunk | 2019-01-07 02:01:20 -0600

Door handling logic for translucent doors
Update the functions that test for close, runed, and sealed doors to
included the clear door types. Add feat_is_open_door() and
feat_is_runed() as general functions to test for open and runed doors
now that there are two kinds of each. Also add dgn_close_door() and
dgn_open_door() functions to close or open a door to the right type that
retains opacity. In other words, when closing a door we turn a clear
open one into a clear closed one. Update door handling logic to use
these new functions.

--------------------------------------------------------------------------------
546a308 | gammafunk | 2019-01-07 02:01:20 -0600

Translucent door feature types and data
Translucent doors are a new door type that allows LOS visibility through
the door itself. These can be referred to simply as "clear" doors, but the
word "translucent" is used in the in-game descriptions.

One of the main uses of clear doors will be for vaults with runed doors.
Clear runed doors allow revealing vault contents without as much use of
adjacent translucent walls. This is especially useful for vaults with
multiple-tile doors, which is something non-runed vaults can take
advantage of as well using ordinary clear doors. Having clear doors
types in addition to the usual opaque ones will generally allow for more
creative terrain in vaults and layouts.

This commit adds the four necessary dungeon feature types for
translucent doors: closed, open, runed, and sealed. Subsequent commits
will add the logic to properly handle retaining the right feature types
as doors are open, closed, sealed, etc. This logic will be analogous to
the behaviour of current opaque doors. Runed clear doors will turn into
ordinary clear doors when opened. Sealed clear doors will remain clear,
allowing visibility through them, but can't be opened until they're
unsealed.

Translucent door console colors are: cyan for ordinary, lightcyan for
runed, and white for sealed. Tiles and tile handling logic will be added
in a subsequent commit.

It would be good to use clear runed doors for rune door vaults whenever
possible to help minimize spoilers in these vaults. It may be possible
to rework all runed door vaults to use clear runed doors. For now, we
keep the opaque runed doors for the occasional more spoilery vault that
needs them. Closes #934.

--------------------------------------------------------------------------------
3751e1c | advil | 2019-01-06 21:32:39 -0500

Don't use `let`
Not necessary here and isn't otherwise used in our codebase.

--------------------------------------------------------------------------------
63bca24 | advil | 2019-01-06 21:15:16 -0500

Fix out-of-order messages (maybe 11780)
For compressed websockets, the decoding process used a FileReader to
convert the output of decompression to UTF-8. However, FileReader comes
with no guarantees about the order in which callbacks get attended to
when there are multiple instances, and in chrome especially they could
get quite out of order for messages sent at roughly the same time. This
lead to the message queue being out-of-order, which various aspects of
the webtiles client are not robust to.

This commit uses (suggested by jilles) a TextDecoder instance instead.
Because this may not be supported by some browser versions still in use,
I have kept the old approach as a fallback. (An alternative would be
simply to use uncompressed websockets if TextDecoder is not supported.)

--------------------------------------------------------------------------------
ca735f5 | gammafunk | 2019-01-06 17:44:52 -0600

A Throw Klown Pie ability for Killer Klowns
This LOS-range ability throws a damaging projectile (a pie!) that
inflicts a non-resistable and temporary debilitating effect on the
victim whenever it does damage. The effects are: inability to drink
potions (player-only), Vertigo (player-only), stat drain (player-only),
silence, fire vulnerability, and polymorph. The player version of
polymorph is restricted to forms that can always move: bat, hog, and
wisp. The effects are weighted evenly except for fire vulnerability,
which has 12% chance, and polymorph, which has 8% chance.

These effects are ones not already represented by existing Zot monsters
and mostly things that are significant in combat, especially with
multiple monsters involved, but don't always necessitate immediate
retreat. Polymorph is the exception to this; it's a rare but scary
effect where the player has to use the form to escape or use things like
potions of cancellation, allies, god powers, powerful spells, etc. for
safety.

The pie does damage that's the same as quicksilver dragon breath, 3d20.
This is enough to give it a good chance to have an effect even on
characters with good AC. Additionally Klowns have a low weight for using
their new ability, about 1/4 as much as Quicksilver dragon use their
breath.

The pie projectile tiles are taken from the April Fool's implementation
of Jesters. Now all that's left is to make Killer Klowns worship Nemelex
and have Xom wrath...

--------------------------------------------------------------------------------
bb96f5f | gammafunk | 2019-01-06 17:44:52 -0600

Code support for restricted player polymorph
Add a `allow_immobile` argument that defaults to true for
actor::polymorph(). If this is false, the player won't polymorph into a
form that can become immobile, like Tree or Fungus form.

This will be used in an upcoming Killer Klown spell.

--------------------------------------------------------------------------------
e027d9b | gammafunk | 2019-01-06 17:44:52 -0600

Initial rework of Killer Klowns
Killer Klowns are fairly boring and ineffective Zot monsters right now.
Their defining characteristics are their speed, their af_klown melee,
and their blinking. The af_klown melee effects are mostly already
represented by existing Zot monsters and are necessarily conservative
to avoid a "never melee this" situation. Overall, Klowns feel like
nothing more than blinking meatbags that don't really live up to their
relative rarity and special use in the Hall of Zot.

This commit is part of a reworks Klowns to give them a more interesting
ranged attack in place of their custom melee type. The ranged attack
will be a "Throw Klown Pie" ability that does damage and inflicts one of
a set of temporary effects. It will be introduced in a subsequent
commit.

In this commit, the af_klown melee type is removed, and Klowns now get
well-enchanted, usually branded clubs as melee weapons. A clubs is a
poor weapon on its own, but high enchantment and use of brands combined
with a Klown's decent melee damage serve a purpose similar to af_klown
without needing a custom attack flavor. A club is also a funny weapon;
you can't help but laugh when getting hit with a +12 club! The club
brands include flaming, freezing, vorpal, elec, venom, vamp, antimagic,
pain, holy wrath, and at very low weights, distortion and chaos. The
last two create a "don't melee this" situation, but with a combined
chance of only 3%, seeing a Klown with one of these brands will be a
rare and delightful treat.

This commit also removes Klowns' extra regen, something I'm sure many
players (and some developers) didn't know they had! Klowns have lots of
HP and like to blink around, so there's no need to help them overstay
their welcome with fast regen.

Klown tiles now have weapon offsets so that their clubs can be properly
displayed for each tile variant. The tiles weren't designed to display a
weapon, but the locations I've chosen work well enough for now. In the
future, it might be good for an artist to adjust the tiles to allow
better weapon display.

--------------------------------------------------------------------------------
a4d50d4 | gammafunk | 2019-01-01 18:06:09 -0600

A Trog-themed ghost vault with wrathtful warriors
A transporter ghost vault for D:7-15, Lair, Orc, Shoals, Snake, Swamp,
Elf, Depths, and Zot. In gammafunk_ghost_wrathful_warriors, some
warriors pay tribute with offerings at Trog altar. An unfortunate player
tried to take the loot, but neglected to notice the moths of wrath
provided by Trog to aid his champions.

The only terrain are three rocky pillars arranged in a primitive henge
with some randomized wall placement. Some of the warriors are armed with
weapons themed as Trog gifts. In certain branches like Elf or Shoals, a
couple monsters are primarily ranged attackers that pose the most threat
before they berserk. All monsters are capable of being berserked and
none are spell-casters. Numbers of monsters and loot scale with depth of
placement, similar to other ghost vaults. The number of Trog-themed
weapons gradually increases, as does their quality.

--------------------------------------------------------------------------------
5ee8fed | gammafunk | 2019-01-01 17:52:56 -0600

Update DES and monster data for a ghost vault
Tweak the monster weapon definitions used by the ghost_orc_armoury
vaults to make them a bit more general. Include some reasonably low
weights for higher-end types for the knight set. Make the monster weapon
sets available as variables for other ghost vaults. These will be used
by a vault introduced in a subsequent commit.

For the ghost_orc_armour vaults themselves, reindent the kmons()
statements to be more readable. Also tweak NSUBST statements to put the
fancier orcs earlier in the statements for clarity.

--------------------------------------------------------------------------------
2b9f6a0 | gammafunk | 2019-01-01 17:52:56 -0600

Fix loot generation in a vault
In gammafunk_ghost_berserking_beasts, the loot wasn't placed properly in
the Spider branch due to missing SUBST statements.

--------------------------------------------------------------------------------
3f50ca7 | gammafunk | 2019-01-01 17:52:56 -0600

Remove some ammo quantities from DES monster specs
When giving ammo to a monster as part of its monster spec, the monster
will be given a reasonable quantity for that ammo type if quantity isn't
specified. The monster gear code doesn't correctly apply
monster-specific quantity bonuses when doing this, which is something
that should be fixed. However those aren't relevant for the instances
changed by this commit.

--------------------------------------------------------------------------------
4b96247 | gammafunk | 2019-01-01 17:52:56 -0600

Update and comment a ghost vault loot function
Have ghost_good_loot() use the lists of auxiliary armour in
dat/dlua/dungeon.lua instead of having its own lists. Add comments
describing how this function sets up its loot glyphs.

--------------------------------------------------------------------------------
8ec7dd4 | gammafunk | 2019-01-01 17:52:56 -0600

Fix a weapon specification function
The random_item_def() function used by ghost vaults didn't properly
exclude quick blades from receiving the speed ego. Also remove a check
for randarts with no ego specification used by an earlier version of
this function, since that's no longer needed.

--------------------------------------------------------------------------------
b60d84b | NormalPerson7 | 2018-12-31 17:24:24 -0500

Improve spell description of memorised uncastable spells (11808)
"You cannot memorise this spell because ..." was unsuitable when the
player had already memorised an unusable spell before it was made
unusable.

Therefore, change this message to "You cannot cast this spell because ..."
when the player had previously memorised the spell.

Also convert `description` in this function from a string to an
ostringstream to prevent casting to a string that would be caused by
neither of the first two additions to `description` being of type
string.

--------------------------------------------------------------------------------
9ccc95a | Edgar A. Bering IV | 2018-12-30 23:04:45 -0500

Changelog through 0.23-a0-642-g3120c2f5

--------------------------------------------------------------------------------
3120c2f | gammafunk | 2018-12-29 22:44:08 -0600

A ghost vault with berserking beasts
A transporter vault for D:7-15, Lair, Orc, non-Slime Lair branches, Elf,
Depths, and Zot. In gammafunk_ghost_berserking_beasts, you encounter the
ghost of a player who stumbled into a cave of beasts with moths of wrath
lurking about. The monsters are animal-intelligence things from the
branch of placement that can be berserked. Monster count and loot are
progressive in the usual ghost vault fashion. An extra piece of
auxiliary armor or jewellery that upgrades in quality by depth is placed
under the ghost.

The layout is the same used in another ghost vault for now. I'll rework
it to be something more uniquely cave-like in a future commit.

--------------------------------------------------------------------------------
0a7f1ce | Edgar A. Bering IV | 2018-12-29 11:35:48 -0500

Update CREDITS

--------------------------------------------------------------------------------
5944deb | Ryan | 2018-12-29 11:33:10 -0500

Grant Qazlal cloud immunity to divine allies
This fixes the non-combo circumstance where your own clouds kill your
Qazlal Elementals. Qazlal still hampers other sources of allies.

[Committer's note: Closees #773, restricted immunity only to Q allies]

--------------------------------------------------------------------------------
a9a3373 | Umer Shaikh | 2018-12-28 14:59:07 -0600

Remove useless function declaration
This function is never defined or called.

--------------------------------------------------------------------------------
c52245b | bjobae | 2018-12-28 08:51:28 -0600

Adjust Amulet of the Acrobat
The acrobat effect no longer works while held or constricted.

Display of the EV-boost during the previous turn is improved by
extending the duration of the acrobat effect for one AUT. There are no
one AUT player actions, so if the player takes a non-acrobat action they
will lose the status before the world_reacts().

The result is that the EV-boost received during the previous turn after
doing non-actions (entering an unknown command, viewing inventory etc).

[Committer's note: Closes #922, tweaked some comments and wording]

--------------------------------------------------------------------------------
a828402 | Umer Shaikh | 2018-12-28 07:46:46 -0600

Make cloud duration more apparent to console players
Tiles players can see when certain clouds (e.g., fire from conjure
flame) are about to expire. We reveal similar information to console
players by adding separate characters for (some) decaying clouds. These
are distinguised by default in CSET_DEFAULT (but not CSET_ASCII) and can
be set by the player by modifying the option display_char.

--------------------------------------------------------------------------------
0ff6057 | NormalPerson7 | 2018-12-27 10:15:30 -0600

Add three tile colour options to the options guide (11802)
Add the options:
    tile_transporter_col,
    tile_transporter_landing_col, and
    tile_explore_horizon_col
to options_guide.txt.
Adjust whitespace to retain alignment of the other tile colour options.

--------------------------------------------------------------------------------
88ca12a | advil | 2018-12-26 16:49:16 -0500

Rename some more `require` calls
These were added after the initial branch.

--------------------------------------------------------------------------------
1d98191 | advil | 2018-12-26 16:32:13 -0500

Rename `require` in tests

--------------------------------------------------------------------------------
8735bf6 | advil | 2018-12-26 16:32:13 -0500

Rename crawl's custom `require`
We don't (normally) load the lua `package` lib, but this function
shadows a lua `require` that would be loaded by this lib. Rename our
`require` both to make it clear that this *isn't* the real lua require,
and to allow the real thing to work (especially when libraries try to
use it) for builds where `package` is loaded.

--------------------------------------------------------------------------------
b80182b | advil | 2018-12-26 13:54:30 -0500

Improve behavior of drain life in wizmode (11801)
Drain life, as a spell, is monster-only, and was crashing in wizmode
because calling it as a player zap doesn't set the range correctly. This
commit sets it explicitly to be monster-only; the Yred ability does use
this spell type, but isn't impeded by this change because it is called
there via `fire_los_attack_spell` which doesn't worry about this flag.
Together with the added exception to prevent the zap from being called,
this causes casting it in wizmode to use the monster cast code (i.e.
create a dummy monster and cast it).

This commit also adds a message when memorizing a monster-only spell via
&!, not just when casting.

--------------------------------------------------------------------------------
5586149 | advil | 2018-12-26 13:03:08 -0500

Mark test statues as non-firewood
43d87f4 caused them to be firewood, which prevents tab from working (and
maybe there are other side-effects no one has noticed). This commit lets
them still be harmless, but also tabbable.

--------------------------------------------------------------------------------
9e4c4e9 | Edgar A. Bering IV | 2018-12-26 09:26:54 -0600

Correct a manual typo (11804)

--------------------------------------------------------------------------------
ae4348f | gammafunk | 2018-12-24 14:12:57 -0600

Fix a typo in the gauntlet portal message (vt)

--------------------------------------------------------------------------------
7e7a9de | NormalPerson7 | 2018-12-24 12:20:21 -0600

Fix surge of power message order when evoking enhanced wands (11753)
This commit adds functionality to deal with the "surge of power" message
when zapping wands under MP-powered wands in your_spells directly, so
that this message is displayed before any of the wand's effects and any
world_reacts effects caused by zapping the wand are displayed.

To effect the change this commit also moves the check for the player
having enough MP to use the full power bonus from MP-powered wands into
wand_mp_cost.

[Committer's note: Closes #926, squashed and kept some Pakellas code in
place since Pak is disabled but not removed]

--------------------------------------------------------------------------------
f6ffe88 | gammafunk | 2018-12-24 10:23:42 -0600

Fix a typo in the INSTALL instructions (enop)

--------------------------------------------------------------------------------
6760373 | NormalPerson7 | 2018-12-24 10:22:16 -0600

Fix a typo

--------------------------------------------------------------------------------
1d2cd9b | gammafunk | 2018-12-23 18:24:49 -0600

Four Gauntlet maps using 7x7 arenas by minmay
These maps use the 7x7 arena subvaults introduced in the previous
commit. They have layouts ideas similar to the existing four 9x9 arena
maps, introducing a couple variations and also sometimes mixing in 9x9
arenas in the same map.

minmay_gauntlet_77_indecision: Six arenas total arranged in vertical
pairs. The player chooses a path through two first tier pairs and one
second tier pair.

minmay_gauntlet_77_tree: A tree like arrangement of 7 arenas where all
paths go through two tier one arenas and then a tier two arena. The
first vault is mandatory, with two choices at each of the two points
afterwards.

minmay_gauntlet_mixed_big_or_small: Mixes 9x9 and 7x7 arenas, giving a
choice of two paths, one using 9x9 and one using 7x7. Each path has two
tier one arena followed by a tier two.

minmay_gauntlet_mixed_oops_all_seconds: The player has three choices of
paths with two arenas each, all of which are tier 2. Each path has one
9x9 and one 7x7 arena.

I've tested all of these maps to make sure that they place all their
subvaults properly and that all of their transporters work.

--------------------------------------------------------------------------------
52e5ff9 | gammafunk | 2018-12-23 17:57:47 -0600

Some 7x7 Gauntlet arena vaults by minmay
These smaller arenas will be used in minmay's Gauntlet maps, which will
be merged in an upcoming commit. The setup and glyph usage of these
arenas is the same as 9x9 vaults, aside from using a different set of
selection tags. The only change I've made is to simplify an NSUBST
statement, but I've also verified that all vaults place the necessary
numbers of glyphs, have the right tags, and call the setup function.

The 7x7 arena vaults leave a lot less space for terrain given the
requirement of 23 glyphs. It might be good to look at lowering the
number of 3 glyphs required. The current sets use no more than six 3
glyphs, for example. Alternately we could have the monster placement
code be aware of vault size limitations, allowing us to require
different numbers of glyphs for different arenas. For instance, smaller
arenas would never roll more than six monsters for the '3' glyph and if
a set required more than six monsters as its minimum, a new set would be
chosen. For now we're just requiring the same set and number of glyphs
for both arena sizes.

--------------------------------------------------------------------------------
e3a65f0 | gammafunk | 2018-12-23 14:02:37 -0600

Clean up some Gauntlet DES
Rewrap comments and remove a stray wall glyph.

--------------------------------------------------------------------------------
59b4ea9 | gammafunk | 2018-12-22 18:18:04 -0600

A Kiku-themed ghost vault
In gammafunk_ghost_crypt, the player finds a crypt housing some liches
and from one to three player ghosts, with decreasing chances for each
additional ghost past the first. Any ghosts that don't place are
replaced with a lich, and the liches upgrade to ancient liches as
appropriate for depth of placement. The vault is Kiku-themed, always
placing a book that is a necro randbook, the Necronomicon, or a manual
of necromancy. The other guaranteed loot are a piece of artefact
auxiliary armor and a piece of randart jewellery. The remaining loot is
randomized in typical ghost vault fashion.

Places on D:15, and in Elf, Crypt, Vaults, Depths, and Zot.

--------------------------------------------------------------------------------
65ce32e | gammafunk | 2018-12-22 18:15:39 -0600

A trap-themed ghost vault
The vault gammafunk_ghost_tricky_traps features Zot, dispersal, and
alarm traps on the inside and outside. In addition to a player ghost,
the vault has some in-branch monsters that can blink along with a
depth-scaled number of normal level monsters. Loot also scales with
depth, but always includes a piece of randart auxiliary armor.

Places on D:15 and in Shoals, Spider, Elf, Vaults, Depths, and Zot.

--------------------------------------------------------------------------------
4f9fac9 | gammafunk | 2018-12-22 17:23:23 -0600

Rename a ghost vault
Rename the vault ploomutoo_gammafunk_ghost_potion_laboratory to
ploomutoo_gammafunk_vaults_ghost_potion_laboratory so its name is
consistent with other ghost vaults. This makes vault searches and
queries easier.

--------------------------------------------------------------------------------
281719c | Edgar A. Bering IV | 2018-12-21 16:35:28 -0600

Spice up the skin of Zhor
Riffing on the cold theme, give it a passive Metabolic Englaciation
effect. To cut down on message spam, have it only trigger when monsters
are around, and give it SInv to avoid weirdness with detection.

--------------------------------------------------------------------------------
2e9d38c | advil | 2018-12-21 16:20:07 -0500

Fix some issues with build-rltiles and webtiles
Ensure that libpng gets built if there is no pkg-config, so that the
submake has access to it. Also a misnamed variable that crept in in
a53296f351.

--------------------------------------------------------------------------------
9ead64f | gammafunk | 2018-12-21 13:53:36 -0600

A ghost vault full of gnarly gnolls
A transporter ghost vault for D:3-8 that's inspired by Lemuel's infamous
castle vault. In gammafunk_ghost_gnarly_gnolls, the player encounters a
ghost who tried and failed to raid a well-guarded gnoll castle. Gnarly
gnolls include those with branded reach weapons and possible nets, as
well as gnoll artificers (just ordinary gnolls with wands). As depth
increases, so does the amount of monsters and loot, with gnoll sergeants
replacing some of the ordinary gnolls. On D:7-8, there's a chance for
Grum and his band of wolves to replace one of these sergeants.

The castle's treasure vault always places a manual (gnolls love raising
skill levels!), a piece of jewelry, and some gold. The vault has mostly
narrow passageways, but one or two doors may place near the entrance to
give both players and monsters additional movement options.

--------------------------------------------------------------------------------
092a5d6 | gammafunk | 2018-12-21 13:37:16 -0600

Use local variables in some vault Lua
Not using local in Lua functions can make certain bugs harder to find.
For instance, bugs can happen when a variable is referenced by the wrong
name and the incorrect name has already been defined globally, often by
another function or block that should have declared the variable as
local. The incorrect variable then gets used, which may lead to
incorrect results without generating an error.

This commits makes a bunch of ghost vault Lua variables local to their
function or block.

--------------------------------------------------------------------------------
63707c9 | gammafunk | 2018-12-21 13:30:31 -0600

Fix a weapon ego designation in a vault
It's 'vampirism', not 'vampiric'. This typo caused the vault to not
place due to a parsing error whenever this ego was selected.

--------------------------------------------------------------------------------
6788861 | gammafunk | 2018-12-21 13:30:31 -0600

Fix a monster item definition in a vault
The randomized weapon quality wasn't being correctly used, leading the
quality to never upgrade from 'good_item' to 'randart'.

--------------------------------------------------------------------------------
343d861 | gammafunk | 2018-12-21 13:30:30 -0600

Fix a decoration and a comment in a ghost vault
The SUBST was on the wrong glyph, never allowing withered trees to place
as an alternate to withered plants.

--------------------------------------------------------------------------------
cb482e9 | Edgar A. Bering IV | 2018-12-20 21:52:46 -0500

Display deck counts upon receiving a Nemelex gift

--------------------------------------------------------------------------------
cf5c981 | Edgar A. Bering IV | 2018-12-20 19:23:35 -0500

Exempt Ashenzari followers from explore traps
The explore trap system interacts poorly with scrying: a player walking
over an explored area to scry a wall rolls traps upon the scry reveal
(though only for those tiles that would grant xp), which means that the
player can be trapped despite only stepping on what they believe to be
safe tiles. This is an unintuitive interaction.

Tracking whether a tile was revealed by scrying or by an honest look is
in principle possible, but would need to be revealed in the UI and
communicated to the player. Even before the trap change, piety was
granted for scried tiles as if they were explored. Though it's not
mentioned in the commit log the behaviour appears to be intentional, and
it certainly prevents a UI headache. For this reason, and since Ash
previously boosted trap searching this patch grants Ash followers
immunity to explore based trap effects.

--------------------------------------------------------------------------------
21ca0c9 | Edgar A. Bering IV | 2018-12-20 19:21:19 -0500

Correct a conditional (Ge0ff)
Commit 7a20e1 used the negation of the correct logic.

--------------------------------------------------------------------------------
13ba85c | Edgar A. Bering IV | 2018-12-20 19:20:05 -0500

Simplify monster trap pathing and knowledge

--------------------------------------------------------------------------------
7a20e13 | Edgar A. Bering IV | 2018-12-20 13:01:13 -0500

Don't trigger alarms through glass
Breaking LOF reciprocity for this trap and not Zot and Dispersal traps
led to bad interactions with scrying for little benefit.

--------------------------------------------------------------------------------
760965b | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Generalize uncancellable menus
Add a flag MF_UNCANCEL that indicates to a Menu that it is
uncancellable. Menus run with this flag should be run from within a
run_uncancel to behave correctly under HUPs.

--------------------------------------------------------------------------------
be15bf4 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Streamline the Stack Five UI
Instead of repeatedly calling the deck chooser menu in a clunky fashion,
implement a fancier deck chooser that displays the cards crawn so far on
the bottom line.

--------------------------------------------------------------------------------
2fa7c9c | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Prompt before canceling damaging cards
The player has already seen the card, so we can't put it back, but if
they want to waste it that's their prerogative. If we see a hup we also
cancel the card.

--------------------------------------------------------------------------------
67175e3 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Display the top of the stack in the ability menu
Currently 'the Pentagram' is 13 characters, so there isn't space in the
Cost column of the ability menu for the string
'A Card (the Pentagram, n more)' using a shorter string than this makes
it even harder to parse. Since a player concerned about how many cards
remain in their stack is probably also interested in which cards those
are it doesn't seem too bad to not have the count in the ability
display.

--------------------------------------------------------------------------------
80e52c9 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Default force_more for Nemelex gift messages
This gives a force_more for every gift. As the gift timeout hasn't
changed this is hopefully not too obtrusive. If it really is, a separate
message for when a deck goes from zero to non-zero card count should be
added and made the default along with the deck is full message.

--------------------------------------------------------------------------------
399e8c3 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Make the Velocity card less harmful at low power
At power level zero Velocity was far more likely to be actively harmful
to the player than to help. With the changes to Nemelex, this particular
blind-draw downside is too harsh.

The new card no longer removes haste at power zero, and has the
following effects based on card level.

- level chance in 2 to remove slow from the player
- for each enemy in sight there is a (level + 1) chance in 3 to slow
- for each ally in sight there is a level chance in 2 to haste

--------------------------------------------------------------------------------
7060c59 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Adjust Triple Draw and Deal Four
The piety cost of deal four was a relic from old Nemelex, was too high
(according to some) for even old Nemelex, and definitely too high for
new Nemelex. The loss of cards means that deal four is piety gated in
the new scheme already, so the piety cost for dealing four is now zero.

Additionally, with card counts known, the punishment mechanic doesn't
make sense (too flavour).

Triple Draw is very good, and knowing deck counts means it can always be
used on 3 cards, so its piety cost is increased.

--------------------------------------------------------------------------------
264638f | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Disable empty decks in the ability menu

--------------------------------------------------------------------------------
8f7bd25 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Display cards available in the ability menu

--------------------------------------------------------------------------------
465c976 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Descriptions for Nemelex Draw abilities
These are automatically built to reflect the current state of the deck
being described.

--------------------------------------------------------------------------------
96e2e8d | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Iconography and gui elements for decks
Move old deck icons to UNUSED. Recolour and relocate the remaining ones
to fit the colour scheme of Nemelex's other abilities.

--------------------------------------------------------------------------------
1e257c8 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Icons for the different draw abilities

--------------------------------------------------------------------------------
69d4283 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Split "Draw One" into individual draw abilities
This removes an extra keypress that will add up over time. For user
consistency, the deck hotkeys in the deck chooser are now the same as
the ability hotkeys for drawing from them. If this behavior is
undesirable for some users, an options toggle can be added.

--------------------------------------------------------------------------------
5f4ef56 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

New Nemelex Stack five
The player draws five cards, one at a time, and then organizes them into
a stack, which can be subsequently drawn from in draw one. Re-using this
ability discards the current stack.

This commit refactors an internal function to simplify displaying card
descriptions.

--------------------------------------------------------------------------------
5ca2704 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

New Nemelex Triple Draw ability
Reimplementation of the old ability, which is otherwise totally
unchanged.

--------------------------------------------------------------------------------
b66aaaf | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

New Nemelex Deal Four ability
Deals four from one of the player's abstract decks, emptying the
remaining cards. The player is still permitted to deal four without
sufficient cards (with a prompt), if they do they get a deal from
Punishment.

--------------------------------------------------------------------------------
d6dedd3 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

New Nemelex Draw One ability
Draws from one of the abstract decks the player has, and is the only
interface to decks.

--------------------------------------------------------------------------------
453e4f2 | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

A deck choosing menu
Add a menu for all Nemelex abilities to select the deck to use. Toggles
to describe the decks, listing their cards.

--------------------------------------------------------------------------------
e45b02a | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Abstract decks to a player property
Nemelex deals cards into the player's decks on the gift timeout and
empties them on wrath.

--------------------------------------------------------------------------------
7ca12cd | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Remove decks as items
Subsequent commits will return decks to Nemelex worshippers without
going through the legacy of having them be actual items.

This commit removes the deck item type, confiscates any remaining decks on
load in save-compatibility, and removes as much of the item handling
code for decks as possible.

Any pre-change Nemelex worshippers transferring their save get a raw
deal, but that's been done once before for the evocations to invocations
change.

--------------------------------------------------------------------------------
5bbfdfc | Edgar A. Bering IV | 2018-12-19 11:55:14 -0500

Remove deck rarity types
Step one of abilifying decks is to remove the different rarities. All
decks are now roughly ornate in power, but the exact distribution of
card_level has changed somewhat, and is now

card_level = x_chance_in_y(power, 900) + x_chance_in_y(power, 2700)

with power a function of piety and invocations:

power = (invocations * 9) + (piety * (invocations + 25)) / 27 + piety * (3/2)

Further attempts at balance are not considered at this stage, since
subsequent commits will further modify Nemelex significantly.

--------------------------------------------------------------------------------
acb4b3f | advil | 2018-12-17 16:18:18 -0500

Don't show ghost debug messages as errors
...so that they don't force a more when doing level reloads. These will
still appear on non-debug builds after wizmode commands, as long as the
diagnostcis channel isn't disabled.

--------------------------------------------------------------------------------
ec6e9a1 | Nikolai Lavsky | 2018-12-17 09:46:10 -0500

Fix display of rotted HP on WebTiles (11759)
Commit 1406302deb reversed the meaning of the get_real_hp()'s second
parameter and updated all instances of this function, except for one
in tileweb.cc.

--------------------------------------------------------------------------------
44dd78f | Edgar A. Bering IV | 2018-12-16 13:15:13 -0500

Add jrmartel to CREDITS.txt

--------------------------------------------------------------------------------
50760eb | jmart | 2018-12-16 11:17:38 -0500

Fix Sif Muna dud gift bug (11791)
If the player has every spell in their library, Sif Muna will still
send the "Sif Muna grants you a gift!" message and trigger gift timeout.
This commit corrects the bug. When the player has all spells in their
library, Sif's gift timeout will no longer be triggered.

The cause of the error was an incorrect check in Sif's gift logic.
The return value of the acquirement(...) method was used to check
success, but that method returns true even if no item was created.

[Committer's note: Formatting tweaks, Closes #923]

--------------------------------------------------------------------------------
1b4a0ca | Edgar A. Bering IV | 2018-12-15 13:25:39 -0500

Elaborate in a comment (|amethyst)

--------------------------------------------------------------------------------
66906bf | Edgar A. Bering IV | 2018-12-15 12:13:01 -0500

Only trigger traps in player sight
This uses LOS_SEE, so that monsters on the other side of glass trigger
traps. Monsters triggering traps out of LOS is a simulationist relic of
player-monster symmetry, which was for the most part not noticable other
than: "distant Zot" messages, occasionally losing track of a unique down
a shaft, and in hall_of_zot where a spoliled player could wait for a
long time outside the vault to thin the monsters within using the
permanent teleport traps.

--------------------------------------------------------------------------------
f63cd86 | Edgar A. Bering IV | 2018-12-15 12:06:13 -0500

Don't place monsters on traps
For dispersal traps this creates the lingering question "how did they
get there"; for alarm traps and Zot traps it prevents an interface screw
in console. (It can still happen that a player enters LOS and a
wandering awake monster is standing on certain kinds of traps.)

--------------------------------------------------------------------------------
6f77609 | Edgar A. Bering IV | 2018-12-15 11:24:20 -0500

Adjust dispersal sequencing
Always blink the triggerer last to prevent chain dispersal from a single
trap. This doesn't prevent dispersal chains from two or more nearby
traps, but those are rare.

--------------------------------------------------------------------------------
fddc42b | Edgar A. Bering IV | 2018-12-15 11:15:04 -0500

Consider dispersal traps impassible in levelgen
While this isn't technically true, dispersal traps can be passed, it is
painfully annoying.

--------------------------------------------------------------------------------
2b1de94 | advil | 2018-12-13 15:11:51 -0500

Respect BFLAG_NO_SHAFTS for explore-triggered shafts (u/Hamsteri)
This affects only tomb 1=>2; 2=>3 was already prevented by
BFLAG_DANGEROUS_END, and no other branch has BFLAG_NO_SHAFTS set. I'm
not sure what the original intent of only checking this on levelgen was,
but it long precedes explore traps. I did a quick audit of code that
calls this and it all seems fine; though it may have been possible for
formicids to self-shaft on tomb 1 before this commit (and probably won't
be now).

--------------------------------------------------------------------------------
c793968 | advil | 2018-12-13 12:27:44 -0500

Clean up some oldghosts code
Now that saving of ghosts is disentangled from loading of ghosts,
there's no pressing reason to prevent saving of ghosts in portals, and
some vault designer might come up with a clever way to design ghost maps
for some portals. (That said, I'm not sure I can see a good way to make
a ghost map for some of the early portals, e.g. sewer.) I've still left
branches disabled where I can't envision any good way of making use of
ghosts.

Also, remove an old function that is now used only for wizmode testing,
and adjust some documentation/naming to better represent how this code
is used for newghosts.

--------------------------------------------------------------------------------
442c57a | gammafunk | 2018-12-13 09:14:05 -0600

Correctly handle LOS for dispersal traps
Dispersal traps are supposed to affect actors that can see the cell of
the trap without any translocation-blocking wall in the way (e.g.
transparent rock or stone). This condition was correctly applied to
monsters, but not to players if the trap was triggered by a monster.
This commit applies the condition to player, preventing monsters on the
side of transparent rock/stone walls from blinking the player with
dispersal traps.

--------------------------------------------------------------------------------
a53296f | advil | 2018-12-13 09:56:36 -0500

Fix cross-compiling + libpng
When cross-compiling, the contrib libraries are not useful for the
tilegen tool, which needs to be run as part of the build process. This
prevents it from trying to use contribs; cross-compiling will therefore
fail if it can't find libpng via pkg-config (this was the status quo for
all builds before 409694ba0a8762, so it doesn't introduce any new
requirements).

--------------------------------------------------------------------------------
25f4479 | gammafunk | 2018-12-12 23:40:13 -0600

Rework gammafunk_gauntlet_shortcut
Make the longer path have four arenas instead of three so that the
shortcut aspect is more emphasized. Make all four of the longer path
arenas have easier difficulty instead of having the last one in the path
sometimes be harder. Adjust the average amount of loot per arena so that
both paths have 7 items on average, which is in line with what the other
Gauntlet maps give.

--------------------------------------------------------------------------------
6ca8497 | gammafunk | 2018-12-12 23:40:13 -0600

Allow Gauntlet maps to customize extra loot
This commit adds Lua support allowing Gauntlet maps to change what loot
their arenas place. This customization only applies to the three extra
item locations within each arena, with the arena's first item remaining
guaranteed. This functionality will be used in a subsequent commit to
have a Gauntlet map place a set of four arenas with the same average
amount of loot as a set of two arenas in another path.

--------------------------------------------------------------------------------
1612a95 | gammafunk | 2018-12-12 23:22:01 -0600

Sometimes place traps in Gauntlet arenas
This gives each arena vault a small chance to place traps using the '^'
glyph, with the chance being 1/6 for tier 1 arenas and 1/4 for tier 2.
If traps don't get enabled, any '^' glyphs become floor.

Currently only dispersal traps are placed, since Zot traps are too
dangerous for most depths where Gauntlets place, and would be especially
dangerous for some vaults. It may be possible to use a limited number of
Zot traps in specific vaults for Gauntlets that place late enough, but
for now dispersal traps will do.

--------------------------------------------------------------------------------
53ffe6b | gammafunk | 2018-12-12 23:21:17 -0600

Add support for custom Gauntlet arena terrain
This commit adds support for arena monster sets to define thematically
appropriate types of liquid and plants. For instance, necromancy-themed
sets might want withered plants, and demonic-themed ones might want
demonic plants. Likewise a simulacra set wouldn't want deep water
replaced with lava and a fire themed set would want lava instead of deep
water.

These preferences are defined via keys described in the comments of
tier1_arena_monsters in gauntlet.lua. The monster sets have been updated
to give these preferences where appropriate.

Also realign the arena variables to consistent spacing.

--------------------------------------------------------------------------------
fcd52a4 | gammafunk | 2018-12-12 23:16:42 -0600

Gauntlet monster set additions and updates
Add entries for a necromancer with wolves for tier 1, and swamp worms
for both tiers. Update the entropy weaver set to place no more than one
wolf spider. Slightly increase the number of slime creatures for tier 1
(still only placing 60% of a band). Have the tier 1 sixfirhy set always
place only one sixfirhy, supplementing it with ufetubus instead, since
those are also fast. Fix the spectral thing entries to use the correct
syntax.

--------------------------------------------------------------------------------
13ad8d5 | gammafunk | 2018-12-12 23:15:35 -0600

Remove low weighting on a Gauntlet exit vault
This vault had low weight during development of the Gauntlet portal due
to its small size at the time. It was changed to make it occupy the full
subvault area, but the weight was never updated.

--------------------------------------------------------------------------------
d6d2466 | gammafunk | 2018-12-12 23:15:35 -0600

Rename some setup functions and a variable
The new function names make it clearer whether the function applies to
Gauntlet arena vaults or to the overall map.

--------------------------------------------------------------------------------
f2ea3f3 | gammafunk | 2018-12-12 23:15:04 -0600

A new Gauntlet entry portal tile (CanOfWorms)

--------------------------------------------------------------------------------
3e74e4c | advil | 2018-12-12 20:16:11 -0500

Remove a default argument, and convert to reference
Previously, the default argument of `0` was taken to indicate the
player. Now that all traps are revealed to the player, there's not much
point to this.

--------------------------------------------------------------------------------
066e7ca | advil | 2018-12-12 19:53:20 -0500

Remove trap revelation from sanctuary

--------------------------------------------------------------------------------
409694b | advil | 2018-12-12 17:34:52 -0500

Use contribs if appropriate when building rltiles/ via sub-make
This passes along the NO_PKGCONFIG value determined by the main Makefile
to rltiles/Makefile. Previously, the sub-make process would use
pkg-config libpng regardless of what the main Makefile is doing. This
isn't necessarily a big deal, because the utility built with this isn't
distributed, but it is breaking the build for hypothetical someone who
is having pkg-config problems and wants to rely just on contribs (me),
or someone who might try to build crawl in a restricted environment
without pkg-config (which apparently is uncommon).

--------------------------------------------------------------------------------
f2ebeb9 | Edgar A. Bering IV | 2018-12-12 09:10:32 -0500

Update credits

--------------------------------------------------------------------------------
7e78d40 | bjobae | 2018-12-12 09:08:17 -0500

Prevent a crash in god descriptions (11492)
Fixed a typo which caused a crash on Lugonu's description screen if
terminal size was too small.

--------------------------------------------------------------------------------
bfc773d | Edgar A. Bering IV | 2018-12-12 08:54:54 -0500

Add ufshaikh to CREDITS.txt

--------------------------------------------------------------------------------
cc558d2 | Umer Shaikh | 2018-12-12 08:52:44 -0500

Make giant creatures no longer tear through webs
Web traps were made permanent to prevent the player from tediously
stepping in and out of them to remove them. But it is still possible to
remove them by luring a giant enemy (e.g., an emperor scorpion) through
a web. (Less realistically, the player may also transform into a giant
form, e.g., using dragon form, and then tear through them.)

Since webs frequently block choke points in retreat paths, this can
easily be worth doing, but is not rewarding gameplay after the first
time the interaction is noticed. In the absence of compelling positive
effect on gameplay from the interaction between size and web traps, the
problem is solved by removing the special case.

--------------------------------------------------------------------------------
30802b1 | gammafunk | 2018-12-10 03:01:12 -0600

Message highlighting for the Gauntlet portal
Add highlighting for all Gauntlet portal timer messages to default
settings.

--------------------------------------------------------------------------------
8ba4ea4 | gammafunk | 2018-12-10 02:55:15 -0600

Better timer messages for the Gauntlet (mikee)
Since Baileys already use the notion of the gate, use a beating drum to
describe the timer of the Gauntlet. The idea being that an instrument
being played calls spectators to watch the combat proceedings or perhaps
calls combatants to enter the arena.

--------------------------------------------------------------------------------
351818a | Edgar A. Bering IV | 2018-12-10 00:42:41 -0500

Add a TAG_MAJOR around a conditional (gammafunk)

--------------------------------------------------------------------------------
873c05a | NormalPerson7 | 2018-12-10 00:23:12 -0500

Add dispersal traps to Zot:5
This commit creates a new function is_regular_trap in traps.cc, which
returns whether a particular trap can spawn from a vault which places
"any trap" (that is, a trap that can be spawned from TRAP_RANDOM).

The primary purpose of this is to add dispersal traps to the
hall_of_Zot, in the hope that it will create interesting and dangerous
situations in Zot:5 with the player having to deal with themself and
their enemies being thrown around everywhere. Regarding the forced trap
locations in Zot:5, dispersal traps should be less punishing than
teleport or Zot traps, since the player can get over the other side
simply by repeatedly entering the trap.

[Committer's note: Edited a comment. Closes #920]

--------------------------------------------------------------------------------
d3cbc84 | Edgar A. Bering IV | 2018-12-09 14:49:46 -0500

Still more change log edits

--------------------------------------------------------------------------------
7a9182e | Edgar A. Bering IV | 2018-12-09 14:41:56 -0500

Further changelog edits

--------------------------------------------------------------------------------
889f499 | gammafunk | 2018-12-09 12:04:47 -0600

Some changelog tweaks

--------------------------------------------------------------------------------
35ae891 | Edgar A. Bering IV | 2018-12-09 12:36:14 -0500

Changelog through 0.23-a0-550-g7de1f8ee9f

--------------------------------------------------------------------------------
7de1f8e | gammafunk | 2018-12-07 15:43:37 -0600

Remove some SUBST for unused subvault glyphs
We use exact matches for all Gauntlet subvaults, since we need to use a
specific shape to guarantee proper alignment. Any glyphs that didn't get
replaced by the subvault would be due to an error, and replacing these
with walls increases the likelihood of said error trapping the player.
So allow these glyphs to simply become floor instead.

--------------------------------------------------------------------------------
e004423 | gammafunk | 2018-12-07 15:42:52 -0600

Extend and rework gammafunk_gauntlet_branching
Add a final arena to both paths for this map. This brings the number of
its arenas more in line with the other maps and makes it not feel like
an abridged version of gammafunk_gauntlet_one_two_three.

Also rework the layout to better use space and allow it to be symmetric
with its new bottom half.

--------------------------------------------------------------------------------
c58ec83 | gammafunk | 2018-12-07 15:15:27 -0600

A new Gauntlet map with progressively more choices
In gammafunk_gauntlet_one_two_three, the first arena is mandatory and
leads to two choices, after either of which the player has three arena
choices. The middle set of arenas are higher difficulty 50% of the time.

--------------------------------------------------------------------------------
1e3a7e1 | gammafunk | 2018-12-07 15:12:04 -0600

Some fixes for a Gauntlet map
Some of the transporter glyphs given in the setup for this map weren't
actually used. Also increase area inside the shortcut path's access to
the second arena. The previous area had only 4 tiles total, possibly
preventing some monsters adjacent to the player from following through
the transporter.

--------------------------------------------------------------------------------
807884b | gammafunk | 2018-12-07 15:12:04 -0600

A couple new Gauntlet monster sets
In one set, a necromancer with death yaks that are potential bind soul
targets, and in another a band of meliai. Both for higher tier
difficulty.

--------------------------------------------------------------------------------
05cfe7a | gammafunk | 2018-12-07 15:12:09 -0600

Balance changes for some Gauntlet monster sets
Use monster bands where the counts we want are close to the natural band
size. Make the hornet set just have hornets, since bees don't do
anything hornets don't already do. Add the possibility for a single,
more middle-tier guardian to some sets. Less use of filler imps, more
hell hounds in their place, but with fewer numbers. Break out a couple
entries specified as two alternates into separate entries so we can have
slightly higher counts for lowest tier monsters.

--------------------------------------------------------------------------------
9cf61d6 | gammafunk | 2018-12-07 15:12:04 -0600

Fix a Gauntlet monster set entry
Will make a function that checks this data on startup in the future.

--------------------------------------------------------------------------------
2dd13d1 | Edgar Bering | 2018-12-07 15:50:05 -0500

Remove a secret dig square (Rawrakai)

--------------------------------------------------------------------------------
e99ae73 | NormalPerson7 | 2018-12-07 11:59:51 -0800

Show blowgun chance on firing with F (11777)
This commit makes it so that both the f and F methods of firing
ammunition end up calling the _fire_choose_item_and_target function,
which sets up the direction chooser with the behaviour required to get
blowgun chances, net immunity descriptions and chaotic descriptions (for
silver ammo) to display.

Previously this function was only called when targeting through f, which
meant that all three of these extra pieces of information were not
provided when firing through F.

--------------------------------------------------------------------------------
48eebcd | advil | 2018-12-07 14:30:47 -0500

Create br.exit milestones for more branches
The initial implementation (49588e8b9b1c) only tracked milestones for
exiting branches that are of size >1 level (and the vestibule), in order
to cut down on milestone spam. This commit expands this to include all
branches that have enemies, because this information is useful for
debugging sometimes, and it won't be that much more data. (I suspect
that the concern came from a time when bots announced a lot more
milestones than they do now.)

If any portal vaults can ever be re-entered, this will only generate
milestones for the first exit. As far as I can tell, all branches
covered by this commit can generate only once outside of wizmode.

--------------------------------------------------------------------------------
b4a7915 | advil | 2018-12-07 11:09:12 -0500

Save compat for 04293e54a7a0
This places an exit under the player (overwriting any features that are
there, so it could overwrite a portal). It is possible for the player to
ignore the exit under some circumstances and get trapped again by taking
a portal, but at that point it's on them. Since the bug wasn't
guaranteed to trigger in this map, this may also provide an early exit
for some players.

--------------------------------------------------------------------------------
3f6f39f | Edgar Bering | 2018-12-06 23:31:27 -0500

Disable met targets after quaffing a potion of experience (11352)
The potion of experience skill menu backed up the player's current skill
training state to allow potion-specific skill selection. Upon restore, the
backup would ignore any met targets and resume training a skill even if the
skill target had been met.

The skill_state object now checks to see if its cached target has been met
on restore, and does not alter the current state if its training information
appears to be out of date.

Finally, a check is added to the potion of experience effect to prompt for
new skilling if targets are met after quaffing the potion.

Closes #886, using a different approach.

--------------------------------------------------------------------------------
7b100e3 | gammafunk | 2018-12-06 20:32:13 -0600

Fix a portal message typo (larvi)

--------------------------------------------------------------------------------
04293e5 | Alan Malloy | 2018-12-06 14:36:21 -0800

Don't trap player in gammafunk_gauntlet_branching (Kierst, NormalPerson7)
The gauntlet_exit subvault was offset by one so all the exits were
being placed upside down.

--------------------------------------------------------------------------------
5e0f5a2 | gammafunk | 2018-12-06 04:08:51 -0600

Remove additional exits from a Gauntlet map
Remove the intermediate exits from gammafunk_gauntlet_branching. It's
better to have maps be more consistent about the use of exits in terms
of not providing many of them. A future map will require the player to
exit through the minotaur if they don't wish to continue through the
arenas.

We might end up going the route of offering the minotaur vault exit as
the only one for all maps, or we might go the route of this map and have
all maps present an initial exit. This could depend on how we decide to
vary the final fight. If there is no initial exit, it's important that
the player know what strong monster they'll be forced to fight before
entering the portal.

--------------------------------------------------------------------------------
1da068c | gammafunk | 2018-12-06 04:08:51 -0600

Add ice statue and oklob plant Gauntlet monster sets
For the lower difficulty tier. These place with a couple appropriate
mobile monsters.

--------------------------------------------------------------------------------
65d9dff | gammafunk | 2018-12-06 04:08:51 -0600

Some balance adjustments to Gauntlet arena monsters
Give some light accompaniment with wizards. Make lower-difficulty eye
sets feature either a shining eye (with mutation potion loot) or an eye
of devastation and having 1-2 floating/golden eyes. Balance the entries
for abominations, death scarabs, shapeshifter, and slimes. Reduce the
number of ugly things that accompany the great orb of eyes so much stuff
with high HP. Give the glowing orange brain a couple ugly friends, since
brains are pretty flimsy.

--------------------------------------------------------------------------------
f0242e9 | gammafunk | 2018-12-06 04:08:51 -0600

Some adjustments for Gauntlet subvaults
Tweaks for most of the arenas to make them not have such a direct path
to the transporter and loot in so many cases. Previously many potential
locations for solid walls weren't added since the would obstruct view of
the landing site or generally lead to too many squares not being visible
from outside the arena. Use transparent stone to ensure visibility and
move the landing site to locations on the other side of these new walls.
Some vaults now have multiple potential landing sites that will be
randomly chosen from during setup.

Introduce some randomized use of iron grates in
nicolae_gauntlet_arena_grate_2. Break up the walls in
gammafunk_gauntlet_arena_hedges, placing more plants-as-walls and using
guaranteed plants to block the path shortest path to the transporter.

--------------------------------------------------------------------------------
f3a0c6f | gammafunk | 2018-12-06 04:08:51 -0600

A Gauntlet map with a long way and a short way
In gammafunk_gauntlet_shortcut the player has a choice between a longer
but easier path and a shorter but harder one. The first path has two
easier arenas followed by a third with a 50% chance to be harder. The
second path has two harder arenas.

--------------------------------------------------------------------------------
6ff5c89 | gammafunk | 2018-12-06 04:08:51 -0600

A Gauntlet map with two long paths
In gammafunk_gauntlet_hard_choice, the player has a choice between two
paths through three arenas. The second arena in each path has a 50%
chance to be harder difficulty, and the third arena in each path is
always harder difficulty.

--------------------------------------------------------------------------------
6525e13 | gammafunk | 2018-12-06 04:08:51 -0600

A Gauntlet main map
This a map for the new portal with more maps to follow in subsequent
commits. gammafunk_gauntlet_arena_branching gives the player a choice of
two branching paths. Each possible path take the player through two
arenas, the second harder than the first.

--------------------------------------------------------------------------------
c8f743d | gammafunk | 2018-12-06 04:08:49 -0600

Setup Lua for Gauntlet main maps
Functions to initialize global variables used by arena subvaults to
match transporters to the main map as well as to determine what
difficulty the main map wants them to use. The setup function also sets
up all transporter features that reside on the main map.

--------------------------------------------------------------------------------
72492bc | gammafunk | 2018-12-06 04:07:55 -0600

Gauntlet exit subvaults
These vaults place a final portal exit, the minotaur, and the loot pile.
All are adaptations of the old lab portal exit vaults to work with the
current layout. The changes I've made are to rotate all vaults to the
same north-to-south orientation, make them subvaults, and to give the
smaller vaults surrounding area to help isolate the minotaur's lair.
This prevents noise from drawing out the minotaur to "camp" the player
near the final transporter landing site.

--------------------------------------------------------------------------------
8f24ca6 | gammafunk | 2018-12-06 04:07:55 -0600

A loot function for Gauntlet exit subvaults
This function places a loot pile on the minotaur's exit with an item
number and composition similar to the old portal. The item count range
is the same the old portal (7 to 16 items with an average of 11.5). The
loot items are 1/3 on-average star_item, which is close to the original
portal's 1/3 chance to have each item be normal class with quality 3 *
depth (star_item is 2 * depth + 5).

The other 2/3 items are a mix of superb_item together with some extra
armour, and some weight for wands and scrolls, since superb_item doesn't
place the latter two. The weights are chosen so that the loot items will
be similar to the custom list used in the old Lab portal. Gone is the
chance for ammo, and the chance for non-wand misc items and staves are
higher, but in general the differences in chances for each kind of item
are not drastic.

The loot definitions for the old portal were likely not chosen with any
particular aim in mind. Also the gauntlet arenas will give the player
4-8 items on the path to the minotaur, depending on the map. This does
require defeating nasty monsters, and the old Lab portal gave vault loot
along the way as well. Still, we may want to reconsider this loot
composition in the future.

--------------------------------------------------------------------------------
2a91107 | gammafunk | 2018-12-06 04:07:55 -0600

Gauntlet arena subvaults
These vaults give a 9x9 area for specifying an interesting feature
layout as well as potential locations for monsters, loot, entry
transporter landing site, and the exit transporter. DES comments
describe what glyphs these vaults must have and what tags and setup
functions they must use.

Many of these are adapted from float vaults in the old Lab portal, and
I've added a few new basic ones as well. We need more of these,
including some creative variants that use special terrain with specific
monsters, but this is a good initial set for play-testing.

--------------------------------------------------------------------------------
136b5b3 | gammafunk | 2018-12-06 04:07:53 -0600

Gauntlet arena subvault Lua
Define functions to set up arena subvault transporters, monsters, and
items. The transporter setup relies on global state variable to give
each transporter a key based on the subvault number. This state variable
is initialized by the main encompass map. A state variable set by the
main map also sets the arena difficulty, which determines the available
arena sets. The setup is broken out into functions so that vaults
wanting to define special monsters and loots can call what setup they
instead of calling the main setup function.

--------------------------------------------------------------------------------
c6bef76 | gammafunk | 2018-12-06 03:26:04 -0600

Gauntlet arena monster sets
This commit defines arena monster sets for two tiers of difficulty. The
sets define one to three related monster sets and define min/max placed
for each. Each set has thematically related monsters that are generally
significantly weaker than the minotaur monster boss. There's an emphasis
on using monsters that might make for an interesting fight for a
character at depths from Lair to D:14, especially for monsters that are
not encountered much in general. Some sets in the same tier are stronger
than others for specific player characters, and some arenas may be too
risky to take on, but this is part of the choice aspect this portal
emphasizes.

--------------------------------------------------------------------------------
9a27e60 | gammafunk | 2018-12-06 03:26:04 -0600

Disable player teleportation in Gauntlets
This portal's layouts have the player choose a one-way path through
arenas with monsters and loot. Teleportation allows the player access to
arenas not along the chosen path, largely defeating the purpose of there
being a choice in the first place. Although teleport scrolls are
limited, they are plentiful and even a single teleport has a high chance
of granting the player access to several new arenas. Unlimited sources
of teleport like the ring of teleportation and the teleportitis mutation
will always let a player loot all areas.

This commit disallows teleports in Gauntlets in the same way as is done
for Sprint. Teleportation scrolls are marked as useless while in the
portal, and attempting to use one aborts with a message. Any passive
form of teleport such as that from the ring, teleportitis, or distortion
is prevented.

--------------------------------------------------------------------------------
58dc622 | gammafunk | 2018-12-06 03:26:04 -0600

Gauntlet: A new portal that replaces Labyrinths
Labyrinths disable autoexplore and force the player to manually solve a
maze, something not related to the kind of gameplay crawl tries to
provide.  There are spoilery aspects to navigating the maze efficiently
and to using teleport in the portal. Once these aspects are known to an
experienced player, they solve the maze with very little thought and
often with great annoyance at having to play this mini-game unrelated to
either tactical combat or strategy. The most interesting aspect of
current Labs is the fight with a single powerful monster, the minotaur.

This commit is the first in a series to implement a new Gauntlet portal
where the player chooses a path through several combat arenas. The
player can see what monsters they'll face and what rewards they'll get
before entering each arena. The portal is similar to Ziggurats in terms
of having progressive rooms with thematic monster sets, but adds a
distinct choice aspect.

Each of the possible paths takes the player through a series of
randomized arena subvaults that have one of two difficulty tiers. Each
arena subvault will having a small group of thematic monsters and a
small amount of loot. All possible paths that could be taken will lead
to the same exit subvault that has boss fight with the minotaur and a
loot pile on the exit stairs. At least one early exit will be provided
at the beginning of the portal before any path is taken, with the only
other exit being guarded by the minotaur.

The number of arena subvaults the player completes in each path will be
small, usually two but it could be three or four on some maps. The
vaults will be accessed via transporters that prevent backtracking by
simply walking out of the vault, and the arenas will not have diggable
walls. All forms of teleportation will be disabled in this portal in a
subsequent commit, but other translocations will work normally.

This portal isn't designed as a maze and doesn't fit the traditional
idea of a Labyrinth, so the new portal will be called a Gauntlet
instead. This commit adds basic data for the new portal and renames any
files being repurposed from the old Labyrinth portal.

This commit also removes the C++/lua code and vaults that won't be
directly used by the new portal. Some of the Lab float and exit vaults
will show up in the new portal with modifications, but we remove these
for now.

For any games saved with an active Lab entrance, that feature is
replaced with an entrance to a Gauntlet. Games saved inside a Labyrinth
will load and the Lab will function normally, except that Lab shifting
won't occur. Since the player is always guaranteed a viable path to
the exit after the shift, the Lab will still be solvable.

--------------------------------------------------------------------------------
1d907f1 | gammafunk | 2018-12-06 02:59:43 -0600

Better documentation and ordering of population lists
These population lists are in order of the branch-type enum. Update to
follow the same order of branch-type when major version changes.

Mention this order dependency in the comments above each list. For the
zombie, water, and lava population lists, add a comment indicating which
branch the entry corresponds to if the entry is otherwise ambiguous.

--------------------------------------------------------------------------------
def993a | gammafunk | 2018-12-06 02:59:44 -0600

Improve branch enum and data ordering for major version change
Branch data and population lists currently depend on the ordering of the
branch-type enum. As long as that's the case, we should maintain a
consistent ordering between this enum and those data when major version
increases.

--------------------------------------------------------------------------------
a799fc4 | Edgar A. Bering IV | 2018-12-05 21:29:27 -0500

checkwhite

--------------------------------------------------------------------------------
3133bb3 | Edgar A. Bering IV | 2018-12-05 21:25:51 -0500

Fix a negative chance in a targeter (hellmonk)
The formula for pacification chance is correct on its domain, but had an
off-by-one in bounds checking.

--------------------------------------------------------------------------------
b7c0781 | Edgar Bering | 2018-12-05 16:32:16 -0500

Improve teleportitis/teleport trap effect messaging
Print a "reason" string before translocating, so the player can tell
whether the teleport was a trap or from teleportitis.

--------------------------------------------------------------------------------
0f8c245 | Edgar Bering | 2018-12-04 13:55:15 -0500

Do not include explore traps in sprint and tutorial
The individual trap effects had appropriate checks, but this adds an
explicit check to make the decision intensional, should future trap effects
not check for sprint/tutorial.

--------------------------------------------------------------------------------
898447a | Edgar Bering | 2018-12-04 11:38:52 -0500

Better trap-effect sequencing
Trap effects (shaft and teleport) can reveal new tiles, leading to the
you.trapped variable being re-set to true. Subsequently the player can get
trapped on their next turn even if they don't move and LOS doesn't change,
which is unintuitive.

This gives players a bit of a break post-trap. If chain-trapping in a single
turn is desired, it should be implemented in a loop in _check_traps().

--------------------------------------------------------------------------------
dd405ac | Edgar A. Bering IV | 2018-12-04 10:05:32 -0500

Don't roll traps on turn 0
That was just a little much. Turn 1 is still fair game though!

--------------------------------------------------------------------------------
0b42d88 | gammafunk | 2018-12-04 05:54:57 -0600

Update trap descriptions
Add a description for dispersal traps and mention in the descriptions
this trap, alarm traps, and zot traps how your allies will avoid
stepping on them.

--------------------------------------------------------------------------------
50a8178 | CanOfWorms | 2018-12-03 23:14:20 -0500

Fix a connectivity issue in the_grid
The center of this vault could be disconnected depending on
the subvault generation. This change should fix the issue.
--------------------------------------------------------------------------------
809d6d0 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Add teleports as an explore trap effect (gammafunk)
Instead of a random teleport, they are a teleportitis-type teleport.

--------------------------------------------------------------------------------
c2dc926 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Flip the dispersal trap tile (CanOfWorms)
Accessiblity change for colourblind players.

--------------------------------------------------------------------------------
34af30c | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Add dispersal traps to some vaults
Add dispersal traps to vaults that use teleport traps if it seems
appropriate. Mostly Xom vaults. Also adds a mini_feature vault with the
traps and some ziggurat furniture with them.

--------------------------------------------------------------------------------
10964a4 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Add a tile for dispersal traps

--------------------------------------------------------------------------------
f51f6a3 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Reduce the trap rate further
Based on play-testing.

--------------------------------------------------------------------------------
e646171 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Re-order some player cleanup in floor_transition
The previous order could lead to invalid constriction data if the player
revealed a tile and got trapped while constricting a monster (due to a
cloud effect, for example). Currently clear_beholders and
clear_fearmongers don't reference the monster grid, but they are
properties of the level that we're leaving (and touch a vector that
references the monster grid), so the call belongs before
we save the old level and load the new one.

--------------------------------------------------------------------------------
53fc6d5 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Tone down the explore trap rate
It was too aggressive. Additionally, don't default to alarming if shafts
are impossible.

--------------------------------------------------------------------------------
ba9ec10 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Refactor to prevent a crash
Separate the calculation of trap-effect chance from firing the effect,
similar to banishment. Otherwise, we might shaft the player in the
middle of some other state update, leading to invalid dereferences.

--------------------------------------------------------------------------------
d1cacb9 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Derandomise num_traps_for_place
Replace num_traps_for_place with trap_rate_for_place, so that it can be
used appropriately in both trap-generation and explore-trap-effect
formulas.

--------------------------------------------------------------------------------
f44f1ef | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Lowercase a trap name in a des

--------------------------------------------------------------------------------
723c74f | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Don't make alarm traps permanent (MarvinPA)
If a player found a permanent alarm trap in favorable terrain they could
repeatedly become marked to clear the level.

--------------------------------------------------------------------------------
e407b66 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Keep friendlies out of traps that affect the player
Previously this behavior was limited to Zot traps. It is now abstracted
to is_bad_for_player, and alarm and dispersal traps are included in the
list.

--------------------------------------------------------------------------------
17e7bed | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Add dispersal traps
Dispersal traps are permanent, and when triggered cause everything in
sight of the trap to blink, including the triggerer.

The purpose of dispersal traps is to provide an alternative for known
teleport traps that is more interesting tactical terrain. The effect
destroys a player's positioning, so if it is good the player will want
to prevent monsters from stepping on the trap. On the flip side, it can
provide a positional rearrangement in a bad situation, though preserving
a good result may be challenging since the trap is permanent.

--------------------------------------------------------------------------------
db6bce5 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Zot-ify alarm traps
Alarm traps now only trigger when the player can see them. When they do,
whether it was a monster or a player, the player gets marked. They are
now permanent and considered passable terrain by the dungeon builder.

--------------------------------------------------------------------------------
0f39d50 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Exploration based trap effects.
Each tile revealed has a small chance (the chance of generating a shaft
trap on that tile for that particular level) of shafting or alarm
trapping (thanks gammafunk) the player.

With all traps known the 'interesting situation' aspect of shaft (and
other) traps was lost. This random explore effect recovers that aspect.

It does mean that a player wishing to avoid traps should avoid revealing
tiles. This is a better trade-off than the previous behavior.  While the
'optimal' play is to not reveal more tiles than necessary, the act of
revealing (instead of stepping on) has the potential benefit of giving
an item or XP from an easy monster. Further, unlike tracking stepped on
tiles, the UI makes it possible to reason about what moves will reveal
tiles; and waypoints provide a method of charting particular routes
through partially explored areas.

However, as minmay has pointed out, Gnolls, Xom, and Ash all give item
detection which allow a player to avoid revealing tiles that they know
will give no benefit. While minmay presents this as a problem, I see it
as a benefit of item detection.

--------------------------------------------------------------------------------
450027e | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Remove trap detection from wizmode
Now obsolete.

--------------------------------------------------------------------------------
ed22641 | Edgar A. Bering IV | 2018-12-03 22:25:24 -0500

Reveal all traps
Reveal all traps, so that they can be tactically relevant terrain. This
removes the "generate tension" aspect of traps, which will return in a
later commit.

Having all traps be known requires some shaft tweaks. Specifically:

Taking a known shaft now has an equal chance of taking you 1/2/3
levels deeper. Shafts now generate on the penultimate level of a branch
with a dangerous end.

--------------------------------------------------------------------------------
91793a9 | NormalPerson7 | 2018-12-02 16:24:24 -0500

Display the chance for needles to work in blowgun targeter (ebering)
When targeting a blowgun with sleeping/paralysis/confusion/frenzy
needles, display the chance for the needle to affect the targeted
monster in the targeter, or "immune to needles" if the monster is undead
or nonliving.

--------------------------------------------------------------------------------
70bc44f | Edgar A. Bering IV | 2018-12-02 16:01:16 -0500

Improve the pacification chance display (11775)
Correctly report when targeting an unpacifiable monster.

--------------------------------------------------------------------------------
0f366d8 | Edgar A. Bering IV | 2018-12-02 13:37:16 -0500

Describe the restrictions on exploration piety
Mention it in the Temple description. After some discussion, the current
description "explore the world" is good enough, since many players
already bring preconcieved notions of terrain. It would be nice to
explain the specific mechanic somewhere but this is ok.

--------------------------------------------------------------------------------
3d1613b | Edgar A. Bering IV | 2018-12-02 13:37:16 -0500

Don't grant explore piety for certain terrain
Granting exploration piety for deep water, lava, and "endless" features
encouraged players with flight or deep water swimmers to wander around
the non-threatening boundaries of shoals and certain lava vaults.

Granting exploration piety in the Temple encouraged a player to
autoexplore the threat-free temple.

--------------------------------------------------------------------------------
e7ea69a | Alan Malloy | 2018-12-01 22:43:55 -0800

Make cheibrodos_fertilizer no_tele_into
It's a pretty nasty enclosed space to get shafted into on D:2, as pointed out 
by /u/DeadKateAlley.
--------------------------------------------------------------------------------
205b0b6 | gammafunk | 2018-12-01 06:07:48 -0600

Fix a potion loot definition
This definition had a leading '/'.

--------------------------------------------------------------------------------
5fd82c5 | Edgar A. Bering IV | 2018-11-30 19:27:16 -0500

unbrace and don't unbrace deleted files

--------------------------------------------------------------------------------
c625362 | Nikolai Lavsky | 2018-11-30 17:25:47 -0500

Fix messaging when Maurice steals a weapon (Salmon, Stenella)
When Maurice steals a weapon, the games says
  Maurice steals <weapon>...
  Maurice wields <weapon>...
  It bursts into flame!/Its appearance distorts for a moment./etc.
even though the weapon always goes into his alternative weapon
slot (unless Maurice's disarmed).

The same happens if you give an "alt"-inscribed weapon to a
monster via the xo wizard command.

Fix this, and also simplify some monster equip code.

Instead of passing "bool msg" into monster::equip() and, subsequently
into equip_weapon(), equip_armour(), or equip_jewellery(), just don't
call equip() if this value is false. Previously, all these functions
did nothing unless msg was true. These functions are also renamed to be
more descriptive; they do not equip the item, only print the message.

[Committer's note: Closes #911]

--------------------------------------------------------------------------------
b50937e | gammafunk | 2018-11-30 05:01:23 -0600

Some loot definitions for auxiliary armour
It's a common to define all possible aux armour as a loot item in vaults
and error-prone to type all the names each time. Make item definitions
available as dgn.aux_armour, dgn.good_aux_armour, and
dgn.randart_aux_armour for normal, good_item, and randart quality items
of this kind.

I'll modify various vaults to use these definitions in subsequent
commits.

--------------------------------------------------------------------------------
f9e11c5 | gammafunk | 2018-11-30 05:00:26 -0600

Fix and update a scroll loot item definition
In the dgn.loot_scrolls item definition variable used by some vaults,
the entry for scroll of enchant weapon was copied three times. Make this
one entry with a reasonable weight. Flatten the weights somewhat to make
scrolls of enchant weapon, enchant armour, and brand weapon all a bit
more common. Update the comments to better describe the intent of these
definitions.

--------------------------------------------------------------------------------
29ba69c | Edgar Bering | 2018-11-29 18:11:56 -0500

Further adjustments to confused monster actions
Simplify some boolean checks and add confusion to one. Re-name an internal
function. Re-impair confused monsters judgements so they resume stumbling
into harmful clouds, deep water, lava, and other bad situations.

--------------------------------------------------------------------------------
32a748b | Alan Malloy | 2018-11-29 09:33:31 -0800

Mark some local functions as static to fix compiler warnings

--------------------------------------------------------------------------------
dce9051 | Alan Malloy | 2018-11-29 09:00:09 -0800

Change inscription on Fencer's Gloves (Yermak)
Previously, +Riposte was the only +Foo inscription that didn't give you an
active ability (e.g., +Blink for evocable blinking).

--------------------------------------------------------------------------------
60b89c1 | Edgar A. Bering IV | 2018-11-28 23:04:20 -0500

Link the contribution guide from README
Make the updated contribution guide more discoverable via github. The
README also has some contribution information, these two documents could
be harmonized more.

--------------------------------------------------------------------------------
1869896 | Edgar A. Bering IV | 2018-11-27 22:09:08 -0500

Don't unconfuse intrisically confused monsters
Restore important lines to mon-behv to ensure that confused species
wander randomly.

--------------------------------------------------------------------------------
35efe26 | Edgar A. Bering IV | 2018-11-27 21:30:28 -0500

Nerf player-to-monster confusion
Confused monsters now always try to set a target. One chance in three a
monster is able to move toward or attack its target; though spells, most
abilities, evokables, etc. are still forbidden. Confused monsters are
still stabbable. If this proves too subtle a nerf this can be upped to a
coinflip.

The reasons for doing this are twofold. One, Confusion as an effect is
available to players at level 1 or 3 in spells, the latter in a starting
book. Confusion was effectively a temporary instant kill, which is an
extreme effect to provide at such a low level, even with checks. Two,
the temporary instant kill was annoying to make permanent because the
monster would wander away while the player attacked it.

This commit also cleans up some of the mon-act code, specifically
removing some dead confusion handling code from the movement handler
that was not executing before this patch.

--------------------------------------------------------------------------------
22ffb11 | Edgar A. Bering IV | 2018-11-27 18:33:17 -0500

Convert Death Channel/Bind Soul to fineffs
This resolves the long standing occasional "fireball/iceblast/etc." hit
your newly formed spectral friend and make it hostile.

--------------------------------------------------------------------------------
da178e9 | Edgar A. Bering IV | 2018-11-27 18:31:22 -0500

Remove the storm bow's rain clouds
Placing occasional temporary shallow (or deep) water at random was
usually flavour and occasionally very annoying.

--------------------------------------------------------------------------------
6e8b230 | Edgar A. Bering IV | 2018-11-27 18:31:22 -0500

Revise the robe of Clouds
The old robe of clouds was basically a +3 {rElec +Fly} robe; it's
gimmick of spawning mist and rain was almost always flavour.

The new robe is now +3 {+Thunder rCloud rElec}, losing the mist gimmick
in favor of evokable radius 2 storm clouds. The evocation costs 5 MP and
has the same difficulty rating as evokable invis.

--------------------------------------------------------------------------------
d9f91f9 | Edgar A. Bering IV | 2018-11-27 18:29:02 -0500

checkwhite

--------------------------------------------------------------------------------
ee2f500 | stenella | 2018-11-27 15:00:30 -0800

MSVC support cont.
Update gen-all.cmd to be up to date with the current makefile,
namely adding aptitudes and crawl_manual.txt, which stops
MSVC builds from crashing when they can't find the files.

Add some more MSVC build outputs to gitignore
Copy CREDITS.txt from the root directory to docs/CREDITS.txt
to match the makefile/release versions; add it to gitignore.

Change MSVC/stdint.h to match MSVC/include/stdint.h , which
we changed earlier in the first MSVC compatability commits.

--------------------------------------------------------------------------------
c8aadda | gammafunk | 2018-11-26 20:37:39 -0600

Update comments describing the Branch struct

--------------------------------------------------------------------------------
db311f7 | gammafunk | 2018-11-26 20:37:38 -0600

Update marker info in the DES syntax guide
Markers are no longer used for several of the cases mentioned.

--------------------------------------------------------------------------------
87d5157 | gammafunk | 2018-11-26 20:37:36 -0600

Fix some lua loot definitions
I don't think this caused any errors, but these trailing slashes are not
needed.

--------------------------------------------------------------------------------
6f7cfd9 | Edgar A. Bering IV | 2018-11-25 20:18:00 -0500

Unrelocate some on-sight logic (gammafunk)

--------------------------------------------------------------------------------
b5b494a | Edgar A. Bering IV | 2018-11-25 20:00:36 -0500

Make player ghosts and pan lords immune to pacification
Both player ghosts and pandemonium lords have wildly varying HP. While
these numbers are revealed in the former case, player ghosts are a
somewhat special monster. In the latter case the revealed HP based on
monster class is a lie, and the variance in max hps is larger due to how
pandemonium lord max hp is calculated. To avoid edge cases with these
two monster types this commit makes both types immune.

--------------------------------------------------------------------------------
28a1794 | Edgar A. Bering IV | 2018-11-25 20:00:36 -0500

Display pacification chance in Heal Other targeter
With the changes to pacification to depend only on numbers visible to
the player, it is now not an information link to display pacification
chance in the pacification targeter.

This also changes pacification to abort when used on monsters which are
truly impossible to pacify (as opposed to those whose pacification
chance rounds to 0% in the display).

--------------------------------------------------------------------------------
cf71bd9 | Edgar A. Bering IV | 2018-11-25 20:00:36 -0500

Simplify Heal Other formula
Previously, pacification checked if

    1d( int_mod * (invo + 1) * healing / holi_mod ) >= avmhp

Healing depended on power by a random roll, which depended on a random
division of invocation skill.

The new formula checks if

biased_random2( int_mod * (invo + 1) * (30 + invo) / holi_mod, 2) >= avmhp

30 + invo passes through the function as the power value, and is also
used to determine how much to heal the target, which is left unchanged.
biased_random2(sides, 2) does a good job of matching the old success
distribution and is easier to reason about and write a chance success
display for (see next commit).

--------------------------------------------------------------------------------
b59e870 | Edgar A. Bering IV | 2018-11-25 20:00:36 -0500

Change pacification to depend only on monster type
Pacification depending on a monster's max hp made it harder to reason
about (why should one jackal be harder to pacify than another). Average
HP for the monster type is displayed in monster info.

--------------------------------------------------------------------------------
8f93ed4 | Edgar A. Bering IV | 2018-11-25 20:00:00 -0500

Prevent invalid_monster messages when converting
036aa52 dismisses summoner's summons on attitude change. One place where
attitude changes is on bribe or Beogh follower acquisition. If this
happens on the turn the summoner comes into view and their summons are
already visible those now expired summons need to be filtered out after
the summoner's conversion occurs.

--------------------------------------------------------------------------------
7bc77c8 | Edgar A. Bering IV | 2018-11-25 20:00:00 -0500

Relocate some on-sight logic to the correct place

--------------------------------------------------------------------------------
abef753 | gammafunk | 2018-11-25 18:14:40 -0600

Some changelog updates (now through 0.23-a0-462-g7c42f869)
Mention a few items missed in the last update, reword a few items, and
fix a couple typos.

--------------------------------------------------------------------------------
7c42f86 | Edgar A. Bering IV | 2018-11-25 18:06:49 -0500

Nerf the acid effect of minor destruction
The formula for power / 2 (versus power for the rest) goes back to the
svn initial revision. Acid was buffed in 8761da415 which intended only
to buff player dracs, but also buffed Makhleb's minor destruction.

This increases the power divisor significantly, to make the damage curve
for acid closer to (but still to the right of) flame. The effect is
still very strong (rarely resisted, chance to corrode).

--------------------------------------------------------------------------------
ff60f68 | Edgar A. Bering IV | 2018-11-25 16:47:09 -0500

checkwhite INSTALL.txt

--------------------------------------------------------------------------------
9be7e05 | Edgar A. Bering IV | 2018-11-25 16:46:46 -0500

changelog through 0.23-a0-459-ge787970

--------------------------------------------------------------------------------
e787970 | stenella | 2018-11-25 10:03:44 -0600

Rest the Ancestor
Add a delay interrupt that executes when the ancestor heals to full HP.
This is facilitated by a new check for ancestor HP being full; this is
always true if the ancestor doesn't exist or is out of sight (to avoid
information leaks).

Introduce a new boolean option rest_wait_ancestor to toggle whether resting
should always wait until the ancestor is healed. This interacts with
rest_wait_both according to the following table:

| rest_wait_both | rest_wait_ancestor | expected behavior              |
| -------------- | ------------------ | ------------------------------ |
| True           | True               | Rest until (HP full and
                                        MP full and Ancestor full)     |
| False          | True               | Rest until (HP full or MP full)
                                        and (Ancestor full)            |
| True           | False              | Rest until (HP full and
                                        MP full) or (Ancestor full)    |
| False          | False              | Rest until (HP full or MP full
                                        or Ancestor full)              |

[ Committer's notes: Closes #900. Tweaked some conditionals, adding some
  missing conditions or simplifying. Added some comments. Tweaked the
  wording of the option. Adjusted the interrupt to not leak information
  about the ancestor when it is out of LOS. ]

--------------------------------------------------------------------------------
93a6ea9 | stenella | 2018-11-25 11:26:50 +0800

MSVC gitignore
Exclude MSVC outputs
Modify vcproj exclude to include vcxproj files

--------------------------------------------------------------------------------
6f6daef | gammafunk | 2018-11-24 18:41:10 -0600

Add more checks for invalid constrictions
Usually monster death handles the necessary constriction cleanup, but
there are cases involving e.g. summons where a summoner's death can lead
the constriction code to attempt to constrict a summoned monster that's
been reset.

This commit adds aliveness checks to the methods that check for invalid
constrictors and constrictees to unconstrict and also requires aliveness
before attempting to apply damage.

--------------------------------------------------------------------------------
c514d67 | NormalPerson7 | 2018-11-24 11:28:03 -0500

Don't let Ru offer mummies the no potion heal mutation (11750)
No potion heal has no real effect on mummies since they can't quaff
potions anyway, so this sacrifice didn't really give up anything.

--------------------------------------------------------------------------------
e12115f | NormalPerson7 | 2018-11-23 21:07:20 -0500

Don't halve the MR of magic immune creatures from AF_VULN (11754)
Previously phantasmal warriors were able to halve the MR of magic immune
creatures, which was announced and appeared to have an effect even
though it really had no effect whatsoever.

Hence, add a check to exit the case for AF_VULN early if the defender is
immune to hostile enchantments.

--------------------------------------------------------------------------------
ae4fabd | Edgar A. Bering IV | 2018-11-23 15:06:03 -0500

Disallow Twisted Resurrection for Enslaved Souls (Doesnty)
This worked exactly like the old player spell, allowing access to
permanent allies that used stairs and bypassed Yred limits.

Closes #889

--------------------------------------------------------------------------------
e0e9ef7 | NormalPerson7 | 2018-11-23 12:35:20 -0500

Let the sturdy frame mutation reduce stealth/dodging penalties
Previously, the sturdy frame mutation was taken into consideration only
for the adjusted_armour_evasion_penalty method, not the
unadjusted_armour_evasion_penalty. The latter of the two methods is used
for stealth penalties, Jiyva stat shuffling, autotraining and some parts
of the dodging penalty calculations, which means these things were not
affected by the sturdy frame mutation. This meant the claimed ER-2 of
the sturdy frame mutation did not have the full effect of reducing the
ER by 2.

Hence, move the sturdy frame mutation's effect to
unadjusted_armour_evasion_penalty.

--------------------------------------------------------------------------------
453ed5a | Edgar A. Bering IV | 2018-11-23 12:20:01 -0500

Don't extend Ru's aura through glass (0011769)
Monsters can't make attacks through glass, so they should not have their
attacks redirected.

--------------------------------------------------------------------------------
1044d4c | NormalPerson7 | 2018-11-21 16:49:30 -0500

Fix a hints mode memorise menu message from extending horizontally
The text from hints_target_mode was not properly broken up.

--------------------------------------------------------------------------------
b6f590f | Edgar A. Bering IV | 2018-11-21 13:33:27 -0500

Buff the scythe "Finisher"
Another entry in the unrand revision project. Finisher, as a speed
scythe, was still not good. This commit removes Str+3 (random stat
sticking) in favor of giving it an instant kill mechanic.

The scythe now has a (50 - hd) / 200 chance of exploding a monster into
chunks on any hit where damage is done. This translates to slightly
worse than 1/4 chance against popcorn, decreasing to a 1/10 chance
against an orb of fire. Compare to distortion's 3/20 odds of either
banishing or instant teleporting a monster.

--------------------------------------------------------------------------------
8e4cbf7 | gammafunk | 2018-11-20 16:46:47 -0600

Disallow Sticks to Snakes under sacrifice love (Reeces)
This is an ally creation spell that would only create hostile allies
under sac love. Disallow use of this spell with sac love as we do for
all ally-creating summon and derived undead spells.

--------------------------------------------------------------------------------
1c01f63 | gammafunk | 2018-11-18 22:40:00 -0600

Fix exclusions for stationary monsters behind solid features (paterick)
Commit 57debff0 had exclusions not continue past solid features for
stationary monsters, but this doesn't create a proper exclusion in all
cases. In particular, such monsters can act behind solid features like
grates and statues that block line of effect but not line of sight, and
we want exclusions to continue past such features. The vault
minmay_statue_bubble is an example of placing a statue monster behind
granite statues where the current logic makes an incorrect exclusion.

The opacity class we want is mostly opacity_no_trans ("no
translocations"), but that rule considers half-opaque features like
clouds that change quickly over time. Hence this commit makes an
opacity_fully_no_trans class that ignores half-opaque features and has
exclusions for stationary monsters use this class.

--------------------------------------------------------------------------------
7b583b2 | Alan Malloy | 2018-11-18 13:27:19 -0800

Update robe of vines text (Angani, #11765)

--------------------------------------------------------------------------------
036aa52 | gammafunk | 2018-11-17 13:31:44 -0600

Expire a monster's summons upon attitude change (7730)
Currently, if a monster's attitude changes due to being
charmed/uncharmed, pacified, or slimified, any of its active summons
keep the summoner's old attitude. This is awkward in the case of slimify
and pacify, since the player can't then kill the slimified/pacified
monster to remove its hostile summons without incurring penance.
Additionally, for neutral monsters as well as for charmed monsters (e.g.
wand of enslavement), their own summons will begin to attack them upon
attitude change. The player might expect summons to convert to the new
attitude of their summoner. However with either that approach or the
current one of no conversion, the player is encouraged to game the
timing and AI of monster summon spells to either avoid danger or get
easy damage on the summoner.

This commit has any monster's summons abjure when its attitude changes
for any reason. This includes whenever a monster is slimified, pacified,
bribed with gozag, or becomes charmed/uncharmed via enslavement.
Non-spell summons like the Royal Jelly Spawns and monster-created
derived undead like the necromancer monster's simulacra are not affected
by this change.

This commit also removes code to convert a battlesphere's attitude upon
attitude change of its summoner, since that's no longer needed.

--------------------------------------------------------------------------------
768d57b | gammafunk | 2018-11-16 02:03:22 -0600

Add TAG MAJOR for a shadow trap summon enum value
This won't be needed after we bump the major version.

--------------------------------------------------------------------------------
76343ca | gammafunk | 2018-11-16 01:45:04 -0600

Remove an unusaged function argument

--------------------------------------------------------------------------------
a32dbc5 | gammafunk | 2018-11-16 00:53:54 -0600

Some monster and loot vaults from minmay
All save one early dungeon vault are 098 vaults that place monsters and
loot in abstract or geometric arrangements. They are float vaults or
minivaults depending on size and use of exits. One large vault has
bottom orientation since it spans the entire bottom of the level.

Nearly all changes from the original submission are to fix small DES
errors or to reformat lua code. I did add lower weight to one vault that
places a high item count.

--------------------------------------------------------------------------------
db6ba40 | gammafunk | 2018-11-16 00:52:37 -0600

Some shop vaults from minmay
A pre-Lair shop with 'used' weapons: good base types that have no ego
and -1 to -4 enchantment.

A shop that's takin' it easy with Cheibriados. It sells plate armour,
crystal plate armour, or unrands that all have ponderous ego.

A jewelry shop featuring enchantable jewelry types.

A shop of 'mayhem' featuring weapons and spells that have AOE.

Finally, a 'Mass Market' featuring weapons, armor, and ammo that could
be considered heavy (rip player burden).

--------------------------------------------------------------------------------
ce47f42 | gammafunk | 2018-11-16 00:48:07 -0600

Clean up tags on some shop vaults
Add transparent tag for vaults missing this, using a KMASK for one vault
with a disconnected decorative area. Remove no_trap_gen for vaults which
don't need this. Add the extra tag for vaults that don't place any
monsters or loot.

--------------------------------------------------------------------------------
b1ff92d | gammafunk | 2018-11-16 00:48:08 -0600

Derandomize use of the 'transparent' tag
The randomized setup function used in many of Kennysheep's vaults gives
a vault the transparent tag based on a random roll. This tag should be
used whenever a vault has multiple entrances running through the vault
and where the vault either has no disconnected areas or these areas
properly have a KMASK with the opaque tag applied. This is to help
levels generate fewer vetoes, since otherwise the validator assumes a
vault is impassible for connectivity purposes. Hence its use shouldn't
be randomized. Have the setup function used for these vaults
unconditionally place this tag.

--------------------------------------------------------------------------------
b8f687f | gammafunk | 2018-11-16 00:45:50 -0600

Some Temple entry vaults from minmay
Temple branch entry vaults, most of which have abstract or geometric
themes. The exceptions to this are a vault that generates items (themed
as an 'offering') and another with a single orc priest guarding the
entrance.

--------------------------------------------------------------------------------
d959f4f | gammafunk | 2018-11-16 00:14:27 -0600

Add some section markers to temple.des

--------------------------------------------------------------------------------
ef876f6 | Edgar A. Bering IV | 2018-11-16 00:06:33 -0500

checkwhite and delete MSVC build byproducts

--------------------------------------------------------------------------------
57debff | stenella | 2018-11-15 23:33:19 -0500

Don't autoexclude past glass sometimes (11658)
When placing an exclusion on a stationary monster don't extend the
exclusion past glass.

[Committer's note: Closes #892, checkedwhite and reworded]

--------------------------------------------------------------------------------
79ed067 | NormalPerson7 | 2018-11-14 22:55:50 -0500

Mention Ijyb and Maurice's wand-carrying
[Committer's note: Closes #899. Tweaked some wording.]

fixup! Mention Ijyb and Maurice's wand-carrying in their descriptions

--------------------------------------------------------------------------------
50e03f5 | Edgar A. Bering IV | 2018-11-14 22:13:29 -0500

Tweak a new arrival vault (gammafunk)
Consistent stone usage and a no_item_gen KMASK.

--------------------------------------------------------------------------------
bb43e84 | Edgar A. Bering IV | 2018-11-14 21:48:07 -0500

An early lizard minivault (WanderingBlade)

--------------------------------------------------------------------------------
7259ab3 | Edgar A. Bering IV | 2018-11-14 21:48:07 -0500

Update CREDITS

--------------------------------------------------------------------------------
b76f445 | Edgar A. Bering IV | 2018-11-14 21:48:07 -0500

Some variable vaults (WanderingBlade, 11140)
A decor river bridge.

A guarded_unrand vault for the ratskin cloak featuring hell rats at a
very early depth.

An evil kobold church, from the same sect as those kennysheep sewer
kobolds.

--------------------------------------------------------------------------------
ed1f8b9 | Edgar A. Bering IV | 2018-11-14 21:48:07 -0500

A shower themed Vaults entry (ximxim, 10658)

--------------------------------------------------------------------------------
68ef482 | palyth | 2018-11-14 21:48:07 -0500

A winding forest swamp entry vault (11061)

--------------------------------------------------------------------------------
4de353c | Edgar A. Bering IV | 2018-11-14 21:48:07 -0500

KennySheep inspired adjustments to a sewer (10035)

--------------------------------------------------------------------------------
79c5e3b | Edgar A. Bering IV | 2018-11-14 21:48:07 -0500

Branch entry vaults (skrybe, 11232)

--------------------------------------------------------------------------------
0b3e9c9 | Edgar A. Bering IV | 2018-11-14 21:48:06 -0500

Multi-coloured glass columns for Zot (Skrybe, 11232)

--------------------------------------------------------------------------------
44191be8 | Edgar A. Bering IV | 2018-11-14 21:48:06 -0500

A decorative Xom vault for Snake (Skrybe, 11133)

--------------------------------------------------------------------------------
ee0713f | Edgar A. Bering IV | 2018-11-14 21:48:06 -0500

New arrival vaults (WanderingBlade, 11132)

--------------------------------------------------------------------------------
796c40d | Edgar A. Bering IV | 2018-11-14 21:48:06 -0500

An arrival vault (Beargit, 11400)

--------------------------------------------------------------------------------
30b1108 | gammafunk | 2018-11-13 21:38:18 -0600

Describe the enchantment of dancing weapons
This commit includes the enchantment in any dancing weapon description.
Curse state is not included to keep the description shorter, just as we
do when describing wielded weapons for other monsters. Curse info will
still be revealed for the weapon when the dancing weapon is destroyed.

--------------------------------------------------------------------------------
923571c | gammafunk | 2018-11-13 21:38:18 -0600

Remove a redundant message about dancing weapons
Currently when a dancing weapon comes into view, it generates a
"...comes into view" message with a followup "It is a..." containing the
exact same information. The second message used to be part of Ash's
passive monster equipment identification, where the first message had
less information and the second contained more information ("Ashenzari
warns you: ..."). Now that monster equipment is always identified when
the monster is first seen, we don't need the second message.

--------------------------------------------------------------------------------
8c0b414 | gammafunk | 2018-11-13 21:38:18 -0600

Reveal equipment for monsters behind glass
Before this commit, monster equipment was only revealed when the monster
actually generated an interrupt. Monsters behind glass don't generate
interrupts, so their equipment wasn't getting identified. We now
identify equipment unconditionally when a monster is seen.

The equipment identification call for interrupts currently has to remain
due to message ordering, since travel messages happen before seen
monsters are processed. It may be good to refactor travel code so that
this doesn't happen. Another possibility is to set all relevant monster
equipment as identified when the monster is created, preventing the need
for any equipment identification pass.

--------------------------------------------------------------------------------
0174fd8 | Aidan Holm | 2018-11-11 11:17:33 +0800

Fix menu item rendering bug
The row height calculated for the last menu item did not include
padding, which caused it to appear vertically cramped.

--------------------------------------------------------------------------------
8871014 | stenella | 2018-11-11 10:56:53 +0800

Fix typo/color layering bug in tutorial
Due to the way strings are formatted after
being read from this function, this
</magenta> tag was being treated as extra
text. It's not needed, so remove it.

Fix a grammar oopsie.

--------------------------------------------------------------------------------
f02c810 | advil | 2018-11-09 08:44:38 -0500

Validate file pointer when loading help parts
This might be better to handle without a crash at all, but right now
there is a possible segfault in fgets if something is wrong with this
file, so check it explicitly. Possibly these files should be explicitly
validated on game load in addition (I think only their containing folder
is right now).

--------------------------------------------------------------------------------
33f1def | gammafunk | 2018-11-08 18:48:30 -0600

Remove a vault that breaks autoexplore (minmay)
Removed by request of the vault author. The vault
minmay_item_behind_shaft generates a corridor with a shaft at the end in
front of an item. If you recognize this vault you'll dig into it,
apport, use allies to trigger the hidden shaft, or just return when the
level below is cleared. If you don't recognize it, you'll autoexplore
into it, always triggering the shaft. To some extent all vaults that
place hidden traps are spoilery, but this is an egregious case. Consider
this elf flogged.

--------------------------------------------------------------------------------
4fac8996 | advil | 2018-11-08 19:37:47 -0500

Potential fix for Mojave black screen issues
Workaround based on:
https://discourse.libsdl.org/t/macos-10-14-mojave-issues/25060
This may be fied in SDL2 master, in which case we should revert this
workaround and update the submodule, when it gets released.

--------------------------------------------------------------------------------
0aa8dd0 | Aidan Holm | 2018-11-08 21:56:56 +0800

Limit extra Ru ability info to followers (amalloy)
The Ru sacrifice ability description contains code for showing sacrifice
significance and piety gain, which crashed if the player was not
following Ru for some abilities. This commit simply hides that line
of text, as well as mutation-specific text for sacrifices that add
mutations, and re-enables using the ability description view for
?/A, which is currently the only way for non-followers to view the
description.

--------------------------------------------------------------------------------
57a8110 | gammafunk | 2018-11-08 00:49:00 -0600

Refactor LOS attack spell code
Use _player_hurt_monster() to apply damage and handle sanctuary checks
and wound messages. Also use refs instead of pointers where possible.

--------------------------------------------------------------------------------
15b4f39 | gammafunk | 2018-11-08 00:49:00 -0600

Centralize conducts for some player damage spells
For player spells that don't use a struct bolt to apply damage, have
them use the now-generalized _player_hurt_monster() function. This
centralizes the handling of aspects like Zin's sanctuary, god conducts
(for most instances), and printing wound messages. Previously this logic
was repeated throughout spl-damage.cc, with some spells not properly
applying sanctuary rules or having god conducts applied in all cases.

--------------------------------------------------------------------------------
0eb21a9 | gammafunk | 2018-11-08 00:20:42 -0600

Fix and simplify god conduct code
The god_conduct_trigger class currently has separate functions to enable
and disable the conducts to go along with set_attack_conduct(). This is
so that conducts could be conditionally enabled at a time when the
relevant monster might have died, but this functionality isn't actually
necessary for any current god conducts. In all cases we've ensured that
the monster is alive before effects or damage happen, and in all cases
we want to apply these conducts if the effect kills the monster.

This commit enables the conduct at the time set_attack_conduct() is
called and removes the enable/disable functions. Additionally
set_attack_conduct() is refactored to take a ref instead of a pointer.

This commit also fixes god conducts being applied too late for melee and
ranged combat, and cleans up the god conduct code for some spells.
Before this commit, melee and ranged attacks against allies would not
actually apply the conduct if the attack killed the ally.

It might be best to replace the use of a scoped god_conduct_trigger
variable and destructor with a simple function call. Message ordering is
the only thing that might complicate this.

--------------------------------------------------------------------------------
15caca4 | gammafunk | 2018-11-08 00:11:18 -0600

Don't prompt for the Arc Blade spell effect
If the player triggers static discharge from this unrand when friendlies
are around, they are prompted whether to cancel this effect. 3a6879684
introduced this when it reworked the unrand to cast static discharge
directly. This commit prevents the prompt when the spell is triggered
via the unrand, letting the prompt happen once, before the attack is
made.

--------------------------------------------------------------------------------
236c270 | gammafunk | 2018-11-08 00:11:18 -0600

Better sanctuary removal for melee/ranged attacks
Zin's sanctuary could sometimes fail to get removed for melee and ranged
attacks when an attack doesn't continue past the hit phase. For example,
if the attack killed the monster, no sanctuary removal would occur. This
commit puts the sanctuary removal at an earlier location in the attack
phase to prevent this.

--------------------------------------------------------------------------------
9d4b7ed | Alan Malloy | 2018-11-07 13:35:24 -0800

Don't crash when looking up Ru sacrifices (JumpingArm)
This is a temporary fix, making the ?/A menu display less useful
information about Ru sacrifices. This commit should be reverted once a
proper solution is in place.

This is in relation to https://crawl.develz.org/mantis/view.php?id=11752

--------------------------------------------------------------------------------
92528d7 | NormalPerson7 | 2018-11-06 13:15:15 -0800

Add a prompt for attacking living things while under divine protection
Killing natural monsters while under Elyvilon's divine protection causes
penance. However, there is no prompt for this, and it seems natural
for the player to invoke divine protection when low on HP so they don't
die, then heal up, and once they've healed, try to fight the enemy
causing them trouble. It was easy for players to accidentally cause
penance by killing enemies while under divine protection in this way.

Hence, add a prompt for attacking natural monsters while divine
protection is active. Penance will not actually trigger until the
monster is killed, but it's better to be safe than sorry.

--------------------------------------------------------------------------------
86cf76c | Alan Malloy | 2018-11-06 13:13:51 -0800

Remove unused code for jump attacking into a sanctuary

--------------------------------------------------------------------------------
368ce00 | NormalPerson7 | 2018-11-05 17:18:52 +0000

Don't corrode or appear to damage rAcid+++ enemies with Punk (11746) (#894)
Acidic attacks, from the acidic bite mutation and Punk, previously
displayed the "[Enemy] is splashed with acid" line against all targets,
which suggested to the player that acid immune targets still took extra
damage from these attacks even though any damage was in fact resisted.
Additionally, this was able to corrode acid immune enemies, which does
not seem thematically correct.

Therefore, in monster::splash_with_acid, add a check at the start of the
method for acid immunity, which if true, return early from without any
opportunity to damage or corrode the monster.

Acid resistant enemies correctly take half-damage from acid splash and
resist corrosion half of the time both before and after this change.
--------------------------------------------------------------------------------
0063841 | NormalPerson7 | 2018-11-04 08:52:19 -0500

Improve spacing in a return statement
This makes it so that all the code is nicely aligned, so that the logic
can easily be followed by examining the indentation. Also remove all
unnecessary parentheses.

--------------------------------------------------------------------------------
025b075 | NormalPerson7 | 2018-11-04 08:52:19 -0500

Give trolls the correct gourmand message, cleanup code
Commit 394fb522 incorrectly
assumed troll players are carnivorous, which they are not. Hence,
include trolls' gourmand mutation in the logic for the carnivorous
message for gourmand amulets being useless.

Additionally, fix a couple of message lines too long, improve the
whitespace around the ifs, and make sure everything is aligned
correctly.

--------------------------------------------------------------------------------
64599a1 | stenella | 2018-11-03 12:36:09 -0400

Leave Dual-Wielders Alone
Fixes #858

If a dual-wielder's primary weapon was removed by Tukima's
(determined by a coin-flip in monster::weapon()) , their mcache
entry would be invalided by this check, which didn't consider the
valid option of an alt-hand-wielded weapon.

--------------------------------------------------------------------------------
9fa8be9 | stenella | 2018-11-03 12:34:45 -0400

Change LRD flavour text for doors
https://crawl.develz.org/mantis/view.php?id=11695

LRD works on door tiles, which seem to be mostly wood.

Explain to the player that the door frame itself is what is shattering,
not the door.

Also, make fall-through's consistent.

--------------------------------------------------------------------------------
394fb52 | Stenella | 2018-11-03 12:33:11 -0400

Properly notify non-users of Gourmand (11692)
Previously, the wear message for gourmand was the same regardless of
whether it would work; change it to reflect the various reasons why it
might not work. Carnivorous/herbivorous mutations cover most species.
`foodless` covers mummies and the extra case of lich transformations,
for added lore. Vampires don't seem to fit into either of these cases,
so they are checked explicitly.
--------------------------------------------------------------------------------
2bcd0a2 | stenella | 2018-11-03 12:23:31 -0400

Check for stat_zero slow before telling player they're good to go
https://crawl.develz.org/mantis/view.php?id=11476

If a player is slowed in some way, then stat zero'd, when the slow runs
out, they'll be told they've been sped up, despite still being slow.

Check to make sure players aren't being slowed by stat zero before
telling them they're fast again.

--------------------------------------------------------------------------------
8eab93f | wheals | 2018-11-02 11:11:38 +0200

Don't print god warnings about a spell you can't memorise anyway.

--------------------------------------------------------------------------------
98fffd3 | wheals | 2018-11-02 11:10:07 +0200

Allow seeing the memorise menu while confused (#11517).
Checks later in the code still prevent memorisation.

--------------------------------------------------------------------------------
5214e5f | gammafunk | 2018-11-01 23:03:18 -0500

A new Ijyb splash screen from ploomutoo

--------------------------------------------------------------------------------
cf17ac6 | advil | 2018-10-31 14:42:38 -0400

Add aliveness checks to some monster equipment functions
Various bits of the subsequent code in these functions may rest on
getting a living, valid monster. This is possibly what was causing
crashes when Fennar refrigerates himself with other enemies on screen.
(gammafunk/amalloy)

--------------------------------------------------------------------------------
6ce9549 | gammafunk | 2018-10-31 01:11:03 -0500

Some decorative tweaks to a Bazaar vault
Don't recolor features like doors and the exit hatch, and use yellow for
the transparent stone instead of white. The surrounding stone is also
white, so having transparent stone be the same color is confusing in
console.

--------------------------------------------------------------------------------
6e9e0f2 | stenella | 2018-10-30 13:58:41 -0700

Console support
Allow the building of console DCSS in MSVC.

Change a unicode character to its equivalent code

Wrap tilecell and tiledgnbuf.cc in the same ifdef that their header files are 
wrapped in.

--------------------------------------------------------------------------------
e82cdd1 | stenella | 2018-10-30 13:58:41 -0700

MSVC2017 Compatability and relocation of project files
Updating submodule projects without changing the submodules themselves seems 
cumbersome, so move vcxproj files to a separate directory within the main 
repository.

Fix project files so they support x64 and Debug configurations.

Update INSTALL.txt to reflect current reality

--------------------------------------------------------------------------------
8c51ad5 | gammafunk | 2018-10-29 20:11:51 -0500

Don't apply negative energy effects to monsters for Drain Life
This spell is only supposed to do damage and give the drained HP to the
caster. The negative energy draining effects accidentally began to be
applied to monsters due to fb95405b.

--------------------------------------------------------------------------------
27fa94f | gammafunk | 2018-10-29 20:11:51 -0500

Fix a crash for LOS attack spells (MeekVeins, amalloy)
It's possible for a monster to die after applying damage flavour effects
but before the direct damage is applied. This invalidates the monster
pointer needed for god conducts, and was causing crashes with e.g. Drain
Life. This commit adds a necessary check for the monster being alive
before trying to apply conducts.

Additionally Drain Life shouldn't actually the flavour effect of
negative energy, and this will be fixed in a subsequent commit.

--------------------------------------------------------------------------------
4a5eb33 | Skrybe | 2018-10-28 22:57:25 -0400

Address a TODO in layout_concentric_octagons
Adds the Snake variant of the layout to Lair.  The notes didn't say that 
anything needed to be addressed before adding to Lair, so the layout code isn't 
changed.
--------------------------------------------------------------------------------
786a77d | Skrybe | 2018-10-28 22:57:25 -0400

Address a TODO in layout_cave_pools
Adds the layout to D, makes decreasing amounts of rock clumps at deeper depths.
--------------------------------------------------------------------------------
141017e | gammafunk | 2018-10-28 16:43:56 -0500

Lower the average number of charges for some wand types
Wand charges were lowered by the removal of scrolls of recharging, yet
the average number of charges for many powerful wands is still quite
high. Over 70 charges generate in a 3-rune game for paralysis and
polymorph, over 50 for wands of digging, and over 40 for enslavement.
For the weaker wands, wands of flame and random effects generate over
150 charges each per game. We'd like the charges for each wand type to
be meaningfully limited, especially for the more powerful ones.

This commit lowers the average number of charges per wand for the
following wand types:

| Wand           | Before | After |
| -------------- | ------ | ----- |
| digging        |   12.5 |     5 |
| enslavement    |   12.5 |     8 |
| paralysis      |   12.5 |     8 |
| polymorph      |   12.5 |     8 |
| flame          |   24.5 |  16.5 |
| random effects |   24.5 |  16.5 |

Digging takes the biggest relative reduction because of how powerful
this wand is at enabling escape, controlling monster movement, and
breaking into vaults.

Wands of flame and random effect charges are still too high, but they
remain as the more spammable wands until their other design issues can
be addressed. Flame duplicates a spell and is something you want to
carry all game due to how good steam clouds are, despite being
low-level. More design work could be done with some problematic wands
like polymorph, flame, and random effects, possibly combining parts of
them with other evocables.

--------------------------------------------------------------------------------
9c9d49f | Edgar A. Bering IV | 2018-10-27 21:39:50 -0400

Prevent unwielding by transforming
After re-introducing this bug, squash it again by further refactoring.
Both this and the bug fixed by 1406302 were caused by transform()
calling functions whose behavior depended on the player's transformation
while a player was in a partially transformed state. This lead to
fragile and unpredictable behavior. Some of it is unavoidable, which
comments point out. There may be other bugs lurking with a similar
cause.

--------------------------------------------------------------------------------
b2d5814 | Edgar A. Bering IV | 2018-10-27 14:24:46 -0400

Update ploomutoo in CREDITS.txt

--------------------------------------------------------------------------------
3a68796 | gammafunk | 2018-10-26 22:45:34 -0500

Rework the Arc Blade (minmay)
Currently this unrand effectively casts static discharge many times, but
with the melee defender as the target instead of the usual random one.
The multiple casting led it to have extremely high damage of over 50%
more than a demon blade of speed. Doing high secondary effect damage to
the primary target is already well-covered by existing unrands. A weapon
that can do good damage to nearby monsters is a more interesting unrand
concept.

This commit reworks the arc blade melee effect to cast static discharge
once with increased spell-power of 100 + random2avg(100, 2), well past
the usual 100 spell-power cap. This effect still triggers with the same
1/3 chance as before. The weapon enchantment is also increased from +4
to +8, making it not so awful versus resistant monsters. Using a normal
cast of static discharge allows it to arc better to monsters adjacent to
the player, and the high spell-power makes this damage effective. Its
damage versus a single target is still excellent, similar to a demon
blades of electrocution/speed, but not as overpowered as it was prior to
this commit.

Finally, it now has a proper melee attack prompt for harming allies.

--------------------------------------------------------------------------------
752426d | gammafunk | 2018-10-26 22:45:34 -0500

Fixes, refactoring, and message cleanups for static discharge
The safe_discharge() function for the attack prompt warnings of static
discharge didn't properly consider the player as an arc location. This
meant that casting it didn't give a warning in some cases where an ally
could be damaged.

Also refactor the main cast_discharge() spellcasting function to allow
non-players to call it, then have monsters use this when casting the
spell. Previously the monster casting code partially duplicated this
function.

Finally, simplify the messaging a bit to remove a separate message about
lightning arcs, adding that to the main damage message instead. The
message spam from this spell is pretty high and could probably be
improved to only print wound messages after all arcing is completed.

--------------------------------------------------------------------------------
dc5cae9 | gammafunk | 2018-10-26 22:45:34 -0500

Remove an unnecessary scope block

--------------------------------------------------------------------------------
8079fb2 | gammafunk | 2018-10-26 22:45:34 -0500

Refactor melee attack prompts for some unrands

--------------------------------------------------------------------------------
7ed3b4c | gammafunk | 2018-10-26 22:45:34 -0500

Apply god ally conducts for Static Discharge, Irradiate, and Shatter
Previously these didn't apply god conducts when harming allies, despite
their warning the player about penance for this.

--------------------------------------------------------------------------------
1903759 | gammafunk | 2018-10-26 22:45:34 -0500

Properly apply god ally conducts for LOS damage spells
Previous to this commit, Ozo's Refrigeration and the Singing Sword's spell
didn't apply god conducts when damaging allies, despite them warning the
player about penance. Now these conducts are applied properly.

--------------------------------------------------------------------------------
d7a6ca6 | Edgar A. Bering IV | 2018-10-26 21:30:35 -0400

Add Stenella to CREDITS

--------------------------------------------------------------------------------
1406302 | stenella | 2018-10-26 21:17:13 -0400

Simplify HP calculations (11728)
Combine calc_hp() and recalc_and_scale_hp() into a single function.

Remove the default for the rotting parameter to get_real_hp() and
require it be explicit in each usage.

Add a check to get_real_hp() for the presence of hp changing
transmutations, and handle those through calc_hp instead of some special
cases. Sequence equipment melding and HP calculation appropraitely.
(This fixes 11728.)

[Committer's note: Closes #875, #877. Checked whitespace, revised the
 commit message to reflect the final state of the patch. Simplified a
 check.]

--------------------------------------------------------------------------------
e56fa01 | Stenella | 2018-10-26 15:55:52 -0700

MSVC 2017 Compatibility (#878)

--------------------------------------------------------------------------------
66a18ee | NormalPerson7 | 2018-10-25 18:53:14 +0100

Start Wn with a spell memorised if they have only one level 1 spell
If wanderers have more than one level 1 spell, they may not have enough
spell levels to memorise all of them, and so the player should get to
choose which spell to memorise.

If, however, wanderers have only 1 level 1 spell in their library, and
they have a spell level available, it makes sense for the player to have
that spell automatically memorised. Hence, in this case, memorise the
player's only level 1 spell.

--------------------------------------------------------------------------------
7e0f0f3 | NormalPerson7 | 2018-10-25 18:53:14 +0100

Announce the starting items and spells for wanderers (11725)
Previously, players that did not look at their M screen would not be
aware of if they had spells in their spell library.

Therefore, print the player's inventory and spell library to the message
log at the start of the game. Also, take a note of the spell library to
include in the dump. This is done by expanding the note_wanderer_items
function and renaming it to note_wanderer_equipment (to be more
accurate).

This commit also adds support to print any spells the player begins with
memorised at the start, although this currently never happens.

--------------------------------------------------------------------------------
305c090 | Alan Malloy | 2018-10-24 18:24:23 -0700

Revert "Fix transformation HP scaling with HP+ artefacts (11728)"
It was allowing you to unwield cursed weapons by transforming,
and triggering unwield effects without warning.

Credit to Malacanter for noticing/reporting.

This reverts commit 82e90586b2dc5d95895fca894a4503104906bce7.

--------------------------------------------------------------------------------
5ce4c07 | advil | 2018-10-24 15:15:34 -0400

Try again to avoid recursive crashes when loading level/save data
bf5fdde8f9eef4 put the unwinds in the saving functions, not the loading
functions...

--------------------------------------------------------------------------------
3bc7ea6 | Doesnt | 2018-10-24 11:36:49 -0400

Spelling

--------------------------------------------------------------------------------
f497b7c | advil | 2018-10-23 23:27:42 -0400

Improve (?) filtered_vector_select
This now takes the `filter` argument in a format that should be
guaranteed to cast to bool (for purposes of #871), guaranteed to handle
a nullptr argument, and is also just more explicit about its type.
Unfortunately this prevents at least my compiler from deducing M
correctly, but such is life.

--------------------------------------------------------------------------------
357f654 | Edgar A. Bering IV | 2018-10-23 20:29:16 -0400

Update CREDITS.txt

--------------------------------------------------------------------------------
82e9058 | NormalPerson7 | 2018-10-23 12:04:18 -0700

Fix transformation HP scaling with HP+ artefacts (11728)
When wearing faerie dragon scales with the HP artefact property and
entering or leaving a transformation that modifies HP, HP would be
scaled incorrectly. This was because:
 - On entering a transformation, equipment was melded after the
   transformation took effect, which meant the new max HP was used as
   the finishing value for the HP change from melding the scales
   (resulting in a much higher than expected final value).
 - On exiting a transformation, equipment was unmelded before the max HP
   was downscaled, which meant the old max HP was used as the starting
   value for the HP change from unmelding the scales (resulting in a
   much lower than expected final HP).

Hence, in transform(), meld equipment before changing the value of
you.form, and in untransform(), downscale HP from the transformation
ending before unmelding equipment.

--------------------------------------------------------------------------------
f2e588f | Alan Malloy | 2018-10-23 11:25:39 -0700

Remove some now-unneeded sarcophagus labelling from a Tomb vault

--------------------------------------------------------------------------------
f86452d | Alan Malloy | 2018-10-23 11:13:25 -0700

Turn some pointers into refs, resolving a TODO

--------------------------------------------------------------------------------
d27e9dc | Alan Malloy | 2018-10-23 11:12:59 -0700

Fix a Tomb vault that was impassable (NormalPerson7, #11733)

--------------------------------------------------------------------------------
bf5fdde | advil | 2018-10-23 11:28:34 -0400

Try to avoid recursive crashes when loading level/save data
If the game crashes while loading items/monsters
(`tag_construct_level_items` and `tag_construct_level_monsters`), it
creates a situation where it is highly likely to crash debug_item_scan
or debug_mons_scan respectively. Since these are called for most builds
during the crash handler (basically for the detailed debug output in
case of things like unlinked items, I think), this leads to recursive
crashes (see e.g. 11734) and complicates diagnosing whatever the
underlying problem is. This change adds yet another state variable to
suppress these scans in the crash handler.

It's possible that I'm missing a case where calling the scans in the
face of such a crash does provide useful information; we'll see.

--------------------------------------------------------------------------------
ceb43e6 | advil | 2018-10-23 11:28:34 -0400

unbrace

--------------------------------------------------------------------------------
084b3f8 | NormalPerson7 | 2018-10-23 10:15:46 -0400

Make the immune_to_hex function available to clua
Add a new function to l-you.cc's clua library, called you_immune_to_hex,
which takes a spell as a parameter and returns whether the player is
immune to that spell.

[Committer's note: added @tparam to the ldoc. Closes #868]

--------------------------------------------------------------------------------
d59976b | NormalPerson7 | 2018-10-23 10:14:21 -0400

Include info about intrinsic immunity in monster spell description
This commit adds the line "You cannot be affected by this spell right
now" to descriptions of monster spells accessed through the monster
description, in place of the "chance to beat your MR" line.

--------------------------------------------------------------------------------
b5b85be | NormalPerson7 | 2018-10-23 10:13:41 -0400

Display (immune) in monster description when a player is immune to a hex
When a player is intrinsically immune to a particular hex, through
innate abilities, equipment, god abilities or transformations, make the
chance to defeat MR indicator next to the spell on the monster
description screen read "(immune)" instead. It is misleading to imply
that these abilities can succeed on the player through printing the
chance to defeat MR, as was the case previously.

This applies to:
 - Paralysis and slowing as a formicid,
 - Confusion with clarity or under Zin's vitalisation,
 - Petrification as a gargoyle, in statue form or under Zin's
   vitalisation,
 - Sleep and fear as undead or nonliving, with clarity or while berserk,
 - Virulence when immune to poison,
 - Porkalator when unable to transform,
 - Teleport and blink as a formicid or with -Tele equipment, and
 - Mesmerisation with clarity or while berserk.

This commit creates a new member function in the player class,
immune_to_hex. This method also returns true for hex-like spells that do
not have an MR check, such as paralysis gaze and blink other, however
these spells do not have the MR indicator and as such also do not have
the immunity indicator.

(If the only reason the player cannot be affected by a hex is because
they have sufficient MR to resist it always, the MR indicator will still
read "(0%)", to maintain the distinction between MR and intrinsic
immunity.)

[Committer's note: lowercased "immune"]

--------------------------------------------------------------------------------
9beedce | gammafunk | 2018-10-22 17:48:21 -0500

Refactor and update comments.
Use max() instead of assignment testing.

Mnoleg no longer has chain of chaos, but has call of chaos instead, and
chaos champions no longer exist.

--------------------------------------------------------------------------------
98c7a59 | gammafunk | 2018-10-21 20:02:35 -0500

Some edits and cleanups for a Bazaar vault
Refactor and simplify glyph usage to use more consistent lettering and
avoid overriding default glyphs. Add a full ring of edging between land
and shallow water with small chance to place water on each tile to make
this effect more randomized. Fix the transparent stone colored tiles by
setting the TILE statements to the color variants manually. I'm not sure
why setting the color alone isn't changing the tile like it does
normally; some aspect of the Bazaar layout seems to be preventing this.
Make the use of transparent stone in the lighthouse walls contiguous,
more how a lighthouse would be. Finally, generate the ophan awake.

Closes #867.

--------------------------------------------------------------------------------
9dc3cf4 | kenranunderscore | 2018-10-21 18:12:31 -0500

Add a lighthouse-themed bazaar vault
Adds the vault bazaar_kenran_lighthouse. It features a circular hut
built on a small island, make to resemble a lighthouse in the ocean.

The shoreline, as well as the transitions from shallow to deep water,
and from deep water to open sea, respectively, vary slightly in each
generated map.

At the moment, the centre of the lighthouse contains a trapped
ophan (as to provide a source of light). Of course this is rather
gimmicky, but I found it fun. It can easily be replaced by another
shop or decorative interior though, should monster generation in
this case be frowned upon.

--------------------------------------------------------------------------------
1757c6e | Manderson | 2018-10-20 22:50:43 -0400

Dispater Resprite
Now looks spookier and more made out of metal

[Committer's note: Closes #863]

--------------------------------------------------------------------------------
acb38b5 | Manderson | 2018-10-20 22:50:11 -0400

Replace Tiles: H. Ghost, S. Wraith, Cob, Eid
Replacing several ugly and unflavorful tiles. Hungry ghost should look
hungry, rather than obese. Shadow wraith and Eidolon are all but
unshaded. Death cob is a little too bright and has no discernible light
source.

--------------------------------------------------------------------------------
4c2fb12 | kenranunderscore | 2018-10-20 20:04:18 -0400

Fix some old bazaar vaults
Some older bazaar vaults did not work/look as originally intended due
to tile randomisation. The problems were mostly due to vaults using
LFLOORCOL in some way, which was then overwritten by the colour
randomisation in bazaar_setup. Some of this was only noticeable in
console mode, since the randomisation also sets LFLOORTILE.

To fix this and thus restore the intended looks of these vaults, several
steps were taken:
- Extend bazaar_setup in way that makes it possible to control whether
  colour randomisation takes place or not.
- In vaults that used RNG to set a floor colour and then checked for it,
  the checks now use dgn.get_floor_colour() to get the correct colour
  (example vault: bazaar_lake). This has to take place after the call to
  bazaar_setup.
- In vaults that set a fixed floor colour, use the version of
  bazaar_setup that does not randomise the colours (example vault:
  bazaar_minmay_generic_d).

Note: The generation of shop halos is the only thing that needs to be
done in the branch epilogue; everything else can be done before that.
The code now reflects this, and vaults that do not want halos
"delete" the epilogue (pass a nil to set_branch_epilogue).
Otherwise, if the player had entered another bazaar before, the epilogue
could have been set already.

[Committer's note: Closes #562. checkwhite and use luaL_optstring for
 set_branch_epilogue]

--------------------------------------------------------------------------------
376f016 | kenranunderscore | 2018-10-20 18:43:29 -0400

Small Lua refactoring for bazaars
The colour randomisation in bazaar.des used a Lua table to pick
a random colour from, then checked whether this colour was contained
as a key in another Lua table. If it was, the corresponding value was
picked as a tileset for the bazaar vault, otherwise there was a default
tileset as a fallback. This check could only fail if - for some reason -
the two Lua tables were not synchronized.

This refactoring removes the need for the check and the default tileset
by combining the two Lua tables into one containing all the
information necessary to randomise the looks of the vaults. This
shortens the code a tiny bit and makes adding new tilesets less
error-prone.

--------------------------------------------------------------------------------
eaabbf3 | Alex Jurkiewicz | 2018-10-20 13:31:18 -0400

Improve bear berserk
Bears mostly die before they can berserk, or they berserk and then die a
turn or two later. Let them cast it when in an emergency (like
orc battlecry) and double the cast frequency.

[Committer's note: Removed the instant from this patch. Closes 591]

--------------------------------------------------------------------------------
6ff198f | jmbjr | 2018-10-20 11:15:31 -0400

Allow setting attitude of cloned monsters (damerell, #11171) (#608)
Matches the attitude of a cloned monster to the cloner. This also
removes the (currently never-used) option of setting the position of the 
cloned monster on call.

For _mons_summon_monster_illusion:
By passing the cloned monster's attitude to clone_mons, we don't have to
do all of the gymnastics that previously had to be done to properly set
the cloned monster attitude and not adversely affect arena bookkeeping.

for _phantom_mirror, we can now simply set ATT_FRIENDLY in the
clone_mons call directly.
--------------------------------------------------------------------------------
6fd5563 | gammafunk | 2018-10-19 20:48:20 -0500

Some pre-Lair vaults that place manuals from minmay
Minmay's comments regarding this submission:

> Pre-Lair vaults with monsters guarding a manual Manuals are most
> interesting early in the game when your character may not yet be
> committed to a specific strategy. However, randomly generated manuals
> are extremely rare and biased towards deeper levels, and existing
> vaults that explicitly place manuals are all quite deep as well. So
> here are some shallow vaults that place manuals!
>
> These all have a mean of five monsters and a minimum of two, with the
> exception of minmay_manual_mares which simply has 2 centaurs. There
> are currently 10 vaults, with a total weight of 50.

Put these vaults in mini_monsters.des with their own section and
description in the relevant areas.

Only changes I made to the vaults themselves were syntax simplifications
for NSUBST, like removing `1:` for single replacements or `*=` for the
final replacement. Also replaced use of `:` with `=` for single
replacements, since I find use of that to be less error-prone when
NSUBST terms get changed around.

--------------------------------------------------------------------------------
aeb629a | advil | 2018-10-19 21:02:43 -0400

Various code cleanups for ghost_demon brands
Also, switch over a bunch of `int`s to `brand_type`.

--------------------------------------------------------------------------------
33639ab | advil | 2018-10-19 21:02:43 -0400

Show pan lord brand information
As with spells, showing the player the randomness immediately helps
smooth out some of the spikiness of just how random pan lords can be.
Doing this is also more consistent with recent changes to monster
equipment id.

This was surprisingly hard to get right, and the wording may still be
slightly odd for some brands and cases. This also improves the display
of ghost brands in xv (where it wasn't previously shown at all).

This commit changes SPECIAL_WEAPON_KEY to store a brand_type, not a
string.

--------------------------------------------------------------------------------
6656e44 | advil | 2018-10-19 21:02:43 -0400

Show pan lord spells in xv unconditionally
While random behavior can be exciting, the particular randomness
involved in panlord spells is extremely spiky, and I think it's better
to reveal to the player the randomness on encountering a pan lord rather
than as they cast their spells. This is especially relevant on the orb
run for newer players who may not have much experience with pan lords,
and given that 792c6d12af should make pan lords slightly more frequent
on the orb run.

With this change, the only kind of hidden spell information remaining is
for monsters with multiple spellbooks.

--------------------------------------------------------------------------------
4538c0e | advil | 2018-10-19 19:58:55 -0400

Make major-tag-history.md -x
Not sure why it was +x. Resolves #832.

--------------------------------------------------------------------------------
28c3e8e | Kyle Rawlins | 2018-10-19 17:57:26 -0400

Update MSVC instructions to reflect current reality
These directions are really too obsolete to keep up, and if someone were 
to get this working, I suspect they'd have to entirely rewrite anyways.
--------------------------------------------------------------------------------
e122d05 | gammafunk | 2018-10-18 10:33:37 -0500

Remove an unused variable
It's possible that this is related to a crash on CBRO potentially caused
by the use of a function template, although that really shouldn't be the
case.

--------------------------------------------------------------------------------
69db12b | Aaron Golden | 2018-10-18 09:39:30 -0500

Correctly tag branch ends in Hell vaults
Having these hard coded for branch ends at level seven causes
problems if branch-data.h is ever changed to make one of these
branches not exactly 7 levels deep.

[Closes #865]

--------------------------------------------------------------------------------
2b29b68 | Edgar A. Bering IV | 2018-10-18 09:39:30 -0500

Tweak nagdon_arrival_double_spiral
The lava and deep water variations spelled death if a ranged monster
spawned awake and near the vault, or wandered by as the player was
departing. The transparent stone could force the player to wake up a lot
of monsters while navigating out of the vault leading to death.

[Closes #864]

--------------------------------------------------------------------------------
9f293ae | Edgar A. Bering IV | 2018-10-18 09:39:30 -0500

Return disablers to disabler_island
This vault wasn't actually placing one of its intended monsters.

--------------------------------------------------------------------------------
fd02fb7 | Andrew Minton | 2018-10-18 09:39:30 -0500

Add the "transparent" tag to more vaults, eliminate some islands
This commit adds the "transparent" tag to most minivaults that have more than
one possible exit. For most minivaults, this eliminates their chance of causing
a veto entirely, and for the rest, it at least reduces it.
Also adds the "transparent" tag to a few non-minivaults.
Vaults with internally disconnected regions have either had the appropriate
opaque KMASKs applied, or said disconnected regions eliminated (only in the
cases where the regions contained nothing...these were mostly my vaults...).
Also fixes many cases where players could become trapped in a disconnected
region (again, mostly my fault), and a couple other fixes to my own vaults and
misspelled tags.

Large minivaults with few possible exits still have a lot of trouble generating.

disabler_island is clearly not functioning as intended (it can never actually
have an orange crystal statue or floating eye) but I'll leave that to its
author; for now I've just made it unable to trap the player.

--------------------------------------------------------------------------------
bd7f2c8 | gammafunk | 2018-10-18 00:22:13 -0500

New tiles for the Sceptre of Torment (CanOfWorms)
The old tiles didn't quite match the idea of "eveningstar". These new
tiles definitely look like something that you wouldn't want to be hit
with. In fact I'm not sure I'd want to touch this thing at all...

--------------------------------------------------------------------------------
8ff0b24 | gammafunk | 2018-10-17 22:28:42 -0500

Fix crashes for melee attacks without a weapon
This was broken in the previous commit.

--------------------------------------------------------------------------------
606f0fe | gammafunk | 2018-10-17 20:22:20 -0500

Fix attack prompts for some unrand weapons
The unrand weapons the Singing Sword, the Mace of Variability, and
Spellbinder can all damage allies in LOS with their secondary effects,
potentially turning allies hostile and causing god penance. This commit
adds an attack prompt for using these with allies nearby so that the
player can have a proper warning.

There is a bug where Singing Sword's spell doesn't cause Okawaru penance
when it harms allies, despite it turning them hostile. This is because
the necessary conduct code is missing from the LOS attack spell code and
the bug likely includes Ozo's Refridge as well. This can be fixed in a
subsequent commit, but for now I'll leave the warning as is.

The warning also uses somewhat misleading language, since it says that
the attack will cause penance. In reality, penance will only be caused
if the secondary effect actually triggers and the effect hits an ally
(in the case of Variability, it may not). I'm leaving the current
language for now, but if there's player confusion we can tweak it.

There are still two unrands that damage allies which need fixing: the
Arc Blade and the Sceptre of Torment. A simple LOS hit function wouldn't
correctly capture the Arc Blade's arcs, since they only travel between
adjacent monsters. This unrand is probably going to get reworked to
simply use a chain spell, in which case a LOS hit function would work.
I'm leaving it without a prompt for now.

For the Sceptre, allies don't currently care if you torment them, nor
does Okawaru give penance when this happens. We need to look into fixing
this logic and probably should move torment over to the LOS damage spell
code. Until this situation changes, there's probably no need for a
prompt, since there are no major consequences other than allies losing
HP.

--------------------------------------------------------------------------------
43d87f4 | gammafunk | 2018-10-17 14:13:25 -0500

Mark test statues as harmless monsters and clean up spacing

--------------------------------------------------------------------------------
ba3dfdf | gammafunk | 2018-10-17 12:56:58 -0500

Don't give a prompt for the Singing Sword's spell effect
When casting its Sonic Wave spell, the player's melee attack will
generate a cancellable prompt if the spell would harm an ally, which we
don't want here. Prevent this prompt; a subsequent commit will add the
necessary check so that this happens before the melee attack begins.

--------------------------------------------------------------------------------
0f038ff | gammafunk | 2018-10-17 12:56:58 -0500

Fix a crash when death curses torment (geekosaur)
The attacker can be nullptr for some sources of torment, so properly
check for that case before dereferencing the attacker.

--------------------------------------------------------------------------------
006994f | gammafunk | 2018-10-16 21:47:58 -0500

Rework the Sceptre of Torment
This torment effect of this weapon makes it something only undead
players want to use, and even then it's not a very good weapon due to
having such low direct damage. This commit makes the torment effect not
apply to the wielder, applying it on 20% of successful hits instead of
50%, changes the base type to be an eveningstar, and gives it the pain
brand. It was previously an unrand one-handed staff, but we already have
one of these, the Elemental Staff, and had no unrand eveningstar with
the removal of the Mace of Brilliance. Now the sceptre will be a usable
weapon that outclasses most branded and highly enchanted weapons for its
type.

It might be nice to update the tile to have spikes, so it more resembles
something one could conceivably call an eveningstar.

--------------------------------------------------------------------------------
9fe5f10 | Edgar A. Bering IV | 2018-10-16 00:25:51 -0400

Remove Misfortune from some vaults
The new version doesn't make sense in certain vaults.

--------------------------------------------------------------------------------
103bc38 | Edgar A. Bering IV | 2018-10-16 00:25:51 -0400

Revise the robe of Misfortune (gammafunk)
The robe of "particularly bad identification trap" was not an
interesting thing. This keeps the theme of an unlucky robe which
frequently leads to unfortunate confluences of events, but now lets some
of that bad luck fall on monsters too. Specifically, the random
appearance is dropped and the robe becomes: +5 with {*Corrode *Contam
*Drain Harm *Slow EV+5}.

--------------------------------------------------------------------------------
6e662b0 | Edgar A. Bering IV | 2018-10-16 00:24:58 -0400

Add Harm as an artefact property
Does not generate randomly at present. Requires *Drain. Multiple sources
of Harm do not stack.

--------------------------------------------------------------------------------
6f3f904 | Edgar A. Bering IV | 2018-10-15 21:58:52 -0400

A farewell to arms (Yermak)
Remove some permarock and unobtainable items used decoratively in
baileys. They're replaced with granite statues given flavourful
descriptions. CanOfWorms is working on some custom statue tiles to use
here.

--------------------------------------------------------------------------------
a838e03 | advil | 2018-10-15 20:22:05 -0400

One too many validity checks

--------------------------------------------------------------------------------
28b8a26 | advil | 2018-10-15 18:14:26 -0400

Add some finiteness checks to rays
...in hopes that this would help pin down when things go wrong.

--------------------------------------------------------------------------------
b49dddc | advil | 2018-10-15 14:16:50 -0400

Default `wall_jump_move` to false
This change has been a long time coming.  In hindsight, the movement
based implementation of this causes a lot of problems by turning what is
normally an interface noop (moving into a solid thing) into something
that can have annoying or bad tactical consequences.

The option is (for now) still there, for those who find the movement
version fun.

--------------------------------------------------------------------------------
792c6d1 | Alex Jurkiewicz | 2018-10-15 19:12:17 +0100

Upgrade orb run spawns
The orb run is relatively safe for players, but the difficulty is wildly
variable across multiple games.

Part of the reason for this is that the spawn list is so varied. An orb
run spawn might be a Pandemonium lord or a crimson imp. This change aims
to make the spawn list more consistent, and more dangerous.

Mid-tier demons used to make up over a third of orb run spawns. Cut that
down to 10% and give the excess spawn chance to orb guardians and
greater demons. Other numbers are slightly shuffled to rounder figures.

Also, the orb run can spawn monsters randomly, rather than near the
player. Stop spawning these monsters, and slightly increase the rate of
spawning near the player (presumably some of the randomly-spawned
monsters found the player).

[Adjusted the spawnrate slightly to only increase it a small amount over the
previous rate, to focus more on reducing the heavy variability of the orbrun
over increasing the difficulty - MarvinPA].

Spawn rate changes:

Monster          Old   New
---------------+-----+----
Pan lord       |  9% | 10%
Tier 1/2 Demon | 12% | 25%
Tier 3/4 Demon | 34% | 10%
Tier 5 Demon   |  4% |  0%
Orb Guardian   | 13% | 15%
Pan spawn      | 27% | 40%

--------------------------------------------------------------------------------
669764e | advil | 2018-10-15 10:01:17 -0400

Fix monster equipment wand id (Yermak)
Need to ID wands at the type level, not just their plusses. This also
fixes an unused variable warning.

--------------------------------------------------------------------------------
c8a7481 | advil | 2018-10-15 09:39:08 -0400

Don't use popup for end() errors in mapstat/objstat
This change sends them just to stderr, probably restoring older
behavior. This for stuff like level description parse errors or bad
command line arguments in general. (I don't think there's really a use
case for being able to view the full log on such errors? Actual crashes
will still just generate a crashlog.)

--------------------------------------------------------------------------------
02c3efa | gammafunk | 2018-10-15 00:16:52 -0500

Don't break player constriction through certain abilities (Vajrapani)
Abilities that move the player to origin to prevent messages like Yred's
Recall Servants previously had the player stop all forms of
constriction. This commit fixes this to relax the player-centric
conditions when the player is at origin, with the exception of Chei's
two time step abilities, where it makes sense to stop constriction.

--------------------------------------------------------------------------------
6bcb69f | Edgar A. Bering IV | 2018-10-14 10:50:41 -0400

Identify monster equipment on sight
Partial mosnter item identification has been increased over time to
de-spoil item generation tables in favor of revealing tactical threats.
Before this patch, the issue of item generation versus tacitcal threat
continued to apply to wands.

Further, players were encouraged to carefully observe damage
exclamation points to watch out for plusses on either monster weapons or
armour.

Finally, mantis bugs 10903 and 10301 involve information leaks regarding
armour ego.

All of these issues ultimately trace to identification of monster
equipment. This commit resolves them by fully identifying monster
equipment. Doing so comes at the cost of further diluting Ash's ID
passive and making Ash's item warning passive no longer exist, as well
as simplifying the ID game slightly more.

--------------------------------------------------------------------------------
e48c14c | Nikolai Lavsky | 2018-10-14 10:36:51 -0400

Remove references to loud noises breaking mesmerisation and fear
Since this mechanic was removed in 74fa8348.

--------------------------------------------------------------------------------
b40ba49 | gammafunk | 2018-10-13 19:56:58 -0500

Merge content from the old contrib guide and remove the old file
Bring over the section on what happens after contributor content is
merged, since that's still relevant. Now that the new markdown guide is
mostly complete, we can remove the old text file.

--------------------------------------------------------------------------------
b6e31bc | Kyle Rawlins | 2018-10-13 19:56:58 -0500

Various wording tweaks, typo fixes
Seems like it's in pretty good shape for merging to me.
--------------------------------------------------------------------------------
5ecafbc | gammafunk | 2018-10-13 19:56:58 -0500

Rewrite the contributor's guide and convert to markdown (advil)
WIP based on advil's rewrite with my own updates. Putting this in a
branch for future edits from myself and other devs.

--------------------------------------------------------------------------------
6773f7a | Aidan Holm | 2018-10-13 23:26:57 +0800

Add new title artwork (cws)

--------------------------------------------------------------------------------
a85b81c | gammafunk | 2018-10-12 21:31:42 -0500

Add dungeon feature statistics to objstat
Objstat now writes statistics about dungeon features to the file
objstat_Features.txt. This has counts of features by type, both in and
outside of vaults, along with standard deviation, min, and max. This
allows us to get answers to questions like "How often does a Jiyva altar
generate in Lair?" and gives a way to compare e.g. trap generation
between levels and branches.

--------------------------------------------------------------------------------
f0a6af8 | gammafunk | 2018-10-12 20:48:04 -0500

Clean up spacing in objstat functions for readability

--------------------------------------------------------------------------------
f30bb39 | gammafunk | 2018-10-11 23:49:44 -0500

Some fixes and tweaks to decor vaults
Prevent teleport closets in chequers_garden and chequers_arboretum using
a checkerboard pattern to guarantee a safe path. Remove unnecessary
no_monster_gen and no_item gen tags from the latter vault. Simplify
glyph and color usage in these two vaults as well as in
chequers_mini_garden. Closes #569.

--------------------------------------------------------------------------------
693b09e | gammafunk | 2018-10-11 22:12:10 -0500

Some fixes and cleanups to the river serial vaults
Fix various potential stranded tiles that could generate in a few of
these vaults by using a checkerboard of squares guaranteed to not be
deep water. For one vault, move no_tele_into from water features to the
entire vault, since the player could strand themselves. Move the
no_monster_gen from the entire vault to water features only for all of
these vaults. This allows their floor tiles to be valid generation sites
for level monsters without introducing more water monsters. Finally,
remove redundant no_pool_fixup tags.

--------------------------------------------------------------------------------
ab66580 | Alex Jurkiewicz | 2018-10-11 16:20:42 -0500

Add new vaults and a serial
* Four new serial corridors vaults
* A new serial layout, "rivers". This is a river-focused serial, similar
  to "bayou" (and the old, removed "ponds"), but without any plants and
  with more river-like (rather than pond-like) water design, along with
  a few waterlogged rooms. Includes thirteen vaults.
* Six new minivaults.

--------------------------------------------------------------------------------
dcc7a32 | gammafunk | 2018-10-11 13:45:19 -0500

A hive-themed ghost transporter vault for Dungeon and Lair
Bees and, in later depths, a queen bee, hornets, and eventually meliai
accompany the ghost of a player who tried to loot the treasures of a
formidable hive. All internal areas of the hive are revealed through
carefully placed windows. A very small number of squares may not be
visible, depending on the generation of a small number of wall tiles.
This won't affect ghost or loot visibility, and the player can easily
ensure they've seen everything in the vault before they enter.

It upgrades monsters and loot with depth, placing on average two food
rations throughout the vault. The other loot is general but with the
usual good loot upgrades that start from D:9.

--------------------------------------------------------------------------------
e7838e6 | advil | 2018-10-10 09:41:02 -0400

Improve gozag distraction flavor vs. mechanics
This is to try to more clearly cue that the distriction will last beyond
the presence of the initial trigger.

--------------------------------------------------------------------------------
f318fe8 | psywombats | 2018-10-10 00:10:50 -0400

A variety of new arrival vaults (psywombats)
Committer's note: This merges some of the vaults from #803. I tweaked a
few things (console colours, whitespace, simplify some SUBST lines, and
remove clear rock in a few places).

--------------------------------------------------------------------------------
c3b755d | Alex Jurkiewicz | 2018-10-09 01:17:51 -0400

Wake up the player if paralysed/petrified
Chaining disables on the player isn't particularly fun. Also prevent
paralysed and petrified players from being put to sleep. Flavour wise
it's not a stretch that these effects interfere with sleep.

[Committer's note: included the sleep immunity, closes #848]

--------------------------------------------------------------------------------
c0b0c76 | gammafunk | 2018-10-08 23:56:27 -0400

Move move actions out of main.cc
This resolves a longstanding TODO in main.cc.

[Committer's note: fixed whitespace, edited commit message. Closes #856]

--------------------------------------------------------------------------------
7ffd15e | gammafunk | 2018-10-08 21:31:35 -0500

Replace permanent teleport traps with zot traps in a maze (Engine)
The teleport trap could place immediately before the final door to the
rune in this Tartarus ending. If a silent spectre generated in this
room, -Tele or random teleport attempts or other more obscure techniques
would be required to enter, since monsters in the room couldn't wake up
and open the door. Since we don't like hard requirements for specific
equipment to access rune areas, use zot traps instead of teleport.
Stepping on a zot trap poses some risk, but requires no special
equipment.

--------------------------------------------------------------------------------
26e74f2 | gammafunk | 2018-10-08 14:33:24 -0500

Make the gold in a loot vault more accessible (biasface)
This vault used to place only fungi as a barrier around the gold, which
meant it could take some players a long time to break into.  Replace a
few of the fungi with toadstools. These decay over time and are easy to
kill even if they haven't decayed. Closes #859.

--------------------------------------------------------------------------------
fcac5de | Edgar A. Bering IV | 2018-10-07 11:29:11 -0400

Allow confusing touch with a weapon
The dexterity to-hit bonus made the unarmed requirement for confusing
touch more an interface obstacle than a real balance effect. If the
spell is too strong we should nerf the mechanic, not annoy a player
trying to use it.

--------------------------------------------------------------------------------
45ed416 | Edgar A. Bering IV | 2018-10-07 10:10:27 -0400

Reactivate autopickup when using stairs (mdonais)
New players sometimes miss the message about ^A to reactivate
autopickup and escape an invisible monster without killing it. They
subsequently get confused when they are no longer eating and grabbing
items. Even more experienced players can forget to turn autopickup on.

If a player does get followed up the stairs by an invisible monster
there will be a double message of Reactivate/Deactivate but handling
this otherwise would leak information.

--------------------------------------------------------------------------------
9da9e51 | gammafunk | 2018-10-06 20:08:01 -0500

Fix altar placement in a ghost vault (Pekkekke)

--------------------------------------------------------------------------------
6719eea | Chris Campbell | 2018-10-06 14:56:18 +0100

Remove an obsolete Wanderer message
Even if it were somehow possible for a Wanderer to start with such low skill
levels, skills < 1 are visible now anyway.

--------------------------------------------------------------------------------
9a66eeb | biasface | 2018-10-05 15:59:59 -0700

Change Donald's line about rPois ring to rN

--------------------------------------------------------------------------------
1df1716 | gammafunk | 2018-10-05 13:11:16 -0500

Revamp gammafunk_the_bubble
Per the reasons in 24521301, add windows into this vault to reveal all
monsters and loot. Also more thoroughly randomize monster placement,
since placements in specific locations are rarely going to be preserved
as monsters wake up and move around. Not only are there windows now, but
the walls are thinner, allowing more noise to reach the vault.

We also rebalance this vault to scale up monsters/loot from earlier
depths. Two of the guaranteed gold piles are gone, but we introduce good
quality consumables together with either jewellery or aux armor instead
of using only | and * loot. This vault will present a bit less risk in
earlier dungeon so it will be more often completed soon after its
discovered; players encountering it in later depths are much more
capable of dealing with the higher numbers of monsters the vault uses in
these places.

Allow this vault to place in Lair 'S' branches as well as Pan, since
these places generally don't have many transporter vaults that can place
there. This is a 098 monster vault, so it will work well in these
branches. In the later branches that don't have well-defined
out-of-depth monsters, we add some specific monsters from the branch as
necessary.

Finally, for the "roulette" variant, rework the portals to not use a
arrival landing site and exit transporter distinct from the roulette
pairs. Integrate these into the pairs, using randomization approach
which ensures that the no transporter takes you to the landing site in
the same pair.

--------------------------------------------------------------------------------
9f0c0e7 | gammafunk | 2018-10-05 12:27:10 -0500

Fix vault designations for boots and gloves
Incorrect designations for these items was causing vaults to fail to
place when boots or gloves were randomly selected. I was only able to
notice this when it happened via a subvault in a debug build. Also
adjust a couple item listings to include gloves as a possibility, since
boots are already included.

--------------------------------------------------------------------------------
a3b1b28 | Chris Campbell | 2018-10-04 18:47:02 +0100

Typo fix (JoelMarler)

--------------------------------------------------------------------------------
2e428d4 | gammafunk | 2018-10-03 18:06:29 -0500

Rework gammafunk_corrupted_shrine
Per the reasons in 24521301, add windows into this vault to reveal all
monsters and loot.

This commit also rebalances monster and loot counts to scale more
consistently and give a more reasonable ratio of monsters to loot. Add
good consumable and good/artefact jewellery to replace some of the more
variable | and * loot items. Adjust the monster lists to give more
balanced threats at the various tiers of monsters.

--------------------------------------------------------------------------------
a3f5176 | gammafunk | 2018-10-03 18:06:29 -0500

Some transporter vault balance and syntax tweaks.
The monsters scaled a bit too aggressively in gammafunk_jiyva_shrine, so
that the monster count got very high by Depths. Start with slightly more
monsters at earliest depths and scale them up half as slowly. Replace
one | or * item with either good consumable or more specific good
equipment at the earliest depth in both this vault and
gammafunk_beogh_shrine. This increases the chance of something usable
generating when we have a lower item count. Also clean up syntax in
gammafunk_beogh_shrine.

--------------------------------------------------------------------------------
65bf2d1 | advil | 2018-10-03 18:13:49 -0400

Use a real join for missing directory errors (amalloy)
This also should fix the problem on CBRO: the chroot c++ lib is old
enough that it apparently doesn't have a final implementation of
string::pop_back. The reason that `bool found = false` triggered an
issue is apparently that gcc was optimizing out the relevant code paths
when `found` was uninitialized.

--------------------------------------------------------------------------------
6cc01a3 | advil | 2018-10-03 17:00:36 -0400

Revert "Fix an uninitialized variable"
This reverts commit fe727ee8d20f9ef5416e00a83b350a3055196f1e.

This reversion is objectively wrong, but somehow this commit appears to
be causing CBRO builds to require a version of libstdc++ that isn't
present in the chroot. I haven't been able to isolate why, so I'm
reverting for now. (n.b. it isn't the exact details of this commit -- I
tried reimplementing the check without using a bool or an assignment,
and it still had issues.)

--------------------------------------------------------------------------------
e5a9903 | advil | 2018-10-03 10:09:18 -0400

Fix two weapon select bugs
* Dispreferred weapons were not readable while highlighted on webtiles.
* The welcome text was selectable (cf. d6d8abe and a814211745).

--------------------------------------------------------------------------------
290e36d | advil | 2018-10-02 22:10:12 -0400

Various beam.cc cleanups
All minor. Via #854.

--------------------------------------------------------------------------------
0b44af7 | advil | 2018-10-02 21:35:58 -0400

Comment a few weird things
via #854

--------------------------------------------------------------------------------
c497677 | advil | 2018-10-02 21:22:38 -0400

Fix several minor pointer issues
via #854

--------------------------------------------------------------------------------
55accd5 | advil | 2018-10-02 21:11:58 -0400

Fix a redundant feature on Sonja
via #854

--------------------------------------------------------------------------------
cae3914 | advil | 2018-10-02 16:50:00 -0400

Add a pointer check
This one was strictly speaking ok as-is, because the conditions always
target the player (MHITYOU), which guarantees that afoe is a pointer to
the player. But this is the kind of thing that shouldn't be taken for
granted in such an indirect way.

via #854

--------------------------------------------------------------------------------
51c88b6 | advil | 2018-10-02 16:45:12 -0400

Some extra pointer checks
I'm not sure these are necessary, but the static checker is right that
they certainly aren't verified as necessary from surrounding code, and
everything else here is pretty careful about `defender`.

Via #854

--------------------------------------------------------------------------------
dacbca0 | advil | 2018-10-02 16:39:09 -0400

Change a + to a +=
via #854

--------------------------------------------------------------------------------
9a040af | advil | 2018-10-02 16:11:32 -0400

Remove some vacuous ASSERTs
Vacuous because these are unsigned types.

via #854

--------------------------------------------------------------------------------
643b770 | advil | 2018-10-02 15:58:14 -0400

Ensure fsim file always gets closed
It would remain open when fsim was aborted at the a/d prompt.

via #854

--------------------------------------------------------------------------------
fe727ee | advil | 2018-10-02 15:47:46 -0400

Fix an uninitialized variable
Via #854

--------------------------------------------------------------------------------
91074bd | advil | 2018-10-02 15:42:26 -0400

Fix two iterators becoming invalidated during iteration
Both of these loops, used in constructing shoals levels, can add
something to the back of the supporting vector during iteration, which
(per the spec, though who knows in practice) will immediately invalidate
an iterator for a vector. This change is a partial revert of
a7d9996df05.

Found via #854.

--------------------------------------------------------------------------------
95cc579 | advil | 2018-10-02 13:32:53 -0400

Fix a bad bitwise calculation for ban_glyph in arena
This incorrectly used logical negation, not bitwise negation, which
would prevent the bounds check it was implementing from ever working.
Found via #854.

I've also cleaned up a couple of less-important stylistic things that
came up.

--------------------------------------------------------------------------------
5ee874d | ICC | 2018-10-02 13:08:27 -0400

Change some dead links to relative links in new_dev_guidelines.md
[Committer's note: changed commit message. Closes #855]

--------------------------------------------------------------------------------
a4718cd | advil | 2018-10-02 12:18:26 -0400

Exclude bones from checkwhite and run it
Also unbrace.

--------------------------------------------------------------------------------
b44a8d1 | advil | 2018-10-02 11:42:31 -0400

Fix disaster area adjacency check
311b6308dd0e64a was supposed to add a constraint to disaster area that
avoided adjacent spaces, but this never worked, because `victims` was
never populated. I'm guessing the idea was to push used targets into
`victims` during this loop, and then not use such targets if they are
encountered later in the loop. (I discovered this while looking through
the errors in #854.)

This commit implements the idea in a somewhat different way. Rather than
just failing on a new target that is adjacent to a previous target, it
downweights all adjacents spaces each time it chooses a target, but
never removes them. This ensures that `count` targets still get used,
following the longstanding current behavior, and imposes a probabilistic
bias against adjacency (with tight clusters >2 especially dispreferred).
In testing this appears to result in better spread at middling invoc
levels.

--------------------------------------------------------------------------------
0cf4261 | Edgar A. Bering IV | 2018-10-01 23:31:49 -0400

Revert "Check bounds for player_can_hear (#689)"
This reverts commit 44fbede512ef246a858dd77d60c7d0e2e745d440.

This is causing initial portal vault messages to not be displayed at
all. I don't have time to investigate further so I'm reverting for now.

--------------------------------------------------------------------------------
7750573 | gammafunk | 2018-10-01 16:15:33 -0500

Don't place a ghost vault with tree walls on Swamp:$ (Pekkekke, 11700)
since Lerny can knock down the trees that form the walls of this vault,
thereby releasing the ghost.

--------------------------------------------------------------------------------
6129075 | gammafunk | 2018-10-01 15:26:22 -0500

Add windows to gammafunk_beogh_shrine and rebalance
Per the reasons in 24521301, add windows into this vault to reveal all
monsters and loot.

Rebalance the loot to incorporate a couple good aux armor and
consumables instead of using only highly variable | and * items. Also
tweak the loot and monster distributions to scale quantities more
consistently, tweaking the monster types for better balance.

--------------------------------------------------------------------------------
82784c5 | gammafunk | 2018-10-01 15:26:22 -0500

Add windows to gammafunk_jiyva_shrine and rebalance
Per the reasons in 24521301, add windows into this vault to reveal all
monsters and loot.

Rebalance the loot to incorporate a couple good jewellery and
consumables instead of using only highly variable | and * items. Also
tweak the monster list to make more judicious use of eye monsters and
high level jellies.

--------------------------------------------------------------------------------
2452130 | gammafunk | 2018-10-01 15:05:34 -0500

Add windows to gammafunk_sealed_library and reformat
This commit modifies this vault to allow players to see what's in the
vault in terms of monsters and loot. Spoilery vaults still have a place
in crawl, at least for the time being, but sealed vaults generally work
better when the player can reason about the risk vs reward. It's better
to discourage reading vault spoilers, which is what the player would
want to do for the vault before this commit. Even if the player doesn't
read spoilers, it's almost never wise to attempt a transporter vault
blind until long after the vault is first encountered. We'd like these
vaults to relevant much of the time when they place, so allowing the
player to see what they'll face is a good way to help ensure that.

Add windows on all four sides, and move the landing site to the other
side of the vault, where we add another level connector. Also reformat
the DES statement spacing.

--------------------------------------------------------------------------------
ab6feb3 | Edgar A. Bering IV | 2018-09-29 23:53:47 -0400

Give Barachi full LOS halo and umbra (11650)
you.normal_vision was perpetually LOS_DEFAULT_RANGE. This changes
you.normal_vision to correctly be the species LOS and then apply further
mutations, spells, and effects to it.

The halo and umbra calculations were using LOS_DEFAULT_RANGE. There may
be other locations where LOS_DEFAULT_RANGE is used instead of
you.normal_vision that give Barachi weird edge cases.

--------------------------------------------------------------------------------
65e0026 | Edgar A. Bering IV | 2018-09-29 21:14:47 -0400

Have wall jump ability respect constriction (11690)
When wall jump is triggered by moving, the player first makes an escape
attempt, and loses a turn if they fail to escape.

This changes wall jump activated via the ability menu to behave in the
same fashion.

--------------------------------------------------------------------------------
ac4dfef | NormalPerson7 | 2018-09-29 19:48:43 -0400

Disallow wall jumping while stuck in a net/web (11690)
When stuck in nets or webs, wall jumping via moving into a wall does not
work, because attempting any movement will break out of the net first.
However, the ability bypassed this check and so the player could wall
jump to immediately free themselves from any net or web via the ability.

Therefore, explicitly disallow wall jumping while held and give a
message for when the player attempts to wall jump out of a net.

Additionally, add a case to _check_ability_possible for the wall jump
ability, which returns false if the player is held, in fungus form and
in view of an enemy, or is not adjacent to any eligible wall. This will
mean the ability is appropriately greyed out for the most general cases
of when this ability is impossible.

--------------------------------------------------------------------------------
c1433dc | NormalPerson7 | 2018-09-29 19:48:43 -0400

Fix the wall jump ability not being available when berserk (11687)
When berserk, like all martial attacks, wall jumping can be done via
moving into a wall. However, the ability screen was previously
unavailable when berserk and the function _check_ability_possible
unconditionally returned false early when berserk, meaning the wall jump
ability could not be used.

The previous commit made the ability screen open even when berserk.
In this commit, add a new abflag, berserk_ok, for abilities which can be
used even while berserk, and add a check for this flag at the start of
the _check_ability_possible function. This means both methods for wall
jump, moving into a wall and using the ability, will now work while
berserk.

--------------------------------------------------------------------------------
d3700a3 | NormalPerson7 | 2018-09-29 19:48:43 -0400

Don't prevent the ability menu from opening when berserk or confused
Previously, three things happened depending on the player's statuses:
  - if the player was berserk, the ability menu would never open;
  - if the player was confused, the ability menu would only open if the
    player had one of the two conf_ok abilities (Ely's Purification and
    Ru's Draw Out Power), and if it did open, only conf_ok abilities
    would be shown.
  - if the player had any other restrictive statuses, the ability menu
    would open, and, in most cases, abilities affected by the
    restrictive statuses would be greyed out.

It was decided that having berserk or confusion act differently to other
statuses, for example silence, was inconsistent and unnecessary. Hence,
we allow the ability menu to be opened even when berserk or confused,
where unusable abilities will be greyed out.

--------------------------------------------------------------------------------
9c2c487 | Edgar A. Bering IV | 2018-09-29 16:19:08 -0400

Don't accept elemental colours by default (11468)
The majority of uses of str_to_colour expect a terminal colour, and can
crash if an elemental colour is returned. Lua and mapdef are the
exceptions.

900b867fb7dce previously added an option to disallow elemental colours
to fix some crashes. The option was set to default to allow elemental
colours but the commit message mentions there are potentially other
places where allowing elemental colours can be bad. This patch chases
those down.

Closes #781

--------------------------------------------------------------------------------
7053962 | Edgar A. Bering IV | 2018-09-29 15:45:55 -0400

Fix a des syntax error

--------------------------------------------------------------------------------
4e7f3e4 | Edgar A. Bering IV | 2018-09-29 12:00:53 -0400

Revise the Spriggan's Knife description (MarvinPA)

--------------------------------------------------------------------------------
a8fa5fe | Edgar A. Bering IV | 2018-09-29 10:25:11 -0400

Fix lua documentation of Item.artprops

--------------------------------------------------------------------------------
133332c | Edgar A. Bering IV | 2018-09-28 22:35:57 -0400

Revise the Spriggan's Knife (mikee)
The knife now always stabs at Tier 1; specifically any stab is converted
to a sleep stab, this is flavoured as cutting into the realm of dreams.
Remove the Dex+4 and MR+ to de-stat-stick it a little. The Dex+4 in
addition to the EV and Stealth plusses was overkill, and since the knife
now always stabs at tier 1 the extra Dex seemed like too much.

A separate idea discussed for the knife was to make it a Hex enhancer.
There's probably room for a Hex enhancer unrand dagger also.

--------------------------------------------------------------------------------
bb6edff | Edgar A. Bering IV | 2018-09-28 22:31:09 -0400

Allow tweaking more artps in wizmode
&t only used 0-Z, there are now more artefact properties than that. This
expands it to use a-z, then A-Z then 0-@.

--------------------------------------------------------------------------------
b1a0310 | Edgar A. Bering IV | 2018-09-28 22:30:39 -0400

Allow SH specification for unrands.
685a3a753ca introduced the ARTP_SHIELDING, but did not add processing in
util/art-data.pl for a keyword. This allows unrands to specify the
shielding property with SH: plus.

--------------------------------------------------------------------------------
8581c8f | gammafunk | 2018-09-28 20:52:56 -0500

Fix a crash for tracers of LOS attack spells
Introduced in fb95405 where an average damage value was removed. This is
still needed for tracer calculations to get a scaling factor for friend
info based on what proportion of damage the target would resist.

This commit also refactors some of this code to remove redundant
variables and better use an input argument pointer to hold the total
damage.

--------------------------------------------------------------------------------
ba00d9b | gammafunk | 2018-09-28 18:12:51 -0500

Use better damage dice for Drain Life
The formula was changed in 2a92f5c in a way that introduced invocations
breakpoints, so that damage increases were only seen on even invocation
skill levels. This commit removes the spellpower divisor of two and uses
one die instead of two, adjusting the adder value accordingly. We
actually get the same average as before 2a92f5c, albeit with a slightly
lower min and slightly higher max.

--------------------------------------------------------------------------------
2a92f5c | gammafunk | 2018-09-28 16:56:36 -0500

Revamp the Singing Sword
Currently this unrand is worse than a +7 vorpal double sword, since it
has no brand and its "sonic damage" effect is weak. This sonic damage is
also linked to having the sword wielded instead being linked to
successful attacks. This commit rebalances the sword to be more
comparable to an enchanted double sword of speed at high tension. It
also makes the sonic damage effect to trigger only on successful melee
attacks (including ripostes). The sword now casts a "Sonic Wave" spell
that uses existing LOS attack spell code, instead of duplicating some of
that logic, and has a visual flash when the effect triggers.
Additionally the sword has a vorpal brand, instead of being brandless,
and has an inscription and updated description indicating its spell
effect.

The sonic wave damage is simplified from the previous multiplicative die
to use a 2d(5 + pow / 10) roll with the chance for the effect lowered to
50%. When the effect triggers at high tension, the sword has a 1/10
chance to "scream", as it did before this commit, but this now gives 50%
more spellpower instead of double damage, since the sonic damage is much
higher now.

Finally, the sword's noise has been set so that it's the same chance and
20 noise value as the *Noise property at low tension, with that noise
increasing by 10 at high tension and by 10 again if the sword "screams".

--------------------------------------------------------------------------------
fb95405 | gammafunk | 2018-09-28 16:56:36 -0500

Refactor LOS attack spell code
This code previously had a lot of duplicated logic between functions
used for the two spells that cast it, Ozo's Refrigeration and Drain
Life. Instead of using function pointers to different functions doing
similar things, use common functions where possible.

Make zap entries for Ozo's and Drain Life to store details like the
damage and color (used for flash effect). This way these details can be
stored in the beam already used to store attack details.

This commit changes the damage formula of Drain Life, which was
previously:

3 + random2(7) + random2(pow)

to be:

2d(4 + pow/2)

which has a similar average as well as min/max damage compared to the
old formula.

--------------------------------------------------------------------------------
d8354db | gammafunk | 2018-09-28 16:55:18 -0500

Remove an unused dlua library
This dlua code to have the dungeon cast LOS-acting spells is no longer
used and partially non-working, so remove it.

--------------------------------------------------------------------------------
44a7aab | gammafunk | 2018-09-28 16:35:09 -0500

Make a function pointer argument into a function template

--------------------------------------------------------------------------------
069075c | Edgar Bering | 2018-09-28 17:33:26 -0400

Update ebering in the mailmap

--------------------------------------------------------------------------------
6cf3e00 | NormalPerson7 | 2018-09-28 14:14:53 -0400

Add reference to * direction as alternative to ctrl+direction (#11401)
There is no way to attack down-right (south-east) using ctrl in some
browsers, since ctrl-N creates a new window and ctrl-3 switches to the
third tab. This commit adds a reference to * direction as an
alternative, to remind players of this option when they try to use
ctrl-N to attack and their browser takes over.

[Committer's note: Closes #738]

--------------------------------------------------------------------------------
44fbede | Matthew Boeh | 2018-09-28 09:38:24 -0400

Check bounds for player_can_hear (#689)
This PR addresses something that aidanh fixed in a different way in 
e27d229730f9, but the change still looks correct to me even if there's
no current bug that it fixes (and bounds for p maybe also should be
checked).

Original commit message:
Fixes https://crawl.develz.org/mantis/view.php?id=11279

You can reproduce the bug consistently by entering a floor with a
portal, leaving the floor, waiting for a while, and returning to that
floor. While catching the floor up to the current time, the portal
message is triggered while the player is not yet on the floor.
--------------------------------------------------------------------------------
31763e9 | Doesnty | 2018-09-28 09:24:52 -0400

Fix box_level_dp loot (#851)
This vault was originally supposed to put one ring of teleportation in the 
metal room, a random quantity of scrolls of teleportation around the perimeter 
of the giant box, and a single amulet of reflection. Commit cefc067 removed the 
rings of teleportation from this vault without updating the letters used for 
the other two, causing the vault to place one scroll of teleportation nowhere, 
a random quantity of amulets of reflection, and a single nothing. This PR 
restores the old and less bizarre behavior.
--------------------------------------------------------------------------------
ab8d2b5 | gammafunk | 2018-09-28 08:01:50 -0500

Add ebering to the list of crawl devs
gammafunk gestures. A swirling arc of seething chaos appears! The arc of
chaos hits ebering!!! ebering evaporates and reforms as a dev! Welcome
to the team!

--------------------------------------------------------------------------------
ab8a48c | Edgar A. Bering IV | 2018-09-28 08:26:06 -0400

Simplify Beogh conversion rules
The previous commit mentions that these lead to a minigame of 'don't
attack this orc until you're certain its met the simulationist criteria
for a conversion attempt'. This commit makes orc conversion attempts
happen on sight, like Gozag and Jiyva (even if the orc is asleep,
confused, paralyzed, can't see you, or has not yet selected you as their
foe), removing the minigame.

--------------------------------------------------------------------------------
fbe1177 | Edgar A. Bering IV | 2018-09-28 08:26:06 -0400

Attempt God conversions on sight.
Currently three gods change monster attitudes on sight: Beogh, Gozag
(under bribe), and Jiyva.

When a player sees a monster, Gozag and Jiyva have already decided
whether they will convert the monster, but prior to this patch the
conversion did not happen until the player took an action with the
monster in LOS. This led to an unfortunate bug in the following
situation: if a bribed monster walked into LOS of a player bribing a
branch with Gozag no messaging would be displayed and the player could
attack the monster. This would have the effect of betraying the bribe
and turn any bribed monsters in LOS hostile for what appeared to be no
reason to the player. (The problem is less severe under Jiyva since not
attacking slimes is part of the conduct, but it does cause the
occasional 'hostile' slime to appear.)

Beogh's conversion behavior is different, and requires the monster be
awake, clear-headed, and targeting the player. As a result this check
needs to happen every turn the orc is reacting to the player (Beogh sets
a flag to make only one conversion attempt per-orc).

This patch makes conversion attempts happen in both relevant code-paths
using a do_conversions() function. While this causes some minor
execution duplication, each conversion function handles being called
multiple times on the same monster correctly, and abstracting the
conversion attempts to attitude-change make it easier to keep track of
them for the future (however unlikely more ally religions are).

I'm fixing the bug this way and not by changing how gozag_break_bribe
operates to avoid the mini-game of "I won't attack this monster that
just walked into my LOS in case I'm about to bribe it". The Beogh
conversion rules should probably be re-thought as their current state
has a bit of this mini-game.

--------------------------------------------------------------------------------
8829680 | Edgar A. Bering IV | 2018-09-28 08:06:26 -0400

Add elemental colour support to the equip bar
This commit modifies the equip bar to process elemental colours (coming
from unrands) for equipment glyphs in the equip bar.

By default, the colours are not animated, since a goal of the equip bar
was to lower visual noise. The option "animate_equip_bar" is added to
toggle this behavior, as the other goal is to show of your cool stuff.

--------------------------------------------------------------------------------
1bcb263 | Edgar A. Bering IV | 2018-09-28 07:52:29 -0400

Have butchering always leave a skeleton.
Currently, if you cast animate skeleton, you get a skeleton and chunks.

However, if you forget that you have animate skeleton (or have
auto-butcher on or whatever), you have a one_chance_in(3) chance of
being left with a skeleton to animate.

This behavior gives Animate Dead an extra hidden nutritional trade-off,
in exchange for an interface screw.

This commit changes the behavior of butchering to always leave a
skeleton, so that butchering and casting animate skeleton commute.

A consequence is that Animate Dead becomes *slightly* stronger, as a
player could now butcher every corpse for nutrition and then animate the
skeleton, at the expense of a few HD for the undead minions. This isn't
actually a buff, though, because said hypothetical player could walk to
each corpse and cast animate skeleton for an almost identical effect
(slightly different MP cost).

--------------------------------------------------------------------------------
1bc9708 | Edgar A. Bering IV | 2018-09-28 07:52:29 -0400

Remove an unused include

--------------------------------------------------------------------------------
2b5ca64 | NormalPerson7 | 2018-09-27 21:09:31 -0400

Add functionality to search items by handedness. (#850)
When a player has a good shield and has trained a lot of shield skill,
it would be nice to filter out two-handed weapons. Likewise, later in
the game once a player is committed to two-handed weapons, it can would
be nice to filter out one-handed weapons. However, no stash search
prefix has previously existed so it was impossible to search for a
particular handedness.

Hence, add a stash search prefix for handedness. There is no check in
the hands function defined in l-item.cc that the item searched for is
actually a weapon, so we check that the item is a weapon first.
Additionally, filter out throwing weapons because they don't occupy the
weapon slot, therefore their handedness is not useful to search for and
will instead clutter up the search results list.

--------------------------------------------------------------------------------
3b46b07 | CanOfWorms | 2018-09-25 23:23:48 -0400

Remove a runed door subvault from the_grid
This specific subvault could be placed in a way that let the out of depth 
monsters inside escape despite having a runed door (and could also rarely be 
placed without any walls around it at all), which mostly confused players into 
thinking there was a problem with the vault generation.
--------------------------------------------------------------------------------
563e2a7 | CanOfWorms | 2018-09-25 23:14:41 -0400

Update Dithmenos's power description (Angani)
Remove a leftover reference to old Shadow Step requirements.
--------------------------------------------------------------------------------
84a5ed2 | advil | 2018-09-25 15:12:45 -0400

Replace hacky allow_password_reset() with getattr calls
I also added a comment in config.py documenting some of these
complexities and recommending `getattr`.

--------------------------------------------------------------------------------
34886a9 | advil | 2018-09-25 15:01:40 -0400

Fix client.html
Just needed a way to safely access module parameters that might not
exist.

--------------------------------------------------------------------------------
8cfa994 | advil | 2018-09-25 14:47:39 -0400

Revert "Temporarily revert html side of forget password commits"
This reverts commit f47f43309fcf60f96e15812b4b351e50b99c0873.

--------------------------------------------------------------------------------
5abb548 | advil | 2018-09-25 14:45:36 -0400

Handle config.pys that lack lobby_url
I missed that this was a new variable also.

--------------------------------------------------------------------------------
f47f433 | advil | 2018-09-25 13:47:14 -0400

Temporarily revert html side of forget password commits
I think these are crashing servers that have updated but not restarted,
temporarily pulling them until I figure out a better approach.

--------------------------------------------------------------------------------
db1f849 | advil | 2018-09-25 11:18:52 -0400

Merge branch 'floraline-webtiles-password-reset'

--------------------------------------------------------------------------------
33f0de1 | advil | 2018-09-25 11:14:35 -0400

Handle the case where config.py lacks allow_password_reset
Most servers don't keep their config.py in version control, or even
merge with the git copy of config.py, so when adding new parameters to
config.py one can't assume that they'll be there. (Yes, this is kind of
a problem with how configuration is done in webtiles, that could use
some more work.)

--------------------------------------------------------------------------------
68a31cc | advil | 2018-09-25 10:20:06 -0400

Various small tweaks
 * improve code style (at least relative to our guidelines), comments
 * handle no auth smtp configurations
 * small tweaks to wording, logging

--------------------------------------------------------------------------------
12a1dd4 | advil | 2018-09-25 09:01:34 -0400

Merge branch 'webtiles-password-reset' of https://github.com/floraline/crawl 
into floraline-webtiles-password-reset

--------------------------------------------------------------------------------
b6b040f | gammafunk | 2018-09-24 00:01:08 -0500

Remove a spiral vault (11554)
This vault is one of many single-tile-corridor spiral vaults. It places
a set of out-of-branch air-themed monsters that aren't particularly
challenging given the narrow layout. Since we already have a lot of
spiral vaults that are more effective, remove this one.

Closes #827.

--------------------------------------------------------------------------------
93a313e | NormalPerson7 | 2018-09-23 18:13:40 -0400

Fix teleport closets in Cigotuvi's Fleshworks (11570)
This wizlab previously had eight teleport closets, designed to be
terrariums of various shapeshifted monsters placed on display. They are
completely disconnected from the rest of the map and visible only
through their transparent walls.

This commit adds the no_tele_into flag to all tiles inside these eight
areas, to avoid the player teleporting/being teleported into these areas
and then having no way to get out of them. We use nine new symbols to
ensure that the content of the wizlab isn't changed at all.

--------------------------------------------------------------------------------
7d5962a | NormalPerson7 | 2018-09-23 18:12:22 -0400

Unify range checks between the targeter and fatal_attraction for Gell's
This commit:
 (a) re-implements a gravitas_range function to be used by both the
     fatal_attraction function and the targeter for Gell's Gravitas;
 (b) makes this function return a value (2 or 3) solely dependent on
     whether the spellpower is greater than the breakpoint of 80 rather
     than using an overcomplicated and inaccurate formula to do this;
 (c) makes the fatal_attraction function check the range of an actor
     near to the centre of the "gravitational reorientation" using the
     gravitas_range function instead of checking if the calculated
     strength was greater than 0; and
 (d) calculates the strength as before in fatal_attraction, but removes
     the restriction that it must always be less than LOS_RADIUS - this
     sanity check was unnecessary and limited the damage slightly at
     high power for targets colliding when they are range 1 from the
     centre.

--------------------------------------------------------------------------------
77c8c95 | NormalPerson7 | 2018-09-23 18:12:22 -0400

Fix the spell targeter for Gell's Gravitas
Previously, the formula used to calculate the targeted area was
completely different to that which the spell itself used, resulting in
the targeter blatantly lying to the player about the tiles which could
and could not be affected.

The current behaviour of Gell's Gravitas is entirely predictable based
on spell power, with no randomness involved, therefore the new targeter
is entirely in the darker yellow colour to indicate the certainty. The
power breakpoints are:
>0 power: at radius 1 from the centre, the monster is pulled 1 tile;
>0 power: at radius 2, the monster is pulled 1 tile;
>60 power: at radius 2, the monster is pulled 2 tiles; and
>80 power: at radius 3, the monster is pulled 1 tile.

The previous spell targeter suggested that, at low power levels,
monsters at radius 2 could never be affected, and that at exceptionally
high power levels, targets at radius 4 could be affected, both of which
are incorrect. Hence, this commit changes the targeter to reflect the
fact that monsters at radius 2 are always affected and monsters at
radius 3 are always affected when, and only when, above 80 power.

An argument could be made for having the targeted tile (the centre of
the "gravitational reorientation") not appear coloured, given that this
tile is not affected, however this would require significantly more
work.

This commit removes the gravitas_range function, which was previously
only used for making the targeter, because it is no longer required.
Additionally, this commit removes the player's tile being highlighted,
given the player is never affected.

--------------------------------------------------------------------------------
3eb00d1 | Aidan Holm | 2018-09-24 01:14:01 +0800

Fix dry fountain tile not showing in ?/F

--------------------------------------------------------------------------------
14233b2 | Aidan Holm | 2018-09-24 00:56:45 +0800

Add list of embedded packages to simplebar.js (advil)

--------------------------------------------------------------------------------
4d241d0 | Aidan Holm | 2018-09-24 00:30:53 +0800

Add background to webtiles scrollbars

--------------------------------------------------------------------------------
b82a549 | Aidan Holm | 2018-09-24 00:30:49 +0800

Fix some webtiles scrollbar update lag

--------------------------------------------------------------------------------
45387a9 | Aidan Holm | 2018-09-24 00:28:49 +0800

Fix webtiles scrollbar visibility and zoom issues
The purpose of these modifications is to make the scrollbar 'stick out'
from the side of the scroller window, so that it is flush with the edge
of the popup. Unfortunately, using a transform is not possible here due
to clipping.

This commit resolves some issues reported by users where the scrollbar
would not be immediately visible, and where the browser scrollbar would
reappear if the zoom level was changed.

--------------------------------------------------------------------------------
1502417 | Aidan Holm | 2018-09-24 00:28:05 +0800

Update simplebar.js to 3.0.0-beta5
This commit also changes to a human-readable and more easily editable
version of the simplebar.js file.

--------------------------------------------------------------------------------
aba95fd | Edgar A. Bering IV | 2018-09-23 09:18:14 -0400

Clean up internal comments (aidanh)
Remove '////' and '----' instances being used as dividers or in internal
comments that are not intended for ldoc.

--------------------------------------------------------------------------------
039bf95 | Edgar A. Bering IV | 2018-09-23 09:18:14 -0400

Sort lua api table of contents.

--------------------------------------------------------------------------------
7bc873d | Edgar A. Bering IV | 2018-09-23 09:18:14 -0400

Document the rest of clua in ldoc
Modules food, item, spells, travel, and view, you. Globals from l-global.cc.
The lua option metatable, internal macro hook, and clua modules iter and
util; and globals provided from loaded lua.

Documents module monster and the  monster.info clua class based on the
source diving and pastebin by Leszczynek.

Documents globals defined in clua.cc inline using ldoc syntax; clua.cc
does not have any Doxygen comments in it. If they get added in the
future that could casue trouble.

Documents the various entry hooks into lua used throughout the codebase
in dat/dlua/userbase.lua, instead of in-line, as that is the file that
initializes hook tables, just to keep things in one place.

--------------------------------------------------------------------------------
a34892a | Edgar A. Bering IV | 2018-09-23 09:18:14 -0400

Stubs for dlua only modules.
Remove spurrious comments triggering ldoc, put in comment stubs in for
modules provided only in dlua. Fixup some punctuation.

--------------------------------------------------------------------------------
49b57b5 | Edgar A. Bering IV | 2018-09-23 09:18:14 -0400

Document dlua additions to the crawl module
Also fix some typos in the previous commit.

--------------------------------------------------------------------------------
96814a8 | Edgar A. Bering IV | 2018-09-23 09:18:14 -0400

Switch over and expand old luadoc
This documents the dlua module colour and the clua parts of crawl, based
on the old LuaDoc comments that were already present.

--------------------------------------------------------------------------------
a2dadd3 | Edgar A. Bering IV | 2018-09-23 09:18:14 -0400

De-Doxygen-ify
These C++ files provide the Lua api, which is documented with ldoc. The
corresponding parts of the internal C++ structure should be documented
at their definitions. Unfortunately ldoc and doxygen almost but
not-quite get along so they are exclusive.

--------------------------------------------------------------------------------
c5a9599 | Edgar A. Bering IV | 2018-09-23 09:18:14 -0400

Switch from LuaDoc to LDoc
LuaDoc never had C++ support, and is now listed as obsolete, directing
users to switch to LDoc, which has C++ support (if a few quirks of its
own).

Adds a make target api-dev to generate a developer's api documentation.
This includes internal functions and hooks that the user should not
touch directly.

--------------------------------------------------------------------------------
dcd3064 | Aidan Holm | 2018-09-23 15:58:45 +0800

Don't include hidden spectators in count (#11691, collin38)

--------------------------------------------------------------------------------
c87c613 | Aidan Holm | 2018-09-23 12:40:52 +0800

Improve monster description quote display
This adds support for showing monster description quotes on webtiles,
and uses a switcher widget to prevent the local tiles popup size from
changing when switching between quote and description.

--------------------------------------------------------------------------------
e70c5d8 | Aidan Holm | 2018-09-23 12:21:10 +0800

Const-ify some member functions

--------------------------------------------------------------------------------
904d0f5 | Aidan Holm | 2018-09-23 12:15:28 +0800

Unparent container widgets' children before destruction

--------------------------------------------------------------------------------
3217af6 | Aidan Holm | 2018-09-23 12:03:28 +0800

Fix rare text widget rendering glitch
If a text widget with a maximum height has its size queried without
being reallocated, its prewrapped text could be expanded beyond what
would normally be shown. This fix ensures that text is wrapped to the
correct size before rendering takes place, even if the widget was not
reallocated (e.g. if it didn't move and wasn't resized).

--------------------------------------------------------------------------------
2f00525 | Aidan Holm | 2018-09-23 12:03:28 +0800

Fix crash when reducing popup width

--------------------------------------------------------------------------------
0ca621a | Aidan Holm | 2018-09-23 12:03:28 +0800

Add background to scrollbars

--------------------------------------------------------------------------------
f37f6fb | advil | 2018-09-20 10:32:57 -0400

Add messaging when servitors skip a turn
Servitors sometimes sit twiddling their thumbs even with a target, and
I've long wondered why, and even if this could be a bug (since this is
something very few monsters do). I've also noticed there's a bunch of
lore around this e.g. you need to constantly do ta to get a servitor to
do something.  It turns out it is intentional, and that for balance
reasons servitors have a randomized interval between casts, that is
implemented by random energy loss. There's no AI problem that I can find
and so there's no need to do ta, but the interface isn't very
transparent about what's going on.

This change simply prints a message on every turn that a servitor loses
to random energy as long as it has a target, so that this random delay
is flavored with "something happening". The situation might also be
helped by being clearer in the UI somehow about when allies have a
target.

As a side note, I'm not really happy about this effect being implemented
using random energy, it'd probably be better to add an extra noop action
to the servitor's action set and balance the weights directly, but
that's a more complicated change to get right

--------------------------------------------------------------------------------
58cdd98 | gammafunk | 2018-09-19 00:17:35 -0500

Fix a message for wand pickup (minmay)

--------------------------------------------------------------------------------
24f899a | advil | 2018-09-18 15:08:00 -0400

Revert complex bones install stuff, add dist_bones to repo
As annoying as it is to have binary files in the repository, the bones
installation code that this commit removes was ending up no less
annoying, and considerably more complicated. This change will also make
it easier for servers that reset the bones folder on incremental updates
to make use of dist_bones.

--------------------------------------------------------------------------------
a5275e7 | advil | 2018-09-17 16:44:49 -0400

Fix the build

--------------------------------------------------------------------------------
cb8baf8 | advil | 2018-09-17 15:27:21 -0400

Don't crash when doing describe-all with a buggy net in los
This also removes net_holdee, instead of relaxing the non-null
assumption; it's just a wrapper on actor_at with some assertions. This
is the first step towards just removing the whole implementation of
net status being stored as an item on the ground.

--------------------------------------------------------------------------------
440b721 | advil | 2018-09-17 10:42:00 -0400

Add bones downloading to the `make source` step
This is intended to simplify packaging on linux; since this step must be
run from a repository, the downloader is more likely to succeed here
than in later packaging steps. The result will be a source distribution
that has the bones tarbell in place so that any build process on that
source distribution defaults to using the local bones file, rather than
downloading. (This could be overridden by deleting the local bones file
in that source directory.)

--------------------------------------------------------------------------------
dbc91a4 | advil | 2018-09-17 10:02:30 -0400

Add a way of using a local bones distribution for make install
To use this, put a file named dist_bones.tar.gz containing bones files
in the appropriate directory structure (in `dat/dist_bones/` in the
tarbell) in `source`. You can also use a custom location by changing
LOCAL_BONES_LOC.  If this file exists, it will override the steps that
try to download the bones file from github. This may be useful for doing
things like building crawl in a chroot that doesn't have wget/curl.

Also updates .gitignore.

--------------------------------------------------------------------------------
3888083 | advil | 2018-09-17 10:01:16 -0400

Clear trapping nets when a monster moves via gell's (minmay)
This appears to have been intentional, but this code is inherited from
singularity, so the history is a bit complicated and I'm not really sure
why it was this way. This was resulting in the net being marked as
trapped, but with no actor trapped in it, so it couldn't be picked up.

Also do some other cleanup that seems to have been missing.

--------------------------------------------------------------------------------
97aacdb | Aidan Holm | 2018-09-15 21:49:22 +0800

Fix inventory menu obscuring some message prompts (#11645, Yermak)

--------------------------------------------------------------------------------
50e1342 | Aidan Holm | 2018-09-15 21:46:19 +0800

Hide shopping list key if shopping list is empty

--------------------------------------------------------------------------------
d05d27e | Aidan Holm | 2018-09-15 20:33:38 +0800

Show correct MP after aborting spell (#11598, Siegurt)
MP is deducted before casting begins, and the deducted amount is
returned if casting is aborted, but the screen was not refreshed
afterward, leading to player confusion.

--------------------------------------------------------------------------------
8f65603 | gammafunk | 2018-09-15 01:51:00 -0500

Properly disable Scrying when abandoning Ashenzari (guyde, salmon)

--------------------------------------------------------------------------------
5ae17c6 | CanOfWorms | 2018-09-11 23:35:06 -0400

More description updates
Mention a (sometimes important) uncommon interaction
of teleportation scrolls. This is already in the status
description section (?/T), but there's no harm in making
it more visible.
--------------------------------------------------------------------------------
07fecf4 | CanOfWorms | 2018-09-11 20:07:57 -0400

Update some scroll descriptions
Clarify exactly what can (or more specifically, can't) be affected by fear.
Unfortunately, this is not a perfect solution as holiness is hidden to the
player, but the holiness of most monsters (especially in the early
dungeon) is usually clear so it should help newer players.

The Cause Fear spell should also have an updated description,
but it currently uses the monster spell description, so that needs
to be adjusted first.

Also remove a very outdated reference to hides in the enchant
armour scroll description.
--------------------------------------------------------------------------------
b21e695 | gammafunk | 2018-09-10 18:34:05 -0500

Adjustments for the Lehudib's Moon Base WizLab
Update the loot in this map to introduce some good loot potions and
scrolls among the loot piles. Also replace the "acquire any" item with
artefact jewellery or good_item aux armour and replace one superb item
in the main loot pile with this. We want to save use of "acquire any"
for things like troves, and there was no need for this particular item
to depend on the player. Next, give the moon troll a couple randomized
monster friends so that he's not stuck all by himself. Finally, slightly
tweak the monster set to remove rust demons and have the random monster
list (used for Shadow Creatures) more in line with the monsters on the
map.

For level adjustments, make some transparent stone areas to see into the
moon troll's lair area. This lets the player see the loot they're after
as well as where they will land when they take the transporter. It also
helps reveal the artefact book in the lair area, which is something
players have tended to miss. Finally, reglyph the vault DES to not use
pre-defined glyphs in our custom glyph definitions.

--------------------------------------------------------------------------------
0d986b7 | gammafunk | 2018-09-10 18:24:08 -0500

Move scroll and potion loot definitions to a better location
The lists formerly in ghost_loot_scrolls and ghost_loot_potions are now
in dgn.loot_scrolls and dgn.loot_potions, respectively, defined in
dungeon.lua. This allows them to be used outside of ghost vaults.

--------------------------------------------------------------------------------
f92cf62 | advil | 2018-09-10 17:31:32 -0400

Remove glob from tar call in Makefile
Gnu tar handles globs differently and they would need to be manually
activated just for those versions; this change should work the same on
all versions of tar (I hope).

--------------------------------------------------------------------------------
6564cf3 | advil | 2018-09-10 17:29:37 -0400

Fix some warnings (gammafunk)

--------------------------------------------------------------------------------
826d253 | advil | 2018-09-10 15:48:18 -0400

Add bones downloading to package/install targets
This is not very elegant in that it will try to redownload the bones
package each time these targets are called, but I did it this way so as
to not make build success contingent on actually downloading this thing
for these targets. Better Makefileing welcome.

I believe this covers all of our packaging targets; I've tested it on
mac tiles only so far.

--------------------------------------------------------------------------------
7711e57 | advil | 2018-09-08 20:25:11 -0400

Attempt to fix newgame colors on remote console (11671)
I can't get this to happen locally, but it looks like an issue with only
8 colors being used in the newgame menus over ssh, even with the right
options set. (Maybe unsurprising, since the options aren't read yet).
This resets the highlight colors for webtiles specifically to what they
were before 44136481aa11. Looks ok in webtiles, could be better.

As a side note, using blue for dispreferred combos (as a fallback for
darkgrey) in console looks really bad.

--------------------------------------------------------------------------------
800ba1e | advil | 2018-09-08 15:15:46 -0400

Add a build target for installing bones distributions
The way this works is that it looks for a file named `dist_bones.tar.gz`
as an asset attached to the most recent tag on github, and downloads any
files in that tarbell that will unpack into `dat/dist_bones`. It will
try either curl or wget, and fail with an error message if neither are
available (or if the relevant link is 404). The tarbell needs to be
manually uploaded to the tag. For now, no other build rule calls this so
it will need to be done manually.

--------------------------------------------------------------------------------
d0dd136 | advil | 2018-09-08 15:15:46 -0400

Add a basic deduplication command for bones files
There might be a bug somewhere that is resulting in multiple copies of
the same ghost?

--------------------------------------------------------------------------------
70f5b00 | advil | 2018-09-08 15:15:46 -0400

Tweak permastore sizes
Branches where the store doesn't include individual levels (e.g. depths)
could be a bit bigger.

--------------------------------------------------------------------------------
daa33e9 | advil | 2018-09-08 15:15:46 -0400

Further tweaks to --bones commands
A few formatting fixes; also, don't require case matching for rm, and
show count for ls.

--------------------------------------------------------------------------------
b54bf1b | advil | 2018-09-08 15:15:46 -0400

Clarify semantics of player_in_hell
I would've expected that this includes the vestibule (and did, leading
to a bones naming bug), but it didn't, so this change provides both
options.

--------------------------------------------------------------------------------
3cb3a19 | advil | 2018-09-08 15:15:46 -0400

Command line tools for manipulating bones files
These are aimed at preparing a bones collection for offline builds.

--------------------------------------------------------------------------------
ee4e6b7 | advil | 2018-09-08 15:15:46 -0400

Increase MAX_GHOSTS
This used to place a (very coarse) limit on how many ghosts could in
principle spawn on the same level. This limit is meaningless now,
because ghosts spawn only via vaults, and it was acting as an artificial
constraint on how many ghosts could be in a bones file. Increase this so
that permastore files can be bigger.

--------------------------------------------------------------------------------
28ba102 | advil | 2018-09-08 15:15:46 -0400

Don't use the full minor tag versioning for bones files
Only use the subset that is relevant to reading and writing
ghost_demons. The issue here is that upgrading a bones file on a server
leads to it not being loadable by older saves, and it gets upgraded any
time a new minor tag is introduced. A previous commit introduced a
somewhat complicated backup system to deal with this, but that still had
some corner cases, and leads to unnecessarily many bones backups on
servers. The fact is that most save compat doesn't have much to do with
bones files, and out of the current 199 minor tags, only 4 actually
impacted bones. So, only use relevant minor tags for bones versions
(which do need to be manually set). I'll leave the backup thing in
place, but this change means that it only rarely will come into play.

This doesn't impact ghost_demons in player saves, which inherit the
versioning from the save.

--------------------------------------------------------------------------------
2c6674c | advil | 2018-09-08 15:15:46 -0400

Support for distributing bones permastore files in dat/
This doesn't yet actually finish the mechanics of distributing them, but
if permastore files are put in the right subfolder of dat/, they will be
copied to the player's bones folder when needed. This should even work
on a server, though it's less necessary there.

--------------------------------------------------------------------------------
ee7bbb8 | advil | 2018-09-08 15:15:46 -0400

Improve the new save version api a bit and use it more
Encapsulates more version logic in just tag-version.h, with a cleaner
interface.

--------------------------------------------------------------------------------
2e7624f | advil | 2018-09-08 15:15:46 -0400

Remove a debugging change

--------------------------------------------------------------------------------
add243b | advil | 2018-09-08 15:15:46 -0400

Improve handling of upgrading bones files for online games
Plus several other fixes + a bunch of streamlining. Now, when a bones
file is loaded that is an old save version, a numbered backup of it will
be made before upgrading so that previous versions of the game can still
use the backup, rather than failing to load the updated versions.

Despite all this fancy footwork, the situation still isn't all that
great. For example, suppose that a player triggers a bones update for
some file from 34.199 to 34.201, and then another player comes along
with save version 34.200. Possibly a solution is to look for older
versions at that point, but I haven't yet come up with a good
implementation of that. Another possible solution is to move to a
seperate versioning system for bones files (probably a subset of the
minor tags); most of this is a pseudo-problem in that there is very
little save compat in bones files at all.

--------------------------------------------------------------------------------
f6d1ed2 | advil | 2018-09-06 22:06:40 -0400

Add cross-compiling to travis
Would be nice to consistently test if the windows build is broken.  This
actually builds the packages, so we could consider replacing the CAO
unstable builds with something like this.

--------------------------------------------------------------------------------
7664ed7 | Aidan Holm | 2018-09-06 22:09:52 +0800

Remove debugging console.log() calls

--------------------------------------------------------------------------------
21b9829 | Aidan Holm | 2018-09-06 22:09:36 +0800

Fix misaligned aptitude table highlighting (#11662, falconhit)

--------------------------------------------------------------------------------
2abc2a7 | Aidan Holm | 2018-09-06 21:56:31 +0800

Add tile for grasping roots monster spell

--------------------------------------------------------------------------------
7935be9 | gammafunk | 2018-09-06 01:05:32 -0500

Give Jorgrun the Grasping Roots spell
This will give Jorgrun a way to get in damage from anywhere and
hopefully give him more chances to get in range for iron shot.

This commit also re-adds Jorgrun to Swamp. He now has a full-range
source of damage that doesn't depend on walls, which Swamp lacks.

--------------------------------------------------------------------------------
b865740 | gammafunk | 2018-09-06 01:05:32 -0500

Rework the Grasping Roots ability of Shambling Mangroves
This monster ability currently applies a Roots status that lowers player
EV, slows movement, and removes any flight. This is similar to a number
of existing monster effects and is a mild effect overall. This commit
reworks Grasping Roots to be a smite-targeted version of monster
constriction, similar to the effect used by the player Borg's Vile
Clutch spell.

Grasping Roots now applies a non-resistable constriction effect to the
player (or target monster) when cast, with similar for escape for the
normal constriction used by e.g. naga monsters. The constriction damage
for Grasping Roots is higher than direct constriction, using two dice
instead of one. This is 2d9 for shambling mangroves at 13 HD, which is
high enough to be significant when applied over several turns.

Constriction impedes movement and lowers EV similarly to how the Roots
status did, but adds additional escape restrictions as well as
significant damage. These help Grasping Roots be a more meaningful
ability without requiring players to learn the effects of yet another
player debuff.

--------------------------------------------------------------------------------
12c6407 | gammafunk | 2018-09-06 01:04:34 -0500

Make a function non-static and reorder its arguments
The monster spell-power calculation will be needed outside of
mon-cast.cc in the future. Also use a more logical argument order that's
consistent with the other global mons_ functions.

--------------------------------------------------------------------------------
e4bf05c | gammafunk | 2018-09-06 01:01:22 -0500

Fix monster spell ranges for certain spells and refactor
For monster spells with range varying based on spell-power, properly use
monster HD as an argument for the range lookup instead of using the
monster's spell-power. This was effectively giving monsters a range
boost for these spells.

Also refactor a range function to have a clearer name and more logical
order of arguments.

--------------------------------------------------------------------------------
1adec7b | gammafunk | 2018-08-31 00:07:13 -0500

An updated tile for the Robe of Vines (ploom, ontoclasm)

--------------------------------------------------------------------------------
8eac906 | gammafunk | 2018-08-31 00:07:13 -0500

Update a Depths vault (minmay)
The door for this vault was meant to contain the jellies, which can't
open doors. However, after the player first comes into view of the
jellies, a subsequent autoexplore will see that the jellies are sealed
and proceed normally, opening the door.

This commit makes the vault have a proper runed door to prevent
autoexplore from opening it. We also update the threats in the vault,
removing early Dungeon slimes and replacing those with slime creatures
and higher level jellies.

Additionally remove unnecessary no_tele_into and no_item_gen flags.
There's nothing in particular about this vault that should require
preventing teleports (or not generating items) compared to other runed
door vaults.

--------------------------------------------------------------------------------
456867d | advil | 2018-08-30 23:23:54 -0400

Fix incorrect .. in some text popups on hidpi displays
The problem was that the window preferred height was calculated
including subpixel advances, but the code to actually split the string
and trim it before rendering it was not. When deciding if text would
fit, it was sometimes (depending on the exact math) predicting that the
text was one line longer than it actual was (with subpixel advances),
and it therefore would chop the last line and put `..` in place of the
last two characters of the prior line.

--------------------------------------------------------------------------------
7f38390 | advil | 2018-08-30 22:10:46 -0400

Fix ?/ at the main menu
This isn't very elegant, it just uses two sequential popups. It's
still better than what was happening before, where the prompt text
wasn't begin displaying at all.

--------------------------------------------------------------------------------
a22e90c | Alan Malloy | 2018-08-29 11:08:36 -0700

Fix announcements for collecting runes in Sprints (hayenne, #11655)

--------------------------------------------------------------------------------
286b84b | advil | 2018-08-29 09:30:38 -0400

Tone down some blue/purple fog machines (hayenne)
These were written assuming a spread rate of 0, I think, but this was
changed in 646ff71b4c43. (Though the size parameter in sprint_mu.des
just seems wrong, and maybe calibrated for gloom before
a0ae0798b3ff7928?)

--------------------------------------------------------------------------------
ef0ad6d | AndSDev | 2018-08-28 12:28:08 -0700

Highlighting exploring horizon behind the doors

--------------------------------------------------------------------------------
722f094 | advil | 2018-08-27 16:43:06 -0400

Tweak newgame highlighting further for console/webtiles
It turns out that console has some fancy thing that automatically
inverts the foreground colors when needed, but this was resulting in
lightgray on lightgray highlighting in webtiles. These tweaks fix that,
and also remove the darkgray on blue combo for non-preferred options
that was also not so readable, replacing it with simple darkgray on
lightgray, which is readable on both targets.

--------------------------------------------------------------------------------
e225a8b | advil | 2018-08-27 11:23:52 -0400

Add explicit description of jelly spawning mechanic to TRJ
This is one of those things that everyone knows, except when they
don't yet, and it's actually fairly spoilery. This change will also
hopefully make the three main corner cases a bit clearer: stabbing,
poly, and (recently) grand finale.

--------------------------------------------------------------------------------
23b030f | advil | 2018-08-27 11:03:12 -0400

Fix a grammar issue with flying corrosive monster bits

--------------------------------------------------------------------------------
2ef98b0 | Aidan Holm | 2018-08-27 21:49:45 +0800

Convert some malloc/free code to std::array

--------------------------------------------------------------------------------
fd4a40f | Aidan Holm | 2018-08-27 21:07:50 +0800

Fix incorrect minimap resizing (RoGGa, #11642)
Placing the minimap uses the difference between m_statcol_top and
m_statcol_bottom to calculate how much available space there is to show
the minimap. m_statcol_bottom was being wrongly calculated because some
inventory size calculations hadn't been completed. This is fixed by
completing those first, if they haven't already been done.

--------------------------------------------------------------------------------
2622018 | Aidan Holm | 2018-08-27 21:07:05 +0800

Allow minimap to shrink when tile_map_pixels set (RoGGa, #11642)

--------------------------------------------------------------------------------
0e7800e | advil | 2018-08-26 18:55:25 -0400

checkwhite

--------------------------------------------------------------------------------
3b8b078 | advil | 2018-08-26 18:55:19 -0400

Spawn jellies when TRJ dies to grand finale (Doesnt)
I'm pretty sure this was just an oversight, the regular jelly spawn code
path is in react_to_damage but grand finale just calls monster_die. This
change brings this TRJ tech in line with poly and stabbing.

--------------------------------------------------------------------------------
2d122dd | gammafunk | 2018-08-26 15:35:48 -0500

Remove the trunk reminder for the 0.22 tournament
This reverts commit aa8cc03057152a697db27c544c24ec6098168342.

--------------------------------------------------------------------------------
a8cb661 | advil | 2018-08-26 09:06:26 -0400

Notify player before forgetting a non-library spell (RoGGa)
Applies to Vehumet gifts. With a large spell library, it's very easy to
lose trick of where spells came from and not be aware that some spell
has only been encountered via vehumet and won't be re-memorizable. Since
the only UI doesn't display this information anywhere in the spell menus
(you'd have to track it down with ?:), include this information in the
new confirmation prompt.

--------------------------------------------------------------------------------
19e28b4 | Aidan Holm | 2018-08-26 02:09:27 +0800

Wrap chardump notes, overview, and messages (NormalPerson7, #11583)
Notes and messages are the major contributors to overly long lines, but
the chardump still contains a few tables that can reach up to 105
columns; these are more difficult to adapt to smaller screen widths.

--------------------------------------------------------------------------------
9417b5c | Aidan Holm | 2018-08-26 01:47:25 +0800

Ask for confirmation when forgetting spells (RoGGa, #11581)

--------------------------------------------------------------------------------
ecc7f9d | Aidan Holm | 2018-08-26 01:34:39 +0800

Fix double-space in Ash dancing weapon warning (Pekkekke, #11603)
Not sure why Ash feels the need to warn about these..

--------------------------------------------------------------------------------
b1aafca | Aidan Holm | 2018-08-26 01:08:12 +0800

Fix X> leaking location of portals (silenth. #11629)
As far as I can see, is_feature() checks against the known feature in a
location; this commit changes that function to return true for portal
entrances and exits, allowing them to still function with > and < if
they are known to be entrances/exits. _is_feature_fudged() calls
is_feature(), and then checks some extra special cases; we remove checks
for portal entrances/exits here, since these are checks against the
actual feature, rather than the player-known feature.

--------------------------------------------------------------------------------
f5ddf05 | Aidan Holm | 2018-08-25 22:23:57 +0800

Fix compilation error with TOUCH_UI=yes (sagitter, GH #833)
This fixes support for clicking the menu title/more in order to switch
panes. It seems quite a few menus don't specify a cycling action,
howver, and there are some menus with multiple toggleable options (e.g.
stash tracker menu); perhaps these should be made into explicitly
clickable buttons?

--------------------------------------------------------------------------------
4413648 | advil | 2018-08-24 19:59:30 -0400

Make newgame menu highlighting less toned down in tiles
Depending on the highlight color, things were pretty invisible at these
alpha values, partly because tiles and console colors *really* don't
match up (even though code assumes they do). This maybe goes too far in
the other direction, so could use some further tweaking.

I also toned down the amount of colors used in the newgame menus on
local tiles, where I don't think they look good. (I have my doubts about
console as well, especially the blue, but I left that as-is.)

The change from WHITE to LIGHTGREY in startup.cc is mainly for local
tiles to balance out the alpha change, it doesn't have an impact on
console.

--------------------------------------------------------------------------------
0f769d1 | advil | 2018-08-24 19:59:30 -0400

Fix swapped blue/green in BoxMenuHighlighter highlight color

--------------------------------------------------------------------------------
a86c9e7 | gammafunk | 2018-08-23 22:30:04 -0500

Updated Azrael tile (ploom, CanOfWorms)

--------------------------------------------------------------------------------
7032119 | Aidan Holm | 2018-08-23 20:09:58 +0800

Fix item description formatting, take two (NormalPerson7, #11632)
Using 'pre-wrap' here instead of 'pre', which was causing some
descriptions to be clipped, since their description text was unwrapped.

--------------------------------------------------------------------------------
ebca68c | gammafunk | 2018-08-23 00:15:23 -0500

Updated mana viper tile (ontoclasm)

--------------------------------------------------------------------------------
4173aa6 | gammafunk | 2018-08-22 23:50:16 -0500

Updated dream sheep tile (CanOfWorms)

--------------------------------------------------------------------------------
8d3be6a | gammafunk | 2018-08-22 21:48:57 -0500

Updated shock serpent tile (ontoclasm)

--------------------------------------------------------------------------------
55e0228 | advil | 2018-08-22 15:02:08 -0400

Provide a (disabled-by-default) way to use lua require
Add #define CLUA_UNRESTRICTED_LIBS to load all libs (or do it from the
command line); if this is set, the original global value for "require"
loaded by package will be bound to `lua_require`. (Crawl has its own
`require` that shadows this.)

--------------------------------------------------------------------------------
b59193a | Aidan Holm | 2018-08-23 02:27:43 +0800

Revert item description fix (silenth, #11633)

--------------------------------------------------------------------------------
497f4a5 | Aidan Holm | 2018-08-23 02:15:57 +0800

Fix require() only failing the first time (pibborn)
Filenames were added to a list of already-loaded files before loading
was actually attempted, which meant that only the first load failure
returned an error, with subsequent require() calls returning true.

--------------------------------------------------------------------------------
6bf7575 | Aidan Holm | 2018-08-23 00:05:23 +0800

Fix god screen powers colours on webtiles (btonasse)
Not proud of this...

fg* are used instead of the colour_* classes because unsurprisingly, the
colours are not actually the same. Separately, the match for the colour
tag is optional because on Gozag everything is yellow all the time, so
only the first line has a colour tag.

--------------------------------------------------------------------------------
d4e5561 | Aidan Holm | 2018-08-23 00:02:39 +0800

Fix webtiles whitespace formatting (NormalPerson7, #11632)
Apart from the issues described in the mantis report, this also fixes a
bug where ash bondage info was not displayed on the ^ screen.

--------------------------------------------------------------------------------
5e4b187 | Floodkiller | 2018-08-21 23:26:09 +0800

Add another set of Gnoll playerdoll tiles
Adds another set of Gnoll playerdoll tiles, by Metoron.

--------------------------------------------------------------------------------
f7ee2ed | advil | 2018-08-20 20:50:41 -0400

Continue to work around old firefox bugs
This time firefox 47 -- it appears that max-height was never inherited
properly from a calc'd max-height in this version, fixed before firefox
49. This makes it explicit everywhere that it's needed (unless I missed
some popup type), which fixes the issue.

n.b. I can still see some broken things in firefox 47, which we may be
less likely to fix. For example, the god screen panes don't work right,
even though this commit makes that popup not completely unusable.

--------------------------------------------------------------------------------
46bba9c | advil | 2018-08-20 20:18:44 -0400

Avoid dith "unlinked items" for clumsy bashes (RoGGa, 11413)
RoGGa noticed in 11630 that this seems to happen when your shadow mimics
a clumsy bash with a ranged weapon. What is happening is that your
shadow unwields the range weapon and then attacks unarmed -- I'm not
even sure if clumsy attacks with a ranged weapon are implemented for
monsters. This was moving the mimicked weapon into the alt slot, and it
wasn't getting cleaned up.

--------------------------------------------------------------------------------
63f3d0b | advil | 2018-08-19 15:04:15 -0400

Load the lua libs correctly for Lua 5.1
It turns out that these setup functions aren't supposed to be called
directly from C as of lua 5.1, but rather called like a lua function.
This is documented (very briefly) in:
http://www.lua.org/manual/5.1/manual.html#5
http://www.lua.org/manual/5.1/manual.html#7.3

This doesn't appear to have mattered for the libraries we were using
(though who knows), but it does matter for other libraries: e.g. package
will panic if not loaded the right way.

A recommendation that I found on stackexchange was to see how it is done
in linit.cc for the specific version of Lua one is using, and follow the
practices there, so that's more or less what I've done.  If we upgrade
Lua to some later version, it sounds like this might change again, so
this code may need to be updated.

(cherry picked from commit ce2052a233ead033e2f61c92c51e49403427babb)

--------------------------------------------------------------------------------
9f8b253 | gammafunk | 2018-08-19 14:02:41 -0500

Make the Temple entrance always visible for two entry vaults (hayenne)
These vaults require access from the floor below and have glass showing
the Temple entrance on the current level. However the entrance is only
visible from a square adjacent to the glass, and it's currently possible
for that square to be a solid feature from the rest of the level. This
commit includes the relevant square as normal floor in these maps.

--------------------------------------------------------------------------------
3bb9011 | advil | 2018-08-19 12:37:02 -0400

Tweak texture loading error message
Make the consequences of the error more transparent to users who
haven't encountered this before.

--------------------------------------------------------------------------------
e8f8661 | Aidan Holm | 2018-08-18 17:00:15 +0800

Show now-monster-only spells on ?/S
Spells that the player used to be able to cast, but that are now
munster-only, are marked as removed by spell_removed(); but since
monsters can still cast them, and the player may reach their description
by other means (such as via a monster description), it's useful to show
them directly in ?/S.

This does not show other spells that have actually been removed (e.g.
delayed fireball), presumably because lookup-help uses the descriptions
database to find all candidate spells, and fully removed spells have had
their descriptions removed.

--------------------------------------------------------------------------------
1b1c699 | Aidan Holm | 2018-08-18 16:57:32 +0800

Restore mass confusion tile
Mass Confusion can still be cast by pan lords and ancestors.

--------------------------------------------------------------------------------
5e01147 | Aidan Holm | 2018-08-18 16:31:09 +0800

Add twisted resurrection tile (NormalPerson7, #11622)

--------------------------------------------------------------------------------
33897af | advil | 2018-08-17 21:59:30 -0400

Fix at least some Beogh unlinked item bugs (8187)
The problem was with named followers who had been gifted items.  What
was happening was that both drop_item and take_item could fail, but
beogh_gift_item() didn't check for these fail conditions and forced the
gift on the follower regardless. If the follower had an old item in the
relevant slot, this left the old item still associated with the follower
but unlinked, and errors started showing up when the follower died and
the item didn't get properly converted to a floor item. The main case
where this came up was if you gifted a follower an item and the item
they already had in that slot was cursed, causing drop_item to fail. The
key symptom (which is rather hard to notice) is that the follower
wouldn't generate a drop message for the old item. I have changed things
so that Beogh removes the curse in these cases, so that the follower can
drop their cursed item.  Alternatively, the gift could just fail, but
this harsher behavior didn't seem to me to contribute anything
interesting to gameplay.

I've also ensured that take_item respects drop_item's fail conditions,
and that beogh_gift_item respects take_item's fail conditions with an
error message.

There are many variants of this out there so I can't promise this fixes
all of them, but I think this will probably fix the Beogh version; all
the saves I have access to are consistent with the case I have
replicated and fixed here, though for many of them the only real
evidence is that a named follower previously died on the level in
question.

To figure this out, it was crucial to get access to a tv that included
the whole sequence of events; thanks to Defined for having a fairly
precise description of their instance of the bug that allowed me to
do this (the tv: `!lg
defined game_key=Defined:cxc:20180717045212S -tv:<T52500:channel=debug`).

--------------------------------------------------------------------------------
417c70b | advil | 2018-08-17 12:00:25 -0400

Sort spell library in morgue files
This previously went by spell enum order, which was a bit confusing.
This commit also unifies the chardump code a bit more with the library
code, and lists completely unmemorizable spells in a chardump as well.
(Currently in-game there seems to be no way to see these.)

--------------------------------------------------------------------------------
3e8b815 | advil | 2018-08-17 11:12:14 -0400

Record the first command of a lua do_commands sequence
The first command was directly processed via process_command, which
didn't send it to the key recorders, but any later commands in the
sequence were recorded. This was causing errors when ` was hit after an
autofight command, because the first command was needed to set the
context properly. Probably a further consequence of various autofight
changes in 0.22.

N.b. repeating autofight leads to (maybe?) an odd result: it doesn't
repeat tab, but rather the key sequence calculated by the first instance
of tab. I'm not sure this really comes up much, but I think you'd expect
TAB+` to be the same as TAB+TAB. It's a bit tricky to get this other
behavior, though, and I think autofight has always worked like this, so
I'm leaving it as-is for now.

--------------------------------------------------------------------------------
66d73a1 | gammafunk | 2018-08-16 19:46:40 -0500

Resize a ghost vault
This makes all potential loot contents visible from outside the vault.

--------------------------------------------------------------------------------
48a0e4a | gammafunk | 2018-08-16 18:05:15 -0500

Remove an unused variable

--------------------------------------------------------------------------------
c4a2057 | gammafunk | 2018-08-16 15:23:01 -0500

Remove an unused legend item from a char dump table

--------------------------------------------------------------------------------
44dc95e | advil | 2018-08-15 15:25:59 -0400

Don't let shop name matching override item matching (Xenobreeder)
Previously, a match against the shop name was just or'd with a match
against the item description, so for example "armour && !!body" would
return everything in an armour shop, because the shop name would usually
also match !!body. This rolls the shop name matching into the item name
matching, so the query is executed against a string containing both.

The remaining disjunction here looks potentially dubious for similar
reasons, I suspect you'd get the same effect with randart descriptions
in shops.

--------------------------------------------------------------------------------
f89bb87 | gammafunk | 2018-08-15 14:12:30 -0500

New tiles for the Mace of Variability (ontoclasm)

--------------------------------------------------------------------------------
9a2f62d | gammafunk | 2018-08-15 14:12:30 -0500

Adjust a Lair entry vault (minmay)
This vault was designed around the guardian being able to fly, but when
fire drakes were removed, the hellhounds that replaced it tends to just
get stuck. This commit substitutes the hell hounds with a fire dragon
and gives this entry the lowest possible weight. A fire dragon is not
too bad an OOD for D:8-11, being equivalent to a 8 or 9 depending on the
Lair entrance depth. This will be a rare, nasty guardian, and of course
players wanting to enter Lair but who are unable to kill the dragon can
employ various means to lure it away from the entrance.

--------------------------------------------------------------------------------
0b27b35 | Free Potion | 2018-08-15 11:37:12 -0700

Update Russian amulet translations
- Removed translation for removed amulets
- Add translation for "reflection

--------------------------------------------------------------------------------
9c62ab6 | advil | 2018-08-15 12:33:05 -0400

Work around a height bug with nested divs in older firefox
This bug (https://crawl.develz.org/tavern/viewtopic.php?f=9&t=25649)
affected firefox versions before 52 and prevented popups from being
sized correctly in the new UI system; they extended off the window to
their max potential height. The firefox bug is
https://bugzilla.mozilla.org/show_bug.cgi?id=1000957.

I'm not going to make a habit of supporting random browser versions like
this, but this particular fix is relatively easy and benign as far as I
can tell.

--------------------------------------------------------------------------------
4a03f4c | advil | 2018-08-15 12:33:05 -0400

Avoid some NaNs if a menu is too tall
This isn't really ever supposed to happen, but it may be possible with
weird zoom values (I encountered it on an older buggy firefox version).
This commit keeps the javascript from breaking, though it *doesn't* make
scroll work right in these circumstances.

--------------------------------------------------------------------------------
c901079 | advil | 2018-08-15 12:33:05 -0400

Don't treat "Another game is already in progress..." as a fatal error
Just another holdover from the days when you re-executed the game to get
back to the main menu.

--------------------------------------------------------------------------------
5f73bc1 | Aidan Holm | 2018-08-13 21:37:13 +0800

Improve webtiles menu scrolling behavior (RoGGa, #11609)
This commit tweaks how visible items are calculated; the bottom item
must now be fully visible. We also now scroll differently when using
pgup: pgup/pgdn/up/down now all line up the first visible menu item with
the top edge of the viewport.

--------------------------------------------------------------------------------
b167e66 | advil | 2018-08-13 09:27:49 -0400

Allow exiting spell descriptions with more keys
We should probably standardize these keys across description screens to
some degree.

--------------------------------------------------------------------------------
22930c1 | advil | 2018-08-12 22:13:53 -0400

Actually disable memorizing from books in shops via descriptions
e17c9578eba4 disabled the message telling you you could, but didn't
actually prevent M at the spell description from working for a book in a
shop.

--------------------------------------------------------------------------------
29e5e51 | gammafunk | 2018-08-12 20:02:37 -0500

Merge pull request #837 from nonfreeblob/some-changes
Small fix
--------------------------------------------------------------------------------
829b399 | nonfreeblob | 2018-08-13 02:04:58 +0300

Small fix

--------------------------------------------------------------------------------
df0b57c | Aidan Holm | 2018-08-12 15:57:23 +0800

Add missing status descriptions (joemaro, github #836)

--------------------------------------------------------------------------------
012e35b | gammafunk | 2018-08-12 00:39:57 -0500

Adjust the Vampire's Tooth guarded unrand vault
This vault was based on the +4 dagger version of the unrand. Now that
this is a significantly stronger weapon, move the vault deeper and
adjust monsters accordingly. For Dungeon, use vampire mosquitoes and a
smattering of tyrant leeches on the outside, with vampires and vampire
knights (in the latest depths) guarding the inside. This vault also now
places in Crypt and Depths, where only vampire knights and vampire mages
are used.

Finally, use a quick blade as the base type for the artefact weapon when
the vampire's tooth has already generated.

--------------------------------------------------------------------------------
c95c2c7 | advil | 2018-08-11 22:28:12 -0400

Fix two packaging issues for source tarbells
(i) the LICENSE file was missing due to its change in location (#834)

(ii) we plausibly shouldn't redistribute a minified / webpacked version
of simplebar.js (#835). This commit simply removes it from the nodeps
source tarbell, but this needs to be examined a bit further. (I first
tried to put it in a contrib directory under game_data and exclude that,
but something about how the tornado python class for serving game_data
is configured wasn't letting this happen very easily.) This library is
MIT licensed and has four small dependencies, all themselve MIT licensed
with no more dependencies, and isn't very big itself, so there's not a
deep reason that this has to be minified as far as I can see. This file
isn't used or present in any of the regular distributions of crawl, but
it (as well as several other js files) are present in minified form in
the deps tarbells still.

--------------------------------------------------------------------------------
aa8cc03 | gammafunk | 2018-08-10 12:10:57 -0500

Add a trunk reminder for the 0.22 tournament

--------------------------------------------------------------------------------
c252fe1 | gammafunk | 2018-08-09 17:45:06 -0500

Remove old hints code about Sif Muna refusing worship (RoGGa, 11578)
Sif no longer requires potential worshipers to have a spell before
accepting worship.

--------------------------------------------------------------------------------
5c563b8 | gammafunk | 2018-08-09 17:41:33 -0500

Rewrap the FAQ.txt file (RoGGa, 11512)

--------------------------------------------------------------------------------
67ddc3d | gammafunk | 2018-08-09 17:36:09 -0500

Update the quickstart.txt for wand identification (RoGGa, 11562)
Wands now ID upon pickup, so have this section only talk about scrolls
and potions.

--------------------------------------------------------------------------------
7fb8b5c | gammafunk | 2018-08-09 17:18:22 -0500

Finalize the Debian changelog for the 0.22 release

--------------------------------------------------------------------------------
b446a2b | gammafunk | 2018-08-09 17:18:06 -0500

Finalize the changelog for the 0.22 release

--------------------------------------------------------------------------------
64c3ba7 | advil | 2018-08-09 12:51:59 -0400

Make menu wrapping at the end not the default
The previous behavior (in local tiles and console, but not webtiles) was
that when you reach the end of a menu, and scrolled down (e.g. with
pgdn), the menu wrapped back to the beginning. This was fairly confusing
for things like inventory, and just bad UI design for longer scrolling
menus like ctrl-f results.  This change makes wrapping opt-in rather
than opt-out, and then doesn't add it to any menus. I did it this way
rather than removing it entirely in case we get begged to add this back
for some menus, but I can't really think of an existing menu in crawl
where it would be better to wrap than just to stop. Home and End should
nowadays work consistently in any scrolling menus in any case.

No impact on webtiles.

--------------------------------------------------------------------------------
35ef639 | Aidan Holm | 2018-08-09 12:21:20 -0400

Add tile_single_column_menus option (KurzedMetal)
Some users complained that reading some menus was now more difficult,
since items in individual categories are displayed in two columns.
One example is when scanning a particular category of items in the
inventory; the player will need to scan left-right as well as up-down.

This new option allows users to force menus to use a single column. It
isn't a perfect solution, but webtiles and console already only support
single column menus, and there aren't too many complaints about that...

--------------------------------------------------------------------------------
dab52ba | advil | 2018-08-09 12:17:15 -0400

Prevent hidden menus from intercepting some keys in webtiles
Seems to have mostly impacted direction keys. This will hopefully fix
all of 11579, 11584, 11592.

(cherry picked from commit 4d0fc0409815ddadc32dc814b008b1fe2e47040b)

--------------------------------------------------------------------------------
8b66304 | Aidan Holm | 2018-08-10 00:01:41 +0800

Add ui-overhaul highlights to changelog

--------------------------------------------------------------------------------
b7c0dbd | Aidan Holm | 2018-08-09 23:16:19 +0800

Fix unused variable

--------------------------------------------------------------------------------
65f37df | Aidan Holm | 2018-08-09 23:08:36 +0800

Fix webtiles level map message hiding (sort of) (Yermak, #11602)
This fixes some recent issues with the level map not showing message
prompts as part of e.g. X! and XG. 1e3a2e4e2f deleted some code that I
previously believed was no longer needed. It's unlikely GOTO_STAT is
strictly necessary though, since these bugs only happened with messages.

This fix only papers over the underlying design flaw, however. viewmap
uses an RAII object (tiles_ui_control) to push a UI state onto a stack,
but the state switching in cgotoxy() does not preserve the previous UI
state. This causes X to lose its fullscreen state on webtiles after ! or
G is used.

--------------------------------------------------------------------------------
995a8c5 | Aidan Holm | 2018-08-09 23:08:36 +0800

Refactor menu code out of menu widget
This commit moves some of the more menu-UI-centric code out of the menu
widget and into wrapper widgets, with the eventual goal of making the
inner menu list widget embeddable in other UI layouts.

This also fixes a local tiles issue where menus would not rewrap from
two columns to one column when the window was expanded vertically, due
to the menu widget not being repositioned. THis bug was caused by menu
widgets being aligned to the top.

--------------------------------------------------------------------------------
18126d3 | Aidan Holm | 2018-08-09 23:08:36 +0800

Fix console scroll indicator formatting
Only show "top" when right against the top (show 0% for "very close to
the top"), and show " 0%" instead of "  %".

--------------------------------------------------------------------------------
c974853 | advil | 2018-08-09 09:31:31 -0400

Fix license for win installer
(cherry picked from commit 1cde9558587f09c0e81b3dbc6590d43036449fb7)

--------------------------------------------------------------------------------
5c1dd30 | advil | 2018-08-09 09:28:28 -0400

Try to fix build stuff with license (gammafunk)

--------------------------------------------------------------------------------
ceb0d1a | Aidan Holm | 2018-08-09 20:57:37 +0800

Fix ^, A screens not switching panes correctly (advil)
Pane-switching was being triggered twice, once for the keydown event and
a second time for the subsequent keypress event.

--------------------------------------------------------------------------------
0539d74 | Aidan Holm | 2018-08-09 19:58:09 +0800

Fix XG not showing prompt on webtiles (NormalPerson7, #11599)

--------------------------------------------------------------------------------
4bf3f6c | advil | 2018-08-08 21:32:42 -0400

Wrap power descriptions in ^ screen
(cherry picked from commit 0aedee734a0a934f6e24a4c4167c25ceaa0d0c19)

--------------------------------------------------------------------------------
3378232 | gammafunk | 2018-08-08 19:43:52 -0500

Simplify a Xom teleport function
This is only ever called for Xom's teleport effect now.

--------------------------------------------------------------------------------
4edfe68 | gammafunk | 2018-08-08 19:43:52 -0500

Rework the xp_by_level table to track vault origin instead of spawns
This table currently tracks proportions of monster XP and counts that
come from spawns vs normal level generation. This was useful when we
were determining how much XP spawns were generating in preparation for
removing spawns. Now that spawns have been removed from most branches,
this information isn't useful to track.

This commit revises the table to track monster XP/count from vaults vs
non-vaults. Orb spawns are excluded from that tallying, just as before.
This information will be useful for balance purposes, especially in
trunk if we make substantial changes involving vault placement.

There is save compat that tallies any existing monster XP/counts into
the non-vault category for transferred games, which is the best we can
do.

--------------------------------------------------------------------------------
69a49ca | gammafunk | 2018-08-08 19:43:52 -0500

Use a define for a prop key

--------------------------------------------------------------------------------
d13e529 | advil | 2018-08-08 16:26:21 -0400

Limit a redraw to the special case it is fixing (gammafunk)
The redraw in 2f468e5a and 2f468e5 is only needed for the case where an
item is evoked from inventory; limit it to that case. It's causing
display problems in targeting, and flickering in ttyrecs.

(I think the original commit probably did it in this order because it
was also redrawing the message window at the time.)

--------------------------------------------------------------------------------
30ddca7 | advil | 2018-08-08 16:25:30 -0400

Remove some "now"s
These descriptions are used for the ^ screen, so "now" doesn't make
sense here.

--------------------------------------------------------------------------------
fa3a264 | Aidan Holm | 2018-08-08 20:02:06 +0800

Prevent shop menu from using two columns (RoGGa, #11597)

--------------------------------------------------------------------------------
ae6112e | advil | 2018-08-07 12:47:12 -0400

Improve dig targeter for fulldebug builds
valid_aim is really supposed to be a lightweight call (and is treated
that way by callers); the initial implementation fired a beam for each
call via set_aim, which is not lightweight at all. On fulldebug builds,
this was also completely filling the log with beam spam. This commit
adds caching of the beam firings so that set_aim only needs to be called
once for each square in los.

--------------------------------------------------------------------------------
4ff6b17 | advil | 2018-08-07 12:47:12 -0400

Make some webtiles _send... calls inert to reentry
This prevents certain ways of getting malformed json out of the webtiles
code. The main offender: if a _send... function can trigger an _mpr that
causes a more, then the original _send...'s json may be interleaved with
message json. This was happening with _send_map in extreme cases on the
dig targeter (which generates a very large amount of beam objects, each
of which is a dprf on fulldebug builds): generating beams would
eventually trigger a more, which would trigger a call to
TilesFramework::redraw, which would then trigger _send_map, which when
drawing cells in direction chooser mode would call valid_aim on the
direction chooser object, which would then generate a beam, which could
generate a more, etc. There are other issues here specific to the
particular buggy case which should be fixed directly, but even with this
sort of complicated interaction we don't want to ever send malformed
json, as the client can get in stuck states.

The _send... calls I have changed here should be basically fine if they
don't happen immediately as needed. I didn't change other _send...
calls, but one option there would be to add an ASSERT rather than make
them inert.

--------------------------------------------------------------------------------
bb52cfb | advil | 2018-08-07 12:47:12 -0400

Don't do extra map redraws in direction chooser
This replaces 2f468e5a82e4 with a hackier workaround but one that avoids
redrawing the map -- direction chooser has its own redraw code and using
the general redraw code here has awkward interactions with the direction
chooser (even setting aside the recursion bug that this will fix).

--------------------------------------------------------------------------------
dc02b5f | Aidan Holm | 2018-08-07 23:18:17 +0800

Fix monster abjuration description UI (NormalPerson7, #11589)
SPELL_ABJURATION, despite being present in the list of removed spells,
is still used by monsters, where it is automaticaly added to their
spellsets. This commit uses the Aura of Abjuration tile for this spell,
and makes it visible from ?/ as well.

--------------------------------------------------------------------------------
799c399 | advil | 2018-08-07 09:08:43 -0400

Fix Ru sacrifice health (joy1999 / 11549)
Missing break means extra int/MP-related bonuses.

--------------------------------------------------------------------------------
d9f7a49 | advil | 2018-08-05 14:57:00 -0400

Update changelog for 0.21.2

--------------------------------------------------------------------------------
1b84a70 | advil | 2018-08-05 14:46:06 -0400

Revert "Fix autotravel out of hell"
The search for target stairs needs to be done on a level excursion. I
think the best solution is to refactor the branch entry storing so that
it stores a particular stairs, not just a level, but I'm not going to
mess with this further until 0.23.

This reverts commit 1388f29e5435320083fdb751e8622ee18bf11a4e.

--------------------------------------------------------------------------------
c138b1c | advil | 2018-08-05 14:06:26 -0400

Move tiles initialization later
18642516775 attempted to move tiles initialization earlier, so that more
error conditions could be shown in the UI. However, this seems to result
in at least some init file options that are relevant for (web)tiles not
applying, such as font settings (Leszczynek).

--------------------------------------------------------------------------------
8441a8a | Aidan Holm | 2018-08-05 18:21:00 +0800

Tidy up menu.h

--------------------------------------------------------------------------------
0e48039 | Aidan Holm | 2018-08-05 18:20:56 +0800

Fix some menus' wrapping behaviour
Using spaces for padding here; yuck.

--------------------------------------------------------------------------------
987bf7f | Aidan Holm | 2018-08-05 18:20:56 +0800

Fix menu titles being off by 2px

--------------------------------------------------------------------------------
b66208c | Aidan Holm | 2018-08-05 16:31:43 +0800

Add MF_NO_WRAP_ROWS menu option for tables
This menu option causes menu rows to be ellipsized instead of wrapped
when the menu width is too narrow to show the full content. This is
necessary to prevent the ability menu from breaking when showing
Makhleb's abilities with "hostile" suffixes.

A better fix for this and other menus would be to move column sizing
into the menu class, perhaps with the help of the ui::grid widget.

--------------------------------------------------------------------------------
e9112c3 | Aidan Holm | 2018-08-05 15:41:46 +0800

Trim ability menu entries

--------------------------------------------------------------------------------
8b50da7 | Aidan Holm | 2018-08-05 14:29:47 +0800

Fix OpenGL error on startup
A value of 1 should be used for GL_UNPACK_ALIGNMENT, since raw pixel
data is densely packed.

--------------------------------------------------------------------------------
73ad57d | Aidan Holm | 2018-08-05 14:29:47 +0800

Fix shop menu text when placing items outside (ShadedKnight, #11582)

--------------------------------------------------------------------------------
5b15854 | Aidan Holm | 2018-08-05 14:29:47 +0800

Fix dancing weapons tile missing in xv (RoGGa, #11571)
With any luck, this won't horribly break other tiles...

--------------------------------------------------------------------------------
6d804a8 | advil | 2018-08-04 21:38:36 -0400

Unbrace

--------------------------------------------------------------------------------
07dd351 | advil | 2018-08-04 21:30:49 -0400

Tweak conditions under which error ui is used
It is now not used on -builddb, and not necessarily used for tests or
scripts. This commit also prints errors to stderr on tests a bit more
aggressively, which reveals a ton of .des issues that might be worth
fixing (mostly shafts in a branch end; the fix for this might not be
printing that as an error).

--------------------------------------------------------------------------------
b0c4752 | advil | 2018-08-04 20:56:09 -0400

Update prebuilt
Hopefully there's nothing OS X-specific about this.

--------------------------------------------------------------------------------
1864251 | advil | 2018-08-04 20:26:35 -0400

Various changes to smooth out / improve error messaging
Previously, except on windows console builds, error reporting on end(1,
...) calls was done mainly via stderr output. On windows console builds,
since there is no reliable way to view stderr output, there was an
ad-hoc error message screen that was used very inconsistently. I assume
that nothing comparable was done on tiles builds because it would have
been technically a bit tricky, especially for errors early on. There was
also a slightly more ad hoc thing with a similar effect that was used as
a backup on windows console, and also on DGL builds that have
DGL_PAUSE_AFTER_ERROR set (which I think is basically all of them).

The intent of this change is to make error reporting, especially for
errors on startup, more consistent across builds and more usable in
general. On all builds, if possible, an end(1, ...) call results in a
popup that shows the error message, and gives the user a chance to view
the entire current log. This change also ensures that the error message
gets logged, and is echoed to stderr if necessary. This now easy on
windows tiles builds because of the new UI system.

Unfortunately very early errors on tiles builds still can't be
displayed, because they happen too early for the tiles UI to be in
place. One specific problem is that there's no provision for trying to
use system fonts as a backup, so these changes won't yet deal with the
case where the data directory is missing on tiles builds. It will show
sensible errors for this case on console builds.  It will as print
sensible errors on all build targets if there's a failure during des
parsing, or database parsing in general.

This commit also includes specific improvements to handling of early
startup fail cases, including trying to validate the data directory a
bit more sensibly.

For now, none of this is used on a crash, because it wasn't clear to me
that it would be generally safe to use ui code; I think it might be
reasonable to try on intentional ASSERTs, but I'll leave that for later.

--------------------------------------------------------------------------------
6c27897 | advil | 2018-08-04 19:27:53 -0400

Fix USE_DGAMELAUNCH builds (OS X-specific?)
One of these fixes is definitely OS X-specific, the include file change
might apply more broadly.

--------------------------------------------------------------------------------
1e3a2e4 | Aidan Holm | 2018-08-04 14:21:41 +0800

Remove most remaining CRT control code, take two (NormalPerson7)
This commit removes most of the CRT layer control code, since it is no
longer used. The few remaining user interfaces which use an emulated CRT
on webtiles now use the single function tiles_crt_popup RAII class,
which renders CRT output to a webtiles popup.

This also fixes an issue where the Xv screen was misbehaving on
webtiles.

--------------------------------------------------------------------------------
1388f29 | advil | 2018-08-03 12:42:09 -0400

Fix autotravel out of hell
Before, autotraveling out of hell while you are in it would incorrectly
use the stair destinations. What will actually happen if you take those
stairs is that it will use the value in brentry (set when you enter the
branch) to find a hell portal on the stored location, and put you there.
This change replicates this logic in the cross-level autotravel code.

Note that this change by itself wouldn't fix the bug addressed in the
previous commit (autotraveling into hell), because it is contingent on
the brentry stored value being updated -- that only happens when you
actually enter hell.

--------------------------------------------------------------------------------
cb77f54 | advil | 2018-08-03 12:42:09 -0400

Don't try shortcuts through hell when autotraveling
When you actually enter the vestibule, the branch entry point is set to
the portal you entered from, and exiting from any portal uses that entry
point rather than the actual destination of the portal in the vestibule.
However, each portal does have a particular destination scattered
throughout depths (and perhaps orc end), and autotravel was looking at
these destinations when trying to find cross-level routes. This
workaround simply doesn't consider routes through hell unless there is
explicitly a target in hell, or you are already in hell.

I also added some (disabled-by-default) debugging code that will
probably be useful in the future.

--------------------------------------------------------------------------------
40385e1 | Aidan Holm | 2018-08-04 00:19:07 +0800

Add some monster spell tiles (NormalPerson7, RoGGa, #11580)
As well as adding some new tiles, this commit also makes all removed
spells use the error tile, uses the blink tile for some of the blink
variants, and removes the mass confusion tile.

--------------------------------------------------------------------------------
1be82e5 | advil | 2018-08-02 22:38:34 -0400

Missing #ifdef

--------------------------------------------------------------------------------
2ba9a4c | advil | 2018-08-02 21:49:40 -0400

Don't send messages to webtiles until game has started
They were accidentally being sent too early. The new state variable is
because need_save (annoyingly doesn't have exactly the semantics I
needed for end-of-game messaging (it gets cleared on death or quitting).

--------------------------------------------------------------------------------
b4ac13e | advil | 2018-08-02 19:00:38 -0400

Replace the shadow startup logger with actual logging
This logger only registered rc file/options errors and one misc other
item-related error, and had a completely separate API. It also showed
errors at so odd of a time that I didn't even know this error dialogue
existed (during the new character chooser).

This commit replaces this semi-hidden logger with the regular logger,
and shows the error dialog at a much more useful time. As before, the
dialog will respect Options.suppress_startup_errors.

This commit shouldn't affect DGL-based webtiles builds, which report
options errors to the player after they start the game.

--------------------------------------------------------------------------------
9187234 | advil | 2018-08-02 13:01:28 -0400

Move license to a more standard location in the repo
(and drop the australian spelling, sorry)

--------------------------------------------------------------------------------
71d24ad | advil | 2018-08-02 12:30:33 -0400

Generate Akashic Record in Golubria (gammafunk)
Replaces "plane papyrus" in  54af7f11.

--------------------------------------------------------------------------------
54af7f1 | advil | 2018-08-02 12:25:53 -0400

A laundry list of .des fixes
Mostly parsing errors for items that don't actually prevent game load
and didn't use to be visible anywhere.  All of these were revealed by
the recent changes to early-game logging.

--------------------------------------------------------------------------------
99b7a44 | advil | 2018-08-02 12:25:53 -0400

Fix an orphan in tutorial 1
This was causing a linebreak at 80x24 that put a more in the middle of
the keys diagram.

--------------------------------------------------------------------------------
9ab8a37 | advil | 2018-08-02 12:25:53 -0400

Don't output in tutorial on des validation

--------------------------------------------------------------------------------
8546c30 | advil | 2018-08-02 12:25:53 -0400

Add more early game logging
for diagnostic purposes. This won't be visible to the user unless they
look at ctrl-p in the main menu.

--------------------------------------------------------------------------------
ccba538 | gammafunk | 2018-08-02 11:09:33 -0500

Reduce early numbers of two-headed ogres (minmay)
For most characters before Lair, two-headed ogres are difficult monsters
to kill and dangerous to engage in melee. This monster was substantially
buffed in 4a298068, yet its weighting was unadjusted except for
absorbing weight of hill giants when those were removed.

This commit switches the distribution shape of two-headed ogres to SEMI,
which gives them half weight on D:8-11, and also reduces their weight by
10%. These changes mean that about 1.5 two-headed ogres are seen
on-average before D:12, which is about half as many as generate on those
levels presently.

--------------------------------------------------------------------------------
f95e932 | gammafunk | 2018-08-02 11:09:33 -0500

Remove fire crabs from the Cloud Mage wizlab (qwqw)
Fire crabs aren't threatening in general by this depth, but a cloud type
has to have have fairly good impact in few turns on this map, since air
elementals can override them quickly. Miasma from death drakes and chaos
from apocalypse crabs are pretty good in this regard, and ghostly create
some nasty summons. Flame clouds, on the other hand, won't do too much
in a turn or two. This commit removes fire crabs from the map.

--------------------------------------------------------------------------------
6c29bc1 | Aidan Holm | 2018-08-02 22:55:46 +0800

Improve acquirement UI (RoGGa, #11573)
Adds support for cancelling acquirement if the scroll type is already
known. Also adds the ability to show the shopping list, in a read-only
mode.

--------------------------------------------------------------------------------
b74a1d2 | Aidan Holm | 2018-08-02 22:55:46 +0800

Fix invalid read on crawl shutdown
UIRoot's destructor accesses the path of hovered widgets, so destruction
order (and thus declaration order) matters.

--------------------------------------------------------------------------------
1626fb9 | Aidan Holm | 2018-08-02 20:44:55 +0800

Show gold when reading ?acq (RoGGa, #11573)

--------------------------------------------------------------------------------
346603e | Aidan Holm | 2018-08-02 20:27:34 +0800

Fix webtiles scroller handling keypresses as keydowns (Xenobreeder)

--------------------------------------------------------------------------------
8c9a20f | advil | 2018-08-01 17:59:16 -0400

Do messaging for aux attacks that kill (G-Flex)
I think this call should be safe, but if it starts generating
DEAD_MONSTER messages, the string probably needs to be built before
inflict_damage.

--------------------------------------------------------------------------------
b09bef4 | Aidan Holm | 2018-08-01 23:22:02 +0800

Fix webtiles ability menu heading alignment

--------------------------------------------------------------------------------
91aedc1 | Aidan Holm | 2018-08-01 23:05:28 +0800

Fix webtiles not handling some scroll keys (thmsdrew, #11576)
Keypress events, such as are generated for text input, were not being
correctly delivered to scroller_handle_key(). This caused >, <, etc.
to be passed through directly to the underlying console UI, and caused
scrolling to happen on the server side. The space key was slightly
different; it seems to have been handled on both the client side
(causing an immediate scroll of one page), and then again on the server
side (causing a one-page scroll one RTT later).

--------------------------------------------------------------------------------
b05fda6 | Aidan Holm | 2018-08-01 22:35:02 +0800

Add missing code
...oops

--------------------------------------------------------------------------------
4fad9ab | Aidan Holm | 2018-08-01 22:13:40 +0800

Always scroll console menus down by a full page (Xenobreeder, #11507)
The issue was caused by the scroller widget automatically scrolling the
menu widget up again, so as to show as much content as possible.

This is fixed by adjusting the size requested by the menu widget,
according to how we scroll; this works because the scroller widget only
scrolls content fully into view when it is reallocated, which occurs
after the menu's size request changes.

One defect with this approach is that the size request is not adjusted
when the window (and thus the menu) is resized. This is pretty minor,
however, since console users rarely resize their terminals.

--------------------------------------------------------------------------------
a393550 | Aidan Holm | 2018-08-01 22:13:40 +0800

Fix console menu footer not sticking to screen bottom
Unfortunately, rounding errors prevent flex_grow from being very useful;
the last pixel of a parent is never filled. This caused the menu footer
to stick to the line above the screen bottom.

--------------------------------------------------------------------------------
b809bb7 | advil | 2018-07-31 17:06:07 -0400

Update changelog for 0.21.2

--------------------------------------------------------------------------------
557ef7e | gammafunk | 2018-07-31 10:30:38 -0500

Fix sdl2 contrib compilation for Linux cross-compiling to Windows.
Set execute permissions on an SDL2 build check script.

--------------------------------------------------------------------------------
5b5cf6b | Aidan Holm | 2018-07-31 23:24:13 +0800

Improve default menu more text (fakechuck, #11563)
Showing and hiding the menu "more" text based on whether there's more
content to scroll to isn't very useful on (web)tiles; that's what the
scrollbar indicates. It's still useful on console; this commit cleans up
the default text, and shows the current scroll position as a percentage.

Currently the more text is often hijacked to display a text-based UI;
it'd be nice if these uses were separated, but that's likely somewhat
tedious.

--------------------------------------------------------------------------------
bf19839 | Aidan Holm | 2018-07-31 23:24:13 +0800

Add wall jump tile

--------------------------------------------------------------------------------
8f018a2 | advil | 2018-07-30 22:16:41 -0400

Wrap Gyre & Gimble code in a player check
I'm not sure why this is necessary, but the weapon() call appears to be
causing crashes, e.g.:
http://crawl.akrasiac.org/rawdata/ventolin/crash-ventolin-20180731-000054.txt

--------------------------------------------------------------------------------
94b1d5a | Kyle Rawlins | 2018-07-30 21:19:37 -0400

Add caveat to changelog entry for webtiles commands

--------------------------------------------------------------------------------
af6b6ee | advil | 2018-07-30 20:36:16 -0400

Add autofight commands to keybind.txt (11569)

--------------------------------------------------------------------------------
9a9f1d3 | advil | 2018-07-30 20:16:25 -0400

Remove unused book burning code (11562)

--------------------------------------------------------------------------------
030cbd3 | advil | 2018-07-30 20:16:25 -0400

Remove obsolete discussion of ghosts (11562)

--------------------------------------------------------------------------------
b94f922 | gammafunk | 2018-07-30 19:07:35 -0500

Update the changelog through 0.22-a0-900-g8945bfbd8a
[skip ci]

--------------------------------------------------------------------------------
8945bfb | gammafunk | 2018-07-30 17:44:54 -0500

Adjust placement of Sonja and Urug
Sonja and Urug have placements that are inconsistent, like Sonja's
placing only in earlier Lair yet placing on D:13-15, and her placing on
Orc:$ yet not on Orc:1. This commit makes these uniques' placement more
consistent and also trims their placement in late Dungeon levels,
allowing them to place more in Lair and Orc instead.

--------------------------------------------------------------------------------
402804a | gammafunk | 2018-07-30 17:34:48 -0500

Cleanups for uniques.des (amalloy)
Clean up syntax to not refer to branch end levels by specific number,
using the `Branch:$` syntax instead, and wrap lines by using multiple
DEPTH statements.

--------------------------------------------------------------------------------
013a482 | Alan Malloy | 2018-07-30 15:16:30 -0700

Add some more diagnostic info about markers to crashlogs

--------------------------------------------------------------------------------
1b7a381 | gammafunk | 2018-07-30 13:56:42 -0500

Clean up the uniques DES file
Move Jorgrun to the section for uniques placing in Dungeon, since he no
longer places in Depths.

--------------------------------------------------------------------------------
68665cc | gammafunk | 2018-07-30 13:46:25 -0500

Fix a type in an integer comparison

--------------------------------------------------------------------------------
32a3b1c | gammafunk | 2018-07-30 13:46:26 -0500

Remove or reduce most down-weighting for ghost vaults
Many ghost vaults were down-weighted relative to other ghost vaults in a
way that was somewhat arbitrary. The down-weighted vaults didn't pose
threats that were particularly extreme, and some of the
normally-weighted vaults have proven quite capable of killing players
even if you factor in the difference in placement between vaults.

This commit makes most ghost vaults have normal weight, using
down-weighting only in pre-Lair dungeon where vaults place 8-tier
monsters. ebering_ghost_inner_flame and ebering_ghost_gozag get half
weight in these levels, since they place 8 spawns. ebering_ghost_xom
gets 0 weight on D:3-5, where a dancing weapon is worse than an even an
8 spawn, and half weight for D:6-7 where a dancing weapon is roughly a
high-rolling 8 spawn.

--------------------------------------------------------------------------------
501d55f | gammafunk | 2018-07-30 13:39:45 -0500

Reduce Harold's casting frequency
He casts his spells a bit too frequently with his current spell weights,
so this commit lowers them by a third.

--------------------------------------------------------------------------------
833fe4c | gammafunk | 2018-07-30 13:39:45 -0500

Adjust Jorgrun's spells and move him earlier
Shatter is not a good monster spell, since it can often one-shot
Gargoyle players or players who happen to move into LOS in statue form.
There are enough LOS-wide unavoidable damage monster spells, and we
don't need another one just because it's based on a player spell or
because it can be resisted with flight. This commit removes Jorgrun's
Shatter spell, replacing it with Iron Shot. Iron shot is not the most
interesting spell for a unique to have, but it does give him an
always-usable source of ranged damage. I have a local branch testing out
monster Borg's Vile Clutch, but this is probably a silly idea. Monsters
with ranged constriction could be fun, so I'll test it and possibly try
replacing his Iron Shot with that spell in 0.23. Should this unlikely
event happen, any blame will deftly be redirected to mikee.

This commit also adjusts Jorgrun's placement to have him show up earlier
and on fewer levels. Previously he showed up on 30 levels, second only
to Donald. His new placement range is:

D:12-15, Orc, Elf:1-2, Snake:1-3, Shoals:1-3, Spider:1-3

His Petrify spell is more effective when players are less likely to have
high MR, so using these earlier levels will help his Petrify/LRD combo
be more relevant. Swamp is omitted since his Dig and LRD are not
effective there.

--------------------------------------------------------------------------------
e275911 | advil | 2018-07-30 14:32:48 -0400

Rework xp_to_level_diff further
This better handles a few cases:
 * cases where there is less than one level to go
 * cases where the player is >xl 27

It is also much cleaner and more obvious about what it is doing.

Resolves #786

--------------------------------------------------------------------------------
5786b86 | shieldal | 2018-07-30 14:32:48 -0400

Make the estimate of XLs to mindelay more accurate (11490)
When a player is not at a whole number xp level, the previous code
didn't properly handle the fractional level already attained.

--------------------------------------------------------------------------------
962055f | Alan Malloy | 2018-07-30 10:55:31 -0700

Explain why 120 is the default randomness range for colours

--------------------------------------------------------------------------------
725e010 | Edgar A. Bering IV | 2018-07-30 10:53:10 -0700

Recolour awoken forests in console.
Make awoken forests an animated RED/LIGHTRED (angry trees) so that the
effect stands out to the player.

Old behavior is awoken forests are an animated GREEN/LIGHTGREEN
alternation. This sticks out a bit in swamp, where trees are
GREEN/BROWN, but is still not as dramatic as the berserk faces now in
tiles. It is also much less noticable outside of the swamp (some lair
ends in particular) where trees are GREEN/LIGHTGREEN to begin with.

--------------------------------------------------------------------------------
1f7d957 | Edgar A. Bering IV | 2018-07-30 10:53:10 -0700

Turn a magic number into a class member
element_colour_calc and random_element_colour_calc were using a magic
number of 120 for the random max, requiring the total weight for random
colours to add up to 120. This moves the weight to a member, which is
default initialized to 120 to work with the existing code, and is
initialized to the total weight by random_element_colour_calc's
constructor so that elemental colours are more robust in the future.

As a consequence, Wu Jian's console colours no longer have an extraneous
and un-indended GREEN, which was the previous default for unused weight.

--------------------------------------------------------------------------------
3327843 | Edgar A. Bering IV | 2018-07-30 09:27:04 -0700

Kung Fu with swordchucks (11402)
Allow Gyre and Gimble to double-attack in Wu Jian martial attacks.

(Implementation introduces the behavior that a player who gets the
Cleave status from Xom wrath while worshipping Wu and using G&G will be
able to cleave their Wu attacks. Handling this edge case correctly would
be a huge pain.)

--------------------------------------------------------------------------------
33a98d2 | advil | 2018-07-30 12:15:47 -0400

Fix messaging with cloud of scarf and qazlal (11500)
This incorporates elements of both #799 and #804. Though apparently both
MarvinPA and amalloy were against it for reasons I don't fully
understand (see note in #804), I think it is preferable to show a
message when you wear this scarf when it is completely useless. It's not
exactly a lot of message spam, since this is an uncommon item, and this
kind of information is useful to new players.

Resolves #799, resolves #804

--------------------------------------------------------------------------------
6a91a31 | pubby | 2018-07-30 11:00:25 -0400

Remove hair/beard layer from Ba, Gn, VS, Gr
Displaying hair on these tiles was unintentional.

Ba for example is drawn to have 4 eyes, but the default hair covers up
the top two. That, and considering the fact that frogs aren't hairy IRL
makes it pretty clear that displaying hair was an accident, not a
deliberate artistic decision.

Resolves #813

--------------------------------------------------------------------------------
42de188 | dplusplus | 2018-07-30 10:19:26 -0400

Several fixes for hints mode
 * add newlines for hints_describe_item()
 * remove redundant periods / fix typos
 * fix hint_throw_stuff (when you don't have it)
 * add untag call to the healing reminder

Resolves #766

--------------------------------------------------------------------------------
fafb374 | Pekkekke | 2018-07-30 07:11:25 -0700

Remove reference to 'p'raying
Replace 'p'raying on altar with "praying with '>' "
--------------------------------------------------------------------------------
aa5e837 | Pekkekke | 2018-07-30 07:11:25 -0700

Remove references to 'p'raying at altars
Replace 'p'raying instances with "praying with >"
--------------------------------------------------------------------------------
0586415 | Nikolai Lavsky | 2018-07-30 07:10:39 -0700

Update descriptions of forms
This commit updates descriptions of all forms that can use wands since
7d43e34acb. It also fixes Fungus form's description: players in that
form can't wear hats or helmets (commit 7346924bb0).

--------------------------------------------------------------------------------
b7b0c8b | advil | 2018-07-29 22:50:09 -0400

Update ?? screen and hints mode for spell library (11561)
This is just a quick pass, and probably needs some more work; in
particular the hints mode text for spellcasting is now kind of buried in
the spell library help screen and needs to be brought out a bit more.

It doesn't seem like ?? really got updated for floor actions either, so
I took that into account on my rearrangement.

--------------------------------------------------------------------------------
615c57a | Aidan Holm | 2018-07-29 23:44:02 +0800

Fix weapon/map choice menus becoming unresponsive
Failing to clear the menus' selected items after retrieving them caused
the help menu item to still be selected after the help popup was
dismissed; this prevented further menu item activations, since the code
explicitly does nothing in such a situation. startup.cc was not buggy,
but the change makes this code more consistent.

--------------------------------------------------------------------------------
80e71c4 | Aidan Holm | 2018-07-29 13:44:05 +0800

Fix ui:scroller mousewheel direction (advil)

--------------------------------------------------------------------------------
5c4e1af | Aidan Holm | 2018-07-28 23:19:57 +0800

Disable PgUp/PgDn on startup menu

--------------------------------------------------------------------------------
997158a | Aidan Holm | 2018-07-28 20:44:06 +0800

Indent nested popups on local tiles

--------------------------------------------------------------------------------
ebc8d61 | Aidan Holm | 2018-07-28 20:26:38 +0800

Remove colours from webtiles monster spell lists
In future it'd be nice to colour code these, but the current colour
coding for monster descriptions is just wrong. The main bug this fixes
is showing monster spells in red if you worship Trog.

--------------------------------------------------------------------------------
9cf2c4c | Aidan Holm | 2018-07-28 17:46:06 +0800

Update webtiles UI scrollbar skin and positioning
Moves the scrollbar outside the scrolled content and against the right
popup margin, similar to the local tiles positioning. This is done by
adding a -20px margin on the outer scroller container, which matches the
20px padding of the popup boxes. This negative margin is offset by a
padding set in scroller.js; necessary, because simplebar.js changes the
padding set based on the current browser.

In addition to the positioning changes, we also style the scrollbar
handle with the new skin. We also give it wide-but-invisible borders, so
that it's easier to click on and drag, and a nice cursor icon.

This is unfortunately fairly brittle, and there's some browser
differences which make this code more complicated than it should be.
Webkit-based browsers do not seem to force inline-grid children to
shrink to fit a smaller container. To hack around this, we set the
height of all paneset children with every browser resize event. This is
mostly an issue only on the ^ UI.

There are a few minor bugs. The first is that vertical scrollbars do not
appear immediately when a scrollable popup opens, even when content can
be scrolled. This seems to be due to building the scroller UI with
simplebar.js before the popup is added to the main DOM hierarchy.
There are also some minor glitches when changing the zoom level while the
^ UI is opened.

--------------------------------------------------------------------------------
5fbd671 | Aidan Holm | 2018-07-28 14:39:03 +0800

Update popup UI skin
This commit removes the image-based background for UI popups, and
replaces it with a border using solid colours. This simplifies the
implementation on webtiles significantly. The border colour is changed
to match the scrollbar colour.

This commit also unifies how popups are aligned within the screen for
webtiles and local tiles, with some changes for both. When a game
has started, popups on local tiles are now aligned top-centre and
offset vertically according to their nesting depth, matching the popup
alignment on webtiles. When a game is not in progress, however, popups
on both platforms are aligned to the centre, and there is no vertical
offset to indicate nesting level.

In future, it'd be nice to a) deduplicate all the different places where
the centredness of the popup is sent to webtiles, and b) query whether
the popup is centred from the popup widget itself, allowing for finer
control.

--------------------------------------------------------------------------------
6a232dd | Aidan Holm | 2018-07-28 14:32:34 +0800

Fix help UI's custom home-key on webtiles

--------------------------------------------------------------------------------
51b3339 | Aidan Holm | 2018-07-28 14:17:18 +0800

Fix webtiles input dialog expanding on chrome

--------------------------------------------------------------------------------
d4c7e9b | Aidan Holm | 2018-07-28 13:59:48 +0800

Fix FS_EASY_EXIT preventing scrolling (ebering)

--------------------------------------------------------------------------------
4d0222c | Aidan Holm | 2018-07-28 13:58:36 +0800

Don't indent menu title if tile_display_mode != tiles

--------------------------------------------------------------------------------
6f80fdb | Aidan Holm | 2018-07-28 13:47:04 +0800

Set webtiles popup backgrounds to fg7 (Ge0ff)

--------------------------------------------------------------------------------
78736fa | Aidan Holm | 2018-07-28 13:29:07 +0800

Fix popup tiles not showing in tile_display_mode=tiles (Ge0ff)
Turns out jQuery's data() does not set the HTML data attribute.

--------------------------------------------------------------------------------
eee5034 | advil | 2018-07-27 17:27:24 -0400

Further memorization layout tweaks
692e0977ac3 left room for a sorting toggle that I haven't finished
implementing yet, but I don't think I'll finish it before feature
freeze, so this commit readjusts things to be a bit more even-spaced.

--------------------------------------------------------------------------------
16ba858 | advil | 2018-07-27 17:00:53 -0400

Ensure that clearing a menu triggers a layout
In local tiles, a pack_buffers call is necessary to relayout a menu, but
simply calling deleteAll(items) doesn't set m_needs_layout (which
triggers the sequence of events that leads to pack_buffers). Console
works differently for reasons I haven't examined closely (this bug
didn't affect it).  This commit calls _queue_allocation on clear() in
order to have a way of clearing the menu and triggering a layout. This
may pop up in other menus since the deleteAll paradigm is used in a
bunch of places.

This was manifesting for the memorize menu for the case where the menu
was cleared during update_entries but no items were added to it.

--------------------------------------------------------------------------------
692e097 | advil | 2018-07-27 14:11:03 -0400

Rework memorize menu layout
Slightly more organized, uses the same style of formatting as the skill
menu. And fix a few other details.

--------------------------------------------------------------------------------
005b4bd | advil | 2018-07-27 12:30:10 -0400

Make _sort_mem_spells arugments const
Also quiet a warning.

--------------------------------------------------------------------------------
98e63d6 | advil | 2018-07-27 12:17:40 -0400

Set expand_v on memorize menu
This is a quick change to keep the status lines in the same place when
searching, rather than dynamically resizing the menu. Possibly the max
sizes could use more tweaking (it might make sense to set the max size
based on the initial spell list, since it can never grow). Also, this
doesn't work on webtiles; resizing on search looked the worst on console
so that's probably ok.

--------------------------------------------------------------------------------
3db0934 | advil | 2018-07-27 11:46:18 -0400

Add MF_NOWRAP to spell menu
Wrapping behavior doesn't seem desireable here. N.b. the behavior
without this set was to wrap on pgdn but not on pgup, which actually
seems like it could have been a bug?

--------------------------------------------------------------------------------
a17920c | advil | 2018-07-27 11:46:18 -0400

Optimize memorize menu a bit
I was getting noticeable lag on opening the spell menu, and profiling
revealed that sorting was having a huge impact, because the sort
function collected all sorts of spell information each time it was
called. The main change of this commit is to precalculate spell
information for each spell in the menu, since they won't change while
memorizing.  This speeds things up quite a bit for me (bringing things
down from ~200ms to ~50ms for a big memorize list). The biggest offender
was repeated calls of failure_rate_to_int(raw_spell_fell(...)). This may
be exaggerated in debug mode since part of the hit was that each call of
that does a dprf, but that wasn't the whole story in the profiling data,
so I expect this will help in non-debug builds as well.

I also hit a few minor slower points including the status line
construction from 985ef60fe1445, and did a bunch of minor modernization
of the c++ style in the memorize menu code in general.

--------------------------------------------------------------------------------
47ae1cb | gammafunk | 2018-07-27 08:54:32 -0500

Prevent ordering allies while confused (RoGGa, ebering, 11505)
While confused, don't allow issuing any 't' commands other than shout.
Also use a more appropriate cancellation message instead of one about
being too berserked/confused. The prompt indicates that any key other
than the one for shout will cancel the menu. Closes #826.

--------------------------------------------------------------------------------
985ef60 | advil | 2018-07-26 22:14:46 -0400

Add a second status line + more information to spell menu
Now this shows the current search text, if any. I also added explicit
mention of ctrl-f to the status lines. (Multiple "more" lines is really
easy to do now!)

--------------------------------------------------------------------------------
92302f4 | advil | 2018-07-26 18:50:11 -0400

Have hidden count in memorize menu respect search

--------------------------------------------------------------------------------
0a7940b | advil | 2018-07-26 18:28:24 -0400

Have esc with spell search clear search
Not sure if I'll get pushback on this, since I haven't seen any explicit
complaints aside from my own, but my expectation from search boxes in
other programs is that esc will clear the search, not immediately exit
the menu.

--------------------------------------------------------------------------------
415d086 | advil | 2018-07-26 14:04:23 -0400

Notify user if there were errors during initialization
This will help with things like the white tile issue: now there should
be opengl errors on startup and this will tell the user about them, so
that they user will have some better idea of who or what to blame.

Possibly it would be better to force a popup with the errors, but this
is a bit more work and the replay_messages ui would need some tweaking
for that use case (I first implemented it this way, but it was too
cryptic), so I'm saving that for a later version.

--------------------------------------------------------------------------------
f11f912 | advil | 2018-07-26 12:27:18 -0400

Error message for bad tile_display_mode
I get this wrong 90% of the time.

--------------------------------------------------------------------------------
cc99ad9 | advil | 2018-07-26 12:27:18 -0400

Log OpenGL errors during texture load/initialization
Now that there's a way of viewing these errors, this can be used to help
troubleshoot graphics problems.

--------------------------------------------------------------------------------
4bbc76f | Aidan Holm | 2018-07-26 21:32:36 +0800

Fix incorrect item description HTML (rigrig)

--------------------------------------------------------------------------------
1aa6ef2 | Aidan Holm | 2018-07-26 21:32:36 +0800

Move num_children() to ui::Container

--------------------------------------------------------------------------------
aabaeae | Aidan Holm | 2018-07-26 21:32:36 +0800

Fix tiles in popups with tile_display_mode=glyph (rigrig, #11564)

--------------------------------------------------------------------------------
b5684aa | gammafunk | 2018-07-26 04:57:44 -0500

Swap Fedhas' 1* and 2* abilities (hellmonk)
Fedhas current 1* ability, Evolution, is one of the strongest god
abilities in the game. While Fedhas isn't the only god that provides
very strong abilities early on, it's one of the gods most in need of a
rework. The most dominant Fedhas abilities create permanent allies that
require a great deal of luring to use most effectively. Until we can
rework the god, it's nice to make some balance tweaks so that players
don't feel so strongly compelled to worship Fedhas in order to win.

This commit makes Sunlight the 1* ability and Evolution the 2* ability.
Sunlight is a useful early accuracy boost that doesn't cost piety, hence
is reasonable for that piety slot. Evolution remains just as good as it
was before and will be an outstanding 2* ability.

--------------------------------------------------------------------------------
e9e22a0 | advil | 2018-07-25 21:08:58 -0400

Revert "Pad textures to powers of two (aidanh)"
This reverts commit 996691b0ab01f384f410aae753aa415f2e413e66.

Textures are padded on load in SDLWrapper::load_texture.

--------------------------------------------------------------------------------
f979ea2 | advil | 2018-07-25 20:21:52 -0400

Add some error messages if the device texture size is too small
This will at least be a placeholder for a better solution. It's probably
extremely rare for this to come up, and virtualbox might be the only
case we'll see any time soon.

--------------------------------------------------------------------------------
1d8e3a0 | advil | 2018-07-25 19:39:41 -0400

Allow _mpr to work much earlier during initialization
There was no real technical reason that logging needed to wait to at
least be recorded to the buffer; it still can't be displayed until
io_inited is true.  These calls should work anywhere, now, since the
buffer is static.

--------------------------------------------------------------------------------
8bfc27d | advil | 2018-07-25 16:48:28 -0400

Fix some autoexplore logic (RoGGa / elliptic)

--------------------------------------------------------------------------------
76c094e | advil | 2018-07-25 16:29:57 -0400

More more suppression
Possibly, more prompts should just be entirely suppressed except when
in a game?

--------------------------------------------------------------------------------
5c56a3f | advil | 2018-07-25 16:09:47 -0400

Make that "Last save" dprf at the main menu more useful
Not even sure this was intended to happen at the main menu, but it's
kind of useless if you have a lot of saves without the names.

--------------------------------------------------------------------------------
7d4b68b | advil | 2018-07-25 15:58:54 -0400

Allow replay_messages from main menu with ctrl-p
This addresses a long-standing complaint of mine: it's a pain to see
debug messages that happen before game start. With the new UI system,
this is the kind of thing that's trivial to add. For regular players,
this will mainly be in case some error messages show up, so it's not
documented in the menu interface.

This commit also tries to more aggressively avoid more prompts during
game startup; for those of us with 50 save games running debug builds,
this makes startup a bit smoother -- what information you could get out
of this can now be seen in ctrl-p.

--------------------------------------------------------------------------------
2bb02df | advil | 2018-07-25 15:41:43 -0400

Remove debug code

--------------------------------------------------------------------------------
c7f5460 | advil | 2018-07-25 15:31:13 -0400

Don't drop the last 1-2 lines in replay_messages
This fixes two bugs in replay_messages:
* introduced in a02aae867cf82, the last line of the message log wasn't
  terminated with a `\n`, and so didn't show. (Should this also be fixed
  in formatted_scroller?)
* a more long-standing issue was that replay_messages didn't guarantee
  that the last message was flushed, so short recent messages wouldn't
  get shown.

I'm not sure how long this second bug was around, but between the two of
them up to 2 lines could be dropped, which made the issue more
noticeable.

--------------------------------------------------------------------------------
996691b | advil | 2018-07-25 11:16:41 -0400

Pad textures to powers of two (aidanh)
This ensures that the texture height is always a power of two, leaving
the width still fixed at 1024. This may address issues on some older
hardware/drivers (and potentially VMs) where textures don't load
properly.

If *square* power-of-two textures are needed that will be a bit more
effort, since the 1024 width seems to be a bit hard-coded into things.

--------------------------------------------------------------------------------
a3c446c | gammafunk | 2018-07-25 09:54:13 -0500

Merge pull request #822 from nlavsky/diths-fiery-randarts
Allow naming randart fiery weapons after Dithmenos
--------------------------------------------------------------------------------
ec0ffd4 | Kyle Rawlins | 2018-07-25 10:27:42 -0400

clarify what is recommended for windows builds (gammafunk)
[skip ci]
--------------------------------------------------------------------------------
8a29c8c | Kyle Rawlins | 2018-07-25 09:33:37 -0400

Further tweaks to MSYS2 instructions in INSTALL.txt
[skip ci]
--------------------------------------------------------------------------------
05cf915 | gammafunk | 2018-07-24 23:07:45 -0500

checkwhite INSTALL.txt

--------------------------------------------------------------------------------
8522bf8 | advil | 2018-07-24 15:30:05 -0400

Update submodules to improve windows compilation
This has another stab at the xinput issue, to deal with further changes
(apparently) in MSYS2.

--------------------------------------------------------------------------------
4a1e013 | Kyle Rawlins | 2018-07-24 13:00:03 -0400

Improve MSYS2 installation instructions
Previously, this made the reader skip around to various other parts of
this document and other web pages; this commit tries to lay everything
out in steps.

[skip ci]
--------------------------------------------------------------------------------
6c6de77 | gammafunk | 2018-07-24 03:05:54 -0500

Remove rC- and rF- from Maxwell's Thermic Engine
This weapon has damage roughly similar to a +9 Freezing or Flaming
double sword, considering how much its enchantment fluctuates during a
fight. Assuming you can sustain its highest enchantment and the target
has neither rC nor rF, it's the same damage as +14 speed double sword.
This is outstanding, but not to the point where the item needs something
like negative resistances or other drawbacks to balance it. The negative
resistances also aren't an interesting trade-off on a swappable weapon.

--------------------------------------------------------------------------------
f552829 | gammafunk | 2018-07-24 01:29:45 -0500

Fix quick blade weapon definitions in ghost vault lua

--------------------------------------------------------------------------------
1e17ac6 | gammafunk | 2018-07-24 01:15:17 -0500

Remove an unused method

--------------------------------------------------------------------------------
dfd0697 | gammafunk | 2018-07-24 01:15:17 -0500

Update the Vampire's Tooth description
Closes #825.

--------------------------------------------------------------------------------
b41cb9a | Edgar A. Bering IV | 2018-07-24 00:43:22 -0500

Buff Vampire's tooth (gammafunk)
The gimmick (100% of damage comes as vampiric heal) only works on a
weapon that's able to do some damage. This patch changes it from a +4
dagger to a +12 quickblade. The quick attack and slaying give it an
average damage less than a +4 electric brand quick blade, but enough
healing to be similar to a spellpower 100 vampiric draining cast against
targets that aren't too heavily armoured.

--------------------------------------------------------------------------------
9b9925d | Edgar A. Bering IV | 2018-07-24 00:43:22 -0500

Constify attack::using_weapon()
Guarantee that using_weapon() is a const boolean check for a given
attack.

--------------------------------------------------------------------------------
a28c36f | Aidan Holm | 2018-07-24 09:14:22 +0800

Fix keyhelp menus not responding to listed bindings (#11559)

--------------------------------------------------------------------------------
1ca9aab | Alan Malloy | 2018-07-23 12:48:40 -0700

Clarify linespint doesn't require 15 runes (advil)

--------------------------------------------------------------------------------
569b9d7 | Alan Malloy | 2018-07-23 11:19:22 -0700

Improve manual's description of sprint modes
Mostly just some copy-editing, and a couple points of added flavour since we're 
making up lore here anyway.
--------------------------------------------------------------------------------
6252f73 | advil | 2018-07-23 13:43:19 -0400

Draft of a manual appendix describing sprint modes
Some of these are pretty under-documented / under-described, so
this may be missing some details.

--------------------------------------------------------------------------------
ebb9c88 | Aidan Holm | 2018-07-23 23:46:21 +0800

Fix hints mode UI printing formatting tags (RoGGa, #11539)

--------------------------------------------------------------------------------
ee55829 | Aidan Holm | 2018-07-23 23:35:00 +0800

Remove useless get_number_of_cols()
The stealth bar is in the first column, which is 20 characters wide.

--------------------------------------------------------------------------------
978c4e9 | Aidan Holm | 2018-07-23 23:34:12 +0800

Fix long artefact text wrapping on %-screen (kitchen_ace, #11533)

--------------------------------------------------------------------------------
731016a | Aidan Holm | 2018-07-23 22:05:42 +0800

Fix truncated spell descriptions (Pekkekke, #11556)

--------------------------------------------------------------------------------
6c6d8f1 | advil | 2018-07-23 09:45:35 -0400

Actually check for ghosts taking stairs when updating annotations
Addendum to b939540, fixes 11558. This still leads to a case where the
annotations get collapsed if one ghost follows you to a level where
another ghost of the same name already exists, but I'm not sure that is
fixable without giving ghosts unique names.

--------------------------------------------------------------------------------
4ee7205 | Aidan Holm | 2018-07-23 21:40:08 +0800

Fix webtiles popup background glitch with non-100% zoom
Turns out modern browsers suffer from rounding errors when using CSS
sprites. Data URIs help, but aren't a complete fix.

The complete fix: popup.png is 69x69px, but instead of directly
slicing it into 23x23px parts, each part is 25px by 25px, and the
side and centre pieces overlap the corners, due to their HTML order.
This overlap neatly covers a slew of nasty rendering glitches on Chrome.

--------------------------------------------------------------------------------
b582571 | Edgar A. Bering IV | 2018-07-23 10:06:16 +0800

Don't re-check forgotten map squares (10461)
Prevents annotations for runed doors and transporters from stacking up.

--------------------------------------------------------------------------------
8125a50 | Aidan Holm | 2018-07-23 09:25:46 +0800

Fix segfault after viewing help from menu (josh, #11553)
These extra lines were holdovers from the previous menu implementations,
which needed to explicitly re-render after showing the help screen and
used reentrancy to do so. This caused an additional UI layer to be
pushed for every time the help was opened; these were not popped when
end() was called, because the UI framework does not handle exceptions
(yet?).

--------------------------------------------------------------------------------
f2cf4e3 | Aidan Holm | 2018-07-23 09:15:55 +0800

Fix use of uninitialized memory in help (josh)

--------------------------------------------------------------------------------
4c1e2d5 | advil | 2018-07-22 12:31:00 -0400

Fix further issues with extra init/exits in SkillMenu (Gorice)
Bugs 11527, 11549. This class really needs to be rewritten with a proper
constructor etc. Thanks to Gorice for the diagnosis of the bug in
https://crawl.develz.org/mantis/view.php?id=11527&nbn=1#bugnotes.

--------------------------------------------------------------------------------
bf23809 | gammafunk | 2018-07-22 04:58:07 -0500

Adjust Harold's attack, armour, spells, and depth (mikee)
Harold doesn't post much of a threat in his current incarnation. In
later dungeon and lair levels he has a difficult time doing appreciable
damage. Additionally his spell set of bolt of fire and emergency blink
don't particularly match well with this bounty hunter theme.

This commit increases Harold's base attack damage by 75%, and gives him
better armour on-average. Additionally he loses Bolt of Fire and
Emergency Blink, gaining Harpoon Shot (currently only seen on swamp
worms and iron giants) and Sentinel's Mark. Sentinel's Mark should make
Harold more of a complicating factor where he appears. Harpoon Shot
prevents player escape, allowing him to put that improved melee to more
use, and restores a bit of ranged damage from losing Bolt of Fire.
Harpoon loses Emergency Blink since it plays poorly with Harpoon Shot,
and since Blink isn't an especially effective spell now that Harold
mostly does melee damage.

Finally, Harold's placement has been moved up so that he places on
D:7-11, Lair:1-2, and Orc:1 (formerly on D:10-12, Orc:1-2, Lair:1-4). He
should be more effective in those earlier Dungeon levels, and D:7-9
happen to have some of the lowest unique placement already.

--------------------------------------------------------------------------------
93d1441 | gammafunk | 2018-07-22 04:39:37 -0500

Hopefully fix menu scrolling in WebTiles (aidanh, robotcentaur, 11551)
If I were to guess why this change fixes things, I'd say the event
callback for scrolling synchronization needs to not try to handle events
for UI objects like menus that send their own sychronization messages.
I could be totally wrong...I'm trying to stay ignorant of most of
Javascript for as long as I can...

--------------------------------------------------------------------------------
cdea453 | Aidan Holm | 2018-07-22 14:07:01 +0800

Revert "Remove most remaining CRT control code"
This commit caused the main game UI to be displayed on webtiles before
starting a game, and also caused the end-game hiscores list to be
invisible. Don't have time to debug properly, so a quick revert is in
order.

This reverts commit 91fb4304bbf47b9154f8e27076c55e3f2d47abdd.

--------------------------------------------------------------------------------
7fc7157 | Aidan Holm | 2018-07-22 13:04:19 +0800

Add webtiles client-side scrolling
This commit adds client-side scrolling to all HTML UI layouts, including
formatted scrollers.

--------------------------------------------------------------------------------
6ffe099 | Aidan Holm | 2018-07-22 13:04:19 +0800

Add server -> client scroller synchronization
This commit sends all client-side scrollers' scroll events to webtiles
clients. The webtiles client responds by scrolling the scroller found
within the top popup, if there is only one such scroller.

With this change, formatted scrollers now send two scroll update
messages: the pre-existing scroll update from UIHookedScroller, and this
newly-added update. The former currently provides client -> server
synchronization (currently lacking for other scrollers), and so webtiles
clients will ignore new scroll messages if the top popup is a formatted
scroller.

There are race conditions here, since scroll update messages do not
identify their target widget.

--------------------------------------------------------------------------------
fba9ade | Aidan Holm | 2018-07-22 13:04:19 +0800

Improve webtiles scroller line-height detection
The previous method of prepending a hidden span had a number of issues,
chief of which was that it recreated all scroller contents by converting
them to HTML and reparsing. This erased all canvas element contents.

--------------------------------------------------------------------------------
a2e7eb6 | Aidan Holm | 2018-07-22 13:04:19 +0800

Fix incorrect JS event propagation handling

--------------------------------------------------------------------------------
e82d12a | Aidan Holm | 2018-07-22 13:04:19 +0800

Fix webtiles menu always handling scroll keys

--------------------------------------------------------------------------------
d6d8abe | advil | 2018-07-21 17:49:56 -0400

Also don't let species welcome text be selected (11547)

--------------------------------------------------------------------------------
a814211 | advil | 2018-07-21 17:34:21 -0400

Don't let gamemode menu welcome text be selectable (11547)

--------------------------------------------------------------------------------
01cda4c | advil | 2018-07-21 17:34:21 -0400

Remove accidental extra line, formatting, unbrace

--------------------------------------------------------------------------------
058c00f | Aidan Holm | 2018-07-21 13:01:37 +0800

Don't render UI layers under direction chooser (stoneychips, #11525)
This fixes a webtiles bug where evoking items from their inventory item
description would lead to the inventory menu obscuring the direction
chooser. This also fixes a secondary bug on local tiles where evoking
items from their inventory item description and then pressing v to
describe a cell would cause the inventory menu to appear under the
description popup.

Briefly, there are two main render loops for local tiles: the directn
loop (which does not render UI popups), and the new UI loop (which does
render the background direction chooser view). Effectively, either all
popups or no popups are rendered, depending on which render loop is
running on the top of the stack (they can be nested). For xv, that's the
UI loop on top of the directn loop; for inv -> item -> evoke, that's the
directn loop on top of the UI loop.

This approach doesn't work on webtiles because it uses HTML to render
the UI, and so the render loops are effectively "running in parallel".
It was buggy on local tiles when describing cells after evoking an item
from the inventory. The fix is to add "cutoff points" which prevent the
rendering of any UI layers already pushed. Local UI and tileweb have
separate UI stacks, and so have their own cutoff point API, in case
non-UI code modifies the tileweb UI stack in the future.

The addition of the cutoff point to show_map() is currently unnecessary,
since there is currently no way to show the map from a popup view, but
this might change in the future.

--------------------------------------------------------------------------------
88f5e90 | advil | 2018-07-20 17:59:43 -0400

Add net size check to Bai Suzhen (Rast)

--------------------------------------------------------------------------------
a501810 | Aidan Holm | 2018-07-21 02:26:42 +0800

Revert "Fix webtiles popups obscuring direction chooser (stoneychips, #11525)"
This broke xv.

This reverts commit f1e831c450af8d9018c9b25eaee77c473c3c0471.

--------------------------------------------------------------------------------
b0d9f32 | Aidan Holm | 2018-07-20 23:13:11 +0800

Improve scroll shade appearance (pedant, #11520)
The items obscured by scroll shade gradients were too easily
misinterpreted as being greyed-out. This commit fixes that by using a
much narrower gradient band. This effect was compounded on webtiles
where the gradient was darker: the webtiles CSS has been changed to
match the local tiles colours.

The gradient band was originally taller to indicate the presence of
additional content beyond the edge of the scroller viewport, but with
the addition of scrollbars to (web)tiles, this is less important.

--------------------------------------------------------------------------------
3b2440b | Aidan Holm | 2018-07-20 23:13:08 +0800

Fix 'hostile' text truncated on ability screen (pedant, #11520)
Unfortunately this introduces a separate minor bug where ability menu
items can wrap (incorrectly), due to their length.

--------------------------------------------------------------------------------
2f468e5 | Aidan Holm | 2018-07-20 22:33:00 +0800

Work around direction-chooser console rendering bug
This rendering bug occurs when viewing an item's description via the
inventory, and then evoking it: the stats sidebar of the main dungeon
view UI is not re-rendered, and instead shows a portion of the item
description text.

I don't feel comfortable calling this a fix, because it's rather
ham-fisted. It's positioned after the clear_messages() call to avoid
causing flicker in the messages panel.

--------------------------------------------------------------------------------
5521402 | advil | 2018-07-20 10:22:10 -0400

Rename ring of loudness to ring of attention
This resolves a long-standing flavor vs. gameplay mismatch, since the
ring of loudness doesn't actually make any noise.

--------------------------------------------------------------------------------
04153b2 | Aidan Holm | 2018-07-20 22:08:28 +0800

Fix webtiles compilation
See commit 91fb4304bb.

--------------------------------------------------------------------------------
6a45e17 | Aidan Holm | 2018-07-20 21:40:27 +0800

Revert "Hack out small-screen-size panic"
A panic is preferable to crashes caused by writing outside of the
terminal viewport, at least until existing code is fully converted to
use the new UI framework (which clips all output and so doesn't have
this problem).

This reverts commit 67b9c875503ac7559665f8a7605d06c5d3259c1d.

--------------------------------------------------------------------------------
54f2113 | Aidan Holm | 2018-07-20 21:34:36 +0800

Fix tutorial finish UI printing formatting tags (RoGGa, #11539)

--------------------------------------------------------------------------------
6887535 | Aidan Holm | 2018-07-20 21:34:36 +0800

Fix local tiles crash when ` opens menus (kitchen_ace, #11534)
update_items() being short-circuited lead to command repetition crashing
on local tiles. I believe these early exits were holdovers from the
previous (wildly different) implementation of menus.

--------------------------------------------------------------------------------
f1e831c | Aidan Holm | 2018-07-20 21:34:36 +0800

Fix webtiles popups obscuring direction chooser (stoneychips, #11525)
This issue was visible when evoking items from their item description,
opened via the inventory. It wasn't a problem on console or local tiles
because the direction chooser code runs its own render loop. The fix
here is analagous to the UI_VIEW_MAP UI state used for viewing the map.

--------------------------------------------------------------------------------
91fb430 | Aidan Holm | 2018-07-20 21:34:36 +0800

Remove most remaining CRT control code
This commit removes most of the CRT layer control code, since it is no
longer used. The few remaining user interfaces which use an emulated CRT
on webtiles now use the single function tiles_crt_popup RAII class,
which renders CRT output to a webtiles popup.

--------------------------------------------------------------------------------
63a12d5 | Aidan Holm | 2018-07-20 21:32:10 +0800

Fix webtiles font settings being ignored (Leszczynek, #11538)
We continue to use the CRT font, even though webtiles barely uses the
CRT emulation layer any more.

--------------------------------------------------------------------------------
5e6ed2a | advil | 2018-07-20 09:04:01 -0400

Have vaults flavor text imply quieter noise (11541)
There's no gameplay reason for actual noise here.

--------------------------------------------------------------------------------
6253c82 | advil | 2018-07-19 14:31:10 -0400

Clean up elven twins + slimify interaction (Alaric_Silvertongue)
Try to make it more consistent. Behavior after this commit:
 * slimifying one will not berserk (or slimify) the other. This is
   different from ely pacification, where pacifying one pacifies the
   other.
 * attacking one will anger the other even if slimified. This is the
   same as ely pacification, and the behavior is unchanged.
    - I added messaging so it's slightly more obvious this is happening.
      Message also covers the pacified case.
    - jiyva abilities can repacify, sometimes even on the same turn.
 * a slimified neutral twin dying will now berserk the other.
   Previously, it accidentally pacified the other (bug related to ely
   pacification). This brings it in line with ely pacification.
 * a regular twin dying will no longer try to berserk a slimified
   neutral twin. Previously, it tried and didn't work. Possibly it
   should make hostile and berserk the the slimified twin instead, but
   I chose this behavior so that it is the same as ely pacification, so
   if one changes, the other should be changed.
 * If both twins are slimified and hostile, killing one gives a berserk
   message (but I don't think there's any effect). This is dubious but
   more annoying to fix.

Pacification behavior should be unchanged.

--------------------------------------------------------------------------------
679915a | advil | 2018-07-19 10:01:53 -0400

Handle an obscure webtiles exit case better
Prevents webtiles from showing an error dialog when exiting from the
main menu via ESC.

--------------------------------------------------------------------------------
4eb3915 | advil | 2018-07-19 09:26:56 -0400

Let sprint, tutorial, main menu work in webtiles
Main menu only works under certain circumstances of course (e.g. non-dgl
build, name_bypasses_menu = true).  Also arena, but it still crashes for
other reasons.

--------------------------------------------------------------------------------
038298e | gammafunk | 2018-07-18 22:09:21 -0500

A kobold themed ghost vault for Dungeon
In gammafunk_ghost_nasty_kobolds, the kobolds pull out all the nasty
tricks: blowguns, wands, daggers with distortion or other nasty brands,
and demon summoning. Places a fancy kobold with a kobold-appropriate 1h
weapon that's branded and good_item or randart. You'll also find at
least one of the aforementioned distortion weapon kobolds. Additionally
there's at least one kobold with either a blowgun with poison or curare
needles or one with a monster-usable wand. Numbers of these increase
with depth, with big kobolds replacing ordinary kobolds and with kobold
demonologists gradually being introduced. Who knows, maybe the lone
ghost you'll find inside is the result of someone failing to appreciate
just how tricky and nasty dungeon kobolds can be.

--------------------------------------------------------------------------------
7ef8c7b | gammafunk | 2018-07-18 21:48:09 -0500

Resize a ghost vault
Currently, any monsters and loot at the back of the vault
gammafunk_ghost_cemetery are one tile out of LOS even when viewed from
outside. This commit decreases the size of the vault so that all floor
tiles can be seen.

--------------------------------------------------------------------------------
52fbc5f | gammafunk | 2018-07-18 21:26:19 -0500

Rename a ghost vault
Rename ploomutoo_gammafunk_potion_laboratory to
ploomutoo_gammafunk_ghost_potion_laboratory so that it has 'ghost' in
the name of the vault like the other ghost vaults do.

--------------------------------------------------------------------------------
6f83d72 | advil | 2018-07-18 12:18:20 -0400

Avoid "mid cache bogosity" for unhandled divine clone bugs
Companion clone bugs lead to "mid cache bogosity" under the following
circumstances:

1. there is a level saved with a copy of the companion that gets false
for is_divine_companion() (e.g. it lost its god, as in e6d7efa92cb0).
2. that level also has a properly saved copy of the companion; they
both share the same mid.
3. the mindex of the corrupted copy is lower than the correct copy.

If all three conditions are met, the elsewhere companion code would
clear the mid cache for the corrupted copy, but the corrupted copy would
still be alive and kicking in the monster list. This would lead to a
crash when entering the level, resulting in an unplayable save.

This commit avoids this situation by fixing up the mid cache after
deleting the elsewhere companion. This fix will still result in errors
under various circumstances, but hopefully not unplayable saves. An
alternative might be to always delete both copies, but doing so will
hide whatever the underlying bug is that is leading to a clone so IMO
it's better to print lots of errors when these things happen, and delete
only corrupted copies where we know what the bug was.

As a side note, if there are multiple copies but they satisfy
is_divine_companion, they'll still be silently deleted -- this is the
status quo from before this commit. If condition 3 above isn't met,
there will also be no error, on load at least.

--------------------------------------------------------------------------------
eb4a410 | advil | 2018-07-18 12:07:20 -0400

Save compat for the Beogh/priest polymorph bug
See e6d7efa92cb0cd for the bug itself.

This cleans up duplicate mid monsters for various cases that match the
conditions of this bug. Possibly this should have a minor version tag
bump, but as of right now that will mess up the ghost permastores and I
don't want to do that this close to a release.

--------------------------------------------------------------------------------
337e1da | advil | 2018-07-18 09:28:01 -0400

Preserve insanity on polymorph (11504)
Because insanity involves an attitude change, polymorph was removing the
enchantment and not returning the attitude to normal. This changes
leaves the monster insane after a polymorph, and the enchantment goes
away as normal, returning the attitude to its correct state at that
point.

--------------------------------------------------------------------------------
b6d156f | Nikolai Lavsky | 2018-07-18 15:35:42 +0300

Allow naming randart fiery weapons after Dithmenos
Because Dithmenos doesn't have an anti-fire conduct any more, it is
no longer necessary to veto names like "...of Dithmenos's Generosity"
for randart flaming weapons.

--------------------------------------------------------------------------------
e6d7efa | advil | 2018-07-17 22:14:49 -0400

Don't overwrite god with GOD_NAMELESS on poly to a priest (11536)
This was creating duplicate monsters under the same mid in the following
way for beogh worshippers: 1. an orc follower gets turned into a
shapeshifter via chaos effects (e.g. an apocalypse crab). 2. the monster
shapeshifts into a priest monster, such as a meliai, setting the
monster's god to GOD_NAMELESS. 3. The player exits the level, and
recalls allies on a new level. A copy of the follower is generated at
this point. 4. They reenter the level of step 2. Because the monster
copy on that level no longer worships Beogh, is_divine_companion returns
false, and the follower copy is not appropriately cleaned up when
re-entering that level (see `tag_read_level_monsters`). Now there are
two. (Probably other variants of this procedure could work.)

This state doesn't crash, but the situation can eventually lead to the
infamous "mid cache bogosity" message in various ways, such as if one of
the copies dies while both are on the level, removing it from the mid
cache.

The fix might give priest monsters some weird gods at times, but it
doesn't mess up orc followers.

--------------------------------------------------------------------------------
a7d8001 | Aidan Holm | 2018-07-18 00:46:40 +0800

Revert "Remove BlackWhiteHighlighter" (NormalPerson7)
Turns out it is different from BoxMenuHighlighter after all, on windows
console.

This reverts commit e1e3f6e481f064d311ea5d7cd77a46fd550104a3.

--------------------------------------------------------------------------------
12c0d5b | Aidan Holm | 2018-07-18 00:44:15 +0800

Fix crash when scrolling+switching in webtiles menus
A webtiles client may send a scroll event before it is informed of
updates to menu content. If the number of menu items is then changed,
such scroll events may reference an out-of-bounds item index by the time
they arrive at the server.

Note that any such scroll events are 'stale' in the sense that they
refer to scrolling to an item/offset that is no longer shown, so there
is no way for servers to handle these events. A more robust solution
would involve webtiles clients acknowledging all updates to menu
content, and the server side using the ordering of acknowledgement and
scroll update messages to detect stale scrolls.

--------------------------------------------------------------------------------
9746042 | Aidan Holm | 2018-07-17 22:22:47 +0800

Disable resize detection on windows console (NormalPerson7, #11532)
For reasons unknown, resize detection was causing an infinite resizing
glitch, which prevented all gameplay.

--------------------------------------------------------------------------------
ac08f70 | advil | 2018-07-16 23:53:26 -0400

Fix xp potions for real this time
Now correctly handling can_train state

--------------------------------------------------------------------------------
52540ca | advil | 2018-07-16 23:53:26 -0400

Don't crash if a manual would be used up by an xp potion
The manual was getting deleted from inventory during the simulations
that the skill menu does as you change your training settings, leading
to a crash when it attempted to restore the manual's charges.

--------------------------------------------------------------------------------
06a55de | advil | 2018-07-16 23:53:26 -0400

Fix behavior of multiple xp potions in the same session
In f02a5016e20a I foolishly did not consider the possibility that the
skill menu might be implemented as a single global value variable whose
state needs to be manually reset. Ideally this commit should be done
with constructors and the like, but my first implementation in a better
c++ style interacted in an awkward way with PrecisionMenu memory
management.

I also missed the fact that exit() being called multiple times leads
too similar problems as f02a5016e20a.

--------------------------------------------------------------------------------
178e555 | Alan Malloy | 2018-07-16 14:20:30 -0700

Make sure Jiyva opens Slime:$ for you if you reach ****** while there (Pekkekke)
It was never updated when we shortened Slime from 6 to 5.

Fixes #819.

--------------------------------------------------------------------------------
eab2209 | advil | 2018-07-16 14:33:08 -0400

Rename `hash_rand`
This function is completely deterministic, so give it a name that's not
so misleading.

--------------------------------------------------------------------------------
ac240df | advil | 2018-07-16 14:19:45 -0400

Fix pumpkin heads in a different way (11524 / Gorice)
As Gorice noticed, hash_rand is not actually random, and so the loop
introduced in 0f663418af6b didn't terminate. Instead, just replace
any pumpkins with boring helms.

--------------------------------------------------------------------------------
08e7145 | advil | 2018-07-16 14:01:09 -0400

Clean up some messy but harmless code (amalloy)
at least I think it's harmless?

--------------------------------------------------------------------------------
5224685 | Aidan Holm | 2018-07-17 00:11:37 +0800

Adjust webtiles mutations UI popup

--------------------------------------------------------------------------------
8b9a6d0 | Aidan Holm | 2018-07-17 00:11:37 +0800

Align webtiles UI popups to centre-top
Nested popups are vertically offset somewhat. Note that local tiles is
not yet changed; further changes are likely and it'd be good to get some
feedback on this design iteration before making wider modifications.

--------------------------------------------------------------------------------
783f74d | advil | 2018-07-16 10:00:53 -0400

Add back in .hidden to static style.css
Most immediately, this hides the text input div in the lobby.

--------------------------------------------------------------------------------
f02a501 | advil | 2018-07-16 09:46:23 -0400

Fix potions of experience
The problem was that SkillMenu::init couldn't handle being called
multiple times in SKMF_EXPERIENCE mode. The player's actual skill state
would be properly saved the first time, and replaced with a temporary
state representing the initial experience allocation (using currently
training skills), but then the second time it would overwrite the actual
skill state backup with this temporary state, effectively replacing the
actual skill state at that point (including the already allocated xp in
the temporary state).

--------------------------------------------------------------------------------
6240e6a | Aidan Holm | 2018-07-16 21:06:43 +0800

Make altar UI more user-friendly (TAS2012, #11530)
This commit makes space and enter always activate the join-religion
prompt (previously, they were swallowed silently by the scroller
widget). In addition, it adds some help text to indicate that the join
action is available (and what key one should press to join).

--------------------------------------------------------------------------------
7e4a324 | Aidan Holm | 2018-07-16 21:06:43 +0800

Fix version UI printing formatting tags (TAS2012, #11529)

--------------------------------------------------------------------------------
ca69a669 | Aidan Holm | 2018-07-16 21:06:42 +0800

Revert "Add item/spell/ability menu adjust mode"
These commits added the ability to adjust entry letters directly from
the inventory, spell, and ability menus, but unfortunately introduced a
regression where adjustments weren't printed, which lead to user
confusion.

This reverts commit f843350036b891c3f998be9d8a21cd141643f795.
This reverts commit bec60ccf0d73caf4a76c060404e86a1defd63097.

--------------------------------------------------------------------------------
2141c5b | Aidan Holm | 2018-07-16 21:06:42 +0800

Redraw screen when closing last popup
There's a slight possibility this change will cause rendering issues:
this functionality was previously in ui-overhaul at some point before it
was merged, but I can't recall if it was removed because it turned out
to have subtle edge-cases, or if it just got accidentally dropped during
a rebase.

--------------------------------------------------------------------------------
dba82d8 | gammafunk | 2018-07-15 17:45:42 -0500

Some flavor adjustments to gammafunk_ghost_fury_of_okawaru (hellmonk)
Add hunting sling to the list of possible bad items and have a small
chance for the bad item to be either robe of misfortune or a -8 artefact
robe if the former is unavailable.

--------------------------------------------------------------------------------
c33bbe7 | advil | 2018-07-15 13:27:46 -0400

Remove some tautological comparisons
...assuming size_t is unsigned.

--------------------------------------------------------------------------------
5fb6194 | Aidan Holm | 2018-07-16 00:04:12 +0800

Actually fix compilation

--------------------------------------------------------------------------------
498ab08 | Aidan Holm | 2018-07-15 23:39:50 +0800

Fix compilation when size_t != long_unsigned (NormalPerson7)

--------------------------------------------------------------------------------
c8d1eea | Aidan Holm | 2018-07-15 22:17:36 +0800

Fix end/hiscore UIs printing formatting tags

--------------------------------------------------------------------------------
205440e | Aidan Holm | 2018-07-15 22:06:55 +0800

Fix screen not redrawing after leaving %-screen (|amethyst)

--------------------------------------------------------------------------------
288e0bf | gammafunk | 2018-07-15 05:13:43 -0500

Updates to gammafunk_ghost_fury_of_okawaru
Place Okawaru gift inspired weapon and armour items for the first two
loot pieces in this vault instead of the usual superb or star items. The
weapon item uses the good weapon base types, with lower weight on the
rarer types, and is always good_item. The armour is more general armour
but can either be good_item or randart. The weapon item always places,
but the armour item only replaces a superb/star item 1/3 of the time
initially, with that chance increasing to 100% as depth increases.

Also place a bad weapon or armour item (negatively enchanted, non-ego,
cursed) under the ghost, since we all know this is what Oka gifts
usually look like.  This bad item is always pre-identified.

--------------------------------------------------------------------------------
a7dcef7 | Aidan Holm | 2018-07-15 11:29:28 +0800

Fix mutation UI printing formatting tags (kitchen_ace)

--------------------------------------------------------------------------------
ffb0f71 | Aidan Holm | 2018-07-15 11:17:22 +0800

Fix god, item UIs printing formatting tags (|amethyst)
This was caused by Text(string) no longer parsing its input by default;
there might be a few other unconverted uses.

This commit also adds a hacky formatted_string::trim() implementation.

--------------------------------------------------------------------------------
283c1ef | advil | 2018-07-14 17:08:57 -0400

Quiet another warning on DGAMELAUNCH builds

--------------------------------------------------------------------------------
ee04ee8 | advil | 2018-07-14 16:42:52 -0400

Quick fix for webtiles menu bug
The problem seems to be that this global variable was getting out of
date at some point, and so referenced a div that is no longer in the
DOM.  I haven't tracked down why but at least on old UI code this sort
of thing would happen when resizing, since the DOM would get completely
rebuilt. In any case, in my testing this fixes the bug.

--------------------------------------------------------------------------------
1dba295 | advil | 2018-07-14 16:24:49 -0400

Quiet a warning on some build configurations

--------------------------------------------------------------------------------
5410c3b | advil | 2018-07-14 16:06:00 -0400

tabs to spaces

--------------------------------------------------------------------------------
420b899 | advil | 2018-07-14 16:03:01 -0400

Fix os x compilation
The replaced `auto` was getting `long long`, which led to an error on
the min call. Hopefully this won't break other OSs.

--------------------------------------------------------------------------------
7732505 | Aidan Holm | 2018-07-15 01:48:22 +0800

Revert "Clip tall monster tiles in webtiles monster list"
This commit caused tall monsters to 'smear' as they moved across the
webtiles viewport, for reasons I don't entirely understand yet.

This reverts commit c0cf510be224db181515dde563bebf1eb9e22036.

--------------------------------------------------------------------------------
6546e2e | Aidan Holm | 2018-07-15 01:17:52 +0800

Fix FS_START_AT_END being ignored
Caused by UINT_MAX overflowing to -1 when converted to a signed int.

--------------------------------------------------------------------------------
e3c7468 | Aidan Holm | 2018-07-15 00:59:38 +0800

Fix some new UI CSS bugs
Scroller shades should be the same colour as the background
(currently #040204), and text rendered within UI popups should never have
a black background,

--------------------------------------------------------------------------------
eec28cc | Aidan Holm | 2018-07-14 17:00:26 +0800

Fix HTML formatted scroller line height detection

--------------------------------------------------------------------------------
a1f343f | Aidan Holm | 2018-07-14 15:42:46 +0800

Show ghost species tiles

--------------------------------------------------------------------------------
0f66341 | Aidan Holm | 2018-07-14 15:42:42 +0800

Only give ghosts pumpkin heads on Halloween

--------------------------------------------------------------------------------
3670636 | Aidan Holm | 2018-07-14 14:17:01 +0800

Fix compiler warnings

--------------------------------------------------------------------------------
c0cf510 | Aidan Holm | 2018-07-14 13:28:04 +0800

Clip tall monster tiles in webtiles monster list

--------------------------------------------------------------------------------
a083f4b | Aidan Holm | 2018-07-14 13:28:04 +0800

Fix cramped spell description text (NormalPerson7)

--------------------------------------------------------------------------------
0d75190 | Aidan Holm | 2018-07-14 13:28:04 +0800

Fix string formatting not being rendered

--------------------------------------------------------------------------------
8f10877 | Aidan Holm | 2018-07-14 13:28:03 +0800

Fix incorrect lookup-help menu flags
This resulted in ?/B0 (labyrinth) not working correctly, as its hotkey
was interpreted as the beginning of a selection count.

--------------------------------------------------------------------------------
6c7ed9e | Aidan Holm | 2018-07-14 13:28:03 +0800

Fix webtiles menu scrolling with non-100% zoom (NormalPerson7)
NormalPerson7 noticed that menus got stuck when scrolling while using
certain zoom levels. This was caused by update_visible_indices() not
correctly accounting for the page zoom level, and thus always reporting
the same (incorrect) supposedly-visible region.

Since this function had a lot of handling for the previous
implementation, which supported partially loaded menus, I've replaced it
with a simpler version that is a reasonably straight-forward conversion
of the code in menu.cc.

--------------------------------------------------------------------------------
b17f314 | Aidan Holm | 2018-07-14 13:28:03 +0800

Show ring swap menu when wearing from inventory
When putting on a ring from the inventory item description, the prompt
in the messages region was obscured by the UI shade. When putting on
rings in this way, just always show the menu; it's a simple fix and
more intuitive than hiding the popup menus.

It's still a little weird that (p)utting on the ring immediately
dismisses the description popup.

--------------------------------------------------------------------------------
52e19c0 | Aidan Holm | 2018-07-14 13:28:03 +0800

Always set mouse event .held and .mod

--------------------------------------------------------------------------------
36a25f2 | Aidan Holm | 2018-07-14 13:28:03 +0800

Use new hover style for BoxMenuHighlighter

--------------------------------------------------------------------------------
e1e3f6e | Aidan Holm | 2018-07-14 13:28:03 +0800

Remove BlackWhiteHighlighter
BoxMenuHighlighter seems to do exactly the same thing on console.

--------------------------------------------------------------------------------
129b045 | Aidan Holm | 2018-07-14 13:28:03 +0800

Show msgwin_get_line as a popup when necessary
i.e. when there is no game currently playing, or when one or more UI
layouts are already being shown (and the message region is obscured).

This includes a new HTML input UI, as the problem of the message region
being obscured also existed on webtiles. Currently, this is very
simplistic, and doesn't use a text box; instead, keystrokes are
forwarded to the server, which then updates the HTML API; so every
keypress requires a round trip to render.

There's quite a few call sites that use cancellable_get_line directly;
it's unclear whether there's any special reason for doing so, but
they'll need to be converted to use msgwin_get_line() (if possible) to
reap the benefits of this commit.

--------------------------------------------------------------------------------
6bfa959 | Aidan Holm | 2018-07-14 13:28:03 +0800

Show popup yesno when not in main UI

--------------------------------------------------------------------------------
cb9e76d | Aidan Holm | 2018-07-14 13:28:03 +0800

Fix stale input state on local tiles (Currency)

--------------------------------------------------------------------------------
78a66ff | Aidan Holm | 2018-07-14 13:28:03 +0800

Tweak spacing on ability, spell menus
Spell menu: stops the menu from changing width when toggling between
views with !
Ability menu: this makes them the same width as the heading, which
prevents the item text from wrapping when the menu width is reduced.

--------------------------------------------------------------------------------
954b274 | Aidan Holm | 2018-07-14 13:28:03 +0800

Refactor and improve Menu UI implementation
This commit breaks up the functionality previously implemented by the
UIMenu widget. Scrolling is now implemented with the UIScroller widget,
which provides a more consistent interface, and menu title and more
text are rendered with UIText widgets. In addition, the visual style of
menu items has been updated and improved, with some rendering fixes and
better margins; we now also have mouse cursor effects!

It's not all good news, though; unfortunately, the restart-allocation
issue is back with a vengeance. This is necessitated by the desire to
use one column when there's available space. While this was previously
manageable due to UIMenu rendering the entire menu (including title and
more), it's now complicated by rendering being split among multiple
widgets.

This complexity is partly caused by a mismatch between the constraints
of the widget layout system and by the desired behaviour of the menu UI.
A layout algorithm like Flutter's might be a better match, as it allows
widget children to decide their size, rather than the parent choosing
the size of its children. It's unclear whether there might be other
areas of crawl UI that are a poor fit for the Flutter model, however,
and at this point, with the complex bit written (and hopefully bug
free), I'd prefer to stick with what's already implemented and working.

--------------------------------------------------------------------------------
1d12019 | Aidan Holm | 2018-07-14 13:28:03 +0800

Add informational scrollbars to scroller widget
These cannot (yet) be dragged with the mouse; they only indicate the
current scroll position and, to a lesser degree, the amount of
scrollable content.

--------------------------------------------------------------------------------
ec331d1 | Aidan Holm | 2018-07-14 13:28:03 +0800

Add UI mouse enter/leave events

--------------------------------------------------------------------------------
4af17ab | Aidan Holm | 2018-07-14 13:28:02 +0800

Linebreak save-update prompt text
yesno() now uses a menu to show this text, which doesn't wordwrap its
prompt text automatically.

--------------------------------------------------------------------------------
82b979e | Aidan Holm | 2018-07-14 13:28:02 +0800

Replace prompt yes/no icons
I'm no artist, but these fit the current visual design a little better.

--------------------------------------------------------------------------------
13706d6 | Aidan Holm | 2018-07-14 13:28:02 +0800

Use menu for yesno prompt outside game (Currency)
This fixes an issue where the yesno prompt text was not being shown
because redraw_screen() was not being called to show updates to the
message buffer. Rather than work out what's actually going on there,
I've opted to use the TOUCH_UI popup code when outside of a game, as
showing the messages panel without a game loaded looks very buggy.

mprf() is still used when calling yesno() inside a game, unless TOUCH_UI
is defined.

--------------------------------------------------------------------------------
f062400 | Aidan Holm | 2018-07-14 13:28:02 +0800

Add more event handling to ui_pump_events (Currency)

--------------------------------------------------------------------------------
f843350 | Aidan Holm | 2018-07-14 13:28:02 +0800

Add MF_SWAP_MODE menu mode

--------------------------------------------------------------------------------
bec60cc | Aidan Holm | 2018-07-14 13:28:02 +0800

Add item/spell/ability menu adjust mode
Functionality is implemented in menu.cc, and is enabled whenever a menu
has an `on_entry_swap` callback, which does the actual swapping. An
additional `swap_mode_prompt_noun` member is used to generate the swap
prompt text. The on_entry_swap callback receives the first item to swap,
and either a pointer to the second or a key to swap it to.

Swap mode is entered by pressing = on a menu that supports it. An
already-existing item is then selected, followed by a letter that may or
may not refer to an existing item. Swapping an item to its own letter
cancels the swap, but stays in swap mode. At any time, = or ESC cancels
the swap and leaves swap mode.

--------------------------------------------------------------------------------
bdb2496 | Aidan Holm | 2018-07-14 13:28:02 +0800

Add menu title indentation automatically

--------------------------------------------------------------------------------
cdcb5b2 | Aidan Holm | 2018-07-14 13:28:02 +0800

Remove easy_exit_menu option

--------------------------------------------------------------------------------
e6dabca | Aidan Holm | 2018-07-14 13:28:02 +0800

Fix SDL tiles arena UI bugs
Fixes the arena crashing and otherwise failing to handle window resizing
correctly.

A mostly straight-forward conversion. ui_delay() is a replacement for
delay() that still responds to UI events, although the delay currently
cannot be interrupted (which is sub-optimal).

In tilereg-map.cc, add_square() checks the current transform to ensure
that the square is pixel perfect regardless of the transform, so we need
to match the transforms used at buffer-packing- and at render-time.

--------------------------------------------------------------------------------
8af06f9 | Aidan Holm | 2018-07-14 13:28:02 +0800

Prevent webtiles game body from scrolling
This prevents webtiles menu scrolling affecting the game window in the
background, which looks odd.

--------------------------------------------------------------------------------
8ffa595 | Aidan Holm | 2018-07-14 13:28:02 +0800

Add menu.set_title() indent option
The bit where titles are still passed in as a MenuEntry is still weird
and hacky, and I'm not happy about the boolean blindness this
introduces. But it does fix some bugs.

--------------------------------------------------------------------------------
cf2c241 | Aidan Holm | 2018-07-14 13:28:02 +0800

Improve loading splash screen UI
Uses the new UI framework, as usual. Now handles resizes correctly,
and renders the splash screen with filtering enabled.

Todo: separate the DCSS logo from the splash image, so that it can be
rendered independently of the scaled splash image.

Visual design could do with some polish; some of the splash screens
have hard edges that look a little out of place, for example.

--------------------------------------------------------------------------------
e1d3802 | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap end-game hiscore list in popup widget

--------------------------------------------------------------------------------
5bc55b2 | Aidan Holm | 2018-07-14 13:28:01 +0800

Remove unnecessary more() and clrscr()
A more is already forced by the code below, and the clrscr call messes
up the local tiles display.

--------------------------------------------------------------------------------
929062c | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap _print_error_screen() in popup widget

--------------------------------------------------------------------------------
161852b | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap arena startup prompt in popup widget
We also add simplistic colour highlighting for the entry; the two teams
are highlighted in white, and the ' v ' is lightgrey.

--------------------------------------------------------------------------------
5379f3e | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap tutorial end messages in popup widgets

--------------------------------------------------------------------------------
f9c367d | Aidan Holm | 2018-07-14 13:28:01 +0800

Remove CRT menu attaching functionality

--------------------------------------------------------------------------------
3273467 | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap the hiscores menu in a popup widget

--------------------------------------------------------------------------------
7e740b3 | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap the new game menus in popup widgets

--------------------------------------------------------------------------------
6f189af | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap the main menu in a popup widget
Like the skill menu, this is for visual consistency.

--------------------------------------------------------------------------------
12418ba | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap doll editor in a popup widget

--------------------------------------------------------------------------------
2e76a7d | Aidan Holm | 2018-07-14 13:28:01 +0800

Wrap skill menu in a popup widget
Still the same old PrecisionMenu implementation underneath, but wrapped
up in a UIPopup; this is mostly for visual consistency on local tiles.

--------------------------------------------------------------------------------
a582a2a | Aidan Holm | 2018-07-14 13:28:01 +0800

Add SDL wrapper API to set mouse cursor
We use a switch statement here to explicitly guarantee that our cursor
enum values are contiguous and start at zero, since we don't yet wrap
all the cursor types that SDL supports.

--------------------------------------------------------------------------------
c96d248 | Aidan Holm | 2018-07-14 13:28:01 +0800

Add webtiles formatted scroller highlighting

--------------------------------------------------------------------------------
1039b03 | Aidan Holm | 2018-07-14 13:28:00 +0800

Add HTML spell menus on webtiles

--------------------------------------------------------------------------------
43034bf | Aidan Holm | 2018-07-14 13:28:00 +0800

Add tiles to HTML monster description UI

--------------------------------------------------------------------------------
b4c22b7 | Aidan Holm | 2018-07-14 13:28:00 +0800

Add text widget highlighting support

--------------------------------------------------------------------------------
9c721c8 | Aidan Holm | 2018-07-14 13:28:00 +0800

Add formatted_string::substr_bytes()

--------------------------------------------------------------------------------
7e28d6f | Aidan Holm | 2018-07-14 13:28:00 +0800

Prevent some menu resizes when (de)selecting items
Specifically, in the pickup and drop menus and in the shop UI, selection
change changes the menu title/more text, which can cause the menu width
to change.

It's hacky, but to work around this for now we just pad the relevant
strings.

--------------------------------------------------------------------------------
6fbea35 | Aidan Holm | 2018-07-14 13:28:00 +0800

Add menu title and more padding

--------------------------------------------------------------------------------
cb03d4b | Aidan Holm | 2018-07-14 13:28:00 +0800

Show trailing partially visible menu items

--------------------------------------------------------------------------------
b1c2063 | Aidan Holm | 2018-07-14 13:28:00 +0800

Add menu overflow gradients

--------------------------------------------------------------------------------
3fb71ae | Aidan Holm | 2018-07-14 13:28:00 +0800

Use a formatted scroller for the help UI

--------------------------------------------------------------------------------
364e786 | Aidan Holm | 2018-07-14 13:28:00 +0800

Add improved deck description UI

--------------------------------------------------------------------------------
1f9488b | Aidan Holm | 2018-07-14 13:28:00 +0800

Synchronize formatted scrollers between clients
We always recalculate the line height every time we scroll: it's
possible the line height has changed if the page zoom level has changed.

When calculating the current scroller position (line number) it's
necessary to round to the nearest integer; with non-100% zooms there's
some rounding errors that sneak in and produce line numbers that are
ever so slightly less than a whole number, and rounding this to a whole
number is the most robust solution.

--------------------------------------------------------------------------------
bdc67e0 | Aidan Holm | 2018-07-14 13:28:00 +0800

Add scroller widget overflow gradients

--------------------------------------------------------------------------------
60de621 | Aidan Holm | 2018-07-14 13:27:59 +0800

Add HTML formatted scroller UI

--------------------------------------------------------------------------------
b0f107b | Aidan Holm | 2018-07-14 13:27:59 +0800

Add HTML version description UI

--------------------------------------------------------------------------------
1c60cbd | Aidan Holm | 2018-07-14 13:27:59 +0800

Add HTML monster description UI

--------------------------------------------------------------------------------
8a2288e | Aidan Holm | 2018-07-14 13:27:59 +0800

Add HTML describe-god UI

--------------------------------------------------------------------------------
cd832e5 | Aidan Holm | 2018-07-14 13:27:59 +0800

Add HTML mutations/vamp-attrs UI

--------------------------------------------------------------------------------
e6589a7 | Aidan Holm | 2018-07-14 13:27:59 +0800

Add getter for top UI popup

--------------------------------------------------------------------------------
f7378a7 | Aidan Holm | 2018-07-14 13:27:59 +0800

Add HTML paneset construct
This is the HTML equivalent of the UISwitcher widget: a set of widgets
(divs) in the same position, only one of which is visible at any one
time, that all maintain the same size.

It's implemented as a 1x1 grid, but that might need to be changed for
browser compatibility reasons.

--------------------------------------------------------------------------------
35ee80c | Aidan Holm | 2018-07-14 13:27:59 +0800

Implement some webtiles UIs in HTML

--------------------------------------------------------------------------------
f2165d8 | Aidan Holm | 2018-07-14 13:27:59 +0800

Add branch tile to ?/B descriptions

--------------------------------------------------------------------------------
1ce9c33 | Aidan Holm | 2018-07-14 13:27:59 +0800

Add webtiles UI stack APIs
This commit repurposes the existing C stack of menus into a general
stack of UI layers (parallel to the UI widget stack), adding the ability
to store one or more JSON data blobs used to construct a HTML UI.
Each non-menu, non-CRT stack frame contains a vector of JSON strings;
the first is the data used to construct the initial UI, and any extra
JSON strings are used to cache state mutation messages separately.
When the initial state is large (e.g. crawl manual help page), this
permits sending only a short message to all spectators for each mutation
(e.g. page scroll), instead of always resending the full state, while
also making it possible for newly-joined spectators to become fully
up-to-date.

--------------------------------------------------------------------------------
8ed8a87 | Aidan Holm | 2018-07-14 13:27:59 +0800

Implement stack-five UI as a menu

--------------------------------------------------------------------------------
8e67019 | Aidan Holm | 2018-07-14 13:27:59 +0800

Refactor spectator menu tracking

--------------------------------------------------------------------------------
5e79477 | Aidan Holm | 2018-07-14 13:27:59 +0800

Always send full menu data

--------------------------------------------------------------------------------
234bcd4 | Aidan Holm | 2018-07-14 13:27:58 +0800

Fix excessive webtiles traffic from menu deselect_all
This is a quick fix: avoid sending one webtiles message per menu item
that wasn't originally selected.

Also, the "sq" (selected quantity) JSON property has been removed:
menu.js wasn't using it. Note that items still need to be sent after a
selection change, as the item text may be changed automatically.

--------------------------------------------------------------------------------
f6ec910 | Aidan Holm | 2018-07-14 13:27:58 +0800

Shrink webtiles CRT popup in some places
This is something of a hack; ideally, the server would send a JSON
message containing the data required for the webtiles client to render
its own view of popups.

--------------------------------------------------------------------------------
2724650 | Aidan Holm | 2018-07-14 13:27:58 +0800

Make webtiles menu mouse-scrollable

--------------------------------------------------------------------------------
3696671 | Aidan Holm | 2018-07-14 13:27:58 +0800

Add HTML scroller
This adds a function that wraps the contents of a div into a scrollable
container.

 - default scrollbars are replaced (they look seriously out of place)
 - semitransparent overflow 'shades' are added at the top and bottom of
   the scroll container.

In addition, we place the scroll container on its own render layer.
Effectively this means that the menu contents are rendered to a texture,
rather than rendered directly; this means that scrolling is much faster,
as painting now consists of translating and rendering that texture,
as opposed to doing a layout pass over the menu items. With large menus
(the largest I know of is ?/m .*) this takes menu two-finger scrolling
from very janky to perfectly smooth.

--------------------------------------------------------------------------------
fc52b2c | Aidan Holm | 2018-07-14 13:27:58 +0800

Improve webtiles menu appearance

--------------------------------------------------------------------------------
582254c | Aidan Holm | 2018-07-14 13:27:58 +0800

Add popup background to webtiles
I'm not entirely happy with how this is done, but there doesn't seem to
be a better alternative, short of using a canvas. In particular, CSS
sprites with multiple backgrounds doesn't work.

--------------------------------------------------------------------------------
22cf74f | Aidan Holm | 2018-07-14 13:27:58 +0800

Add webtiles popup UI stack
This commit adds an additional webtiles game API to show popups.
Unlike the existing show_dialog() and hide_dialog() functions, the new
API supports a stack of popups.

This API is not available from the client. This avoids adding a
permanent back-compatibility requirement, and also means that no manual
merges are necessary on servers.

--------------------------------------------------------------------------------
b56509f | Aidan Holm | 2018-07-14 13:27:58 +0800

Render menus with new UI framework
This commit replaces most of the menu rendering code with a newer
implementation.

- MenuDisplay abstraction replaced with a single UIMenu class. This
class implements the menu widget used by the UI framework, for both
tiles and console builds.
- tilereg-menu has been merged into UIMenu.
- Misc. other code improvements and bug fixes.

Most of the UIMenu implementation is fairly straightforward; the only
complication is its width-for-height nature. The menu UI will use one
column if there is enough vertical space to display all items, falling
back to a two-column layout otherwise, and so the menu's provisional
height must be known to calculate its corresponding width. This is
incompatible with the UI framework, which can only accomodate widgets
whose height varies based on their width. To work around this, the menu
widget sets itself to expand vertically to determine the available
height; it then disables vertical expansion and requests re-layout,
using the determined height in the second layout pass.

--------------------------------------------------------------------------------
e4b3838 | Aidan Holm | 2018-07-14 13:27:58 +0800

Add resumable_line_reader
This is intended for use as an interim measure, until I get around to
adding a text input widget. The base line_reader cannot be used in new
UI code, since the UI framework needs to provide the keys that arrive at
the widget. The resumable_line_reader works around that by being driven
externally with putkey().

--------------------------------------------------------------------------------
dda5ca5 | Aidan Holm | 2018-07-14 13:27:58 +0800

Add ui::getch()
This commit adds a ui-layout-aware equivalent to getch(), and allows UI
code to associate a layout with a specific keymap context.

Currently, UI layouts and their keymap contexts are stored separately;
this might change once the distinction between layouts and widgets is
clarified.

--------------------------------------------------------------------------------
481745b | Aidan Holm | 2018-07-14 13:27:58 +0800

Make menu columns as narrow as possible

--------------------------------------------------------------------------------
ef52903 | Aidan Holm | 2018-07-14 13:27:58 +0800

Replace PopupRegion with menus
Pretty straightforward. MenuRegion is next...

--------------------------------------------------------------------------------
50fa2d4 | Aidan Holm | 2018-07-14 13:27:58 +0800

Remove unneeded mouse_control
yesno() has its own MOUSE_MODE_YESNO

--------------------------------------------------------------------------------
915e485 | Aidan Holm | 2018-07-14 13:27:57 +0800

Send mouse button pseudo-keys for compatibility

--------------------------------------------------------------------------------
2e207e4 | Aidan Holm | 2018-07-14 13:27:57 +0800

Spruce up the god UI
On local tiles:

- Expand the UI enough so that switching between panes does not force
the height to change. But, if the window is too small, shrink the UI and
allow scrolling.

- Add the altar tile to the UI. The vertical centring of the god name
is sometimes visualy a little iffy when the altar tile is visually
unbalanced (e.g. Trog's altar).

On all platforms:

- Don't adjust the prompt height when switching between god join
prompts. Currently, this is only relevant for Gozag, who has some
additional fee text.

- Don't scroll the top line with the god name or the more text; only
scroll the description.

- Always scroll / switch pages when the relevant key is pressed, even if
a god join prompt is being displayed.

--------------------------------------------------------------------------------
d0573e7 | Aidan Holm | 2018-07-14 13:27:57 +0800

Show tiles for more descriptions
Skills, abilities, cards (just the generic card tile), and clouds

--------------------------------------------------------------------------------
d62d397 | Aidan Holm | 2018-07-14 13:27:57 +0800

Don't resize mutation UI when showing vamp attrs

--------------------------------------------------------------------------------
0867f05 | Aidan Holm | 2018-07-14 13:27:57 +0800

Use new description UIs for ?/I, ?/A, ?/K, ?/F

--------------------------------------------------------------------------------
d0d35ae | Aidan Holm | 2018-07-14 13:27:57 +0800

Add tile option to show_description()

--------------------------------------------------------------------------------
2fc808d | Aidan Holm | 2018-07-14 13:27:57 +0800

Add Switcher widget
This widget only shows one of its children at a given time, but keeps
the same size regardless of the child it is showing. Its size is
determined by the size requirements of its children.

--------------------------------------------------------------------------------
36a14b3 | Aidan Holm | 2018-07-14 13:27:57 +0800

Show tiles for all described dungeon features

--------------------------------------------------------------------------------
fa58e6d | Aidan Holm | 2018-07-14 13:27:57 +0800

Don't include title twice in show_description() UI

--------------------------------------------------------------------------------
bad7c4e | Aidan Holm | 2018-07-14 13:27:57 +0800

Refactor spell-letter to item pairings
This commit reimplements the storage for spell-letter pairings as
a single structure. The previous implementation had two different
structures, and couldn't handle missing letters.

--------------------------------------------------------------------------------
b5f1695 | Aidan Holm | 2018-07-14 13:27:57 +0800

Add { -> i alias in item description UI

--------------------------------------------------------------------------------
8bf25d9 | Aidan Holm | 2018-07-14 13:27:57 +0800

Use improved spell description UI for ?/S

--------------------------------------------------------------------------------
6446de9 | Aidan Holm | 2018-07-14 13:27:57 +0800

Add UI widget min/max sizes
This is used to limit the size of description popup boxes so that
paragraphs don't become fully unwrapped into a single very wide line.

--------------------------------------------------------------------------------
a02aae8 | Aidan Holm | 2018-07-14 13:27:56 +0800

Reimplement formatted scroller
This is the uber commit that 1) moves the formatted_scroller
implementation out of menu.cc and reimplements it with the new UI code,
and 2) adjusts everything that used formatted_scroller to account for
slight API differences.

There's also a few places where this commit reimplements the UI, using
the new UI framework instead of a formatted_scroller, for two reasons:
1) we want to show tiles as part of the UI, and 2) we plan to further
extend each individual UI (item description, spell description, etc) in
ways that require access to the UI widgets (and prevent the use of a
description-with-icon UI abstraction).

--------------------------------------------------------------------------------
6b7a2dd | Aidan Holm | 2018-07-14 13:27:56 +0800

Add helper for running UI layers (Currency)

--------------------------------------------------------------------------------
daa132a | Aidan Holm | 2018-07-14 13:27:56 +0800

Remove lookup-help spellbook specialization

--------------------------------------------------------------------------------
95e8667 | Aidan Holm | 2018-07-14 13:27:56 +0800

Add DungeonCellBuffer::add_monster()
The DungeonCellBuffer renders monsters correctly (full demon parts for
example): this function adds a way to render a monster and its status
icons to a DungeonCellBuffer, without including the floor, etc: to be
used in monster descriptions.

--------------------------------------------------------------------------------
0599262 | Aidan Holm | 2018-07-14 13:27:56 +0800

Add UIDungeon wrapper for DungeonCellBuffer

--------------------------------------------------------------------------------
8742d9a | Aidan Holm | 2018-07-14 13:27:56 +0800

Add UIPopup widget

--------------------------------------------------------------------------------
8ddcb42 | Aidan Holm | 2018-07-14 13:27:56 +0800

Render new UI layouts on top of old UI
This change renders the pre-existing tiles UI before rendering the UI
hierarchy. Since most of the UI using the new system are popup windows,
this works nicely.

--------------------------------------------------------------------------------
0d1085f | Aidan Holm | 2018-07-14 13:27:56 +0800

On console, only redraw dirty part of screen

--------------------------------------------------------------------------------
124b843 | Aidan Holm | 2018-07-14 13:27:56 +0800

Only redraw when screen contents have changed

--------------------------------------------------------------------------------
98b620f | Aidan Holm | 2018-07-14 13:27:56 +0800

Only reallocate widgets with new regions

--------------------------------------------------------------------------------
67b9c87 | Aidan Holm | 2018-07-14 13:27:56 +0800

Hack out small-screen-size panic
For testing purposes.

--------------------------------------------------------------------------------
7558cda | Aidan Holm | 2018-07-14 13:27:56 +0800

Add UI layout invalidation

--------------------------------------------------------------------------------
2505a39 | Aidan Holm | 2018-07-14 13:27:56 +0800

Don't expand grid tracks beyond their natural size

--------------------------------------------------------------------------------
5abded6 | Aidan Holm | 2018-07-14 13:27:56 +0800

Add scroller widget
This has a single child widget and can be scrolled vertically.

--------------------------------------------------------------------------------
ef29da6 | Aidan Holm | 2018-07-14 13:27:56 +0800

Add UI widget event observer API
This commit adds a way to register callbacks for UI-related events.
This mechanism is intended to facilitate coordination between widgets
(as opposed to sub-classing, which customizes behavior within a given
widget).

Listeners are type-safe, and can be anything convertible to a
std::function. Most widgets won't have any listeners attached, so
callbacks are stored in structs associated with the widget type,
rather than within the target widget itself.

--------------------------------------------------------------------------------
aeecdb1 | Aidan Holm | 2018-07-14 13:27:56 +0800

Only render visible grid rows

--------------------------------------------------------------------------------
141eec3 | Aidan Holm | 2018-07-14 13:27:56 +0800

Add text widget
Fairly straightforward. Text is set with a formatted_string, and can be
ellipsized or wrapped independently.

--------------------------------------------------------------------------------
f562428 | Aidan Holm | 2018-07-14 13:27:55 +0800

Add UI scissor stack
A stack of scissor regions is needed because scissoring may occur
at multiple levels of the hierarchy. Without a stack, a pair of
set_scissor() and reset_scissor() will change the scissor region.

--------------------------------------------------------------------------------
bc3b7a3 | Aidan Holm | 2018-07-14 13:27:55 +0800

Add rowspan, colspan, and flex_grow to grid

--------------------------------------------------------------------------------
4a7592a | Aidan Holm | 2018-07-14 13:27:55 +0800

Add crt/sdl-specific widget margin helpers

--------------------------------------------------------------------------------
dcabc23 | Aidan Holm | 2018-07-14 13:27:55 +0800

Add widget preferred size caching
This commit caches the result of a widget's calculations for its
preferred width, as well as its preferred height for a given width.

The cache for a given widget must be invalidated if it or any of its
descendants change any properties that affect their layout.

--------------------------------------------------------------------------------
7936736 | Aidan Holm | 2018-07-14 13:27:55 +0800

Add hierarchical UI system
= Introduction =

This commit implements the beginnings of a UI widget system. The basic
idea is that the UI code should be abstracted somewhat from the rest of
crawl. This new code provides a small framework for two main components
of the UI: layout and rendering.

This has a number of advantages:

 - Resize support for free.
 - UI code is aware of the entire UI that needs to be drawn: this meansd
   no weird edge cases because the event handling loop in one function
   isn't (and can't) repaint something its caller needs repainted... etc.
 - No (fewer?) hacks: no peppering redraw() calls all over the place
   with wild abandon, no CK_REDRAW.

In addition, the same UI layout code is used for both SDL tiles and
console builds: the only difference is that tiles uses pixel coords,
and console uses terminal char coords. Rendering and layout for both
platforms is fully abstracted.

= Layout / Rendering =

get_preferred_size() retrieves a widget's minimum and "natural" size on
a given dimension (a "size request"). If retrieving the vertical size
request, a prospective width must be given, and the returned minimum and
natural size will be calculated according to that width: this allows a
text widget to adjust its required height depending on its width, by
rewrapping text to fit the width. Container widgets (those that contain
other widgets) will generally call this method on their children in
order to calculate their own size requirements.

When the UI hierarchy needs to be laid out, the horizontal minimum
and natural sizes are computed by calling get_preferred_size() on
the toplevel widget: this is a recursive process. The viewport
(screen/terminal) width is clamped to the minimum and natural widths,
and the result is used to compute the vertical size request, again using
get_preferred_size(). Likewise, the viewport height is clamped to the
result. The resulting viewport width and height are passed to
allocate_region().

Each container widget is responsible for laying out its children within
its allocated region, and then calling allocate_region() on each of them
in turn. Leaf widgets (text/image/etc.) usually pack buffers at this
point.

Rendering is relatively straight-forward: widgets render their contents
to their allocated regions, and then call render() on their children.

= API =

The main API is designed to be used with existing crawl code.
ui_pump_events() is a replacement for the ad-hoc while-getch loops seen
throughout the crawl codebase; as it has full knowledge of the UI
layout, it can render the full UI, including UI from code completely
unrelated to the call site.

This function is meant to be used in conjunction with event handlers
(implemented in a later commit).

--------------------------------------------------------------------------------
49ce1fb | Aidan Holm | 2018-07-14 13:27:55 +0800

Add tile_def_info() helper
This helper works like tile_gui_info(), tile_player_info() et al,
except that it takes a tile_def structure, calling whichever
texture-specific function is appropriate to retrieve the tile texture info.

It's a little strange that this is a method of the ImageManager; ideally
the ImageManager would query this function rather than maintain a map of
texture to texture-info-getters (which is how this function is currently
implemented).

--------------------------------------------------------------------------------
3f26980 | Aidan Holm | 2018-07-14 13:27:55 +0800

Add CK_RESIZE to console input handling
This commit adds an interface to specify that getch_ck() should return
CK_RESIZE when the terminal is resized. This is necessary for the new
UI system to redraw the UI immediately on resize, without repeatedly
polling ncurses.

Unix requires using ncurses' builtin SIGWINCH handler to interrupt
get_wch(), but variants without support for KEY_RESIZE will continue to
use the old signal handler, and therefore won't return CK_RESIZE.

Whether CK_RESIZE is returned is controlled by set_getch_returns_resizes()
This interface isn't ideal, but it's simpler than modifying all existing
call sites to handle CK_RESIZE.

--------------------------------------------------------------------------------
1015d74 | Aidan Holm | 2018-07-14 13:27:55 +0800

Revert "Add static files for CBRO ui-overhaul experimental"
This reverts commit 101988f953aa354d7553a1fbf43b5dbbc4932be4.

--------------------------------------------------------------------------------
a0c6fd2 | gammafunk | 2018-07-13 15:06:51 -0500

A mace-themed ghost transporter vault for Dungeon and Orc
Various ogre and giant monsters wait inside a transporter area to remind
you to respect things that can hit with a giant stick, lest you end up
like the ghost in this vault. Places ogres initially, progressing to
two-headed ogres, with a chance to place an ettin, frost giant, or fire
giant in the latest depths. One monster of the most dangerous type will
have a fancy good_item or randart mace that is either a dire flail or
great mace. If this monster is a fire or frost giant, its mace will be
flaming or freezing, respectively.

--------------------------------------------------------------------------------
d6a3efe | gammafunk | 2018-07-12 02:32:07 -0500

Add a missed changelog item (Ge0ff)

--------------------------------------------------------------------------------
6d95e9e | advil | 2018-07-11 14:27:37 -0400

Enforce minimum buffer sizes for domain sockets
On linux these have reasonable defaults, but on OS X (and probably other
unixes) the receive buffer default for unix datagram sockets is
unreasonably small for crawl's purposes, 4096. This mins the receive
buffer at linux's default (which is enough that a crawl map can transfer
without errors). For sanity's sake I added a min for the send buffer,
but I think this value is much more standard.

--------------------------------------------------------------------------------
d5849c7 | advil | 2018-07-11 13:38:02 -0400

Make socket write retries more aggressive
Under some circumstances, these writes may block while the webtiles
server processes data -- something that happens very quickly, but not as
quickly as the send loop in this code. For example, if the socket buffer
size is <=4096 (the default on OS X, but not linux), trying to send
larger batches of data (such as a map on load or level change) will
cause ENOBUFS until the server has had a chance to receive the previous
fragment. The previous sleep timing was effectively causing a 500ms
sleep per 2048 byte fragment[1], and so since a map can take on the
order of 200kb, this was imposing substantial slowdowns on OS X
webtiles.

This fix first tries some 2ms sleeps, and then backs off to 500ms. 2ms
is still more than enough for the webtiles server to do its thing in my
testing; we'll see if it causes in problems on live servers (I have no
idea how often this case is triggered outside of OS X). I may still
accompany this with a change to the default socket size.

1 I'm not sure why it's not every two fragments, but there might have
been a few initial bytes in the buffer in real-world scenarios, or some
overhead not directly accounted for.

--------------------------------------------------------------------------------
b59be55 | advil | 2018-07-11 13:33:42 -0400

Add debug messages for webtiles socket writes
These seem like they could probably be useful in the future, too.

--------------------------------------------------------------------------------
34fbaa0 | gammafunk | 2018-07-10 23:40:44 -0500

Add Patashu to the mailmap

--------------------------------------------------------------------------------
4a2a387 | Timothy Stiles | 2018-07-10 23:33:43 -0500

Gnoll tiles (Giik)
Made by Giik ( http://the-giik.tumblr.com/ )

Committer's Note: Closes #811.

--------------------------------------------------------------------------------
d2f0174 | Alan Malloy | 2018-07-10 16:37:55 -0700

Clarify description of =rCorr and ARTP_RCORR (/u/cstieg1)
Hopefully saying 'all sources' of acid and corrosion will reduce
player confusion about whether this applies to *Corr.

--------------------------------------------------------------------------------
46e8f3c | gammafunk | 2018-07-10 15:37:36 -0500

A stat drain themed ghost vault for Dungeon and Orc (mikee)
Players who don't watch out for those pesky sources of stat drain might
end up haunting the transporter vault gammafunk_ghost_stat_death.
Dex-draining Quasits are the only threat accompanying the ghost early
on, with the quasits being supplemented by int-draining neqoxecs by D:9.
There's the usual pile of progressive loot, and the ghost generates over
a ring of dexterity or intelligence that has progressively higher
chances for being good_item or randart.

Based on an initial suggestion from mikee for a ghost vault with a bunch
of quasits and a ring of DEX.

--------------------------------------------------------------------------------
65f81ef | gammafunk | 2018-07-10 15:37:20 -0500

Updates to gammafunk_ghost_icy
Tweak the numbers of monsters and loot items to have a more consistent
progression and fix floor tiles surrounding the vault.

--------------------------------------------------------------------------------
fedc9ff | advil | 2018-07-09 10:43:58 -0400

Handle sealed runed doors properly (11508)
Monsters could open runed doors while they were sealed, leading to
escaping player ghosts. This checks the original terrain for the seal. I
lightly refactored some closed door checks in monster AI to be clearer
and a bit more general.

--------------------------------------------------------------------------------
8a62e23 | gammafunk | 2018-07-08 16:39:02 -0500

Remove code for using decks when worshiping gods other than Nemelex
Back when decks could appear as random items and were retained upon
abandonment of Nemelex, cards could potentially be used by players
worshiping other gods. Hence there is code in place to prevent
generating cloud types that specific gods disapprove of and to track use
of Degeneration under Zin.

This commit removes this code, since decks no longer generate randomly
and are destroyed upon abandonment of Nemelex. It could have a
TAG_MAJOR, but the gameplay ramifications of this change are very small.

--------------------------------------------------------------------------------
d782b18 | gammafunk | 2018-07-08 16:39:02 -0500

Don't warn Dithmenos worshipers about burning trees (kitchen_ace, 11509)
Dith no longer has an anti-fire conduct.

--------------------------------------------------------------------------------
acb6733 | advil | 2018-07-08 09:49:36 -0400

Don't dissipate clouds when testing door sealing for tension (11506)
As |amethyst suggested, this is happening because clouds will be
instantly deleted on terrain changes that leave them out of los (as of
7e89378e288a). The door sealing code tests various door closing options
to see which maximizes tension, and these would delete the clouds even
if none of them for used, because their los effect is still calculated.
This solution simply backs up a copy of env.cloud, since in principle
the cloud changes might impact tension.

--------------------------------------------------------------------------------
9281fa2 | gammafunk | 2018-07-06 23:48:07 -0500

Update the changelog through 0.22-a0-604-gc538b7411b

--------------------------------------------------------------------------------
c538b74 | gammafunk | 2018-07-06 23:22:08 -0500

Update the changelog for some previous releases
The changelog was missing some changelog entries for previous point
releases going back to 0.17.1. Add these so that the changelog isn't
confusingly missing release information.

--------------------------------------------------------------------------------
fc1114d | gammafunk | 2018-07-06 16:58:02 -0500

Make Dithmenos an evil god (mikee)
Now that Shadow Step has an HP cost, this reinforces the notion that
Dithmenos is an evil god. It wants the entire world to be shrouded in
eternal darkness; doesn't that sound just mean and awful? The gameplay
consequences of this are few, mostly related to conversion wrath from
the good gods, the god-themed artefacts not getting the holy wrath
brand, and the inability to summon or phantom mirror holy monsters. It
will give Dith a bit more flavor to replace that which was lost when the
fire conduct was removed.

The new god description text, which is surprisingly non-transifex-like,
comes courtesy of mikee.

--------------------------------------------------------------------------------
6d45252 | gammafunk | 2018-07-06 16:57:05 -0500

Rework Dithmenos' Shadow Step restrictions and costs (mikee)
Shadow Step currently requires that any target monster be "still" in
order for it to be a valid target, which means the monster has to be
asleep, paralyzed, or otherwise immobile. This generally requires using
the ability near unexplored areas, which is risky even if the player can
one-shot the target monster with a stab. Players without good stabbing
ability found little use for Shadow Step despite the ability being the
only relatively low cost invocable offered.

This commit removes the stillness restriction for Shadow Step, instead
giving the ability an HP cost of about 8% of max HP. This will give
incentive for non-stabbers to use the ability while still being useful
for setting up stabs for high-priority targets. Shadow Step still
requires the target to be within the Umbra, but no longer requires any
notion of monster stillness.

Balance-wise, allowing the player to make long chains of shadow step is
a concern, but a significant HP cost paired with the current fairly high
piety cost prevent this from getting out of hand. As the player loses
piety, their access to Shadow Form can be lost and the size of the Umbra
decreases, reducing the range of the next shadow step. We can adjust the
HP and piety costs accordingly if the current costs aren't sufficient.

The ability description has been updated to remove references to
stillness and to clarify that the adjacent landing site is randomly
chosen.

--------------------------------------------------------------------------------
b0ed703 | gammafunk | 2018-07-05 16:10:20 -0500

Give non-menu abilities default flags, document, and reformat
Give Wu Jian's Lunge and Whirlwind abilities default flags so people
don't think that these actually show up in the menu. It might be nice if
the ability enums/entries didn't have to exist just because of action
counting, but that would take some reworking of the action counting
system. Closes #775.

--------------------------------------------------------------------------------
a441c7e | Edgar A. Bering IV | 2018-07-05 16:10:20 -0500

Allow Call Merchant while Starving
When porridge was removed from Potion Petition a careless and hungry
Gozagite could end up Starving without rations by not paying attention.
The only escape was then to abandon Gozag, kill something to eat, and then
either re-join or live out the wrath, and hope that you have enough gold
to do this successfully.

Previous nutrition-granting abilities have been allowed while Starving
(Vitalization and Potion Petition) since the
"abandon->eat->rejoin/mollify" flow is a cruel screw, so Call Merchant
should be allowed (with its guaranteed food shop).

--------------------------------------------------------------------------------
ccc8333 | Edgar A. Bering IV | 2018-07-05 16:10:20 -0500

Datify ability hunger checks
Add a new flag abflag::starve_ok and add it to abilities that can be
used while starving, instead of using a switch/case.

--------------------------------------------------------------------------------
06ccb6e | advil | 2018-07-05 10:28:27 -0400

Fix webtiles chat player urls (Cody Cutler)
Broken in caf04dffec4948451bd, because I didn't understand how these
were supposed to work.

--------------------------------------------------------------------------------
bd89b2e | gammafunk | 2018-07-05 02:22:10 -0500

Adjust the placement of Ilsuiw (alexjurkiewicz)
Currently Ilsuiw has a 100% chance of placing on Shoals:4 if she didn't
place on Shoals:3. Fighting her will be a more memorable (some would say
'unique') experience if doesn't happen every time on a specific level.
This commit introduces a 1/5 chance that her Shoals:4 guardian vault
places. It also sets the range of her normal unique vault to Shoals:2-3,
both so that she can place on Shoals:2 and so that this vault does not
give an additional chance of placing her on Shoals:4. Finally, we give
her normal unique vault the typical weight of 50 we use for
branch-specific uniques. Now her chances of placement on Shoals:2-3 are
more similar to that of placing on Shoals:4.

After this commit, mapstat shows her chance of placing overall in shoals
is between 40 and 50% (more objstat iterations needed to be sure), with
a slightly higher 20-25% chance of placing on Shoals:4 compared to about
10-15% chance for both Shoals:2 and Shoals:3. This is similar to
placement of other branch-specific uniques like Polyphemus, Arachne, and
Vashnia. Closes #774.

--------------------------------------------------------------------------------
fbd32a6 | gammafunk | 2018-07-04 20:49:11 -0500

Simplify out a function
This is no longer needed, as longer half-opaque solid features no longer
exist.

--------------------------------------------------------------------------------
47e2213 | gammafunk | 2018-07-04 20:45:41 -0500

Clean up a condition and document a possible simplification
As the comment mentions, trees should probably be treated as walls by
`feat_is_wall()`.

--------------------------------------------------------------------------------
be81960 | gammafunk | 2018-07-04 20:36:09 -0500

Merge pull request #796 from ebering/lrd-tree-bug-pr
Have trees properly block explosions
--------------------------------------------------------------------------------
bea20c6 | gammafunk | 2018-07-04 20:12:54 -0500

Merge pull request #807 from NormalPerson7/fix-cloak-generation-rate
Make items for the cloak slot be equally common as other auxiliary armour slots 
again
--------------------------------------------------------------------------------
c01a7f0 | gammafunk | 2018-07-04 18:50:36 -0500

Revise the chance for pulling players deeper into the Abyss
The new formula removes the XL15 cutoff for the chance to pull the
player deeper into the Abyss upon shift/teleport. The chance formula is
now:

  (XL + 4 - Depth)^2 / (27^2 * (Depth + 5))

Some of the new chances:
* Characters at XL 1 have about a 0.1% chance of getting pulled from
  A:1.
* Characters at XL 13 have chances of 5.9%/4.4%/3.3%/2.6% for getting
  pulled from A:1/A:2/A:3/A:4.
* Characters at XL 27 have chances of 20.6%/16.5%/13.4%/11.1% over the
  same levels.

It's relatively easy to escape from the abyss at XL13, and a small
chance of getting pulled a level deeper where exits are more common
won't have much impact on players at these XLs.

This commit also updates comments and spacing and properly declares a
function as static. Closes #757.

--------------------------------------------------------------------------------
ae4dde8 | Edgar A. Bering IV | 2018-07-04 18:37:40 -0500

Draw higher XL players deeper into the abyss
Currently, outside of the abyss, as dungeon threat level goes up, the
average banishment depth goes up also. However, if a high XL player
enters the abyss voluntarily, they can hang out on A:1 forever.

This patch gives a chance that an abyss teleport drives the player
deeper into the abyss. The chance scales up with XL and down with depth,
and doesn't kick in until XL > depth +13. This has two effects: it
increases the lethaltiy of the abyss for higher XL players, and speeds
their progress through it.

Committer's Note: The chance formula is modified in the next commit to
scale the chance without using an XL cutoff.

--------------------------------------------------------------------------------
7d32d7c | gammafunk | 2018-07-02 23:56:40 -0500

Update the description of the mace of variability
Don't refer to the chain of chaos spell, which isn't directly castable.
Instead refer to the effects right in the description. Also change the
flavor text to be more inline with the current weapon behavior.

Closes #802.

--------------------------------------------------------------------------------
e3ae32f | gammafunk | 2018-07-02 23:49:05 -0500

Remove unused monster casting for chain of chaos
This spell used to be castable on a demonspawn monster, but that monster
no longer exists. Chain of chaos isn't very good as a monster spell
since it applies multiple chaos effects to the player per turn and at
range. Chaos breath is ranged but only applies on effect per turn due to
its use of clouds, so this is at least a better style of spell or breath
to give monsters.

This commit removes code used to let monsters cast chain of chaos
directly. Monsters can still use the chain of chaos effect from wielding
the mace of variability, since that triggers from a melee effect and
doesn't need the usual monster spell setup functions.

--------------------------------------------------------------------------------
f487629 | gammafunk | 2018-07-02 23:49:05 -0500

Adjust the effects of chaos beams
The chaos beam type is only used for the chain of chaos spell cast by
the mace of variability and for the impact (non-cloud) effect of
apocalypse crab breath. Currently chaos beams select from a set of beams
analogous to effects used by the chaos brand, but using mostly flat
selection weights. The flat weights effectively give chaos beams much
higher weighting relative to the chaos brand for strong effects like
banishment, polymorph, hexing or buffing the monster, or miscast
effects. This difference isn't very apparent for chaos breath, since the
beam is only applied once for impact damage, but for the mace of
variability, a chaos arc can hit a monster multiple times in a turn.

This commit re-weights the chaos beam effect table to be closer in
behaviour to the chaos brand. Beams directly analogous to other brands
like flaming, freezing, electrocution, etc now have comparatively higher
weight, and rarer effects that only happen when the chaos brand
reselects itself have lower weight.

Note that this commit has no effect on the behaviour of the chaos brand,
monster af_chaos, or chaos clouds; it's only relevant for the mace of
variability and impact (non-cloud) effects from chaos breath. It would
be ideal to somehow merge the selection of these beam effects with the
effect selection used for SPWPN_CHAOS, especially since the latter is
already used for all chaos melee and launcher egos as well as chaos
clouds.

--------------------------------------------------------------------------------
0c8d57c | gammafunk | 2018-07-02 23:37:48 -0500

Adjust effect damage and enchantment of the mace of variability
The mace of variability casts chain of chaos with spell-power ranging
from 75 to 149 with an average of 112. Ignoring any damage from the
chaos beam effect, the current arc damage formula of 3d(5 + pow / 2)
gives the mace's spell damage die of 3d61 per arc on average. This is
very high, especially since the monster gets zapped 4 times on average
(albeit with spell-power that decreases by 14 on average with each arc).

To balance the damage from the mace, reduce the damage formula of chain
of chaos to 3d(5 + pow / 6). Now an arc from the spell will do 3d23
damage on average, which is still significant damage even when cast only
1 in 5 melee hits. And of course, in addition to damage, each arc
applies random effect from the chaos beam.

This commit also lowers the enchantment of the mace to +7 from a
previous commit's value of +10. A +7 great mace will be quite strong
enough with 1 in 5 attacks casting chain of chaos in addition to the
normal chaos ego. Also 7 is a lucky number, which Xom appreciates, and a
value lower than the typical +9 max is a **secret reference** to the
original unrand behaviour.

--------------------------------------------------------------------------------
9148847 | Edgar A. Bering IV | 2018-07-02 23:36:58 -0500

Add the mace of Variability to ebering_ghost_xom
The item is terrifying now that it has chain of chaos, so it can't
appear early. But also thematic and good temptation.

--------------------------------------------------------------------------------
8c3e449 | Edgar A. Bering IV | 2018-07-02 23:35:09 -0500

Revise the mace of Variability
Having a weapon that was occasionally useless didn't make for a good
item. In the tradition of other unrands that are "this brand but more"
(Arc Blade, Firestarter, Frostbite, Leech), this changes the mace to
have a chance of casting chain of chaos on hit and have a fixed plus. As
flavourful as the plus swing is the player is encouraged to wait for the
random walk to go up before fighting.

Committer's Note: The chain of chaos damage and set of effects as well
as the enchantment for this weapon are modified in a subsequent commit.

--------------------------------------------------------------------------------
8c174e5 | Edgar A. Bering IV | 2018-07-01 22:48:40 -0500

Remove self-harm from chain of chaos (gammafunk)
The effects (even with a special case preventing banishment and
polymorph) didn't make for a good monster spell because of self-harm. This
adds a special case to prevent chain of chaos from harming the caster,
replacing the beam's flavour with BEAM_VISUAL to keep the arcs going and
waste an arc so that the spell has about the same offensive power as
before. Banishment and polymorph are now added to the effect list.

--------------------------------------------------------------------------------
d5db89c | Chris Campbell | 2018-07-01 17:47:36 +0100

Add Alexandra Shields to credits

--------------------------------------------------------------------------------
b62a27e | gammafunk | 2018-07-01 01:33:49 -0500

Port some ghost vaults to the Vaults branch
Adapt ebering_ghost_xom, biasface_ghost_orc_armoury, and
ploomutoo_gammafunk_potion_laboratory as ghost rooms for Vaults.
Ebering's vault is copied basically unchanged, just with some extra
space to not make the room too tiny. For Biasface's vault, I've removed
the wargs, orc priests, and some of the plain orcs, replacing them with
orc high priests, some more orc knights, stone giants, and orc warlords.
The armour/weapon/jewellery loot has one piece of good potion or scroll,
and the additional warlords that sometimes place have a chance to get
fancy gear. Ploomutoo's vault is ported mostly unchanged, using the same
monster and loot set that the original vault uses in Depths, but with
slightly fewer top-tier monsters and one less loot piece in each
chamber.

--------------------------------------------------------------------------------
afc7989 | gammafunk | 2018-07-01 01:24:11 -0500

Some ghost vault DES and code cleanups and refactoring
Use the general loot functions for lone ghost vaults in the Vaults ghost
rooms, adding it to ghost.lua so it's available to those vaults. Trim
extra outer spacing or wall in some of these same ghost rooms and remove
any special floor tile settings. These tiles look out of place in Vaults
rather than conveying a ruined look. Don't try to use sandstone wall
tiles in the Gozag ghost vaults since it conveys more of a weathered
natural look than it does "gold". Likewise remove the yellow stone wall
coloring for console.

Move several ghost vaults that have thematic monsters into the "Themed"
section of ghost.des, add a missing float ORIENT, and fix a comment.

--------------------------------------------------------------------------------
5148d60 | gammafunk | 2018-07-01 00:49:14 -0500

Updates to ebering_ghost_davey_jones
Allow this vault to place on Shoals:$, since it will work fine on this
level. Instead of either a kraken or a kraken simulacrum, place either a
single kraken or a mix of two kraken simulacrum or spectres, as either
of the latter have vastly less HP than a kraken. Add a bit more deep
water to give the pair more room to move about.

Refactor glyph usage to not use the % glyph for corpses and hence fix a
loot item.

--------------------------------------------------------------------------------
a172949 | gammafunk | 2018-07-01 00:49:14 -0500

Updates to ebering_ghost_gozag
Scale the threats more carefully so that it doesn't feature so many 9
and 8 monsters in earliest depths and so that difficulty increases more
smoothly with depth. Always place 2 normal random spawns on average,
slowly increasing the monster count by adding 9 and 8 monsters. Tweak
the placement of the obsidian statue to increase in chance gradually,
making it 100% by Lair branches. To supplement the loot as depth
increases, add a mix of either a good loot potion or an antique shop,
starting with a 50% chance of one of these on D:9, making up to two of
them by the later depths.

Simplify the logic of the gold pile function to mostly use absdepth,
increasing the value used a bit for Orc. Also add a variant of this
vault as a ghost room for Vaults.

--------------------------------------------------------------------------------
a6a7277 | Edgar A. Bering IV | 2018-07-01 00:49:14 -0500

Port several ghost vaults to the Vaults branch
Committer's Note: Squashed commit that ports the lone ghost vaults
ebering_ghost_inner_flame, ebering_ghost_reflecting_pool, and
ebering_ghost_disaster_area to vault rooms for Vaults.

--------------------------------------------------------------------------------
0289154 | Edgar A. Bering IV | 2018-07-01 00:49:14 -0500

Davey Jones' / Kraken themed ghost vault for Shoals
Guarantees a randart ring, chance of an octopus king ring

--------------------------------------------------------------------------------
bb431e2 | Edgar A. Bering IV | 2018-07-01 00:49:14 -0500

Disaster themed lone ghost vault

--------------------------------------------------------------------------------
2af43bd | Edgar A. Bering IV | 2018-07-01 00:49:14 -0500

Gozag themed ghost vault
No items, only gold and a Gozag altar. Gold loot is scattered in piles
and scales as follows: From 3-9 piles at D:3 to 12-18 at D:15 and below.
Further scaling comes from the natural scaling of gold pile size. The
monster set has two 998 monster placements and adds some 0's deeper.
There is a chance for the central statue to be an oklob in lair or an
obsidian statue elsewhere.

Committer's Note: Squashed two other subsequent commits by ebering and
updated the final commit message based on his notes in the squashed
commits. This vault's placement depth, loot, and monster composition
will be modified in a subsequent commit.

--------------------------------------------------------------------------------
0116f15 | NormalPerson7 | 2018-06-30 14:22:29 +0100

Make items for the cloak slot be equally common as other aux slots again
In commit 651d724, scarves were increased from being 1/6 to 1/4 of items
generated for the cloak slot, however the actual increase in spawn rate
for scarves was minimal, from 1/30 to 1/28 of all auxiliary slot armours
generated, because what this commit actually did was reduce the spawn
rate of cloaks from 5/30 to 3/28 by reducing the weight of cloaks.

It seems like an accident that this meant the total weight for this
random_choose_weighted was not the 30 that a comment implied, and that
the cloak slot items (cloaks and scarves combined) were made 2/3 as
common as other auxiliary slot armours.

As a result, this commit buffs the spawn rate of cloaks and scarves to
bring the overall spawn rate in line with that of other auxiliary
armours, whilst maintaining the same 3:1 ratio of cloaks:scarves.

--------------------------------------------------------------------------------
4a923d4 | Aidan Holm | 2018-06-30 19:18:02 +0800

Fix Ru sacrifices not giving full piety (Xenobreeder, #11503)
For skill sacrifices specifically, the amount of piety gained was
recalculated after the sacrifice was performed, i.e. after the skill in
question had been dropped to level zero. In testing, sacrificing 27
stealth promised full piety, but granted none.

--------------------------------------------------------------------------------
58866f5 | Chris Campbell | 2018-06-29 18:21:25 +0100

Merge pull request #806 from shieldal/fix-zot-trap-malign-gateway
Fix zot traps casting friendly malign gateways (0011042)
--------------------------------------------------------------------------------
e1900bc | shieldal | 2018-06-28 22:47:11 -0700

Fix zot traps casting friendly malign gateways

--------------------------------------------------------------------------------
270d1ae | gammafunk | 2018-06-28 22:54:26 -0500

A happy afterlife ghost vault for Dungeon and Lair from hellmonk
In hellmonk_ghost_happy_afterlife, a ghost decides to not dwell on the
failures they made in life, preferring to just relax next to a nice tree
with a nice meal (a ration) and some nice drinks (1-2 potions). Of
course, if you disturb its meal it will not hesitate to kill you, since
ghosts like killing players more than they like meals they can no longer
eat. The potions upgrade in quality and number as depth increases.

--------------------------------------------------------------------------------
ff9aefc | gammafunk | 2018-06-28 17:19:05 -0500

A potion ghost vault for Dungeon, Elf, and Depths (Ploomutoo)
In ploomutoo_gammafunk_potion_laboratory, an alchemist with a collection
of nice potions conducted a fatal experiment resulting in an explosion
of mutagenic horrors. Now their ghost haunts a two-chambered lab,
guarding loot that contains a number of potions of mutation, high
quality random potions, and a piece of aux armour or a robe. Monsters in
the first chamber are melee-oriented: ugly things, very ugly things,
large abominations, and tentacled monstrosities are all used depending
on the depth and branch, supplemented with the occasional glowing orange
brain. In the second chamber is the ghost along with shape-shifters and
malmutators (neqoxecs and later cacodemons).

This vault was originally submitted by ploomutoo with the main layout
and a basic set of monsters and loot for dungeon. I modified the monster
sets to make the themes of the chambers distinct and to allow placement
in other branches. I also scaled the number and composition of loot and
monsters as depth increases. Finally, the layout was updated to better
allow placement of mutagenic fog machines.

--------------------------------------------------------------------------------
b275bf3 | gammafunk | 2018-06-28 15:44:43 -0500

Some ghost vault fixes and refactoring.
Make the good loot potion/scroll item lists available as variables for
other vaults to use when they're handling their own loot placement. Fix
a potion specification error ('cancellation', not 'cancelation') and
clean up DES spacing.

--------------------------------------------------------------------------------
fc6459a | gammafunk | 2018-06-27 02:14:37 -0500

Updates to gammafunk_ghost_spectres
Use monster/loot depth breakpoints consistent with the other vaults and
update the wraith composition for later depths. This was placing a high
proportion of ordinary wraiths at D:12-, where the player is likely to
have have completed both Lair and Orc. Reduce numbers of these and add
more freezing wraiths in their place, also slightly increasing the
highest tier wraiths in the very latest placement depths.

--------------------------------------------------------------------------------
3e71e8a | gammafunk | 2018-06-27 02:14:37 -0500

Updates to gammafunk_ghost_split
For later depths, update the monsters this vault places to use a bit
less 0 monsters and a little more of 9 and 8 out-of-depth ones. Early on
it's ok if this vault feels less like a 098 vault and more like a vault
with in-depth monsters only, but by Lair branches it should really have
a significant number of more threatening monsters in addition to the
ghost. Also update the wall glyph usage so that the outer or inner walls
would use wall types that would seem out of place in certain branches.

--------------------------------------------------------------------------------
1b94d8d | gammafunk | 2018-06-27 02:14:37 -0500

A labyrinth themed ghost vault for Dungeon, Lair, and Orc from Maelrawn
In maelrawn_ghost_labyrinth_escape, a player tried to escape from a lab
with loot in tow. Sadly, the minotaur was right behind them, and then
they ran right back into all the monsters they ditched to reach the lab
entrance.

This vault places on any level that could normally place a labyrinth
(D:10-, Lair, Orc:2), but of course only places through the usual ghost
vault chance and additionally has half the usual vault weight. It should
be a pretty nasty one, since the minotaur is quite the threat on its
own. The vault supplements the minotaur with a few branch monsters that
eventually include out-of-depth 9 monsters at later placement depths. It
doesn't recreate the more generous loot of an actual Labyrinth portal,
but it does place up to 5 items and supplements this with the good loot
replacement used by other ghost vaults.

--------------------------------------------------------------------------------
d813392 | gammafunk | 2018-06-27 02:14:37 -0500

Add good consumables or equipment to the loot in many ghost vaults
Currently, ghost vaults that place monsters in addition to the ghost
also place items that upgrade in quality, with the count increasing from
3 to as high as 7 as depth increases. These items are of higher quality
than usual floor items, with each item eventually reaching 50% each of
superb_item and star_item, but those item classes are highly variable.
In later Dungeon levels and beyond, it's common to see no item that's
reasonably worth the risk of fighting a ghost along with additional
monsters. To provide additional incentive for players to attempt these
vaults, this commit adds a `good_ghost_loot()` function that can replace
one or two pieces of the "superb_item / star_item" loot with items that
have a narrower range of useful possibilities.

The first replacement consists of scrolls and potions with weights only
for those that are broadly useful, along with aux armour, jewellery, and
a small chance for a manual. The aux armour and jewellery have lower
weight relative to the scrolls and potions, but upgrade to have
good_item and later randart modifiers as depth increases. The first item
replacement only has a chance to happen starting from D:9-11, with the
chance increasing to 100% by Lair. The second item is a potion or scroll
using the same weights as the first item. It has a chance to appear
starting in Lair, becoming 100% by the Lair branches.

Most ghost vaults that place additional monsters have been updated to
call this function and have any necessary change to their loot placement
statements. The function defines the items on the 'd' and 'e' glyphs and
leaves the calling vault to perform any necessary substitutions if they
wish to override this definition or handle multiple instances of those
glyphs. A couple vaults that already place specialized loot remain
unchanged.

--------------------------------------------------------------------------------
06062c5 | gammafunk | 2018-06-27 02:14:14 -0500

Remove upweighting for gammafunk_ghost_grave
This vault was originally the only simple vault that placed a single
ghost. We now have a number of others like this that have normal weight,
so there's no need to upweight this one in particular.

--------------------------------------------------------------------------------
921cf92 | gammafunk | 2018-06-27 00:16:25 -0500

Consistently use depth breakpoints for ghost vault loot
Use the same depth partitions for the Dungeon branch across these
vaults.

--------------------------------------------------------------------------------
6e350e3 | gammafunk | 2018-06-27 00:15:07 -0500

Some small ghost vault fixes
Add a missing float ORIENT to a ghost vault, remove an erroneous loot
substitution and a floor tile statement, don't use wall types inside a
vault that would seem out of place in some branches, and clean up a
comment and a variable name.

--------------------------------------------------------------------------------
c224181 | Chris Campbell | 2018-06-25 22:39:14 +0100

Don't make ancient zymes sicken friendlies (#10769)
Neutral zymes (from Corruption for example) will still sicken the player, but
friendly ones won't sicken the player and hostile ones won't sicken other
hostiles.

--------------------------------------------------------------------------------
b306ea2 | Edgar A. Bering IV | 2018-06-25 22:09:14 +0100

Fix bug 11478: Movement-key actions and Wu Jian
In _move_player, the easy-open door let control flow continue through
the function to behaviors that should only trigger upon moving. The most
noticable is the Wu Jian processing, leading to the bug.

The function could use some further simplifications, it's a bit
spaghetti.

Closes #778.

--------------------------------------------------------------------------------
59e8874 | Chris Campbell | 2018-06-25 22:09:14 +0100

Fix bracing

--------------------------------------------------------------------------------
334a0db | Chris Campbell | 2018-06-25 22:09:14 +0100

Don't break Ozo's or cause barb damage on forced level transitions
Such as being banished or falling down an unknown shaft. Also re-order some
checks.

--------------------------------------------------------------------------------
2b3c548 | Jacob Meigs | 2018-06-25 22:09:00 +0100

Trigger barbs and break Ozo's Armour when taking stairs/walljumping
[Cleaned up some code and whitespace, and updated commit message - MarvinPA]

Closes #747.

--------------------------------------------------------------------------------
9358b0b | gammafunk | 2018-06-24 18:49:35 -0500

Add a missing ghost setup function to another vault (ebering)
Incredibly, I also missed this one that ebering also missed!

--------------------------------------------------------------------------------
28ad1da | gammafunk | 2018-06-24 18:37:47 -0500

Add a missing ghost setup function to a vault (ebering)
ebering_ghost_reflecting_pool was missing this.

--------------------------------------------------------------------------------
3b2bdd4 | gammafunk | 2018-06-24 16:51:00 -0500

Ghost vault DES cleanups
In gammafunk_ghost_necromancy, specify the Depth in a better way by
using 0 weight for Elf. Fix variable initialization for the hydra head
code and reformat DES alignment in various vaults.

--------------------------------------------------------------------------------
b51906a | gammafunk | 2018-06-24 16:51:00 -0500

Updates to two ghost sewer vaults
For ebering_ghost_sewer_d, a single adder guard doesn't scale very wall
through D:6. The original sewer entry was just trying to slow the player
down a bit to make the portal timer relevant, but monsters in ghost
vaults are trying to pose a legitimate threat. Supplement the vault with
additional adders in earlier depths and a chance for a bullfrog, adding
a guaranteed bullfrog by D:6. Adjust the loot to upwards a little, since
this vault places multiple monsters in addition to the ghost.

For ebering_ghost_sewer_f, make some similar adjustments. Introduce more
monster variety and add some higher tiers of sewer guardians. Lower the
average number of monsters placed, since they're a bit nastier, but
randomize those numbers.

Finally, in both of these vaults, reorganize and reformat some DES
statements.

--------------------------------------------------------------------------------
7bfabb5 | gammafunk | 2018-06-24 16:50:59 -0500

Updates for ebering_ghost_xom
Instead of placing a dancing dagger with a random ego, place a dancing
weapon with a base type that scales with depth and always has the chaos
ego. Initially use lower base-damage weapons more commonly found early
on, slowly increasing the weapon quality. On each level, define up to
three sets of potential dancing weapons: a common class with default
weight, a somewhat higher damage/quality set of weapons with lower
weight, and at later depths introduce a set of rare weapons with lowest
weight. This should make fighting the weapon still potentially scary in
later depths as well as a loot item that's more rewarding. Finally, add
a "guarded" loot item under the ghost itself, since this ghost vault
only ever places one additional monster.

--------------------------------------------------------------------------------
30f0393 | gammafunk | 2018-06-24 16:50:13 -0500

Move a function to the ghost vault lua file and refactor
The random_item_def() function will likely be of use to vaults e.g. in
Vaults, so move this to ghost.lua and add documentation. Generalize the
"artefact" argument to just be an argument string, allowing callers to
set whatever additional item properties they want instead of just
good_item or randart.

--------------------------------------------------------------------------------
577b210 | Edgar A. Bering IV | 2018-06-23 23:33:14 -0500

Two sewer themed ghost vaults
Based on sewer entry vaults d and f, only place in D:3-6 where sewer
entries can spawn.

--------------------------------------------------------------------------------
9374e73 | Edgar A. Bering IV | 2018-06-23 23:33:14 -0500

Xom themed ghost vault
Has the player ghost, a Xom altar, and a dancing nice dagger which was
animated by Xom. A dancing dagger is only a bit tougher than a killer
bee, so shouldn't be too excessive, and it is good loot if defeated!

--------------------------------------------------------------------------------
6fc7002 | Edgar A. Bering IV | 2018-06-23 23:31:17 -0500

Reflecting pool ghost vault
Lone ghost with different decoration from the gravestone.

--------------------------------------------------------------------------------
617fbbe | Edgar A. Bering IV | 2018-06-23 23:31:13 -0500

Haunted rock garden ghost vault
This vault follows roughly the loot scaling of
gammafunk_ghost_gravestone with the large rock stack counting for one of
the "good items". This will make it appeal more to large rock throwers
and less to others, but that's fine.

--------------------------------------------------------------------------------
d3eb0d8 | Edgar A. Bering IV | 2018-06-23 23:12:42 -0500

Abstract loot scaling for single ghosts
Creates two lua functions for placing the "guarded" and "extra" loot in
a ghost vault that places a single ghost, for consistent scaling and to
make writing single-ghost vaults easier.

--------------------------------------------------------------------------------
ce4f928 | Chris Campbell | 2018-06-24 04:30:50 +0100

Fix a coding convention typo

--------------------------------------------------------------------------------
2d8cebb | Alan Malloy | 2018-06-23 15:05:06 -0700

Add Alcon to mailmap

--------------------------------------------------------------------------------
876ca31 | Alan Malloy | 2018-06-23 15:02:54 -0700

Add Alcon to CREDITS

--------------------------------------------------------------------------------
fbd9004 | jnooner | 2018-06-23 14:57:00 -0700

Fix a crash when blinking away a cleaving attacker (amalloy, #718)
When working through the list of enemies to cleave, we now check that each
enemy is still adjacent.
--------------------------------------------------------------------------------
a1b6296 | Edgar A. Bering IV | 2018-06-22 21:57:16 -0400

Have trees to block explosions (Reeces)
Trees are not walls, but often should be treated like them. In this
particular case they should block the explosion like all other
no_transparent opacity features. In particular this prevents LRD from
sneaking into places it shouldn't in certain edge-cases.

--------------------------------------------------------------------------------
c63589d | Edgar A. Bering IV | 2018-06-22 21:04:52 -0400

Don't treat trees as half-opaque for exclusions
Remove a vestige of the old behavior

--------------------------------------------------------------------------------
76cc104 | gammafunk | 2018-06-22 19:30:22 -0500

And icy themed ghost vault for Dungeon, Lair, and Depths (Biasface)
An icy cave filled with monsters with cold melee and ranged attacks. The
ghost spawns over a pre-type-identified ring of fire; sadly the fallen
player did not remember to remove their source of rF- in time. The ring
of fire eventually has a chance to be an artifact, with that chance
reaching 100% in the latest depths. The other loot is typical for other
ghost vaults, a progressive mix of superb_item and star_item. The
composition and number of icy monsters increases in difficulty with
depth.

Based on a vault idea submitted by Biasface.

--------------------------------------------------------------------------------
e9e9f76 | Chris Campbell | 2018-06-22 22:49:38 +0100

Remove veto_fragmentation, replace veto_disintegrate with veto_dig
Since LRD and disintegration no longer destroy walls.

--------------------------------------------------------------------------------
9b9f9d0 | Chris Campbell | 2018-06-22 22:49:38 +0100

Remove an unused param
Monsters no longer spawn from stairs, so stair_type was unused.

--------------------------------------------------------------------------------
bbb2ed9 | gammafunk | 2018-06-22 16:28:56 -0500

Merge pull request #795 from ebering/tweak-inner-flame-vault-pr
Remove flame clouds from inner flame vault (jboons)
--------------------------------------------------------------------------------
bbc7872 | Edgar A. Bering IV | 2018-06-22 17:09:53 -0400

Remove flame clouds from inner flame vault (jboons)
Ghosts and monsters were dying to them. Replaced with black smoke, which
gives similar flavor but without the monster deaths.

--------------------------------------------------------------------------------
4d20840 | gammafunk | 2018-06-21 16:49:15 -0500

An orcish armoury ghost vault for Dungeon and Orc (Biasface)
In biasface_ghost_orc_armoury, a player tried to raid an orcish armoury
and was overwhelmed by the defenses. Hopefully you can succeed where
they failed...just keep in mind that the player's ghost has joined
forces with the orcs in guarding the base.

The vault places melee orcs in substantial numbers, introducing a
smattering of orc priests after D:3. The ordinary orcs are reinforced
with warriors, knights, and a possible warlord in the latest depths. For
the top tier orc class used, one such monster will always have a fancy
weapon and armour (each either good_item or randart), and the additional
loot items are aux armour, general armour, weapon, and jewellery that
get progressively introduced and upgraded with good_item.

Biasface made the original vault submission. I made some slight layout
changes and added many of the item and monster progression details as
well as code support for setting equipment on the higher-level orcs.

--------------------------------------------------------------------------------
cd2a3d9 | gammafunk | 2018-06-21 16:49:12 -0500

Bug fixes and code generalizations for gammafunk_ghost_hdyra_chop
Generalize the random item definition code so that it can be used for a
forthcoming vault. Move the general parts to a new `random_item_def()`
function that allows specifying the item/ego weights as tables, with the
ego optional, as well as the separator to use in the definition. The
latter will allow is to use this in items in MONS statements. Simplify
the weighting used in this function when both items and egos are given
to simply multiply the weights together. A scaling factor is not
necessary if we compute the weights this way.

In the vault itself, fix the erroneous specification for long swords and
rename the function to use 'setup', since it's not initializing
anything.

--------------------------------------------------------------------------------
bf3ec1f | Chris Campbell | 2018-06-21 20:38:09 +0100

Add nlavsky to CREDITS.txt

--------------------------------------------------------------------------------
d75db79 | Chris Campbell | 2018-06-21 20:28:40 +0100

Merge pull request #777 from nlavsky/throw-ally-fix
Make Iron Giants and other Throw Ally users obey Sanctuary
--------------------------------------------------------------------------------
b6040eb | Chris Campbell | 2018-06-21 20:17:38 +0100

Merge pull request #776 from nlavsky/injury-bond-description
Fix Injury Bond description
--------------------------------------------------------------------------------
6e5688e | Muffindrake | 2018-06-21 11:13:13 -0700

Remove duplicate code for attack punctuation (#771)
Put the punctuation code into a function and remove exact duplicate used in a
different part of the code base.
--------------------------------------------------------------------------------
f69a080 | gammafunk | 2018-06-19 21:58:19 -0500

Updates to ebering_funeral_grove
Some significant modifications to the monster set for this this vault.
Spriggan druids don't work as well in Dungeon and Lair, since Awaken
Forest requires it to be hard to get away from trees (i.e. be in Swamp)
and Druid's Call needs most level monsters to be beasts (not the case in
Dungeon). Rework the monster list, retaining the spriggans that always
have polearms, but adding in some wolves/bears and eventually a boggart
to replace the spiritual role of the druid. Additionally always give one
spriggan an artefact spear or trident both as part of the loot and to
highlight the troubles of an unfortunate player stuck in tree form
versus a monster with a nasty reach attack. Initially use only ordinary
spriggans but later introduce spriggan riders. In Swamp we can use the
spriggan druid again and use 098 Swamp monsters instead of wolves/bears.
The final average amounts of loots and monsters are similar to the
numbers before these changes.

Also add better windows into this vault so that any wandering ghost can
always be seen, and generally simplify glyph usage and SUBST/NSUBST.
Move the decoration statements towards the end of the vault definition
where we customarily put these.

--------------------------------------------------------------------------------
c87f014 | gammafunk | 2018-06-19 21:53:51 -0500

Updates to ebering_ghost_inner_flame
Down-weight the vault in the earlier levels since it places 9 or 8, and
spruce up its loot a little in line with the potential threats it can
have. Also make it place at least one of either a chunk or a flame cloud
to avoid it placing none of either, which would make the theme less
clear. Finally, call the current ghost setup function instead of an old
one used in PR #700.

--------------------------------------------------------------------------------
52696f8 | Edgar A. Bering IV | 2018-06-19 21:17:27 -0500

Two item themed ghost vaults
ebering_ghost_inner_flame is a small 098 room that is blood splattered,
has flame clouds, and a guaranteed scroll of immolation.

ebering_ghost_funeral_grove is slightly larger, forest-themed guarded by some
spriggans plus the ghost. The vault always places a druid and a potion
of lignification, the druid watching over the poor dead treeformed
player.

Committer's Note: The vault ebering_ghost_funeral_grove is modified in a
subsequent commit to place a different set of monsters. Notably the
druid is only seen in the Swamp branch; see the comments in that
follow-up commit for details.

--------------------------------------------------------------------------------
01493d7 | gammafunk | 2018-06-19 16:57:11 -0500

A demon polymorph themed Depths ghost vault from Biasface
In this vault, the unfortunate player ghost hovers over a
(pre-identified) wand of polymorph, their final act having been an
attempt to polymorph a demon into something less threatening. Was it a
hellion? A tormentor?  Perhaps the player polymorphed a mere neqoxec to
avoid getting a **game-ending mutation**? Whatever their choice, the
untimely result was a tier 1 demon and, ultimately, a player ghost. The
vault also contains a few tier 2 demons (although no
tormentors/hellions) and a group of other common demons (tiers 3 and 4).

Changes from the original vault include a little vault surgery to make
the lava pool larger, more randomization to the composition of demons,
and randomization of the numbers and placement of demons. Loot is
adjusted to be roughly similar to what other ghost vaults give in
Depths. Also make the statue tiles a random assortment of demon-themed
ones.

--------------------------------------------------------------------------------
b137804 | advil | 2018-06-19 15:16:16 -0400

Add a targeter for wands of digging
This now shows you the exact range and path that will be affected by
digging, up to map knowledge. Two behavioral changes: 1. If you know
that it won't affect anything, it won't let you fire. 2. you can target
at any angle (previously, you could only move the targeting cursor on
squares that you could see).

As with recent passwall changes, this targeter can give you information
about the map bounds.

--------------------------------------------------------------------------------
9de5397 | advil | 2018-06-19 15:16:16 -0400

Add a wizmode command to completely wipe out the level map
For debugging info leaks; just forgetting isn't usually enough.

--------------------------------------------------------------------------------
0da5cb0 | gammafunk | 2018-06-19 12:06:41 -0500

Adjust the vault muffindrake_ghost_dead_mans_drink
Rename this vault to muffindrake_ghost_dead_mans_drink to keep vault
naming consistent. Add "portholes" (transparent stone) to some sides of
the vault so that the ghost can be seen from outside even if it wanders
into the back of the vault.

Add randomization to the kinds of derived undead used
in this vault and randomize the placement and numbers of monsters,
keeping the same average. Increase the loot a little to keep numbers
more in line with other Depths ghost vaults.

--------------------------------------------------------------------------------
2547c9b | gammafunk | 2018-06-19 12:06:41 -0500

Adjust the vault muffindrake_ghost_three_little_ghosts
Rename this vault to muffindrake_ghost_three_little_ghosts to be in line
with other vault name formatting. Don't use diggable rock in the walls
in the vault to prevent monsters digging out/in. Instead use
stone/crystal/iron progression to make the theme consistent, and since
crystal has a nice interaction with the room 2 monsters. Remove outer
glass, since vault already reveals each rooms contents as the player
progresses.

Use a shaman band in the first room instead of just a single
non-threatening deep troll. Add randomization to the types and numbers
of monsters in the remaining two rooms. Increase loot to be more in line
with what we place for other Depths ghost vaults.

--------------------------------------------------------------------------------
95e1b32 | gammafunk | 2018-06-19 12:06:41 -0500

Adjust the vault muffindrake_ghost_dual_entry
Rename this vault to muffindrake_ghost_dual_entry to be in line with our
other vault names. Add windows for the back of the vault and a dungeon
connector so that the player will always be able to inspect it and find
any ghost, if they so wish. Also down-weight the vault in its earlier
depths of D:10-11. Among ghost vaults it should be a less commonly seen
challenge, since it places two 8, a 9, and a lich, which is (almost)
guaranteed to overshadow the ghost itself.

Randomize the placement of the 1, 2, and 3 monsters, also randomizing
their placement numbers slightly but with the same average numbers.
Slightly increase loot quality by giving another superb_item instead of
gold.

--------------------------------------------------------------------------------
6ea8e7e | Muffindrake | 2018-06-19 12:06:41 -0500

Add four ghost vaults for mainly Depths
Committer's Note: Removed a vault from this commit that's not quite ready
for merging.

--------------------------------------------------------------------------------
bce20ac | floraline | 2018-06-19 12:37:34 -0400

Merge branch 'master' into webtiles-password-reset

--------------------------------------------------------------------------------
75794bf | advil | 2018-06-18 20:57:21 -0400

Make player ghosts non-recallable (Malacante)
Ideally they could be recalled if their vault is open, but there's no
way to do that that I know of.

--------------------------------------------------------------------------------
96ba041 | advil | 2018-06-18 16:43:22 -0400

Don't have ghosts teleport with health <50% on stairs
This is ancient behavior that is obsolete now that ghosts take stairs
normally.

--------------------------------------------------------------------------------
b939540 | advil | 2018-06-18 16:37:05 -0400

Update ghost annotations if you can see the ghost transiting
I missed this when removing the assumption that ghosts can't change
levels.

--------------------------------------------------------------------------------
0943f25 | gammafunk | 2018-06-17 16:03:24 -0500

Use the correct integer variable type
With advil's branch implementation (many thanks for that!), the
extension of the Vaults layout, and the previous set of vaults, we're
ready to merge the spooky_vaults branch. Closes #700.

--------------------------------------------------------------------------------
7f357de | gammafunk | 2018-06-17 15:48:43 -0500

Remove an unused error tracking variable

--------------------------------------------------------------------------------
1d9e83a | gammafunk | 2018-06-17 15:48:43 -0500

TAG MAJOR comment for Forest/Blade branch entries
These vault rooms were used to place Forest/Blade entries, but won't be
necessary with the next major version increase, since those branches no
longer exist.

--------------------------------------------------------------------------------
84fad1d | gammafunk | 2018-06-17 15:48:42 -0500

A ghost vault themed after Okawaru's wrath (hellmonk)
In gammafunk_ghost_fury_of_okawaru, the player finds a ghost on the
altar of Okawaru along with a bunch of representative Oka wrath monsters
and some loot. Although the generated ghost likely wasn't the result of
dying to "the Fury of Okawaru", hopefully this vault evokes the common
occurrence of players trying and failing to switch from Oka to another
god. It places in Dungeon, Orc, Vaults, Elf, and Crypt, and uses
warrior, archer, and giant monsters from Oka's wrath set. The Vaults
variant place through a separate vault room.

Original idea courtesy of hellmonk. Add new and exciting food costs.

--------------------------------------------------------------------------------
c41e3e3 | gammafunk | 2018-06-17 15:48:42 -0500

A hydra-themed ghost vault (mikee)
In gammafunk_ghost_hydra_chop, a fallen player made the mistake of using
a non-flaming edged weapon vs a hydra, leaving their ghost, the weapon,
and of course a hydra with more heads than usual. The weapon was not the
fallen player's actual weapon, but we can allow a little creative
fiction here, especially if the player was a felid!. We place only
weapon types usable by all non-felid species and always use a
non-flaming ego. There is a 1/3 chance for the weapon to be artefact.

The vault can also place a limited amount of additional loot and extra
hydras, scaling with depth, with the max possible hydra heads going as
high as 16 in late Swamp. Also places in D:8- and Lair.

--------------------------------------------------------------------------------
28d1087f | gammafunk | 2018-06-17 15:48:42 -0500

A ghost vault that places multiple ghosts
gammafunk_ghost_cemetery places 2-5 ghosts, with a 50% chance to place
only two and decreasing chances for each additional ghost, placing about
2.8 on average. Loot is 1.5 items per ghost with loot quality increasing
with depth. This vault places in all ghost vault branches, with half
weight in the very early dungeon levels and normal weight elsewhere. It
has a separate vault room for the Vaults branch as well.

--------------------------------------------------------------------------------
8f30707 | gammafunk | 2018-06-17 15:48:42 -0500

Some thematic ghost vaults
These vaults feature a few different specific themes and hence go in the
second section of ghost.des:

gammafunk_ghost_necromancy: Part one of a three part spooky ghost vault
sequence. Places derived undead from slightly later depth along with a
player ghost. Initially places skeletons and zombies, later replaces
skeletons with spectral monsters and simulacra, and finally only
spectrals and simulacra. In Crypt, Depths, and Zot we possibly throw in
lich and curse skulls/curse toes. Places in all branches that place
ghosts, using a separate vault room for Vaults.

gammafunk_ghost_spectres: Similar to the former vault, but using 'W'
monsters: the various types of ghosts, wraiths, and other spectres. This
one starts placement later, where wraiths would be not too out-of-depth,
since I didn't want to make an early variant featuring only phantoms and
hungry ghosts. Like the ghost_necromancy vault, places nasty undead
spellcasters in later branches. Places in D:8-, Vaults (through a
separate vault room), and Crypt.

gammafunk_ghost_ooze: A vault for D:8-, Lair, and Depths that always has
a Jiyva altar. From D:8 places slime creatures and jellies initially,
introducing death oozes from lair onwards.

gammafunk_ghost_mausoleum: A transporter vault that's nastier than the
previous two, placing general undead monsters from the relevant branch
with chances for some out-of-depth ones. Places in D:3-, Swamp, Crypt,
Depths, and Zot.

--------------------------------------------------------------------------------
6d380fd | gammafunk | 2018-06-17 15:48:41 -0500

A set of general ghost vaults
These vaults all have progressive loots and monsters, with the number of
monsters and number/quality of loot both increasing with depth.

gammafunk_ghost_grave: A runed door vault with a ghost near a grave and
a small number of loot items, scaling up to three.

gammafunk_ghost_split: A runed door vault with a ghost and 0, 9, and 8
monsters. In earliest depths there is only a chance for a single 9, and
later the proportion of 8 and 9 compared to normal spawn 0 monsters
increases.

gammafunk_ghost_arena: A transporter vault with a ghost and 0, 9, and 8
monsters. Similar concept to the ghost_split vault above, but somewhat
harder due to being in a transporter. It scales up to higher numbers of
monsters an loot, so it will be fairly dangerous, yet more rewarding.

The first two vaults have vault room variants adapted for the Vaults
branch.

--------------------------------------------------------------------------------
c69a6cf | gammafunk | 2018-06-17 15:48:41 -0500

Some ghost vaults for the Vaults branch
Update the quick ghost vaults advil made as vault rooms. I've made them
place a bigger variety of the Vaults-specific monsters and standardized
the loot to be more in line with the other (forthcoming) ghost vaults.
Their names have been update to include advil's name and to follow a
standard naming convention.

--------------------------------------------------------------------------------
a2df02c | gammafunk | 2018-06-17 15:48:26 -0500

Update ghost vault guidelines
Mention the necessary ghost vault setup functions and update the
guidelines with more specific advice about ghost visibly, wall type
usage, and loot.

--------------------------------------------------------------------------------
99b25f0 | gammafunk | 2018-06-17 15:37:08 -0500

Extend the Vaults layout to place ghost vault rooms
Vault rooms placing ghosts should now set a `vaults_ghost` tag to be
selected as part of the chance for each level to have a ghost vault. The
Vaults layout rolls based on the chance value in dat/dlua/ghost.lua and
selects from rooms with the vaults_ghost tag. Vault rooms that place
ghosts should call the function vaults_ghost_setup() to set this and
other tags we want all ghost vaults to have.

--------------------------------------------------------------------------------
30c74a2 | gammafunk | 2018-06-17 15:37:08 -0500

Ghost vault functions and ghost DES file cleanup
Add some lua vault setup functions to set tags we'll always need for
ghost vaults and set the common ghost vault CHANCE value. For branches
other than Vaults, a ghost vault makes a call like:

``` : ghost_setup(G_) ```

Ghost vault rooms in the Vaults branch instead call
`vaults_ghost_setup(G_)`, which sets a `vaults_ghost` tag recognized by
the Vaults layout. Support for this will be added in a subsequent
commit.

This commit also organizes ghost.des into sections for future vaults and
removes the initial set of test vaults made by advil; those will
reappear in a subsequent commit, where they'll be revamped.

--------------------------------------------------------------------------------
9e38d4b | gammafunk | 2018-06-16 23:26:18 -0500

Reformat vault guidelines
Use proper subheaders instead of just bold text, and use code blocks for
DES examples.

--------------------------------------------------------------------------------
b611b69 | advil | 2018-06-16 23:26:18 -0500

Make bones file resolution coarser (first pass)
On the old ghost system, there was one bones file per level. Players die
at very different rates across the dungeon, but this worked fine,
because that just led to lower likelihood of ghosts in some places. In
the new system, since we're trying to have ghost generation rates
entirely determined by vault placement, this becomes problematic; for
example so far in the entire 0.21 cycle there is been exactly one death
in Geh:5, so it makes absolutely no sense for this level to have its own
bones file and permastore.

This commit tries to solve this problem by (i) mostly not having
per-level permastores (as of this change, only dungeon and lair do),
(ii) in some cases not having per-level bones files (though most of
these don't generate ghosts right now), and (iii) grouping all hells
together for both bones files and permastores, since even
per-hell-branch the death rate is extremely low (just 43 in 0.21 in Geh,
for example, only 11 of which even occurred in the first two weeks of
release -- barely enough to fill a permastore at current rates).

This may need a bunch more tweaking, and it may be worth considering
whether dungeon region is the right way to organize bones files at all
(alternative: xl, with some kind of subdivision for xl27).

(n.b. I wish bones data was in an sqlite db, not a bunch of files, but I
think this is unfortunately not practical to consider right now.)

--------------------------------------------------------------------------------
e1a807f | advil | 2018-06-16 23:26:18 -0500

Don't allow undead mirrored ghosts
This just converts them to human.

--------------------------------------------------------------------------------
3ff1096 | advil | 2018-06-16 23:26:18 -0500

Clean up bones file debugging messaging
This centralizes all the complicated #define conditioning in one place,
so it's a lot easier to figure out what's going on, and hopefully this
will minimize accidental compiler warnings. This relies on a fairly
hacky unwind in one place, though.

This is all a bit complicated because one wants these messages to show
in wizmode on a server, which won't ever have a debug build.

--------------------------------------------------------------------------------
f886858 | advil | 2018-06-16 23:26:18 -0500

Don't crash on mprf while loading ghosts
Somehow this is a distant side effect of mprf. (prepare_message =>
silenced => _update_agrid => _actor_areas => monster::halo_radius =>
monster::holiness => monster::has_attack_flavour)

--------------------------------------------------------------------------------
45f54b8 | advil | 2018-06-16 23:26:18 -0500

Lower ghost chances even more
In practice, the old 33% chance provides just an upper bound on
placement probability, because bones files can be empty. It's hard to
estimate, but I suspect from inspecting bones files from a live server,
that the probability of generating a ghost is (on average) usually quite
a bit lower, subject to a lot of variability due to server conditions.
Since the chances of ghost vault generation now are much closer to an
exact probability, they need to be lowered. For now, something like 10%
seems reasonable to me; in a 3 rune game this means maybe 4 ghost vaults
on average.

--------------------------------------------------------------------------------
0683b26 | advil | 2018-06-16 23:26:17 -0500

Draft some design guidelines for ghost vaults
[skip ci]

--------------------------------------------------------------------------------
72bd907 | advil | 2018-06-16 23:26:17 -0500

Improve (old) variable names

--------------------------------------------------------------------------------
7b7af9e | advil | 2018-06-16 23:26:17 -0500

Various vault adjustments based on feedback
Possibly these still drop too much loot.

--------------------------------------------------------------------------------
397a453 | advil | 2018-06-16 23:26:17 -0500

Use CHANCE rather than WEIGHT for non-Vaults ghost vaults
This is more accurate. Also reduce the chance somewhat.

--------------------------------------------------------------------------------
d5aaa04 | advil | 2018-06-16 23:26:17 -0500

Let ghosts use stairs
If they are all generated in sealed vaults that a player can chose to
open, letting them be able to use stairs seems much more reasonable.
(That behavior restriction is a very blunt instrument for balancing, in
any case.)

--------------------------------------------------------------------------------
46a0957 | advil | 2018-06-16 23:26:17 -0500

Don't spawn randomly-placed ghosts on level generation
With this change, all ghost placement is done by vaults.

--------------------------------------------------------------------------------
30d8ac5 | advil | 2018-06-16 23:26:17 -0500

Tweak ghost vault generation rates
This is aiming for a 1/3 chance of generation, following the old ghost
placement rates.

--------------------------------------------------------------------------------
0f524d8 | advil | 2018-06-16 23:26:17 -0500

Don't use permastore when rewriting on level veto

--------------------------------------------------------------------------------
9478639 | advil | 2018-06-16 23:26:17 -0500

Add a permanent store for some fallback ghosts
This addition is to deal with the question of how to place a ghost vault
if there are no bones files: basically, always try to keep around some
ghosts to use, rather than deleting all of them all the time. If this
idea works out, we may want to pre-seed download versions with some
sanitized ghosts.  This randomizes names saved in the permastore for
online play, but doesn't for offline play.

--------------------------------------------------------------------------------
a8b80c1 | advil | 2018-06-16 23:26:17 -0500

Add a description line for mirrored player ghosts
These won't be the norm, but I anticipate keeping them around as an
emergency fallback. (They could be fun to very occasionally generate on
purpose.)

--------------------------------------------------------------------------------
a3c4442 | advil | 2018-06-16 23:26:17 -0500

Add some ghost mini-vaults that will place in Vaults
Still pretty basic, I don't know much about vault design. The weights
might need rethinking, still.

--------------------------------------------------------------------------------
ce72dfe | advil | 2018-06-16 23:26:17 -0500

Allow ghosts built from bones files to be placed in vaults
This commit is the first proof-of-concept for a potential overhaul of
the player ghost system that places ghosts only in sealed
(runed/transporter) vaults. Specifically, vaults will accept "player
ghost" as a monster name, and on getting this description will
try to load a ghost from a bones file for the level being generated. If
there is no bones file, it falls back on making a ghost based on the
player; this is a placeholder for something better.

This idea tries to balance the flavor value of ghosts with the many ways
in which they are problematic; ghosts in vaults like those in this
commit are entirely optional.  (This commit doesn't disable normal ghost
generation.)

One glaring issue: how to control the distribution of these vaults? Both
of the vaults in this commit place a minimum good item, so having them
as frequently as current ghosts might be too much (possibly the items
should be toned down). With the current (absurd) weight they still don't
generate all that often; possibly a WEIGHT setting isn't the right way
to do this for these particular vaults.

--------------------------------------------------------------------------------
76e0a5f | Aidan Holm | 2018-06-17 00:51:53 +0800

Only show uncursed worn rings on ring swap menu
Previously, this menu would show all jewellery the user was carrying,
whether worn or not, including amulets.

--------------------------------------------------------------------------------
5591a09 | Aidan Holm | 2018-06-17 00:12:31 +0800

Remove quotes from tutorial lesson descriptions

--------------------------------------------------------------------------------
991dd4b | Aidan Holm | 2018-06-14 13:58:34 +0800

Fix webtiles lobby flash-of-unstyled-content
This prevents the popup box template from briefly being visible while
the CSS file (that includes a rule to hide .templates) is loading.

--------------------------------------------------------------------------------
c6e99f3 | gammafunk | 2018-06-13 17:00:57 -0500

Merge pull request #788 from NormalPerson7/fix-temple-vault
Fix some floor tiles in pf_slime_end_temple
--------------------------------------------------------------------------------
516f575 | gammafunk | 2018-06-13 17:00:20 -0500

Merge pull request #787 from ebering/des-syntax-pr
Document glyph default behavior in .des
--------------------------------------------------------------------------------
2526e47 | NormalPerson7 | 2018-06-13 20:47:51 +0100

Fix pf_slime_end_temple
Previously this would place erroneous floor tiles on some altars,
because it was missing B in the FTILE assignment.
--------------------------------------------------------------------------------
ce5a547 | Edgar A. Bering IV | 2018-06-13 14:57:25 -0400

Document glyph default behavior in .des

--------------------------------------------------------------------------------
c1e5224 | floraline | 2018-06-13 13:44:58 -0400

Merge branch 'master' into webtiles-password-reset

--------------------------------------------------------------------------------
101988f | Aidan Holm | 2018-06-14 01:30:35 +0800

Add static files for CBRO ui-overhaul experimental
These changes are cherry-picked off the ui-overhaul branch (and modified
slightly to avoid affecting the lobby page). They shouldn't have any
effect on games outside of an ui-overhaul experimental, and will
eventually be superseded when ui-overhaul is merged.

--------------------------------------------------------------------------------
19b682e | advil | 2018-06-13 09:50:06 -0600

Replace remaining uses of `*map_find` with explicit ASSERTs
`*map_find` is highly dubious, because it assumes that the relevant map
is complete with respect to some enum (usually under some specific
assumptions), and none of the uses were plausibly cases where this is
just going to automatically be fine in the long run.  This change
converts the checking of that assumption to an explicit ASSERT, rather
than a segfault.

--------------------------------------------------------------------------------
bd48a76 | advil | 2018-06-13 09:29:38 -0600

Set player as summoner for elemental force
I'm not sure why this wasn't done in the first place, and there may be
some reason I'm not thinking about. But the immediate impact of this
commit is to prevent elemental force from placing tloc clouds when used
in abyss, since this is the wrong flavor.

--------------------------------------------------------------------------------
632a1ea | advil | 2018-06-13 09:27:52 -0600

Don't overwrite opaque clouds with non-opaque clouds
This will come up mostly for tloc clouds, I think.

--------------------------------------------------------------------------------
e4f624a | advil | 2018-06-13 09:27:52 -0600

Don't assume elemental force placement doesn't change clouds
This code assumed that the values returned by `cloud_at` were unchanged
from the first pass to all points of the second pass. However, in the
abyss, placement of elementals was also adding tloc clouds, which are
not in the map, and therefore `*map_find` was not safe. This could cause
crashes, which were relatively reliably triggered by reading summoning,
fog, and triggering elemental force in succession. (I think the impact
of summoning was just to get a crowd of already placed monsters around,
though I didn't test carefully why this mattered.)

--------------------------------------------------------------------------------
522be1c | advil | 2018-06-13 08:35:55 -0600

Let `user_settings` be determined automatically
So that a manual config.py change isn't required. This will by default
use the same location as password_db.

--------------------------------------------------------------------------------
ecf68fc | floraline | 2018-06-11 17:52:08 -0400

Report invalid recovery token before showing form
This way the user won't be prompted to enter a password
before finding out that their token is invalid.

--------------------------------------------------------------------------------
bff803d | floraline | 2018-06-11 16:11:37 -0400

Extract function for recovery token lookup

--------------------------------------------------------------------------------
3de9d90 | floraline | 2018-06-11 16:06:09 -0400

Disallow password reset if feature is disabled

--------------------------------------------------------------------------------
3951a75 | floraline | 2018-06-10 14:58:25 -0400

Merge branch 'master' into webtiles-password-reset

--------------------------------------------------------------------------------
de97b25 | floraline | 2018-06-10 14:50:23 -0400

Move recovery tokens into separate table
This allows us to create multiple tokens for each
user, so recovery links won't become invalid if the
user gets impatient and makes multiple requests.

We also check to see if the token is expired
in order to return a more useful error message.

--------------------------------------------------------------------------------
f26638a | Aidan Holm | 2018-06-11 02:25:50 +0800

Reorder M&F and Axes on skill menu (Arrhythmia)
Tavern post: https://crawl.develz.org/tavern/viewtopic.php?f=8&t=25476

This makes the menu order consistent with the crosstraining cycle, as
well as with the aptitudes table columns.

--------------------------------------------------------------------------------
e4a679f | Edgar A. Bering IV | 2018-06-10 15:27:03 +0800

Clean up uses of unique_ptrs
operator bool and operator* allow a lot of superflous .get() calls to be
removed, as well as a few ASSERTs that will never trigger and some
braces.

--------------------------------------------------------------------------------
2c2b542 | floraline | 2018-06-10 02:58:09 -0400

Remove debug sql script

--------------------------------------------------------------------------------
22b321e | floraline | 2018-06-10 02:19:04 -0400

Add email address regex validation
This is a very simple regex validation used by the
registration and forgot password forms. It only checks
for basic mistakes when inputting an email address.
The proper way to validate email addresses would be to
send a validation email.

Also adds a warning to the registration screen
indicating that an email is required in order to
perform a password recovery.

--------------------------------------------------------------------------------
d74e810 | floraline | 2018-06-10 01:47:21 -0400

Remove debug text

--------------------------------------------------------------------------------
58cd727 | floraline | 2018-06-10 01:41:21 -0400

Automatically upgrade db where columns are missing
When the server is started, we will automatically upgrade
the database in the event that one already exists but is
missing necessary fields.

This function is intended only to add things like new columns
and tables, which can be added to an existing database without
re-creating it.

--------------------------------------------------------------------------------
cc00237 | floraline | 2018-06-10 01:02:50 -0400

Merge branch 'master' into webtiles-password-reset

--------------------------------------------------------------------------------
06be723 | floraline | 2018-06-10 00:57:50 -0400

Automatically upgrade user db on startup
I am giving meaning to sqlite's user_version here.
It is assumed that existing databases will have a
value of zero, and a value of one will indicate that
the database is ready for the password recovery
feature.

Future changes to the database could take advantage
of this function to further upgrade existing
databases. And a database that is very out of date
could potentially go through multiple upgrades
at once!

--------------------------------------------------------------------------------
d338dc9 | floraline | 2018-06-09 18:54:46 -0400

Hide recovery dialog if recovery is not enabled
This prevents a user from following a recovery link
in their email and attempting to reset their password
if password recovery has been disabled.

--------------------------------------------------------------------------------
df0964f | floraline | 2018-06-09 18:20:26 -0400

Move boilerplate SMTP code into helper function
By extracting the SMTP function calls into a separate function,
we simplify the business logic and make it easier to maintain.
This also enables us to easily change the way emails are sent,
such as queuing them for sending by another application.

--------------------------------------------------------------------------------
fe6c23a | floraline | 2018-06-09 17:42:22 -0400

Enhance emails sent for password recovery
By sending a multipart mime message, we can include an HTML version
of the message that allows the user to click on the links directly.
This has an added benefit of helping the email appear more legitimate
to other email servers.

This commit also adds a subject line and proper cleanup of the
email server object.

--------------------------------------------------------------------------------
cd0a981 | floraline | 2018-06-09 16:40:18 -0400

Use CSPRNG urandom to generate the password reset token

--------------------------------------------------------------------------------
5c5de1c | advil | 2018-06-09 16:28:21 -0400

Let ArmourOffDelay be invalidated for undefined items (11494)
This can apparently happen (rarely) in local tiles if mouse clicks pile
up extremely fast, leading to an ArmourOffDely -> DropItemDelay ->
ArmourOffDelay -> DropItemDelay sequence for the same item. Since the
item starts off as an inventory item, they all use the same reference
for the item, but dropping invalidates the item (see
`items.cc:dec_inv_item_quantity`), it is no longer a reference to a
valid item after the first drop, leading to a crash.  DropItemDelay
already handled invalid items.

It might also be good to have drop_item just abort if there's already a
DropItemDelay scheduled for the item in question, but that's somewhat
tricky to do technically, since both item drop delays actually call
drop_item. This safety check for ArmourOffDelay still seems reasonable
anyways.

--------------------------------------------------------------------------------
b7c2d6f | floraline | 2018-06-09 16:18:46 -0400

Merged master into working branch

--------------------------------------------------------------------------------
caf04df | advil | 2018-06-09 14:17:00 -0400

Show mute status in spectator list

--------------------------------------------------------------------------------
2dae380 | advil | 2018-06-09 14:17:00 -0400

Add a way of minimizing and hiding the chat window
This adds a third mode to the chat window: it can be minimized into a
small box with just a `+` that does not visually change with chat state,
in case (for any number of reasons) a player doesn't want to be
distracted by chat. The window can be restored by clicking the +, or by
hitting F12.

There's also a slightly hidden mode that really gets rid of chat, aimed
at streamers who are currently just doing this with browser dev tools.
To get this, type `/hide forever` in the chat window. To get it back,
you will need to reload, or log out and in.  When a user types "/hide
forever" this will also hide their name from the spectator view in the
chat window (basically the same behavior as a console spectator or
viewer).  Should this instead do something like "n hidden"?

None of this state is saved, although it could be if there's demand for
that.

--------------------------------------------------------------------------------
56e49a4 | advil | 2018-06-09 14:17:00 -0400

Add an `/unmute *` command, /help, misc cleanups
Intentionally making it easier to clear than to add to mute lists.

--------------------------------------------------------------------------------
94a6f44 | advil | 2018-06-09 14:17:00 -0400

Implement mutelist saving with a server-side sqlite db
This implements per-user saving of mutelists across sessions.  Because
I'm paranoid, I used a separate database from the password database;
perhaps this is overkill. Part of my concern is that the password
database is shared with dgl, and I just didn't want to have to worry
about what dgl might do.

--------------------------------------------------------------------------------
186421b | advil | 2018-06-09 14:17:00 -0400

Proof of concept implementation of server-side tileschat mute
This implements per-process muting for tileschat in the webserver. There
are three commands, "/mute", "/unmute", and "/mutelist"; only the player
can use any of these commands. Right now this doesn't save at all, so
would need to be reconstructed on every save/reload. It's just a first
pass / thought experiment in how better tileschat controls could be
implemented, so more work would be needed before merging. There's no
indication to anyone except the player who is muted, which might be good
to have.

I'm not sure this is the best way to do it, especially for a quick fix
for spamming. In ##crawl-dev gammafunk and I discussed an alternative
that would be client-side, per-user (instead of for the whole channel),
and saved in a cookie, which could be better, and wouldn't require any
server updates. (It might be possible to adapt the cookie saving idea to
the current commit.)

--------------------------------------------------------------------------------
bd68aaf | shieldal | 2018-06-09 14:02:06 -0400

Fix grammar in Zin's laws description (0011491)

--------------------------------------------------------------------------------
c2a7574 | floraline | 2018-06-09 02:19:05 -0400

Adds DB changes required for password reset feature

--------------------------------------------------------------------------------
98963a9 | floraline | 2018-06-09 01:39:54 -0400

Adds password reset token which allows a user to enter a new password for their 
account. The password reset email will now include this token. This commit adds 
another required config item for the password reset feature.

--------------------------------------------------------------------------------
552bd0d | floraline | 2018-06-08 21:34:49 -0400

Adds config values for password reset feature. Admin can turn this feature on 
or off, SMTP config is required for this to be used.

--------------------------------------------------------------------------------
4c2974a | floraline | 2018-06-08 21:08:59 -0400

Added Forgot Password link to allow users to request an email to reset their 
password. This is the first half of this implementation, still needs email 
config and reset link.

--------------------------------------------------------------------------------
49b1da7 | advil | 2018-06-08 16:07:07 -0400

Add command sequences to the front of the buffer for crawl.do_commands
I think this will finally fix 11489 and related bugs. The basic problem
here is that in all attempts at dealing with this before,
crawl.do_commands has potentially separated the first element of the
sequence from the remainder by pushing the remainder of the sequence to
the back of the macro buffer (either the sendkeys buffer in the original
version and 3f858e37d316, or the regular buffer in d5c8bedc332) and
triggering the first command immediately. If multiple input keys happen
very fast, there could be intervening keys at the front of the buffer
when the first command is triggered. For autofight, the primary (only?)
use of crawl.do_commands, this sometimes resulted in targeting commands
in the wrong context, depending on the key.

This behavior could happen in online play with lag or network
randomness, and I recently discovered it could also be triggered in
offline play by e.g. binding the macro sequence `\{9}\{27}` to a key.

This change pushes the remainder of the sequence to the front of the
regular macro buffer, which guarantees that they won't be separated. The
problem that was causing in crashes in d5c8bedc332 won't apply, since it
was an ASSERT that only triggers on pushing to the back of the regular
macro buffer.  This fixes some other weird behavior introduced in
461d14e83c155adf, such as making it impossible to put tab in a macro
with other keys; that commit in general probably produced errors in more
places than the previous versions.

I did not yet change crawl.process_keys similarly, but this maybe should
be done.

--------------------------------------------------------------------------------
fc9006d | Alex Jurkiewicz | 2018-06-09 00:35:26 +0800

Add error output to unbrace
Changes the output of `util/unbrace -n` so it's informative for new
contributors.

--------------------------------------------------------------------------------
c254099 | Nikolai Lavsky | 2018-06-08 13:45:48 +0300

Make Iron Giants and other Throw Ally users obey Sanctuary
Iron Giants can throw monsters at the player protected by Sanctuary.
They can do up to 35 damage (random2(HD*2)) per throw without angering
Zin. Originally Throw Ally was a Robin-exclusive ability, so this was
not a problem.

Normally monsters don't use abilities that can harm the player, if the
player is in sanctuary. These checks are done in
mon-cast.cc:_ms_waste_of_time(). But for spell_harms_target()
Throw Ally is not a harmful ability. This is because the ability
doesn't have a SPFLAG_TARGETING_MASK flag (either SPFLAG_DIR_OR_TARGET
or SPFLAG_TARGET). Since Throw Ally is a smite-targeted ability, the
appropriate flag for it is SPFLAG_TARGET.

--------------------------------------------------------------------------------
b446440 | advil | 2018-06-07 17:49:45 -0400

Fix (un)woken_rest.rc
This entomb function didn't work right because it changed the player's
location to a metal wall, which teleported them away.

--------------------------------------------------------------------------------
461d14e | advil | 2018-06-07 16:05:34 -0400

Don't allow crawl.process_keys or crawl.do_commands with pending input
Each of these lua calls pushes a sequence into the sendkeys buffer, and
immediately triggers the first member of the sequence. If there's
anything else in either pending input buffer, (a) it should presumably
have priority over new commands, and (b) the remainder of the sequence
(if there is one) will get separated from the initial one.

For sequences of keys that don't obey this constraint, then
crawl.sendkeys is the correct call, it will add things to the back of
the buffer only. There is apparently no equivalent call for commands,
but it could be added if necessary.

--------------------------------------------------------------------------------
49d386f | Nikolai Lavsky | 2018-06-07 22:01:03 +0300

Fix Injury Bond description
Injury Bond affects all allies in LOS, not just one.

--------------------------------------------------------------------------------
11ed031 | gammafunk | 2018-06-05 08:08:25 -0500

Fix glyph usage in two temple entrances (Reeces)
Due to a missing substitution, temple_doors_ab would sometimes place a
large number of random altars instead of placing stone or rock wall as
intended. Fix this, and also add a connecter on the right side of this
vault and temple_doors_cd for the cases when these vault sections are
not trimmed. This will prevent the resulting passage from simply running
into a wall.

--------------------------------------------------------------------------------
a0624bf | Chris Campbell | 2018-06-04 16:43:11 +0100

Update some more glyphs in the manual

--------------------------------------------------------------------------------
14ec769 | NormalPerson7 | 2018-06-04 16:27:55 +0100

Remove some obsolete references to rods

--------------------------------------------------------------------------------
7d3bdab | NormalPerson7 | 2018-06-04 16:27:55 +0100

Escape the | character in crawl-manual.rst to fix some formatting

--------------------------------------------------------------------------------
bef45da | Chris Campbell | 2018-06-04 16:21:06 +0100

Merge pull request #722 from dplusplus/fix_help
fix help; "stick" tag is not available in current version
--------------------------------------------------------------------------------
8c5347a | Chris Campbell | 2018-06-04 16:07:22 +0100

Merge pull request #767 from ebering/vd-full-health-prompt
Abort Vampiric Draining at full health
--------------------------------------------------------------------------------
1fb7470 | advil | 2018-06-03 10:13:20 -0400

Quiet some gcc-specific shadow warnings on tiles builds
gcc (but not clang) warns if a local variable shadows a member function.
This is probably a bit overenthusiastic of gcc, but it doesn't hurt to
get back to warning-free compilation.

--------------------------------------------------------------------------------
ee5f723 | advil | 2018-06-02 17:00:16 -0400

Use positive -W flags to check for compiler compatibility
This is because gcc will only emit a warning for unknown negative
(`-Wno-foo`) warning flags if there are other warnings/errors that show
up. However, both gcc and clang guarantee a positive and a negative form
for all warning flags, so it should be safe to test the positive form
(-Wfoo), which will trigger a message from gcc if unknown.

--------------------------------------------------------------------------------
37d83ea | gammafunk | 2018-06-02 11:32:07 -0500

Make Lee's Rapid Deconstruction never break walls
This commit removes the ability of LRD to break any type of wall. No
changes are made to the types of walls or monsters that LRD can target
nor to how damaging the LRD fragments are.

LRD provided access to infinite digging and wall destruction without
requiring much training, especially if enhancers were used. We'd like to
make access to digging relatively limited since infinite digging
encourages the player to carefully and tediously dig out paths that are
ideal for luring and killing monsters. LRD's destruction of
stone/metal/crystal walls also made it too easy for the player to bypass
the intended entry of many vaults. The Shatter spell allows some of
these things, but it requires far more investment to be castable.

The wand of digging, Shatter spell, and other species/god abilities
collectively do a good job of providing the player with forms of wall
destruction or movement. LRD without wall destruction is still a very
strong spell and remains a fairly complicated one due to all of its wall
type and monster type interactions.

--------------------------------------------------------------------------------
8c8ef71 | advil | 2018-06-01 12:06:05 -0400

Fix webtiles status artifacts due to custom status light code (11488)
When a duration was immediately followed in duration_type by a duration
that has some custom webtiles code in tileweb.cc:_update_statuses, the
status_info wouldn't be fully reset for the custom status; I'm not sure
if this had any noticeable effects beyond the acrobat case, but this
would've bitten someone eventually (it's more or less by accident that
divine shield follows divine stamina, so one couldn't have both at the
same time).  For acrobat in particular, 8519d868e99a introduced a check
that was missing a continue, meaning that recite cooldown (the next
duration in the enum) would show up twice if acrobat was not active.

This also replaces a janky static reset function for status_info with a
proper constructor that actually guarantees the int is initialized, and
switches unnecessary pointer uses of status_info to references.

--------------------------------------------------------------------------------
9e76084 | Edgar A. Bering IV | 2018-06-01 05:47:39 -0500

Make splash_gauntlet patrolling, add bog bodies
The splash_gauntlet loses its 'run the gauntlet' theme if the monsters
wander off and it's just a lone electric eel. Added bog bodies to the
monster mix and the patrolling flag to the vault.

The weight preserves the expected number of monsters at 4 + maybe the
eel, which might be too heavy with patrolling.

Committer's Note: Squashed a previous commit that was reverted and
updated commit message accordingly. Closes #763.

--------------------------------------------------------------------------------
17c3723 | gammafunk | 2018-05-30 07:15:45 -0500

Merge pull request #762 from ebering/arrival-vault-pr
A knot of arrival vaults.
--------------------------------------------------------------------------------
cf5b0c6 | gammafunk | 2018-05-29 07:24:02 -0500

Merge pull request #769 from ebering/uskayaw-stomp-descript
Correct Usk stomp description
--------------------------------------------------------------------------------
20ad6ec | Edgar A. Bering IV | 2018-05-28 18:12:24 -0400

Correct Usk stomp description

--------------------------------------------------------------------------------
ac93bac | gammafunk | 2018-05-28 16:58:50 -0500

Update an ice cave transporter vault
Rename this vault to ice_cave_statue_garden_transporter. The teleporter
feature is no more, so having this in the vault name is confusing.

Also remove no_tele_into from the second chamber. This wasn't ever
necessary, since both chambers have exits. It's also spoilery that
reading teleport in the second chamber always took the player to the
first chamber.

To allow the player to return to the first chamber should they have
forgotten something there, make a return transporter in the second
chamber that's only reachable from the loot area. Simplify glyph usage
now that distinct glyphs aren't needed for no_tele_into purposes.

--------------------------------------------------------------------------------
90f0736 | gammafunk | 2018-05-28 16:58:50 -0500

Mark an unused feature tile for removal after major version change

--------------------------------------------------------------------------------
7c5a50c | gammafunk | 2018-05-28 16:58:44 -0500

Reindent a lua function

--------------------------------------------------------------------------------
04e6133 | gammafunk | 2018-05-28 16:55:36 -0500

Move some unused lua code to the save compat DES file
When these functions were deprecated, I kept them in their original
files with a TAG_MAJOR comment. Some save compat testing I did seemed to
show that they would only properly be seen when found in the original
DES file. However it's awkward having these functions lie around in
their original files, and it's been about 1.5 releases since the
functions were deprecated. The vast majority of games that might have
needed the save compat functions are finished by now, and any errors
will not be game-breaking. If we do see any live save compat errors due
to the functions being moved to compat.des, we can possibly get a copy
of the save and do some troubleshooting to look into why the functions
aren't loading.

--------------------------------------------------------------------------------
04dac39 | Edgar A. Bering IV | 2018-05-28 03:14:09 -0500

Update old glyph sets for teleporter->transporter
DEC/IBM now re-glyph transporters to use the teleporter glyph.
old_unicode already used © for teleporters, so the line is deleted.

Committer's Note: Closes #765.

--------------------------------------------------------------------------------
b72857b | Edgar A. Bering IV | 2018-05-26 18:12:55 -0500

Update options_guide.txt for teleporter->transporter
The option display_char no longer cares about teleporter and now takes
transporter and transporter_landing.

--------------------------------------------------------------------------------
d2a9cce | advil | 2018-05-26 16:41:10 -0400

Explicitly store version history in the save file as a prop
This can usually be reconstructed from the morgue, if the morgue is
available, but sometimes it's not, and it can be really annoying not to
have this info.

--------------------------------------------------------------------------------
10d5862 | advil | 2018-05-26 10:16:39 -0400

Fix shopping list crashes from multiple items with the same name
Mainly happening when trying to remove spellbooks from the shopping
list.  It was possible to get multiple items with the same name on the
shopping list, which would then (depending on iterator order) lead to
crashes if they were removed. All of the find/delete code behaved
unreliably in this case, because it worked by getting the first index by
name, which may not actually match up to the `thing` that was passed in,
and so the removal order didn't match up with the iterator order.  This
change generalizes these bits of the shopping list code to not assume
that there will be single items associated with any name-level pair.
This fix is more of a patch than a complete fix, because:

1. The level_pos checks in this code seem to be still unreliable in ways
   I haven't fully tracked down yet.
2. Reading the code, it was supposed to be impossible to have multiple
   items with the same name, but the checks for this are hopelessly
   broken (as far as I can tell), and probably undesireable anyways.
3. It seems to me that associating shopping list items with level ids,
   rather than particular shops, is just a fundamental design flaw that
   makes it impossible to uniquely associate shopping list entries with
   actual particular items in the game. This will need more of a rewrite
   to fix, though.

--------------------------------------------------------------------------------
925dece | advil | 2018-05-26 10:16:24 -0400

unbrace

--------------------------------------------------------------------------------
74ca774 | Edgar A. Bering IV | 2018-05-25 16:53:53 -0400

Abort Vampiric Draining at full health
The spell will have no effect so don't waste a turn and mp casting it.

--------------------------------------------------------------------------------
6609fc6 | advil | 2018-05-25 14:24:28 -0400

Quiet some gcc warnings (NP7)

--------------------------------------------------------------------------------
97ce8ef | advil | 2018-05-24 16:33:16 -0400

Tweak wall jump messaging

--------------------------------------------------------------------------------
e766b1c | advil | 2018-05-24 16:31:03 -0400

Automatically retract mandibles if wall jump is triggered as an ability

--------------------------------------------------------------------------------
154e428 | advil | 2018-05-24 15:36:58 -0400

Tweak passwall range/power
Because spell range is always capped by your current vision range in
`spell_range`, and passwall range was set to 9, passwall spellpower had
a weird interaction where range capped out way before spellpower (at 140
spellpower; would be higher on a Ba I guess). It was also one of those
spells where max spellpower was impossible anyways (e.g. 27/27/27 int 50
still didn't do it).  This change makes it so that max spellpower = max
range (now 7, the practical range for most non-Ba before), with max
spellpower adjusted down slightly (120) from where the previous actual
cap was, though it's still extremely implausible to get.

This commit more or less maintains the status quo with more meaningful
spellpower; I'm not really opposed gameplay-wise to longer passwalls
being possible, but this would present some problems with the
introduction of the targeter in the preceding commit. If someone wants
to do this you'd need to start by special-casing it in
spl-util.cc:spell_range.

--------------------------------------------------------------------------------
cae90e3 | advil | 2018-05-24 15:36:58 -0400

Refactor passwall and add a targeter
This commit rewrites the passwall logic to hopefully be much cleaner,
and more consistent about revealing map information (following up on
4197694d79069). It adds a targeter that shows the exact possible range
of a passwall, covering any possible landing sites, as well as the
infrastructure necessary for targeting rays to display out of sight.

The commit also fixes a number of other longstanding passwall issues,
6571 and 11229. Now when you abort a passwall with full knowledge of the
possible landing sites, it should not waste a turn.

One potential issue with this change is that the passwall targeter can
reveal map bounds, because the ray won't render. I'm not sure there's
anything to be done about this, though, and this is far from the only
thing that does (e.g. setting exclusions on out of bounds positions).

--------------------------------------------------------------------------------
89d60a1 | gammafunk | 2018-05-22 23:00:02 -0500

Merge pull request #758 from ebering/banished-cleanup
Code cleanup
--------------------------------------------------------------------------------
4197694 | advil | 2018-05-22 18:36:00 -0400

Don't leak information about passwall landing site via exclusions
Discovered by u/top_koala,
https://www.reddit.com/r/dcss/comments/8l5qhx/passwall_bugexploit_to_help_you_st
ab_things/

Basically, exclusions on unseen spaces could be used to avoid stopping
earlier than desired if the earlier space is floor. This change will
prompt on intermediate exclusions on unseen tiles that would undershoot
the actual destination. There is probably still a similar overshoot
leak, but I'm less clear on what exactly the check is or whether such a
leak is as useful in practice.

--------------------------------------------------------------------------------
c9969fe | Edgar A. Bering IV | 2018-05-21 13:09:57 -0400

A knot of arrival vaults.

--------------------------------------------------------------------------------
9628fc8 | Alan Malloy | 2018-05-15 13:00:12 -0700

Document a surprising (to me) pointer alias

--------------------------------------------------------------------------------
2950eec | Alan Malloy | 2018-05-15 13:00:12 -0700

Fix a comparator to be permissible (hexaflexagon, #11472)

--------------------------------------------------------------------------------
bed293b | advil | 2018-05-15 09:44:14 -0400

Revert "Revert "Handle just seen monsters better, especially fast ones (791)""
This reverts commit 492bfec932320e40cd2473a1590838919e5ca699.

--------------------------------------------------------------------------------
492bfec | advil | 2018-05-14 20:10:20 -0400

Revert "Handle just seen monsters better, especially fast ones (791)"
Getting random crashes in arena test, not sure what's up and I won't be
able to look until later.

This reverts commit ae1bc95d447d08b7691663c52d789b5344f7abc1.

--------------------------------------------------------------------------------
ae1bc95 | advil | 2018-05-14 18:10:29 -0400

Handle just seen monsters better, especially fast ones (791)
This improves the handling of several cases of fast monsters that are
newly seen. First, it was possible for them to move multiple times in
world_reacts with the following buggy pattern: they move into the
players los, get announced, shout, and leave los -- this last step is
supposed to be announced, but isn't unless it happens on the first move.
Second, it was possible for fast monsters to move into and out of los
without being announced at all, as long as they were wandering, and now
they will be announced in such cases.

However, there is an odd consequence of this, which comes from the fact
that observing a wandering monster for the first time temporarily
changes its behavior.  As long as the observation happens in the middle
of world_reacts (not on the player's movement), and the monster has more
energy, the monster subconsciously tries to stay in the player's los for
at least one turn, so the player can get a real glimpse. Consequently,
in cases where previously a fast monster would flicker in and out of the
player's los with no one being the wiser, the monster will now be marked
as SC_JUST_SEEN and most likely stay there for a turn. This probably
adds an extra stealth check to such cases. I'm not sure how often this
happens in practice, I had to jigger the wander behavior to get it to
easily replicate.

I thought that when I fixed the core bug, I could simplify things, but
this was wrong -- I don't dare remove any code to do with previously
unseen monsters.  This whole system is completely insane.

--------------------------------------------------------------------------------
1387785 | advil | 2018-05-13 22:07:58 -0400

Clear seen flags when wizmode moving a monster out of view
For testing messaging on newly seen monsters, as it is otherwise
extremely hard to set up repeatable scenarios. I don't think it should
be a problem to have this always happen.

--------------------------------------------------------------------------------
b7b63b2 | advil | 2018-05-13 21:26:19 -0400

Relax restrictions on wizmode monster moving
This now allows you to move monsters past transparent walls, and even to
positions out of los. (It also allows moving into solid features, and
into the player's position, but both of these were already possible. The
behavior when you move a monster onto another monster is also the same
as before - they swap.)

--------------------------------------------------------------------------------
e82b8a9 | advil | 2018-05-13 20:23:06 -0400

Properly handle previous offlevel travel targets in map view (11466)
Before, this would go to the coordinates of the previous travel target,
but without changing levels.

--------------------------------------------------------------------------------
acd343e | NormalPerson7 | 2018-05-12 17:05:42 +0800

Dont tell player of dragon scales creation when to be destroyed (#11464)
Previously, the message saying scales had been dropped appeared after
the message saying they had been destroyed (#11464, Leszczynek), which
is erroneous.

This commit removes the message for scales being dropped entirely when
over water/lava, because the scales were hardly "intact", leaving just
the "You hear a splash" message.

--------------------------------------------------------------------------------
e8614c9 | Aidan Holm | 2018-05-12 14:37:34 +0800

Edit swastika-shaped arrival vault
It's now less of a spiral, and more of a wavy pattern. Perhaps a rename
is in order? I also fixed up the slanted corners of the vault, which
were not symmetrical.

--------------------------------------------------------------------------------
2b68d14 | Aidan Holm | 2018-05-11 22:05:05 +0800

Add spell library contents to dump
Excludes spells you already have memorised, to avoid duplication.

--------------------------------------------------------------------------------
beac91d | advil | 2018-05-11 08:46:25 -0400

Add gnolls to mutation test (Sergeek)

--------------------------------------------------------------------------------
97be04f | advil | 2018-05-10 21:55:22 -0400

Fix messaging for oods that have just been created (11469)
OODs are created at (0,0) and then get a placement somewhere in the
first call of iood_act. If they were to hit a wall immediately (for
example if fired point blank into the wall with Z), a check for ood
visibility that determined whether to print the crash message was
failing, because the player can't see (0,0). This change uses the IOOD's
actual starting position after fuzzing for the visibility check and
cloud placement. N.b. I think that this position might sometimes be the
caster's position or a solid feature in tight quarters, which is
presumably why the ood isn't placed immediately; the cloud still doesn't
usually show up in these cases for this reason.

--------------------------------------------------------------------------------
ad65372 | Edgar A. Bering IV | 2018-05-10 10:40:28 -0400

Code cleanup
Remove an unnecessary call to push_features_to_abyss from banished()

--------------------------------------------------------------------------------
b855193 | gammafunk | 2018-05-09 17:08:40 -0500

Prevent shafts/teleports into an early cloud vault (MainiacJoe, #11449)
That vault places large numbers of cloud generators in a long corridor.
Players shafted or teleported into it from early dungeon levels are very
likely to have no means of escape depending on where they land. Mark the
vault with no_tele_into and clean up DES syntax.

--------------------------------------------------------------------------------
0c774a7 | advil | 2018-05-09 09:46:03 -0400

Add a necessary emptiness check (11467?)
Possibly was causing crashes with -D_GLIBCXX_ASSERTIONS on gcc.

--------------------------------------------------------------------------------
b098539 | advil | 2018-05-08 10:30:31 -0400

Use "recommended" in the character menu instead of "viable"
The intent of this change is to weaken the implication (technically a
scalar implicature) that non-highlighted combos are really bad.
Right new the inference is that that non-highlighted combos are not
viable (because if they were viable they would be highlighted). It's
hard to avoid some inference of this kind, but "not recommended" seems
much weaker than "not viable".

I didn't change the use of "viable" in rc files, or in the underlying
code.

--------------------------------------------------------------------------------
9ff8d77 | Poroing | 2018-05-07 21:30:15 -0500

Fix obsolete function name.
Committer's Note: automagic.lua is still defining and using a
delta_to_vi() lua function. Automagic should be rewritten to use this
delta_to_cmd() for the same reason autofight was rewritten in 7aac3cfd.
The delta_to_cmd() definition could then be moved to
dat/dlua/userbase.lua, which is loaded for clua as well as dlua.

--------------------------------------------------------------------------------
6463fda | advil | 2018-05-07 19:57:09 -0400

Handle startup preferences (esp. name) better when restarting
Startup preferences weren't really working properly for new games
without completely exiting the program, only restoring handled the
various restart cases.

Also remove some no-longer-relevant code from 2006.

--------------------------------------------------------------------------------
35e5176 | Alan Malloy | 2018-05-07 13:54:16 -0700

Fix a crash in game startup
It was possible (but not guaranteed) to cause a crash by starting a
new game after quitting to the menu from a previous game, because we
didn't clean up the existing shopping_list, leaving us in an inconsistent
state.

--------------------------------------------------------------------------------
c217a56 | Aidan Holm | 2018-05-07 23:26:49 +0800

Fix loading of paletted images on SDL tiles
Previous code was assuming that all pixel data was contiguous, which was
not the case: pixels in a row are contiguous, but rows may be separated.

--------------------------------------------------------------------------------
a933591 | Neil Moore | 2018-05-05 12:17:51 -0400

Remove some parentheses to satisfy unbrace.
I'm not entirely convinced that prohibiting parentheses around return
expressions is a great policy, particularly for multi-line expressions
like this one, but whatever.

--------------------------------------------------------------------------------
27b4f7b | Neil Moore | 2018-05-05 12:15:28 -0400

Remove references to obsolete mutation sources (dds1)
[skip ci]

--------------------------------------------------------------------------------
a245024 | pikaro | 2018-05-05 10:37:43 -0400

Expose current LOS in CLua, adjust autofight and automagic to use it

--------------------------------------------------------------------------------
c4eb3cb | gammafunk | 2018-05-05 03:43:31 -0500

A "magic classroom" special room for Depths (Skrybe, #11384)
A Depths special room that places spell-casting monsters with small
chances to place one of a few spell-using uniques that normally appear
in Depths.

This only non-formatting changes from the original submission are to add
Boris to the unique list and to tweak the least dangerous case that can
happen on Depths:1-2 based on the result of a random roll. For that
case, place a tengu reaver as the alternate for a lich instead of having
small chances for said uniques. These uniques normally spawn through
their vaults on Depths:3-5 and are certainly more comparable to fighting
an ancient lich that places in the worst case in this special room.
Therefore give them weight only in that worst case monster list.

--------------------------------------------------------------------------------
8bb545f | advil | 2018-05-03 22:20:20 -0400

Remove a dubious nullptr-terminated vararg
and replace with initializer lists.

--------------------------------------------------------------------------------
d0aace3 | advil | 2018-05-03 22:19:08 -0400

Use the sendkeys buffer for local tiles clicking
Since this seems to be safer for CMD_... sequences that might be mixed
in with other keystrokes.

--------------------------------------------------------------------------------
3f858e3 | advil | 2018-05-03 08:25:09 -0400

Go back to adding autofight commands to the secondary buffer
Adding them to the main buffer is causing some occasional crashes that I
can't replicate, probably about the interaction of tab with other keys;
going back to doing this should avoid triggering the relevant ASSERT.

--------------------------------------------------------------------------------
fed312b | advil | 2018-05-02 22:19:27 -0400

Add the ultimate enemy
I got tired of wizmode test monsters inconveniently moving around and
dying. (How did we not have one of these before?)

--------------------------------------------------------------------------------
d5c8bed | advil | 2018-05-02 20:50:19 -0400

Don't convert lua do_commands to keys and back (11095)
An actual command_type should be handled ok by anything on the other end
of this, so converting to keys immediately is overkill. This was causing
problems with keybindings in targeting mode that remapped numbers to the
direction commands in unusual ways: the first call converted the
commands to keys, and the keys got converted (incorrectly) to vikeys by
`unmangle_direction_keys`; they then got converted back to commands,
preserving the incorrect mapping. So the exact bug in 11095 is really
that unmangle shouldn't be called on the output of command_to_key, since
it isn't aware of keybindings.

The bug required a somewhat unusual key mapping to surface; in this
particular report 6 and 8 were (maybe by accident) swapped relative to
their normal position on a keypad, and this is why unmangling went
wrong.

Only autofight even uses this lua call, so hopefully there are no
other consequences to this simplification, but if tab starts acting
weirdly, this commit was probably why.

--------------------------------------------------------------------------------
7f50228 | advil | 2018-05-02 00:47:30 -0400

Don't print errors when mouse targeting a ranged weapon
Consequence of 991379fdf84c: mouse targeting uses CMD_... sequences
directly, and for targeting it uses ones that are targeting context
commands. The call in `fire_target_behaviour::get_command` to
`key_to_command` uses the default key context, since the four commands
it's checking aren't actually targeting keys, but any input was passed
through this, and since `key_to_command` validates the context for any
commands you give it, the mouse targeting command sequence caused a
bunch of errors each time it was called (the errors were basically just
cosmetic).

If we make a habit of using some `command_type`s in multiple contexts,
the context system should probably be refactored to handle that a little
bit better.

--------------------------------------------------------------------------------
5dc3fd9 | gammafunk | 2018-04-30 12:14:08 -0500

Replace encased rock with stone in an Elf vault (NormalPerson7)
This rock can be turned into earth elementals by deep elf elementalists
so that the elementals just remain trapped yet still detectable by
antennae. There's no reason to use rock in these inaccessible areas, so
replace it with stone. Closes #750.

--------------------------------------------------------------------------------
927ce74 | Chris Campbell | 2018-04-30 16:18:34 +0100

Don't give monsters a movement penalty when escaping engulf

--------------------------------------------------------------------------------
8baa81b | NormalPerson7 | 2018-04-30 16:17:50 +0100

Remove Engulf's movement penalty and make it block all god abilities
This commit removes the undocumented 50% movement penalty from Engulf
(mentioned by #11458) and makes Engulf block all god abilities.

This makes being unbreathing and being able to swim identical for the
purposes of Engulf, and removes a special case in Zin's recite.

Adds a new lua option you.res_drowning to avoid having to
list all of the races and forms which are immune to drowning in the
Engulf status description.

[Squashed and cleaned up some formatting. Merges #748 PR - MarvinPA]

--------------------------------------------------------------------------------
8519d86 | advil | 2018-04-29 23:44:30 -0400

Have display of the acrobat ev boost in tiles match console
Neither the number, nor the color, were showing properly in webtiles,
where by properly I mean showing with the timing that they do in
console. (As discussed in the dev channel in the past, it isn't entirely
clear what the best way to show this is, but I went with the existing
behavior.) To get the number to show, the LAST_MOVE_... property needed
to be reset slightly later in main.cc, because it was getting cleared
before the webtiles redraw (and probably regular tiles too, though I
didn't test it); this led to it only appearing under strange
circumstances such as resting with 5. To get the color to render, it
just needed some explicit casing to get the timing right. As of this
commit, the behavior should be the same in tiles/console.

I also slightly generalized / unified some of the logic for checking
whether to show the acrobat boost.

--------------------------------------------------------------------------------
09e6169 | Aidan Holm | 2018-04-29 02:10:50 +0800

Revert "Allow auto-travel to/from all locations"
This reverts commit cd58e32bf33d8759b4cd63677a1ee1a00a8f276d.

--------------------------------------------------------------------------------
b94d8b5 | Nikolai Lavsky | 2018-04-29 00:52:57 +0800

Improve Ashenzari's warnings for wands
Two fixes:
* Ash was giving warning messages for wands of clouds and iceblast
  even though monsters don't use them.
* Ash wasn't warning the player about monsters carrying a wand of
  enslavement, which can be used to confuse the player.

--------------------------------------------------------------------------------
6184afb | advil | 2018-04-28 10:47:01 -0400

checkwhite / unbrace

--------------------------------------------------------------------------------
24998ea | advil | 2018-04-28 10:20:55 -0400

Encrypt the channel name in .travis.yml so forks can't use it
See https://github.com/travis-ci/travis-ci/issues/1094
and 
https://github.com/mozilla/build-tools/commit/c13a2978e0869219295013eeb52cf52227
ab45ec

Hopefully I did the encryption correctly...

--------------------------------------------------------------------------------
f65d00e | Jacob Meigs | 2018-04-28 21:58:27 +0800

Remove get_item_info() deck filtering
Fixes mantis issue #11435

Small comment change to note decks used_count can be negative.

--------------------------------------------------------------------------------
32d7058 | NormalPerson7 | 2018-04-28 21:00:02 +0800

Allow brand weapon scrolls to give venom under TSO
TSO no longer hates venom, and hasn't for almost two years.
This was inspired by gammafunk's commit ab1296c.

--------------------------------------------------------------------------------
4f8b0bd | Aidan Holm | 2018-04-28 20:26:00 +0800

Clear useless books from $-list after finding spells
Filtered to items that were made useless by the act of finding spells;
i.e. if you add an already-useless item to the shopping list and then
find some other spells, that item won't be removed, since it wasn't just
made useless.

--------------------------------------------------------------------------------
cd58e32 | Aidan Holm | 2018-04-28 20:24:37 +0800

Allow auto-travel to/from all locations
Auto-travel now supports travelling to and from all locations, including
the abyss, pandemonium, hell sub-branches, and timed portals. For abyss
and pan, < refers to a branch exit, while > means abyssal stairs and pan
transits respectively.

Handling pandemonium unfortunately requires a fair bit of
special-casing, as it is the only branch with a depth of 1.

In future, it might be nice to immediately reply with "I don't know how
to get there" when the player is in abyss/pan with no reachable exits,
rather than prompting for a destination. An improved prompt could also
show "(>) Deeper into the abyss / Another region of pan" when that is
the only available destination.

--------------------------------------------------------------------------------
6e0a438 | Aidan Holm | 2018-04-28 20:24:37 +0800

Fix some abyss features having wrong destination
Abyssal stairs and exit-via-abyss didn't set their destinations
correctly, which broke autotravel.

--------------------------------------------------------------------------------
a9d99d6 | Alan Malloy | 2018-04-27 12:42:39 -0700

Simplify a boolean expression

--------------------------------------------------------------------------------
2a24f12 | Alan Malloy | 2018-04-27 12:42:39 -0700

Fix teleport/hatch closets in erik_orc_3 (Leszczynek, #11460)
Rather than marking the closets as no-tele, I've simply made sure each
tile is reachable by removing some of the maybe-wall tiles.

--------------------------------------------------------------------------------
846bec1 | advil | 2018-04-26 15:01:28 -0400

Add a way of detecting sendkeys problems for stress tests
This adds a way to have the stress tests (which heavily use
crawl.sendkeys) crash if the keybuffer is flushed before all the queued
keys are processed. The intent is to catch situations like
15e00174aab247bba1, where a sendkeys sequence to do with flight became
obsolete, and led to the test no longer working (for at least 2 years)
because the buffer was flushed after those keys failed, but the rest of
the test kept running as normal.

Crashes only happen in wizmode with the relevant crawl_state parameter
set; non-wizmode still prints an error if this parameter is set.  (Maybe
this error should always be printed? But there might be all sorts of
ways to cause the buffer to flush. Crashing in this circumstance is
definitely a very special case thing.)

--------------------------------------------------------------------------------
15e0017 | advil | 2018-04-26 12:58:27 -0400

Fix abyss_short_run.rc (aidanh)
This is doubly-broken: Since 1f733d267d2fff9e920c items of flying start
flight when worn, and at some point (not sure when) the default key for
starting flight seesm to have become `g` anyways. So this test got a
silent error on sendkeys('ah'), and failed to ever enter the abyss.

--------------------------------------------------------------------------------
2895223 | NormalPerson7 | 2018-04-26 21:58:50 +0800

Fix the message order when unwielding randart weapons (damerell, #11427)
When a randart weapon had Fragile, the weapon would stop
flaming/glowing/its visual brand after the weapon had "crumbled to
dust", which is erroneous. This was caused by unequip_artefact_effect,
containing the check for fragility, being called before the weapon
brand's visual effect was dealt with.

This commit fixes that by (a) creating a separate helper function
unequip_fragile_artefact for dealing with Fragile artefacts, (b) calling
this function from unequip_weapon_effect after the brand's visual effect
is handled, and (c) calling this function from unequip_artefact_effect
only when the artefact is not a weapon.

--------------------------------------------------------------------------------
5dfd9e3 | Yer mivvaggah | 2018-04-25 12:56:12 -0600

don't recommend LTO
according to geekosaur, it doesn't do much even when it works.

and according to me, cross compiling from Arch to Windows with LTO=y causes 
teleport scroll crashes!
--------------------------------------------------------------------------------
ab1296c | gammafunk | 2018-04-24 19:54:11 -0500

Allow brand weapon scrolls to give flaming and chaos brands under Dith
Dith no longer has a fire-hating conduct.

--------------------------------------------------------------------------------
01d5f99 | gammafunk | 2018-04-24 19:54:10 -0500

Allow fire facet mutant beasts under Dith and remove unused code
Dith's fire conduct was the only use of this mutant beast facet
exclusion code. Now that the conduct no longer exists, this code can be
removed. If a new god conduct gets made where mutant beast facets need
to be excluded, this commit can be partially reverted.

--------------------------------------------------------------------------------
609ae0a | gammafunk | 2018-04-24 19:20:20 -0500

Allow the ignite blood demonspawn mutation under Dith (gameguard)
Dith no longer hates fire, so this mutation should be allowed to work.
Fixes bug 11455.

--------------------------------------------------------------------------------
6ec6d78 | gammafunk | 2018-04-24 19:19:28 -0500

Mark some Pakellas code for removal when the major version changes

--------------------------------------------------------------------------------
c73351f | Kyle Rawlins | 2018-04-23 17:07:28 -0400

Fix a typo
[skip ci]
--------------------------------------------------------------------------------
870eee8 | advil | 2018-04-22 21:43:38 -0400

Ensure that close_all_menus syncs with webtiles clients
This is one possible explanation for 11387, that somehow the javascript
menu_stack gets out of sync with m_menu_stack on the client side. I
haven't managed to reproduce this bug at all, but the two stacks getting
out of sync via an extra open_menu immediately following init_menus
would lead to the observed behavior, and explain why further menus act
as submenus. This change ensures that the javascript stack is entirely
empty when client-side close_all_menus is called, which is triggered on
redraw. If this fix doesn't work, back to the drawing board.

--------------------------------------------------------------------------------
b72a975 | advil | 2018-04-21 13:23:46 -0400

Merge branch 'dokempf_skill_callback'

--------------------------------------------------------------------------------
ae935ca | advil | 2018-04-21 13:22:27 -0400

Check the results of the skill_training_needed callback
Also some light refactoring to consolidate some related skill checks,
and a bug fix: lua code could enable training on a maxed skill (and
skill targets could probably be set for this case too).  The refactoring
shouldn't otherwise change any behavior but who knows with this code,
some of the ways that these checks were done were subtly different.

Resolves #729, doing the check non-recursively.

--------------------------------------------------------------------------------
b03524a | Dominic Kempf | 2018-04-21 13:22:06 -0400

Add player LUA callback skill_training_needed
The new skill target mechanism and its lua bindings
are a very nice way of implementing automated skill
advancement logic. However, when the last skill target is met
while gaining experience the skill menu is opened
and needs user interaction. The patch introduces a
callback `skill_training_needed` in this case. If it
returns true, the skill menu is not opened.

--------------------------------------------------------------------------------
646ff71 | advil | 2018-04-21 09:55:09 -0400

Fog spread rate simplification
Previously, fog-producing effects had a 50% chance of producing a smoke
type with 0 default spread rate, conditioned on smoke color (purple/blue
didn't spread, grey/black did). This difference between smoke types
predates the introduction of scroll of fog in 7ef7c926, and comes from
the days when fog was only produced by miscast effects / xom; it may
even predate dcss. It's quite spoilery, and I think it's not very well
or easily understood by players, given that it's happening on top of a
bunch of other randomness in cloud behavior. It's also, I believe, a
contributing factor to newer players not figuring out how to use scrolls
of fog. I'm not really even sure if it's intentional, since (especially
in early code) you had to read between the lines to know that it was
happening.  Of course, the first version of fog was intentionally a bit
more random (even had a 10% chance of producing miasma), so it might be.
This commit makes the default spread rate the same for all four smoke
types (and in fact all player-producable los-blockers); as far as I
know, the differences between the four smoke types are now just
cosmetic. (Spread rate can still be overridden on placing the cloud, but
this is used extremely rarely, and not at all for los-blocking clouds
that I have found.)

This is a buff to scrolls of fog, since blue/purple smoke were likely to
be useless for los blocking, and if this needs to be balanced I'd rather
do it by decreasing the drop rate (though I tend to think the drop rate
is ok at the moment, and definitely shouldn't be halved). It's also a
buff for cloak of the thief, which maybe something should be done about.
A possible balancing tweak would be to apply some randomness to spread
rate independent of smoke color; I'm not currently very in favor of this
because I think there's already enough randomness to the initial cloud.
Other impacts: miscast effects, xom. Note that this doesn't affect tloc
clouds even though they use the same tile/color as purple smoke. It also
doesn't change steam, which already spread.

--------------------------------------------------------------------------------
29407c6 | CanOfWorms | 2018-04-21 01:39:22 -0400

Fix some manual acquirement logic
Mark invocations skill as useful for Nemelex worshippers and useless for Ru 
worshippers.
--------------------------------------------------------------------------------
535178c | advil | 2018-04-18 20:04:42 -0400

Fix the octopode + P interaction when wearing many rings (aubilenon)
When an octopode is wearing all the rings, and that number is more lines
than there are lines in the message window, using P and selecting a ring
forced an extremely awkward prompt that required a more, and then a ? if
you want to see all the rings at once. This change just has the prompt
use the menu from the beginning if there are too many rings to fit in
the message window at its current height (the normal situation for
webtiles).

Annoyingly, there is no easy way to prompt only for rings, so this
change shows all jewellery (for now).

--------------------------------------------------------------------------------
68eecb7 | advil | 2018-04-18 17:36:11 -0400

Refactor fsim for retaliatory damage, and to just be a little better
It's been a long-standing annoyance that there's no way to check
retaliation damage with fsim. This refactor tries to generally clean up
how fsim works a bit (providing better abstraction) and use the
improvements to handle retaliation damage (long blades, porcupines,
etc).

Because I unified setup for attack and defense, and tried to make it a
bit more robust (using more unwinds, etc) this commit will also improve
some special cases (e.g. retaliation damage from porcupines wasn't
properly cleared).  But, there are no doubt more special cases, and
there may be unintended consequences.

This commit doesn't change double scale fsim.

--------------------------------------------------------------------------------
76f67b3 | advil | 2018-04-18 17:36:11 -0400

Disable the poison effect in fsim
This doesn't impact damage calculations (I think).

--------------------------------------------------------------------------------
5e80d7e | Nikolai Lavsky | 2018-04-18 14:37:33 +0800

Remove books from shopping list on pickup (Kipster)
Usually items are removed from the shopping list when they are put into
inventory. But after the introduction of spell library books no longer
take up inventory space, so the usual code path,
    _put_item_in_inv() -> _got_item() -> cull_identical_items(),
no longer works for them.

--------------------------------------------------------------------------------
7563fe7 | CanOfWorms | 2018-04-18 00:15:01 -0400

Scale skills correctly when checking fail rate
Oops...
--------------------------------------------------------------------------------
a98e25f | CanOfWorms | 2018-04-17 23:21:45 -0400

Fix ordering in spellpower calculations

--------------------------------------------------------------------------------
802c45d | CanOfWorms | 2018-04-17 22:50:02 -0400

Remove a stepdown in spell success calculations
Spell success calculations currently use spellpower calculations to
partially determine failure rates, but the stepdown doesn't apply
until the player has trained magic skills to a high degree;
Specifically, the stepdown applies whenever

Spellcasting/2 + Spell School Average*2 > 50

This commit removes the stepdown from spell success (but still
leaving it in spellpower calculations) and cleans up the code.
To compensate for the buff at high skill levels, level 9 spell
difficulty is adjusted. The net effect for level 9 spells is a
reduction of about 0.5 to 2.5 in spell schools required
to achieve the same failure rate in the 20-27 skill range.

By removing the stepdown, spell success penalties due to armour
and shields are simpler to quantify in terms of skill levels, e.g.

"Wearing this armour penalizes spell success by an amount equal to
5.5 skill levels in all spell schools."

Adding this type of information to the item information screen can
be done in the future.
--------------------------------------------------------------------------------
201945f | advil | 2018-04-16 19:56:06 -0400

Let webtiles message height be set via `msg_webtiles_height` (aubilenon)
Before this commit, the height of the webtiles message pane is inherited
from console, but since webtiles is running over a console backend with
a fixed size (80x24), it just isn't customizable using the existing
options and I couldn't figure out a sensible way of adding better
behavior using only the existing options. The only case where the
previous behavior had an impact was in spectating (via webtiles) a
console player with a customized message pane size. This option just
sets the webtiles message pane independent of console, with the
console's current size as a min. (N.b. the documentation simplifies this
slightly, because the actual situation only makes sense if you have a
good grasp on the fact that there is a secret console client.)

Caveats: now a console player spectating a webtiles player with this
setting will not see a matching messages pane, and a console player with
this set will silently affect webtiles spectators.

--------------------------------------------------------------------------------
30dfbe6 | NormalPerson7 | 2018-04-15 23:39:28 +0800

Fix a double prompt on putting on rings with *Drain/*Contam/!P (#11309)
Previously, if the player already had two rings on and needed to choose
which ring to swap off, check_warning_inscriptions would be called
twice, once before choosing which ring to swap off, and once after,
causing a double prompt if the ring the player was putting on had *Drain
or *Contam.

Specifically, this behaviour was bad because the player could cancel
putting on the ring by inadvertently pressing Esc/N on the second prompt,
after having removed a ring already, resulting in a waste of 5 auts.

This commit adds an extra argument to puton_ring which allows the
function to be called from JewelleryOnDelay::finish() without checking
check_warning_inscriptions, which results in just one check for
inscriptions and *Drain/*Contam, occuring the first time the player
tries to put the ring on. Hence, after selecting which ring to remove,
the ring in question will be put on without prompt.

Note that the static function _puton_item is called only by puton_ring.

--------------------------------------------------------------------------------
2d6336e | NormalPerson7 | 2018-04-14 15:20:18 +0800

Fix an extra "the" in "It would be a sin to butcher..." (Reeces)
There was a "the" in the mprf description as well as from the
name(DESC_THE).c_str().

--------------------------------------------------------------------------------
c608dd7 | NormalPerson7 | 2018-04-13 17:26:04 +0800

Make statue descriptions accurate about no-regen (#11448)
This commit gives statues the M_NO_REGEN flag, which will show up in
their description as "It cannot regenerate".

This wasn't there before because statues cannot regenerate by any means,
as seen in the check in monster::heal, whereas other monsters with this
flag will still regenerate if given the regeneration status. The check
in monster::heal is still checked with this flag on, however, so there
is no reason this should change any behaviour.

--------------------------------------------------------------------------------
29664b4 | advil | 2018-04-11 21:40:47 -0400

Make the behavior of DEBUG_ITEM_SCAN more consistent
In particular, this will fix up unlinked temporary items on level load
consistently on all builds, not just FULLDEBUG builds. What was
happening is that DEBUG_ITEM_SCAN is #defined on all builds, but for
everything except FULLDEBUG builds, it got #defined in item-scan.cc,
which of course interacts with compilation order; the result being that
it was *not* defined at the time where tags.cc was built, and the fixup
code wouldn't get called. This moves the #define to AppHdr.h (sorry) and
does a bunch of other cleanup. It also prints an explicit error when
loading the level, though now this will only get printed once; before
these errors would get silently fixed up on FULLDEBUG builds only,
leading to confusion.

It may be that we *don't* want the fixup, since we'll get more saves
that way that actually instantiate bugs that trigger this error, but for
the moment I am just restoring the intended behavior from
dc59d2025591002a2. Players seem to find it disconcerting when this
message keeps repeating (e.g.
https://crawl.develz.org/mantis/view.php?id=11413&nbn=1#bugnotes) so
this makes it a bit easier on them.

There's some worry in the comments about DEBUG_ITEM_SCAN being slow, but
I think we do want it on always and it's been on for all builds for like
10 years, so I think it's fine.

This doesn't interact with unlinked items held by dead monsters, which
don't get fixed up by this code (though they could if we want that).

--------------------------------------------------------------------------------
910c0f9 | advil | 2018-04-11 18:46:10 -0400

Remove a swastika-ish arrival vault (11428)
There's been some past discussion about whether this really looks like a
swastika vs. some kind of spiral, but on console with the rest of the
map not revealed
(https://crawl.develz.org/mantis/file_download.php?file_id=7665&type=bug
), I agree with the judgment. The past discussion was using a tiles
screenshot, which I agree looks different (because the ground doesn't
stand out as much I think).

--------------------------------------------------------------------------------
873ca8c | advil | 2018-04-11 18:22:13 -0400

Fix a possible disconnected region in minmay_the_grid_ultimate (11444)
If all three of these "s go to x (plus a few others), this region
becomes cut off. By symmetry around the diagonal (noticed by aidanh) it
seems that the fix is to change these particular "s to `.`. Minmay let
us know if we're wrong...

--------------------------------------------------------------------------------
d16d139 | Aidan Holm | 2018-04-06 23:01:07 +0800

Remove a bunch of unused variables

--------------------------------------------------------------------------------
b46e3d7 | Aidan Holm | 2018-04-06 23:01:07 +0800

Remove some unneeded drawing function calls
Fixes github issue #684

--------------------------------------------------------------------------------
a714374 | wheals | 2018-04-05 10:27:17 -0400

Remove process-desc.h.

--------------------------------------------------------------------------------
051d7ab | wheals | 2018-04-05 10:17:43 -0400

Explain how to clear the spell library filter.

--------------------------------------------------------------------------------
915a0fd | Aidan Holm | 2018-04-05 20:17:40 +0800

Add tiles for new game weapon options

--------------------------------------------------------------------------------
83320f9 | Aidan Holm | 2018-04-05 19:16:24 +0800

Add braces

--------------------------------------------------------------------------------
00f67d9 | Aidan Holm | 2018-04-05 19:16:24 +0800

Remove unused show_quote argument

--------------------------------------------------------------------------------
eb62f64 | Aidan Holm | 2018-04-05 19:16:24 +0800

Tweak spell library UI and add help page
Most of the changes here are removing the slight UI differences on local
tiles. Cramming the "press ? for help" text into an already somewhat
cluttered bottom line turns out to be a bit of a challenge, but it'll do
for now.

--------------------------------------------------------------------------------
7fd3ada | Aidan Holm | 2018-04-05 19:16:24 +0800

Tweak menu select count string spacing

--------------------------------------------------------------------------------
c95b66f | Aidan Holm | 2018-04-05 19:16:24 +0800

Remove process_description template monstrosity
The given template converted a describe_info into a description string,
using an additional parameter that provided a ncurses like interface to
drop parts of the description if not everything could fit. This was only
ever used for hover descriptions in local tiles (elsewhere, we're making
long descriptions scrollable), and was only used to add a droppable
prefix about clouds. This prefix is now always shown.

Wrapping the text to fit the message region has been moved to
MessageRegion::render(), which uses FontWrapper's split(). There's an
extra bit to change the ellipsization style.

--------------------------------------------------------------------------------
3e50427 | Aidan Holm | 2018-04-05 19:16:24 +0800

Remove unneeded tiles_crt_control instances
All of these instances are followed by code that uses
show_description(), which already pushes and pops a menu on webtiles
with code internal to Menu. The second string parameter is used to
add a class to the menu HTML element to permit per-menu customization,
but none of these were in use. (class: "menu_" + tag)

--------------------------------------------------------------------------------
2a239ed | Aidan Holm | 2018-04-05 19:16:23 +0800

Remove no-longer-needed helper function

--------------------------------------------------------------------------------
4ddc6ac | Aidan Holm | 2018-04-05 19:16:23 +0800

Replace all uses of print_description()
Replaced with show_description(), which now automatically shows a UI for
the description quote. The monster description UI still does its own
thing at the moment though.

--------------------------------------------------------------------------------
761eef7 | Aidan Holm | 2018-04-05 19:16:23 +0800

Fix wordwrap on FAQ menu, and support long Q/As

--------------------------------------------------------------------------------
94544a2 | Aidan Holm | 2018-04-05 19:16:23 +0800

Move monster description quote toggle text to bottom

--------------------------------------------------------------------------------
dbd6ce8 | Aidan Holm | 2018-04-05 19:16:23 +0800

Add better alternative to print_description()
... better in that show_description() supports scrolling, instead of
just ellipsizing the content if it's too long to fit.

--------------------------------------------------------------------------------
5755430 | Aidan Holm | 2018-04-05 19:16:23 +0800

Append newline to ?/m titles (for consistency)

--------------------------------------------------------------------------------
dd0f9c7 | Aidan Holm | 2018-04-05 19:16:23 +0800

Make spell memorise text consistent with item actions

--------------------------------------------------------------------------------
acbdab5 | Aidan Holm | 2018-04-05 19:16:23 +0800

Remake god description UI with formatted_scroller
This commit moves the describe-god UI to a formatted_scroller, and
reimplements the religion join yesno prompts as a small state machine.
This helps get rid of cgotoxy/the CRT abstraction: the god description
functions now build formatted_strings.

The god joining prompts are stuffed into the more string of the
formatted_scroller, which is... not ideal, but should work until I get a
replacement for formatted_scroller up and running.

Fixes:
 - on webtiles, ^ will now show the religion UI in a popup box,
   instead of clearing the full screen: this matches ?/G behaviour.
 - religion join prompts can no longer fill up the screen.
 - the page indicator is now hidden when asking the player to join.

Changes:
 - Message about yes/no only no longer changes based on the key that's
   pressed. To compensate, adjusted the string slightly to indicate that
   uppercase Y is required, while N and n are acceptable.
 - Pressing escape now always leaves the join-religion prompt loop and
   closes the menu.

Regressions:
 - on webtiles, switching between religion pages now closes the popup
   before reopening it to the new page.
 - religion prompts now appear at the bottom of the screen, with the
   page indicator: not a problem on console, but is sub-optimal on local
   tiles (until I make local tiles menus boxed, like webtiles menus).

--------------------------------------------------------------------------------
7ef6792 | Aidan Holm | 2018-04-05 19:16:23 +0800

Remove unused webtiles client HTML

--------------------------------------------------------------------------------
0b74486 | Aidan Holm | 2018-04-05 19:16:23 +0800

Fix webtiles console hiding last empty line

--------------------------------------------------------------------------------
7cd8b77 | Aidan Holm | 2018-04-05 19:16:23 +0800

Force webtiles CRT popup to 80-char width
This prevents the popup from resizing when scrolling through text of
varying width.

--------------------------------------------------------------------------------
993470f | Aidan Holm | 2018-04-05 19:16:23 +0800

Remove unused webtiles menu tags

--------------------------------------------------------------------------------
41d4792 | Aidan Holm | 2018-04-05 19:16:23 +0800

Render menu icons at full size
.. as opposed to rendering at the same size as the dungeon view. The
dungeon view shrinks tiles to try to fit in the full LOS, but there's no
need to do that for menu tiles. Resizing was also not properly handled:
scrolling after a resize could cause new menu entries to be initialized,
creating a menu with some tiles reduced in size.

--------------------------------------------------------------------------------
391584f | gammafunk | 2018-04-05 05:03:38 -0500

Remove an extra blank line

--------------------------------------------------------------------------------
8a7c851 | gammafunk | 2018-04-05 05:03:38 -0500

Remove the Dithmenos fire conduct
Dithmenos' hatred of fiery spells and items isn't an interesting
gameplay limitation, since restricting access to one kind of elemental
damage has little effect on strategy. Damage from other elemental and
non-resistable sources are widely available and can do the same thing
that fire elemental damage does. A previous version of the Dith conduct
was larger and tried encompass "sources of light", but this didn't work
well, since "light" isn't a well-defined notion in crawl. Since the
no-fire conduct prevents use of a rather specific set of items without
introducing much decision making, it's better to simply not have the
conduct.

This commit removes Dith's hatred of fire-based items, spells, weapon
brands, and summons. For consistency we also remove the god's
appreciation of killing fiery monsters. Now Dith doesn't care about
fiery things in general, and the shadow mimic works normally with
fire-themed attacks.

--------------------------------------------------------------------------------
60b3cfd | Aidan Holm | 2018-04-01 21:44:20 +0800

Deduplicate card types in card description

--------------------------------------------------------------------------------
f89cf90 | Aidan Holm | 2018-04-01 21:44:20 +0800

Improve local tiles hover info for clouds

--------------------------------------------------------------------------------
5f88266 | Aidan Holm | 2018-04-01 21:44:20 +0800

Merge WME_KEYPRESS into WME_KEYDOWN
There's no actual differentiation between how these events are handled,
for now. In future, once we have proper widgets, text entry widgets will
need to differentiate between them, but unifying them simplifies UI
screen implementation for the time being.

--------------------------------------------------------------------------------
99f3766 | Aidan Holm | 2018-04-01 21:43:59 +0800

Don't randomize ?/F tiles
... so they match the tile in the description popup, which will be added
in a future commit.

--------------------------------------------------------------------------------
66d6621 | Aidan Holm | 2018-04-01 21:37:10 +0800

Fix compilation error

--------------------------------------------------------------------------------
276b176 | Aidan Holm | 2018-04-01 21:00:53 +0800

Spruce up the stash search and shopping menus (NormalPerson7, #11376)
Add tiles for both of them, and also show feature descriptions for
stash search results. This needs to use level_excursion to show
instance-specific descriptions (such as trove costs).

Picking feature tiles by the search result description is a horrible
hack, and is currently buggy for a very small number of features, but it
avoids a level_excursion for every menu entry.

--------------------------------------------------------------------------------
285f75a | Aidan Holm | 2018-04-01 21:00:53 +0800

Refactor some code into get_tiles_for_item()
The code that adds the background tile assumes that the item is on the
same level, which is not always the case, and generally makes this
pretty buggy. But a level_excursion would likely be too heavyweight.
Blegh.

--------------------------------------------------------------------------------
e0921bb | gammafunk | 2018-04-01 05:43:01 -0500

Revamp a lemuel worm vault
This vault got nerfed as various worm monsters were removed over the
years, with many of the worms formerly in the vault being replaced with
ordinary worms of the kind that stop generating by D:6. It was an
autoexplore trap due to placing submerging swamp worms earlier than they
usually generate. It was later also added to Spider, but not with
terribly depth-appropriate monsters. Now swamp worms no longer submerge,
hence not causing the same autoexplore problem, and pose a more credible
threat at later depths, but the monster set still needs variety and
adjustment.

This commit reworks the monster set to remove the low-level worms and
make the threat level appropriate for all depths and includes Swamp as
an eligible placement branch. At pre-D:12 depths it's swamp worms only
and in much more limited numbers, with tyrant leeches and a torpor snail
showing up at later depths. By Spider and Swamp, a moths of wrath is
thrown in with a chance for a couple additional moths of wrath and/or
torpors, and most of the worms are tyrant leeches (since these play
better with berserk than swamp worms).

--------------------------------------------------------------------------------
e799247 | gammafunk | 2018-04-01 05:43:01 -0500

Some vault formatting cleanups

--------------------------------------------------------------------------------
300c91b | gammafunk | 2018-04-01 05:43:01 -0500

Fix and update a Swamp worm vault
This vault got a bit broken due to some improper merging in e.g.
d131b1cb, something that seems to have happened before and gotten
reverted, only to get added again. It was placing normal level spawns
where it tried to place specific monsters on a monsters list. It also
placed ordinary worms since some of the original worm monsters it used
got removed.

This commit updates the vault to use the correct glyphs and to use
appropriate numbers of swamp worms and tyrant leeches, also varying the
number and type of monsters placed a bit.

--------------------------------------------------------------------------------
77ec1f3 | gammafunk | 2018-04-01 05:43:00 -0500

Clean up a swamp entry vault
Simplify some glyph usage and thin out the worm population a little,
since swamp worms are nastier now.

--------------------------------------------------------------------------------
83361d3 | gammafunk | 2018-04-01 05:43:00 -0500

Give swamp worms Harpoon Shot and further adjustments
This commit gives swamp worms Harpoon shot, described in the previous
commit and removes their submerging behaviour. Submerging gave swamp
worms a trap-like effect that occurred only in water. However the
frequency of swamp worms made water navigation more tedious to do in a
way that minimizes risk, since many squares could harbor the unseen
monster. The Harpoon Shot spell will let swamp worms sometimes move the
player into unfavorable shallow water or collide them with deep water,
but the player will now always see swamp worms ahead of time.

This commit also reduces swamp worm frequency by 33%, giving that weight
equally to tyrant leeches and alligators.

--------------------------------------------------------------------------------
f80497b | gammafunk | 2018-04-01 05:43:00 -0500

Implement a Harpoon Shot monster spell and give it to iron giants
From the spell description:

"Fires a long and flexible barbed mass. The ensnared victim will either
be pulled adjacent to the caster or collide with anything blocking the
way."

Harpoon Shot is a range 6 spell that fires a blockable shot which pulls
the victim adjacent to the caster when it hits and does damage. It lets
monsters reposition the player in range of melee and other spells and
possibly deposits them in less favorable terrain like shallow water.
Similar to the idea of the old throwing attack previously used by iron
giants (and octopode crushers before that), but without repeatedly
putting players attempting melee out of melee range.

Casters won't use this spell on adjacent targets, nor will they pull
victims through or to inhabitable squares or intermediate actors.
Instead said squares cause a collision in the same way Force Lance and
Draconian Ice breath do (e.g. "You violently stop moving!"), where the
victim takes collision damage and further movement ceases.

Iron giants now have this spell and have their overall casting frequency
reduced so they don't cast more than 50% of the time, putting them more
in line with other monsters that have strong melee as well as spells.
The spell does relatively light damage (2d17 on iron giants) and does
require damage to perform the pull effect, but has relatively good
accuracy.

--------------------------------------------------------------------------------
efa7288 | gammafunk | 2018-04-01 05:43:00 -0500

Remove copy-and-pasted comments
The comments weren't needed, since the beams in question would have had
these console colors regardless of the monsters casting.

--------------------------------------------------------------------------------
7905ed6 | gammafunk | 2018-04-01 05:43:00 -0500

Refactor methods related to actor knock-back
Move the is_stationary() actor check done in the knockback_actor()
method to the can_knockback() method, and have the latter take a ref
instead of a pointer. Also update comments accordingly.

--------------------------------------------------------------------------------
2b15929 | Aidan Holm | 2018-03-30 21:36:49 +0800

Fix mousewheel scrolling being reversed vertically
SDL 2.0 has the origin in the bottom-left.

--------------------------------------------------------------------------------
7e9e52a | Aidan Holm | 2018-03-30 21:36:47 +0800

Remove unused shopping list code

--------------------------------------------------------------------------------
d21a89c | advil | 2018-03-27 22:34:16 -0400

Don't crash after stash search help with messages_at_top=true
This probably fixes some other obscure crash possibilities; basically,
redraw_screen would leave the cursor region as GOTO_MLIST if
`messages_on_top` was set to true, but GOTO_MSG if false (the default).
Code that relied on the default behavior would likely crash on a screen
write out of bounds, because GOTO_MLIST isn't very big. Exiting out of
help screens to a prompt is a likely candidate in general.

Probably redraw_screen shouldn't even be able to change region, because
side-effects are bad (and probably region shouldn't be bad global state,
for that matter), but I have no doubt that there is code that implicitly
relies on this.

--------------------------------------------------------------------------------
c4e68a0 | Chris Campbell | 2018-03-27 19:44:51 +0100

Let equip_unequip work on weapons (xbon)
And fix the options_guide description for it being inaccurate.

--------------------------------------------------------------------------------
4a852b3 | Alex Jurkiewicz | 2018-03-26 10:05:12 -0400

Update chequers_ecumenical_altar_grove
* Remove all potentially disconnected areas (every - is adjacent to a .,
  which should guarantee connectivity).
* For double safety, mark potentially disconnected areas as no_tele_into
* Reduce the frequency of dead trees
* Remove replacement of trees with crystal/rock

--------------------------------------------------------------------------------
4c9dbd0 | advil | 2018-03-26 10:01:35 -0400

Fix prefix behavior for FONTDIR (11430 / sterilizedmilk)

--------------------------------------------------------------------------------
f0fe05c | Chris Campbell | 2018-03-25 18:50:02 +0100

Recolour floors in skrybe_limestone_x
Since yellow floor looks the same as a monster halo in console unless manually
examined.

--------------------------------------------------------------------------------
82e80c5 | gammafunk | 2018-03-24 23:53:44 -0500

A decor vault from Skyrbe (#11384)
For Dungeon and Depths. Only changes from the original submission are a
more appropriate vault name and slightly cleaned up syntax.

--------------------------------------------------------------------------------
43f9854 | Aidan Holm | 2018-03-25 10:50:25 +0800

Fix door exclusion info leak (Etesian, #10966)

--------------------------------------------------------------------------------
92d99f3 | Chris Campbell | 2018-03-24 17:59:25 +0000

Allow MP-powered wands to fire with 0 MP, don't consider it a bad mut
With less than 3 MP, the power bonus is reduced accordingly while still using
any available MP. Since wands of healing/hasting/teleportation no longer exist,
wands of digging are the only wand that gains no benefit from it so it's much
closer to a wild magic-style double-edged mutation.

--------------------------------------------------------------------------------
7d43e34 | Chris Campbell | 2018-03-24 17:58:44 +0000

Allow all forms to use wands
All forms could already use most other evoked items - simplify the wide range
of form-by-form restrictions by letting them all use wands too.

--------------------------------------------------------------------------------
822b61b | advil | 2018-03-24 12:59:16 -0400

Fix the ash autotravel/autoexplore bug (6503 etc)
The problem was that sensed monsters would be immediately marked as
MTRAV_KNOWN_UNREACHABLE, but in _mons_has_path_to_player this value was
effectively used as a cache to decide whether to recalculate the path to
the player. If set, the path would never be recalculated for a sleeping
monster, and this function would always return false. There were a bunch
of special cases that avoided this issue making it harder to diagnose
(there's a hard check for a 1 tile distance that skips pathfinding
altogether, if the monster wakes the path gets recalculated, and
monsters with known ranged attacks that are visible ignore the
pathfinding result, maybe others). This bug also impacted boots of the
assassin (e.g. 11322).

--------------------------------------------------------------------------------
6c1b826 | gammafunk | 2018-03-24 03:21:29 -0500

Tweak the layout of a transporter vault
Add some doors to the arrival area of gammafunk_sealed_library so that
the player will be more likely to need to move out of this room.

--------------------------------------------------------------------------------
e3b9353 | gammafunk | 2018-03-24 02:00:43 -0500

Nerf the Hellbinder wizard lab some
Recent changes made the wave of demons too strong, mostly due to there
being too many tier-2:

<elliptic> hellbinder wizlab is ridiculous now, basically hellion
           island...

Reduce the monster count, mostly by removing tier-2 from the chambers
near the entrance, and reducing them a bit in the other chambers as
well. This is still a tough wizlab that can generates about one hellion
and one tormentor per level and can generate more of those, but it's not
insane now.

--------------------------------------------------------------------------------
c9362ec | Aidan Holm | 2018-03-23 22:37:02 +0800

Fix crash when updating minimap for out-of-map tiles

--------------------------------------------------------------------------------
0df9d5f | Chris Campbell | 2018-03-22 22:14:46 +0000

Don't Gozag bribe summons (#11149)

--------------------------------------------------------------------------------
1df535d | Chris Campbell | 2018-03-22 22:08:09 +0000

Fix messaging for unmelding guardian spirit (#11408)
With permanent mutation-based guardian spirit (either as a VS or a Demonspawn)
there's no need to print any message when unmelding gear grants a level of
guardian spirit.

--------------------------------------------------------------------------------
de484de | Chris Campbell | 2018-03-22 21:56:55 +0000

Don't pick up duplicate amulets of the acrobat (#11383)

--------------------------------------------------------------------------------
09c32aa | Chris Campbell | 2018-03-22 20:30:17 +0000

Fix Sap Magic not properly expiring on Felid death (#11354)
Along with a couple of WJC attributes that shouldn't persist through death.

--------------------------------------------------------------------------------
3d944cd | Chris Campbell | 2018-03-22 20:02:03 +0000

Allow training evocations with the ratskin cloak
Since it has an active ability like the cloak of the Thief.

--------------------------------------------------------------------------------
9b9f04d | Chris Campbell | 2018-03-22 19:36:42 +0000

Add no_tele_into to some closets in grated_community_mu (#11423)

--------------------------------------------------------------------------------
f559e6e | Chris Campbell | 2018-03-21 20:53:06 +0000

Make Ozocubu's Armour expire immediately on movement
Granting a level of ponderous wasn't a very effective downside and the spell
remained extremely widely desirable. Having it break immediately when moving
lets it remain strong when cast directly in combat, but completely prevents
it from being useful to have active when out of combat.

--------------------------------------------------------------------------------
647f2b0 | Chris Campbell | 2018-03-21 19:38:26 +0000

Fix high-power Dispersal working through walls
Other uses of apply_monsters_around_square are all radius 1, so this was only
broken for Dispersal once it gained an increased range with spellpower.

--------------------------------------------------------------------------------
99d1f74 | Chris Campbell | 2018-03-19 16:20:43 +0000

Update orb of destruction description (#11419)

--------------------------------------------------------------------------------
1871b15 | advil | 2018-03-17 21:24:05 -0400

Try updating sdl2 contrib again for xinput errors
This should have happened in 17e5181afb10e1dfc8 but it apparently didn't
take.

--------------------------------------------------------------------------------
9a6c51a | dplusplus | 2018-03-18 00:26:48 +0900

fix help; "stick" tag is not available in current version

--------------------------------------------------------------------------------
dd34a7d | Aidan Holm | 2018-03-17 07:21:33 +0800

Fix missing derived undead tile cases
The only remaining one is for octopodes, but the spectral tile looks
decent and there's no good alternative simulacrum tile, so I've left it
at the default for now.

--------------------------------------------------------------------------------
2e20325 | Aidan Holm | 2018-03-17 04:33:36 +0800

Add undead kraken tentacle tiles (Midn8, #11410)
To track which tentacles are undead tentacles, we set base_type to the
undead type, instead of type; this is *inverted* compared to all other
monsters (not great), but requires only minimal changes to the tentacle
handling code in tilepick.cc; using the reverse (correct) order
requires more extensive refactorings.

Adding multiple first/last-tentacle-tile delimiters isn't great, but is
necessary for the easy conversion from normal- to undead-tentacle tiles.

All of these tiles were automatically generated from the normal kraken
tentacle tiles and could definitely be improved.

--------------------------------------------------------------------------------
69bf1f3 | Aidan Holm | 2018-03-16 04:24:09 +0800

Fix minimap being clipped (Malevolent, #11414)
update_minimap() in turn expands a clip rectangle in tilereg-map.cc to
include the coord. This was not previously being expanded to include the
map border, causing the reported issue.

--------------------------------------------------------------------------------
fa10ee1 | Nikolai Lavsky | 2018-03-15 21:47:09 +0800

Update dream sheep description
Since dream sheep fires are no longer a thing.

--------------------------------------------------------------------------------
8f80174 | Aidan Holm | 2018-03-15 05:14:56 +0800

Fix some weird magic-mapping tile choices
The boundary feature checks make the border tiles blend in with the
floor/wall. The vaults walls special-case applies to all DCHAR_WALL
features, instead of just DNGN_STONE_WALL, because some areas within the
vaults have rock walls, which should be shown with the same tile.

--------------------------------------------------------------------------------
d774a3c | Aidan Holm | 2018-03-15 04:08:56 +0800

Handle shaft-self and hop in _check_ability_possible()
This causes the corresponding menu entries and sidebar tiles to
be correctly greyed out when these abilities are not possible.

--------------------------------------------------------------------------------
660f3e5 | Aidan Holm | 2018-03-15 02:52:51 +0800

Use quadruped skeleton for bears and yaks

--------------------------------------------------------------------------------
b8b0824 | advil | 2018-03-14 10:59:29 -0400

Don't flush messages (potentially switching regions) on spell search
Mostly a problem in wizmode, I think, but basically,
cancellable_get_line isn't designed to be used outside of the messages
pane. This commit does involve a bit of code duplication, and when I
have more time I'd like to convert Menu::title_prompt to use an
EditableTextItem, which would involve better abstraction.

--------------------------------------------------------------------------------
f8199ec | Chris Campbell | 2018-03-12 23:47:47 +0000

Fix shopping lists always displaying "0 thing" (#11409)

--------------------------------------------------------------------------------
3d7ae58 | gammafunk | 2018-03-12 03:55:16 -0500

Prevent monsters from picking up a loot item in a vault
The merfolk impaler would sometimes pick up a weapon loot item and thus
lose its ability to reach attack the player across the lava square. Make
the item into a superb_item so we can mark the item as no_pickup to
prevent this. Previously it used an "acquire any" item, which currently
can't take the "no_pickup" tag, and we'd like to avoid using these loot
items outside of troves in the first place.

--------------------------------------------------------------------------------
8181cae | gammafunk | 2018-03-12 03:41:39 -0500

Tweak monsters and placement for a float vault (mikee)
Allow gammafunk_mikee_crab_dinner to place on D:10- instead of just
D:13-, since the vault uses the same threats as it does in Lair, which
are not so bad compared to what 8 and 9 glyph vault monsters often
generate around D:10.

In Depths, use Flayed Ghosts instead of Titans, since although the
former are a lot flimsier than what they replace, the Flay effect lowers
player HP quickly enough that players might end up actually dying in the
vault. In Zot, replace Klowns and Draconians in the vault with Curse
Toes for similar reasons.

--------------------------------------------------------------------------------
c000056 | Chris Campbell | 2018-03-09 19:30:54 +0000

Reformat some lines
For better coding convention-ness and ease of reading.

--------------------------------------------------------------------------------
ef6b427 | Alan Malloy | 2018-03-09 11:28:03 -0800

Remove erroneous error message in ability menu
Just looking at a menu with Evoke Berserk Rage as an option doesn't
always mean you want to go berserk, so you shouldn't get a message
telling you you can't.

--------------------------------------------------------------------------------
a231a93 | Chris Campbell | 2018-03-09 18:58:30 +0000

Adjust some weapon randart names
Remove a couple of overly silly and/or ungrammatical potential names.

--------------------------------------------------------------------------------
1cc83ef | advil | 2018-03-08 09:17:00 -0500

Simplify

--------------------------------------------------------------------------------
10657f7 | advil | 2018-03-08 08:54:42 -0500

Only send tiles exit reason in game_ended on crash (wheals)

--------------------------------------------------------------------------------
5fdf0d7 | Doesnt | 2018-03-07 22:30:27 +0800

Add auto_hide_spells option

--------------------------------------------------------------------------------
0d8bc90 | Alan Malloy | 2018-03-05 17:04:22 -0800

Clarify explanatory text for Tomb card (Yermak)

--------------------------------------------------------------------------------
f70c721 | Alan Malloy | 2018-03-05 16:59:19 -0800

Simplify code for changing pluses on mace of Variability. (#716)

--------------------------------------------------------------------------------
ab157ee | Alan Malloy | 2018-03-05 13:03:21 -0800

Add NormalPerson7 to CREDITS.txt

--------------------------------------------------------------------------------
9649ee7 | NormalPerson7 | 2018-03-05 12:48:17 -0800

Randomise the placement of the rune in dis_grunt (#715)
Randomise the placement of the rune in dis_grunt

Previously, the rune would be guaranteed to spawn in one of the two corners 
nearest to the entrance, making it a trivial exercise to steal the rune with 
LRD. It functioned as a hoax for new players, because it looks like the rune 
would place in the central structure.

Now, the rune will place in this central structure as expected 20% of the time, 
to make stealing the rune through LRD on the outer walls not guaranteed. The 
other 80% of the time it places in one of the four corners, retaining the hoax 
but also making stealing slightly less trivial.

Also add one additional Hell Sentinel to the end vault, location randomised 
just like the other monsters. It only had 1 Hell Sentinel previously, which was 
lackluster compared to the boss rooms of other Dis:$ vaults.
--------------------------------------------------------------------------------
f0767a5 | Aidan Holm | 2018-03-06 04:03:28 +0800

Revert "Fix wind-blast not applying location effects (advil, Beargit, 
rangerofthewest, #11253)"
This reverts commit 66e28abd87814127e8ae3a727caeabbe4bf002e6.

--------------------------------------------------------------------------------
66e28ab | Aidan Holm | 2018-03-06 03:55:11 +0800

Fix wind-blast not applying location effects (advil, Beargit, rangerofthewest, 
#11253)
Moving actors is postponed in order to print messages in the right
order. apply_location_effects() takes care of monsters being blown onto
traps (the original issue) and should handle other conditions that
weren't previously handled, such as merfolk transformation.

--------------------------------------------------------------------------------
dd11e71 | advil | 2018-03-04 21:01:06 -0500

Make phrasing less awkward
I didn't proofread this one enough..

--------------------------------------------------------------------------------
34c0b7b | advil | 2018-03-04 15:21:54 -0500

Cleanups to game restarting and the main menu
The main point of this change is to remove a few more die/fail/end calls
that boot the player from the main menu regardless of their settings (on
exiting from an upgrade prompt, or on an incompatible save), making it
act more like a real menu. In order to get this to work right, I needed
to do a bunch of other things:

 * regularize how error/info messages are shown in the main
   menu (always in the bottom line, where tooltip-type information is
   shown). It's a bit hacky, but less so than before.
 * cleaned up an ad hoc message for bad names in the main menu.
 * support passing a message to be shown in this spot on game_ended. The
   main use case is game_exit::abort.
 * improve messages for upgrade prompts
 * make clearer a previously surreptitious static variable in
   _show_startup_menu
 * do a better job returning to the main menu position on restart, to
   preserve the illusion that nothing has changed. (I couldn't figure
   out a great way to do this without adding even more global state,
   unfortunately.)

Overall, the fact that we return to the main menu by more or less
*restarting the entire program* remains just as insane as it was before.

--------------------------------------------------------------------------------
e769cdc | advil | 2018-03-04 15:21:53 -0500

Tell player if monster can never be recited to (m-aigner / 10416)
This adapts m-aigner's code from https://github.com/crawl/crawl/pull/379

The previous messaging seemed to have been actively wrong (the HD
calculation is different than what seems to happen in god-abil.cc), so I
decided it was time to finally merge a version of this, fixing the crash
discussed in the PR thread. The new version still only checks particular
monsters, so as discussed in the PR thread, something that looks at a
monster_info might be desireable. In principle this more accurate info
can leak information about a monster's spellset, but for that to happen,
I think there would have to be something like a monster with multiple
spellsets and subhuman intelligence, which as far as I can tell doesn't
exist right now.  Calculating over monster_info might deal with that
case as well, if it were to ever come about.

Resolves #379

--------------------------------------------------------------------------------
5284510 | Aidan Holm | 2018-03-05 00:50:09 +0800

Add note about tomb walls' early collapse (advil)

--------------------------------------------------------------------------------
2e530e8 | Aidan Holm | 2018-03-05 00:41:21 +0800

Make entombment more consistent (NormalPerson7, #11405)
This commit simplifies the set of features that the tomb card effect
will convert to a wall. The feat_is_door() check allows closed doors
to be filled; before this commit, they were left untouched and could
be opened.

--------------------------------------------------------------------------------
af95ca0 | Andy Roche | 2018-03-03 13:02:48 -0500

Fix grammar of MUT_SLOW_METABOLISM.

--------------------------------------------------------------------------------
f9d0ce5 | Aidan Holm | 2018-03-02 13:46:58 +0800

Fix ctrl-x refresh issue (gammafunk)

--------------------------------------------------------------------------------
cace5d2 | wheals | 2018-02-28 11:52:09 -0500

Clarify Lugonu disto protection (Fingolfin).

--------------------------------------------------------------------------------
072727e | wheals | 2018-02-28 11:41:08 -0500

Identify the starting book (Dynast).

--------------------------------------------------------------------------------
848dc5c | advil | 2018-02-28 11:11:19 -0500

Don't allow repeating shop actions with `
Now that this doesn't crash, the only use case we can find for this is
expensive miskeys (I suspect the crashes were miskeys themselves). This
also prevents repeats on altars, which I'm not sure matters.

--------------------------------------------------------------------------------
c6edcda | advil | 2018-02-28 11:00:53 -0500

More consistently check for repeats in menu code
This was causing a crash in shop code, which calls draw_more directly,
because certain variables are only initialized if the menu has been
drawn.  For example, the following key sequence triggered it on any
shop, ignoring spaces: > ! a ESC ESC `

--------------------------------------------------------------------------------
c8378ba | Aidan Holm | 2018-02-28 04:58:54 +0800

Fix oversized infestation tile (NormalPerson7, #11404)
[skip ci]

--------------------------------------------------------------------------------
bddf880 | Aidan Holm | 2018-02-22 23:21:27 +0800

Don't do client-side direction key wrangling
The on-numpad keys (pgup/down, etc) were converted to arrow keys before
they were sent to the server. This is unnecessary, since crawl maps
these keys to the correct movement commands, and broke page up/down.

This should not introduce any incompatibility with older versions of
crawl: crawl began mapping these keys at e75f4e49b8d8, which is included
in 0.5 and newer, which is before crawl supported webtiles.

--------------------------------------------------------------------------------
dc04c06 | Alan Malloy | 2018-02-21 12:35:47 -0800

Prevent generating some grammatically incorrect randart names
Notably, stuff like [GOD]'s [thing that's not a noun].

--------------------------------------------------------------------------------
6acd07a | Alan Malloy | 2018-02-21 12:35:26 -0800

Fix up a number of comments in randart naming code
Mostly this meant removing them, because they didn't say anything useful,
but a couple just needed tidying up.

--------------------------------------------------------------------------------
58d4f8e | Alan Malloy | 2018-02-21 12:35:26 -0800

Move one particularly silly weapon name to the jokes section

--------------------------------------------------------------------------------
66ef5e3 | Alan Malloy | 2018-02-21 12:35:26 -0800

We should at least spell our silly words correctly

--------------------------------------------------------------------------------
4884353 | Aidan Holm | 2018-02-22 02:18:15 +0800

Fix memorise menu heading glitch
A menu's items are only indented if at least one item has a tile. When
switching between memorise-menu pages with zero and >1 spells listed (or
vice-versa), the item indentation would change. This caused the subtitle
to shift around. To fix this, we just ensure that tile indents are
always used by giving this entry an invisible tile.

--------------------------------------------------------------------------------
1f6c355 | Aidan Holm | 2018-02-22 02:17:34 +0800

De-dup memorise menu paging text for local tiles

--------------------------------------------------------------------------------
539252a | advil | 2018-02-20 22:58:05 -0500

Unbrace / checkwhite

--------------------------------------------------------------------------------
54792a9 | advil | 2018-02-20 22:57:13 -0500

Don't let an undocumented texture setting affect fonts
This is one of those commits where I'm not really sure what's going on,
but it seems that we probably don't want to apply this gl texture filter
setting (GL_LINEAR) to glyph textures.  Specifically, this was (no idea
why) causing local tiles colour_bars to not render properly, as reported
by dolemite99 in:
https://crawl.develz.org/tavern/viewtopic.php?f=9&t=25131

--------------------------------------------------------------------------------
d711f93 | Chris Campbell | 2018-02-20 15:58:44 +0000

Fix formatting on a help menu

--------------------------------------------------------------------------------
4386d7c | Chris Campbell | 2018-02-20 15:40:57 +0000

Mark PoG only temporarily useless when in Zot but without the orb (|amethyst)
Since you could still leave and go elsewhere, so it should still be possible
to memorise the spell.

--------------------------------------------------------------------------------
be7b7cd | Chris Campbell | 2018-02-20 15:33:12 +0000

Improve spell library display and messaging
Mark permanently useless spells as hidden by default, and show a count of
hidden spells on the memorisation screen (the formatting here could be better,
though). Also improve the messages when adding spells to the library to be less
spammy.

--------------------------------------------------------------------------------
6ad8dc3 | Chris Campbell | 2018-02-20 15:30:37 +0000

Don't mark cloud spells as permanently useless under Still Winds

--------------------------------------------------------------------------------
97f78ea | Ian Caltabiano | 2018-02-20 14:05:09 +0000

Mark axes as a preferred weapon type for Ogres (#11391)

--------------------------------------------------------------------------------
d1b7544 | Neil Moore | 2018-02-20 09:00:22 -0500

Remove Trog spellbook autopickup special-case.

--------------------------------------------------------------------------------
362d6f4 | Chris Campbell | 2018-02-20 13:55:10 +0000

Note the effect of Invo skill in Nemelex description (#11393)

--------------------------------------------------------------------------------
1b571ea | advil | 2018-02-19 19:38:53 -0500

Remove useless butchering, and improve butchery code
With doors pushing items out of the way, there's basically[1] no reason to
chop corpses that are entirely inedible for your species. This removes
that possibility and accordingly simplifies the butchery interface.
Because I tried to improve the messaging, things didn't get much
shorter, but hopefully the situation is overall clearer. I also removed
a goto. The interface could be even simpler, as there's very little
practical reason to use 'n'.

1 There are rare corner cases where a corpse may still jam a door. I
think these are rare enough to ignore entirely, but if someone
disagrees, the best way to handle it with something like the behavior
before this commit I think would be to add a * command to the butchery
menu that allows chopping them, similar to many inventory commands,
rather than have them show up in the basic butchery list. Alternatively,
one could just destroy the corpses. I've coded up a version that does
this if anyone wants, but it has weird interactions with god conducts so
I paused.

--------------------------------------------------------------------------------
17e5181 | advil | 2018-02-19 19:25:55 -0500

Update sdl2 contrib (maybe fixing XINPUT errors on msys2)

--------------------------------------------------------------------------------
59181c3 | wheals | 2018-02-19 18:56:16 -0500

Don't request books for troves (#11395).

--------------------------------------------------------------------------------
3692b99 | Aidan Holm | 2018-02-19 16:27:47 +0800

Fix ability descriptions not visible on webtiles (droogie, #11390)

--------------------------------------------------------------------------------
ae599e4 | Aidan Holm | 2018-02-19 16:27:47 +0800

Colourise the ability menu

--------------------------------------------------------------------------------
c2f0fb8 | Aidan Holm | 2018-02-19 16:27:47 +0800

Add _check_ability_dangerous()

--------------------------------------------------------------------------------
c850c1e | Aidan Holm | 2018-02-19 16:27:47 +0800

Move ability checks to _check_ability_possible()
Among other things this fixes a bug where the SDL tiles ability menu was
not correctly indicating that abilities weren't possible.

--------------------------------------------------------------------------------
8cf3520 | Muffindrake | 2018-02-18 03:31:59 -0800

Iron out typo in Zephyr's description

--------------------------------------------------------------------------------
0f5d773 | wheals | 2018-02-17 21:04:51 -0500

Fix Tiles compile/warnings.

--------------------------------------------------------------------------------
f4362f2 | wheals | 2018-02-17 21:04:51 -0500

Fix typo/reword.

--------------------------------------------------------------------------------
87fe873 | wheals | 2018-02-17 21:04:51 -0500

Allow searching for spells in the memorise menu.
The search matches either on spell names or spell types (so you can see
all the translocation spells at a glance, for instance).

The extra newline was removed from menu.js since it seems the browser
adds its own newline (tested this with the \ menu and it works the same
as before).

--------------------------------------------------------------------------------
2cf55e6 | wheals | 2018-02-17 21:04:51 -0500

Remove references to starting books from background descriptions.
Better writing very welcome.

--------------------------------------------------------------------------------
692369f | wheals | 2018-02-17 21:04:51 -0500

Show unmemorisable spells in the memorise menu.
I wasn't convinced at first this was a good idea, but people pointed out
that there ought to be some feedback about what happens to spells that
you pick up that you can't memorise, and why you can't memorise them.

--------------------------------------------------------------------------------
b0bc94e | wheals | 2018-02-17 21:04:51 -0500

Remove memorising spells from a book by clicking on it.
With goldified books, I'm not sure this is ever useful. If you've
identified a book, its contents are in your spell library. The one
exception might be a book from a store that couldn't fit into your
inventory but that's a really small edge case.

--------------------------------------------------------------------------------
b0e1f0f | wheals | 2018-02-17 21:04:51 -0500

Prevent some harmless(?) JS errors.

--------------------------------------------------------------------------------
b74d8c8 | wheals | 2018-02-17 21:04:51 -0500

Remove some other vestiges.

--------------------------------------------------------------------------------
f475dab | wheals | 2018-02-17 21:04:51 -0500

Fix a webtiles bug with using the mouse on menu entries.
This would stop working after the first time the entry list was refreshed;
previously this affected only the shopping menu but it also affected the
memorisation menu as well.

--------------------------------------------------------------------------------
b1bc8ad | wheals | 2018-02-17 21:04:51 -0500

Allow hiding spells from the main screen of the memorisation menu.
In every game the player runs into tons of spells they have no
interest in memorising. Combined with the new spell library, this would
tend to lead to tons of clutter.

--------------------------------------------------------------------------------
fee09f9 | wheals | 2018-02-17 21:04:51 -0500

Exterminate you.had_book too.

--------------------------------------------------------------------------------
e3f13c2 | Doesnt | 2018-02-17 21:04:51 -0500

Don't let Vehumet offer spells that are already in your library

--------------------------------------------------------------------------------
751bf6f | Doesnt | 2018-02-17 21:04:51 -0500

Exterminate seen_spells.
Now redundant unless a mechanism is added to make spells leave the library
(unlikely).

--------------------------------------------------------------------------------
a98daa0 | Doesnt | 2018-02-17 21:04:51 -0500

Replace failed book acquirements with manual acquirements.
Except for Xom and Sif gifts.

--------------------------------------------------------------------------------
3921d5a | Doesnt | 2018-02-17 21:04:51 -0500

Mark books with only unlearnable spells as useless

--------------------------------------------------------------------------------
f64ed86 | Doesnt | 2018-02-17 21:04:51 -0500

Remove book burning from the tutorial

--------------------------------------------------------------------------------
4c6852c | Doesnt | 2018-02-17 21:04:51 -0500

Remove Trog's Burn Spellbooks ability.
Spellbooks are not marked as useless so as to keep autopickup on, since the
player may switch gods still.

--------------------------------------------------------------------------------
8827bed | Doesnt | 2018-02-17 21:04:51 -0500

Mark books with no new spells as useless

--------------------------------------------------------------------------------
5f84044 | Doesnt | 2018-02-17 21:04:51 -0500

Implement spell library

--------------------------------------------------------------------------------
464ede7 | Corin Buchanan-Howland | 2018-02-17 15:28:59 -0500

Give monster minotaurs armor and javelins
This toughens them up a bit and makes them harder to kite. This is intended
primarily as a labyrinth challenge buff, since minotaurs are otherwise only
spawned by a few vaults or shape-shifted into.

--------------------------------------------------------------------------------
879740d | Chris Campbell | 2018-02-17 16:29:22 +0000

Make some accuracy penalties consistent for aux unarmed
There are still a bunch of weird inconsistencies and it'd be good to properly
de-duplicate this code with the regular to_hit calculations.

--------------------------------------------------------------------------------
430cd93 | Chris Campbell | 2018-02-17 16:29:22 +0000

Generalise starvation penalty checks
De-duplicates a lot of checks for starving players that don't apply to vampires
or ghouls (such as inability to use abilities/spells). Has a couple of minor
gameplay effects, with starving ghouls no longer having a penalty to accuracy
or damage.

--------------------------------------------------------------------------------
5403bb0 | Chris Campbell | 2018-02-17 16:29:22 +0000

Fix bloodless Vampires having their accuracy penalised

--------------------------------------------------------------------------------
f9081d1 | Chris Campbell | 2018-02-17 16:29:22 +0000

Turn res_wind into res_tornado
Wind doesn't make much sense as a general resistance, since its main effect is
just making a tiny selection of enemies be unexpectedly immune to airstrike and
Qazlal wind attacks. It's more reasonable as just tornado immunity, since
almost everything that has it casts tornado innately (with Sojobo still being a
weird exception due to her air elemental band).

--------------------------------------------------------------------------------
c748515 | Chris Campbell | 2018-02-17 16:29:22 +0000

Fix dream sheep genus using a removed monster
To avoid problems on save compat break.

--------------------------------------------------------------------------------
1d1b100 | Chris Campbell | 2018-02-17 16:29:22 +0000

Remove dream sheep fires
The special-cased sticky flame mechanic isn't really justifiable with sheep now
being a real enemy that's intended to be threatening instead of mostly just a
joke.

--------------------------------------------------------------------------------
4ac3794 | Aidan Holm | 2018-02-17 22:42:13 +0800

Fix stash menu redraw issues
... and clean up some other odds and ends.

--------------------------------------------------------------------------------
ee22f27 | Aidan Holm | 2018-02-17 02:50:44 +0800

Fix some local tiles menu bugs (Etesian, #11389)

--------------------------------------------------------------------------------
9299d87 | Aidan Holm | 2018-02-16 21:44:15 +0800

Fix sending webtiles messages in wrong order

--------------------------------------------------------------------------------
4828832 | Aidan Holm | 2018-02-16 20:04:50 +0800

Add on_single_selection() hook

--------------------------------------------------------------------------------
6a83056 | Aidan Holm | 2018-02-16 20:04:50 +0800

Fix titles persisting between menus

--------------------------------------------------------------------------------
6ffc940 | Chris Campbell | 2018-02-15 19:23:17 +0000

Revert monster minotaur speed and adjust other stats
Monster versions of player species are a case where the symmetry should be at
least reasonably close, so breaking it substantially by having the monster
version be fast isn't a good way of buffing monster minotaurs. Instead increase
their health, defenses and HD slightly.

--------------------------------------------------------------------------------
8d23802 | Aidan Holm | 2018-02-15 16:11:28 +0800

Fix use of incorrect tile variants

--------------------------------------------------------------------------------
9b7402f | Aidan Holm | 2018-02-15 15:47:09 +0800

Allow lowercase letters from choose_stat_gain hook

--------------------------------------------------------------------------------
981819d | Aidan Holm | 2018-02-15 15:31:59 +0800

Fix pixel-perfect rect drawing

--------------------------------------------------------------------------------
d686732 | Aidan Holm | 2018-02-15 15:01:06 +0800

Seed domino generation with branch:depth
Domino generation was randomized for every level load, which caused
floor tiles using dominos (only crypt afaik) to vary when reloading the
level: going up and down stairs, or saving and reloading the game.

Now, the rng is seeded with the current branch and depth as well as the
game seed, which is marshalled in saves.

Side note: that dominoes.Generate() call takes up most of level load
time, even though most levels don't use domino tiles..

--------------------------------------------------------------------------------
55dd942 | Aidan Holm | 2018-02-15 15:00:00 +0800

Replace you.game_seeds[] with you.game_seed
This seed is currently only used for generating tile difficulties for
passive mapping, so there's only one seed in the array anyway.

More importantly, there's no logical reason for different parts of crawl
to use different seeds; this is used to seed domain-specific RNGs, and
there's no risk of these RNGs interfering with each other.

--------------------------------------------------------------------------------
3d3d9be | Aidan Holm | 2018-02-15 13:30:15 +0800

Remove useless use of std::map

--------------------------------------------------------------------------------
e330310 | Alan Malloy | 2018-02-14 12:33:15 -0800

Add a wizard command to list keys with no assigned command
As of the time of this commit, the list of free keys in the main area
of a US-English keyboard is pretty short:

] - ^M p ^T ^V

--------------------------------------------------------------------------------
7362139 | Aidan Holm | 2018-02-14 16:30:35 +0800

Fix broken colour_bar rendering on local tiles

--------------------------------------------------------------------------------
9e71ff9 | Aidan Holm | 2018-02-14 13:33:57 +0800

Simplify font atlas lookup LRU management
The main purpose of this commit is to improve code clarity. The previous
map container implementation and the replacement vector-based
implementation perform roughly the same.

Should it become necessary (for when offline crawl gets serious about
i18n), this new version is also much easier to optimize:
 - could store index into atlas in glyph table, to remove iteration
 - could remove LRU vector and add atlas entry hit counters, moving
   expensive path to atlas eviction.

--------------------------------------------------------------------------------
11d8d7a | Aidan Holm | 2018-02-14 13:33:57 +0800

Don't call map_unicode() for non-renderable glyphs
A recent test showed that around 85% of glyphs that hit map_unicode()
are spaces. These spaces are coming from the message region and other
text regions; they appear to send the entire line to the renderer, not
just the text portion.

--------------------------------------------------------------------------------
b22368a | wheals | 2018-02-13 15:39:43 -0500

Remove an unnecessary member from ShopMenu.

--------------------------------------------------------------------------------
ef5cdb2 | wheals | 2018-02-13 15:25:13 -0500

Move some shop menu code into Menu.
This will allow using something similar for the upcoming new memorise
menu without code duplication.

--------------------------------------------------------------------------------
b5258fd | Aidan Holm | 2018-02-13 15:03:10 +0800

Remove list_commands() redraw parameter

--------------------------------------------------------------------------------
e53cf38 | Aidan Holm | 2018-02-13 15:03:10 +0800

Use single column for menus if there's enough space (advil)

--------------------------------------------------------------------------------
11ddb1a | Aidan Holm | 2018-02-13 15:03:10 +0800

Add section dividing line (advil)

--------------------------------------------------------------------------------
368cd01 | Aidan Holm | 2018-02-13 15:03:10 +0800

Move menu title rendering to mdisplay
This refactor moves all menu title rendering from the CRT layer to the
mdisplay backend, and simplifies a number of interfaces.

- Title suffixes have been removed. Instead, code that wishes to update
the title dynamically can override calc_title(), which is called
whenever the title is about to be changed.

- On local tiles only, filtering menus now uses a custom line reader
that overrides the displayed title, since the CRT line reader can no
longer be used. Using the existing line reader on console and webtiles
is fine, and has been left alone. The title is overloaded in this way
because it ensures that the filter UI correctly handles resize events:
having multiple UI layers try to handle redraw is almost impossible to
make work.

- update_title() and write_title() have been merged with draw_title()

--------------------------------------------------------------------------------
6e0fa9b | Aidan Holm | 2018-02-13 15:03:10 +0800

Remove Menu text-only option
This commit removes the text_only constructor option, and always uses
MenuDisplayTile on local tiles, and MenuDisplayText on everything else.
(Except for formatted_scrollers).

MenuRegion already supports rendering menus without tile icons
(when tile_menu_icons = false), so this commit simply adds an additional
check that the menu entries have tiles. This removes a whole host of
conditional checks, and will allow removal of CRT code on local tiles.

--------------------------------------------------------------------------------
61877e1 | Aidan Holm | 2018-02-13 15:03:10 +0800

2-col tile menus: wrap horizontally and support line scrolling
This commit re-adds support for scrolling MenuDisplayTile menus by line,
and does a fair amount of general MenuRegion refactoring as well:

 - Menus now limit the height of each page to ensure that <= 52 items
 can be shown on a page: this greatly simplifies pagination. In
 practice, this is slightly shorter than a full 1080p screen.
 - MenuRegion::place_buffers() has been split into two functions that do
 layout and pack buffers respectively, rather than having one function
 that does both.

Non-ideal bits:

 - Scrolling state for tile menus is now mostly located in
 tilereg-menu.cc, instead of menu.cc: scrolling requires knowledge of
 the menu item sizes and screen positions, so the MenuDisplayTile
 scrolling methods mostly proxy MenuRegion methods.
 - set_menu_display() is used to detect switching between menus.
 - this predates this commit, but the need to check entry.valid all
 over the place makes this code pretty bug-prone.

--------------------------------------------------------------------------------
c7e3d39 | Aidan Holm | 2018-02-13 15:03:10 +0800

Remove limit on lookup-help results length
Menus now automatically handle duplicated hotkeys, so we don't need to
limit the length ourselves. Also made the menu use two columns on local
tiles.

--------------------------------------------------------------------------------
136611b | Aidan Holm | 2018-02-13 15:03:10 +0800

Refactor Menu scrolling into MenuDisplay
This commit moves the scrolling handling for Menus into the MenuDisplay
class. This is necessary because the menu itself does not have the
layout information necessary to scroll or render the current page of
items, only the renderer (MenuDisplay) does.

Below, "Tile menu" means a menu using a MenuDisplayTile instance;
likewise "Text menu" means a menu using a MenuDisplayText instance.

There are a number of other changes+improvements this commit makes:

 - the two MenuDisplay derived classes have been moved into menu.cc
 - an MF_USE_TWO_COLUMNS flag has been added for TILES_LOCAL builds
 - Tile menus force a page break before a duplicate hotkey
 - Text menus limit their pagesize to 52 rows if duplicate hotkeys are
   detected. This approach keeps the Text menu scrolling/layout code simple.
 - showing the --more-- line now works correctly with menus with
   multiple parts delimited by MEL_END_OF_SECTION
 - scrolling formatted_scrollers with home/end keys now stays within the
   current section. This breaks the ? help menu, but I've added a small
   hack for that. It's still broken on webtiles, but it was like that
   alrady.

Removal of functionality:

 - Tiles menus can no longer be scrolled by line, as the notion of
   scrolling by line does not work well when combined with two-column
   layouts. Scrolling to an item scrolls to the page containing that item.

--------------------------------------------------------------------------------
6a01d73 | Aidan Holm | 2018-02-13 15:03:10 +0800

Remove column_compoer set_pagesize()
This was used to add separator newlines to composed text, except at page
boundaries. This doesn't work any more because the page size can change
on resize, so we just show separator newlines either way.

--------------------------------------------------------------------------------
d84e81a | Aidan Holm | 2018-02-13 15:03:10 +0800

Remove unused menu.f_drawitem hook

--------------------------------------------------------------------------------
717c7b6 | Aidan Holm | 2018-02-13 15:03:10 +0800

Explicitly set MF_SINGLESELECT on describe menu

--------------------------------------------------------------------------------
6b2ca4f | Aidan Holm | 2018-02-13 15:03:10 +0800

Assert that menus have a valid selection flag

--------------------------------------------------------------------------------
e39abd2 | Aidan Holm | 2018-02-13 15:03:10 +0800

Remove menu.set_maxpagesize interface
This was used to prevent hotkeys from being reused on a single page.
This changes the behaviour to automatically limit the number of items
shown on a single page if any of them are selectable.

--------------------------------------------------------------------------------
5351223 | Alan Malloy | 2018-02-12 16:50:55 -0800

Fix Dowan's reaction to Duvessa dying far away (minmay)
Dowan is really more of a moper than a rager.

(I accidentally made too broad a change in bf6022e)

--------------------------------------------------------------------------------
89cf10f | advil | 2018-02-12 14:16:27 -0500

Workaround for travis erroring related to ppa.launchpad.net
These errors lead to an out-of-date package list being used, which then
causes the build to error relating to the libsdl2-dev package.  The
timeout may need further tweaking, and hopefully there'll be a point
where travis will fix this, but this basically works for me in my fork,
so I'm going to try adding it to master. See ongoing discussion in the
following issue:

https://github.com/travis-ci/travis-ci/issues/9112#issuecomment-364629682

--------------------------------------------------------------------------------
55045ed | Aidan Holm | 2018-02-12 22:58:30 +0800

Fix alignment for ability & spell menu headings

--------------------------------------------------------------------------------
4451672 | Aidan Holm | 2018-02-12 20:49:48 +0800

Check floor items for digit inscriptions
The main use-case is reading known scrolls and quaffing known potions
from the ground without switching menu sections with ,

--------------------------------------------------------------------------------
33bf127 | advil | 2018-02-11 14:25:15 -0500

Have shock serpent retaliation check rElec
rElec for the retaliation fineff has apparently not been checked, at
all, either for monster or player attackers, since 494c5fece274. For
player attackers, this change is a major nerf to shock serpents if you
have rElec, so given that they have always been this way, they may need
some further balance adjustments to make them not completely trivialized
by rElec.  This change also prevents shock serpent recursion (pointed
out as a bug by u/eazyirl,
https://www.reddit.com/r/dcss/comments/7wtmkr/shock_serpent_recursion_has_dungeo
n_science_gone/,
since shock serpents have rElec+++.)

I also added an expose_to_element call to ensure that retaliation
triggers qazlal elemental adaptation (also wasn't happening).

--------------------------------------------------------------------------------
198051c | Aidan Holm | 2018-02-10 13:08:49 +0800

Add WME_MOUSEWHEEL
The main benefit this brings (apart from code tidiness) is the ability
to check whether the next event is a mousewheel event, which will allow
processing multiple mousewheel events without redrawing the screen.

--------------------------------------------------------------------------------
cc81d7a | Aidan Holm | 2018-02-10 12:39:31 +0800

Use travel keys for ?/B menu entries

--------------------------------------------------------------------------------
7ce444f | Tomas Krag Hansen | 2018-02-08 12:28:21 -0500

Putting the honeycombs back in the bee hives.

--------------------------------------------------------------------------------
f028f7a | advil | 2018-02-08 11:10:36 -0500

Show >0 skill message (if needed) when entering skill menu (dds1)
Before this would only show when you try to exit the menu without any
skills enabled; this will also show it if you enter the menu with 0
skills enabled (e.g. after reaching a skill target with just that skill
training).

It might make sense to remove the more() before entering the skill menu
with 0 skills trained, with this change.

--------------------------------------------------------------------------------
169b76a | Aidan Holm | 2018-02-08 10:18:06 +0800

Fix kbhit() for multi-char textinput events (advil)

--------------------------------------------------------------------------------
ba4b0f4 | Corin Buchanan-Howland | 2018-02-07 20:07:34 -0500

Let regeneration amulets work again for players that can heal.
I'm on fire!

--------------------------------------------------------------------------------
4ef6cfa | Corin Buchanan-Howland | 2018-02-07 20:06:41 -0500

Fully disable acrobat while using Wu Jian attacks.

--------------------------------------------------------------------------------
da3306a | advil | 2018-02-07 09:53:38 -0500

If there's no assert message on crash, put signal into the noun
This includes the signal information in the crash milestone if there's
no assert message; before, the milestone would just be empty (which I
guess translates to "?"). It also will give the signal info on the first
line of the crash dump in these circumstances so that any non-windows
crash dump always has a cause on the first line.

--------------------------------------------------------------------------------
548d406 | Neil Moore | 2018-02-07 08:44:37 -0500

Make waiting work again.
Broken in bc573f345, which made waiting take neither time nor a turn.

--------------------------------------------------------------------------------
65f3478 | Neil Moore | 2018-02-07 08:44:35 -0500

Brace.
[skip ci]

--------------------------------------------------------------------------------
bc573f3 | Corin Buchanan-Howland | 2018-02-07 08:32:55 -0500

Let amulet of the acrobat work while waiting (Hellmonk)
Since otherwise people will be incentivized to move and forth while waiting.

Also, some light clean-up on the initial Acrobat commit and actually
enable the amulet to spawn.

--------------------------------------------------------------------------------
005426d | Aidan Holm | 2018-02-07 14:56:49 +0800

Handle multiple keys in SDL textinput

--------------------------------------------------------------------------------
870e420 | Corin Buchanan-Howland | 2018-02-06 22:11:05 -0500

Create new amulet: amulet of the acrobat
This amulet boosts the EV of the wearer by 15 only during move actions.
The boost only applies during the execution of the move action, though the
enhanced EV is visible until the player takes another action.

The amulet must be worn at full hp before it begins to operate.

The thought process here is that there's interesting design space around
adding effects to basic actions. The boost size is intentionally quite large
to attempt to balance out the amulet doing nothing during turns spent
fighting.

--------------------------------------------------------------------------------
f2798f9 | Aidan Holm | 2018-02-06 17:36:29 +0800

Make rectangle rendering pixel-perfect
Offsetting two of the borders renders all of the corners (previously,
the top-left pixel was left out) and ensures that semitransparent pixels
are not double-rendered.

Pixel-perfection still depends on drivers not stuffing up line
rendering; 0.5px should probably be added to all coordinates at some
point.

--------------------------------------------------------------------------------
fdd7f25 | Corin Buchanan-Howland | 2018-02-05 21:28:36 -0500

Change labyrinth risk-reward: reduce loot
This trims 1-3 items from the loot pool the minotaur guards. It's a small
adjustment, but I'm not certain it needs too much more.

This and the prior commit are short-term adjustments, but I know there are
plans for a larger fix in the longer term.

--------------------------------------------------------------------------------
1a64493 | Corin Buchanan-Howland | 2018-02-05 21:24:34 -0500

Change labyrinth risk-reward: buff minotaurs
Improve minotaur speed from 10 to 12 and MR from 60 to 100. This should
make them quite nasty for the depth labs appear at, though still killable.

--------------------------------------------------------------------------------
dab028f | Corin Buchanan-Howland | 2018-02-05 20:58:15 -0500

Improve some god welcome messages (Dingbat)
I didn't use any of Dingbat's suggestions, but I was inspired to do this
by them.

--------------------------------------------------------------------------------
e17c957 | Chris Campbell | 2018-02-05 20:21:44 +0000

Don't allow memorising from books in shops without buying them (drazt1k)

--------------------------------------------------------------------------------
83aada6 | Alan Malloy | 2018-02-05 06:46:40 +0000

Fix a compiler warning: uints are never less than 0

--------------------------------------------------------------------------------
91cc6d7 | advil | 2018-02-04 13:05:25 -0500

Don't crash if Duvessa dies when Dowan is polymorphed
If the new form is non-casting, mons->spells would be empty, leading to
a segfault. This commit simply prevents him from getting spells in these
cases (which are usually something like a worm). There are also rare
cases where this code probably would've worked, overwriting some spells,
but these are things like a boggart where we probably want him to keep
the poly'd spells.

--------------------------------------------------------------------------------
8de8177 | wheals | 2018-02-04 12:45:05 -0500

Give the actual correct color.
Dark blue was too easily confusable with mapping, not much uses brown.

--------------------------------------------------------------------------------
db5935f | wheals | 2018-02-04 12:43:46 -0500

Clear the minimap on Abyss shift.

--------------------------------------------------------------------------------
22cbc13 | wheals | 2018-02-04 12:35:12 -0500

Don't show explore horizon around magic mapped locations.
Reduces the clutter for Deep Dwarves.

--------------------------------------------------------------------------------
7f09d74 | wheals | 2018-02-04 12:34:39 -0500

Don't show explore horizon in Labyrinth and Abyss.
It only contributed to visual clutter.

--------------------------------------------------------------------------------
f571278 | wheals | 2018-02-04 12:34:04 -0500

Darken the default explore horizon color.
Still open for suggestions on a better one.

--------------------------------------------------------------------------------
83a10e5 | Neil Moore | 2018-02-01 11:37:04 -0500

Fix grammar in Gnoll manual entry (Ge0ff)
[skip ci]

--------------------------------------------------------------------------------
6f012ad | Doesnty | 2018-01-30 20:45:14 -0500

Allow Fulminant Prism and Lightning Spire to be cast on traps. (#536)

--------------------------------------------------------------------------------
8af8940 | wheals | 2018-01-30 20:44:46 -0500

Fix a crash when targetting near a friendly monster.
Also, unbrace.

--------------------------------------------------------------------------------
090d9d4 | jmbjr | 2018-01-30 20:36:38 -0500

Discourage summoned creatures from Bolting their summoners (jwoodward48ss) 
(#613)

--------------------------------------------------------------------------------
21b7597 | wheals | 2018-01-30 20:05:21 -0500

Refactor god_hates_item_handling.
Removes some duplication of conducts.

--------------------------------------------------------------------------------
47a4871 | wheals | 2018-01-30 18:32:48 -0500

Refactor testing whether items are forbidden.

--------------------------------------------------------------------------------
78804fe | wheals | 2018-01-30 17:16:00 -0500

Remove some leftover purple chunk handling code.

--------------------------------------------------------------------------------
68cc883 | wheals | 2018-01-30 11:03:15 -0500

Require uppercase letters for SID prompt (Sprucery, minmay).

--------------------------------------------------------------------------------
fbf05e5 | wheals | 2018-01-30 10:39:49 -0500

Correctly mark partially-ided weapons evil or useless (#9545, #10724).
Closes #691 PR.

--------------------------------------------------------------------------------
50b93cf | wheals | 2018-01-30 08:37:12 -0500

Refactor lambdas in l_item_do_stacks (|amethyst).

--------------------------------------------------------------------------------
307c7c3 | Matthew Boeh | 2018-01-29 23:47:03 -0500

Allow lich form to set gargoyle holiness to undead (#688)
This was broken in 63fd1ff.
--------------------------------------------------------------------------------
0de994a | wheals | 2018-01-29 23:28:45 -0500

Give jobbed monsters a random base type in ?/M.
None of the options here seem ideal:

* Showing all possible combinations would make the list way too big, and
  it would be annoying if ?/M on "red draconian" or on "draconian knight"
  gave a menu, instead of just showing the specific monster type
  searched for.
* The previous code showed a Platonic ideal of a monster, one that you
  would never actually find in the wild. Not very useful.
* If this randomness is too weird, we could take the approach derived
  undead do and only show the monster description, but that would be
  pretty unhelpful.
* The solution I went with here might confuse someone who wonders why
  the description keeps changing. Plus, it still doesn't allow searching
  for "red draconian monk" directly, for example, so the only way to see
  a particular combination is to refresh the entry a few times. (This
  isn't a regression, though, since before it was impossible to see a
  particular combination.)

Fixes #695 issue.

--------------------------------------------------------------------------------
991379f | wheals | 2018-01-29 22:53:28 -0500

Make i, (, and ) in the targetting UI obey keymapping.
This is still a bit of a hack; arguably it would be better code-wise to
add separate commands for doing these things on the firing screen, but
this would add mostly needless work for people remapping their keys.

Removes the (totally undocumented that as far as I can see) aliases of
^P for ( and ^N for ).

Fixes #706 issue.

--------------------------------------------------------------------------------
ea6f5a2 | wheals | 2018-01-29 22:17:14 -0500

Treat wands like other stackables for autopickup (#11305).
The alternative implementation would be to make is_stackable_item return
true for wands, but that has more far-reaching consequences.

--------------------------------------------------------------------------------
c8a8a66 | wheals | 2018-01-29 21:51:43 -0500

Fix local tiles minimap not properly showing transporters.

--------------------------------------------------------------------------------
6540597 | wheals | 2018-01-29 21:51:12 -0500

Fix the order of tile color options to match the enum.
Or in one case, to be alphabetical.

--------------------------------------------------------------------------------
13168bc | wheals | 2018-01-29 21:37:44 -0500

Show the explore horizon on the Tiles minimap (AndSDev).
Tested on both Webtiles and local.

Fixes #389 issue.
Closes #392 PR.
Closes #394 PR.

--------------------------------------------------------------------------------
89fc7b8 | wheals | 2018-01-29 20:34:52 -0500

Rename feature_def::{d,}map_colour to unseen_colour.
To clarify that it is used specifically when the feature has not yet
been seen.

--------------------------------------------------------------------------------
82d722a | cut1less | 2018-01-29 19:23:05 -0500

(Console) Use magic mapping colors
map_colour() exists but is not called anywhere. This adds a
magic-mapping section to where out-of-LOS elements get their color.

--------------------------------------------------------------------------------
314b907 | wheals | 2018-01-28 15:18:53 -0500

Fix an uninitialized variable warning.

--------------------------------------------------------------------------------
8341686 | wheals | 2018-01-28 15:10:21 -0500

Restrict the "treat monster under you as the source" code to Dith shadows.

--------------------------------------------------------------------------------
1c85753 | Corin Buchanan-Howland | 2018-01-28 14:54:24 -0500

Make Dith Shadow Mimic launchers normal (Valarioth, ebering, advil, Snack)
Dith now correctly sets shadow mimic launchers to be unbranded and +0 as
intended. Thanks to ebering for determining the root cause and advil for
writing this code.

--------------------------------------------------------------------------------
70bfd0b | Elan Morin Tedronai | 2018-01-28 11:16:20 -0500

Do not force more prompts for (most) of desolation of salt messages. (#707)
Timed portals have a default force more prompt for their initial
announcement message. The following messages do not cause additional
more prompts by default.

This commit makes the Desolation of Salt messages also behave like that.
Before this commit, the force_more was defined just as "distant wind".
Since "distant" is also used in many of the followup messages to
describe how far away the player is from the portal, this caused a lot
of additional "more" prompts for the player.
--------------------------------------------------------------------------------
dd6f4a9 | Aidan Holm | 2018-01-28 04:13:31 +0800

Add icon for possessable status (Ultraviolent4, #11239)

--------------------------------------------------------------------------------
871f50c | Aidan Holm | 2018-01-28 03:51:09 +0800

Fix typo (Poroing, #11291)

--------------------------------------------------------------------------------
bb09730 | Aidan Holm | 2018-01-28 03:46:07 +0800

Fix crash when resizing window while targeting (#11356)

--------------------------------------------------------------------------------
5b255cf | Aidan Holm | 2018-01-27 05:25:19 +0800

Fix spurious spell failure warning for wands (Le_Nerd, #11370)
Also removes the unused fail_chance variable, spotted by wheals.

--------------------------------------------------------------------------------
beb7240 | advil | 2018-01-25 20:21:15 -0500

Make sudo: required for travis explicit
We were grandfathered in to this being the default because the project
was created before Feb 15, 2015.  It's no longer the default, so any
forks after that will get travis errors from running on the
container-based enviornment, which doesn't support sudo.

--------------------------------------------------------------------------------
89a7304 | Aidan Holm | 2018-01-26 03:00:20 +0800

Add verbal spell failure description (amalloy)
This provides spell safety information to players who are unable to
see the colour of the failure rate. The text colour of this prompt has
also been changed to lightgrey, in order to make the spell name more
distinct.

--------------------------------------------------------------------------------
3ad276d | Aidan Holm | 2018-01-26 03:00:20 +0800

Omit very-dangerous message on 100% spell failure

--------------------------------------------------------------------------------
bcde4f2 | John Boyle | 2018-01-26 03:00:20 +0800

Colourize risk of spell failure for last casted spell (aidanh)

--------------------------------------------------------------------------------
505e61d | John Boyle | 2018-01-26 03:00:20 +0800

Prevent casting a spell with 100% failure chance (aidanh)
If there's never an advantage for a player to try to cast a spell with
100% failure, why do we even allow it as an option?

If there's really some edge case advantage for a player to try to cast a
spell with 100% failure, why would we continue to encourage that?

Seems like a win/win to just prevent it from being cast in the first
place.

--------------------------------------------------------------------------------
dc44e7b | John Boyle | 2018-01-26 03:00:20 +0800

Display spell fail % for "dangerous to cast" warning (aidanh, tedric, Zenthirum)
These are Zenthirum's changes from the mantis bug report.

--------------------------------------------------------------------------------
ee1c82b | Aidan Holm | 2018-01-26 03:00:20 +0800

Add spell_failure_rate_string()

--------------------------------------------------------------------------------
37984e8 | Aidan Holm | 2018-01-26 02:32:34 +0800

Fix ?/I showing descriptions for wrong items
There were several problems with the old implementation.
get_item_by_name() did fuzzy matching, instead of exact matching, and
only a handful of item types were checked in _describe_item(). In
addition, a partial match against item types checked first would be used
immediately, without checking for a better match of a different type.

To fix this, get_item_by_exact_name() is added. The name given to it is
compared against the dbname of all possible items, and only an exact
match is considered a success.

--------------------------------------------------------------------------------
ff2d48b | wheals | 2018-01-25 11:09:24 -0500

List the includable rcfiles in options_guide.txt (Yermak).
They were already in the default init.txt, but that tends to get overwritten.

--------------------------------------------------------------------------------
366d4ef | panicbit | 2018-01-25 11:06:25 -0500

Add neo command keys (#566)
Probably not going to be more unused than Dvorak or Colemak...
--------------------------------------------------------------------------------
1ac4c55 | wheals | 2018-01-24 21:04:08 -0500

Fix crash when describing memorised spells.

--------------------------------------------------------------------------------
b4b8e1f | Aidan Holm | 2018-01-25 07:32:45 +0800

Make Serpent of Hell name wrangling slightly less brittle

--------------------------------------------------------------------------------
2fe0497 | Aidan Holm | 2018-01-25 07:32:45 +0800

Show Serpent of Hell flavour in ?/M list

--------------------------------------------------------------------------------
7cd46d3 | Aidan Holm | 2018-01-25 06:25:49 +0800

Allow memorising from description of book on ground (Yermak, #10799)

--------------------------------------------------------------------------------
a32820b | cut1less | 2018-01-25 03:29:34 +0800

Display zombie hands icon for offline tiles users

--------------------------------------------------------------------------------
7da2295 | Aidan Holm | 2018-01-24 22:44:10 +0800

Don't list removed books in ?/s spell descriptions (rchandra, #11287)

--------------------------------------------------------------------------------
6b88ebb | advil | 2018-01-22 16:07:15 -0500

checkwhite
[skip ci]

--------------------------------------------------------------------------------
3374514 | advil | 2018-01-22 16:05:46 -0500

Centralize some vault-type-specific guidelines to be easier to find
+ a bunch of editing and formatting.

--------------------------------------------------------------------------------
23542c2 | Aidan Holm | 2018-01-22 04:58:05 +0800

tiles: show dungeon cursor on mouse-move in X view

--------------------------------------------------------------------------------
bd61d0d | wheals | 2018-01-21 15:51:17 -0500

Revert "0.21 tournament reminder."
This reverts commit eb883ae61ce99abd1f1afd7a535320dd6b9a2829.

--------------------------------------------------------------------------------
de60138 | elliptic | 2018-01-21 15:33:47 -0500

Fix zombie hands math.
Damage wasn't exactly multiplied by 0.75 in 55908e5a (because 2dN has
expected value N+1, not N).

--------------------------------------------------------------------------------
7adf481 | wheals | 2018-01-21 15:19:44 -0500

Add instructions for compiling local tiles on Windows 10 WSL.

--------------------------------------------------------------------------------
b094c4c | wheals | 2018-01-21 15:11:11 -0500

Mark cloud immunity scarves as useless under Qaz.
This is in line with scrolls of amnesia under Trog.

--------------------------------------------------------------------------------
94e0ad4 | gammafunk | 2018-01-19 17:42:17 -0600

Remove Borgnjor's Vile Clutch from the Book of Necromancy
This is a strong spell that works against most things in the dungeon.
The Necromancer start is already very strong without BVC, having animate
skeleton/dead for non-resistable damage and vampiric drain for good
damage and healing. This commit removes BVC from the Necromancer
starting book, leaving it in the Book of Unlife and the Book of Dreams.
It's also available through Kiku/Sif gifts, of course.

--------------------------------------------------------------------------------
55908e5 | gammafunk | 2018-01-19 17:42:17 -0600

Reduce the constriction damage from Borgnjor's Vile Clutch
This is a level 5 spell that does high damage per cast with good spell
power, is applicable to a large majority of monsters, and only checks
half AC.  Although the damage per turn is not high compared to other
level 5 spells, the cumulative damage is high, and the spell has lots of
additional utility for restricting monster movement on top of this
damage. To help keep the overall usefulness more in line with other
level 5 spells, this commit reduces the constriction damage by 25%.

--------------------------------------------------------------------------------
3fd002e | advil | 2018-01-19 17:53:57 -0500

Add transporter landings to sanitize_feature
I'm still not really sure how this is happening (and it may be a bug),
but somehow abyss terrain can get reused on abyss shifts, including
terrain that used to be MMT_VAULT. This seems to occur when the abyss
level layout generater is reset, something that happens at least on the
first abyss morph after loading a game in the abyss.  When it does
happen, sanitize_feature is called on the remnant terrain to clean up
various things before reusing it.  Transporters were already on the list
(turning to arches) but not landing sites; I just made landing sites
turn to arches as well.

This led to a (rare) way that the abyss could break transporter pairs,
if ex-vault-terrain is part of what gets reused. I don't know the exact
conditions, but I *think* it is some combination of saving/loading at
the right distance from the vault, and then having the abyss shift. This
probably could use some more investigation.

--------------------------------------------------------------------------------
218e7ff | advil | 2018-01-18 19:23:26 -0500

Don't let lugonu corrupt overwrite transporter landing sites
Since it can't overwrite transporters. This is not the bug we were
looking for, but it is still *a* bug.

(cherry picked from commit 2553a3340b4d1c90901eebb07941a6ff69edc3fc)

--------------------------------------------------------------------------------
246a1cd | advil | 2018-01-18 16:00:29 -0500

Don't infinitely loop with crawl_state.seen_hups on tiles (11353)
This could happen if multiple key events were in the SDL queue when
SDL_QUIT was received, a situation apparently triggered by windows
alt+f4 after the recent SDL2 update. I'm not entirely sure why it's not
swallowing the key events any more, but some aspects of modifier key
behavior did change, and event order may have changed. This fix
ignores all key events after the SDL_QUIT event (or other HUP).

This is exactly the possible infinite loop referred to in 2dbd2a41df8c.

--------------------------------------------------------------------------------
7478db5 | advil | 2018-01-17 12:33:40 -0500

Ensure that _getch_mul returns a non-empty keyseq (aidanh)
The getch concept seems to imply this, but if somehow you get the SDL
event loop to produce only CK_NO_KEY, this assumption would be violated.
(Though, crawl didn't obviously have problems when the deque size was 0;
it's possible the assumption is still made somewhere in the macro code
that I didn't check.)

--------------------------------------------------------------------------------
af9c194 | advil | 2018-01-17 12:33:40 -0500

Rewrite text input suppression to use different hacks
On most(?) windows and linux setups, numpad keys with numlock on send
both a keydown event and a textinput event with the corresponding
number; with numlock off only the keydown event is sent. On OS X there
is no numlock, but this dual behavior happens always. Crawl is supposed
to treat the numpad uniformly regardless of numlock state, so it needs
to ignore the double press. For legacy reasons (I think) it also needs
to correctly handle just the number input. In the numlock on case (and
on OS X), therefore, one or the other has to be suppressed.

The previous approach relied on starting and stopping the text input
system clearing any upcoming SDL_TEXTINPUT events. On Windows, updating
SDL to 2.0.7 has broken this assumption, and this toggle only sometimes
works as intended. I couldn't figure out a reasonable way to restore the
behavior of this toggle, so here is a new approach.

This commit tries to do things without relying on any particular SDL
code; if a textinput event immediately follows a matching keydown event,
the textinput event is ignored. This of course assumes that these events
are adjacent, but in my testing on OS X and windows this has always been
true so far. This patch will need some more testing.

(I suspect the relevant SDL commit is this one:
https://github.com/spurious/SDL-mirror/commit/ff8a1efc51a6ad7de6379cde7047d135ff
d7e15e
because it changes the timing of textinput events, which were previously
guaranteed to be near the keydown; but I haven't tested this
hypothesis.)

--------------------------------------------------------------------------------
605b837 | advil | 2018-01-16 20:16:13 -0500

Clear m_glyphs when (re-)configuring fonts
Not clearing this breaks changing DPIs (e.g. by dragging across screens,
22212c17e2ada4c5306) because the advances (probably among other things)
are apparently still cached here from the previous DPI.

--------------------------------------------------------------------------------
0f8607c | advil | 2018-01-14 15:11:58 -0500

Make ability wall jump work under silence
...like the movement based version.

--------------------------------------------------------------------------------
0fd0111 | Aidan Holm | 2018-01-14 04:01:05 +0800

Fix uninitialized read when handling god speech

--------------------------------------------------------------------------------
d698a02 | Aidan Holm | 2018-01-13 06:29:24 +0800

Add some new title artwork (froggy)

--------------------------------------------------------------------------------
1fede22 | advil | 2018-01-11 20:52:08 -0800

Update submodule

--------------------------------------------------------------------------------
7512b04 | advil | 2018-01-11 20:37:56 -0800

Improve support for MSYS2
This check was relying on a uname that MSYS2 doesn't always set,
depending on how it is run.

SDL2 submodule also needs a related fix.

--------------------------------------------------------------------------------
db02301 | advil | 2018-01-11 18:37:05 -0500

Revert 399e2f71cb99 and do it a different way
v.1 was a terrible, terrible idea.

--------------------------------------------------------------------------------
2b194f0 | Gregory Chereshnev | 2018-01-11 13:56:55 -0800

Update species.txt
A small translation.
--------------------------------------------------------------------------------
399e2f7 | advil | 2018-01-11 15:01:59 -0500

Fix a DEAD MONSTER (u/cervance)
Even with clean=false, if inflict_damage recursively triggers the
disappearance of a defender that is a summon via the death of the
summoner (via usk pain bond), you can get a cleaned up dead defender
after the call.

This fix addresses only aux attacks, other calls to inflict_damage may
still lead to DEAD MONSTER messages. I don't think it is plausible to
change things so that the summon isn't cleaned up yet, which would be a
better fix in principle (cf. f70bbbcf307f), but I could be wrong.

--------------------------------------------------------------------------------
92e58f9 | Alan Malloy | 2018-01-11 11:26:44 -0800

Simplify printf specifiers for !agi and !brill

--------------------------------------------------------------------------------
116c2a8 | advil | 2018-01-10 12:51:39 -0500

One more -- add a caveat about the font
[skip ci]

--------------------------------------------------------------------------------
9254d95 | advil | 2018-01-10 12:48:40 -0500

List recognized language codes in options_guide.txt

--------------------------------------------------------------------------------
0944b2b | Alan Malloy | 2018-01-10 09:44:59 -0800

Mention the 'language' option in options_guide.txt

--------------------------------------------------------------------------------
7da74aa | Alan Malloy | 2018-01-10 09:41:21 -0800

Improve error message when rcfile specifies unknown language

--------------------------------------------------------------------------------
4406e2f | Aidan Holm | 2018-01-11 00:55:49 +0800

fontwrapper-ft: cache glyph metrics outside the atlas
This fixes huge lag when trying to calculate the rendered size of huge
strings of text (string_width(), string_height()). Previously, glyph
metrics were stored with the font atlas metadata, so every glyph lookup
required shuffling the LRU metadata: 95% of string_width() runtime was
spent inside map_unicode(), and 95% of its runtime was spent updating
the LRU metadata. This is pointless, because the glyphs aren't
getting rendered (and what happens when a buffer has >256 distinct
glyphs in it, anyway...)

New solution: store glyph metrics in a big vector keyed by codepoint,
for fast access, and auto-expand it as necessary. If memory usage
becomes a concern, there are several low hanging fruit: the GlyphInfo
struct could be compacted significantly, and the codepoints used in
game content (in dat/) fall into distinct bands with about 50% empty
space.

After this change, string_width() runtime is dominated by next_glyph().

--------------------------------------------------------------------------------
f756b68 | Kyle Rawlins | 2018-01-10 10:06:50 -0500

Tweak build instructions for msys2
Apparently installing the toolchain doesn't set the path automatically.

[skip ci]
--------------------------------------------------------------------------------
eddfa9b | Alan Malloy | 2018-01-09 17:41:07 -0800

Don't clear unique annotations when you defeat an illusory unique

--------------------------------------------------------------------------------
f34168a | Aidan Holm | 2018-01-10 07:36:22 +0800

Fix some unused func/var warnings on console

--------------------------------------------------------------------------------
bf6022e | Alan Malloy | 2018-01-09 13:11:22 -0800

Make Duvessa and Dowan react the same to killing each other

--------------------------------------------------------------------------------
6b3d46c | Aidan Holm | 2018-01-09 22:53:21 +0800

Remove redundant spell tiles

--------------------------------------------------------------------------------
b6df83e | Aidan Holm | 2018-01-09 22:53:21 +0800

Add generic monster spell tile
As distinct from the Error tile.

--------------------------------------------------------------------------------
03c2c45 | Aidan Holm | 2018-01-09 22:53:21 +0800

Add consistent background to monster spell tiles

--------------------------------------------------------------------------------
8ce38db | Aidan Holm | 2018-01-09 22:53:21 +0800

Don't show removed spells in ?/s menu (rchandra, #11287)

--------------------------------------------------------------------------------
25970fc | Aidan Holm | 2018-01-09 22:51:33 +0800

Fix floor features getting a black tile in ?/F
A DNGN_UNSEEN tile was being added by FeatureMenuEntry, since the
uninitialized position (the origin) was unseen. Normally this didn't
matter as menu entry tiles are rendered in a sorted order, with the
unseen tile underneath the feature tile, but for floor tiles this
sorting placed the floor tile underneath the UNSEEN tile.

--------------------------------------------------------------------------------
3eaed18 | Chris Campbell | 2018-01-09 13:47:07 +0000

Clean up some comment spacing

--------------------------------------------------------------------------------
0a53ea1 | Chris Campbell | 2018-01-09 13:47:07 +0000

Don't place air elemental bands with spriggan air mages
Since their tornadoes tend to just kill the spriggans.

--------------------------------------------------------------------------------
e097ebc | Chris Campbell | 2018-01-09 13:47:07 +0000

Don't require the rest command to make barbs expire
Have them expire when not moving (as with Hop cooldown), rather than having the
"wait" command specifically do something special for them. Also slightly
increase their base duration, since this does allow for them to expire while
doing other things in combat.

--------------------------------------------------------------------------------
299d06e | Chris Campbell | 2018-01-09 13:47:06 +0000

Allow manually cancelling Formicid digging
Normally there's no need to manually cancel it (since it's always free and
instant to activate, and taking any action other than digging cancels it), but
having the digging status active prevents WJC walljumping so there needs to be
a way to cancel it without taking an action (other than saving and reloading).

--------------------------------------------------------------------------------
1bb26a1 | Aidan Holm | 2018-01-09 05:47:28 +0800

Fix local tiles resize during yesno and stat gain prompt

--------------------------------------------------------------------------------
76f3efa | Aidan Holm | 2018-01-09 00:33:26 +0800

Shorten Trog ability description to fit in one line

--------------------------------------------------------------------------------
614aadd | gammafunk | 2018-01-07 16:05:44 -0600

Fix a crash when attempting to print constriction status (dweomer)
Broken in 5bb8f479, we have an ASSERT when the player is constricted,
but we're unable to look up the corresponding monster. This commit uses
the proper check for a valid constrictor, returning false in the
relevant function if the constrictor is invalid for any reason, which
will prevent constriction being printed as a status.

--------------------------------------------------------------------------------
8770677 | Aidan Holm | 2018-01-07 04:00:30 +0800

Choose correct tile for headless vines/starspawn tentacles

--------------------------------------------------------------------------------
7216f87 | Aidan Holm | 2018-01-07 04:00:30 +0800

Don't vary tiles for fake monsters
This fixes monsters' tiles varying on the ?/M screen.

--------------------------------------------------------------------------------
b9bda1d | Aidan Holm | 2018-01-07 01:26:49 +0800

Fix glyph metric lookup for multibyte utf-8 chars

--------------------------------------------------------------------------------
5d95dd4 | Aidan Holm | 2018-01-07 01:26:42 +0800

Fix some iterations over multibyte utf-8

--------------------------------------------------------------------------------
eb883ae | wheals | 2018-01-05 16:17:53 -0500

0.21 tournament reminder.

--------------------------------------------------------------------------------
c6c46c7 | gammafunk | 2018-01-05 12:39:40 -0600

Finalize the changelog for 0.21

--------------------------------------------------------------------------------
002c468 | gammafunk | 2018-01-04 18:35:51 -0600

Fix the smite targeting of Borgnjor's Vile Clutch (mibe, 11334)
Currently the function to determine if susceptible monsters are in LOS
considers this spell as a beam exploding spell. This means any monsters
or other obstructions along the path to a valid target has the UI's
tracer beam explode on the obstruction, causing the beam to not count
the valid target as affected. The UI then incorrectly tells the player
that no valid target is in view.

This commit changes spell_no_hostile_in_range to handle the relevant
tracer for smite-targeted spells directly through an explosion at the
target. Now the UI correctly ignores obstructions for determining if
hostiles are in range for Vile Clutch.

TODO:

1) I leave a comment noting how some solid and non-reachable targets
should probably be bypassed for the hostile-in-range check.

2) I leave another comment noting how explosion radii data for spells
are not stored in any central place, and it would be good to do that.

3) Make the necessary zap_data entries so smite-targeted spells can use
the zap tracer loop in spell_no_hostile_in_range to properly determine
when a susceptible monster is in view. Currently the UI will only
consider range for smite-targeted spells without zap data. This means it
will consider e.g. an rWind monster to be a valid hostile in range for
Airstrike initially, only preventing the targeting later when the player
finally accepts that target in the UI.

4) I'm not actually sure that having to make zap entries for spells only
so they can properly consider targets in range is a good idea. Might
need to look at what the main intent of zap_data actually is.

--------------------------------------------------------------------------------
8c2458a | gammafunk | 2018-01-04 17:03:26 -0600

Slightly refactor some spell targeting code and update comments

--------------------------------------------------------------------------------
3d2f077 | gammafunk | 2018-01-03 21:21:33 -0600

Enable Wu Jian in stable versions
Although this god probably still has significant work to be done (e.g.
with Wall Jump), it's stable enough for release.

Any server admins with 0.21 need to be sure to pull this commit,
otherwise Wu Jian won't be available in that version.

This reverts commit bb42413abe9137b984ae9489003580cc3c1e1fdd.

--------------------------------------------------------------------------------
670f5c0 | gammafunk | 2018-01-03 20:55:35 -0600

Enable Gnolls in stable versions
This species is ready for release. Any server admins with 0.21 need to
make sure to pull this commit, otherwise their 0.21 won't have Gnolls.

--------------------------------------------------------------------------------
c6ec8ce | gammafunk | 2018-01-03 14:54:08 -0600

Have all forms of monster movement break indirect constriction (mibe)
Previously monsters would continue to be indirectly constricted under
Borgnjor's Vile Clutch if they were trampled, yanked with Lesser
Beckoning, did a swoop attack, etc, since the move only caused
direct constriction to be checked for validity.

This commit unifies the checks for all forms of constrictions and
simplifies the code to have the validity checks for both happen through
a single method. Now any form of movement will cause the monster's
zombie hands constriction to end.

--------------------------------------------------------------------------------
c5a4238 | gammafunk | 2018-01-03 14:42:36 -0600

Give a static function a clearer name

--------------------------------------------------------------------------------
ae4c1f7 | Chris Campbell | 2018-01-03 14:16:34 +0000

Remove duplicate info from a description
The fact that it's instant is already automatically displayed.

--------------------------------------------------------------------------------
33df271 | Chris Campbell | 2018-01-03 14:16:34 +0000

Improve some WJC messaging/descriptions

--------------------------------------------------------------------------------
d3d06db | Chris Campbell | 2018-01-03 14:16:34 +0000

Coding convention fixes

--------------------------------------------------------------------------------
5354c77 | Chris Campbell | 2018-01-03 14:03:57 +0000

Allow (a)bility-walljump to be used when starving
Since the movement-based version can be - although if the ability is changed to
be ability-only, it'd probably be fine to revert this again.

--------------------------------------------------------------------------------
a749362 | advil | 2018-01-02 17:39:58 -0500

Do post-move things for ability walljump (MarvinPA)
I forgot to deal with all this stuff.

--------------------------------------------------------------------------------
00266d7 | Chris Campbell | 2018-01-02 20:43:48 +0000

More completely remove Delayed Fireball
Just leave the minimum required compatibility code and treat it like a regular
removed spell instead of leaving it as fully functional if it was still
memorised.

--------------------------------------------------------------------------------
37babaa | Chris Campbell | 2018-01-02 20:43:47 +0000

Make Yredelemnul's Enslave Soul smite-targeted
To make it slightly simpler and easier to use.

--------------------------------------------------------------------------------
aaa5eb4 | Chris Campbell | 2018-01-02 20:43:47 +0000

Remove another ability use of LOS_RADIUS
Doesn't have any actual effect in this case since the ability is smite-targeted.

--------------------------------------------------------------------------------
083de83 | Chris Campbell | 2018-01-02 20:43:47 +0000

Swap the ranges of Makhleb's Minor/Major destruction (edgefigaro)
Since Minor Destruction is very cheap and spammable, limit it slightly with
lower range, while increasing Major Destruction's range as it costs piety and
includes potential big explosions.

Also fix the abilities being able to be cast out of LOS when under an LOS
reduction effect.

--------------------------------------------------------------------------------
392ec66 | Chris Campbell | 2018-01-02 20:43:47 +0000

Don't allow firing Draconian breaths out of LOS
When wearing the robe of Night, for example. Also allows the full-range breaths
to reach range 8 when playing as a Purple Draconian-Barachi hybrid (or if some
other method of increasing LOS comes into existence).

--------------------------------------------------------------------------------
eb5ee87 | Chris Campbell | 2018-01-02 20:43:47 +0000

Fix Lugonu Banish working on out-of-LOS enemies
Had been broken with the addition of Barachi.

--------------------------------------------------------------------------------
9c1766a | Chris Campbell | 2018-01-02 20:43:47 +0000

Remove Shatter from pan lord spell lists
It doesn't function very well as a monster spell in general (and should
possibly also be removed from Jorgrun) - much more so than other high-level
conjurations, it's likely to kill lots of the caster's allies, and especially
on very high-HD monsters is able to deal extremely high damage to players
without the kinds of restrictions that other scary spells have.

--------------------------------------------------------------------------------
8389209 | Chris Campbell | 2018-01-02 20:43:47 +0000

Adjust messaging for emergency flight
So that it makes slightly more sense when swimming forms expire (without really
trying to give an explanation as to how the emergency flight works).

--------------------------------------------------------------------------------
ce77710 | gammafunk | 2018-01-02 12:12:29 -0600

Correct weapon offsets for the wight monster tile (gorglomux)

--------------------------------------------------------------------------------
34d3fd3 | gammafunk | 2018-01-02 07:32:17 -0600

Updated entropy weaver and tormentor tiles (roctavian, #11340)
Entropy weavers don't have a multi-turn spell any more, so we don't need
3 tiles, but it was agreed that the second state is the best rendition
for the main tile.

The new tormentor is purple, which matches the console color better, but
it is *very* purple. Some would claim it is too purple, and I would have
no defense against this argument. Roctavian has said he'll redo the tile
entirely, but until then we'll use this one. The new tile helps make
tormentors distinct from, say, cacodemons, and telling demons apart is
the key to dominating the late-game, the end-game, extended, the
post-game, and the metagame.

--------------------------------------------------------------------------------
9421e3f | gammafunk | 2018-01-01 17:21:09 -0600

A batch of updated monster tiles (roctavian, #11340)
From insects, to orcs, to demons and many things in-between. Also new
tiles for many uniques, and Erica now has a version of her tile used
when she's not wielding a flaming scimitar, which allows that weapon's
tile to display.

--------------------------------------------------------------------------------
90586b7 | gammafunk | 2018-01-01 17:21:09 -0600

A new Shining One altar tile (roctavian, #11340)
The iconography is less a reference to Christianity and it's a fun
little inside joke for people familiar with the commonly used
abbreviation for this god.

--------------------------------------------------------------------------------
1cd5daa | gammafunk | 2018-01-01 17:21:09 -0600

A batch of updated artefact weapon tiles (roctavian, #11340)
For random artefacts and the unrands Majin-Bo, Wucad Mu, Leech, and
Wyrmbane. The latter is suppose to have its tile upgraded every couple
of enchantment, but I haven't yet made the code modifications for that.
For now, I've added the later variants and let the first variant be the
only one used.

Slings and fustibali have their ordinary and ego tiles updated in
addition to the artefact ones.

--------------------------------------------------------------------------------
9b14fc1 | gammafunk | 2018-01-01 17:21:09 -0600

A batch of updated elven monster tiles (roctavian, #11340)
Updates for all the elven monsters, including the uniques Dowan,
Duvessa, and Fannar.

Deep elf elementalists are supposed to have one of three tiles that
cycles with each UI action as nice way to make them distinct and
visualize their elemental nature, but this needs some additional code
changes. Right now, using these in a cycle wouldn't display their
wielded weapon for any tile except the first variant. I'm adding the
variants, but only enabling use of the first one until said code changes
can happen.

--------------------------------------------------------------------------------
898fae9 | gammafunk | 2018-01-01 17:21:09 -0600

Some tweaks to plant tiles (roctavian, #11340)

--------------------------------------------------------------------------------
20fe0ec | gammafunk | 2018-01-01 17:21:09 -0600

New and updated zombie and skeleton monster tiles (roctavian, #11340)
Improvements to various zombified and skeletal beasts. Now yak zombies,
bear zombies, and draconian skeletons have their own distinct tiles.

--------------------------------------------------------------------------------
4f60a59 | advil | 2018-01-01 14:45:26 -0500

Update wall jump info in changelog, options guide, and help
To add something about the ability, and try to make very obvious that
you can disable the movement-activated mode. (This mode is pretty
divisive, between players who find it fun, and players who it drives
crazy because it's so easy to trigger accidental wall jumps.)

--------------------------------------------------------------------------------
e27d229 | Aidan Holm | 2018-01-02 00:45:03 +0800

Postpone timed portal messages bofore level load (Yermak, #11279)
TimedMessaging now ignores all turn events that occur before an
ENTERED_LEVEL event, and the ENTERED_LEVEL event now also causes
an elapsed time check.

--------------------------------------------------------------------------------
35895e1 | Aidan Holm | 2018-01-01 22:39:09 +0800

Fix spell list column heading alignments

--------------------------------------------------------------------------------
6182cf9 | Aidan Holm | 2018-01-01 19:51:03 +0800

Improve rendering of menu entries with tall tiles
This makes the ?/M menu much nicer when big uniques (e.g. hell lords)
are shown. On webtiles, the centre of the tall tile was shown, while on
local tiles the full tile was shown, with the excess sticking out the top.

--------------------------------------------------------------------------------
3182a47 | Aidan Holm | 2018-01-01 19:51:03 +0800

Add centre parameter to renderer.draw_from_texture()

--------------------------------------------------------------------------------
8a0fcf7 | Aidan Holm | 2018-01-01 19:51:03 +0800

Fix renderer.draw_from_texture() ignoring y_max

--------------------------------------------------------------------------------
01001fb | Aidan Holm | 2018-01-01 19:46:15 +0800

Fix alignment of spellsets with hex-chances

--------------------------------------------------------------------------------
dc0ec3b | dplusplus | 2018-01-01 19:18:47 +0800

fix explore_discoveries::cleaned_feature_description()

--------------------------------------------------------------------------------
887ef9c | Aidan Holm | 2018-01-01 18:19:30 +0800

Correctly ellipsize multibyte strings

--------------------------------------------------------------------------------
122557b | Aidan Holm | 2018-01-01 18:19:30 +0800

Fix word-wrapping pt 2: short strings
This fixes the case when a newline occurs in the input string before the
width limit is reached.

We also use the new chop_bytes() to handle newlines correctly.

--------------------------------------------------------------------------------
1fac53a | Aidan Holm | 2018-01-01 18:19:30 +0800

Fix word-wrapping of text with embedded newlines
This function is intended to find the point at which a string exceeds a
given horizontal width, but neglected to reset the accumulated width
after newlines. This caused text wrapped to fit within a rectangular
region to be prematurely wrapped.

--------------------------------------------------------------------------------
4e99ca0 | Aidan Holm | 2018-01-01 18:19:30 +0800

Add formatted_string::chop_bytes()
chop() uses wcwidth() -- this leads to subtle bugs if you're chopping
strings based on indices.

--------------------------------------------------------------------------------
4fa69d9 | Chris Campbell | 2017-12-31 20:05:56 +0000

Mark some Ely abilities as unusable when confused
Makes Ely's Purification and Ru's Draw Out Power the only abilities that can be
used while confused (since one of their main purposes is to cure it).

--------------------------------------------------------------------------------
ec8b4a9 | Chris Campbell | 2017-12-31 20:05:47 +0000

Fix unidentified scarves being targetable by ?enchant armour

--------------------------------------------------------------------------------
d89ddbe | Aidan Holm | 2017-12-31 17:48:34 +0800

Fix crash in player doll editor (GuideCritic, #11333)
Crash was caused by a collision between this enum and a player doll part
tripping up an assertion.

No save incompatibility: player doll data is serialized in a manner
independently of this enum's value, and mcache_ghost entries have their
dolls reconstructed from species and equipment on creation.

--------------------------------------------------------------------------------
fd72fac | gammafunk | 2017-12-30 19:28:37 -0600

Preliminary debian changelog entries for 0.21 and 0.22
[skip ci]

--------------------------------------------------------------------------------
e7d2b72 | gammafunk | 2017-12-30 19:05:14 -0600

More changelog updates

--------------------------------------------------------------------------------
786e97d | gammafunk | 2017-12-30 18:15:33 -0600

Update the changelog through 0.21-a0-642-g5d013b21

--------------------------------------------------------------------------------
5d013b2 | Aidan Holm | 2017-12-30 21:22:16 +0800

Fix ghost doll cycling through parts
The acting_part member was entirely unused. The i_ghost struct it is
part of is hashed to determine ghost appearances. While it is cleared
in the (monster_type, monster_type) constructor, it isn't cleared in
the (monster*, int) constructor, which seems to be used when monsters
move between cells.

--------------------------------------------------------------------------------
eef9d7f | Chris Campbell | 2017-12-30 02:26:27 +0000

Tweak Shatter some more
Add icy creatures back to the increased damage level (so they now take 2*
damage, compared to previously taking 1.5*), make the chances of wall
destruction all fixed instead of power-based, and update description.

--------------------------------------------------------------------------------
849abb4 | hellmonk | 2017-12-30 02:00:18 +0000

Simplify shatter damage formula.
Will always do either 1, 3, or 6 dice depending on the monster. Notably,
shatter will now damage insubstantial monsters (for 1 die of damage), will do
normal damage instead of 1/3 to water elementals, and no longer does
additional damage to icy monsters. TBH this should be simplified further.

[Made some minor further adjustments, adjusting the order of operations for
checks on material/flight/insubstantiality for better consistency - MarvinPA]

--------------------------------------------------------------------------------
8afaa31 | Chris Campbell | 2017-12-30 01:20:52 +0000

Simplify LRD explosion damage and size
Make each material type have a fixed damage and size, and don't increase
damage or size on a cast that destroys a monster or wall. Adjust metal walls
to have a fixed chance of destruction once above the power threshold, as alli
other wall types already had (instead of a power-based chance - simplifying
these further across the board would probably be good).

--------------------------------------------------------------------------------
11b2e07 | advil | 2017-12-29 15:44:44 -0500

Allow wall jump against closed doors via the ability
Since the ability is always possible, there's no reason not to allow
this now. When moving, moving against a closed door still has the
regular behavior for the door type.

--------------------------------------------------------------------------------
f6577c8 | advil | 2017-12-29 15:44:44 -0500

Add a targeter/ability for WJC wall jump
This adds a way to trigger wall jump via an ability that has you target
a wall position; the targeter highlights the landing square and any
affected monsters. The behavior of wall jump activated this way should
be identical to that of move-triggered wall jump, but this is safer and
easier to understand.

This ability is always available if the player has wall jump, but
doesn't replace move-triggered wall jump.  For safer movement,
move-triggered wall jump can be disabled in rc by setting
`wall_jump_move = false` (default: true) leaving only the ability.  The
`wall_jump_prompt` option remains, but by default is false.

--------------------------------------------------------------------------------
589fbc3 | Neil Moore | 2017-12-29 07:22:59 -0500

Update new-member instructions slightly.
With the move of the private list, the set of people who can edit
it is different.

[skip ci]

--------------------------------------------------------------------------------
1790b82 | Neil Moore | 2017-12-29 07:22:59 -0500

Champagne and caviar for aidanh.
Welcome to the team!

[skip ci]

--------------------------------------------------------------------------------
af8bc5d | advil | 2017-12-28 22:21:32 -0500

Use random food tiles for rations
This is based on a bunch of ideas that came up in ##crawl-dev last week
(|amethyst, wheals, maybe others).  It may or may not be a good idea
UI-wise with this exact tile set (since all the tiles are very focused
on one food concept, and might give the wrong impression) but it does
make the food tiles, and especially food shops, less monotonous.

This approach normalizes to the basic tile (currently the old bread
ration tile) in inventory. I've also brought back some old tiles, though
I left out the ones I found hardest to identify as food.  Handles save
compat for the inventory tile name.

--------------------------------------------------------------------------------
4c047d5 | Alan Malloy | 2017-12-27 14:02:52 -0800

Update copyright from 2016 to 2018
It may look a little early to you, but I got a time machine for Christmas.

--------------------------------------------------------------------------------
1e37ce5 | gammafunk | 2017-12-26 07:12:43 -0600

Fix messaging when the Borg's Vile Clutch enchantment expires
Previously it would say "You lose your grip on ..." when Vile Clutch
expired, since the message was handled in the constriction code after
the enchant expired. Move this message into the enchantment expiration
code, so it can say "The zombie hands release their grip on..." instead.

--------------------------------------------------------------------------------
b5dc200 | gammafunk | 2017-12-26 07:12:43 -0600

Lower the enchantment duration of Borgnjor's Vile Clutch
Currently the enchantment lasts a long time relative to how many failed
escape attempts a monster is likely to have before it breaks free. This
means that monsters that can't or won't move can take especially large
amounts of damage from a single cast of Vile Clutch. At starting
spell-power levels of around 35 spell-power, the enchantment duration is
currently 5 + 0-16 turns for an average of 14 turns.

This commit changes the formula from:

5 + random2avg(spellpower / 2)

to:

4 + random2avg(spellpower / 10)

and using randomized rounding for the division. So at 35 spell-power,
the duration will be 4-7 turns for an average of 5.5 turns, and at 100
spell-power this gives 4-13 turns for an average of 8.5

A monster is very likely to escape before these average turns values at
those respective spell-powers, so the new duration formula will
effectively put a limit on damaging monsters that don't attempt escape
without frequently expiring before a monster breaks free.

--------------------------------------------------------------------------------
344d351 | Chris Campbell | 2017-12-24 19:16:26 +0000

Further ghost adjustments
Re-allow distortion, since it doesn't have any particular reason to be disabled 
compared to other threatening early brands, and fix movement speed at 10 rather 
than allowing slow but not fast ghosts.
--------------------------------------------------------------------------------
a19c9dc | advil | 2017-12-24 13:06:03 -0500

Tweak min ghost speed to 10 after further discussion

--------------------------------------------------------------------------------
72aa5ef | advil | 2017-12-24 12:54:02 -0500

Normalize ghost min speed and prevent more ghost brands
The particular value of 12 was a suggestion of Lasty's; this may need
some more tweaking but I'd like to do something since newghosts won't
get merged for 0.21. 10 might be ok, it's probably the modal value right
now anyways. N.b. for anyone reading this who isn't familiar with
monster speed, 12 is slower than the player.  (These changes are likely
to get reverted or at least modified for newghosts.)

Resolves #570

--------------------------------------------------------------------------------
87fa41b | advil | 2017-12-24 12:54:02 -0500

Don't generate ghosts in portal branches
Also clean up / unify the code that decides where ghosts can place. We
probably won't merge any major ghost reform in 0.21, so this is a
stopgap to minimize griefing and avoid the balance issues that come from
the fact that many of these portals can generate at a wide range of
depths. Not sure if disabling wizlabs/desolation is necessary, but I did
it for consistency. At the very least, the design of portal branches can
make ghosts extremely annoying even for high level players (if you get
the ac/hp bag variety).

--------------------------------------------------------------------------------
79970e1 | gammafunk | 2017-12-24 10:23:06 -0600

Show constriction and held statuses show properly (Pekkekke)
The logic was inverted, making damaging constriction show up as a "Held"
status light instead of "Constr" like it should. Fix this and a similar
inversion for monster info.

--------------------------------------------------------------------------------
1119ec1 | advil | 2017-12-23 21:04:11 -0500

Add constriction information to xv in wizmode
Also a debug message for zombie hands constriction.

--------------------------------------------------------------------------------
16f8e2c | advil | 2017-12-23 15:06:36 -0500

Fix fontbuf_line_reader in insert mode (aidanh)
Remove some vestigial direct writing to crt.

--------------------------------------------------------------------------------
80d1a53 | advil | 2017-12-23 14:46:38 -0500

A couple instances of 0 -> nullptr

--------------------------------------------------------------------------------
55ff828 | advil | 2017-12-23 14:43:21 -0500

Attempt to fix the BVC constriction bug
I still haven't replicated this, but as near as I can tell the problem
is that in some special cases involving summons,
`constriction_damage_defender` can lead to the iterator for constricting
becoming invalid. (One symptom is that the crashes happen at a point
where defender is nullptr.) This attempts to head off the problem by
operating on a copy of constricting when calculating constriction
damage. There may still be an underlying problem that this commit
doesn't fix.

--------------------------------------------------------------------------------
c60411f | gammafunk | 2017-12-23 05:33:01 -0600

Fix monster constriction data not getting marshalled
Broken in 5bb8f4791 as part of removing actor.held, we forgot to replace
a check with one of ::is_constricted().

A monster saved when it was constricted but not constricting something
itself wouldn't have its constriction data marshalled. So it would lose
all constriction state upon reload, causing a crash if the actor
constricting the monster attempted to constrict it again. In this case,
::is_constricted() would return false for the monster, yet it would
already be in its constrictor's constricting map.

This commit re-adds the constrictor check and uses the appropriate
methods to check constriction state instead of duplicating them.

--------------------------------------------------------------------------------
2783f27 | gammafunk | 2017-12-23 05:33:01 -0600

A status tile for zombie hands constriction (Ultraviolent4)
Don't ask.

--------------------------------------------------------------------------------
ed4c157 | gammafunk | 2017-12-23 05:33:01 -0600

Shorten some enum names
Remove the BORGNJORS_ prefix from the enchantment, beam, zap, and
mon-info enums, which makes them significantly shorter and is consistent
how we name these enums for other spells.

--------------------------------------------------------------------------------
6cbd37f | Neil Moore | 2017-12-22 21:48:28 -0500

Don't guarantee Corpse Rot in Kiku's first book (hellmonk)
Make Corpse Rot alternate with Animate Skeleton instead of Pain, so that
Pain is the guaranteed spell.  Bloodless characters are still guaranteed
all three of those spells, while bloodful characters are guaranteed
Sublimation of Blood, so everyone gets at least one spell that isn't in
the Book of Necromancy.

Also, simplify the logic for doing this a bit.

--------------------------------------------------------------------------------
0010f08 | Neil Moore | 2017-12-22 21:48:16 -0500

Guarantee a corpse-using spell in Kiku's second book.
And add a comment about it.  We have tried to enforce this guarantee in
the past, but never actually wrote it down.

--------------------------------------------------------------------------------
6d9b277 | advil | 2017-12-22 09:26:20 -0500

Fix a comment (wheals)

--------------------------------------------------------------------------------
8e08f28 | gammafunk | 2017-12-22 02:22:13 -0600

Don't have Borgnjor's Vile Clutch constrict friendlies (mibe)
I didn't intend for the spell to harm allies, but forgot to add the
alignment check initially. With this commit, any allies in the effect
area will be unaffected by the spell, and it will work normally on any
hostiles in the same area.

It's fair question as to whether an enchantment spell should have such
favorable selective targeting like this, but it makes using other
necromancy ally spells with this spell a lot less annoying. If this
selectivity gets removed, the spell will need a proper warning prompt
when friendlies would be affected.

--------------------------------------------------------------------------------
760ccf5 | gammafunk | 2017-12-22 02:03:38 -0600

Show the constriction icon monsters under Borg's Vile Clutch (mibe)
We could have a spell-specific version of this icon to help
disambiguation rare cases when it's not clear what the source of the
constriction is, but this will do for now.

--------------------------------------------------------------------------------
5d64845 | gammafunk | 2017-12-21 22:50:25 -0600

More fully remove Cigotuvi's Embrace
Descriptions removed and Lugonu's bribe vault uses animate dead in its
place.

--------------------------------------------------------------------------------
88d601c | gammafunk | 2017-12-21 22:50:24 -0600

More fully remove Control Undead
We missed spell descriptions as well as monster casting code, which
wasn't actually used by any monster. In Lugonu's bribe vault, only use
Dispel Undead for the randbook Kiku "taunt".

--------------------------------------------------------------------------------
d3d47d3 | gammafunk | 2017-12-21 22:50:23 -0600

A spell tile for Borgnjor's Vile Clutch (CanOfWorms)

--------------------------------------------------------------------------------
b17dc04 | gammafunk | 2017-12-21 22:50:23 -0600

Fix a method comment (amalloy, PR#678)
Thanks for all the feedback in the pull request, amalloy! Closes #678.

--------------------------------------------------------------------------------
eccb353 | gammafunk | 2017-12-21 22:50:22 -0600

Tweak a spell description (amalloy, PR#678)
Hopefully clarify that the corpses supplying our zombie hands for Vile
Clutch were already there and that it's not a corpse-using spell.

--------------------------------------------------------------------------------
f540f80 | gammafunk | 2017-12-21 22:50:22 -0600

Correctly use a variable for spell noise (amalloy, PR#678)

--------------------------------------------------------------------------------
5c814b5 | gammafunk | 2017-12-21 22:50:21 -0600

Correct a comment (amalloy, PR#678)

--------------------------------------------------------------------------------
d8688e6 | gammafunk | 2017-12-21 22:50:21 -0600

Use nullptr for a null pointer value (amalloy, PR#678)

--------------------------------------------------------------------------------
6bb3b7a | gammafunk | 2017-12-21 22:50:21 -0600

Allow Vile Clutch to work under Sacrifice Love (amalloy, PR#678)
This spell isn't actually creating an controllable ally, and Sacrifice
Love is otherwise consistent about blocking use of ally monsters.

--------------------------------------------------------------------------------
cb6d0b3 | gammafunk | 2017-12-21 22:50:20 -0600

Tweak Kiku's book gifts and remove a double entry (amalloy, PR#678)
When removing Control Undead, I simply had Kiku's second gift book
always contain Animate dead since there was no other level 4 Necromancy
spell. This isn't necessary, since we can choose between Animate Dead
and Agony for the first spell, then Vile Clutch and Excruciating Wounds
in the second. It's better to have more variety in Kiku's gifts.

Also don't mistakenly double the weight of gifting Vile Clutch.

--------------------------------------------------------------------------------
8dea739 | gammafunk | 2017-12-21 22:50:20 -0600

Fix logic in a constriction damage check (amalloy, PR#678)
Technically this case should never arise, but don't count not having a
constriction attack as having a damaging constriction attack.

--------------------------------------------------------------------------------
417cd8a | gammafunk | 2017-12-21 22:50:19 -0600

Satisfy grammarians (amalloy, PR#678)
"I know you didn't write this, but RIP grammar. It's a participle, not a
gerund." --amalloy

--------------------------------------------------------------------------------
d0a639d | gammafunk | 2017-12-21 22:50:19 -0600

Shorten a spell noise check (amalloy, PR#678)

--------------------------------------------------------------------------------
4099806 | gammafunk | 2017-12-21 22:50:19 -0600

Fix spacing (amalloy, PR#678)

--------------------------------------------------------------------------------
d48fd3a | gammafunk | 2017-12-21 22:50:19 -0600

Require solid ground for Borgnjor's Vile Clutch (amalloy, PR#678)
It's reasonable to not allow this spell to work when a monster is in
deep water or lava given the theme of hands reaching up from the earth.
Shallow water is still allowed.

--------------------------------------------------------------------------------
62db60e | gammafunk | 2017-12-21 22:50:18 -0600

Refactor constriction code (amalloy, PR#678)
Don't have so many methods handle both direct and indirect constriction,
and move repeatedly used logic into methods and functions.

Be more consistent about stopping only direct constriction when the
reason is based on physical changes, as opposed to level or LOS changes
that would affect both forms.

--------------------------------------------------------------------------------
e8387de | gammafunk | 2017-12-21 22:50:18 -0600

Remove an old comment
Only applicable for save compat, and it will be confusingly left around
when TAG MAJOR is increased if not removed.

--------------------------------------------------------------------------------
7a04ea1 | gammafunk | 2017-12-21 22:50:18 -0600

Remove the Twisted Resurrection icon
since this is no longer a player spell.

--------------------------------------------------------------------------------
b102ffe | gammafunk | 2017-12-21 22:50:18 -0600

Remove Cigotuvi's Embrace
This spell had a terrible time competing with the other corpse-using
spells and almost never saw actual use by players. It had to compete
with corpse-using spells that already effectively increase your defense
by making allies in addition to dealing damage through those allies. The
time-degeneration aspect needed to limit degenerate tactics made
deciding to use this spell over those spells even less likely.

It may be possible to re-imagine this spell as a death-channel-like
charm that gives defenses when a monster dies. This commit removes this
spell until any such rework can be done.

--------------------------------------------------------------------------------
e53b2ad | gammafunk | 2017-12-21 22:50:17 -0600

Remove Control Undead
This spell was a cheap source of allies in the Necromancy school, a
school that already gives hordes of cheap allies. It did this by turning
nearly any monster with the undead holiness either directly into a
source of out-of-LOS damage or indirectly into a source of damage
through any summons the monster made. Due to the out-of-LOS and
greater-than-usual ally management aspects of temporarily charmed
monsters, enslavement is better kept on the wand of enslavement, which
has limited uses due to charges.

For dealing with summons via a spell we have aura of abjuration, which
at least doesn't both shut down high-level undead summoners and deal
loads of damage at the same time. Necromancy has a new damage spell,
Borgnjor's Vile Clutch, so that addition and removing Control Undead
help shift Necromancy away from feeling like Summonings Redux.

--------------------------------------------------------------------------------
3088ccc | gammafunk | 2017-12-21 22:49:22 -0600

A Level 5 Necromancy/Earth Spell: Borgnjor's Vile Clutch (mikee)
A spell used to simultaneously damage a monster and hinder their
movement. The in-game spell description:

    Calls forth hands from corpses interred beneath the dungeon floor
    long ago. Enemies caught in the area will be held in place and
    constricted until they break free.

This spell helps move the focus of Necromancy a bit away from
summoning-like effects and gives the school some synergy with the Earth
school.  This is a powerful spell likely to remain useful for damage and
escape purposes the entire game, but it does require significant
investment in two schools that otherwise don't have overlap in spells.

For testing purposes it's currently in the Necromancer starting book
(the Book of Necromancy), as well as the Book of Unlife and the Book of
Dreams. Haven't you ever had a nightmare like that?

It may not remain in the Book of Necromancy. Even with the future
removal of Control Undead, this book will have 5 spells culminating with
Vampiric Drain and Animate Dead, which are very strong. That said, this
spell might have a place in that book, possibly depending on other
adjustments to its spell list.

Kiku's book gifts have been adjusted to include this spell where
appropriate.

Spell Details:

Borgnjor's Vile Clutch is smite-targeted with range 5 and a 3x3 area of
effect for applying its enchantment, allowing you to affect monsters up
to 6 squares away. To be susceptible, a monster must be visible, on or
over ground with a solid floor, meaning normal floor or shallow water,
and not resistant to constriction (Note: the solid floor restriction was
actually implemented in a subsequent commit). The latter means it must
be substantial, not a slime, and not have spines. If a cast is
successful, the monster gets a "zombie hands" enchantment and is
constricted (and damaged from this constriction) immediately. The
overall duration is based on spell-power and is generous enough that a
monster is more likely to either escape or die from constriction damage
before the enchantment expires.

A monster going invisible doesn't stop the enchantment after it's been
successfully applied, but the monster's square becoming no longer
visible to the player does. Hence you can't constrict monsters out of
LOS with this spell.

During the enchantment, the monster is indirectly constricted, with the
player free to move independently. A player could decide to cast this
spell and move away in order to prevent the monster attacking them, but
this will give the monster escape attempts as it tries to move.

Damage is done over time according constriction rules, but with the
constriction base damage calculated by spell-power:

2d(5 + spellpower / 15)

Per usual constriction, damage increases over turns of constriction,
with a 5 turn step-down that adds half as much additional damage
on-average as was added in the previous 5 turns.

The chance for a monster to break free depends on spell-power and the
number of escape attempts they've made thus far (including the current
one):

(3 * attempts - 1) / (10 + spellpower / 5)

For 40 spell-power, which is typical for when the spell is first able to
be cast, this gives a 1/9 chance of the monster breaking free
immediately, a 5/18 chance on the next turn, and an 8/18 chance on the
third turn. If a monster does break free, it loses the enchantment and
the spell can be re-cast.

This spell is based on mikee's original tavern proposal at

https://crawl.develz.org/tavern/viewtopic.php?p=321376&sid=e6c1c6bba9bbf5ad71299
a95682c8452#p321376

and on discussions had with him (and *not* elliptic) in ##crawl. Zombie
Hands is a silly name for a spell, and that's not the name of this
spell, except possibly in informal speech. There are no orcs on the
moon, and there never will be.

--------------------------------------------------------------------------------
5bb8f47 | gammafunk | 2017-12-21 22:29:53 -0600

Refactor out an enum and actor property
The held_type enum was vestigial, since the previous uses are now
handled elsewhere. It's only used related to checks whether a monster's
constriction does damage and doesn't need to be marshalled. Remove this
property and add the necessary save compat to handle transferred games.
The constriction damage check is now handled via an actor method.

--------------------------------------------------------------------------------
2314aa1 | Yermak | 2017-12-21 11:43:00 -0500

Require a single keypress to abort ?amnesia
This commit puts ?amnesia in line with other scrolls that bring up a
menu.

There are still inconsistencies left though: any letter keypress that
isn't legal exits ?amnesia's menu but not other scrolls' menus; any
digit keypress does the opposite: doesn't exit ?amnesia's menu but exits
other scrolls' menus; the first string of ?amnesia's menu is coloured in
blue (Forget which spell?), the first string of other menus is in white
(Identify which item?), the formatting is different too.

Resolves #661

--------------------------------------------------------------------------------
e1710fc | Aidan Holm | 2017-12-21 09:56:48 -0500

Add uncollected rune/orb tiles for } menu
The uncollected rune/orb tiles were made with the following imagemagick
command:

  convert in.png -normalize +level 12%,18% -fx intensity out.png

Brightness normalization isn't perfect, and perhaps the parts of each
tile included in the greyed-out version should be restricted; e.g.
mnoleg's rune is a little spotty.

--------------------------------------------------------------------------------
eac747f | advil | 2017-12-21 09:43:03 -0500

Allow partial loading of bones files, and enforce level limits on load
This is a bit hacky: it loads the bones file and then resaves a new one
with any remaining ghosts. I'm not sure there's a good alternative
without significantly rewriting the bones file format (which I don't
really want to do).

Previously, level ghost limits were enforced when saving a bones file;
this switches to enforcing on load I expect this will make D:3-D:10
bones files fill up with ghosts quicker, not sure if this matters; it
also may reduce the average number of ghosts on levels deeper than 10
(though probably not by a lot). If I'm understanding things right, it
also preserves early-game ghosts that kill (non-undead) players, which
were previously guaranteed to be used only once -- this may matter more
than the first two effects (I'm not committed to this aspect of the
change).

The real end goal of this commit is to allow ghost loading one by one,
In preparation for more substantial changes to player ghosts.

--------------------------------------------------------------------------------
79d79c4 | advil | 2017-12-21 09:43:03 -0500

Allow saving arbitrary vectors of ghosts
This still uses the player's current level, so it's not independent of
global state, but this change allows some more flexibility.

--------------------------------------------------------------------------------
49f8b85 | advil | 2017-12-21 09:43:03 -0500

Move some initialization inside ghost_init

--------------------------------------------------------------------------------
907874f | advil | 2017-12-21 09:43:03 -0500

Refactor ghost load/save to avoid global state
This shouldn't have any impact on current behavior, but will be helpful
for just about any changes that might happen to ghosts.

--------------------------------------------------------------------------------
8bd9a9d | advil | 2017-12-21 09:43:03 -0500

Don't create buggy ghosts in wizmode
If they don't have hp, they lead to problems on save/load.

--------------------------------------------------------------------------------
185da8e | Alan Malloy | 2017-12-19 17:32:53 -0800

Clarify display of Fedhas food-based invocation powers (Stonar, #11330)

--------------------------------------------------------------------------------
2c32b0f | Neil Moore | 2017-12-18 23:58:50 -0500

Pull out likes_chunks ? HS_* : HS_* into a function.

--------------------------------------------------------------------------------
1b93aee | advil | 2017-12-18 23:38:41 -0500

Let carnivores get nutrition out of chunks above full (ranchugoldfish)
Missed in the conversion to 1-level mutations, I think.  Because of a
somewhat odd fallthrough-ish setup in _chunk_nutrition, this was giving
gourmand ("extremely unsatisfying") messaging and 4% nutrition to
carnivorous players who ate chunks at HS_FULL or above, unless they were
actually wearing gourmand.

--------------------------------------------------------------------------------
b7d493d | Aidan Holm | 2017-12-18 14:00:07 -0800

Fix extra pixel in demonic rune tile

--------------------------------------------------------------------------------
5a59f16 | Filip Michałowski | 2017-12-18 12:05:24 -0800

Fixed no ability description on R-click (mantis #11231)

--------------------------------------------------------------------------------
50ea28b | Aidan Holm | 2017-12-18 10:58:05 -0500

Fix tiles not properly processing mouse move events
The old continue statement never worked at all: its while loop had
(!key) as a condition, so it was equivalent to a break. I've moved
the check to the start of the MOUSEMOTION handling: there's no point
partially processing the event if there's another mouse motion event
right behind it. Also updated the comment text a little to clarify.

This fix makes targeting mode gloriously smooth when rapidly moving the
mouse; probably fixes lag in other places as well.

--------------------------------------------------------------------------------
c6e9d75 | wheals | 2017-12-17 20:31:22 -0500

Move some relevant information upwards.

--------------------------------------------------------------------------------
eea428d | wheals | 2017-12-17 20:27:53 -0500

Add information about building Crawl on Windows with the WSL.

--------------------------------------------------------------------------------
e8bd881 | Isaac Sloat | 2017-12-17 16:06:43 -0600

Retire, belatedly.
I don't have the time anymore to work on Crawl (and haven't had time for quite 
a while now), and I don't foresee myself revisiting this project in the future. 
I enjoyed contributing to this game, and deeply appreciate the devteam helping 
me learn the ropes a year ago. I'm looking forward to seeing what Crawl becomes 
in 2018 and onwards!

"I wonder... What does this button do?"

[skip ci]
--------------------------------------------------------------------------------
651f7c3 | gammafunk | 2017-12-17 12:31:22 -0500

Remove mutagenic chunks from db_lint
[skip ci]

--------------------------------------------------------------------------------
1e3b116 | gammafunk | 2017-12-17 12:31:22 -0500

Remove some mutagenic chunks from a shop

--------------------------------------------------------------------------------
02dccac | Neil Moore | 2017-12-17 12:31:22 -0500

Remove mutagenic chunks from util/monster.
Double doh.

--------------------------------------------------------------------------------
643a220 | Neil Moore | 2017-12-17 12:31:22 -0500

Fix broken logic, and remove some vestiges.
Doh.

The broken logic was in food.cc, where the relative precedences of >=
and ?: were not respected.

--------------------------------------------------------------------------------
b0796c2 | Neil Moore | 2017-12-17 12:31:22 -0500

Move mutagenic food brand tile to UNUSED.

--------------------------------------------------------------------------------
26a0572 | Neil Moore | 2017-12-17 12:31:22 -0500

Remove mutagenic chunks.
Now that potion of mutation has a reasonable change of increasing the
number of mutations, this secondary means of gaining single mutations is
unnecessary.  I for one will miss eating sky beast and ugly thing
corpses, but it is for the best.

--------------------------------------------------------------------------------
b40dbd6 | Neil Moore | 2017-12-17 12:31:22 -0500

Replace references to fruit in Fedhas ability descriptions.

--------------------------------------------------------------------------------
1eb5282 | Neil Moore | 2017-12-17 12:31:22 -0500

Remove unused fruit-eating messages.

--------------------------------------------------------------------------------
135f6fc | Neil Moore | 2017-12-17 12:31:22 -0500

Checkwhite.
[skip ci]

--------------------------------------------------------------------------------
99be76f | Neil Moore | 2017-12-17 12:31:22 -0500

Rename Fruit acquirement back to Food.
The only special effect of Fedhas is that foodless races can still acquire
food, which doesn't matter for any extant race.

--------------------------------------------------------------------------------
4123852 | Neil Moore | 2017-12-17 12:31:22 -0500

Remove food_is_veggie.
Since there is no longer any food prohibited to carnivores. Keep the
lua function for compatibility, having it always return false.

Also adjust preferred (yellow) food: return true only for Vp blood
potions and Gh chunks.

--------------------------------------------------------------------------------
fcb2e5d | Neil Moore | 2017-12-17 12:31:22 -0500

Correct objstat nutrition counts for food piles.
It was counting only one item per pile towards TotalFooNutr.

--------------------------------------------------------------------------------
420a138 | Neil Moore | 2017-12-17 12:31:22 -0500

Reduce ration nutrition by about 37%.
To make up for the increase in permafood from merging the food types.
Perhaps it would be better (fewer keypresses) to instead keep the total
nutrition and decrease the spawn rate, but that (1) is harder to do, (2)
increases variance, and (3) makes it harder to tune food vaults, since
the quantum of permafood would be coarser.

--------------------------------------------------------------------------------
5b9873a | Neil Moore | 2017-12-17 12:31:22 -0500

Decrease herb/carn ration nutrition.
Preliminary objstat runs show a 36% increase in nutrition for normal
characters, a 55% increase for herbivores, and a 72% increase for
carnivores.  Changing the herbivore/carnivore ration nutrition evens
this out, resulting in a 36-37% increase for everyone.

--------------------------------------------------------------------------------
4bc9aef | Neil Moore | 2017-12-17 12:31:22 -0500

Remove obsolete commends in food.des.

--------------------------------------------------------------------------------
204c329 | Neil Moore | 2017-12-17 12:31:22 -0500

Fix swapped herb/carn food values.
Doh.

--------------------------------------------------------------------------------
b85e219 | Neil Moore | 2017-12-17 12:31:22 -0500

Merge fruit into rations.
Existing fruit are converted to rations at a ratio of approximately 5:1,
and Fedhas abilities are made to take two rations rather than one fruit.
Adjust item weights and quantities in maps to approximate the original
amount of nutrition (ish).

--------------------------------------------------------------------------------
b1bc957 | Neil Moore | 2017-12-17 12:31:22 -0500

Remove royal jellies.
The food, not the monster. RIP puns.

--------------------------------------------------------------------------------
a054861 | Neil Moore | 2017-12-17 12:31:22 -0500

Merge bread and meat rations.
Taking the average of the two for normal, herbivorous, and carnivorous
nutrition.

Move the old meat ration tile to UNUSED. The remaining tile should be
updated to represent a balanced meal rather than simply bread.

Remove some out-of-date nutrition totals from food.des.

The new description needs translation, unless we're giving up on that.

--------------------------------------------------------------------------------
0678283 | Neil Moore | 2017-12-17 12:31:22 -0500

Simplify food_def.
By listing the nutrition value for each type of vory, rather than a base
nutrition value and modifiers.

--------------------------------------------------------------------------------
00fd8db | Neil Moore | 2017-12-17 12:31:22 -0500

Make food restriction mutations single-level.

--------------------------------------------------------------------------------
d2a8542 | Neil Moore | 2017-12-17 12:18:28 -0500

Avoid some clang 6.0 warnings.
The first change is serious:

  * Add a virtual destructor to Delay, to avoid undefined behaviour
    when shared_ptr<Delay>s are freed.

The other two are mostly cosmetic:

  * Remove an unused 'this' capture from a couple of lambdas.

  * Disable -Wtautological-unsigned-enum-zero-compare, which warns about
    construct such as:

        branch_type b = ...;
        if (b < 0 || b > NUM_BRANCHES) return false;

    However, another compiler might give branch_type a signed underlying
    type, in which case we would still want this check (since the "..."
    might have a bad casted or unmarshalled value).  So, rather than
    remove the checks, we disable the warnings (but not similar warnings
    about non-enums).

--------------------------------------------------------------------------------
0e17531 | Neil Moore | 2017-12-17 12:01:15 -0500

Checkwhite.
[skip ci]

--------------------------------------------------------------------------------
593960d | Chris Campbell | 2017-12-16 16:53:56 +0000

Fix messaging for Zin mutation potion cleansing

--------------------------------------------------------------------------------
3327e8e | advil | 2017-12-16 11:01:19 -0500

Let !mutation for Zin at ****** (160) just delete mutations
First: this isn't intended to be a big major capstone ability even
though it happens at high piety, but rather a logical extension of what
Zin already does.  This sequence of changes leaves zin without a
"capstone" ability, which I think is fine. It does leave zin as a god
you can join to keep your mutations stable, which seems to bother some
people, so this could require more thought. After discussion in
idea of using the gift timeout to delete mutations (the original premise
of #522).

The penalty for drinking !mut was already fairly trivial (10 piety, no
penance), and at full piety one could drink these fairly safely --
except that this was communication extremely poorly. This change
clarifies the situation, having Zin always cleanse potions of mutation
at ******, with no piety hit. After some discussion in the dev channel
(with elliptic and |amethyst) this seemed like a reasonable replacement
for the capstone ability that lets zin players actually cure mutations
that get stuck with. Below 160 piety, Zin still doesn't like drinking
!mut (though it's not completely terrible to do); I bumped the piety
penalty slightly to 15. At high but not full piety a !mut is still
unlikely to add much in the way of new mutations, but will clear them,
just at a piety cost.

I considered having cleansing just happen unconditionally, but that
seems to trivialize zin's mutation protection (as well as making god
swapping to cure mutations, if indeed people do that, trivial).

Resolves #522

--------------------------------------------------------------------------------
e0a6212 | advil | 2017-12-16 11:01:19 -0500

Change Zin's mutation protection to be 100% at ****** (160) piety.
Previously this was 100% at 200 piety and 5% at 160 piety. There was
some consensus in ##crawl-dev that having an uncommunicated max point
like this was not great.

--------------------------------------------------------------------------------
fd779ed | Alex Jurkiewicz | 2017-12-16 11:01:19 -0500

Rework gift messaging
s/$GOD will $GIFT as your piety grows./$GOD will $GIFT as you gain
piety./

This removes ambiguity around what happens when the player is at maximum
piety.

--------------------------------------------------------------------------------
7e31929 | Alex Jurkiewicz | 2017-12-16 11:01:19 -0500

Move all god gifting logic into separate functions
This cleans up the gifting logic a bit; despite the ugly diff this
commit involves very little code change. Some gods didn't previously set
success properly, and so it is conceivable that there will be effects of
this happening now.

(This is a partial commit of edb395ada69680e9c4055dfea4f325bd6acb3b27
from PR 522 by alexjurkiewicz.)

--------------------------------------------------------------------------------
aa2292d | Alex Jurkiewicz | 2017-12-16 11:01:19 -0500

Remove Zin's capstone ability
This capstone ability is a bit vestigial, and the following changes to
!mutation will fill the needs of zinnites who want to get rid of
mutations.

(This is a partial commit of 8f7e939df157f7d82f08b4330cb204143006d066 in
PR 522 by alexjurkiewicz)

--------------------------------------------------------------------------------
09e1869 | advil | 2017-12-16 10:51:53 -0500

Unbrace

--------------------------------------------------------------------------------
6746751 | advil | 2017-12-16 10:50:39 -0500

Remove an apport special case by using visible_igrd
Now, apport will work on items in deep water iff the player can see
those items; before it always failed on items deep water with a special
message, regardless of whether the player could see items there. Should
still always fail on lava.  (Partial commit of c5b1387f630209d4807b.)

--------------------------------------------------------------------------------
a7bb147 | advil | 2017-12-16 10:50:39 -0500

Fix a fallthrough

--------------------------------------------------------------------------------
cc02c76 | advil | 2017-12-16 10:50:39 -0500

Docstrings, commenting, formatting

--------------------------------------------------------------------------------
50984c1 | advil | 2017-12-16 10:50:39 -0500

Use refactored push code for door sealing
This should have exactly the same behavior, but this code is a bit
complicated.

--------------------------------------------------------------------------------
7555bd9 | advil | 2017-12-16 10:50:38 -0500

Use new push code for abyss generation

--------------------------------------------------------------------------------
a3e6914 | advil | 2017-12-16 10:50:38 -0500

Refactor imprison to use new push code
This code is hopefully cleaner / better than the old version which is
still entangled messily with sealing.

--------------------------------------------------------------------------------
fc69bf2 | advil | 2017-12-16 10:50:38 -0500

Push items out of the way when a door is closed, if possible
By popular demand, this version pushes items out of the way when closing
a door, but refuses to close a door if there are items that can't be
moved anywhere. (This can come up with deep water, lava, but also when
something like door_vault with a gateway places against a wall.) It
should be impossible to get items under doors on this version.

--------------------------------------------------------------------------------
d16b88a | Alan Malloy | 2017-12-14 16:32:57 -0800

Don't leak information about unid scarves (Brathek, #11325)

--------------------------------------------------------------------------------
d2fb950 | advil | 2017-12-14 12:24:03 -0500

Count WJC passive abilities in morgue files
Also refactored walljump into its own function.

--------------------------------------------------------------------------------
dbbf329 | Alan Malloy | 2017-12-13 11:30:34 -0800

Fix spelling (|amethyst)

--------------------------------------------------------------------------------
549b18d | advil | 2017-12-13 12:16:16 -0500

Add major tag version history to main repository
I wrote this a while ago as a gist, but it seems like a useful
supplementary document to the save compat documentation to be able to
easily point new contributors to.

--------------------------------------------------------------------------------
08ce2bd | advil | 2017-12-13 11:25:04 -0500

Add malmutate to random effects (|amethyst)
This is partly in response to the idea of using random effects lategame
as a source of haste/invis on cleared levels, which apparently happens.
This change provides a bit of potential long term cost for that beyond
draining. As far as I'm aware monsters never use this wand, so this
change doesn't add another source of malmutation aside from the
self-targeting case.

--------------------------------------------------------------------------------
b64b8ae | PabloMansanet | 2017-12-13 10:59:05 -0500

Normalize Number of Attacks under Serpent's Lash
As it stands right now, fast races are unfairly punished and slow races
rewarded when using Serpent's Lash.

There is an aspect of SL that is unavoidable and makes it valuable for
slow characters; a free move is worth more for them. However, since
number of attacks scales proportionally to the character's move delay,
they also enjoyed the additional advantage of hitting more often when
lashing.

This fix makes it so all characters calculate their number of attacks
based on a normalized 10 aut move delay when using Serpent's Lash,
regardless of their movement speed. Keep in mind that the formula still
factors in attack delay as usual, so it won't allow a character to
perform multiple hits with a long attack delay weapon.

Resolves #663

--------------------------------------------------------------------------------
adff09b | Aidan Holm | 2017-12-13 00:17:37 -0800

Fix some outdated info in options guide (mibe420)
This fixes mantis issue #11323
--------------------------------------------------------------------------------
acddea6 | Kyle Rawlins | 2017-12-11 16:28:34 -0500

Tweak INSTALL.txt wording more (amalloy)
[skip ci]
--------------------------------------------------------------------------------
832612b | Kyle Rawlins | 2017-12-11 14:56:45 -0500

Update INSTALL.txt to be less optimistic about MSVC
Previously, it made it sound like building with MSVC was supported and
could actually work.

[skip ci]
--------------------------------------------------------------------------------
8c7b3f5 | advil | 2017-12-08 11:21:02 -0500

Don't crash when a spell_slot rule checks a used letter (11250)
Two changes really: first rename vars in add_spell_to_memory to reflect
the implicit typing going on in this function, and then fix the
now-obvious mistake (bad cast of a spell slot # to a spell_type).

--------------------------------------------------------------------------------
f531e82 | Alan Malloy | 2017-12-07 13:39:52 -0800

Don't let liches keep holy-wrath weapons wielded (/u/hexaflexagon)

--------------------------------------------------------------------------------
a86a592 | advil | 2017-12-07 10:25:45 -0500

Tweak walljump messaging
This changes some of the messaging about failed walljump targeting from
walljump v2 to walljump v3. This may result in more message spam, but it
doesn't make sense to only complain if there's a monster in los any
more. It also tweaks the cancellation behavior in some special cases.

--------------------------------------------------------------------------------
8a80c14 | PabloMansanet | 2017-12-07 10:25:45 -0500

Add prompt for wall jump
Adds a GUI prompt before performing a wall jump. It is now necessary to
walk against a wall twice to actually jump (although it does not need to
be the same segment of wall, in case you change your opinion halfway).

There is a RC file option (wall_jump_prompt) to disable this for players
who are used to the old behaviour.

Hopefully this will significantly reduce accidental wall jumps without
forcing the user to detour through the ability menu, and since wall jump
spam is not a thing anymore, the extra keypress is not an issue.

Resolves #658

--------------------------------------------------------------------------------
a34b322 | Nikolai Lavsky | 2017-12-06 14:07:49 -0800

Add Cling flag to monster info
This commit adds Cling to the list of flags displayed by the monster
utility.

--------------------------------------------------------------------------------
614d7e5 | gammafunk | 2017-12-06 03:35:07 -0600

Don't allow scarves to generate as random artefacts
Scarves are supposed to be distinguished from cloaks by having a special
ego that's more powerful than what you could normally find on a cloak.
Currently artefact scarves are essentially artefact cloaks guaranteed to
have +0 AC. We could try to guarantee a scarf ego for these, but the
egos are meant to be strong and standalone. The existing egos could do a
better job of this, but that's something that can be worked on.

This commit only allows scarves to generate as mundane items, at least
until an unrand scarf gets designed. In the meantime we'll still have
cloaks for random artefacts on this slot.

--------------------------------------------------------------------------------
22d298a | gammafunk | 2017-12-06 03:35:07 -0600

Slightly refactor some item artefact generation code
Don't try (and fail) to repeatedly generate artefact weapons for types
that don't allow it. Instead downgrade them to a good_item ahead of
time.

--------------------------------------------------------------------------------
a8338f0 | Alan Malloy | 2017-12-05 13:46:38 -0800

Mark scarf of spirit shield useless if you have it innately (/u/ClefAria)

--------------------------------------------------------------------------------
1cd18d1 | advil | 2017-12-04 16:20:56 -0500

Don't let Gn change their training settings in tiles (aagocs)
This would still get fixed up on save/load, but within a play session on
local tiles you could turn on/off training for individual skills in the
mouse button panel.

--------------------------------------------------------------------------------
34ea15e | advil | 2017-12-04 16:20:56 -0500

Add some ASSERTs in case gnolls somehow get skills disabled (aagocs)
This is a bug, but the previous behavior would be to trap the player in
the skill menu until the force-quit the program.

--------------------------------------------------------------------------------
b765982 | advil | 2017-12-04 00:29:36 -0500

Update sdl2 submodule with Makefile fix
Did I do this right?

--------------------------------------------------------------------------------
43a1781 | advil | 2017-12-03 17:17:53 -0500

Fix a cut and paste error in b82119a2b70b

--------------------------------------------------------------------------------
d76cfe0 | CanOfWorms | 2017-12-03 00:36:07 -0500

Updated Thermic Engine doll tile
This changes the Thermic Engine's doll tile so that the fire portion looks less 
like the sticky flame status effect, which is placed in the same area.
--------------------------------------------------------------------------------
aaff437 | Neil Moore | 2017-12-02 20:42:45 -0500

Fix an obsolete options example (minmay)
[skip ci]

--------------------------------------------------------------------------------
8d4ebbe | gammafunk | 2017-12-02 02:26:34 -0600

Further improvements to the Hellbinder WizLab
Use a simple list of common demons (tiers 3 and 4) vs tier 2 demons
instead of hand-selecting from each tier and up-weight the tier 2 demons
somewhat. Most of the tier 4 and even some tier 3 are weak for this
depth, but they'll have a better chance to be relevant if the player is
dealing with more of the tier 2. Also increase the size of the
Hellbinder's entourage somewhat.

For the map layout, open up the area between the bottom two chambers so
that there'll be less separation between the map's monsters. In the
Hellbinder's chamber, make the Makhleb's altar area have a wall on the
other side to give cover to those poor demons from nasty player ranged
attacks.

--------------------------------------------------------------------------------
cd93bbd | gammafunk | 2017-12-02 02:26:28 -0600

Small adjustments to Cloud Mage WizLab
Add doors to the starting area and down-weight fire crabs, since those
are pretty weak at this depth. Also improve the Cloud Mage's melee
weapon by removing freezing egos on shorblades and adding a possible
staff of air.

--------------------------------------------------------------------------------
dcb3f5e | advil | 2017-11-30 22:10:09 -0500

Remove old outline font code
This code (which was intended for doing a simple form of anti-aliasing
on mono glyphs) predates the use of freetype, and in particular the use
of a freetype with high-quality modern anti-aliasing. It was
accidentally being used on non-mono fonts with bad results. In principle
this code could be made to work again by having freetype generate a mono
bitmap (FT_RENDER_MODE_MONO), but in practice this seems a bit
pointless.

--------------------------------------------------------------------------------
0ee8fc4 | advil | 2017-11-30 22:10:09 -0500

Don't load any fonts as "outline" fonts
Freetype antialiases by default, and so the glyph-loading code was
applying a simple pseudo-antialiasing algorithm to an already
anti-aliased bitmap. The result is a lot of dark pixels with incorrect
alpha values, which don't blend properly. I'm not really sure why these
specific cases where loaded as outline fonts, but as far as I can tell,
nothing should be.

--------------------------------------------------------------------------------
5c865af | Alan Malloy | 2017-11-30 18:20:34 -0800

Improve level 2 MUT_HOP description (longer than what?)

--------------------------------------------------------------------------------
5070ee8 | advil | 2017-11-30 11:11:46 -0500

Prevent a bad linebreak in the skill menu

--------------------------------------------------------------------------------
ecc5317 | advil | 2017-11-28 08:47:50 -0500

Do a better job setting cursor size in fontbuf_line_reader (aidanh)
The previous version was basically just choosing a random number that
accidentally worked out on retina.

--------------------------------------------------------------------------------
f08a75f | Neil Moore | 2017-11-27 16:48:02 -0500

Correct grammar for AT_POUNCE and AT_SPORE in x-v (#11300)

--------------------------------------------------------------------------------
a8f6b7a | advil | 2017-11-26 18:06:53 -0500

Indicate retina support in mac app bundles
I have no idea what the implications of setting NSPrincipalClass are,
but apparently you're supposed to do it for retina apps, and it doesn't
seem to break anything.

--------------------------------------------------------------------------------
a0ee87a | advil | 2017-11-26 16:09:16 -0600

Update Makefile for SDL-2.0.7 on OS X
Apparently some more frameworks are needed to link SDL.

--------------------------------------------------------------------------------
0135c5a | gammafunk | 2017-11-26 16:09:16 -0600

Update SDL2 contrib to 2.0.7
This contribe includes an upstream fix that allows MSYS2/mingw
compilation to work again.

--------------------------------------------------------------------------------
2eda330 | advil | 2017-11-24 15:21:54 -0500

Remove debugging dprf

--------------------------------------------------------------------------------
52e4085 | advil | 2017-11-24 15:19:32 -0500

Make stabbable tile statuses compatible with attitude statuses
Allow ?? icons to show for neutral monsters.  This still won't show the
?? icons with friendly monsters (11295) because these icons don't mean
confused/sleeping/etc right now -- they mean stabbable. (Friendly
monsters are never stabbable.) This probably isn't very intuitive to
players (I had no idea myself)...

--------------------------------------------------------------------------------
5dcb9f8 | advil | 2017-11-24 15:19:32 -0500

Reprint monster info after wizmode xF

--------------------------------------------------------------------------------
d7c8661 | gammafunk | 2017-11-24 13:51:12 -0600

Prevent getting stranded in Baileys (EMTedronai)
Several baileys have areas behind deep water or lava where you can fly
to pick up loot or where you might get teleported to. Give these areas
exit portals in case players get access to these areas through temporary
means, since forcing players to quit if they make a miscalculation about
their flight duration isn't something we want.

--------------------------------------------------------------------------------
ca0307c | advil | 2017-11-24 10:55:20 -0500

Reword whirlwind descriptions to cue reduced damage (ultraviolent4)
"Lightly" might be too weak for 80% but it's an improvement.

--------------------------------------------------------------------------------
ab55e39 | PabloMansanet | 2017-11-24 10:17:45 -0500

Fix Whirlwind pin
Used to only be cleared after a movement turn, instead of after any time
consuming action, which made it able to kite enemies for longer.

--------------------------------------------------------------------------------
1b60429 | gammafunk | 2017-11-23 22:15:06 -0600

WebTiles support for the monster pinned status icon
This is for the monster status afflicted by Wu Jian Council's Whirlwind
attack.

--------------------------------------------------------------------------------
2afff41 | gammafunk | 2017-11-23 22:06:30 -0600

Add a Tiles monster icon for the pinned status (Ultraviolent4, #11293)
This is for the monster status afflicted by Wu Jian Council's Whirlwind
attack.

--------------------------------------------------------------------------------
696f58f | gammafunk | 2017-11-22 14:34:37 -0600

Clean up transporter landing sites in a vault (amalloy)
In grunt_nemelex_the_gamble, remove the transporter landing site in the
area opposite where the player reached, so they won't mistakenly think
it has a corresponding transporter they could use to reach that area.

--------------------------------------------------------------------------------
7c12b18 | gammafunk | 2017-11-22 14:34:37 -0600

Clean up item placement and generation in a vault (|amethyst)
Don't allow grunt_nemelex_the_gamble to generate items in potentially
unreachable areas, and spread its loot items out more decoratively.

--------------------------------------------------------------------------------
4b1fdcf | gammafunk | 2017-11-22 14:34:37 -0600

Move some vault save compat code to compat.des

--------------------------------------------------------------------------------
22212c1 | advil | 2017-11-22 15:33:23 -0500

Correctly handle dragging between displays with different DPI
Yes, I realize I'm insane.

--------------------------------------------------------------------------------
ef8ecb5 | advil | 2017-11-22 15:33:23 -0500

Refactor high-DPI code
This was all over the place (with fonts, wm, and glmanager storing it
separately), and fairly confusing on top of that. This change
centralizes the density information and code for converting between
device / logical pixels. Should have no impact on behavior.

--------------------------------------------------------------------------------
a0408e1 | Neil Moore | 2017-11-22 14:13:39 -0500

Make Nemelex's gamble a gamble again.
With the addition of transporter landing sites, the player can tell in
advance whether the main transporter leads to prize or peril.  Prevent
that by putting an unused transporter landing in the other possible
destination.

amalloy pointed out that this could lead to confusion, because the
player might think that somewhere on the level there is a transporter
that lands in the correct place.  Ideally we'd clear out both landing
sites (or at least the unused one) after taking the main transporter.
I'll leave that for someone who knows markers better than I do.

--------------------------------------------------------------------------------
87dc6a9 | Aidan Holm | 2017-11-22 13:15:18 -0500

Don't (auto)travel via stairs into exclusions
[Committer's note: This time without crashing when taking unvisited stairs.
 -nfm]

--------------------------------------------------------------------------------
4f54bde | Neil Moore | 2017-11-22 13:04:23 -0500

Remove another varargs function.
_create_random_element_colour_calc was just a varargs wrapper around
the random_element_colour_calc constructor (plus a new).

--------------------------------------------------------------------------------
c317228 | gammafunk | 2017-11-22 11:57:54 -0600

Fix monster wand assessment (saltwaterterrapin)
Monsters use a formula to decide whether they want to use a given wand
based on the monster's HD and the wand's charge value. This formula was
broken when the wand charge value was changed to mean the max charge a
wand could generate with. Fix this, so that Ijyb, Maurice, and others
can happily zap players again.

--------------------------------------------------------------------------------
a335af4 | Alan Malloy | 2017-11-22 09:37:22 -0800

Revert "Don't (auto)travel via stairs into exclusions"
This reverts commit e9ed347cad6fc9e730c97155aa8f1c449e08c3b4.

It caused a segfault on trunk. Reverting for now so it stops breaking,
while we have time to fix it.

--------------------------------------------------------------------------------
0e05f1c | Neil Moore | 2017-11-22 12:00:57 -0500

Remove a varargs function and simplify (advil)
It was used as a wrapper for a non-varargs function that takes a
vector, but with C++11 and initializer lists, we can more easily
call the base version directly.

While we're at it, remove a few parameters, since the function
is only ever called from one place. I didn't go so far as removing
the list of {distance, replacement} pairs and making that a static
array inside the function, but maybe I should have.

--------------------------------------------------------------------------------
2875ce1 | Neil Moore | 2017-11-22 12:00:57 -0500

Checkwhite.
[skip ci]

--------------------------------------------------------------------------------
cd31912 | advil | 2017-11-22 10:42:29 -0500

Remove a few references to wasting charges

--------------------------------------------------------------------------------
d70176a | advil | 2017-11-22 10:38:31 -0500

Remove pakellas device charge id (everyone gets this now)

--------------------------------------------------------------------------------
31fed6f | advil | 2017-11-22 10:23:52 -0500

Clean up a case of charge id conditioning on pakellas (Yermak, 11289)
When picking up an un-id'd paralysis wand, this caused a "will waste
charges" message.  Possibly passive_t::identify_devices can be removed
altogether? Also, is there any way to waste charges any more?

--------------------------------------------------------------------------------
e9ed347 | Aidan Holm | 2017-11-22 07:06:29 -0800

Don't (auto)travel via stairs into exclusions
This prevents auto-travel via staircases that lead to excluded areas,
and asks when traversing staircases into an excluded area. This works
only when the staircase's destination is known, and single-tile
exclusions on the destination staircase (indicating excluded travel in
the reverse direction) are ignored.

--------------------------------------------------------------------------------
5da0f0d | Alan Malloy | 2017-11-21 22:17:42 -0800

Mild copy-editing of changelog.txt

--------------------------------------------------------------------------------
139aec4 | gammafunk | 2017-11-22 00:07:44 -0600

Changelog through 0.21-a0-478-g6b4cb3753b

--------------------------------------------------------------------------------
6b4cb37 | Yermak | 2017-11-21 22:02:20 -0800

Remove Haste reference

--------------------------------------------------------------------------------
afc4b18 | Yermak | 2017-11-21 22:01:30 -0800

Add size to % screen

--------------------------------------------------------------------------------
d103f4b | advil | 2017-11-21 18:13:31 -0500

Make the anomolous due_jungle_book statue grey (|amethyst)
Turns out there was a grey elephant statue tile ready and waiting.

--------------------------------------------------------------------------------
cc397bb | advil | 2017-11-21 18:01:26 -0500

Make that one statue in due_jungle_book diggable
This is a bit confusing now because none of the other statues in this
vault are diggable, but at least as a quick fix this removes one (and
possibly the only) case where setting trees on fire was important. (As a
player, I think that *this* statue is diggable is cued reasonably well,
but this change implies that the other statues are, and might make
someone waste a wand charge.)

--------------------------------------------------------------------------------
05767a1 | Neil Moore | 2017-11-21 13:28:47 -0500

Fix brand weapon tile (#11288).
Recharging removal changed the order of tiles, but that has to match the
enum.

Also, add a comment to item-prop-enum.h warning about changing the order.

--------------------------------------------------------------------------------
129e634 | Neil Moore | 2017-11-21 13:28:46 -0500

Checkwhite
[skip ci]

--------------------------------------------------------------------------------
223bcb9 | gammafunk | 2017-11-21 00:47:38 -0600

Properly handle autopickup of unknown wands (Zibokwe, |amethyst)
Empty wands could previously generate normally, so there were calls to a
function that checks for a known empty wand for purposes of hints mode,
usefulness, and the Tiles UI. Recent wand charge merging commits had
this check look only at charges and not identification, since empty
wands no longer normally exist. But this broke the autopickup of
unidentified wands due to how the usefulness check is performed, based
on what knowledge the player has of such items.

This commit restores the empty check to only return true when the wand
is both empty and identified, and it either removes the check or tags it
for removal with the next major version increase. Empty wands will be
properly handled in transferred games and unided wands will have
autopickup work normally.  After a major version increase, the checks
aren't necessary since the items could only be created in wizmode, and
even then they won't cause problems when evoked due to a empty charge
check in the evocation code.

--------------------------------------------------------------------------------
d587bd5 | Chris Campbell | 2017-11-21 00:20:34 +0000

Even more completely remove recharging

--------------------------------------------------------------------------------
eeb3749 | Alan Malloy | 2017-11-20 15:55:11 -0800

Put trees on the inside of layout_gridlike, not outside
They used to be semitransparent so it made sense for them to form a
decorative border around something, but they've been opaque for quite
a while now.

--------------------------------------------------------------------------------
268bfee | Alan Malloy | 2017-11-20 15:55:11 -0800

Allow dungeon builder to bulldoze trees for reachability
Thanks to /u/azrac_ for reminding us about this bug.

--------------------------------------------------------------------------------
2b5f0e8 | Alan Malloy | 2017-11-20 15:55:11 -0800

Add diagnostic for dungeon connectivity failures

--------------------------------------------------------------------------------
4c202ba | Chris Campbell | 2017-11-20 23:17:53 +0000

More completely remove recharging
Remove the scroll from some vaults, and remove support for the actual effect
itself too (since it already didn't function properly on merged wand stacks).

--------------------------------------------------------------------------------
a1252f7 | Chris Campbell | 2017-11-20 23:15:32 +0000

Add a missing TAG_MAJOR_VERSION check

--------------------------------------------------------------------------------
8120a92 | Chris Campbell | 2017-11-20 22:30:10 +0000

De-pluralise an acquirement prompt entry

--------------------------------------------------------------------------------
0a5f80b | Chris Campbell | 2017-11-20 22:22:53 +0000

Remove wands of lightning
To further reduce the very large number of distinct types of direct damage
wands/evocables. With its removal, wand of flame is also the only remaining
wand that directly duplicates a player spell.

--------------------------------------------------------------------------------
c071dca | gammafunk | 2017-11-20 13:25:03 -0600

Don't show scrolls of recharging on the recognized item menu (Yermak)

--------------------------------------------------------------------------------
102393a | gammafunk | 2017-11-20 13:07:52 -0600

Don't show identified wands in the identification scroll menu (reddit)

--------------------------------------------------------------------------------
2470eb2 | Chris Campbell | 2017-11-20 12:42:21 +0000

Make some move-slowing effects more consistent
Don't randomise monster speed in shallow water (as with players, just apply a
fixed penalty).
Don't give monsters a bonus to movespeed under their own Leda's effect (no
monsters cast it anyway).
Make Root and Frozen apply the same level of slow movement, instead of very
slightly different amounts (they do still apply different amounts to players
and monsters).

--------------------------------------------------------------------------------
737a915 | gammafunk | 2017-11-19 21:37:41 -0600

Remove wands of confusion
This wand is differentiated from the other hex wands ostensibly by being
low-level yet having many charges generated. Unfortunately confusion is
basically as effective as paralysis at disabling monsters, so in
practice a wand of confusion was much more powerful than a wand of
paralysis. It's also a wand that duplicates a low-level spell that's
easily castable for most characters that find it. Lowering its charges
wouldn't make it more interesting as a wand compared to the other four
existing hex wands, so this commit removes it.

Its weight in wand generation and acquirement is given to paralysis and
enslavement with some distributed evenly to the other types in the case
of basic item generation. Wanderers receive wands of paralysis when they
previously would have received wands of confusion.

--------------------------------------------------------------------------------
b644aa4 | gammafunk | 2017-11-19 11:38:01 -0600

Wand Charge Merging V: Remove scrolls of recharging
Scrolls of recharging exist to generate more wand charges, yet those are
not scarce. Recently wands were changed to no longer lose charges
through being partially identified and to have charges merged upon
pickup, both of which give access to more wand charges in inventory.
Even before those changes, it was common to have many wand charges
available in a game and yet have extra scrolls of recharging in
inventory. It would be possible to try to extend the effect of this
scroll to other evokables, but this can't be done in a universal way for
all types, and balance-wise it's better to not generate so many extra
evocable charges.

This commit removes the scroll of recharging from generation, leaving
the scrolls in-game where it's already generated. Its weight for scroll
generation is evenly distributed amongst the other scroll types. For the
evocations trove, the three recharging scroll items are replaced with
two more of the standard evocable or stave items and one guaranteed
manual of evocations.

Recharging code remains for any games that still have the scroll or
Pakellas (which has a wand recharge ability), but is marked for removal
after the next save major version increase.

--------------------------------------------------------------------------------
d6801f7 | gammafunk | 2017-11-19 11:37:44 -0600

Wand Charge Merging IV: Wands of the same type merge charges upon pickup
When the player picks up a wand of a type they already have in
inventory, the charges from the new wand are merged into the existing
one, and the new wand no longer exists.

--------------------------------------------------------------------------------
6cf28c1 | gammafunk | 2017-11-19 11:35:39 -0600

Remove the wand draining effect from Zot traps
This was essentially a form of item destruction and wasn't a very
interesting effect. It encouraged the player to drop wands before
intentionally stepping on Zot traps (e.g. in Zot:5) or just in general
when Zot traps were around and specific types of wands aren't likely to
be useful in the near-term. Thankfully Zot traps have plenty of
interesting and dangerous effects as it is.

--------------------------------------------------------------------------------
0e0890e | gammafunk | 2017-11-19 11:32:06 -0600

Wand Charge Merging III: Wands are destroyed when out of charges
When a player or monster uses the last charge of a wand, the wand is
destroyed. In subsequent commits, wands will merge charges upon pickup
and recharging scrolls will be removed, so there's no need to have empty
wands exist as items.

Existing empty wands in current games will continue to exist, but empty
wands are no longer generated in special vaults and shops and shouldn't
appear in normal games. We still have code to check for empty charges
before evoking a wand, and empty wands can still be created in wizmode
by setting charges to 0. It might be good to refactor code to make a
wand item's existence more directly connected to its charges in some
way.

--------------------------------------------------------------------------------
d679150 | gammafunk | 2017-11-19 11:31:35 -0600

Remove Pakellas Supercharge
Wands no longer have a cap on charges, so this ability is of no use even
in trunk games where players worship Pakellas.

--------------------------------------------------------------------------------
e566d14 | gammafunk | 2017-11-19 11:28:52 -0600

Wand Charge Merging II: Remove the cap on wand charges
A subsequent commit will have wand charges merge between those of the
same type, so it's necessary to remove the cap on wand charges.

--------------------------------------------------------------------------------
f61038a | gammafunk | 2017-11-19 11:18:46 -0600

Wand Charge Merging I: Remove wand charge identification
This is is the first commit in a series to simplify wand management,
removing details that are not interesting but that the player has to
deal with frequently. The major changes from the player perspective are:

1) Wand charges merge upon pickup when the player already has a wand of
   that type.

2) Wands no longer have a cap on the number of charges.

3) Remove wand charge identification; now a wand's charges are seen when
   picked up.

4) Remove scrolls of recharging, since wand charges are already readily
   available, and the aforementioned changes make them even more so.

5) Wands are destroyed when their last charge is used.

This first commit removes wand charge identification, making the current
charges of a wand visible when the wand type is identified (which still
happens upon pickup).

There were a couple proposals to allow the charge wasting/identification
system to work with wand charge merging, but they involved complicated
presentation of charge information. The player would want to know
identified charges, the range of the unidentified charges, and the
average number of unidentified charges (based on how many wands of that
type they had picked up). Displaying all this information isn't worth it
just to make scrolls of identification a bit more useful, so for now we
simply identify charge information whenever the wand type is identified.

--------------------------------------------------------------------------------
74feaab | gammafunk | 2017-11-18 14:34:17 -0600

Remove some unused enum values
Some inventory selectors were no longer in use, yet the enum values
weren't changed to reflect this.

--------------------------------------------------------------------------------
9a9e23e | gammafunk | 2017-11-18 14:34:17 -0600

Mark Pakellas code for removal with major version change

--------------------------------------------------------------------------------
d87a9b2 | advil | 2017-11-17 09:59:32 -0500

Add labeling for pinned monsters
This needs to be signaled somehow.

Resolves #652.  See https://github.com/crawl/crawl/pull/652
for detailed discussion of these WJC changes.

--------------------------------------------------------------------------------
c17f1d9 | PabloMansanet | 2017-11-17 09:59:32 -0500

Refactor and fix Whirlwind Pin
-Moved the Whirlwind Pin effect to a more appropriate location
-Took bloat out of main and into god-passive along with other WJC
functions
-Gave Whirlwind Pin a longer default duration just in case, but kept
clearing it at the beginning of the player's turn.

--------------------------------------------------------------------------------
972c5ad | PabloMansanet | 2017-11-17 09:59:32 -0500

Fix order of ability unlocks
Ensure casting Serpent's Lash can never cause martial attacks to become
unavailable.

--------------------------------------------------------------------------------
8a73434 | PabloMansanet | 2017-11-17 09:59:32 -0500

Add WJC Whirlwind pin effect
- Whirlwind now pins enemies in place. Indefinite enchantment that
prevents the first monster move (only motion, not actions) and
disappears.

--------------------------------------------------------------------------------
a30aec3 | PabloMansanet | 2017-11-17 09:59:32 -0500

Rework WJC Serpent's Lash
- Halve the piety cost and reduce exhaustion time
- Make it first ability to unlock (followed by Lunge, Whirlwind, Wall
Jump and HoE)
- Slightly reduce the bonus damage (50% - 40%)
- Martial attacks made under Serpent's Lash cannot miss
- (cosmetic) Since Distraction is no more, made Serpent's Lash blow up
targets on death instead, as people have reported really liking the
martial gore.

--------------------------------------------------------------------------------
4bd3c4a | PabloMansanet | 2017-11-17 09:59:32 -0500

Rework WJC Wall Jump
 - Remove distraction mechanic
 - Remove target limitation
 - Double time spent in Wall Jump (normalize with walk speed)
 - Double number of outgoing attacks to compensate
 - Adapt Serpent's Lash so it works with two-turn Wall Jump

--------------------------------------------------------------------------------
29a2fec | gammafunk | 2017-11-16 20:05:36 -0600

Remove the secret Crawl ASDF project added by the Shadow Dev Team
You were never supposed to know of its existence!

(It was actually just a normal crawl binary mistakenly added to the repo
in the previous commit)

--------------------------------------------------------------------------------
aba41f5 | advil | 2017-11-16 18:20:06 -0500

Check for slime walls in i_feel_safe
The main issue this commit aims to fix is that lua `feel_safe` uses
this function, and really shouldn't return true if the player is in a
position where they can be damaged by waiting or taking an unrelated
action to the damage source. It could have weird consequences that I
haven't spotted, but I did a quick check through i_feel_safe calls and
there doesn't seem to be anything too bad.  This is a followup of sorts
to 56314776da1, and moves one of the checks there into `i_feel_safe`.

The particular issue was brought up by the lua butchering script
described here:
https://crawl.develz.org/tavern/viewtopic.php?p=322979#p322979
Previously, it endlessly loops if there is a corpse next to a slime wall
until the corpse goes away (usually the player dies first).  For the
record that's not a great way to do auto butchering, I wouldn't be
shocked if there are other endless loop corner cases it triggers. But, I
do think it was making a reasonable assumption about `feel_safe` that
was violated.

There's also a little bit of rewording I did while checking i_feel_safe
calls.

--------------------------------------------------------------------------------
848f44b | advil | 2017-11-11 20:33:49 -0500

Try a little harder to fit the whole tab region in a row
This may or may not look great on other computers/fonts than the three
that I've tested this on, feel free to change or propose changes if you
notice problems. This is basically to make things look better on a
retina mac (because of interactions with high-DPI font rendering), but I
tested it on two non-retina displays including one that's very small.

--------------------------------------------------------------------------------
6e1775c | advil | 2017-11-11 19:58:37 -0500

Better handle fractional advances in font glyphs in tiles
On a high-DPI display, fonts can (and do) use advances that are
fractional relative to logical pixels. These were rendering properly,
but not being incorporated into layout calculations.  Previously, crawl
used the truncated logical glyph width to calculate layout (dropping the
fractional part), which was leading to all sorts of problems at the
edges of the screen.  E.g. the stat region with the default font and
size had an extra device pixel per glyph relative to what layout
calculated its size as, so it extended off the edge of the window.  This
also impacted the height and width of the message display.

This commit properly uses device pixels when calculating text region
widths for layout.  It also now rounds when converting glyph widths to
logical pixels, which will lead to excess whitespace rather than cut off
text. There's still a bunch of code that uses multiplication by
character widths (mostly in menus) and so isn't properly handling
fractional advances yet.  (Multiplication by character widths is
deprecated!)

--------------------------------------------------------------------------------
28109cb | Alan Malloy | 2017-11-09 15:21:18 -0800

Simplify magic_mapping() by naming some intermediate locals

--------------------------------------------------------------------------------
abf74bb | advil | 2017-11-09 12:18:24 -0500

Let mmapping work on saves where forgetting marked everything mapped
4af208bdd212 fixes the forget command, this commit lets mmapping work on
saves where forget was used before the fix.

--------------------------------------------------------------------------------
4af208b | Alan Malloy | 2017-11-09 08:51:52 -0800

Make ?mapping work even after forgetting level map (Beargit, EMTedronai)

--------------------------------------------------------------------------------
e5bf024 | advil | 2017-11-08 18:22:14 -0500

Add an option for people who really like to restart (Zibokwe)
This option allows fully restoring the quick restart behavior I changed
in cbc62810bc49e and 34efee411a0df0. I made this a distinct option, with
default false, because I don't think it will be the expected behavior
for new players, and because lumping it in with existing options would
easily lead to a situation where if you set a combo in an rc file, the
only way to quit the game is to save or crash. That situation still is
possible, but you have to want it to happen.

There's now a lot of options around restarting, but at the moment I
don't see a way of simplifying it and keeping both old and new behavior
(where the new behavior is arguably much more like what new players
would expect).

--------------------------------------------------------------------------------
f55f1f5 | advil | 2017-11-08 10:21:06 -0500

Don't show training target button when describing non-inv items
This applies to item lookup, and when examining floor items. Training
target numeric info is still shown as long as you are in a game. It
could maybe be convenient to have this button around in some cases, but
it doesn't work at all from the lookup screen (which doesn't even render
formatted text), so it's better for now to just disable it.

--------------------------------------------------------------------------------
5164969 | advil | 2017-11-08 09:54:51 -0500

Retain skill focusing when setting a target from inv (Shaded Knight)

--------------------------------------------------------------------------------
806c6c2 | advil | 2017-11-07 21:11:52 -0500

Checkwhite / unbrace

--------------------------------------------------------------------------------
e7131c6 | advil | 2017-11-07 21:11:52 -0500

Several fixes for repeat/again
This commit:
 * handles empty key sequences gracefully (no crashing on 0`` in a new
   game).
 * cleans up state after a repeat cancellation or again failure more
   carefully. Before, it was possible to get odd/inconsistent states
   where the previous command didn't match the key sequence.
 * clears repeat/again state in _reset_game.

I wouldn't say this will fix every weirdness in these commands, but this
fixes everything I was able to replicate.

--------------------------------------------------------------------------------
6a4a694 | gammafunk | 2017-11-07 14:44:29 -0600

Update descriptions of the Ogre species (Pereza0)
In the selection screen description, describe ogres as being competent
at magic instead of excellent, and mention their potential use of armour
in the manual. Clean up some wording in both places. Closes #646.

[skip ci]

--------------------------------------------------------------------------------
01fcc59 | Yermak | 2017-11-07 09:36:54 -0500

Fix identification of floor items in edge cases
Items (wands and books) under player will be identified after using
Shadow Step, transport, stairs or passage of Golubria.

Also Merfolk will now properly change its form after shadowstepping into
water. moveto_location_effects() uses 'stepped = true' here because it
prevents splash upon landing on water, which fits current behaviour. The
only side effect here is that Tonado will run for its full duration
while usual blink shortens it severely.

Resolves #644

--------------------------------------------------------------------------------
517d9b7 | Aidan Holm | 2017-11-07 09:08:21 -0500

Add new card tile to lookup-help menu
Makes this menu a bit more consistent with the others. I've placed the
new tile image in the items/misc with the decks, but really it's more of
a GUI icon.

--------------------------------------------------------------------------------
f361398 | Aidan Holm | 2017-11-07 09:08:21 -0500

Add item tiles to lookup-help menu

--------------------------------------------------------------------------------
08060ca | Aidan Holm | 2017-11-07 09:08:21 -0500

Show branch tiles in lookup-help menu

--------------------------------------------------------------------------------
c5fe4b4 | Aidan Holm | 2017-11-07 08:56:51 -0500

Fix sidebar for large tile_font_stat_size
Earlier changes hardcoded the sidebar pixel width. This change now bases
the sidebar width mostly on the width of the stat HUD (dependent on its
font size), but with a minimum width in tiles as well.

There's also a bunch of dead code removal, and the way the stat HUD is
fitted into the sidebar is improved slightly as well.

--------------------------------------------------------------------------------
98080a9 | gammafunk | 2017-11-04 09:33:54 -0500

Add EMTedronai to the mailmap

--------------------------------------------------------------------------------
d837b2d | gammafunk | 2017-11-04 09:15:28 -0500

Add Yermak to the mailmap

--------------------------------------------------------------------------------
639b47e | Aidan Holm | 2017-11-04 09:41:25 -0400

Fix webtiles section boundaries not being updated

--------------------------------------------------------------------------------
05a6460 | Aidan Holm | 2017-11-04 09:40:05 -0400

Fix health minibars being drawn outside viewport
This can happen when viewing the map with X and then panning.

--------------------------------------------------------------------------------
5b1b836 | Yermak | 2017-11-04 09:35:24 -0400

Improve Maurice's message and fix #11241

--------------------------------------------------------------------------------
fc1ce30 | Aidan Holm | 2017-11-03 10:43:47 -0400

Fix title screen lingering when tile_skip_title = true
Fixes the tile screen showing on other LAYER_TILE_CONTROL layouts
(scenes?) when tile_skip_title = true, such as the doll edit screen.

Not sure if the redraw should be conditional, but it works fine like
this.

Resolves #633.

--------------------------------------------------------------------------------
54598c2 | Yermak | 2017-11-03 10:29:16 -0400

Remove reference to cleared levels from 'Out of the depths' paragraph.

--------------------------------------------------------------------------------
d80284d | Aidan Holm | 2017-11-03 09:51:23 -0400

Make dream sheep tile face left
Also optimized the tile while I'm at it, why not...

--------------------------------------------------------------------------------
dc3326c | Aidan Holm | 2017-11-03 09:13:56 -0400

Fix issue orders prompt when not berserk
The previous message should be flushed regardless of whether the player
is berserk. The if-condition is causing the "Anything else - Cancel"
text to not appear.

--------------------------------------------------------------------------------
0adc95b | Mindcrafter | 2017-11-02 16:03:17 -0700

Improve WJC messaging (sokol815) (#648)

--------------------------------------------------------------------------------
79d0e6c | Mindcrafter | 2017-11-02 13:56:17 -0700

Improve messaging for passage of Golubria (#645)

--------------------------------------------------------------------------------
9d6f0e4 | gammafunk | 2017-11-02 10:57:20 -0500

Give the Vortex monster spell a description

--------------------------------------------------------------------------------
ba8bdf1 | Neil Moore | 2017-11-01 19:02:45 -0400

Fix teleport closets in water_boxes_lemuel.

--------------------------------------------------------------------------------
4a39e9c | gammafunk | 2017-11-01 15:18:57 -0500

Rework of the Hall of the Hellbinder
This map wasn't very threatening for its depth and had layout problems
as well as fixed placement of monsters. The old layout had two far apart
sections that could be used to avoid half of the monsters, either
skipping to the final area or just clear the map while facing few
monsters at a time. Overall the changes in this commit will make the map
more threatening but with more generally useful reward items.

The new layout has the two chamber sections much closer together,
allowing monsters from both sides to more easily travel between.
Additionally the kobold and deep elf demonologists have been replaced
with a demonspawn blood saint or black sun, and the demons now have
randomization as to their location and numbers, placing more monsters
overall. Finally, the Hellbinder, who has a better spellset from a
previous commit, gets some demonic accompaniment in his chamber and now
wields the majin-bo instead of stashing it with his other loot.

For said loot, I've scattered 8 consumable items in the chambers that
still have some extra weight on thematic items useful in the wizlab,
like scrolls of summoning and holy word, or a summoning book containing
the aura of abjuration spell. The main loot pile of 12 items has
somewhat increased weighting for demon weapons, small weighting for
artefact jewellery or a good_item cloak, and uses star_item as the most
highly weighted class. One item from this will be a summoning school
randbook, as before.

--------------------------------------------------------------------------------
a58e5a4 | gammafunk | 2017-11-01 15:17:57 -0500

Adjust the Hellbinder's spell spell set.
It previously had only the lower-level demon summoning spells together
with its hurl damnation, haste, and blink Away spells. This made it sort
of just the old version of deep elf sorcerer. In the soon-to-be revamped
wizlab map where the Hellbinder places, this monster always has demon
monsters generated nearby, which could prevent it from using damnation
effectively.

This commit replaces summon minor demon with summon greater demon and
give that somewhat higher weight. We could try harder to make this
monster something more creative than a cross between a deep elf sorcerer
and a demonologist, but this change will at least upgrade its threat
level for now.

--------------------------------------------------------------------------------
dc66bd4 | gammafunk | 2017-11-01 15:15:08 -0500

Give the Cerebov statue tile a DES name
This allows us to choose this specific tile for granite statues.

--------------------------------------------------------------------------------
2694e31 | gammafunk | 2017-11-01 15:15:07 -0500

Revamp of the Cloud Mage WizLab
This vault places a very limited set of air-themed monsters, some of
which like wind drakes and (especially) insubstantial wisps are too easy
for WizLab depth. Much of the loot had a strong focus on flavor (e.g.
potions of flight) over being a reasonable reward.

This commit revamps the monster list, removing insubstantial wisps and
adding shock serpents and spark wasps, two fast electricity themed
monsters, as well as the three crab monsters, death drakes, and blizzard
demons for more cloud effects. Cloud monsters make the fog machines more
relevant, since the player can fight near these to minimize placement of
harmful clouds. The biggest weight is on air elementals, but the weights
are so that none of these new monsters appear too frequently on-average,
especially the nastier ones.

The loot has been updated to feature more general consumables
potions/scrolls in the two early loot piles that were formerly
potion-only, with some extra weight on haste, and a much smaller amount
on !resistance, ?silence, and ?fog. One of these will contain an
thematic non-consumable item (arguably) helpful for the map.

The main loot pile behind the Cloud Mage is updated to feature some
higher quality item classes (superb_item and star_item) in addition to
the ordinary items. The chance for plain rings of flight are replaced by
artefact rings of flight and good_item boots of flying and running.

--------------------------------------------------------------------------------
7d0f330 | gammafunk | 2017-11-01 15:15:07 -0500

Give Sojobo wind immunity
Now that her air elementals can use Vortex, rWind will prevent her from
taking a large amount of damage every time she summons them.

--------------------------------------------------------------------------------
bd10913 | gammafunk | 2017-11-01 15:15:07 -0500

Show wind immunity in monster info
This was a hidden resistance that a few monsters have, and it effects
player spells like Airstrike and Tornado, as well as the fan of gales,
so it's better to show when a monster is immune to such things.

--------------------------------------------------------------------------------
c23e797 | gammafunk | 2017-11-01 15:15:07 -0500

Give air elementals Vortex, a weakened form of Tornado
Air elementals currently appear primarily in Elf, but they're not
effective monsters there.  They are extremely fast at speed 25, but have
low HP and a weak attack, so when they appear individually they do
little damage.

This commit gives air elementals a Vortex ability that is a 3-radius
tornado with half the normal duration (3 turns instead of 6). Air
elementals can close distance very quickly in order to use this
effectively, but the limited radius still gives players an opportunity
to kill the monster at range if avoiding any damage is necessary. The
limited duration prevents the damage levels from being too high,
especially since the player can often avoid damage for at least one of
the turns when the spell is active.

Air elementals have low HD, which gives them low spell-power, so Vortex
has a spell-power boost relative to Tornado to make the damage
reasonable. A future commit will adjust placement of air elementals in
any early vaults or vaults where they otherwise would not be
appropriate.

--------------------------------------------------------------------------------
c134197 | gammafunk | 2017-11-01 12:39:04 -0500

Add a -force-map option for objstat and mapstat
Using this forces those statistics modes to always place the given map
on every level generated. This is useful when getting e.g. objstat data
for a map on a given level without having to edit the DES file to force
the map to place.

The map is tested for existence and minivaults are properly handled, but
the validity of the map for the given level isn't checked.

--------------------------------------------------------------------------------
f2af9a1 | Mindcrafter | 2017-10-31 14:00:03 -0700

Add 'Size' section to game manual (#643)

--------------------------------------------------------------------------------
291f19a | Alan Malloy | 2017-10-25 16:03:24 -0700

Add Yermak to CREDITS

--------------------------------------------------------------------------------
4337635 | Yermak | 2017-10-25 15:57:09 -0700

Fix LARGE_BONE_PLATES colouring in Statue Form

--------------------------------------------------------------------------------
cbae7d1 | Alan Malloy | 2017-10-25 14:42:38 -0700

Clarify command-line instructions (Yermak)

--------------------------------------------------------------------------------
0b6bec4 | Aidan Holm | 2017-10-20 17:30:01 -0400

Fix formatted_scroller::line_down() returning wrong boolean
'true' indicates the menu position has changed.

--------------------------------------------------------------------------------
417d9d2 | Aidan Holm | 2017-10-19 18:59:34 -0400

Move MEL_TITLE sectioning to MEL_END_OF_SECTION
Commit e7c3f7c9a3ced171f522a22d201bda9d37fed8f0 prevented some in-game
menus from being displayed, such as the eating menu when there was a
choice of items from both inventory and floor. This fixes that by
moving some overloaded functionality into its own MenuEntryLevel.

--------------------------------------------------------------------------------
de6fda0 | Aidan Holm | 2017-10-19 18:59:34 -0400

Fix tiles message region resize behaviour
This fixes a bug where the message region would add and remove lines
repeatedly as the window was slowly made less tall.

--------------------------------------------------------------------------------
2ec2765 | advil | 2017-10-19 15:55:09 -0400

Update mailmap and credits
[skip ci]

--------------------------------------------------------------------------------
4a2d380 | Jean Martel | 2017-10-19 10:58:43 -0400

Fix wizmode mutation resistance bug (#623)
Remove an unnecessary unwind; force=true for the call to mutate already does 
this.
--------------------------------------------------------------------------------
a924934 | Aidan Holm | 2017-10-18 09:02:41 -0400

Fix tiles UI not being redrawn on expose
I use the awesomewm window manager, and when switching to a workspace
(tag) with a running instance of crawl-tiles, the tiles window takes
several seconds to redraw. Before it redraws, the window contains
whatever was in that section of the screen on the previous workspace.
This bug does not appear when minimizing and then restoring tiles.

--------------------------------------------------------------------------------
39bf9ee | nlavsky | 2017-10-18 07:21:01 -0400

Fix message displayed when Gh tries to quaff potion of mutation (#622)
After f20264c8 ghouls get the "You cannot mutate at present." message when they 
try to quaff an identified potion of mutation. The "at present" part is not 
correct, since it's a permanent restriction.

This commit fixes that and clarifies the function's description.
--------------------------------------------------------------------------------
dc75ea7 | advil | 2017-10-17 19:32:44 -0400

Use device pixels for clipping, not logical pixels
glScissor requires device pixels, so without this transformation,
clipping wasn't working well on high-DPI devices (e.g. retina).

--------------------------------------------------------------------------------
fa7d736 | Aidan Holm | 2017-10-17 22:16:45 +0800

Fix resize+keypress crash on local tiles
Sometimes a crash was being caused while rendering the dungeon view tile
region, after enlarging the window. This was caused by the tile region
having been expanded to fill the new available space, but its backing
crawl_view_buffer still having the old size, because the redraw began
before the resize operation was complete:

 1) TilesFramework::getch_ck() gets WME_RESIZE, does layout, queues a
    redraw, amd returns CK_REDRAW.
 2) This return value bubbles up to _getch_mul() on the way to the for
    loop in _get_next_keycode(), which has an if-test that should pass
    for the returned value CK_REDRAW. If it passed, it would resize the
    crawl_view_buffer to the new size.
 3) But execution never gets there, because getch_mul() will check for
    more key events, calling TilesFramework::getch_ck() again if there
    are any. getch_ck() will see the queued redraw, and trigger the crash.

The fix is to pass the CK_REDRAW sentinel back immediately. Also added
assertions to verify that the sizes match.

--------------------------------------------------------------------------------
f28a9d0 | Aidan Holm | 2017-10-17 22:16:45 +0800

Fix leaking a freetype context per loaded font
The old fontwrapper didn't free its FT_Library handles after use, and
used a new one for each call to load_font(). Now, there's a single
static FT_Library instance. This code also used to leak memory
buffers containing the ttf file contents; that's been fixed as well.

--------------------------------------------------------------------------------
8b534f6 | Aidan Holm | 2017-10-17 22:16:45 +0800

Remove dead code, update docs for tile_layout_priority
The functionality corresponding to the gold_turn item in the
tile_layout_priority has been removed; this removes some leftover code
and removes all mention of the gold_turn item. The item is now ignored
to preserve compatibility with existing config files.

--------------------------------------------------------------------------------
eff00c1 | Aidan Holm | 2017-10-17 22:16:45 +0800

Ensure TabbedRegion is given enough height to render tab icons

--------------------------------------------------------------------------------
c8658d2 | Aidan Holm | 2017-10-17 22:16:45 +0800

Remove useless visual separator
The \n======\n separator is not needed, as the file added to the
scroller is bracketed by MEL_TITLEs, which prevents scrolling or viewing
multiple sections at once.

Additionally, the separator has its width specified at menu construction
time; this width will not remain appropriate after a resize event.

--------------------------------------------------------------------------------
e7c3f7c | Aidan Holm | 2017-10-17 22:16:45 +0800

Stop drawing current menu page after a MEL_TITLE entry
This fixes multi-part menus with sections separated by MEL_TITLE entries
not working correctly after a resize. Specifically, the scrolling code
used to scroll down until any MEL_TITLE entries in the next page were
just about to be scrolled into view, but ignored any in the currently
visible page. This necessitated padding overly-short sections with empty
lines (see code removed from command.cc).

Now, menu rendering stops at the first MEL_TITLE within the page region,
and the downward-scrolling code handles this correctly.

--------------------------------------------------------------------------------
dfbc2d2 | Aidan Holm | 2017-10-17 22:16:45 +0800

Fix menu rendering when window size is reduced
This fixes an issue where text rendered by the menu would extend beyond
the bounds of the text buffer on tiles, causing memory corruption and a
crash. This issue was caused by the maximum number of lines to write
being pre-determined, during menu construction.

This fix recalculates pagesize based on the maximum page size given by
the MenuDisplay instance (which varies on resize), and the menu
instance-specific max_pagesize, which is used by some menus to limit the
menu size. The smaller of the two is chosen for (re)rendering the menu.

--------------------------------------------------------------------------------
53b8672 | Aidan Holm | 2017-10-17 22:16:45 +0800

Clean unused code, add assertion
This code didn't seem to do anything, so I removed it.

The assertion guards against memory corruption that occurs when you try
to write text after a cgotoxy() with y out of bounds. Note that a
similar assert for x is inappropriate, as the for loop truncates any
horizontally-out-of-bounds text, and parts of the UI rely on this.

--------------------------------------------------------------------------------
14d58c3 | Aidan Holm | 2017-10-17 22:16:45 +0800

Fix a few tiles rendering glitches
- Fixes cursors still being shown on the dungeon viewport even when the
  cursor has left the dungeon region.
- Fixes updated alt text not always being redrawn.

--------------------------------------------------------------------------------
8ed9be3 | Aidan Holm | 2017-10-17 22:16:45 +0800

Improve layout+spacing of tiles main dungeon view
This fix does the following:

- The sidebar now has fixed width, and is always flush against the
  right side of the window.
- The messages box sticks to the bottom of the screen.
- The main dungeon view expands to fill all remaining space, showing
  parts of partially visible tiles.

--------------------------------------------------------------------------------
740c049 | Aidan Holm | 2017-10-17 22:16:44 +0800

Fix tiles minimap viewport indicator leaving the sidebar
Fixed: on wide windows where the character is on the left of the map,
the rectangle outline over the minimap indicating the current viewport
could overlap the dungeon viewport, leaving the sidebar.

--------------------------------------------------------------------------------
a801f16 | Aidan Holm | 2017-10-17 22:16:44 +0800

Fix sidebar monster/inv background flicker on resize
On every resize event m_flavour is resized and re-randomized. This
caused the individual tiles of the monster and inventory sidebar panels
to change between tile variants randomly.

This fix uses the panel tile's index to choose the tile instead of
m_flavour, so the individual tiles vary in appearance, but not randomly.

--------------------------------------------------------------------------------
43d289b | Aidan Holm | 2017-10-17 22:16:44 +0800

Add GL render clipping support for local tiles

--------------------------------------------------------------------------------
d65dc97 | Neil Moore | 2017-10-16 23:04:19 -0400

Staticalise a few functions.
Also extract a common subexpression into a variable, and constify
another variable.

I was tempted to make _exit_type_to_string return a const char *,
but since TilesFramework::send_exit_reason needs a string, it wouldn't
have actually saved any allocations.  It will be nice when we can use
string_view.

--------------------------------------------------------------------------------
df9fdda | Neil Moore | 2017-10-16 22:48:24 -0400

Avoid a warning from gcc.
Depending on optimisation level, it didn't know that we actually
covered all the cases here. And theoretically someone could have
passed in a casted int and caused us to return who knows what.

--------------------------------------------------------------------------------
022a3cd | Neil Moore | 2017-10-16 22:31:38 -0400

Fix an _add_insert_commands varargs overrun (aidanh, advil)
It was impossible to pass a list of zero commands, because the first
command argument was *not* considered as a possible terminator.
Instead, one needed to pass  (..., "desc", 0, 0) or something along
those lines.

A few callers *didn't* do this, instead passing just a single 0 under
the incorrect assumption that it would terminate the varargs list.  By
sheer luck (because there was typically a zero left somewhere on the
stack, from the previous call), that didn't usually crash.

Fix the problem by ripping out the varargs altogether, instead taking
just a vector of commands that can then be passed on directly to
insert_commands.

For the version of _add_insert_commands with an "int space_to_colon"
argument, the first command actually was treated differently, because
it went before the colon instead of replacing a percent sign.  Keep
it as a separate argument (of the correct type) for that overload,
and move it before the description, to match _add_command.

FIXME: Those two overloads work differently enough that they should
probably not have the same name...

--------------------------------------------------------------------------------
5e037d9 | Neil Moore | 2017-10-16 22:31:36 -0400

Take an argument by const reference.
There was no reason to require a copy/move here.

--------------------------------------------------------------------------------
ab89da6 | Neil Moore | 2017-10-16 22:31:36 -0400

Don't have a member with the same name as its type.

--------------------------------------------------------------------------------
7cd14ec | advil | 2017-10-16 20:40:53 -0400

Various cleanups, including enum classing the game exit type (|amethyst)
Also changed it so leaving the dungeon acts like winning/dying in terms
of whether the startup menu can be bypassed.

--------------------------------------------------------------------------------
af2b63a | advil | 2017-10-16 19:43:55 -0400

Delete an obsolete comment that I missed
[skip ci]

--------------------------------------------------------------------------------
cbc6281 | advil | 2017-10-16 19:21:25 -0400

Further tweak restart behavior and options (Zibokwe)
This started as an attempt to restore some behavior I'd broken on the
previous restart commit where in local tiles (e.g. if restart_after_game
was true) if you had the name and combo set in your rc, death dropped
you right into a new game. This quick restart mode will now work again
(and will work in consoles with `restart_after_game = true`). I didn't
quite conform to the old behavior in that quitting will exit to the menu
-- this is so there is a way to quit crawl besides saving. We'll see if
this bugs tiles players who like to quit a lot, if there are any.

In the process of this I re-overengineered the startup/restart process
and fixed a few things that have always annoyed me. Most importantly,
aborting game setup menus that use game_ended will now never exit the
game and always restart (except for dgl/webtiles with the right
settings). Now, setting `name_bypasses_menu=false` on webtiles will more
cleanly use the menu in webtiles (though it's still somewhat flaky, and
arena doesn't work).  As before this *shouldn't* have an impact on DGL,
hopefully I did that right.

--------------------------------------------------------------------------------
d0ff781 | gammafunk | 2017-10-15 19:47:04 -0500

Fix usage of a prompt function that expects a format string

--------------------------------------------------------------------------------
d56c60c | advil | 2017-10-15 16:19:54 -0400

Add an option to allow having a name set to not bypass the menu
This is primarily to get easy access to the menu on a non-DGL webtiles
build. It's ignored on DGL builds. I didn't do anything to avoid having
to log in still, and I noticed that this is slightly flaky on some saves
for webtiles == you may need to move or something to force a reload.

Reminder: dcss uses a login specific rc file for regular webtiles
builds, so that's where you'd need to set this.

--------------------------------------------------------------------------------
34efee4 | advil | 2017-10-15 15:36:53 -0400

Over-elaborately enable restart_after_game by default
Having this off by default (for console builds) is very confusing,
especially to new players, especially for the tutorials. However, as
usual, change is hard. This commit tries to balance a bunch of things:
what the previous default behavior was, what expectations users might
have based on existing rc settings, the behavior on webtiles builds, and
the goal of having this option enabled.

I did this by making the option ternary (idea due to |amethyst). If set
to `false`, quitting/dying will always exit. If set to `true`,
quitting/dying will always return to the menu. If set to `maybe`,
quitting/dying will return to the menu just in case the startup options
(i.e. name) don't bypass the startup menu, otherwise it will exit.  As
before, the behavior on saving for the maybe/yes cases is configurable
with a separate option.  The new default for console/webtiles builds is
maybe.  Local tiles keep their previous default of true.

For the vast majority of users who (I'm assuming) don't have a name set
in their rc, this will amount to setting the default to true.

--------------------------------------------------------------------------------
397cdb2 | advil | 2017-10-14 23:22:20 -0400

Make the manual bonus match the help (11139) and simplify
This was complicated because once upon a time manuals and crosstraining
were shown in the same slot as a sum. Things are simpler now.

--------------------------------------------------------------------------------
45f8505 | elliptic | 2017-10-14 17:44:04 -0400

Prevent random switching of gnoll titles when their top skills are tied.
For example, previously a GnBe would randomly switch back and forth between
titles for Fighting and for its chosen weapon skill (before Invocations
surpassed both of them at XL 22ish, that is). This should no longer happen.
The reason for replacing shuffle_array() by reverse() instead of just
removing that line for gnolls is that this way is consistent with the
initial title selection (via init_skill_order()).

--------------------------------------------------------------------------------
feb02eb | elliptic | 2017-10-14 17:44:04 -0400

Fix title weirdne