-------------------------------------------------------------------------------- c5509c9e31 | Nicholas Feinberg | 2022-09-30 20:53:23 -0700 Fix holy unrand fallbacks (elliptic) Don't place randart vorpal eudaemon blades! -------------------------------------------------------------------------------- d1b97b9b04 | Nicholas Feinberg | 2022-09-30 20:50:23 -0700 Increase player base regen by 0.2 (elliptic) To make early game resting less annoying. Someone can revert or comp this later, if desired. -------------------------------------------------------------------------------- 85af917532 | Nicholas Feinberg | 2022-09-29 21:10:15 -0700 Only trigger Momentum -Move on a hit Remove a feels-bad. I'm a little concerned about balance here, but hopefully it's fine. -------------------------------------------------------------------------------- 06f667207d | Monkooky | 2022-09-29 13:28:04 -0400 Fixes power leap, line pass, and shadow step (#2756) -------------------------------------------------------------------------------- 0b976cbdc4 | Nicholas Feinberg | 2022-09-28 20:52:16 -0700 Clean up Momentum Strike's -Move Make it only prevent voluntary physical movement - walking, flying around, hopping, etc. Translocations are still unaffected, as are other sources of movement - so you can be trampled, etc. Rewrite the descriptions to be a little clearer. Also rename the old -Move from -Go to Stuck. -------------------------------------------------------------------------------- 62a5988fa7 | Nicholas Feinberg | 2022-09-28 20:24:55 -0700 Don't arcjolt rElec+++ enemies Fixes a warning when arcjolting next to a summoned lightning spire. -------------------------------------------------------------------------------- 5d06c95188 | Nicholas Feinberg | 2022-09-28 10:16:58 -0700 Continue to ruin ebering's vision (Monkooky) Remove an overlooked reference to astral vision / xray_vision, per 1891117ce. -------------------------------------------------------------------------------- 1891117ce2 | Nicholas Feinberg | 2022-09-27 19:03:23 -0700 Remove Ashenzari's Astral Vision (hellmonk) Very thematic, but quite buggy - breaks monster AI, resting, etc. Let's axe it for now. Could maybe bring it back someday as an active, similar to old Ash. -------------------------------------------------------------------------------- 83d47c8028 | Nicholas Feinberg | 2022-09-27 17:47:20 -0700 Rework Volcanic Tap into Momentum Strike Switch it from Conj/Fire/Earth to Conj/Tloc, to reduce the number of spells in the starting book and to push more toward hybrid-friendly schools. Also frontload the power of the spell a bit more. Tile is a placeholder. -------------------------------------------------------------------------------- c060d6dac2 | Nicholas Feinberg | 2022-09-27 17:18:09 -0700 Add new loading art (Gompami) Kobold with a triple crossbow! -------------------------------------------------------------------------------- 2ba88f6271 | Nicholas Feinberg | 2022-09-27 14:05:35 -0700 Fix Airstrike (nicolae) Very bad merge in 068b7645628b362d40088dc8c96a52e76a035056. -------------------------------------------------------------------------------- dd60e06945 | Kate | 2022-09-27 15:58:33 +0100 Fix monster spellcasting test failure -------------------------------------------------------------------------------- cfceee88d3 | advil | 2022-09-27 07:55:25 -0400 fix: don't crash in hailstorm targeting 068b7645628b seems to have a bad cut and paste that removes the return value here, leading to crashiness. -------------------------------------------------------------------------------- 068b764562 | Nicholas Feinberg | 2022-09-26 21:57:55 -0700 New spell: Volcanic Tap (L2 Cj/Earth/Fire) Try three at a level 2 start spell for Reaver. Volcanic Tap is a range 4 smitey (but capable of missing) damage spell, comparable to Stone Arrow. However, it locks the player in place with -Move for 5-8 turns after a cast, and can't be recast until that status wears off. For the first few dungeon floors, it's a 'cast once per fight' spell - a strong pull toward continuing to cast rather than immediately switching to armour. Later, it becomes more situational, since getting locked in place in fights against multiple enemies can be extremely dangerous. Let's try it out. -------------------------------------------------------------------------------- 895c20ea24 | Nicholas Feinberg | 2022-09-26 21:57:55 -0700 Tweak Hailstorm To maybe make it more appealing to Reaver, move it to level 3 and give it a miss chance. This should also serve the cause of making more spells care about accuracy. -------------------------------------------------------------------------------- 161da3a0d4 | Nicholas Feinberg | 2022-09-26 21:57:43 -0700 New background: Reaver A new warrior-mage background, Reavers primarily focus on melee combat, but have a small set of backup spells to use for tough situations. These spells have limitations (Drain, -Move, or simply positioning) that make them difficult or impractical to use as a primary offense. Reavers are intended to be a flexible background - shifting more toward melee, casting, or neither (remaining a hybrid) as the game goes on. Tile by Sastreii. Partially reverts 1cc687962fc2b6 (2011). -------------------------------------------------------------------------------- f478ae5f9b | Nicholas Feinberg | 2022-09-26 21:53:45 -0700 Switch out Ice Elementalist's Hailstorm for SIB Players have historically been a bit unhappy with Hailstorm as the top-end of the Ice Elementalist spellset. It's an interesting spell, but tricky to use effectively, especially without Summon Ice Beast or Metabolic Englaciation to help maintain distance between the player and their enemies. That trickiness suits Reaver exactly, though, so I'm stealing the spell from IE. In exchange, Summon Ice Beast returns to the IE start. 1b49dfe8c25f9 (2021) removed Summon Ice Beast because it was 'overly defining' for the background (and we already have another background defined by summons!). However, now that there's a 1-beast summon limit on the spell and now that it's not stealing attention from Hailstorm, that should be much less of a problem. Let's try it out! -------------------------------------------------------------------------------- 833205f978 | Nicholas Feinberg | 2022-09-26 21:53:37 -0700 New spell: Kiss of Death L1 Conj/Necro. Does high draining damage to an adjacent foe, starting at 2d5 and rising to 2d13 at max (25) power. However, also inflicts heavy drain on the player, equivalent to a use of Ru's Apocalypse. Can bail you out of a tough spot early on, but be careful about over-using it! Intended as a starting spell for the new Reaver background. Kiku can also grant it. Tile by Sastreii. -------------------------------------------------------------------------------- b106f4c828 | Kate | 2022-09-26 21:55:49 +0100 Let Static Discharge affect rElec monsters As long as they're not completely immune to electricity, they should still be valid targets. Also fix resistance being applied twice for its damage. -------------------------------------------------------------------------------- 71e3da25a7 | Kate | 2022-09-26 21:55:49 +0100 Fix missing save compat for a removed vault -------------------------------------------------------------------------------- d541229a0b | hellmonk3 | 2022-09-26 16:50:46 -0400 feat: hermit pendant guarded unrand Also, adjust pendant capitalization (elliptic) -------------------------------------------------------------------------------- f412724dd0 | hellmonk3 | 2022-09-26 16:40:49 -0400 feat: new Okawaru overflow Teaches the player what a real friend looks like. -------------------------------------------------------------------------------- 343ea32564 | advil | 2022-09-26 12:43:43 -0400 fix: save compat for 1eb326923381 Without this, saves where the vault has already placed will crash on loading the level. Alternatively one could disable this vault in the save compat, but I don't have a test save with the vault on hand. -------------------------------------------------------------------------------- 7f746667c4 | Nicholas Feinberg | 2022-09-25 22:19:34 -0700 Fix @ attack delay with haste + finesse (elliptic) Don't claim that haste stacks nicely with finesse in @. I'm not sure when this became broken - it looks like maybe we tried to factor out haste when displaying attack speed in @, and didn't fix the finesse code after we started including haste? -------------------------------------------------------------------------------- 4d237caa85 | Nicholas Feinberg | 2022-09-25 22:10:59 -0700 Let formicids shaft through Tomb I believe this was only forbidden by accident; shafts can't generate as random malevolence effects in Tomb, which incidentally broke Formicid self-shaft. -------------------------------------------------------------------------------- 30045a6dda | Nicholas Feinberg | 2022-09-25 22:06:32 -0700 Mark delvers pre-shafted (acrobat) Don't allow delvers to be shafted in D, for lore and kindness reasons. -------------------------------------------------------------------------------- 10421eeba7 | Nicholas Feinberg | 2022-09-25 21:56:41 -0700 Give lochaber axe *Drain (acrobat) To discourage swapping for higher-damage weapons against single targets. Lochaber axe is an oldschool weapon - if you just toss it aside for newfangled 'bardiches' and 'executioner's axes' at the least excuse, you deserve to get haunted! acrobat also suggested giving a vorpal brand, but that seems excessive to me. If you want the spectacular power of a 5x5 cleave, you shouldn't get mega damage per hit too! -------------------------------------------------------------------------------- 03d90e2e6d | Nicholas Feinberg | 2022-09-25 19:22:19 -0700 Display monster Arcjolt damage (ardl) -------------------------------------------------------------------------------- 748be8cbb9 | Nicholas Feinberg | 2022-09-25 19:18:36 -0700 Remove AK (the background tile) Missed a spot earlier. Partially reverts 1d83d27b2f203060e91c6742e3b95ad49ca714ac, in a sense. -------------------------------------------------------------------------------- fbc108b0ab | Nicholas Feinberg | 2022-09-25 19:15:22 -0700 Fix: banished pharaohs shouldn't bind souls (ardl) Only killing pharaoh ants should trigger the bind soul effect. -------------------------------------------------------------------------------- 7370640ec8 | Nicholas Feinberg | 2022-09-25 14:10:51 -0700 Remove unused targeter_shotgun Gone but not forgotten 7, add fighter flag to mostly compensate accuracy, add XP multiplier to mostly compensate XP. -------------------------------------------------------------------------------- ea98e250e0 | advil | 2022-09-20 17:08:18 -0400 feat: more butterflies This commit makes two changes: * Substantially increase the density of range 2 butterflies. * Approximately double the total amount of butterflies, placing the second set further from the player. Too far? Not enough? I'm not sure... It might be more sensible to explicitly randomize based on local density, not number, but this commit works with existing summon placement tricks. Because it doesn't do this, this commit maybe makes things too strong in enclosed areas? But it doesn't do anything about butterflies dying easily. -------------------------------------------------------------------------------- 630cfc4551 | Nicholas Feinberg | 2022-09-19 21:27:31 -0700 Fix delvers + ?fog + ?butterflies (Monkooky, Solitudinal) Don't show ?butterflies in the unknown items list after you've already found a ?fog on the floor - item sets make that impossible. Closes #2711. -------------------------------------------------------------------------------- b40fab5c76 | Nicholas Feinberg | 2022-09-18 13:37:51 -0700 Make fleeing monsters enter clouds Someone in #dcss suggested this, but I can't find their post again now that I'm looking for it. Anyway, it seems fun. If this makes the Cause Fear spell too powerful, we may simply have to r-word it. -------------------------------------------------------------------------------- 8056f4cfa4 | Nicholas Feinberg | 2022-09-18 13:33:12 -0700 New Cinder Acolyte (Sastreii) -------------------------------------------------------------------------------- ba5a0857d8 | Nicholas Feinberg | 2022-09-18 13:29:25 -0700 Make friendlies avoid blastsparks (acrobat) Make it take a little more work to blow up your pals. -------------------------------------------------------------------------------- 3d28bfe2ac | Nicholas Feinberg | 2022-09-18 13:25:17 -0700 Prompt before walking into blastsparks And don't autoexplore into em, etc. -------------------------------------------------------------------------------- 28931fb96c | Nicholas Feinberg | 2022-09-18 12:58:36 -0700 Make monsters cheat when casting Sandblast (hellmonk) It's too much of a pain to make them take 1.5x time, so make em take 1x instead of 2x. -LOC! -------------------------------------------------------------------------------- 5188dcd197 | Nicholas Feinberg | 2022-09-18 12:57:47 -0700 Fix Arcjolt noise (acrobat) -------------------------------------------------------------------------------- aceff491a1 | Nicholas Feinberg | 2022-09-18 12:54:27 -0700 Make the Robe of Misfortune an early unrand (gammafunk) Seems funny. -------------------------------------------------------------------------------- cbaa6ad2a4 | robertxgray | 2022-09-18 20:28:10 +0100 Fix missing newline in the options guide This breaks the corresponding help dialog in small screens. Bug introduced in f02deff4a79ecda93b89ecfb91e49eea323dc6f2. -------------------------------------------------------------------------------- 78081006d9 | Kate | 2022-09-18 20:25:35 +0100 Fix Golubria timers being stopped by terrain changes (#2728) If all the existing passages of Golubria on a level were temporarily removed (for example by casting Noxious Bog, or by an elemental wellspring creating water), their timers wouldn't resume when the terrain expired and they'd remain permanently (or until restarted by some other action such as reloading the game or casting the spell again). Fix by reapplying the relevant level state whenever any passages are created again. Closes #2728. -------------------------------------------------------------------------------- 51eefa89be | advil | 2022-09-17 14:08:41 -0400 fix: remove a spurious file (Goratrix) Thematic name, but no idea where this came from. -------------------------------------------------------------------------------- 90ed53a01c | advil | 2022-09-17 11:05:59 -0400 fix: tweak shapeshifter notes * indicate known shapeshifters on seen notes in chardumps. (Note: this still doesn't apply to shifters that change out of LOS, their known flag gets dropped in this case) * Reorder the "change" note and any following "seen" note, it makes more sense this way. The ordering here seems to be a little bit delicate, so hopefully these changes (especially the second one) doesn't have any further unexpected side effects... -------------------------------------------------------------------------------- 91d0c66ccf | hellmonk | 2022-09-16 22:52:57 -0400 reduce static discharge damage Still a bit too good with lower power cap. -------------------------------------------------------------------------------- 2a1322497e | advil | 2022-09-14 12:58:21 -0400 fix: mostly disable item actions in menu describe popups The examine changes in 0.29 made it possible to get to describe popups in basically every item-oriented menu, and by default, item actions were enabled for these popups. Aside from the regular inventory menu, these actions are more weird than useful, and some are quite buggy (e.g. (d)rop from the drop menu). In a few cases I can imagine these making sense, but the describe popup action code is not very well suited to custom item lists, so it is a lot more straightforward to simply blanket disable for most InvMenus. Still enabled for regular inventory, and stash menus (but in this case, only ground item actions show up). Resolves #2713 -------------------------------------------------------------------------------- b27577e5d9 | Kate | 2022-09-13 20:45:13 +0100 Fix Arcjolt crashing on dismissed summons -------------------------------------------------------------------------------- c8d74c9d4e | Kate | 2022-09-13 19:38:21 +0100 Show when monsters are hurt by Arcjolt -------------------------------------------------------------------------------- ecb607e51a | Kate | 2022-09-13 19:30:34 +0100 Don't let Arcjolt travel through walls/out of LOS Letting Arcjolt travel through metal walls is intended to be for theme reasons but is inconsistent with how metal walls interact with other lightning spells, and also allows damaging monsters inside vaults from safety. Also fix the spell being able to continue past the caster's LOS. -------------------------------------------------------------------------------- a018f8e90f | advil | 2022-09-12 20:46:10 -0400 fix: maybe quiet another gcc warning A silly warning deserves a silly macro solution. Resolves #2658, and half of #2673 -------------------------------------------------------------------------------- 66a3b8458b | advil | 2022-09-12 20:38:26 -0400 fix: maybe quiet a gcc warning These conditions on wchars were written in an overly involved way that was preventing gcc from detecting that `key` was defined or unused for every condition. -------------------------------------------------------------------------------- 3b1a8e4ee4 | advil | 2022-09-12 17:53:24 -0400 fix: use only annotated tags for version info The new CI script for building debs uses an action that has a bug whereby it can create a (lightweight) tag to hang files on in trunk, independent of the current branch. This, unfortunately, has played havoc with our versioning. And even more unfortunately, it does not appear that a regular pull/fetch will ever remove stale local tags, so servers need some workaround. To fix this issue and also prevent it from happening again, this commit changes the version scripts to use only annotated tags -- the release guide explicitly uses annotated tags, and I think we have been pretty consistent about it. This also seems more consistent with the intended distinction here (from the git-tag man page, "Annotated tags are meant for release while lightweight tags are meant for private or temporary object labels"). Also, no one currently around can figure out why we are using `--tags` in the version info in the first place, something which appears to go back as far as 2f656a0430f3. -------------------------------------------------------------------------------- 95531337e3 | Nicholas Feinberg | 2022-09-12 13:13:32 -0700 Fix blastsparks + hop (Bardcore) -------------------------------------------------------------------------------- 744e84de5b | advil | 2022-09-12 10:04:14 -0400 feat: `tile_display_mode` for local tiles This implements both hybrid and glyph mode for local tiles, in the dungeon view only. Visually, the implementation matches webtiles reasonably closely, including the awful square rendering in hybrid mode. Glyphs mode is probably more accurately rendered than webtiles as it uses some weird hacks to get the grid to exactly match the font size. Unfortunately extending this to show glyphs in other contexts (sidebar, popups, etc) is a fair amount more work, given the way this is all implemented. (Overall, this is a much more involved patch than the webtiles glyph implementation was, because local tiles defined out most of the necessary info.) This commit also fixes a bug in background rendering in local tiles where the rectangle offset shouldn't have used the glyph offset. -------------------------------------------------------------------------------- 5625c4ed77 | advil | 2022-09-12 10:02:13 -0400 Revert "task: add a trunk reminder for the 0.29 tournament" This reverts commit be8da3892a6db78639d8a0adbdc467c1312d330c. -------------------------------------------------------------------------------- c3f1650bb9 | Nicholas Feinberg | 2022-09-11 21:16:19 -0700 Fix: don't place zombies without attacks For example, via Kiku's Unearth Wretches. -------------------------------------------------------------------------------- c067630892 | advil | 2022-09-11 22:08:08 -0400 fix: more AK tag_upgrade fixes -------------------------------------------------------------------------------- 1eb3269233 | hellmonk3 | 2022-09-11 21:50:38 -0400 remove grunt_zot_stairs_overgrown This vault was spoilery, weird, and not very good by modern crawl standards. -------------------------------------------------------------------------------- 367992a1e3 | hellmonk3 | 2022-09-11 21:49:33 -0400 feat: New early unrand, the Hermit's pendant An amulet of faith that sets your invocations skill to 14 and evocations skill to 0 while worn. Description by Pleasingungus, tile by Sastreii. -------------------------------------------------------------------------------- fa959c11ff | hellmonk3 | 2022-09-11 21:31:25 -0400 nerf Simulacrum The power scaling was a bit too good. -------------------------------------------------------------------------------- 7436db4de4 | hellmonk3 | 2022-09-11 21:30:03 -0400 rework Ignacio spawn rate (#2719) Rather than scaling with runes just do a flat 10% per pan floor in games where he spawns. Let people actually see the lad. -------------------------------------------------------------------------------- 2fa46d2e7a | hellmonk3 | 2022-09-11 20:52:19 -0400 feat: Allow branded quickblade generation seems to be disallowed for legacy reasons; quickblades are already quite rare so it seems fine to allow eg acquiring a branded one. -------------------------------------------------------------------------------- 0feb890e1c | advil | 2022-09-11 20:49:01 -0400 fix: fully remove AK from job selection It was still possible to choose AK by doing jobs first, but then you could only pick species randomly and got converted to a monk on game start. This commit will also fix a tag_upgrade build failure. -------------------------------------------------------------------------------- 8307c4eb84 | advil | 2022-09-11 20:45:48 -0400 fix: webtiles build? e63b5e06755426 commented out `TILEP_PART_DRCHEAD` with a note, but doing this prevents webtiles from building. If this part of e63b5e06 were to be reverted, this commit should be reverted too. -------------------------------------------------------------------------------- a6dd27ae95 | advil | 2022-09-11 20:33:53 -0400 feat: show range in scorch targeter This was implicit, in that out-of-range enemies wouldn't highlight, but it's still very useful ui feedback to so out-of-range squares grayed out. This commit also refactors so that scorch directly uses the targeter when choosing targets, and there is therefore only one code path for ui and actual casting. -------------------------------------------------------------------------------- a887aabcbf | hellmonk3 | 2022-09-11 20:20:31 -0400 feat: Upgrade dk_xom_monty_hall The iguana wasn't much of a "prize" compared to the jellies. Upgrade it to a friendly goblin, with the bonus of matching xom's friendship vault lore. -------------------------------------------------------------------------------- 3b22beffe7 | robertxgray | 2022-09-11 20:17:23 -0400 Add the developer name to the metainfo -------------------------------------------------------------------------------- 921e097f49 | robertxgray | 2022-09-11 20:17:23 -0400 Build debian packages using github actions The script debian_changelog.py checks if the latest version in debian/changelog is the same as the release. If they are not the same, then an automatic entry is added: crawl (2:0.99.0-1) unstable; urgency=low * New upstream release. -- Crawl bot Mon, 01 Jan 2022 12:12:12 +0000 -------------------------------------------------------------------------------- 2701b9a906 | robertxgray | 2022-09-11 20:17:23 -0400 New XDG_NAME build variable This variable configures the XDG resource names. The default names are: - org.develz.Crawl_console (console build) - org.develz.Crawl_tiles (tiles build) -------------------------------------------------------------------------------- 6869e69685 | robertxgray | 2022-09-11 20:17:23 -0400 Configure GitHub Actions for AppImage builds -------------------------------------------------------------------------------- 8c09ba367f | robertxgray | 2022-09-11 20:17:23 -0400 Update AppImage and AppStream - AppImage: Fix missing fonts - AppImage: Prepare files for GitHub Actions - AppStream: Use reverse domain names as identifiers - AppStream: Add content rating -------------------------------------------------------------------------------- 9bf192ea13 | robertxgray | 2022-09-11 20:17:23 -0400 Fix some paths on AppImage builds GAME is used to set the name of the executable. Define SAVEDIR because the current path is used otherwise. -------------------------------------------------------------------------------- b3285335bf | robertxgray | 2022-09-11 20:17:23 -0400 Standardize Linux packages - New build target: install-xdg-data. Installs some files required by Linux packages according to the XDG specifications (freedesktop.org). Related resources stored in crawl-ref/source/xdg-data - New build target: appimage. Builds a Linux AppImage with the help of the install-xdg-data target and the linuxdeploy tool. - Debian build updated to make use of the install-xdg-data target. Common files have been removed from the debian folder. Fixed missing icon in crawl menu item if crawl-tiles is not installed. Use Debian's uses machine-readable format for copyright file. Remove menu files based on CTTE #741573. - Documentation and man page updated. Closes #464 Closes #1256 Closes #2049 -------------------------------------------------------------------------------- 9ddfead1bb | mainiacjoe | 2022-09-11 20:14:43 -0400 Permit a Temple map to actually be placed. (#2688) I suspect this TAG typo is preventing the level builder from choosing this map. -------------------------------------------------------------------------------- 4cabb3c838 | Nicholas Feinberg | 2022-09-11 16:21:10 -0700 Fix the build..? -------------------------------------------------------------------------------- 82223dbcf9 | Nicholas Feinberg | 2022-09-11 16:00:18 -0700 Add rF- and rC- badmuts to the general pool These are impactful without being crippling, and change the way that you evaluate threats. Let people enjoy these without having to get Qazlal wrath first! Getting rF- from an OOF is rough, but so are a lot of malmuts. Players will figure things out. :) -------------------------------------------------------------------------------- cc36c8f8a0 | Nicholas Feinberg | 2022-09-11 15:11:23 -0700 Remove conjure flame further MMaybe fix the tag-upgrade build? -------------------------------------------------------------------------------- 26221c613b | Nicholas Feinberg | 2022-09-11 14:02:01 -0700 Readjust Manifold Assault When I first created Manifold Assault, I intended for it to be an incentive for 'melee' characters to hybridize. In practice, it's mostly used by transmuters, since they don't have to balance the costs of getting a spell castable in armour. It's popular there, and that's fine, but the original design goal isn't being accomplished. So, lower Manifold Assault to L4 (from L5), and make it hit half as many targets when used with UC. (It's hard to send your own limbs through twisty space without breaking em!) We'll see how this does. It might be cooler for this to apply contam on cast with UC instead (per ebering). I may revise this. -------------------------------------------------------------------------------- ed78777e1f | Nicholas Feinberg | 2022-09-11 13:56:25 -0700 Fix Hexslinger abbrev (elliptic) -------------------------------------------------------------------------------- bfaf442b86 | Nicholas Feinberg | 2022-09-11 13:55:23 -0700 Actually add Arcjolt tile Oops... -------------------------------------------------------------------------------- e63b5e0675 | Nicholas Feinberg | 2022-09-11 13:55:19 -0700 Remove Abyssal Knight Dungeon Crawl once had many, many zealot backgrounds. The dev team has been steadily moving away from this, because picking a god is a big, interesting, exciting moment in each game. A zealot start has to do something really valuable to justify taking that away. Historically, abyssal knights' big thing was starting in the abyss. This was a fun little minigame, a bit like delver - the bold could wander a bit to try to pick up an extra scroll or potion, the reasonable could race for the exit, and then you could start a normal game. It was a little taste of something different, especially for newer players. However, a series of changes have steadily eroded that experience. Items no longer generate in the Abyss, and you now start on the exit. The correct move is almost always to hit > immediately. It's a nothingburger. Sad! Removing Abyssal Knight from the starting backgrounds allows us to make Lugonu much stronger. Altars to Lugonu scattered around the Abyss are meant as an incentive to worship, but the consequences of your old god's wrath are harsh enough that it's rarely right to do so, and it also feels bad - if you wanted to play a Lugonu worshipper, you'd just start AK! We can now (in subsequent commits) fix both problems. Last and certainly least, this means that adding another background to the centre column of the background picker doesn't add a new row to the display. :) Closes #2689. -------------------------------------------------------------------------------- 06a4886a65 | Nicholas Feinberg | 2022-09-11 13:54:21 -0700 Add Arcjolt tile (Sastreii) -------------------------------------------------------------------------------- 2207dc9a4c | Nicholas Feinberg | 2022-09-11 13:48:29 -0700 Allow Spellforged Servitors to cast Arcjolt -------------------------------------------------------------------------------- 2fb67d7a0d | Nicholas Feinberg | 2022-09-11 13:48:26 -0700 New spell: Arcjolt (L5 Conj/Air) Fires an electrical blast that hits everything adjacent to you, adjacent to creatures adjacent to you, etc, etc, up to the spell's range. It also goes through metal walls, for theme reason. Damage is exactly Fireball's, but ignoring half AC and higher variance. (This may be too strong - my feeling is that the targeting is more restrictive, but I could be wrong.) No big design goal, it just seems fun. -------------------------------------------------------------------------------- 5a0acc285a | Nicholas Feinberg | 2022-09-11 13:46:45 -0700 Add missing blastsparks art Oops! -------------------------------------------------------------------------------- 7e3f6f0d8d | Nicholas Feinberg | 2022-09-11 13:44:03 -0700 Rename Arcane Marksman to Hexslinger Arcane Markspersons have very long and clunky name, which also reads as weirdly gendered/anthrocentric. For the sake of the octopodes among us, rename to the sexier name of 'Hexslinger'. It's a pun! Other names considered: - Archer-Mage - Arcane Sniper - Hexbow -------------------------------------------------------------------------------- ed66197fdc | Nicholas Feinberg | 2022-09-11 13:40:02 -0700 Reduce salamander base damage Again, per 71f743befe3 but without the math. -------------------------------------------------------------------------------- db108d344f | Nicholas Feinberg | 2022-09-11 13:40:02 -0700 Reduce shock serpent retaliation damage by 25% Try to make them a little less punishing to fight. -------------------------------------------------------------------------------- f5932fce55 | Nicholas Feinberg | 2022-09-11 13:40:02 -0700 Reduce orc knight and orc warlord damage Per 71f743befe3, but without the meticulous mathmetical analysis. -------------------------------------------------------------------------------- 97a1fe776a | Nicholas Feinberg | 2022-09-11 13:40:02 -0700 Pull naga warriors back further Even after 76187f39e07, they remain an overwhelmingly dominant Snake and indeed midgame killer. Cut off a few hp and points of base damage. -------------------------------------------------------------------------------- e50850e3d0 | Nicholas Feinberg | 2022-09-11 13:40:02 -0700 Reduce boulder beetle damage somewhat They're a fast-moving, tough enemy for their depth. Reduce their damage from 32 to a more aesthetically pleasing 27 to give players a little more wiggle room when dealing with them. -------------------------------------------------------------------------------- 189654fd88 | Nicholas Feinberg | 2022-09-11 13:40:02 -0700 Reduce orc warrior damage again In 6e9d80e302b, orc warrior damage was reduced to partially compensate for the attack speed changes in 581982f5c1d5 and the weapon damage increase in d9c6a3bf672d99. This was not really a full compensation, though. Comparison for the three most common orc warrior weapons (by killcount): 0.26: Dam/Hit Delay Dam/Aut War Axe 30 12.5 24 Halberd 32 12.5 25 Glaive 34 13.5 26 0.27: Dam/Hit Delay Dam/Aut War Axe 26 10 26 Halberd 28 10 28 Glaive 30 10 30 That is, ignoring AC (which we shouldn't), damage over time was higher across the board in 0.27 onward. To compensate, knock 3 damage back off orc warrior. -------------------------------------------------------------------------------- 41f77ac28b | Nicholas Feinberg | 2022-09-11 13:40:02 -0700 Reduce two-headed ogre damage somewhat Their damage was increased along with their attack delay, but they're getting somewhat too many kills now. Let's pull that back down now, and add a pleasing symmetry with one-headed ogre attack damage while we're at it. -------------------------------------------------------------------------------- b375b1e849 | Nicholas Feinberg | 2022-09-11 13:40:02 -0700 Move hydras a little deeper In D and Lair: they're iconic, but getting too many kills. Scootch em a floor or two deeper, to give players more time to gear up and prep. -------------------------------------------------------------------------------- a70db94c74 | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 New draconian tiles (Sastreii) -------------------------------------------------------------------------------- 7e7a2aba73 | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 Remove the MP cost from evoke blink/invisibility Redundant with their newer drawbacks (-Blink and Drain respectively), and felt weird with the Drain-on-failure of Invis particularly. Adds more of a reason to care about +Blink even if you have the spell castable, since it now works when you're out of MP. -------------------------------------------------------------------------------- 13bd0ecfb8 | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 Autoshoot when bumping with a ranged weapon Extremely annoying to play ranged characters and get randomly prompted. -------------------------------------------------------------------------------- cf644656b2 | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 Give unrands their own colour Teal (per nicolae/ebering), to help players keep an eye out for really special unique properties. -------------------------------------------------------------------------------- e5bca228d6 | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 Give mummies innate Faith (Lici) Mummies have never had a really fun distinct playstyle, and the loss of food made that even more obvious. Give them something new and fun to play with: innate Faith, equivalent to always wearing the corresponding amulet. -------------------------------------------------------------------------------- 95544447e1 | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 Make walking tomes silenceable Consider them to be reading their spells. It seems good for them to have more weaknesses, and makes some sense in terms of consistency that spells in spellbooks do need to be verbally read to take effect. -------------------------------------------------------------------------------- 0aaa971b33 | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 Show possibilities for faded altars Ecumenical (aka faded) altars are intended to increase the variety of the game, by encouraging players to take a risk (get an unknown god) in exchange for an upside (earlier god, small piety or other bonus). There are a few problems with the design, however. Proper play requires thinking about all ~25 possible gods you could get, which is both overwhelming if done seriously, and often bad enough (in the worst case) to discourage altar use entirely. It's also discouraging for those who really dislike certain gods. Instead, let's show a preview of three possible gods you might get, similar to how /polymorph now works. Players can now see a description of each god (reducing the barrier to entry for newer players), and then get one randomly. -------------------------------------------------------------------------------- b03bc503e8 | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 Make batty monsters their own BEH (acrobat) So that it's possible to see when batty monsters are unaware of the player, make 'batty' and 'wandering' separate states. This is probably buggy. -------------------------------------------------------------------------------- 421d095d5f | Nicholas Feinberg | 2022-09-11 13:39:26 -0700 Reduce short sword base delay (elliptic) Early-game compensation for the damage reduction in e8845773e3cb. -------------------------------------------------------------------------------- 5f81fb4344 | Nicholas Feinberg | 2022-09-11 13:39:25 -0700 Add UC damage ratings in the @ UI By overwhelming popular demand. Would love to plop em somewhere more visible, maybe in a new tab of %. -------------------------------------------------------------------------------- 4715a6a9d8 | Nicholas Feinberg | 2022-09-11 13:39:25 -0700 Add tiles for Kindle Blastsparks (Sastreii) -------------------------------------------------------------------------------- 638e43912b | Nicholas Feinberg | 2022-09-11 13:39:25 -0700 Remove Corpse Rot Corpse Rot has been a troubled spell for quite a long time. We've gone through many iterations on it, and few have made players happy. Let's hope Cigotuvi's Dreadful Rot has a better run at it. Also rewrite Kiku gift code. -------------------------------------------------------------------------------- 522f029d39 | Nicholas Feinberg | 2022-09-11 13:39:25 -0700 Remove Conjure Flame As discussed in the preceding commits, Conjure Flame was a cool and powerful spell, but the 'ember' mechanic (necessary for balance purposes) was confusing and frustrating for players. Hopefully Kindle Blastsparks and Cigotuvi's Dreadful Rot will together fill its niche. -------------------------------------------------------------------------------- 08ca5ef3b5 | Nicholas Feinberg | 2022-09-11 13:39:25 -0700 New spell: Cigotuvi's Dreadful Rot (L2 Nec/Air/Pois) Part B of the plan to replace Conjure Flame and Corpse Rot, Cigotuvi's Dreadful Rot plops a single-tile cloud of miasma onto the caster and drains them. (Your flesh rots into miasma!) You get one turn of miasma immunity, but after that, if you're not undead, you'd better hustle out of there. Cloud duration scales with power. (The drain is because this is a very strong effect.) Any creature which is vulnerable to miasma avoids it for dear life, so it's a great way to make some space if you're in a jam. If you have some way to trick monsters into it, though - Gell's Gravitas, Lesser Beckoning, potions of attraction, orbs of mayhem... well, they're in for a bad time! It's also hilariously good against Robin specifically. The hope is that this will be more intuitive than Conjure Flame (with its delayed 'embers' that monsters stomp on), and won't have the self-buff or positioning issues of Corpse Rot. Also it hopefully won't be wildly overpowered. Let's try it! Replaces Conjure Flame in the Hedge Wizard start. Also available as a Kiku gift. -------------------------------------------------------------------------------- debd7cae40 | Nicholas Feinberg | 2022-09-11 13:39:25 -0700 New spell: Kindle Blastsparks (L3 Fire/Air/Tloc) Conjure Flame is a strong effect, but the current incarnation has proven confusing and unintuitive for players. Let's try something a little bit different. Kindle Blastsparks creates a cloud of blastsparks on the caster's tile. When any creature moves *into* that cloud (eg a monster chasing the caster), or when that cloud is hit by fire damage (fireball, wand of flame, etc), it explodes in a 3x3 blast. The blast does low damage, but it also knocks back any creature not at its center, pushing them away. This allows for a whole bunch of cute tricks. Damage currently scales with power from 2d10 to 2d18ish. If players often find it undesirable to increase power, because they'd rather blast themselves as a cheeky movement trick, then we can instead scale cloud dur or knockback chance on power. Replaces Conjure Flame in the FE start book. It's a bit unsynergistic with HW's spells (imp, meph...), so I want to do something else there. -------------------------------------------------------------------------------- c0703345a7 | Nicholas Feinberg | 2022-09-10 15:34:52 -0700 More simulacrum tiles (Sastreii) For X-shaped monsters and orb-shaped monsters. -------------------------------------------------------------------------------- 8b159a9891 | Nicholas Feinberg | 2022-09-09 22:22:48 -0700 Fix: don't mark ?poison dangerous under Q (ThMeInTeam) Or with the robe of clouds. -------------------------------------------------------------------------------- e6a4009bfd | Nicholas Feinberg | 2022-09-09 20:37:27 -0700 Tweak hand crossbow stats Increase base delay by 1 point. In general, we have 1-handed weapons take less skill than 2-handed weapons, since players need some XP to invest in Shields with, but we also have ranged weapons take a bit more skill than comparable melee weapons, since melee weapons also need XP for a ranged option (throwing, evo, invo, etc). A hand crossbow is along the same lines as a double sword or eveningstar (16 skill to mindelay), so set its base delay a little higher, requiring 18 skill. Decrease base damage by 1 point, to 16. This is mostly so people feel happier that an arbalest does more damage than a hand crossbow. (But maybe we should rename it to 'hand cannon' anyway.) -------------------------------------------------------------------------------- 90e3122c3a | advil | 2022-09-08 09:01:21 -0400 fix: add a multidrop sanity check -------------------------------------------------------------------------------- 2e61a25929 | advil | 2022-09-06 13:49:45 -0400 fix: sync webtiles hover on UseItemMenu `,` This completely overrides the superclass code, and so needs to duplicate the webtiles sync call. (Without this, `,` left the webtiles hover on a header, even though the crawl binary had the correct position.) -------------------------------------------------------------------------------- d67112afd3 | advil | 2022-09-06 13:46:10 -0400 fix: suppress initial mouse hover on menu display If the mouse cursor is over a hoverable menu item when a menu pops up, even if it isn't currently visible, a mouseenter event is generated. This can lead to fairly unintuitive initial selections if the mouse is in the wrong place. This commit suppresses hover entirely on initial display. It might be nice to do this in a slightly more nuanced way, but I think this commit is a net improvement. -------------------------------------------------------------------------------- 86a8295270 | Nicholas Feinberg | 2022-09-05 15:21:11 -0700 Maybe fix the famous serpent's lash mimic bug Check for mimics on entering a space, not at end of turn. Is this right? Who knows. -------------------------------------------------------------------------------- 784eafce7f | Nicholas Feinberg | 2022-09-04 21:50:15 -0700 Clarify effects of Strength (acrobat) -------------------------------------------------------------------------------- b2d611f6b1 | advil | 2022-09-02 09:08:51 -0400 fix: remove an unnecessary game links optimization As a bonus, this change makes it a lot easier to customize game links. -------------------------------------------------------------------------------- 1cef19eb02 | Kate | 2022-09-01 21:33:25 +0100 Fix Natasha respawning as neutral when dying while frenzied -------------------------------------------------------------------------------- 86fc33db47 | Kate | 2022-09-01 21:33:18 +0100 Fix frenzied and non-frenzied slime creatures merging -------------------------------------------------------------------------------- e5163829ff | advil | 2022-09-01 14:09:59 -0400 fix: relocate an item use check I thought I was being clever to centralize this check, but without some more refactoring it needs to be done in operation-specific code. This commit prevents crashes when wielding/wearing floor items with a full inventory (jewellery was already ok). -------------------------------------------------------------------------------- 5a63ccc183 | advil | 2022-09-01 00:29:56 -0400 fix: get equip menu mode toggling to fully work This was missing the part that actually let this work, sigh. This implementation is kind of brute force, in order to get something at all to work. -------------------------------------------------------------------------------- c6058ea1ff | advil | 2022-08-31 23:42:59 -0400 fix: item type changing for read/drink menu This was somewhat embarassingly broken as initially implemented. This commit is a quick pass to get it to work, but this would need some refining. -------------------------------------------------------------------------------- ec41be8ddc | advil | 2022-08-31 20:54:24 -0400 fix: some empty menu crashes -------------------------------------------------------------------------------- bbf338a72c | advil | 2022-08-30 08:38:05 -0400 fix: explicitly handle a webtiles error case Occasional exceptions like: 2022-08-30 05:12:17,081 WARN: #5978 Error while handling JSON message (''{"has_focus":true,"generation_id":null,"widget_id"'...')! Traceback (most recent call last): File "/chroot/crawl-master/webserver/webtiles/ws_handler.py", line 1104, in on_message self.process.handle_input(message) File "/chroot/crawl-master/webserver/webtiles/process_handler.py", line 923, in handle_input self.conn.send_message(utf8(msg)) File "/chroot/crawl-master/webserver/webtiles/util.py", line 89, in wrapped return f(*args, **kwargs) File "/chroot/crawl-master/webserver/webtiles/connection.py", line 113, in send_message self.socket.sendto(utf8(data), self.crawl_socketpath) FileNotFoundError: [Errno 2] No such file or directory I'm not sure I exactly understand what is causing this (it seems to be the same connection repeatedly), but this commit causes the socket to explicitly close when it does happen. -------------------------------------------------------------------------------- 806c11bf1d | Nicholas Feinberg | 2022-08-29 07:30:52 -0700 Fix Artificer manual description (#2689) They don't start with a short sword anymore! -------------------------------------------------------------------------------- b3c18b1f4e | Nicholas Feinberg | 2022-08-29 07:30:52 -0700 Fix: make rC+++ monsters immune to Refrig again Broken in aed3a0c8d8a132d27718dec265e5da983d5dda97 . I forgot how monster resists worked. -------------------------------------------------------------------------------- c6d0f036a7 | Kate | 2022-08-28 23:20:42 +0100 Fix monsters not waking up when resisting mass enchantments Monsters that are completely immune to any given mass enchantment still won't necessarily be alerted by them, but any monster that resists Cause Fear, Anguish or Discord will now properly wake up. -------------------------------------------------------------------------------- 42789b21ef | Nicholas Feinberg | 2022-08-27 22:28:52 -0700 Restrict lemuel geyser map depths To D:11-. Nasty autoexplore trap earlier. Still a little bit later, so maybe we should do something more with these. -------------------------------------------------------------------------------- 011bda1208 | Kate | 2022-08-27 17:15:36 +0100 Fix some unrand effects not scaling with time taken -------------------------------------------------------------------------------- 28f7cfb6c4 | Kate | 2022-08-27 17:15:36 +0100 Fix Wereblood shout chance not scaling with time taken -------------------------------------------------------------------------------- 372c29fc68 | Kate | 2022-08-27 17:15:36 +0100 Fix spacing -------------------------------------------------------------------------------- 86255a743f | Nicholas Feinberg | 2022-08-27 09:14:35 -0700 Fix shield delay description They were incorrectly claiming to act like body armour wrt ranged weapon attack speed. -------------------------------------------------------------------------------- be8da3892a | gammafunk | 2022-08-26 15:20:46 -0500 task: add a trunk reminder for the 0.29 tournament -------------------------------------------------------------------------------- 695f716631 | advil | 2022-08-26 14:20:30 -0400 fix: one more blocking annotation It's basically expected that this call will trigger a slow callback alert; this keeps it from being attributed to something else. -------------------------------------------------------------------------------- cfff12708b | advil | 2022-08-26 14:06:34 -0400 fix: unbreak slow callback logging too quick cut & paste... -------------------------------------------------------------------------------- 743cabc681 | advil | 2022-08-26 10:40:00 -0400 fix: prevent massive strings in py27 I know I said that py27 is deprecated, but it's probably better not to do it by making players lag. What was happening here is that the annotate function gets called a lot and appends to a string, but without the context manager in play, the string was never getting cleared, amounting to a fairly rapid memory leak. At the rate this append happens, this code was easily producing a string that hit memory limits, and so I'm pretty sure once this happened each append would trigger a non-trivial swap (and block). This commit refactors so that this annotate call is a (nearly) noop in py27, and also adds in a truncation sanity check (since this error case could still happen if this function isn't called right). Unfortunately I haven't figured out a more clever / elegant way to get username info into the slow callback messaging. I've also simply removed the problem call, since it's better not to make send_message heavy, and I believe the urgency of seeing usernames there is removed by 5d08c370806fe (on CAO I'm currently never seeing blocking in this function any more, which is what should be expected from now on). -------------------------------------------------------------------------------- cf6e50daae | advil | 2022-08-26 09:59:40 -0400 docs: separate changelog for the webtiles server I've ended up writing out most of these in github issues at each release, so it seems useful to reorganize this info into an actual changelog that is stored in the repository. The main audience for this changelog is server admins, and devs who don't normally work on the server, so it is much more technically focused than the game changelog. This commit goes back through my notes from these issues to fill in a few past versions (I think basically to when I and aidanh started actively working on the server, before this it was relatively dormant except for bugfixes back to the original implementation). I expect I've missed details for the old versions, though. The 0.29.0 notes are more guaranteed to be complete. (Also, I've taken this opportunity to impose some of my own aesthetic changelog preferences here.) -------------------------------------------------------------------------------- 142975f185 | Nicholas Feinberg | 2022-08-24 22:29:05 -0700 Fix: ozo's fridge targeter + Hep (CarefulOdds) Don't claim it'll damage Hep ancestors, Fed plants, etc. -------------------------------------------------------------------------------- 557434ed05 | Nicholas Feinberg | 2022-08-24 22:23:32 -0700 Cap Static Discharge power at 50 (hellmonk) 100 power is a lot for a level 2 spell. -------------------------------------------------------------------------------- 09854fe43d | hellmonk | 2022-08-24 22:11:15 -0400 feat: Adjust the silence spell To make it a bit more attractive to characters with low spellpower, increase the fixed portion of the duration and decrease the power-dependent portion. Also, remove the casting noise (this doesn't do anything). -------------------------------------------------------------------------------- 93aa2d5b49 | advil | 2022-08-24 21:49:39 -0400 fix: mark more potential blocking functions in webtiles -------------------------------------------------------------------------------- acc37e2db0 | advil | 2022-08-24 13:04:03 -0400 fix: don't crash on ' in pickup sigh -------------------------------------------------------------------------------- 5e824e72be | advil | 2022-08-24 13:04:03 -0400 fix: fix a webtiles log message -------------------------------------------------------------------------------- e60ba3568b | Nicholas Feinberg | 2022-08-23 20:18:39 -0700 Revert "Switch numpad 5 back to 'wait'" Reverting and reverting in the widening gyre. The committer cannot hear the player; the centre (of the numpad) cannot hold... chaos reigns. This reverts commit 4c767a20b829d4591a964c99a805ecd90d16041d. -------------------------------------------------------------------------------- 64df0e423e | Nicholas Feinberg | 2022-08-23 20:17:40 -0700 Fix: no attacks of opportunity in Sanctuary (#2685) Closes #2685. -------------------------------------------------------------------------------- 5d08c37080 | advil | 2022-08-23 17:24:19 -0400 fix: make webtiles UDS socket connection fully nonblocking On linux (or at least CAO), if the socket buffer gets filled, the server appears to just sleep for the timeout length, and then close the socket. Since the timeout length is 10s, this badly lags the whole server, often causing more timeouts. I'm not sure why this is happening -- it is not the behavior that I would expect (rather, I'd expect it to block until the crawl binary catches up on its input), but in any case, it is bad. There is already code that handles just dropping input if the buffer fills, so setting this to simple non-blocking at least works on CAO in my testing. -------------------------------------------------------------------------------- 8e1c26396d | advil | 2022-08-23 16:17:40 -0400 fix: more webtiles logging -------------------------------------------------------------------------------- e059d3dbb2 | advil | 2022-08-23 14:43:17 -0400 fix: mark some more potential blocking funs (webtiles) -------------------------------------------------------------------------------- f9c0e7fdb7 | advil | 2022-08-23 14:20:41 -0400 fix: reorder CK_NUMPAD_5 binding canonical binding needs to be last -------------------------------------------------------------------------------- afde610a49 | Nicholas Feinberg | 2022-08-23 10:52:58 -0700 Fix a CREDIT per request -------------------------------------------------------------------------------- 9c555d0772 | advil | 2022-08-23 13:49:48 -0400 fix: eliminate some unnecessary disk i/o This extra stat may or may not matter, but this function is definitely a hotspot on cao. -------------------------------------------------------------------------------- 4cc3fdd212 | advil | 2022-08-23 12:24:20 -0400 feat: logging options for asyncio slow callbacks The default debug mode for logging these is fairly useless (for our code at least, it just reports the Tornado code as the problem), and is not ideal for production either. This commit adapts code from the aiodebug package to do lightweight logging to help find slow callbacks. Unfortunately I don't think it is possible to detect hotspots, or at least doing so requires much more advanced techniques than I know about, so to look for blocking code you need to explicitly decorate relevant functions or code. I've done some likely candidates in this commit. This decorator is extremely lightweight, though it's still possible I may need to reverse this part of the commit later. -------------------------------------------------------------------------------- 6d867f7e1d | advil | 2022-08-23 12:24:19 -0400 feat: load logging for webtiles This is mainly for production debugging, and is spammy, so is disabled by default. It responds to HUP. -------------------------------------------------------------------------------- dcc30181a8 | Nicholas Feinberg | 2022-08-23 07:09:26 -0700 Consider rPois- enemies affected by ?poison (dilly) oops -------------------------------------------------------------------------------- d8047c6341 | Nicholas Feinberg | 2022-08-22 21:09:40 -0700 Fix: bring the eye of draining screen back Oops! -------------------------------------------------------------------------------- 3885252ca9 | Nicholas Feinberg | 2022-08-22 20:48:13 -0700 New splash screen by PhilosopherOpposite Licensed under CC0. Source: https://www.reddit.com/r/dcss/comments/wu6f2o/comment/ilcg25z/ -------------------------------------------------------------------------------- 310bbde435 | Nicholas Feinberg | 2022-08-22 20:36:05 -0700 Fix: don't let lochaber axe go through grates (acrobat) -------------------------------------------------------------------------------- 4c767a20b8 | Nicholas Feinberg | 2022-08-22 20:27:39 -0700 Switch numpad 5 back to 'wait' This is symmetric with the other numpad keys. Just as they spend one turn moving in some direction, '5' spends one turn moving in no direction. Partially reverts 0d6ea506dcc. -------------------------------------------------------------------------------- cc983562f6 | Nicholas Feinberg | 2022-08-22 20:25:50 -0700 Fix Ozocubu's Refrigeration usefulness check (dilly) If enemies were weaker than allies, it'd claim there were no targets in range. -------------------------------------------------------------------------------- 94fe547ab8 | advil | 2022-08-22 11:16:49 -0400 fix: numpad keys at the `G` prompt (wheals) These keys were working in some of the subprompts, but not the main prompt. -------------------------------------------------------------------------------- 7c9e10e132 | advil | 2022-08-21 18:57:36 -0400 fix: adjust some numpad key behavior This should enable NP enter as well as numpad scrolling in a bunch of cases, including the main menu. -------------------------------------------------------------------------------- 3a90980b9d | Nicholas Feinberg | 2022-08-21 10:16:49 -0700 Fix Oka throwing weapon gift default force_more (Lici) Broken in 9ffc8e8dbe0b832c. -------------------------------------------------------------------------------- a7cffc901d | Nicholas Feinberg | 2022-08-19 21:34:51 -0700 Fix: give octopodes storm tentacles (dilly) -------------------------------------------------------------------------------- c9032a9cac | advil | 2022-08-19 11:36:49 -0400 fix: unbreak change email/pw This has apparently been broken since 45d3ea808a7ee. Possibly most webtiles servers haven't been restarted since then? Anyways, I only got a report about this today. -------------------------------------------------------------------------------- f48d83f5e2 | advil | 2022-08-18 18:24:55 -0400 fix: add a try...except block in the terminal handler I'm seeing OSErrors on disconnect on this call on CAO in py3. I'm not entirely sure why this isn't happening on my test device, but I'm pretty sure it's simply that a read ends up timed badly with respect to the crawl process ending. Also looks like CBR2 is doing this, so it's probably a linux thing. So, treat it like an error flag. -------------------------------------------------------------------------------- 69b7b797bf | Nicholas Feinberg | 2022-08-18 14:43:18 -0700 Fix: changelog but but (Ge0ff) And remove Lair:6 again. -------------------------------------------------------------------------------- 844d9cd41c | advil | 2022-08-18 16:49:09 -0400 docs: update changelog * reorder sections alphabetically * mention a new local tiles option -------------------------------------------------------------------------------- 1d49662b45 | advil | 2022-08-18 12:11:56 -0400 fix: don't show (g)oto for cases where travel will fail Use a previously static travel check. I'm really surprised I couldn't find an already-existing public function along these lines, so maybe I missed something. (Though, the usual check for a visible monster and then fedhas passthrough + maybe other stuff is done manually in a really large number of cases, so maybe not.) -------------------------------------------------------------------------------- e58dc06b8e | advil | 2022-08-18 12:11:56 -0400 fix: exit conditions for full_describe_square Mentioned in https://crawl.develz.org/mantis/view.php?id=12687 -------------------------------------------------------------------------------- 47a6bb87d6 | Nicholas Feinberg | 2022-08-17 22:04:29 -0700 Fix: remove those those (FizzleBang) -------------------------------------------------------------------------------- 5fe6d566dd | advil | 2022-08-17 22:17:31 -0400 fix: make frog hop targeting exactly match fuzzing Previously, targeting was affected weirdly by statues (see mantis 12697), because it inherited some incorrect logic from explosions. It may have been possible to fix this simply, by changing a param in the beam call, but I have done something a bit more ambitious: this commit uses the exact same targeter code for both targeting and the fuzzing itself. Along the way it adds some more generally useful infrastructure for doing this kind of thing, in particular, a subclass of rectangle_iterator designed for iterating over affected squares of a targeter. (Also, replace a static that annoyed me in targeting code with an actual copy constructor on FixedArray.) -------------------------------------------------------------------------------- 509654366e | advil | 2022-08-17 19:37:15 -0400 fix: send signed Xom piety to webtiles This was maxed against 0 and then cast to an unsigned int on top of that making it very hard to know if you are Xom's special toy on webtiles. Followup to a1f3fc70dd8b21 which at least sent the value to webtiles, but missed the sign issue. Resolves https://crawl.develz.org/mantis/view.php?id=12565 and probably some closed stuff, including #2186. -------------------------------------------------------------------------------- 24050441d8 | advil | 2022-08-17 19:21:31 -0400 fix: don't tell players they are already flying Resolves https://crawl.develz.org/mantis/view.php?id=12700 -------------------------------------------------------------------------------- bc57f8fbdb | advil | 2022-08-17 15:56:06 -0400 fix: let CMD_MENU_EXAMINE on right click work in webtiles I noticed while updating the changelog that I had missed this. Hopefully not too much of a feature to be adding this late... -------------------------------------------------------------------------------- ad17d311a4 | advil | 2022-08-17 15:35:15 -0400 fix: WJC extra spacing As implemented, webtiles needs the binary to be sending preformatted text for any extra screens, but getLongDescription unwraps by default. (The diagrams were saved because indentation also indicates preformatting.) Also, adjust spacing of the text w.r.t. the diagrams, and fix some bad linebreaking. Resolves #2648 -------------------------------------------------------------------------------- 5abcae952a | advil | 2022-08-17 15:01:11 -0400 docs: changelog tweaks Mostly misc UI things. -------------------------------------------------------------------------------- 6eeae00818 | advil | 2022-08-17 14:28:44 -0400 build: bump CI actions/cache version -------------------------------------------------------------------------------- 31cfa1876a | advil | 2022-08-17 14:28:44 -0400 build: use pkg-config for rltiles cross-compiling on mac When building a universal binary or cross-compiling, this tool needs to avoid being linked to a cross-compiled libpng dep for the other architecture. Following the approach used for windows cross-compiling, we just force the issue with pkg-config. This adds some extra deps to the mac release build, but most people doing that will have them already satisfied or easily be able to add them via homebrew or macports. -------------------------------------------------------------------------------- 1249214d54 | advil | 2022-08-17 14:28:44 -0400 build: fix use of DEPCXX when cross-compiling on mac This code from old universal binaries was breaking current universal binaries, by passing the wrong `-target` to rltiles via DEPCXX. This was masked on my M1 test machine because the x86 `tilegen.elf` just ran under rosetta. -------------------------------------------------------------------------------- 7a48c89a40 | advil | 2022-08-17 14:28:44 -0400 build: try universal builds again Runners that support cross-compiling are now available, so let's try that out in CI. It is fairly excruciatingly slow with an empty cache, so it may end up being necessary to disable this by default just for the sake of CI not taking forever. But maybe with caching it'll be ok. -------------------------------------------------------------------------------- 4018c0d16e | Nicholas Feinberg | 2022-08-17 10:14:13 -0700 Clarify TLA mechanics (FizzBang) -------------------------------------------------------------------------------- e7f5c69dce | Nicholas Feinberg | 2022-08-17 10:07:12 -0700 Make enemies more reluctant to enter poison clouds They underestimated them pretty badly, which made scrolls of poison much more lethal than was intended. -------------------------------------------------------------------------------- 6990b1bffc | patrick | 2022-08-16 17:09:53 -0400 Fix a typo in the Condemnation description It is important to have consistent names for your archangels. One must be conscientious of the lore. -------------------------------------------------------------------------------- ee5d04aabb | Nicholas Feinberg | 2022-08-16 12:44:23 -0700 Halve Okawaru throwing gifts By popular demand. It's been a bit excessive ever since other ammo was removed. Doing this via quantity, rather than via gift timer, to avoid messing with the piety curve. Let's reconsider that later. -------------------------------------------------------------------------------- 9ffc8e8dbe | Nicholas Feinberg | 2022-08-16 12:44:23 -0700 Update Oka gift message (Bamboomancer) Plus some comments. -------------------------------------------------------------------------------- 47afbbedbb | advil | 2022-08-16 15:15:26 -0400 lint: unbrace -------------------------------------------------------------------------------- 619dfb4ed5 | advil | 2022-08-16 13:40:13 -0400 fix: a very old off-by-one error in `join_the_dots` I've convinced myself that this is not intentional, good to fix, and safe to fix. We'll see -- this pathfinding method is heavily used. The issue appears to originate from 883396a6ffc, and is that `cur.insert(cur.begin() + random2(cur.size()), *ai);` cannot insert at the end of `cur`. Since `cur` starts empty in the relevant loop, and at most three things can be inserted, this insertion or the resulting behavior is completely deterministic in a number of circumstances and at least always deterministic in what the third element is if there are three. The most visible one I am aware of was when pathfinding near a masked region (a vault), if the path gets pushed N or S by a mask, and needs to eventually get the other direction, emergent behavior can (must?) cause the path to continue deterministically N or S until it hits something (e.g. the map boundary), and then make a loop back, also moving straight. This often looks quite weird, especially if there is a long distance to the map boundary. Example (I was able to replicate this exact case using the seed and spent some time investigating it): https://www.reddit.com/r/dcss/comments/wl9yrm/odd_shallow_water_formation_should _i_be_looking/ This commit also includes some useful debug code that I wouldn't want to write again, and tries to comment the pathfinding part of this algorithm to the best of my understanding (it's odd). I've also isolated the rng here, to try to control the impact of calling jtd and random draws before and after for any future changes to this algorith (since it had a very unpredictable effect due to the varying number of draws). This may or may not be futile. -------------------------------------------------------------------------------- 7c58e119a4 | Alex Jurkiewicz | 2022-08-15 16:25:01 -0700 Remove unused variable ui.cc:2174:9: warning: variable 'ew' set but not used [-Wunused-but-set-variable] int ew = 0; ^ -------------------------------------------------------------------------------- 17b7e71a25 | Nikolai Lavsky | 2022-08-15 16:24:01 -0700 fix: don't offer Meteorae potion petitions with invisibility Since Meteorae can become invisible only via the shadow form, there is no point to offer them petitions with the invisibility potion. -------------------------------------------------------------------------------- fc2ad454c0 | Nicholas Feinberg | 2022-08-15 16:23:21 -0700 Disable opportunity attacks when swapping Since the enemy can't follow you directly anyway. Probably this should also apply to moving out of a fedhas plant. -------------------------------------------------------------------------------- 9f74c4bd0f | Nicholas Feinberg | 2022-08-15 16:23:21 -0700 Turn sandblast into speedblast Player feedback feels very strongly that 2x delay is too high. By popular demand, let's try it at 1.5x delay instead. -------------------------------------------------------------------------------- 569b05d6ff | Rytis Petronis | 2022-08-14 23:08:34 -0700 Add sentei_temple_godly_chess chessboard temple for 17 gods [ Committer's note: Closes #2636. Taught the gods a bit more opening theory. ] -------------------------------------------------------------------------------- 87b1fcd763 | Nicholas Feinberg | 2022-08-14 18:37:39 -0700 Put meteorans and palentongae in jail Add them to a silly arrival vault, and remove dwarves again (rip). -------------------------------------------------------------------------------- c98ce4fa87 | Nicholas Feinberg | 2022-08-14 18:35:08 -0700 New player species tiles (Sastreii) Octopode, meteoran and palentonga. Vault only. -------------------------------------------------------------------------------- 074fecc49e | Nicholas Feinberg | 2022-08-14 18:25:40 -0700 Add a tiles section to the changelog -------------------------------------------------------------------------------- fc20370e89 | Nicholas Feinberg | 2022-08-14 13:51:49 -0700 Fix changelog formatting -------------------------------------------------------------------------------- ce01778f00 | Nicholas Feinberg | 2022-08-14 13:50:11 -0700 Remove Deep Dwarves (from the changelog) (Goratrix) -------------------------------------------------------------------------------- d913b07440 | Nicholas Feinberg | 2022-08-14 11:24:53 -0700 Assorted changelog fixes and tweaks -------------------------------------------------------------------------------- b5b6a5fa4f | Nicholas Feinberg | 2022-08-14 11:24:53 -0700 Cut Artificer iceblast starting charges (acrobat) Nine /iceblast on d:1 was a bit much. Take it down to five. -------------------------------------------------------------------------------- e50532568f | Edgar A. Bering IV | 2022-08-14 10:50:28 -0700 Revert "Simplify Drain Life logic" This reverts commit 5bf4a2a1db00f9f780ff1542a8ce14cca4721bce. The commit message says that players don't cast Drain Life anymore but Yredelemnul's Drain Life ability still exists and uses SPELL_DRAIN_LIFE under the hood. -------------------------------------------------------------------------------- cbed440bb6 | Nicholas Feinberg | 2022-08-14 10:29:54 -0700 Docs: changelog through 0.29-a0-1033 -------------------------------------------------------------------------------- b6c65ffae6 | Nicholas Feinberg | 2022-08-13 18:10:34 -0700 Rephrase -Scroll/-Potion mutation desc (#2629) Avoid use of the term 'threatened' where it would be ambiguous. -------------------------------------------------------------------------------- 2b1b757b24 | Nicholas Feinberg | 2022-08-13 18:03:08 -0700 Fix: don't "fizzle" on v-v (#2649) This code is a nightmare. Fixes #2649. -------------------------------------------------------------------------------- 489732b8f0 | Nicholas Feinberg | 2022-08-13 15:01:49 -0700 Don't consider all items to be in sets (Plaidstone) oops -------------------------------------------------------------------------------- f5f8719cae | gammafunk | 2022-08-13 16:10:09 -0500 fix: Correct tagging in an arrival vault (acrobat) For kb_arrival_jail, this vault was only partially updated for species removals and additions. It now has cells with no corresponding monster that are also not appropriately tagged for no_tele_into and no_item_gen. Fix this by putting in additional species monsters in the empty cells. Some of the newer species monsters don't have appropriate tiles for use as decorative monsters, but we'll hopefully be getting those soon. Instead of resizing the vault only to revert that change later, fill the empty cells with random species monsters that we can use. Also reglyph the vault to use glyphs with no default definition. -------------------------------------------------------------------------------- 3196055cea | Nicholas Feinberg | 2022-08-13 13:59:36 -0700 Remove starting item spoilers Don't allow players to determine which items from a given set will spawn in a game by checking the 'unknown items' list after picking an artificer, delver or wanderer. -------------------------------------------------------------------------------- de8b1eb099 | Nicholas Feinberg | 2022-08-13 12:37:00 -0700 Tweak Ozocubu's Refrigeration damage further To try to make the positional aspect of the spell's damage more noticable, make the adjacency penalty for damage 2/3rds / 1/3rd for 1 / 2 adjacent creatures (was 3/4ths / 1/2). -------------------------------------------------------------------------------- cd8c55af63 | advil | 2022-08-11 17:02:10 -0400 fix: correctly initialize seed info for ancient games For games prior to `TAG_MINOR_SEEDS`, seed info was not getting set at all. For games prior to `TAG_MINOR_GAMESEEDS`, they were incorrectly getting the default value for deterministic_pregen (true). -------------------------------------------------------------------------------- 659819d403 | advil | 2022-08-11 14:26:14 -0400 fix: ancient save compat The fixup in 83a48905f1 can lead to crashes on very old saves (testing with a 0.11 save) because these props don't exist. Creating empty versions seems to make things ok. -------------------------------------------------------------------------------- cb49e86079 | advil | 2022-08-11 12:23:01 -0400 fix: fix exiting popup version of the yesno prompt The popup version was exiting too vigorously, because of changes in how keyhandling work. This commit brings its behavior more in line with the message prompt version, where incorrect keys (I have restricted this to just alpha keys) will now show an error message instead of exiting. -------------------------------------------------------------------------------- ec03ce3624 | advil | 2022-08-11 11:59:32 -0400 fix: add a couple of !d checks Resolves #985, and one was also missing from the describe popup drop call. (For Reasons, `drop_item` itself does not perform this check, in contrast to e.g. the wield call.) -------------------------------------------------------------------------------- 6ae1a4a2c7 | advil | 2022-08-10 14:08:46 -0400 fix: handle color in "Found..." messages correctly This had two parts. First: the use of a closing tag in message.cc is simply incorrect, on the current state of things -- colour strings are valid without closing tags, though closing tags must match if present, so wrapping an open and a closing tag around an arbitrary colour string therefore does not guarantee a valid colour string (bug introduced in ae15d2e64f). This at long last resolves #1224. Second: using `formatted_mpr` in the travel.cc for some "Found..." messages is incompatible with consistent coloring given the current state of things, because it eliminates any sense of a default color. So even with the first fix, messages with sub-coloring were not affected correctly by a `message_colour` rc line (e.g. when an un-id'd scroll was in the same message as something else). N.b. if `formatted_string` was refactored to use a more stack-like representation internally, as in #1249, then the second fix at least wouldn't be necessary. However, that PR has been languishing for a long time, and is a bit overkill for this bug in any case, given that the use of formatted_mpr is extremely rare (maybe should be eliminated). -------------------------------------------------------------------------------- 3e17be3ea5 | advil | 2022-08-10 11:29:46 -0400 fix: remove an `mpr` overload in favor of `formatted_mpr` These are redundant, and the `mpr` overload is used exactly once; I think the `mpr` overload was only added (in dbf363a7764) because it's easy to miss the existence of `formatted_mpr` (which is in a different header). I have also prevented the implicit cast that led to the issue in 6ad10583fd2. The alternative, removing `formatted_mpr` and leaving only the overload, is maybe simpler as an API, but `formatted_mpr` has a bunch more params than regular `mpr`, and also I think it is worth someone knowing this conversion is happening and handling it explicitly. This commit reverts dbf363a776. -------------------------------------------------------------------------------- eaf7ee7e1e | advil | 2022-08-10 11:02:37 -0400 fix: complicate to_colour_string defaults Yet another adjustment to 29c30a7bfa8. That commit was really tailored at dealing with passing information to webtiles as flat text. However, to_colour_string is used internally in all sorts of places in ways that are subtly affected by this change. Rather than try to rework those, I'm semi-reverting 29c30a7bfa8 so that the default behavior is the same as what it was prior to that commit, and mostly only webtiles uses of it explicitly set a default color. -------------------------------------------------------------------------------- 4f9e239c0e | advil | 2022-08-09 20:47:27 -0400 fix: simplify some duplicated code -------------------------------------------------------------------------------- 84f7d21838 | advil | 2022-08-09 20:28:22 -0400 fix: various skill menu fixes Mostly for the experience menu (see #2597), which was extremely broken in autotraining mode. 1. In autotraining mode, use you.training for the !xp defaults (rather than every single skill) 2. Let any visible skill be selectable; previously, you could get a skill to show up under SKM_SHOW_DEFAULT and when toggled back to -, it would become unselectable (conspiring with 3 below) but still visible. This was doable in either manual mode or !xp mode. 3. Don't define SKM_HELP to coincide with the default value for `MenuItem::m_item_id`: this led by weird side effects to unselectable menu items (via 2) entering help mode. (Which to top it off, is not otherwise enabled in !xp mode and is somewhat buggy.) 4. Correctly implement selection cycling for numeric hotkeys -------------------------------------------------------------------------------- 6b6670bd90 | advil | 2022-08-09 12:20:35 -0400 fix: click handling in `InvMenu`s (Goratrix) Yet another case where there are misc keys hardcoded that shouldn't be (unfortunately this commit does not fix the overall problem). Also, fixed some downcasting to an unsigned char for no good reason. -------------------------------------------------------------------------------- 091d24779b | advil | 2022-08-09 11:47:21 -0400 fix: clean up UseItemMenu mode code Make this implementation slightly less brute force. Also, add keyhelp, and fix a local tiles visual bug in this menu. -------------------------------------------------------------------------------- 236c7fd91e | Nicholas Feinberg | 2022-08-08 21:26:42 -0700 Tweak weapon brand display (acrobat) Do show venom brand in the damage rating, don't show dispersal. -------------------------------------------------------------------------------- 1598f19b23 | advil | 2022-08-08 22:42:34 -0400 fix: restore some fire inscription behavior This code is all a bit messy, but this commit more or less brings things back to what the manual says should happen. (E.g. you can inscribe your silver javelins with =f to prevent autoquivering.) Resolves #2418 -------------------------------------------------------------------------------- a8c0faee3b | advil | 2022-08-08 17:41:17 -0400 fix: maybe fix AltGr in local tiles See #2623. I'm pretty sure the comment there that cf85d11 was responsible is right, and this fix targets that issue. But, I don't have a windows machine on hand to test. Also, alt handling got rewritten somewhat since then so I don't know if the new code breaks it further. What I can verify at least is that this all works correctly with mac alt keys. -------------------------------------------------------------------------------- 0638b6a9f9 | advil | 2022-08-08 16:56:37 -0400 fix: don't generate empty extra religion screens in webtiles More generally, don't insert a default in colour strings unless the first op is a text op. This bug is continued fallout from 29c30a7. I think this fix probably subsumes edc2efc2671c but not f9470816a (since blank colour strings will still get a default tag). -------------------------------------------------------------------------------- 5fcc5c1eac | advil | 2022-08-08 16:02:04 -0400 fix: implement local tiles menu clicking as clicking Previously, clicking menu items was implemented via a key event using the menu's hotkey. This implements a proper clicking interface. Because CK_MOUSE_CLICK is sent by ui code on arbitrary clicks regardless of location, I used the less common CK_MOUSE_B1 for clicks specifically on a (selectable) menu item. Along the way I also implemented right click to examine. Resolves #2639 -------------------------------------------------------------------------------- 8251ee3229 | advil | 2022-08-08 15:12:16 -0400 fix: numpad movement in local tiles Partial revert of dbb8aaeb5fe9d6. I don't think I can entirely prevent this from being returned in some circumstances, so I've just given up and dealt with it in the menu code. What was happening is that two quick events came in succession, the second suppressing the first, but the `break` here sent processing back into a loop that needed another key to break it. Resolves #2644 -------------------------------------------------------------------------------- 73cb963dcd | Nicholas Feinberg | 2022-08-08 10:17:51 -0700 Rework Gong description (Lici) Avoid implying spirit shield? -------------------------------------------------------------------------------- 60c99734e7 | Nicholas Feinberg | 2022-08-07 13:43:14 -0700 Fix messages for unseen dream sheep (CarefulOdds) You could be told about dream sheep sparkling even when you couldn't actually see them. This is incredibly niche! -------------------------------------------------------------------------------- 949cc1d0fb | Nicholas Feinberg | 2022-08-06 13:48:58 -0700 Swap out AM ?vuln for ?poison Scrolls of vulnerability were intended to provide an early game tool to help Arcane Markspersons hex effectively, but early game enemies have such low Will that vulnerability has little effect on them. Swap it out for the newish Scroll of Poison, which should help them fight foes at range. -------------------------------------------------------------------------------- fab9b68f5b | Nicholas Feinberg | 2022-08-06 13:36:37 -0700 A tisket, a tasket, new tiles from (Sastreii) Finisher, Jorgrun, and Octopode/Felid lichform. -------------------------------------------------------------------------------- 0dd7720b37 | Nicholas Feinberg | 2022-08-05 14:44:41 -0700 Fix a Zenata monspeak typo (ebird) -------------------------------------------------------------------------------- 6e1c3f9eef | Nicholas Feinberg | 2022-08-05 12:11:29 -0700 Update more things for deep abyss -------------------------------------------------------------------------------- 417cb75212 | Nicholas Feinberg | 2022-08-05 12:11:29 -0700 Fix deep abyss spawns Don't exclude them from XP tracking, oops. Also simplify and refactor logic generally. -------------------------------------------------------------------------------- 08a8388b2b | Nicholas Feinberg | 2022-08-05 12:11:29 -0700 Don't force alligators to always be patrolling Added in 7d59d745cd3 (2010). The plan seems to have been to make alligators 'semi-neutral' - they'd only attack if you came within four spaces of them. As best I can tell, the latter part of this plan was never implemented. -------------------------------------------------------------------------------- 3a827bf7a4 | Nicholas Feinberg | 2022-08-05 12:11:29 -0700 Deduplicate some abyss spawn logic -------------------------------------------------------------------------------- 36053be5b9 | Nicholas Feinberg | 2022-08-05 12:11:29 -0700 Decrease deep abyss exit spawn rate (Oneirical) A bit too easy to dip in and out of Abyss:6-7 as desired. -------------------------------------------------------------------------------- 458353e8b9 | Nicholas Feinberg | 2022-08-05 12:11:29 -0700 Display current attack delay in weapon description Oops, forgot to commit this after writing it up some days ago. -------------------------------------------------------------------------------- f35a41adde | Nicholas Feinberg | 2022-08-05 12:11:29 -0700 Shift Frozen Ramparts damage later (acrobat) Adding +6 damage to it when making it check AC made it quite a bit too strong at low level. Reduce the base damage to 1 and increase damage gained from spellpower by 50%. -------------------------------------------------------------------------------- 1987434951 | advil | 2022-08-04 16:29:42 -0400 fix: don't start resting if `can_rest_here` is false bdabc8c6d3d1 ran afoul of one of the weird pitfalls of this code, that rest/wait fail messaging is handled in a different place than rest/wait start messaging. Possibly this can/should be cleaned up, but I don't immediately know what else it would break, so I've just updated the relevant check in _start_running to be exactly parallel. Also commented the point in the code where this trap can be found. -------------------------------------------------------------------------------- f6f7e2dfe7 | riverfiend | 2022-08-03 22:44:34 -0400 fix: Changes to god wrath (#2606) Give Makh 2 more greater servants as suggested in code comments. Remove unnecessary slow duration checks in Chei, Trog wrath. Remove jellies from Jiyva wrath spawns. Fuzz minor minion numbers for Lugonu wrath summons. Modify Zin mutation removal logic to be more understandable. Make Zin wrath fall through to other effects if all player mutations are bad. Update wrath descriptions for Chei, Yred, and Ely. See original pull request for full explanation of the old wrath behaviors. -------------------------------------------------------------------------------- 82fb55b1ac | nlavsky | 2022-08-03 22:17:43 -0400 fix: no hostile Necrotise skeletons (#2630) For consistency with other ally-creating spells under Okawaru or Sacrifice Love, this commit blocks the Animate Skeleton part of the Necrotise spell. -------------------------------------------------------------------------------- 8a7feb118f | gammafunk | 2022-08-03 15:24:36 -0500 feat: Adjust Ice Cave simulacra Entropy weaver simulacra are great at killing players, but are far nastier in melee than their originating monster due to their relatively high HD and how af_cold works. Players tend to not expect this, given that entropy weaver melee at its normal placement depth is only dangerous when the player has poor AC (e.g. when highly corroded). We can use hydra simulacra with the appropriate numbers of heads to have a similar effect, but one that somewhat better telegraphs the level of danger. This commit uses 3-headed hydra simulacra in the top-end "cruel" set for easy ice caves, 7-headed hydra simulacra in that same set for hard ice caves, and removes entropy weaver simulacra from the simulacra lists. For ice_cave_hellmonk_azure_passage, now that jellies and eyes can be simulacra, we replace entropy weaver simulacra and other less-in theme simulacra with slime creature and great orb of eye simulacra. The non-jelly/eye we still use are shapeshifter and glowing shapeshifter simulacra. These changes are a nerf to ice caves, but ice caves could stand a mild nerf, especially for easy ice caves. -------------------------------------------------------------------------------- c5c9f59d18 | Kate | 2022-08-02 21:58:16 +0100 Fix compiler warnings And rebrace. -------------------------------------------------------------------------------- 4a18f31a58 | Nicholas Feinberg | 2022-08-01 18:38:10 -0700 Give palentongas +2 strength Make them a little better at using heavy armour, etc. -------------------------------------------------------------------------------- 3e1970ce6f | Nicholas Feinberg | 2022-08-01 18:38:06 -0700 Slash Palentonga roll attack noise When I designed Palentongas, I added 12 noise to them so that it wouldn't always be correct to use roll attacks. Now that we've had a while to play with them, I suspect this was the wrong call. Roll attacks are Palentonga's cool thing - players should want to use them very heavily, and we should design the UI to support that. Reduce noise to one-third, 4 noise. This is mostly there as a justification for preventing roll-sleep-stabs, but isn't really noisier than the melee combat itself. -------------------------------------------------------------------------------- e9813d02cc | Nicholas Feinberg | 2022-08-01 18:14:16 -0700 Simplify Airstrike (CarefulOdds) Make it a simple dice roll, rather than the sum of a flat value (based on empty space nearby) and a random2avg call. This increases average damage by 0.5 per cast, and increases max damage considerably in open space. Gastronok now does 2d34 if you're in totally empty space, which might be a bit much? -------------------------------------------------------------------------------- 68da1b8662 | Nicholas Feinberg | 2022-08-01 17:56:01 -0700 Don't count conjured 'mons' for Fridge (acrobat) Probably an orb of destruction can't insulate you from freezing... I guess? -------------------------------------------------------------------------------- 78424f4fe2 | Nicholas Feinberg | 2022-08-01 17:56:01 -0700 Don't spawn ponderous gloves (ebonnov, CarefulOdds) It's only supposed to be on body armour! Excepting one unrand, ha. The tradeoff is too awful otherwise. -------------------------------------------------------------------------------- f828392251 | Nicholas Feinberg | 2022-08-01 17:56:01 -0700 Don't show invisible monsters in the Refrig targeter Oops! Also don't leak info about monsters outside LOS but adjacent to monsters you do see. -------------------------------------------------------------------------------- 9d01ccc615 | Nicholas Feinberg | 2022-08-01 17:56:01 -0700 Don't spam messages in local tiles When there are invisible monsters nearby. Broken by bdabc8c6d3d15eae00cd2e427f43c04c37675bc5 . -------------------------------------------------------------------------------- df0a18e73c | advil | 2022-08-01 15:39:38 -0400 feat: mode cycling for use item menus This lets you cycle between wield/wear/puton, and read/quaff (depending on starting mode). It's a pretty rough and ready implementation, but recent menu changes made it possible to implement this way. The cycle keys are the usual ones (arrow keys, !), but it's currently not hinted -- e.g. the feature is secret for now. Ideally, a similar change would happen for the remove menus before this becomes fully baked, but that's a bit more work, since those are regular `InvMenu`s. -------------------------------------------------------------------------------- af557a844c | advil | 2022-08-01 15:37:00 -0400 feat: differentiate passable/impassable water in console Previously, both of these used the same glyph by default, ≈, and relied on color to differentiate. This has accessibility issues, and also is annoying in builder debugging / scripting contexts (where e.g. dump_map doesn't output color). This commit switches shallow water to use a regular tilde. Colors stay the same, but it's possible they could use further tweaking after this change. -------------------------------------------------------------------------------- 8b785cd64e | advil | 2022-08-01 12:59:05 -0400 fix: limit vaults builder tag effects to vaults This is a followup to c37658a0fea4; the effect here isn't really a false positive, in that it can impact seed stability on local games when the binary isn't restarted. The situation is that Vaults layouts, in order to place vaults used elsewhere, typically need to ensure they are non-opaque to the builder. The means by which it does this (tags like transparent and passable), then become part of the vault's state, and persist to any later reuse. 2170ac5abdc97a already limited the effect of `passable` to uses when placing a vault in Vaults, but the v_rooms.lua code (for reasons that are not entirely clear to me) used the `transparent` tag to a similar effect. Changing this to `passable` has the same effect and prevents the seed stability issues (at least, in my testing). It would be nice if there were a better way of resetting vault tags to the des cache state without restarting the binary? This commit also fixes what seems to have been a logic error in the interaction between passable and opaque, from 2170ac5abdc97a, where the passable tag would not result in MMT_PASSABLE outside vaults, but would also prevent MMT_OPAQUE where appropriate. (This was probably creating a whole bunch of unnecessary vetoes for affected vaults..) -------------------------------------------------------------------------------- 79d4c32e18 | Nicholas Feinberg | 2022-08-01 07:43:13 -0700 Simplify weapon attack descriptions (#2326) When a monster is wielding a weapon, merge that weapon's damage and plusses into the damage shown into xv. Still can't quite show brands, but better something than nothing. Before: "can hit for up to 16 with its +5 giant club of flaming..." After: "can hit for up to 45 + Flame with its weapon..." -------------------------------------------------------------------------------- aed3a0c8d8 | Nicholas Feinberg | 2022-07-31 21:55:21 -0700 Experimental: redesign Ozocubu's Refrigeration In DCSS, spells are most exciting when they're context sensitive. You cast Fireball or Freezing Cloud when the terrain and enemy positions suit it. It's fine to have strong spells, but it's not very fun to have one spell which is so universally good that you can repeatedly cast it to clear the great majority of fights. Ozo's Fridge fell in this category. Let's experiment with making it a bit more situation-dependent. This commit increases its damage by ~10% and removes the -Potion gimmick, but reduces damage against creatures that are adjacent to others (including the player). The current formula reduces damage by 25% if there's one creature adjacent and by 50% if there are two or more, but this should be considered very much a first draft. Concerns I've seen about this design: 1. It'll cause players to lure enemies so you can fight one-on-one. This is generally wise, but I don't think a screen-wide AOE particularly pushes players to do this, even if it's worse against clumps of enemies. 2. It'll be hard for players to tell what's happening. I've done some work on the targeter to try to show how much enemies are affected, and probably some work could be done on printed messages if necessary. -------------------------------------------------------------------------------- 9e354a60c6 | Nicholas Feinberg | 2022-07-31 21:55:21 -0700 Make Refrigeration and Ramparts check AC and do more damage One of the trickier things to teach new players is that AC works against elemental attacks. Fireball, bolt of cold, etc - AC will help! It's a simple, consistent mechanic that has big implications across play. This becomes much trickier, and more confusing, when an arbitrary subset of spells do *not* check AC. What, ultimately, is the difference between a flash freeze, a freezing cloud, and a Refrigeration? Why should the latter ignore AC while the former two don't? Can't all that thick armour insulate you from the cold? If a spell doesn't have a lot else going on in terms of mechanical distinctiveness, we can have it ignore AC as its one big Thing. That's how Freeze works, and that's fine. But adding it into spells that have many other mechanical distinctions is both unnecessary and confusing. Let's not. Freezing Ramparts and Ozocubu's Refrigeration both now check AC and do more damage (+6 for Framparts, +10 for Refrigeration), based on a vague average of AC in relevant parts of the game. -------------------------------------------------------------------------------- 733a6eaeeb | Nicholas Feinberg | 2022-07-31 21:55:21 -0700 Simplify LOS attack effect logic Simplify and unify code for damaging players and monsters with Drain Life, Ozocubu's Refrigeration, and the Singing Sword. Remove the fairly redundant message announcing everything you hit. -------------------------------------------------------------------------------- 5bf4a2a1db | Nicholas Feinberg | 2022-07-31 21:55:21 -0700 Simplify Drain Life logic Now that players can no longer cast it, no need to special-case summons. -------------------------------------------------------------------------------- 572474d683 | advil | 2022-07-31 18:56:10 -0400 fix: maybe fix a gcc warning -------------------------------------------------------------------------------- 7483850d73 | advil | 2022-07-31 17:52:02 -0400 feat: generalize `F` to fire any targeted item This gives a quicker way of accessing e.g. the targeter for scroll of fear than quivering it. Behavior on launchers and ammo remains the same as before, and you can still use `*` to toss any item. There's a lot of special cases to deal with here in terms of preconditions, so it may be that there are more cases where this menu should be prevented altogether. Also, fix a bug where untargeted firing of disabled items would show the targeter prompt; now it just messages right away. (This is pretty niche, previously you would have to do something like quiver a potion of magic to see this.) -------------------------------------------------------------------------------- 2d25de79ac | advil | 2022-07-31 13:38:16 -0400 feat: readable keycodes for some non-ascii keys This is a fairly inelegant approach that gets the job done for now; it lets "F1" (etc) for function keys, "NPx" for numpad key x, as well as "Down", "PgDn", etc for navigation keys, work as keycodes. These can appear in contexts where a \{} keycode is valid, as well as directly in the [] brackets in a `bindkey` rc line. -------------------------------------------------------------------------------- c1b7fc97e0 | advil | 2022-07-31 11:13:23 -0400 fix: a few more CK_NUMPAD_ENTER bindings Map mode, more, doll editor, text input. -------------------------------------------------------------------------------- afa891f487 | gammafunk | 2022-07-31 09:24:58 -0500 fix: Correct grammar (Solitudinal) For the description of the lunar statue from Lehudib's WizLab and the Zot statue from the Ten Rune Challenge Sprint. Closes #2637. -------------------------------------------------------------------------------- ac7da5f7f0 | advil | 2022-07-30 18:32:34 -0400 fix: update hover on local tiles click If you hover with a mouse, then use arrows to move the hover away, then click without moving the mouse at all, the currently hovered item (not under the mouse) gets activated. This commit updates the hover on mousedown, so that when the click is processed (on mouse up), the item under the mouse is what does get clicked. -------------------------------------------------------------------------------- 43c84944fd | Nicholas Feinberg | 2022-07-30 12:59:58 -0700 Marble at these new tiles (Sastreii) New Tukima's Wizlab marble wall tiles. -------------------------------------------------------------------------------- dbb8aaeb5f | advil | 2022-07-30 15:37:00 -0400 fix: suppress more instances of CK_NO_KEY in local tiles 0d6ea506dcc got one way of producing this keycode, but not the only one. It would be better to fully suppress this in `wait_event`, but I think that would require more of a refactor. -------------------------------------------------------------------------------- 619506e67d | Nicholas Feinberg | 2022-07-30 11:12:11 -0700 Add icons for Brilliance and Resistance (Sastreii) -------------------------------------------------------------------------------- 8769cd89f2 | Nicholas Feinberg | 2022-07-30 11:12:11 -0700 Scale up some art [pun?] (Sastreii) New tiles for Faerie Dragon Scales and basilisks. -------------------------------------------------------------------------------- a52d00042f | advil | 2022-07-30 13:27:47 -0400 fix: accept more keybinds (again) in webtiles 8027019649d8 was too restrictive in its raw key arrow key check; we want to also accept raw arrow keys in new macro definitions. This approach is somewhat hacky (possibly the server should explicitly indicate this mode similar to raw key input mode) but it works. -------------------------------------------------------------------------------- f9470816a2 | advil | 2022-07-30 13:03:10 -0400 fix: correct formatted_string::trim implementation The first pass at this function only trimmed whitespace outside of color tags, which was previously reasonable for the main use cases. However, 29c30a7bfa8 broke that assumption, leading to dead space in some popups. This commit is a full formatted_string::trim implementation that trims whitespace regardless of color tags. -------------------------------------------------------------------------------- edc2efc267 | advil | 2022-07-30 13:03:10 -0400 fix: remove empty spans in newgame buttons Because these are using a css flex layout with equal sizes, empty spans generated from a color string have a weird effect on these buttons. Since 29c30a7bfa80, the strings used for these buttons are guaranteed to have an empty span. Possibly the approach in that commit should be revisited, and I'm unclear on why the button spans are formatted this way, but for now, fix the local problem in the newgame buttons by removing empty spans. -------------------------------------------------------------------------------- 4c7e25f38b | gammafunk | 2022-07-30 11:43:31 -0500 doc: Update a comment Despite what some people claim, hammers and maces are not equivalent! -------------------------------------------------------------------------------- b5fe8ed81c | advil | 2022-07-30 10:42:59 -0400 fix: skill menu alignment issue (Goratrix) -------------------------------------------------------------------------------- 10f4acb857 | advil | 2022-07-30 10:15:17 -0400 fix: fix describe menu issues (xv, ctrl-x) I had completely missed that this exists and uses InvMenu for some reason, and so it needs custom examine code. There was also an issue where (because of inheriting from InvMenu) it needs to override some overridden key bindings. Resolves #2638 -------------------------------------------------------------------------------- c8bbfd0a37 | advil | 2022-07-29 18:02:18 -0400 fix: restore targeting CK_NUMPAD_ENTER binding (Nefhilion) Possibly this should be handled via numpad_to_regular? But right now this is all manual, and probably got deleted by accident. -------------------------------------------------------------------------------- fab03dca74 | advil | 2022-07-29 17:51:09 -0400 fix: use correct index when describing memorized spells -------------------------------------------------------------------------------- 5fb1e05c50 | Nicholas Feinberg | 2022-07-29 14:20:38 -0700 Occasionally generate hand crossbows Oops! Objstat says this increases hand crossbow drops in a 3-rune game by 30-40% or so, but the baseline is quite low. -------------------------------------------------------------------------------- d064c1aaf2 | Nicholas Feinberg | 2022-07-29 11:17:27 -0700 Confirm that #2634 is fixed Closes #2634. -------------------------------------------------------------------------------- 6693796725 | Nicholas Feinberg | 2022-07-29 11:11:52 -0700 Maybe fix a local tiles newgame crash -------------------------------------------------------------------------------- 1ab02bc704 | advil | 2022-07-29 13:50:17 -0400 fix: add some missing `static`s -------------------------------------------------------------------------------- 33dda2a4a5 | advil | 2022-07-29 13:37:46 -0400 feat: scroll by item type hotkeys in InvMenu Long-requested feature, now finally easy to implement. This commit also fixes a number of hover syncing bugs with webtiles that came up while testing it. -------------------------------------------------------------------------------- 29c30a7bfa | advil | 2022-07-29 13:37:46 -0400 fix: explicit default foreground for to_colour_string When the crawl binary renders colour strings, it uses lightgray as the default foreground color. However, this is not explicitly part of the string, so the webtiles color parsing code was not inserting a lightgray span, leading to artifacts. This commit ensures that this default is present in all autogenerated colour strings; it may or may not have some side effects I haven't noticed. (N.b. trying to change this on the webtiles side breaks a *lot* of formatting, unfortunately.) -------------------------------------------------------------------------------- e6dd553d16 | advil | 2022-07-29 13:37:46 -0400 fix: improve cast/view spell menu minorly These still shouldn't be distinct, but for now, this generalizes the toggle keys to commands, and adds a hint to the more indicating which type of menu you are in. -------------------------------------------------------------------------------- 70d6ccd9e9 | advil | 2022-07-29 13:37:46 -0400 fix: generalize some ToggleableMenu code to menu commands This moves `?` to help generally, adds a way to set toggle keys from commands, and then uses CMD_MENU_HELP for the toggle for relevant menus on the basis that this is essentially the help mode for these menus (thanks Kate). -------------------------------------------------------------------------------- 8027019649 | advil | 2022-07-29 13:37:46 -0400 fix: explicit handling for macro raw input mode This seems to have only been working accidentally, by passing everything to the server. But this relied on the server sending back hover info, which seems to be broken by recent changes [I am not sure this was intentional]. Anyways, it's better to just manually implement this so that the client knows it is in manual input mode and can act accordingly, rather than having everything work by side effect. -------------------------------------------------------------------------------- e1bd305f2e | advil | 2022-07-29 13:37:46 -0400 fix: backtrack on a new binding I want to reserve tab/shift-tab for a hypothetical future where keyhelps are widgets, not text. -------------------------------------------------------------------------------- 39874f90f9 | advil | 2022-07-29 13:37:46 -0400 fix: disable examine in KnownMenu Also, make esc abort reset mode rather than close the menu, and provide a hint that ctrl-d + * will reset everything. -------------------------------------------------------------------------------- e010e3413a | advil | 2022-07-29 13:37:46 -0400 fix: don't crash when examining floor items in UseItemMenu Needed to be implemented. Also, prevent a crash when examining unarmed. -------------------------------------------------------------------------------- 9f78f2f222 | advil | 2022-07-29 13:37:46 -0400 fix: yet more memorize menu tweaks * reset hover when switching to/from the hidden spell pane * enable CMD_MENU_EXAMINE bindings (which allows using the examine key on the hidden spell pane) * Remove MF_ANYPRINTABLE, I find that this leads to too many accidental menu exits when using the hide/show features -------------------------------------------------------------------------------- 2c367d4636 | advil | 2022-07-29 13:37:46 -0400 fix: remove legacy ' binding in webtiles This is repurposed to be CMD_MENU_EXAMINE, so pass it to the server. -------------------------------------------------------------------------------- 5930f321ed | advil | 2022-07-29 13:37:46 -0400 fix: don't read keybinds on first rc pass This lets the webtiles menu command check work correctly (we apparentlly cannot rely on `tiles.is_controlled_from_web()` during the first rc pass). Possibly this change should be webtiles-only? But I don't think it will have negative impacts.. -------------------------------------------------------------------------------- fc0b34fa67 | advil | 2022-07-29 13:37:46 -0400 fix: derive keyhelps from command binding This is all fairly painful, brittle code, but this commit at least reduces some hardcoded key assumptions... -------------------------------------------------------------------------------- d8e63177a4 | advil | 2022-07-29 13:37:46 -0400 fix: memorize menu hover issues * don't snap to hover on the server side when receiving scroll information from the client side; this leads to the two being out of sync, and lettering potentially being calculated incorrectly. * don't hover letter-selected singleselect items - most singleselect menus exit (so this doesn't matter), and the memorize menu relied on the previous behavior. (Hopefully no impact outside this menu..) -------------------------------------------------------------------------------- 8c06e03c53 | advil | 2022-07-29 13:37:46 -0400 fix: webtiles mouse hover when menu size decreases Two webtiles bugs: * the visible item range wasn't correctly recalculated when a menu size changed without scrolling * the hover event handlers were getting wiped out when a menu size decreases; particularly noticeable in the spell menu. I'm still not 100% sure why this was happening, but it seems most likely to be a side effect of the `clear()` call on the container? -------------------------------------------------------------------------------- dca162d7b1 | advil | 2022-07-29 13:37:46 -0400 fix: correctly sanitize mouse hover in memorize menu With menu_arrow_control=false, hover can still be set by the mouse, but `set_hover` does not apply the sanitizing `min` check (because it doesn't change it at all). This commit adds a corresponding check for this case in `update_menu`, which should be called whenever `items.size()` may have changed. -------------------------------------------------------------------------------- 83eecf6fab | advil | 2022-07-29 13:37:46 -0400 fix: various issues with the `F` menu Previous commits broke some of the keybinds for this menu, which needed attention anyways. The "throw any item" menu was different from the * menu only if you had a wielded launcher at this point, so it was a little silly to have both. Also, fix a bunch of the messaging, generalize some of the validity checks. -------------------------------------------------------------------------------- b7493b8c6f | advil | 2022-07-29 13:37:46 -0400 feat: add CMD_MENU_EXAMINE and support code The Menu superclass had some support for the concept of describing a menu item, via ACT_EXAMINE and all the cycling stuff, and nearly every Menu subclass uses it somehow, but for whatever reason handling was left to manual subclass code. This commit generalizes the standard pattern into the superclass, hopefully making it more straightforward to write code that does whatever description popup is needed. Along the way, this change makes it possible to add a distinct "examine selected menu item" command, which I have bound to `\\` and `'`. The latter replaces a rather ancient compatibility binding, we'll see if this bothers people. Some misc refactoring that happened as part of this: * clean up acquirement menu a bit * enable hover in mutation menu, various deck menus * improve some shop menu behaviors, stash search menu behaviors * fix a weird casting preselect bug -------------------------------------------------------------------------------- 9571f3400c | advil | 2022-07-29 13:37:46 -0400 docs: comment Menu class hierarchy I'm tired of trying to keep all this in my head and inevitably forgetting StackFiveMenu or whatever. No doubt this comment will go stale at some point, and there are ways of programmatically generating this, but I think it's still better to have as just a text comment in an easy place than not. Also, remove a reference to a nonexistent class. -------------------------------------------------------------------------------- 3c416a43b8 | advil | 2022-07-29 13:37:46 -0400 refactor: improvements to UseItemMenu This is mostly pulling code into UseItemMenu, though I did not succeed yet in eliminating the outer loop. * Restructure API around operation_types, instead of object selectors, and use this to set title prompts inside the menu * Move non-terminating key handling into process_key * other misc tweaks -------------------------------------------------------------------------------- 5e10d65620 | advil | 2022-07-29 13:37:46 -0400 fix: name some magical menu constants Also, rewrite the key function that uses these, as it was pretty confused (I think, not in ways that mattered). -------------------------------------------------------------------------------- d406f26c7b | advil | 2022-07-29 13:37:46 -0400 refactor: abstract more menu actions to commands Abstract various selection commands to CMD_MENU_... actions, and refactor Menu::process_key accordingly. Hopefully won't break subclasses in ways that my testing has so far missed, as this is a relatively major change in how input is handled across all menus. This commit should by itself not result in much behavior change (a few minor bugfixes and one exception below). Notes: * This adds a new keymap context specifically for multiselect menus, as a way of having keybinds that target just that case. It's maybe a bit heavy handed, but works surprisingly well. * Behavior change: enter in a multiselect menu with no selection does not exit. I will probably adjust this some more. * Remove multiselect count in menu title, as it was redundant with footer. * Remove MF_PRESELECT, as it wasn't needed for anything (despite a few bits of code that say what they're doing is "preselecting"). -------------------------------------------------------------------------------- 9e8725f314 | advil | 2022-07-29 13:37:46 -0400 refactor: updates to webtiles keyhandling This is my latest take on how to do webtiles keyhandling in a way that points towards a more modern approach, while supporting old game versions. Followup to 7b1be97da7. * For versions following this commit, convert numpad and function key handling to use modern `code` values rather than keycodes. This has widespread browser support in 2022 and should be more robust than the previous keycode-based approach. * Remove keycode overrides from game.js, with a new division of labor and clearer handling for legacy keycodes. Now all the client needs to do to use updated keyhandling is enable `code` mappings. * Support for some new internal keycodes: ctrl+shift bindings; modified space, del, enter, bksp, esc; numpad =/enter, F keys through F19, fix delete handling (this is the only one that works on older versions). Still to be done: fix alt handling, convert modifier handling to use `code`. This commit attempts to support all versions and all possible cache states for non-versioned code (which on some servers may require a server restart to refresh). We'll see if that actually works. -------------------------------------------------------------------------------- e3431fa5fd | advil | 2022-07-29 13:37:46 -0400 feat: a few more mac-oriented console keys Plus, some comments. -------------------------------------------------------------------------------- df642b0ec9 | advil | 2022-07-29 13:37:46 -0400 fix: tweaks for ncurses keycode handling * Add and update various comments * Fix (I hope) the keycode for numpad / in application mode, this seems to have simply been wrong (but only tested on mac...) * Add a mapping for keypad = * add rxvt-style handling of function keys for mac Terminal.app defaults, working around what seems to be buggy terminal behavior * add human-readable names for F keys through F24 for ncurses. I didn't add keycodes because this is annoying to do for stupid reasons. Probably not widely supported, but they work on iTerm2! * some misc menu fixes that got rolled in -------------------------------------------------------------------------------- 0d6ea506dc | advil | 2022-07-29 13:37:46 -0400 refactor: Revamp SDL keycode handling Main changes: * Finally, convert to internal keycodes for SDL keycodes where we have internal keycodes. This lets a bunch of keycodes be unconditionally defined, and means that all build targets will use the same keycodes for these keys/key combos (though they vary in what is available). It does mean that SDL keycodes will change, breaking existing macro files, but also that the same macro defs will (largely) work across all build targets. Also, some combos will no longer work (see below). * Expand the set of internal keycodes: Support ctrl+shift for arrow (etc) keys; explicitly support modifiers for enter, bksp, esc, del; a few missing numpad cases. * Revamp how alt is handled. Well, it uses the original principle (just shifting the key space by -3000), but is now applied more systematically to all non-ascii keys. For ascii keys, alt is still not intercepted because these days this is used to input unicode chars on many OSs. I've fixed some mac issues with this. * Implement option modifier support for macs. This uses the same hacky keycode shifting as alt, just with a bigger number (-20000). * Refactor the SDL keycode translation code so that it makes more sense. * Fix some macro menu bugs, show naming for basically all keys correctly now. (Some UTF issues still maybe?) * Fix some lingering issues with numpad key suppression (before, it was returning a textinput CK_NO_KEY event as well as the key event.) What is missing or iffy: * The previous code had incomprehensible, hacky, modifier handling code that (sort of) worked on absolutely every key. I've moved away from this, where the practical impact is the ctrl works on a lot less stuff. In particular, ctrl + fn keys is not implemented. If people were using this, I can probably bring it back. Also, ctrl with whatever random SDL keycodes you have will not work, because this was a really bad idea. Shift is also fairly variable, though I'm not sure it's more-so. * Numpad with ctrl and shift is a bit weird. Previously, on SDL numpad keys were just mapped to arrow keys. Since we have numpad numbers, I mapped to those and added bindings. But, to get movement commands to work, ctrl/shift on the numpad turn the key into its corresponding arrow key. Also, in menu code numpad keys act like arrow keys. It's all a bit messy. * Haven't checked if some of the new keycodes can be added to webtiles Resolves #1228 -------------------------------------------------------------------------------- 4075c45985 | advil | 2022-07-29 13:37:46 -0400 fix: handle uppercase prompt menu defaults (Fix the macro menu "really clear" prompt, maybe others) -------------------------------------------------------------------------------- 2a601844f1 | advil | 2022-07-29 13:37:46 -0400 refactor: generalize some numpad handling For popups, menus, etc we want numpad special keys to be handled uniformly with their regular counterpoints basically all the time. Before there was a lot of ugly special casing for this that often has had mistakes, missing mappings, etc. This commit generalizes the mappings so that they are translated behind the scenes on all menus except the macro menus, as well as scrollers. Keymaps do still allow changing the numpad keys specifically. Some waffling on what to do with numbers. Previously, most menus did no translation at all for them (rendering them inert), and for these menus, they get translated to numbers now. (Most keyboards with a numlock should be able to turn this off and get navigation keys still.) The skill menu had some (incorrectly implemented?) hardcoding to let 2/4/6/8 act as direction keys, and I've left this (/fixed this to be) active. Possibly this should be done uniformly? Not sure what players will expect. (Also, some misc unrelated comments) -------------------------------------------------------------------------------- 2d6fbdf044 | advil | 2022-07-29 13:37:46 -0400 refactor: make menu quantity selection non-default This was a default possibility, I assume, from back in the days where Menus were used almost entirely for items, and managing stacks mattered for more things (e.g. weight). Nowadays I'm aware of only two menus that even need this (drop and pickup), and even here this is not an option that users have much of a reason to use. Swap the meaning of the flag and the corresponding defaults so that menus have to enable this rather than disable it; in principle this also simplifies using digits for other things in some Menus. -------------------------------------------------------------------------------- 2ec3508d20 | advil | 2022-07-29 13:37:46 -0400 fix: improve overriding options for Menu subclasses Avoid hacky pre_process with a cleaner set of things to override (mainly used for help right now), implement handling for `-`. Numpad handling is very ad hoc here still, maybe menus should always collapse numpad equivalents to their regular keys in a systematic way? -------------------------------------------------------------------------------- 0719e5db6c | advil | 2022-07-29 13:37:46 -0400 fix: tweak what bindkeys are allowed * blanket disallow rebinding esc and mouse commands in popups/menus * mark CK_MOUSE_MOVE as synthetic * ignore menu key rebinds in webtiles specifically. Most of these "work" but (rightly?) don't send UI state back to the webtiles client, so they result in inconsistent client/server UI state, and are basically just a recipe for bug reports as-is. I'm not sure how to do this without implementing the abstract commands on the client side and transmitting keybinds, which seems extremely involved. -------------------------------------------------------------------------------- 2f41a18165 | advil | 2022-07-29 13:37:46 -0400 feat: CMD_MENU_... for menu navigation bindings This is part of my attempt to somehow get some order out of the keybindings used across different menus, by putting a layer of abstraction between individual keys and menu actions. This is only a partial implementation that focuses on navigation: by design there's quite a bit of falling back on the old process_key, partly because I'm undecided about how to handle some of the general cases, and also because there are many, many, menu-specific bindings that don't seem like they should obviously be implemented in a general way. Some key missing things: * Most aspects of this in webtiles -- I'm completely undecided about how or even if to handle this. Many of the keybinds covered in this commit have full javascript parallel implementations for snappier UI. * Many more menu special cases * select/activate actions * user rebinding. Right now this is completely disabled, because I think there's certain things we would not want to allow at all (e.g. bindings for mouse buttons, CMD_MENU_EXIT, stuff like this). Of course, this is advanced rc stuff, so it call fall under caveat emptor? -------------------------------------------------------------------------------- 0a7a3d12f8 | Nicholas Feinberg | 2022-07-27 21:55:23 -0700 Maybe fix a revival untransform crash (Oneirical) Very scary to do almost anything while dead. -------------------------------------------------------------------------------- fe0b616f53 | Nicholas Feinberg | 2022-07-27 17:27:53 -0700 Fix Meteoran manual positioning (FizzleBang) -------------------------------------------------------------------------------- 6e406bff71 | Nicholas Feinberg | 2022-07-26 18:05:04 -0700 Give a +1 to the AM starting sling It's still slightly weaker than the Hu starting shortbow, but perhaps a little less sad. -------------------------------------------------------------------------------- 9a622b1e81 | Nicholas Feinberg | 2022-07-26 17:45:31 -0700 More Abyssal tiles (Sastreii) A tweak to Louise and a rework of the Mad Acolyte of Lugonu. -------------------------------------------------------------------------------- 44044ebd20 | Nicholas Feinberg | 2022-07-26 17:45:31 -0700 Maybe fix a Golubria + floor ID bug (But I couldn't repro the problem.) -------------------------------------------------------------------------------- 5d2155ec51 | gammafunk | 2022-07-26 10:27:05 -0500 fix: Remove an unecessary subvault (Goratrix) The vault grunt_ashenzari_visionary_trees is one of two fallback vaults placed when information about Lair branches isn't available. However we don't need two distinct vaults for this case, as fallback never happens in an actual game. Remove the trees vault, leaving grunt_ashenzari_visionary_lava as the fallback, and add allow_dup to the latter so it can be used twice. -------------------------------------------------------------------------------- d064cfad1c | Nicholas Feinberg | 2022-07-25 23:06:30 -0700 Fix: don't double sandblast delay on miscasts This was not intended, and is (IMO) a bug. -------------------------------------------------------------------------------- 52dc46e822 | Nicholas Feinberg | 2022-07-25 23:03:52 -0700 Buff sandblast accuracy To make missing with an extra-slow spell less painful. This has a pretty small effect in the cases I tested, but maybe it helps. -------------------------------------------------------------------------------- f6505d1e93 | Nicholas Feinberg | 2022-07-25 23:01:35 -0700 Increase sticky flame damage by 25% vs monsters Sticky Flame has taken some hits in recent versions, not least due to attacks of opportunities weakening kiting. Now that it's not in the Fire Elementalist start, it can afford to be a bit stronger. This doesn't affect the displayed damage, which only shows the initial impact. TODO: clean up and unify this. This does not affect sticky flame damage on players. -------------------------------------------------------------------------------- 416d80c6de | Nicholas Feinberg | 2022-07-25 23:01:35 -0700 Increase Flame Wave damage Continuing the saga of dde70e7af44 and daab1c2f9be. Average damage per round (pre-AC): 0 power 100 power Original 5 25 Post-nerf 4 14 Post-buff 4 17 Current 4 21 We're gonna find the perfect number. It's in there somewhere. -------------------------------------------------------------------------------- 98872c3ec8 | Nicholas Feinberg | 2022-07-25 23:01:35 -0700 Increase Irradiate contamination Irradiate is widely considered an extremely strong spell, 'trivializing' many encounters and much stronger than other spells of its level. The 'contamination' limit, intended to balance it by limited access to other contamination-causing effects, has become less relevant as those other sources (Haste, Invisibility spell, Controlled Blink...) have left the game. It's not a bad thing for Crawl to have strong spells, but we want players to be making exciting strategic choices, and to be excited to upgrade from lower level spells to higher ones. We've recently reduced the spell's max damage, but this hasn't really made any signifcant impact on its power. So, let's dial it back a little, from 3-4 'safe' uses before hitting yellow contamination to 2-3. I expect it will still be quite powerful, but perhaps somewhat more situational. This commit also changes the threshold at which contamination goes from dark grey (trace) to light grey (you're near yellow contamination), such that being in light grey still warns you that one more Irradiate could put you into yellow. This affects pretty few other effects now - evokable invisibility was the only other one that had the same logic, and you really don't want to use that in grey contam regardless. Currently: 1000-1500 contam (light grey is 3.5k, yellow is 5k) Best case: 4 safe casts at 1k contam each (5th puts you at yellow contam guaranteed, ignoring contam reduction over time). Worst case: 3 safe casts at 1.5k contam each (5th is guaranteed yellow). New: 1250-2000 contam (light grey is 3k, yellow is 5k) Best case: 3 safe casts at 1.25k contam each (4th is yellow guaranteed, ignoring contam reduction over time) Worst case: 2 safe casts at 2k ea (3rd is yellow guaranteed). -------------------------------------------------------------------------------- 906f1d757c | Kate | 2022-07-25 21:30:03 +0100 Make unidentified ?butterflies fizzle under Okawaru As with scrolls of summoning - instead of summoning hostiles have the scroll just fizzle if read-identified under Okawaru or with Sacrifice Love. -------------------------------------------------------------------------------- 4287b5424a | Kate | 2022-07-25 21:29:59 +0100 Update some halo descriptions To make it clearer that the accuracy bonus doesn't apply against the owner of the halo. Also correct an inaccurate comment. -------------------------------------------------------------------------------- a87ceb1aab | gammafunk | 2022-07-25 15:06:40 -0500 fix: Remove unreachable items from a vault (dilly) The vault grunt_ashenzari_visionary didn't have tagging to prevent level items from generating inside its unreachable areas. Its `no_tele_into` tagging was also a bit suspicious in that it only masked certain squares. Add no_item_gen and no_tele_into to the subvault tags to prevent any problems. Also rework the terrain and monster placement inside these vaults. Although weights were chosen to make monster closets unlikely, they didn't fully prevent them, and the simple SUBST used meant that solid features had to be very sparse. Make a grid of wall location glyphs for the non-Shoals subvaults, placing walls only on these locations and thinning out the walls as appropriate to give the sight sense open areas versus walled areas. This also allows us to use trees in the Swamp subvault. Adjust monster placement use place: tags so we don't have hard-coded lists of decorative monsters that easily go stale. -------------------------------------------------------------------------------- 88e6f02907 | Neil Moore | 2022-07-24 23:39:04 -0400 Add a missing word [skip ci] -------------------------------------------------------------------------------- 35202b1573 | Nicholas Feinberg | 2022-07-24 20:07:42 -0700 Maybe fix ?id uselessness (Lightli) Broken by the addition of scrolls of butterflies. -------------------------------------------------------------------------------- 30c7767f5c | Nicholas Feinberg | 2022-07-24 11:22:09 -0700 Add Naga recolour tiles (Lyre) -------------------------------------------------------------------------------- 030b2a9e5e | Nicholas Feinberg | 2022-07-24 11:22:09 -0700 Add Djinni recolour tiles (Lyre) -------------------------------------------------------------------------------- 370ae71bdb | Nicholas Feinberg | 2022-07-24 11:22:09 -0700 Revivify Borgnjor's Mausoleum (Sastreii) New floor & wall tiles for the famous wizlab. -------------------------------------------------------------------------------- 68d77ee5f7 | Nicholas Feinberg | 2022-07-24 11:22:09 -0700 Dance with the stars (Sastreii) Add animated starflower tile variants. -------------------------------------------------------------------------------- 552816ba1b | Nicholas Feinberg | 2022-07-24 11:22:09 -0700 Don't autoexplore into krakens (ardl, CarefulOdds) Krakens weren't considered dangerous until they woke up and started spawning tentacles, since they couldn't path to the player. Fixes #2556. -------------------------------------------------------------------------------- 46b74f5a98 | Nicholas Feinberg | 2022-07-24 11:22:09 -0700 Remove KRAKEN_TENTACLE_RANGE Unused since 26b18322453b0e8f90b8bb6dee5690025d588116 (2010). -------------------------------------------------------------------------------- 86a584de0a | Nicholas Feinberg | 2022-07-24 11:22:09 -0700 Add a new ancient tile (Sastreii) Ancient zyme. -------------------------------------------------------------------------------- 0f71de6fce | Kate | 2022-07-23 13:19:55 +0100 Don't let troves ask for ?butterflies under Okawaru Since they're useless otherwise, so don't make for a meaningful toll. Worshippers of Ashenzari that have sacrificed love can still be asked for scrolls of butterflies, but that's possibly enough of an edge case to allow them to get away with. -------------------------------------------------------------------------------- 46a8461d6a | riverfiend | 2022-07-22 20:01:36 -0700 Make classed draconians match their base color Now that each classed drac maps neatly onto a base drac color, it's silly for the white draconian stormcaller to be brown, or for the black draconian knight to be cyan. The line-up isn't perfect, classed dracs are kept on light colors to help them stick out in vaults that explicitly use different base colors. -------------------------------------------------------------------------------- 1931ea0d09 | Nikolai Lavsky | 2022-07-22 19:48:58 -0700 fix: tweak shield offsets for several elves and spriggans This commit fixes shield offsets for the following monster tiles: * deep elf pyromancer, zephyrmancer, and demonologist; * spriggan berserker and air mage. -------------------------------------------------------------------------------- cd2578efcb | Nikolai Lavsky | 2022-07-22 19:48:28 -0700 fix: tweak spacing on the dungeon overview screen As a followup to ed30ed24e, this commit fixes column alignment in the two-columns mode. -------------------------------------------------------------------------------- 6e3fbd0ac6 | Nicholas Feinberg | 2022-07-22 18:49:08 -0700 Fix op/dr hat use (ebird) Closes #2625. -------------------------------------------------------------------------------- d4eca3973b | Nicholas Feinberg | 2022-07-22 18:33:46 -0700 Don't let Ashenzari block innate mutations (Nomi) Oops! -------------------------------------------------------------------------------- 9542dc02ca | Nicholas Feinberg | 2022-07-22 16:46:43 -0700 Make Ashenzari block curse-shattering mutations Just a really excessively brutal feel-bad otherwise. -------------------------------------------------------------------------------- 65808cdf32 | Nicholas Feinberg | 2022-07-22 15:56:22 -0700 Add new mutation tiles (Sastreii) SInv, horns, antennae, and passive mapping (the thing DD got and Meteorans still get). -------------------------------------------------------------------------------- 1b0b605977 | Nicholas Feinberg | 2022-07-22 15:56:22 -0700 Add Teleporting status & icon (Sastreii) -------------------------------------------------------------------------------- 0687760f0c | Nicholas Feinberg | 2022-07-22 15:56:22 -0700 Add some uniquely abyssal tiles (Sastreii) New Mlioglotl and Louise tiles. -------------------------------------------------------------------------------- 2c4c91d9db | Kate | 2022-07-21 19:41:55 +0100 Give scrolls of butterflies their own summon type Since the spell has been removed, treat them the same way as scrolls of summoning (and re-remove the spell enum at TAG_MAJOR_VERSION 35). This reverts commit 1595a9cb2e31c54c4631752689330e52b5ae3b26. -------------------------------------------------------------------------------- 85def6a6a5 | Kate | 2022-07-21 19:41:55 +0100 Fix summon scrolls being readable under no-allies conducts Scrolls of summoning and butterflies are marked as useless under Sacrifice Love and while worshipping Okawaru, but previously could still be read (with no effect other than wasting a turn for ?summoning, and with ?butterflies creating friendly monsters that then turned hostile) - prevent reading them while under a no-allies conduct. -------------------------------------------------------------------------------- cbf53edc00 | Kate | 2022-07-21 19:41:34 +0100 Fix inverted logic in a butterfly check -------------------------------------------------------------------------------- cf90b5c518 | Nicholas Feinberg | 2022-07-21 07:55:08 -0700 Maybe fix an obscure Abyss exit bug (CarefulOdds) meaning that the game considered it to be temporary terrain. A water nymph was killed in the same action that the exit was spawned. I was unable to repro the issue, but I believe that the game still considered the exit to be part of the nymph's temporary terrain. This tries to clean up that situation. Closes #2618. -------------------------------------------------------------------------------- 1595a9cb2e | advil | 2022-07-21 10:34:42 -0400 fix: unremove `SPELL_SUMMON_BUTTERFLIES` -------------------------------------------------------------------------------- cbe080d7e0 | Nicholas Feinberg | 2022-07-20 19:05:23 -0700 Scroll of butterflies icon (Sastreii) -------------------------------------------------------------------------------- fb1a3fa8b1 | Nicholas Feinberg | 2022-07-20 11:27:01 -0700 Let a thousand starflowers bloom (Sastreii) New Starflower tile. -------------------------------------------------------------------------------- b26ba3297d | Nicholas Feinberg | 2022-07-19 22:02:55 -0700 Fix the build? -------------------------------------------------------------------------------- ff774ecaa7 | Nicholas Feinberg | 2022-07-19 22:01:23 -0700 Brutally nerf butterfly EV 25 -> 15. This is intended to make scrolls of butterflies more effective against ranged attacks. Centaurs go from having a 20% chance of hitting a butterfly to a 44% chance. Deep elf master archers go from 42% to 65%. Dropping to 12 EV would be even better, but I don't yet have the heart... poor butterflies... -------------------------------------------------------------------------------- 0affbf219e | Nicholas Feinberg | 2022-07-19 21:58:36 -0700 Add a targeter for ?butterflies And fix the ?summoning targeter. -------------------------------------------------------------------------------- dfd6e90d5d | Nicholas Feinberg | 2022-07-19 21:53:27 -0700 Begin the Butterfly Bargain (kate) Make troves not charge ?fog if your game only generates ?butterflies. -------------------------------------------------------------------------------- 4e36813289 | Nicholas Feinberg | 2022-07-19 21:24:37 -0700 Set scroll of fog to alternate with butterflies Delver is unaffected. -------------------------------------------------------------------------------- df2fad6ba1 | Nicholas Feinberg | 2022-07-19 21:24:36 -0700 New scroll: scroll of butterflies For many years, there were suggestions to turn the 'summon butterflies' effect from random uselessness into its own scroll (c.f. 17b97e55154e). Before we had 'alternate item' tech, this would have caused inventory clutter. But now we can have variety without causing UI issues or option overload, and with the removal of the Summon Butterflies spell, the only other analogous effect is a Xom action! A subsequent commit will make this an alternate for scrolls of fog. -------------------------------------------------------------------------------- 230be3ade3 | Nicholas Feinberg | 2022-07-19 21:21:17 -0700 Maybe silence some compilation warnings -------------------------------------------------------------------------------- 7b45a56547 | Kate | 2022-07-19 18:04:56 +0100 Don't list Deep Dwarves on the aptitudes menu (#12704) -------------------------------------------------------------------------------- ee4989fb63 | Nicholas Feinberg | 2022-07-19 09:54:00 -0700 Fix: don't spawn monsters in portals (CarefulOdds, Goratrix) Broken in 74bf5736c0002df9636fc6333b837f5770b722dd . -------------------------------------------------------------------------------- fc89b1a5bd | Edgar A. Bering IV | 2022-07-18 20:57:32 -0700 docs: changelog through 0.29-a0-875 -------------------------------------------------------------------------------- 74bf5736c0 | Nicholas Feinberg | 2022-07-18 19:07:50 -0700 Remove env.spawn_random_rate (riverfiend, acrobat) This field was extremely useless and mostly misleadingly misused. This might fix a bug with orb spawns not spawning in Temple. At any rate, they spawn there now. -------------------------------------------------------------------------------- 76f050b3ff | Nicholas Feinberg | 2022-07-18 19:07:50 -0700 Intermediate state -------------------------------------------------------------------------------- 9d4207de54 | Nikolai Lavsky | 2022-07-18 15:10:52 -0700 fix: allow Poisonous Vapours to work under Still Winds Allow Poisonous Vapours to work under -Clouds, since as of 3f0e5c0cc there are no clouds involved. -------------------------------------------------------------------------------- 797fff5ad1 | Nicholas Feinberg | 2022-07-17 11:55:30 -0700 Mark elementals and animated weapons/armour M_UNBLINDABLE They have no eyes. Possibly tomes should go this way too. Undecided. -------------------------------------------------------------------------------- 9694c85c73 | Nicholas Feinberg | 2022-07-17 11:55:30 -0700 Mark slime creatures M_UNBLINDABLE (graveyardigan) Looks like an oversight - all other jellies have this. -------------------------------------------------------------------------------- 2c972031a6 | Kate | 2022-07-17 03:34:55 +0100 Fix various Step from Time pathfinding interactions (acrobat) Don't let monsters path towards the player during Step from Time if marked or if (0,0) was visible from the location where the ability was used, and don't let monsters re-target the player while they're at (0,0) if they fail a stealth check. It's entirely feasible that this makes Step from Time work completely differently to how it used to, but since nobody really understood how it worked in the first place that's probably fine. -------------------------------------------------------------------------------- 4f890cd2dc | Kate | 2022-07-17 01:32:14 +0100 Fix slimified Dowan/Duvessa handling Slimified monsters shouldn't be able to turn hostile again, as this causes messy interactions with Jiyva penance prompts. Instead treat slimify similarly to banishment and anger the other twin (along with some speech lines for Dowan, but none for Duvessa since her perma-berserk means they'll never be used). -------------------------------------------------------------------------------- db86c2195a | Kate | 2022-07-17 01:32:03 +0100 Fix some Dowan/Duvessa speech handling when dueled If it's even possible to duel one of Dowan/Duvessa, fixes the surviving twin acting as if the dueled twin had been banished. If the player abandons Okawaru mid-duel with one of the twins, the other will still act like the dueled twin is dead on their return, but this is probably impossible to do in the first place anyway. -------------------------------------------------------------------------------- b03dc68cea | Kate | 2022-07-16 23:18:58 +0100 Trim a floor from Lair To continue shortening some of the branches which outstay their welcome, as discussed in PR #1898 and partially implemented with 0.28's shortening of Depths. More substantial changes have been discussed for the future (such as only generating one S branch per game, and only one of Hell or Pan for the extended endgame), but in the meantime shortening Lair slightly is a good step in the right direction. Monster spawns and vault depths are mostly adjusted such that the new Lair:1 is equivalent to the old Lair:2. -------------------------------------------------------------------------------- 0545e20025 | Nicholas Feinberg | 2022-07-16 13:30:26 -0700 Ban useless attack orders against invisible foes Prevent wasting time. This is sort of weirdly inconsistent (we allow attack orders when you have no allies at all) and should probably be rethought. -------------------------------------------------------------------------------- a8a175f626 | Nicholas Feinberg | 2022-07-16 13:19:34 -0700 Warn when ordering an attack on an invisible foe If some or all of your allies can't see invisible. -------------------------------------------------------------------------------- 6811fc6c64 | Nicholas Feinberg | 2022-07-16 13:03:59 -0700 Simplify frozen ramparts code (Gammafunk) The loop was a copy-paste from slime wall code - it's redundant here. -------------------------------------------------------------------------------- 27034753ed | Nicholas Feinberg | 2022-07-16 13:03:42 -0700 Simplify god spell hate code -------------------------------------------------------------------------------- 9cde7d24d7 | Kate | 2022-07-16 19:52:21 +0100 Apply coding conventions -------------------------------------------------------------------------------- c8ba4cecf6 | Kate | 2022-07-16 19:52:21 +0100 Remove obsolete evocations enhancer handling Also tied in to Pakellas, this has been unused for years and makes the code for all evokers unnecessarily more complicated. -------------------------------------------------------------------------------- 1d18206e20 | Kate | 2022-07-16 19:52:21 +0100 Remove obsolete Pakellas code There's no reason for all this to still exist, since Pakellas doesn't pretend to be anywhere near functional if a player does somehow transfer a Pakellas-worshipping save to a modern version, and any future reimplementation of the god would need to be a redesign from scratch. Just keep around the minimum amount of code to allow transferring without crashing or completely breaking the game, and don't punish players for abandoning Pakellas. -------------------------------------------------------------------------------- 0e1e14f5ec | Kate | 2022-07-16 19:52:21 +0100 Fix some dancing weapon interactions under Gozag (#2530) Fixes dancing weapon kills not granting wereblood stacks, as well as possibly some other very niche interactions such as hints mode kill messages not displaying. Closes #2530. -------------------------------------------------------------------------------- 9f61a2287f | Kate | 2022-07-16 19:52:21 +0100 Let Gozag give gold in the Abyss again Missed from the rest of the reverts in ba36221789. -------------------------------------------------------------------------------- 9b1aa3ac5b | Nicholas Feinberg | 2022-07-15 22:05:20 -0700 Display weapons for zombie orcs Fixes #2476. -------------------------------------------------------------------------------- f0f64f35a9 | Nicholas Feinberg | 2022-07-15 22:00:55 -0700 Update Parghit desc to match art (ShaperMC) :( goodbye, wiry frame Closes #2482. -------------------------------------------------------------------------------- dc776d099f | Nicholas Feinberg | 2022-07-15 21:58:15 -0700 Fix yet another fishtail bug (ardl) Don't unmeld boots while in statue form after leaving water. Merfolk fishtail bugs are my Moby Dick. Someone please rescue me. Fixes #2537. -------------------------------------------------------------------------------- a3d7043d74 | Nicholas Feinberg | 2022-07-15 21:46:16 -0700 Fix unneeded Devastator attack prompts Closes #2554. Also future-proof the sceptre of torment. -------------------------------------------------------------------------------- 1ba91cf0d7 | Nicholas Feinberg | 2022-07-15 21:42:16 -0700 Refactor melee_attack bad attack code -------------------------------------------------------------------------------- 6deee45b7e | Nicholas Feinberg | 2022-07-15 21:18:47 -0700 Shift goblin weapon tile up one pixel This is an attempt to fix #2557, but I haven't bothered to compile webtiles to test it. -------------------------------------------------------------------------------- 5add3c4762 | Nicholas Feinberg | 2022-07-15 18:37:58 -0700 Don't show fake frozen ramparts floors Fixes #2609. -------------------------------------------------------------------------------- 16f3739923 | Nicholas Feinberg | 2022-07-15 18:28:26 -0700 Refactor is_seen_foo_wall functions -------------------------------------------------------------------------------- 777627f9b7 | Nicholas Feinberg | 2022-07-15 18:15:26 -0700 Don't autoexclude friendly statues (CarefulOdds) Closes #2612. -------------------------------------------------------------------------------- bdabc8c6d3 | Nicholas Feinberg | 2022-07-15 17:50:12 -0700 Fix: allow autoexplore with inhibited regen (various) Yet another in a very long series of issues with i_feel_safe(), a876b224025 fixed various issues with resting while inhibited regen prevented the player from healing. However, it unintentionally broke many other things that depend on i_feel_safe(), such as autoexplore, running, interlevel travel, spell memorization, etc etc. It also gave a very confusing message - it was not at all clear that inhibited regen was at fault. This refactors the code to split out the relevant check into a new can_rest_here() function. (Maybe that function should also call i_feel_safe()?) It will almost certainly cause new issues. This closes #2595. -------------------------------------------------------------------------------- 24c0ca63c9 | gammafunk | 2022-07-15 12:57:06 -0500 fix: Properly tag two transporter vaults The vaults gammafunk_sealed_arena and gammafunk_sealed_library were not placing under their usual FLOAT orient. When various transporter vaults were unified so their Vaults branch variants didn't need to be separate vaults, these two got that treatment, but without proper tagging with transparent for the outside and opaque for the inside. The passable tag they were given meant they always failed to place as FLOAT vaults. Also add salamander tyrants to gammafunk_sealed_library as alternates for nagaraja, since that's appropriate for this vault. -------------------------------------------------------------------------------- 2802c0ca9a | Nicholas Feinberg | 2022-07-15 07:18:24 -0700 Clarify Dispersal Will checks (Booper) -------------------------------------------------------------------------------- 6161e89988 | Nicholas Feinberg | 2022-07-14 22:10:12 -0700 Dial back corrosive bolt scaling a bit (Ge0ff) Accidental side effect from monster wand changes. (0fff342652f313) Deep elf sorcerer: 3d25 -> 3d20 -> 3d21. Ancient lich: 3d35 -> 3d42 -> 3d34. -------------------------------------------------------------------------------- e8845773e3 | Nicholas Feinberg | 2022-07-14 10:00:40 -0700 Nerf short blade damage (acrobat) When we switched long blades to using dexterity for damage, we made short blades do likewise purely for player intuition. It felt very odd that the smaller, more 'dextrous' short blades would use strength if long blades used dex. At the time, I noted (in 85b37ae345e8) that short blades might need a compensatory nerf. This was indeed the case. A pretty middling endgame character (15 str, 25 dex, 15 fighting & short blades) was getting the equivalent of an extra ring of slaying compared to the old status quo, which seemed neither necessary nor helpful - it made short blades less interesting by helping players just plow through everything with them, rather than needing to stab, etc. To compensate, shift base damage on quick blades, short swords and rapiers down 1. Daggers are unaffected - their base damage is already quite low and they're mostly used early game, where the stat difference is lower. Short swords don't really need the nerf either, but I worry there's not enough differentiation between them and rapiers otherwise. I considered removing stat scaling from short blades entirely, but that seemed like a more complex change (another special case). Let's try this for now. -------------------------------------------------------------------------------- 0fff342652 | Nicholas Feinberg | 2022-07-14 08:48:19 -0700 Brutally nerf Ijyb In general, DCSS tries to provide some form of tactical counterplay for threats. If you see a hydra on D:6, it's a normal-speed melee threat, so you can walk away. A cyclops is slow; a centaur is fast, but does much less damage and drops its bow in melee. As the iconic splash screen of Ijyb melting a player with a wand of acid depicts, Ijyb (and other early game wand-users) went a bit too far - long ranged, very high damage threats. Let's try dialing them back to more reasonable numbers for their depth and see how it plays. Wand Old New /acid 3d12 3d9 /light 3d12 3d9 /qsilver 3d14 3d9 /mindburst 1d22 1d20 /iceblast 3d8 3d8 /flame 3d3 3d5 Also, simplify the logic to remove a bonus special case for wands. GOOE Mindburst damage increased slightly, purple draconian quicksilver bolt damage decreased slightly, various corrosive bolt casters' damage decreased slightly. -------------------------------------------------------------------------------- e0f87948b3 | Nicholas Feinberg | 2022-07-14 07:43:31 -0700 Give the amulet of vitality a shop price Somewhat arbitrary. -------------------------------------------------------------------------------- 116ddc6ace | Nicholas Feinberg | 2022-07-13 20:26:33 -0700 More explicitly document Zin hell effect resistance This was canonically classed as 'protection from Chaos', but I don't think hell effects are really all that chaotic. No more than half the other things in Crawl, anyway. We should probably make poly resistance a little clearer, too. -------------------------------------------------------------------------------- 303e14b210 | Nicholas Feinberg | 2022-07-13 20:20:14 -0700 Don't let Yred derived undead attack out of LOS (ebering) This was an oversight during the recentish Yred rework. This might not be the right way to fix this (perhaps we should add an unlimited duration fake abjuration?), but eh, close enough. -------------------------------------------------------------------------------- 4793fd635e | Nicholas Feinberg | 2022-07-13 11:31:57 -0700 Add another welcome message -------------------------------------------------------------------------------- 385bb11a5b | Nicholas Feinberg | 2022-07-12 17:15:33 -0700 Add studio walls (Sastreii) For later use in vaults. -------------------------------------------------------------------------------- 174bc33265 | patrick | 2022-07-12 16:25:51 -0400 Fix errors in some recently-added variable-altar temples I had somehow missed that get_altar_counts returns a string, not a number. I have fixed the erroneous temples. -------------------------------------------------------------------------------- 139bfe3b0c | Nicholas Feinberg | 2022-07-12 12:37:01 -0700 Fix beams stopping at target (dilly) Only stop when you'd hit an ally, not when you'd hit an enemy, ha. -------------------------------------------------------------------------------- a65acad94f | David Damerell | 2022-07-12 18:35:05 +0100 Change acquirement's description to match new acquirement Another highly important change for ebering. :-) -------------------------------------------------------------------------------- 1e95ca9f62 | gammafunk | 2022-07-11 23:37:41 -0500 fix: Airstrike damage for monster This no longer has a minimum base damage, but the relevant code wasn't fully updated. -------------------------------------------------------------------------------- 34b5299d54 | Nicholas Feinberg | 2022-07-11 19:02:01 -0700 Add reflect icon for monsters (Sastreii, acrobat) To make it a little more obvious when your iron shot is about to come back hilariously toward you. -------------------------------------------------------------------------------- 72eb547380 | Nicholas Feinberg | 2022-07-11 18:51:26 -0700 Add a skeleton for new Lerny tiles (Sastreii) Skeletal Lernaean hydra tiles. -------------------------------------------------------------------------------- 412af75db4 | Nicholas Feinberg | 2022-07-11 18:27:59 -0700 Make phantoms avoid teleport closets (leNuup) -------------------------------------------------------------------------------- cb1280458a | Edgar A. Bering IV | 2022-07-10 23:58:36 -0500 vaults: give thematic (and good) loot to bailey warlords Warlords get a one chance in three to get a good_item weapon, but an orc warlord with a good_item greatsword looks out of place in an axe baily, so let's outfit them particularly and force the good_item since the warlords are quite early. -------------------------------------------------------------------------------- bc3a993a49 | hellmonk | 2022-07-10 20:02:53 -0400 feat: Minor artifact price adjustments -------------------------------------------------------------------------------- 9d1704292e | hellmonk | 2022-07-10 19:51:58 -0400 feat: Rework scroll prices. Bring these more into line with rarity/utility. -------------------------------------------------------------------------------- a07a83588e | hellmonk | 2022-07-10 19:36:33 -0400 feat: Rework wand shop prices Scale cost linearly with charges and rearrange the hex effects. -------------------------------------------------------------------------------- 80bc156356 | hellmonk | 2022-07-10 18:47:58 -0400 Reduce irradiate max damage -------------------------------------------------------------------------------- 72347fce65 | Nicholas Feinberg | 2022-07-10 13:42:02 -0700 Auto-stop-at-target when firing toward allies Instead of prompting ("really shoot toward your goblin?"), use '.' targeting mode automatically if your shot might otherwise miss an enemy and hit an ally. TODO: find remaining cases that this needs to apply to, then remove the overshoot_prompt boolean. -------------------------------------------------------------------------------- d827844252 | Nicholas Feinberg | 2022-07-08 11:19:01 -0700 Fix: Allow zapping /roots through ancestors (acrobat) -------------------------------------------------------------------------------- c37b1572da | patrick | 2022-07-07 20:37:50 -0400 Remove scythes from ghost vaults with Xom altars (ebird) Looks like the removal of scythes missed one. Rather than replacing them with reskinned halberds, just remove them from the list. -------------------------------------------------------------------------------- a620ab95ad | Kate | 2022-07-07 18:56:23 +0100 Fix the mountain boots showing messages on all beams (#2599) Closes #2599. -------------------------------------------------------------------------------- 66395355a5 | Nicholas Feinberg | 2022-07-06 16:45:08 -0700 Hackily 'fix' a vp webtiles mut menu bug (rhaal) -------------------------------------------------------------------------------- 1caec59328 | Nicholas Feinberg | 2022-07-06 16:41:20 -0700 Don't randomize displayed aux damage (acrobat) Display the max damage for all auxes, including demonic touch. -------------------------------------------------------------------------------- 94b489e0ae | Nicholas Feinberg | 2022-07-05 07:54:28 -0700 Simplify hex miscasts (acrobat) Hasting foes is a little too vicious, and also adds extra complexity in terms of preventing the player from instantly excommunicating themself by using Spellbinder with Cheibriados. -------------------------------------------------------------------------------- 2d5a0d7a41 | Nicholas Feinberg | 2022-07-05 07:39:38 -0700 Don't call bad miscasts 'potentially lethal' (riverfiend) That's not limited to top-tier miscasts (the severity is based on your MHP, not current HP, so lower colored miscasts can also be lethal), and it's not accurate for eg hex miscasts (which can't directly damage you). -------------------------------------------------------------------------------- 9904bce7a6 | Nicholas Feinberg | 2022-07-04 22:50:25 -0700 Replace hex miscast effect (riverfiend) Wiping player effects didn't make much sense for modern hexes (since the school has fairly few durations that would be affected by cancellation), and was quite abusable. Replace it by hasting nearby enemies. -------------------------------------------------------------------------------- 82769f0e0c | Nicholas Feinberg | 2022-07-04 14:03:47 -0700 New lochaber axe tile (Sastreii) -------------------------------------------------------------------------------- 41c3e4b865 | Edgar A. Bering IV | 2022-07-04 10:42:22 -0500 docs: update CREDITS.txt -------------------------------------------------------------------------------- 0d988dd55d | advil | 2022-07-04 10:44:28 -0400 fix: remove a double exponentiation in a lua call Seems to be just a misunderstanding in how bitfield iteration works. I have also added a compile check for this bitfield's range value, which had gotten out of sync. -------------------------------------------------------------------------------- 4a14ea37d6 | Nicholas Feinberg | 2022-07-03 22:22:39 -0700 No attacks of opportunity for constricted foes (acrobat) Since they can't follow. -------------------------------------------------------------------------------- 49d5403b4a | advil | 2022-07-03 22:16:27 -0400 fix: add a missing nullptr check in a lua call -------------------------------------------------------------------------------- 8c06add4a9 | Nicholas Feinberg | 2022-07-03 18:30:04 -0700 Don't stop /roots tracers at invisible foes (dilly) Oops! -------------------------------------------------------------------------------- 3812dd5c9c | hellmonk3 | 2022-07-03 14:34:17 -0500 feat: silent ossuary map All but the outer edge of the map is silenced. Typical ossuary monster set. -------------------------------------------------------------------------------- df645b4c5c | Rytis Petronis | 2022-07-03 14:21:06 -0500 feat: option for adjusting explore_greedy non-autopickup item visits explore_greedy_visit is added as an rc file option to adjust explore_greedy behavior. By default greedy explore travels to piles of items on each square in addition to items that are eligible for autopickup. This setting allows to also/only go to enchanted items or artefacts instead by providing a list option explore_greedy_visit, supporting - stacks: makes explore_greedy visit stacks even if they don't necessarily have target auto pickup items - glowing_items: makes explore_greedy visit glowing_items, even if not in a stack - artefacts: makes explore_greedy visit artefacts, even if not in a stack The default is updated to `explore_greedy_visit = glowing_items,artefacts`, as stack-visiting is a behavior more for console UI smoothness and accessibility than any gameplay reasons; visiting glowing_items and artefacts should allow the default player to loot efficiently (finding goodies). -------------------------------------------------------------------------------- a2102b4d9d | patrick | 2022-07-03 12:50:04 -0400 Add a randbook.txt entry (hellmonk) -------------------------------------------------------------------------------- 426022cc84 | patrick | 2022-07-03 12:20:13 -0400 Add some more options to randbook.txt Add some more options for naming random-generated spellbooks. I kept all of the existing options, except for (most of) the nouns and adjectives for Air Magic that were about flight, since that spell is no longer part of the school. -------------------------------------------------------------------------------- eadc89832f | damerell | 2022-07-03 10:22:26 -0500 fix: correctly produce strings of the form "one hundred and one" In Australian English there is an "and" after "hundred" in numbers of this kind. (Source: I asked all the Aussies I know.) -------------------------------------------------------------------------------- 5b9a7de867 | patrick | 2022-07-03 09:43:12 -0500 vaults: add several new temples, add section for tiny temples Adds several new temples, including several variable-size temples, an edit of my old great_sept temple so it has a chance to place 7 altars again, a temple where demons yell at you, and a temple featuring Lugonu's victory over the temple gods. [ Committer's note: removed a use of permarock, tweaked some colours. ] -------------------------------------------------------------------------------- b127be5c9c | Kate | 2022-07-03 15:12:42 +0100 Cancel constriction enchantments on Duel (acrobat) The actual constriction damage/effect was already cancelled by the duel, but the roots/zombie hands enchantments weren't ended so were still displaying visually on monsters. -------------------------------------------------------------------------------- d130422d61 | Nicholas Feinberg | 2022-07-03 07:00:03 -0700 Fix a refactoring oversight (Aliscans) -------------------------------------------------------------------------------- 34511f41fd | Nicholas Feinberg | 2022-07-02 20:58:20 -0700 Remove the prompt for firing at unhittable enemies This drives me absolutely nuts, and has for years. There's no point in this prompt! Just don't fire. -------------------------------------------------------------------------------- 13870d9ccb | Nicholas Feinberg | 2022-07-02 20:42:21 -0700 Don't allow distortion blinking during aoops This has a reasonable chance of crashing the game, I think. It certainly spooks me out. -------------------------------------------------------------------------------- 163208c30e | Nicholas Feinberg | 2022-07-02 20:40:45 -0700 Rename Necrotize -> Necrotise (|amethyst) Follow Australian English. -------------------------------------------------------------------------------- d32efaa14b | Nicholas Feinberg | 2022-07-02 20:34:07 -0700 Rename: bouda -> gnoll bouda To clarify to players what species it is, since that's relevant to its function and otherwise not obvious from the name. -------------------------------------------------------------------------------- 471e52b980 | Nicholas Feinberg | 2022-07-02 20:25:33 -0700 Allow friendly torpor snails to slow foes Way back in 2014, when I first added torpor snails, I prevented friendly torpor snails from slowing enemies. In 18cebf10d87e656198, I wrote: Disables the aura entirely, since it'd be hilariously abusable otherwise. (As long as the Enslave spell remains in the game...) Enslave has been gone for a long time, as is Shadow Creatures, and /charm charges are quite limited. Let's simplify, and let players have fun. Also double torpor snail Will (40 -> 80), just to make sure there's not *too* much fun being had. -------------------------------------------------------------------------------- 8cd43ee5b5 | Nicholas Feinberg | 2022-07-02 20:20:47 -0700 New statuesque beauties (Sastreii) New statue form tiles for all species. -------------------------------------------------------------------------------- 7df905bfc2 | Nicholas Feinberg | 2022-07-02 20:15:28 -0700 Re-add ranged to-hit % display -------------------------------------------------------------------------------- 4cfcd3498a | Nicholas Feinberg | 2022-07-02 20:12:14 -0700 Unify melee & ranged combat noise For consistency, make both melee & ranged attacks make noise proportionate to the damage done at the defender's location. -------------------------------------------------------------------------------- 1c776c33a3 | Nicholas Feinberg | 2022-07-02 19:56:25 -0700 Remove unused should_alert_defender var Unused since the removal of darts of sleeping (9adfa933843a, 2019). -------------------------------------------------------------------------------- 800ede72b0 | Nicholas Feinberg | 2022-07-02 13:03:44 -0700 Simplify ranged weapon noise There's no particular need for different ranged weapons to make different amounts of noise. -------------------------------------------------------------------------------- 90d98aa4a7 | Nicholas Feinberg | 2022-07-02 12:57:55 -0700 Readjust Spriggan ranged apt (acrobat) Going from +2 slings to +2 ranged weapons was expected to be a buff, but in practice it was a bit much. Spriggans are already quite good at ranged weapons without a positive aptitude, by virtue of their high dexterity and fast movement speed - let's move them down to +0 for now. -------------------------------------------------------------------------------- a0f254aafb | Nicholas Feinberg | 2022-07-02 12:57:35 -0700 Don't let roots go through enemies and walls Oops! -------------------------------------------------------------------------------- 14d1036c72 | Nicholas Feinberg | 2022-07-02 12:57:35 -0700 Make monsters not zap roots at constricted players Waste of charges. -------------------------------------------------------------------------------- 7a8fcbc185 | Neil Moore | 2022-07-02 01:26:09 -0400 Add a quote for shambling mangroves, thanks to Prof Neil Peart. -------------------------------------------------------------------------------- 40bbea3e73 | Nicholas Feinberg | 2022-07-01 19:36:50 -0700 Clarify fencer's gloves' effect (4L2A) -------------------------------------------------------------------------------- 9e05a5b3ab | Nicholas Feinberg | 2022-07-01 19:36:50 -0700 Fix a roots vs player crash (HendSelp) -------------------------------------------------------------------------------- 37b1a91500 | gammafunk | 2022-07-01 17:53:59 -0500 fix: Update a clua monster info function When the `holiness()` monster info method is called with no arguments, it's supposed return the holiness as a string, but the implementation was incorrect, so fix this. -------------------------------------------------------------------------------- e5ab06ae1c | Nicholas Feinberg | 2022-07-01 15:10:04 -0700 Set up wand of roots damage For players, the goal is for the base damage to be about 1/3rd of an iceblast use - 2d4 at 0 evo (compared to iceblast's 3d7) and 2d14 at 27 evo (compared to iceblast's 3d27). Roots does multiple turns of damage (increasing over time) & also has bonus utility (doesn't hit allies, doesn't check rC, wastes monster turns), so this seems reasonable as a starting point. For monsters, this matches Jorgrun's Grasping Roots spell. Ijyb will deal about 2d4 with it (I believe!), and other monsters will scale. -------------------------------------------------------------------------------- 5507e99a2f | Nicholas Feinberg | 2022-07-01 15:10:04 -0700 Refactor constriction Try to more clearly split up different ways to be constricted. -------------------------------------------------------------------------------- a4b73df947 | Nicholas Feinberg | 2022-07-01 15:10:04 -0700 Alternate wand of roots with wand of iceblast -------------------------------------------------------------------------------- ddcf899e2d | Nicholas Feinberg | 2022-07-01 15:10:04 -0700 New item: wand of roots Continuing the theme of alt items, wands of roots are a new item that will alternate with /iceblast. They fire a 3x3 (fireball-sized) effect which constricts its victims (ala BVC), with a duration that scales with wand power. -------------------------------------------------------------------------------- b44b3c5ca4 | Nicholas Feinberg | 2022-07-01 15:10:04 -0700 Refactor Grasping Roots -------------------------------------------------------------------------------- 652cadfb38 | Aliscans | 2022-07-01 15:31:57 -0500 feat: only list gods you can ever worship in the dungeon overview & dump Different gods forbid worship from different species. This change gives a way for the player to check which gods are available, and hides irrelevant information about whether an unusable altar has been found. Co-authored-by: Aliscans -------------------------------------------------------------------------------- 7e300f6e71 | Perry Fraser | 2022-07-01 15:25:30 -0500 refactor: wearing/removing armour This refactors a good bit of the logic for taking off armour, as well as a few other things in the inventory wear/unwear section. I also removed a few TODOs, clarified the semantics of the return values of the wear/unwear armour functions (they are not used anywhere anyway [ Committer's note: they are used in clua to indicate success, but the inverted return values changed by this commit were not correct ]), and added a few doc comments for some of the less intuitive functions. [ Committer's note: Closes #2340. Rebased and fixed up, restored overzealously removed inscription checking prompts. ] -------------------------------------------------------------------------------- 8ec7be85a6 | Perry Fraser | 2022-07-01 14:45:37 -0500 fix: prompt once on tiles for wearing risky items On Tiles, you would be prompted twice if you wanted to wear an item that was potentially dangerous (e.g., {Contam}). This removes the redundant check_warning_inscriptions that were happening when handling these clicks. -------------------------------------------------------------------------------- 24d99152b8 | Edgar A. Bering IV | 2022-07-01 11:31:03 -0500 feat: warn when an orb of energy backfire was guaranteed (Cebolla) Closes #2449 -------------------------------------------------------------------------------- bb76e39405 | Edgar A. Bering IV | 2022-07-01 09:22:23 -0500 fix: don't print wereblood messages silenced -------------------------------------------------------------------------------- 4d7333d4e2 | ruxi | 2022-06-30 22:35:56 -0500 feat: describe storm form's insubstantialness Closes #2509 -------------------------------------------------------------------------------- 250d9ad825 | RojjaCebolla | 2022-06-30 22:12:23 -0500 feat: set hp_colour to higher defaults This might subtly hint to newer players that things have gone awry sooner. -------------------------------------------------------------------------------- 7e9ac4eb86 | Reono | 2022-06-30 22:03:45 -0500 vaults: new vaults by reono Closes #2516 -------------------------------------------------------------------------------- a24da20820 | Nicholas Feinberg | 2022-06-30 15:08:20 -0700 Break out extra throwing base damage separately Try to make throwing damage rates clearer. -------------------------------------------------------------------------------- 4d60fd9eac | Nicholas Feinberg | 2022-06-30 15:08:20 -0700 Unhide Damnation's damage rating (CarefulOdds) I'd forgotten that Damnation did normal arbalest damage in addition to the Damnation burst. -------------------------------------------------------------------------------- 2e8140cf71 | Kate | 2022-06-30 22:47:27 +0100 Fix spelling -------------------------------------------------------------------------------- 18b9c4ed99 | Kate | 2022-06-30 22:47:27 +0100 Interrupt delays on paralysis/petrification/sleep Sleep already interrupted some delays, but not all. Make all three of paralysis, petrification and sleep consistently interrupt delays, including stair travel, and don't allow resuming delays such as equipping/unequipping armour when interrupted by one of these effects. -------------------------------------------------------------------------------- e8933c00c5 | Kate | 2022-06-30 22:47:27 +0100 Update Spriggan's Knife description -------------------------------------------------------------------------------- 967b614d45 | Kate | 2022-06-30 22:47:27 +0100 Remove some unused stab messaging These stab messages haven't been able to be used since 9c76b8a688. The stab strengths here should probably also be enum-ified instead of being magic numbers. -------------------------------------------------------------------------------- a993524b14 | Kate | 2022-06-30 22:47:27 +0100 Fix tag_upgrade compilation Remove HINT_SEEN_RANDART yet again, and remove an unused function. -------------------------------------------------------------------------------- dd995151d0 | Nicholas Feinberg | 2022-06-30 14:21:14 -0700 Fix minor hints mode issues -------------------------------------------------------------------------------- 1c741a5a2c | Brian Power | 2022-06-30 16:05:59 -0500 refactor: externalise hints text Move hints text to the database, with some lua support. Closes #2271 -------------------------------------------------------------------------------- e2a13e336d | U-DESKTOP-2MKRQ21\rosst | 2022-06-30 13:51:37 -0500 text: speech, death, and banishment lines for some uniques Erolcha gets a banishment line, as a notable early banisher. Louise gets a banishment line, for the Lore. New speech lines for Grum, Kirke, Lodul, Margery, Sojobo and Snorg. Polyphemus gets a rare death message, also for the Lore. [ Closes #2481 ] -------------------------------------------------------------------------------- 3f25a06b81 | Edgar A. Bering IV | 2022-06-30 11:41:19 -0500 feat: make monster airstrike damage match player's, display -------------------------------------------------------------------------------- 4c3e83d15c | hellmonk | 2022-06-30 11:19:58 -0500 feat: Display airstrike and discharge damage -------------------------------------------------------------------------------- d72e128878 | hellmonk | 2022-06-30 11:19:36 -0500 feat: Rework the static discharge formulas Primarily so that damage can be displayed in future. Don't rely on division by power to recur, just caclulate the number of arcs to do upfront and do them at full power. Additionally, random round all of the formulas to avoid messy power breakpoints. New numbers give mostly similar damage at low power, I think. At high power with a lot of targets things can get a bit wilder. If it's a problem, can cap power at 50 instead of 100. -------------------------------------------------------------------------------- b575a813fa | Edgar A. Bering IV | 2022-06-30 10:39:00 -0500 feat: rework and rename gnoll shaman -> bouda (nikheizen) Gnoll shamans are somewhat lackluster as an enemy. They fit the "support priest" archetype pretty well, but unfortunately this not as effective early on as its Deep Troll counterpart in Depths/Vaults. Early game has shorter fights and monsters have to get to business more quickly as every turn matters. This commit reworks them into "Bouda," and also creates a monster type who can more easily bridge the gap between early dungeon Orc Wizards and the more powerful spellcasters who can show up later on. This is accomplished by giving them support spells that work more rapidly: a new "Hunting Call" is like battlecry, but applies swiftness in favor of might (helping a gnoll pack swarm better without being too strong of a buff early), and Weakening Gaze, fitting the Evil Eye flavour. As an instant gaze attack, Weakening Gaze does a better job of debuffing the player in a noticable way than Corona, particularly in the quicker fights of the early game. Bouda are characters from Northeast African folklore who are shapeshifters that turn into jackals. They have the power of the Evil Eye which curses others with spectacular misfortune. The term is historically one of exclusion-othering someone by calling them Bouda is analogous to the European tradition of naming folks as witches. In crawl they have all the malevolent energy of their mythological basis, but here it is directed towards the player-the dungeon's one true outgroup. Closes #1969. Based on that PR -------------------------------------------------------------------------------- 477250c084 | advil | 2022-06-30 09:13:41 -0400 fix: improve wording in weapon descriptions I just wanted to fix this wording, but I found a whole bunch of other issues here that could be better and I don't have time to fix right now. (Most misleading is that this item desc code ignores shield delay.) -------------------------------------------------------------------------------- 358383bc75 | amcnicky | 2022-06-29 22:27:01 -0500 tiles: hood of the Assassin hood of the Assassin - made sharper, more like a hood, and shifted colour palette towards red. Finishes half of #1387 Closes #1569 -------------------------------------------------------------------------------- 20e0cd1ebb | RojjaCebolla | 2022-06-29 18:06:32 -0500 vaults: a few maps featuring starflowers An abyssal rune vault and four exit vaults. [ Committer's note: Closes #2466. Squashed and rebased. Tweaked monster stats a bit more. Adjusted harpoon shot AI logic. Updated the rune vault for runelight usage. ] -------------------------------------------------------------------------------- 122d04a4e0 | RojjaCebolla | 2022-06-29 18:06:32 -0500 feat: new monser "Starflower", an abyssal oklob A stationary plant/tentacle hybrid monster with harpoon shot, reach 3 distortion melee, reach 2 melee, and an additional melee attack. Meant as a vault-placed monster for abyssal vaults, guarding an exit or a rune or what have you, as a threat that's dangerous to be close to, but can be neutralized if the harpoon shot can be blocked or avoided somehow. -------------------------------------------------------------------------------- a47bfe3f80 | Edgar A. Bering IV | 2022-06-29 17:32:43 -0500 feat: don't fire harpoon shots if a melee attack is possible Affects Harold, who now won't try to pull you back unless you're out of pole arm range. Also affects the monster added in the next commit. -------------------------------------------------------------------------------- b7bb9d756e | patrick | 2022-06-29 16:31:50 -0500 vaults: some abstract decor vaults to float.des Some more abstract vaults based on geometric designs, except these ones are big so they go in float.des. [ Closes #2559 ] -------------------------------------------------------------------------------- ff91a8ed75 | patrick | 2022-06-29 16:31:50 -0500 vaults: two new theme shops Features a shop that sells big spellbooks and one which is much smaller and sillier. -------------------------------------------------------------------------------- 26dd769911 | patrick | 2022-06-29 16:31:50 -0500 vaults: a simple generic overflow altar Just a simple altar. Some water, some lava, some altars. -------------------------------------------------------------------------------- 8e6dc78163 | patrick | 2022-06-29 16:31:50 -0500 vaults: various designs for mini_features.des Add some decor vaults based on geometric patterns and designs. -------------------------------------------------------------------------------- 0912897232 | Edgar A. Bering IV | 2022-06-29 15:48:11 -0500 fix: remove a debug weight (hellmonk) -------------------------------------------------------------------------------- 184eed5aab | Edgar A. Bering IV | 2022-06-29 15:36:47 -0500 feat: rare low-altar count temples The (higher-weight) cousins of the Temple with every god. One is a small, colourful, crystalline grotto with exactly one altar. The other is an abandoned empty temple with no altars at all! -------------------------------------------------------------------------------- 1659c76842 | Edgar A. Bering IV | 2022-06-29 14:07:19 -0500 feat: enable small Temples With the addition of small Temple maps, lower the minimum Temple size to 6. The distribution used has a picewise linear probability density function, starting with a 2.5% chance of a temple of size 6, rising to its maximum at size 13.5, (roughly 10% each for sizes 13 and 14) and then decreasing to a 2.5% chance of a temple of size 21. This is a bit more verbose than using 6 + random2avg(16,2), but the latter makes the extremes too small. A distribution that falls off harder in the direction of larger temples might be interesting but it's a somewhat tricky balancing act. -------------------------------------------------------------------------------- 1f4f75ee32 | Edgar A. Bering IV | 2022-06-29 14:05:40 -0500 feat: add random2min and random2max For when distributions with various polynomial pdfs are desired. -------------------------------------------------------------------------------- d6dbc1d939 | hellmonk3 | 2022-06-29 12:07:58 -0500 feat: nine new temples - hellmonk_temple_micro_hex 6-8-10 altars -hellmonk_temple_forest_ring 8-9-12-13 altars - hellmonk_temple_of_storms 7, 8, 11, 15, or 19 altars. - hellmonk_temple_divided_pantheon Places any odd number of altars from 7 to 19. - hellmonk_choose_your_character Rare temple with every god. - hellmonk_temple_rainy 6, 8, 9, or 10 gods. - hellmonk_temple_flakie 6, 8, 10, or 12 gods. - hellmonk_temple_beads 6-10 gods. - hellmonk_temple_two_chambers 6-8, 12, or 15 gods. Co-authored-by: hellmonk Co-authored-by: Edgar A. Bering IV -------------------------------------------------------------------------------- 221c65d467 | Perry Fraser | 2022-06-29 11:02:28 -0500 fix: correct desc. grammar for CANT_SEE_YOU status -------------------------------------------------------------------------------- da9226009b | Alex Jurkiewicz | 2022-06-29 10:39:55 -0500 refactor: tag out some Pakellas-specific code Closes #2475 -------------------------------------------------------------------------------- fe44c63f7f | Alex Jurkiewicz | 2022-06-29 10:36:26 -0500 refactor: simplify player mp/hp-on-kill implementation Split a large conditional into smaller blocks for clarity. Also, further isolate Pakellas logic so it can be more easily removed when TAG_MAJOR_VERSION increases to 35. [ Closes #2475 ] -------------------------------------------------------------------------------- e5bf7c5c39 | RojjaCebolla | 2022-06-29 10:16:37 -0500 feat: reduce the +stab effect on Spriggan's Knife by 50% Most monsters die in a single hit from the Spriggan's Knife; those that survive take massive damage and can be quickly dispatched with a couple more stabs. Stabs that result from netted/webbed/petrifying/invisible/confused often leave the target open for further stabbing, as the condition still applies. This is especially overpowered with irresistible status effects such as that from Line Pass. To make this less of a guaranteed instakill, add a coinflip(). It may take a few tries before the target dies. -------------------------------------------------------------------------------- 7d34257905 | 4Hooves2Appendages | 2022-06-29 09:59:06 -0500 text: quotes for charm and Mephetic cloud Plus some quotation mark fixes. -------------------------------------------------------------------------------- 85b6c24e30 | spicyCebolla | 2022-06-29 09:49:01 -0500 vaults: arrival vaults by SpicyCebolla - spicycebolla_arrival_risky_transporter This teaches that using a transporter can be risky: the 'porter takes you from pretty safe terrain to a wide open space. [ Committer's note: simplified the substitutions, cleaned up, added sightlines. ] - spicycebolla_arrival_clurvy a few simple 20% chances of theme variations, giving different iterations on a forgotten stand of trees (possibly long forgotten) [ Committer's note: adjusted tree colouration, prevented a small chance of a teleport closet ] - spicycebolla_green_bress_n_ham - spicycebolla_green_bress_n_ham_2 Simple arrivals. - spicycebolla_arrival_ecumenical Places a faded altar with stairs (or a very lucky teleport) required to reach it. [ Committer's note: This slightly increases the 87.5% chance of a D:1-3 faded altar, but not so much that it matters. Closes #2492 ] -------------------------------------------------------------------------------- 91da1267ba | spicyCebolla | 2022-06-29 09:08:56 -0500 fix: entry vault missing some blood relevant to #704 -------------------------------------------------------------------------------- cd6ae0ea07 | Edgar A. Bering IV | 2022-06-29 08:43:01 -0500 fix: scary damage fraction at tier 2 (Sentei) -------------------------------------------------------------------------------- 9e4779279f | Edgar A. Bering IV | 2022-06-29 07:39:57 -0500 vaults: tweak two arrival vaults -------------------------------------------------------------------------------- dc9d147ae0 | Edgar A. Bering IV | 2022-06-29 07:33:42 -0500 text: sling changes in zh/items.txt -------------------------------------------------------------------------------- 8f12646833 | Edgar A. Bering IV | 2022-06-29 07:32:55 -0500 lint: checkwhite -------------------------------------------------------------------------------- 4208692735 | 张凯 | 2022-06-29 07:24:08 -0500 text: update zh/items.txt Updated translations. -------------------------------------------------------------------------------- 3d7fbe0af2 | nicolae-carpathia | 2022-06-28 23:44:41 -0500 vaults: add several small vaults containing transporters to mini_features.des Add several small vaults which use transporters in ways besides just setting off an optional murder zone. Some, with "diode" in their names, allow the player to only move in one direction down one or more hallways. The others just make weird intersections. -------------------------------------------------------------------------------- a39a8af6d9 | Nicholas Feinberg | 2022-06-28 21:39:11 -0700 Adjust arbalest and hand crossbow (acrobat) Make arbalest a bit weaker earlier on, and make hand crossbow more competitive as a 'high-tier' one-hander. See this graphic: https://media.discordapp.net/attachments/205316046230388737/991216806184366130/r ange.PNG -------------------------------------------------------------------------------- 5686a2c4f1 | Edgar A. Bering IV | 2022-06-28 22:19:44 -0500 text: some quotes citation editing -------------------------------------------------------------------------------- 836e7b5932 | Edgar A. Bering IV | 2022-06-28 21:42:35 -0500 text: a new Orb adjective and welcome message (Rosstin) Closes #2485 -------------------------------------------------------------------------------- 6bb282b620 | Nicholas Feinberg | 2022-06-28 12:33:36 -0700 Simplify jewellery price code Make stat ring prices match AC/EV ring prices - they don't seem substantially better or worse. -------------------------------------------------------------------------------- 89c9ce7d72 | Nicholas Feinberg | 2022-06-28 12:32:14 -0700 Remove an unused var -------------------------------------------------------------------------------- 50f2ce223d | Nicholas Feinberg | 2022-06-28 12:00:49 -0700 Don't let large players flounder in toxic bogs The DNGN_SHALLOW_WATER check here was redundant, and only affected bogs. -------------------------------------------------------------------------------- a706738f4e | advil | 2022-06-28 12:37:20 -0400 fix: update some throw/launch code These are a couple of places that relied on get_item() being always ammo, from the original newquiver implementation. This was still approximately true for throwing/launching, until ce39da1c22d. However, ce39da1c22d is supposed to be the correct way to set a tile, etc. This commit makes ce39da1c22d work correctly, so I have reverted 0fc3c4380c. -------------------------------------------------------------------------------- 0fc3c4380c | Nicholas Feinberg | 2022-06-28 06:52:31 -0700 Revert "Fix quivered launcher tile" This reverts commit ce39da1c22d85fa8819e7db12783cbae1a8eb494. -------------------------------------------------------------------------------- ce39da1c22 | Nicholas Feinberg | 2022-06-27 22:27:28 -0700 Fix quivered launcher tile Farewell, mysterious ❌. -------------------------------------------------------------------------------- 64f5989226 | advil | 2022-06-27 10:27:08 -0700 fix: don't use levelgen checks for TRJ splitting (particleface) The TRJ splitting code doesn't use normal summon placement code (which would typically be `find_habitable_spot_near`), but rather repurposes some levelgen placement code, that has the right adjacenty check for TRJ. However, because this code is otherwise used only in levelgen, it enforced an `MMT_NO_MONS` mask check. A result is that if you can manage to fight TRJ in the loot vaults, it won't split. This commit simply conditionalizes the levelgen check, so that the placement-finding code can be used either way. On a quick glance, this should bring it in line with regular summon placement; there isn't an explicit los check but I expect that's approximated by the floodfill. -------------------------------------------------------------------------------- 7f417c9bbb | Nicholas Feinberg | 2022-06-26 18:22:17 -0700 Turn fustibaluses into hand crossbows Fixes a crash when trying to fire fustibali. Easier than retaining support for them. This will result in some funny randart names, since those will include the old name of the weapon. Not bothering with a minor tag. -------------------------------------------------------------------------------- ac13c76575 | gammafunk | 2022-06-26 18:29:46 -0500 feat: New runed door tiles from Sastreii The old tiles used a light blue color for the runes that didn't contrast well with the blues used for clear doors. This set of tiles uses an orange color for runes that has better contrast. -------------------------------------------------------------------------------- 0fec994a2d | advil | 2022-06-26 13:15:32 -0700 fix: remove an unnecessary `fixup_skills` call This fixup is uniformly called on characters after they've loaded at the end of _post_init, and it's much safer to call it after loading anyways. So, remove the early call for the ranged merger fixup -- the _post_init call does accomplishes the same thing. -------------------------------------------------------------------------------- 365da2f8ac | Nicholas Feinberg | 2022-06-26 12:32:08 -0700 Fixup a gnoll save compat crash? Boy, this code is scary. -------------------------------------------------------------------------------- 6dac4ea423 | Nicholas Feinberg | 2022-06-25 22:41:36 -0700 Don't give old gnolls huge Ranged Weapons skill (CarefulOdds) oops -------------------------------------------------------------------------------- f28ee254f9 | Kate | 2022-06-25 21:48:00 +0100 Scale potion of attraction effect with time taken Fixes fast actions resulting in monsters being pulled more effectively with a potion of attraction active. -------------------------------------------------------------------------------- 7753eeab26 | Kate | 2022-06-25 21:48:00 +0100 Compress some bad mutations to 2 levels As with the other similar chance-based bad mutations (shoutitis and deterioration, and now also -Scroll and -Potion), reduce teleportitis and berserkitis to 2 levels, with the first level being equivalent to somewhere between the old levels 1 and 2, and the second level equivalent to the old level 3. -------------------------------------------------------------------------------- 769091470e | Nicholas Feinberg | 2022-06-25 13:24:45 -0700 Save ranged quiver actions Closes #2506. -------------------------------------------------------------------------------- 55bc7a5df9 | Nicholas Feinberg | 2022-06-25 12:34:16 -0700 Nerf walking crystal tomes HD 20 -> 15, crystal spear damage 3d40 -> 3d34. XP unchanged. -------------------------------------------------------------------------------- 7b5732409f | Nicholas Feinberg | 2022-06-25 12:17:12 -0700 Remove fustibaluses Fustibaluses were originally created as an upgrade for players using the Slings weapon skill. Now that all ranged weapons use one skill, players can easily upgrade from slings into bows or crossbows. There's nothing particularly resonant about fustibaluses thematically, and they don't fill any gap in the loot game not filled by other items, so there's no need to keep 'em around. If we want more ranged weapon types, it'd make more sense to add more exciting weapon types like the cho-ko-nu, composite bow or woomera. -------------------------------------------------------------------------------- e572f60725 | Nicholas Feinberg | 2022-06-25 12:15:51 -0700 Readjust ranged weapons' stats and distribution Shortbows and slings are more common. Longbows are now rarer and more common later. Hand crossbows tend to show up in Vaults, as an eveningstar-ish upgraded one-hander. Arbalests are shifted around. Triple crossbows are unchanged. -------------------------------------------------------------------------------- ef730cc156 | Nicholas Feinberg | 2022-06-25 12:15:50 -0700 Don't give hand crossbows out to kobolds They're being positioned as a later-game weapon. -------------------------------------------------------------------------------- 941941d4ec | Nicholas Feinberg | 2022-06-25 12:15:50 -0700 Make Punk a custom weapon type In preparation for fustibalus removal. -------------------------------------------------------------------------------- 1416de1b61 | Nicholas Feinberg | 2022-06-25 12:11:09 -0700 Remove hunting from slings I renamed 'slings' to 'hunting slings' in b938532f5e to avoid confusion with the name of the skill. Now that Slings skill is no more, we can go back to the shorter and punchier name. -------------------------------------------------------------------------------- 33dec36d26 | Nicholas Feinberg | 2022-06-25 12:11:09 -0700 Tweak titles Most of the old Bows titles work fine for Ranged Weapons, but 'Archer' isn't quite right for many weapons. Trade it out for Fighting's 'Skirmisher' title, and replace that one with 'Trooper'. -------------------------------------------------------------------------------- 586177b653 | Nicholas Feinberg | 2022-06-25 12:11:09 -0700 Merge ranged skills (ebering) DCSS's ranged weapon types aren't very well differentiated. Slings, bows, and crossbow games all tend to play very similarly - much moreso than different magic schools, and still more than different melee weapon types, like polearms and axes. We've spent quite a long time trying to differentiate the ranged weapons further. The main differences at present are fairly arbitrary differences in stats - damage, accuracy, speed, brands, generation frequency, handedness... there's quite a lot of them, but they don't add up to much interesting. Historically, ammo frequency was another difference along those lines - it had more impact, but (by encouraging fiddly weapon swapping) that impact was mostly negative. There are also quite few ranged weapons per skill. We have about half a dozen weapons for each melee weapon type, but there are only two or three per ranged weapon skill. (And that's after the last rework that added three more!) So, let's merge em. As one consolidated type, Ranged Weapons will have a better chance at earning their place in Crawl. Very few species had different apts for different ranged weapon types. most of those have been given their best apt for the new skill, or something reasonably close to it. The skill screen has been reorganized, which will be quite disorienting for some, but I think it does a better job of showing that 'Throwing' is quite a different type of skill from the Ranged Weapon skill. Other names I considered for the skill: - Launchers/Launching (unpleasant) - Missiles (futuristic) - Bows & Slings (what about xbows?) - Slings & Arrows (cute, but likewise) Ranged Weapons has history - Throwing used to be called this, long, long ago - so that gets some bonus callback points. A subsequent commit will adjust weapon stats and frequency. -------------------------------------------------------------------------------- 7c5339f103 | Nicholas Feinberg | 2022-06-25 12:11:09 -0700 Remove weapon choice for Hu/AM In preparation for merging ranged weapon skills. -------------------------------------------------------------------------------- a8f87797a9 | Nicholas Feinberg | 2022-06-25 12:07:39 -0700 Unify Xom reach cleave with lochaber axe Simplify the code by making all polearms work the same way under Xom's Cleave status as the Lochaber Axe does normally. -------------------------------------------------------------------------------- bdae368155 | Nicholas Feinberg | 2022-06-25 11:53:34 -0700 Two cool new tiles (Sastreii) Slime simulacrae and lochaber axe. -------------------------------------------------------------------------------- 60cadc97f0 | Goratrix | 2022-06-25 07:43:47 -0700 Stat mutation description adjustment Add spaces between the stat names and the numbers (to be consistent with all the other similar mutation descriptions) and change Int/Str to Str/Int for consistency with the order of the stats in the ui and elsewhere. -------------------------------------------------------------------------------- 5b5c5c9dfb | Kate | 2022-06-25 11:40:13 +0100 Fix conflicting vault-defined monster and item renames Both using the "name:" tag caused them to be incorrectly parsed, breaking monster renames. -------------------------------------------------------------------------------- 2f1814c7b2 | Nicholas Feinberg | 2022-06-24 21:54:03 -0700 Checkwhite -------------------------------------------------------------------------------- 1248423c9f | Nicholas Feinberg | 2022-06-24 21:23:22 -0700 Unrig big pig dig (buh) Don't let formicids dig via the quiver in forms that meld mandibles. -------------------------------------------------------------------------------- 3f287b9546 | Nicholas Feinberg | 2022-06-24 21:06:43 -0700 Remove scythes Scythes, as it stands, are something of a gag weapon. Their stats are ludicrously terrible - there are very few cases in which it's right to use a scythe. Gags are great! But it's not great to pull jokes on newer players, and it's not good to discourage new players from using that cool looking weapon they just got from scary ol' Sigmund. We could add some funky gimmick to scythes, but honestly, the polearm weapon progression already works quite well. Instead, let's turn scythes into a purely cosmetic item - a reskin for halberds. Sigmund and reapers can still have their iconic weapon, and players can actually use 'em if they so please. Win-win! Unrand scythes remain unchanged. -------------------------------------------------------------------------------- f0ca2457bd | Nicholas Feinberg | 2022-06-24 21:06:43 -0700 Remove scythes from vaults In preparation for full removal. -------------------------------------------------------------------------------- ff0870d9f4 | Nicholas Feinberg | 2022-06-24 21:06:43 -0700 Base unrand scythes off halberds In preparation for scythe removal. -------------------------------------------------------------------------------- ec28fa79f6 | Nicholas Feinberg | 2022-06-24 21:06:43 -0700 Make reapers & Sigmund wield renamed halberds In preparation for scythe removal. -------------------------------------------------------------------------------- 3702571b76 | Nicholas Feinberg | 2022-06-24 21:06:43 -0700 Remove support for shared-description item renames Not currently needed and a bit of a pain to get working fully. -------------------------------------------------------------------------------- f0e39d631f | Nicholas Feinberg | 2022-06-24 21:06:43 -0700 Give Crazy Yiuf his hammers back Retheme the maces as hammers. A little theme goes a long way. I considered re-adding hammers in some of the other places they were formerly used, eg the 'hammer & chisel' vault in Orc, but didn't feel excited about it. They can be special for Yiuf. -------------------------------------------------------------------------------- e866d9a976 | Nicholas Feinberg | 2022-06-24 21:06:43 -0700 Make item tile: and wtile: support variants For e.g. enchanted/randart weapons/armour. (Only weapons currently support variants for held tiles.) -------------------------------------------------------------------------------- 99da04ecca | Nicholas Feinberg | 2022-06-24 21:06:43 -0700 Support vault-defined item names/descs Time to get up to some big time nonsense. -------------------------------------------------------------------------------- 32ab5fea29 | Kate | 2022-06-24 21:55:44 +0100 Fix a Zot clock crash (#2567) By removing bezotting level 4 - it was supposed to only be reached at Zot clock zero, but due to how AUTs were rounded to display as turns, it was possible to reach while less than a full turn (0-9 AUT) remained. As a Meteoran with a scarf of shadows equipped, this allowed the player to reach 0 LOS and crash. Closes #2567. -------------------------------------------------------------------------------- e598fa6640 | Kate | 2022-06-24 21:46:54 +0100 Add some Zot clock messages to default force_more The new messages for being drained at 0 Zot clock, specifically. -------------------------------------------------------------------------------- 7eeb665c8c | Kate | 2022-06-24 14:38:24 +0100 Fix spelling -------------------------------------------------------------------------------- 98ab2a97b9 | Nikolai Lavsky | 2022-06-24 16:12:42 +0300 fix: let pieces from Xom's chessboard affect frenzied monsters Continuing with the removal of restrictions on attacking frenzied monsters, let the pieces affect insane enemies. -------------------------------------------------------------------------------- c3b6d67b95 | Nikolai Lavsky | 2022-06-24 16:12:24 +0300 fix: further fix grammar for artefact bardings with Regen There are two different attunement messages for items with Regen. The first one is displayed when a character puts on such item while at full health. When an injured character puts on an item with Regen and then reaches full health, the second message is printed. The first attunement message was fixed in 68df51542, and this commit fixes the second one. -------------------------------------------------------------------------------- 5f5fd466e5 | Nikolai Lavsky | 2022-06-24 16:11:46 +0300 fix: remove a stray function declaration The corresponding function definition was removed in 7ca12cd9. -------------------------------------------------------------------------------- 7e06a55bdf | Nikolai Lavsky | 2022-06-24 16:11:46 +0300 fix: don't crash when &s-ing a useless skill Training an unusable skill, like a magic school on a Dj or Invocations on a Dg, via the &s command crashes the game. Training a sacrificed skill doesn't crash the game, but has no effect, so let's disable it as well. -------------------------------------------------------------------------------- e04d5b83ea | Nikolai Lavsky | 2022-06-24 16:11:46 +0300 feat: show current skill level in &s This commit reduces the need to use the `m` menu while experimenting with the skills in wiz-mode. Also, it fixes the messaging. For example, when Fighting is changed 10.5 -> 10, the message will be "Lowered Fighting to skill level 10.0." instead of "Reset Fighting to skill level 10.0." -------------------------------------------------------------------------------- ba467f2e49 | Edgar A. Bering IV | 2022-06-24 08:09:59 -0500 docs: update CREDITS.txt -------------------------------------------------------------------------------- 0d03ebdc04 | Rytis Petronis | 2022-06-24 08:07:08 -0500 feat: make -Scroll and -Potion regular 2-tier bad mutations Two tiers are added to both MUT_READ_SAFETY and MUT_DRINK_SAFETY mutations to make it more in line with the other bad mutations, and the latter is added to the general bad mutation pool. To make the 2 tiers work correctly the _is_damage_threatening function has an added variable to decide on the safety level with which to evaluate the threat. Ru's sacrifice now sets the mutation at tier 2, which is the same severity as before this commit. This commit also adjusts the weight of both mutations to 7 (average) from 10 (most common). [ Committer's note: Squashed, rebased, checked whitespace. Closes #2573 ] -------------------------------------------------------------------------------- b80629599b | 4Hooves2Appendages | 2022-06-24 07:21:45 -0500 feat: give arachnids 'skitter' shouts This commit creates two new shout types: 1) S_SKITTER, for medium and larger many-legged monsters, normal noise. 2) S_FAINT_SKITTER, for little and small many-legged monsters, quiet noise level. For a variety of arachnids and insects, replaces S_HISS with new shouts. [ Committer's note: Fixed whitespace, made faint skitters quiet, kept Pharaoh Ants as S_MOAN: it's louder so it helps bring more spiders for their gimmick. Closes #2575 ] -------------------------------------------------------------------------------- 626dbc2b52 | Edgar A. Bering IV | 2022-06-24 07:08:05 -0500 feat: restore the nearby altar for AK start flavour -------------------------------------------------------------------------------- b66ea993e3 | Spencer Baugh | 2022-06-24 15:03:44 +0300 feat: make AK start standing on exit It's basically a spoiler that an exit always generates near the AK starting spawn. If the player doesn't know that, they'll waste a fair bit of piety using Depart the Abyss. That could be fine, except that now that means their starting escape mechanism, Bend Space, will be offline for the first few levels of the Dungeon, defeating the purpose of bumping AK piety to make it available. We could make the exit just generate in LOS, but there's nothing really tactically interesting about walking a few squares and maybe getting very unlucky, so just have AK start out standing on the exit. -------------------------------------------------------------------------------- 5c1d49f3b4 | Edgar A. Bering IV | 2022-06-24 07:00:08 -0500 fix: take proper note of banishment depth (Goratrix) -------------------------------------------------------------------------------- a64570c9d2 | Nikolai Lavsky | 2022-06-24 04:47:12 +0300 fix: tweak teleportitis-related messaging and status display This commit fixes two issues with teleportitis messaging and status display: * although teleportitis is suppressed in the Abyss since db80c5092, the ``%`` screen shows ``Rnd*Tele`` there; * after 6b4f085fc, ``stairs.cc:_gauntlet_effect()`` doesn't print "You feel stable on this floor." for players with teleportitis, since ``player.cc:player_teleport()`` always returns ``0`` when the player is in the Gauntlet. Currently, ``spl-transloc.cc:_teleport_player()`` has code for preventing teleportitis while in the Abyss. Adding an extra check into ``player_teleport()`` allows aborting such teleports a couple function calls earlier, in ``player-reacts.cc:player_reacts()``. Also, let's give ``int player_teleport()`` a more descriptive name. -------------------------------------------------------------------------------- e176fc164b | Nikolai Lavsky | 2022-06-24 04:47:12 +0300 fix: mark teleportitis as suppressed in more cases Currently, the mutations screen displays this mutation as suppressed only when the player is in tree form. This commit marks the mutation as inactive when all teleports are forbidden or while the player is in the Abyss. -------------------------------------------------------------------------------- 5f01ad7185 | robertxgray | 2022-06-23 20:44:11 -0500 Quote for Gozag's altar Francisco de Quevedo, _Poderoso caballero es don Dinero_. 1603. -------------------------------------------------------------------------------- 85323850a6 | nlavsky | 2022-06-23 20:42:12 -0500 fix: apply item_slot when seeing monsters use unid'd scrolls or potions When a monster uses a scroll or potion, it identifies the consumable and applies autoinscriptions. But unlike other methods of item identification, it didn't change inventory letters according to the ``item_slot`` option. -------------------------------------------------------------------------------- 859816b266 | Nicholas Feinberg | 2022-06-23 17:24:58 -0700 Fix (?) throwing damage rates (Lici) This isn't a great display - it'd be really nice to clarify where the extra base damage is coming from. Oh well! -------------------------------------------------------------------------------- 87332871fa | Nicholas Feinberg | 2022-06-23 17:09:14 -0700 Don't crash when a dead monster cleaves E.g. if they're killed by minotaur retaliation midway through an axe swing. Broken in 437f8d1d3d7ac52eafa3a8e7bdbfce506b4eac7f. -------------------------------------------------------------------------------- 5ff2a30383 | Edgar A. Bering IV | 2022-06-23 06:59:30 -0500 fix: cap all beam wand charges for Wn start (acrobat) -------------------------------------------------------------------------------- c25378c239 | gammafunk | 2022-06-23 01:38:29 -0500 fix: Correct a mutation description (acrboat) For Sacrifice Experience, we now only lower XL by one each time, so reflect this on the mutation screen. Also mention this change in the changelog. -------------------------------------------------------------------------------- 12ee2bf84d | Nicholas Feinberg | 2022-06-22 21:37:15 -0700 Unbrace -------------------------------------------------------------------------------- 1aa759944b | Nicholas Feinberg | 2022-06-22 19:25:25 -0700 Allow banished monsters to appear after Abyss:1 (acrobat) Previously, there was an oversight (?) in which banished monsters would only ever appear on Abyss:1. Make them follow you through the whole Abyss instead. This is a little silly (are they taking the stairs down?!), but prevents you from losing the Royal Jelly on a lower Abyss level, for example. -------------------------------------------------------------------------------- 26d293caef | Nicholas Feinberg | 2022-06-22 11:50:49 -0700 Ramp up deep Abyss spawn rates Make many more monsters spawn on Abyss:6 and :7, and give em a chance to spawn near the player. (This is a hacky breakpoint.) -------------------------------------------------------------------------------- dd63cfa21d | Nicholas Feinberg | 2022-06-22 11:27:04 -0700 Add some truly stellar new tiles (Sastreii) New runelight tiles, to make it clearer when the player is near the abyssal rune (or perhaps other ones someday?) -------------------------------------------------------------------------------- ff9cad4a3d | gammafunk | 2022-06-21 23:37:40 -0500 fix: Place Grunn with his band (dilly) We need the "band" mon spec designator in the uniq_grunn vault, otherwise Grunn places without any rare puppers. -------------------------------------------------------------------------------- be5fe9cee2 | Nicholas Feinberg | 2022-06-21 18:09:47 -0700 New small abomination tiles (Sastreii) Eww, gross! These might not be small enough. We'll see. -------------------------------------------------------------------------------- 910882235c | Kate | 2022-06-21 23:37:41 +0100 Increase chances of a Jiyva altar at Slime entry Previously there were a small fixed number of Slime entry vaults that always placed a Jiyva altar, with their total weight resulting in roughly a 1/2 chance to see one in any given game. Instead let all Slime entries place Jiyva altars, with a 2/3 chance. -------------------------------------------------------------------------------- d0a8d1b88b | Kate | 2022-06-21 23:37:41 +0100 Rebrace -------------------------------------------------------------------------------- 25bf049393 | Kate | 2022-06-21 23:37:41 +0100 Don't let Irradiate affect conjured monsters (CarefulOdds) -------------------------------------------------------------------------------- 28b9d68c38 | wheals | 2022-06-22 00:36:07 +0300 fix: really don't generate rare temples outside the 1% chance -------------------------------------------------------------------------------- 94431d12f0 | Edgar A. Bering IV | 2022-06-21 22:38:04 +0300 feat: don't generate rare temples as a part of normal generation Only pick them for their tag. -------------------------------------------------------------------------------- 7553cd0caa | Edgar A. Bering IV | 2022-06-21 20:53:51 +0300 feat: select the size of the Temple in C++ Temple size has a major impact on god selection: a big Temple means getting your choice god-but it might take until D:7. A small temple scatters the gods over the overflow range. Both experiences are good for the game, but before this commit the chance of a given temple size was controlled by the sundry weights of the different temple maps. This control was brittle, and indeed b444dcf96dcc4 marked a big shift in the prevalence of larger temples (thanks to acrobat for pointing out how large this impact was), that was not intended. This commit changes temple selection to work as follows: First a 1% roll decides to select a rare temple. Current rare temples are the Lugonu, Jiyva, and Ignis temples. Rare temples are those that should create special moments outside of the usual temple system. Failing the 1% roll, the temple size is rolled. Currently this is 9 + random2avg(13,2), but this can be adjusted (and will be to accomodate some smaller temples coming in subsequent commits). -------------------------------------------------------------------------------- 1ace0e5f75 | patrick | 2022-06-21 12:23:09 -0400 Change mountain boots' name back to mountain boots Painting the bike shed one final time. This reverts the commit where I changed it. -------------------------------------------------------------------------------- 4e50b17284 | Edgar A. Bering IV | 2022-06-21 13:32:33 +0300 fix: a crash and a check -------------------------------------------------------------------------------- 1c8a42db57 | Edgar A. Bering IV | 2022-06-21 09:56:56 +0300 docs: changelog through 0.29-a0-653-gd47aff6735 -------------------------------------------------------------------------------- d47aff6735 | Nicholas Feinberg | 2022-06-20 22:32:40 -0700 Remove a probably unused function? As far as I can tell, the "item()" function is *only* used in Volcanoes, and it is *not* used in the slot-setting mode. Don't believe it was documented, either. If this breaks stuff, please revert this. -------------------------------------------------------------------------------- 45357cb20f | Nicholas Feinberg | 2022-06-20 22:25:19 -0700 Fix item exclusion for shops Shops with excluded items would hold an empty list (treated as 'any item') instead. -------------------------------------------------------------------------------- 437f8d1d3d | patrick | 2022-06-20 22:00:43 -0700 Add a new unrand: the lochaber axe Long long ago, bardiches used to be known as lochaber axes, until they were renamed in commit 8b14a9, on December 13, 2007, presumably so that players wouldn't think they were some kind of axe. The lochaber axe was gone... but not forgotten... It's back, reimplemented as an unrand, and this time, there's no problem if players think it's some kind of axe. Because it is. The lochaber axe has both reach and cleaving, and combines them both into a sort of "super-cleave", aka "reave", which attacks everybody in a radius of 2 with each swing. Additionally, due to its nature as a combination of polearm and axe, either skill can be used to wield it -- the higher of your Polearms or Axes skill will be used to determine its damage and delay. Currently, it's statted out as a +5 bardiche with -1 to base accuracy and +1 to base damage and base delay. Currently uses the old tile for lochaber axes, although it will probably need something more menacing before it's ready for prime-time. Much thanks to PleasingFungus for coding assistance, and gammafunk for discussions, the lochaber axe tile, and not immediately reverting this. -------------------------------------------------------------------------------- 8101c4d66a | patrick | 2022-06-20 22:36:36 -0400 Make some cosmetic changes to the mountain boots Now they're the boots of the Mountain, and their effect is renamed from the descriptive-but-not-super-flavorful "rDislodge" to the somewhat-more-flavorful "steadfast". Also the description of the effect is clarified somewhat more precisely. thank you for your time. love, nicolae -------------------------------------------------------------------------------- 45c230d69a | hellmonk3 | 2022-06-20 15:55:43 -0400 feat: New Orc ending (#2454) Salted Orc, if you will. -------------------------------------------------------------------------------- 6b26cc9f40 | advil | 2022-06-19 12:16:09 -0700 fix: generalize a bit of abyss rune code I think this change will also fix another case of odd messaging after getting the rune, on leaving the abyss. -------------------------------------------------------------------------------- b07f931dc7 | Nicholas Feinberg | 2022-06-19 11:41:38 -0700 Remove the old ct_skills array Unused since 7c1a5597fd584d (2014). -------------------------------------------------------------------------------- da25f7726e | Nicholas Feinberg | 2022-06-19 11:33:12 -0700 Fix a misleading rune message -------------------------------------------------------------------------------- e8efa2268b | Nicholas Feinberg | 2022-06-19 11:27:33 -0700 Don't show item hints for corpses in tiles It's a bit silly to tell people to mess around with a purely decorative object - quite confusing. -------------------------------------------------------------------------------- 0428525265 | Nicholas Feinberg | 2022-06-19 11:19:15 -0700 Grunn tile (Sastreii) Unique's is back baby. It's good again. Awoouu (wolf Howl) -------------------------------------------------------------------------------- a013cefcf8 | Nicholas Feinberg | 2022-06-18 22:38:41 -0700 Remove obsolete code for throwing hunters -------------------------------------------------------------------------------- 3454511d3d | neo-bop | 2022-06-19 08:35:50 +0300 docs: fixed grammar mistake -------------------------------------------------------------------------------- b59bef153c | Nicholas Feinberg | 2022-06-19 08:31:14 +0300 text: add Grunn dialogue Rough pass, a mix of Grum-isms plus some kvetching about being a lil bit dead. Also, in Hell. [ Closes #2459 ] -------------------------------------------------------------------------------- d0c25b80c2 | hellmonk | 2022-06-19 08:31:08 +0300 feat: Grunn the Punished Alt-timeline version of Grum who has a pack of doom hounds. Appears in Depths, Crypt, and Zot. -------------------------------------------------------------------------------- 29a8cdef9d | RojjaCebolla | 2022-06-19 08:19:07 +0300 fix: undefined local entry '_ashenzari_heavens_' It was only missing one % symbol. [ Closes #2431 ] -------------------------------------------------------------------------------- e81f215762 | RojjaCebolla | 2022-06-19 08:19:01 +0300 fix: no godspeak entry for 'Xom zero miscast effect' -------------------------------------------------------------------------------- ff17717bc1 | RojjaCebolla | 2022-06-19 08:18:51 +0300 text: remove quote db entries for deprecated items -------------------------------------------------------------------------------- de4a49754e | RojjaCebolla | 2022-06-19 08:18:46 +0300 text: add a description for the spriggan hatter -------------------------------------------------------------------------------- c2a2f2613b | Nicholas Feinberg | 2022-06-18 21:20:36 -0700 Don't cover the entire Abyss with exits ...once you get the rune. ??doh -------------------------------------------------------------------------------- 155753f734 | Nicholas Feinberg | 2022-06-18 21:20:21 -0700 Don't erode runelights They're important for finding runes! -------------------------------------------------------------------------------- 6e2bebc5d0 | Nicholas Feinberg | 2022-06-18 16:07:40 -0700 Make Abyss seven levels deep Attempt to make the Abyss sufficiently spooky to make 15-rune players worried about spending much time at the bottom. Megaziggers will probably have no issues, but that's fine. Might want to adjust spawn rates and/or spawn tables further - these are a big mess. -------------------------------------------------------------------------------- 781b4ac09e | Edgar A. Bering IV | 2022-06-19 00:34:14 +0300 feat: force a minimum entry depth on the Abyss In lieu of the previous anti-scumming mechanism, which threw the baby out with the bathwater and created an unpleasant experience with a lot of special cases, this introduces a minimum depth mechanic for the abyss. Upon entry from any source (distortion, banishment, exiting pandemonium through the abyss, entering an abyss portal) the player is sent to the highest depth so far achieved. In combination with the rune-guide improvements, a continued dearth of items, and the XL scaled depth-increasing-on-teleport mechanic, this should give a better experience to the recently punished mid-game banishment victim and the 3rd rune hunter, while still dissuading the scummer (who will rapidly find themselves on A:5) than the no-xp abyss did. If A:5 is not harsh enough to be a deterrant we can add greater depths as needed. -------------------------------------------------------------------------------- ae2251da70 | advil | 2022-06-19 00:34:14 +0300 fix: messaging for leaving and missing the abyssal rune This prop needs to be reset so that the messaging when reentering the abyss is correct, and we might as well indicate that the player missed out. [ Closes #2572 ] -------------------------------------------------------------------------------- 8e0c6649c8 | advil | 2022-06-19 00:22:02 +0300 fix: rewrite abyssal rune detection The first pass implementation relied on being able to store rune memory purely in map_knowledge, and use this at various points in time to detect both rune generation and removal. The abyss code makes this impractical. The rewritten version stores rune memory in a player prop that gets synced with map_knowledge; this is much more robust in my testing. -------------------------------------------------------------------------------- d66da3e29f | advil | 2022-06-19 00:22:02 +0300 feat: abyssal rune detection In newabyss players want to get in and out of the abyss as quickly as possible, but there's a lot of variation in how quickly people find the run, and it can really drag on with no rewards if this doesn't happen quickly. When you're at a rune depth, there's not a lot you can do to find the rune beyond just wandering and/or looking for vaults via giveaway tiles (these could be removed if this current commit goes forward). This commit implements an idea where all players detect the presence and map location of the abyssal rune, and also detect if the map shifts and it vanishes. This gives players a much more concrete goal, as long as the rune has generated. I am still not entirely sure if this is a good idea, but in my testing it works way better than I expected. The rune typically generates pretty far from you and then you have a bit of a race towards it, both (a) simply navigating the abyss between you and it, and (b) figuring out how to even get into the vault. I'd theorycrafted this as making it too easy to find the rune, but I'm not sure it (typically) is at all. But, it probably needs more playtesting. Also, by the nature of abyss code, I am at best medium sure that I added this hook in all the places that it needs to be in. -------------------------------------------------------------------------------- ba36221789 | Edgar A. Bering IV | 2022-06-19 00:22:02 +0300 revert: unrewarding abyss This reverts most of the "no-XP" abyss changes, specifically: fcf54068 feat: prevent gaining experience in the Abyss d764ef0d feat: give an XP reward for the abyssal rune 010f2a22 feat: don't grant piety in the Abyss 0647d936 Refactor piety gain prevention in the Abyss 6c1bee59 feat: reduce wretched star malmutation rate 050a5067 fix: turn down wretched stars corrupting pulse a bit more The no XP abyss did stop abyss scumming, but at too great a cost. While some players enjoyed the stealth-emphasis-increase of the XP being concentrated in the rune, the overall result wasn't good. So this reverts the changes that revolve around XP, in preparation for the following commits. Not reverted are: - the changes to exit and stair spawn rates. These remain increased, in anticipation of the subsequent anti-scum mechanic making them desireable. - the removal of items outside of vaults. Items still have the potential to be a grind-trap (more a trap than "optimal" scumming), but the abyss isn't supposed to be a place players want to linger so let's not give them too many reasons to stay beyond a rune. -------------------------------------------------------------------------------- 39ea5eca17 | Nicholas Feinberg | 2022-06-18 13:14:11 -0700 Despoiler the Abyss rune (mostly) Replace external uses of the secret 'abyss rune tile' with a new 'runelight' feature, which stops autoexplore and is explicitly described as indicating the presence of a nearby rune. Possible that some or all of the internal tiles in these vaults should also be replaced with runelights, for those with dungeon mapping mutations or similar. Art is placeholder. -------------------------------------------------------------------------------- 7f7ec87276 | Edgar A. Bering IV | 2022-06-18 22:48:14 +0300 text: clarify battlesphere's description -------------------------------------------------------------------------------- a996378906 | Edgar A. Bering IV | 2022-06-18 17:28:42 +0300 fix: idiomatic randomness (PleasingFungus) -------------------------------------------------------------------------------- 39d4558d33 | Edgar A. Bering IV | 2022-06-18 16:54:40 +0300 refactor: remove dead quantity code for launcher ammo -------------------------------------------------------------------------------- 14c03f4a0f | Edgar A. Bering IV | 2022-06-18 16:54:14 +0300 feat: reduce stone availability and make them always mulch Stones are very good on D:1-2, and while they quickly fall off remain useful for characters for a bit longer, or as a "poke the monster quietly before walking away to pull a small number of foes" tool. They're also all over the dungeon in massive numbers, and are re-usable to boot. Now that they're not used for Sandblast, their primary gameplay function is early game plinking. To make this plinking a bit more interesting this commit reduces the supply of stones in each pile, and makes stones always mulch when used. In the very early game this should put significant pressure on the use of stones in an interesting way, with them becoming plentiful closer to the time the player has better things to do than plink away. -------------------------------------------------------------------------------- 8217bd198b | Edgar A. Bering IV | 2022-06-18 16:29:11 +0300 feat: damage ratings for thrown items -------------------------------------------------------------------------------- e4689427c4 | Edgar A. Bering IV | 2022-06-18 09:48:43 +0300 fix: remove a stray random altar from overflow range -------------------------------------------------------------------------------- 13ace881f2 | patrick | 2022-06-17 11:09:41 -0400 Let randart bardings generate with rPois The code prevented randart bardings from generating with properties that were already innate to barding wearers. At the time, this was just nagas, and nagas already have rPois and SInv. Now palentongas can wear bardings, and they lack rPois, so now it makes sense for randart bardings to be able to generate with rPois. Since nagas and palentongas both have innate SInv, SInv is still excluded from the properties randart bardings can have. -------------------------------------------------------------------------------- d6e8e0e227 | Edgar A. Bering IV | 2022-06-17 16:15:19 +0300 feat: re-vitalize Vitality Regeneration and 15 hit points aren't much. Vitality has been on the "to redesign" list for a long time. Some of the possibilities discussed are very close to what ultimately became the dreamshard amulet. It was also suggested, and discarded, as a possible early-game unrand. Let's buff it out of this awkward place. The 15 hp are traded for two pips of MP regen and an additional hp regen pip. Lore has it the amulet kept Borgnjor alive in her final days before descending into undeath, so it's also now evil. -------------------------------------------------------------------------------- 2e310f0204 | Edgar A. Bering IV | 2022-06-17 14:12:33 +0300 text: remove a randart name with an unpleasant connotation -------------------------------------------------------------------------------- 7a6b98fccd | Nicholas Feinberg | 2022-06-16 20:16:32 -0700 Adjust Ru mutations (acrobat) After the change to make Sacrifice Experience properly affect your current XL in c127bba4f6dc8, Sacrifice Experience was comparatively underpriced. It had a considerably more negative effect on the player across the board than the Frailty sacrifice, but gave only 40 piety to Frailty's 45! Rather than set experience to its proper value, which would have to be very high (perhaps ~60 piety?), instead cut its effect in half and sacrifice one level per sacrifice. (This has the additional advantage of simplicity.) Then make the following adjustments: - Experience: 40 -> 35 piety - Frail: 45 -> 35 piety (compare Sacrifice Love at 40) - Weak-Willed: 38 -> 35 piety (for neatness) - Eye: 20 -> 25 piety (think this was undervalued) I don't think any of these will make a dramatic impact on the Ru experience, but they should make things very slightly tidier overall. -------------------------------------------------------------------------------- c53de2f800 | Nicholas Feinberg | 2022-06-16 19:43:03 -0700 Add a rock-solid new artefact tile (Sastreii) Mountain boots get their own tile. Bye (again), boots of the spider. Player doll doesn't match, but that's not a big deal. -------------------------------------------------------------------------------- deedd76f10 | Nicholas Feinberg | 2022-06-16 12:49:37 -0700 Fix ignis wrath + mountain boots (nicolae) -------------------------------------------------------------------------------- 2001307d0b | advil | 2022-06-16 09:27:48 -0400 fix: remove pakellas 's color -------------------------------------------------------------------------------- f2c431b9b9 | patrick | 2022-06-15 21:42:22 -0700 Add a new unrand, the +3 mountain boots {rDislodge, rC+} Gives dislodge resistance, keeping the player from being moved by external non-translocation sources. (Trampling, shafts, tentacles, etc.) Currently uses the tiles for the spider boots, which weren't being used anyway, but will probably need actual tiles at some point. -------------------------------------------------------------------------------- b8e136fc6a | Nicholas Feinberg | 2022-06-15 17:31:43 -0700 Double Airstrike's empty space bonus To encourage more tactical and positional thinking, make Airstrike somewhat better against enemies in open areas and worse against enemies not surrounded by open space. Sometimes it'll be the right spell to use, sometimes you'll want to reposition or use another tool from your toolbox. -------------------------------------------------------------------------------- 91acacb2e3 | gammafunk | 2022-06-15 18:07:51 -0500 fix: A teleport closet (riverfiend) In nicolae_swamp_secret_spriggan_hideout, a wall could sometimes place and seal off an area. -------------------------------------------------------------------------------- 99610632ab | Kate | 2022-06-15 23:50:13 +0100 Remove Kiku's undead duplication passive In practice, the changes to necromancy spells making them easier to make use of (in addition to them interacting more favourably with Unearth Wretches) make Kiku fairly strong already. Duplicating undead on top of that resulted in excessively huge hordes being a little too easy to create. This reverts commit 2fcf5398dde68d34f8f1d11118976734faf3d690. -------------------------------------------------------------------------------- b56f46d856 | advil | 2022-06-15 15:51:10 -0400 fix: attitude check for poisonous vapours disabling Previously this would appear to be enabled with susceptible allies in view. It was oddly hard to see what the exact right way to implement this is, but wont_attack is what some other spells in this code use, so it should do for now. -------------------------------------------------------------------------------- 5f3c444be0 | Edgar A. Bering IV | 2022-06-15 21:57:46 +0300 feat: make animated armour fly For consistency with dancing weapons and the notion of "spirit", as well as removing a gameplay synergy with Leda's, let's make these buddies fly about. -------------------------------------------------------------------------------- ed4851bcc5 | Nicholas Feinberg | 2022-06-15 10:21:38 -0700 Fix stat mut descs (Goratrix) -------------------------------------------------------------------------------- ddeeb70f77 | Nicholas Feinberg | 2022-06-15 09:39:44 -0700 Pull out zot.cc from timed-effects.cc More than enough stuff to deserve its own file. -------------------------------------------------------------------------------- 6a3c3ed53f | Nicholas Feinberg | 2022-06-15 09:28:23 -0700 Make positive stat muts more impactful (various) The "str +2" etc muts are reasonably helpful, but don't meaningfully impact playstyle or player decisions. Let's make them more impactful by making each one give +4 to the primary stat and -1 to the other stats, enough to shift the player towards that stat in a very serious way. Since each mut only has two levels, it seems like it'll be quite rare for those -1 stats to cause stat zeroes. Theming/naming could use another pass. -------------------------------------------------------------------------------- 3118c4fcd2 | Nicholas Feinberg | 2022-06-15 09:28:23 -0700 Apply monster wand damage nerfs more generally To somewhat reduce the classic "instantly melted by ijyb with a wand of acid" scenario, instead of special-casing Mindburst specifically, make all monsters do 2/3rds damage with all wands. This is a brutal nerf to /flame monsters. -------------------------------------------------------------------------------- f530d57ad0 | Nicholas Feinberg | 2022-06-15 09:28:23 -0700 Update fo mut desc For giant clubs. -------------------------------------------------------------------------------- b1b9a4145c | Nicholas Feinberg | 2022-06-15 09:28:23 -0700 Don't force /para in hellmonk_paralyzer -------------------------------------------------------------------------------- 800f0a2745 | Nicholas Feinberg | 2022-06-15 09:28:23 -0700 Remove Ar wand printing code No longer relevant, now that ar start wands aren't randomized with item sets. -------------------------------------------------------------------------------- c0164372c5 | Edgar A. Bering IV | 2022-06-15 19:26:28 +0300 feat: move timed hell effects to level arrival Timed hell effects were intended to punish lingering and encourage taking on the Hells "all in one go". The XP gated, but time-applied nature of them meant that even traversing a larg end level could be needlessly punishing. After several attempts at turning tuning knobs, they're still not in a great place, and push players to stair-dance, do a hell partially then go to Pan for a bit, etc. This commit moves the effects to apply on each level descent. Players doing the hells "all in one go" preferring to dive over fight won't get hit too badly, (just enough for some seasoning), but stair dancing to clear a tough encompass part way through will meet stiff penalty. Branch-wide conducts are unchanged. The numbers will probably need some further tuning to get them "just right" in the tension-versus-too-punishing department, but let's start with these. -------------------------------------------------------------------------------- 1680f32a72 | Nicholas Feinberg | 2022-06-15 07:07:10 -0700 Don't overexaggerate hand-pairs (wheals) Overcorrection. -------------------------------------------------------------------------------- d8304a5bf4 | Nicholas Feinberg | 2022-06-14 22:34:29 -0700 Let formicids wield giant clubs again Reverts 9a20582491d1. At the time, giant clubs were thought to be so strong that formcids would be unmotivated to use their shield gimmick. Today, that seems less likely. -------------------------------------------------------------------------------- 69c401ce25 | Nicholas Feinberg | 2022-06-14 20:18:34 -0700 Fix the build? -------------------------------------------------------------------------------- 57363d2029 | Nicholas Feinberg | 2022-06-14 19:27:36 -0700 Pull mindburst out of the hex set I've been persuaded for now that it's sufficiently distinct from para/charming. We might change this later. -------------------------------------------------------------------------------- 3bc56fe6af | Nicholas Feinberg | 2022-06-14 19:27:34 -0700 New wand tiles (Sastreii) -------------------------------------------------------------------------------- c4eff49456 | Nicholas Feinberg | 2022-06-14 19:27:34 -0700 Relax the no-excluded-items policy. To avoid startscumming, have artificer go back to always having a wand of charming, regardless of which hex wand will spawn for the rest of the game. Also let hellmonk's paralyzer always spawn a para wand, as a meme. -------------------------------------------------------------------------------- 5a9699462f | Nicholas Feinberg | 2022-06-14 19:27:32 -0700 New item: wand of quicksilver (ebering) An alternate for the wand of acid, wands of quicksilver shoot dispelling bolts. They do slightly more damage than /acid, with a perhaps slightly less broadly applicable affect. You can also zap yourself, if you like pain! (I'm hoping self-zapping isn't *too* strong. It doesn't help with contam, fwiw.) -------------------------------------------------------------------------------- 376ae5a38f | Nicholas Feinberg | 2022-06-14 19:27:31 -0700 Add 'any beam wand' shorthand -------------------------------------------------------------------------------- 4f8b61c030 | Nicholas Feinberg | 2022-06-14 19:27:31 -0700 Make wands of light alternate with acid wands Half of games will have one, half will have the other. -------------------------------------------------------------------------------- 48b2cc46b9 | Nicholas Feinberg | 2022-06-14 19:26:47 -0700 New item: wand of light Intended as an alternate for wands of acid, wands of light fire a beam that blinds targets for a duration dependent on HD. The beam checks AC and EV normally, but no resists. It's otherwise identical to acid. If it hits a player, it has a 1/3 chance of confusing them for 2-3 turns. (Since players can't be blinded.) The goal is that this has a broadly similar use case to acid (high damage beam that ignores most resists & applies a debilitating effect), but plays somewhat differently. It'll be more useful for stabbers, and somewhat helpful defensively (by reducing enemy accuracy instead of AC). I'm very undecided on the blinding effect duration. Buff wand of light -------------------------------------------------------------------------------- c28e0ee30e | Nicholas Feinberg | 2022-06-14 19:26:14 -0700 New feature: item sets One of the most exciting things is adding new features: items, monsters, etc. However, the problem with items is that each distinct item type fills up an inventory slot. This is both a UI burden and a decision-making issue: it's possible to give out too many options, leading to analysis paralysis or most players simply ignoring most of what they have. So, here's an alternate approach. Pull wands of mindburst, paralysis, and charming into an 'item' set, and make the game only spawn one of the three types in any given game. Artificer starts with whatever is chosen. (This hopefully won't lead to startscumming.) Item specs (i.e. vaults) automatically exclude the wands which *weren't* chosen from the set, and I did some tweaks to make sure that all vaults should still work. Wand generation weights are tweaked slightly - the combined slot is slightly less common than mindburst plus para plus charm were together. (NOTE: A later commit will pull mindburst back out of the item set, leaving only charming + paralysis to alternate.) I have high hopes for this design technology. We'll see how it plays! -------------------------------------------------------------------------------- 1f97f7987d | Nicholas Feinberg | 2022-06-14 18:28:00 -0700 Let parghit throw ruk (dilly) What silly code! -------------------------------------------------------------------------------- 3e51bf9b82 | Nicholas Feinberg | 2022-06-14 18:24:28 -0700 Don't injury bond ioods (riverfiend) And do some code cleanup while I'm here. -------------------------------------------------------------------------------- 53e7fda734 | Edgar A. Bering IV | 2022-06-15 01:13:45 +0300 vaults: new demonic serial vault Encountering "common demons" at a time when they're a threat and not summons is a rare occurance in crawl. This serial vault, a shameless ripoff of serial_undead, places some demonic themed decor on a dungeon level to give it a "demonic feel". Spooky. Featuring demonic trees and plants, plus 5, 4, and 3 tier demons. -------------------------------------------------------------------------------- 58cc3432a3 | Edgar A. Bering IV | 2022-06-15 01:13:45 +0300 vaults: adjust serial_undead to modern D spawn tables -------------------------------------------------------------------------------- b10a8bf730 | advil | 2022-06-14 17:33:08 -0400 feat: indicate zot clock death risk in status light This might be overkill, since I think the likelihood of a player drained this much actually dying of the zot clock itself is rather low, but it seems useful to try out. In the end, rather than fancy punctuation, I simply added ", death" if the next zot clock 0 would kill. The color tweaks here bring this in line with the overview screen, though in contrast to there, the color is always stepped up if the player is drained enough to be risking death. (If `always_show_zot` is off though, for non-meteorae, clocks >=1000 turns are still not shown, though.) I also tweaked magenta->lightmagenta mainly for the sake of webtiles where regular magenta looks a bit dull (possibly just my badly calibrated monitor). -------------------------------------------------------------------------------- ed30ed24e1 | advil | 2022-06-14 17:32:48 -0400 feat: add zot clock to dungeon overview This displays in both the dungeon overview popup, and in morgues. Whether it displays follows the usual rules for showing the zot clock: it is forced by always_show_zot or meteorae, and otherwise only shows info if the bezotting level is >0. This also clearly indicates when the player is in death range as well as which branches they need to watch out for. Unfortunately, though I tried very hard, I just could not get this info into a three-column display. (I tried both inline approaches, and two-row branch displays; the former doesn't have enough space, and the latter looked quite bad.) Therefore, if any zot clocks are shown, it flips to a two-column display. Possibly confusing? I should also note that there are enough special cases here that I really doubt I got all the spacing to look right in all cases (as much as I did try to generalize the code for this a bit). -------------------------------------------------------------------------------- e82337ba6a | Nicholas Feinberg | 2022-06-13 21:38:19 -0700 Fix batty monsters + Mark (dilly) Don't make Mark turn batty monsters into unstoppable killing machines. This has been broken since 7f122b9c1a7 (2013), when Vault Sentinels and hence Mark were first added. -------------------------------------------------------------------------------- e9a90b782e | advil | 2022-06-13 17:15:01 -0400 fix: reword autofire message with mp 0 When autofiring an mp-using quivered action with mp 0, this still somewhat confusingly gave the "reckless" message. Just give an out-of-MP message. Also, reword a use of "mana" to "magic", afaik "mana" is not canon outside of some function names. -------------------------------------------------------------------------------- 113927532b | advil | 2022-06-13 16:46:26 -0400 feat: explore_wall_bias tweaks * don't consider just cardinal directions in checking for adjacent walls. (Fair warning, I don't know why it originally did this, so this change could be breaking something?) * let explore_wall_bias be negative, to prioritize open space. I should add that the use case of this option remains somewhat theoretical. There seems to be some historical idea that setting this to positive values would speed up eploration, but in my testing this is really far from correct: it adds sometimes 100s of turns to exploring a level, because it can drastically increase the amount of backtracking. Similar for negative values. It *might* be useful for meteorans as it possibly deprioritizes things they don't want to explore anyways, but the total explore time if you do a full explore is definitely still increased. In my testing for negative values what tends to get deprioritized are corners and corridors, which is what I was hoping for. But it's hard to say anything conclusive about whether this would be an improvement.. -------------------------------------------------------------------------------- 1de43cadea | advil | 2022-06-13 09:46:39 -0400 fix: float issue for webtiles pgdn / last menu item calculations After the new pgdn code from c0181ea820b1, in some cases the last menu item was not being calculated correctly because of minute (~ 0.1) overlap of the last menu item with the footer, I assume because of floating point inaccuracy. This caused pagedown to not consistently move to the last element in a menu that is larger than one page. This commit tries to fix this by just adding a bit of heuristic margin; I don't think this error should ever be more than 1px or so. -------------------------------------------------------------------------------- b72297ba39 | gammafunk | 2022-06-13 05:40:34 -0500 feat: Rename the Hedge Wizard abbreviation to HW When Wizard was renamed to Hedge Wizard in 0.26, we avoided changing the background abbreviation. This was to avoid the hassle of retroactively renaming combos, but it left us in an awkward situation where the two class names were different yet the combo names remained unchanged. We're sure we want to regard the historical Wizard class as equivalent to current Hedge Wizard, and with release coming soon, now is a good time to rename the abbreviation and do a retroactive rename in Sequell. This commit renames the abbreviation Wz to HW and renames all related enums and image filenames for good measure. I've also updated the lookup key for background descriptions in all language files that previously had entries for Wizard, but I've not changed any of the language text. -------------------------------------------------------------------------------- afbf2c5d25 | Nicholas Feinberg | 2022-06-12 21:09:02 -0700 Make allies not autotarget Kiku wretches They're harmless, and autotargeting em might prevent the player from using targeted effects like Simulacrum or Infestation on em - they can die after the invocation & before the player gets a turn! -------------------------------------------------------------------------------- 3281e725f0 | Nicholas Feinberg | 2022-06-12 21:02:14 -0700 Increase formicid dexterity by +3 Now that dexterity is the only stat that matters for shields, formicids could use a teensy bit more of it. This increases their SH as follows: - With bucklers: (3 * 38 * (3*2 + 13) / 26) / 200 = +0.4. - With kite shields: +0.6. - With tower shields: +0.85. -------------------------------------------------------------------------------- 0dc89cf053 | Nicholas Feinberg | 2022-06-11 22:54:11 -0700 Rock out, skillfully (Lightli) New gimmick Meteoran earth magic title. Perhaps too silly. -------------------------------------------------------------------------------- c323245b08 | Nicholas Feinberg | 2022-06-11 22:10:43 -0700 Tone down Amaemon's loot An enchanted demon whip of venom pre-lair is just a bit too much reward to be handing out so often. Turn down the enchantment to the same level as Grum's, maybe -2 to +1 or so. -------------------------------------------------------------------------------- 1b89ca2c71 | Nicholas Feinberg | 2022-06-11 21:30:13 -0700 Fix petrifying/frozen + aoops (acrobat) The wrong function was being called to determine whether monsters were slower than the player (and hence unable to get attacks of opportunity on them). Closes #2529. -------------------------------------------------------------------------------- bc6e321ce9 | Nicholas Feinberg | 2022-06-11 21:13:46 -0700 Fix simulac/dchan + wretches (dilly) Broken by 2ca5787500ec8efac2b55a44e937fbcb8f280d80. -------------------------------------------------------------------------------- e9b4822f2a | Nicholas Feinberg | 2022-06-11 20:48:55 -0700 Increase Sandblast's range Compensate for slowness and make spriggan nonsense a lil less fiddly. -------------------------------------------------------------------------------- 8aee0ca6de | Nicholas Feinberg | 2022-06-11 20:45:58 -0700 Add enums for random beams Clarify the secret meaning of an enum range. -------------------------------------------------------------------------------- 9aa79d2f82 | Kate | 2022-06-12 00:40:56 +0100 Fix an invisibility uselessness message -------------------------------------------------------------------------------- a50e9794a5 | Kate | 2022-06-12 00:40:56 +0100 Suppress glow while in shadow form As mostly-flavour change to Dithmenos shadow form, let it suppress glow from Corona, as well as innate Meteoran glow and other effects that light up the player. -------------------------------------------------------------------------------- 8197eedfc6 | Kate | 2022-06-12 00:40:56 +0100 Don't reduce Corona's duration against invisible players It's unclear why it was extremely short-duration against players that were invisible - in the very unlikely event that a monster manages to land Corona on an invisible player, they should get the actual intended benefit for doing so. -------------------------------------------------------------------------------- 40ec974cc1 | Kate | 2022-06-12 00:40:48 +0100 Improve messaging for Kiku spell gifts Handle cases where Kiku fails to offer any new spells, or where the player can only learn a limited subset of the capstone spell gifts. -------------------------------------------------------------------------------- 7a16c6de65 | advil | 2022-06-11 09:48:03 -0400 fix: don't let broodmother spawning crash the arena The foes for summon spiders were set wrong. This commit generalizes some code and should perhaps be applied further for the sake of future-proofing, since any of these summoning spells that just sets the foe to MHITYOU would crash in the arena if it were ever callable in the arena. -------------------------------------------------------------------------------- d29158461a | advil | 2022-06-11 09:48:03 -0400 fix: hide some references to "you" in the arena I think the conditions that set the UI flags for these are also wrong for the arena, but it was easier just to hide them. Currently, the mon info codepath is not used for AI so this is just cosmetic. -------------------------------------------------------------------------------- 64e4043184 | sdynet | 2022-06-10 22:50:37 -0400 Tiny improvement of Oct's ring It's a bit more useful, and I've adjusted the numbers slightly to fit the theme (8) -------------------------------------------------------------------------------- 3e17c549df | Nicholas Feinberg | 2022-06-10 18:33:17 -0700 Turn Sandblast into Slowblast The idea of a spell that uses up ammunition of some kind is pretty cool. You can use less powerful spells to conserve ammo, and then use the big spell for special occasions - if you have other spells available, there's no inconvenience similar to switching between different weapons. However, at level 1, you won't *have* other spells available. So the only way to preserve stones for Sandblast is to switch to melee for chaff... which isn't very exciting! Instead, let's play with a new mechanic that I've wanted to try out for Earth Magic for a while. Sandblast now no longer consumes stones, but instead takes twice as long to cast as normal spells. In testing, this gave it a distinctive and spicy character, but still felt quite powerful. (It's probably a slight nerf to D:1 EE and maybe a buff for D:2-3, which seems fine.) I'll keep an eye out for other places to use the ammo mechanic, though it might not involve stones. -------------------------------------------------------------------------------- a02bf68b3c | Nicholas Feinberg | 2022-06-10 14:39:34 -0700 Remove water (potion [colour logic]) Obsolete since d34118a48d77f2a9bb4910353feb4662b87d51c0 (2012). -------------------------------------------------------------------------------- bafdd74861 | advil | 2022-06-10 14:16:22 -0400 fix: give death and suffering their due -------------------------------------------------------------------------------- 359e09b9d1 | advil | 2022-06-08 16:47:42 -0400 fix: minor tweaks to mac console exec script * add a condition to run this directly from the repo without a containing app * refactor the app name logic * add an error case * add a comment explaining how to use a different terminal app (real wish: a user-friendly way to do this) -------------------------------------------------------------------------------- 883231c05f | advil | 2022-06-08 10:17:55 -0400 fix: reword middle Ru sac level As pointed out in: https://crawl.develz.org/tavern/viewtopic.php?f=8&t=27288 it's a bit hard to figure out whether "significant" or "major" is bigger. (The answer is "major".) I changed "significant" to "medium", which to me reads as both bigger than "modest" and less than "major". -------------------------------------------------------------------------------- 43b9904bd1 | Nicholas Feinberg | 2022-06-07 19:10:39 -0700 Fix Chei + rampaging randarts (dilly) Artefacts with rampage weren't being rejected from acquirement because they weren't ID'd enough. Ridiculous. -------------------------------------------------------------------------------- 2ca5787500 | Nicholas Feinberg | 2022-06-07 16:05:25 -0700 Don't freeze jelly spawns' souls (ebering) Casting simulac on the royal jelly's buddlylings didn't even work. -------------------------------------------------------------------------------- 3b24f45cc1 | Nicholas Feinberg | 2022-06-06 20:47:35 -0700 Make concentrated venom decay over time Looks like an oversight in 6ecf17fd6c (15 months ago). -------------------------------------------------------------------------------- 62b45afb52 | Nicholas Feinberg | 2022-06-06 20:46:07 -0700 Allow raising invisible foes from the dead (ebering) Also allow raising simulacs from out of LOS. -------------------------------------------------------------------------------- 81b289dbe5 | Neil Moore | 2022-06-05 05:43:12 -0400 Simplify slightly -------------------------------------------------------------------------------- cc0464ae43 | Edgar A. Bering IV | 2022-06-05 11:00:37 +0300 text: list kiku gift spells in the description -------------------------------------------------------------------------------- ffc1d7fb78 | Nicholas Feinberg | 2022-06-04 16:47:50 -0700 Fix webtiles monster descriptions Broken by new status icons. -------------------------------------------------------------------------------- 81e455f4c2 | advil | 2022-06-04 17:59:13 -0400 fix: prioritize non-removed species for species::from_str_loose The main effect of this is that &rorc in wizmode turns you into a hill orc, not a lava orc. (You can still use exact strings to get the removed species.) -------------------------------------------------------------------------------- e87547aa71 | advil | 2022-06-04 17:59:13 -0400 fix: move a bunch of option defaults out of dat/defaults I would prefer if only lua options had their defaults set in these files. We are a ways from there but these two really don't need to be done in an include; one of them even had its default split between c++ and the include. Everything that is left here is either lua or a text_pattern (where for reasons I haven't discerned, text_pattern defaults never seem to be set in c++). -------------------------------------------------------------------------------- 32f4ba3753 | Nicholas Feinberg | 2022-06-04 14:27:25 -0700 Turn off explore_auto_rest for Meteorans It's usually better to keep moving. -------------------------------------------------------------------------------- 8f12ed8835 | Nicholas Feinberg | 2022-06-04 14:23:59 -0700 Fix the build oops -------------------------------------------------------------------------------- 3a238a73d9 | Nicholas Feinberg | 2022-06-04 14:21:48 -0700 End the terror of tentacle segment zombies Too spooky...................... -------------------------------------------------------------------------------- 1c0eb391a4 | Nicholas Feinberg | 2022-06-04 14:18:25 -0700 Fix sprint combo bans Don't display delver in the jobs list if you haven't chosen a species yet, and don't allow Meteoran at all. (Sprints have no zot clock.) -------------------------------------------------------------------------------- 10a518f58f | Nicholas Feinberg | 2022-06-04 13:56:02 -0700 Add many new status icons (Sastreii) - Antimagic - Concentrated Venom - Dazed - rF- (fire vuln) - Partially & fully charged (floating eyes) - Injury Bond - Repel Missiles - Simulacrum - Still Winds - Waterlogged (phial) - Weakened Whee! -------------------------------------------------------------------------------- 05c506a3cf | Nicholas Feinberg | 2022-06-04 13:56:02 -0700 Store tile icons as a list We'd run out of space in a 64-bit int to store more status icons for tiles, and we want a bunch more! Turn em into a list. -------------------------------------------------------------------------------- 075992c915 | advil | 2022-06-02 15:01:32 -0400 fix: don't wipe out Ru muts with change_species_to This code was promoted from a wizmode function, where things didn't need to be absolutely perfect, to being used in fixups. Among other issues, it overlooked Ru sacs, which are implemented as innate mutations. I'm not perfectly confident that the following code won't mess with sacs in some way I don't understand, but this fix works for the straightforward cases. -------------------------------------------------------------------------------- af1fc19f1b | advil | 2022-06-01 17:55:51 -0400 fix: tiles umbra/halo interactions This logic is exactly copied from showsymb.cc (this was working for console) minus the silence stuff. Resolves #2561 -------------------------------------------------------------------------------- bfd55560d8 | advil | 2022-06-01 16:58:58 -0400 fix: a tag major upgrade crash As long as these enum values exist, we apparently need to give them a color. (I haven't looked very deeply into why.) -------------------------------------------------------------------------------- da7b1fbfba | advil | 2022-06-01 16:44:43 -0400 fix: misc tag upgrade things visible locally, but not in CI -------------------------------------------------------------------------------- cd130a58c2 | advil | 2022-06-01 16:37:08 -0400 fix: remove halfling -------------------------------------------------------------------------------- 223e3869e7 | advil | 2022-06-01 16:14:08 -0400 fix: tag major #ifdefs for aptitudes.h This was apparently never implemented, but didn't matter. I don't know why this didn't break before. -------------------------------------------------------------------------------- a137e16256 | advil | 2022-06-01 15:41:03 -0400 fix: major tag bracketing for removed species Now that this enum is not fully conditionalized, specific removed species need to be marked for the tag upgrade CI test to succeed. -------------------------------------------------------------------------------- 5014999b08 | advil | 2022-06-01 14:27:52 -0400 fix: default `create_enum` to false in species gen As recently discovered, alphabetically generating an enum that is serialized as a number is a really bad idea if you want to preserve any sort of save compatibility. Disable by default the enum-generating option for species_gen.py, and adjust docs and yaml files accordingly. I considered removing this option entirely but it may be useful for less experience coders playing with the code, if you're just adding one species in a private fork (or don't care very much about your players' save files) it's fine/useful. This only didn't come up between 2018 and now out of sheer luck; Dj reused an existing hardcoded enum value, Gn and Pa's alphabetical order matches the order in which they were added, and My didn't exist for long enough for the bug to get noticed (or reported, at least). I think everything else has been a revamp or removal. -------------------------------------------------------------------------------- 26aeb8ffec | advil | 2022-06-01 12:25:49 -0400 fix: avoid a potential divide by 0 error The calc_hp code can be triggered during fixups, at a point where hp_max (which is recalculated on load during _post_init) is not yet set, causing a divide by 0 error. Just skip the rescaling for this case. Also add an explicit dprf for species changes. -------------------------------------------------------------------------------- 200812b14b | advil | 2022-06-01 11:41:13 -0400 fix: pa/me/my fixup fix (real) fa20dd96a133 fixed meoteoric Pas correctly, but turned Me into My (with Me muts at least). This commit fixes the original fixup, and adds a new fixup for My generated along the way. -------------------------------------------------------------------------------- dd5a78fe54 | Kate | 2022-06-01 13:01:57 +0100 Don't suppress Meteoran glow in forms The one form where it would make a big difference either way (shadow form) already doesn't suppress glow since it's a form that keeps mutations. Making the glow permanent allows potions/scarves of invisibility to be properly marked as permanently useless, instead of being left on autopickup because they were technically only "temporarily" useless previously. -------------------------------------------------------------------------------- 67b01d5277 | Kate | 2022-06-01 12:47:49 +0100 Mark scarves of invisibility useless when perma-backlit -------------------------------------------------------------------------------- 1b1fc82263 | Kate | 2022-06-01 12:14:08 +0100 Allow ice beast zombies again As natural monsters, they should be zombifiable the same way as other weird-but-living creatures like sky beasts, unseen horrors and jellies are. -------------------------------------------------------------------------------- fa20dd96a1 | Nicholas Feinberg | 2022-05-31 21:17:56 -0700 Stop turning palentongas into meteorans? Try to fix the build. This is very scary code and may be quite wrong. -------------------------------------------------------------------------------- 05f53baf05 | Nicholas Feinberg | 2022-05-31 17:38:00 -0700 Merge deep, mountain and hill dwarves DD were a very cool experiment. By removing passive regeneration, they asked: if misplays in any fight have consequences (HP loss) that extend beyond that fight, does the game become more dynamic and exciting? 'No regen' over time works great in many games - Spelunky, Cogmind, Desktop Dungeons, Slay the Spire, Hoplite, etc, etc. If I were designing a new game today, I'd very likely not have passive regen over time! However, Crawl is designed to have very large numbers of fights in each game, over a time much longer than any of the above games. Playing 'optimally' throughout every fight for a whole game is exhausting! DD largely circumvent their own gimmick by a variety of 'allowed' healing mechanisms - e.g. vampiric weapons, Vampiric Draining, Makhleb, Ru, Elyvilon (if one must), and now Jiyva. The final result is a species that's quite powerful, but enjoyable for only a select few. As such, let's call this experiment to a close. Whisper 'Farewell' when you leave, Dimli... -------------------------------------------------------------------------------- 1352289c90 | Nicholas Feinberg | 2022-05-31 17:37:32 -0700 New species: Meteoran Time pressure often creates exciting gameplay and interesting tradeoffs. Baseline Dungeon Crawl uses the Zot Clock to add a very weak form of time pressure, but there's so much variety between the playstyles of different species and backgrounds that a tight clock for some would be almost impossible for others. So, let's try limiting that gameplay to just one species! Meteorae have an exciting variety of bonuses - great attributes and aptitudes across the board, passive mapping, and exploration healing, regaining HP and MP when viewing new territory. In exchange, they have one big downside: instead of getting 6,000 turns of Zot clock for each floor, they get 600! The big concern here is whether this species can be made fun without also being made wildly, boringly 'overpowered'. Lots of levers and knobs to tweak, so let's give it a shot! Extra notes: - Meteorae are humanoid beings. (In the night sky, they look like dots because they're very far up.) Hat tip to Neil Gaiman's Stardust. - This commit has a silly 'flavour' gimmick where Meteorae's LOS radius decreases by 2 when they have less than 50 turns left of Zot clock, and again when they have less than 10. Darkness is closing in... - Meteorae glow in the dark. Permanent backlit status (not halo!): +enemy to hit, -stealth, disables invis. Suppressed in forms. Seems funny. Credit to hellmonk for the initial version of this species and pushing to make 'em happen. :) -------------------------------------------------------------------------------- 7c30feaf68 | Nicholas Feinberg | 2022-05-31 17:36:39 -0700 Add a description for short-lived -------------------------------------------------------------------------------- 611cb8dbe1 | Nicholas Feinberg | 2022-05-31 17:36:31 -0700 Soften the Zot clock Instant death is something DCSS has flirted with from time to time, and generally ends up steering away from. In a game as long as DCSS, instantly dying from falling into lava is just a bit too cruel. So, too, goeth the Zot clock. Soften it by making it apply extremely heavy drain for the first few hits, roughly 1/3rd of max HP each time. Only at very low max HP will it now kill the player. (I'd wanted to remove this too, but I think Xomscumming would still be possible without it.) After Zot draining, the player gets another 1k turns on the clock (200 for Meteorae). Let's try this out and see how it goes. -------------------------------------------------------------------------------- 4d55d654a6 | Nicholas Feinberg | 2022-05-31 17:08:02 -0700 Crumble Animate Dead zombies on leaving the floor Tragically seemed to only lead to unfun strats. My heart weeps. -------------------------------------------------------------------------------- 81a890a79d | Neil Moore | 2022-05-31 19:11:12 -0400 Update copyright date -------------------------------------------------------------------------------- a956f109cc | Neil Moore | 2022-05-31 19:11:12 -0400 gather_monster: strip backslash-newline in kmons() The Head Instructor definition has an unstripped backslash, resulting in `make monster` giving the error: util/monster/vault_monster_data.h:50:1: warning: unknown escape sequence: '\040' -------------------------------------------------------------------------------- 59ce8b2d47 | Nicholas Feinberg | 2022-05-31 14:01:06 -0700 X Gonna Zombify Ya (Sastreii) New zombie tiles for jellies, orbs and Xs. -------------------------------------------------------------------------------- c852659d43 | advil | 2022-05-30 09:55:12 -0400 fix: handling of animating objects on banishment This reverts an incidental part of df715e3894bdc; after this commit the animating object for dancing weapons was getting unconditionally destroyed on banishment. The ENCH_ABJ check here is necessary to identify animated objects that are temporary but not summoned. In addition, I think it is correct to only set UNIQ_LOST_IN_ABYSS on temporarily animated objects, because otherwise (in principle) duplicates would be possible. I'm not 100% sure that KILL_BANISHED will do something sensible on a temp animated weapon, independent of this codepath though? It may still go on the transit list... -------------------------------------------------------------------------------- 90894fac46 | Neil Moore | 2022-05-30 02:32:10 -0400 Simplify mephitic movement check. Now that there is no damage to worry about (0.28-a0-1521-g870370a84aO) -------------------------------------------------------------------------------- e2af7f97bc | Neil Moore | 2022-05-30 02:14:08 -0400 Finish promoting Sastreeii The commit 0.28-a0-623-g7f772adbe3 neglected to remove them from the (implicitly non-dev) contributors list. Fix that. [skip ci] -------------------------------------------------------------------------------- bdf32494f2 | Neil Moore | 2022-05-29 23:41:05 -0400 Move orbs to lightgrey, animal skins to red. Orbs had the same colour as cloaks and scarves, despite being in a completely different slot. Rather than move orbs to cyan with their slotmates, put them on a mostly-free colour. This requires, or at least suggests, moving the one other lightgrey armour, animal skins, to another colour. Since skins are functionally identical to robes (this is, as far as I know, the only remaining instance of functionally-identical items distinguished purely for flavour reasons), put the two on the same colour. Also move CPA in the relevant switch, to keep the (now fewer) white armours together. -------------------------------------------------------------------------------- 906aab00d3 | Nicholas Feinberg | 2022-05-29 17:25:01 -0700 Remove ice beasts' skeletons -------------------------------------------------------------------------------- 7c1fb6cc08 | Nicholas Feinberg | 2022-05-29 11:16:22 -0700 Fix jelly/orb/orb guardian zombie tiles A bit hacky, but good enough for now. -------------------------------------------------------------------------------- f985e02bcb | Nicholas Feinberg | 2022-05-29 10:46:17 -0700 Dispel with the illusion of zombies Don't allow insubstantial zombies, e.g. player illusions. (Arguably those should be MH_NONLIVING anyway.) -------------------------------------------------------------------------------- e4dad5d916 | advil | 2022-05-29 13:12:52 -0400 refactor: remove mons_zombifiable 88678701b151 made this equivalent (indirectly) to mons_class_can_be_zombified, and I'm now pretty sure this is correct. The only reason that has come up to have them distinct is to allow some kinds of monsters to place in vaults but not generate randomly, but this can also be accomplished by setting the M_NO_GEN_DERIVED flag, so the only function of both of these existing at this point is confusion. Also removes a bunch of lua stuff that I think is now useless since corpses are purely cosmetic; if I'm wrong it's easy enough to revert. Possibly what is needed is now similar functions that act on monsters? -------------------------------------------------------------------------------- f59ac788ac | Nicholas Feinberg | 2022-05-28 17:25:58 -0700 Fix stab logging with spriggan's knife (Rhaal) -------------------------------------------------------------------------------- a64e7d0afd | Nicholas Feinberg | 2022-05-28 17:12:25 -0700 More body mutation tiles (Sastreii) Large bone plates, sharp scales, and thin skeletal structure. -------------------------------------------------------------------------------- 343b47744d | Nicholas Feinberg | 2022-05-28 17:12:25 -0700 Add missing Bearserk description -------------------------------------------------------------------------------- 793eeb5391 | advil | 2022-05-28 14:34:57 -0400 fix: some issues for shops you aren't in Don't show purchase costs, don't allow marking items for purchase. Shopping list is still editable, but `$` is disabled. (You can view shops in this mode via stash search.) -------------------------------------------------------------------------------- 901c68f7c3 | advil | 2022-05-28 12:30:32 -0400 fix: incremental shopping menu improvements This menu is still incredibly confusing, but here are a few tweaks. * when in describe mode, enter on a hovered item describes it, keyhint changes correspondingly * the purchase keyhint disappears when nothing is selected * the cost hint accurately reflects when you are purchasing the shopping list items. Missing: * the difference between shopping list items being selected and regular items being selected is very confusing * keyhints for `$`, `.` * hover-based way of interacting with shopping list * should `.` have mode-sensitive behavior? * use general menu keyhint code, instead of custom more -------------------------------------------------------------------------------- 711e9a50b0 | Kate | 2022-05-28 17:15:28 +0100 Update some Kiku descriptions (#12703) -------------------------------------------------------------------------------- a2e7fffb44 | Nicholas Feinberg | 2022-05-27 17:28:32 -0700 Add tiles for ?/U (mutation lookup) -------------------------------------------------------------------------------- 99dc0984f0 | Nicholas Feinberg | 2022-05-27 17:22:06 -0700 Add the ultimate big brain meme (Sastreii) Average Chei fan vs average !mutation enjoyer..? -------------------------------------------------------------------------------- ec6baf379c | Nicholas Feinberg | 2022-05-27 14:28:43 -0700 Add mutation lookup -------------------------------------------------------------------------------- 5bb2ffafd0 | Kate | 2022-05-27 19:51:12 +0100 Prevent some unsuitable monster skeletons -------------------------------------------------------------------------------- 6e53cefa51 | Kate | 2022-05-27 19:02:44 +0100 Remove an unnecessary non-flag -------------------------------------------------------------------------------- 50bc209b2e | Kate | 2022-05-27 19:01:19 +0100 Allow shapeshifter zombies Fixes a build failure, since a vault relies on them working. Historically shapeshifter zombies have been allowed to be placed by vaults or reanimated by the player, but didn't generate randomly (which they now will). -------------------------------------------------------------------------------- 88678701b1 | advil | 2022-05-27 13:33:42 -0400 fix: prevent zombifying various undead (Rhaal) Also shapeshifters. As the comments note, I'm fairly unsure of what the division of labor is supposed to be for the relevant zombification functions so I haven't collapsed anything (though I believe it would be safe to if this commmit is correct). -------------------------------------------------------------------------------- e94edfd80f | advil | 2022-05-27 12:07:01 -0400 fix: header build tests Needed to ensure tileidx_t is defined for the new mutation icon function. Also fixed a few misc warnings I noticed. -------------------------------------------------------------------------------- e007cd9fbb | advil | 2022-05-27 11:01:12 -0400 fix: typo Hadn't saved the file -------------------------------------------------------------------------------- b6e6f924de | advil | 2022-05-27 10:58:46 -0400 fix: prevent another player tile crash (Aliscans) See #2544 -------------------------------------------------------------------------------- 281f2b06d5 | gammafunk | 2022-05-27 03:30:13 -0500 fix: Correct a Makefile variable (Goratrix) A typo was introduced in 08a933d9 that broke compilation on some platforms. -------------------------------------------------------------------------------- 17b79114eb | Nicholas Feinberg | 2022-05-26 20:23:57 -0700 Display mutation tiles in-game (Sastreii) Sweet! -------------------------------------------------------------------------------- 08a933d9be | Nicholas Feinberg | 2022-05-26 20:23:57 -0700 First mutation tiles (Sastreii) Scales, fangs & clarity. Not yet supported in-game. -------------------------------------------------------------------------------- 10c3c7b3e5 | gammafunk | 2022-05-26 18:07:26 -0500 fix: Prevent teleports into a closet (Sergey) For evilmike_makhleb_hellhole, the chamber with neutral humans sealed by an iron grate needs `no_tele_into`, in case one teleports inside and has no digging. -------------------------------------------------------------------------------- 10b964d8d7 | Kate | 2022-05-26 17:28:12 +0100 Actually allow all natural monsters to be zombified Without crashing on reading des files this time - non-natural monsters with corpses (such as pearl dragons and demonic crawlers) can still also be zombified. -------------------------------------------------------------------------------- ac2d4088d3 | advil | 2022-05-26 09:42:56 -0400 fix: disallow player tile mons:dancing_weapon This crashes. For some animated objects you can still set a tile like `tile_player_tile = tile:mons_spectral_lbl`, but this unfortunately isn't available for dancing weapons proper. It seems reasonable (at some level) to implement this but I won't be doing it myself right now. Probably the simplest thing would be to just add some dancing weapons to the player tile name pairs? (Implementing a full on dancing weapon tile mode is much more annoying, because dancing weapons set their tiles based on a real item that is technically in their inventory.) resolves #2544 -------------------------------------------------------------------------------- 77b3608bb8 | Nicholas Feinberg | 2022-05-25 16:29:21 -0700 Revert "Allow all natural monsters to be zombified" Broke the build. TODO: unrevert me. This reverts commit 2245875f922b5f5f3da7fd50e32a253ad6a85885. -------------------------------------------------------------------------------- 7bd733b9cc | Kate | 2022-05-25 23:10:23 +0100 Fix a compiler warning (shadowed params) -------------------------------------------------------------------------------- 2cb01fd4ca | Kate | 2022-05-25 22:52:50 +0100 Don't allow derived undead with no attacks Require monsters to at least have an attack of some sort to be able to be zombified, or to have either an attack or some spells to be a Yredelemnul bound soul. -------------------------------------------------------------------------------- 2245875f92 | Kate | 2022-05-25 21:45:51 +0100 Allow all natural monsters to be zombified Whether or not a monster leaves an actual corpse item is now purely cosmetic, so there's no small arbitrary set of otherwise-living monsters (eg unseen horrors, orb guardians) that Animate Dead doesn't work on. -------------------------------------------------------------------------------- a88943ba61 | Kate | 2022-05-25 21:15:22 +0100 Fix Simulacrum not working on demons It could be cast on them, but wouldn't actually do anything. To be fully consistent with its lore and with Death Channel's behaviour, let it work on any monster with a soul (all natural, demonic and holy monsters, including natural monsters with no corpses). -------------------------------------------------------------------------------- 12ac202842 | advil | 2022-05-25 13:00:42 -0400 fix: save after world_reacts on level entry There's a save call in `floor_transition`, and a new level is saved on generation. However, these save states are not at a point where the player can ever have control over the game, because there's always a following world_reacts cycle. Because of this, if a crash happens after these saves but before a real save, the game is rolled back to a time that is impossible to get to in any other way -- time 0 after level entry. This is the bug discovered by personjerry and mentioned in f3dacdeeaaba2. To be clear, it's *not* (imo) a bug that you can roll back time by intentionally force quitting or killing a local game in this way, that's just a variant of ordinary savescumming -- this commit doesn't prevent using force quits to roll back time[1]. But what it does ensure is that a crash rolls back time to a possible game state. The implementation is very brute force and adds Yet Another Bool to `crawl_state`. Along the way I fixed what I think is a bug in sprint save checkpoints -- the level state wouldn't get saved, so a crash in sprint could at least in principle lead to a save with a very inconsistent player / level state. As a side note, the fact that outside of regular save+quit the player and the level are typically saved independently (something I hadn't grasped before this fix), could lead to all sorts of other weirdnesses on crash. [1] This could be desireable but it's not entirely clear to me how to do it, and it's also quite platform-specific. -------------------------------------------------------------------------------- 0e957ee05f | advil | 2022-05-25 07:58:56 -0400 Revert "Revert "Make new stairs fast after crashing (advil)"" There's a bug here, which is that the game state is saved before stair travel time (as well as seen_monsters_react) is applied, but this happens independently of this flag, and so this revert did not fix it. So killing the crawl process, forcing a crash, immediately after stair descent always rolls back whatever stair time there was as well as the initial hits. Also possibly a bug that the crash isn't saving? I'm not sure why it wouldn't. Also, I kind of want to say that force-quitting a local game is essentially a form of save-scumming and so I'm slightly mixed on whether this is really what I'd call a bug. This reverts commit f3dacdeeaaba24e7937b459bf04e6c4ca36dcd6f. -------------------------------------------------------------------------------- 69413ace17 | Nicholas Feinberg | 2022-05-24 20:56:20 -0700 Make the simulacrum targeter smarter (CarefulOdds) Only target valid enemies. -------------------------------------------------------------------------------- 771e844529 | Nicholas Feinberg | 2022-05-24 20:42:02 -0700 Remove prompt for inner flaming friendlies You want to set your friends on fire? Go wild, bud. -------------------------------------------------------------------------------- 34935aedf5 | Nicholas Feinberg | 2022-05-24 20:40:15 -0700 Make the inner flame targeter smarter No targeting will-immune guys, etc. -------------------------------------------------------------------------------- f3dacdeeaa | Nicholas Feinberg | 2022-05-24 20:06:42 -0700 Revert "Make new stairs fast after crashing (advil)" As personjerry notes, this allows quick-moving players to cheat and get fast stair descents by force-quitting the game. I wouldn't have believed it if I hadn't seen it! This reverts commit 653eee55725701cece7eb2daeb7dd585f623eeee. -------------------------------------------------------------------------------- 93865b4adf | Nicholas Feinberg | 2022-05-24 18:04:02 -0700 Allow casting simulacrum on demons (kate, ardl) Consistent with Death Channel. -------------------------------------------------------------------------------- 6d556a0ce6 | Nicholas Feinberg | 2022-05-24 17:06:14 -0700 Ban very low enchantment randart armour It's sort of funny to generate a -7 randart barding, but it's never ever getting worn. Floor it at -2, in the spirit of the hat of the Alchemist. -------------------------------------------------------------------------------- 62b78b4225 | Nicholas Feinberg | 2022-05-23 21:19:21 -0700 Simplify Death Channel (Monkooky) Remove the ability to recast while the duration is active, forcing all specters to expire before you can get a fresh batch. This should hopefully make gameplay with it a little more dynamic, and also improve UI a bit - you no longer need to remember to recasting when the expiration message appears. It still seemed quite strong in testing, but other adjustments can always be made if need be. -------------------------------------------------------------------------------- 78b83d787e | Nicholas Feinberg | 2022-05-23 21:07:44 -0700 Let death channel work with enemy necromancy Simpler to have it work with all corpse-eating effects. -------------------------------------------------------------------------------- e40278f558 | Nicholas Feinberg | 2022-05-23 21:04:18 -0700 Increase Necrotize skeleton duration Try to make em a little more relevant. -------------------------------------------------------------------------------- dfe5cd140f | Nicholas Feinberg | 2022-05-22 20:45:33 -0700 Reorganize necromantic effects Make Infestation consume corpses. The only Necromancy spells that stack are now Death Channel + one of (Infestation, Simualcrum, Animate Dead, Necrotize) + Corpse Rot. TODO: we should make necromancy spells that consume corpses still give out monster organs (eg dragon armour) as appropriate. -------------------------------------------------------------------------------- acb4ef3bc5 | Nicholas Feinberg | 2022-05-22 07:21:09 -0700 Vulnerability, anguish, and decay (Sastreii) New tiles for the amulet of Elemental Vulnerabilty, Anguish, and Necrotize. -------------------------------------------------------------------------------- e5599a681e | Nicholas Feinberg | 2022-05-21 22:19:03 -0700 New early-game fixedart: the amulet of Elemental Vulnerabilty AC+8, rPois, rC--, rF--. Would you wear it? I would :) -------------------------------------------------------------------------------- 88dec836d1 | Nicholas Feinberg | 2022-05-21 21:56:30 -0700 Remove Pain (Lightli) Update the Necromancer background description. -------------------------------------------------------------------------------- 9071f44f2d | Nicholas Feinberg | 2022-05-21 21:13:30 -0700 Release the God of Metal (Sastreii) New Kiku invo tiles. -------------------------------------------------------------------------------- d254ca66d9 | Kate | 2022-05-21 13:16:41 +0100 Fix some commas in unrand inscriptions Remove Damnation's comma (it was trimmed out anyway due to not having any other properties) and give it to Condemnation. -------------------------------------------------------------------------------- e57f7f99b4 | Nicholas Feinberg | 2022-05-20 17:17:11 -0700 Remove condemnation fallback (advil, gammafunk) No need to special case this - it's ok to very rarely generate randart trishulas. -------------------------------------------------------------------------------- e4d8c67b05 | Nicholas Feinberg | 2022-05-20 17:03:32 -0700 Finish shortening Condemnation's name oops -------------------------------------------------------------------------------- ca8cdc03c0 | Nicholas Feinberg | 2022-05-20 17:02:39 -0700 Clarify Condemnation's holiness Remove skip_ego and remove the 'Barbs of' to make space. -------------------------------------------------------------------------------- 48891804b8 | Nicholas Feinberg | 2022-05-20 17:01:56 -0700 Condemn some placeholder dev tiles (Sastreii) New tiles for the trishula "Condemnation". -------------------------------------------------------------------------------- 50448035db | Nicholas Feinberg | 2022-05-20 09:10:19 -0700 Tweak Condemnation lore Clarify in the weapon description why it inflicts anguish (thematically), and move the noises further in line with the lore. -------------------------------------------------------------------------------- df083b7a6e | Nicholas Feinberg | 2022-05-20 07:09:34 -0700 Add missing Condemnation doll tile -------------------------------------------------------------------------------- f74b082263 | advil | 2022-05-20 09:34:20 -0400 fix: correct weapon stats for UNRAND_WOE The description was showing numeric stats for a regular exec axe. Also, fix an unrelated ∞. At this point all ∞s besides those in art-data.txt are correctly conditionalized. -------------------------------------------------------------------------------- e4767303ab | advil | 2022-05-20 09:34:20 -0400 fix: conditionalize a few more ∞s -------------------------------------------------------------------------------- a9ffdc3c7e | Nicholas Feinberg | 2022-05-20 05:57:51 -0700 Remove an accidental addition -------------------------------------------------------------------------------- 97dee8cd24 | Nicholas Feinberg | 2022-05-19 21:58:38 -0700 New unrand: the trishula "Barbs of Condemnation" The weapon of a long-gone archangel of judgment, this is a +8 trishula that inflicts 4-8 turns of Anguish on hit. (That is, victims have their damage mirrored back to them.) It also gives flying, rN+, and makes angel noises. Fun! It's a one-hander so that the anguish damage is more relevant (rather than the weapon damage more quickly & directly murdering everything), a polearm to synergize with allies, and a trishula for thematic & mechanical variety. (We already have a perfectly good demon trident unrand.) For more details, please read the description of Barachi in the Crawl manual. -------------------------------------------------------------------------------- 5c6f5cd5d9 | Nicholas Feinberg | 2022-05-19 21:38:24 -0700 Actually decay anguish over time ??oops -------------------------------------------------------------------------------- 93c1fc3693 | advil | 2022-05-19 20:47:50 -0400 fix: remove wrong comment, use "inf" (PF) -------------------------------------------------------------------------------- 667b474bfb | advil | 2022-05-19 20:41:17 -0400 fix: respect char_set=ascii in hud We've been using ∞ to indicate immunity for a while now, but this was shown even if the player tried to force ascii. I chose `!` semi-arbitrarily as potentially indicating the right thing, maybe there's better options. -------------------------------------------------------------------------------- 96ad54b138 | advil | 2022-05-19 18:11:32 -0400 feat: use .tsv for objstat outputs instead of .txt These already are tsv files, and using the extension makes it easier to auto-open them in a spreadsheet app and so on. This change approved by gammafunk(tm). -------------------------------------------------------------------------------- 53bdb1016d | advil | 2022-05-19 18:06:05 -0400 fix: tweak precision for NumOOD in objstat These are reporting rare enough events that with just to digits of precision, a lot of stuff that is non-0 shows up either as 0.00 or 0.01. An extra digit on top of the default seems to be enough that most values can be compared when working in the 1000 iters range. -------------------------------------------------------------------------------- f113fcf677 | advil | 2022-05-19 16:55:32 -0400 feat: add some monster OOD info to objstat The relative depth values correlate with this, but it's interesting and potentially useful to pull out OOD info specifically. At the moment for large iters, the NumOOD field very rarely exceeds 0.01 for individual monsters that do place in my testing, so I may need to tweak this further for it to be useful. -------------------------------------------------------------------------------- 763a1779be | advil | 2022-05-19 11:14:18 -0400 feat: add some basic monster depth info to objstat Two new fields derived from mon-pick-data.h. These are a bit rough but still informative in my testing. RelativeDepth: the current depth minus the average depth based on regular placement tables. So more negative is more out of depth, more positive is more under depth. So for example a fire dragon placing on D:9 gets RelativeDepth -11, because its average placement (rounded) is 20. Out-of-branch monsters get 0 for this, so the following Num stat is what is used to calculate the average. NumInBranch: Counts monsters that are generated by the regular branch placement tables. For individual monsters, this will either be the total count or 0. (Maybe NumOutOfBranch would be more useful as a directly viewable stat?) A few caveats: neither uniques nor derived undead ever count as in-branch. I did it like this because there is already an average function, but it might also or instead be nice to have an explicit OoD number, maybe something like the closest depth range edge minus current depth. E.g. the fire dragon in the example above is also over-OoD, because its minimum placement is D:14 (placed by a vault), and this is a bit hard to directly reconstruct. Maybe later. -------------------------------------------------------------------------------- fbfa42419e | Nicholas Feinberg | 2022-05-18 14:35:18 -0700 Fix corpse description (Lightli) -------------------------------------------------------------------------------- f02deff4a7 | advil | 2022-05-18 16:25:48 -0400 refactor: convert `pregen_dungeon` to enum, clean up parsing This option was previously implemented with the double bool for three values strat; this converts it to a 3-valued enum and uses this to clean up the parsing code as well. Sort of annoying to have yet another tiny little enum.h around, but I guess that's what we do. -------------------------------------------------------------------------------- 9e3099983f | Nicholas Feinberg | 2022-05-18 12:42:42 -0700 Remove Animate Skeleton's remains Just a few spare leg and arm bones floating around. -------------------------------------------------------------------------------- a536a90030 | Nicholas Feinberg | 2022-05-18 12:38:31 -0700 Remove excruciating wounds The description. -------------------------------------------------------------------------------- aae9a6c917 | Nicholas Feinberg | 2022-05-18 12:36:35 -0700 Fix OOD fuzzing Broken in 18a14b5c600 (almost exactly a year ago) to *not* weight away from the edges. Oops! -------------------------------------------------------------------------------- 3b62d05871 | Kate | 2022-05-18 19:01:44 +0100 Apply coding conventions -------------------------------------------------------------------------------- e11e1e56b0 | Kate | 2022-05-18 19:01:18 +0100 Fix Corpse Rot's description for !cancellation And clarify a comment to explain why short_text needs to be in adjective form. -------------------------------------------------------------------------------- 0f0961c20d | Kate | 2022-05-18 18:48:17 +0100 Give Unearth Wretches an ability targeter -------------------------------------------------------------------------------- ed0ba456c6 | advil | 2022-05-18 11:41:36 -0400 fix: remove some unused functions (Goratrix) -------------------------------------------------------------------------------- 5dfcd41d59 | Nicholas Feinberg | 2022-05-18 07:07:00 -0700 Ban anime zombies from attacking outside LOS, again -------------------------------------------------------------------------------- ef7be07a3d | Nicholas Feinberg | 2022-05-18 07:07:00 -0700 Update kiku desc -------------------------------------------------------------------------------- eecb74a380 | Nicholas Feinberg | 2022-05-18 07:07:00 -0700 New Kiku ability: Unearth Wretches Replacing corpse drop, this summons a few wretched, near-death souls for you to practice necromancy on. They're zero XP, paralysed, 1 HP, 0 will, and die in a few turns. Rough! -------------------------------------------------------------------------------- c36bb38398 | Nicholas Feinberg | 2022-05-18 07:07:00 -0700 Retheme simulac -------------------------------------------------------------------------------- 9dfb08f9a7 | Nicholas Feinberg | 2022-05-18 07:06:57 -0700 Re-rework animate dead Make the zombies unlimited duration, but have them crumble when the caster re-casts this spell. This is intended to avoid the boring play pattern of repeatedly casting the spell at the start of every fight, and to encourage somewhat more dynamic and fun decision-making. Also reduce power scaling to make the spell more usable by 'hybrids'. -------------------------------------------------------------------------------- 3a8266931e | Nicholas Feinberg | 2022-05-18 07:06:27 -0700 Fix some animate dead issues Re-add messages and fix a bug where enemies would create hostile zombies while animate dead was active. Also add simulac messages and tweak necrotize skeleton messages. -------------------------------------------------------------------------------- b89b5c0cdd | Nicholas Feinberg | 2022-05-18 07:06:27 -0700 Ban Gozag from animating gold corpses -------------------------------------------------------------------------------- 20812cadf4 | Nicholas Feinberg | 2022-05-18 07:06:27 -0700 Apply refactoring & fixes to all on-death necromancy effects -------------------------------------------------------------------------------- ef05d3b997 | Nicholas Feinberg | 2022-05-18 07:06:27 -0700 Update Kiku description -------------------------------------------------------------------------------- 5cd8600749 | Nicholas Feinberg | 2022-05-18 07:06:27 -0700 Move Tukima's Dance from Maledictions to Weapons Purely vibes-based change. -------------------------------------------------------------------------------- 14519f8a5a | Nicholas Feinberg | 2022-05-18 07:06:27 -0700 Remove the Book of Pain Gutted. -------------------------------------------------------------------------------- 1025688b39 | hellmonk | 2022-05-18 07:06:27 -0700 Rearrange kiku spell gifts -------------------------------------------------------------------------------- 2fcf5398dd | hellmonk | 2022-05-18 07:06:16 -0700 Kiku duplicate undead passive To replace corpse drop, give Kiku a piety-dependent chance to grant an extra ally each time one would be generated from a necromancy spell or the reaping brand. This applies to all of the derived undead spells and infestation, and simulacrum rolls independently for each simulacrum generated. Starts off at about 14% chance at 30 piety and rises linearly to 25% at max piety. -------------------------------------------------------------------------------- cdf6c57b5d | hellmonk | 2022-05-18 07:06:07 -0700 remove kiku corpse drop -------------------------------------------------------------------------------- 8cd6c6eb39 | hellmonk | 2022-05-18 07:06:07 -0700 Remove excruciating wounds It outlived warp weapon by more than 5 years, somehow. -------------------------------------------------------------------------------- 613369fe0c | hellmonk | 2022-05-18 07:06:04 -0700 feat: Replace pain/aniskele with Necrotize New level 1 spell, identical damage/range/etc to pain. No self damage. On damaging a skeleton-having monster, applies a 10 aut status that animates its skeleton on death with a summon duration of 2. This should, I think, be limited enough to work without being overpowered but may need further adjustment. WL check plus low damage should keep it from being a good use of a turn past the relatively early part of the game. Necrotize -> make a skeleton -> can't hit the next guy behind it may not feel very good, so could try some kind of random targeting with less range. -------------------------------------------------------------------------------- 38ecc28c78 | hellmonk | 2022-05-18 07:02:25 -0700 feat: Rework corpse rot Apply the effect on kill for a duration, scaling with power. Tentatively moved to level 4 necro/poison/air. Plenty of room to toggle here. -------------------------------------------------------------------------------- a05d3bcdc0 | hellmonk | 2022-05-18 07:02:25 -0700 feat: rework simulacrum Simulacrum is now a smite-targeted spell that places an irresistable status. A monster that dies with the status will spawn a power-dependent number of simulacra (no longer depends on monster size). I think this is enough of a difference to distinguish it from dchan and infestation. Desperately needs a status icon and better lore. -------------------------------------------------------------------------------- 8cec33880d | hellmonk | 2022-05-18 07:02:25 -0700 feat: Rework Animate Dead Move this spell toward a dchan-like model. For the duration of the effect, monsters with corpses have power dependent chance to become zombies. Duration also scales with power, and the zombies crumble when the effect ends. Numbers very preliminary. -------------------------------------------------------------------------------- 653eee5572 | Nicholas Feinberg | 2022-05-18 06:29:49 -0700 Make new stairs fast after crashing (advil) If you crash while descending the stairs into a new level, you should still have a 'fast' descent rather than a 'slow' one. -------------------------------------------------------------------------------- afbd6decc1 | Nicholas Feinberg | 2022-05-17 22:15:05 -0700 Make it fast to enter new stairs (catern) Historically, it's been twice as fast to enter new levels as to re-enter old ones. Fast entries made players die in surprising ways less often when entering new floors, and slow re-entries provided valuable discouragement to "stair-dancing". However, they also produced some big feel-bad moments when players got clobbered while taking new stairs to a new level - "I thought I was safe the first time I took the stairs!" Align things a bit more with player intuitions by making it faster to take stairs (or trapdoors, or shafts) that the player does not know the destination of, instead of basing it on whether the level is 'new'. -------------------------------------------------------------------------------- ecc9850ee1 | Nicholas Feinberg | 2022-05-17 22:08:15 -0700 Move an orphaned boolean Looks like this got split up for no good reason at some point. -------------------------------------------------------------------------------- 57f2fb0196 | Nicholas Feinberg | 2022-05-17 21:13:22 -0700 Make D shafts even nicer 5c17abdc72d04c8214fdcadc9cb7d8cf9756b66e used felid revival logic to place the player after a shaft, but that logic was not very good at placing the player out of sight of enemies. Write some new logic. (Perhaps we should change felid revival instead..?) -------------------------------------------------------------------------------- 77450f2105 | Nikolai Lavsky | 2022-05-17 09:45:49 -0400 fix: restore scroll-swinging and scroll-tossing speed (12701) After a8e9c987b8, scroll-swinging takes 3 auts instead of 15 auts. Also, the speed of tossing items depends on the wielded weapon and can be slowed by armour instead of being 15 auts. This commit restores the old speeds. -------------------------------------------------------------------------------- c0181ea820 | advil | 2022-05-16 13:21:45 -0400 fix: rewrite webtiles menu pgup/pgdn This was previously a bit of a mess; the behavior of the two was almost never symmetric, and there were all sorts of messy interactions with headers (because they are rendered in a smaller font). This rewrite doesn't solve everything but it generally has much better behavior on both of these points. * refactor so that these are largely using shared code, making symmetry much easier * redo pgup to use set_bottom_visible rather than do an ad-hoc size calculation (that was also wrong). This makes it much closer to how pgdn is implemented. * when recalculating hover after paging, ignore headers. This overall leads to much more consistent behavior. (Though it still has some weird cases..) N.b. possibly this should be ported to local tiles too, but in practic local tiles paging (which uses a different approach) is less susceptible to these issues. Alternatively, webtiles paging could get the local tiles algorithm, which scrolls by pixels? * heuristics for hover at the end Also fix a bug for menu.last_visible calculation with size 1 menus. -------------------------------------------------------------------------------- a44e0411cd | advil | 2022-05-16 13:07:18 -0400 fix: improve local tiles menu pgup/pgdn This tweaks local tiles paging in menus to be more consistent in various ways. Main changes: * use top of menu items, not bottom, to calculate first visible. (I've never understood why it was implemented the other way, so hopefully this doesn't break some case I haven't thought of..) * halve the impact of the shade on scrolling margin, tweak the shade's alpha value * ignore initial visible headers in preserving relative hover for pgup/pgdn * preserve a scroll context that is 1.5x the max line height when scrolling via pgup/pgdn (previously there was no context except as a side effect of the shade). This resolves #2515 This mostly won't affect console, except for the header change (which should be an improvement). -------------------------------------------------------------------------------- 83a48905f1 | advil | 2022-05-15 16:13:17 -0400 fix: really old save compat for random draconians debd2d6947 and f64331b8c2b added new RANDOM_ monster types without save compat for random draconian placement types used in zigs. A save that crashed while generating a zig level before these commits would (following these commits) then crash while trying to generate the zig level, because the random monster types are no longer valid. This commit is quite approximate, but handles the crash seen in a save here: https://crawl.develz.org/mantis/view.php?id=6308 (As of this commit, this save no longer crashes.) -------------------------------------------------------------------------------- 12f7694b2d | advil | 2022-05-15 14:51:06 -0400 fix: repair an ancient fixup In current dcss, NUM_BOOKS drastically exceeds MAX_SUBTYPES. This doesn't matter, because nothing (after this commit) assumes that books are relevant to MAX_SUBTYPES, and this is why (I'm assuming) there was no prior COMPILE_CHECK for this case. However, this one fixup assumed that there were enough force_autopickup slots that there was a value for NUM_BOOKS, leading to a crash on saves from this era. It's possible that MAX_SUBTYPES should be increased to prevent future confusion, but I instead just added a COMPILE_CHECK to validate the specific assumptions current force_autopickup needs, and changed the fixup. Found via the save in: https://crawl.develz.org/mantis/view.php?id=6308 (though this isn't either of the crashes noted there) -------------------------------------------------------------------------------- 5075937ec3 | Kate | 2022-05-14 12:21:03 +0100 Fix compilation -------------------------------------------------------------------------------- 559d8e5bd9 | Nicholas Feinberg | 2022-05-13 22:12:58 -0700 Fix felid zot death message You didn't enter a new level -------------------------------------------------------------------------------- fc8527a98e | Nicholas Feinberg | 2022-05-13 22:12:58 -0700 Warn while resting and bezotted -------------------------------------------------------------------------------- f845f52a54 | Nicholas Feinberg | 2022-05-13 22:12:58 -0700 Make zot death messages more exciting -------------------------------------------------------------------------------- 9596d59a08 | advil | 2022-05-13 16:55:55 -0400 fix: mark closets as notele in ossuary_zaba_flooded This is a bit of an overkill / quick fix, in that (as far as I can tell) closets generated by the flooding algorithm here are guaranteed to be deep water, and so marking all deep water as notele seems to do the trick. Probably it would be better if this algorithm didn't generate closets at all, but someone would have to understand it to fix that. Relevant mainly to species that can inhabit deep water of course. Recently trapped a player in: https://cbro.berotato.org/morgue/pigah/morgue-pigah-20220513-145335.txt -------------------------------------------------------------------------------- d843f3a48c | Nicholas Feinberg | 2022-05-12 13:42:24 -0700 Trigger riposte on blocks Historically, one of the issues with riposte was that it interacted poorly with shields. Shield blocks triggered before dodges, so they made riposte less effective. We didn't want to make riposte trigger on blocks, for both power level concerns and worries about diluting the focus of the mechanic (toward "dex-centric", dodgy characters). But now riposte is unrand only, so we can go wild! This should avoid feel-bad shield/riposte interactions going forward. -------------------------------------------------------------------------------- 6c28700d94 | Nicholas Feinberg | 2022-05-12 13:30:57 -0700 Increase 'large' species shield aptitudes Following 7b68f1b707db and ffcb275ae500, 'large' species ended up substantially worse at using shields than before. Increase their Shields aptitude by 1 point (14%) to compensate. This affects trolls, ogres, nagas, palentongatrices, and formicids. -------------------------------------------------------------------------------- 477518b81c | advil | 2022-05-12 14:50:41 -0400 refactor: more options cleanup Move several things out of reset_options that don't need to be there. -------------------------------------------------------------------------------- 1debfa714c | advil | 2022-05-12 14:21:33 -0400 refactor: standardize parsing of wiz_mode, explore_mode This moves these options to be `MultipleChoiceGameOption`s for standardized parsing, default setting, etc. The implementation in builds that disable these is slightly different than previously. In DGL builds, these options cannot be set but do produce an error (previously silent) indicating that they are disabled for the build. CLO behavior is unchanged. In !WIZARD builds, the option field is now present in the Options object, but cannot be set via rc or command line so is basically inert, aside from erroring (previously this case was also silent). If the error is annoying for some reason it would be possible to restore the old silent behavior, but I'm not seeing a lot of reasons why this error would be bad. -------------------------------------------------------------------------------- 6c54550755 | advil | 2022-05-12 14:21:33 -0400 refactor: clean up handling of -wizard and -explore Rather than having the CLO parsing code set an option value which then interacts with the defaults in a complicated way, have fixup code check the options directly after all option handling is done, and promote WIZ_NEVER to WIZ_NO as needed. This has the benefit of getting a more sensible interaction of the CLO and rc options (not that I would imagine this comes up much); but the main goal is just to simplify the defaults a bit. -------------------------------------------------------------------------------- 8f4046f52e | advil | 2022-05-12 14:21:33 -0400 refactor: standardize a few more enum-like options Following 6e02c14617caef94b9e -------------------------------------------------------------------------------- 5c17abdc72 | Nicholas Feinberg | 2022-05-12 09:31:23 -0700 Make D shafts nicer (Sergey) Shafting is exciting when it means having to find a way back up to safer levels. Shafting into a position when you're surrounded by later-game enemies, however, tends to feel very unfair - it's often surviveable, but doesn't feel like a reasonable or just challenge. Borrow felid revival logic to make D shafts try to send the player to somewhere outside LOS of monsters. Shafts in other branches remain unchanged. This helpfully differentiates shafts further from teleport traps, which try to send the player *to* monsters, and alarm traps, which send monsters to players. -------------------------------------------------------------------------------- 6e02c14617 | advil | 2022-05-12 11:26:03 -0400 refactor: standardize custom enum-like options This converts various options with custom handling to MultipleChoiceGameOptions (all that I'm seeing that are obvious candidates for it). This gets: (i) better default handling, (ii) more standardized error messages, (iii) less code duplication, (iv) for many of these, more general bool-like parsing (accepting yes/true/1 and no/false/0 for all bool-like args). The only downside is that for a few of these, the else case (usually mapping to the default) didn't impose any constraints, so it may introduce some spurious errors. I've worked around this by adding some extra mappings for several of these. Remaining options with custom handling do something on top of just putting enum-like values into an Options member variable, so would need a more involved approach. -------------------------------------------------------------------------------- 12f90c9db4 | Nicholas Feinberg | 2022-05-12 07:56:49 -0700 Double demonic touch damage (hellmonk) Current demonic touch is generally considered a bit weak. Let's try making it wildly overpowered and then see where we want it to settle. -------------------------------------------------------------------------------- 3b3f824e1b | Nicholas Feinberg | 2022-05-12 07:49:26 -0700 Remove stoker's M_MAINTAIN_RANGE We must preserve orb spiders' mechanical uniqueness of 'being incredibly annoying'. Wind blast is quite enough on its own :) Also, increase their creeping infernos' durations so that they can do something before expiring. -------------------------------------------------------------------------------- ccd5019c30 | gammafunk | 2022-05-12 09:36:50 -0500 fix: Adjust a mini vault (Lici) For dispersion_dpeg, this vault dates from when traps could work out of LOS, hence monsters inside could easily teleport if they woke up before the player reached the vault. This wasn't a great gimmick overall, and the vault's contents would be relatively hard to access without blink, apport, etc. Rework the vault to feature a guaranteed path out of the center through either nothing or non-permanent teleport traps. Also use clear walls to prevent the vault from having spoiler/autoexplore issues. At least if the monsters don't disperse from the vault before the player arrives, the player will have enough time plan out their actions before monsters reach the traps. Also simplify loot placment and reformat DES. -------------------------------------------------------------------------------- e13fd1374b | gammafunk | 2022-05-11 18:43:41 -0500 fix: Adjustments to an arrival vault (personjerry) The vault erik_arrival_cave_to_temple had an area in a subvault that could place monsters and loot fully encased in stone. Have this area always place a door, introducing some clear stone so it won't be as much of a spoiler and autoexplore trap. The other subvault for this map placed monsters immediately behind a door followed by nasty monsters and altars behind digable walls. Remove the door to improve spoilers/autoexplore, and put the nasty area behind a runed door. Tone down the Abyss monster set to not place demonic crawlers on D:1, instead placing only the 5 class demon that can generate in the abyss. Fix `no_item_gen` masking and also add `no_monster_gen` masking to this section. -------------------------------------------------------------------------------- 846e4a0bbc | advil | 2022-05-10 14:45:14 -0400 fix: use rng::UI for help lookup (gammafunk) Previously, this would use the gameplay UI. I'm not sure this was particularly exploitable without crashes or the like, but would allow the player to tweak this rng in a fairly controlled way. -------------------------------------------------------------------------------- 17b9a4b632 | advil | 2022-05-10 12:34:24 -0400 fix: remove debug code -------------------------------------------------------------------------------- 1b0d357a27 | advil | 2022-05-10 12:34:24 -0400 fix: don't let help mark unrands as existing e9b396fb1906e62 generates the unrand to show its info in help lookup, and a side effect of the generation call marks the unrand as existing in you.unique_items. In consequence, a player can force arbitrary unrands that haven't yet generated to be (potentially) converted to fallback randarts by looking them up. I'm not sure if this is good for players to do or not but it's at least a very good bug. Resolves: https://crawl.develz.org/mantis/view.php?id=12702 -------------------------------------------------------------------------------- 12a17119fa | advil | 2022-05-10 12:34:24 -0400 fix: unbreak UNIQ_LOST_IN_ABYSS A bit too late, since it's now exceptionally rare for this to come in to play, but oh well. Since 850bfe61e39c27fcd unique item status would get (incorrectly, I believe) cast down to bool when setting UNIQ_LOST_IN_ABYSS, and get converted to UNIQ_EXISTS as a consequence. This tries to clarify the current statue of the API and restores what's left of this mechanism. -------------------------------------------------------------------------------- 47a863cc1b | Nicholas Feinberg | 2022-05-08 10:32:00 -0700 New wind drake & acid dragon tiles (Sastreii) -------------------------------------------------------------------------------- 297d3b089c | hellmonk | 2022-05-07 21:14:54 -0700 buff kiku torment Don't require a corpse. -------------------------------------------------------------------------------- f1fea46640 | hellmonk | 2022-05-07 21:06:13 -0700 feat: allow ranged pain Expand Kiku's brand capstone to ranged. -------------------------------------------------------------------------------- 665335d0ad | hellmonk | 2022-05-07 21:04:34 -0700 fix: correct kiku rtorm formula It was possible for partial torment protection to roll 0 damage reduction, but give the protection message anyway. Always reducing damage by at least 1 if the kiku passive triggers seems fine. -------------------------------------------------------------------------------- d8082fcd2d | Kate | 2022-05-07 22:34:36 +0100 Remove some obsolete default runrest_ignores (gammafunk) -------------------------------------------------------------------------------- 23c34f7495 | Kate | 2022-05-07 21:57:18 +0100 Adjust AM species recommendations Don't recommend Troll (since throwing is no longer a starting option), replacing them with Gnoll (since AM benefits from training lots of skills). -------------------------------------------------------------------------------- 9e3a32f71c | Nicholas Feinberg | 2022-05-07 09:33:35 -0700 Don't claim to clatter in silence (Monkooky) -------------------------------------------------------------------------------- 3d288355ac | Nicholas Feinberg | 2022-05-07 09:27:25 -0700 Fix artefact MP prop unequip effects -------------------------------------------------------------------------------- 94e2008b86 | Nicholas Feinberg | 2022-05-07 09:20:37 -0700 Remove MP when un-equipping +MP items (ɯ|s|ı|ʍ|o|ǝ|ɯ) Encourage making choices ("do I want +MP or wizardry?), rather than swapping off your =mp halfway through every fight. -------------------------------------------------------------------------------- 6960b1960d | Nicholas Feinberg | 2022-05-05 21:43:30 -0700 Tweak Gauntlet description (jumble) The last line was intended to describe the path through the Gauntlet arenas, but came across as saying 'once you enter a Gauntlet, the only way out may be through the arenas & the minotaur'. You can see the path through the arenas once you're there, so there's no need for this text. -------------------------------------------------------------------------------- 8b6f518c11 | Nicholas Feinberg | 2022-05-05 09:37:35 -0700 Deduplicate the 'soothsayer' title (Ge0ff) Replace Ashenzari's Soothsayer title (duplicates a Nem title) with a riff on Scottish freemasonry, plus shift some stuff around. -------------------------------------------------------------------------------- 7bf7899b20 | Nicholas Feinberg | 2022-05-05 08:46:13 -0700 Reduce some paralysis durations As part of the ongoing quest to make DCSS a little nicer and reduce 'feel bad moments', reduce the max paralysis duration for the Paralyse spell and from various god wraths from 7 to 5. Also remove some dead code and simplify logic for demonic magic. This does not affect the player paralysing monsters, only the player being paralysed. -------------------------------------------------------------------------------- b2816e9c68 | Nicholas Feinberg | 2022-05-05 07:05:13 -0700 Cap Zenata summons (Ge0ff) -------------------------------------------------------------------------------- f50f0a9fbc | Nicholas Feinberg | 2022-05-04 16:51:57 -0700 Fix the build -------------------------------------------------------------------------------- 4f0bcfc870 | Nicholas Feinberg | 2022-05-04 16:33:06 -0700 Randomize Gastronok's hair This is a little silly, but so's Gastronok. Gastronaut remains a player tile exclusive. -------------------------------------------------------------------------------- c08b2e8bf8 | nicolae-carpathia | 2022-05-03 17:09:34 -0400 Add the most nicolae demonic rune vault possible (#2260) * Add the most nicolae demonic rune vault possible I have reached my apotheosis: I have put a rune in a shop. Since the demonic rune repeats if you don't pick it up, I figured it would be the best option for a rune shop. (The abyssal rune also reappears if you don't pick it up, but the theme is easier to fit into Pandemonium.) If you already have the rune, the shop instead places another kind of rarity: a figurine of a ziggurat. (The only other really rare item I could think of was a quad damage, and I've been explicitly told multiple times that I'm not allowed to use those outside of Sprint. Tyranny!) Out of 25 generated shops, the stats on the price of a demonic rune: Minimum: 3804 Maximum: 8647 Average: 6640.76 St Dev: 1412.1 I didn't check the price stats on the zigfig because the rune is the real draw here. The vault also places fat stacks of cash, three other shops, and demon-summoning monsters from other branches as visitors. Enjoy! * Make adjustments to the pan bazaar rune vault Make some changes based on feedback from the other devs: 1) If you already have the demonic rune, instead of selling a zigfig, the central shop now just sells randarts. (I had underestimated the importance of zigfigs.) 2) The difficulty has been turned up a bit. The area outside the central area places more monsters now. 3) A few of the nonruniferous shops have been tweaked. -------------------------------------------------------------------------------- 277feda236 | gammafunk | 2022-05-03 11:26:53 -0500 fix: Remove an unused variable -------------------------------------------------------------------------------- d82a6b94f7 | gammafunk | 2022-05-03 11:11:21 -0500 fix: Adjustments to an arrival vault For `spicycebolla_arrival_teleportal_tutorial`, rename this vault to `spicycebolla_arrival_transporter_tutorial`, since the feature in question is called a transporter. Add a missing level connector to the path leading from the hatch. Remove some SUBST and SHUFFLE, relying in the default undefined glyph mapping to floor as well as the natural vault rotations that occur for variation. Reglyph and reorder transporter statements to straightforward entry/dest order, so the transporter definitions are easier to read. -------------------------------------------------------------------------------- 5102b3be25 | Nicholas Feinberg | 2022-05-02 18:34:57 -0700 Remove two-headed ogres from Lodul's band It's a bit mean to toss average 5, max 10 2-headed ogres at a D:9 player, much less accompany them with friends. Let's just make em basic ogres and see how that goes. -------------------------------------------------------------------------------- 84a40017fa | Nicholas Feinberg | 2022-05-02 18:15:34 -0700 Remove scrolls of holy word Scrolls of holy word are more or less the least interesting type of scroll currently in the game. They're irrelevant for the vast majority of the game, and when they are useful later on, it's not in a particularly interesting way. They don't create exciting situations or memorable moments, just inventory clutter. Let's cut em. TSO's holy word remains in place... for now. -------------------------------------------------------------------------------- fac262f41b | Nicholas Feinberg | 2022-05-02 18:15:34 -0700 New item: scroll of poison Inspired by the late and largely unlamented 'sea of fire' Ignis ability, the scroll of poison fills every unoccupied space on the screen with poison clouds for 10-20 turns. Early on, it can be a way to escape enemies or to attack them from range with impunity, especially with a source of rPois or some !curing. Later, it can damage enemies reckless enough to advance through, block more dangerous clouds, reveal invisible enemies, be ignited with Ignite Poison, trick enemies into walking into other clouds you've placed... and so on. It also can amuse Xom. It's closest to the condenser vane in use, but unlike the vane, it doesn't place clouds directly on enemies, place non-poison clouds, scale with Evo, or recharge. -------------------------------------------------------------------------------- 06c70da812 | advil | 2022-05-02 18:09:41 -0400 fix: remove =g inscription on autopickup ignore Otherwise autopickup gets stuck. This is similar to code that removes this inscription when explicitly dropping something. There's still a weird UI interaction with [a] and items that are being targeted for autopickup only because of a =g, but one that seems mostly harmless.. -------------------------------------------------------------------------------- 91724d5b39 | Nicholas Feinberg | 2022-05-01 16:16:31 -0700 Standardize screamitis conditions (ardl) Maybe don't scream at foxfires. -------------------------------------------------------------------------------- b5314be063 | advil | 2022-05-01 10:42:12 -0400 docs: document stair delays (catern) Previously, the stair-dancing penalty on re-entering levels was not documented except insofar as it was possible to notice it from the time indicator in-game. There's some discussion in the dev channel about whether this delay "matters", but if it exists, it should be documented at least minimally. Add a note to the manual and to the hints mode stair description. -------------------------------------------------------------------------------- d956c00756 | gammafunk | 2022-04-30 23:50:47 -0500 fix: Tweak monster placement in an early vault (dilly) For `dilly_guarded_unrand_morg`, the second-highest tier monster glyph probably shouldn't be an out-of-depth necrophage on D:2-D:3 when we're also placing either Natasha or phantom, both of which are pretty strong monsters at that depth. This vault is small and already places plenty of additional monsters. Have the second-highest tier monster simply be another derived undead on D:2-D:4, using it for something stronger only when the vault is placed at higher depth. -------------------------------------------------------------------------------- adf2fefa87 | Nicholas Feinberg | 2022-04-30 16:40:44 -0700 Fix natural_leader assignments The natural_leader field claimed to affect monster behavior, leading monsters to try to 'follow their leader'. This was a lie. The only effect that the field had was to credit the band leader for kills - 'killed by a 2-headed ogre (led by Lodul)'. This commit fixes documentation & adjusts many monsters. Notables include merfolk aquamancers/impalers/javelineers, Lodul, Josephina, Ilsuiw (+credit) and skeletal warriors, alligators, spriggan defenders (-credit). -------------------------------------------------------------------------------- c2b5878c41 | Nicholas Feinberg | 2022-04-30 14:06:13 -0700 Remove item destruction (Tukima^G) It's an unecessary gotcha/feelbad for Gozagites to permanently destroy weapons they've animated with Tukima's Dance. It also invites weird tactics - tukima-ing bad weapons to turn them into gold. Instead, don't. -------------------------------------------------------------------------------- a876b22402 | advil | 2022-04-30 09:43:04 -0400 fix: tweak rest/wait with inhibited regen Background terminology: CMD_REST triggers a "rest delay" if there's hp/mp/ancestor hp/barbs to rest off (details configurable), or a "wait delay" (which lasts a fixed amount of time) otherwise. Before this commit: * if you do CMD_REST with an inhibiting monster in view that can't reach you, a wait delay is started and lasts the full wait time (unless a reachable monster shows up of course). For example, a monster across deep water with no (direct-ish) path to you. * if an inhibiting monster that can't reach you enters view during either a rest or wait delay, it counts as safe and nothing happens, so if the monster stays in view, a rest proceeds infinitely (which gets detected and triggers a crash). A wait finishes normally. After this commit: * CMD_REST doesn't work at all with an inhibiting monster in view * both rest and wait delays are interrupted by an inhibiting monster, even if it can't reach you. We'll see whether this is annoying for some reason. A more nuanced behavior would be possible if there are common use-cases for waiting with an inhibiting monster that can't reach you in view. (It may still be possible to force an infinite rest by disabling seen monster interrupts. One complication here is that there is currently no particularly good way to detect when the -Regen status actually turns on, because it all happens indirectly. But possibly the game should also detect this and send a full_hp interrupt in this case.) -------------------------------------------------------------------------------- d383c6f625 | gammafunk | 2022-04-30 02:56:29 -0500 fix: Don't consider launcher skills for ammo gifts (elliptic) Before ammo removal in a8e9c987, Okawaru could gift ammo for launchers based on skill training. The gifting code wasn't updated for ammo removal, hence Oka is gifting excessive/unwanted throwing gifts for players with launcher skills trained. Update the relevant code to only consider throwing skill. -------------------------------------------------------------------------------- 921d912d32 | gammafunk | 2022-04-29 04:01:54 -0500 feat: Some adjustments to unrand vaults dilly_guarded_unrand_throatcut: Scale the monsters better with depth. Adjust the skeleton placement so that it's spread within each of the two rooms, so that both rooms always get skeletons. dilly_guarded_unrand_morg: Adjust monster set and placement to better scale with depth. Use spectral things and simulacra and a wight band for the single "boss" monster on D:5-7, and use either skeletal warrior or less commonly a death knight for the boss monster on D:8-D:9. Give the dead trees their usual custom description, and give them special coloring for console. dilly_guarded_unrand_devastator: Rework the monster list to better connect with the themes of Devastator, and improve scaling with depth. Use ogres as the basic threat, using normal ones for D:4-6 and two-headed ogres for D:7-12. Introduce one gargoyles for D:7-D:9, adding more for D:10-12, also adding a boulder beetle for that same range. Place the unrand centrally in the vault, and make all statues use the "orb" tile, since that visually best matches the theme. Closes #2527. -------------------------------------------------------------------------------- b676c2808e | dilly | 2022-04-29 04:01:28 -0500 Some guarded unrand vaults For Morg, Devastator, and Throatcut. Committer's Note: Squashed commits and reworded commit message. -------------------------------------------------------------------------------- 5854e031c7 | advil | 2022-04-28 15:45:11 -0400 fix: ignore some disabled interrupts in rest checks Before this commit, disabling rest interrupts could result in infinite rests (and then a crash on demand in code attempting to detect them). This commit changes things so that if hp or mp interrupts are disabled, they are not factored into whether a rest can be started -- so if both are disabled, resting actually becomes impossible (and a wait will be started instead). That is, a rest that can't be interrupted is never started. I think this may still have a weird interaction with ancestor_hp, which I don't quite understand and haven't changed. -------------------------------------------------------------------------------- 2d807254ef | advil | 2022-04-28 15:36:51 -0400 fix: hardcode an activity interrupt for barb removal No rc options should be able to trigger an infinite rest, but currently because of the way resting is implemented, if the regular interrupt conditions are satisfied before the barb duration is cleared, only a message interrupt (easily disableable) remains to stop the rest, making it easy to force an infinite rest. In the past this has typically happened by accident (e.g. as in 8ed1089bbe3), but it could also be used to force a crash on demand and reset levels. This commit takes a slightly hacky approach, and sends a full hp interrupt explicitly when barbs are removed. It doesn't seem worth adding a specific barb interrupt. But as long as barbs' interaction with resting is hardcoded (see player::is_sufficiently_rested), something hardcoded needs to happen on the end of a barb duration. -------------------------------------------------------------------------------- 8ed1089bbe | advil | 2022-04-27 19:24:32 -0400 fix: don't parse bad channels as no channel in runrest rc lines This was happening because the crawl code returns nil on the error case for parsing a channel name, which is then passed to crawl.message_filter as a channel arg. Since this function supports channel as an optional arg, nil maps to no channel (-1). So the gammafunk rc line `ignore += pray:` actually sets a runrest_ignore for basically any message. After this change, the code errors and prevents the line from being used at all, in line with what happens in channel parsing in initfile.cc. Also fixes a buggy ignore involving Jiyva. (Though probably this should only look for one word channel names?) Note that this doesn't fix a larger issue leading to this commit, which is that it is still possible to write runrest_ignore_message lines that trip the buggy rest ASSERT under the right circumstances. -------------------------------------------------------------------------------- 541a27f54d | Kate | 2022-04-26 21:19:08 +0100 Destroy melded cursed items on Ash abandonment They were just falling off instead, leaving the player with cursed items in their inventory. -------------------------------------------------------------------------------- ccd5be9afd | advil | 2022-04-26 13:57:08 -0400 fix: improve arena cancel/end behavior * Remove all delays on cancelling, these are just confusing. * Show popup if any trials have occurred, even if no explicit t:1 flag has been set. I guess it may not be super informative with only one trial, but there's no other good way to see the log if you want it. This includes even the cancellation case, but only if at least one complete trial has occurred. * Add some more messaging around cancelling. I wonder if there are interesting stats the final popup could show? While testing this I noticed all sorts of other flaky behavior. Sampling: Sometimes cancelling still results in a delay with a blank screen. In console when I hit space during the first trial, there is a redraw that wipes out half the banner. Sometimes the cursor shows up in an ugly way (but sometimes it doesn't). -------------------------------------------------------------------------------- 2679155cab | advil | 2022-04-26 13:57:08 -0400 fix: more consistent right click handling in main menu As noted in #2528, a bunch of main menu popups or submenus weren't correctly handling right clicks to exit. This should standardize the behavior. (Caveats: I still don't really understand why right click is best detected using `CK_MOUSE_CMD`, and I had do something a bit dodgy to get good handling of this for the seed/arena text entry boxes. Also, what would be much better is a click outside to close behavior, similar to how webtiles mouse handling works, which would probably address the touchscreen issues in that #2528.) -------------------------------------------------------------------------------- 7bc237e783 | Nicholas Feinberg | 2022-04-24 15:23:45 -0700 Nerf Vv melee again Post-602b31c20e3eccb, Vv became a lil too lethal. Move melee down to 35/35, from 45/45. -------------------------------------------------------------------------------- 7276a9ff7f | advil | 2022-04-24 13:56:04 -0400 refactor: misc opengl comments / refactoring This is not a very focused commit, just a bunch of tweaking and some commenting I added while trying to understand parts of this code a little bit better. -------------------------------------------------------------------------------- b366d0e2d1 | advil | 2022-04-24 13:42:24 -0400 fix: tile sheet tweaks for better packing This is basically an emergency patch to get the player.png tile sheet size below height 2048, which won't work as a long term solution for the relevant issues but can be back-ported to 0.28 at least. If the tile sheet size exceeds 2048, on local tiles, it requires a 1024x4096 size texture atlas. Any modern hardware will support this, but a non-trivial amount of older or cheaper hardware won't[1]. Before 0.28, we had been able to keep most tile sheets to 1024x1024 with the exception of wall.png and player.png, both at 1024x2048. This is still not ideal (https://crawl.develz.org/mantis/view.php?id=11378), but this is something like 1% of graphics cards these days, as opposed to 6% for not supported 1024x4096. Various additions in 0.28 pushed player.png up across this threshold. In the long run, it would be much better if tile sheets were automatically split up and the implementation weren't tied to the size of the tile sheet. However, the tech cost for doing this is really painful, as the local tiles buffer implementation is really deeply tied to the assumption that each texture atlas is stored in a single 2D texture. So since I was able to tweak things to get player.png down a bit, I'm going with that for now. [1] https://feedback.wildfiregames.com/report/opengl/feature/GL_MAX_TEXTURE_SIZE -------------------------------------------------------------------------------- 370832a12f | advil | 2022-04-24 13:23:57 -0400 fix: remove lava orcs ...from the tile sheet. -------------------------------------------------------------------------------- 0917bc69df | advil | 2022-04-22 15:41:51 -0400 fix: add a missing MF_ARROWS_SELECT check (elliptic) This was correct in webtiles, missing in local menu code. Practical impact: with `menu_arrow_control=false` this lets space act as page down (where before it would be a noop under this setting). -------------------------------------------------------------------------------- cb44be3569 | advil | 2022-04-22 12:56:40 -0400 fix: force build sqlite from contribs on msys2 This addresses the following issue (in a probably non-ideal way): on current msys2 `pkg-config sqlite3 --cflags-only-I` returns `-IC:/msys64/mingw64/include`. For reasons that aren't entirely clear to me (maybe just to suppress warnings) we sed -I into -isystem. This runs right up against https://github.com/msys2/MINGW-packages/issues/10761, breaking the build in a fairly basic way. It would probably be somewhat better to find a way to allow building of sqlite3 via pkg-config, but for now I'm just going to disable this, which does fix the msys2 build in my testing. Resolves #2440. -------------------------------------------------------------------------------- 7790a0e70a | Nicholas Feinberg | 2022-04-21 21:33:47 -0700 Tweak tile saturation (ardl, others) Make salamanders slightly easier to see in lava, and wind drakes slightly easier to see in shallow water. -------------------------------------------------------------------------------- bb8214d451 | Nicholas Feinberg | 2022-04-21 21:33:47 -0700 Buff Hat of the Bear Spirit (ardl) :berserk: -------------------------------------------------------------------------------- d15c067e26 | Nicholas Feinberg | 2022-04-21 21:33:47 -0700 Make allies default to attacking One of the most confusing and annoying things for players about allies is that, by default, they will not attack enemies. If you or your ally is hit by an enemy, or if you attack an enemy or order an attack, or if you tell your allies to wait/guard, they'll attack; otherwise they'll follow you uselessly. This feels buggy to players - understandably! Change allies to default to attacking enemies instead. This is a slight buff to summoning allies out of sight of enemies & a nerf to trying to sneak around while hanging out with allies, but hopefully is a net improvement to the player experience. -------------------------------------------------------------------------------- 46f7bbceaa | Nicholas Feinberg | 2022-04-21 21:33:47 -0700 Move D enemies that encourage retreating later (dilly) Certain monsters are designed to have 'strong phases' and 'weak phases'. Sky Beasts go invisible and visible; Death Knights turn their pain mirror on and off. It's often wise for players to retreat while those monsters are in their 'strong' state & to fight again later. With the addition of 'attacks of opportunity', this is sometimes more dangerous. To compensate, move death knights & sky beasts slightly deeper. -------------------------------------------------------------------------------- a87a4c8c21 | Nicholas Feinberg | 2022-04-21 21:33:47 -0700 Don't rate Damnation's damage (particleface) It's off the charts! -------------------------------------------------------------------------------- 1716ac0dbf | Nicholas Feinberg | 2022-04-21 21:33:47 -0700 Simplify damage rating display (ebering, elliptic) The "damage per time" display was more misleading than helpful, since it didn't account for enemy AC and also rounded delay aggressively. The latter is fixable, the former isn't. Since delay is displayed on the line above, let players do the math & simplify the damage rating down to a single line. -------------------------------------------------------------------------------- e2f44be95a | gammafunk | 2022-04-20 13:15:54 -0500 feat: Rebalance the slime special room Remove the dependency on absdepth, instead using simple monster lists conditioned by branch. We don't need weight scaling by depth for a vault placing only on Lair:$ and endgame branches. Remove the endoplasms completely, since they're total chaff, using more jellies instead in Lair and more slime creatures in Slime and Depths. Likewise don't use jellies in Slime and Depths. Nerf the amount of rockslimes, treating them on par with acid blobs as the top tier threats, favoring quicksilver oozes and to a lesser extent azure jellies. This tones down the vault in Lair:6 a good deal, but you're still getting two top tier slimes on-average, decent numbers of mid-tier slimes, and the removal of endoplasms. It will remain a quite nasty (and rare) Lair:6 vault that will cause the player to abandon the level for a while in many cases. The vault should also now pose a better threat in Slime and Depths with all the chaff removed; in these places the top tier slime monsters get higher weighting. We also introduce golden eyes and shining eyes in these branches. -------------------------------------------------------------------------------- 3af9d588a4 | gammafunk | 2022-04-20 13:15:29 -0500 feat: Simplify chances for special rooms For the `special_room` vault, currently there's a 0.5% chance to place this vault in Slime, a 1% chance to place this in Orc, Spider, Crypt, and Pan, and a 3% chance to place it elsewhere. There's no reason to have different yet extremely similar chances for this vault among the non-extended branches. This commit uses a 2% chance for non-extended branches and 1% for the Hells and Pan. This will reduce the frequency of special rooms somewhat, but the vault does have `allow_dup` and hence still has a decent chance of being seen one or more times for each complete game. The 1% chance for extended branches isn't quite justified either. Arguably it might have some impact on balance for the Hells. For Pan we have potentially infinite levels, so it may be good to reduce its frequency. I'll keep it at 1% in these branches and leave any adjustment to people wanting to tweak extended. -------------------------------------------------------------------------------- 5774675eae | gammafunk | 2022-04-20 12:58:52 -0500 fix: Clean up DES syntax -------------------------------------------------------------------------------- 24ffce5b50 | advil | 2022-04-19 10:25:44 -0400 docs: update map mode help with ctrl-c change Since 4d47a7520311 this no longer forgets item info. -------------------------------------------------------------------------------- 6efceafd81 | Neil Moore | 2022-04-19 01:00:30 -0400 Simplify calls to, and defaults for, clear_map(). Make the clear_items argument default to false, since that is usually (in fact, now, always) how we call it. No one currently calls clear_map() with clear_items == true or clear_mons == false, so this could be simplified even further, but I didn't want to take that step quite yet. Specifically, I didn't want to rename the function to "clear_map_monsters()" or such, since it does also clear clouds. -------------------------------------------------------------------------------- 4d47a75203 | Neil Moore | 2022-04-19 00:55:45 -0400 Clear monsters but not items, on Ctrl-C and X Ctrl-C. The idea being that, nowadays (unlike when these commands were introduced), most items cannot be moved or destroyed once they have been seen, so there is very rarely a reason to want to forget them. Arguably these commands should also forget corpses, since they do decay. But I did not want to add that extra complexity to clear_map's interface. -------------------------------------------------------------------------------- 1ff7896281 | Nicholas Feinberg | 2022-04-16 20:22:31 -0700 Simplify Lugonu's Bend Space Remove the damage component (tiny and irrelevant) and the chance of blinking monsters away from the origin (actively counterproductive). Make it much more likely to blink monsters away from the destination. Remove invocations scaling - Lucy's other abilities offer great incentive for invo training already, so there's no particular need to complicate this one. -------------------------------------------------------------------------------- 68df138881 | Nicholas Feinberg | 2022-04-15 09:20:30 -0700 Make hell knights into priests Make them evil without making TSO celebrate the deaths of 6/7 orcs. -------------------------------------------------------------------------------- af92d4a5d6 | Nicholas Feinberg | 2022-04-15 09:03:32 -0700 Make Hell Knights evil again (catern) Lost this when they lost Pain. Slightly hacky. -------------------------------------------------------------------------------- 76187f39e0 | Nicholas Feinberg | 2022-04-15 08:59:26 -0700 Cut naga warrior hp by 20% They're by far the top killer in Snake since their buff, and players note that their tankiness to killpower ratio is a bit high. Let's dial them back some. -------------------------------------------------------------------------------- b41bcbb86e | Nicholas Feinberg | 2022-04-12 15:46:29 -0700 No Usk piety for non-hostiles (Ge0ff) "how to tele-frag Crazy Yiuf with 0 Invo: 1. summon 100 spammals and slowly build up piety..." -------------------------------------------------------------------------------- b4c28e87c6 | Nicholas Feinberg | 2022-04-12 09:05:37 -0700 Fix/simplify damage rating + ench/slay Base damage was incorrectly treated as about twice as good as it is on average. Damage rates are now about 2x mean damage. -------------------------------------------------------------------------------- 5e1b129e87 | Nicholas Feinberg | 2022-04-12 08:47:45 -0700 Fix Yara's + Petrify (various) Dispelling the 'petrifying' status should not cause 'petrified'. -------------------------------------------------------------------------------- 4a08ba55a3 | Nicholas Feinberg | 2022-04-12 08:31:40 -0700 Remove brand damage rating Think it was more misleading than helpful. -------------------------------------------------------------------------------- 52719c12eb | Nicholas Feinberg | 2022-04-11 21:10:59 -0700 Display a 'damage rating' in weapon descriptions I don't like some parts of this (the brand rating should probably live with the brand description) but it's better than nothing, maybe. Let's see! -------------------------------------------------------------------------------- 0b05bf5e21 | Nicholas Feinberg | 2022-04-11 21:07:53 -0700 Describe monster unblindability (Lici) -------------------------------------------------------------------------------- 65376010d4 | Nicholas Feinberg | 2022-04-11 20:59:33 -0700 Fix penetrating launchers + throwing (particleface) Thrown items would inherit penetration from a wielded weapon (eg, the Storm Bow), allowing them to pass through enemies and shields. Fix this. -------------------------------------------------------------------------------- bb24c3b5da | Nicholas Feinberg | 2022-04-11 20:53:47 -0700 Simplify some throwing checks -------------------------------------------------------------------------------- 28c3e03cda | Nicholas Feinberg | 2022-04-11 20:47:21 -0700 Give Usk piety for summons and such Hopefully this isn't abuseable! It seems nice, though. -------------------------------------------------------------------------------- 72f4aa029e | Nicholas Feinberg | 2022-04-11 20:27:18 -0700 Simplify -------------------------------------------------------------------------------- 7bc3a90fb7 | Nicholas Feinberg | 2022-04-11 20:00:58 -0700 Don't recommend OgHu/TrHu (ardl) Since they can't throw the game anymore. -------------------------------------------------------------------------------- 050149af67 | Kate | 2022-04-09 18:03:57 +0100 Fix Delatra's Gloves not healing on lignification quaff-id (#2521) Adds a check for whether the gloves are worn before triggering the potion effect, so that as long as they're unmelded when the potion is quaffed the player will still be healed on quaff-id. Closes #2521. -------------------------------------------------------------------------------- 68df515428 | Neil Moore | 2022-04-04 18:38:01 -0400 Fix grammar for artefact bardings with Regen (jillest) Fixes #2514. -------------------------------------------------------------------------------- f1c400731a | Aliscans | 2022-04-02 14:55:46 +0100 FIX Remove an erronous "the" from a message. The player can see invisible monsters which are bribed, charmed or hexed. When the status is lost, the monster may suddenly vanish. This changes the message this generates from "You can no longer detect the Sigmund." to "You can no longer detect Sigmund.". The "the" is retained for non-unique monsters. -------------------------------------------------------------------------------- 9f8742066b | Nicholas Feinberg | 2022-04-01 20:59:30 -0700 End the day Fly away, little mayflies. Come again another day. -------------------------------------------------------------------------------- ad05b8d819 | hellmonk | 2022-04-01 00:19:50 -0400 mayflytaurs -------------------------------------------------------------------------------- b333ed421b | hellmonk | 2022-03-31 22:39:26 -0400 delete a buggy vault -------------------------------------------------------------------------------- d16b76e6b1 | Kate | 2022-03-29 20:54:26 +0100 Stop constriction on transforming into an immune form -------------------------------------------------------------------------------- 2ae49fcbb9 | Nicholas Feinberg | 2022-03-29 07:28:01 -0700 Replace Oka's Warrior title (Ge0ff) Duplicates a Fighting title. -------------------------------------------------------------------------------- af6dd05e2f | advil | 2022-03-28 20:38:42 -0400 fix: add some 0 checks for %s in quiver code mod 0 can result in a divide by 0 error (really, it's undefined per the spec). -------------------------------------------------------------------------------- b00dd7cb4b | advil | 2022-03-28 17:37:51 -0400 fix: clarify the conditions of a movement message As illustrated in a discussion on discord this morning, this message didn't succeed in explaining what the exact problem is. Make it more specific. -------------------------------------------------------------------------------- f2db06da9e | Nicholas Feinberg | 2022-03-28 10:32:14 -0700 Allow creeping frost animation to be disabled (Lici) -------------------------------------------------------------------------------- 43bc051769 | Nicholas Feinberg | 2022-03-28 08:04:08 -0700 Correct Weak status description (dilly) -------------------------------------------------------------------------------- cbd9eb2193 | Nicholas Feinberg | 2022-03-27 14:56:41 -0700 Prevent 'failure to reach' for protected allies If you can freely shoot through Hep ancestors, Fedhas plants, etc, you should probably be able to reach through them as well. -------------------------------------------------------------------------------- d3370f49d2 | Nicholas Feinberg | 2022-03-27 14:56:41 -0700 Narrow Amaemon's range some Cut D:12, Orc:1, and Lair:4 from the spawn range. Poor fella just wasn't getting any kills there. -------------------------------------------------------------------------------- 11dafa56b2 | Nicholas Feinberg | 2022-03-27 14:56:41 -0700 Make Parghit's will indomitable 100 -> 140. Make him a lil trickier to hex. -------------------------------------------------------------------------------- 4e025c60ea | Nikolai Lavsky | 2022-03-27 09:58:00 -0700 fix: display Irradiate damage in monster descriptions -------------------------------------------------------------------------------- ecccbbdb84 | Nicholas Feinberg | 2022-03-26 14:23:15 -0700 Nerf mummies (increase consumable generation) To further compensate for attacks of opportunity & to adjust difficulty downward, generate about 18% more potions and about 12% more scrolls. Might be good to do a second pass at this point and shave down weights of 'strategic' scrolls (?ew, ?ea, ?bw, ?amnesia, ?id, ?acq) somewhat. -------------------------------------------------------------------------------- 7fa12cc219 | Nicholas Feinberg | 2022-03-26 14:06:36 -0700 Actually simplify Majin-Bo damage ??doh -------------------------------------------------------------------------------- 093c7b3b58 | Nicholas Feinberg | 2022-03-26 13:42:19 -0700 Simplify Majin-Bo vampirism Majin-Bo has a great deal of variance, both strategic (not affecting demons/undead, forbidden by good gods) and tactical (heals for 1d at a 60% chance). Simplify by upgrading the healing to a 100% chance. -------------------------------------------------------------------------------- b34f9e133a | sdynet | 2022-03-25 09:45:25 -0700 Update Korean translation (gods.txt) Closes #2497. -------------------------------------------------------------------------------- e4682ce883 | Kate | 2022-03-24 19:01:32 +0000 Fix a yellow draconian acid splash check Don't splash onto battlespheres/spectral weapons/god-protected friendlies. -------------------------------------------------------------------------------- 543d47181c | Kate | 2022-03-24 19:01:32 +0000 Reword some attack prompts -------------------------------------------------------------------------------- defda700fc | Kate | 2022-03-24 19:00:30 +0000 Don't consider avatars valid targets for Cleansing Flame (surr) Prevents battlespheres/spectral weapons from giving prompts when activating Cleansing Flame, since the effect itself already ignores them. -------------------------------------------------------------------------------- efd9c33606 | Kate | 2022-03-23 15:48:29 +0000 Prevent piety troves from generating under Yredelemnul (hellmonk) -------------------------------------------------------------------------------- 4c793a2ed2 | Nicholas Feinberg | 2022-03-23 07:39:03 -0700 Disable AF_BLINK for AOOPs Crashes if the blink frog blinks into the player. -------------------------------------------------------------------------------- 3c90f9a769 | Nicholas Feinberg | 2022-03-21 17:24:01 -0700 Increase Hexer attack speed Compensating for the loss when monster attack went to speed 1. -------------------------------------------------------------------------------- 7659ce593d | Kate | 2022-03-19 11:41:59 +0000 Remove Haste from spell libraries on ancient save transfers It crashed when cast, since it's now a monster-only spell. Also clean up some duplicate checks for other spells that have been entirely removed. -------------------------------------------------------------------------------- da187f2e07 | advil | 2022-03-18 15:28:15 -0400 docs: fix/clarify runrest prepend vs append The docs are overall not very consistent, but for options where it matters, there seems to be a preference to teach ^= as the default. I've switched runrest_stop_message and runrest_ignore_message to this, since this is what you need to do to override defaults (in fact there was a non-working snippet here following 80dc71225541). I've also tried to clarify that ^= matters for the interaction of the two. -------------------------------------------------------------------------------- 497ad06e87 | Nicholas Feinberg | 2022-03-18 08:26:51 -0700 Remove self destructs of opportunity Fix a crash with creeping infernos and generally reduce surprising weirdness. -------------------------------------------------------------------------------- 83ea962da3 | Kate | 2022-03-17 17:11:21 +0000 Mark necromancy spellbooks as evil (#2491) Closes #2491. -------------------------------------------------------------------------------- 48ae54a172 | Kate | 2022-03-17 17:11:21 +0000 Fix messaging for -Potion/Scroll durations in Hell -------------------------------------------------------------------------------- fed8413159 | Kate | 2022-03-17 17:11:21 +0000 Adjust some mutation descriptions Clarify that demonic touch grants a new aux attack instead of changing the standard off-hand punch, and remove some redundant details for claws. -------------------------------------------------------------------------------- a4d04cda05 | Nikolai Lavsky | 2022-03-17 17:01:25 +0000 fix: add a space for fellow slimes Fixes a missing space in the monster list. -------------------------------------------------------------------------------- 9d40539af8 | Nicholas Feinberg | 2022-03-17 08:59:58 -0700 Improve creeping frost animation Display it as appearing on all cells that are adjacent to walls and don't contain visible allies of the caster. This should hopefully clarify how it works. -------------------------------------------------------------------------------- 2178c42546 | Nicholas Feinberg | 2022-03-16 12:26:16 -0700 Don't tell ball lightning to rot Fix a bug in which taking stairs while adjacent to ball lightning would claim the ball lightning 'stayed behind to rot'. -------------------------------------------------------------------------------- 92b06acc75 | Nicholas Feinberg | 2022-03-16 12:19:52 -0700 Mark Anguish as dispellable (Dinky) It is magical, after all. -------------------------------------------------------------------------------- 2a1340cf14 | Nicholas Feinberg | 2022-03-16 12:18:11 -0700 Bump up shadow dragon scales AC From 10 to 11. Puts em a bit higher than storm dragon scales, but with an arguably worse innate ego, and still a point below gold dragons. -------------------------------------------------------------------------------- 41199d4a87 | Alex Jurkiewicz | 2022-03-15 11:12:25 +0200 Add MUT_DEVOUR_ON_KILL description -------------------------------------------------------------------------------- 0902485e31 | Alex Jurkiewicz | 2022-03-15 11:12:25 +0200 Convert Ghoul devour-on-kill to a mutation This behaviour was previously hard-coded. I considered an alternate implementation of creating US_HUNGRY_UNDEAD. This ended up creating a lot more code and making undead state checks more complex, so I discarded it. -------------------------------------------------------------------------------- f9362112df | advil | 2022-03-13 17:01:39 -0400 docs: improve keymap documentation in options guide The main point of this change was to add K4, which was missing entirely, but I cleaned up and clarified a bunch of other things here. -------------------------------------------------------------------------------- a02f740833 | Perry Fraser | 2022-03-12 22:16:33 +0000 fix: remove surprious space in regen description -------------------------------------------------------------------------------- 1fd2556b9a | Nicholas Feinberg | 2022-03-12 08:44:37 -0800 Prevent opportunity attacks from slower monsters When moving away from monsters that move more slowly than the player, don't allow those monsters a chance at launching an opportunity attack. Such attacks are unintuitive and don't serve any design purpose. This affects the worm vs human and most monsters vs felid/spriggan dynamic. -------------------------------------------------------------------------------- 0ef121a99b | Kate | 2022-03-12 15:48:41 +0000 Add a (redundant?) orb check Preventing pickup AI from considering orbs for two-handing/dual-wielding monsters. -------------------------------------------------------------------------------- d808a8bb3c | Kate | 2022-03-12 15:45:21 +0000 Allow gifting orbs to Beogh orcs Giving your allies orbs of mayhem is now possible, if potentially unwise! -------------------------------------------------------------------------------- 7c249980d5 | Kate | 2022-03-12 15:40:29 +0000 Update a hint To reflect the fact that orbs also take up the offhand slot, for ranged weapon users. -------------------------------------------------------------------------------- 1c2307e1b3 | Nicholas Feinberg | 2022-03-12 07:05:33 -0800 More early-game monster nerfs In the interest of adjusting difficulty, tune down base damage and/or HP slightly on adders, phantoms, scorpions, and Sigmund. -------------------------------------------------------------------------------- 1251d06ae9 | Kate | 2022-03-12 14:51:58 +0000 Don't let monsters wield two weapons and a shield No more 3-handed blademasters. -------------------------------------------------------------------------------- e21a839c99 | Nicholas Feinberg | 2022-03-12 06:43:05 -0800 Make hunters more dextrous Since that's quite important for them now. -------------------------------------------------------------------------------- 389c0b56f3 | Edgar A. Bering IV | 2022-03-08 17:28:25 +0200 docs: fix changelog (gammafunk) -------------------------------------------------------------------------------- 17cd264cf9 | Edgar A. Bering IV | 2022-03-08 17:23:29 +0200 docs: update changelog -------------------------------------------------------------------------------- 8310661d2b | Edgar A. Bering IV | 2022-03-08 16:10:51 +0200 fix: don't give frightened monsters opportunity attacks (iamserjio) -------------------------------------------------------------------------------- 84ccd498e3 | Edgar A. Bering IV | 2022-03-08 08:33:34 +0200 wip changelog -------------------------------------------------------------------------------- d4eb659eea | advil | 2022-03-07 17:16:21 -0500 fix: allow anon spectating I guess everyone assumed that this was disabled because of account hold stuff and that's why no one told me this was broken, but it was just broken by mistake. -------------------------------------------------------------------------------- 1586fc07ea | Kate | 2022-03-07 02:03:29 +0000 Adjust an ice cave entrance ice_cave_statue_garden_transporter could place fast simulacra so close to the player that they couldn't safely leave if they decided to immediately abandon the vault after entry. Put the exit adjacent to the entrance, and move some of the monsters further away. Nagas and Chei worshippers are still out of luck against harpy simulacra, but at least can't get constricted by anaconda simulacra when trying to leave. Nagas of Chei simply suffer (and maybe this and similar portal vaults should be reworked further to make leaving safely always be possible). -------------------------------------------------------------------------------- 2e7ade144c | hellmonk | 2022-03-06 20:15:57 -0500 brutally nerf baileys Baileys had a very high kill rate and closing attacks probably make it worse. -------------------------------------------------------------------------------- 5627465c62 | Kate | 2022-03-06 17:27:00 +0000 Fix Ignite Poison's targeter leaking information It displayed the locations of invisible poisoned monsters - don't count them during the spell tracer. -------------------------------------------------------------------------------- e8b325be47 | Nicholas Feinberg | 2022-03-06 07:05:14 -0800 New Vv and Zenata tiles (Sastreii) Oooooh -------------------------------------------------------------------------------- f56f883ddd | Nicholas Feinberg | 2022-03-05 11:16:01 -0800 GOOE adjustments - Remove rPois (why is it there? Predates Stone Soup) - Remove from Depths - Roughly double Vaults weight, replacing wizards Try to have em place somewhere they have a chance of working. -------------------------------------------------------------------------------- b1efcce96a | Nicholas Feinberg | 2022-03-05 11:05:07 -0800 Uncomment a very important line (Yermak) Oops! -------------------------------------------------------------------------------- d32acbc352 | Nicholas Feinberg | 2022-03-05 10:57:33 -0800 Show LRD damage in monster desc (ardl) -------------------------------------------------------------------------------- 404d694432 | Nicholas Feinberg | 2022-03-05 10:49:50 -0800 Unrand tweaks - Glaive of the Guard: ench +8 -> +5. Ludicrously strong. - Damnation: 3d14 -> 2d14. Compensation for ammo removal. (Funny alternative: drain on fire...? Probably better not.) - Gyre & Gimble: ench +7 -> +12. Make it more competitive with non-unrand short blades. -------------------------------------------------------------------------------- d12d1d25ed | Nicholas Feinberg | 2022-03-05 10:46:01 -0800 Swap radroaches and meliai in spider Latter seem more threatening in practice. -------------------------------------------------------------------------------- f2a2391c1e | Nicholas Feinberg | 2022-03-05 10:44:31 -0800 Reduce meliai Spider gen Too rude. -------------------------------------------------------------------------------- 7e222a1f62 | Nicholas Feinberg | 2022-03-05 10:39:53 -0800 Reduce merfolk net gen (meowsim) To reduce "chain netting" of the player & general overabundance of nets in Shoals, drop from a 1/4 to 1/8 chance of any given merfolk spawning in with a throwing net. Average drops from 8.4 to 4.5 nets per Shoals. -------------------------------------------------------------------------------- d469af4107 | Nicholas Feinberg | 2022-03-05 10:06:57 -0800 Implement closing attacks An experimental way to discourage long-distance luring or so-called 'pillar dancing', which tends to be rather repetitive and not very fun. Gives monsters a 1/3 chance to get a free attack when the player moves away from them. This only costs energy for enemies that attack slowly, like ogres and juggernauts. Wu Jian martial attacks & rampaging give immunity, and monsters that don't move fast enough to follow you can't attack. This should have a minimal impact on most normal fights, and even allow repositioning across a reasonable distance with adjacent enemies. -------------------------------------------------------------------------------- 7d8c13d22b | Nicholas Feinberg | 2022-03-05 10:06:57 -0800 Revert "Re-randomize energy temporarily" Obsoleted by closing attacks. This reverts commit 333b8329f1cbc402d63d599db9b7d6ba7397d29b. -------------------------------------------------------------------------------- a581b86abd | Nicholas Feinberg | 2022-03-05 10:06:57 -0800 Don't recommend pillar dancing Fie! -------------------------------------------------------------------------------- eff9672185 | Nicholas Feinberg | 2022-03-05 10:06:57 -0800 Improve characters' starting kits (Hellmonk) One of the most interesting and exciting decisions in Dungeon Crawl is when and where to use your consumable items. In the very early game, characters may not yet have any consumables, which diminishes the tactical aspect of the game. So, let's try to give most characters some options which, if used wisely, can help them with a tough situation. - All 'mages' ('pure casters') start with a potion of magic. - Gladiators get a throwing weapon; javelin, large rock or boomerangs. - Monks get a potion of ambrosia. (See, it's divine.) - Hunters get a scroll of immo. - Brigands get an additional poisoned & curare dart. - Artificers trade their xom piece for nine charges of iceblast. - Wanderers get an additional random potion or scroll. - Delvers get nothing, for now, since I'm already pretty happy with how they play. They're a challenge anyway, really. :) - Berserkers and Cinder Acolytes likewise get nothing. They already have perfectly good early game buttons. - Abyssal Knights start at 60 piety (just over 2*) instead of 38 (just over 1*). This should allow them to use Bend Space if needed. (I think they're still quite weak.) - Chaos Knights get Artificer's xom chesspiece. - Transmuters get a potion of lignification, which should work well with their unarmed combat focus. It's also very thematic. - Warpers get more boomerangs of dispersal. - Arkane Markspersons get a scroll of vulnerability. - Enchanters get another potion of invisibility. - Fighters are unchanged. This should also be a nice compensation for various recent changes that increased early game difficulty. -------------------------------------------------------------------------------- 6e15ea0a97 | Nicholas Feinberg | 2022-03-05 10:06:57 -0800 Weaken early spawns somewhat Take top killers and make em a bit less common. (Ogres, centaurs, water moccassins, 2hos, and hydras.) Also move Harold a bit deeper. Lad is a terror. -------------------------------------------------------------------------------- 614883fcd9 | Nicholas Feinberg | 2022-03-05 10:06:57 -0800 Make ogres attack more slowly To make their gimmick more noticeable and easier to reason about, make em swing at 1.5 aut/per instead of 1.3. Buff damage slightly, but not enough to fully compensate (ignoring AC). Change 2HOs, ogre mages, Erolcha, thunderhulks and Lodul to match. Considered including ettins too, but it might be a bit much... -------------------------------------------------------------------------------- 68b12284db | Edgar A. Bering IV | 2022-03-05 15:37:22 +0200 docs: update CREDITS.txt -------------------------------------------------------------------------------- 24134d049f | Perry Fraser | 2022-03-05 15:22:12 +0200 fix: make color tags render in MessageRegion [ Closes #2302. ] -------------------------------------------------------------------------------- 80730f7218 | Kate | 2022-03-04 22:09:13 +0000 Improve wording in ranged weapon descriptions -------------------------------------------------------------------------------- 811e9ec5e5 | Kate | 2022-03-04 22:09:13 +0000 Reduce the amount of wand charges in a shop The gimmick of the vault is overcharged wands, but guaranteeing the maximum number of charges is already a significant amount compared to normal generation, so giving a 66% bonus on top of that was excessive. Reduce it to 25%, and slightly reduce the prices. -------------------------------------------------------------------------------- cad78a6a97 | Aliscans | 2022-03-04 22:32:03 +0200 feat: don't highlight Vehumet offers if you also have book learning. This changes the meaning of "blue spell at the top of the list" from "spell Vehumet is offering you" to "spell which is only available because Vehumet is offering it to you". Vehumet can withdraw the offer, but you cannot lose the book. This change doesn't affect the religion screen. Co-authored-by: Aliscans -------------------------------------------------------------------------------- 3d610745aa | Nicholas Feinberg | 2022-03-04 11:33:08 -0800 Add mon-death asserts Try to hunt down an odd rare crash. -------------------------------------------------------------------------------- 0cb962c1f0 | Antanishin, Ernest | 2022-03-04 19:58:56 +0200 feat: add tile_sidebar_pixels option The option allows one to resize inventory and spells icons in local tiles. It works in the same way as tile_cell_pixels for the dungeon tiles. [ Committer's note: Closes #2147, renamed option. ] -------------------------------------------------------------------------------- e5966c3f1e | Nicholas Feinberg | 2022-03-04 06:57:57 -0800 Tweak Sheza's Dance cast messages (SpicyCebolla) -------------------------------------------------------------------------------- 1a685ed5de | Edgar A. Bering IV | 2022-03-04 16:56:40 +0200 feat: distinguish drain levels in monster list (Aliscans) Closes #2411 -------------------------------------------------------------------------------- 85c4641d08 | Aliscans | 2022-03-04 16:08:38 +0200 feat: add annotations for distracted monsters Most of the reasons for a monster_info having MB_DISTRACTED give a description when the monster is selected on the level map, but not all. This creates two flags to fill in the gap. Monsters which you can see, but which can't see you because of invisibility, are described as "can't see you" in the examine surroundings command and monster list summary. Monsters which are distracted (possibly because they are attacking a summoned monster rather than you) ar described as "not watching you" or as "distracted". Co-authored-by: Aliscans -------------------------------------------------------------------------------- 602b31c20e | Nicholas Feinberg | 2022-03-03 20:06:52 -0800 Revise new uniques I'm quite happy with how Amaemon is doing post-nerf, but the others don't seem to be all there yet. Let's adjust. - Lodul: +8 avg mhp (62 -> 70) - Parghit: +large rocks, +damage (50/40/40; was 40/35/35). - Josephina: +HD (15 -> 18), +damage (10 -> 27), +HP (130 -> 150), +cast frequency (Seracfall 24 -> 36), +flash freeze - Vv: +damage (27/27 -> 45/45), +HD (21 -> 23), +HP (210 -> 270), +Will (120 -> 140), +25% cast frequency - Zenata: -HD (18 -> 15), -HP (240 -> 180), move from Depths/Zot to Elf/Vaults/Crypt, haste dancing weapons on cast. Also fix the Sheza's Dance casting message. -------------------------------------------------------------------------------- 4b928d7a4c | Nicholas Feinberg | 2022-03-03 19:49:42 -0800 New unique tiles (Sastreii) Amaemon, Josephina, and Parghit. Also properly display weapons for the former two - I initially forgot to have them show held weapons. -------------------------------------------------------------------------------- 20d21d4356 | Edgar A. Bering IV | 2022-03-03 23:35:32 +0200 lint: checkwhite -------------------------------------------------------------------------------- 645c86315e | Edgar A. Bering IV | 2022-03-03 23:15:23 +0200 vaults: fix a typo -------------------------------------------------------------------------------- dd60b7245b | RojjaCebolla | 2022-03-03 23:01:03 +0200 vaults: two arrivals by spicyCebolla spicycebolla_arrival_teleporter_tutorial Teleporters generally only show up in dangerous scenarios; this puts a pair of teleporters into an arrival vault for people to play with. These can also be used to juke gnolls and panlords, in times of need. (Inspired by the "throwing tutorial" key holder vault in Brogue, which shows up early and often in dungeon generation, helpiing the player learn that items can be thrown to trigger traps from a distance.) spicycebolla_arrival_xxxplode Minmay style. [ Committer's note: cleaned up some des, moved organization to small, fixed a teleport closet. Closes #2458 ] -------------------------------------------------------------------------------- 0f8c3457c7 | DreamDust | 2022-03-03 22:28:46 +0200 vaults: minivaults by DreamDust dreamdust_wishing_well Mini vault featuring a wishing well with some gold sprinkled around it. There's a small chance of a scroll of acquirement generating. Partially inspired by Nethack, + some nostalgia for when we used to be able to quaff from magic fountains in Crawl. [ Committer's note: simplified the terrain, the effect will be a bit more subtle but that's fine. ] dreamdust_mushroom_princess Just a simple vault featuring a princess statue surrounded by mushrooms. dreamdust_princess_bridge A bridge over a pond and a little courtyard area off to the side. dreamdust_princess_corridor A decorative corridor with three variations: summer, fall, and abyssal. [ Committer's note: also simplify some feature renames in a previous DreamDust vault, don't want to go overboard with these. All vaults edited based on review by hellmonk. Closes #2135 ] -------------------------------------------------------------------------------- 12ad11c1a6 | DreamDust | 2022-03-03 22:28:46 +0200 vaults: a DreamDust overflow temple A fancy temple dedicated to the three good gods. [ Committer's note: converted to an overflow temple ] -------------------------------------------------------------------------------- e8bc28a0cf | DreamDust | 2022-03-03 22:27:54 +0200 vaults: float vaults by DreamDust dreamdust_dug_too_deep The dwarves dug a little too deep and unearthed... a Balrug! Even a mighty dwarf hero (with a potentially good weapon to loot!) fell in battle to the demon. RIP. Maybe this is why we don't see deep dwarves much anymore. Hmmmm... The idea behind this vault is to place a single Balrug early enough that it's a serious (but not unmanageable) threat. I added a downhatch close by if players need to escape in a hurry. There are also warning signs in advance (all the dwarf corpses and the suspicious volcanic floor tiles outside the Balrug room). [ Committer's note: Added a runed door for the balrug, adjusted transparency, traded volcanic floor for blood. ] dreamdust_wu_jian_sword_trials A Wu Jian-themed vault. Challenge three increasingly powerful sword-wielders for their increasingly good swords. [ Committer's note: Adjusted depth range, added monsters to the earlier trial, trimmed arenas, added transperency. ] dreamdust_merry_men Inspired by Robin Hood and his band of merry men. Features a forest with a bunch of archers and a good bow and aides to banditry to loot in the center. [ Committer's note: Adjusted layout to prevent teleport closets, monster counts, loot. ] dreamdust_tengu_aerie A large nest of tengus. They keep their shiny loot in the center... along with their fledglings (wait, are we the baddies??). [ Committer's note: moved the crystal walls to the middle, put the rock wall on the outside (so the reavers can bolt bounce their omnibolts), and thinned the monster density. ] dreamdust_hydra_shepherd A shepherd is raising a flock (?) of hydras down in the Depths! Some players might regret abandoning their flaming weapons after finishing Lair/Swamp, haha. [ Committer's note: upgraded the cyclops to a stone giant, added a small chance for a really high head count. ] dreamdust_elfheim The home of Duvessa and Dowan. The more-practical Duvessa has training dummies in her room, while the vain Dowan has a large mirror to admire himself with. [ Committer's note: cut down on custom tiling/colouring a bit. ] -------------------------------------------------------------------------------- 7b655af5e2 | DreamDust | 2022-03-03 20:48:24 +0200 vaults: arrivals by DreamDust dreamdust_arrival_beginning_and_end Arrival vault that resembles the central orb chamber in Zot:5. Thought it would be cute (especially for new players) to realize it at the end of the orb run. dreamdust_arrival_sigmund_warning Beware the dreaded Sigmund, slayer of noobs! (and everyone else tbh, lol) -------------------------------------------------------------------------------- 0dae59b3db | DreamDust | 2022-03-01 21:11:17 +0200 Seven new vaults [ Committer's note: Edited accounting for gammafunk's feedback, thinned monster densities in a few places. Closes #2184. ] dreamdust_cave_troll Just a deep troll tucked away in a little cave. Using orient:northwest because I like how it looks when the level generator makes a path to the vault. Feels like a nice, cozy cave deep in the rock. dreamdust_gnoll_farm Just some simple gnoll farmers trying to make an honest living. dreamdust_gnoll_shepherd A cute little gnoll shepherd and his flock of dream sheep (or herd of yaks). dreamdust_wasp_nest A wasp/hornet nest! dreamdust_looks_like_rain A portal to the elemental plane of air briefly opened and spat out some clouds and monsters! dreamdust_zin_vs_xom Zin and Xom are having a skirmish in Zot. I think it's a nice contrast between Order and Chaos. dreamdust_under_siege The general idea is that you have a chance of going down some stairs and finding yourself in a little fortress under siege (usually by a swarm of undead). -------------------------------------------------------------------------------- 1125b37a9b | Nicholas Feinberg | 2022-02-28 17:35:56 -0800 Describe eruption damage in xv (ardl) This is a hack; the correct fix would be to make a zap. -------------------------------------------------------------------------------- 162f3ce599 | Nicholas Feinberg | 2022-02-28 17:21:31 -0800 Fix @ display for launchers with armour Broken by 9445043ebcbc046d65807a91ab1288053957184b. Closes #2450. -------------------------------------------------------------------------------- 945431f764 | Implojin | 2022-02-27 21:53:51 +0200 feat: add a new randart name of @god_name@'s Attic -------------------------------------------------------------------------------- 230a35465e | RojjaCebolla | 2022-02-27 21:52:43 +0200 text: new adjective and verbs for ran dart names, plus usage * Teach Trog adjectives and verbs example item names now possible: the Foo... (general) of Hungering Death of the Rescuing Gods of the Glowing God of Uskayaw, Screaming (trog) of Glamorous Victory of the Hopping Regicide of Barnacled Death (oka) of Okawaru, Healing (xom) "Xom, Gnashing and Baking" of Healing Xom -------------------------------------------------------------------------------- ce1ebfb2c9 | robertxgray | 2022-02-27 14:45:29 -0500 Update typed-ast to 1.4.3 This is required to run the server on Python 3.10+ -------------------------------------------------------------------------------- cf85d113b3 | Diego Essaya | 2022-02-27 14:40:39 -0500 fix: click + key modifier detection in tiles Fixes #898 -------------------------------------------------------------------------------- 9cf36f4b4d | RojjaCebolla | 2022-02-27 20:20:21 +0200 feat: remove identification scrolls from troves In the past year, identification scrolls have become increasingly less important as gear now is automatically identified, and never cursed. By the time players get into a trove, they generally will have no further use for scrolls of identify, so those should be removed from the trove.good_scroll table. In their place, we now have immolation scrolls, which are a fun tool for safely fighting large armies, and torment scrolls, so that these troves can be just as fun for demons/undead as they are for other species. These two additions are equally as common as scrolls of holy word. Finally, a small chance of the very powerful summon scroll. -------------------------------------------------------------------------------- ba8e22afda | Nicholas Feinberg | 2022-02-27 10:08:25 -0800 Move mu necro enhancers earlier XL 13/26 is too late to be relevant. Shift to XL 3/13 instead. -------------------------------------------------------------------------------- 54f80b8ed5 | Elliott Bernstein | 2022-02-27 20:08:00 +0200 fix: when felid has 2 lives, show actual died-now xp needed for next life Co-authored-by: Elliott Bernstein -------------------------------------------------------------------------------- b3188875b7 | Nicholas Feinberg | 2022-02-27 08:25:02 -0800 Adjust wight/necrophage XP They're pretty similar threats. Move necrophage to about 80 XP (from about 120, higher than a black bear or ogre) and bump wights to about 75 XP (from 60ish). -------------------------------------------------------------------------------- 7cd8c5c774 | Nicholas Feinberg | 2022-02-27 08:17:44 -0800 Tweak Phial of Floods description Clarify air breathing requirement. -------------------------------------------------------------------------------- 5b244fca1f | advil | 2022-02-26 09:48:58 -0500 fix: handle undefined item slots with action_panel_glyphs=true This can specifically cause a crash when dropping an artefact and then picking up something in the same slot, where it tries to get a glyph on an undefined item_def and artefact-related properties are in an inconsistent state. Possibly a pseudo-bug that flags are not reset for this case, or that get_item_glyph tries to do something for this case? (I think otherwise, this call was mostly was stable.) Resolves #2434 -------------------------------------------------------------------------------- ceb61267dd | advil | 2022-02-25 17:02:44 -0500 fix: improve some randart name grammar seems to need a determiner or noun. (I'm still not sure this is the most coherent randart name I've ever seen.) -------------------------------------------------------------------------------- 51b9c0fbd8 | gammafunk | 2022-02-25 09:59:46 -0600 fix: Remove a ghost vault restriction For ebering_ghost_funeral_grove, remove the restriction preventing Swamp:$ placement, since it no longer uses trees for its outer border. -------------------------------------------------------------------------------- 0a02b1cf4f | Nicholas Feinberg | 2022-02-24 17:15:28 -0800 Don't spawn Amaemon on D:7 Too rude. -------------------------------------------------------------------------------- f2abdc9806 | Nicholas Feinberg | 2022-02-24 13:48:19 -0800 Tweak frog hop targeter Don't show known invalid destinations as possible (occupied by actors, such as the player, or dangerous terrain). -------------------------------------------------------------------------------- ce79c09f71 | Nicholas Feinberg | 2022-02-24 08:03:50 -0800 Remove D skeletons too Missed em in the last commit, whoops. -------------------------------------------------------------------------------- 0c351c38d6 | Nicholas Feinberg | 2022-02-24 07:31:53 -0800 Bump down Amaeemon's HP/HD He was doing a little more direct damage than I wanted. HP from 92.5 to 87.5, HD from 10 to 7 (reducing accuracy and poison damage). -------------------------------------------------------------------------------- 29cdfe4e04 | Nicholas Feinberg | 2022-02-24 07:23:26 -0800 Remove most D zombies (hellmonk) Zombies aren't very exciting enemies. They're like other, existing monsters, except they don't have any cool gimmicks or definining features that those monsters have, and they make a bunch of nice items (poison darts/spells, ice magic, necro magic) useless. They're also not great for UI - it's harder to tell at a glance what you're fighting, or how tough it is. Let's cut em from normal D spawns. This is an early-game TSO nerf, but probably an overall buff to players. -------------------------------------------------------------------------------- 17f627cfee | Nicholas Feinberg | 2022-02-23 18:59:54 -0800 Fix missing regen space (ardl) -------------------------------------------------------------------------------- c45ea81df0 | nicolae-carpathia | 2022-02-23 21:42:27 -0500 Fix an error with a generic overflow vault that is NOT how the shuffle command works, did i write this at two in the morning, damn -------------------------------------------------------------------------------- 748a509809 | advil | 2022-02-23 18:55:44 -0500 fix: sanity check item quantity surely it is safe to add such a simple sanity check to low level item code, right? -------------------------------------------------------------------------------- 18cb72b20d | advil | 2022-02-23 18:33:38 -0500 fix: more info on invalid item tags.cc crashes The error for item_def::is_valid() had messaging, but it uses dprfs so wasn't visible in crashlogs. Since the game is going to crash anyways, let's actually print out these error messages. I've also reworded a bunch of them. -------------------------------------------------------------------------------- 9445043ebc | Nicholas Feinberg | 2022-02-23 09:27:28 -0800 Don't slow clumsy bashes with armour When attacking with launchers. -------------------------------------------------------------------------------- 989f1d9ccb | Nicholas Feinberg | 2022-02-23 08:33:23 -0800 Bring back Summon Scorpions tile Forgot this when adding Amaemon, whoops! -------------------------------------------------------------------------------- 7b0a884809 | advil | 2022-02-23 09:05:10 -0500 fix: tweak wording in a rampage prompt Rampaging is in general fine for wielded_weapon_check; it's only if your rampaging would trigger an attack that this verb is used in messaging. -------------------------------------------------------------------------------- f982a884d8 | Nicholas Feinberg | 2022-02-22 22:04:18 -0800 Remove anguish on leaving levels Maybe the cause of the mystery anguish bug..? Also, I hate this switch quite a lot. -------------------------------------------------------------------------------- 4a66f2e2b5 | Nicholas Feinberg | 2022-02-22 20:59:03 -0800 Allow LRDing Vvurtles (Nomi) Oversight! -------------------------------------------------------------------------------- 235afadefe | Nicholas Feinberg | 2022-02-22 18:54:55 -0800 Update job recs for og/tr (Lici) Now that you can't start with large rocks as Hu or AM, don't recommend them to trolls or ogres. AE background rec for ogre is semi-arbitrary. Seemed to have a high recent winrate for not excessively dubious reasons (wasn't a nem choice, wasn't one player streaking, etc). Seems reasonable for apts and so on (bouncing less dangerous when you have high HP). Might add Gl as a rec if a-good-start lands. -------------------------------------------------------------------------------- 8e21839460 | Nicholas Feinberg | 2022-02-22 18:42:21 -0800 Don't mention monster ammo When cursoring over a monster, and printing something like Here: a centaur, wielding a +0 shortbow, quivering arrows Cut the bit about 'quivering arrows'. Meaningless verbiage :) -------------------------------------------------------------------------------- 7cd6805d08 | Nicholas Feinberg | 2022-02-22 18:35:08 -0800 Fix: Don't slow throws with armour (Yermak, 12688) Oops! -------------------------------------------------------------------------------- 2e1b08cf00 | advil | 2022-02-22 21:25:47 -0500 feat: readd quivering/firing ranged weapons It's proven somewhat confusing to many players that the relevant UI elements no longer worked with launchers after ammo removal. This commit restores the ability to quiver launchers, allowing them (if quivered) to be triggered on default keybinds using `f` and `p`, as well as `v` and tab regardless of what is quivered. I've restored some corresponding options as well. It's entirely possible their defaults should be different than they used to be, if these are better viewed as compatibility options now. But for now, launchers are in the fire order (this never got removed), and `launcher_autoquiver` defaults to true. -------------------------------------------------------------------------------- 015645fbfe | advil | 2022-02-22 21:25:47 -0500 feat: add an explicit toss submenu Tossing is currently in a weird state where as more and more things become quiverable, they have two types of actions that could apply, making them harder to figure out how to toss. This is all sort of still in a mess for other menus, but this (quite basic) submenu is guaranteed to always use `ammo_to_action` and therefore only throw. -------------------------------------------------------------------------------- c7997b95f3 | Nicholas Feinberg | 2022-02-22 12:05:53 -0800 Launcher reform: update sling descriptions RIP rock v sling bullet dynamic -------------------------------------------------------------------------------- 542faf17db | Nicholas Feinberg | 2022-02-22 08:10:15 -0800 Fix a Jiyva jelly crash (?) If the player is damaged by a monster that's already dead (eg a guardian golem's inner flame), don't try to point jellies in its direction. I couldn't repro the crash, so not sure about this fix. -------------------------------------------------------------------------------- 28b64116f0 | Nicholas Feinberg | 2022-02-22 07:29:36 -0800 Roll-back post-AEVP delay launcher buffs When adding AEVP to launcher delay in af6a381e141a, I'd assumed that would be a considerable nerf that called for compensation. With the change to use dex for launcher damage shortly after, however, that no longer seems called for. Revert to more or less the weapon stats from a852ce8369264a3a4759b99df0bbba7645a78c97. -------------------------------------------------------------------------------- e3fb4bd5a4 | Nicholas Feinberg | 2022-02-21 19:05:10 -0800 Re-add launcher to-hit display (pdpol) This is a bit of a hack. Closes #2438. -------------------------------------------------------------------------------- 79605ca0cb | advil | 2022-02-21 19:50:11 -0500 fix: hide account hold div on force-logout Unintentionally still displayed after an account gets force logged out when an account hold is escalated to a ban. -------------------------------------------------------------------------------- 36e498a9cf | advil | 2022-02-21 19:50:11 -0500 feat: improve account-related logging This more consistently shows the IP address, and puts a substring that is very easily matched for scripts that want to pull out account-related logging from the main log. (This only will reliably log things that happen while a player is connected, so releasing a hold or removing a ban still won't show up here.) -------------------------------------------------------------------------------- 6e3aafee17 | Nicholas Feinberg | 2022-02-21 15:00:42 -0800 Fix fix -------------------------------------------------------------------------------- a21e45360d | Nicholas Feinberg | 2022-02-21 14:58:04 -0800 Fix kaux/ckaux Broken in 4e44252f3f24252e461ee3764b93ec7b8ad007b5, 9 months ago. -------------------------------------------------------------------------------- c9553a8f79 | Nicholas Feinberg | 2022-02-21 13:03:01 -0800 Pull back slightly on SpHu (Lightli) To compensate for dex increasing ranged weapon damage, make fustibali 2-handed and 3xbows unusable for spriggans. -------------------------------------------------------------------------------- 16cad56b0c | Nicholas Feinberg | 2022-02-21 09:47:50 -0800 Maybe fix a tossing crash (ardl) -------------------------------------------------------------------------------- 299514152f | advil | 2022-02-21 12:22:16 -0500 fix: (re)allow launching from `F` Previously this was implemented via ammo, which is gone. But it seems very confusing to not have launchers selectable from this menu, which after this change became limited only to throwing. This commit is a bit of a quick hack to do this, may need some more work. This means you can't use `F` any more to toss away a wielded launcher, though this is still possible via quivering it (with `Q**`). You can still toss a non-wielded launcher from this menu. More generally, it might be good to also allow quivering newlaunchers so that they still work with `f`/`p` (especially the latter, it's confusing that CMD_AUTOFIRE no longer has a way to fire for this case), but this will not be as easy so I'm not going to get to it immediately. The division of labor for autofight/autofire introduced with quivers may need some rethinking. -------------------------------------------------------------------------------- ca6a0d2473 | advil | 2022-02-21 12:06:24 -0500 fix: reenable anonymous spectating -------------------------------------------------------------------------------- 9aa386d172 | advil | 2022-02-21 09:44:16 -0500 fix: show lobby in a stable order with account holds I only had tested this in a python version where all dicts are ordered. Also, remove some traces of a pre-py27 compatibility shim for OrderedDict. (If anyone is still running this on py26, I don't know what to say. But probably not, because webtiles.load_games already dropped this.) -------------------------------------------------------------------------------- a23d9638d5 | Nicholas Feinberg | 2022-02-20 19:04:59 -0800 Give Vv a quote (ebering) There's probably better quotes from The Fifth Season - this was the first reasonable one I found. -------------------------------------------------------------------------------- 6546220326 | Nicholas Feinberg | 2022-02-20 19:04:48 -0800 Give Amaemon a signature weapon Don't drop that whip! -------------------------------------------------------------------------------- c2a82b186b | Nicholas Feinberg | 2022-02-20 15:47:36 -0800 Re-remove HINT_SEEN_RANDART Missed a few spots in 4be7dbf86b841721fccbcb6690ed74273671146d . -------------------------------------------------------------------------------- 2ef5e920f0 | Nicholas Feinberg | 2022-02-20 14:32:13 -0800 Remove Amaemon's corpse Every person is a whole world unto himself... but perhaps not a whole species. -------------------------------------------------------------------------------- d601ab35b5 | Nicholas Feinberg | 2022-02-20 13:30:48 -0800 Revert "chore: add a trunk reminder for the 0.28 tournament" This reverts commit 03a7b78be7a97b61e3ccfaa102cec36b0ca111bc. -------------------------------------------------------------------------------- 599418656c | Nicholas Feinberg | 2022-02-20 13:28:26 -0800 Ru melee redirection refactoring -------------------------------------------------------------------------------- 65f304602f | Nicholas Feinberg | 2022-02-20 12:35:52 -0800 Unbrace files.cc -------------------------------------------------------------------------------- 9fbeeb3dcf | Nicholas Feinberg | 2022-02-20 12:33:39 -0800 More mut description tweaks Cut more mut descriptions that are (IMO) non-actionable, and add the overlooked MUT_FANGS to dataified descriptions. -------------------------------------------------------------------------------- ca93a6e943 | Nicholas Feinberg | 2022-02-20 12:33:39 -0800 Trim Jiyva mut descriptions I don't think that the details here are helpful to players. You can't really control these muts, so what do detailed numbers get you? How will you play differently? It doesn't seem like something that will meaningfully affect play. -------------------------------------------------------------------------------- b9ea505e61 | Nicholas Feinberg | 2022-02-20 12:33:39 -0800 Tweak Ru eye desc -------------------------------------------------------------------------------- 507d7b0529 | Nicholas Feinberg | 2022-02-20 12:33:36 -0800 Programmatic aux descriptions -------------------------------------------------------------------------------- b4860018a3 | Nicholas Feinberg | 2022-02-20 12:33:36 -0800 Dataify aux attack trigger chances -------------------------------------------------------------------------------- adaf126bc6 | Nicholas Feinberg | 2022-02-20 12:33:36 -0800 Fancy Lua horns description -------------------------------------------------------------------------------- bb7b57aa70 | Nicholas Feinberg | 2022-02-20 12:33:36 -0800 Beak -------------------------------------------------------------------------------- 0ef5763bac | advil | 2022-02-20 12:33:36 -0800 docs: attempt to despoiler various aux/retaliation muts I say "attempt" because this stuff is complicated enough that there may be all sorts of mistakes in here still, or even some random rolls I've missed entirely. In many cases I have chosen to give slightly round numbers (e.g. 40% rather than 38%), maybe these should be made exact. Also, this is a lot of numbers, but I think we have become pro-numbers enough for this sort of change. This commit began in response to https://www.reddit.com/r/dcss/comments/svj867/demonic_touch_utterly_useless/ where it became apparent that how this particular mut worked was completely opaque to players (especially since its behavior is pretty atypical), but once I started doing this it became clear to me that basically all of these would be better with more information. I've tried to get all of the direct combat effects in this change. Some of the Ru mutations that are responsive (e.g. no potion heal) could maybe use similar work. -------------------------------------------------------------------------------- c3e01e4e4d | Nicholas Feinberg | 2022-02-20 12:29:54 -0800 Fix Josephina vault (geekosaur) ??oops -------------------------------------------------------------------------------- fffab11c1d | Nicholas Feinberg | 2022-02-20 12:27:44 -0800 Add item descriptions to monster So no one ever has to maintain the ldb book entries ever again. This is quite ugly but mostly works? -------------------------------------------------------------------------------- cd8f6311e7 | Nicholas Feinberg | 2022-02-20 12:27:21 -0800 dgn_place_item refactoring -------------------------------------------------------------------------------- 96d55e26a3 | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Checkwhite hints changes -------------------------------------------------------------------------------- 5e4a951760 | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Add a malevolence (explore trap) hint -------------------------------------------------------------------------------- 4be7dbf86b | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 More hints updates Remove references to allies stealing XP (now only true for Beogh), and rewrite HINT_YOU_RESIST to be a bit clearer (maybe!). Remove HINT_SEEN_RANDART (would generally only show up once a randart was already IDed) and tweak the description of Spellcasting skill. Don't bother noting demon tiers, and don't claim that statues are notable or hide 'special areas'. -------------------------------------------------------------------------------- 0c76a2f6e3 | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Remove HINT_FLEEING_MONSTER Mostly obsolete since 5cea4aff0001 (2012), 13c00676f0 and f1aa33a6750 (2013), and completely obsolete after b8068419c757 (2015). -------------------------------------------------------------------------------- fc0c1e2a9a | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Fixup HINT_EXCOMMUNICATE Don't claim you get wrath for abandoning a good god (or Ru) and not worshipping a new god. Also, dedent. -------------------------------------------------------------------------------- 491e7b286d | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Update HINT_CONVERT -------------------------------------------------------------------------------- bc0daef7cc | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Cleanup NEW_ABILITY_GOD -------------------------------------------------------------------------------- 477d20c3ff | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Misc hints cleanup -------------------------------------------------------------------------------- ca3a83724e | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Simplify wand use advice logic -------------------------------------------------------------------------------- 566ef67269 | Nicholas Feinberg | 2022-02-20 12:26:55 -0800 Remove HINT_SEEN_CARRION Irrelevant in a post-butchering world. -------------------------------------------------------------------------------- d8e2eab272 | advil | 2022-02-20 15:24:02 -0500 refactor: clean up `chr` chunk loading This was sort of impressively convoluted and bad: the tag code read chr chunk data directly into `you`, and then a `player_save_info` object was constructed from that. In most cases, this was wrapped in code that made a copy of `you` and then restored it after getting the info object. There were also all sorts of inconsistencies in what data was stored in this object. I'm guessing no one really wanted to mess with this old code where the cost of breaking things is high, but I'm going to give it a short here. This commit: * Cleans up `player_save_info` to exactly match the data in the `chr` chunk, aside from version info (and doll info used for tiles main menus). Add a few fields, remove one (`experience`) that seems to be completely unused. * Add a constructor to `player_save_info` to handle default values a bit more cleanly * Rewrite the tag code to read directly to a player_save_info object, and only copy data into `you` on demand * more comments, code reordering to match chunk data order, slightly better error messages in a few cases -------------------------------------------------------------------------------- 57cb919b73 | advil | 2022-02-20 15:24:02 -0500 fix: simplify and fix setup for save info CLOs `-save-version` was broken because it didn't correctly reset paths. In addition, I'm pretty sure that these don't need a full options reset. (Possibly I'm wrong, we'll see -- if there's mysterious uninitialized memory crashes, it'll probably just break the webtiles save viewer again and nothing else.) -------------------------------------------------------------------------------- 8aa3a5f11e | advil | 2022-02-20 15:24:02 -0500 fix: webtiles save info collection This broke around b939be14790 but I hadn't sat down to figure out what happened until now. (Amazed that there was never an actual issue about this that I'm aware of!) It may have been sort of a blessing in disguise as at least on CAO this callback chain has become pretty heavy and often times out. We'll see... -------------------------------------------------------------------------------- e9b396fb19 | Nicholas Feinberg | 2022-02-20 12:22:37 -0800 Allow looking up unrands in ?/I This was surprisingly annoying! -------------------------------------------------------------------------------- 8338fcb62e | Nicholas Feinberg | 2022-02-20 12:21:12 -0800 Don't let nymphs/elios port to unseen foes (dinky) That is, if you're invisible, don't let water nymphs waterport or eleionomae treeport to you. Also, dedent the water nymph logic. -------------------------------------------------------------------------------- 15338bc10e | Nicholas Feinberg | 2022-02-20 12:20:01 -0800 Tweak Merfolk weapon aptitudes (Hellmonk) Trade a point of Polearms for a point of Long Blades. At +3 polearms, Merfolk will still be extremely strong polearms users, but it'd be nice for them to occasionally have some reason to do something else. (Especially with impending changes to long blades.) -------------------------------------------------------------------------------- 32946d4e34 | Nicholas Feinberg | 2022-02-20 12:19:30 -0800 Make Jiyva less verbal Jiyva doesn't seem like much of a talker. Possible that J penance should be rethought regardless, but for now... -------------------------------------------------------------------------------- 68506e6fbd | Nicholas Feinberg | 2022-02-20 12:19:07 -0800 Disable the MCC targeter by default It seemed to mostly confuse players by leading them to think that the spell was targeted, since they could move the cursor around while in the targeter. It's also not super useful, since whatever monster is highlighted when you start the spell may not be the eventual victim. The MCC targeter can still be seen by quivering and (f)iring the spell, or by adjusting the rcfile. -------------------------------------------------------------------------------- d9437148fb | Nicholas Feinberg | 2022-02-20 12:18:29 -0800 Slot name: armour -> body armour To avoid confusion that the Armour skill only applies to the Armour slot. -------------------------------------------------------------------------------- 67d208b9ac | Nicholas Feinberg | 2022-02-20 12:16:14 -0800 Remove most uniques from Tomb Tomb has its own thing going, and most of these guys aren't really scary by the time you get there. (<0.6% recentish killratio.) Also drop Mara and Parghit from Crypt; former for killratio reasons (0.2%) and latter for thematic ones. Parghit is a winner! He's heading for the orb! No reason for him to be in the Crypt. -------------------------------------------------------------------------------- 06d020a549 | Nicholas Feinberg | 2022-02-20 12:16:14 -0800 New unique: Zenata, Seeker of Sheza Zenata is another late-game unique (appearing in Depths, Zot &c), borrowing a bit from the Desolation of Salt and putting a twist on it. She's taken the ragged hierophants' "Resonance Strike", which is like airstrike that gets bonus damage from adjacent constructs instead of from open spaces, and uses it in conjuction with a new "Sheza's Dance" spell, which summons 2-4 dancing weapons. To encourage players to kill her, she comes with a high-tier weapon with some plusses already on it. Zenata's theme is intended to expand slightly on the Desolation lore. She entered the Dungeon to look for secrets of the old Sheza/Sargol cult, the Divine Twins that ran the Desolation of Salt before it was a desolation. The bits and pieces she found required her to replace more and more of her flesh with metal to unlock their power... but hey, upgrade! :) -------------------------------------------------------------------------------- 226d363e7e | Nicholas Feinberg | 2022-02-20 12:16:14 -0800 New unique: Vv the Exile Vv is a combination of ironbound frosthearts (Creeping Frost) and Salamander Tyrants (Eruption/Pyroclastic Surge), appearing in Depths, Zot, Crypt and Tomb. She's themed as a new species, the Stoneborn, sentient earth elementals. She also has strong defenses and AF_FIRE and AF_COLD melee. I haven't yet added any loot for her, to incentivize players to tussle with her. The XP and curiosity might be enough for now. The theme is intended to push in a different direction from uniques like Parghit and Josephina. The former expand on existing lore. Vv, by contrast, expands the world of DCSS by suggesting the existence of something greater outside the game's current bounds. -------------------------------------------------------------------------------- 375cf7ae12 | Nicholas Feinberg | 2022-02-20 12:16:13 -0800 Fix new VISUAL monspeak entries -------------------------------------------------------------------------------- 69db86b63c | Nicholas Feinberg | 2022-02-20 12:16:13 -0800 New unique: Lodul the Thundrous Lodul is an ironbound thunderhulk who's been sent to patrol outside the Vaults, in late D. He's got a weaker version of Call Down Lightning (lower HD) and a big band of ogres and two-headed ogres to help him keep distance from the player. Defensively, he looks a lot like Erolcha. His loot is a big pile of gold. Nothing like cash to bribe players into potentially risky fights :) -------------------------------------------------------------------------------- 9cfbde7411 | Nicholas Feinberg | 2022-02-20 12:16:13 -0800 New unique: Amaemon the Diabolical Poisoner Amaemon is Crawl's first demonspawn unique, appearing in mid-D, early Lair and Orc:1. Alongside his orange demon companion, Amaemon summons scorpions (the classic returns!) and casts Concentrate Venom, upgrading his allies' poison into curare. To encourage players to try to kill him, he wields a demon whip of venom, with 1% chance of the unique Snakebite. -------------------------------------------------------------------------------- 618b504a9a | Nicholas Feinberg | 2022-02-20 12:16:13 -0800 New unique: Josephina the Ice-Lich As one more 'alt-timeline' unique, Josephina is an upgraded version of Josephine. She appears in late Vaults, Depths, Crypt, Tomb and Zot, and borrows Wendigo Seracfall (turning simulacrula into 3d33 bombs) to add to her classic Ghostly Fireball. She comes with a guaranteed randart ring of ice. I suspect a lot of the numbers here will need more fine-tuning. She might be a bit of a glass cannon at the moment, especially with the rF-, and I think the placement range is probably a bit off. -------------------------------------------------------------------------------- 141cb85572 | Nicholas Feinberg | 2022-02-20 12:16:13 -0800 New unique: Parghit the Mighty Following the example of Maggie/Margery, Parghit is an "alt-timeline" version of Pargi. Parghit appears in late Depths, Zot, Crypt and Tomb, and sports high-enchantment golden dragon scales (with a 1% chance of wearing the Dragon King) and an astonishing 27 HP regenerated per turn. He's definitely killable, but best not underestimated. I considered also giving him large rocks. It seemed rude, but I might go back to that if it seems appropriate. Credit Hellmonk for several parts of this idea. -------------------------------------------------------------------------------- 920eff52f4 | Nicholas Feinberg | 2022-02-20 12:15:54 -0800 Mark dummy species mons as NO_GEN_DERIVED Don't spawn Palentonga zombies in Crypt. They're not real monsters! -------------------------------------------------------------------------------- 1eaea45740 | Nicholas Feinberg | 2022-02-20 12:12:34 -0800 Change the Woodcutter's Axe into a battleaxe Pushing back a bit on the original design principle, make skill matter a bit more (multiplying a higher base damage & augmenting a lower base accuracy), and add another tradeoff (2-hander status). I'm not adding save compat, so anyone upgrading from an older version can have both an off-hand and the woodcutter's axe until they unequip something. Bonus! :) -------------------------------------------------------------------------------- e3029af5aa | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Make ranged weapons use dex instead of str for damage After e08ca24d97b194, strength became extremely valuable for ranged weapons. It increased damage quadratically: not just multiplying the base damage of the weapon, but also increasing attack speed while wearing armour. This isn't the end of the world, but it does seem more intuitive that dexterity should be the desirable stat for ranged weapons. So, let's make ranged weapon damage scale with dex instead of str. Str is still quite valuable for ranged characters to allow them to use heavier armour, just a bit less so. -------------------------------------------------------------------------------- 85b37ae345 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Make blades use dex instead of str (hellmonk) To differentiate long blades further from other weapon classes, make Dex increase their damage instead of Str, in exactly the same way. It would feel very weird if lbl used dex but sbl still used str, so change sbl to match as well. Possible that some sbl nerfs could be called for after this? Probably it's fine. -------------------------------------------------------------------------------- 7cd8695230 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Ammo removal: more hints updates -------------------------------------------------------------------------------- af6a381e14 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Add AEVP to ranged weapon delay Ranged characters in Crawl generally feel rather similar to melee characters. Other than dealing with ammo - which tends to be mostly busywork, rather than a meaningful or interesting set of choices - ranged characters feel like polearm users with a very very long pole. This is not great for variety, and it's also not very intuitive. A player could reasonably expect that a ranged character should look different from a melee character - Robin Hood and Legolas aren't running around in plate armour! So, let's fix that. As of this commit, AEVP is now added to missile weapon attack delay. As usual, this is reduced significantly by Str and slightly by Armour skill. Some sample numbers: - Starting human hunter in leather: +0.042 delay - Starting human hunter in plate: +0.864 delay - 30 str, 16 armour, plate: +0.253 delay - 50 str, 27 armour, plate: +0.097 delay - 50 str, 27 armour, crystal plate: +0.159 delay - 5 str, 0 armour, crystal plate: +2.645 delay - 20 str, 10 armour, swamp dragon: +0.066 delay (Delays below 0.1 are randomized with every attack. For example, an added delay of 0.042 has a 42% chance of slowing an attack by 0.1.) In compensation, ranged weapons' have gotten various buffs; most weapons have seen their base damage has been increased, and slings have seen their base delay decreased. The expectation is that players will be encouraged to choose somewhat lighter armour than they might otherwise, making ranged characters feel more different from melee. It also makes ranged weapons somewhat less attractive as a swap for melee characters. All numbers subject to change. -------------------------------------------------------------------------------- 34d9ade26b | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Update the quick-start guide for ammo removal -------------------------------------------------------------------------------- b9b4b4cd67 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Give kobolds +3 xbows As something they're better at than other races (being mechanically inclined), it's nice to accentuate that strength a little more than their former +2. Plus, it's funny to give a race that has a big obvious disadvantage for ranged combat (reduced LOS) a great apt for it - creates a different kind of experience! -------------------------------------------------------------------------------- 216ade4d86 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Remove an unused variable (Aliscans) -------------------------------------------------------------------------------- ed46df0f1f | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Mark launcher ammo as removed (Aliscans) -------------------------------------------------------------------------------- a852ce8369 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Play with ranged weapon stats more Following some thinking about ranged weapons, here's a new set of ammoless stats. Philosophy: - Slings are high-skill 1-handers. Hunting slings are vaguely like war axes, and fustibaluses are no longer ultra-rare but are now more like broad axes. - Bows are high-skill 2-handers. - Crossbows are lower-skill - it takes fairly little to get the hand crossbow or the arbalest to mindelay. The triple crossbow is still high-skill, but it's quite rare, so doesn't define the 'feel' of the class, much as you can't rely on finding a triple sword as a lbl user or an exec axe as an axe user. (Unless a gifting god gets involved.) If we're going to keep all these item classes, it would be great to have some more obvious and pronounced gimmicks. I suspect we'll end up merging or removing some of these at some point, but that's a larger project than I'm ready for right now. TODO: make fustibali spawn at a higher rate - right now they're about 1/5th as common as I'd like. -------------------------------------------------------------------------------- 9b9ebdfc37 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Remove launcher ammo from the \ menu (Aliscans) -------------------------------------------------------------------------------- a30ec57329 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Remove throwing weapon hunter start (Aliscans) Throwing weapons were always an odd fit for the hunter background. They aren't a primary playstyle or 'killdudes' method like ranged weapons, but they were presented in the same way. Now that hunter's lost its short sword, it's an especially odd fit. Let's cut the throwing start for now. I think in the near future we might bring back additional throwing ammo as a supplement to another background, either Gladiator or Brigand (or perhaps both?). -------------------------------------------------------------------------------- cb38ff9839 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Remove webtiles launcher quiver -------------------------------------------------------------------------------- d562ef3a11 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Remove the short sword from the hunter start No longer needed. -------------------------------------------------------------------------------- 39307501d7 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Adjust ranged weapon stats post-ammo Mostly reduce numbers across the board, since players are no longer constrained by ammo. Slings are a little sad about the loss of sling bullets and so don't get hit quite as hard as the others. I playtested these and kept turning numbers downward until just mashing o-tab on a HuHu would get me killed somewhere in early-mid D. (With no numerical tweaks, it was pretty trivial to reach Lair, and probably to just win.) -------------------------------------------------------------------------------- 3bbc7b7260 | Nicholas Feinberg | 2022-02-20 12:05:40 -0800 Remove ammo from vaults, sprints & the tutorial -------------------------------------------------------------------------------- 13dfb44323 | Nicholas Feinberg | 2022-02-20 12:05:38 -0800 Adjust item gen for ammo removal Drop non-vault loot proportionate to the weight of old arrows, bolts, etc. Counting vaults, overall game loot will be slightly higher - maybe about 2%? -------------------------------------------------------------------------------- 4fc27e4f60 | Nicholas Feinberg | 2022-02-20 12:04:49 -0800 Allow firing with v Since launchers no longer use ammo, there's no reason for them to interact with the quiver system. Instead, make them fire using 'v', like polearms or other melee weapons. Tab also works. If people request, maybe there could be an option to have 'f' always fire a held ranged weapon, rather than using the quiver. -------------------------------------------------------------------------------- a8e9c987b8 | Nicholas Feinberg | 2022-02-20 12:04:47 -0800 Remove launcher ammo Ranged weapons in Crawl have long contained a painful tension. On the one hand, their design suggests that the player is expected to use them as their primary means of killing enemies. They have dedicated weapon skills, imposing a substantial strategic cost to reach mindelay with any given type, and there's a tactical cost to switching between them and melee weapons. On the other hand, the limited ammo supply suggests the player is expected to conserve ammo in some way. The only real way to do this is to use other means (i.e. melee weapons) to kill some enemies. However, there's still more than enough ammo to kill any really threatening enemy, and later on there tends to be more than enough ammo to make its limitations meaningless, especially for followers of Okawaru. Thus, ammo currently provides no really interesting tactical or strategic decisions, just busywork. It seems that ammo should either be made much more restrictive, so that the player is rewarded for engaging with it, or removed. If we made ammo much scarcer, such that players could only kill a few very dangerous enemies with it, players would generally be forced to train something else as their primary 'killdudes' skill, and use ranged combat as a supplement. This would end up looking quite a lot like Throwing or Evocations, but with a worse UI, since players would need to switch weapons rather than just pressing 'F' or 'V'. This seems uncompelling. As such, let's cut ammo entirely. Monsters *already* had infinite ammo, and players can follow suit. Subsequent commits will deal with the small print. -------------------------------------------------------------------------------- d09b832af6 | Nicholas Feinberg | 2022-02-20 11:48:37 -0800 Remove launcher ammo acquirement This will be meaningless very soon. (See following commits.) -------------------------------------------------------------------------------- 8efb068a30 | advil | 2022-02-19 14:01:43 -0500 feat: indicate stateful ?tele behavior in ItemUseMenu The stateful behavior of scrolls of teleportation is kind of easy to forget about, and also unique (I think) among consumables. Because of this, it seems helpful to indicate if it will cancel an existing teleport explicitly. I've done this in the `r` menu, another place this could be done is in the item description itself. -------------------------------------------------------------------------------- ba4477c8fd | Nicholas Feinberg | 2022-02-19 07:47:14 -0800 Add Ignis to db_lint (SpicyCebolla) -------------------------------------------------------------------------------- 4040846114 | Nicholas Feinberg | 2022-02-18 21:46:58 -0800 Fix Throatcutter player tile (Gwynnette) -------------------------------------------------------------------------------- 06d03a830b | Nicholas Feinberg | 2022-02-18 12:21:35 -0800 Remove a spurious tracer check Didn't quite think that one out. -------------------------------------------------------------------------------- 097e55589a | Nicholas Feinberg | 2022-02-18 12:20:20 -0800 Fix quiver/summon warnings (CarefulOdds) Don't check for interactions with ongoing AOE attacks (OTR, Polar Vortex, &c) when you're just quivering a summon spell. Only check on cast. Closes #2429. -------------------------------------------------------------------------------- 99c160cdfe | Nicholas Feinberg | 2022-02-18 11:01:33 -0800 Fix Shilleiagh noise (frdfg) When Devastator was added in 9cc3ee3f91d, it was intended to make 7 noise with every hit. However, since it was an explosion, it accidentally made 15 noise instead, and hence the wiki noted it as making 'fireball-level noise'. This continued for 10 years until 58ad9d9fa3b, which accidentally muted it while trying to make Irradiate silent. This commit restores Devastator to its intended 7 noise per hit. -------------------------------------------------------------------------------- 5b5bac981a | advil | 2022-02-18 10:14:58 -0500 feat: a means of preventing player ghosts from held accounts This is implemented a bit generally for maximum compatibility, but because it uses the new `-no-player-bones` option, a held account will not be able to start games with crawl binaries that do not support this. This applies both to old versions and forks. I will cherry-pick the options commit to a few stable versions back. Should have no impact on servers that aren't using account holds. -------------------------------------------------------------------------------- abffb2d2b2 | advil | 2022-02-18 09:28:53 -0500 feat: add a CLO to prevent writing player bones This is not really intended as a player facing feature (it doesn't prevent ghosts from being generated or anything like that), but as an option to support community management features on webtiles. Implementing as a separate commit to make it easier to backport. -------------------------------------------------------------------------------- 078de9bc30 | Nicholas Feinberg | 2022-02-17 19:49:28 -0800 Display irradiate damage in monster (ardl) -------------------------------------------------------------------------------- 501f64c9ef | Edgar A. Bering IV | 2022-02-18 04:39:55 +0200 feat: smooth early super ood cap and document In des syntax the glyph `8` means depth * 2 + 4. A "super ood". The glyph `9` means depth + 5, a "moderate ood". Both of these are constrained in D:1-8 at present, the maximum vault OOD is depth * 2 over D:1-8. This cap expires after D:5 for `9`, but continues to impact the meaning of `8` until D:8. The result is that from D:8 to D:9 there's a large jump in difficulty of vaults. This commit smooths things, so that the additive term goes up by 1 for each floor afte D:8 until reaching its full value by D:12 (at which point `8` means max depth since the cap of D's OOD table is 27). -------------------------------------------------------------------------------- baf749a769 | CipHuK | 2022-02-16 19:39:45 -0800 Fix: Don't warn on trying to summon rPois allies This is quite fragile, but maybe it's less annoying than the alternative. It'd be good to do the same trick for toxic bog and fliers. [Committer's note: did various cleanup and fixes.] Closes #2424. -------------------------------------------------------------------------------- 189f89ecda | advil | 2022-02-16 17:53:56 -0500 fix: check webtiles db flags more consistently and act on them This improves the handling of using the cli to change the ban/hold state of players who are currently logged in. The main change to db access is that the flags are updated when starting a game, and changes (in either direction) should take effect immediately. To get this to work I had to improve some of the logout handling (which previously relied on a reload, and couldn't be triggered from the server). Hopefully the I/O cost of this extra db check on I/O-bound servers isn't impactful, we'll see. This commit also fixes a bug where a held account that tries to spectate got the error info through the wrong message (well, the right one didn't exist yet) causing the user/password boxes to reappear. -------------------------------------------------------------------------------- 613497d651 | advil | 2022-02-16 17:01:34 -0500 feat: add a cli command to list only account holds In a real server in practice, the bans list can get pretty nsfw / unpleasant to see. So it's useful to have a way to look only at account holds for normal maintenance. -------------------------------------------------------------------------------- dac63da4db | advil | 2022-02-16 15:39:14 -0500 fix: allow disabling yaml games definitions Since these aren't templated on dgl setups, they are a bit of a pain to deal with even if the goal is just to remove the default one from trunk or prevent its installation. This commit provides another approach, where you can set the directory to `None` and skip loading yaml game definitions altogether. -------------------------------------------------------------------------------- 0523dad39a | gammafunk | 2022-02-16 11:55:29 -0600 fix: Add a missing vault definition and refactor For bailey_polearm_vampire_castle_hellmonk, one of the vampire weapon definitions was missing its vampirism ego, which the others all had. Also reformat the monster definition, simplify NSUBST syntax, and align indent. -------------------------------------------------------------------------------- 0a07039d5a | Nicholas Feinberg | 2022-02-15 21:23:51 -0800 Tweak branch entrance noise messages (Booper) "Less far" is very awkward. Closes #2427. -------------------------------------------------------------------------------- 6e81df9875 | Nicholas Feinberg | 2022-02-15 20:46:08 -0800 Fix an typo (FizzleBang) -------------------------------------------------------------------------------- 4b50743c59 | hellmonk | 2022-02-15 20:13:30 -0500 nerf vampire castle bailey -------------------------------------------------------------------------------- 37f86683bf | advil | 2022-02-14 18:34:46 -0500 feat: webtiles reload on SIGHUP This is a long requested feature whose implementation is made more tractable by the separation of config.py and the webtiles.config module. I'd still definitely put this in the "experimental features" category. It will probably go badly for at least some options, but I've tested it on the account disable-type features I added recently, and it works well for those. Game data reload looks to work fine but I haven't tested it very carefully (e.g. no idea what would happen if someone is playing a game that got removed, etc.) The implementation is tied to an option and disabled by default, both because I'm not sure how well it will work in practice, and because I have the impression some dgl setups may have used SIGHUP to stop the server at some point, and enabling this by default would break init.d scripts. -------------------------------------------------------------------------------- 45d3ea808a | advil | 2022-02-14 18:11:52 -0500 feat: various account management enhancements Nick restriction improvements: * Allow defining a custom name check function in config. Some things are a bit easier to do this way than with a regex. Two restricted registration modes: * set `new_accounts_disabled` to disable new account creation altogether. This is a bit quick and dirty, and users currently don't get an error until they hit the submit button. * set `new_accounts_hold` to allow new account creation, but mark any new accounts with an "account hold" flag. This flag: - prevents login via ssh, where relevant. (It just sets the ban flag, so messaging to players may be confusing..) - prevents the account's games from appearing in the lobby or being spectated. - prevents the account from using chat. - prevents the account from spectating altogether. (Of course they can log out and spectate as anonymous.) - Players with this flag can still play games. - This flag is implemented as a new dgamelaunch db flag. Since dgl itself hasn't added any flags in like 15 years, hopefully this is safe. The account hold flags can be set and cleared via the wtutil.py command line tool. I'd like to add an admin panel interface too, but that isn't done. Ths flag, if set, has an effect even when the new account hold mode isn't enabled, so it can also be used as a kind of soft ban if someone is causing trouble in chat but for whatever reason isn't judged to merit an outright ban. -------------------------------------------------------------------------------- 0f647bec9a | advil | 2022-02-14 09:38:39 -0500 fix: check ban flag for token logins I think I didn't add this before because it is awkward to check at the point of login without adding another db call. However, user flags are collected from the db shortly after the point of checking the token, so this is a perfectly workable point to check the ban flag again. (Some of this code could perhaps be consolidated.) -------------------------------------------------------------------------------- 60f898f876 | advil | 2022-02-13 17:12:39 -0500 feat: more verbose new account logging This information was accessible, but needed digging in the logs by cross-referencing a socket, or digging in the db. I could see an argument that the email value is better not reported in a logfile, but I'm going to include it for now. -------------------------------------------------------------------------------- 80d8537514 | advil | 2022-02-13 17:11:19 -0500 fix: handle nonexistent accounts in ban checks This was crashing on None values and therefore not displaying the "login failed" message. -------------------------------------------------------------------------------- 25f29fbe20 | advil | 2022-02-13 15:18:29 -0500 fix: stabilize serpent of hell placement The previous code was a bit of a pain to understand, and also seems to have never been updated for pregeneration. This simplifies the calculation, and restructures it to not rely on player exploration. It is still entirely possible for hell end vaults to mess this up. -------------------------------------------------------------------------------- 88c9fad16d | hellmonk | 2022-02-12 23:37:05 -0500 Unthin early D loot This was reduced as part of D:1 item gen changes but seems to have been unnecessary. Taking this back up to prior levels. -------------------------------------------------------------------------------- 93358da72b | hellmonk | 2022-02-09 21:59:09 -0500 feat: Xom orb gift speech -------------------------------------------------------------------------------- 6187a340c9 | hellmonk | 2022-02-09 21:28:40 -0500 slightly nerf bailey_axe_minmay_hex_keep -------------------------------------------------------------------------------- 258763100d | hellmonk | 2022-02-09 21:26:26 -0500 fix floor tiles in a bailey -------------------------------------------------------------------------------- 1f87ffd4f4 | hellmonk | 2022-02-09 21:24:55 -0500 fix: Nightstalker stealth Give 50 stealth at mutlevel 3 instead of 48. -------------------------------------------------------------------------------- ee772dd00f | advil | 2022-02-08 10:38:20 -0500 fix: regularize confused self-attacks (perryprog) Previously, there was basically one way where a monster could accidentally hit itself while confused (with a number of other rare special cases): if it targeted another monster, `mmov` would be reset after the `fight_melee` call, and then the later there's an additional 1/6 chance for a self-attack. There's code that appears intended to handle a similar player case in `_monster_move`, as well as a chance on top of the monster rolling mmov as 0,0, but these were unreachable due to variously an earlier batch of code that handles attacking the player, and an early return if `mmov.origin()` is true. This commit regularizes things to what appears to be intended. Further tweaks may be justified, and in particular I'm not sure the purely random chance of self-attacking is needed. After this commit: 2/3 chance of stumbling, with a 1/n chance of rolling 0,0 (n=habitable spaces), and then a 1/6 chance of a self-attack. So *probably* rare enough to be not worth kiting to get. If the monster targets another monster, or (now fixed) the player: a 1/6 chance of a self-attack on top of the swing. Oddly (?), this doesn't change energy and the monster always gets a swing for this case, so they attack twice for the usual energy cost. As noted in the comments, I'm interpreting this as a kind of slapstick effect. But it might be more consistent if that 1/6 roll attacked themselves *instead* of the intended target, not sure. -------------------------------------------------------------------------------- debf4667c2 | advil | 2022-02-06 12:40:32 -0500 fix: don't crash on theft during EquipOnDelay Hopefully the reference `equip` is ok in this case, but it seems to work in testing and this is how EquipOffDelay handled it. Relevant crashlog: https://crawl.project357.org/morgue/cpf86/crash-cpf86-20220206-105923.txt -------------------------------------------------------------------------------- c37658a0fe | advil | 2022-02-05 15:34:50 -0500 fix: invert some mistaken transparency logic This seems to be the opposite of what was intended in 7e0d850643. On top of the wrong transparency logic, the fact that these vaults can get a transparent tag added if they are used in vaults was generating false positives in seed testing (where the transparent tag persists to a later run). I'm not actually sure its great for the vaults layout code to force-add `transparent` like that (even though I probably added it), but I'm leaving that alone for now. -------------------------------------------------------------------------------- f8c823261f | advil | 2022-02-05 10:38:52 -0500 fix: various dancing weapon death message issues * give the "strangely unrewarding" message in the abyss (and other no-xp scenarios). Also applies to simulacra. * Don't give a goldify message in the abyss (and other no-xp scenarios). * Handle goldify better for a couple of spell special cases as well. Also, add an explicit ASSERT in dancing weapon tile code based on a recent crash report. -------------------------------------------------------------------------------- 03a7b78be7 | advil | 2022-02-04 14:47:43 -0500 chore: add a trunk reminder for the 0.28 tournament -------------------------------------------------------------------------------- 2e6bf50d99 | Nicholas Feinberg | 2022-02-04 08:16:33 -0800 Add Oozemancy ability tile (Sastreii) -------------------------------------------------------------------------------- 95d2506d3f | Nicholas Feinberg | 2022-02-04 08:02:31 -0800 Post-final changelog updates (Ge0ff) -------------------------------------------------------------------------------- 58af29d98f | gammafunk | 2022-02-04 08:48:45 -0600 Update the Debian changelog for 0.28 (cherry picked from commit c65acfa365c381bc93a5adae01e2246700b84dc4) -------------------------------------------------------------------------------- da9a4e44c3 | gammafunk | 2022-02-04 08:48:32 -0600 Final 0.28.0 changelog (cherry picked from commit 1f18f1326188bb30cc2e2468d6abd7c50934ed76) -------------------------------------------------------------------------------- 93cd696043 | gammafunk | 2022-02-04 08:48:19 -0600 Checkwhite (cherry picked from commit 5a74557163c3c3b12ce7de0173ff567a5bd4a380) -------------------------------------------------------------------------------- 837932c90e | Edgar A. Bering IV | 2022-02-03 18:53:05 -0500 docs: update CREDITS.txt -------------------------------------------------------------------------------- 2c38d6c9ec | Kate | 2022-02-03 23:48:24 +0000 Fix a crash on Jiyva jelly spawns Caused by damage from YOU_FAULTLESS (such as a guardian golem's clouds) triggering a jelly to try and spawn with a dummy monster set as its foe. -------------------------------------------------------------------------------- 3050e97935 | Edgar A. Bering IV | 2022-02-03 15:03:58 -0600 tiles: jiyva oozemancy tile Some slime wall in the invocations lozenge. Could use improvement. Closes #2394 -------------------------------------------------------------------------------- ad4ee0f8b3 | RojjaCebolla | 2022-02-03 14:37:04 -0600 text: add descriptions to mutations.txt for no-skill-training mutations for Demonspawn cloud immunity for Engulf and Noise Suppression for various Ru sacrifice muts [ Committer's note: Squashed and rebased, removed removed mutations. Closes #2391 ] -------------------------------------------------------------------------------- 66d9a3572a | RojjaCebolla | 2022-02-03 14:37:04 -0600 fix: a typo in the description of repulsion field -------------------------------------------------------------------------------- d89ecb8dae | Edgar A. Bering IV | 2022-02-03 14:36:22 -0600 fix: tweak staff of Olgreb description To make it clear it is used via the 'a' menu now. Closes #2400 -------------------------------------------------------------------------------- de281f79f8 | Edgar A. Bering IV | 2022-02-03 14:36:22 -0600 docs: update the manual -------------------------------------------------------------------------------- c270d1dad5 | Nicholas Feinberg | 2022-02-03 09:05:12 -0800 Changelog tweaks -------------------------------------------------------------------------------- c5fe22d4ff | Perry Fraser | 2022-02-03 07:45:21 -0800 fix: correct hint for stat increases per 6 levels Change introduced in 03ef38a. -------------------------------------------------------------------------------- 85bba54663 | gammafunk | 2022-02-03 07:44:43 -0800 Update the changelog Near final for 0.28.0, but probably more tweaks to this to come. -------------------------------------------------------------------------------- 1732ff48e7 | Edgar A. Bering IV | 2022-02-02 23:19:51 -0600 fix: default runrest ignore transformation ending messages As reported in #2189 the default options repeatedly interrupt resting for transmuters, and this is particularly noticable in the early game when spell power is low. This commit adds a default ignore for all transformation-expiring-soon messages and for transformation end messages for all good forms. Wisp, Bat, Pig, and Tree form still interrupt rest, as these are far more likely for the player to want to rest off. This commit does entail a tradeoff: it makes the experience smoother for newer players in the early game at the expense of requiring a player who wants to remain in a form while auto-exploring/auto-traveling to edit their rc. It's not clear to me that there's a way to easily satisfy both use cases, someone will need to edit their rc. This change shifts the onus to do so to what are probably more experienced players. Closes #2189 -------------------------------------------------------------------------------- e854522c82 | Edgar A. Bering IV | 2022-02-02 23:19:51 -0600 fix: prefer foes for default inner flame target (12676) -------------------------------------------------------------------------------- 0c4cd36759 | Edgar A. Bering IV | 2022-02-02 23:19:51 -0600 fix: allow trog (and other divine allies) to spawn in clouds (12675) Removes an ancient and undocumented hack to avoid placing divine allies in particular in clouds (except with Xom). Since summons from other sources can appear in clouds just fine, let's go with the simpler, consistent approach here. -------------------------------------------------------------------------------- 81e803b10a | advil | 2022-02-02 23:42:39 -0500 fix: update some mac plist stuff I have no idea why LSRequiresNativeExecution was previously being ignored (the 0.27.1 release has this set and runs fine under Rosetta), but as of the 0.28-b1 release artifacts, it is *not* being ignored and this prevents it from running under Rosetta. I'm not sure why this was even set in the first place. I've also adjusted the minimum version field to what we actually build for. Probably more values here need a pass, e.g. the bundle id is pretty outdated. -------------------------------------------------------------------------------- e7179d36cc | advil | 2022-02-02 21:01:04 -0500 fix: adjust mouse hover suppress timing (ebering) This was mainly tested in firefox, which takes about 10-20ms to deliver mouseevents to the menu after a scroll, so 80ms seemed nice and conservative. However, in Safari, the timing seems to be more on the order of 100ms. (Maybe it's intentionally delaying them if they result from rendering rather than actual mouse movement?) I've upped this timeout to 200ms. Even with a value that might in principle be noticeable, I wasn't able to generate any intentional physical motion that revealed the suppression when trying to use a mouse. Unfortunately this change does make it a lot easier for the timeouts to overlap, which a simple bool doesn't handle very well, leading to the more involved approach here. -------------------------------------------------------------------------------- 1d65ae1bb4 | advil | 2022-02-02 16:01:02 -0500 fix: handle webtiles SIGHUP messaging differently SIGHUP indicates that something killed the process. While this can happen for various reasons, it mostly happens on some form of disconnect. If the player is around to see this message (as in Mantis 11595), they probably hit the back button or something, and it's misleading to describe this as a crash ("Unfortunately your game terminated due to an error."). In any case, there's no crash report on a SIGHUP. This commit adds a new message in client.js that'll require caches to catch up, but until then the default case message is fine, and prints the exit reason. More or less resolves https://crawl.develz.org/mantis/view.php?id=11595 -------------------------------------------------------------------------------- b207118a1a | Kate | 2022-02-02 20:31:37 +0000 Reduce Wucad Mu's channeling effectiveness (atomjack) The new formulae resulted in Wucad Mu scaling much more strongly than intended, up to approximately a 99% chance to make spellcasting free at 27 Evocations skill. Ideally the formulae will be reworked in the longer term to also make the effect scale better for regular orbs of energy at lower skill, but in the meantime reduce the ceiling by counting Wucad Mu as 1.5 sources of channeling instead of 2, and removing the stacking effect of multiple sources on the backfire rate. -------------------------------------------------------------------------------- 3f3a666523 | advil | 2022-02-02 15:14:16 -0500 fix: further issues with non-casting monster descriptions df0a5da549d686d didn't get this case right -------------------------------------------------------------------------------- 139f01a7f8 | advil | 2022-02-02 15:14:16 -0500 fix: scroll more sanely in webtiles Page up/down was overshooting. This commit seems to bring it to a better place (although the interaction with the shade is messy). I'm not sure why this code was previously commented, as far as I can tell (aside from compensating for the shade) it was correct, so hopefully there isn't some problem I didn't find. Resolves https://crawl.develz.org/mantis/view.php?id=12193 -------------------------------------------------------------------------------- 28f407b12d | Edgar A. Bering IV | 2022-02-02 14:04:40 -0600 fix: inform the player that using yaras on fedhas summons doesn't work (12670) -------------------------------------------------------------------------------- 0a91294c2c | Edgar A. Bering IV | 2022-02-02 14:03:14 -0600 fix: don't double prompt for monsters with Yara's (12669) Using stop_attack_prompt and firing a tracer is overkill. The former uses a better verb and works well with modern hitfuncs. The latter includes a self-damage check. It would be great if the former could be converted but that's not a small task and is likely to introduce a bunch of new double prompt bugs. For now I've gone with checking for self-damage separately. -------------------------------------------------------------------------------- 9d6eb31067 | Edgar A. Bering IV | 2022-02-02 13:47:22 -0600 fix: account for guile in ctouch display (dilly) -------------------------------------------------------------------------------- 2e2478e390 | advil | 2022-02-02 14:18:54 -0500 fix: handle a few more numpad keys in menus Resolves https://crawl.develz.org/mantis/view.php?id=12641 (and a few others that I spotted). -------------------------------------------------------------------------------- df0a5da549 | advil | 2022-02-02 13:59:38 -0500 fix: handle webtiles spellset parsing a bit better The webtiles code replaces the spellset in a monster description body with a placeholder. Previously it did this by regenerating the full spellset string and doing a simple `replace_all`. This obvious relies on deterministic behavior for `describe_spellset`, something not true of spells that have some random elemental coloring. This webtiles code could probably use some major refactoring, and possible the spellset should be separated out at the level of monster_info fields, but to fix this for release I've done something a bit simpler (and hackier). When generating a spellset description for webtiles, the monster description code inserts some delimiters, and these delimiters are used to insert the placeholder. I've also inserted some code to explicitly detect this sort of bug both when inserting the placeholder, and in the webtiles js code that was going wrong as a result of this bug. (For the latter, the colour string markers that remained in the body were getting parsed as tags by the browser, or maybe jquery, and wiping out the div where the real spellset was supposed to be inserted.) -------------------------------------------------------------------------------- a2763057c1 | gammafunk | 2022-02-02 10:45:19 -0600 feat: Updates to octagon-themed float vaults For minmay's set of octagon vaults, namely `minmay_shoctagon`, `minmay_roctagon`, `minmay_firetagon`, and, yes of course, `minmay_coctagon`, updates to placement, monster sets, loot, and syntax. These vaults all have a lower-tier monster set that places 8 monsters on-average along with a single out-of-depth "boss" monster, but the monster sets don't change much with depth. I've updated the maps to have appropriate monsters for earlier Dungeon (either D:10-D:12 or D:12-D:13, depending on the map), late Dungeon, Elf, and Depths. For Depths, all vaults can now place on every level of that branch. I've replaced `ident:type` with `ident:all` in all cases. Simplify the loot/monster placement logic to not have a rare chance to add a lot more of either monsters or loot. Nearly doubling the loot doesn't work well in a vault where the loot is already generous and every loot item is thematic. Remove these rare substitutions in the common setup function. Tweak the NSUBST to place a few more monsters so we keep the same average. For the unrand weapon item, follow the lead of `minmay_coctagon` and have thematic randart weapons of the same weapon class but of subtypes different from the unrand. This way we're not placing e.g. the Arc Blade 100% of the time, like a guarded unrand vault. Also add to these vaults some other thematically appropriate unrands with randart alternative to these vaults in cases when unrands exist. -------------------------------------------------------------------------------- d243af8c8e | gammafunk | 2022-02-02 10:45:00 -0600 feat: Update a vampire-themed float vault For `lemuel_vampire_tower`, revamp the vault to have better monsters that scale with depth of placement. We remove the down-hatch, since it served little purpose other than limiting placement. Move the guaranteed altar to where the down hatch was, and put a superb_item on the altar to go along with the other two loot items. Allow the vault to place on the final levels of Dungeon, Depths, and Crypt. Rework the monster tiers to follow a more logical progression, using monsters appropriate for placement depth. For the vampire boss, place a vampire for earlier Dungeon, upgrading to a vampire knight, with a placement of either Jory or a vampire knight decked out with thematic equipment of high quality for Crypt and Depths. -------------------------------------------------------------------------------- 292b7dfcfe | gammafunk | 2022-02-02 10:29:20 -0600 feat: Update a Depths float vault For `gammafunk_depths_water_palace`, update the monster list to be more current with the Depths roster. Instead of solo water elementals at certain locations, use merfolk exclusively, but have a chance for two of these locations near the central chamber entrance to be elemental wellsprings. Reglyph a bit as necessary. -------------------------------------------------------------------------------- 727057aadf | gammafunk | 2022-02-02 10:29:20 -0600 fix: Wrap a DES line -------------------------------------------------------------------------------- 10b4fd4ada | gammafunk | 2022-02-02 10:29:20 -0600 feat: Update a Depths float vault For `lightli_eight_chambers`, make the monster sets more appropriate for Depths, removing the orc and poison themed sets, which don't really have appropriate monsters, replacing them with earth, tengu, and spriggan themed ones. Revamp the other sets to be more coherent in terms of threat level. -------------------------------------------------------------------------------- c803637380 | gammafunk | 2022-02-02 10:29:20 -0600 feat: Update a Depths float vault For `hangedman_six_sided_sadism`, update the monster lists to remove some of the less interesting monsters from outside the branch. Use an appropriate SUBST to thin out two of the monster sets instead of having `nothing` in the monster list. -------------------------------------------------------------------------------- f436032661 | gammafunk | 2022-02-02 10:29:20 -0600 fix: Clean up syntax of a float vault -------------------------------------------------------------------------------- 05b2614ef2 | gammafunk | 2022-02-02 10:29:20 -0600 feat: Update a fire-themed float vault For `lemuel_flame_loot_2`, replace teleport closet areas with simple lava. The vault requires flight or translocations to reach, and said closets didn't add anything to the vault aside from requiring `no_tele_into` masking. Add depth scaling, adding more monsters and loot as placement depth increases. Use two tiers of fiery monsters, with a single boss monster and a lower tier of support monsters. Allow fire monsters to generate as level lava spawns, but turn off level monster gen elsewhere in the vault. -------------------------------------------------------------------------------- 0f297cac12 | gammafunk | 2022-02-02 10:29:20 -0600 feat: Update placement of a float vault For `onia_ninara_swampy_vault`, don't place this vault in Depths, since there's not an appropriate set of Swamp-themed monsters that are appropriate difficulty for Depths. Refactor syntax and glyph usage. -------------------------------------------------------------------------------- 695ac6beb5 | gammafunk | 2022-02-02 10:29:20 -0600 feat: Update a troll-themed float vault For `lemuel_troll_bridge`, make the monsters scale better with depth. For later Dungeon, upgrade yaks to death yaks and upgrade trolls. For Depths, we replace the timid yak genus monsters with wizards, since it seems like wizards would be scared of being eaten by trolls. Place fewer monsters at earlier depths, since 10 trolls guaranteed on D:9 is a little much. -------------------------------------------------------------------------------- 14386d3767 | gammafunk | 2022-02-02 10:29:19 -0600 feat: Update a Depths mummy-themed vault For `lemuel_minitomb`, update the vault to monsters that are appropriate challenges for Depths, and revamp the appearance, layout, and loot. Don't use plain mummies, using spectral things at the low end, along with guardian mummies and mummy priests to go along with the single royal mummy. Replace some of the gold in the final chamber with super and star item loot, which is a more meaningful award. Use tomb-theme wall and floor tiles, and make the layout more favorable to monsters in the final two chambers. Allow the vault to place in all of Depths and Crypt. -------------------------------------------------------------------------------- 6705b9cb7d | gammafunk | 2022-02-02 10:29:19 -0600 feat: Update a Depths float vault For `minmay_skeletal_surprise`, use a better substitution setup and add more Depths-appropriate nasties monsters. Namely mix in a small chance for ancient/dread liches, keeping averages the same. For the nastier monsters that place in the gold rooms, place a superb or star item instead of just more gold. -------------------------------------------------------------------------------- e7567d4e05 | advil | 2022-02-02 11:07:07 -0500 fix: fix a rounding issue in webtiles bars This fixes the specific issue reported, but I couldn't swear that there are still no overflow issues. What was happening is that at the exact hp values reported in the issue, the main bar was 96.88% and the decrease bar ended up as 3.13%. Resolves #2384 -------------------------------------------------------------------------------- 69f475c709 | advil | 2022-02-02 10:29:52 -0500 docs: changelog updates Mostly editing/expanding UI/options bullet points -------------------------------------------------------------------------------- 72cdf85f72 | wheals | 2022-02-02 10:51:39 +0200 fix: ASSERT tripped with targeted destruction cards -------------------------------------------------------------------------------- 62a80824bf | Edgar A. Bering IV | 2022-02-01 22:56:19 -0600 fix: always give a message when a net trap fails to trigger For clarity. -------------------------------------------------------------------------------- 9fc6a9d840 | Nicholas Feinberg | 2022-02-01 15:57:34 -0800 Remove a reference to exploration traps C.f. 86c161e70f1664227c2cfe580500b2e3d2ef0146. -------------------------------------------------------------------------------- 89e12c0570 | Nicholas Feinberg | 2022-02-01 09:42:45 -0800 Fix toxic bog XP (Oneirical) It passed you->as_monster() into the temp map marker code (which is null), instead of the expected MID_PLAYER. -------------------------------------------------------------------------------- 8eb35efe60 | advil | 2022-01-31 22:58:10 -0500 fix: eliminate a bad memory access When the player had no wieldable inventory items, toggling the show all mode could lead to the deleted inv_header being modified. Write a custom clear() function for this class that explicitly sets nullptr. (Some day it would be nice if Menu classes used shared_ptrs or something...) -------------------------------------------------------------------------------- 581ba40fa7 | advil | 2022-01-31 16:16:31 -0500 docs: more color diagnostics for terminal These are intended to flag to putty users using certain options that their terminal is misconfigured. (I have *absolutely no idea* why putty is misrendering either of these. It's not impossible that at least the two block one is a low-level bug in our curses code? -------------------------------------------------------------------------------- a1db9ad13e | advil | 2022-01-31 16:16:31 -0500 fix: color spell letters by utility in more menus This was already done in the memorize menu. It looks more consistent overall, and also draws less attention to whatever is going on with putty's bg color swapping in blink_brightens_background mode. -------------------------------------------------------------------------------- 2ed287c6d8 | advil | 2022-01-31 16:16:31 -0500 fix: indicate compatibility mode for putty in more cases This was getting suppressed for players using blink_brightens_background, but the results of this mode are (currently) kind of odd, so we need to print the info about compatibility mode even then. Wording tweaked slightly in consequences. -------------------------------------------------------------------------------- b1d7ae0460 | wheals | 2022-01-31 20:16:04 +0200 fix: Numpad '*' and '+' in newgame menu (#12666) -------------------------------------------------------------------------------- ccf83627c4 | wheals | 2022-01-31 19:57:20 +0200 feat: allow closing the webtiles chat with F12 (Yermak) -------------------------------------------------------------------------------- 190321e9dd | advil | 2022-01-31 12:21:03 -0500 fix: restore item class hotkeys to id menu (Lici) No guarantees this behavior will stay forever, but it was unintentionally remove in fc454544111 so I'm restoring it for now. -------------------------------------------------------------------------------- 0a9fdd57f5 | advil | 2022-01-31 11:43:50 -0500 fix: menu selection for `prompt_invent_menu`s (gressup) These menus do manual keyhandling (which should eventually be refactored) and so CK_ENTER needed its own manual handling here. Affects most noticeably fire menu, but maybe all sorts of other misc ones. -------------------------------------------------------------------------------- 93984085d6 | wheals | 2022-01-31 18:28:56 +0200 fix: select all menu items when pressing a type shortcut Because the second iteration of the loop did not have the MF_SINGLESELECT check, using a non-primary hotkey to select things you had already scrolled past did not reliably select all items. The best way to reproduce this was to have several weapons in your inventory, scroll down past them on the (d)rop screen, and then press ). The topmost weapon would not be selected. (More specifically, I suspect it was being selected twice, leading to it being deselected.) -------------------------------------------------------------------------------- 238b2ceb19 | wheals | 2022-01-31 18:01:49 +0200 fix: time out drain when returning to a level (#12663) Wasn't updated when monster drain was made temporary. -------------------------------------------------------------------------------- 0aac2aca22 | wheals | 2022-01-31 17:57:46 +0200 fix: easy_floor_use when your (sub-)inventory is empty (#12667) -------------------------------------------------------------------------------- 171a82f519 | wheals | 2022-01-31 17:49:07 +0200 fix: restore spacebar behaviour in autoexplore autopickup prompt (#12671) -------------------------------------------------------------------------------- 15a0a6fec6 | wheals | 2022-01-31 17:19:41 +0200 fix: standardize penance piety display (#12565) Webtiles showed the piety rank even under penance, but console/local tiles did not. -------------------------------------------------------------------------------- 236b832b77 | wheals | 2022-01-31 17:14:28 +0200 fix: scroll of fear success chance (#12665, Yermak) The targetter did not properly reflect the power cap. The same bug probably also affected Anguish and Discord. -------------------------------------------------------------------------------- 9887b6b090 | wheals | 2022-01-31 17:04:59 +0200 fix: on the spellcasting menu casts the last spell again This was broken for both menu_arrow_control = true and false. The previous behavior was restored if arrow control is off; if arrow control is on, the menu automatically defaults to hovering over the last-cast spell, which means that pressing enter will cast that spell. Either way, the last-cast spell is shown with a '+' after the hotkey instead of a '-'. This does not restore the behavior when the player knows only one spell; that was mostly for newbies who are presumably keeping the default of true for arrow control. -------------------------------------------------------------------------------- 7f48f510a0 | Nicholas Feinberg | 2022-01-30 12:30:15 -0800 Fix (?) orb of wrath uselessness check Match the call to go_berserk() in melee-attack.cc triggered by you.angry() (which is the effect of an orb of wrath). -------------------------------------------------------------------------------- e4388f8e44 | advil | 2022-01-30 12:28:15 -0500 fix: correct shopping list menu more lettering This was doing the wrong thing on letters > 'z', which resulted in invalid UTF-8 and prevented the menu message from ever getting to the webtiles client. Resolves https://crawl.develz.org/mantis/view.php?id=12672 -------------------------------------------------------------------------------- a79f92ac9c | Nicholas Feinberg | 2022-01-29 14:47:47 -0800 Remove explicit fix slot support Unused since bf516ccc1f22f3449c9dce1c7828d97747f247d2 (2007) and unlikely to be used in future. -------------------------------------------------------------------------------- bf593b16ee | Nicholas Feinberg | 2022-01-28 17:25:33 -0800 Fix negative energy mutation description -------------------------------------------------------------------------------- e65d7fc6d1 | RojjaCebolla | 2022-01-28 19:25:24 -0500 fixup! Add descriptions for a few resistance mutations continuing to noodle on this. advil: "add explicitly any relevant abbreviations" -------------------------------------------------------------------------------- e889dcbc7e | RojjaCebolla | 2022-01-28 19:25:24 -0500 Add descriptions for a few resistance mutations Filling some holes in mutations.txt -------------------------------------------------------------------------------- ef7f3e67aa | advil | 2022-01-28 12:46:25 -0500 docs: a few more species mutation descriptions Also, tweaked hop to have more detail. Some of these touch on related fakemuts that wouldn't otherwise be currently described. -------------------------------------------------------------------------------- 9e681642b6 | Nicholas Feinberg | 2022-01-28 09:28:44 -0800 Tweak Mlioglotl Make him demonic holiness to better match player expectations (re vulnerability to holy word), and make his Lugonu abilities priestly rather than magical. -------------------------------------------------------------------------------- b194023da8 | advil | 2022-01-28 11:48:09 -0500 fix: don't list removed muts in describe debug code Also, put a static inside its only direct consumer. -------------------------------------------------------------------------------- 2e94016dc0 | Implojin | 2022-01-28 11:40:34 -0500 fix: lowercase help lookup on ctrl-o The keybinds shown on ctrl-o were outdated, this aligns it with how help lookup currently works. -------------------------------------------------------------------------------- 60158a2511 | Nicholas Feinberg | 2022-01-28 07:50:19 -0800 Add missing dj species mut descs (advil) -------------------------------------------------------------------------------- 13803eac2f | advil | 2022-01-28 10:44:29 -0500 feat: debug code to display muts without a description This is pretty spammy so not enabled by default. I've also restored the debug build `validate_mutations` call to the describe mut menu, if this was intentionally removed (it's a bit spammy too) it could be gated behind the new DEBUG_MUTATIONS define. -------------------------------------------------------------------------------- 59a240f8a5 | advil | 2022-01-28 10:22:38 -0500 fix: adjust some casing in mut short names These short names are being used as popup titles for `A` screen popups, and given this it is better to systematically uppercase relevant abbreviations. Because this field was designed for the % screen list, there was mostly a lowercase convention for these fields (with a few exceptions), but it doesn't seem to matter in any technical way if this casing is adjusted; db lookup is case insensitive. They look ok in the short list too, and a few things were already cased there. (Also because these have been designed for brevity, they often don't work well as titles, and I think in the long run it may be good to have an explicit "title" field of some kind in this data that allows writing a better one. But that's a bit of a project.) -------------------------------------------------------------------------------- e4976b13b8 | advil | 2022-01-28 10:00:28 -0500 fix: don't show (level 1/1) in mutation descriptions This seems to me more confusing than useful, I guess one might argue with this though. -------------------------------------------------------------------------------- a75d3d97ab | advil | 2022-01-27 20:52:29 -0500 fix: update SECURITY.md Someone needs to remember to do this again in a few weeks. Resolves #2107 -------------------------------------------------------------------------------- 08fb2288ea | advil | 2022-01-27 20:45:25 -0500 fix: quivering ammo from item description This call needed to correctly handle the ammo quiver (and the inscribe check), and to avoid code duplication I pulled similar relevant code out of ActionSelectMenu into its own call. Overall, this whole setup could possibly use some simplification at this point, it was written to support arbitrary numbers of quivers but I am not sure that's ever going to be realistic. Resolves #2257 -------------------------------------------------------------------------------- 022ca4c890 | advil | 2022-01-27 14:15:01 -0500 fix: suppress mores during describe actions This prevents graphical glitches in console and a hard-to-spot key input prompt in webtiles. Just suppressing the more is not an ideal solution as it can make you miss force_mores, but I'm not sure there's an alternative that wouldn't take some major refactoring. (I could imagine an RAII object that instead of suppressing output, collected it in a message tee and showed a popup if there was a force_more. But this is definitely in non-freeze territory.) Resolves #2232 -------------------------------------------------------------------------------- 0446c0dae4 | advil | 2022-01-26 23:07:21 -0500 fix: use menu api instead of deleteAll in a few menus -------------------------------------------------------------------------------- 068bf27d47 | advil | 2022-01-26 23:00:18 -0500 fix: reset scroll on spell search If the scroller was sufficiently far down, a search could result in no menu lines visible in console because the scroll didn't get adjusted. I haven't quite figured out why the Scroller m_scroll sanitization, which appears to be correctly implemented, doesn't kick in until a manual scroll. Maybe there's a missing _allocate? In any case, this commit explicitly manages the scroll for spell search, trying to keep it on the same spell if possible, but otherwise resetting to the top. Resolves #2303 -------------------------------------------------------------------------------- a859fcf985 | advil | 2022-01-26 16:57:37 -0500 ci: reset cache for mingw builds Or rather, change the cache key, which is apparently the way to do this right now. (The old cache gets erased if not accessed in 7 days.) -------------------------------------------------------------------------------- b8ed39c57d | Alex Jurkiewicz | 2022-01-26 16:16:26 -0500 Change return signature for set_rc Return boolean success. Also add a missing import used in on_message. Fixes #2382. -------------------------------------------------------------------------------- b0e57e52b4 | advil | 2022-01-26 12:43:07 -0500 fix: explicitly set UI_NORMAL before load_level in webtiles Messaging from portals happens during load_level, but on new char creation, UI_CRT is set by the character selection popups, and wasn't cleared in webtiles until load_dungeon. Since this state change is what is required for the initial show() call to the `normal` div in webtiles for this case, a more triggered during load_level would still wait for input but with the entire game div invisible. This is what led to the delver bug when landing on a level with a portal. Arguably it is also a bug that this messaging happens so early on initial load, but this seems extremely hard to change (marker init can't be moved later without what I seem to remember is complete disaster, so it would require deferring marker init messaging somehow). Resolves #2318, mantis 12343. -------------------------------------------------------------------------------- 53e83337bc | Alex Jurkiewicz | 2022-01-26 09:37:48 -0500 Use append for lists, not add Fixes #2380. -------------------------------------------------------------------------------- 12fcac58f8 | Nicholas Feinberg | 2022-01-25 18:03:19 -0800 Fix: clarify Conjure Flame description Try to explain how a rather complex spell works, without misleading newer players into thinking that re-casting the spell is the only way to get the embers to burn. -------------------------------------------------------------------------------- f2d273c862 | advil | 2022-01-25 15:51:46 -0500 fix: add a missing from future import (TZer0) -------------------------------------------------------------------------------- 94f35f3178 | advil | 2022-01-25 13:28:47 -0500 docs: remove a reference to CRD in the release guide since we haven't been doing that in as long as I've been a dev. -------------------------------------------------------------------------------- f1a7530480 | advil | 2022-01-25 13:04:53 -0500 fix: reenable * in UseItemMenu Probably broken in 673f3e5d658 -------------------------------------------------------------------------------- 87a8dc699f | advil | 2022-01-25 12:57:32 -0500 fix: make the unwield menu item usable Previously, this menu item was basically cosmetic, and didn't have a hotkey, preventing it from being hovered (in local tiles at least). This commit turns it into a real menu item that can be selected. While I was at it I improved some of the visuals of this item -- it uses form/species custom unarmed attack strings (though a lot of forms simply prevent this menu altogether), and indicates visually if unarmed is currently chosen. To match previous behavior, this menu starts with the first real item selected. We'll see if this is confusing or not. -------------------------------------------------------------------------------- 6d66802b9f | advil | 2022-01-25 11:22:10 -0500 fix: improve all items known case in KnownItemsMenu This fixes up the keyhelp to not show the toggle key, and absorbs the '-' keypress rather than just exiting the menu. This code needs some work still... -------------------------------------------------------------------------------- 2dc3af7c02 | advil | 2022-01-25 11:12:37 -0500 fix: adjust local tiles mouse hover behavior * get hover switching section to work in use and quiver menus, bringing these in line with webtiles * with arrow selection on, don't lose hover on MouseLeave * ignore mouse click keycode except on noselect menus. (Generally, this keycode only seems to happen when clicking outside of a window, which is extra confusing for anything else.) * don't draw hover for MF_NOSELECT menus, it makes the user think they can click and do something -------------------------------------------------------------------------------- 9123634e07 | advil | 2022-01-24 20:39:05 -0500 feat: quiver menu lettering improvements A long-time complaint about the newquiver menu is that the hotkeys are fairly arbitrary. This is challenging to resolve, since things that appear in this menu come from items, spells, and abilities, and there are likely to be collisions past the most basic of characters. A lot of players with this complaint have their preference for which lettering is the most important (I think that team item is the most vocal, because the old quiver menu just used item lettering), but these can't be mutually resolved. This commit attempts to use some of the fancier technology from UseItemMenu to resolve this problem. It adds a new mode to the quiver menu that focuses in on one of the three categories and uses the lettering from that category; the UI improvements from UseItemMenu hopefully make it easier to switch between the categories (e.g. arrow keys move smoothly between them, mouse hover changes categories*, and there's a toggle key as well. Focus mode on/off is implemented via a persistent option, so while you can manually set the rc option, it just remembers whatever mode you last had it in. Within a single play session it also remembers the section while in focus mode. So a typical use case for someone who doesn't quiver anything except items would be to hit ! to put the menu in focus mode, and not think about it ever again (until they upgrade, I suppose). This commit also involved a bunch of related fixes for stuff in Menu and UseItemMenu, as well as moving the quiver menu keyhelp to the footer. [*] n.b. there's been a regression somewhere along the line where this stopped working on local tiles, I'll deal with that separately. -------------------------------------------------------------------------------- cc9c2818f3 | advil | 2022-01-24 19:40:21 -0500 fix: guard against potential recursion in UseItemMenu Discovered while working on the quiver menu. I think this actually prevents some hover glitching at the moment. -------------------------------------------------------------------------------- 508f987c07 | advil | 2022-01-24 17:31:20 -0500 fix: fix some webtiles color string bugs This code didn't handle hand-generated nested color strings very well. More exactly recreate the stack algorithm from the crawl binary (still a bit different though). Should now work for any amount of foreground nesting, at least. -------------------------------------------------------------------------------- c496ab42f3 | advil | 2022-01-24 13:52:44 -0500 fix: correct exit logic for ability quiver submenu (Aliscans) -------------------------------------------------------------------------------- f64c0c316f | advil | 2022-01-24 13:52:43 -0500 feat: quiver menu section headings This is an old wishlist item and now that the cycle_header call and support code exists, becomes a lot more practical. Some minor other visual improvements to this menu as well. -------------------------------------------------------------------------------- cc732e7c34 | advil | 2022-01-24 13:01:45 -0500 refactor: clean up some messy quiver menu code Refactor a bunch of checks into the menu class, improve api for checking whether there are actions to quiver. Should not change behavior. -------------------------------------------------------------------------------- 283549b12f | advil | 2022-01-24 11:24:54 -0500 fix: fix use item section toggle with arrow control off -------------------------------------------------------------------------------- 673f3e5d65 | advil | 2022-01-24 11:05:06 -0500 fix: clean up some messy use item menu code This simplifies the use item menu so it doesn't have to entirely rebuild the menu every time the section changes. Rather, this commit adds an enable/disable toggle at the MenuEntry level that suppresses all hotkeys when disabled, and then changes this for relevant entries when switching sections. It also generalizes the section-switching code using the newer cycle_headers pattern. In addition, a minor visual tweak: indent non-hotkeyed items in these menus so that there horizontal position doesn't change on section change. -------------------------------------------------------------------------------- 55149d5790 | advil | 2022-01-24 11:05:06 -0500 fix: default `easy_floor_use` to false This option applies the action (read, wield, etc) to the floor item immediately on pressing ',' in the relevant menu if there is exactly one item of the right type on the floor. This behavior is really inconsistent with how menus work in general, and with what ',' does when there's more than one item. I'm keeping the option since it's been a default for a very long time. If people really don't like this new default I'm open to doing something further; one idea might be that if there's one item, assign it an actual (non-comma / non-letter) hotkey. -------------------------------------------------------------------------------- f728b707aa | Perry Fraser | 2022-01-23 13:46:06 -0800 fix: set FTILE in kennysheep_arrival_seaside stair -------------------------------------------------------------------------------- c66546352e | advil | 2022-01-23 11:10:02 -0500 fix: initialize a bool (Goratrix) This was resulting (depending on random local circumstances) in the first viewmap command sometimes being dropped spuriously. -------------------------------------------------------------------------------- 6e7a31e4fc | advil | 2022-01-23 10:58:36 -0500 fix: map touch input backspace to esc The lack of esc is one of the more immediate issues for using an on-screen keyboard, and using backspace seems like a workable solution. Backspace is prominent on these any touch virtual keyboard I've seen and would otherwise just go (almost) unused on touch input (in fact sending a fairly useless ctrl-h, which maybe needs a webtiles workaround in general). This only affects key input events handled via the mobile input button, so doesn't affect normal play or touch devices with physical keyboards. -------------------------------------------------------------------------------- e5bbfea7ee | advil | 2022-01-23 10:19:52 -0500 feat: use DESC_INVENTORY_EQUIP for carried stash search results Suggestion from u/SvalbardCaretaker -------------------------------------------------------------------------------- ee65da1d57 | advil | 2022-01-23 10:06:59 -0500 fix: select first travelable item in stash search Some players use this menu as a quick shortcut while collecting items that they are sure already exist, and I guess having to hit ','+enter is too much work. This lets enter immediately travel to the first travelable item. I'm undecided as of yet what to do with the lettering: I respect that many players have some muscle memory for ctrl-f a, but on the other hand, I don't think the fact that a kind of dodgy UI decision is enshrined in people's muscle memory is a good reason to keep it. I'm definitely opposed to making items on the current position fully unselectable in this UI, as was done (for carried items) in response to https://crawl.develz.org/tavern/viewtopic.php?f=8&t=20374. This makes the whole UI less usable and there's a ton of players who don't need or want the reversion that was (rather unconstructively) advocated for in that old thread. -------------------------------------------------------------------------------- 820543e53a | advil | 2022-01-22 19:38:17 -0500 fix: enable feature actions in full square describe Under this one code path (which happens with multiple describable things on the same square) a bool was not correctly applied. -------------------------------------------------------------------------------- 70179d601d | advil | 2022-01-22 19:22:08 -0500 fix: further fix describe item actions (perryprog) inventory items can't be expected to have a valid item index relative to env.items. -------------------------------------------------------------------------------- c30f734a66 | advil | 2022-01-22 16:14:06 -0500 fix: remove debug code -------------------------------------------------------------------------------- 86ee99c729 | advil | 2022-01-22 15:52:08 -0500 fix: parens -------------------------------------------------------------------------------- d457d2bfb3 | advil | 2022-01-22 15:42:00 -0500 fix: expand item index check from b35b39474d43 Reading and quaffing shouldn't work for this case either (and will crash). -------------------------------------------------------------------------------- b35b39474d | advil | 2022-01-22 15:11:05 -0500 fix: prevent pickup of non-env items via describe actions If an item_def is otherwise valid but is a copy of a real item in `env.items`, and the player is in the right position, this code would allow trying to pick it up and then crash. Add a check for a valid index. (The logic here is patterned off of `invalid_monster_index`.) The immediate effect is on descriptions accessed via stash search, and it would be better to actually allow the (g)et to work in this case, but it may be somewhat unavoidable that stash search is working with copies, so getting (g)et to work will be a bit of a project. -------------------------------------------------------------------------------- a0c2dbb3aa | advil | 2022-01-22 14:54:55 -0500 fix: reentrant calls to show_map via descriptions When viewing a staircase description, you can now use ]/[ in the description popup to go right to the map view on the other side. Since description popups are possible in `X` view, this could lead to weird stacking of map view UIs that were really not designed to happen. There was also a (possibly independent, but I'm not entirely sure) set of bugs where exiting the describe popup wasn't handled right and made the player travel to the stair location. This commit fixes all of this by refactoring `show_map` to allow graceful reentry without creating a new map view layer. Well, the behavior is graceful, the code isn't, but it'll do for now. -------------------------------------------------------------------------------- af8930e228 | nlavsky | 2022-01-22 10:52:22 -0600 fix: unmute the horn of Geryon "A hideous howling noise" was a lie: the horn has never produced a sound. This commit gives the horn a proper noise. -------------------------------------------------------------------------------- 050a50673c | Edgar A. Bering IV | 2022-01-21 15:26:51 -0600 fix: turn down wretched stars corrupting pulse a bit more Temporary mutations were turned down as they don't expire while in the Abyss. Even with that change, a handful of wretched star encounters could quickly add up. A handful of temporary mutations is an interesting challenge to overcome; receiving all of them gets to be a bit much. This commit reduces the casting frequency again, and also makes the chance to apply a temporary mutation scale down with the number of temporary mutations. -------------------------------------------------------------------------------- 3197508d1c | advil | 2022-01-21 15:42:09 -0500 fix: autocreate dgl status file dir (Pinkbeast) On default settings, this is automatically created on login or account creation, but until this happens a lot of warnings are generated by the timeout. I couldn't think of a good reason not to just create it if needed. -------------------------------------------------------------------------------- 8b1c90781f | advil | 2022-01-21 15:14:35 -0500 docs: update webtiles docs (WSL, other tweaks) * Incorporate Pinkbeast's discussion from: http://crawl.montres.org.uk/wsl-webtiles.txt. * Restructure prerequisites vs actually running the server * Note about UTF-8 * Other editing -------------------------------------------------------------------------------- daab1c2f9b | Nicholas Feinberg | 2022-01-20 13:47:34 -0800 Increase flam.wav damage by 20%ish dde70e7af44 was a well-deserved nerf, but overshot somewhat. Let's dial it back the other way. Average damage per round (pre-AC): 0 power 100 power Original 5 25 Post-nerf 4 14 Current 4 17 Easy to make further adjustments. -------------------------------------------------------------------------------- a624279079 | advil | 2022-01-20 16:05:37 -0500 fix: linebreak Y/N popup prompts (ebering) It is very unclear to me whether adding automatic linebreaking would be a good idea to MenuEntry items (which are used for many things), so I added a convenience function that only does this happen on demand, and used it for `yesno` calls. N.b. it works fine on Menu titles, but console regular menu entries do not work with multiline text. I also did a bit of relevant MenuEntry refactoring. -------------------------------------------------------------------------------- 47742a1d20 | advil | 2022-01-20 16:04:46 -0500 fix: tweak console hover rendering on yes/no prompts There is a difference in how hovers render for formatted vs non-formatted menus; this basically results in the hover being the width of the menu for non-formatted ones. Since yes/no menu prompts are pretty variable, this can sometimes be odd (and it's worse if someone overflows the terminal width). So, as a quick workaround, just mark this with MF_ALLOW_FORMATTING. -------------------------------------------------------------------------------- ae24e75c0c | Edgar A. Bering IV | 2022-01-20 14:14:50 -0600 feat: print what can't be picked up when prompting Could be verbose on large stacks with very greedy autopickup, but it's been a big screw for me to not know what is in the cell and have to stop and examine it before answering the "couldn't pick up" question. -------------------------------------------------------------------------------- 2a4342cb04 | Monkooky | 2022-01-20 14:14:50 -0600 feat: prompt to disable autopickup items of a type during autoexplore [ Committer's note: Re-wrote the patch to use more crawl codebase idioms and the new ask_always parameter to yesno previously implemented. Closes #2367. Closes #1873. ] -------------------------------------------------------------------------------- 4ed01045b5 | Edgar A. Bering IV | 2022-01-20 14:14:50 -0600 feat: removed unused yesnoquit It was partially provided to the lua API in 2008 when implementing toll zigurats for prompting if the player wanted to pay. Or at the same time, that ended up using yesno. Subsequently it slowly rotted against the weight of the FIXME: looking to be a real mess and disuse in the main codebase. This might be a pain point for some clua users, but yesno is quite full featured and ternary decisions (yes/no/quit) can be factored into nested binary decisions by those downstream users. -------------------------------------------------------------------------------- fa79eddd99 | Edgar A. Bering IV | 2022-01-20 14:14:50 -0600 feat: add "always" prompting to yesno There's one place in particular where we ask the player a specific question about a one-time situation that we can generalize both technically and sensibly for ui: "Could not pick up an item here" prompts. There may be others, so I've implemented this as a way to prompt for either a one-time or global change. Previously, a general [A]lways prompt was available via yesnoquit, but that has been unused for 6 years, has a FIXME for being a mess, and is missing some updates and modernizations of yesno. -------------------------------------------------------------------------------- 4b4a722d26 | advil | 2022-01-20 13:25:02 -0500 fix: further adjust some format specs `%llu` produces warnings on mac/linux, and the exact definition of size_t is not guaranteed by anything, so use the `%zu` format spec instead. -------------------------------------------------------------------------------- 886a180965 | Zarchan | 2022-01-20 11:46:42 -0600 feat: no more accidental lava related item destruction. Checks if the tile a player is on will destroy items, and if so prompts the player before continuing. [ Committer's note: Closes #2353. Tweaked and specialized the prompt. ] -------------------------------------------------------------------------------- 932a3574db | Zarchan | 2022-01-20 10:22:51 -0600 docs: update monster_list_colour documentation -------------------------------------------------------------------------------- ec4c6a5604 | advil | 2022-01-20 10:45:04 -0500 fix: tweak webtiles mouse hover behavior with multiple popups Previously, if you open a popup over a menu, and closed the popup, the mouse position at the time would determine hover, which can be a bit confusing (especially big menus where the mouse is likely to be somewhere in the menu, and especially for arrow key selection). This keeps hover on the previously hovered item (if any) when focus is returned. We'll see if something even more fine-grained would be better, e.g. suppress hover if previous item was not selected by mouse. It's also still TBD under what conditions if any a pure mousemove (with no leave or enter events) should set the hover, right now it doesn't. -------------------------------------------------------------------------------- 16e8fc0620 | Chris Landry | 2022-01-20 09:26:38 -0600 fix: update wizard armor gen with new egos [ Committer's note: Checkwhite and made consistent with weapon egos. Closes #2373. ] -------------------------------------------------------------------------------- a69ad8bafb | Aliscans | 2022-01-20 09:26:38 -0600 fix: correct spelling of skilful Was "skillful", but this is not a valid spelling according to https://www.australian-dictionary.com.au/wordcheck/. Closes #2372. -------------------------------------------------------------------------------- 83964af658 | Aliscans | 2022-01-20 09:26:38 -0600 fix: correct spelling of wilful Was "willful", but this is not a valid spelling according to https://www.australian-dictionary.com.au/wordcheck/. -------------------------------------------------------------------------------- d61996a82c | Aliscans | 2022-01-20 09:26:38 -0600 fix: pluralise ghosts with the same name as "2 ghosts called " The previous version gave "2 's ghosts", which was poor English. This form of words makes sense if they are ghosts of the same character or of different ones. -------------------------------------------------------------------------------- 903a904aa7 | Chris Landry | 2022-01-20 09:26:38 -0600 fix: some numeric compiler warnings Closes #2369 -------------------------------------------------------------------------------- 4a4240be9d | Aliscans | 2022-01-20 09:26:38 -0600 fix: a compiler warning In _genus_factoring(), mon is set in a loop. This is always set as "types" and "genera" are set in _count_monster_types(), which builds them both from the same list of monsters. This is not apparent to a code coverage tool, so set it to nullptr. Closes #2371 -------------------------------------------------------------------------------- d6fec0f1ec | Edgar A. Bering IV | 2022-01-20 09:26:38 -0600 docs: update CREDITS.txt -------------------------------------------------------------------------------- a72db329a9 | advil | 2022-01-20 09:59:04 -0500 fix: prevent webtiles mouse hover from scrolling This commit tweaks two related pieces of mouse hover behavior: * don't snap a mouse-hovered item into view; this was kind of confusing when it happened (by hovering a partly visible menu element). * apply a tiny bit of margin to what counts as partly visible for mouse hover purposes. This is very heuristic so it may need some tweaking or adjustment for different resolutions. Without this, it's sometimes possible to be hovering something you can't even tell is there. I first consider just making partly visible elements unhoverable by mouse, but this was also confusing. -------------------------------------------------------------------------------- a885d4b3d6 | advil | 2022-01-19 22:14:03 -0500 fix: tweak popup window heights This accomplishes two things: * prevent overlapping with the chat box in most regular browser circumstances, which has bugged me for a while * provide a workaround for the 100vh issue on iOS Safari, by simply leaving more blank space There might be better workarounds available. We'll see if people find the extra vertical space too much, or if it needs some more responsivity. -------------------------------------------------------------------------------- a88e694cbd | advil | 2022-01-19 22:14:03 -0500 fix: exert more control over iOS virtual keyboards The behavior is still somewhat flaky (a few bugs noted in comments), but this commit brings improvements. Basically, it tries to never let anything else but the mobile input box have focus, while the keyboard is displayed -- this is apparently what it takes on iOS to keep the keyboard up. Once it's down, focusing a text input doesn't bring it back up, and despite trying many recipes, I could not find a way to programmatically bring it back up. This prevented several alternative approaches that I considered, e.g. using a timeout. The focus control involved here is quite aggressive and hopefully won't break anything on Android. This also does some better styling of the mobile input box, rather than relying on the browser focus highlight. -------------------------------------------------------------------------------- d61c85c099 | advil | 2022-01-19 22:14:03 -0500 fix: clicking in multiselect webtiles menus Because there were previously no multiselect+ arrow menus, the code was sending enter (which only works for singleselect). For now send space; this commit is a placeholder for a non-keycode-based solution. -------------------------------------------------------------------------------- 6000d10c1c | advil | 2022-01-19 22:14:03 -0500 fix: make canvases non-selectable On touchscreens (ios), it is a bit too easy to long tap and select the canvas, which is then somewhat annoying to undo. This commit isn't a real solution because it is still possible to long top the canvas, but it prevents the canvas itself from being selected. (In my testing, some very thin element to the left of the canvas gets selected?) This means that if you tap the canvas itself the selection disappears. -------------------------------------------------------------------------------- 0a9ec5b959 | advil | 2022-01-19 22:14:03 -0500 fix: suppress click after touchend clickoutside At least on iOS, the click was still getting processed after the popup was closed, leading to spurious things happening. -------------------------------------------------------------------------------- 9c9f7e8d09 | advil | 2022-01-19 22:14:03 -0500 fix: let webtiles mouse dungeon clicks interrupt travel/repeats Previously, the click was just discarded during interruptible travel/repeats. This change will let the fake key enter the key handling queue, and `kbhit()` return true, which is the main check for interrupting such things. I think it's ok to return a keycode unconditionally for click handling, and CK_MOUSE_CLICK is innocuous, but we'll see. -------------------------------------------------------------------------------- 8cf2c06242 | advil | 2022-01-19 22:13:37 -0500 fix: improve mobile input box behavior This commit should prevent spurious shifting (which I believe was happening because the first letter of the input box is capitalized), and hide autocomplete/spelling suggestions at least on iOS. It also attempts to hide the cursor, and uses a placeholder instead of text. (Since anything that tries to edit the box is prevented, this should always be visible, I hope.) -------------------------------------------------------------------------------- 7722353844 | robertxgray | 2022-01-19 22:10:13 -0500 feat: better support for mobile browsers This is a minimum set of features and fixes to make the WebTiles interface playable on mobile browsers. - Added an optional auxiliary input field that can be focused to enable virtual keybards. - Added a new option tile_web_mobile_input_helper to enable or disable the input field. - Fix touch zoom and scroll disabled when a popup is shown. - Allow popups to be closed with touch events. - Fix some minor display issues on small screens. [Committer's note: squashed and edited commit message. Several tweaks aimed at iOS follow in subsequent commits from me. -advil] Closes #2221, closes #2332 -------------------------------------------------------------------------------- ee0477cf1a | Edgar A. Bering IV | 2022-01-19 20:40:53 -0600 fix: a typo (ManiacJoe) -------------------------------------------------------------------------------- 623ef8b387 | Crestwave | 2022-01-19 20:26:13 -0600 fix: add support for Haiku These are patches applied by upstream packagers. -------------------------------------------------------------------------------- 72eb5c4738 | Edgar A. Bering IV | 2022-01-19 19:53:49 -0600 docs: update CREDITS.txt -------------------------------------------------------------------------------- 12e810a91a | Edgar A. Bering IV | 2022-01-19 19:49:35 -0600 fix: update runrest_stop defaults for modern times and old doors Closes #2346, Closes #2368 -------------------------------------------------------------------------------- e87ddf7535 | Edgar A. Bering IV | 2022-01-19 18:54:23 -0600 feat: give out some fancy shields in Snake Give Naga Warriors a chance of getting a good_item shield. Overall this will result in an average of 2-3 good shields per Snake. With the lootfeel shifts of Spider and Swamp, and Shoals' throwing items, Snake was already somewhat distinguished by the chance of getting a kite or tower shield off of a Naga warrior. Adding a small chance for the shield to be fancy should make this pop a bit more as lootfeel. -------------------------------------------------------------------------------- 477bb3ace5 | hellmonk | 2022-01-19 18:43:26 -0600 feat: two new spider ends Adds a broodmother end and a themed ending that only places non-spiders. -------------------------------------------------------------------------------- acdfd95529 | hellmonk | 2022-01-19 18:29:16 -0600 feat: update floodkiller_spider_rune_tomb Add new monsters and some loot, cut density a bit. -------------------------------------------------------------------------------- 1478b6322d | hellmonk | 2022-01-19 18:29:16 -0600 feat: adjust arachne_lair spider end Reglyph and add new monsters and loot, fix some substs. -------------------------------------------------------------------------------- dbc70543e1 | hellmonk | 2022-01-19 18:29:16 -0600 feat: update grunt_spider_rune_island Add new monsters and loot, reglyph. -------------------------------------------------------------------------------- 9ca27bf259 | hellmonk | 2022-01-19 18:29:16 -0600 feat: adjust grunt_spider_rune_parallel add new monsters and loot, reduce density slightly. -------------------------------------------------------------------------------- 46fceaadd4 | hellmonk | 2022-01-19 18:29:16 -0600 feat: adjust guppyfry_spider_rune add new monsters and loot -------------------------------------------------------------------------------- 86b270519b | hellmonk | 2022-01-19 18:29:16 -0600 feat: adjust grunt_spider_rune_circles Add worms and loot, rewrite some of the monster randomization. -------------------------------------------------------------------------------- 85af5c1198 | hellmonk | 2022-01-19 18:29:15 -0600 feat: update and reglyph spider_rune_water Add a few of the new monsters, change trash mob randomization, add some loot. -------------------------------------------------------------------------------- dee6c067ee | hellmonk | 2022-01-19 18:29:15 -0600 feat: loot function for spider ends Not in use yet, but soon? -------------------------------------------------------------------------------- c6f6baafec | hellmonk | 2022-01-19 18:29:15 -0600 feat: two spider minivaults featuring some of the new monsters -------------------------------------------------------------------------------- aeca334d3e | hellmonk | 2022-01-19 18:20:09 -0600 feat: adjustments to non-end spider vaults -------------------------------------------------------------------------------- 9e22a525d0 | hellmonk | 2022-01-19 18:20:02 -0600 feat: two new spider entry vaults -------------------------------------------------------------------------------- 88295113b6 | hellmonk | 2022-01-19 18:19:57 -0600 feat: update spider entry vaults -------------------------------------------------------------------------------- 77cbbf62ba | Aliscans | 2022-01-19 10:58:41 -0500 fix: Make space toggle the selected item in shop menus. Pressing either Space or Return had attempted to buy the selected items. This changes Space to match the effect '.' has, which matches the behaviour b5dea8a184 added to various other prompts. The effect of the space bar remains undocumented. -------------------------------------------------------------------------------- 1695149f81 | Kate | 2022-01-19 06:27:41 +0000 Checkwhite -------------------------------------------------------------------------------- e73e3526bd | Nicholas Feinberg | 2022-01-18 22:03:15 -0800 Cleanup meatsprint des We no longer need to specify ident:all or no_pickup, since both are always true. -------------------------------------------------------------------------------- 95a8017c83 | advil | 2022-01-18 21:00:48 -0500 feat: arrow key navigation for the memorize As a bonus, I made left and right work to move between menu panes, as it felt fairly natural. At some point I'll experiment with generalizing this beyond this menu. -------------------------------------------------------------------------------- 7369b063a1 | advil | 2022-01-18 20:50:27 -0500 feat: arrow selection for spell cast/describe menu Also some minor formatting tweaks. There's still one extremely minor issue I can't track down, where this menu's with changes on ! in webtiles. -------------------------------------------------------------------------------- 52c9ff9b3a | advil | 2022-01-18 20:15:09 -0500 feat: enable arrow selection for ability menu Pretty straightforward, no special tweaks needed that I'm aware of. -------------------------------------------------------------------------------- 2eedf47f95 | advil | 2022-01-18 20:11:35 -0500 fix: improve webtiles menu pageup In menus with variable height menu items, this was occasionally overshooting the last visible. This commit fixes the problem, but for pageup maybe the relative hover position should be handled differently. -------------------------------------------------------------------------------- 99ac4a3411 | advil | 2022-01-18 20:11:35 -0500 feat: stash search menu improvements The ultimate aim of this is to make this menu workable with arrow key selection. Previously, carried item results weren't hotkeyed at all (presumably because travel is pointless), but this didn't quite work for arrow selection. * All stash search results are selectable. * Visually, items at the player's feet and in their inventory are grouped together, and the former are now clearly indicated in the menu. A hotkey (,) quick-moves the menu between these sections. * In travel mode, selecting an item at the player's position doesn't do anything; previously this was true for carried items (because they weren't selectable) but did open for things on the ground. Possibly it would be clearer to do something in this case, maybe a message? Or open a description? These items are also greyed out in travel mode. * Subheads are now cyan for better readability * Various supporting Menu API improvements (including some bits that are probably extremely useful in the future but didn't end up fully needed here.) It would be possible, but I found it a bit confusing on first implementation, to start the menu with the first item not at the player's position selected. Will revisit this on feedback. I think with the , hotkey this isn't as important. Other TBD improvements: the keyhelp could be improved and standardized, I think it might be good to support right click to describe in this menu. -------------------------------------------------------------------------------- 060a6a1bfc | Kate | 2022-01-18 17:22:39 +0000 Fix some spell description typos -------------------------------------------------------------------------------- 417bf1fd16 | Edgar A. Bering IV | 2022-01-18 09:03:21 -0600 fix: a teleport closet (12658) -------------------------------------------------------------------------------- cbc3b0e11f | Edgar A. Bering IV | 2022-01-18 09:00:01 -0600 docs: changelog through 0.28-a0-1557-g548886b -------------------------------------------------------------------------------- 548886b2ed | Edgar A. Bering IV | 2022-01-17 21:53:49 -0600 feat: slightly increase the orb floor drop rate Since orbs, unlike shields, don't come as monster gear currently. -------------------------------------------------------------------------------- 303e8cf5e6 | Edgar A. Bering IV | 2022-01-17 21:53:49 -0600 fix: tune down guile a lil bit -------------------------------------------------------------------------------- 9ae15a6949 | Nicholas Feinberg | 2022-01-17 18:42:51 -0800 Move Passwall check to a better place The confusingly similarly named casting_ and _spell uselessness checks are for different things - casting_ is only for costs, Ru sacrifices, and a few other broad things, whereas whereas spell_ checks everything else. -------------------------------------------------------------------------------- 6f2a123a96 | Nicholas Feinberg | 2022-01-17 18:42:28 -0800 Make Call Imp fight alongside you Typo in 877f77fdfb4cba3a06bde7f51e1239edfa655e6c . -------------------------------------------------------------------------------- 6a8d134351 | Edgar A. Bering IV | 2022-01-17 20:38:49 -0600 fix: restrict passwall's constriction restriction to passwall -------------------------------------------------------------------------------- ad4bc827a9 | Edgar A. Bering IV | 2022-01-17 20:26:09 -0600 text: clarify transmutations spell power effects -------------------------------------------------------------------------------- 877f77fdfb | Edgar A. Bering IV | 2022-01-17 20:00:32 -0600 text: clarify the spellpower dependence of Summonings spells (10906) -------------------------------------------------------------------------------- eb7d2789bd | Edgar A. Bering IV | 2022-01-17 19:03:05 -0600 feat: stop teleporting passwall obstructing monsters (5107, 12041) The player has paid the MP and delay cost, if we can't shift the target abort. The lack of space only occurs in packed vaults and specific vaults and allows for cheesing more than it adds gameplay. Closes #2127 -------------------------------------------------------------------------------- 753840947a | Edgar A. Bering IV | 2022-01-17 18:21:26 -0600 fix: trigger explore traps on passwall end immediately (12647, 11952) The "free turn" exempting players from traps was unintuitive and surprising. Unlike doors and fog, which do bring new tiles into view, remaining completely in place and triggering a trap in a subsequent turn breaks the feel and expectation of trap effects. -------------------------------------------------------------------------------- a3b06d5894 | Edgar A. Bering IV | 2022-01-17 18:04:44 -0600 fix: prevent passwall while constricted Constriction interrupts passwall, but then you can just start again. Not that it's a good idea often, but for consistency with stair delays constriction blocks passwall. -------------------------------------------------------------------------------- 15810a7b44 | Edgar A. Bering IV | 2022-01-17 17:25:48 -0600 fix: treat Passwall like stair and shaft-self delays Treating Passwall like a usual delay, as opposed to a multi-turn move commitment like shaft self and stairs, created all sorts of weird things as documented in Mantis #12239, #11825, and #10961. Treating it like a stair or shaft self delay makes it behave more like "movement" and gives it a consistent set of rules. -------------------------------------------------------------------------------- 957fa82e37 | Edgar A. Bering IV | 2022-01-17 17:25:36 -0600 fix: adjust some inapprorpiate uses of force interrupts -------------------------------------------------------------------------------- 945cd3f27e | Nicholas Feinberg | 2022-01-17 13:35:51 -0800 Fix thunderhulk armour (Nomi) -------------------------------------------------------------------------------- ef8730868c | Edgar A. Bering IV | 2022-01-17 15:15:57 -0600 fix: respect FTILE when destroying terrain Closes #1628 -------------------------------------------------------------------------------- e92cbb8f83 | Edgar A. Bering IV | 2022-01-17 14:20:18 -0600 fix: enrage elven twins taken to duel If a player duels one sibling have the other react as if they're already dead. This is because there are only three ways out of the arena for the player - their death (so who cares) - the death of the elven twin they're dueling (so the twin's gonna be mad when they get back) - renouncing okawaru within the arena to escape (twin's still mad that you dared do such a thing, also a ridiculous edge case) Closes #2325 -------------------------------------------------------------------------------- 7dfede7c9b | Edgar A. Bering IV | 2022-01-17 13:52:20 -0600 fix: the build -------------------------------------------------------------------------------- eb816f4f03 | Edgar A. Bering IV | 2022-01-17 13:34:55 -0600 fix: set pet_target when using a LOS attack spell Relevant for Hepliaklqana followers in the days of shooting through your Hep ancestor. Closes #2256. -------------------------------------------------------------------------------- 4c6099d30f | Edgar A. Bering IV | 2022-01-17 13:34:55 -0600 fix: don't offer to throw_item_no_quiver if you're a cat Closes #2348. -------------------------------------------------------------------------------- b657c59d09 | Edgar A. Bering IV | 2022-01-17 13:34:55 -0600 fix: keep grey dracs unbreathing in dragon form Since everyone else keeps their breath weapon and grey dracs don't get one they should get this! Closes #2349 -------------------------------------------------------------------------------- 933e3b857f | Edgar A. Bering IV | 2022-01-17 13:34:55 -0600 fix: add breaks to a switch statement 467f337aae6 did not intend these fallthroughs. Closes #2350. -------------------------------------------------------------------------------- 9ba09be145 | Edgar A. Bering IV | 2022-01-17 13:34:55 -0600 fix: don't try to die repeatedly if pending revival Prevent reflection and other misc bound soul related crashes when the revival is triggered by something on the monster's turn. Closes #2323. -------------------------------------------------------------------------------- 5967ad2b6c | Edgar A. Bering IV | 2022-01-17 13:34:55 -0600 fix: don't offer unavailable gods in interlevel travel Closes #2315 -------------------------------------------------------------------------------- a1f3fc70dd | Edgar A. Bering IV | 2022-01-17 13:34:55 -0600 fix: correct the Xom webtiles moodmeter Closes #2186 -------------------------------------------------------------------------------- 811ca023a5 | Edgar A. Bering IV | 2022-01-17 13:34:55 -0600 fix: a teleport closet in an arrival Closes #2151 -------------------------------------------------------------------------------- ee5c5fb8bb | advil | 2022-01-17 14:04:51 -0500 fix: re-allow `w-` Originates from fc4545441119, because of the new tag, `-` in this menu needed a menu-specific check. Also, generalize this code a bit, and add the macro submenu to the list as well. Resolves #2363 -------------------------------------------------------------------------------- 570b316de1 | advil | 2022-01-17 13:58:17 -0500 fix: default for menu_arrow_control intended to be true, oops -------------------------------------------------------------------------------- 866c7d65e6 | advil | 2022-01-17 13:44:10 -0500 docs: remove a spurious plural I already fixed one mismatch between this heading and ToC but missed the plural. -------------------------------------------------------------------------------- 7af6551d5a | advil | 2022-01-17 13:35:47 -0500 feat: option to disable arrow key menu control I admit that 50% of the reason I'm adding this is so that the 1% of the player base that is enraged by >90s UI features will stop bugging me. But I suspect it could also be useful for accessibility purposes to be able to disable hover in console -- for example I doubt it works well with screen readers without some specific effort that I don't really know how to do. As a side effect this option does disable arrow control for all menus that had it added in the 0.27 cycle. -------------------------------------------------------------------------------- be3f6fb03a | advil | 2022-01-17 11:25:42 -0500 docs: move auto_hide_spells to a different section I think this was probably in 3-a because its consequences do happen during pickup, but I think it's probably more intuitive for it to be in the "Command Enhancements" section with most other spell options. -------------------------------------------------------------------------------- 8903882b62 | advil | 2022-01-17 11:15:20 -0500 fix: swap order in add_alias calls oops -------------------------------------------------------------------------------- 6c7bc2a1f9 | advil | 2022-01-17 11:07:18 -0500 refactor: rename `.._brand` options to `.._highlight` I assume there's some charming retro-roguelike and/or Australian explanation for the use of "brand" here, but it seems completely non-standard now and extremely confusing. I chose "highlight" as a much more intuitive name. I also rewrote a fair amount of the options guide for these beyond the name, partly with an eye towards including all the search terms I initially tried when looking for this code the other day. This is a full internal rename as well. The actual implementation of these options is very odd and could use some refactoring, but I'm not going to do that right now. Needs testing on Windows (CI should be enough). -------------------------------------------------------------------------------- 7e9bcdcf84 | advil | 2022-01-17 10:09:11 -0500 feat: add shift-left/right as line up/down menu shortcuts This is because in my testing I've found terminals that by default only define shift left/right and not up/down, and shift left/right weren't doing anything at all in any menus. For completeness I added this in webtiles also, though shift up/down already worked there. -------------------------------------------------------------------------------- 066c4f1fa3 | advil | 2022-01-17 10:09:11 -0500 fix: correctly handle console shift arrows if defined Previously, the crawl binary got ncurses keycodes that were not ignored by the binary but not interpreted properly. This translates the keycodes to crawl's internal scheme, so that they are recognized by e.g. the menu code. If people had macros for these keycodes they will need to remap. Worth noting that these being correctly produced is pretty variable. E.g. in my testing, iTerm defines all of them, mac terminal defines only left and right, and putty defines none of them. Usually (always?) what happens instead is that the terminal sends the escape codes for regular arrow keys. It would be possible to configure them in at least some terminals using the escape codes that I noted in the comments. -------------------------------------------------------------------------------- e72afd5fc6 | Kate | 2022-01-17 06:53:36 +0000 Don't let monsters try to re-polymorph a polymorphed player Fixes monsters wasting charges and turns emptying their wands of polymorph after already having succeeded at polymorphing the player. -------------------------------------------------------------------------------- 5f3ffaac98 | Kate | 2022-01-17 06:53:36 +0000 Let monsters use spell_logic for zapping wands Doesn't have any effect currently, but makes it possible to add better logic for deciding whether to zap a wand where needed. -------------------------------------------------------------------------------- 8550a1e9b9 | Kate | 2022-01-17 06:53:36 +0000 Mark confusion beams as harmless to monsters with clarity -------------------------------------------------------------------------------- 870370a84a | Kate | 2022-01-17 06:53:36 +0000 Remove Mephitic Cloud's damage It did 0-2 damage, which was mostly insignificant but resulted in it not being consistently marked as useless against targets with clarity (with a hack for the player to mark it harmless unless below 2HP). Instead remove the damage and handle clarity properly. -------------------------------------------------------------------------------- c3277d3759 | hellmonk | 2022-01-16 21:24:36 -0500 tweak some spider monsters Make some of the new spider enemies a little frailer. -------------------------------------------------------------------------------- c307741d3e | hellmonk | 2022-01-16 20:49:56 -0500 feat: tweak layout_spider_delve Adjust parameters to avoid generating big open levels so frequently. -------------------------------------------------------------------------------- be868bca14 | advil | 2022-01-15 22:20:35 -0500 fix: tone down default `may_stab_brand` (G-flex) This was set to yellow, which by default on most terminals is extremely bright as a background color, with poor contrast with many foreground glyph colors. Most players were either used to this and didn't notice, or playing in 8 color putty where this comes out as `brown`, not the brighter yellow that putty is also capable of displaying (but doesn't on default settings). I think `brown` (which is typically a sort of mustard color) has much better contrast on terminals I've tried anyways, and it's not otherwise used for a monster highlight, so let's go with that. -------------------------------------------------------------------------------- 020f416216 | advil | 2022-01-15 21:55:53 -0500 fix: revert main menu hover changes Using lightgrey with a manually inverted foreground color seems safer overall in terms of contrast since this menu doesn't need to ever change foreground color; unfortunately the implementation (which I've just restored) is all a bit ad hoc. Possibly this hover scheme could be better generalized. -------------------------------------------------------------------------------- 37088b3766 | advil | 2022-01-15 21:55:53 -0500 fix: tweak hover color for 8 color consoles This moves it from lightgray to blue, since the latter has much better overall contrast with all foreground colors. -------------------------------------------------------------------------------- 81556d0073 | advil | 2022-01-15 21:55:53 -0500 feat: color/display diagnostic popup The somewhat odd situation has emerged several times recently that console players don't realize that their terminal is running in some variant of an 8 color compatibility mode. First, when allow_extended_colors=true was made the default and people thought 16 color mode was "new", and then more recently, when putty users have been complaining about the new menu hover being too non-contrasty. (I'll actually change that, but this isn't that commit.) This popup provides in-game information that is mostly relevant to console players about what their terminal and options are actually doing. It's largely aimed to make it clear to putty users that something is wrong, but should be more generally useful. For other build targets most of the information isn't relevant, but it still shows the color palettes corresponding to the 8/16 ANSI colors. The popup is slightly hidden, under `?!`. I can imagine a later approach where it is under an "advanced" submenu of the game menu, especially if it eventually becomes an interactive popup. But for now this also lets it be used at the main menu. Still needs testing on windows. -------------------------------------------------------------------------------- 3e5f17529f | advil | 2022-01-15 21:55:53 -0500 feat: support background colors in formatted_string This is not something that I think we should start using much, or really even at all, but it's very useful for diagnostic purposes. -------------------------------------------------------------------------------- e4f4046303 | Kate | 2022-01-15 22:42:27 +0000 Don't allow attempting to enter Malign Gateway portals It was very rarely possible to even try since usually the portal would be blocked by the tentacle, and having it deal a small amount of damage and blink the player is unnecessarily complicated compared to just treating it consistently as a solid feature. -------------------------------------------------------------------------------- 142ac7cd73 | Kate | 2022-01-15 22:42:27 +0000 Don't use Malign Gateways as walls for Creeping Frost (#2359) They're sort of solid for most purposes, but shouldn't be valid targets for Creeping Frost. Closes #2359. -------------------------------------------------------------------------------- 0647d9364e | Kate | 2022-01-15 21:31:10 +0000 Refactor piety gain prevention in the Abyss Fixes a number of bugs: Ru and Ashenzari will no longer offer new sacrifices/curses from exploring or killing monsters in the Abyss, but if the player enters with one already available, they can still gain piety from taking it. Gods in general will no longer give misleading messages about accepting your kills in the Abyss. Beogh will no longer gift new followers or upgrade weapons/armour/classes of existing followers, but will still give existing followers healing. Hints mode won't give a hint about gaining XP for killing a monster in the Abyss. Yredelemnul piety will be properly tracked on gaining zombie followers. Converting to Lugonu or picking your first god as a monk in the Abyss will properly give bonus piety. -------------------------------------------------------------------------------- d0f6b136d3 | hellmonk | 2022-01-13 23:31:53 -0500 feat: shrink some spider bands Make the monster density a little less overwhelming. -------------------------------------------------------------------------------- 5ff2a343f8 | hellmonk | 2022-01-13 23:19:47 -0500 rework orb of destruction damage formulas Removes a secret hidden power stepdown and makes the formula linear. The new formula is roughly equivalent damage to the old at low power, somewhat worse at about 100 power, and very slightly worse at 200 power. Additionally, to emphasize the positional aspect of the spell, change the damage dropoff at low distance to more harshly penalize point-blank iood casts. Distance 1 now deals a wimpy 30% damage (was 50%) and 60% at range 2 (was 70%). Range 3 and above are unchanged. Can be adjusted further if this is an overnerf. -------------------------------------------------------------------------------- 054e75b119 | Kate | 2022-01-14 01:03:26 +0000 Reword an ushabti cast message -------------------------------------------------------------------------------- b10ca78fad | Kate | 2022-01-14 01:00:15 +0000 Fix inventory menu colouring not being used in item menus Possibly the new item selection menus could use a new menu_colour category, but previously they used the inventory category so keeping that behaviour seems reasonable. -------------------------------------------------------------------------------- 3893175d92 | Nicholas Feinberg | 2022-01-12 22:10:48 -0800 Add Summon Hell Sentinel description (Nomi) Oversight in ff29be1aa77. -------------------------------------------------------------------------------- 8c907de6ad | advil | 2022-01-12 19:12:58 -0500 fix: memorise menu ui tweaks * convert to keyhelp, remove custom set_more calls, make keyhelp more consistent with others. * fix various spacing issues, including interactions of search and divine exegesis, search width in local tiles, column alignment consistency. * Indent the more if the title is indented (both tiles targets). I'm not actually sure I like how this looks but it leads to a more consistent UI behavior with console spacing. It also prevents window size jumping in local tiles in various cases. What would be better is if the more column width itself could be adjusted, but that seems extremely hard. The code to generate this menu's keyhelp remains an unholy mess of c and c++ style string formatting. -------------------------------------------------------------------------------- 839a4452db | Nicholas Feinberg | 2022-01-12 11:25:18 -0800 Turn Spider noise back down (ardl) It was quieted down back when web sense was removed, but Spider monsters are a lot more lively now - players don't need as big a party to have fun. We can re-revert this if spider feels too lonely with normal noise. -------------------------------------------------------------------------------- 9e29e62679 | Nicholas Feinberg | 2022-01-12 11:24:43 -0800 Revert "REVERTME: increase orb rate for testing" Initial testing is done. This reverts commit 8dc402e3264e5ac93cec5fabe3b95c5186369434. -------------------------------------------------------------------------------- 98be2d08f0 | Nicholas Feinberg | 2022-01-12 11:24:32 -0800 Revert "force Spider generation for testing" Initial testing is done. This reverts commit be321230710a090a0a22678120c99eebdee71df4. -------------------------------------------------------------------------------- 99b08493b7 | Nicholas Feinberg | 2022-01-12 11:24:19 -0800 Revert "REVERTME: Make infusion gloves very common" Initial testing is done. This reverts commit e3c729c0851fa3275ad841092a6c6a803fe431f6. -------------------------------------------------------------------------------- 21c982267c | Nicholas Feinberg | 2022-01-12 11:04:02 -0800 Halve Anguish damage (ebering) It was a bit much. -------------------------------------------------------------------------------- f88bddc06d | advil | 2022-01-12 13:41:39 -0500 fix: fix hover colors on 8 color consoles and standardize On 8 color consoles, a darkgrey background color as hover shows up as black. This commit uses lightgrey in an 8 color setting instead. Otherwise, I think darkgrey looks better, though it's possible opinions may differ. (If they do, we'll find out soon, since I've applied this standardization to the main menu as well -- it used its own custom hover color.) -------------------------------------------------------------------------------- 61e5acc4d9 | advil | 2022-01-12 13:41:39 -0500 doc: further clarify some console color logic Add a contenful comment to the relevant code, and restructure the options documentation. -------------------------------------------------------------------------------- ab9d7fee88 | Edgar A. Bering IV | 2022-01-12 10:26:41 -0600 feat: reduce poison dart quantity At current quantities a character can always have a mega ammount past the early game, and is incentivsed to use them whenever they lack a stronger ranged alternative at minimal cost. Let's lower the stack size to put a bit more strategic pressure on their use. Poison darts are in a bit of an awkward place relative to their other thrown siblings, it might make more sense to move the poison brand to boomers and have darts only be specialty items, but that's for a future consideration. -------------------------------------------------------------------------------- 3c2d7996e7 | Kiëd Llaentenn | 2022-01-12 09:38:14 -0600 fix: make Trog tantrum if orb of energy is used An orb of energy is primarily used for enhancing spellcasting, so it makes sense that it should be considered a wizardly item and thus that Trog should frown upon its use. -------------------------------------------------------------------------------- 5f9446187d | nlavsky | 2022-01-12 09:37:25 -0600 feat: don't grant explore piety to Jiyva worshippers in the Slime Pits Granting exploration piety in the Slime Pits encourages Jiyva worshippers to fully explore this threat-free branch. A dozen tests show that if the player dives the Slime Pits and joins Jiyva on the last floor, they'll have 63-105 piety from auto-exploring the rest of the branch. The average is 86 piety, which is three stars. Joining Jiyva before entering the branch guarantees that the player will get to 100+ piety and reach four stars after fully exploring the Pits. -------------------------------------------------------------------------------- 253b278887 | Edgar A. Bering IV | 2022-01-12 09:36:08 -0600 fix: throatcutter doll tile -------------------------------------------------------------------------------- 08698888e4 | Edgar A. Bering IV | 2022-01-11 22:14:14 -0600 feat: an untended Ignis altar temple 12 altars with nice plants and roaring votive fires, plus an Ignis altar and some ecumenical altars with sputtering smoke and cobwebs. Less dramatic than pdpol_scorched_temple to tell a more subtued ecumenical story about abandonment. -------------------------------------------------------------------------------- 7e3bb95383 | paul | 2022-01-11 22:14:14 -0600 feat: a rare Ignis-themed temple [ Committer's note: Closes #2219. Tweaked the lava lake room and the tile and console colours, used granite statues instead of stone arches for the broken pillars for consistency. Added water to the smaller rooms and wall contrasts. ] -------------------------------------------------------------------------------- 7d64a5f647 | paul | 2022-01-11 22:14:14 -0600 fix: an off by one error in a temple vault altar count It looks like minmay_temple_bridge_d expects to place 17 or 18 altars but there are only markers for 16 or 17. -------------------------------------------------------------------------------- a01311f068 | paul | 2022-01-11 22:14:14 -0600 fix: a comment on pow_rolls default value -------------------------------------------------------------------------------- a6001f96d0 | advil | 2022-01-11 19:52:28 -0500 feat: add `bold_brightens_foreground=force` Recently it came up that it can be helpful for console readability to be able to use bold weight on bright colors even on modern terminals, not just as a workaround; people (and by people I mean ebering) had been doing this just by using 8 color mode. This commit provides an option to not ignore bold_brightens_foreground in 16 color mode. -------------------------------------------------------------------------------- 24bb901ea4 | advil | 2022-01-11 19:52:28 -0500 fix: more consistent shopping list menu keyhelp Move the shopping list keyhelp to the more, make it more consistent with other keyhelps (especially shops). This also fixes a number of misc base class issues: * correctly handle default keyhelp more init * spacing in default keyhelp * generalize some code for lettering in keyhelps * update_more timing -------------------------------------------------------------------------------- 0a3215c577 | Edgar A. Bering IV | 2022-01-11 17:40:07 -0600 fix: don't feel guilty for choppin firewood Don't cause Anguish damage when attacking firewood. -------------------------------------------------------------------------------- 8196b01e9b | Kate | 2022-01-11 07:31:45 +0000 Fix Xom granting ~4 potions of experience at once Caused by !XP now caring about effect power. -------------------------------------------------------------------------------- 077359a4bf | Perry Fraser | 2022-01-10 20:44:47 -0600 fix: display_bar should clamp negative values * fix: display_bar should clamp negative values If a bar was displayed of something with a negative value (like with EV) then text such as "EV: none (normally )" could be displayed. This function is only used for values that aren't meaningful when negative, so let's clamp any negative values to zero. -------------------------------------------------------------------------------- a4b24466b4 | Edgar A. Bering IV | 2022-01-10 19:31:10 -0600 fix: an anguishing crash -------------------------------------------------------------------------------- da10c1d967 | Edgar A. Bering IV | 2022-01-10 18:44:32 -0600 tiles: throatcutter and maulers (Sastreii) Closes #2322 -------------------------------------------------------------------------------- fc45454411 | advil | 2022-01-10 18:51:03 -0500 fix: disable item class hotkeys in UseItemMenu This adds nothing except surprises, especially the case noticed by ebering, where an optimistic person might imagine that the `r` menu has a help dialog and instead read the first scroll. Implementation is ugly.. -------------------------------------------------------------------------------- 7509e2a2af | Perry Fraser | 2022-01-10 17:22:17 -0600 fix: phial should always engulf the center target Previously, if the phial of floods knocked a target back onto a non-floor or water feature like a staircase, then no flooding would generate at that location (fine) and consequently no waterlogging/engulfing (not fine). Let's instead make create_feat_splash return a set of coordinates, and add back the center location before iterating over monsters to waterlog. Closes #2331. -------------------------------------------------------------------------------- 744777c2d9 | advil | 2022-01-10 18:20:58 -0500 feat: enable arrow keys for shopping list menu Also, improve the behavior of a subprompt for long item names. -------------------------------------------------------------------------------- 74d9c6da68 | advil | 2022-01-10 18:20:58 -0500 fix: show hover by default for shop menu -------------------------------------------------------------------------------- 486f26dfa3 | Edgar A. Bering IV | 2022-01-10 17:19:12 -0600 fix: an intermittent levelgen crash An operator precedence bug. The necessary check is covered by !feat_is_gate in the changed conditional. -------------------------------------------------------------------------------- 273aa18710 | advil | 2022-01-10 17:35:54 -0500 fix: don't check gold for MSG_NOTHING_CARRIED -------------------------------------------------------------------------------- 7cf701f5d5 | advil | 2022-01-10 17:35:54 -0500 fix: don't crash when cycling hover on an empty menu This is an old one, but I guess it's harder to trigger without item menus. -------------------------------------------------------------------------------- 6dc9c6bb35 | Perry Fraser | 2022-01-10 16:31:03 -0600 fix: properly describe moving staircases When you climbed down a staircase while Xom was sliding them around, you could get the message " slides away from you right [...]". The stair was being described by feature_description_at which only uses the player map knowledge, which means the staircase would be DNGN_UNSEEN. This uses feature_description instead to get around that. -------------------------------------------------------------------------------- 56126dae6c | advil | 2022-01-10 17:24:17 -0500 fix: properly sync non-templated mores to webtiles -------------------------------------------------------------------------------- 62e843ad78 | advil | 2022-01-10 17:07:09 -0500 fix: crash during settings_db initial generation Reported by @Walther in #2332 -------------------------------------------------------------------------------- 442d625886 | advil | 2022-01-10 17:06:53 -0500 fix: don't send crash milestones over webtiles sockets This appeared in 6ef7baa362 but shouldn't be applied to the case of crash milestones. (a) this code is super heavy and not safe after a crash, and (b) it has timing issues with the socket closing, and so was causing recursive crashes on a dead socket. (This is why no crash milestones have appeared for the last couple weeks, they've all been recursive crashes which don't generate milestones.) To be clear, after this commit crashes will still be written directly to the milestones file. -------------------------------------------------------------------------------- 981f6e296f | robertxgray | 2022-01-10 15:43:02 -0600 fix: check negative energy resistance when casting vampiric drain The game doesn't warn the player when casting vampiric drain on natural monsters with immunity to negative energy (Josephine). -------------------------------------------------------------------------------- 841984c3b6 | Aliscans | 2022-01-10 15:33:48 -0600 fix: stop artefact amulets of faith from flashing on first worshipping Gozag The game checked ignore_faith_reason() when a non-demigod puts on an amulet of faith, and checked is_useless_item() when one committed to a god. These give different results for artefacts (which are never considered "useless"). It now checks ignore_faith_reason() in both cases, and there is no special message when a character wearing an amulet of faith worships Ashenzari, Gozag or Ignis. Co-authored-by: Aliscans -------------------------------------------------------------------------------- 8b0d500728 | Aliscans | 2022-01-10 15:31:07 -0600 feat: mark identify scrolls as useless once everything is identified. Create a "have identified all potions and scrolls" prop. Scrolls of identify are treated as useless if it is set. It's updated on game load if the version has changed, and also whenever set_ident_type() changes something. This also refactors several checks for complete identification to check this prop. [ Committer's note: Closes #2244. Added Mu special casing. ] -------------------------------------------------------------------------------- 6790c33dfa | advil | 2022-01-10 15:57:59 -0500 fix: don't divide by 0 in keyhelp rendering missed because clang doesn't crash, gcc does -------------------------------------------------------------------------------- 1e88248612 | advil | 2022-01-10 15:04:48 -0500 fix: update acquire menu to work with item menu changes The acquire menu had its own custom keyhandling for some reason; this commit removes this and uses the `Menu` default keyhandling. It also updates this menu's keyhelp to use the new API (and fixes some issues in that API that I had missed). -------------------------------------------------------------------------------- 30118fcd2b | advil | 2022-01-10 15:04:48 -0500 fix: remove old cursor code This has been semi-broken for some time, completely broken on webtiles, and was also a fairly bad implementation of the idea to begin with. It is superseded by the new hover code, so let's just kill it completely. -------------------------------------------------------------------------------- b5dea8a184 | advil | 2022-01-10 15:04:48 -0500 feat: arrow key controls for item menus This ended up being a fairly big change that needed to be mostly done at once. This affects every item menu except stash search and shopping list (which I'll do in a later commit). Because this affects a *lot* of different UI elements, there may be some more testing needed... Menu-general changes: * Arrows controlling hover is fully implemented for multiselect menus (previously only for singleselect menus). In webtiles and tiles, shift+arrow have the old behavior, but I haven't gotten this to work on console. * MF_ALWAYS_SHOW_MORE is removed; a more is now visible iff it is non-empty. * New flag, MF_INIT_HOVER: if set, show hover on initial display. Previously menus have needed to manually call `cycle_hover`. This is on for all item menus except the regular inventory. * New virtual method, get_keyhelp: generate a keyhelp more for both the case of a menu with scroll bars, and a menu without. Designed to be overridden, see the known item menu for an example. * scroller keyhelp is shown in more cases and fully implemented in tiles targets (before it was only complete for console) * Many hover issues fixed and tweaked, especially in webtiles * Old multiselect cursor stuff is disabled, will be removed in a separate commit * In multi-select menus '.' does not change the hover. (If people want a key that does this it could be arranged, but it isn't so clear anyone has been using the old cursor -- it was broken on webtiles anyways.) Item menu changes: * MF_ARROWS_SELECT is on for any item menu unless it is MF_NOSELECT * Bugs in multiselect category selection fixed, category selection snaps category into view UseItemMenu: * better indication of `easy_floor_use`. (Though, from a UI perspective, I'm not a fan of this being on by default, it's not very consistent...) * hovering can cross that inv/floor boundry and reletters items when it does so. (Needs to ping the server on webtiles unfortunately.) -------------------------------------------------------------------------------- cdc11d4697 | advil | 2022-01-10 15:04:48 -0500 refactor: remove `easy_quit_item_prompts` (wheals) Since c5434703b61cb9, these prompts have been quite hard to get to, and are perhaps on the verge of disappearing altogether. I think this option may have also targeted worry about some potential item-wasting cases (maybe enchant scrolls and the like), but if so, these cases are long gone as well. At this point, this micro-option doesn't serve much purpose, so remove (retaining the current default behavior). -------------------------------------------------------------------------------- 20fba0d420 | advil | 2022-01-10 15:04:47 -0500 refactor: simplify drop ui Previously, the drop menu would let you drop to a prompt by hitting enter with nothing selected. This is not very useful, and the code was a mess; plus I plan to change the behavior of enter somewhat in a later commit. (I guess there may be players out there who will need to remap enter+letter to letter+enter at the worst?) If there's really demand for the prompt mode it may be better to integrate it with prompt_invent_item and get a working codepath for the toggle. But for now just make this function much more straightforward -- as of this commit, enter with nothing selected just exits. -------------------------------------------------------------------------------- 95bfa34988 | advil | 2022-01-10 15:04:47 -0500 feat: clean up and generalize menu keyhelp code This commit generalizes the keyhelp code and makes most of it less client-specific: * show scroll keyhelp on all clients * refactor the templating code for adding in the percent so that it can be used on local tiles and is a bit less ad hoc (it's still weird though). * refactor so that keyhelp can be overridden. -------------------------------------------------------------------------------- 84980b0d82 | advil | 2022-01-10 15:04:47 -0500 fix: adjust shop keyhelp The right-click hint is only accurate for local tiles; for webtiles any click outside will work but a right-click inside will not -- too complex to describe, but also now standardized. -------------------------------------------------------------------------------- 370c3107d9 | advil | 2022-01-10 15:04:47 -0500 fix: modernize some inventory code -------------------------------------------------------------------------------- dc4cd7eb33 | Edgar A. Bering IV | 2022-01-10 13:53:10 -0600 fix: don't scan for unlinked items midway through abyss vault generation -------------------------------------------------------------------------------- 66ff00425e | Goratrix | 2022-01-10 11:01:11 -0600 fix: small tweaks to crystal spear projectile tiles Correct size and remove stray pixel in crystal_spear1.png and clean up the rest of the tiles. -------------------------------------------------------------------------------- d6a3831c70 | Nikolai Lavsky | 2022-01-10 10:54:02 -0600 feat: display potion/scroll rarity on the item knowledge screen As a followup to 2f15ad60, this commit makes it easier to compare potion/scroll rarities by displaying all of them on one screen. When deciding which unidentified consumables to use in order to survive, players often check the `\-` screen to see possible outcomes. So it makes the item knowledge screen a perfect place for this information. -------------------------------------------------------------------------------- aeb352d00f | Perry Fraser | 2022-01-10 10:35:06 -0600 fix: skip title on tiles integration tests -------------------------------------------------------------------------------- 78a2654a08 | Edgar A. Bering IV | 2022-01-10 10:30:02 -0600 text: update some Yred translation keys -------------------------------------------------------------------------------- 374218e70b | Zhang Kai | 2022-01-10 10:29:21 -0600 text: update Chinese translations of ability.txt Add translations. 增添翻译。 [ Committer's note: Fixed whitespace, Closes #2203. ] -------------------------------------------------------------------------------- 9084b0ae73 | Aliscans | 2022-01-10 10:11:47 -0600 fix: remove references to Hell from feat_is_branch_exit() Delete DNGN_ENTER_HELL, as the function returns false whether it's listed separately or not. Delete DNGN_EXIT_HELL and feat_is_hell_subbranch_exit(), and adjust the callers to accommodate this. This should not affect game behaviour. Also remove feat_is_hell_subbranch_exit() from is_feature_fudged(), as is_feature() now returns true for these and CMD_GO_UPSTAIRS. -------------------------------------------------------------------------------- a2056f7337 | Aliscans | 2022-01-10 10:11:47 -0600 fix: remove references to Hell from feat_is_branch_entrance() feat_is_hell_subbranch_exit() can simply be deleted, as the function returns false whether it's listed separately or not. The response to DNGN_ENTER_HELL changes from false to true, so change the functions which call it to accommodate this. The things which should behave differently are: - Hints mode now treats DNGN_ENTER_HELL as a branch entrance. - In lua (dlib), is_branch_entrance() now returns true for DNGN_ENTER_HELL. This isn't used in the Crawl source at present. -------------------------------------------------------------------------------- 2965a4dc42 | Aliscans | 2022-01-10 10:11:47 -0600 refactor: split DNGN_ENTER_HELL into one feature per destination Replace DNGN_ENTER_HELL with DNGN_EXIT_COCYTUS, DNGN_EXIT_DIS, DNGN_EXIT_GEHENNA or DNGN_EXIT_TARTARUS for gates leading out of those branches. This means that the descriptions for these are more appropriate, and makes it easier to change how one of them looks in a console build. [ Committer's note: Closes #2173. Tweaked descriptions and made these PORTAL_EXIT features. ] -------------------------------------------------------------------------------- b131497017 | Edgar A. Bering IV | 2022-01-10 09:31:43 -0600 fix: ensure Mennas never speaks across attitude changes Closes #2330 -------------------------------------------------------------------------------- a049f037fa | Edgar A. Bering IV | 2022-01-10 09:27:31 -0600 feat: some bound Donald dialog -------------------------------------------------------------------------------- c586ae71bd | Edgar A. Bering IV | 2022-01-10 08:29:55 -0600 fix: clarify shallow water's effect on large movement Closes #2345 -------------------------------------------------------------------------------- a5a8893891 | Edgar A. Bering IV | 2022-01-09 17:46:38 -0600 fix: a teleport closet in Nemelex: the Gamble Closes #2138. Closes #2126. -------------------------------------------------------------------------------- 47dfaac58e | DreamDust | 2022-01-09 17:23:04 -0600 fix: prevent breaking level connectivity (#2137) Closes #2039 Adds extra padding to nicolae_take_the_stairs -------------------------------------------------------------------------------- 108eccecdf | Aliscans | 2022-01-09 17:21:26 -0600 fix: use the standard names for monsters in "comes into view" messages. (#2132) Change the "comes into view" messages to use the names the game normally uses for each monster by preference, rather than a name based on the monster type. This particularly affects dancing weapons and ugly things. The game still uses different names (based on the "genus") when a lot of different monsters come into view at once. This should fix bug #0012649. Co-authored-by: Aliscans -------------------------------------------------------------------------------- 6c55d0bc0c | Edgar A. Bering IV | 2022-01-09 16:07:00 -0600 feat: display to hit chance for targeted drac breath weapons Closes #2165. This also resolves some internal todos around zap mappings for breath abilities. -------------------------------------------------------------------------------- c9894997ea | Kate | 2022-01-09 21:27:37 +0000 Adjust Kiku book gift logic Add Anguish as an option to the second book, move Agony from the second book to the first, and rework the logic for picking spells. The first book now guarantees Animate Skeleton, and then picks 3 spells at random from Pain, Corpse Rot, Sublimation of Blood, Vampiric Draining, and Agony. The second book guarantees Animate Dead, then picks 4 from Anguish, Dispel Undead, Borgnjor's Vile Clutch, Excruciating Wounds, Death Channel, and Simulacrum. This simplifies much of the logic while retaining the guarantee of a corpse-using spell in each book, and slightly increases the variation in spell choices for each book. -------------------------------------------------------------------------------- de96f65983 | Kate | 2022-01-09 21:27:37 +0000 Update options_guide defaults -------------------------------------------------------------------------------- 6bfe6b3ffa | Kate | 2022-01-09 21:27:25 +0000 Apply coding conventions -------------------------------------------------------------------------------- 6a3f3e4ae6 | Nicholas Feinberg | 2022-01-09 12:48:20 -0800 Fix a crash? -------------------------------------------------------------------------------- 7e5176108a | Nicholas Feinberg | 2022-01-09 11:48:21 -0800 Fix a name mispelling For years, I was very confident I knew how to spell Yred's name. For years, I was wrong! Oops. -------------------------------------------------------------------------------- 467f337aae | Nicholas Feinberg | 2022-01-09 11:34:41 -0800 New spell: Anguish (L4 Hex/Necro) With Yred's Injury Mirror ability removed, the design space of 'retalation damage' that it occupied has become open. Anguish puts a different spin on that idea, causing affected monsters to take twice the damage they deal for the duration of the affect. Assorted notes: - The theme is 'haunted by the damage you've done'. Horrible, supernatural visions of the wounds you've caused appearing on your own body, that kind of thing. - For flavour reasons, it doesn't work on mindless creatures, but it does work on intelligent demons and undead. - It's not a straight port of Injury Mirror as a player-based duration, largely because, without the piety cost of Injury Mirror, it'd suffer from the 'buff problem' of something you'd want to have online at all times. Probably there's some way to deal with that, but in general, Crawl spells work better as things you cast on enemies. - It's taken Corona's spot in the status effect icons, because Corona is now a somewhat uncommon effect on monsters (mostly just from Ru retaliation?) and not that important. We should strongly consider refactoring the status effects to not be packed into a single int, either by adding a second int (lol) or by using a list like sane people. We don't need to scrounge for a few dozen bytes per monster... it's 2022, for heaven's sake. - It's Hexes because it checks Will and I wanted to make a hex, and it's Necromancy for flavour (somewhat difficult to conceptualize as pure hexes) and to suggest fun synergy with undead allies. (Enemies hitting your zombies triggers anguish too, which is big thematic!) - I'm very unsure about balance. Lots of levers and knobs to pull, so let's try it out! -------------------------------------------------------------------------------- af83eef3db | Nicholas Feinberg | 2022-01-09 09:55:52 -0800 Remove support for Yred injury mirror Since it was removed in b4513a33dfc258858182bc1aa8ffa57d82efba1c . -------------------------------------------------------------------------------- aff854cc17 | Nicholas Feinberg | 2022-01-09 07:39:54 -0800 Give XP for frenzied monsters' deaths Frenzied monsters (from orbs of mayhem, Discord, or datura darts) gave no XP due to a detail of their implementation. In general, it's better for players to get XP for their kills (mostly for reasons of 'fun'), so let's fix that here. Balance issues are best handled through other mechanisms. -------------------------------------------------------------------------------- 82390b3a13 | Edgar A. Bering IV | 2022-01-08 11:31:44 -0600 fix: don't strip ashenzari abandoners naked (Aliscans) -------------------------------------------------------------------------------- 0490bf50c2 | Nicholas Feinberg | 2022-01-08 09:20:02 -0800 New hats (CanOfWorms) This code is very bad. -------------------------------------------------------------------------------- ec1d49878b | Nicholas Feinberg | 2022-01-08 08:34:59 -0800 Woodcutter/dreamshard tiles (Sastreii) Like a dream... keep trying, skeleton -------------------------------------------------------------------------------- 39c23d704c | Nicholas Feinberg | 2022-01-08 08:30:36 -0800 Update waypoint docs (Slacking) Don't claim that show_waypoints exists; it hasn't for quite some time. (Since f2373cbd01457d94902, 2016.) -------------------------------------------------------------------------------- 3e8e36ac5f | Edgar A. Bering IV | 2022-01-08 10:06:31 -0600 fix: nerf seracfall Reviewing tvs and play data, wendigo had big assists with shard shrikes (whose prevalence was turned down). Cocytus remained an outlier among the hells, with wendigo getting the lion's share of hell kills. So let's tone down seracfall damage a bit. -------------------------------------------------------------------------------- a82b073101 | Edgar A. Bering IV | 2022-01-08 09:43:47 -0600 fix: use abyss regeneration for wizard level regeneration Closes #2342 -------------------------------------------------------------------------------- f3d713df7a | Edgar A. Bering IV | 2022-01-07 14:43:57 -0600 refactor: give !xp power scaling -------------------------------------------------------------------------------- d764ef0d23 | Edgar A. Bering IV | 2022-01-07 14:43:57 -0600 feat: give an XP reward for the abyssal rune With the abyss now stripped of most rewards, let's give the rune a stronger incentive. It gives a potionlike effect for potions of XP equivalent to two potions of XP (due to how its implemented it gives slightly less skill XP than quaffing two !xp, but it's still a nice blob of skill XP and two XLs). -------------------------------------------------------------------------------- d21ca1c0ff | Kate | 2022-01-07 14:43:57 -0600 feat: make Abyss exits and staircases slightly more common With the changes to prevent scumming for XP or items in the Abyss, make exits slightly more common to try and make Abyss trips tend to be shorter (especially for characters that reach/are pulled to greater depths). -------------------------------------------------------------------------------- 6c1bee596d | Kate | 2022-01-07 14:43:57 -0600 feat: reduce wretched star malmutation rate Since it's no longer possible to work off temporary mutations while in the Abyss, make wretched stars only ever apply 1 bad mutation at a time with Corrupting Pulse, and reduce its casting weight so that it's more likely to be possible to deal with them without racking up a huge amount of bad mutations for the current Abyss trip. -------------------------------------------------------------------------------- 010f2a2272 | Kate | 2022-01-07 14:43:57 -0600 feat: don't grant piety in the Abyss Alongside XP gain and item generation, it also shouldn't be possible to gain piety in the Abyss, or to goldify corpses under Gozag. Uskayaw is an exception, since the piety isn't persistent, and likewise Yredelemnul still works normally. -------------------------------------------------------------------------------- 3b305989a8 | Edgar A. Bering IV | 2022-01-07 14:43:57 -0600 feat: increase abyss plunge rate The chance to fall deeper into the abyss is meant to increase the challenge, discourage scumming at high levels, and speed strong characters to the rune encounters. The chance is a bit low, this tunes it up. -------------------------------------------------------------------------------- 578a0bbfb4 | Edgar A. Bering IV | 2022-01-07 14:43:57 -0600 feat: remove abyss random item generation The second half of abyss scumming, collecting consumables on Abyss:1 and departing promptly on the first offered XP gate exit. Again, this has historically been regarded as not-worth-the-risk, but the shifting nature of the end game means that balance has changed. Vaults can still place items, but vaults are scary and sufficiently rare that this should be low enough percentage to be not a good idea to scum. -------------------------------------------------------------------------------- fcf540680d | Edgar A. Bering IV | 2022-01-07 14:43:57 -0600 feat: prevent gaining experience in the Abyss Abyss scumming has been present in the game for a long time, a lingering design wart where the running thinking is that the risks outweigh the benefits. With the changes to the Hells and Tomb this wisdom is a bit lackluster; indeed the strategic damage of the Hells can be countered by "working off" the stat and HP drain in the abyss. This commit locks out progress towards all XP-gated effects except the abyss progress timer. The player gets messaging to show Abyss monsters grant no rewards. -------------------------------------------------------------------------------- 19973ebb7a | Nicholas Feinberg | 2022-01-07 11:29:03 -0800 Fix some mutation comments -------------------------------------------------------------------------------- 79b0f14e7e | Nicholas Feinberg | 2022-01-07 11:27:09 -0800 Fix a mutation crash? -------------------------------------------------------------------------------- a4934feff6 | Kate | 2022-01-07 18:27:16 +0000 Remove the strength bonus from bite damage It was the only attack remaining with a special-cased stat bonus on top of the regular stat multipliers, and it was mostly an insignificant bonus. Increase base bite damage by 1 for bite attacks (which does include VS bite bite although this didn't previously benefit from the strength bonus), and give Dragon Form an effective extra 2 levels of fangs since this would be the main case where the strength bonus was actually noticeable. -------------------------------------------------------------------------------- ed6f2ea202 | Nicholas Feinberg | 2022-01-07 09:45:50 -0800 Remove a misleadingly named function undead_mutation_rot sounded like it would rot the player for trying to mutate. But it was just a thin alias over a bool check! -------------------------------------------------------------------------------- 8ce13c4dff | Nicholas Feinberg | 2022-01-07 09:43:38 -0800 Simplify delete_mutation() (gammafunk, Sauken) Replace a complex and hard-to-reason about loop with some classic unweighted reservoir sampling. -------------------------------------------------------------------------------- 082bef1587 | Nicholas Feinberg | 2022-01-07 08:02:30 -0800 Remove many diverse spells (dilly) RIP big spellbooks. -------------------------------------------------------------------------------- 7c84da036a | Nicholas Feinberg | 2022-01-06 18:33:56 -0800 Remove most angel sInv (Yermak) Largely redundant with haloes. Seraph keeps it as a 'boss', and profane servitor of course has an unhalo. -------------------------------------------------------------------------------- c19253909b | Nicholas Feinberg | 2022-01-06 18:17:08 -0800 Remove sInv from guardian mummies (kate) Plenty of other Tomb enemies still have it, and it's odd for guardian mummies to keep sInv while the 'higher threat' mummy priests don't. -------------------------------------------------------------------------------- 493c1fd462 | Nicholas Feinberg | 2022-01-06 18:09:36 -0800 Strip sInv from various enemies Now that Invisibility isn't a player-castable spell, we can dial back on monster sinv and prune it off some monsters. This cuts sInv from: - shrikes (both) - orc high priests, deep elf high priests, mummy priests, hierophants - water nymphs - ancient zymes, worldbinders, tentacled starspawn - jiangshi - shadow imp, chaos spawn, sun demon, ynoxinul - mlio minderbender, grinder, rupert Things that still have sInv: - spriggans, nagas, trolls and jellies - vault guards - "wizards" (some) - high-tier demons & all angels - some statues and some other stuff Plausible that more pruning is called for in future. -------------------------------------------------------------------------------- f95308ed99 | Kate | 2022-01-06 04:12:50 +0000 Add an ability targeter for Hepliaklqana Idealise -------------------------------------------------------------------------------- a4a8cb2b72 | Nicholas Feinberg | 2022-01-05 19:50:16 -0800 Remove the Tomb of Dorokhle Enormously complex, very weird (it'd turn into Blink in various cases?), and rather pointless. -------------------------------------------------------------------------------- 445fb3080f | Nicholas Feinberg | 2022-01-05 19:41:24 -0800 Add Enfeeble tile (Sastreii) -------------------------------------------------------------------------------- 32e282a20f | Kate | 2022-01-06 02:17:53 +0000 Simplify Jiyva tendril disarm chance To not check strength/dexterity - just use a straight monster HD check, and don't give "fighter" tagged monsters a bonus to their HD. -------------------------------------------------------------------------------- 0b286ecb3d | Kate | 2022-01-06 02:12:11 +0000 Fix retaliation dealing 0 damage with Confusing Touch active -------------------------------------------------------------------------------- 2894324c5e | Kate | 2022-01-06 02:12:11 +0000 Adjust Minotaur retialiation chance To be based on XL instead of stats, as with other incidental strength and dexterity checks. Now grants around a 25% chance to retaliate at XL1, and around a 50% chance at XL27, which is comparable to the previous chances for a Minotaur with average stats. -------------------------------------------------------------------------------- a8dd43b1d0 | Edgar A. Bering IV | 2022-01-05 11:34:09 -0600 tiles: radioactive spikes (Sastreii) -------------------------------------------------------------------------------- 7885d49575 | Edgar A. Bering IV | 2022-01-05 11:17:34 -0600 fix: account for orbs in invis_allowed (#12662) -------------------------------------------------------------------------------- 4df0f3684d | Edgar A. Bering IV | 2022-01-04 22:05:20 -0600 fix: spacing -------------------------------------------------------------------------------- ffcb275ae5 | Kate | 2022-01-05 02:18:06 +0000 Increase kite shield and tower shield encumbrance They were tuned a little low with the new formula. Tower shields now have similar penalties (for normal-sized species) to before the rework, and kite shields still have lower penalties until around 8 skill. -------------------------------------------------------------------------------- ee2755802b | Kate | 2022-01-05 01:41:15 +0000 Refactor aux attack accuracy Factor in some accuracy bonuses/penalties that previously weren't handled for aux attacks (palentonga roll/transformation/halo bonuses, and invisibility/umbra penalties), and don't make Confusing Touch affect aux attack accuracy or damage. -------------------------------------------------------------------------------- 4b82a7ed23 | Kate | 2022-01-05 01:41:15 +0000 Rework offhand punch checks Simplify the check for offhand punches and make them overall slightly more likely to trigger - don't make heavy armour reduce the chance of punching, and get rid of Octopodes' improved chance for offhand punches (they still the benefit of being able to punch with a shield/two-handed weapon). All species instead have a 5% chance to trigger an offhand punch that scales with unarmed combat skill to a 50% chance at max skill (compared to a a 33% chance previously at 20 UC or higher). -------------------------------------------------------------------------------- 3a1cdb9d31 | Kate | 2022-01-05 01:41:15 +0000 Base aux attack chance on XL instead of str+dex Aux attacks had a fairly obscure chance to trigger based on str+dex, followed by various other specific checks depending on the type of attack. Simplify by making the initial check depend only on XL, scaling from just over 50% at XL1, up to near 100% at XL27. -------------------------------------------------------------------------------- 7b68f1b707 | Kate | 2022-01-05 01:41:15 +0000 Rework shield penalties To remove the hard skill thresholds for shield skill training, rework shields to use a similar formula to armour encumbrance, with the penalties being fully removed at 27 skill. The new formula is: 2/5 * shield_penalty^2 / (20 - 3 * racial_factor) * (27 - shield_skill) / 27 where shield_penalty is 5 for bucklers, 9 for kite shields, and 13 for tower shields, and racial_factor is -2 for large species and formicids, 0 for medium species, 2 for kobolds, and 4 for spriggans. -------------------------------------------------------------------------------- d379f8d934 | Nicholas Feinberg | 2022-01-04 17:26:20 -0800 Remove an unused attack field -------------------------------------------------------------------------------- 2cf8304be8 | Kate | 2022-01-05 00:53:55 +0000 Fix halo descriptions on '@' Broken since 44cf67ff301, oops. -------------------------------------------------------------------------------- dcb3f3653b | Kate | 2022-01-04 17:59:36 +0000 Update the quickstart guide It's an ancient relic either way, but still! -------------------------------------------------------------------------------- 4f6bc678fa | Nicholas Feinberg | 2022-01-03 14:44:42 -0800 Remove to-hit penalties from armour & shields These were so small as to be unnoticeable in almost all plausible cases. There are already many interesting tradeoffs from wearing heavy armour & shields; we don't need to complicate things further. -------------------------------------------------------------------------------- c92c38d8fe | Nicholas Feinberg | 2022-01-03 14:02:34 -0800 Fix to-hit display of armour/shield penalties What a ridiculous bug! This has been broken for the last 1.5 years, since I added it in 5b8897f42da . Simply too many randoms... -------------------------------------------------------------------------------- bd29554cb1 | hellmonk | 2022-01-03 16:34:23 -0500 reduce meliai frequency in spider -------------------------------------------------------------------------------- b5fd6dc846 | Nicholas Feinberg | 2022-01-03 11:05:40 -0800 Don't allow omnireflecting vampiric draining (Grit) Your +3 warlock's mirror {reflect} reflects the Vampiric Draining! INVALID YOU_FAULTLESS draws life force from the deep elf death mage! Would be nice to fix this instead, though I'm not sure what the correct behaviour would be. Would need to poke at _vampiric_draining_effect for a bit. -------------------------------------------------------------------------------- cbb8a028cc | Nicholas Feinberg | 2022-01-03 11:00:05 -0800 Allow scorch recasts to refresh duration (Snakku) -------------------------------------------------------------------------------- fede4e8891 | Nicholas Feinberg | 2022-01-03 10:53:02 -0800 Remove old shaft immunity Obsoleted by the removal of multiple explore traps per branch (in 2ccdadd). -------------------------------------------------------------------------------- c726bef33b | Kate | 2022-01-02 19:24:15 +0000 Simplify Gozag gold distraction (hellmonk) Instead of using bernoulli trials and reducing the chance to gain stacks depending on the number of current stacks, make gold distraction a simple 3% chance per stack to distract, capped at 10 stacks, and with all valid kills increasing the stack count. -------------------------------------------------------------------------------- 3b246a18e6 | Kate | 2022-01-02 18:46:36 +0000 Reduce Ashenzari's skill boost (again) It was still very overtuned after the previous reductions (and is probably still pretty generous even after this change) - 4 boosts are now equivalent to the old fully bound boost. -------------------------------------------------------------------------------- 3a22ab9bdc | Nicholas Feinberg | 2022-01-01 14:31:22 -0800 Restore 0.26 acquirement frequency (perryprog) Looks like it got drastically boosted at some point. Not clear how. -------------------------------------------------------------------------------- 95c3d9ec3d | Kate | 2022-01-01 22:12:49 +0000 Let autofight target frenzied monsters (nicolae) -------------------------------------------------------------------------------- cb2c1687f3 | Nicholas Feinberg | 2022-01-01 13:57:53 -0800 Add some lovely puppies (Sastreii) New tiles for Pharaoh Ants, Jorogumos, and Broodmothers. -------------------------------------------------------------------------------- b830f16b3f | advil | 2022-01-01 14:24:28 -0500 feat: improve mouse handling for message pane input * Don't lose focus when clicking on random stuff. Before you could click on e.g. the dungeon and nothing would happen, except that the input would lose focus. * With tile_web_mouse_control, right click exits a prompt by sending esc. (This could also accept left click, maybe outside of the message pane, but in my testing this seemed too prone to misclicks.) * Smooth over trading focus with the chat pane -------------------------------------------------------------------------------- 7516f22de0 | advil | 2022-01-01 14:24:28 -0500 fix: add a missing Error instance in webtiles -------------------------------------------------------------------------------- 92835e5c71 | Kate | 2021-12-31 21:11:24 +0000 Add some newlines in ammo descriptions -------------------------------------------------------------------------------- 5f6e48996a | Kate | 2021-12-31 21:10:36 +0000 Make blindness, frenzy, antimagic and daze dispellable Partially going back on a previous commit (8836bdb7) - frenzy was made undispellable since various other dart effects were also undispellable, but this approach doesn't really work consistently, since most monster enchantments can be applied by multiple different sources (eg frenzy can be applied by Discord as well as orbs of mayhem and darts of datura) and it's unclear why effects like this wouldn't be considered dispellable. -------------------------------------------------------------------------------- dd239049a3 | Kate | 2021-12-31 20:21:56 +0000 Allow attacking frenzied monsters normally Unlike regular neutral monsters, they don't turn hostile when attacked, so there's no reason to have any restrictions on attacking them. -------------------------------------------------------------------------------- bf4c3871c4 | advil | 2021-12-31 14:29:09 -0500 fix: don't ignore game menu exit button Yet another fix of a fix -------------------------------------------------------------------------------- 9884ec658a | advil | 2021-12-31 14:24:25 -0500 refactor: consolidate help lookup to one UI This commit entirely removes the message pane UI for help lookup, replacing it with the menu-based version added in 4c3c5a04a9. Along the way I did a bunch of tweaking and testing of this menu; main secondary changes: * submenus have arrow key navigation enabled * exit menu is the last item, not the first * some error popups clarified and improved, fully works on webtiles * the key to open this popup from the game menu is now `/`, for consistency with `?/`. * use the search icon introduced in 4c3c5a04a9 across the board instead of the circled i icon. Some of these could be adjusted further if desired. -------------------------------------------------------------------------------- 39bde7bcfb | advil | 2021-12-31 12:23:09 -0500 fix: further fix game menu fallthrough behavior Generalize a75cb3825e and fix the save command. In local games, this was crashing at the main menu when used, with a segfault in UI code. (Possibly indicates a bug there? But it's safest just to exit the popup anyways.) -------------------------------------------------------------------------------- b870ddcdaf | advil | 2021-12-31 12:23:09 -0500 fix: use correct save and X wording in game menu That is, don't mention the "main menu" if the game is in a state where one won't be used. -------------------------------------------------------------------------------- 9cff2364a1 | gammafunk | 2021-12-31 01:47:45 -0600 feat: Nerf ghost moth melee a bit These currently hit for up to 76 damage. Compare to emperor scorpions, a top-tier melee-only threat, that do up to max 60 damage with the same monster speed of 12. The increased ghost moth damage was to allow af_drain_stat to apply more often, but it had the side effect of turning them into the HULK (which is hard to program). Nerf their (28, 28, 20) melee attacks down to (24, 18, 18) for now. Some play-testing shows them still able to drain stats in honorable single combat versus a shield-equipped HuFi possessing sInv. The stat drain I got while testing was fairly minor; typically a few points in a couple stats after one fight. If we'd like the drain to become more relevant, it may be best to increase the amount of stat drain applied per successful hit, since it's clear that the stat drain will still get applied with these nerfed numbers even against characters with strong defenses. -------------------------------------------------------------------------------- a75cb3825e | advil | 2021-12-30 22:04:12 -0500 fix: correct a fallthrough issue with e3a463e -------------------------------------------------------------------------------- 7577a969be | advil | 2021-12-30 21:57:59 -0500 fix: a few issues with the help lookup menu * Don't show an extra popup when escaping out of the text entry sub-popups. (Super ugly code, this stuff could use a refactor to not rely on `response` for a non-error condition.) * Do actually show the above popups in webtiles (before it didn't do anything but still needed the key input). This popup is a bit rare now it seems but can at least be triggered on a string consisting of spaces. * Remove some (I think) unnecessary UI_CRT things. -------------------------------------------------------------------------------- e3a463ef05 | advil | 2021-12-30 21:57:59 -0500 fix: submenu behavior for most main menu commands It was probably a strategic error to not do this initially, but I think having a submenu open is more what people would expect from a main menu command. I didn't do this for CMD_QUIT because it uses a message pane prompt. The lookup menu already did this. -------------------------------------------------------------------------------- 76a60e06d6 | Nicholas Feinberg | 2021-12-30 17:25:01 -0800 New placeholder Jorogumo tile -------------------------------------------------------------------------------- 69a50951d7 | Nicholas Feinberg | 2021-12-30 16:33:36 -0800 Fix tag_upgrade build -------------------------------------------------------------------------------- 0aadbb367f | Nicholas Feinberg | 2021-12-30 16:23:34 -0800 Improve frenzy UX - Allow targeting frenzied monsters with damage spells, etc normally. - Don't make good gods punish you for attacking frenzied monsters. -------------------------------------------------------------------------------- 33a2d3f881 | Nicholas Feinberg | 2021-12-30 16:06:16 -0800 Remove one last ray of sunshine TARG_HOSTILE_SUBMERGED, unused since 1d64b78cf4984becb95c8. -------------------------------------------------------------------------------- b64ed734f3 | Nicholas Feinberg | 2021-12-30 15:59:07 -0800 Correct a frenzy comment ENCH_FRENZY does not exist. -------------------------------------------------------------------------------- d371e1541e | Nicholas Feinberg | 2021-12-30 15:57:23 -0800 Merge strict neutral with good neutral (kate) They were almost identical. The only difference is that jellies will now show up with a brown background instead of grey & will be described as 'fellow slime' instead of 'indifferent', which seems fine! (Could have made them grey instead of brown, but it'd be misleading.) -------------------------------------------------------------------------------- 7e0445c96d | Nicholas Feinberg | 2021-12-30 10:38:27 -0800 Bring back Xom's dragons (kate) This partially reverts commit a0dfb7b2014fc097504f6b115edb92e612a79952. -------------------------------------------------------------------------------- a0dfb7b201 | Nicholas Feinberg | 2021-12-30 10:34:39 -0800 Remove non-player-castable Xom spells (pi-314) -------------------------------------------------------------------------------- e07096e7bc | Nicholas Feinberg | 2021-12-30 10:25:58 -0800 Fix channeled exegesis from ignorance (Nomi) Don't end channeled spells immediately when you exegesis them with no spells memorized. -------------------------------------------------------------------------------- 6040ee8864 | Nicholas Feinberg | 2021-12-30 10:10:57 -0800 Remove the orb Added accidentally. -------------------------------------------------------------------------------- b2e798e311 | Nicholas Feinberg | 2021-12-30 09:52:38 -0800 Improve orb of light description (🐙Mike) -------------------------------------------------------------------------------- 0273388e84 | Nicholas Feinberg | 2021-12-30 09:05:12 -0800 Add player orb tiles Feel the orb within your hand... feel its cold, smooth surface. The deadly temptation of its power. Who could stand against you if you bore such a device? Who could withstand the sorcery boiling within, seeking only a crack to escape and wreak boundless havoc? You would be a king. No... more. A god. -------------------------------------------------------------------------------- 7b639605f7 | Nicholas Feinberg | 2021-12-30 08:36:54 -0800 Fix Hep powers webtiles display (🐙Mike) -------------------------------------------------------------------------------- e1d817e1ef | Nicholas Feinberg | 2021-12-30 08:23:04 -0800 Fix allied radroach crash Instead of consistently crashing when an allied radroach decides whether or not it should cast irradiate, don't crash instead. Also, switch to using a tracer for irradiate cast logic instead of weirdly hand-replicating the same logic. -------------------------------------------------------------------------------- 2ac24fcec8 | Nicholas Feinberg | 2021-12-30 07:30:37 -0800 Remove un-ID'd angel weapon code I warned it'd never come up, and now it definitely won't! -------------------------------------------------------------------------------- 2ad6d04315 | Neil Moore | 2021-12-29 23:12:07 -0500 Handle correct name of Japanese language. Ever since the very first commit that introduced Japanese support (viz. 05c31b08e25), the lang option has accepted the ethnonym but not the name of the language . Leave as an alternative for compatibility. -------------------------------------------------------------------------------- cf31067fe6 | Kate | 2021-12-30 02:54:40 +0000 Mark some orbs as useless when appropriate -------------------------------------------------------------------------------- 62fc55f08d | Kate | 2021-12-30 02:29:00 +0000 Fix Summon Spider messaging (nicolae) -------------------------------------------------------------------------------- c3160e8207 | Nicholas Feinberg | 2021-12-29 16:45:36 -0800 Tweak channel status descriptions Semicolons are a dangerous vice, not to be overindulged. Also, it's *waves* of flame, not *a wave* :P -------------------------------------------------------------------------------- 1c5e12ca7f | Kate | 2021-12-30 00:01:36 +0000 Fix some descriptions (Ge0ff) -------------------------------------------------------------------------------- a5cd5cae6f | Kate | 2021-12-29 23:31:18 +0000 Rename Heavenly Storm's status light (PleasingFungus) To no longer overlap with Storm Form. -------------------------------------------------------------------------------- cbcab8c68d | Kate | 2021-12-29 22:55:36 +0000 Don't gender some non-unique enemies Water nymphs, harpies and jorogumos were always gendered female which was inconsistent with all other non-unique enemies. Closes #2317. -------------------------------------------------------------------------------- 9cd67a661c | Kate | 2021-12-29 22:55:36 +0000 Update some status light descriptions And the related spell descriptions for some forms. Currently Heavenly Storm and Storm Form overlap, and one of them needs their status light to be renamed. Closes #2321. -------------------------------------------------------------------------------- 050f3537b9 | advil | 2021-12-29 17:37:17 -0500 fix: restore rest behavior when > rest_wait_percent The => was accidentally introduced in 0bdd5ba03093. Resolves #2304 -------------------------------------------------------------------------------- 113dc556a4 | Kate | 2021-12-29 01:50:18 +0000 Remove unequip penalties from the robe of Misfortune It's no longer intended to be a strictly-bad unrand, with its design being that it grants substantial AC/EV but with the significant downsides of *Slow and *Corrode when damage is received, as well as having Harm. To encourage at least trying it on, remove the Contam and Drain on unequip - as body armour, it can't be quickly swapped so doesn't need an additional unequip penalty alongside the Harm. -------------------------------------------------------------------------------- c8854da52d | Kate | 2021-12-29 01:44:13 +0000 Simplify an orb check -------------------------------------------------------------------------------- fc495fb4ec | Nicholas Feinberg | 2021-12-28 17:26:06 -0800 Don't talk about orb AC (ShaperMC) Squash a pointless message in orb descriptions. -------------------------------------------------------------------------------- 6b9ff3a05d | Nicholas Feinberg | 2021-12-28 11:06:26 -0800 Refactor Irradiate, pt 1 (sdynet) Don't prompt when a monster would irradiate one of your allies, do pass the caster by reference rather than as a pointer, and various other fixes. -------------------------------------------------------------------------------- 18cc7973ba | Kate | 2021-12-28 18:11:32 +0000 Improve Makhleb destruction ability descriptions -------------------------------------------------------------------------------- 3d317c14f4 | Kate | 2021-12-28 18:11:32 +0000 Make Chei consider orbs of mayhem hasty -------------------------------------------------------------------------------- ba9079b354 | Edgar A. Bering IV | 2021-12-28 12:08:03 -0600 docs: changelog through 0.28-a0-1340-g77f64c2 -------------------------------------------------------------------------------- 77f64c2f64 | Edgar A. Bering IV | 2021-12-28 08:51:10 -0600 fix: prevent wearing an orb while wielding a 2-hander The reverse check already worked but this one was missed. Closes #2316 -------------------------------------------------------------------------------- a5422284a4 | Nicholas Feinberg | 2021-12-27 20:28:46 -0800 Fix orbs + SH (Lightli) Don't make orbs set your SH to 0 when you have other sources. -------------------------------------------------------------------------------- ce4b496cc8 | Nicholas Feinberg | 2021-12-27 18:44:10 -0800 Revert "Let good gods cause some mayhem (booper)" Neutral is a mess :( This reverts commit 83453ab7136c4dc63250dae6215468288a3404e4. This reverts commit 9a4740a79772870bd10ec86309d9a473f55b9590. -------------------------------------------------------------------------------- 83453ab713 | Nicholas Feinberg | 2021-12-27 18:38:02 -0800 Make neutrals considered less friendly In a few places. Maybe this is an improvement? Unsure. -------------------------------------------------------------------------------- 9a4740a797 | Nicholas Feinberg | 2021-12-27 18:37:40 -0800 Let good gods cause some mayhem (booper) Good gods don't like you attacking peaceful creatures, like ely's friendly neutral or kirke's humans' strict neutral (?), but it should be fine to attack frenzied 'true neutrals'? Maybe? This is too many neutrals... -------------------------------------------------------------------------------- ebfa916d04 | Nicholas Feinberg | 2021-12-27 18:22:21 -0800 Clarify mayhem (booper) -------------------------------------------------------------------------------- 1c9ffb4daf | Nicholas Feinberg | 2021-12-27 13:57:16 -0800 Fix a duration crash (skeral) Introduced by 95685b5d4a526e94ea562b9df2ea7fce36eb05bc . -------------------------------------------------------------------------------- 95685b5d4a | Nicholas Feinberg | 2021-12-27 12:52:58 -0800 Rename mid_msg -> expire_msg, etc (Pinkbeast) 5c2cb368445 (2015) continued the misleading naming used by _decrement_a_duration() in which effects for the 'expiration point' (an arbitrary # of turns before the end of a duration at which the player is warned that it's nearly done) were claimed to occur at the 'midpoint' (50% of the way through the duration.) Fix this. -------------------------------------------------------------------------------- 9cdbbaba87 | Nicholas Feinberg | 2021-12-27 12:44:16 -0800 Remove centaurs (Lici) Centaurs weren't meaningful threats in Shoals. They are a nice match for the vaguely Greek mythological theme, though, so swap in some centaur warriors instead. -------------------------------------------------------------------------------- a7867985be | Kate | 2021-12-27 20:16:58 +0000 Adjust some monster genuses -------------------------------------------------------------------------------- 586501026f | Kate | 2021-12-27 20:16:58 +0000 Remove some speech lines and a randbook name As with recent changes to Yred's theming, remove a few somewhat tasteless lines. -------------------------------------------------------------------------------- e4a90f2674 | Kate | 2021-12-27 20:16:58 +0000 Remove some obsolete book titles -------------------------------------------------------------------------------- 8ca4fe5f7a | Kate | 2021-12-27 20:16:58 +0000 Display drowning resistance in monster descriptions -------------------------------------------------------------------------------- 9e5b8c6e9f | Kate | 2021-12-27 20:16:58 +0000 Remove water vulnerability Only an extremely small number of monsters were vulnerable to water, it did very little (affecting only direct BEAM_WATER damage, but not granting any additional vulnerability to waterlogging or engulfing), and the player has minimal access to sources of water damage. -------------------------------------------------------------------------------- 8dc402e326 | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 REVERTME: increase orb rate for testing -------------------------------------------------------------------------------- 961f3f1587 | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 fix: remove a placeholder -------------------------------------------------------------------------------- 17eb628754 | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 feat: orbs of energy (bringing back the crystal ball) This commit adds a new "energy" orb ego that offers passive channeling, like Wucad Mu. The implementation is set to stack with Wucad Mu and any other potential source of energy (currently none) in the following ways: - The trigger chance is multiplied by the number of sources. - The all sources must backfire for the backfire effect to trigger. Wucad Mu's channeling was interesting, but compared to an enhancer staff or other unrands the effect underwhelemed many players. In addition to offering channeling with a shield, this commit buffs Wucad Mu by making it count as two sources of channeling for internal calculations. XXX: Unsure of the best way to communicate this to the player without turning our inscriptions into a line of dubious code, inscribing it *channel++ just doesn't sit right. -------------------------------------------------------------------------------- 92c09265f1 | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 feat: orbs of guile The guile ego is a will-check analog of harm: it reduces the willpower of any user's target by 3 * WL_PIP, in exchange for reducing the willpower of the user by 2 * WL_PIP. This is more interesting than a straight hex enhancer: the tradeoff is stiffer and it works with all willpower checks, not just hexes. -------------------------------------------------------------------------------- ecb9636ef5 | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 feat: orbs of mayhem (nicolae) The mayhem ego for orbs causes monsters who see the wielder kill something to go frenzy. It only hits one monster per kill with a coinflip for now. This could be adjusted up or down based on power, but we definitely don't want to give out free Discord casts for a single kill. -------------------------------------------------------------------------------- acce00ee20 | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 feat: orbs of wrath A *Rage orb, because *Rage is powerful, fun, and dangerous. This one is in the mix because why should spellcasters get all the orb fun. -------------------------------------------------------------------------------- 973e1c81fd | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 feat: orbs of light The first of several orb egos, an orb of light gives the player a radius 3 halo. Halo prevents invisibility and backlights the player (an extra defensive penalty) in exchange for revealing invisible creatures and an accuracy bonus. Alone the accuracy bonus isn't that big, but an ally user can get quite a bit of a boon from halo. This is probably the weakest of the orb egos, but that's ok. In general orb egos will represent some kind of a tradeoff, as they're egos that one can use in place of a shield without training. -------------------------------------------------------------------------------- e3aa5898da | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 feat: chill lofi orbs to ponder/crawl with A shield-slot analog of scarves, meant to play with the same sort of defense/interesting ego trade-off. Orbs give no SH and no penalty. "Caster" and some "battlemage" archetype characters are almost always steered to shields through a confluence of factors: - cheap one-handers (demon weapons and shortblades) that can be amplified with magic - one-handed enhancer staves leaving the other hand flapping around empty and begging for a shield - shield penalties are easier for low-strength characters to overcome Forthcoming commits will introduce orb egos (currently ponderous is a placeholder but will not be on the final list) aimed at expanding the options for these characters. Another direction to pursue in this design space is to create some 2-handers that tempt such characters, this is not an exclusive direction so both could happen, but for now orbs are what we've got. -------------------------------------------------------------------------------- 050272b745 | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 refactor: adjust some reflection checks Make actor.reflection() do what it says on the tin, and use the shield_reflects(item) method only for messaging, not for determining which actors are reflective. -------------------------------------------------------------------------------- 9e8018ba61 | Edgar A. Bering IV | 2021-12-27 14:13:17 -0600 fix: remove the limit on weapon and armour egos These were limited for seen item tracking to (subtly) influence acquire. Unlike seen basetypes, seen ego tracking makes a lot less sense, since seeing an ego on an unwanted base type tells us nothing about the player's preferences. This seemed cleaner than the save-compatibility needed to expand the bitfields because they're saved. -------------------------------------------------------------------------------- e154d51992 | Nicholas Feinberg | 2021-12-27 11:22:27 -0800 Revert "fix: remove a now unused MB check" This broke the bound soul icon. This reverts commit 53f92202ff9e202943409b577e6ad06e644bce8b. -------------------------------------------------------------------------------- f86f92d26c | advil | 2021-12-27 13:58:43 -0500 fix: bounds checks for monster lrd and ghostly sacrifice This removes the hardcoded checks from 73776a4c32c7 and 4f857bc58ec3. The reason for these crashes and for their variability was that the fake monster used for the validity check is at position 0,0. So if the game was saved on a level where a monster was in the upper left corner, the iterators used in these two spells would fire a tracer at the monster during game setup. The presence of a salt entrance in the save in #2308 was a red herring, it's just that this level had some monsters in the right place. It's probably still not ideal that the level even exists at the point where this validity check happens? Re-resolves #2308, should resolve #2281 (though I couldn't get an abyss crash to happen on demand). I also added a bit more info to the ASSERT that may make this easier to track down in the future. -------------------------------------------------------------------------------- 73776a4c32 | advil | 2021-12-27 13:19:26 -0500 fix: don't fire tracers for ghostly sac validity check This is a followup to 4f857bc58ec3, it seems that this ASSERT triggers only if a monster with the relevant spell is on the level where a player saved. (???) Resolves #2308 -------------------------------------------------------------------------------- bc27143018 | Nicholas Feinberg | 2021-12-27 07:16:34 -0800 Revert "Move the Mace of Variability to the early game" Various people have pointed out that, while the mace of variability used to be weak enough to be an early game item, it's now a compelling one for the later game. Mea culpa! This reverts commit fdf38ca10bdff2f4954046791e0ea06d90ea673a. -------------------------------------------------------------------------------- 71652a0310 | Nicholas Feinberg | 2021-12-26 19:49:55 -0800 Add a guarded Meek vault -------------------------------------------------------------------------------- 0e9cb7027e | Nicholas Feinberg | 2021-12-26 19:49:55 -0800 New early-game unrand: staff of the Meek Another early-game unrand, the staff of the Meek is a +7 quarterstaff of super-protection. When the player is below 55 HP, the staff of the Meek gives extra AC, scaling up to an additional +7 AC (for a total of +14) at 27 HP or below. I suspect it might be slightly overtuned. -------------------------------------------------------------------------------- be34dac4b3 | Nicholas Feinberg | 2021-12-26 19:49:55 -0800 Rename Danyla -> Delatra To avoid name conflicts with Slavic regions. -------------------------------------------------------------------------------- dce6b4fef7 | Nicholas Feinberg | 2021-12-26 19:49:55 -0800 Move the Robe of Augmentation to early-game (Lici) It's just not that strong. -------------------------------------------------------------------------------- 17cdd1422e | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 New early-game unrand: Throatcutter Throatcutter is a +7 long sword of draining with a 33% chance to instakill struck foes that are below 21 hp. Monster HP tends to increase over the course of the game, so this is of course most relevant early on. It's a bit like extra AC-ignoring damage, but it only works when enemies are at low HP to begin with. Terence gets a Maggie-esque 1% chance to spawn with this. -------------------------------------------------------------------------------- a2d17535fb | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Move the Trident of the Octopus King early It's too weak to be good later, unless its gimmick goes off, which it won't. (FR: new/tweaked gimmick!) Also remove its Will+ as superfluous. (rElec and rPois are both vaguely thematic.) -------------------------------------------------------------------------------- fdf38ca10b | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Move the Mace of Variability to the early game It's often a trap to use the mace of variability later on, and there are plenty of fun later-game unrands for m&f users to use. Let's switch this back to a simple mace (from a great mace), buff its ench (mimicking klown clubs), and put it in the early-game weapon set. -------------------------------------------------------------------------------- f4a11d3a62 | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Move Lear's to the early-game Lear's tradeoff - blocking aux slots in exchange for a big flat AC bonus - makes more sense in the early game, when players have access to few items to fill those aux slots. Later on, it just means players get to play around less with the loot game, which isn't that exciting. Its focus on enchantment over base AC is also stronger early, when players have little Armour skill. So, move Lear's into the early-game unrand category (making it more likely to spawn early & less likely later), and cut its enchantment from +27 to +18. -------------------------------------------------------------------------------- 2cb09928ac | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Shift more unrands to be early-game Morg, Devastator, the Ratskin Cloak, and Kryia's mail. - Kryia's mail potion healing buff is more relevant earlyish, when potion healing is more relevant and competing armour options are worse. - Ratskin cloak's summons don't scale; makes sense for it to show up earlier. - Devastator as a mini-shatter is a fun earlier-game effect. - Morg is just too weak for later. At some point I do want it to have a better gimmick, though - perhaps some way to trigger a 'sublimation of blood'-type HP for MP trade? Or, perhaps, a twist on pain brand that's works better in the early game. -------------------------------------------------------------------------------- dd19a0eca0 | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Fix danyla ftiles (nicolae) -------------------------------------------------------------------------------- 4d69e0ec34 | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Refactor early-game unrand weights -------------------------------------------------------------------------------- 2b8dd8ea68 | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Force woodcutter's axe to speed 10 (hellmonk) Regardless of being slowed, shield delay, etc, etc. -------------------------------------------------------------------------------- 07e9fc738c | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Add a fireplace -------------------------------------------------------------------------------- 88828878fe | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Add a guarded unrand woodcutter's axe vault -------------------------------------------------------------------------------- fcf6033174 | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 New unrand: woodcutter's axe Another early-game unrand, the woodcutter's axe swings at a fixed 10 aut, regardless of skill. As a +8 vorpal war axe that can never hit a normal war axe's mindelay, it should become obsolete by midgame, but quite powerful earlier. -------------------------------------------------------------------------------- a9f048274c | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Add a guarded unrand vault for Danyla's -------------------------------------------------------------------------------- 7890d4bb03 | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Make Danyla's less likely later Since Danyla's are intended to be interesting in the early game, give them a 10x weight at early depths (D:6 and earlier, I think) and 0.1x weight at later depths. -------------------------------------------------------------------------------- f9a06f655c | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 New unrand: Danyla's gloves Continuing the 0.28 trend of new unrands, Danyla's gloves play in the space of 'unrands for the early game'. The wearer is healed by drinking unknown potions, and their MP is restored by reading unknown scrolls. Is it wise to intentionally keep consumables unknown so that you can use them as ersatz !hw and !magic? Maybe?? I considered also giving some bonus for reading ?id or some alternate way to use up ?id with these gloves, but that seemed to go against the design premise. Also, to be a bit too complicated. More related changes to come in subsequent commits. -------------------------------------------------------------------------------- 1f8817ceea | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Allow artefacts to spawn on D:2-3 To increase variety, and to allow early-game unrands to work, lift the ban on artefact generation in D:2-3. To discourage startscumming, D:1 artefacts are still banned. -------------------------------------------------------------------------------- 54527cc1f4 | Nicholas Feinberg | 2021-12-26 19:49:52 -0800 Explain no_upgrade -------------------------------------------------------------------------------- b4563b27b3 | Nicholas Feinberg | 2021-12-26 14:51:13 -0800 Remove zombie deep dwarf damage shaving Monster deep dwarf zombies had damage shaving, probably left over from when actual deep dwarf enemies existed. Let's clean that up. -------------------------------------------------------------------------------- 91df5548d3 | Nicholas Feinberg | 2021-12-26 08:17:46 -0800 Pass item_level into make_item_unrand This is mostly intended for future changes. -------------------------------------------------------------------------------- 77e77742e6 | Nicholas Feinberg | 2021-12-26 08:14:29 -0800 Fix unrands being able to reappear in the Abyss This was broken in 850bfe61e39, a year and a half ago. Probably no one noticed because it's almost impossible to encounter this case to begin with. -------------------------------------------------------------------------------- 8a08cb6da8 | Nicholas Feinberg | 2021-12-26 08:13:51 -0800 Minor artefact refactoring -------------------------------------------------------------------------------- 700d31dd17 | Kate | 2021-12-26 15:35:15 +0000 Add some new wizards as potential spellbook owners -------------------------------------------------------------------------------- 73c4ac0421 | Kate | 2021-12-26 15:35:15 +0000 Give Portal Projectile a static targeter -------------------------------------------------------------------------------- 6bde065e89 | hellmonk | 2021-12-25 21:40:59 -0500 minor revisions to vampire castle -------------------------------------------------------------------------------- 01e59b5888 | hellmonk | 2021-12-25 21:40:59 -0500 delete boomers Reduce the number of boomerangs generated in bailey maps and entries. -------------------------------------------------------------------------------- 507d92f863 | hellmonk | 2021-12-25 21:40:59 -0500 various bailey fixes -------------------------------------------------------------------------------- 69d4bd79ad | hellmonk | 2021-12-25 21:40:59 -0500 remove bailey_polearm_4 This map was very small and also very bad. -------------------------------------------------------------------------------- 65a5005c76 | hellmonk | 2021-12-25 21:40:59 -0500 adjust bailey_polearm_2 Make the outer area less annoying and shrink the border. Slightly randomize monster counts and placements. Adjust loot. Also, fix bailey_polearm_1. -------------------------------------------------------------------------------- 514828de85 | hellmonk | 2021-12-25 21:40:59 -0500 Adjust bailey_polearm_1 Make the moat shallow. Give routes for monsters in the center to escape the lava (makes the vault less annoying and less cheeseable). Adjust the good item selection slightly. -------------------------------------------------------------------------------- c62d020828 | hellmonk | 2021-12-25 21:40:59 -0500 enchanted keep bailey Spriggans and ogres, plus one small dragon. -------------------------------------------------------------------------------- b6a7f6400c | hellmonk | 2021-12-25 21:40:59 -0500 checkwhite -------------------------------------------------------------------------------- 1f28f93398 | hellmonk | 2021-12-25 21:40:59 -0500 Prince Ribbit bailey Feat: frogs, vault guards. -------------------------------------------------------------------------------- eca784f0a1 | hellmonk | 2021-12-25 21:40:59 -0500 checkwhite -------------------------------------------------------------------------------- 1e23faca81 | hellmonk | 2021-12-25 21:40:59 -0500 remove bailey_axe_1 This was the other kobold boomerang behind water map, and it was very bad. -------------------------------------------------------------------------------- bafb9c2f4c | hellmonk | 2021-12-25 21:40:59 -0500 Rework bailey_axe_3 This was formerly one of two 'boomerang kobolds behind deep water' baileys. Now it is a kobold brigand bailey; they replace a few of the regular kobolds (which are no longer behind deep water) and the other weak enemies. Loot has been updated to include a few stacks of specialty darts. -------------------------------------------------------------------------------- fb8d33413f | hellmonk | 2021-12-25 21:40:59 -0500 vampire castle bailey Features 1-3 vampires with big polearms, a gargoyle, and some orcs. -------------------------------------------------------------------------------- c7d099ddaa | hellmonk | 2021-12-25 21:40:59 -0500 checkwhite -------------------------------------------------------------------------------- d8f7bb276c | hellmonk | 2021-12-25 21:40:59 -0500 restructure bailey_axe_of_yendor_kennysheep Rearrange the layout so that the hard monsters appear later in the map. Also, randomize monster counts. -------------------------------------------------------------------------------- a913e2b07b | hellmonk | 2021-12-25 21:40:59 -0500 adjust bailey_axe_bossmonster_kennysheep Randomize monster counts. Remove deep water to prevent kobold annoyance and trivial drowning strats. Reduce loot slightly (early portal maps should generally not place multiple stacks of !exp, I do not care how hard killing the warlord is). -------------------------------------------------------------------------------- 39464d8d1f | hellmonk | 2021-12-25 21:40:59 -0500 adjust bailey_polearm_5 Reduce and randomize monster counts. Add terrain. Tag the summoning scrolls no_pickup. Reduce loot slightly. -------------------------------------------------------------------------------- 673e66e2bb | hellmonk | 2021-12-25 21:40:59 -0500 new elf bailey Places a single pyromancer or zephyrmancer, who is held hostage by the typical bailey polearm orcs. Armour, potion, and gold loot. -------------------------------------------------------------------------------- 0c74f66fb6 | hellmonk | 2021-12-25 21:40:59 -0500 adjust bailey_polearm_gnolls_kennysheep Randomize monster count slightly. Add wolves and a chance for Grum. Buff loot. -------------------------------------------------------------------------------- c07eaa88f9 | hellmonk | 2021-12-25 21:40:59 -0500 adjust bailey_polearm_flooded_kennysheep Push the centaurs out of the entrance's line of sight. Adjust and randomize monster counts. Slightly adjust loot. -------------------------------------------------------------------------------- a63312ec20 | hellmonk | 2021-12-25 21:40:59 -0500 adjust bailey_axe_minmay_hex_keep Place less popcorn. Space out and randomize "hard" monster locations. Reduce loot from 2 exp/acq to 1. Still places a warlord. -------------------------------------------------------------------------------- 3b12c07c51 | hellmonk | 2021-12-25 21:40:59 -0500 adjust bailey_axe_4 Give the player a path across the moat without flight. Move the flight items into the vault proper. Randomize monster placement. -------------------------------------------------------------------------------- bd0c3d1049 | hellmonk | 2021-12-25 21:40:59 -0500 adjust bailey_axe_2 Add draining to formerly mundane halberds, let orc warrior get in on the elec action, and nerf the loot (this map is too easy to place guaranteed acq/exp). -------------------------------------------------------------------------------- 46454fb2af | hellmonk | 2021-12-25 21:40:59 -0500 Cut bailey spawn depth Bailey portals spawned between D:7-14 and in Orc:1. While at first glance this looks like a small portion of the game, players get massively stronger over those floors. D:7 characters might still be working on their starting kit, whereas a character on D:14 or in Orc is likely well established and has probably cleared Lair. The monsters in many existing Bailey vaults are similar to Orc spawns as well, so they tend to be threatening in the early part of the Bailey spawn range but mundane in the later part. Thus, Bailey will now spawn between D:7-10 and the chance per floor is doubled to keep the overall likelihood of seeing a bailey roughly the same. -------------------------------------------------------------------------------- fc91cddb57 | Kate | 2021-12-26 02:30:05 +0000 Simplify a zap -------------------------------------------------------------------------------- ff14099be7 | Kate | 2021-12-26 02:30:00 +0000 Store spellpower on cast for ongoing spells Make Borgnjor's Vile Clutch, Searing Ray, Olgreb's Toxic Radiance, Flame Wave, Searing Ray, Frozen Ramparts, and Dragon's Call all check spellpower only once on cast, instead of continuously throughout the duration. Also includes some minor cleanup for other spells that unnecessarily rechecked power. As noted in 9c71ebef145, this fixes their interactions with Sif's Divine Exegesis, and for Searing Ray and Flame Wave it has no other meaningful effect (since it's not possible to swap gear while channeling). For the other spells, it does become possible to cast them with an enhancer and switch to another item, but this is no different to the majority of other spells with an ongoing component (such as transmutations, hexes, and summons) where all that matters is the power at time of cast. -------------------------------------------------------------------------------- c629bbe4ae | Edgar A. Bering IV | 2021-12-25 17:14:01 -0600 fix: remove a diacritic Since we still officially support pure ascii interface, changing the monster name to "jorōgumo" in mon-data.h is a non-starter. To get the description to appear the diacritic must also be missing in the database. -------------------------------------------------------------------------------- 52c95e12a3 | hellmonk | 2021-12-25 16:49:40 -0600 refactor: rename a monster spellbook Since it's now in use by multiple enemies. -------------------------------------------------------------------------------- be32123071 | hellmonk | 2021-12-25 16:49:40 -0600 force Spider generation for testing -------------------------------------------------------------------------------- 4f13a64121 | hellmonk | 2021-12-25 16:49:40 -0600 feat: adjust and refactor monster web immunity Use a monster flag. -------------------------------------------------------------------------------- b4f9141d82 | hellmonk | 2021-12-25 16:49:35 -0600 feat: update spider bands -------------------------------------------------------------------------------- 4dffdd49c8 | hellmonk | 2021-12-25 16:49:01 -0600 feat: revise spider spawn table Incorporate the new spider monsters introducded in previous commits, enable ood usage. -------------------------------------------------------------------------------- db8c699bc0 | Edgar A. Bering IV | 2021-12-25 16:49:01 -0600 feat: adjust existing spider monster numbers -------------------------------------------------------------------------------- dabb86c9ba | hellmonk | 2021-12-25 16:49:01 -0600 feat: radroaches They cast irradiate. Currently contams the player a lot rather than mutating them outright; not totally opposed to changing it though. -------------------------------------------------------------------------------- f555730fcc | hellmonk | 2021-12-25 16:49:01 -0600 feat: adjust some spider layouts Allow another cavelike layout, change a few parameters in delve. -------------------------------------------------------------------------------- 8ac70cea53 | hellmonk | 2021-12-25 16:49:01 -0600 feat: sun moths Holy moths with a single tile halo, sticky flame, and energy bolt. -------------------------------------------------------------------------------- 43fd8d3cd6 | hellmonk | 2021-12-25 16:49:01 -0600 feat: adjust ghost moths Take away their poison sting and make them much better at draining stats. -------------------------------------------------------------------------------- 73a05ced62 | hellmonk | 2021-12-25 16:49:01 -0600 feat: adjust emperor scorpions Reduce their defenses and damage in exchange for speed 12. -------------------------------------------------------------------------------- b1d9b9a04c | hellmonk | 2021-12-25 16:49:01 -0600 feat: culicivora Low end spider for packs; heal other + vamp bite -------------------------------------------------------------------------------- cdf09cc80e | hellmonk | 2021-12-25 16:47:59 -0600 feat: broodmothers High end spider enemies that summon spiders and bite to summon spiders. -------------------------------------------------------------------------------- b91c745bbe | hellmonk | 2021-12-25 16:47:59 -0600 feat: Jorogumo High end spider nasties that cast ensnare and bolt of draining, plus melee for hornet poison. -------------------------------------------------------------------------------- 5bc7cbe778 | hellmonk | 2021-12-25 16:47:59 -0600 feat: steelbarb worms They inflict barbs status in melee, have regen and rF, and are fast. -------------------------------------------------------------------------------- de0d139c19 | hellmonk | 2021-12-25 16:47:59 -0600 feat: buff orb spiders Increase cast rate, hd, and melee damage -------------------------------------------------------------------------------- da204c4458 | hellmonk | 2021-12-25 16:47:59 -0600 feat: Pharaoh Ants A new undead spider monster that hits moderately hard for AF_DRAIN and binds the souls of all nearby monsters on death. -------------------------------------------------------------------------------- 2a955c5cc2 | hellmonk | 2021-12-25 15:22:40 -0600 feat: rework demonic crawlers Give them warning cry so they can alert their spider friends. -------------------------------------------------------------------------------- f280a0fbb2 | Kate | 2021-12-25 17:16:50 +0000 Make Formicid digging drain max health The ability to dig outside of combat with no limit or meaningful cost has been known to be a problem ever since Dig existed as a spell, and it encourages a variety of undesirable behaviours. Formicids have been a problem in this regard for a while (and even when the ability had a food cost, this didn't appropriately limit its use). To make digging have a noticeable cost, make it drain the user for each tile dug, to make extensive out-of-combat digging hopefully much more dangerous. To simplify the ability and make it slightly more useful as an in-combat escape, also remove its movement speed penalty. -------------------------------------------------------------------------------- 32bd0c41fe | Kate | 2021-12-25 17:03:33 +0000 Update some speech lines Remove various outdated speech lines, adjust a few others, and give Crazy Yiuf some new words. -------------------------------------------------------------------------------- 986220338f | Nicholas Feinberg | 2021-12-25 15:31:26 +0000 Code tweaks Constify some variables, switch from a pointer to a reference, and make some mon-info code shorter (this bit is dubious). -------------------------------------------------------------------------------- 2f14e528d3 | Kate | 2021-12-25 15:31:26 +0000 Make enchantment power use a smooth stepdown Should result in minimal changes to enchantment power in practice, but removes a use of the (supposedly) deprecated stepdown_value function, and also removes the cap of 120 on enchantment power, allowing spells with high power caps and a power boost (such as Agony and Enfeeble) to continue improving their success rate at very high skill levels. -------------------------------------------------------------------------------- 0dbd67afb6 | Kate | 2021-12-25 15:31:26 +0000 Add a new L7 Hex: Enfeeble Intended to give Hexes some more interesting utility to fill the gap between the powerful early stabbing spells and Discord at level 8, Enfeeble is a beam-targeted hex which irresistibly applies weakness and antimagic to a single foe (even against infinite willpower). The target is also dazed and blinded if they fail a willpower check (with a fairly substantial power bonus). -------------------------------------------------------------------------------- b25a51b929 | hellmonk | 2021-12-24 21:43:23 -0500 nerf Tukima's Studio This wizlab has like 3x the kill rate of the next most dangerous one. -------------------------------------------------------------------------------- 7c8fac35f0 | hellmonk3 | 2021-12-23 21:28:31 -0500 feat: Install some new plumbing Update old sewer maps to use best vaultmaking practices (randomized monster counts and placements, minimal hidden areas/spoilers). Reduce loot quality or quantity in most maps - this was buffed significantly when potion/scroll types got despoilered, so needs to come down somewhat. Additionally, add two exciting new sewer maps and re-weight all maps so that formerly rare ones are somewhat more common. -------------------------------------------------------------------------------- 826d19b2e0 | hellmonk3 | 2021-12-22 22:41:54 -0500 Add some assorted vaults feat. 1 (one) funny shop, 1 (one) funny transporter, and a few other things -------------------------------------------------------------------------------- 92def6ad0a | advil | 2021-12-22 17:47:50 -0500 build: add wtutil.py to the flake8 exclude list This is such a useless linter -------------------------------------------------------------------------------- a21510a5d8 | advil | 2021-12-22 17:29:43 -0500 feat: CLI interface for the dgl ban flag This can maybe be done already using the dgamelaunch-config tools, but it's useful to just have a simple interface built directly into the wlutil.py script. Resolves #1034 (together with the ^^ commit) -------------------------------------------------------------------------------- 45a336b667 | advil | 2021-12-22 15:21:08 -0500 feat: split off some webtiles cli stuff to a separate file This moves the commands for setting and resetting password tokens to a separate utility. (The underlying code is still part of webtiles.server, though, since all the setup stuff is there.) -------------------------------------------------------------------------------- 428f677eea | floraline | 2021-12-22 14:56:20 -0500 fix whitespace -------------------------------------------------------------------------------- 82aefee779 | floraline | 2021-12-22 14:56:20 -0500 Disallow user login when account has been banned DGL already supports banning user accounts via the user flags. Webtiles will now check this flag when testing password on user login. If the account is disabled, webtiles will not allow the user to log in. A message will be returned indicating that the account is disabled. -------------------------------------------------------------------------------- 270c432c18 | advil | 2021-12-22 14:54:57 -0500 fix: Restore #! line for server.py This got cut in 9b1d5c9715351a9bef3c. I'm not sure this should be an env call though? For the moment, keeping it unchanged. -------------------------------------------------------------------------------- a9037bb4c8 | advil | 2021-12-21 10:36:05 -0500 fix: fix some config defaults code * correctly check the bind options * fix handling of invalid recursive key checks -------------------------------------------------------------------------------- 59251e613b | advil | 2021-12-21 09:36:32 -0500 docs: update README.md, comments in config.py -------------------------------------------------------------------------------- 47ca6f2f2d | advil | 2021-12-21 09:36:32 -0500 fix: temporarily revert changes to client.html template This one gets me every time: templates update immediately even if the server hasn't yet restarted. So a pre-refactor server trying to load this template generates a 500 error because it doesn't have the new config API. This commit adds a shim that will work until servers have all restarted, and then it can be reverted. -------------------------------------------------------------------------------- 473480021d | advil | 2021-12-21 09:36:32 -0500 fix: correct a wrong config name -------------------------------------------------------------------------------- fb42bd042d | advil | 2021-12-21 09:36:32 -0500 fix: don't double webtiles --live-debug logging A logging call before `init_logging` results in doubled output, just push this check later. -------------------------------------------------------------------------------- 9b1d5c9715 | advil | 2021-12-21 09:36:32 -0500 refactor: move main server code into the webtiles package This was the last remaining chunk of webtiles code that was not inside the `webtiles` namespace. This commit moves it into a proper module, leaving the original non-package `server.py` as just a light wrapper on this module. -------------------------------------------------------------------------------- 65b1a8c667 | advil | 2021-12-21 09:36:32 -0500 refactor: move server.py This change apparently needs to happen in two steps so that the move is properly tracked in git history. -------------------------------------------------------------------------------- e20dd551ba | advil | 2021-12-21 09:36:32 -0500 docs: update placeholder README I originally put this file here just as a test of how DGL setups would handle subdirectories, but now that it has served its purpose, why not do something with it. This overview is pretty brief and high level, but as far as I know this kind of overview doesn't really exist anywhere else. -------------------------------------------------------------------------------- 2872ec6120 | advil | 2021-12-21 09:36:32 -0500 fix: acclimitize auth_test to `webtiles` * use package-anchored module names for mock * remove an unneeded mock for config -------------------------------------------------------------------------------- b939be1479 | advil | 2021-12-21 09:36:32 -0500 refactor: regularize the internal config api This wraps the server config module that is used as the repository for config info as if it were a dict-like. This would enable eventually just subbing in a dict (e.g. from yaml). In the short term it also makes the module have better behavior when no server config is provided. -------------------------------------------------------------------------------- c07941e8bc | advil | 2021-12-21 09:36:32 -0500 refactor: move webtiles defaults into webtiles.config Before there were occasional default values scattered around the code in get/getattr calls, in combination with things that are de facto defaults because no one has ever changed them. This collects the defaults in one place. I've aimed to leave uncommented in config.py only things one should or might want to change. -------------------------------------------------------------------------------- 0364767e1c | advil | 2021-12-21 09:36:32 -0500 fix: fix imports in tests This won't fully fix CI I think, because one of these tests needs config info that is now separated from the package; I'll fix that later. -------------------------------------------------------------------------------- 6b151ea7cb | advil | 2021-12-21 09:36:32 -0500 refactor: restructure webtiles into a package Previously, webtiles was just a loose collection of modules in the same directory. This restructures things so that everything but server.py and config.py form a proper python package. This has three main goals: 1. make the webtiles server code more encapsulated, and cleaner to load and interact with. This commit (to some degree) regularizes a lot of import statements. 2. short term: make it easier to dissociate config logic from config content. The `config.py` file in `webserver` is the same as before -- a python module with config settings for the webserver. The webtiles.config module on the other hand provides an api for getting config info that is abstracted from the python module that provides it. This can help clean up the handling of defaults, and pave the way for turning most of the old config.py into something like yaml, while retaining backwards compatibility. This could all have been done with a distinctly-named module in the same directory, but I think it is just a lot conceptually cleaner to do it in combination with 1. 3. long term: make it easier to swap out parts of the server code en masse by changing around package loading. This is aiming at a compatibility-preserving way of merging the dormant `webtiles-asyncio` branch. *Possibly* make it possible to version the webtiles server itself. This is a big change, and I've done only light testing so far, but in a local setup at least, everything is working. It may be that this commit will require a dgl change to merge (I'm not sure if subdirectories will be copied by default). -------------------------------------------------------------------------------- 76c8c3f4a7 | advil | 2021-12-21 09:36:32 -0500 fix: remove remaining import *s -------------------------------------------------------------------------------- 0243856f03 | Kate | 2021-12-21 01:29:26 +0000 Document mons_has_attacks behaviour Weird monsters with special zero-damage attacks like fire elementals and drowned souls are considered as having no attacks here which is very weird, but probably technically correct in the context of considering whether they should be able to be weakened or go berserk, so add a comment explaining it. -------------------------------------------------------------------------------- c6b4282bc0 | Edgar A. Bering IV | 2021-12-20 22:53:56 +0200 refactor: move Cantrip messaging to the monspell DB Instead of hard-coded strings plus some custom speech DB strings that got strange less-than-fully-featured handling. -------------------------------------------------------------------------------- 6bb796e56f | Edgar A. Bering IV | 2021-12-20 22:05:15 +0200 feat: leave Dissolution's prayers unanswered if Jiyva dies (11741) Dissolution is an incredibly devout follower of Jiyva, but not so devout to keep Jiyva alive alone without the Royal Jelly or the player as well. So, when Jiyva dies, this commit replaces Dissolution's eyeball summon with a cantrip and adds some custom casting messages for tragic flavour. [ Closes #2136 ] -------------------------------------------------------------------------------- a0fd31170c | Edgar A. Bering IV | 2021-12-20 20:39:51 +0200 fix: don't treat tentacles as separate monsters for yred (mdonais) This fixes both a funny piety bug and a serious crash-on-demand coming from kraken. -------------------------------------------------------------------------------- 948942c869 | Kate | 2021-12-20 18:15:36 +0000 Disable targeter for the staff of Battle's battlesphere (#2300) Closes #2300. -------------------------------------------------------------------------------- 2034e2a03a | Kate | 2021-12-20 18:00:33 +0000 Fix a Djinn mutation description -------------------------------------------------------------------------------- 75d13f451a | Kate | 2021-12-20 18:00:33 +0000 Improve wording of nimble swimmer mutation (#2295) Closes #2295. -------------------------------------------------------------------------------- 193881aaa2 | Nicholas Feinberg | 2021-12-19 17:12:51 -0800 Tweak Bind Soul description (🐙Mike) Move the important part (gotta kill the target before the mark expires!) before a bunch of fine print, and make other small tweaks, such as removing an overlooked 'enslave'. -------------------------------------------------------------------------------- e70e11bbaa | Nicholas Feinberg | 2021-12-19 16:36:57 -0800 Tweak Yred power description (🐙Mike) Try to clarify re raising the dead, etc. -------------------------------------------------------------------------------- c10b29e619 | Kate | 2021-12-19 23:39:51 +0000 Adjust Black Mark to only apply useful effects Instead of just randomly rolling for weakness, antimagic or draining when the mutation triggers, only select an effect that the defender is susceptible to. -------------------------------------------------------------------------------- bdd4f303c2 | Kate | 2021-12-19 23:39:51 +0000 Show when monsters are affected by antimagic Instead of having it be a hidden status effect, display it as a regular enchantment and give a message when it expires. -------------------------------------------------------------------------------- 1e6f1b2279 | advil | 2021-12-19 10:20:57 -0500 lint -------------------------------------------------------------------------------- ac32c9ce6f | advil | 2021-12-19 10:02:04 -0500 fix: make some prop types explicit Seems to be breaking the build on some compilers. -------------------------------------------------------------------------------- d731693074 | advil | 2021-12-19 09:43:41 -0500 feat: (g)o to location in item descriptions This seems like a fairly natural thing to have in this popup; already available via many other means of course, but you had to jump through various hoops to get to it from an item description depending on where the popup came from. -------------------------------------------------------------------------------- ef9e1dbd39 | Nicholas Feinberg | 2021-12-18 14:23:50 -0800 Fix Slouch stop attack prompt Don't ask "Really harm near your goblin?" -------------------------------------------------------------------------------- 582babd7fa | advil | 2021-12-18 12:56:47 -0500 feat: in ctrl-x list, indicate items at player's position The behavior of the full view menu for this case is somewhat confusing: by default a left click travels to the item's position, so nothing happens when a player clicks on an item in the menu at their position. I think a more major refactor of this menu might be helpful (not sure exactly what), but this commit tries to very slightly smooth over the case by marking which items are at the player's position explicitly. -------------------------------------------------------------------------------- ce354f50cf | advil | 2021-12-18 12:56:47 -0500 fix: enable describe actions for item stacks d40668a25 worked only on stacks of 1, because that was the only case where the describe popup got access to the "real" item that was on the floor. This commit expands things out so that for stacks of items if they are at the player's feet, the real item is used all the way along the chain. There was some required const munging that is not so great (though there's a lot of code that did not seem like it should actually be using const item_def * -- I started to work through this but the domino effect made me back up.) This commit also makes describe actions work for items in the full view describe that are at the player's feet. -------------------------------------------------------------------------------- 6159c76d74 | advil | 2021-12-18 12:56:46 -0500 feat: add (g)et as a describe action -------------------------------------------------------------------------------- bf359695bc | Nicholas Feinberg | 2021-12-18 09:25:21 -0800 Make the undead unpruneifiable Since they can't transform, right..? -------------------------------------------------------------------------------- 11349e6732 | Nicholas Feinberg | 2021-12-18 08:50:25 -0800 Rework the glaive of Prune (perryprog) The glaive of Prune has, for many years, had exactly one unique mechanical feature: being hated by Zin. Let's add something slightly more meaningful. Whenever the glaive's wielder is paralysed, petrified, or KO'd, they'll be overcome with the curse of the Prune, transforming into a giant prune. This makes the player so squishy that they're hard to injure, making them take half damage until the paralysis/etc ends. N.b.: probably this shouldn't affect the undead? -------------------------------------------------------------------------------- 876f0bc6b4 | Nicholas Feinberg | 2021-12-18 07:51:21 -0800 Manually add a throwaway gag (flappity) -------------------------------------------------------------------------------- 3f01f628eb | Edgar A. Bering IV | 2021-12-18 15:01:56 +0200 docs: add Gopall to credits -------------------------------------------------------------------------------- ed7a1ca826 | Edgar A. Bering IV | 2021-12-18 15:01:14 +0200 docs: changelog through 0.28-a0-1190-g77e1c55 -------------------------------------------------------------------------------- 77e1c55843 | advil | 2021-12-17 11:45:24 -0500 feat: use Goratrix's main menu tile in the action panel -------------------------------------------------------------------------------- 03e5d3d3bf | Nikolai Lavsky | 2021-12-17 11:39:14 -0500 refactor: combine code for drawing item glyphs and panel actions (advil) Both `draw_action()` and `draw_item_glyph()` have the same code for drawing quantities and highlighting actions, so it makes sense to combine them into a single function. Also, add a few TODO comments for future improvements. -------------------------------------------------------------------------------- 013d6de2c3 | Nikolai Lavsky | 2021-12-17 11:39:14 -0500 feat: don't hide the action panel unless it is explicitly disabled Since the panel always has at least one action now, it should be permanently visible unless disabled by configuration. -------------------------------------------------------------------------------- 5f2c673282 | Nikolai Lavsky | 2021-12-17 11:39:14 -0500 feat: add a main menu button to the action panel (PleasingFungus) With a main menu button on the action panel, it should be easier for players to discover the macro editor, lookup-help menu, and other tools and commands. -------------------------------------------------------------------------------- e4c47cc41c | Nikolai Lavsky | 2021-12-17 11:39:14 -0500 refactor: add helper functions for drawing panel actions The code for drawing actions and item glyphs is a bit complex, so it's better to split it up into separate functions. Also, we drew an item glyph and the cursor for some items twice. This happened if an item had a base tile and a brand icon. Fix this and simplify handling of `adjusted_scale`. -------------------------------------------------------------------------------- 4dc111b8cc | Goratrix | 2021-12-17 11:04:33 -0500 Tweak tile for game menu button on local tiles Commit 6a8ace0 added the game menu button to local tiles using a placeholder tile, this updates the tile to have the correct button frame. -------------------------------------------------------------------------------- 53156a8862 | Kate | 2021-12-17 02:17:16 +0000 Adjust messaging for monsters dropping wands on death To make it a little more succinct. -------------------------------------------------------------------------------- 2b4b0b1879 | Kate | 2021-12-16 23:26:30 +0000 Prevent self-healing abilities under DDoor They had no effect, but could waste max MP (as a Deep Dwarf) or piety (as an Elyvilon worshipper who abandoned to cast DDoor and then reconverted with DDoor active and enough saved piety to still activate Heal Self). -------------------------------------------------------------------------------- 381e24db82 | Nicholas Feinberg | 2021-12-15 22:08:27 -0800 Add an 'unaffected by silence' status A very common error for newer players is to try to silence demons and then to be confused about how they cast anyway. Adding a status that describes them as 'unaffected by silence' might help? -------------------------------------------------------------------------------- ba1fe864d9 | Nicholas Feinberg | 2021-12-15 21:51:18 -0800 Shift fire champion's display ordering -------------------------------------------------------------------------------- 586d44308f | Nicholas Feinberg | 2021-12-15 21:47:24 -0800 Buff infusion These felt a bit worse to me than I expected. Costing 2 MP per hit really burns through your pool startlingly fast, and results in a lot of resting. Let's try it at 1 MP per hit and see if it still feels like a significant cost. The Mad Mage's Maulers are unaffected. -------------------------------------------------------------------------------- e3c729c085 | Nicholas Feinberg | 2021-12-15 21:41:37 -0800 REVERTME: Make infusion gloves very common So that we can actually test this. Roll this back before 0.28's release. -------------------------------------------------------------------------------- 3097664d63 | Nicholas Feinberg | 2021-12-15 21:32:05 -0800 Increase the rat rate Changing the ratskin cloak from +Rats to *Rats may have left it somewhat undertuned. Increase the rat rate by 50% to compensate. -------------------------------------------------------------------------------- 7ef81e1a51 | Nicholas Feinberg | 2021-12-15 21:30:22 -0800 Add default values for monster spell slots Rather than requiring a full specification (spells:fireball.200.wizard...), allow just naming a spell and default to some plausible frequency and casting type values. -------------------------------------------------------------------------------- 0bdaba56fc | Nicholas Feinberg | 2021-12-15 21:30:22 -0800 Discover traps Don't claim that &Tzot will "mark it undiscovered". -------------------------------------------------------------------------------- d6bfa8a262 | Nicholas Feinberg | 2021-12-15 21:30:22 -0800 Zot! (Sastreii) New Zot trap tile. -------------------------------------------------------------------------------- 766a6a42ef | advil | 2021-12-15 21:23:11 -0500 doc: tweak some comments The return values here are not very obvious, document and make the comments consistent. -------------------------------------------------------------------------------- 38569e0721 | Kate | 2021-12-16 02:02:35 +0000 Fix a return value -------------------------------------------------------------------------------- 90128a5531 | Oneirical | 2021-12-16 02:02:14 +0000 Ban Jiyva from Thunderdome, replace Teleport Self with Blink Away Jiyva now uses exploration piety so doesn't function in arenasprint, and Teleport Self has been removed. [Committer's note - updated commit message, and kept Fedhas as enabled. Closes #2293] -------------------------------------------------------------------------------- bbd083314f | Kate | 2021-12-16 00:50:52 +0000 Make Yara's Violent Unravelling smite-targeted Along similar lines to Inner Flame and its recent change, Unravelling is a fun hex spell with some good utility, but is often quite fiddly to make effective use of. Change it to also be smite-targeted, allowing more precise enchantment/summon removal without the chance of a non-enchanted creature blocking the beam and making it ineffective. -------------------------------------------------------------------------------- f21496c7a1 | Kate | 2021-12-16 00:24:28 +0000 Shorten some new welcome messages To fit on a single console line. -------------------------------------------------------------------------------- e8bcaa7831 | Kate | 2021-12-16 00:02:48 +0000 Remove an unnecessary prompt The dreamshard necklace as implemented doesn't have any problem interacting with DDoor - the player will be invincible as expected while the spell is active, and then once it expires the necklace works as normal to save them if required. -------------------------------------------------------------------------------- c1efb617dc | Kate | 2021-12-16 00:02:48 +0000 Remove a duplicate canned message -------------------------------------------------------------------------------- 616b1c6417 | advil | 2021-12-15 14:40:31 -0500 lint -------------------------------------------------------------------------------- a718ce6c6e | Nicholas Feinberg | 2021-12-15 11:14:23 -0800 Lighten hands (kate) Continue a policy of strategic ambiguity wrt the purpose & uses of the Orb of Zot. -------------------------------------------------------------------------------- d40668a259 | advil | 2021-12-15 13:57:14 -0500 feat: read/quaff floor items from description Pretty straightforward change except that it was slightly tricky to get the right item to use. In the course of this I also refactored some of the switch statements and generalized the quiver check -- you can quiver from the description anything that is normally quiverable, rather than using an item by item check. This required a somewhat ugly hack to keep (q)uiver and (q)uaff from colliding, point even more towards the need to overhaul this code in a more structured way. -------------------------------------------------------------------------------- f8141789e4 | advil | 2021-12-15 13:57:14 -0500 feat: feature description tweaks * Show "you are here" if the player is at the position being examined. For now this is only on feature descriptions, but I have long wanted to add something like this for accessibility reasons. * Simplify some redundant feature decriptions. This was already done on the js side (I haven't removed that code, but possibly it is now removable if this one remains bug-free). * Improve door long descriptions. This mentions open/closed state, which is redundant, but felt odd not to include. It also explicitly mentions the door breaking mechanic. -------------------------------------------------------------------------------- 96c0fc9bb0 | advil | 2021-12-15 13:57:14 -0500 feat: tweak describe item actions order This is aimed at getting the "main" thing you do with various item types first, and the stable things across many item types last. (Previously, the latter were mostly first, and the order of the former was somewhat variable.) -------------------------------------------------------------------------------- 39b20cf4d7 | Nicholas Feinberg | 2021-12-15 10:24:05 -0800 Ignis flavor tweaks - Put its message before the 'you have escaped'. The latter is iconic and should always be last. - No messaging for escaping without the orb with Ignis - it won't come up often & doesn't really add much. -------------------------------------------------------------------------------- cb000ee472 | Edgar A. Bering IV | 2021-12-15 20:17:44 +0200 feat: some Ignis lore messaging (Wandering Mushroom) -------------------------------------------------------------------------------- 933dd556d1 | Edgar A. Bering IV | 2021-12-15 20:10:45 +0200 fix: lower the cost of Yred recall It didn't survive its tweak in the rebase, oops. -------------------------------------------------------------------------------- 27aa881441 | advil | 2021-12-14 17:22:12 -0500 fix: relax the conditions for `X]`/`X[` (elliptic) These got overly tightened in 5bd2f0ac44. -------------------------------------------------------------------------------- 93145404a5 | Edgar A. Bering IV | 2021-12-14 22:20:41 +0200 fix: silence library messages during newgame creation (kate) -------------------------------------------------------------------------------- 43c36bbe99 | Edgar A. Bering IV | 2021-12-14 22:20:41 +0200 fix: don't announce empty wanderer inventories -------------------------------------------------------------------------------- 805a0a0067 | Edgar A. Bering IV | 2021-12-14 22:20:41 +0200 fix: remove some dead book code from ng-setup -------------------------------------------------------------------------------- c9877f665c | Edgar A. Bering IV | 2021-12-14 22:20:41 +0200 fix: don't fall back to a kite shield inappropriately at newgame -------------------------------------------------------------------------------- a95d5098ad | hellmonk | 2021-12-14 22:17:31 +0200 feat: invert the wanderer paradigm Wn is a really cool "random start" option, but has a couple annoyances. You can get some truly awful starts due to the way skill points are assigned, and are basically guaranteed to have awful stats due to the way stat points are assigned. This commit tries to rectify those problems and adds some new things that Wn can get at game start. The new model assigns the equipment first, based entirely on species apts, then assigns stats and skills afterward depending on what we got. It tends to lead to more lopsided (ie useful) stat distributions and higher levels of skill in things that are useful, though these are by no means guaranteed. Along with changing the model this commit makes the following adjustments to Wn starting equipment, offering a wider mix of cool things: - "good weapon" can get an upgraded base type or vorpal brand instead of enchant - "good armour" can roll chain instead of +2 scale, and gives acid scales for non-chain users - "good shield" now rolls an enchanted buckler or prot buckler, instead of a kite shield - "good magic school" rolls a 3-spell randbook instead of a background starting book - "good spellcasting" rolls a 4-spell any-school randbook (capped at level 3) - "good stealth" can give either a +2 dagger and a consumable or a plain dagger and a mix of atropa and datura darts - "decent armour" can role chain or ring, with a plain aux armour for odd shapes (all scales and tla are too strong for decent items) - "decent dodging" and "decent stealth" can give an aux armour if a good armour wasn't received - "decent fighting" can give an extra weapon plus if a weapon is available - it is possible to start with a hunting sling and sling skill - throwing can start with boomerangs - it is possible to get aux armour (and likely for oddly shaped species) - a wider variety of potions and scrolls can be rolled - a wider variety of evocables can be rolled - Wn that start with sandblast also start with stones [ Committer's notes: Thanks to gammafunk, kate, and PleasingFungus for input in this overhaul. ] -------------------------------------------------------------------------------- f74599e7d4 | Edgar A. Bering IV | 2021-12-14 11:22:38 +0200 text: quotes for Chei abilities This might be gratuitous and I don't care -------------------------------------------------------------------------------- 9c71ebef14 | Nicholas Feinberg | 2021-12-13 20:44:56 -0800 Store polar vortex power on cast We historically didn't do that to discourage, say, wielding a staff of ice, casting the spell, and then unwielding the staff to do something else. But... usually if you're casting a level 9 ice spell, you sort of want to have ice enhancers for other things (eg ozo's fridge), and the un-stored power system encourages other silly swaps - eg start with a ring of wizardry to get vortex castable, then swap to =ice once it was running. Anyway, not storing power meant that using exegesis on vortex was a nasty player trap. Now that's fixed! -------------------------------------------------------------------------------- 59a505c739 | Nicholas Feinberg | 2021-12-13 20:24:43 -0800 Beef up ironbound thunderhulks Even as mid-tier enemies, thunderhulks were generally considered to be somewhat underwhelming threats. So, increase their HD by 50% to increase the accuracy and damage of their Call Down Lightning (damage from 3d21 to 3d26, accuracy from 19 to 21). Also give them Blink Range so that they eventually get a chance to re-distance themselves after getting too close to the player, similar to boulder beetles. -------------------------------------------------------------------------------- ef4b3a621b | Nicholas Feinberg | 2021-12-13 20:15:18 -0800 Fix Fire Storm damage display (elliptic) A weird ancient hack (3a4159644bb83, greensnark, 2008) was causing displayed damage (in xv, etc) to be twice actual damage. Now fixed. -------------------------------------------------------------------------------- 286b55035a | Nicholas Feinberg | 2021-12-13 20:12:48 -0800 Clarify Fiery Armour desc Be explicit about the +AC. -------------------------------------------------------------------------------- ec31e34405 | Nicholas Feinberg | 2021-12-13 20:10:41 -0800 Make two sudden removals The teleportatis exploration trap message used "suddenly" three times in a row. It was a bit much. -------------------------------------------------------------------------------- c7b72d3202 | gammafunk | 2021-12-13 14:58:16 -0600 fix: Update loot potion weights (darkwolf811) The list dgn.loot_potions is supposed to have weights adding up to 100, but this was broken f55cbd34. Adjust the entries appropriately so we total to 100 again. -------------------------------------------------------------------------------- 0f060c364e | advil | 2021-12-13 12:18:53 -0500 feat: no exiting popups via mouse with mouse control disabled Disabling this for now because of complaints. I'm not sure if this is really a good idea, this strikes me as the sort of thing where if this had always existed, no one would be asking me to remove it. -------------------------------------------------------------------------------- 5bd2f0ac44 | advil | 2021-12-13 12:18:53 -0500 feat: add key hints and hotkeys to feature descriptions Also, add clicking to webtiles, with some other misc description enhancements. This turned out to be a mess of special cases, many of which I've probably still missed. The commands that are supported are up, down, open, close, and some shortcuts that go directly to the map view for the other side of explored staircases. Bugfixes: correctly handle unseen tiles with webtiles right click; fix a subtle ordering issue in description hotkey handling. -------------------------------------------------------------------------------- c91ac77a38 | advil | 2021-12-13 12:18:53 -0500 fix: don't crash when right clicking out of bounds Probably webtiles specific. -------------------------------------------------------------------------------- cf6077d4cc | Kate | 2021-12-12 21:14:02 +0000 Tweak wording of autumn katana description For consistency with other DESCRIP lines. -------------------------------------------------------------------------------- c8569940dd | Edgar A. Bering IV | 2021-12-12 23:08:30 +0200 fix: remove some leftover code -------------------------------------------------------------------------------- 5f824d10e6 | sdynet | 2021-12-12 23:06:02 +0200 Rework the autumn katana Now, the sword sometimes uses manifold assault when attacking an enemy, instead of having clarity. Due to issues of setting time_taken and preventing re-entry the katana duplicates some of the functionality of cast_manifold_assault instead of simply re-using the function. However! There are two great upsides to this implementation: monsters can use the katana (no special flag) and players can use it with manifold assault to get one layer of recursion (and a rare message). [ Committer's note: Rewrote the artefact function, tweaked the implementation, revised the commit message. Closes #2234 ] -------------------------------------------------------------------------------- dee3398930 | advil | 2021-12-12 14:55:11 -0500 fix: add explicit styling for action panel settings For most players this is just minor color / spacing tweaks. But, it's come to my attention that CWZ loads bootstrap, and bootstrap's css is impacting the action panel quite badly. This commit should undo the most egregious aspects of this, though it's a bit hard to test directly. (Don't get me wrong, tossing bootstrap on top of webtiles is super double plus unrecommended, likely to lead to any number of subtle unpredictable rendering glitches, and by providing a workaround for these particular fairly major ones I in no way endorse doing webtiles+bootstrap...) -------------------------------------------------------------------------------- 386a16afc0 | advil | 2021-12-12 10:30:58 -0500 feat: click to close webtiles popups Previously, there was no way to escape a popup with a mouse(!). This commit adopts the local tiles approach, where clicking outside of a popup exits the popup. Unlike local tiles, both left or right clicking will work; in local tiles it's only right click. Possibly both clients should be standardized to use one or the other. -------------------------------------------------------------------------------- ff41af4bb9 | hedk3 | 2021-12-12 10:49:17 +0200 fix: more Storm Form hand naming [ Committer's note: fixed to compile correctly and unbraced. Closes #2290 ] -------------------------------------------------------------------------------- 4ce00ec954 | Edgar A. Bering IV | 2021-12-12 10:35:37 +0200 docs: update the CREDITS -------------------------------------------------------------------------------- 8fc9a925bb | Edgar A. Bering IV | 2021-12-12 10:11:16 +0200 feat: revise the ring of the Mage The ring of the Mage was a not-super exciting Wiz ring with light bonuses. In keeping with the "good or interesting" unrand revision paradigm, this commit revises the ring of the Mage to be a Wiz/Archmagi ring. Archmagi on an easty to swap slot might raise some eyebrows, but it is no worse than enhancer swapping. The hope is that this item might convince some more hybridization, helping make up for both the penalty of heavy armour and the lack of intelligence of heavy armour users. Of course, it'll also be an exciting find for any spellcaster who has body slot Archmagi, thanks to the stacking change. Boom pow! XXX: The _resist_composer in output.cc assumes that resists with a max of < 5 should get spacing, if it becomes possible to get 3 pips of Archmagi this will cause display issues % on console. -------------------------------------------------------------------------------- e886f3e13f | Edgar A. Bering IV | 2021-12-12 10:09:28 +0200 feat: archmagi stacking Currently the only sources of archmagi are body armour and a save-transferred hat of the high council. However, adding more archmagi sources has been discussed in a couple of development spitballs and the expectation in all of these conversations is that archmagi stacks. This commit alines expectation and reality. -------------------------------------------------------------------------------- 151b4aef40 | Edgar A. Bering IV | 2021-12-12 10:09:17 +0200 fix: archmagi handling in util/art_data.pl -------------------------------------------------------------------------------- 468af4c5fd | Edgar A. Bering IV | 2021-12-12 09:31:54 +0200 fix: remove a Tar teleport closet Closes #2291 -------------------------------------------------------------------------------- 87f88a2ef8 | Edgar A. Bering IV | 2021-12-12 09:24:06 +0200 Revert "fix: don't force picking up of newly IDd equipment" This reverts commit f5e35ccd160c657ff46174990fc3fe4e97655484. As implemented it did not have the correct behavior, and was still incorrect after 99a87601b6. Discussion with players revealed there are many users who expect autopickup to make its "should pick up decision" on an item when it comes into view, while others would like their autopickup options applied with respect to the item post-floor-identification. So I'm reverting this to the behavior before f5e35ccd: an item will be autopickedup if it meets the user's autopickup preferences before it is floor-identified. The correct solution here is to add a boolean game option that is checked before setting NEED_AUTOPICKUP_KEY in the relevant lines (the ones modified by this commit). -------------------------------------------------------------------------------- 8cf3085ebe | Edgar A. Bering IV | 2021-12-12 09:24:06 +0200 fix: don't crash on deathbed conversions Closes #2289 -------------------------------------------------------------------------------- c51a68064b | Kate | 2021-12-11 21:51:33 +0000 Add a missing canned message to Shaft Self prompt -------------------------------------------------------------------------------- a6bf8c0b4a | Kate | 2021-12-11 21:51:32 +0000 Let Yara's Unravelling turn summons into explosions (Undo) Yara's is a fairly situational spell, so to give it some slightly wider utility, allow it to also be cast on summoned monsters, unravelling the magic that summoned them and killing them immediately. This allows it to be used as a form of single-target abjuration that can additionally damage the summoner with the resulting explosion. -------------------------------------------------------------------------------- b845255321 | gammafunk | 2021-12-11 14:30:48 -0600 fix: Correctly handle classed objstat averages For the classed averages of charges and enchantment, use the correct count when averaging according to classes of "Vault", "Shop", and "Mons" for items in vaults/shops/held by monsters. -------------------------------------------------------------------------------- 64c176eb70 | advil | 2021-12-11 14:48:53 -0500 feat: expand out webtiles mouse control Webtiles mouse control has always been a bit of an incomplete feature; I think edlothiol only barely started on this in 2012 in 52f5b20b692aa, which was (afaict) his last commit. No one else has tried to fix this up since. This commit fills out the feature set a bit. Previously, you could use left click to move and attack in command mode, and there was a minimal tooltip for monsters, and that's it. This commit adds: 1. right click to describe in regular view, targeting view, and map mode. 2. left click to fire in targeting mode. (Or other behaviors, e.g. in `x` this triggers autotravel.) 3. synchronization of a targeting ray with the mouse cursor position. This is probably the dodgiest feature in that (a) it may run into issues with latency (it's handled on the server side) and (b) it may make it too easy to misclick. The implementation follows local tiles but I wonder if this would be better with something like, click to select target, click again to fire. (Also, this was rather involved to implement as it revealed a subtle bug in the direction chooser.) 4. Slightly less minimal tooltips. This only shows tooltips for monsters still, because it's a bit constrained by what info there is on the client side, and constantly doing popups with just the click hints was pretty annoying in my testing. One departure from local tiles: mousing over a square out of view doesn't affect the currently set ray. I found this a lot more natural and it works better with mousing from an object in the action panel to the targeting range (which almost always involves crossing out-of-los squares). Possibly this should be ported to local tiles. As before, all of this stuff is entirely disabled with `tile_web_mouse_control = false`. -------------------------------------------------------------------------------- 29f2d0b5fe | gammafunk | 2021-12-11 13:26:29 -0600 feat: Update briar patch and bush logic Currently, both bushes and briar patches allow projectiles and non-piercing magical beams to pass through, but get hit by enchantments and piercing or exploding beams. Although these rules are documented, they aren't intuitive and their complexity doesn't to interesting decisions. This commit simplifies the rules to allow pass-through to apply to all kinds of beams, be they enchantment, exploding, piercing, or non-piercing. Thus if a monster is shooting you behind a bush with whatever beam, you can shoot back with whatever beam. Bush and briars can still be targeted directly to prevent pass-through for any type of beam. We also remove specific exceptions for ranged and non-ranged sticky flame pass-through, since again this distinction is vanishingly rare in practice. Finally, we remove an unused exception for Chain Lightning as well, since it's not necessary for that spell to function properly. For briar patches, we improve their logic so pass through beams only if the actor is aligned with the briar. They intercept beams fired by a non-aligned actor like a normal monster would. This means that thorn hunters can fire through their briars, but the player's beams through these briars will be intercepted. This helps the briar patch to be a more effective anti-player-ranged barrier. For player-created briar patches under Fedhas, briars now block all incoming beams from hostile monsters like the player would expect. Monster descriptions for bushes and briar patches are updated to describe the new logic. -------------------------------------------------------------------------------- f48e6d8fb1 | amcnicky | 2021-12-11 20:06:22 +0200 feat: new unrand artefact: dreamshard necklace The dreamshard necklace is an amulet of nothing that for the most part does nothing. However, on a lethal or near-leathal blow the necklace shatters, absorbing the blow and releasing protective dreams of healing (a big heal, between half and full HP), friendship (shadow creatures), and clouds (fog). That is, the player gets to trade their amulet slot (with its many powerful effects) for a one-time-get-out-of-death-free card. [ Committer's note: Simplified the shattering effect significantly, re-factored the trigger logic to be simpler, moved the dreamshard effect to spl-goditem, reduced the visuals to a single flash (no permanent tile changes), implemented Ashenzari and Death's Door checks. Thanks to kate and PleasingFungus for input in the PR process. Closes #2078. ] -------------------------------------------------------------------------------- 12f55c057d | Edgar A. Bering IV | 2021-12-11 19:23:03 +0200 fix: finish an old todo in player::heal -------------------------------------------------------------------------------- 397d20460d | mgdelmonte | 2021-12-11 11:08:11 +0200 feat: add travel trail functions to clua Adds `travel.clear_travel_trail` and `travel.set_travel_trail` functions, allowing clua control over the travel trail. This purely visual feature can enable some nice generated visualizations, without affecting gameplay. [ Committer's note: Closes #2273. ] -------------------------------------------------------------------------------- 376ce86db5 | mgdelmonte | 2021-12-11 10:58:57 +0200 feat: add optional weapon argument to monsterinfo.target_weapon Adds an optional `weapon` argument to the Lua `monsterinfo.target_weapon` function. If `weapon` is omitted, it shows the targeting description accompanying an unarmed attack. If `weapon` is provided, it shows the targeting description for an attack with that weapon. This changes usage of the function slightly (formerly, the function returned only the description for your current weapon), but the function is new in this trunk cycle. [ Committer's note: Tweaked to also resolve a TODO in describe.cc. Closes #2275 ] -------------------------------------------------------------------------------- 9993a5020f | mgdelmonte | 2021-12-11 10:51:22 +0200 feat: add you.known_items clua function This exposes the list of known, identifiable subtypes to Lua. It's the same list as given by the `\` "display known objects" command, minus the unknowns. Without this, it's impossible to know (within Lua), that one has already seen a particular kind of potion or scroll. [ Committer's note: Squashed and clarified docstring. Closes #2286 ] -------------------------------------------------------------------------------- 31a25a4635 | mgdelmonte | 2021-12-11 10:30:17 +0200 fix: don't treat range 1 spells as "ranged" in mons_has_ranged_spell Range 1 spells like Freeze aren't really ranged spells, for the purpose of this function. [ Committer's note: Closes #2279 ] -------------------------------------------------------------------------------- ea0b6819f9 | mgdelmonte | 2021-12-11 10:14:27 +0200 feat: add can_traverse to clua monsterinfo Adds `can_traverse(x,y)` function to the clua monsterinfo object. Returns true if the monster can traverse (actually, occupy) the cell at x,y coordinates. Helpful for deciding where monsters might move. [ Committer's note: Closes #2274 ] -------------------------------------------------------------------------------- 398d93cfb8 | Brian Power | 2021-12-11 10:12:25 +0200 fix: add missing args for lua print_hint() [ Committer's note: Closes #2247 ] -------------------------------------------------------------------------------- 0bdd5ba030 | advil | 2021-12-10 21:04:28 -0500 fix: don't rest forever when divine vigour ends (ardl) If divine vigour ends while resting, bringing the player to full health, the delay would not end on its own, because the delay end condition was apparently only checked when increasing hp or mp. (I thought the delay was also supposed to check, but it seems I've been misreading this could. Possibly this would be a lot more robust than what we're doing now...) For most players this doesn't matter, because the divine vigour end message interrupts the delay. But any player who has something like `runrest_ignore_message += pray:` can trigger the bug. (Thanks to ardl for his ...involved rc, I got some good bisecting practice to find the interaction.) To fix this, this commit adds a check to calc_hp on top of inc_hp, which should also cover any similar cases that have so far been missed. Also, some cleanup of resting checks to be more uniform. -------------------------------------------------------------------------------- 2df8497881 | nicolae-carpathia | 2021-12-10 19:33:30 -0500 Make nicolae_danse_macabre slightly less macabre After comments, toned down a bit in D and Elf, by adding runed doors and also using less demon weapons in D. -------------------------------------------------------------------------------- fd376f2b2f | advil | 2021-12-10 18:15:15 -0500 lint: checkwhite (Odd thing for checkwhite to be enforcing, maybe a bug?) -------------------------------------------------------------------------------- 8eb0198dcf | advil | 2021-12-10 17:54:37 -0500 fix: handle multi-word actions in webtiles item descriptions Previous implementation made wrong assumptions about what actions there could be; instead of trying to generalize this commit just brute-forces the handling of a final "or". -------------------------------------------------------------------------------- 52f9137b40 | advil | 2021-12-10 17:28:42 -0500 fix: make webtiles ui push bugs less disastrous Two related issues: * If the menu state gets out of sync with the webtiles ui state, don't bring down the whole client (this could happen in `menu_key*_handler` if `menu` was set but `ui.top_popup()` returns null or undefined). * If there is a crash in a ui handler, show a buggy div rather than do nothing, to head off one way that the game's menu state and webtiles ui can actually get out of sync. This will also make it a bit clearer to the user they are seeing a bug that they could report. -------------------------------------------------------------------------------- 5c4f51bb93 | advil | 2021-12-10 15:28:19 -0500 fix: don't crash on `(t)ake off` This won't render quite right, but this commit should fix the javascript crash. -------------------------------------------------------------------------------- 1608afb2e1 | Edgar A. Bering IV | 2021-12-10 22:04:00 +0200 fix: don't treat all delays as frozen time -------------------------------------------------------------------------------- 97e41b5463 | Kate | 2021-12-10 19:49:04 +0000 Update some tests Remove obsolete items/egos from test character setups. This was only from a very cursory glance over the tests, and they likely could use some further attention (especially poor qw). -------------------------------------------------------------------------------- 76092dafaf | Edgar A. Bering IV | 2021-12-10 21:28:39 +0200 fix: don't crash when reaping with zonguldruk or chaos The refactor to work like the rest of corpse exploitation got lost in rebasing new Yred, oops. -------------------------------------------------------------------------------- f17af53183 | Edgar A. Bering IV | 2021-12-10 19:23:15 +0200 fix: the build -------------------------------------------------------------------------------- 6ce92f56ac | ArmiesAndCastles | 2021-12-10 19:03:35 +0200 feat: improve wizmode freeze time This commit keeps time frozen during autoexplore and forbids resting (since HP will not be recovered). [ Committer's note: Squashed and rebased, blocked the rest command completely. Closes #2206 Closes #2205 ] -------------------------------------------------------------------------------- a90572a584 | advil | 2021-12-10 11:39:59 -0500 feat: clicking for inventory item actions One thing the action panel has revealed is how minimally implemented clicking is in the webtiles UI. I realize that lots of advanced players are perfectly fine with never using a mouse, but allowing it makes things easier for newer players who aren't used to huge keybindings. This commit enables clicking on the actions in an item description popup (which is one of my first targets for this kind of change because it's so obviously missing when you right click from the action panel). The implementation is entirely client-side: it converts any strings like "e(v)oke" into a span with the `data-hotkey` attribute set to the hotkey in parens. This might be described as hacky (perhaps sending structured action data from the server would be better), but it was really easy to implement and actually seems pretty robust/useful. Part of the trick was that someone (aidanh I assume) has previously implemented an amazing thing where if you just set this data attribute, an on click handler magically springs into existence that sends the hotkey. -------------------------------------------------------------------------------- 39a6f95271 | Aliscans | 2021-12-10 18:39:39 +0200 feat: use modifier prefix keys in the direction chooser /+direction and shift+direction are valid combinations for the "long walk" command. Shift+direction is a valid combination for "fire in a direction", with direction+! as an alternative, but having /+direction do the same should make it easier to remember. Ctrl+X and Ctrl+P are both valid inputs to the direction chooser and common browser hotkeys, this commit also allows *X and *P as alternatives. Put ' and ; before * and / in targeting_help_1, as the above change means the latter keys are used as modifiers if use_modifier_prefix_keys is set (the default). In unmangle_direction_keys(), only let * modify characters which CONTROL() maps to \x00-\x1F. In particular, this means that ** is *, giving a work-around for people who use the default settings but are used to * and / cycling through objects. Co-authored-by: Aliscans -------------------------------------------------------------------------------- 0997d3a168 | ArmiesAndCastles | 2021-12-10 18:00:45 +0200 feat: add awoken forest attitude indicator to xv [ Committer's note: fixed bracing style, Closes #2204 ] -------------------------------------------------------------------------------- 99a87601b6 | Edgar A. Bering IV | 2021-12-10 16:44:21 +0200 fix: use identify_item when deciding autopickup information -------------------------------------------------------------------------------- f5e35ccd16 | Perry Fraser | 2021-12-10 16:24:55 +0200 fix: don't force picking up of newly IDd equipment This just re-uses the logic that was being used for wands, which also avoids the edge-case where if you floor-id something without using autopickup triggering (like when AP is disabled) then it was possible to have the item ID'd, marked as don't-pickup in `\`, and still picked up due to NEEDS_AUTOPICKUP_KEY set in its props. The old code that led to this logic seems to imply there was an intentional hack for "previously-unknown items", but in testing, I found no unexpected behavior with the new version. -------------------------------------------------------------------------------- c8cd538e2d | Edgar A. Bering IV | 2021-12-10 16:06:36 +0200 lint: checkwhite -------------------------------------------------------------------------------- 6a268ab339 | Gopall | 2021-12-10 16:04:24 +0200 feat: prompt when wearing faith Trying to remove an amulet of faith (while worshipping a deity that cares about it) would trigger a confirmation to confirm your choice. But there wasn't any confirmation like that for when you tried to put it on. So I added a bit of code to a function so the game would ask the player if they were sure they wanted to wear an amulet of faith. [ Committer's note: There was some discussion among the devteam as to whether or not this prompt is necessary or if auto inscriptions can implement the desired functionality (autoinscribing faith with !P to force a prompt). I'm merging this for consistency and because this prompt protects new players who are exactly the ones who won't have autoinscriptions set up. ] -------------------------------------------------------------------------------- 9766e9d42a | ArmiesAndCastles | 2021-12-10 15:55:55 +0200 fix: forbid temporary form lava exploration Closes #1975 -------------------------------------------------------------------------------- 27af8a720d | EdDewey | 2021-12-10 15:55:05 +0200 fix: only ask barachi for confirmation once when they hop -------------------------------------------------------------------------------- 88f0ff19eb | Nikolai Lavsky | 2021-12-10 15:29:25 +0200 feat: allow checking if there is enough space for Malign Gateway This commit disables the spell in the quiver and z/Z menu when there is not enough space to open a gateway. -------------------------------------------------------------------------------- 2bfde531ef | Perry Fraser | 2021-12-10 15:23:54 +0200 fix: correct levdes.vim comment syntax highlighting Seems to have been introduced as a typo in 763bd81. -------------------------------------------------------------------------------- 9d8ee82f23 | Aliscans | 2021-12-10 15:14:55 +0200 feat: state when a terrain blocks movement, but not reaching or magic State in the description when a terrain blocks movement, but doesn't restrict reaching weapons or LOS_NO_TRANS spells. At present, the former covers orcish idols, granite statues and malign gateways (the last only shows a description before the tentacle appears), and the latter also covers grates. This knowledge could be useful for (e.g.) cheibrodos_spider_deadly_dance. Co-authored-by: Aliscans -------------------------------------------------------------------------------- 5bfae530bd | Nikolai Lavsky | 2021-12-10 15:11:34 +0200 fix: don't erase travel trail when visiting item piles (#2081) After 330158af and 1bdd5c97, the travel trail is not drawn at all when the player visits item piles. `movement:cc:move_player_action()` adds visited tiles into the trail as long as there is the running delay in the delay queue. If the player moves manually (`running == false`), the same function calls `clear_travel_trail()` to erase the trail. Before we call `move_player_action()` for the last time, `travel.cc:travel()` calls `stop_running()`, which removes the running delay. As the result, `move_player_action()` clears the trail instead of adding the last step to it. Fix this by using `stop_running(false)`, which doesn't clear the delay. This should be safe, since the delay will be cleared by other code later anyway. -------------------------------------------------------------------------------- dce3279b65 | Nikolai Lavsky | 2021-12-10 15:11:34 +0200 fix: draw complete travel trail when autoexploring (#2081) After 14faa605, the travel trail sometimes doesn't have the last step. It happens when autoexplore is interrupted by a monster coming into view or by the player noticing a new item pile. Previously, we removed the running delay from the delay queue only after adding the last visited tile to the trail. We stop running and remove the delay earlier now, so we need an extra check after the code added in 14faa605. -------------------------------------------------------------------------------- 6a9fe35dad | burnish3d | 2021-12-10 15:10:15 +0200 docs: update style of use_animation and monster_list_colour (#2261) -------------------------------------------------------------------------------- 51eb943035 | hedk3 | 2021-12-10 15:08:02 +0200 fix: Storm Form display weapon name depending on species (#2265) Currently, this form always displays "Storm fists" no matter the active species, despite tiles showing that the player character's anatomy is maintained in this transformation. To be consistent with Statue Form and Blade Hands, this minor change uses the same logic used in Statue Form to fix this. -------------------------------------------------------------------------------- f47a79d804 | Jonathan Klabunde Tomer | 2021-12-10 15:05:23 +0200 consider Summonings useless after sacrificing love (#2277) With Abjurations gone, every spell in the Summonings school is inaccessible to characters that have sacrificed Love to Ru. The skill is therefore useless to them; we needn't bother allowing them to train it, and certainly shouldn't offer manuals of Summonings from acquirement. -------------------------------------------------------------------------------- 498bec7977 | Edgar A. Bering IV | 2021-12-10 11:54:41 +0200 tiles: yred iconography (Sastreii) -------------------------------------------------------------------------------- 1eb2483b26 | Edgar A. Bering IV | 2021-12-10 11:47:23 +0200 fix: consistently treat zombie base types In 1e9075421c5 zombies were de-anonymized. As an unfortunate side effect, the function mons_zombie_base was changed to return the species of the base zombie, not the base monster class used to define the zombie. As a result, most dramatically noticed for the damage of orcish derived undead, but also relevant for spriggan defender zombie action eneriges and any monster with a species much weaker than its type, the zombie was based on the underlying species. This commit simplifies some uses of the function and is being made after verifying every other use will work correctly (or as originally intended) with mons_zombie_base returning the monster class, and not the underlying species. Undead orc warlords should once again be as spooky as they seem from their name. -------------------------------------------------------------------------------- f3fc490d9d | Kate | 2021-12-10 03:13:02 +0000 Fix TSO not giving penance for miasma effects Appears to have been broken since the poison conduct was removed in c6e9da29e, oops. Fortunately didn't really matter since methods of creating miasma (like casting Corpse Rot) would already cause penance, but fixes the very powerful tech of creating a bunch of miasma in advance and then converting to TSO and letting it kill things. -------------------------------------------------------------------------------- 0f7456fd9b | Kate | 2021-12-10 02:39:54 +0000 Update the manual's mutation section -------------------------------------------------------------------------------- 594c0c42f0 | Kate | 2021-12-10 01:51:32 +0000 Update the manual -------------------------------------------------------------------------------- a282ea246d | advil | 2021-12-09 15:45:36 -0500 docs: update action panel options -------------------------------------------------------------------------------- 450912fe5d | advil | 2021-12-09 14:30:05 -0500 feat: action panel glyph mode I'm not sure this is really that useful, so it's currently not tied to actually being in glyphs mode and has its own option. We'll see if people actually use it; if not, (and if I don't find a way to improve it) it may just be better to remove before release. -------------------------------------------------------------------------------- 0cd4c285bc | advil | 2021-12-09 11:30:52 -0500 feat: more control over action panel item order Previously, item order was determined by enum order. This change uses the action_panel option itself to determine primary order (this was already implemented in an ordered way), and item letter for the suborder. It's possible that the latter will be too confusing by default, and if so, we can return to subtype as the secondary sort (which provides a stable ordering across games). I've also tweaked the default so that it is actually enum order, for some level of consistency before and after this commit. -------------------------------------------------------------------------------- a9895729f1 | gammafunk | 2021-12-09 06:32:15 -0600 feat: Slightly tone down a float vault (Lici) For minmay_chambers_of_sevens, the final chamber of sevens has seven 9 out-of-depth monsters, which is a bit steep for earlier mid dungeon levels like D:7. Allowable, but verging into runed door territory, which this vault isn't. Replace 3 9s with 0 spawns and downgrade two of the loot items, preserving the count of seven monsters and seven loot items in the final chamber. -------------------------------------------------------------------------------- 05a166d0ed | Kate | 2021-12-09 01:45:16 +0000 Adjust Chain Lightning damage falloff with range Increase the damage falloff from 2/3 per arc to 3/5 - in practice the damage falloff wasn't quite significant enough to make it feel distinct from other level 9 spells that deal massive AoE damage. Making it fall off faster helps make the positional aspect of the spell more important, while retaining its huge initial damage. In addition, rework the initial arc to scale smoothly with range, instead of having damage breakpoints at range 4 and 7 - this wasn't communicated clearly, and made those range breakpoints especially important against Nikola, for example. -------------------------------------------------------------------------------- a9c9dcfaf8 | Kate | 2021-12-09 01:45:16 +0000 Make wizmode god gifting grant Yredelemnul zombies Since &^ can't be used to adjust Yred's piety, special-case &- to gift zombies up to the next piety star. -------------------------------------------------------------------------------- 31ca34fcf2 | Kate | 2021-12-09 01:45:16 +0000 Refactor Bind Soul to use a new ability targeter And slightly adjust a failure message. -------------------------------------------------------------------------------- 6c0667d426 | Kate | 2021-12-09 01:45:16 +0000 Slightly increase BiA piety cost By 0.5 on average, to continue toning down the strength of various god abilities that are extremely strong and relatively low cost. -------------------------------------------------------------------------------- 46f1710d2c | Kate | 2021-12-09 01:37:05 +0000 Adjust some Qazlal ability costs To help Qazlal out a bit early on, reduce the MP and piety cost of Upheaval slightly, and also reduce the MP cost of Elemental Force. Also increase the MP cost of Disaster Area by 1, to make it a tiny bit harder to use multiple times in a single fight. -------------------------------------------------------------------------------- c1a47e44fc | Kate | 2021-12-08 23:25:24 +0000 Increase Okawaru Duel cost, reduce grace period on win It's an intended part of the ability that the player has some time to heal up after winning a duel, but it should be a little less reliable as a method of escaping danger. -------------------------------------------------------------------------------- 3cb2360906 | Edgar A. Bering IV | 2021-12-08 23:05:34 +0200 tiles: spectre tiles for bound souls (Sastreii) Not the full range of zombies like some of the others, but enough types to capture the different kinds of soul encountered in crawl. Should help the player keep track of their bound soul better. Definitely look super cool. -------------------------------------------------------------------------------- 53f92202ff | Edgar A. Bering IV | 2021-12-08 23:05:34 +0200 fix: remove a now unused MB check -------------------------------------------------------------------------------- 26d7df5b1f | Edgar A. Bering IV | 2021-12-08 23:05:34 +0200 feat: add the rest of genus W to Dark Bargain Since that was intended from the start. As the list is now longer in the mid range, adjust the quality floor upward. -------------------------------------------------------------------------------- 274bf074c3 | Edgar A. Bering IV | 2021-12-08 23:05:34 +0200 feat: toughen up bound souls For a capstone that's a bit tricky to earn, bound souls are pretty flimsy, even with the extra HP they were previously given. Let's turn them up a bit more so they get a better "bridge moment" feel, and players feel good about keeping them around/replacing and upgrading them. -------------------------------------------------------------------------------- a437c65847 | Edgar A. Bering IV | 2021-12-08 23:05:34 +0200 fix: clean up merge-induced bugs in dark bargain As well as abort the ability if the servant fails to arrive, instead of charging the player zombies for nothing. Unlike other ally abilities, Yred's Dark Bargain is used by players who have gobs of allies, so many that they might not have any available space for their servant. Aborting may leak a small amount of information, but the cases where that happens are either: ones where the player is getting it any way in virtue of their zombies, or so vanishingly rare and punishing that its probably ok to leak here. -------------------------------------------------------------------------------- b2c76ee18a | Edgar A. Bering IV | 2021-12-08 23:05:34 +0200 feat: mark death channel useless for Yredites -------------------------------------------------------------------------------- d6ebe8a65d | Edgar A. Bering IV | 2021-12-08 23:05:34 +0200 feat: allow bound souls to throw rocks -------------------------------------------------------------------------------- ea437062f2 | Edgar A. Bering IV | 2021-12-08 23:05:32 +0200 rename: change Yred abilities to not be explicit slavery Casual use of slavery-as-entertainment in crawl has been on its way out as poor taste for a while. Yred was one of the last hold outs, this rework is a good opportunity to make a change. Instead of dipping into the metaphysics of whether or not "enslaving souls" is the same as chattel slavery, let's just be a bit more vague in the flavour of Yred. -------------------------------------------------------------------------------- 17048352e6 | Edgar A. Bering IV | 2021-12-08 23:04:45 +0200 refactor: black torch: treat bound souls as their own species There were a bunch of strange special cases for spectral things intended to handle edge cases for bound souls but not show up on regular spectrals because of other checks or luck. This changes the enslaved soul to be its own monster type, still of species spectral thing, and simplifies or makes explicit the relevant checks. This commit also allows bound soul stats to be adjusted independent of spectral things; the EV modifier could be changed in the future. For now, to buff the bound soul, it gets full HP so as to be less fragile. -------------------------------------------------------------------------------- 5224dc67e1 | Edgar A. Bering IV | 2021-12-08 23:04:45 +0200 fix: clarify that undead left behind will poof -------------------------------------------------------------------------------- df1d555f45 | Edgar A. Bering IV | 2021-12-08 23:04:45 +0200 feat: fineff-ify attitude changing revivals Many different ways of harming a monster don't expect the monster to change attitude partway through the process. This has been the source of several mysterious Yred enslaved soul and Beogh deathbed conversion bugs. To prevent them, move both of these attitude-changing revivals to a fineff, so that mon->alive() returns false for the convertee until the fineff fires. This is a bit hacky so might cause weird behavior, but since fineffs now fire after each monster turn I don't think it will. -------------------------------------------------------------------------------- c2baa198af | Edgar A. Bering IV | 2021-12-08 23:04:45 +0200 feat: black torch: spectral mist immunity Like nightvision, meant to make monsters from Dark Bargain not harmful to the player. Of course, we could have left revenants off of the dark bargain list but that is a significantly less cool approach. -------------------------------------------------------------------------------- 8b846c3b94 | Edgar A. Bering IV | 2021-12-08 23:04:45 +0200 fix: reduce message spam under Yred and Usk -------------------------------------------------------------------------------- 8212ce3e68 | Edgar A. Bering IV | 2021-12-08 23:04:45 +0200 feat: black torch: yredelemnul conduct enforcement -------------------------------------------------------------------------------- 772aeeb350 | Edgar A. Bering IV | 2021-12-08 23:04:45 +0200 feat: black torch: handle yred abandonment correctly Update the abandonment sequence for the new style of yred minion and tidy up the now unused ALLY_YRED daction. -------------------------------------------------------------------------------- 0a07692a02 | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 feat: black torch: monk and ecumenical altar bonuses Grant the devout some immediate zombies. Monks get filled all the way up to **, which will feel a bit sad in the Temple but oh well. Ecumenical altar grants * worth of zombies, which at D:1-3 is a lot of bodies. Monk + Ecu gives ** but a few more zombies than a monk alone. -------------------------------------------------------------------------------- bf6f545f5c | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 fix: increase bind soul duration Now that it's a bit more awkward to use, give players a little more time to make the kill, since the zombies are paid out either way. -------------------------------------------------------------------------------- 3254f7a1f8 | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 feat: ensoul the animals And other less intelligent creatures. Souls are things that living, demonic, and holy creatuers have regardless of intelligence! -------------------------------------------------------------------------------- bf073b50f9 | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 fix: prevent spectral things from taking stairs -------------------------------------------------------------------------------- 556ba5c09b | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 feat: don't drop corpses with Yred This is to create the illusion that Yred always reaps when a corpse is dropped. (Yred's reap chance can be improved with faith, so it's a separate roll, but without faith they're both coinflips.) For consistency, both the reaping brand effect and this Yred effect now occur before dropping a hide. You cannot skin a zombie after its been reanimated! -------------------------------------------------------------------------------- 7da1dd8346 | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 feat: black torch: give full XP for Yred ally kills Commit db2750068a removed the summon XP penalty for all but Beogh and Yred allies, hoping a future rework of these two categories would allow the penalty to remove. The black torch sequence of commits overhauls Yred into a state where full XP is ok. -------------------------------------------------------------------------------- 39e59bd991 | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 feat: runrest ignore yred messages by default -------------------------------------------------------------------------------- 3d579d9813 | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 feat: black torch: amulet of faith Amulets of faith increase the chance of reaping a semipermanent follower while worshipping Yred. On removal some of these followers are reclaimed. This means that a Yred worshipper without zombies can remove faith for free, but that's similar to Uskayaw. -------------------------------------------------------------------------------- 98cb3ae26c | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 feat: grant Yred nightvision at all times (kate) -------------------------------------------------------------------------------- 2e4292cc8c | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 text: Update Yred's description to reflect the changes -------------------------------------------------------------------------------- 484e03e0cf | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 text: give more detail in the bound soul desc -------------------------------------------------------------------------------- b0a17c5a12 | Edgar A. Bering IV | 2021-12-08 23:04:44 +0200 feat: black torch: remove yred gifting In Yred's redesigned piety system, the gift timer and its mechanics don't make sense, so the permanent ally gifts are removed. This achieves one of the goals of the redesign, which is to severely limit the use of permanent allies (to only the enslaved soul). -------------------------------------------------------------------------------- 3e152b4d76 | Edgar A. Bering IV | 2021-12-08 23:04:43 +0200 feat: black torch: dark bargain A subsequent commit will remove Yred's passive, permanent gifts. Yred's more powerful servants are really cool as allies and significantly better than plain zombies and spectres. This active ability brings them back as summons, the player trades their zombies for them. This commit also expands the list of Yred servants to cover almost all of genus n, z, V, and W. The exceptions are Vampire Mages (kiku worshippers, or at least too proud to serve), and a couple of monsters that would be more harmful to the player than good allies. -------------------------------------------------------------------------------- 83783ab100 | Edgar A. Bering IV | 2021-12-08 23:03:47 +0200 feat: black torch: zombie piety Move Yred to an alternative piety system, where abilities are paid by offereing up some of the player's reaped souls. Currently this uses Zombies-recently-in-LOS for piety, the aim being a medium-time-scale piety system that builds up over a single floor, but resets on floor transition. Zombies on the floor could also be used, but there are information leak issues with that, plus it encourages closet stashing. The goal is to encourage the player to keep their harvest close at hand! Reaped monsters live on the floor they were created on and disappear when the player leaves the floor (by any means, portal vaults and shafts both count). This gives Yred a medium-scale piety system, lasting longer than Usk but much shorter than a conventional god. -------------------------------------------------------------------------------- 35b79d20d0 | Edgar A. Bering IV | 2021-12-08 23:03:47 +0200 refactor: move the targeting abflags to the high byte -------------------------------------------------------------------------------- 831c365f3e | Edgar A. Bering IV | 2021-12-08 23:03:46 +0200 feat: black torch: passive reaping To replace Yredelemnul's active animate dead abilities, this introduces a passive reaping status, granted at 0*. In this redesign Yred will use zombies as piety, so this is in essence the new piety gain system. Yred reaps both body and soul, from monsters that don't have a corpse (or whose corpse exploded!) the player gets a spectral thing. With the recent change to allow spectralizing demons, Yred can reap their twisted souls, too. The reaped monsters cannot leave the floor they came into being on, and if the player leaves they are dismissed. -------------------------------------------------------------------------------- b4513a33df | Edgar A. Bering IV | 2021-12-08 23:02:13 +0200 feat: new yred: remove injury mirror Injury Mirror was the most awkward of Yred's abilities. It cost a lot of piety if it activated, but getting a big activation meant taking a lot of damage. In comparison, Drain Life gains hitpoints and costs a predictible amount of piety. It's possible there's an injurry-mirror or damage-sharing ability that works with the re-designed Yredelemnul "zombies are piety" principle, beyond just having allies to soak up damage. For now, this gets the axe. -------------------------------------------------------------------------------- 286e7562c3 | Edgar A. Bering IV | 2021-12-08 23:01:25 +0200 feat: black torch: remove yred animation actives This sequence of commits re-designs Yredelemnul. A key feature of the re-design is a passive reaping to replace the animation active abilities, and a necessary first step is to remove them. -------------------------------------------------------------------------------- aa9a639d33 | Perry Fraser | 2021-12-08 15:22:59 -0500 Have deps.py print output of a command on fail Note: probably would be better to use subprocess.run instead of check_output, but that's Python 3.5+ only. I'm not sure what the intended version this is supposed to run on. -------------------------------------------------------------------------------- 92583b6a8d | advil | 2021-12-08 14:25:50 -0500 fix: don't let Usk steal other gods' powers (G-Flex) As discovered by G-Flex, if you have a religious ability quivered and convert to Uskayaw, the quivered ability registers as valid and can be used via quiver commands if you meet its piety threshold. This commit changes `god_power_usable` to do an explicit god check. To support this check I refactored the god_powers static to use a construct-on-first-use paradigm, and added the god field directly to the struct type. -------------------------------------------------------------------------------- 7a5fce4930 | Edgar A. Bering IV | 2021-12-08 16:05:56 +0200 feat: adjust fiend ratios in Coc and Dis New Cocytus and Dis have turned out significantly deadlier than new Geh and Tar. In Cocytus, shard shrikes shine bright, sticking out as an outlier in kills. In Dis, iron giants aren't as much of an outlier, until you notice the second kiler is iron golems, who spawn in bands with an iron giant leader to chuck them at the player. On the other hand, Ice Fiends have barely notched any kills in coc, despite being rather nasty; Hell Sentinels have about 1/3rd the kills of the giant/golem duo, a bit more respectable but not enough to catch up to an outlier. Comparatively, tainted leviathans and hellephants spawn singularly. The former hold their own, racking up kills with a similar rate to tzitzimimeh (who spawn less often). The latter are weaker, but the rarer brimstone fiends top the charts. So this commit reduces the frequency of iron giants and shard shrikes, swapping them with hell sentinels and ice fiends respectively in the table, in hopes of making the four hells a bit more level. -------------------------------------------------------------------------------- 9c4cb8273d | advil | 2021-12-07 15:52:52 -0500 fix: handle db source files with mtime 0 These don't occur normally in the wild, but sometimes people doing reproducible packaging or the like will set all mtimes to 0. When this happens some old db code that treated 0 as an error condition would produce a fairly incomprehensible ASSERT. I suspect this is what is behind: https://crawl.develz.org/mantis/view.php?id=11956&nbn=1#bugnotes https://github.com/crawl/crawl/issues/2276 and the like, though this is not something I've been able to test. I've also rewrote the ASSERT to produce something more like a real error message, though I think it should be much harder to trigger now. Note to packagers: this commit keeps things from crashing, but distributing files with mtime 0 is *really not recommended* unless you are sure to never use a shared db cache directory. If you do, this commit will severely break having multiple versions installed (and I don't think the errors will be any less cryptic that this one). It should meet a typical reproducible build desiderata to use the official file times for db (and most dat/ files) as these are not generated at build time -- they are game data files. -------------------------------------------------------------------------------- 9b0f503c9e | advil | 2021-12-07 14:26:38 -0500 fix: hidpi scaling for action panel div -------------------------------------------------------------------------------- 702cd34d14 | advil | 2021-12-07 14:20:06 -0500 fix: scale action panel qty for hidpi also There must be some better way to do this... -------------------------------------------------------------------------------- 5957592b1c | advil | 2021-12-07 13:40:16 -0500 fix: correct hidpi rendering for the action panel (PleasingFungus) This code assumed that the `renderer` object was pre-adjusted for the device to pixel ratio (which is how it's done elsewhere), but this is not so straightforward to do for the action panel (though it might be cleaner if it could be done). So, do explicit scaling for the device ratio, and remove explicit scaling for mouse cursor position. Should have no impact on non-hidpi/retina devices. -------------------------------------------------------------------------------- b7f16da270 | advil | 2021-12-07 12:22:38 -0500 fix: improve `.prf` file naming/location on DGL builds Two changes, should affect DGL builds only: 1. Set the filename correctly. After game start, it turns out that Options.game.name is the empty string, resulting in the hilarious behavior of everyone on a DGL_STARTUP_PREFS_BY_NAME build sharing a single prefs file named `start--ns.prf`. 2. For a DGL_STARTUP_PREFS_BY_NAME build, put prefs in a subdirectory of the shared directory, rather than the saves directory. The reason for this is that the saves directory on a DGL setup (and maybe any setup using this flag) is versioned, and so the .prf file gets wiped out/ignored on any trunk version change. (An alternative would be having DGL copy the files, but this would be too painful to implement.) -------------------------------------------------------------------------------- 1a2f33fa85 | Nicholas Feinberg | 2021-12-06 18:37:15 -0800 Remove spurious malevolence (some) If an explore trap teleportation fails to teleport the player, don't print a message about malevolence. Still possible to get a spurious message from getting explore shafted after getting non-explore shafted, in principle. -------------------------------------------------------------------------------- a8db75c868 | Nicholas Feinberg | 2021-12-06 18:29:54 -0800 A flaming sword which turned each way... (Sastreii) New tiles for ironbound thunderhulk, Yredelemnul's altar, and the Seraph. -------------------------------------------------------------------------------- 8410daf38b | advil | 2021-12-06 21:19:17 -0500 fix: tweak full hide behavior with minimized action panel The action panel is supposed to hide itself entirely if there's no relevant inventory items (either by happenstance or by configuration), but because of the sequencing this would still show the minimized form -- clicking the + then got rid of the panel. (An easy way to replicate was to set `action_panel =` and `action_panel_show = no`, but it also had similar behavior when dropping items.) This adjusts the sequencing so that the placeholder is handled correctly with no items at all. -------------------------------------------------------------------------------- 8662a715a7 | advil | 2021-12-06 20:00:25 -0500 fix: use longname for explore trap flavor Adding "the" to `shortname` doesn't always work, and `longname` already is designed to be used wherever a definite description should work. Resolves #2270 -------------------------------------------------------------------------------- 6b46d0572a | advil | 2021-12-06 18:36:35 -0500 fix: show wands by default in the action panel Early indications are that it is more confusing than not to leave these out by default. I guess the concern may have been screen space, but we'll see how it goes in practice. -------------------------------------------------------------------------------- 3b2567e0bc | advil | 2021-12-06 18:29:49 -0500 fix: use targeters from action panel This change got lost in the shuffle, I think this is what players will expect though. -------------------------------------------------------------------------------- 57bb0be0ea | advil | 2021-12-06 17:03:44 -0500 fix: fully remove custom parsing code for action_panel_orientation This check can be implemented using a different class, so let's do that. (A previous commit had made the custom parsing code inert by converting the option to StringGameOption, but this had the result that anything other than "horizontal" was interpreted as "vertical" rather than producing an error.) -------------------------------------------------------------------------------- 0724427129 | advil | 2021-12-06 17:03:44 -0500 feat: save action panel scale and font size This also changes the behavior of action_panel_scale so that it is an int percentage, rather than a float -- this allows removing custom parsing code, and makes it so that the ui and settings values are more consistent. (I had apparently already added the IntGameOption part of this in a previous commit, so this commit isn't clean.) -------------------------------------------------------------------------------- 691f867587 | advil | 2021-12-06 17:03:44 -0500 fix: hide action panel for spectators A braver person than me might try to sync the visual state of this with the player rather than hiding, but I'm not going to do that any time soon myself. -------------------------------------------------------------------------------- b232902b95 | advil | 2021-12-06 17:03:44 -0500 fix: hide tooltips when action panel settings is open These aren't readable anyways, because they are under the popup. -------------------------------------------------------------------------------- 090e49b2c9 | advil | 2021-12-06 17:03:44 -0500 fix: apply an upstream fix from focus-trap This reverts ac5a30bc78f08b3 and applies the final upstream fix for https://github.com/focus-trap/focus-trap/issues/103, in particular: https://github.com/focus-trap/focus-trap/commit/fe2b0ad8d03d3a727d7f0d4d1e0ec2b3 f2887577. Since my original fix for this focus-trap has gained a new maintainer and seen a bunch of releases, so possibly we should consider updating, or at least checking if there are specific bugfixes to apply. -------------------------------------------------------------------------------- bbe7356047 | advil | 2021-12-06 17:03:44 -0500 feat: use focus-trap for action panel settings popup This fixes a whole bunch of issues with keypresses going the wrong place, focus not being returned after this closes and just generally being weird, etc. There are still various issues with this commit that are indicated in the comments, where basically (to me at least) browser focus can be extremely mysterious. But the only user-facing one is that I couldn't get tabbing to the buttons to work. Also, rename some html elements. -------------------------------------------------------------------------------- 394b2318f7 | advil | 2021-12-06 17:03:44 -0500 fix: min panel scale to 50%, not 10% With 0.1, it becomes hard (on my display at least) to get back to the panel by right clicking. 50% is about the smallest I could imagine it being usable at, and it makes it possible to get to the settings menu to reset this value. This may need further tweaking. Note that nothing prevents you from setting a lower value in rc if this is useful in some configuration I'm not imagining. (There's a different way to hide it altogether.) -------------------------------------------------------------------------------- a1dc6246e2 | advil | 2021-12-06 17:03:44 -0500 fix: don't toggle settings panel on settings change This fixes a regression introduced when I implemented saving. Because the textinput value is processed on key input, they are unusable if the panel closes immediately. -------------------------------------------------------------------------------- af3cd226fe | advil | 2021-12-06 17:03:44 -0500 fix: change behavior of x when settings open Previously, this would still minimize the panel, but I think it's more intuitive to just hide the settings pane if settings is currently open. -------------------------------------------------------------------------------- ff10334c96 | advil | 2021-12-06 17:03:44 -0500 docs: update action panel entries -------------------------------------------------------------------------------- 551de97837 | advil | 2021-12-06 17:03:44 -0500 refactor: rename consumables panel => action panel I anticipate we may eventually want to generalize this beyond just items. This is an optimistic preemptive rename, since the options names need to be definitive before merge, though I don't anticipate making it handle non-consumables before merge. This change also makes the options names a bit shorter and (maybe) easier to remember. -------------------------------------------------------------------------------- 7743480e9c | advil | 2021-12-06 17:03:44 -0500 feat: save some consumables panel settings in .prf file This provides a persistent memory of whether the user has the panel visible, and what orientation they have it in, across games. -------------------------------------------------------------------------------- d1ef89111a | advil | 2021-12-06 17:03:44 -0500 feat: improvements to webtiles options API This adds a bit more control over some of the set_options calls on the webtiles side, and provides a way for webtiles to send options settings back to the crawl process. It's still all a bit brute force. -------------------------------------------------------------------------------- c9e27d6a74 | Nikolai Lavsky | 2021-12-06 17:03:44 -0500 fix: iron out a few bugs in the consumables panel enhancements This commit fixes the following issues: * The hide button was drawn on top of the first consumable item. * Interaction options - adjust, read/quaff, drop, inscribe - didn't work when called from the describe popup, printing "Unknown command" messages instead. I fixed this by replacing `describe_item_popup()` with `describe_item()`, which executes the selected interaction via `_do_action()`. * It wasn't possible to use unidentified potions and scrolls by clicking them on the panel. I "fixed" this by allowing to quiver unidentified potions and scrolls. This was explicitly disabled in `consumable_action:is_valid()`, but it looks like such consumables work fine from the quiver, so I hope this change is OK. Also, I added an extra check into `consumable_action:is_enabled()` to prevent information leaks. * The cursor for the selected item didn't scale with the panel. This was caused by calls to `draw_icon()` missing a couple of arguments. * There were no item tooltips in Chrome (caused by a missing `var`). Also, there is a new `draw_gui()` helper function for drawing tiles from the `gui.png` tilesheet. It wasn't obvious that the panel has a settings menu, so I added a tooltip for the hide button. -------------------------------------------------------------------------------- bd7f567b5d | advil | 2021-12-06 17:03:44 -0500 feat: consumables panel enhancements (clicking, information) (This is not super well-tested, so I'm not really sure if it is safe to merge just yet.) This commit adds the following features to nlavsky's original consumables panel patch: * click to show/hide; the leftmost icon when visible is always a hide icon. * right click on the hide icon (only) to get the settings popup * right click closes the settings popup also. (This should maybe close * if you click out of this ui, but I wasn't quite sure how to do that.) * tooltip on consumables gives the item name and inventory letter * right click on consumables (when in mouse command mode) opens the describe popup * left click (in mouse command mode) just directly triggers the item. This is implemented via the actions interface, so doesn't need to add much code (as it rests on 6e4aca117). Does this make misclicks too easy? I'm undecided whether this should be minimized or shown by default. It would be really nice if minimization state at least were stored either as a cookie or in the save between sessions. Motivation: The patch as it stands is feature-complete relative to the original goals (including ones I encouraged), but after testing I unfortunately don't think it will feel very complete to end users. The UI has the form of something that should be clickable, so players will expect it to be clickable. (The tiles even look kind of like local tiles menus.) Also, players not familiar with the icons will have a lot of trouble with this: even as a long-time console player I don't know the icons well. Hence the tooltip. -------------------------------------------------------------------------------- 9e6efe1491 | Nikolai Lavsky | 2021-12-06 17:03:44 -0500 Add an in-game configuration menu for the consumables panel This new menu allows changing the panel's orientation, scale, and font size in-game. Also, it allows minimizing the panel into a "+", similar to how the chat window can be minimized. All the changes are done on the client side and not saved between sessions. Also, this commit splits the panel's font option into font_size and font_family, so it is similar to other existing font options. -------------------------------------------------------------------------------- 8d133420af | Nikolai Lavsky | 2021-12-06 17:03:44 -0500 Add a font option for the consumables panel (nojaa3) The pixel font used for displaying the quantities of items is quite small and doesn't scale well. Instead of mimicking the style of the inventory panel from local tiles, it's better to use a system font and allow the player to configure it. This commit adds an option to specify the font for the panel and increases the default font size. -------------------------------------------------------------------------------- f446b847d9 | Nikolai Lavsky | 2021-12-06 17:03:44 -0500 Add an option to reposition the consumables panel (Implojin) To make the panel less intrusive for more screen resolutions and sizes, add the `consumables_panel_orientation` option. When set to 'horizontal' (the default), the consumables panel will be placed along the top edge of the screen. When set to 'vertical', the panel will be placed along the left edge. -------------------------------------------------------------------------------- 637e5f1bb1 | Nikolai Lavsky | 2021-12-06 17:03:44 -0500 Filter consumables on the crawl binary side (advil) This allows to use the same regex parser that the crawl binary uses, which should be faster. Also, it makes the code more portable to other build targets. Now `TilesFramework::_send_item()` does the filtering and sends an extra flag with each item, `qty_field`. If it's either "plus" or "quantity", the web client(s) will show such items on the panel. -------------------------------------------------------------------------------- 58cd58bcfe | Nikolai Lavsky | 2021-12-06 17:03:44 -0500 Remove a couple of obsolete vendor prefixes Firefox v.51+ (2017) and Chrome v.30+ (2013) can handle the unprefixed `imageSmoothingEnabled` canvas property just fine. -------------------------------------------------------------------------------- 972ed031cb | Nikolai Lavsky | 2021-12-06 17:03:44 -0500 Fix web clients not getting updated about the state of XP evokers Whenever an inventory item's item_def changes, the game sends an update to the web client(s). Because information about XP evokers is stored outside of item_defs, there are no updates when XP evokers recharge or lose charges. Fix this by caching the number of charges in the item.plus field (similar to how wand charges are stored) and sending updates when necessary. -------------------------------------------------------------------------------- d76b51a1a8 | Nikolai Lavsky | 2021-12-06 17:03:43 -0500 New consumables panel for Web Tiles The main goal of adding this panel is to give the player a quick and easy way to see all the items that can help them succeed in a fight. It would be ideal to have the full inventory panel, similar to Local Tiles, but there are a couple of problems. The first is a lack of screen space: unless you have a big monitor, the choice is either the monster list (Web Tiles) or the inventory panel (Local Tiles). The second problem is that only about a half of inventory items are useful in fights. A filtered view of the inventory will take less space and present only combat-relevant items. This commit adds a new panel, which can be configured via four options: * `consumables_panel`: types of items to show on the panel; * `consumables_panel_filter`: a list of regular expressions for filtering items out; * `show_unidentified_consumables`: whether to show unidentified scrolls and potions; * `consumables_panel_scale`: allows to change the size of icons on the panel. The panel is displayed in the top left corner, partially covering the top row of tiles on the map. Non-Barachim chars should always have at least one out-of-sight row at the top. For Barachim, the game can show 18 rows of tiles with one out-of-sight row at the top as long as you have 736 pixels vertically. -------------------------------------------------------------------------------- 4b78bf2b85 | Edgar A. Bering IV | 2021-12-06 21:12:23 +0200 docs: changelog through 0.28-a0-1004-g00e6d53462 -------------------------------------------------------------------------------- 00e6d53462 | Edgar A. Bering IV | 2021-12-06 21:00:32 +0200 fix: make mauler's inscription consistent -------------------------------------------------------------------------------- a36b043db1 | Edgar A. Bering IV | 2021-12-06 20:27:03 +0200 feat: refactor eleionoma and fenstrider wands 2dcde036d21 gave eleionoma and fenstirder witches guaranteed wands. However, it didn't give them the ability to use the wands. This was on purpose, the wands were meant as loot for the player, not an extra threat on already mid and high tier monsters. Placing the items into monster inventory was a bit confusing, players expect monsters carrying wands to be capable of using them; especially with the UI efforts put in to announce monster wands. Since these are meant as pure loot, this commit refactors them to drop on death through the same code path that drops dragon hides. This roughly halves (corpse rng) the rate of wand generation in 2dcde036d21, so the charges dropped are doubled to compensate. -------------------------------------------------------------------------------- f00fe891ef | Kate | 2021-12-06 01:09:34 +0000 Don't allow equipping Lear's with Demonic Touch (Lightli) -------------------------------------------------------------------------------- 1d7427ec22 | Kate | 2021-12-06 00:40:18 +0000 Refactor some breath weapon handling Although it could still use some more streamlining. -------------------------------------------------------------------------------- 1aa8e01074 | Kate | 2021-12-06 00:40:18 +0000 Initialise a variable (geekosaur) -------------------------------------------------------------------------------- ce17e19b79 | Kate | 2021-12-06 00:40:14 +0000 Adjust umbra accuracy and stealth handling Grant players (and monsters) immunity to umbra's accuracy reduction if they're wearing the ring of Shadows, and don't give players a stealth bonus in umbra unless they're emitting it themselves, so Yredelemnul worshippers no longer gain bonus stealth from allied profane servitors (while still avoiding the accuracy reduction). -------------------------------------------------------------------------------- b9e9c7b67e | Kate | 2021-12-05 04:26:43 +0000 Add missing canned messages for some cancelled abilities -------------------------------------------------------------------------------- e2d2f24f2d | Kate | 2021-12-05 04:26:43 +0000 Let Divine Exegesis trigger Battlesphere/Demonic Magic Since it's mostly-but-not-quite a real spell. -------------------------------------------------------------------------------- b3aea5d014 | Kate | 2021-12-05 04:25:00 +0000 Refactor spell-based ability failure timing Fixes Demonspawn Damnation, Beogh Smiting, and Sif Muna Divine Exegesis having fail checks before targeting. -------------------------------------------------------------------------------- 0dbd382bca | Kate | 2021-12-05 04:18:00 +0000 Refactor many ability fail checks Abilities should always be targeted before their fail check, so that they can consistently be cancelled before committing to activating the ability. This commit fixes this issue for a large number of abilities, and removes unnecessary fail checks for abilities that should never fail. A small number of abilities still need further refactoring to move the fail check to take place pre-targeting. -------------------------------------------------------------------------------- 27b72ba42d | Kate | 2021-12-05 04:18:00 +0000 Refactor some abilities to use new targeters Most breath weapons (except for Breathe Acid, which has a more complex targeter), as well as a number of simple targeted god abilities (Makhleb Minor/Major Destruction, Zin Imprison, Okawaru Duel, and Fedhas Grow Ballistomycete/Oklob) now use new ability targeters. -------------------------------------------------------------------------------- 557f2b6704 | Kate | 2021-12-05 04:17:54 +0000 Add more ability targeter handling There should now be full support for targeted abilities to share the new targeting code. Some particularly complex abilities might be difficult to refactor, but many aimed abilities such as breath weapons can now start being moved to use the improved targeters. -------------------------------------------------------------------------------- 46d0310cc0 | Kate | 2021-12-04 22:56:01 +0000 Display ability ranges in their descriptions By adding range to ability_def, in preparation for also using it in ability targeters. -------------------------------------------------------------------------------- 956f0ee3d5 | Kate | 2021-12-04 01:58:07 +0000 Make Demonspawn stingers conflict with regular stingers -------------------------------------------------------------------------------- 482a24a92f | Kate | 2021-12-04 01:30:09 +0000 Give Pikel a new title To match his new(-ish) job trading souls of the damned. -------------------------------------------------------------------------------- d7bf75cbcc | advil | 2021-12-03 18:56:15 -0500 fix: don't use html entities in issue template This didn't work, I don't know why I thought it might. -------------------------------------------------------------------------------- 17ad3ed552 | advil | 2021-12-03 18:53:24 -0500 docs: adjust issue template People seem to be surprisingly incapable of reading and following the "replacing or deleting all italicized text" instructions, so make it easier on them by putting this text in comments. -------------------------------------------------------------------------------- 8383568036 | Kate | 2021-12-03 21:54:34 +0000 Slightly increase Dragon Form fire breath power Draconians in dragon form all get to keep their breath weapons and use them at a power of 2 * XL, but other species (and red draconians) used fire breath at a power of XL + 12 instead. Change fire breath's power to also be 2 * XL for consistency. -------------------------------------------------------------------------------- 82fdf335c4 | Kate | 2021-12-03 21:39:05 +0000 Remove an unused function -------------------------------------------------------------------------------- d6bbb3f436 | Nicholas Feinberg | 2021-12-03 10:54:22 -0800 Rename: traumaturge gloves -> Mad Mage's Maulers The lowercase name felt odd, and also conflicted with a Veh title. Neither were large problems, but neither is a rename, so why not? -------------------------------------------------------------------------------- 3775c662fe | Nicholas Feinberg | 2021-12-02 15:55:11 -0800 Put on my wizard hat (Sastreii) New funny hat tile. -------------------------------------------------------------------------------- 1de4e0787c | Kate | 2021-12-02 01:35:24 +0000 Add static targeters for many abilities Making abilities behave more consistently with regards to targeting is a pretty substantial project, but this is a start for many of the simpler abilities. Currently this only supports static targeters - some limited support for regular targeters has been added, but more work would be required to fully support regular targeters (such as more ability flags to indicate how an ability should be targeted). As with spells, a number of abilities with either full-LOS or limited radius effects are added to the default force_ability_targeter option. -------------------------------------------------------------------------------- 134dc7ce2c | Kate | 2021-12-02 01:35:24 +0000 Remove some unused handling for wand trove tolls (Ge0ff) -------------------------------------------------------------------------------- 945c40ea80 | CanOfWorms | 2021-12-01 18:01:05 -0500 Reduce the average number of items in a shop With the pool of permanent items slowly decreasing over the years, shops have shown a noticeable increase in redundancy with permanent items, such as jewellery stores selling multiple copies of a particular amulet type. In addition, shops can generate with up to 16 items, which creates unnecessary UI clutter. Fix this issue by reducing the average number of items in a shop from 4 + 3d12/3 to 4 + 3d8/3, reducing inventory by 2 items on average. This change also counterbalances a gradual increase in the quantity of consumables available, possibly due to the removal of food and gadget shops. -------------------------------------------------------------------------------- 3664467d6e | mgdelmonte | 2021-12-01 11:04:50 -0800 bugfix: lua moninf_get_flags must init flags Function fails until flags are initialized, which for now only happens if you call `is` first, at least once, with a string. -------------------------------------------------------------------------------- 85d866c40e | robertxgray | 2021-12-01 11:01:39 -0800 Exclude hidden spells from the memorisation tab -------------------------------------------------------------------------------- 79cf1ff08c | Brian Power | 2021-12-01 09:32:09 -0800 hint mode: prevent temporary portals being misindentified as downstairs -------------------------------------------------------------------------------- 8735e2aeb5 | Kate | 2021-12-01 16:52:37 +0000 Adjust some deck descriptions Conveniently also prevents gather_items from claiming that there exists a "deck of at one's foes (or, if unlucky, at oneself)." Probably the script should also be reworked somehow to avoid similar things happening again elsewhere in future. -------------------------------------------------------------------------------- dd2fe8c8b9 | Kate | 2021-12-01 16:40:22 +0000 Add some missing books to gather_items -------------------------------------------------------------------------------- 86362df473 | Kate | 2021-12-01 16:18:20 +0000 Remove some unused handling for book trove tolls -------------------------------------------------------------------------------- 0325d80940 | Kate | 2021-12-01 15:43:42 +0000 Remove an obsolete trove message -------------------------------------------------------------------------------- a7f8b01127 | Aliscans | 2021-11-30 18:38:00 -0800 Remove "const" from the parameter to seen_item(). 751e42844d described removing the const from a reference within seen_item() as a "major hack". 11 years later, fixing this involves removing the const from this function and one additional method, with no changes needed for stack_iterator. -------------------------------------------------------------------------------- 8d97f0daa7 | paul | 2021-11-30 17:37:22 -0800 A couple small barding cleanups I was reading some Palentonga code to try to be less bad as them and came across two things that looked like reasonable cleanups. * Comment in acquire.cc suggests only nagas have increased chance to acquire a barding but I think it applies to palentongas too since it's based off you.wear_barding(). * wears_barding() checks the SPF_SMALL_TORSO flag instead of SPF_BARDING which works because they both apply to the same species but I assume is just coincidental. Tested out trying to wear bardings and acquire a bunch on nagas/palentongas and humans as a control and I don't think I broke anything. -------------------------------------------------------------------------------- 880e0f58e3 | Aliscans | 2021-11-30 17:34:00 -0800 Add "flight" to the stash search prefix for armour "of flying". Searching for "fly" returned any equipment which gives flight, but not potions, and searching for "flight" returned potions and artefacts, but not boots of flying (as "find" searches artefact descriptions, but not ego item ones). This change means that a search for "flight" finds everything. -------------------------------------------------------------------------------- d52952e488 | Martin Kennedy | 2021-11-30 17:29:38 -0800 fix: typo: Correct a typo in the description of the Book of Pain -------------------------------------------------------------------------------- 2dcde036d2 | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Make Swamp a bit more magical Give out guaranteed wands to swamp-exclusive Eleionomae and Fenstrider Witches - on average, about 5 wands per Swamp, about 10% of the total generated over the course of a game. This is intended to be something of a counterpart to the ammo generation in Shoals, and to complement the earlier reduction of wand charge generation. We can increase these numbers farther if need be. -------------------------------------------------------------------------------- cca59f9bd0 | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Update a hacky comment -------------------------------------------------------------------------------- 34a2937e56 | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Reduce mid/late-game wand charges Wands can be a fun and exciting tactical tool. Deciding how much to invest in Evocations to power them up is a cool strategic choice, and limited charges make for tough usage decisions. In the late game, though, most characters will have more wand charges than they know what to do with. This feels bad (picking up essentially valueless wand charges, since you'll never use them up), and makes the game less interesting. To compensate, starting around D:8, halve charge generation for most wands (excepting the already-scarce /digging). Following the earlier reduction in throwing ammo generation, this should hopefully keep wand charge limits more relevant into the late-game. -------------------------------------------------------------------------------- 47ffb9280c | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Erase DROPPER_MID_KEY on pickup So that if you poly a monster (causing it to drop its weapon), the monster picks it up, and you then disarm that monster, they won't pick it up again. -------------------------------------------------------------------------------- f2ff745afe | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Simplify monster pickup logic Now that monsters don't normally pick up seen items, most of this was irrelevant. (And it broke monsters picking up items when poly'd.) -------------------------------------------------------------------------------- 94437a2481 | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Revert "Don't let monsters pick up seen items they've dropped" Broke monsters picking up items after poly. No longer needed after bc3f381ebcfc7bc390c3495e054d1fb84b63bb7e. This reverts commit 2d6b87359491cf4d84fe175b5a7c57c56e3f85ff. -------------------------------------------------------------------------------- 2ccdaddb72 | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Limit explore shafts to 1/branch/game Being shafted is a fantastic experience - it can be hard to survive, but can create truly deep, memorable tactical challenges. However, its charm wears on repeated exposure. Let's limit players to one shafting per branch per game. -------------------------------------------------------------------------------- a7c9fdd7d1 | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Allow shafting the player on stairs Vaguely buggy not to. -------------------------------------------------------------------------------- 86c161e70f | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Retheme explore traps Exploration effects are themed as 'traps', but work quite differently from the features. Rather than existing in fixed locations that the player can stumble into, explore 'traps' have a chance of triggering whenever new terrain is revealed. This commonly occurs when the player goes down stairs, or even without any action from the player at all (when a monster opens a door). Players are frequently (and understandably) confused by this - how did they 'stumble into a teleportation trap' without going anywhere? Instead, attribute these events to an unspecified 'malevolent force', spontaneously causing bad things to happen to the player. This is also intended to offer potential for expansion, allowing new and exciting bad things to happen to the player. (What if the player could be shafted from Depths straight to Hell?) -------------------------------------------------------------------------------- 7bd870e236 | Nicholas Feinberg | 2021-11-30 13:23:02 -0800 Add wizmode explore trap command -------------------------------------------------------------------------------- 12e872d363 | advil | 2021-11-30 10:35:46 -0500 docs: edits to attributes section of manual Mostly, better paragraph breaks. -------------------------------------------------------------------------------- ab84650245 | advil | 2021-11-30 10:07:15 -0500 refactor: wrap Dg species gain in a mutation This is much cleaner than species checks, and lets the mutation menu describe the exact statgain behavior. -------------------------------------------------------------------------------- 42eb19b844 | Nicholas Feinberg | 2021-11-29 21:45:58 -0800 Remove get_stat_gain_multiplier (ebering) Rendered unhelpful by 03ef38a5c2cf. A bolder soul than I can add a MUT_BIG_STATS for demigods, if they so desire. -------------------------------------------------------------------------------- 03ef38a5c2 | Nicholas Feinberg | 2021-11-29 21:40:07 -0800 Give 2 points per attribute choice The attribute choices at XL 3, 6, 9 and so on accumulate into interesting decisions. Being able to shift your character toward a given stat by a total of 9 points over the course of a character can make a real impact. However, each individual choice is almost meaningless - 1 point in any attribute has approximately no impact. To make players' choices meatier and more impactful, shift the choice to only occur every 6th level (XL 3, 9, 15, 21, and 27), and to give 2 points per level-up. This is a minor player buff (attributes are recieved earlier, and 1 more point is receieved total), but we'll nerf em in some other way sooner or later. Hopefully this won't be too confusing. Demigods are unaffected. -------------------------------------------------------------------------------- f78dbcb89b | Nicholas Feinberg | 2021-11-29 21:25:10 -0800 Nerf merfolk impalers/javelineers Javelineers are the deadliest enemy in Shoals, and it's a bit odd that they are. A common nice dynamic in Crawl is that the closer you get to an enemy, the more dangerous they are (so closing in to melee is a risk). Occasionally, we toss in a curveball and have enemies that are neutered in melee, eg centaurs. But javelineers are just consistently deadly at all ranges. That's not awful, but it seems like in melee, other enemies should be nastier. So, drop javelineer damage by 5 (from 27 [with javelin] to 22), and remove 2 EV (14 -> 12) and 5 avg HP (78 -> 73). Also pull back on impalers slightly, as a belated response to melee enemy buffs from weapon delay changes. (Damage with trident down from 34 to 31.) This might make Shoals a bit closer to Snake and Swamp in overall difficulty (varying with character, of course), which seems good. -------------------------------------------------------------------------------- 0ea205dc43 | Nicholas Feinberg | 2021-11-29 21:25:07 -0800 Initialize a variable -------------------------------------------------------------------------------- 2ad3dba794 | Kate | 2021-11-30 03:09:06 +0000 Adjust summon spell targeters Summons can be placed on the other side of grates/statues, so update their targeters to reflect this. -------------------------------------------------------------------------------- 04878082bc | Kate | 2021-11-30 03:04:16 +0000 Don't destroy foxfires/ball lightnings when blocked by grates They could be summoned on the other side of a grate (as with all summons), but would then immediately die - let them keep existing as long as they're not fully out of LOS or on the other side of a wall. -------------------------------------------------------------------------------- ced782017d | Kate | 2021-11-30 02:26:33 +0000 Fix Wall of Briars leaking invisible monster information This would be very difficult to actually come across in practice, but sets the ability up better to use a targeter when that gets implemented in the (hopefully near) future. -------------------------------------------------------------------------------- 9f272a1a52 | Kate | 2021-11-30 01:36:17 +0000 Remove an obsolete comment -------------------------------------------------------------------------------- 1e39a6ef00 | Kate | 2021-11-30 01:36:16 +0000 Don't allow activating Yred animate dead with no targets -------------------------------------------------------------------------------- ee6e0bcda6 | Kate | 2021-11-29 22:33:09 +0000 Remove an unused parameter -------------------------------------------------------------------------------- 2f15ad600a | Kate | 2021-11-29 21:04:17 +0000 Display potion/scroll rarity in item descriptions So that it's easier for newer players to learn their relative generation weights and make better reasoning about identification. -------------------------------------------------------------------------------- 216afd96f5 | Kate | 2021-11-29 21:04:17 +0000 Refactor and standardise potion/scroll generation weights To allow unspoiling some information about consumable generation (particularly in cases where it's relevant to identification), give potions and scrolls a more discrete set of weights. -------------------------------------------------------------------------------- 3c35fc0fc0 | Edgar A. Bering IV | 2021-11-29 17:35:52 +0200 text: further tweak a charge description -------------------------------------------------------------------------------- 72e5a758c0 | Edgar A. Bering IV | 2021-11-29 16:58:12 +0200 text: descriptions for some status lights -------------------------------------------------------------------------------- 17860c6496 | Edgar A. Bering IV | 2021-11-29 12:36:30 +0200 fix: decapitalize -------------------------------------------------------------------------------- 12477afec8 | Nicholas Feinberg | 2021-11-28 21:56:15 -0800 Scale up some tiles (Sastreii) New 'mundane' dragon armour tiles. -------------------------------------------------------------------------------- 140ffa10cf | Edgar A. Bering IV | 2021-11-28 20:28:55 +0200 fix: clarify spell danger prompt (lukem1234) Closes #2230 -------------------------------------------------------------------------------- 4f8b84809c | Edgar A. Bering IV | 2021-11-28 20:22:59 +0200 fix: only merge options different from default (ardl) The feature in 843f935 was implemented by adding merge functionality to the game_option class. Unfortuantely, this led to defaults being loaded from init files (instead of included in the binary) being clobbered as they were not set in the temprorary perf-loaded options. This changes the implementation of merge to only merge entries that were loaded in the source game_options object. The buggy behavior was most notable in how it interacted with the auto_exclude default. -------------------------------------------------------------------------------- 61a4acea3e | Edgar A. Bering IV | 2021-11-28 20:22:23 +0200 fix: remove a duplicate entry -------------------------------------------------------------------------------- bc3f381ebc | Nicholas Feinberg | 2021-11-27 10:51:57 -0800 Remove DROPPER_MID from most monster-dropped items I'm moderately sure this wasn't used for anything. -------------------------------------------------------------------------------- b588e42d88 | Nicholas Feinberg | 2021-11-27 08:49:40 -0800 Remove an antique ID call Monster weapons are now just all auto-ID'd on sight. -------------------------------------------------------------------------------- c5f9a05f81 | Nicholas Feinberg | 2021-11-27 08:49:40 -0800 Flatten monster_drop_things This function is ridiculous. -------------------------------------------------------------------------------- 6df31dea4b | Kate | 2021-11-27 16:24:48 +0000 Fix MP regen rate not being recalculated on amulet removal And let the amulet remain attuned while melded. -------------------------------------------------------------------------------- 3387f7d204 | Kate | 2021-11-27 16:24:48 +0000 Fix some amulet equip/unequip handling Removes some obsolete checks for activating amulets of reflection/acrobat, and makes them also display messaging consistently when unmelding. -------------------------------------------------------------------------------- dde70e7af4 | Edgar A. Bering IV | 2021-11-27 10:20:45 +0200 feat: nerf flame wave damage Flame Wave did calcdice_calculator<3, 10, 2, 5> damage for each blast (at a total cost of 6mp over 3 turns) Compare to some other level 4 damage spells: - Hailstorm calcdice_calculator<3, 10, 1, 2> (more awkward targeting, costs 12 mp to fire for 3 turns) - Mystic Blast calcdice_calculator<2, 6, 1, 3> (also has knockback (for possible knockback damage), easier targeting; still 12 mp to fire for 3 turns) - Sticky Flame calcdice_calculator<2, 3, 1, 12> (also sets them on fire for a time, doing 2d4 per turn extra damage; initial sticky flame damage plus 2 turns of fire damage is the calcdice plus 4d4 for 4mp over 3 turns) At equal training, flame wave can do as much as half the damage of 3 casts of starburst, for 1/3rd the mp. There's targeting awkwardness and the hazard of being adjacent but this damage is just really really good. With 3 dice it is also consistent in its damage output. So let's nerf it to calcdice_calculator<2, 8, 1, 5>. -------------------------------------------------------------------------------- 843f935a50 | advil | 2021-11-26 16:06:07 -0500 feat: save `default_manual_training` in `.prf` files This is more of a proof of concept commit than a complete implementation of this idea that can be generalized immediately to tons of options, but it seems to work well enough and provides a path towards generalized option serialization in .prf files. I chose `default_manual_training` because it already has a UI element that players might reasonably expect to be saved, it involves no custom parsing (just a simple `BoolGameOption`), and because if something goes wrong with the .prf files for it, it doesn't seem too disastrous (because the it's ignored after game start). The .prf files are already used to store newgame options, and are parsed using game_options reading code already, so this change was a matter of figuring out how to coherently write non-newgame options, and pull them in to the Options static in a sensible way. Some notes: * If a player has an option explicitly set in their rc file, it will override the .prf version. This part is written in a general way so it will extend to new serialized options. * The general code only works for options implemented using a GameOption object. Getting it to work for others will need a more effort, including custom handling in the `merge` function and changes to the tracking of what was loaded from an rc. Possibly more options should be converted to `GameOption`s rather than more custom handling being added. * Serialization code is extremely not general, this would be easy + tedious to generalize so I will leave that for when more options are added. * A bunch of boilerplate code is moved to game-options.h. This stuff definitely has the feel of something that ought to be templated, but this doesn't work with the polymorphism needed for GameOption in any way that I have yet found. This commit also adds a generic function to set one GameOption object from another, with a somewhat ugly implementation. (Also should be templated, but I haven't come up with a way yet.) * Most other options will need UI added to do something like this. * It's possible that we should add a game menu command that lets you reset the .prf file before adding too much more to this. -------------------------------------------------------------------------------- 629283d8f3 | advil | 2021-11-26 16:05:36 -0500 feat: api to track GameOptions modified by rc settings This provides a way of checking whether a GameOption subclass was explicitly modified by a player's rc. The eventual point of this to ensure that explicit settings can override an autosaved preference. Obviously, because this is tied to use of GameOption, it does not work on custom-parsed options handled in read_option_line, nor on options that are stored on the lua side. It also doesn't track any changes to member variables of game_options made directly. -------------------------------------------------------------------------------- a3687e240c | Nicholas Feinberg | 2021-11-26 08:46:49 -0800 Fix webtiles AC light for Ignis (Lici) I dislike this code a lot :) -------------------------------------------------------------------------------- eabae20b52 | advil | 2021-11-26 09:18:48 -0500 refactor: unify some seed display code Centralize this in one function with a single approach to checking for player death. -------------------------------------------------------------------------------- eeb059e727 | advil | 2021-11-26 09:18:48 -0500 refactor: lightly generalize newgame prefs code This is just trying to make this options serialization code better, in preparation for later more involved changes. * turn newgame_def-specific code (which is, currently, all of this) into a method on newgame_def * write prefs file on any save * but don't rewrite unless there are changes -------------------------------------------------------------------------------- 1d79628fcd | advil | 2021-11-26 09:18:48 -0500 fix: remove an old #ifdef for seed preferences This originates from when online games didn't support seeded play. Now most servers do in some form and several servers enable the seeded play popup. Removing this #ifdef lets the seed field in this popup be prepopulated with the seed of a recent ended game in online play. -------------------------------------------------------------------------------- 0fd3a81354 | advil | 2021-11-26 09:18:47 -0500 refactor: remove an unused build conditional As far as I can tell this #define and its conditionals have never been used by anyone. The only use case anyone has come up with is shared accounts (geekosaur), but if this is an actual use case that someone wants I'd rather implement it in a different way (e.g. CLO or just a regular rc option). -------------------------------------------------------------------------------- d5e1996cdb | Nicholas Feinberg | 2021-11-25 08:28:35 -0800 Totally blork our tiles (Sastreii) -------------------------------------------------------------------------------- f5b72a5aab | Nicholas Feinberg | 2021-11-25 08:09:51 -0800 Fix Mindburst damage I believe this was broken since monster /disintegration use was first added in 65c148fa03d (2007). -------------------------------------------------------------------------------- a419b9d3f4 | Kate | 2021-11-25 14:09:07 +0000 Adjust gloves of infusion messaging To make it clear that normal gloves of infusion do work for Djinn. -------------------------------------------------------------------------------- 334d32066b | Kate | 2021-11-25 13:58:22 +0000 Add some unrand equip/unequip messages -------------------------------------------------------------------------------- 4693fef7fb | Kate | 2021-11-25 13:57:22 +0000 Fix Djinn instakilling themselves with traumaturge's gloves Luckily they would also crash at the same time as killing themselves, but either way seems less than ideal - prevent the unrand from working for Djinn instead, and adjust pay_mp to consistently use an ASSERT that would normally be used when paying HP for things. Also fixes Djinn crashing when using normal infusion gloves at 2 HP or less. -------------------------------------------------------------------------------- e90d3d521c | Kate | 2021-11-25 12:52:57 +0000 Fix a typo -------------------------------------------------------------------------------- 0b5b508569 | Nicholas Feinberg | 2021-11-24 22:32:20 -0800 Let Nikola hurl Reverts 87e75285439, since it seems very goofy and not particularly pointful. -------------------------------------------------------------------------------- a42776352a | Nicholas Feinberg | 2021-11-24 22:32:07 -0800 Rework archery ego into hurling The archery gloves ego has always been an odd outlier. Giving +slaying to 'ranged combat' (bows, slings, xbows, and throwing) is simultaneously broad and narrow. Why do only those types of combat get an ego to bolster them? Why aren't there gloves of slashing for long and short blades, or gloves of magma for fire and earth magic? We may go that way some day, but for now, let's refocus. Gloves of hurling (replacing gloves of archery) give a bonus exclusively to throwing. Recent reductions to throwing item generation have left throwing weapons in a distinctive position, as a strong but limited-supply killing method. Giving a bonus to that *specifically* could potentially change players' tactics, encouraging them to try hurling a bit more. And that's fun! -------------------------------------------------------------------------------- d9240322ae | Nicholas Feinberg | 2021-11-24 22:28:53 -0800 New unrand: traumaturge's gloves The traumaturge's gloves spend your *entire* MP every time you hit any enemy in melee, giving a proportional bonus to damage. To make them less obnoxious to use, they get RegenMP, and to make them less interesting for characters who don't actually want to hit stuff, they have Int-4. This is in the same vein as rampaging boots and the seven-league boots - they're super-infusion gloves. In practice, I found them to be very funny. Possibly they encourage kiting too much and will need to be cut, but I do want people to get a chance to try them out first. -------------------------------------------------------------------------------- f4b206033c | Nicholas Feinberg | 2021-11-24 22:28:44 -0800 New gloves ego: "infusion" A riff on the old Charms spell of the same name, gloves of Infusion give +0,+4 slaying (that is, +0-4 pre-AC damage per hit) on melee attacks, in exchange for 2 MP spent per hit. This will be appealing for many characters, but will you regret being stuck at 0 MP in a tight spot? Maybe! Numbers are very preliminary. In testing, my main concern was whether it'd cause too much resting, but it didn't seem to be worse than 'caster' characters already have it. Excited to hear feedback from others. -------------------------------------------------------------------------------- cd63401287 | Nicholas Feinberg | 2021-11-24 17:21:57 -0800 Shift vampire knight weapons left -------------------------------------------------------------------------------- c41cc7542a | Nicholas Feinberg | 2021-11-24 16:40:38 -0800 Add some new tiles that really suck (Sastreii) New vampire, vampire knight, and vampire mage tiles. -------------------------------------------------------------------------------- 12fdbb3a91 | Nicholas Feinberg | 2021-11-24 16:33:15 -0800 Buff amulets of magic regeneration The amulet of magic regeneration is generally considered fairly weak. 0.25 MP/turn is not nothing, but it compares pretty poorly to other amulet effects, even for characters that should like it. Adjust it up to 0.4 MP/turn. This is exactly half of the 0.8 HP/turn that regen effects give, which is nice aesthetically. -------------------------------------------------------------------------------- dd814f33f1 | Nicholas Feinberg | 2021-11-24 16:27:46 -0800 Re-adjust Regen properties In c8f691b2cc7, effects that granted Regen (the amulet, artefacts, etc) went from giving 0.4 HP per turn to 1.0 HP per turn, a 2.5x multiplier. Having played with the new, stronger version for a few months, it's clear that high levels of regen are stronger than I anticipated. As such, this commit reduces regen somewhat back down to 0.8 HP per turn. This is still double what it was before c8f691b2cc7, so I expect it should still be an exciting and powerful property, but it should take a little more work to stack regen to such ludicrous levels that enemies have difficulty harming the player. The Robe of Vines goes from 3 HP/turn to 3.2 HP/turn, and loses a point of enchantment in exchange. Most other sources of regen follow the change, excepting Trog's Hand and Powered by Death, which go back to their old flat values (no longer pegged to the regen pip). -------------------------------------------------------------------------------- caa4c314a1 | Nicholas Feinberg | 2021-11-24 16:23:04 -0800 New Ignis ability: Fiery Armour Replacing Sea of Fire for the 'cheap ability' slot, Fiery Armour is a proactive defensive ability, complementing Foxfire Swarm (a reactive offensive ability) and Rising Flame (a reactive escape). When used, Fiery Armour gives +7 AC and 2d4 fire damage to melee attackers. It lasts for somewhere around 120 turns, to help it feel better compared to Foxfire Swarm - the latter straight up wins a fight, so it's nice if Fiery Armour can help with a few fights. (It also provides an incentive not to dawdle, which is fun!) There's a special message when you use it with Ozo's Armour, Icemail, or Ice Form, as a bit of a lampshade. -------------------------------------------------------------------------------- 68fc8d02d3 | Nicholas Feinberg | 2021-11-24 16:08:43 -0800 Remove Sea of Fire Ignis's Sea of Fire was a very visually cool effect, but it had no clear purpose. It wasn't clear when players should use it - the most common experience was for players to use it once, get trapped by it, feel extreme regret, and never use it again. Let's replace it with something with a greater clarity of purpose. -------------------------------------------------------------------------------- 796cbd3a86 | Edgar A. Bering IV | 2021-11-23 23:44:01 +0200 text: two new Donald speech lines -------------------------------------------------------------------------------- 9e5967653d | Edgar A. Bering IV | 2021-11-23 23:32:31 +0200 text: add a slimify quote (Ge0ff, 12661) -------------------------------------------------------------------------------- 59e3c9d8a8 | Kate | 2021-11-23 21:16:12 +0000 Don't crash on alerting dead monsters to acid damage (#2240) Closes #2240. -------------------------------------------------------------------------------- 0406aca7d3 | Nicholas Feinberg | 2021-11-22 17:05:57 -0800 Update mut math -------------------------------------------------------------------------------- 2a66bcaeff | Kate | 2021-11-23 00:06:24 +0000 Add a Jiyva ability: Oozemancy (acid ramparts) With Slimify as the only active ability, Jiyva could use something new to spend piety on, especially since the god is intended to have rapid piety gain. Oozemancy is granted at 3*, has a relatively high piety cost, and temporarily turns nearby walls (within radius 4) into slime-covered walls. It has no movement restriction like Frozen Ramparts, but slime walls don't deal damage outside line of sight. -------------------------------------------------------------------------------- 5b0ebec07e | Kate | 2021-11-23 00:06:24 +0000 Increase Slimify's MP and piety costs Jiyva has rapid piety gain, and Slimify is mostly an irresistible instant kill, so it should be pricy. -------------------------------------------------------------------------------- 738adcbc29 | Kate | 2021-11-23 00:06:24 +0000 Move some Jiyva passives earlier Move rCorr from 3* to 2* (since it's mainly flavour, and to free up the 3* slot for a new active ability), and move the jelly-on-hit effect from 6* to 5* (since 6* is generally reserved for one-off capstone effects or gifts. It was also already displayed as available at 5* despite not yet being in effect). -------------------------------------------------------------------------------- 12af580f8b | Kate | 2021-11-23 00:06:20 +0000 Change Jiyva's piety gain to be from exploration Gaining piety from sacrificing items was flavourful but didn't function well in practice, since it encouraged going back to old floors upon converting to Jiyva to sacrifice junk items and gain piety quickly. Jellies eating items becomes strictly a conduct to encourage moving forward quickly, and Jiyva's piety gain is changed to be from normal exploration, but at a much faster rate than other gods to compensate for the fact that the god is generally picked up late. Since jellies eating items is now a conduct rather than a method of piety gain, also remove the ability to call a jelly, and don't immediately place a jelly on conversion. -------------------------------------------------------------------------------- 60ee69b403 | Kate | 2021-11-22 21:08:41 +0000 Make Jiyva's Cure Bad Mutation a passive part of mutation gifts Being able to remove mutations at will doesn't fit with the god's theme, overlaps with Zin's specialty, and isn't necessary with the god no longer gifting bad mutations. Instead increase the chances of Jiyva removing bad mutations via mutation gifts, to help dealing with mutations from external sources (since potions will be less effective with big mutation sets). -------------------------------------------------------------------------------- c8825b9f11 | Kate | 2021-11-22 21:08:41 +0000 Don't let Jiyva gift bad mutations Since having a bad mutation maxed out by a god gift would be particularly unpleasant (or act as a large piety tax requiring repeated use of the ability to remove it again), just grant good/slime mutations. -------------------------------------------------------------------------------- f2b78a14d2 | Kate | 2021-11-22 21:08:25 +0000 Update some options_guide entries -------------------------------------------------------------------------------- cca88958be | advil | 2021-11-22 09:31:19 -0500 fix: don't allow spell memorisation in tiles map view Another extension of 904a573f8967; spell memorisation isn't designed to happen in this UI mode and so while it *seems* to work, I suspect there could be unintended consequences. This should be everything that takes time disabled. This commit also adds an i_feel_safe check for whether memorise buttons are enabled. (I believe before it would have prompted, but just outright disabling them gives clearer UI I think.) -------------------------------------------------------------------------------- 2ecf54ff0b | advil | 2021-11-22 09:19:49 -0500 fix: disable tiles item buttons in view map mode This extends 904a573f8967; don't allow things to happen in map mode that aren't designed for it and may have buggy behavior. This commit isn't very subtle, just check map mode directly. Resolves #2236 -------------------------------------------------------------------------------- f7baa44570 | advil | 2021-11-22 08:50:51 -0500 fix: add a missing negation Missing since 70de9b6695476e, but I guess no one uses the "cast a spell" button itself. 904a573f89 made spell-specific buttons enabled or disabled depending on whether casting is allowed via this check, revealing the bug. Resolves #2237 -------------------------------------------------------------------------------- 6e5f11bd55 | advil | 2021-11-21 23:12:20 -0500 fix: improve the ASSERT from 4f857bc58ec395c Don't crash during tests or scripts. -------------------------------------------------------------------------------- 805c5ecd05 | Nicholas Feinberg | 2021-11-21 19:35:07 -0800 Fix bribe branch costs Broken in 2eadbcdadce4. -------------------------------------------------------------------------------- 5e322aebe8 | Kate | 2021-11-21 21:26:22 +0000 Remove a reference to Zin divine sustenance When save compat is broken, at least. -------------------------------------------------------------------------------- 4f857bc58e | advil | 2021-11-21 15:38:21 -0500 fix: don't fire tracers on LRD validity check This is a somewhat nasty bug that triggers when returning to the main menu after playing; because there is still a map kicking around, when trying to check if LRD is valid, the LRD setup code fires off some tracers in that map, leading to bad memory access. I'm 90% sure this is without manually inserting the ASSERT here. (But llvm is usually "better" about not crashing on bad memory accesses.) My approach here was pretty brute force: I didn't see how to make the LRD setup code safe so I just force-validated it. Even on the clean startup case, it's still interacting with suspect memory regions, even if it never fires tracers. Possibly env stuff ought to be cleared up in _reset_game() so that the global state during startup steps is more predictable. In general, I wonder about the rest of the monster spell setup code triggered in this init step... Resolves #2168 (probably) -------------------------------------------------------------------------------- 61c88513d0 | advil | 2021-11-21 14:32:11 -0500 fix: set ui_root.needs_paint after a resize This resolves #2218. The proximate issue seems to have been that resizing with ctrl-command-f both exits the menu and triggers a resize event, which is handled immediately when pump_events is next called during; this is immediately on displaying the game menu. Something about being the first event was messing up the repaint. I'm not sure what. Beyond that, I think there is still something weird going in the ui.cc code for this case: in my testing on a large monitor I see a brief flash of a very strangely resized window before the new size takes hold. Unfortunately I don't understand ui.cc well enough to have any sense of what might be doing this. -------------------------------------------------------------------------------- 88c7259194 | advil | 2021-11-21 13:36:48 -0500 feat: turn the map view button into a toggle Right now this command uses the same tile as CMD_DISPLAY_MAP; possibly someone could add an x to it or something to differentiate them. -------------------------------------------------------------------------------- 904a573f89 | advil | 2021-11-21 13:36:48 -0500 fix: disable most tiles buttons in map view All sorts of stuff was semi-clickable in map view, e.g. you could cast spells or use abilities via local tiles buttons. This commit tries to be more consistent about it: anything that works in KMC_LEVELMAP can work, and anything that doesn't, can't. It's possible that this disables some useful stuff that can work (even if it isn't designed to) that tiles players will be used to? We'll see if there are complaints... -------------------------------------------------------------------------------- 820883e265 | advil | 2021-11-21 13:36:27 -0500 fix: handle button commands in map view (local tiles) There were two interrelated bugs here: command handling was simply unimplemented (a key was returned by tiles code, but the widgetified version of the map UI ignored it), and any clicking (including on buttons) was interpreted as dungeon clicking, moving the cursor to a clamped map position. I guess this probably just fell through the cracks when the map view was widgetified. At least because of the new API, we can now pass the command directly to the map view, rather than needing to pass a key. I've implemented this with an unappealing dynamic_cast, someone may want to do something nicer here. Resolves #2087 -------------------------------------------------------------------------------- b27f3f0c18 | advil | 2021-11-21 10:12:49 -0500 feat: refactor debug build autowiz with an options default Previously, when working with a debug build, to get a truly non-wizard character you had to rebuild entirely (either switch to a different build, or comment out the wizard mode setting in startup.cc). Suppress wizmode is still not perfect, and it is useful to be able to start a regular character from time to time. This commit reimplements the auto-wiz feature so that instead of a debug build simply forcing wizmode directly on character creation, a debug build defaults the `wiz_mode` option to `yes` instead of `no`. (N.b. this doesn't override the logic in a dgamelaunch build.) This lets a debug build respect `wiz_mode=no` (or `never`) in an rc file. -------------------------------------------------------------------------------- b23a865559 | advil | 2021-11-21 10:03:29 -0500 fix: trigger tiles layout on chaging wizmode Now that wizmode activates some abilities, this needs to relayout each time status of wizard or suppress_wizard changes. -------------------------------------------------------------------------------- bdc701c526 | advil | 2021-11-21 09:56:15 -0500 fix: generalize some relayout code from rings In the past, it seems that evokable abilities were mostly confined to rings, and so the code that checked for ability changes was only done when putting on a ring. This commit generalizes the (extremely brute force) check so that it happens whenever any equip is added or removed -- so this should handle scarfs of invis, unrands that have abilities, etc. Resolves #1754 -------------------------------------------------------------------------------- ab553e919e | advil | 2021-11-21 08:14:08 -0500 fix: bring morgue_dir more in line with save_dir For some reason morgue_dir is set and initialized in a slightly different way, so the changes in 381dff06d7c didn't affect morgue_dir quite right. This unconditionally resets it to its default value if `reset_paths` is called. For unclear reasons, this one will get overridden by SysEnv in fixup_options, and I have left this fairly ancient behavior intact. Further resolves #2192 -------------------------------------------------------------------------------- c8d7bad45d | Kate | 2021-11-21 00:16:52 +0000 Add messaging for gaining Jiyva's bonus regen Unfortunately can't be handled via the normal gain/loss messaging since it also has special handling for display on the ^ screen. -------------------------------------------------------------------------------- 7dab3e9f5c | Kate | 2021-11-21 00:16:52 +0000 Remove a reference to Jiyva stat shuffling -------------------------------------------------------------------------------- ae16bb6c82 | advil | 2021-11-20 14:42:41 -0500 feat: reveal init.txt in finder on mac This is a super quick, OS-specific, implementation of this feature, in part just because I realized that on mac it is a 1-liner. It is triggered from the game menu. As noted in the comments: * someone should implement this at least on windows, maybe linux if that's feasible. Probably won't be me though. * might be handy from the main menu somehow, though not in that menu directly (it has no more space). So I'm not sure what the UI is exactly. -------------------------------------------------------------------------------- 8add94bf39 | Kate | 2021-11-20 17:46:13 +0000 Give living spells a summon cap of 6 Mainly to prevent them from filling up LOS in cases where they're sticking around for a few turns without being able to fire for whatever reason. -------------------------------------------------------------------------------- 29138dbd66 | Kate | 2021-11-20 17:46:04 +0000 Allow living iceblast spells to blow themselves up again With ugly special-casing in beam.cc rather than by marking them as non-threatening monsters. -------------------------------------------------------------------------------- c155b14c34 | Kate | 2021-11-20 17:02:34 +0000 Don't mark living spells as non-threatening Since they are definitely dangerous, and marking them as non-threats causes targeting issues with some spells. -------------------------------------------------------------------------------- 381dff06d7 | advil | 2021-11-20 11:32:37 -0500 fix: resequence rc directory setting Previously, when setting `crawl_dir` in an rc, the following sequence of events would happen: 1. crawl_dir gets set to a default value (e.g. a ~/Library directory on mac.) 2. reset_options initializes save_dir based on this crawl_dir. 3. crawl_dir changes (stored in static SysEnv) 4. a. maps are loaded, des cache is built in the save_dir set in 2 b. game menu is also initialized from this save_dir 5. player starts game, triggering another reset_options. Now the save_dir is set based on the crawl_dir in 3, instead of 1. This is what we want, but: 6. No des cache in the current save_dir, so the game crashes any time levelgen is triggered The main change in this commit is to do the path resets from step 2 any time `crawl_dir` is set, so that the save_dir can't get out of sync like this. There's a bunch of refactoring that I did while working on this, some of which didn't end up being necessary but I kept because it seemed cleaner. This commit also explicitly rechecks for a data directory if crawl_dir changes (since the data directory could be under crawl_dir, though it's not in most cases I think). The overall directory handling code is pretty insane but it's covering so many special cases across multiple platforms that it's a bit hard to refactor safely. This commit also adjusts the documentation. Partly this is to indicate this change (since setting save_dir before crawl_dir gets overridden), but partly this is just to make it more accurate. Unfortunately I couldn't really even figure out how the defaults are interpreted outside of mac, so more accurate -> more vague in this case. Someone could try to make this more specific, especially for the defaults for `crawl_dir` and `macro_dir` -- it would be best to explicitly list the defaults for each of win/mac/linxu. I think based on the report in #2192 it might use the current directory on linux for crawl_dir? Resolves #2192. -------------------------------------------------------------------------------- ba3a78600c | Kate | 2021-11-20 15:33:36 +0000 Shorten some mutation descriptions So that they still fit on one line with the new mutation menu interface. -------------------------------------------------------------------------------- aee5879d26 | Kate | 2021-11-20 14:58:06 +0000 Fix Manifold Assault targeter leaking invisible monster locations -------------------------------------------------------------------------------- 3304299650 | Kate | 2021-11-20 14:58:06 +0000 Print wounds when monsters collide with each other Usually via Gell's Gravitas, so that it's easier to see what the spell's effects are. -------------------------------------------------------------------------------- 241ead5b78 | Edgar A. Bering IV | 2021-11-20 13:39:25 +0200 fix: destaticify mangrove colour We really don't want a global colour for the mangrove feature picked by the values _etc_mangrove is called with the first time it gets invoked. -------------------------------------------------------------------------------- 80cf8599ee | Nicholas Feinberg | 2021-11-19 20:38:51 -0800 Fix amnesia/negative levels (CarefulOdds) When amnesiaing a spell with negative levels remaining (e.g. after breaking an Ashenzari Spellcasting curse), print the correct number of spell levels you'll have left afterward. -------------------------------------------------------------------------------- 5db232d3bc | Nicholas Feinberg | 2021-11-19 18:40:05 -0800 Give Jiyva passive HP and MP regen Following on from 3b57ee21721, give Jiyva passive HP and MP regen. This is intended to synergize with the item-eating conduct to encourage the player to rush through levels before all the good stuff is eaten (using fast regen to minimize resting time), while also being an overall buff to the god's strength. (As a god that's somewhat harder to get than normal temple gods, Jiyva should be strong once reached, especially earlier.) This currently gives one pip of HP and MP regen (1 hp/turn, 0.25 mp/turn) at 1* piety, scaling to double that at 6* piety. Numbers can be adjusted as appropriate. -------------------------------------------------------------------------------- facf16e111 | Nicholas Feinberg | 2021-11-19 18:40:05 -0800 Make J give mutations in bursts Jiyva has historically given very frequent mutation changes. Their frequency made them less impactful: since they vanished so quickly, their impact on play was generally limited. Instead, make J give mutations at roughly 1/4th the frequency. In each gift, all mutations have a 25% per-level chance of losing a level. Then 4 new mutation levels are given out, proceeding through one mutation at a time before maxing it out and choosing another. This will let players explore the top-level effects of muts (normally unseen) and enjoy them for a while before they fade away. On average, going from 60 to 200 Jiyva piety caused 3-4 of these gifts. I expect we'll want to tweak this frequency in response to playtest feedback. -------------------------------------------------------------------------------- 53b1d5cb3f | Nicholas Feinberg | 2021-11-19 18:40:05 -0800 Remove Jiyva hp/mp from item eating Jiyva healing from item eating was strong and flavourful, but encouraged goofy tactics, like carrying around stacks of arrows to drop one-by-one for healing. We can provide both strength and delicious jelly flavour by other means, so let's. -------------------------------------------------------------------------------- 05814a4f1e | Nicholas Feinberg | 2021-11-19 18:40:05 -0800 Small cleanups Fix a typo & remove a duplicated check. -------------------------------------------------------------------------------- 278d75afea | advil | 2021-11-19 20:20:23 -0500 fix: correctly interpret `~` in crawl_dir etc In most cases, this was just getting used for its string value, leading to the creation of subdirectories named `~/`, pretty amazing. For some uses of `SysEnv.crawl_dir`, `_resolve_dir` was getting correctly called on subdirectories, leading to probably inconsistent directory patterns, but I'm not sure of the details. The directory handling code here is very confusing. -------------------------------------------------------------------------------- 754df0dcc8 | advil | 2021-11-19 20:09:53 -0500 fix: correctly handle map_load_exception for temple generation This can happen if something is wrong with the des cache, or the des location. Without this fix it triggers uncaught exception behavior, probably a cryptic abort trap. -------------------------------------------------------------------------------- 61ead9eb7d | Nicholas Feinberg | 2021-11-19 15:05:37 -0800 Remove minotaurs from Depths (again) -------------------------------------------------------------------------------- 8af684f10f | hellmonk | 2021-11-19 15:05:33 -0800 Improve the monsters in some overflow vaults Overflow vaults with a uniq_altar tag can place in Depths. Some of these vaults place very easy monsters, like goblins with spears, which are suitable for the overflow altar range but not suitable later. This commit either adds an alternative monster set for Depths placement or limits the range of the vault to dungeon only, depending on which method seemed best. Closes #2215. -------------------------------------------------------------------------------- 8cecda6153 | Nicholas Feinberg | 2021-11-15 17:35:42 -0800 Give orb guardians a glow up (Sastreii) -------------------------------------------------------------------------------- 58c29a6370 | Nicholas Feinberg | 2021-11-15 14:29:57 -0800 Fix Degeneration & Xom polymorph These were broken in 6ee961360c27e and functioned identically to /poly. -------------------------------------------------------------------------------- e64d6db94f | nicolae-carpathia | 2021-11-14 23:02:05 -0500 Add a selection of vaults to various places (#2172) * Add a diverse assortment of vaults in various places Add vaults of all kinds. Vaults for ecumenical and overflow altars, shop vaults, floats, mini_features, mini_monsters, a serial vault, a trove layout, a Hell entry, and vaults for Crypt, Lair, and Hell. They're all here and ready for visitors. Next time I should really break these up into separate pull requests. -------------------------------------------------------------------------------- 41a590f754 | Nicholas Feinberg | 2021-11-14 17:43:17 -0800 X gonna give [a new tile] to ya (Sastreii) New orb guardian tile. We'll always remember the original, and by the original I mean the original original one that was literally a floating fetus. -------------------------------------------------------------------------------- d8f344a91d | Implojin | 2021-11-15 00:30:19 +0000 fix: really end engulf upon polymorph At present, the bug described in #1935 still occurs in trunk. dd09596130 made an attempt to fix this, but clear_far_engulf() only applies to non-adjacent monsters by default. This commit forces the engulf removal upon monster polymorph, hopefully fixing the bug. -------------------------------------------------------------------------------- 8f7a205945 | Kate | 2021-11-15 00:06:13 +0000 Move Cheibriados Bend Time to 1* In general, gods should require some initial investment before granting abilities, and this has been changed recently for various other gods. Cheibriados had Bend Time granted at 0* intentionally since the god is fairly challenging and does immediately slow the player, however it's also not very likely to help much on initial worship, with its success rate depending on piety and invocations skill. Instead swap it with the poison-slowing passive (which has a decent chance of being helpful early), and move Bend Time to 1*, at which point it's more likely to be usable. -------------------------------------------------------------------------------- 8c1bd5eb55 | Kate | 2021-11-15 00:06:13 +0000 Give Trog berserk a piety cost Outside of historical inertia, there wasn't really any good reason for such a strong ability to have no piety cost at all. Giving Berserk a small piety cost won't affect the strength of the god or berserker background in a particularly significant way, but should at least slightly slow down early piety gain. -------------------------------------------------------------------------------- 81a577e8d6 | Kate | 2021-11-15 00:05:11 +0000 Give Dowan permanent haste on Duvessa's death Dowan already gained the Haste spell and an immediate haste enchantment, so this is a much less significant change than Duvessa's permanent berserk, but upgrading the haste to permanent at least saves him from needing to recast it. -------------------------------------------------------------------------------- 0e04eb73d5 | Kate | 2021-11-15 00:05:11 +0000 Allow Death Channel to work on demons and holies To allow necromancy some further application in areas where it's generally weaker, and for thematic consistency with Yredelemnul's Enslave Soul, allow it to create spectral demons and holies, and to also work on living creatures that don't leave a corpse. -------------------------------------------------------------------------------- f87a654afa | Aliscans | 2021-11-15 00:01:10 +0000 Remove a redundant "your" from a message. The item_name variable in _equip_weapon_effect() uses DESC_YOUR, so doesn't need "your" to be added later. -------------------------------------------------------------------------------- 80664f265d | Nikolai Lavsky | 2021-11-14 23:59:42 +0000 fix: let Beogh's Smite set ally targets Also, tweak Smite's damage message to include attack strength punctuation. -------------------------------------------------------------------------------- bbce81c95b | Nicholas Feinberg | 2021-11-14 12:25:10 -0800 Make a quick tile swap (Sastreii) New Quicksilver Elemental (not ooze!) tile. -------------------------------------------------------------------------------- 8b9cc49659 | Nicholas Feinberg | 2021-11-13 18:40:21 -0800 Enrage the Bear Spirit As a follow-up to e692aea80228c, make the Hat of the Bear Spirit's new *Rage also buff berserk rage. While wearing the hat, berserk will give +100% HP (normally +50%), and the slow duration afterward is reduced by 1/3rd. In compensation & to simplify, remove the rN. Possibly it should only have one of these buffs, but I liked them both, so in they both go. (Also possible some other hat props should get tossed.) -------------------------------------------------------------------------------- 09de17f5b5 | hellmonk3 | 2021-11-12 21:43:11 -0500 dezombify saegor_arrival_fortress -------------------------------------------------------------------------------- aed13ad2c0 | Kate | 2021-11-13 02:30:43 +0000 Slightly randomise Beogh's Smite piety cost It was fixed at 3, but as a rule piety costs are randomised slightly to prevent tracking exact piety values, so give it a randomised cost of 3-4 piety. -------------------------------------------------------------------------------- ac13b58d08 | Kate | 2021-11-13 02:13:27 +0000 Remove charge count display for wands from \ menu Since showing max charges per wand isn't useful any more. -------------------------------------------------------------------------------- 0713323be1 | Kate | 2021-11-13 02:13:27 +0000 Let Noxious Bog be generated with 1 adjacent solid tile Instead of requiring zero adjacent solid tiles. The limitation still prevents the spell from being used in corridors and very enclosed areas, but allows it to be a little more effective in unevenly-shaped spaces. -------------------------------------------------------------------------------- 9a1a4af6a0 | Nicholas Feinberg | 2021-11-12 16:54:48 -0800 Necrotize putrid mouths (Sastreii, CanOfWorms) -------------------------------------------------------------------------------- fc338a8e3c | hellmonk | 2021-11-11 22:35:21 -0500 re-remove a description -------------------------------------------------------------------------------- 52b40a1e3f | MainiacJoe | 2021-11-11 22:31:36 -0500 feat: a zoo-themed Lair entry vault (mainiacjoe) did a little syntax cleanup; this closes pr 2140 -------------------------------------------------------------------------------- b979743d38 | Perry Fraser | 2021-11-11 19:02:29 +0000 fix: typo in mut description for slowness -------------------------------------------------------------------------------- c3dbe4743c | Kate | 2021-11-11 19:01:52 +0000 Fix Englaciate lasting 10 times too long on players No monsters actually cast it, but this appears to have been broken since it was implemented as a monster spell in 8e67a19276. -------------------------------------------------------------------------------- b106dbac18 | Kate | 2021-11-11 19:01:45 +0000 Give Metabolic Englaciation a minimum duration The effect's duration was scaled down by monster HD, which could often result in a monster being affected but only for an extremely short duration. Let monsters still fully resist the effect in the same way, but guarantee a minimum duration for monsters that don't resist. -------------------------------------------------------------------------------- e9a2b5622a | Kate | 2021-11-11 18:08:37 +0000 Consistently redraw EV/SH values when incapacitated -------------------------------------------------------------------------------- 6f72491a82 | Kate | 2021-11-11 15:58:20 +0000 Don't let sleeping monsters try to use shields Fixes an oversight in merging cannot_move and cannot_act. Closes #2214. -------------------------------------------------------------------------------- 47ca5a425f | Perry Fraser | 2021-11-11 15:58:19 +0000 Refactor actor::cannot_move into actor::cannot_act With the change in 7190d3f, player::cannot_move and player::cannot_act became equivalent. This was in addition to the monster versions of those methods also being equivalent, which meant we can remove the super versions of them. This also corrects one instance where the lack of checking for sleepiness in player::cannot_speak was relied on to enable talking while sleeping. -------------------------------------------------------------------------------- 0321f2dd10 | Perry Fraser | 2021-11-11 15:58:19 +0000 Fix: consider the player unable to act while asleep Being asleep wasn't considered a condition in being unable to move, which led to issues like not having your evasion reduced while asleep. I investigated this after causative mentioned it in #crawl. [Committer's note: adjusted commit message.] -------------------------------------------------------------------------------- 2d8be16583 | Kate | 2021-11-11 11:54:11 +0000 Fix Cold Breath description (#2220) Closes #2220. -------------------------------------------------------------------------------- bb0bd99bb4 | Kate | 2021-11-11 11:46:05 +0000 Fix Yara's Head Instructor not having a description -------------------------------------------------------------------------------- 1a73be5ee4 | Kate | 2021-11-10 22:19:32 +0000 Let Noxious Bog affect the player's current tile Since you're now immune to it while active, there's no need to leave the player's current square unaffected. -------------------------------------------------------------------------------- 84f7f7b7e7 | Kate | 2021-11-10 21:35:48 +0000 Properly cancel Noxious Bog on level transition The terrain already expired on changing floors, but the duration lingered, which prevented recasting the spell on a new floor until it timed out. -------------------------------------------------------------------------------- 7b4740d1af | Kate | 2021-11-10 21:35:48 +0000 Don't mark rCorr useless with temporary rCorr active -------------------------------------------------------------------------------- 025dcb77dc | Nicholas Feinberg | 2021-11-10 11:30:18 -0800 Fix tentacle corners (Goratrix, dilly) Broken by 325244837d3070345b97a7eb4a78b7e1acbdd791. (There's probably a better fix.) -------------------------------------------------------------------------------- f98f3959e3 | Nicholas Feinberg | 2021-11-10 10:10:17 -0800 Devour hungry ghosts (Sastreii) Replace the old Putrid Mouth tile with a new one. -------------------------------------------------------------------------------- 1410851fad | advil | 2021-11-10 09:32:27 -0500 build: add a test placeholder This is a brute-force way of trying to figure out whether various DGL setups will copy subdirectories of webserver. -------------------------------------------------------------------------------- 0121872642 | Kate | 2021-11-10 01:03:09 +0000 Remove the Orb's effect on contamination Contamination is now much less a common status that players need to manage, and more a rare effect from miscasts and specific abilities/items. As such it no longer makes as much sense for the Orb to have a special (and fairly minor) interaction with it. If any special interaction is still desired, it'd be better to increase contamination received rather than to just reduce dissipation slightly. -------------------------------------------------------------------------------- 08208c227e | Kate | 2021-11-10 00:50:16 +0000 Adjust invisibility costs and contamination To simplify the effect and its costs, remove the contamination over time, and reduce the initial contamination for activating the ego. As with Irradiate, the darkgrey to lightgrey threshold is now also the threshold at which activating the ability again might cause yellow contamination. Increase the drain cost slightly to further penalise using it at lower success rates, and to make it less likely that the kills during the effect can quickly counteract the draining. Also remove the contamination from invisibility beams, since wands of invisibility are long gone. -------------------------------------------------------------------------------- 1d1595ee42 | Kate | 2021-11-09 13:39:08 +0000 Remove Invisibility as a player spell Invisibility is a very powerful effect, and has multiple sources (spell, potion and scarf ego). The spell is by far the most easily repeatable of these, making it much stronger and less interesting to make effective use of. The scarf still remains as a non-consumable source of invisibility, but is better balanced by the additional drain cost. -------------------------------------------------------------------------------- 1135068088 | Kate | 2021-11-09 13:39:08 +0000 Give Beogh orcs more health when surrendering Previously hostile orcs had a chance to convert when a Beogh-worshipping player would kill them, but were only given 1-4 health back so were likely to immediately die to any other nearby hostiles. Increase the healing up to a larger portion of their max health to make this less likely, especially when converting higher tier orcs or uniques. -------------------------------------------------------------------------------- e8106a3eec | Kate | 2021-11-09 13:39:08 +0000 Don't let hostile monsters level up Restrict levelling up to only divine allies (specifically to Beogh orcs, since undead can't level up anyway). This behaviour was barely noticeable otherwise, except in occasional cases of charming a monster and having it kill something else. -------------------------------------------------------------------------------- b444dcf96d | MainiacJoe | 2021-11-08 21:35:08 -0800 Add nine large Temple maps with 18-21 gods Closes #2124. -------------------------------------------------------------------------------- 2a3509429d | MainiacJoe | 2021-11-08 21:34:15 -0800 Expand label for category <<3>> to twenty altars -------------------------------------------------------------------------------- 923ab73998 | Nicholas Feinberg | 2021-11-08 11:54:20 -0800 Make Ignis less mad at non-worshippers (nicolae) -------------------------------------------------------------------------------- 68644deec8 | advil | 2021-11-08 09:30:15 -0500 feat: add some text to the chargen pseudo-milestone This is not a real milestone (it isn't saved, or written to the milestones file) -- it's only used in the webtiles lobby. So it should be fine to add some informative text to it. -------------------------------------------------------------------------------- 6ef7baa362 | advil | 2021-11-08 07:41:47 -0500 feat: transmit milestones/where info over webtiles sockets In order to update the lobby, the webtiles server needs various bits of information about ongoing games. Previously, this information was transmitted via 0-2 distinct channels: the .where file in the morgue directory, and the milestone tailing. (The 0 is because on just a plain `WEBTILES=y` build, where/milestone info was just extremely unreliable, and milestones weren't sent at all as far as I can tell.) This commit refactors things so that where info and milestones can just be sent directly to the webtiles server over the socket connect, rather than increasing the I/O load. (Probably not impactful on most servers, but possibly actually matters on CAO.) This change also simplifies client/server communication quite a bit. For versions with this patch, the webtiles server does not need to tail the milestones file, and does not need to read .where files at all, simplifying configuration as well. We do keep these capabilities around for legacy reasons, as I expect to backport this a bit but not very far back. Specific notes: * The crawl process still writes a .where file if DGL_WHEREIS is defined. This is necessary for dgl setups, but probably could be dispensed with otherwise. * If a crawl process sends direct where/milestone info, the server will stop paying attention to the indirect versions. This should make using older versions fairly seamless. * On the webtiles server side, some light refactoring so that milestones and wheres use the same code, moreso than before at least. * The last milestone is saved in a prop so that it can be shown when reloading, and explicitly synced on game start. (Previously it was just a static variable that was not saved.) * An explicit where is sent directly during character generation. -------------------------------------------------------------------------------- 06939e2a5b | advil | 2021-11-08 07:41:47 -0500 refactor: further refactor lobby sync * Dispense with caching the lobby_entry() result; if this needs to be cached it could be cached on ProcessHandler object itself (but I suspect it's not very important). The global state is now just a set of games with known stale lobby entries. * separate out lobby updating from the asynchronous loop code; this is just to make it easier to understand and refactor in the future. * Use a queue-then-flush paradigm, rather than send everything at once. This should do a better job of batching the message traffic. * Better avoid race conditions in case of asynchronous calls -------------------------------------------------------------------------------- 592c3b7cb7 | advil | 2021-11-08 07:41:47 -0500 refactor: do lobby updates on a schedule Previously, every time any game changed state in a way that would affect the lobby, the lobby update function was called immediately. This, so far as I can assess this sort of thing, scales quite poorly with the number of active players and the number of lobby viewers. The amount of data was still quite small, but the amount of send_message calls, it seems, was not. This commit refactors lobby updates to be sent all at once, by default every 2 seconds. The idea is put a configurable bound on the amount of traffic involved in lobby info, where lower-traffic servers could set this much lower (e.g. 1 or 0.5), and higher traffic servers could tweak upwards as needed. It should be mentioned that truly profiling webtiles in live situations is basically impossible as it stands, so this commit is based on some level of guesswork. It's also not tested yet in a real live situation. -------------------------------------------------------------------------------- b054d885db | Nicholas Feinberg | 2021-11-07 20:14:21 -0800 Remove Jiyva's stat shuffling It seems to have been meant as a perk, but it was pretty frequently detrimental to the player - not in the fun way of systems that encourage one to adapt to circumstances, but just in an overly complex and busted way. -------------------------------------------------------------------------------- fb90bdcb57 | Kate | 2021-11-08 02:35:31 +0000 Remove Disjunction's contamination cost It's not really necessary for balancing the spell - contamination is supposed to prevent recasting multiple times, but the cost was low enough that it could already be recast a lot of times before risking yellow glow, and it's high level enough that the MP cost works fine to prevent continuous recasting. -------------------------------------------------------------------------------- f37d360483 | Kate | 2021-11-08 01:03:24 +0000 Update a comment -------------------------------------------------------------------------------- 1b360eb39e | Kate | 2021-11-08 00:22:24 +0000 Add targeters for Silence and Liquefaction -------------------------------------------------------------------------------- 8d5f0ca64a | Kate | 2021-11-08 00:15:08 +0000 Display current/max level on mutation descriptions (Mike) -------------------------------------------------------------------------------- 00180f5fcc | Kate | 2021-11-07 22:02:19 +0000 Remove obsolete identification checks for reflection -------------------------------------------------------------------------------- ac2d178426 | Kate | 2021-11-07 21:58:13 +0000 Don't let Yred try to reflect reflected splash damage Fixes a crash when the player reflects a yellow draconian acid breath attack, it hits a monster, splashes back onto the player, and Yred tries to mirror that damage back onto a dummy monster that represents the player. -------------------------------------------------------------------------------- 108efc2627 | Kate | 2021-11-07 20:37:14 +0000 Fix misleading indentation -------------------------------------------------------------------------------- 581a213eff | Kate | 2021-11-07 20:21:10 +0000 Let monsters use Rift's bonus reach range And fix its display in the monster list so that it shows up as a polearm there. -------------------------------------------------------------------------------- 7e933cf55b | Kate | 2021-11-07 19:50:24 +0000 Let monsters use reaching attacks in any attack slot Reaching attacks previously only functioned in the first attack slot, but some mutant beasts could have them in later slots, resulting in the reach attack not functioning. -------------------------------------------------------------------------------- 19d727b07e | Kate | 2021-11-07 18:17:04 +0000 Remove unused AF_KITE handling Since this attack flavour has been removed. -------------------------------------------------------------------------------- de3ffcc593 | Kate | 2021-11-07 17:48:04 +0000 Give Excruciating Wounds a targeter As with transmutations and other self-enchantments. -------------------------------------------------------------------------------- 60983d4ba9 | Kate | 2021-11-07 00:23:51 +0000 Fix Serpent of Hell attack descriptions Due to various complicated handling for hydra-style multi-attacks, only their first bite attack was listed in their descriptions. -------------------------------------------------------------------------------- 74956062c1 | Kate | 2021-11-06 15:41:08 +0000 Adjust some mutation descriptions -------------------------------------------------------------------------------- 09f76e8c00 | Kate | 2021-11-06 01:50:21 +0000 Fix Xom chesspieces claiming to put undead to sleep And correctly give the "is unaffected" message instead. -------------------------------------------------------------------------------- 4fbe447692 | AdamPG | 2021-11-06 00:55:39 +0000 Readjust Ignis ability costs to 4/3 of original cost This gives the player 8 uses of Foxfire Swarm, each of which cost and additional 3 piety, leading to an increase of 24 piety cost - exactly the former cost of one use of Rising Flame (which is now free). -------------------------------------------------------------------------------- c9cd55e000 | AdamPG | 2021-11-06 00:55:39 +0000 Make Ignis' Rising Flame only usable once Cinder Acolyte has proven to be an incredibly strong start. In particular, the Rising Flame power changes the game in ways that make the entire early and mid-game into a foregone conclusion for any experienced reasonably-high-win-rate player. While strong starts such as Berserker already exist, these are all still susceptible to losing if one makes the various mistakes that players make in an average game of Crawl. Rising Flame, however, removes all consequences for mistakes. At starting Ignis Piety, the player gets four uses of Rising Flame. When they activate it, they are shafted upwards after a delay of 2+random2(3) turns (an entire turn faster than a teleport scroll!). This ability is probably the most powerful escape ability in the entire game and is simply too strong to be available from the start of the game in such a large quantity. A "get out of jail free card" for a player's worst mistakes is a cool idea, but it should only be available one time, similar to Tso or Kiku's capstone abilities. As such, this PR turns Rising Flame into a capstone ability, usable exactly once at any piety level and with no piety cost of its own. [Committer's note: squashed commits and updated commit message to reflect the change from an increased piety cost to a capstone ability. Closes #2209.] -------------------------------------------------------------------------------- b5f29a7041 | Nikolai Lavsky | 2021-11-06 00:03:45 +0000 fix: disable miscast-created allies when allies are forbidden As a followup to cf4520f7, this commit blocks one more source of allies who would immediately turn hostile under Okawaru or Sac Love. This covers Spellbinder melee and any other potential way of causing summoning miscasts on monsters. -------------------------------------------------------------------------------- e7ca7b5467 | Nicholas Feinberg | 2021-11-05 16:24:08 -0700 Reword clarity berserk slightly "Losing temper" reads very strangely to me; I've always seen it as "losing [your/my] temper". Perhaps it's a commonwealthism? In any case, it seems to imply that without this mutation, you could become enraged for no reason at all; let's try to fix that. -------------------------------------------------------------------------------- f458de4411 | Nikolai Lavsky | 2021-11-05 23:10:10 +0000 text: fix, reword, and extend a few mutation descriptions * To make style more consistent, this commit capitalizes stat names, adds a missing serial comma, and replaces +Stealth with Stealth+. * "Stab" has a special meaning for melee attacks, so replace it with the spiked tentacle's attack verb, "pierce". * Clarity blocking Rnd*Rage is a well-hidden mechanic, which is not mentioned anywhere in the game, so let's fix this too. -------------------------------------------------------------------------------- d4f0d3f9b2 | Kate | 2021-11-05 22:46:59 +0000 Remove checks for unidentified equipment Items equipped by the player and by monsters are always identified, so remove a lot of code that handled cases where the player didn't know whether they or a monster had a certain resistance or not. -------------------------------------------------------------------------------- 4e399c39f0 | advil | 2021-11-05 09:48:49 -0400 fix: make an ASSERT more informative This ASSERT has been triggering sporadic, unreplicatable crashes since 2018 or so. Maybe more information will help. (In particular, if one of these link values is corrupted somehow, this might give a clue as to how.) -------------------------------------------------------------------------------- afe8c5f9e9 | Nicholas Feinberg | 2021-11-04 15:59:56 -0700 Allow players to use anubis guard tiles -------------------------------------------------------------------------------- 31680bbd8b | Nicholas Feinberg | 2021-11-02 19:02:40 -0700 Celebrate true heroism (Sastreii) New Heroism and Duel invocation icons. -------------------------------------------------------------------------------- 75f770b44e | Edgar A. Bering IV | 2021-11-02 23:32:51 +0200 feat: make Duvessa permanently berserk when Dowan dies She waits to see you before going crazy. But the game of "kill Dowan first then escape to wait out the berserk and fight a normal Duvessa" always seemed a bit sad, considering Dowan's grief gave him permanent new strength. So lets let the bond run a bit deeper, and make Duvessa's rage eternal. -------------------------------------------------------------------------------- d6d7bb098e | Edgar A. Bering IV | 2021-11-02 23:30:27 +0200 fix: prevent petrified monster speech -------------------------------------------------------------------------------- 9f4689a14b | Edgar A. Bering IV | 2021-11-02 23:19:52 +0200 fix: don't time out any permanent enchantments on stair change -------------------------------------------------------------------------------- 03c7b27e48 | Nicholas Feinberg | 2021-11-02 13:36:35 -0700 Reduce crystal tome spell count Drop to 1-2 spells per cast, from 2-3. They're quite strong regardless, and can stand to be pulled back just a little bit. -------------------------------------------------------------------------------- 59c5b1f36e | Nicholas Feinberg | 2021-11-02 13:36:35 -0700 Increase living earthen tome HD Give em a better shot at hexing Depths characters. -------------------------------------------------------------------------------- 2d16a5e2fa | Nicholas Feinberg | 2021-11-02 13:36:35 -0700 Fix living spell HP display -------------------------------------------------------------------------------- fc378a028c | Nicholas Feinberg | 2021-11-02 13:36:35 -0700 Hopefully clarify living tome descriptions -------------------------------------------------------------------------------- a3f3a1a0a4 | Nicholas Feinberg | 2021-11-02 13:36:35 -0700 Cut living spell HP Make it easier to kill them before they cast. -------------------------------------------------------------------------------- b1e28150d3 | Edgar A. Bering IV | 2021-11-02 22:29:10 +0200 vaults: adjust a zot vault lich placement -------------------------------------------------------------------------------- b4ddf7de7f | Edgar A. Bering IV | 2021-11-02 22:26:26 +0200 vaults: adjust a zot vault draconian placement -------------------------------------------------------------------------------- 02bda5dcb3 | advil | 2021-11-02 12:36:46 -0400 docs: update placement.lua docs (perryprog) This replaces some obsolete documentation that referred to `placement.lua`'s predecessor, as well as updates the script --help output to include some things that got added but never documented. -------------------------------------------------------------------------------- 6f86257384 | Nicholas Feinberg | 2021-11-02 08:31:42 -0700 Improve armour/sh miss messages Account for to-hit being randomized after armour & shield penalties are applied, before they're compared to EV. Also de-indent. -------------------------------------------------------------------------------- 186eaeaa95 | Nicholas Feinberg | 2021-11-02 07:53:31 -0700 Remove the tail tail -------------------------------------------------------------------------------- 3d1f99b579 | Nicholas Feinberg | 2021-11-01 21:19:35 -0700 End All Hallow's Eve This reverts commit 91a516d0e768b6e4232327f2d9d008fc577132f3. -------------------------------------------------------------------------------- a603e38af3 | Nicholas Feinberg | 2021-11-01 16:36:08 -0700 Add a mutation menu To allow players to examine details of mutations. Lots of notes about good future improvements in get_mutation_desc(). -------------------------------------------------------------------------------- c1b1554a8f | Nicholas Feinberg | 2021-11-01 16:36:08 -0700 Minor mutation description tweaks Mostly to removed muts. -------------------------------------------------------------------------------- ddf5a44173 | Nicholas Feinberg | 2021-11-01 16:36:08 -0700 Add mutation DB -------------------------------------------------------------------------------- 90e1efd671 | Nicholas Feinberg | 2021-11-01 16:36:08 -0700 Separate out _get_fakemuts -------------------------------------------------------------------------------- 1fcdd13c02 | Nicholas Feinberg | 2021-11-01 16:36:08 -0700 Refactor form fakemuts Simplify poison immunity printing & pull out form fakemuts into their own category. -------------------------------------------------------------------------------- 130ae17fe5 | Kate | 2021-11-01 01:34:27 +0000 Reduce spellpower caps of some low-level spells Teleport Other, Sublimation of Blood, Spider Form, Inner Flame, Gell's Gravitas and Vampiric Draining - as level 2-3 spells, they shouldn't scale all the way up to 200 power. -------------------------------------------------------------------------------- 2d6b873594 | Kate | 2021-11-01 01:34:27 +0000 Don't let monsters pick up seen items they've dropped This allowed them to pick up their weapon again after being disarmed, for example. -------------------------------------------------------------------------------- 91a516d0e7 | Edgar A. Bering IV | 2021-10-31 20:36:10 +0200 hack: halloween tonight, be careful Since we're a bit late and didn't put this on Maurice let's give our players a spooky costume with a hasty options default. Doing this (or maurice) automatically using today_is_halloween() will come later. -------------------------------------------------------------------------------- c05be326da | gammafunk | 2021-10-31 01:11:00 -0500 feat: Tweak a Master Elementalist vault Remove the final chamber door in `mu_elemental_laboratory`, since it tends to allow players to sneak up on our secretive wizard too easilly. Also put a small window into the final chamber about halfway through the vault. Then players can see what they'll be up against as well as the potential rewards. -------------------------------------------------------------------------------- 550dbda0cd | advil | 2021-10-30 18:42:21 -0400 fix: tweak &P temple behavior when low on gods (nicolae) If the seed-chosen temple had fewer altars than an &P placed one, levelgen would simply place floor. This change repurposes an existing check for mapstat/objstat that places a Xom altar in this case. -------------------------------------------------------------------------------- 8c92f1e708 | advil | 2021-10-30 17:50:07 -0400 fix: suppress corrupted PlaceInfo error for wizmode commands This is treating the symptoms, but I think it is safe to ignore this fixup entirely for things like &P. (A better fix might be to make wizmode commands not need the fixup.) -------------------------------------------------------------------------------- 84b7309ef8 | advil | 2021-10-30 17:50:06 -0400 fix: make &P work in temple Previously, the selected map for this command was ignored in temple, overridden by the temple map chosen at seed start. This commit lets a FORCE_MAP_KEY prop override TEMPLE_MAP_KEY if both are set. This does not replace the TEMPLE_MAP_KEY prop, so `&ctrl-r` resets. A map that requires a layout will crash here; this could maybe be headed off by requiring the map to be usable in temple to place there in the wizmode code. I've fixed the crash so that it's an ASSERT at least, and not a segfault (which is how this initially presented). This commit also fixes the encompass warning for `&P` to check PLACE restrictions and not just DEPTH; it was ignoring PLACE before and so probably printing this warning for a bunch of unnecessary cases. -------------------------------------------------------------------------------- 0164abf027 | Kate | 2021-10-30 20:39:40 +0100 Don't consume corpses on Kiku torment failure -------------------------------------------------------------------------------- 4ac5789cae | advil | 2021-10-30 15:25:49 -0400 fix: remove an essentially unused function This function has both webtiles and local tiles code, but isn't used in local tiles. In webtiles it returns 1. Possibly intended for greater things in 1f9488b117fe8, but that didn't happen. -------------------------------------------------------------------------------- cc23663199 | advil | 2021-10-30 15:25:49 -0400 fix: explicitly use TargetConditionals.h in platform detection OS X provides a header that is in some ways quite similar to our platform.h, up to the macro naming style, but unfortunately uses a value of 0 rather than undefinedness for false. This has been around for a very long time (e.g. I found a version as old as 2000), and it looks like there have always been some collisions, but these are largely for for macos 12) added a few new ones that do matter quite a bit, in particular TARGET_OS_WINDOWS and TARGET_OS_LINUX are now #defined to 0 when building on OS X. This breaks many things. This commit takes the easy way out and does some selective #undefs. I've tried to fix a few of the old problems that don't really matter as well, e.g. the old version had noticed that TARGET_CPU_PPC was defined but didn't handle that correctly. I think in the longer run it could be better to change our prefixes, e.g. to DCSS_TARGET_OS_WINDOWS. But this is a bit of an annoying task. Resolves #2208 -------------------------------------------------------------------------------- b5831b966b | Kate | 2021-10-30 20:19:33 +0100 Adjust some Elyvilon abilities While Elyvilon's basic functionality is relatively strong, the god had a very large number of activated abilities and is heavily focused on using them with high invocations training, so was quite fiddly in practice. To streamline things slightly, make the lifesaving ability entirely passive, with no requirement to avoid attacking things (since Zin's Sanctuary is a more interesting version of that design). It now provides the standard good god lifesaving chance, plus an additional stronger piety-based chance which becomes guaranteed at 5* but has a piety-gated timeout. Rather than having two separate self-healing abilities, also remove the Lesser Healing ability and move the other active abilities earlier - Purification moves to 1* and is made slightly cheaper, and Greater Healing is renamed to Heal Self and moves to 3*. -------------------------------------------------------------------------------- 707b13c9aa | Kate | 2021-10-30 19:24:57 +0100 Improve Kikubaaqudgha's invoked torment Allow it to take corpses from adjacent squares instead of only the player's location, and guarantee at least partial torment protection. -------------------------------------------------------------------------------- 2b075f26b7 | Kate | 2021-10-30 19:20:35 +0100 Move some TSO active abilities earlier Moves Divine Shield to 1* and Cleansing Flame to 3*. The Shining One isn't really a useful god in the early game, and this doesn't really change that, but should make the god a little more usable if chosen from a faded altar, for example. -------------------------------------------------------------------------------- d57beee77b | Kate | 2021-10-30 19:20:35 +0100 Cap Gozag's gold distraction chance In edge cases (primarily casting level 9 spells in Ziggurats), it was possible to stack gold distraction so high that monsters could barely act. Adjust the probability of gaining a stack, so that it's now easier to gain multiple stacks at low values, but harder once lots of stacks have been gained, and cap the number of stacks at 20. This is unlikely to be relevant most of the time but should at least tone it down in extreme situtations. -------------------------------------------------------------------------------- f0b37e2a93 | Kate | 2021-10-30 19:20:35 +0100 Slightly reduce Ru's chance of passive retaliation From 1/4 at max piety to 1/5. Ru is very powerful for most characters, and while the sacrifices are a good tradeoff for this, having that power focused in the active abilities (with their cooldowns) is more interesting than having passive retaliation do too much of the work. -------------------------------------------------------------------------------- 5845fe868d | Kate | 2021-10-30 19:12:29 +0100 Highlight some Pan rune messages by default -------------------------------------------------------------------------------- b643f36830 | Kate | 2021-10-30 19:12:29 +0100 Remove a reference to spell hunger -------------------------------------------------------------------------------- abee14ce83 | Kate | 2021-10-30 19:12:27 +0100 Randomise the corpse used for Animate Skeleton Instead of picking the first location visited by radius_iterator. -------------------------------------------------------------------------------- 8f272e2798 | Kate | 2021-10-30 18:59:48 +0100 Remove some handling for multi-headed players -------------------------------------------------------------------------------- f7c1052996 | Kate | 2021-10-30 18:59:48 +0100 Update description for scrolls of fear -------------------------------------------------------------------------------- c1929b3ff3 | Edgar A. Bering IV | 2021-10-30 20:49:11 +0300 fix: recolour titans and antaeus in console -------------------------------------------------------------------------------- 0db16c8cc9 | Nicholas Feinberg | 2021-10-30 07:46:08 -0700 Add ArmiesAndCastles to the CREDITS -------------------------------------------------------------------------------- ef3a642a4e | Nicholas Feinberg | 2021-10-29 07:39:35 -0700 Fix using ?id under Ashenzari (particleface) Also remove an unused #include. -------------------------------------------------------------------------------- 7c675f85b1 | Nicholas Feinberg | 2021-10-28 21:01:04 -0700 Fix console builds? -------------------------------------------------------------------------------- ded9c35045 | Gopall | 2021-10-28 19:48:25 -0700 Prompt user when trying to enter ziggurat portal. Ziggurats are very dangerous. And the portal you enter through is disabled when you enter. It would be a good idea to prompt the user to prevent them from accidentally entering a ziggurat. -------------------------------------------------------------------------------- 340af05277 | Nikolai Lavsky | 2021-10-28 19:45:31 -0700 tile: add ability icons for the Olgreb, Dispater, and Asmodeus unrands -------------------------------------------------------------------------------- 9e3a184554 | ArmiesAndCastles | 2021-10-28 19:34:31 -0700 Add spell menu option -------------------------------------------------------------------------------- 1ad88e3242 | Aliscans | 2021-10-28 19:27:42 -0700 Only compile 27 functions when USE_TILE (or similar) is set. There were a number of functions which were only called if TILE, TILE_LOCAL or TILE_WEB was defined, but were defined unconditionally. Add #ifdefs to some of them to reflect the way they are used. -------------------------------------------------------------------------------- cf0edb70ba | Aliscans | 2021-10-28 19:27:42 -0700 Delete 43 unused functions. Make 1 DEBUG-only. Delete these unused functions: can_spawn_mushrooms() compare_skills() count_allies() count_desc_lines() count_monsters() count_neighbours() count_traps() downgrade_zombie_to_skeleton() drain_hp() fully_map_level() get_armour_repel_missiles() get_desc_quantity() get_random_stair() get_recent_messages() gozag_gold_in_los() ignite_poison_affects() inc_max_hp() init_abomination() is_helmet() is_real_food() item_from_int() item_int() macro_sendkeys_end_add_cmd() max_cloud_damage() mons_can_move_towards_target() mons_class_res_polar_vortex() mons_has_flesh() mons_has_incapacitating_ranged_attack() mons_has_incapacitating_spell() mons_secondary_habitat() multiple_items_at() num_feats_between() pack_item_identify_message() playable_job_names() playable_species_names() player_can_memorise() rand_round() set_hydra_form_heads() spell_is_form() tile_clear_map() tile_reset_feat() update_monster_symbol() zin_remove_all_mutations() Put "#ifdef DEBUG" around keyseq_to_str(). This is not used in the code, but this means that it can still be called through a debugger with the right compile option. -------------------------------------------------------------------------------- 3554995387 | hellmonk | 2021-10-28 19:20:36 -0700 adjust the slow spell Move it to level 1, but cap the power at 25. This might make slow more exciting early on AM without letting it remain too relevant later on. It still has a success bonus compared to other hex effects; this could be removed, but might require adjusting other sources of slow. -------------------------------------------------------------------------------- 776b58c23f | ArmiesAndCastles | 2021-10-28 19:17:21 -0700 Forbid invalid ghost spells -------------------------------------------------------------------------------- 6247938026 | ArmiesAndCastles | 2021-10-28 19:11:23 -0700 Solve wizard mode charms crash -------------------------------------------------------------------------------- 1d6e689fef | Santiago Acosta | 2021-10-28 19:07:31 -0700 Simplify mon_to_hit_base mon_to_hit_base asked if the attack was ranged or not. but this was pointless, since it always returned 18 + 2.5 * HD for skilled monsters or, 18 * 1.5 * HD for unskilled ones. Removed this distinction, and simplified the magic numbers. -------------------------------------------------------------------------------- 09e7bd7c26 | Aliscans | 2021-10-28 19:05:39 -0700 Don't say the map boundary can be burnt or dug through. Prevent get_feature_desc() from stating that terrain on the map boundary can burn or be dug through, as it can't. This reflects a restriction in destroy_wall(). Fix a typo in a comment. -------------------------------------------------------------------------------- de44f11507 | Gopall | 2021-10-28 19:03:49 -0700 Fix a Pan teleport closet -------------------------------------------------------------------------------- 1cc4480b13 | dilly | 2021-10-28 19:03:02 -0700 Give master elementalist willlpower Carry on, master elementalist. -------------------------------------------------------------------------------- 6bb2ce7825 | Perry Fraser | 2021-10-28 19:01:43 -0700 Rename Purgy to Pargi After an IRC discussion brought up by PleasingFungus/gammafunk/geekosaur, it was decided to rename Purgy to Pargi to avoid a potential comparison to bulimia. -------------------------------------------------------------------------------- 9ea0df9366 | ArmiesAndCastles | 2021-10-28 18:57:55 -0700 Solve lost soul crash -------------------------------------------------------------------------------- bb860f9c85 | Nicholas Feinberg | 2021-10-28 18:56:08 -0700 Adjust dpeg_arrival_tiny_a Be merciful (?) -------------------------------------------------------------------------------- 0f29109cba | Nicholas Feinberg | 2021-10-28 18:38:15 -0700 Add seven new Gastronoks (Sastreii) Replace Gastronok's tile with a much sillier one, and add six other tiles for players who want to set a custom tile. These are: - MONS_GASTRONOK_MUSTACHE - MONS_GASTRONOK_CLEANSHAVEN - MONS_GASTRONOK_HANDLEBAR - MONS_GASTRONOK_FU_MANCHU - MONS_GASTRONOK_SIDEBURNS - MONS_GASTRONAUT They can be set by using this rcfile option: tile_player_tile = tile:mons_gastronaut (Or likewise for other tiles.) -------------------------------------------------------------------------------- f7145f7991 | Nicholas Feinberg | 2021-10-28 18:15:39 -0700 Show Crypt rocks (Sastreii) New rock wall tiles for Crypt. -------------------------------------------------------------------------------- 75e6d9beac | Kate | 2021-10-28 16:12:16 +0100 Simplify scrolls of brand weapon Their list of brands with multiple different weights was fairly spoilery. Instead split the brands into "common" (vorpal, freezing, flaming, venom, protection) and "rare" (draining, electrocution, spectral, vampiric, chaos) categories, with each brand within those categories having the same weight, and add this information to the item description. In practice this is a relatively small change to the brand weightings, with the main exceptions of protection and chaos becoming noticeably more common. -------------------------------------------------------------------------------- 59de83eefb | advil | 2021-10-28 09:53:32 -0400 fix: NOWIZARD build compilation issues There are still a bunch of warnings that look harmless, but this should get it to build -------------------------------------------------------------------------------- 892d06dc2c | Kate | 2021-10-28 05:12:11 +0100 Move Ashenzari's item and trap identification to 1* Ashenzari is extremely strong and generically useful to any character, and in addition to the substantial skill boosts offered once cursed, granted a number of abilities up-front without requiring any curses at all. Instead move the trap protection and item identification to 1*, so that joining Ashenzari doesn't immediately identify all consumables for free and some investment is required. -------------------------------------------------------------------------------- 7a50183f53 | Kate | 2021-10-28 05:12:11 +0100 Remove an unused Jiyva god_passive And fix a typo describing some related functionality. -------------------------------------------------------------------------------- 0181a31188 | Nicholas Feinberg | 2021-10-27 07:25:52 -0700 Make Shoals less washed out (Sastreii) Tweaks to new stone wall tiles. -------------------------------------------------------------------------------- ef20177fd5 | advil | 2021-10-27 10:12:41 -0400 fix: remove a spurious # No idea if this could be causing monterey build problems somehow, but it doesn't need to be there. -------------------------------------------------------------------------------- 4a9143789a | Nicholas Feinberg | 2021-10-26 18:50:32 -0700 Actually add new Shoals tiles Oops! -------------------------------------------------------------------------------- 345791154b | Nicholas Feinberg | 2021-10-26 17:39:39 -0700 Add a pillar of the community (Sastreii) New Shoals stone wall tiles. Simply classic... -------------------------------------------------------------------------------- 66f9036eb4 | Kate | 2021-10-26 02:37:52 +0100 Make boulder beetles stop rolling when incapacitated -------------------------------------------------------------------------------- 095bd1b44f | Nicholas Feinberg | 2021-10-24 15:05:01 -0700 Show brimstone fiends the door (Sastreii) More brightness and contrast tweaks. -------------------------------------------------------------------------------- c0678643b6 | Kate | 2021-10-24 22:23:03 +0100 Remove shock as an option for black draconian breath Black draconian breath being uncontrollable works well to distinguish it from being another plain elemental-flavoured bolt, but makes it harder to use effectively and very high-variance. Remove shock as one of the zaps it can fire, and slightly increase the relative weight of orbs of electricity (from 33/33/33 shock/lightning/OoE to 60/40 lightning/OoE). -------------------------------------------------------------------------------- 5a7bdb8870 | Kate | 2021-10-24 22:07:26 +0100 Remove duplicate acid breath handling -------------------------------------------------------------------------------- 7be2a051a4 | Kate | 2021-10-24 20:03:31 +0100 Improve yellow draconian breath targeter So that it properly displays as a beam, instead of looking like it's smite- targeted. -------------------------------------------------------------------------------- 5dbd38fb6a | Kate | 2021-10-24 20:03:31 +0100 Let yellow draconian breath splash more consistently It previously couldn't splash if the monster it hit was killed by the initial damage. -------------------------------------------------------------------------------- e95497fc47 | Kate | 2021-10-24 20:03:31 +0100 Simplify some Shadow Creatures handling Since it's now only a scroll and not a player spell. -------------------------------------------------------------------------------- 190f86ba01 | Nicholas Feinberg | 2021-10-24 09:44:50 -0700 New Brimstone Fiend tile (Sastreii) Decided to take a break from puns for this one. Gotta mix things up :) -------------------------------------------------------------------------------- 73b70caff8 | gammafunk | 2021-10-24 06:19:49 -0500 feat: Remove a Gauntlet exit vault The map `gauntlet_exit_spiral` is a simple spiral Gauntlet exit map adapted from an exit vault for the original Labyrinth portal. This map is significantly harder than the other exits because it provides no cover over long corridors. It predates the minotaur having access to javelins, so this difficulty difference is unintentional. Furthermore it's not an especially interesting exit map on its own. The newly added `dreamdust_gauntlet_exit_labyrinth` map is more balanced and interesting than `gauntlet_exit_spiral`, and the former is also a Labyrinth reference, so I'm removing the latter. It's possible to rework the map's layout to give the player some better terrain while retaining a spiral aspect, but it would make more sense to make a new map at that point. -------------------------------------------------------------------------------- 7e422d3a0a | gammafunk | 2021-10-24 06:00:19 -0500 feat: Some tweaks for a Gauntlet exit map For dreamdust_gauntlet_exit_labyrinth, use alternating patterns to place dead ends not cardinally adjacent to wall openings, which would make the dead end not function. Tweak the inner-most wall to always a path around corners that doesn't create a diagonal choke point. Finally, move the map to the end of the DES section, so that the maps are ordered by when they were added. Closes #2166. -------------------------------------------------------------------------------- b7d1d2055b | DreamDust | 2021-10-24 06:00:19 -0500 A Gauntlet exit map Similar to my other labyrinth vault, dreamdust_labyrinth, but scaled down and turned into a gauntlet exit vault. Commiter's Note: Tweaked commit message and squashed a fix commit. -------------------------------------------------------------------------------- 6a1266e7b4 | gammafunk | 2021-10-24 06:00:19 -0500 feat: Some adjustments to two large themed maps For `dreamdust_labyrinth`, this is a large vault that ultimately places a single monster. Although the larger maze is visually interesting, there's a lot of dead space. This commit scales down the maze by removing one set of stone walls. Additionally it simplifies the substitutions and introduces an alternating pattern to prevent the dead end from sometimes placing adjacent to the single opening in the wall in a way that prevents the dead end from functioning. For `dreamdust_isle_of_ice`, I've rebalanced the monster lists for each placement depth and added loot appropriate for the threat. For monsters, since this vault is evoking the Ice Cave aesthetics and monster themes, I've made monster lists that combine the "natural" and "undead/demonic" sets, choosing depth-appropriate monsters from the Ice Cave common monster lists used in that portal. The earlier Dungeon and Lair placements use the "easy" Ice Cave monsters, the later Dungeon uses the "hard" Ice Cave monsters, and for Depths I've logically extended the sets to include top end "hard" monsters and a few additional threats form Cocytus. I've added a mix of the usual loot types as well as one thematic Ice Cave loot item that borrows some of the loot definitions used in the portal. The monster and loot item counts are the same for all depths, only the types of monsters change. Ice statues have a chance to place in Dungeon and Lair, with a chance for a second ice statue in late Dungeon. For Depths, we use an orange crystal statue. I've tweaked the appearance of the vault to be more consistent with the Ice Cave portal for console, and added vault connectors near the front of the map, so the vault will be better integrated with the level layout. -------------------------------------------------------------------------------- 8fcd438c92 | DreamDust | 2021-10-24 06:00:19 -0500 Two large themed vaults dreamdust_isle_of_ice: An ice-themed vault on the edge of the map. Original inspiration is how Antarctica looks on a 2D world map, but I'm a terrible artis. So quickly gave up on replicating it. dreamdust_labyrinth: An homage to the old labyrinths. I gave it the lowest WEIGHT since it's a large vault and I think it works best as a very rare easter egg. Committer's Note: Combined commits and tweaked commit messages. -------------------------------------------------------------------------------- 10fb06eb29 | DreamDust | 2021-10-24 06:00:19 -0500 A small loot vault dreamdust_deal_with_the_devil: Some devilish being is trying to tempt players into using a powerful but dangerous piece of equipment. Original plan for this vault was to generate a randart armour with Harm, but this apparently isn't possible. Unfortunate. -------------------------------------------------------------------------------- ac3eafeb5c | gammafunk | 2021-10-24 06:00:19 -0500 Some fixes and adjustments to some float vaults For `dreamdust_black_sun_cult`, use the new correct name for demonspawn black suns. Tweak placement to allow on branch ends, since there's nothing special about this vault that needs to avoid that. For `dreamdust_experimentation`, mix in some "experimental" hostile monsters along with the wizards, to make the vault a bit less mundane. Scale loot and monster count better with depth of placement. For the decorative monsters, use either only human or animal species monsters depending on the monster set chosen, all with permanent enchants, and have them generate awake. For `dreamdust_cat_pyramid`, slightly increase the number of sphinxes, placing 3 on-average and up to 5 to balance the vault's difficulty relative to its loot. Use the good loot potion set instead of random potions, and thin out the loot count a little. This way there's a bit less loot, but it's higher quality. Spread the loot items out in the vaults interior, moving external gold to inside the vault. Tweak the vault layout to prevent statues from blocking the door and to give a more complete path around the outside of the vault. -------------------------------------------------------------------------------- 3ea58914d7 | DreamDust | 2021-10-24 06:00:19 -0500 Some float vaults `dreamdust_black_sun_cult`: Vault featuring a fire and necromancy based cult. In the Dungeon, players will encounter sun demons and a demonspawn black sun, while in Zot they'll find powerful draconians and a black sun worshipping an orb of fire. Rewards are a book (either a manual or a spellbook) and a fire-related item. `dreamdust_cat_pyramid`: A cat-themed pyramid with a couple guardian sphinxes and some offerings as loot. `dreamdust_experimentation`: Some wizards have been performing inhumane experiments... Kill them, stare in horror at what they've created, and then feel free to loot their potion stash! :) Committer's Note: Merged commits and cleaned up commit message. -------------------------------------------------------------------------------- 79a10526bc | gammafunk | 2021-10-24 06:00:19 -0500 feat: Some tweaks to a Shoals vault For `dreamdust_from_the_deep`, the custom water and wall tile visuals taken from the Sewer portal are out of place for the visuals of Shoals. The vault's themes directly referencing the Abyss, so this commit removes the custom water tiles and replaces the Sewer wall tiles with Abyss rock wall tiles. Also replace the gravestone tile for the statue with the newly added tentacle statue tile and remove the custom description. Custom statue descriptions used only in one vault tend to confuse the player as to whether the statue might some special effect, which this one doesn't. -------------------------------------------------------------------------------- 7e8daab784 | DreamDust | 2021-10-24 06:00:19 -0500 A Shoals vault dreamdust_from_the_deep: An "eldritch" vault full of tentacle and chaos monsters. Gives a randart ring and a spellbook with malign gateway & summon horrible things as rewards. Commiter's Note: Cleaned up commit message. -------------------------------------------------------------------------------- f6f64a616a | Kate | 2021-10-24 01:35:50 +0100 Give Blink a power-dependent cooldown Blink was the final player spell that ignored spellpower completely, and was also one of the worst offenders for being universally desirable without requiring any noticeable skill investment. Give it a power cap of 50 and a short cooldown (which is also applied to evokable blink on randarts, but no other methods of blinking - scrolls of blinking and forced blinks from monster spells are unaffected). At full power the cooldown is reduced all the way to zero. -------------------------------------------------------------------------------- c1fbb6f34a | Nicholas Feinberg | 2021-10-23 16:22:37 -0700 Do some deep trolling (Sastreii) New DTEM and deep troll shaman tiles, tweaked for better visibility. -------------------------------------------------------------------------------- 4d584c6bc1 | Kate | 2021-10-23 22:44:42 +0100 Rename a removed mutation So that it doesn't have the same name as an existing mutation for wizmode purposes. -------------------------------------------------------------------------------- b99661e8b9 | Kate | 2021-10-23 22:44:42 +0100 Fix a wispform typo -------------------------------------------------------------------------------- a01ba6cf96 | Kate | 2021-10-23 22:44:42 +0100 Don't make -Potion duration display as a mutation Moves the display for lichform's inability to drink potions to the form's list of innate fake mutations - possibly these should be extended to allow marking a form mutation as good/bad to determine colour, rather than special-casing bad mutations with colour tags. -------------------------------------------------------------------------------- 5ef96339b7 | Kate | 2021-10-23 22:44:42 +0100 Make Inner Flame smite targeted (perryprog) Inner Flame was strong but often a little fiddly to use - making it smite targeted allows it to still be used with foxfires blocking line of fire, for example. Closes #2175 (and implements the change slightly differently, with the beam/zap still kept so that it can be used elsewhere). -------------------------------------------------------------------------------- fe11b99a14 | Kate | 2021-10-23 22:44:42 +0100 Let player hexes set ally targets As with direct damage spells, hexing a monster indicates that you probably want your allies to attack it. Hibernation is kept as an exception, since the player is more likely to want to stab themselves than to have their allies try to do so. -------------------------------------------------------------------------------- 0812ffde7f | Nikolai Lavsky | 2021-10-23 22:44:09 +0100 fix: don't show Rage % when the player can't be affected by *Rage Don't show the Rage chance on the character overview screen for lifeless undead and for players with Clarity. -------------------------------------------------------------------------------- 20c1a8e840 | Aliscans | 2021-10-23 22:43:29 +0100 Shrink some overview screen labels to make them fit better Reduce the width of the first column of labels from 9 to 8. This creates a 1 character gap between the right edge of the Stlth field and the second column of labels. Set the length of the Stlth, HPRegen and MPRegen labels using cwidth. This means that every field in the two label columns has its width set by cwidth. Remove loops from _stealth_bar(). -------------------------------------------------------------------------------- 47f3eba078 | Nicholas Feinberg | 2021-10-22 08:22:14 -0700 Add a spooky new halloween tile (Sastreii) Not currently used for anything but could be fun for Maurice. -------------------------------------------------------------------------------- 841cac7204 | Nicholas Feinberg | 2021-10-22 08:09:07 -0700 Shatter Morrison's legacy (Sastreii) New broken door tiles. -------------------------------------------------------------------------------- ff097466f2 | Kate | 2021-10-21 17:09:34 +0100 Simplify sickness status display It's a much simpler effect than it was in the distant past, and can just be displayed straightforwardly instead of changing colour depending on remaining duration. Also fixes it not being correctly displayed by potions of cancellation. -------------------------------------------------------------------------------- e4f7e7e258 | Kate | 2021-10-21 03:57:34 +0100 Adjust a distortion message So that it doesn't overlap with the messaging for Lugonu's Bend Space or translocation miscasts, which resulted in misleading message colouring by default. -------------------------------------------------------------------------------- 1f2755edf2 | Kate | 2021-10-21 03:57:10 +0100 Give Bend Space a chance to blink monsters at the destination Bend Space's power-dependent chance to blink and damage adjacent monsters mostly acts as flavour and to slightly distinguish it from regular Blink. To lean into this and Lugonu's chaotic nature a little more, let it also blink monsters at the destination. Blinking monsters at the destination also has the added bonus of making it slightly less likely to end up next to a hostile creature. -------------------------------------------------------------------------------- 5bcc4f242e | Kate | 2021-10-21 02:25:10 +0100 Remove an obsolete parameter -------------------------------------------------------------------------------- ad6df49e81 | Kate | 2021-10-20 01:23:27 +0100 Make the player immune to their own Noxious Bog The spell's utility was previously very heavily dependent on whether the player had easy access to flight. Make it a little easier to use without needing access to flight, since it already does have strong restrictions on where it can be cast in the first place. (This can also technically be used to gain immunity to monster-cast sludge, which is probably fine.) -------------------------------------------------------------------------------- e46a2d6e3a | Kate | 2021-10-20 01:23:27 +0100 Fix spacing -------------------------------------------------------------------------------- a55568f2eb | advil | 2021-10-19 17:51:19 -0400 lint: checkwhite -a -------------------------------------------------------------------------------- 42619f35cc | advil | 2021-10-19 17:50:58 -0400 docs: MSYS2 install tweaks for python issues The main contentful change here is to be consistent about using the binary name `python3` instead of `python`. The reason for this is that apparently these days `base-devel` forces install of the `python` package as a dep of various things included in it, and we also install the `mingw-w64-x86_64-python` package as part of that toolchain. Having the latter installed (which uses the `python3` binary name) seems to break regular `python` in current MSYS2 versions, because when you load `python` the python path (as seen in `sys.path`) gets set wrong, to the mingw toolchain version. Because of this it fails to load any c libs due to binary incompatibility (`math` being the one that shows up when trying to import `yaml`). Anyways, this confusing situation doesn't actually impact building crawl, because the build steps themselves already use `python3`, it just means this step that was supposed to check `yaml` was producing an error. The situation is possibly an outright MSYS2 bug, though I'm not entirely sure where to report or ask about it. Because the build actually works fine as-is, I don't think any deeper change is merited on our part (e.g. uninstalling one or the other python, each of which is a dep to a corresponding version of gdb). This commit resolves #2195, which proposed a less direct workaround for getting an attempt to import `yaml` not to crash. -------------------------------------------------------------------------------- b91baff9cc | Nicholas Feinberg | 2021-10-18 21:06:12 -0700 Maybe fix an engulf bug -------------------------------------------------------------------------------- 66d609a797 | Nicholas Feinberg | 2021-10-18 21:03:36 -0700 Make living spells more reckless (causes bugs) Allow living iceblast spells to target an adjacent player, removing their regard for their own existence. This probably causes some new bugs. I don't know what, but I suspect there's something. -------------------------------------------------------------------------------- 4011e67c31 | Nicholas Feinberg | 2021-10-18 17:03:51 -0700 Put the last nail in the coffin (Sastreii) New Crypt door tiles of all shapes and sizes. Dead cool. -------------------------------------------------------------------------------- 30a9fa1a03 | nicolae-carpathia | 2021-10-18 17:15:42 -0400 Add/fix synonyms for statue tiles, vault that uses them Fixes the synonyms for the two new statue tiles, adds synonyms for all the statue tiles that didn't have any, and adds the new tile synonyms to dreamdust_ecumenical_altar_statues, which uses the synonyms to make sure the two statues placed are identical. -------------------------------------------------------------------------------- a8797d1ae1 | Nicholas Feinberg | 2021-10-17 21:19:34 -0700 Clear engulf after rising flame (Prakerore) -------------------------------------------------------------------------------- d288e3ce45 | Kate | 2021-10-18 04:24:54 +0100 Clear engulf status when monsters swap places (Daunt) -------------------------------------------------------------------------------- 1ffa25e84c | Kate | 2021-10-18 04:03:29 +0100 Fix a header-build-tests error -------------------------------------------------------------------------------- e885453c89 | Kate | 2021-10-18 03:59:30 +0100 Improve Yara's Violent Unravelling targeter Display a message when aiming at a monster that can't be unravelled. -------------------------------------------------------------------------------- 182c74e625 | Kate | 2021-10-18 03:59:30 +0100 Make monster Injury Mirror dispellable Monster enchantments are generally dispellable even if they're divine/priestly in origin and undispellable on the player (see 8836bdb7d9), but Injury Mirror had been missed from the updated list. -------------------------------------------------------------------------------- 48537fa010 | Kate | 2021-10-18 03:59:30 +0100 Remove an obsolete spell targeter -------------------------------------------------------------------------------- 3278d6a771 | Nicholas Feinberg | 2021-10-17 07:53:47 -0700 Take new Sastreii tiles for granite Two new statue tiles. -------------------------------------------------------------------------------- 6a1b92adce | Kate | 2021-10-17 14:48:37 +0100 Fix Refrigeration and OTR targeters (Goratrix) -------------------------------------------------------------------------------- c014c758b5 | Kate | 2021-10-17 14:39:43 +0100 Reduce some code duplication -------------------------------------------------------------------------------- daf460b524 | Kate | 2021-10-17 02:07:26 +0100 Remove a duplicate #include -------------------------------------------------------------------------------- 47fb96b963 | Kate | 2021-10-17 01:51:07 +0100 Upgrade Corpse Rot and PoG targeters Correctly handle corridors and adjacent walls for Corpse Rot, to show when it has a chance of spilling out and when it's guaranteed to affect a cell. Highlight squares that overlap for both portals in the Passage of Golubria targeter, to make it visually clearer that they're two distinct target areas. -------------------------------------------------------------------------------- 0a521eb1f5 | Kate | 2021-10-17 00:35:00 +0100 Adjust targeter_radius behaviour Change a number of radius spell targeters so that the caster's tile isn't automatically displayed as affected, unless it's actually a spell that can affect the caster such as Static Discharge. For Battlesphere, also slightly adjust the spell's behaviour so that the valid squares for recalling an existing battlesphere are the same as the squares for summoning a new one. -------------------------------------------------------------------------------- ee0c6bb3a6 | Kate | 2021-10-17 00:35:00 +0100 Add a spell targeter for Passage of Golubria -------------------------------------------------------------------------------- 50bfc30901 | Kate | 2021-10-17 00:35:00 +0100 Make Passage of Golubria's range scale with power Passage of Golubria was one of the few remaining spells that ignored spellpower completely, and was a desirable tool for anyone able to cast it. To make it less useful with low investment, scale its range with spellpower, from 2 at 0 power up to full LOS at 100 power. For practical spellpower values, this results in range 4/5 with minimal skill to cast the spell, and range 6/7 with more skill investment. -------------------------------------------------------------------------------- 6308e9f754 | Kate | 2021-10-17 00:34:56 +0100 Add a spell targeter for Corpse Rot -------------------------------------------------------------------------------- db29cd8f73 | Kate | 2021-10-17 00:12:34 +0100 Make Corpse Rot create more clouds with higher power Corpse Rot was one of the few player-castable spells that ignored spellpower completely, and was also fairly awkward to make good use of despite the strength of miasma clouds. Allow it to rot multiple corpses from a single stack, and give it a power-dependent chance of creating an extra miasma cloud per corpse in LOS. With high power and/or high numbers of corpses, also allow it to spread out to radius 2, once all adjacent squares have been filled with miasma. -------------------------------------------------------------------------------- 162e43154e | Nicholas Feinberg | 2021-10-16 10:17:14 -0700 Add a howler of a new tile (Sastreii) New Bunyip tile. -------------------------------------------------------------------------------- 0e9bf3705b | Nicholas Feinberg | 2021-10-16 09:18:30 -0700 Clarify explore mode (venx) -------------------------------------------------------------------------------- 4c3c5a04a9 | Nicholas Feinberg | 2021-10-16 08:29:54 -0700 Add ?/ to the main menu TODO: - Somehow show a proper response when regex searches (e.g. ?/M) don't find anything, instead of silently failing. (This works in local tiles and console, but not in webtiles.) - Tiles? -------------------------------------------------------------------------------- c179e30c89 | Nicholas Feinberg | 2021-10-14 11:12:35 -0700 Let Discord wake sleeping monsters Instead of leaving them unaffected. Seems simpler to reason about for players. -------------------------------------------------------------------------------- df75b09677 | Nicholas Feinberg | 2021-10-14 11:06:11 -0700 Simply divine tile changes (Sastreii) New tiles: - Angel - Daeva - Profane Servitor - Pikel - Goblin -------------------------------------------------------------------------------- 1651b1f1e0 | Kate | 2021-10-14 03:57:15 +0100 Update Pacification description It was changed in ff9e726d5e to give full XP. -------------------------------------------------------------------------------- 144af121cd | gammafunk | 2021-10-13 13:11:13 -0500 feat: Roomify Vaults branch Desolation entries Similar to what was done with 1b783e53 for Wizlab entries, move Vaults branch Desolation entries into rooms. Add floor border to some entries so they work better as Vaults rooms. This border won't cause any issues for placement outside of Vaults (i.e. in Elf), so I'm not going to CLEAR it outside of Vaults branch. One entry is a large diamond shape that won't work terribly well as a Vaults room, so it has 0 weight only for Vaults. -------------------------------------------------------------------------------- df74fcfb57 | gammafunk | 2021-10-13 13:10:30 -0500 feat: Move Vaults branch Wizlab entries to rooms Currently, Wizlab entries in the Vaults branch place through the normal CHANCE method as minivaults, but non-room vault placement doesn't work well in Vaults. These vaults routinely destroy parts of the Vaults layout, making the room vaults placed by the layout less effective. In the worst case, ghost vault rooms can be partially broken, releasing the ghost vault contents into the level without player interaction. This commit does for Wizlab entries the same thing as was done for ghost vaults: give them a special tag and Vaults room generator that applies the desired chance, placing the entries as rooms if the chance is successful. We use the existing entries by modifying the setup function. No layout changes were necessary to adapt these vaults into Rooms, but I did clean up the decorations in mu_enter_wizlab_7 to be more Zot-like and reglyphed and cleanup up a couple other vaults. and making some slight changes to Wizlab entry vaults where necessary. -------------------------------------------------------------------------------- a7a6a45411 | gammafunk | 2021-10-13 11:34:25 -0500 fix: Generalize a vault depth range Use depth ranges that don't indirectly reference branch length. -------------------------------------------------------------------------------- faba86c3f8 | gammafunk | 2021-10-13 11:34:25 -0500 feat: Merge door vaults maps For the variations of door_vault placing in the Vaults branch, we previously had separate vaults for these. Similar to to the ghost vault merge done in 17de5e6, this commit merges the Vaults branch variants into their parent vaults, adjusting the parent to have a ring of floor tiles and the necessary tags. -------------------------------------------------------------------------------- 71136c5590 | nicolae-carpathia | 2021-10-12 13:07:34 -0400 Slightly improve documentation for vault ORIENT: statement -------------------------------------------------------------------------------- 66cdd625d7 | advil | 2021-10-12 10:05:19 -0400 fix: condense logging on webtiles connection timeout Based on 7bb4a8268b, one thing I can say is that in Tornado 4+, when a timeout finally reaches the point of closing out the socket, there can be a really large number of async write Futures waiting to be failed, that all get their callbacks triggered within a few ms of each other. This situation in and of itself indicates some issues in our code, e.g. one culprit apparently is lobby messages, which look to be really inefficient and scale badly with the number of players on the server. However, it seems possible here that the server thrashing conditions are triggered by just too much logging in response to this sudden burst of callbacks. I still haven't replicated any of this locally, so this is all somewhat speculative. However, for exceptions indicating that the connection is closed, now that I have seen some logging, I don't think there's a huge need to keep the verbose logging on (it can always be restored if I need more data). This commit logs just the first one, and keeps track of the total number of failed callbacks on connection end, printing that in the final close message. Regular exceptions will still be fully logged, if they happen. This commit also adds correct handling for StreamClosedError in tornado 4. -------------------------------------------------------------------------------- 4eb62b627b | advil | 2021-10-11 22:30:09 -0400 fix: remove debug code oops -------------------------------------------------------------------------------- 7bb4a8268b | advil | 2021-10-11 22:28:55 -0400 feat: more debugging info for Future exceptions This is aimed at debugging CAO thrashing on disconnects, which I can't replicate locally. This leads to extremely spammy debug messages when this issue happens, so may need to be reverted, but this should be quite rare in normal circumstances. -------------------------------------------------------------------------------- 7e9dba17c3 | Kate | 2021-10-11 00:04:19 +0100 Shorten some welcome messages So that they'll fit on a single line in the message area. -------------------------------------------------------------------------------- 885e983cc2 | Kate | 2021-10-10 23:29:32 +0100 Update CREDITS.txt -------------------------------------------------------------------------------- 1c50d1d167 | Perry Fraser | 2021-10-10 23:28:39 +0100 Fix: redraw tiles when breath ability gained (#2142) Before, until TilesFramework::update_tabs() was called, the tiles abilities pane would not appear when receiving your first ability by way of draconian breath. This amends that by calling layout_statcol when Draconian maturity is reached. -------------------------------------------------------------------------------- 770bde8897 | Perry Fraser | 2021-10-10 23:28:26 +0100 Fix: don't list walljump twice in the ability pane while silenced (#2121) Closes #2120. -------------------------------------------------------------------------------- 2b6bb2fd11 | Kate | 2021-10-10 21:33:44 +0100 Don't let grunt_zot_stairs_overgrown turn orbs of fire into oklobs Fixes a Zot stair vault being able to turn any monster into an oklob if it's standing in one of the spots where a valid plant used to be. -------------------------------------------------------------------------------- 0d26b95db6 | Kate | 2021-10-10 17:24:45 +0100 Let monsters use potions of brilliance -------------------------------------------------------------------------------- ad9de1bfc8 | Kate | 2021-10-10 17:07:06 +0100 Don't let monsters read scrolls while unable to speak Scroll-reading was prevented under silence, but not when engulfed or muted by Zin recite. -------------------------------------------------------------------------------- c2b38c0785 | Kate | 2021-10-10 17:07:06 +0100 Adjust some monster emergency spells Remove Minor Healing and Invisibility from a few books that were already quite full or where they weren't likely to be relevant (orc high priests, sphinxes, and deep troll shamans lose Minor Healing, and necromancers and the Enchantress lose Invisibility). -------------------------------------------------------------------------------- 33d3b24fc1 | Kate | 2021-10-10 17:07:06 +0100 Remove some unused handling for monster scroll use Pacified monsters would in theory try and use scrolls of blinking and teleportation, but the scroll use check also required them to have a foe nearby, which would never be the case. -------------------------------------------------------------------------------- e0297cdf13 | Kate | 2021-10-10 17:07:01 +0100 Remove Teleport Self as a monster spell The timely follow-up to 9d39c9a61c - only Sonja, Prince Ribbit, and Maurice were left using it, and for all of them it was still unlikely to be particularly interesting to deal with. -------------------------------------------------------------------------------- 84cb2ea78e | Kate | 2021-10-10 01:44:07 +0100 Reduce the electrocution brand's chance to trigger Electrocution highly overperforms as a weapon brand - not only is it rare for monsters to resist it, its damage was high enough to compete with multiplicative brands such as vorpal/freezing/flaming even on larger, slower weapons. Reduce its chance to trigger from 1/3 to 1/4 per hit, to make it slightly less of an obvious best choice. -------------------------------------------------------------------------------- 587649e3ce | Kate | 2021-10-10 01:44:07 +0100 Let LRD work on permarock walls Since the main function of permarock is just to be indestructible, and LRD no longer destroys walls. -------------------------------------------------------------------------------- a6156daa3a | Kate | 2021-10-10 01:42:58 +0100 Make Demonic Touch's attack chance independent from str/dex Give it a fixed 2/5 chance to trigger, rather than the standard str/dex check followed by a 1/2 chance, since its damage is also independent from stats and other bonuses. The aux attack still has to successfully hit the target (and uses the normal tohit calculations), but should now be more effective early, before the main draw of the vulnerability effect shows up. -------------------------------------------------------------------------------- 1f24579cd5 | Kate | 2021-10-10 01:28:55 +0100 Clarify pain brand description for Djinn As with elemental staves, add to the description to indicate that spellcasting skill isn't good enough to make use of pain weapons. -------------------------------------------------------------------------------- d89666f14f | Kate | 2021-10-10 01:28:55 +0100 Allow training currently-useless skills with !XP And also allow toggling the display of base skills/enhanced skills. -------------------------------------------------------------------------------- 6c90c26265 | Kate | 2021-10-10 01:28:31 +0100 Fix targeting not being reset on phantom mirrored enemies Targeting was being reset on the caster instead of on the mirrored target. -------------------------------------------------------------------------------- da0c5dcf31 | Kate | 2021-10-10 01:15:32 +0100 Fix a KMONS line in nzn_ghost_randoct Looks to have been accidentally broken when the vault was refactored in 388b075d1f. -------------------------------------------------------------------------------- e759d193ff | Santiago Acosta | 2021-10-09 23:53:25 +0100 Fix some Phantom Mirror bugs Bug 1 is simple: When a monster casts phantom mirror on another monster, the casting monster is unentangled/unconstricted. This behaviour is unintended, as clearly, the monster being copied should be freed instead. Bug 2 is more subtle: When a monster is copied, its constriction status is not copied (as intended). However, the enchantment applied by BVC to indicate direct constriction IS copied. This results (in tiles) in a graphical bug, where the monster has the BVC icon, but can move around and act as normal. Closes #2122. -------------------------------------------------------------------------------- e5425f880d | Nikolai Lavsky | 2021-10-09 23:45:07 +0100 fix: add a usefulness check for Elyvilon's self-healing abilities Without such check, it's easy to over-heal and waste piety. Closes #2169. -------------------------------------------------------------------------------- 19d156f19b | Aliscans | 2021-10-09 23:45:07 +0100 Fix: Give useful notes when an ally dies. Previously, the death of a unique ally would be marked with the note "Your ally died". Insert the name of the deceased. Closes #2133. -------------------------------------------------------------------------------- 500345e458 | MainiacJoe | 2021-10-09 23:45:07 +0100 Take note when a Ds is revealed as monstrous [Committer's note: Monstrous status was tracked as a DGL milestone, but wasn't conveniently visible from in-game. Closes #2125.] -------------------------------------------------------------------------------- f509bdd586 | MainiacJoe | 2021-10-09 23:45:07 +0100 Take note when player prays at an ecumenical altar In the morgue, it will be referred to as, "the altar of an unknown god," since I've discovered that some players think the term, "ecumenical altar" refers to an altar in the Ecumenical Temple. -------------------------------------------------------------------------------- 0446da8ef9 | nicolae-carpathia | 2021-10-08 20:48:43 -0400 Add some entries to miscname.txt This includes entry messages for when you first arrive in the dungeon, along with some new adjectives for the Orb of Zot and also some new Halloween variants, which I hadn't realized were even a thing. Also includes some new messages for Hell effects. Fun times all around! -------------------------------------------------------------------------------- 0357d9c091 | nicolae-carpathia | 2021-10-08 16:48:35 -0400 Fix a Halloween typo, just in time -------------------------------------------------------------------------------- 4a3272bca7 | Nicholas Feinberg | 2021-10-08 11:26:41 -0700 Clarify Discord sleep failure (CarefulOdds) -------------------------------------------------------------------------------- 3c9886e45e | Kate | 2021-10-07 23:21:09 +0100 Add a missing comma (perryprog) And a related compile check. -------------------------------------------------------------------------------- 4e9751bbfc | advil | 2021-10-07 17:41:34 -0400 docs: remove an obsolete sentence in options documentation Since e74157ce7a5c and preceding commits, no artefact can be evoked in the way that the removed sentence was alluding to. -------------------------------------------------------------------------------- 35d0774509 | Kate | 2021-10-07 20:33:17 +0100 Fix an off-by-one error -------------------------------------------------------------------------------- 1ca825e530 | Kate | 2021-10-07 19:37:03 +0100 Add a compile check for some aux attack handling -------------------------------------------------------------------------------- e23450071b | Kate | 2021-10-07 19:32:26 +0100 Give monster draconians fixed colours per job While the draconian colour/job system works better than it did on monster demonspawn (since they're more noticeably differentiated by their breath weapons), it still allows for a very large set of possible monsters. Instead give every draconian job a single default colour when randomly generated: white = stormcaller, green = monk, purple = shifter, yellow = annihilator, black = knight, and red = scorcher. Pale and grey draconians already don't randomly generate. Vaults have been edited to stick to these combos, but in cases where the vault is self-contained and based on a specific theme they can manually override them (for example a fire-themed vault could place red draconians of any job, or a conjurations-themed vault could place annihilators of any colour, as long as the vault sticks to a single colour or job in each case). -------------------------------------------------------------------------------- 7f772adbe3 | Nicholas Feinberg | 2021-10-07 11:14:23 -0700 Add Sastreii to the dev team Welcome! 🎊 🎊 🎊 -------------------------------------------------------------------------------- baef9634d7 | gammafunk | 2021-10-06 11:44:22 -0500 fix: ghost vault logic The ghost vault logic changes in 17de5e62 were partially incorrect and messed up ghost vault placement. We need to have ghost vaults placing outside of the Vaults branch always set a CHANCE, but not set CHANCE for the Vaults branch. Furthermore ghost vaults exclusive to the Vaults branch should only exist as so-called Vault rooms in the file `vaults_rooms_ghost.des`. The vaults in this file have no set DEPTH so that they never attempt to place as minivaults but are still selectable by the `vaults_ghost` tag. However 17de5e62 had these vaults also set a CHANCE, which caused this to be applied to a default depth of *all levels*, even ones not included in the ghost vault range. Furthermore the conditional in `ghost_setup()` incorrectly didn't set CHANCE if the `vaults_setup` argument was true, even for ghost vaults that placed both in Vaults and outside of Vaults. This commit fixes these issues. For Vaults exclusive ghost vaults in `vaults_rooms_ghost.des`, we have them set a new `set_chance` arg for `ghost_setup()` to false to prevent setting the CHANCE at all. The vaults in this file thus only rely on the `vaults_ghost` tag to be used (and only in the Vaults branch). This argument defaults to true, so ghost vaults outside of this file will get their CHANCE set properly for non-Vaults branches. Furthermore we give any such vault a CHANCE weight of 0 specifically in Vaults. This prevents a ghost vault that places both outside of Vaults (as a CHANCE vault) and inside of Vaults (as a ghost vault room) from ever independently placing in Vaults branch as a minivault via CHANCE. -------------------------------------------------------------------------------- ad74161d1b | Kate | 2021-10-06 16:46:37 +0100 Don't crash on chardump after making tentacle attacks Caused by adding a new aux attack type but not handling it in action count displays, oops. -------------------------------------------------------------------------------- 539b0f7ac7 | Kate | 2021-10-06 02:29:16 +0100 Remove talons as a demonspawn mutation Unlike the other body slots with multiple options (horns/antennae, and now claws/demonic touch), there's no noticeable mechanical distinction between hooves and talons, and hooves are much more demonic. -------------------------------------------------------------------------------- 7b6c64ccd2 | Kate | 2021-10-06 02:12:21 +0100 Add a demonspawn gloves slot mut: demonic touch The demonic touch mutation grants an offhand touch attack which deals a small amount of irresistible damage (not increased by skills/stats, and not reduced by AC). At level 3 it blocks the gloves slot and also applies the vulnerability status effect for a short duration. -------------------------------------------------------------------------------- b5b0ca8da5 | Kate | 2021-10-06 02:12:21 +0100 Add a demonspawn cloak slot mut: weakening stinger The weakening stinger mutation gives demonspawn a tail and a stinger, granting a tail-slap aux attack. At level 3, it becomes large and sharp enough to block the cloak slot, and begins to apply the weakness status on hit (to all except undead and nonliving monsters). -------------------------------------------------------------------------------- 4e51291bfa | Nicholas Feinberg | 2021-10-05 16:44:15 -0700 Make berserk monsters break more doors This is pure theme, but it feels right, you know? -------------------------------------------------------------------------------- deb3d7f7b4 | Nicholas Feinberg | 2021-10-05 14:35:25 -0700 Supply Snake stone surfaces (Sastreii) ssssssss -------------------------------------------------------------------------------- ff9e726d5e | Nicholas Feinberg | 2021-10-05 12:05:35 -0700 Make Pacify give full XP As with Banishment, Pacification is already something the player dedicates significant resources to achieve - piety, mp, Invocations skill, a god... Getting half XP feels bad, and there's no balance requirement for it, so toss it. -------------------------------------------------------------------------------- 07eab104ef | Nicholas Feinberg | 2021-10-05 12:05:35 -0700 Remove portal mimics (hellmonk) A little bit too cruel. Timed portals are a fun minigame; having a chance of a no-prize isn't great. I'll add some kind of mimics somewhere else someday, Hep willing... -------------------------------------------------------------------------------- 3e9935cbe5 | gammafunk | 2021-10-05 11:42:59 -0500 fix: Correct a lua syntax error (Sergey) A bad search and replace, oops. -------------------------------------------------------------------------------- cfc00ec14d | Nicholas Feinberg | 2021-10-04 22:11:34 -0700 Solve the problem of evil Refactor away MH_EVIL to simplify the concept of holiness. -------------------------------------------------------------------------------- 6ae9c628c9 | Nicholas Feinberg | 2021-10-04 22:11:12 -0700 Fix monster sustain limit descriptions 'obsidian statue can sustain at most three...' -> 'The obsidian statue can sustain at most three...' -------------------------------------------------------------------------------- 3aaae7bc06 | Nicholas Feinberg | 2021-10-04 21:53:27 -0700 Don't color SH red while Petrifying? Since, per 7dc2aef8cabe0b31, Petrifying no longer disables SH. (Petrified does.) I couldn't make the coloring work while testing, but hopefully it does. -------------------------------------------------------------------------------- fe5b701de9 | Kate | 2021-10-05 01:08:41 +0100 Update some vault demonspawn The Pan Orc vault previously used non-monstrous base demonspawn, and Wucad Mu's monastery used monstrous base demonspawn. Re-stat the dummy demonspawn monster to have similar stats to old monstrous demonspawn and put them back in both vaults, reducing the number of other threats (knights, sorcerers and high priests) in the Orc end vault to compensate for the more dangerous demonspawn. Also restore these buffed demonspawn to the zombie spawn list. -------------------------------------------------------------------------------- b65a5730ee | Kate | 2021-10-05 01:08:12 +0100 Give demonspawn corruptors entropic weave Replacing their temporary malmutation, since there's a decent amount of permanent malmutation in Pan anyway, and corrosion is a more immediate and reliable threat. -------------------------------------------------------------------------------- 82a91f0f04 | Kate | 2021-10-05 01:08:12 +0100 Adjust demonspawn weapon sets Greatly trim down the list of weapons in the weapon sets used by demonspawn corrupters and black suns (keeping the same odds of them having a demon weapon). -------------------------------------------------------------------------------- b058677d0a | Kate | 2021-10-05 01:08:12 +0100 Remove monster icemail As with Ozocubu's Armour, giving monsters extra AC that sometimes melts isn't worth the extra complexity compared to just giving them the AC unconditionally. Demonspawn stats have been adjusted in the previous commit to be more appropriate per-class without the icemail bonus. -------------------------------------------------------------------------------- 10ef46f4bb | Kate | 2021-10-05 01:08:06 +0100 Simplify monster demonspawn Monster demonspawn using draconian-style colour/job combinations was flavourful but ultimately just made them overcomplicated, since base demonspawn were mostly unremarkable and didn't provide very meaningful distinctions other than monstrous demonspawn having much more health and damage than the rest. Instead remove all base demonspawn, and make each of the classed demonspawn effectively have a fixed base type: warmongers are monstrous (extra health, damage and 2 aux attacks); blood saints are infernal (rF+++, +3 AC and AF_FIRE attacks), black suns are gelid (rC+++, +6 AC and SInv), and corrupters are torturous (rN+++, +3 EV and 1 aux attack). They also all gain increased willpower, since previously classed demonspawn were (presumably unintentionally) inheriting the reduced willpower of their base type. The old separate base/job tiles have been updated and merged together by wormsofcan. Demonspawn bands are adjusted to contain a single greater demon and 1-2 other classed demonspawn. -------------------------------------------------------------------------------- 249bb1af34 | advil | 2021-10-04 17:30:12 -0400 fix: use correct keymap context for level maps (Nasst) This seems to have gotten lost in translation when this view was widgetified in 08ff59a6b337511f. I guess that indicates how much people actually use this feature. -------------------------------------------------------------------------------- 0edeeca3e2 | Kate | 2021-10-04 21:44:41 +0100 Tweak Call of Chaos effects again Move berserk to the list of rare "backfire" effects, since allied monsters are often spell-based, and the positive effects can already apply haste and might separately (but it's fun to have at least some chance of sending nearby demons berserk). -------------------------------------------------------------------------------- 9b3319b32b | Nicholas Feinberg | 2021-10-04 12:58:16 -0700 Don't let wandering monsters break doors Reduce ambient noise. -------------------------------------------------------------------------------- 992ecb606c | Nicholas Feinberg | 2021-10-04 12:55:12 -0700 Break doors less often To reduce incidental noise. 1/5 instead of 1/3 chance. -------------------------------------------------------------------------------- 388b075d1f | gammafunk | 2021-10-04 12:07:40 -0500 feat: Ghost vault adjustments This commit expands the placement of a number of ghost vaults, allowing them to place in Vaults as ghost vault rooms, and in some cases allowing them to place in additional branches. It also adjusts monster and loot placement for a few vaults. List of changes by vault: hellmonk_ghost_happy_afterlife: Allow this vault to place in all branches. It's pretty general, hence good to have in the set of simple ghost vaults that can place everywhere. Replace the second potion with a scroll. The former was itself a replacement for the removed ration, and while two potions works fine thematically, so does the idea of having good reading material for the afterlife. More loot variety is also nice. nzn_ghost_randoct: Allow this vault to place in Vaults. Also revamp its use of monster statues to consistently have a chance to place a relevant statue everywhere it places. Use orange crystal statues for later depths and retain its use of ice statue or oklob for Lair and earlier Dungeon. Make the use of branch-specific "boss" monsters more consistent in terms of how those are used along with multiple ghosts, so that we always have the chance to have up to three ghosts, instead of this limit being lower for some of the later placement depths. Refactor some of its conditional code. gammafunk_ghost_necromancy: Tweak its monster placement NSUBST to place more at minimum, but with the same average and clean up a few monster lists to pose a better threat for certain branches. gammafunk_ghost_ooze: Allow it to place also in Elf, Vaults, Depths, and Zot, choosing an appropriate slime distribution for each branch. Mix in some of the debuffing eye monsters. This vault began with a specific "death" theme using nothing worse than death oozes, but those are gone, so just go with the more general theme of Slime Pits monsters. gammafunk_ghost_mausoleum: Allow it to place also in Spider and Vaults, using appropriate undead for those branches. Tweak the Zot derived undead list to use only a few choice monsters. biasface_ghost_orc_armoury: Add two good potion or scroll loot items that places sometimes for D:14-15 and always for Vaults. gammafunk_ghost_smash: Allow it to place also in Vaults and Depths. Rework the good weapon equipment of the highest tier monsters to sometimes include giant (spiked) clubs. Introduce fire giants, frost giant, ironheart thundehulks, and iron giants, using them appropriately in the later placement Depths. gammafunk_ghost_wrathful_warriors: Allow it to place in Vaults. Tweak the monster equipment so that ranged weapons aren't used, since Trog no longer gifts launchers/ammo. Tweak monster lists to remove ranged-specific monsters. gammafunk_ghost_abyssal_escape: Allow it to place in Vaults. Improve the equipment given to certain distortion wielding monsters. Remove the Ring of the Hare as a potential loot item, as it now has no translocations theme. Remove trees from vault border, so it can't be broken into trivially. Mark the vault as `transparent` with the inner portions appropriately masked as `opaque`. hellmonk_ghost_big_iron: Allow it to place in Vaults and Crypt. Add some intermediate upgrading of hat quality. -------------------------------------------------------------------------------- 08eb9380c9 | gammafunk | 2021-10-04 12:05:03 -0500 feat: Improve a monster weapon selection function The function `dgn.monster_weapon` is used to give vault monsters higher quality weapons appropriate to their function. Add one-handed and two-handed classes for "warrior" and "knight" to allow vaults using this function to specify the handedness of the desired weapon. This is useful when when the original monster always recieves a weapon of a specific handedness, e.g. tengu monsters always have a buckler and ancient champions always use a two-hander. Update a few ghost vaults to use these new classes where appropriate. -------------------------------------------------------------------------------- 17de5e62ec | gammafunk | 2021-10-04 12:04:45 -0500 feat: Simplify Vaults branch ghost vaults Currently for ghost vaults in the Vaults branch, we maintain separate copies of existing vaults. This was done because Vaults branch ghost vaults must be defined as so-called vault rooms that have special tagging and, in some cases, changes to layout relative to the original ghost vault. However in all cases this wasn't actually necessary, since the original vault could have relatively minor modifications allowing it to be uses as-is in both branches. This commit merges the Vaults branch vaults back into the original vaults, mainly by copying over any Vaults-specific monster and loot definitions and by generalizing the ghost vault setup code to do any required Vaults branch tagging and setup. We remove the `vaults_ghost_setup()` function, and modify `ghost_setup()` to have a boolean argument that performs any setup related to the Vaults branch when the argument is true. We also modify the terrain of these vaults to give more spacing near areas that could create single square corridors should the vault place as a Vaults room. In some cases this just adds a row of floor near the vault entrance, but other vaults need an addition border of floor to surround the entire vault. Transporter vaults are now marked `passable` (for Vaults) and `transparent` with relevant sections masked with `opaque`. The transparent/opaque masking isn't required, but helps the layout code properly determine the vault's connectivity. The ghost vault setup function is now documented. The ghost vault guidelines will be updated in the future. -------------------------------------------------------------------------------- d048e4c10b | gammafunk | 2021-10-04 06:55:55 -0500 fix: Rework the border of a ghost vault In ebering_ghost_funeral_grove, the vault border is made of trees with a destruction veto. This isn't revealed to players except when they attempt to destroy the tree, which is spoilery. Additionally it has odd gameplay side effects with respect to certain spell effects. This commit adds a border of stone to the vault, retaining the use of trees for the vault's interior, and removes the tree destruction veto. The vault's theme still very much comes across with this change. -------------------------------------------------------------------------------- afb812fb24 | gammafunk | 2021-10-04 06:55:55 -0500 feat: Move a Shoals-only ghost vault to shoals.des Part of a forthcoming reorganization of ghost vaults. Now dat/des/variable/ghost.des is for ghost vaults that place in multiple branches. Similarly to how we handle other vaults, any ghost vaults that place in only one non-Dungeon/Depths branch go in the respective branch file. -------------------------------------------------------------------------------- 9f6c0e134a | Kate | 2021-10-04 03:12:00 +0100 Simplify Call of Chaos Greatly reduce the number of effects it can apply, to slightly reduce the interface burden of having to check lots of monsters for different status effects. -------------------------------------------------------------------------------- aa1e17a07e | Kate | 2021-10-04 03:09:31 +0100 Adjust Plane Rend and Forceful Invitation Tweak both branch-based summoning spells to be more distinct and to summon better threats. Remove Lair and Orc as options from Forceful Invitation, remove all the Lair branches from Plane Rend to focus it on the deeper branches, and adjust a number of the summon sets for both spells. -------------------------------------------------------------------------------- 8e0189d5dd | Kate | 2021-10-03 23:05:21 +0100 Make Zin and TSO more effective at cleaning up blood -------------------------------------------------------------------------------- 6fc52098c6 | Kate | 2021-10-03 22:08:30 +0100 Reword an unequip message -------------------------------------------------------------------------------- cf4520f741 | Kate | 2021-10-03 22:03:23 +0100 Disable more unrand-created allies when allies are forbidden So that reaping from Zonguldrok and demons from the obsidian axe are consistently blocked under both Ru's Sacrifice Love and Okawaru's no-allies conduct. -------------------------------------------------------------------------------- 20facfdd61 | Nicholas Feinberg | 2021-10-03 09:44:27 -0700 Disable Zonguldrok reaping under Oka (dilly) -------------------------------------------------------------------------------- 333b8329f1 | Nicholas Feinberg | 2021-10-02 20:35:27 -0700 Re-randomize energy temporarily While we continue discussion. We'll hopefully remove it again in a little bit. Reverts c20955654e95f046d01c06ff82ebef2e971ceded. -------------------------------------------------------------------------------- d698ae2ba6 | Nicholas Feinberg | 2021-10-02 20:00:55 -0700 Clarify Battlesphere description (kab) -------------------------------------------------------------------------------- c2ca4e2432 | Nicholas Feinberg | 2021-10-02 16:33:20 -0700 Refactoring -------------------------------------------------------------------------------- bdb9d174a4 | Nicholas Feinberg | 2021-10-02 13:46:38 -0700 Break doors In certain circumstances, it's possible for players to door-dance, repeatedly closing doors in the face of an enemy who then opens the door, etc. This allows the player time to heal and gives a decent chance the enemy will simply forget about them. There's already a chance for doors to creak, creating noise, but this has a very limited impact on the tactic. To weaken this somewhat (in context of recent changes to random energy), give a 1/3 chance of doors breaking whenever monsters open them. This turns them into 'broken doors', which can be re-locked by vault wardens but are otherwise useless. (If we simply destroyed the doors, players would be incentivized to repeatedly open doors until they broke in some circumstances in Vaults, to mitigate vault wardens.) This should have fairly little impact on most players, but it sure was a pain in the butt to make crude sprites for. -------------------------------------------------------------------------------- c20955654e | Nicholas Feinberg | 2021-10-02 13:46:38 -0700 Remove random energy Random energy has a long and dismal history. It was invented as a means to discourage repetitive and boring play patterns (pillar-dancing, door-dancing, break-dancing, etc), but signally failed to do so. Instead, it obfuscated game mechanics, added situations that felt 'unfair', and generally kludged everything up. It was a bold experiment, but it's been clear for many years now that it's failed. Let's move on. -------------------------------------------------------------------------------- 0594cd7a83 | Kate | 2021-10-02 18:17:59 +0100 Prompt when trying to Drain Life with no valid targets This could probably use a proper targeter, too. -------------------------------------------------------------------------------- f117bdfcbe | Kate | 2021-10-02 17:54:14 +0100 Fix Drain Life tracer -------------------------------------------------------------------------------- 36912a808a | Kate | 2021-10-02 17:46:23 +0100 Fix Drain Life working on firewood -------------------------------------------------------------------------------- 98e7288b7f | Nicholas Feinberg | 2021-10-02 09:42:27 -0700 Fix piercing allies (dilly) 98ec5579a34455a245d inadvertently disabled piercing for all allies with beam-type attacks (lightning spires, merfolk javelineers, etc). -------------------------------------------------------------------------------- a2639ab843 | Nicholas Feinberg | 2021-10-01 17:00:07 -0700 Power up a leggy boy (Sastreii) New Gloorx Vloq tile. Did you know that Gloorx had spooky shadow shoulder tendrils this whole time? I didn't! -------------------------------------------------------------------------------- b15b5f7f7d | Kate | 2021-10-02 00:13:08 +0100 Adjust some demon resistances Remove rPois from hell hounds, as with all the other demons that are closely related to living creatures, and give hell hogs fire immunity. -------------------------------------------------------------------------------- 717728bcc0 | Nicholas Feinberg | 2021-10-01 09:17:22 -0700 Restore treeform rTorm Broken by 662dcd36ddf41f5a366a00f7f19567d347cff114 . See comment about some issues here. -------------------------------------------------------------------------------- b193047a1f | Kate | 2021-10-01 01:57:06 +0100 Tweak wording -------------------------------------------------------------------------------- 6b7ffc0d7b | Kate | 2021-10-01 01:46:25 +0100 Fix Pacification working on sleeping undead Caused by 70bc44f8 changing the pacification check to look specifically for the "sleeping" status (applied to natural, holy and demonic monsters), but not the "dormant" status (applied to undead, nonliving and plant monsters). -------------------------------------------------------------------------------- 738fa26ca9 | Kate | 2021-10-01 01:46:25 +0100 Improve Pacification failure messaging -------------------------------------------------------------------------------- d1ff7b2e8d | Kate | 2021-10-01 01:46:25 +0100 Make Elyvilon care about plants Lets Elyvilon lifesaving work on plant allies, and lets Pacification work on intelligent plants - most plants are mindless so still can't be affected, but thorn hunters (animal intelligence) and shambling mangroves (human intelligence) can now be pacified. -------------------------------------------------------------------------------- 399c192ba0 | Kate | 2021-10-01 01:39:43 +0100 Don't consider worshippers of good gods as innately holy beings Separates out checks that should care about innate holiness (obtainable only by being a literal angel, daeva etc) from things that should care about whether something is merely a priest of a good god. Fixes some theoretical weird edge cases such as nonliving monsters being also considered holy if they worship a good god and for example, losing their innate fear immunity as a result. Ideally mon_holy_type should be further simplified and every monster (and the player) would innately fall into exactly one holiness category, with the MH_EVIL flag being separated out and handled elsewhere. -------------------------------------------------------------------------------- b600878595 | Kate | 2021-10-01 01:39:43 +0100 Remove holiness restrictions from Intoxication and spores The other existing limits on these abilities still make sense without them them being usable on natural holiness only, so remove the holiness restriction and make them a little more flexible. Alistair's Intoxication now affects any intelligent monster that isn't poison-immune, so can now affect many demons and holies, and intelligent plants (which is currently only shambling mangroves), although these mostly do have poison resistance so are harder to affect. Spore explosions are now able to affect demons and holies, and still don't affect unbreathing monsters (undead, nonliving, and plants). -------------------------------------------------------------------------------- 662dcd36dd | Kate | 2021-10-01 01:39:38 +0100 Don't give plant holiness monsters innate rN+++ Since plants are now a set of actual monsters instead of only decoration, it feels odd that they're living creatures but can't be affected by draining or negative energy. Remove their innate rN+++, but keep their torment immunity (since it makes more sense that pain-flavoured effects wouldn't work). Other draining-flavoured effects that previously only worked on natural monsters now work on plants, too - including Scythe of Curses miscasts, vampiricism, and Ghoul health-on-kills. Withered plants in Crypt/Tomb keep their rN+++. Firewood in particular remains unaffected by vampiricism, to prevent decorative plants being available for free healing. -------------------------------------------------------------------------------- 070a2a64fb | Kate | 2021-10-01 01:25:43 +0100 Allow demons and holies to be feared/berserked As part of an effort to reduce the number of effects that are restricted to natural monsters only, to increase some of the distinctions between undead/demonic/nonliving holinesses, and to allow some more flavourful interactions. Lore-wise, demons and holies are supposed to be of similar stock aside from their god alignment, so are grouped together here. They're also established to be like living creatures in a number of ways - they're generally intelligent, can be poisoned, and have souls, so it feels appropriate for them to feel emotions in some way and be able to go berserk and be feared. (Importantly this also allows the zealot's sword to send divine allies berserk, for any TSO worshippers who happen to find it.) -------------------------------------------------------------------------------- 2d0446b249 | Kate | 2021-10-01 01:21:04 +0100 Display torment immunity in monster descriptions Since it's separate from negative energy resistance/immunity. -------------------------------------------------------------------------------- 575fbe42a6 | Kate | 2021-10-01 01:21:04 +0100 Let frenzy apply haste/might to all affected creatures Previously it could affect creatures of any holiness, but only natural holiness creatures were hasted/mighted. Instead make it work the same way on any affected creature. -------------------------------------------------------------------------------- 544b704789 | Kate | 2021-10-01 01:21:04 +0100 Simplify mass enchantment handling Remove a lot of old code for now-unused mass enchantments, and some old assumptions about what can be affected. Should also fix messaging around firewood when using a scroll of fear. This could still use some more substantial refactoring ideally! -------------------------------------------------------------------------------- 5885fe61e5 | Kate | 2021-10-01 01:21:04 +0100 Rebrace -------------------------------------------------------------------------------- 7719699fd9 | Nicholas Feinberg | 2021-09-30 07:54:26 -0700 Upgrade ghost sewer tiles -------------------------------------------------------------------------------- d7573fbb20 | Nicholas Feinberg | 2021-09-30 07:50:38 -0700 Fix sewer entry c tiles (12653, Majang) Broken in 115e938b4e1d6. -------------------------------------------------------------------------------- f77a47075d | Nicholas Feinberg | 2021-09-28 20:05:50 -0700 A few more minor doc fixes -------------------------------------------------------------------------------- 911e869b65 | Nicholas Feinberg | 2021-09-28 20:03:24 -0700 Update background creation guide -------------------------------------------------------------------------------- c72452776e | Santiago Agustín Acosta | 2021-09-28 13:29:05 -0400 feat: improve archer description (#2164) Improves the description given for for monsters bonus damage in 619f226: the goal is to make it easier for the player to understand what damage will be gone if they get the monster to stop attacking with ranged weaponry, and to convey the damage bonus for thrown ammo as well as launched. [commiter's note: light commit message edits] -------------------------------------------------------------------------------- 173413878b | Nicholas Feinberg | 2021-09-28 08:29:57 -0700 Clarify *Rage desc (kate) -------------------------------------------------------------------------------- fb8421d2c4 | Nicholas Feinberg | 2021-09-28 08:04:35 -0700 Revert: "Revert "fix: Clarity once again blocks *Rage"" Now that Chei doesn't give penance for getting mad, but instead only gets even (see 2dc4ca50970f), we can once again treat berserkitis and artefact rage as unintentional and let Clarity prevent it properly. This matches player intuition ('clear thoughts' do seem like they should prevent gettin real salty). Balance implications should be minimal. Reverts 35c06b56. -------------------------------------------------------------------------------- 619f226d55 | Nicholas Feinberg | 2021-09-28 07:42:08 -0700 Describe archer bonus damage When a monster with the archer flag is wielding a ranged weapon, show the bonus damage it gets from that in its description. -------------------------------------------------------------------------------- aa5fe0c46d | Nicholas Feinberg | 2021-09-27 21:42:46 -0700 Make shard shrikes battify after shooting The design intent was always for these lil guys to wander off after hitting OR shooting, but I never bothered checking to see if it actually worked. It didn't! But now it will. This is probably a minor nerf, since they'll spend a couple turns wandering around instead of hitting or shooting after they shoot you. If players think they're too weak now, something can be arranged. -------------------------------------------------------------------------------- ab23d0e057 | Nicholas Feinberg | 2021-09-27 21:22:20 -0700 Consider *Rage a bad prop Randomly berserking is very likely to get you killed. It is funny, though. -------------------------------------------------------------------------------- 4a18f0a723 | Nicholas Feinberg | 2021-09-27 21:21:37 -0700 Actually really remove +Rage It was 'removed' but was still generating on randarts, resulting in randarts with few or no props. -------------------------------------------------------------------------------- 4214526f7d | Kate | 2021-09-28 02:17:04 +0100 Rebrace -------------------------------------------------------------------------------- 9c95886402 | Kate | 2021-09-28 02:16:23 +0100 Don't place shafts in the Abyss with Rising Flame -------------------------------------------------------------------------------- 3153ac1ab2 | Kate | 2021-09-28 02:16:02 +0100 Cancel Rising Flame on abandoning Ignis -------------------------------------------------------------------------------- 18fa513841 | Kate | 2021-09-28 02:14:24 +0100 Mark amulets of faith as useless under Ignis Since they have no effect. Also de-duplicate the code handling this. -------------------------------------------------------------------------------- 5d3631ad8e | Kate | 2021-09-28 00:43:42 +0100 Fix spectators having the wrong species -------------------------------------------------------------------------------- 34f850c0d2 | Kate | 2021-09-28 00:17:16 +0100 Make Okawaru Arena spectators into real monsters Rather than vault renames of humans. Doing so allows fixing a few edge cases - they have no attacks and give no XP, and can no longer be recalled into duels by convokers, they're given higher HD so that they're more likely to notice that a duel is happening if the player is very stealthy, and they no longer appear in the monster list. -------------------------------------------------------------------------------- 0384439e04 | Kate | 2021-09-27 22:58:34 +0100 Spread out *Rage's randart weight slightly With the removal of evokable berserk, *Rage had quite a high weight compared to other negative properties - instead spread out a bit of its weight to *Noise and Fragile. -------------------------------------------------------------------------------- b1a8950f57 | Kate | 2021-09-27 19:13:53 +0100 Reglyph some snakes and eels Move eels off ; and onto S, since they were the only remaining monster using ; as the ancient "fish/water monster" glyph (and this frees up ; for walking tomes). To make room for eels and also to improve visibility of some other monsters, also shuffle around some colours: Electric eel: lightblue ; -> lightcyan S Sea snake: lightcyan S -> lightred S (for better visibility in water) Lava snake: lightred S -> yellow S (for better visibility in lava) -------------------------------------------------------------------------------- 7ee5da7d44 | Kate | 2021-09-27 19:13:53 +0100 Replace a hardcoded number with its #define -------------------------------------------------------------------------------- 5a15c83aae | Kate | 2021-09-27 19:10:44 +0100 Display some attack flavours in the monster list Specifically reaching, constriction and trample - chosen because they're the three attack flavours that carry over to derived undead, and getting information on which zombie out of a group of zombies has a certain attack flavour is very awkward. For other attack flavours, players can at least be sure that a certain tile or glyph represents one specific monster and so will have one specific set of attack flavours, whereas derived undead are only distinguished by size in console or body shape/genus in tiles, which isn't sufficient to communicate what they can actually do. Other ideas on how to better display this information would be welcome, since this change on its own isn't enough to properly address the problem. -------------------------------------------------------------------------------- 207b005307 | nicolae-carpathia | 2021-09-27 08:17:00 -0400 Make edits to some vaults based on comments Made some changes based on ebering's comments: nicolae_coc_kraken_the_ice: change kraken undead to just simulacra nicolae_coc_caroushell: set WEIGHT to 2 nicolae_coc_on_the_berg: mark fog machine origins with shallow water nicolae_coc_wendigon: add { nicolae_geh_tyrants_menagerie: remove hell hounds and narguns nicolae_hells_demon_pit: branch conditions for demons nicolae_hells_seeping_fissure: branch conditions for cloud types nicolae_hells_slight_mixup: remove mismatched weapons, renamed to nicolae_hells_giants_party, made it oriented centre nicolae_tar_fifth_circle: chance to place toxic bog instead of W -------------------------------------------------------------------------------- ff8c9aff81 | nicolae-carpathia | 2021-09-27 08:17:00 -0400 Add Gehenna lava maze vault This vault has enough subvaults that I gave it its own file. I think this makes three files in /branches/ just for my own vaults. Also there's a checkwhite in here somewhere. -------------------------------------------------------------------------------- 40b5bdf05a | nicolae-carpathia | 2021-09-27 08:17:00 -0400 Move multi-Hell vaults to their own file Move vaults that are intended to place in multiple Hells into their own file in /dat/branches/, called hells.des. -------------------------------------------------------------------------------- c41377e160 | nicolae-carpathia | 2021-09-27 08:17:00 -0400 Add new vaults to Tartarus new vaults. decor. encompass. monsteriferous. somehow, my willpower to write this commit has been halved... -------------------------------------------------------------------------------- 4fe6ac43cf | nicolae-carpathia | 2021-09-27 08:17:00 -0400 Add new vaults to Cocytus As before: cool new vaults of all kinds for the smaller new Cocytus. -------------------------------------------------------------------------------- 1f62ee5ebf | nicolae-carpathia | 2021-09-27 08:17:00 -0400 Add new vaults to Gehenna Like the previous commit, a selection of decor, monsteriferous, and encompass vaults for the new, smaller Gehenna layouts. -------------------------------------------------------------------------------- 5ae6719378 | nicolae-carpathia | 2021-09-27 08:17:00 -0400 Add new vaults to Dis New vaults for Dis, designed to work with the new monsters and smaller level layouts. Decor, monsteriferous, and encompass vaults are all here. -------------------------------------------------------------------------------- 3bccd9ccbf | Neil Moore | 2021-09-26 18:19:18 -0400 Minor changelog fixes [skip ci] -------------------------------------------------------------------------------- 4f1c8046e5 | David Damerell | 2021-09-26 13:53:42 -0500 Recite to the correct group (12652) Commit 5f4c38d67a61b9ac2c9eef99dcee94b507b00502 changed the ordering of items in enum recite_type but did not notice the choice of sinners, sins, and virtues in zin_recite_text() is dependent on this to, say, complain about amorphous wretches in a RECITE_CHAOTIC. [ Committer's note: thanks to stoat soup for the patch ] -------------------------------------------------------------------------------- 6f645e4c1d | Nicholas Feinberg | 2021-09-25 22:00:09 -0700 Rev up yaktaur tiles (Sastreii) New Revenant, Yaktaur & Yaktaur Captain tiles. You would not believe how much discussion there was about the revenant. LRD is a divisive subject... -------------------------------------------------------------------------------- 4b64996d49 | Nicholas Feinberg | 2021-09-25 21:55:30 -0700 Have ice statue, will travel (railbird80) Don't claim that stationary monsters can travel through anything, regardless of their habitat. Arguably I should still display their habitat and use a different word in place of 'travel', but I have a hard time imaginging when it would matter. -------------------------------------------------------------------------------- 9f97627e2a | Kate | 2021-09-24 22:12:40 +0100 Move revenants from L to z Since they're actual real spooky skeletons and can be affected by LRD, move them to the glyph specifically for skeletons. Also tweak their description to make this a little clearer. -------------------------------------------------------------------------------- 4d8ae7cab5 | Kate | 2021-09-24 22:12:40 +0100 Update some LRD colours Match the monster colour directly for a few crystal monsters that had different explosion colours. -------------------------------------------------------------------------------- 8885160007 | Kate | 2021-09-24 22:12:40 +0100 Give curse toes their own genus It's funny for them to be technically liches, but not actually good for the the theoretical case of a curse toe and a ton of liches coming into view, which would previously have grouped them all together into a single "comes into view" message. -------------------------------------------------------------------------------- af8216a34e | Edgar A. Bering IV | 2021-09-24 15:31:23 -0500 fix: correctly display and apply Dis corrosion -------------------------------------------------------------------------------- 3bad584f25 | advil | 2021-09-23 18:06:04 -0400 tile: octagonal wizmode ability tiles from Sastreii -------------------------------------------------------------------------------- 4b98be1b05 | Nicholas Feinberg | 2021-09-23 13:35:56 -0700 Buff walking tome XP Put em somewhere around lichen and titans, to match their intended threat level. -------------------------------------------------------------------------------- c9a36226f5 | advil | 2021-09-23 15:09:03 -0400 fix: tiles for wizmode terrain abilities Apparently people don't like question marks in their GUI. These break the octagonal ability tile convention, sorry. If someone has interest in making these into octagons, feel free. -------------------------------------------------------------------------------- f8e193620d | Edgar A. Bering IV | 2021-09-23 11:23:08 -0500 doc: update the changelog through 0.28-a0-524-g197395d739 -------------------------------------------------------------------------------- f0617a802e | Nicholas Feinberg | 2021-09-23 09:21:57 -0700 Fix a goofy message -------------------------------------------------------------------------------- 197395d739 | Nicholas Feinberg | 2021-09-23 09:06:12 -0700 Describe quicksilver bolt effects In the spell description. -------------------------------------------------------------------------------- 0e5110bbff | Nicholas Feinberg | 2021-09-23 08:34:33 -0700 Make Tiamat's tile more visible (Sastreii) "I'm a god. How can you kill a god? What a grand and intoxicating innocence..." Also change her to SIZE_LARGE to match her new tile. -------------------------------------------------------------------------------- 4794fbc64e | Nicholas Feinberg | 2021-09-23 08:30:00 -0700 Galvanize Sastreii's Monster Often incorrectly called just 'Sastreii'. -------------------------------------------------------------------------------- 115e938b4e | Nicholas Feinberg | 2021-09-23 08:12:54 -0700 Use new sewer tiles for sewer entrances This is information asymmetry between tiles and console, but it looks really cool. (Plus, ossuary entrances already do the same thing.) -------------------------------------------------------------------------------- fb1784a141 | Nicholas Feinberg | 2021-09-23 08:03:50 -0700 Hack: fix threat values 2eadbcdadce4 made late-game monsters worth much less XP, which made the game count them as unthreatening. This is unsound. Revert to the historical threat values. -------------------------------------------------------------------------------- bfeecf2fc5 | Kate | 2021-09-22 23:17:53 +0100 Give Blinkbolt a fixed LOS casting range It previously had a variable range based on power (copied directly from Lightning Bolt), but this was almost never actually relevant in practice - raiju and spark wasps always cast it at range 7, Storm Form would almost always have either 6 or 7 range for any character reasonably capable of casting it, and beasts from the box of beasts would almost always have range 7 except at extremely low power. Instead of keeping these barely noticeable range variations, simplify the ability and allow it to always be cast at full LOS range. -------------------------------------------------------------------------------- 36894cfc38 | Nicholas Feinberg | 2021-09-22 11:08:35 -0700 Nerf divine living tomes Drop them from 3-5 living spells per cast to 2-3, same as other tomes. Also fix descriptions for all living tomes being nondeterministic. -------------------------------------------------------------------------------- 4d5786efa1 | Nicholas Feinberg | 2021-09-22 08:59:59 -0700 Reduce javelin/boomerang generation Throwing weapons are intended to be an auxiliary tool for players to use tactically, not a primary 'killdudes' mechanism. They have LOS range and strong damage, so it's very important that there is a limited supply of these weapons. Shoals in particular broke this assumption. Javelineer bands provided huge numbers of javelins and boomerangs. Shoals generated more javelins than the rest of an average 3-rune game put together (!), and nearly as many boomerangs. Now that monsters have unlimited ammo, reduce most monsters' ammo generation considerably, along with a small tweak downward for random ammo stacks. This should help keep ammo limitations relevant for a 3-rune game. Urug and the Minotaur still get big javelin stacks, since that's their special thing. -------------------------------------------------------------------------------- 5a36c9af25 | Nicholas Feinberg | 2021-09-22 08:36:50 -0700 Brighten up husks' disposition Increase contrast vs swamp floor tiles. -------------------------------------------------------------------------------- c05233ca19 | advil | 2021-09-22 09:07:26 -0400 fix: add some numpad bindings for the skill menu Webtiles/console only (where the latter is extremely variable depending on TERM settings, as usual). Resolves #2117 -------------------------------------------------------------------------------- 0d7ab7f379 | Nicholas Feinberg | 2021-09-21 16:32:20 -0700 An immobile stone gathers much moss (Sastreii) New stone wall tiles for Swamp and Sewer. -------------------------------------------------------------------------------- 47465dbb04 | Nicholas Feinberg | 2021-09-21 16:22:53 -0700 Tweak orc weapon offsets again (ardl, gammafunk) -------------------------------------------------------------------------------- 960c72b710 | advil | 2021-09-21 10:27:04 -0400 fix: clean up failed crawl processes correctly in webtiles I think this should fix the lobby in scenarios we see where something goes very wrong with the webtiles server and the lobby ends up looking like there are many duplicate games. What was happening is that if an exception prevents the crawl process from starting altogether, the cleanup code was also throwing an exception on this first logging call because self.process was None. This prevented the inprogress file from getting removed, and the webserver's ongoing game table from getting cleaned up. This will unfortunately make it *harder* to see when a webtiles server is completely borked, so possibly something should be done about that. I did add an error message to the player when this happens. (In the process of adding this, I attempted to alleviate a race condition that was preventing exit dialogs from being shown when a process never started. Hopefully I did so correctly. Basically, multiple go_lobby messages in close timing will wipe out an exit dialog if it's already been shown.) -------------------------------------------------------------------------------- cc94558de3 | Nicholas Feinberg | 2021-09-20 21:35:55 -0700 Reduce delay for top-end twohanders It takes a ludicrous amount of XP to reach extremely high weapon skill in Dungeon Crawl, which made the rare top-end weapons (executioner's axes, lochaber axes and triple swords) hard to justify using. These are intended to be very exciting items, so it's sad that they ended up being 'traps' even for most characters that are interested in using their weapon type! In combination with the earlier XP curve changes, reducing delay by 1 aut each should hopefully make these weapons more viable for use in 3-rune games. New skill to mindelay: - Executioner's axe: 24 (was 26) - Bardiche: 24 (was 26) - Sword sword sword: 22 (was 24) -------------------------------------------------------------------------------- 2e89a317aa | AdamPG | 2021-09-20 21:35:55 -0700 Reduce the experience cost of high-level skills The cost of increasing a skill from 20 to 27 was more than the cost of increasing a skill from 0 to 20, making training extremely high level skills (e.g. for level 9 spells or slow two-handed weapons) a poor investment for most of the game. This commit makes the implicit quadratic-with-break-point formula explicit, and divides the break point contributions to skill costs above level 9 by 2. This has the following implications: * Skill costs up to level 9 are unaffected; * The new cost of skill level 15 is half-way between the old costs of level 14 and 15; * The new cost of skill level 20 is approximately the same as the old cost of skill level 19; * The new cost of skill level 27 is approximately the same as the old cost of skill level 25; * The decreases in costs are roughly equivalent to a +1 increase in aptitude by skill level 23, and the impact is always smaller than a +2 increase in aptitude. [Committer's note: code refactored.] Closes #1733. -------------------------------------------------------------------------------- 2eadbcdadc | Nicholas Feinberg | 2021-09-20 21:34:01 -0700 Cut late-game XP This commit reduces the total XP in a 3-rune game by about 20%, overwhelmingly concentrated in late-game areas. D and Lair are almost unchanged, while Zot loses about a third of its XP, for example. This should help compensate for impending apt changes, and also generally help with the late-game difficulty slump. -------------------------------------------------------------------------------- 902bb890a6 | Nicholas Feinberg | 2021-09-20 17:31:10 -0700 Flush some good art right down the toilet Repurpose last commit's Swamp wall tiles for Sewer. -------------------------------------------------------------------------------- c9b6b5e602 | Nicholas Feinberg | 2021-09-20 16:54:56 -0700 New Sastreii tiles (bloated husk etc) Also included are some Swamp tiles, but those are currently unused - I'm not sure what the best place to put them is. Maybe they should replace the existing rock tiles? -------------------------------------------------------------------------------- 9ecc6377bc | Nicholas Feinberg | 2021-09-20 16:46:12 -0700 Update battlesphere description (ardl) -------------------------------------------------------------------------------- 2d6a64c10f | Nicholas Feinberg | 2021-09-20 16:46:12 -0700 Fix Gozag player ghost speech (Spaninq) Oops! -------------------------------------------------------------------------------- f79e20f00e | Nicholas Feinberg | 2021-09-20 16:46:12 -0700 Fix Sting effect tile (spaninq) Oops! -------------------------------------------------------------------------------- 83f2989fac | Kate | 2021-09-20 02:14:13 +0100 Fix crashes when attempting to leave Zot For games where Depths was generated in a broken version, fix up the branch entry location for Zot and hopefully allow leaving the Zot again without crashing. -------------------------------------------------------------------------------- 6c43a8f463 | Implojin | 2021-09-19 21:46:17 +0100 fix: allow unrand air enhancer stacking (#2134) e08c5e17fd added an air enhancer to the amulet of the air, but unlike the rest of the spell enhancers in the game, it didn't permit stacking this with the elemental staff. This looks to me like an oversight rather than a balance issue, (especially given that you could still stack the amulet with a vanilla staff of air), so here's a fix. -------------------------------------------------------------------------------- eef7685dc3 | Implojin | 2021-09-19 21:45:30 +0100 Fix missing MUT_NOISE_DAMPENING punctuation (#2141) -------------------------------------------------------------------------------- 121bc3e445 | advil | 2021-09-19 12:32:23 -0400 fix: branch entry depths for zot and zigs This will ensure that zot entry actually generates. (I think it may also cause a fix up for any games without it on depths 4? Not sure.) -------------------------------------------------------------------------------- 516edc7163 | advil | 2021-09-19 11:35:43 -0400 test: tweak a bunch of CI test output * Remove the rng test, I think this is no longer needed * Apply some indents in a few cases * Remove most of the vault-related output; hopefully the failing seed number will be enough if this trips. This level of output was really from back when this test often failed. -------------------------------------------------------------------------------- 203a4d6027 | advil | 2021-09-19 11:35:34 -0400 fix: further update unique tests for shallower depths -------------------------------------------------------------------------------- 8b1ebaf2f3 | Nicholas Feinberg | 2021-09-19 08:17:04 -0700 ...fix the build? -------------------------------------------------------------------------------- 613524ee8a | Nicholas Feinberg | 2021-09-19 07:56:32 -0700 Shift orc weapons 1px left Feels better with their new beefy look. -------------------------------------------------------------------------------- 9bb89235eb | advil | 2021-09-19 10:33:11 -0400 fix: update fixup for depths portals to new values Also, comment on the code duplication. -------------------------------------------------------------------------------- e2d2658822 | Nicholas Feinberg | 2021-09-18 21:37:11 -0700 Fix the build Oops -------------------------------------------------------------------------------- 98ec5579a3 | Nicholas Feinberg | 2021-09-18 21:34:48 -0700 Make allies avoid shooting you (Torax) Use aimed_at_spot to have allies avoid hitting the player when they miss their actual target. Keep enemy & neutral behavior the same. It seems polite. -------------------------------------------------------------------------------- 3d4abc6862 | Nicholas Feinberg | 2021-09-18 21:09:52 -0700 Switch Sting back to its old tile The poison arrow is way too big and fancy for a level 1 spell. Partially reverts 3cb921fa598. -------------------------------------------------------------------------------- c732d1d4b8 | Nicholas Feinberg | 2021-09-18 21:06:04 -0700 Make Abyssal Knights a bit dumber Move 1 int into str and 1 into dex. They're no berserkers, but they're still not particularly inclined towards spellcasting, and they're weak enough that we might as will give them some slightly better suited stats. -------------------------------------------------------------------------------- 3788438092 | Nicholas Feinberg | 2021-09-18 21:04:35 -0700 Remove Tukima's Dance's power boost (hellmonk) Recent changes (removing monster weapon delay, allowing Tukima's Dance to affect ranged weapons) have made the spell much more powerful. It no longer needs the power boost it got when I originally rewrote it, so... let's toss it. -------------------------------------------------------------------------------- a22a9363c6 | Nicholas Feinberg | 2021-09-18 20:59:18 -0700 Ban channeling when you can't cast (gressup) Standardize and streamline. It might be helpful to have extra messaging here when you enter one of these states while channeling - it might be too easy to miss right now. -------------------------------------------------------------------------------- 706b79e7bb | Nicholas Feinberg | 2021-09-18 20:41:13 -0700 Remove tarantellas' bite Tarantellas are a perfectly fine monster and a great name pun, but their theme is extremely misleading. If a spider bites you, you'd naturally expect rPois to protect against the effects. But that's not how tarantellas work! Instead, make their attack a 'touch'. That should hopefully make their behaviour a little more intuitive, though I expect some people will still be surprised by the pure fact of them being spiders... -------------------------------------------------------------------------------- 2322c75162 | Nicholas Feinberg | 2021-09-18 20:36:22 -0700 Fix cloud targeters (CarefulOdds) They can't actually hit stuff through transparent walls. Broken since, god, 098d46cfcc740f maybe? Not sure, honestly. -------------------------------------------------------------------------------- 6302f7b1d6 | Nicholas Feinberg | 2021-09-18 20:25:47 -0700 Remove Depths:1 (mostly) Recent changes to differentiate Depths from Vaults caused it to become considerably more intense. That's not a bad thing! But 5 straight levels of powerful intensity are a bit much. Let's draw it down to 4. Vaults have mostly been adjusted, but I'm sure I missed a few. -------------------------------------------------------------------------------- c45d5503f1 | Nicholas Feinberg | 2021-09-18 20:04:29 -0700 Clarify Conjure Living Spells desc Specify which spells a given tome will create in the spell description. -------------------------------------------------------------------------------- e8cdce0153 | Nicholas Feinberg | 2021-09-18 19:56:12 -0700 Plop walking tomes in Depths Replacing the high tier deep elves, which still have plenty of other places to show up (Elf, Vaults:5, many vaults, etc). On average, looks like you'll see about two tomes per Depths. -------------------------------------------------------------------------------- a443631078 | Nicholas Feinberg | 2021-09-18 19:42:29 -0700 Make Blink Allies Encircling drain energy (ardl) Don't let enemies hit you on the same turn they get blinked encircling around you. It seems excessively cruel to be hit by 5 guys who weren't on screen the turn before. -------------------------------------------------------------------------------- f8b08d3f47 | Nicholas Feinberg | 2021-09-18 19:42:23 -0700 Axe ironbound beastmasters Ironbound beastmasters were a whole pile of cool ideas, none of which quite panned out. - They depended very heavily on their bands, which tends to work poorly (it's pretty common for monsters to get separated) - They had some hacks to guarantee they'd only generate with bands, which broke monster queries and still didn't prevent them from getting separated. - The effects of their spell was poorly communicated to players - the energy system is a very secret under-the-hood effect, unlike e.g. haste, which has a visible effect. - They weren't tuned to the point of being very strong. (This is the most fixable issue.) There was some discussion of replacing them with a summoner that calls and berserks harpies and such, and we could still do that. For now, though, let's roll back this experiment. Partially reverts 0b001bae985. -------------------------------------------------------------------------------- ea7fc97e4c | Nicholas Feinberg | 2021-09-18 15:42:34 -0700 Give orcs a workout (Sastreii) New basic orc and orc warrior tiles. -------------------------------------------------------------------------------- 4d16425fc6 | Nicholas Feinberg | 2021-09-18 15:38:30 -0700 Add a truly thrilling trio (Sastreii) -------------------------------------------------------------------------------- 5baa6b73be | Nicholas Feinberg | 2021-09-16 19:17:31 -0700 Spider stone sprites (Sastreii) SSSS SSSS -------------------------------------------------------------------------------- b47aa1321a | Nicholas Feinberg | 2021-09-16 17:55:39 -0700 Add a truly thrilling trio (Sastreii) New tiles: zombie human, elf, and ogre.n -------------------------------------------------------------------------------- 0b43c73ce0 | Nicholas Feinberg | 2021-09-16 07:38:35 -0700 Fix Ignis invocation frames (Sastreii) -------------------------------------------------------------------------------- 0f06bd746f | Nicholas Feinberg | 2021-09-15 17:11:03 -0700 New zombie tiles (Sastreii) Lizard and large and in charge. -------------------------------------------------------------------------------- 7dc2aef8ca | Nicholas Feinberg | 2021-09-15 08:03:36 -0700 Simplify Petrifying (dilly) Don't consider petrifying creatures to be fully incapacitated. This fixes a bug in which petrifying monsters couldn't shoot or throw (though they could still cast spells, attack, etc). It also allows all petrifying (but not petrified) creatures, monsters and players, to block attacks with shields, which probably doesn't matter that much. -------------------------------------------------------------------------------- 535839065c | Nicholas Feinberg | 2021-09-14 17:37:22 -0700 Fix slime wall death message Broken in e619aef00bffaae3f811d3ff97aa9ddea2c37f07. Oops! -------------------------------------------------------------------------------- 079b763570 | Nicholas Feinberg | 2021-09-14 17:24:39 -0700 Electrify cats and calamari (Sastreii) Two new species-specific Storm Form tiles. -------------------------------------------------------------------------------- 50180c0d78 | Nicholas Feinberg | 2021-09-14 11:39:27 -0700 Storm Form player tile (Sastreii) -------------------------------------------------------------------------------- 27616f31e4 | Kate | 2021-09-14 18:26:12 +0100 Don't crash when failing to pacify nothing Targeting empty space with pacification is allowed so that invisible monsters can be pacified, but doing so still costs a turn to avoid leaking information. However if the attempt to use the ability rolled a failure, it would instead crash when targeting an empty space due to a missing fail_check(). -------------------------------------------------------------------------------- 5218f81949 | Kate | 2021-09-14 18:26:12 +0100 Adjust some randart names Remove "of Battle" to avoid overlap with the unrand, and Australianise some spelling. -------------------------------------------------------------------------------- 5de4b4396b | Edgar A. Bering IV | 2021-09-14 09:17:37 -0500 fix: give seracall its own beam name -------------------------------------------------------------------------------- e8575c7553 | Edgar A. Bering IV | 2021-09-14 09:08:26 -0500 fix: restore berserk and confusion checks for evocables (12651) The misc evokers had confusion (but not berserk) checks in their specific methods, while wands had no checks at all. -------------------------------------------------------------------------------- 103e827438 | Edgar A. Bering IV | 2021-09-14 08:11:21 -0500 feat: replace hell contam with temporary mutations In the game of one of these things is not like the other, the contam hell effect produced permanent strategic damage, the other two produced XP gated strategic damage. Contam hits a few more things other than mutations (putting a brake on miscasts and preventing invis) but the interaction with the mutation system is the noticable part in hell. At the rate we'd like to apply hell effects, however, it gets to be a bit much in terms of permanent damage. So let's try temp mutations. -------------------------------------------------------------------------------- 5e7bb1d84c | Edgar A. Bering IV | 2021-09-14 08:11:21 -0500 feat: slow down hell effects Still trying to dial these in to a good place. The larger effects less frequently make for spikes, which are more exciting (do I gamble and press on I'm almost there) than smaller more frequent attrition. -------------------------------------------------------------------------------- e2dae52223 | Nicholas Feinberg | 2021-09-13 21:06:00 -0700 Remove unthings None of these placeholder monsters exist enough to even be used in vaults. -------------------------------------------------------------------------------- 0687ed57fd | Nicholas Feinberg | 2021-09-13 12:26:56 -0700 New randart name Specifically to break formatting. -------------------------------------------------------------------------------- 941f9de75c | Nicholas Feinberg | 2021-09-13 09:14:22 -0700 Reorganize Mlio Since it no longer appears in Depths. -------------------------------------------------------------------------------- 6aa5aab5a4 | Nicholas Feinberg | 2021-09-13 07:57:04 -0700 Remove an antique "faith special case (hellmonk) If you were at 15 piety or less when you removed the amulet of faith, you wouldn't lose any piety. This was introduced in the very first commit that added "faith, 5871154a2e, and has never really had a good reason to exist. Simplify. -------------------------------------------------------------------------------- 2dc4ca5097 | Nicholas Feinberg | 2021-09-12 21:19:52 -0700 Make Chei chill out Instead of being angry at berserk rage, just turn off the haste (as Chei already did when you quaffed un-id'd !zerk). In general, there aren't a lot of situations where divine penance for actions is more fun than your god just shutting things off. This (esp in light of recent changes to e.g. zerkitis) was no exception. -------------------------------------------------------------------------------- 91930fd77e | Nicholas Feinberg | 2021-09-12 20:11:38 -0700 Walking Tome tiles (Sastreii) Book it! -------------------------------------------------------------------------------- aa0f46ea79 | Neil Moore | 2021-09-12 21:33:22 -0400 Two new splash screens by KaoNedong Licensed under CC0. Source for the images: https://www.deviantart.com/kaonedong -------------------------------------------------------------------------------- 4afc6ae9f4 | Kate | 2021-09-13 00:20:54 +0100 Fix tag_upgrade compilation -------------------------------------------------------------------------------- ce0acab4f2 | Kate | 2021-09-12 23:52:33 +0100 Replace Leech's *Rage with Harm *Rage is a fairly severe downside and means the player should expect to berserk in every combat, which heavily limits the chances of any items with it from being actually used. It's very thematic on the Wrath of Trog and necklace of Bloodlust, and the zealot's sword also has a unique (although perhaps hard-to-utilise) interaction with berserk, but the other unrands with *Rage could use different downsides to encourage still using them. The hat of the Bear Spirit could use a new idea, but for Leech, replace *Rage with Harm (and drain-on-unequip to prevent it from being freely swappable). The only other use of Harm on an unrand is the robe of Misfortune, so Leech's guaranteed vampiricism seems like a fun place to encourage trying to work around Harm's downsides. -------------------------------------------------------------------------------- cbfb7e9818 | Kate | 2021-09-12 23:52:23 +0100 Remove the Elemental Staff's Will++ Since it doesn't fit the elemental theme, and it's now a pretty strong actual weapon on top of giving out a heap of resistances. -------------------------------------------------------------------------------- b5e7e19f26 | Kate | 2021-09-12 23:25:36 +0100 Give the *Rage inscription its star back Since the * is inscription-ese for "this thing triggers some random portion of the time when x condition is met" (as with *Noise, *Slow, *Corrode). -------------------------------------------------------------------------------- 73f125ba1b | Kate | 2021-09-12 23:25:19 +0100 Remove an unused parameter -------------------------------------------------------------------------------- 0f1c06f14f | Kate | 2021-09-12 23:25:12 +0100 Fix compilation -------------------------------------------------------------------------------- 2fb25c9035 | Edgar A. Bering IV | 2021-09-12 17:10:28 -0400 feat: combine berserkitis and item Rage The separate displays and (slightly) separate semantics for "go berserk on melee hit" confounded the issue, especially since berserkitis' chances are so small at low levels. This commit changes berserkitis to simply grant angry percentage points, identical to other sources of random berserk. It does mean that berserkitis now works through clarity and causes Cheibriados penance. This is consistent with the previous commits: berserkitis only triggers on melee attacks, which are intentional. If this is too severe some grace can be hacked in for Chei followers, but the fraction of characters that will find berserkitis much worse than they already do is tiny. -------------------------------------------------------------------------------- e692aea802 | Edgar A. Bering IV | 2021-09-12 17:08:49 -0400 feat: remove evoked berserk, increase *Rage berserk chance Step-by-step we have been cutting back on items that add active abilities to the 'a' menu: even with the quiver these abilities are often forgotten by players for ui reasons since they only come from artefacts (+Inv is the remaing exception) so aren't frequently encountered. A player can't forget to use a "passive" ego. *Rage was meant as a bad property. With a 5% chance to berserk it was small enough that one could take a swing here and there and not expect to berserk (making it an unreliable source of zerk), but large enough that a player trying to use it had to approach fights expecting to go berserk in every fight. This commit removes +Rage in favor of giving *Rage a greater chance to trigger berserk, currently 20%. This leans into the "always be ready to zerk", while being low enough that it's not a guaranteed immediate berserk in desparate situations. The insrcription is changed simply to "Rage". When it comes to changing unrands: - Leech and Bear Spirit might want lower (or 0) Angry values, but for now they both get the standard 20% for clarity; - the necklace of bloodlust, which has a swap penalty and extra zerk powers, gets a 50% zerk chance - the wrath of Trog, with its swap penalty, keeps its 50% zerk chance - the Zealot's sword gets the standard 20% chance; The chance contribution is shown in the item description, and the total zerk chance is shown in the character overview if nonzero. -------------------------------------------------------------------------------- d8b2e6da16 | Nicholas Feinberg | 2021-09-12 12:15:42 -0700 s/inflammable/combustible (FIQ) Reduce ambiguity about the meaning of FIRE_VULN. -------------------------------------------------------------------------------- a6d6528d93 | Edgar A. Bering IV | 2021-09-12 13:00:12 +0200 fix: clarify battlesphere description (12644) -------------------------------------------------------------------------------- 35c06b56df | Edgar A. Bering IV | 2021-09-12 12:59:05 +0200 Revert "fix: Clarity once again blocks *Rage berserk (Mantis 12640)" This reverts commit 51f8dfeb475ed0e39ea3046524384fdaf5c92adb. Commit 51f8dfe intentionally made *Rage on artefacts an intentional source of berserk, as equipping the item and attacking in melee is intentional, and otherwise Chei players could get access to penance free berserk (the hates item code is only for generating the warning prompt, penance comes from actually using it). This revert clarifies the description of *Rage to make it read as intentional source of berserk (like the potion or +Rage), which clarity does not block. It also displays the items contribution to the berserk chance, and makes these contributions linear so the probability is clear to players. -------------------------------------------------------------------------------- 1f95980246 | Nicholas Feinberg | 2021-09-11 21:32:30 -0700 Clarify Ash wrath (JF) -------------------------------------------------------------------------------- b986a403c0 | gammafunk | 2021-09-11 22:03:30 -0500 fix: Don't give cloud rings to friendly pan lords Before this commit, friendly pan lords from the Pentagram card could get cloud rings that would damage the player and their allies. Prevent this by passing the necessary attitude information to the ghost demon code we use to initialize pan lords. -------------------------------------------------------------------------------- 51f8dfeb47 | Seve Monahan | 2021-09-11 14:02:42 -0500 fix: Clarity once again blocks *Rage berserk (Mantis 12640) 516ec7 unintentionally caused *Rage to work on characters with Clarity. This is because 'intentional' rage bypasses Clarity, and 516ec7 caused *Rage berserks to be classified as intentional. Since 911e812, *Rage artifacts have been classified as intentionally hasty at all times. This has similar implications for Chei worshippers as 516ec7 was intending (i.e, Chei worshippers can't use *Rage artifacts without provoking penance). As a result, I do not believe any further changes to the Chei/*Rage interaction are necessary. -------------------------------------------------------------------------------- 34660d7429 | advil | 2021-09-11 13:03:29 -0400 fix: improve SIGHUP handling in clua code on dgl builds User lua that involved hand-rolled prompts could interact in a bad way with SIGHUPs, prevent the game from ever properly handling the HUP. The following example based on long-time crash generator `ziggurnaut` is a case in point: { function ready() force_prompt("asdf") end function force_prompt(text) while true do crawl.formatted_mpr(text) crawl.formatted_mpr("Type p", "prompt") res = crawl.getch() if string.lower(string.char(res)) == "p" then break end end end } If the player disconnects at the prompt, the `while` loop runs in a tight loop because getch returns immediately without a client, and the loop never exits on its own, so the HUP isn't handled. The webserver does detect this 10s or so later, and kills the process with SIGABRT, so the issue isn't catastrophic, but it still is 100% cpu for that time period and generates an annoying crash report in #crawl-dev. (For reference, the best thing to do here on the current API would be to also accept ESC (27) at any prompt implemented in a loop like this; getch returns ESC on disconnects. Or just use crawl.yesno instead of trying to write a custom one.) This commit piggybacks on the clua throttle code to check for HUPs if the throttle trips; if a HUP has been seen it immediately errors out of clua code, which leads to a graceful shutdown of the process. It's possible this could use its own separate hook (which would let it work by default on non-DGL builds as well, and possibly be checked more often), but the main problem here is on webtiles so I'm going with this more minimal solution for now. -------------------------------------------------------------------------------- 1af55ca459 | advil | 2021-09-11 13:03:29 -0400 fix: don't allow c_message reentry This hook is already pretty wild, given the arbitrary points where mpr can be called from, but it's additionally very, very easy to trigger recursion that would be infinite if it weren't for the lua stack limit. Depending on what happens this recursion can be quite cpu intense as well, even with the stack limit. This commit just prevents any recursive triggering of the hook in a heavy-handed way. (Overall, I find this hook quite worrying, and I suspect it still needs substantial auditing.) -------------------------------------------------------------------------------- 8072b577e9 | advil | 2021-09-11 13:03:29 -0400 fix: step up lua throttle aggressiveness On testing, a tight loop in ready() takes nearly 3 minutes to get killed by this on a fast cpu, and does still have a noticeable cpu impact until then -- I expect it'd be much worse on a busy server. This commit makes the throttle kill scripts much more aggressively, and also, if ready() in particular is killed by the throttle, keeps it from running again. If this runs up against legitimate online use we can adjust, but I really think it won't. I tested this on qw, and qw does trip the throttle but never more than ~4 times in a row at the absolute max. So 15 is still extremely conservative. It's possible that this could be tightened even further: e.g. by starting the throttle time at something like 128ms instead of 2, or by reducing the number of lua instructions this is checked between (currently defaults to 50000 I think). No impact outside of webtiles. -------------------------------------------------------------------------------- b603f484b2 | Nicholas Feinberg | 2021-09-11 08:15:45 -0700 Scorch and Flame Wave tiles (Sastreii) -------------------------------------------------------------------------------- e3cd3e9c68 | Nicholas Feinberg | 2021-09-10 20:00:27 -0700 Stoker tile (Sastreii) I'm stoked. Are you? -------------------------------------------------------------------------------- 4cf4cd4993 | Nicholas Feinberg | 2021-09-10 10:08:01 -0700 Dial down tile_show_threat_level defaults Only show on nasties by default. -------------------------------------------------------------------------------- 3d58a18ffd | Nicholas Feinberg | 2021-09-10 10:02:08 -0700 Ignis altar tile (Sastreii) -------------------------------------------------------------------------------- 3d5cecec24 | Nicholas Feinberg | 2021-09-10 09:15:51 -0700 Make a BIG removal Remove SIZE_BIG, switching monsters into either SIZE_LARGE or SIZE_GIANT as seems appropriate. Following up on 7bd0902ce6cc84c6, we really don't need two sizes that are 'bigger than any player race'. Is a yaktaur bigger than a centaur? How does a spatial maelstrom compare in size to a fire dragon? These are questions that we don't care about and shouldn't bother with. This is a small buff to dragon form and maybe a nerf to something else. Who knows. -------------------------------------------------------------------------------- 07589e2de0 | advil | 2021-09-10 11:58:17 -0400 fix: remove comma -------------------------------------------------------------------------------- 392f49ab0d | Nicholas Feinberg | 2021-09-10 08:40:45 -0700 Remove Okawaru Commander title (Graveyardigan) Since Okawaru now prevents you from commanding anyone. Toss in 'Myrmidon' instead, shifting "Warmonger" one higher. -------------------------------------------------------------------------------- 579aff930e | Nicholas Feinberg | 2021-09-10 08:23:57 -0700 Refactor Ignis quiver logic (advil) Allow quivering but don't do so by default. -------------------------------------------------------------------------------- 32eb216c14 | Nicholas Feinberg | 2021-09-10 08:22:35 -0700 Don't autoquiver wizmode abilities Makes testing default quiver stuff impossible. -------------------------------------------------------------------------------- e87aa7cc50 | Nicholas Feinberg | 2021-09-10 08:17:05 -0700 Default tile_show_threat_levels Experimentally set tough and nasty on by default, in an attempt to make it clearer to players when something spooky is headed their way. -------------------------------------------------------------------------------- 118590704b | Nicholas Feinberg | 2021-09-10 08:12:59 -0700 Ignis ability icons (Sastreii) Might want to recolor these or Trog's at some point to avoid overlap, but confusion doesn't seem very likely. -------------------------------------------------------------------------------- c56ee47f37 | Nicholas Feinberg | 2021-09-10 07:59:22 -0700 Searing Wretch tile (Sastreii) https://cdn02.plentymarkets.com/qozbgypaugq8/item/images/1625/full/PSTR-DOOM002. jpg -------------------------------------------------------------------------------- 1448048969 | Nicholas Feinberg | 2021-09-09 11:18:36 -0700 Turn down Hell effects Per popular demand. - Contamination down 25% (from 4-8k to 3-6k). - Stat drain down 33% (from 2-7 to 1-5). HP drain is unaffected. These numbers are still fairly arbitrary and remain subject to revision in either direction. -------------------------------------------------------------------------------- b8cf3755b2 | Nicholas Feinberg | 2021-09-09 11:13:25 -0700 Don't quiver Ignis abilities (various) Too pricey, too easy to misfire. Womp womp. -------------------------------------------------------------------------------- 6657d4870c | Nicholas Feinberg | 2021-09-09 11:09:26 -0700 Nargun tile (Sastreii) https://media.discordapp.net/attachments/747522859361894521/885578302797021234/S chermata_2021-09-09_alle_19.31.21.png -------------------------------------------------------------------------------- da42bb4400 | Nicholas Feinberg | 2021-09-09 07:46:38 -0700 Wendigo tile (Sastreii) when do they call it wendigo when you wendy go the cold food wendy go hot eat the food? -------------------------------------------------------------------------------- d0eccab798 | Nicholas Feinberg | 2021-09-08 11:45:25 -0700 Dragon cleanup (Sastreii) -------------------------------------------------------------------------------- b4fee303d0 | advil | 2021-09-08 14:17:11 -0400 fix: remove a book that required a lvl 1 hex This book placement is not saved by ffd9c288d6fe because there's nothing to reroll -- it'll crash unless there is a level 1 hex. Could be replaced? But for now I'm just removing it to fix crashing games. -------------------------------------------------------------------------------- af36da5c11 | Nicholas Feinberg | 2021-09-08 07:38:10 -0700 New Cactus & Manifold tiles (Sastreii) New tiles for the Manifold Assault and Summon Cactus Giant spells, along with a new tile for the Cactus Giant itself. -------------------------------------------------------------------------------- d71735cc25 | Nicholas Feinberg | 2021-09-07 15:54:29 -0700 Add Ignis altar description Oops! -------------------------------------------------------------------------------- d1dd6c5fb5 | hellmonk | 2021-09-07 14:04:56 -0400 feat: add an ambush vault to lair It's called ambush because there am a lot of bush. -------------------------------------------------------------------------------- 0c02eea278 | Nicholas Feinberg | 2021-09-07 09:16:54 -0700 New Kobold tiles (Sastreii) Goodbye, kobold vest. You will be missed. -------------------------------------------------------------------------------- 3dc288482e | Nicholas Feinberg | 2021-09-07 08:30:18 -0700 New zombie tiles (Sastreii) Gnoll, orc, wolf, bear, hydras. -------------------------------------------------------------------------------- 01ebcbcbcd | sdynet | 2021-09-07 08:16:38 -0700 Simplify the ranger card There are too many monsters with similar roles on this card. I want to cut out too many branches and leave only those who match the name of this card. Modified Effect: Now it summon only these three(centaur warrior, naga sharpshooter, deep elf master archer). -------------------------------------------------------------------------------- 4da15c877b | John Stahara | 2021-09-07 08:13:11 -0700 Accurately order a comment with the variables it describes -------------------------------------------------------------------------------- cae3918e47 | Perry Fraser | 2021-09-07 08:12:07 -0700 Improve Ratskin Cloak god interactions [Committer's note: - Don't allow the cloak to spawn rats that should hate you (hell rats under good gods, any rats under Oka or Sac Love) - Unmark the cloak as evil.] Closes #2102 -------------------------------------------------------------------------------- cf6c460519 | Nicholas Feinberg | 2021-09-07 07:59:26 -0700 Tweak Ignis wratch status msg (dilly) -------------------------------------------------------------------------------- 55a29874ef | Nicholas Feinberg | 2021-09-07 07:45:43 -0700 Make Scorch suitable for sauna use Create steam clouds when it hits someone in water, for consistency with other fire effects. -------------------------------------------------------------------------------- de365fb1df | Nicholas Feinberg | 2021-09-06 13:39:49 -0700 Cut Storm Form power scaling 20% It's a bit stronger than I intended at high power, partially because I got the math slightly wrong when setting it up. Let's scale it back somewhat. -------------------------------------------------------------------------------- 9c2f8b1708 | Nicholas Feinberg | 2021-09-06 13:15:01 -0700 Reduce Searing Ray power scaling Searing Ray is a fun and distinctive early-game spell. However, with the current damage values, it remains surprisingly effective well into Lair branches, reducing the need to branch out into new spells. To increase variety, let's keep the min damage the same while reducing the max damage about 25%, from 3d7 to 2d8. (Fewer dice should also increase variance, which is nice.) -------------------------------------------------------------------------------- ffd9c288d6 | advil | 2021-09-06 14:02:57 -0400 fix: reroll spell schools for crashing hex books After d4a3b56016 removed corona, there are currently no level 1 hexes. The vault spec randbook generation code did not handle cases where a vault spec could not find any spells at all, which happened for some early randbook placements that tried to include a single level 1 spell, if they rolled hexes after this change. This commit adds a somewhat convoluted means of rerolling the book discipline(s) if the first try fails. It does fix the version of this crash that I have replicated. -------------------------------------------------------------------------------- bef64dd269 | hellmonk | 2021-09-05 23:53:28 -0400 Rework the flesh golem This Cigotuvi wizlab monster is a reskinned iron golem, so it got buffed when they did. While a wizlab-depth player can certainly deal with a slow 300 hp monster, it feels pretty awful to have to do it. Lower it to ~100 hp and give it corrupting pulse so it has something to do besides walk slowly at you. -------------------------------------------------------------------------------- 6a72785379 | Nicholas Feinberg | 2021-09-05 10:59:27 -0700 End Ctouch on hitting will∞ (Graveyardigan) To save players who have made poor life decisions (e.g. casting Confusing Touch when going up against a fire elemental), make Confusing Touch end itself when you hit something that has infinite willpower (and hence can never be affected). -------------------------------------------------------------------------------- d4a3b56016 | Nicholas Feinberg | 2021-09-05 10:43:13 -0700 Make the hex 'Corona' monster-only See discussion in cafe5c4f27db83f. We may offer some compensation to arkane markspersons at a future date. (Or we may decide they're fine as-is.) -------------------------------------------------------------------------------- 69098e2f6d | Kate | 2021-09-05 00:53:25 +0100 Shorten a vault shop name It was too long to display the "What would you like to do?" shop prompt in console. -------------------------------------------------------------------------------- 4bac719ec2 | Nicholas Feinberg | 2021-09-04 12:09:37 -0700 Don't let sp. servitors cast v weak spells https://www.reddit.com/r/dcss/comments/phpjtn/ Also prune some monster-only spells. -------------------------------------------------------------------------------- b337144f63 | Kate | 2021-09-04 19:30:26 +0100 Staticify a function -------------------------------------------------------------------------------- d1960fc7b0 | Nicholas Feinberg | 2021-09-04 10:45:04 -0700 Make nonflammable trees block fire (ardl) (But really people shouldn't be using nonflammable trees! Booooo) -------------------------------------------------------------------------------- eb13ee3423 | Nicholas Feinberg | 2021-09-04 10:22:10 -0700 Maybe fix !cancel fly desc (particleface, shummie) Don't claim that !cancel will remove permanent sources of flight (e.g. items, species, etc) when you had some other actually dispellable duration active. -------------------------------------------------------------------------------- c0c42a9b79 | advil | 2021-09-04 10:57:45 -0400 build: improve messaging if `git describe` fails This message was pretty cryptic and didn't cover one major case at all (when `git describe --tags` fails because the repository is a shallow clone). The new error is extremely verbose but hopefully provides much better hints as to what went wrong. This also adds a comment documenting a workround to gen_ver.pl. This workaround seemed too niche to me to put in INSTALL.md, but maybe it should be there? See discussion in #2115 -------------------------------------------------------------------------------- e240ad9e29 | hellmonk3 | 2021-09-04 00:46:55 -0400 Merge pull request #2110 from crawl/delightfullyreddevilish feat: rework red devils -------------------------------------------------------------------------------- bc928eaac7 | hellmonk3 | 2021-09-04 00:36:00 -0400 feat: add six wizlab maps Expand Crawl's wizlab offerings: -Eringya's Formal Garden (removed in 0.17) returns with a modified layout, nastier archers, and the addition of some of the swamp monsters that have been added between then and now. -Tukima's Studio (also removed in 0.17) returns with a modified layout and several brand-new monster types to complement the dancing weapons: walking tomes, which cast living spells that cast themselves at the player. Thanks to PleasingFungus for the monster concept. -Yara's Duelist Academy features mana vipers, lots of warrior-mages wielding antimagic weapons, and a fearsome semi-unique Head Instructor who likes to dual-wield triple swords. -Borgnjor's Mausoleum features both corporeal and incorporeal undead. Lost souls occasionally appear when monsters are killed, making big fights scarier. A cult of halazid warlocks serve as the final encounter. -Maxwell's Workshop features an array of golems and big, meaty workers who wield big, meaty maces. You'll find some of Maxwell's cast-off equipment here, perhaps including the legendary artifacts themselves. -Alistair's Party Mansion features an array of wizards and their bizarre guests. There's some good consumables to be had if you don't mind crashing the party of the century... and wading through statrotting clouds of degeneration. In addition to the new wizlabs, this commit removes the golem set from the Tomb of Doroklohe (because it was mostly taken by Maxwell), so that map will exclusively place demons or undead now. The inner chamber of Iskenderun's Mystic Tower was also changed slightly; classed purple draconians will show up to make the end a bit more dynamic. With luck, we will soon have new tiles for the added maps and monsters, but until then you can enjoy some truly q u a l i t y art. -------------------------------------------------------------------------------- 0fcadc17a9 | Kate | 2021-09-04 04:14:10 +0100 Capitalise fruit And remove some duplicate entries from the randart name database. -------------------------------------------------------------------------------- 1a7b1a870f | Kate | 2021-09-03 22:28:38 +0100 Remove the book of stone from vaults Missed in the previous commit, oops. -------------------------------------------------------------------------------- db61641bf8 | Kate | 2021-09-03 21:53:38 +0100 Make Bolt of Magma a monster-only spell With the addition of Flame Wave, fire magic now has a very wide range of mid-level attack spells (which fits the school's flavour), but Bolt of Magma sticks out as one of the remaining old-style bolt spells and is much less interesting than the newer spells around it. Even with it removed, fire magic still is still more heavily weighted towards direct attack spells than other elements. Earth magic also now has access to Borgnjor's Vile Clutch at the same spell level, which fills a similar purpose but again has a more interesting design. Lightning Bolt remains as a classic bolt spell which has been more intentionally kept around due to the bouncing behaviour fitting air magic's theme. Some spellbook contents are shuffled to accomodate the change, and the book of Stone is removed to avoid repeating too many spells. -------------------------------------------------------------------------------- 8d994e73c7 | Nicholas Feinberg | 2021-09-03 07:57:29 -0700 Probably fix flame wave crash (spaninq) Off by one. -------------------------------------------------------------------------------- 4d1e82e741 | advil | 2021-09-03 10:25:05 -0400 fix: don't corrupt place_info on &ctrl-r in the vestibule As usual, place_info handling is a complete mess and extremely brittle. This crash could happen because the vestibule is a depth 1 connected branch, so a fixup corrected levels_seen in files.cc before getting to the wizmode handling for this field for this command, which assumed that it was uncorrected. This commit adds a workaround on top of the fixup. The fixup was originally created for a very specific bug but is *also* necessary for `&ctrl-r` in the vestibule, because otherwise the following assert crashes due to the branch depth. Possibly place_info validity handling should be entirely rethought. Resolves #2067 -------------------------------------------------------------------------------- 142c4e0e00 | advil | 2021-09-03 09:30:39 -0400 fix: improve `auto_switch` behavior with two bad weapons This makes the check on the current weapon and the target weapon identical, following a suggestion in #2057. I was initially worried that this would lead to further special cases but I think it's ok. This commit also makes an item definedness check explicit, where before it relied on `is_melee_weapon` to do the right thing. Resolves #2057 -------------------------------------------------------------------------------- 57a78d8006 | advil | 2021-09-03 09:16:10 -0400 docs: better document auto_switch=true This is a clarification in response to #2057, though I won't immediately close that issue. -------------------------------------------------------------------------------- 7265e17f22 | advil | 2021-09-03 08:43:40 -0400 fix: remove incorrect key handling for primary fire Handling for `()Q` was incorrectly inherited from action_cycler. Resolves #2083 -------------------------------------------------------------------------------- b254ac4902 | Nicholas Feinberg | 2021-09-02 21:21:18 -0700 Update the manual For the foxfire -> scorch swap. -------------------------------------------------------------------------------- 4726060ac2 | Kate | 2021-09-03 05:14:22 +0100 Update options_guide -------------------------------------------------------------------------------- c9e9834ff9 | Kate | 2021-09-03 05:11:55 +0100 Remove an extra character from Flame Wave desc -------------------------------------------------------------------------------- 0a9eca1c1b | Nicholas Feinberg | 2021-09-02 17:43:53 -0700 Update FE spell list As part of the mission of increasing variety across games and making backgrounds more of a 'starting kit' than a fully game-defining role, make Flame Wave the new top end of Fire Elementalists' start kit. Together with Scorch, Fire Elementalists should have a more fun and varied early game while still wanting to branch out by the time they reach Lair. -------------------------------------------------------------------------------- f3a705cdda | Nicholas Feinberg | 2021-09-02 17:43:53 -0700 New Spell: Flame Wave (L4 Fire/Conj) Flame Wave is a channeled spell (like Searing Ray) that blasts your surroundings with ever-wider waves of flame. It's intended to be a fun (and spectacular!) capper to the Fire Elementalist start. Fact sheet: - Max damage 10 + pow * 0.4. - Channel costs 1 MP per turn. - Can be channeled twice normally, for a max radius of 3. - Veh range extension allows a third channel at radius 4. - Noise starts at 12 (shout+) and goes up by 2 per turn. - Burns trees (very efficiently!) It would be nice to explain how Veh works in the spell description. -------------------------------------------------------------------------------- 79de503ca0 | Edgar A. Bering IV | 2021-09-02 11:46:17 +0300 fix: adjust hell effect strength The timing reduction in the final balance got hell effects in about the right place in terms of frequency, and contam in the right place for quantity. Drain was checking rN, which players carry a lot of. Instead of turning it up to big number, this commit makes hell effect drain ignore rN. Stat drain was hitting with reasonable frequency, but the XP available made it worked off easily. This commit increases the amount of stat drained. -------------------------------------------------------------------------------- 0ad3c213c0 | hellmonk | 2021-09-01 22:41:33 -0400 feat: rework red devils Instead of kiting (annoying), let red devils impede the player's movement more directly by giving them a melee attack flavor that inflicts barbs if any damage is dealt. They still spawn with polearms, so can use this to their immediate advantage especially in groups. -------------------------------------------------------------------------------- 9e0c098162 | Nicholas Feinberg | 2021-09-01 15:14:13 -0700 Add Scorch to FE and CA As discussed in the previous commit. Also push CA back toward spellcasting stats - you'll have to start with melee for a level or so, but I'd like for it not too be *too* hard to get Scorch castable. -------------------------------------------------------------------------------- 08d601b168 | Nicholas Feinberg | 2021-09-01 15:14:12 -0700 New spell: Scorch (L2 Fire) Scorch is a damage spell that strikes a random enemy within 3 tiles, dealing fire damage to them and (if it beats AC & resists) applying Cerebov's rF- debuff to them for a few turns. Currently, it does 2d5 damage at 0 power, scaling to 2d10 at 50 power. Veh extends range as usual. Scorch is intended to provide additional variety to the Fire Elementalist early game (reducing reliance on Foxfire) and to make Cinder Acolyte feel more distinctive from FE by replacing its Foxfire entirely. -------------------------------------------------------------------------------- 33c4956463 | Edgar A. Bering IV | 2021-09-01 17:41:43 +0300 fix: further tweak the Manifold Assault desc -------------------------------------------------------------------------------- 937acc2988 | Edgar A. Bering IV | 2021-09-01 08:37:18 +0300 fix: clarify Manifold Assault description -------------------------------------------------------------------------------- 6a4b6a32f9 | Edgar A. Bering IV | 2021-09-01 08:32:55 +0300 feat: downgrade Fighters to a buckler The starting kite shield on a Fighter was in a weird place. It had the kind of very long term value that the recent changes to spellcasting backgrounds have moved backgrounds further away from. It was completely reasonable to put some enchant armour scrolls into it and use it throughout the game. Unlike the aux armour of other backgrounds which provide 0-1 AC at the start and 2-4 AC at best, the kite shield starts out around 8SH and without enchants or increased dexterity rises to 13SH with training; it is a significant portion of the user's defenses. On the other hand, with the 0.27 change linearizing shield delay penalty, the shield was a liability for normal sized races. The penalty was sufficiently high that "remove your shield turn 1" advice reappeared and was not unreasonable. This is unfortunate, as a starting kit should ideally be useful at game start. Given the above, lets replace the kite shield with a buckler. The buckler will be worth using on turn 1, but any normal-sized heavy melee fighter will want to find an upgrade... or consider a two-hander or an alternate character archetype, depending on what drops. Races that cannot use a buckler get a kite shield. Currently this leaves the background description and manual intry as is---both simply mention "shield". -------------------------------------------------------------------------------- f8c7cfddd9 | gammafunk | 2021-08-31 22:03:27 -0500 feat: Despoiler loot and monsters in a Lair ending For due_jungle_book, the thematic loot item guarded by the obsidian statue is at a position where one had to step in view of the statue to see the item at all. Additionally the statue is easy to autoexplore into, and the area in which it resides is rather cramped for it to be able to use its summons. This commit encloses the loot item in a clear stone room with a clear door, placing the statue in front. The room is visible from another room usually encountered before the statue area. Hence the player can always see basic information about the loot item before deciding to fight the statue, and the statue itself will likely be seen and autoexcluded before it's reached. An additional bonus is that the loot item can't simply be apported without fighting the statue, since the door must be opened first. Finally, we clean up the terrain surrounding the statue to open up space a little, allowing its summons to work better. -------------------------------------------------------------------------------- 84fbe2c6ea | hellmonk | 2021-08-31 22:44:53 -0400 fix: don't spawn an oklob vault as often -------------------------------------------------------------------------------- 46f4d3c346 | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Change a miniruin subvault for better wand placement -------------------------------------------------------------------------------- b29a9eb848 | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 checkin the whites -------------------------------------------------------------------------------- 5d38da674a | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Two new encompass vaults for Desolation Two new encompass vaults for Desolation: Pilgrimage, in which the three mini-ruin subvaults are laid out linearly across the salt flats, and Temple, which eschews subvaults entirely and scatters loot around the outlines of an ancient crumbling temple. -------------------------------------------------------------------------------- 8f02261bec | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Add a handful of Desolation mini-ruin subvaults -------------------------------------------------------------------------------- c8992b3357 | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 New entry vaults for Desolation Inspired by the famous report "Expert Judgement on Markers to Deter Inadvertent Human Intrusion into the Waste Isolation Pilot Plant", these entry vaults are designed to suggest that the Desolation is not a place of honor and no great deed is commemorated there. Lower weights since they're big. -------------------------------------------------------------------------------- 4e71d33c19 | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Change the statue tiles used in Desolation Statues are renamed to "ruined idols" in Desolation, but the description says they've all had their features removed, while the statues still use the regular dungeon tiles, which have plenty of features. After discussion in the discord, use the crumbling column tiles for now for statues in Desolation. At least they're featureless. -------------------------------------------------------------------------------- 963f628cec | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Rearrange the order of subvaults in Desolation Put the paired intact/wrecked vaults in a separate section from the unpaired singleton vaults. The other arrangement was driving me bonkers. -------------------------------------------------------------------------------- 3674f0abaf | Nicolae Carpathia | 2021-08-31 18:53:19 -0400 Fix some subvault misconceptions in Desolation The desolation_ruins_setup function called by all the subvaults in Desolation doesn't need to subst . = , - the main vault can't replace anything in a subvault anyway. Also, subvaults don't need ORIENT statements. -------------------------------------------------------------------------------- e74157ce7a | advil | 2021-08-31 18:21:55 -0400 refactor: remove CMD_EVOKE_WIELDED Until recently, there were only 3 holdouts that used this command, all unrands. Previous commits moved those unrand evocations into abilities in order to have a cleaner, more standardized, UI for them, leaving nothing that uses evoke wielded. Based on past discussion, we are unlikely to add anything that does use it, and item-specific abilities are generally better. As part of this I've removed all the old stuff for triggering reaching weapons via evocations; this was partly dismantled already as part of the introduction of CMD_PRIMARY_ATTACK. For one-key triggering of Olgreb (a common request), there are two recommended solutions after this commit: quiver the ability and use `p`, or just macro the ability like any other. -------------------------------------------------------------------------------- 28a71e5310 | advil | 2021-08-31 18:21:55 -0400 fix: add ability descriptions for dispater/asmodeus Also, tweak the Olgreb description. This commit intentionally leaves the artefact descriptions of these abilities in place (which lets them be obvious while not wielding them). -------------------------------------------------------------------------------- 31e2066950 | advil | 2021-08-31 18:21:55 -0400 refactor: converk staff of olgreb evoke to an ability As with the previous two commits, this lets a much more straightforward version of the power be shown to the player. As part of this, I have simply removed the fail check. This required 5 evo skill to get to 100%, which is trivial; it originates from earlier versions of the staff that could also cast venom bolt. -------------------------------------------------------------------------------- b9327a18ab | advil | 2021-08-31 18:21:54 -0400 refactor: convert staff of dispater evoke to an ability This allows for better transparency for the costs, more code reuse, etc. I have provisionally converted the HP cost to a percentage, which overall should work better for damnation. This is currently set at 10%, and it may be a nerf to many characters at higher HPs. Further adjustment might be required. -------------------------------------------------------------------------------- 3858e25e18 | advil | 2021-08-31 18:21:54 -0400 refactor: Convert Sceptre of Asmodeus evoke to an ability This regularizes the interface to the sceptre, allowing nice things like showing the fail rate, etc. The existing evocations check didn't fit well into the more standardized ability.cc checks, so I've adjusted it (I think this is a buff, but I'm not sure it matters -- anyways, others can feel free to adjust further). -------------------------------------------------------------------------------- b16ebcc8e8 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 feat: don't place shafts in hell The small levels and placement of hatches give a fast enough dive, shafts are an ultra fast forward. We'll permit Fo to shaft in hells and permit shafts in vaults for the hells, so that they can be used as vault "loot". -------------------------------------------------------------------------------- 51d9a1de7a | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 fix: new hell mosnter description tweaks (PleasingFungus) -------------------------------------------------------------------------------- 46c4a727e1 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 feat: update doom howl spawns -------------------------------------------------------------------------------- 4b270e8d09 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 fix: describe stoker movement (dilly) -------------------------------------------------------------------------------- 5fa11ae2f9 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 text: add some newlines (PleasingFungus) -------------------------------------------------------------------------------- 5d3d9a63fa | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 vaults: adjust Tartarus vaults for new monsters Add the new Tar cast to the vault des. Some places shadow demons were replaced with doom hounds, for the summon effect, and others profane servitors for the "shadowy flavour". Most reapers are gone but a few stick around as guests. -------------------------------------------------------------------------------- 4c841b28f7 | Edgar A. Bering IV | 2021-09-01 00:37:30 +0300 vaults: adjust monsters in Cocytus vaults Some care was needed to make sure there's simulacra around for the wendigo, but placing wendigo bands can take care of that when needed. Otherwise, blizzard demons were replaced by titans or shard shrikes depending on context, and several vaults were 098-ified. -------------------------------------------------------------------------------- 3d3c2c6d84 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust Gehenna vault monsters This adjusts all Gehenna vaults to use the new cast. Fewer changes than the Dis vaults, mostly replacing sun demons with searing wretches and sprinkling in some creeping infernos. -------------------------------------------------------------------------------- 2bde554b36 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: Dis end vault monster set adjustments In line with the Dis changes, remove trash mobs and replace with the new Dis cast. As with the non-end vaults, a few juggernauts sneak in as a guest threat, and the cacodemons in the one grunt ending stick around. Might have been too heavy with caustic shrikes on some of these. -------------------------------------------------------------------------------- f8756136d3 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust non-end Dis vault monsters and cleanup Adjust monster sets of Dis vaults. When possible I tried to stick with or switch to 098. When vault storyline demanded eg. a humanoid or a boss monster one was chosen from the new Dis cast appropriately. Occasionally some vaults desired slightly more variety, and juggernauts get sprinkled in there. I'd considered putting them on the Dis spawn table, but a few vault cameos seems to be better for them. -------------------------------------------------------------------------------- 3a40abb400 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: make hangedman_mysterious_dungeon_monster_house 098 Essentially. The generic undead are preserved (with some branch flavoring so Cocytus wendigo have simulacra to collapse), and the "fodder" placements are replaced with 09. The "boss" is specified to be a top tier threat for the branch. -------------------------------------------------------------------------------- 8b58bad9cc | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new Cocytus spawn table The icy hell, ruled by Antaeus, this monster set has a slightly more cryptonatural feel, keeping with the "newness" of Cocytus in the lore. The monster mix aims to beset the player with iceblasts, cold, and status effects (much worse under -Potion) This places the following monsters in addition to the cross hell threat set. "basic" branch welcome monsters: - simulacra Using the adjusted simulacra list, these simulacra either hit hard, are fast, or mess up player position (often two or more). - freezing wraiths Somewhat on the weak side for hell, a lucky slowing hit goes much further when a player cannot obtain potion help. - frost giants Lower tier colossus, following Antaeus' leadership. "branch flavour" monsters: - titans More of Antaeus' pals. Titans' airstrike is spooky in Coc's mostly open layouts, as is their flight over deep water. - azure jelly Rarer, might be a bit too weak for its place, but a good cold monster with big ol hits. - wendigo To help slower simulacra really nail the player, the wendigo can turn them into 3d43 iceblasts (one time only, destroyingn the simulacrum), in addition to having stunning burst and some strong melee. Wendigo are fragile and cannot fly, however, so they can be managed with care using Cocytus' terrain. - nagrun Earth spirits who were here first and tolerate the new hell that was dug out around them. Petrification is much more threatening if it can't be cancelled, so these earth spirits come with it, plus AF_VULN to help it land. "signature threat" monsters. Equal chance at max depth, otherwise more shrikes - shard shrike Basically TIE fighters with blue lasers. A player favorite. - ice fiend The cold tier 1 demon. -------------------------------------------------------------------------------- 58b44f322d | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new Tartarus spawn table The decaying hell, this monster set is out to bewitch the player and drown them in foul miasma. Unlike other hells, because of the misma quantity no living holiness monsters are added. This places the following monsters in addition to the cross hell threat set. "basic" branch welcome monsters: - spectral things The generic late population is adjusted so that the spectrals that place should be a somewhat serious threat to the player, if they start to swarm. - shadow wraiths Not very hard hitting, but AF_DRAIN_SPEED makes these a thematic mix. - eidola Also not very hard hitting (could they gain dispell undead lol?) but with Tar's new Will/2 their Cause Fear has a chance at landing and constraining player movement. "branch flavour" monsters - profane servitors A monster from "elsewhere" repurposed to service in Tartarus. Some concern about this aura and silence aura being difficult to see in combination in console. They're a nice melee threat and combined with their aura a nice threat multiplier. - bone dragons Big dumb hits. Thwacks. Tramples. - putrid mouths Somewhat similar to ushabti, putrid mouths are a stronger melee threat in addition to the warning cry and miasma breath. They apply poison and stat drain fitting in with Tar's theme. - doom hounds Definitely not spirit wolves. Everyone's favorite "summoner" monsnter. - silent spectres (rarer, flat distribution) These are sprinkled in to fit with Tar theme and provide a unique tactical challenge. Much rarer than regular monsters. "signature threats" - tainted leviathans A C genus monster for tar. With mesmerisation to use the Will/2 branch-wide effect, a miasma ring, silence, and large rocks, these giants are an all-around top tier threat. - tzitzimimeh The branch's tier 1 demon. -------------------------------------------------------------------------------- a5164bd282 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new Dis spawn table The iron city, this uses a mix of new and classic monsters to beset the corroded player with big hits (wham pow), metal splinters, and prevent their escape with fetters and barbs. This places the following monsters in addition to the cross hell threat set. "basic" branch welcome monsters that fall off with depth and aren't used for ood rolls beyond max depth: - ancient champion Iron shot, haste, good hits. Currently they have skeletal warrior bands, perhaps that should change. - war gargoyle Metal splinters and fast, but not tough. - iron dragon Metal splinters and stronger melee than a war gargoyle, tougher as well. Unfortunately they're slow, so currently less frequent. Might be worth making them speed 10. "branch flavour" monsters to fill out the regular threats: - iron golem Buffed iron golems are hard to kill and hit really hard at normal speed, so it is not good to be next to them. That's easy to do because they're slow, but it does mean they might block an escape in the kind of layouts Dis generates. - caustic shrike The pigeons of Dis. Recontextualize a top-tier depths threat as a regular friend in the iron city. Their corrosive attack stacks with the present Dis corrosion for maximum fun! - quicksilver elementals At least one Dis castle places quicksilver dragons (good flavor, but not really strong enough for a Dis threat). These elementals are a cross between a quicksilver ooze, a qsd, and a shard shrike. Quicksilver bolt will remove some corrosion, but do you really want to keep one as a pet? - crystal echidna Iron golems are slow, many other Dis threats are regular speed. To help everyone along these spiny green helpers have throw barbs, along with crystal bolt so they're not defenseless on their own. The cramped layouts of Dis should give them many bolt bouncing opportunities. "signature threat" monsters (becoming equal chance at max ood). - iron giant The classic C, with harpoons and iron shots and now hurling buffed iron golems (which get a swing on the turn they're thrown). - hell sentinel The tier 1 demon of Dis. -------------------------------------------------------------------------------- 1c5eef2bd2 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new Gehenna spawn table The firey hell, this uses new monsters along side classic favorites to beset the player with fire storms, fireballs, and burn away their resistance. This places the following monsters in addition to the cross hell threat set. "basic" branch welcome monsters that fall off with depth and aren't used for ood rolls: - hell hog The classic fast fireballing demon. Their fireballs hit enough to hurt and they swarm, but they aren't so tough. - fire giant Increasing placement of 'C' genus monsters in hell is a lorebuilding exercise. Not as fast as hell hogs, stronger melee. - salamander tyrant The highest tier salamander monster, recontextualized here in hell. Their lava spells work well in Gehenna's lava pool terrain. "branch flavour" monsters that fill out the regular spawns in the mid range and fall off for ood (but not as sharply as the cross-hell set): - balrug Classic demon; subsequent changes to the other hells makes this one of the few non-fiend non-common demons appearing. - searing wretch Resistance stripping melee threat. - stoker (less common) Ranged, maintain range threat. In Gehenna's layouts corners are hard to comeby, and hiding from creeping infernos is a good deal trickier than dodging oods. Setting them off early is a possibility for the player, but comes at a cost. - creeping inferno (less common) Like a lurking horror, but with Fire Storm. "signature threat" monsters that fill out the ood weight. At depth 7 helephants are more common than fiends, and at the depth cap they have equal chances. - hellephant 3d40 bolt of fire (ow!), trample, and blink. Tough but not too tough defenses. A good firey monster for the firey hell. - brimstone fiend Every hell needs a thematic 1 and the brimstone fiends are the fiends for Gehenna. -------------------------------------------------------------------------------- 1c56b440e8 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: define a cross-hell spawn population To unify the hell branches, this defines a population subtable that produces "cross-hell" threats: a flat (falling off in ood range) sprinkling of tormentors and hellions bringing suffering to the damned, plus rare lichen making sundry unholy pacts. Lore note: Lichen, having mastered life and death, are not minions of hell or bound there. They're simply visiting. So we don't want to put a ton in any hell, even Tartarus. -------------------------------------------------------------------------------- cec1ff2907 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: enable a higher ood cap for hells In order to let 098 pick out true nightmares without making each hell 6/7 roll oops all fiends, let's set an ood cap that we can work with. Technically we lose a bit of expressivity at the deepest possible 8 depth, but I don't think that's needed. -------------------------------------------------------------------------------- a084dd16cf | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: revise generic_late_zombie populations (nojaa) The generic_late_zombie population is used for derived undead base classes in areas where the player is expected to be quite strong. This commit adjusts the way depth is handled by the picker so that the population list has its own depth cap (independent of branch depth caps). It also changes the monster selection to focus on derived undead that are either fast or interfere with player movement or both, with a few hard hitters for good measure. -------------------------------------------------------------------------------- e6604a7e06 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: adjust derived undead attack flavours This commit allows spectrals and simulacra to constrict and reach (losing the flavor brand on that attack) and all derived undead to trample. These "physical" attack flavours mess with player positioning in various ways; not including them on the higher tier derived undead made it challenging to use those derived undead as serious threats. -------------------------------------------------------------------------------- 5587a7b593 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, nargun Without cancellation pots, status effects are much more deadly in Cocytus. Nargun are modelled after the Australian mythic stone creatures, and are gargoyle-esque: they hit hard, have big AC, and a threatening spell but weak HP. In this case they bring Petrify to the mix, along with AF_VULN and a big HD to help it land. They are lrdable and treated as icy. -------------------------------------------------------------------------------- a7dcba2b6e | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, wendigo Wendigo are a new Cocytus monster. They're somewhat flimsy and act as threat multipliers, with stunning burst and a new spell seracfall. Seracfall turns a simulacrum in view into a very high power (3d43) iceblast. Cocytus will have plenty of simulacra around as part of the overhaul, but many simulacra are slow. The wendigo "help" the simulacra along in a couple of ways. The targeting also means that a player facing a wendigo plus simulacra will have to manage LOF from several directions as the simulacra advance. -------------------------------------------------------------------------------- 5a7b489cf3 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, tainted leviathan A non-fiend top tier threat for Tartarus. Tainted leviathans come with mesmerise and a cloud ring to pull players into. Oh! And they're giants so they thro rük. -------------------------------------------------------------------------------- 0cc904eb20 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, putrid mouth Putrid mouths are a new Tar monster, meant to be a more substatial (ha) wraith genus monster to fill out the branch flavour set of threats. They are based on Chinese mythology around hungry ghosts and re-use the old hungry ghost tile since it was so cool. As a monster they aren't the toughest of Tar threat, but the mix of miasma, poison, and warning cry should combine with the small levels to prevent a player who mismanaged the encounter from recovering before reenforcements arrive. -------------------------------------------------------------------------------- 6bad965b88 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, crystal echidna Meant as a "support caster" type monster for Dis, crystal echidnas have barbs (to confine the player's movement while slow things catch up) and crystal bolt (to be a bolt-bouncing threat when they're met alone in the cramped rooms of most Dis layouts). Crystal Echidna are nonliving and explode like green crystal for LRD. -------------------------------------------------------------------------------- e42411b9ad | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, quicksilver elemental I considered simply using quicksilver oozes or quicksilver dragons in Dis, as both are reasonably strong late-game threats. However both dragons and oozes are vulnerable to some of the collateral damage done to allies by hell minions. It seemed like a better idea to make a monster in a genus that won't fall so easily to tormennts, since the new Dis list already has its share of living creatures. This monster is something like a cross between a quicksilver dragon and a shard shrike, with batty movement and qs breath, though not as fast as a shrike. Not 100% happy with repeating the shard shrike gimmick, could instead just make quicksilver oozes torment immune. (How does one torment a blob of quicksilver anyway?). -------------------------------------------------------------------------------- 6bbbebb4f9 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: buff iron golems (amcnicky) Iron Golems are slow, and slow monsters are often sad. Dis has iron giants, which can throw them into range, which makes them more exciting. Except they're also not that strong, and attack slowly to boot. To make them a better Dis monster this gives them a big buff to their AC and HP, the idea being that they are avoidable but will block a player's manouverability. To make their obstruction to manouvering even more pointed, they get buffed attack and a second attack, and attack at normal speed. The normal speed attack ensures that (depending on monster list sequencing) they get a good chance to swing at the player after being thrown. Big big big ruk. -------------------------------------------------------------------------------- a2eda6f88b | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, stoker Stokers are a ranged harrassment and positioning threat in Geh. The player can defeat one solo by setting off its own creeping infernos against it, but in a fray this back-line threat should keep the player off balance with wind blasts and inferno-firestorms. -------------------------------------------------------------------------------- a95eead60a | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, searing wretch A hard-hitting melee threat for Gehenna, searing wretches are ghoul genus monsters that stack on fire, sticky flame and strip fire resistance. They are complementary to the other Geh threats, which all have some sort of ranged component, and other than hellephants are a bit flimsy at hell depth. -------------------------------------------------------------------------------- b7fef34776 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: new monster, creeping inferno Creeping infernos are a new monster for Gehenna. Operating with lurking horror move rules, creeping infernos unleash a power 120 fire storm at their location upon death. The savvy player will be able to use them to advantage, so we won't place too many, but the player caught off guard will be exploded. -------------------------------------------------------------------------------- 751aad3b66 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust Tartarus vaults for new hell levelgen Fewer encompasses here, large vaults again get ORIENT: centre to keep them from wandering off, stairs adjusted. -------------------------------------------------------------------------------- 8c116a9034 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust Cocytus vaults for new hell levelgen Similar to Dis, several of these vaults are very large and given ORIENT: centre, one is turned into an encompass. Stair placement fixed up. -------------------------------------------------------------------------------- ffef9bb0b2 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adust Gehenna vaults for new hell levelgen -------------------------------------------------------------------------------- 0cff350621 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: add green crystal to Dis While Dis is the Iron hell, it is also notionally earth/metal themed. Moreover elemental iron can crystalize. So let's spice up the wall types a bit. Currently this is accomplished by repurposing serial_glass to place green crystal instead of glass. Other Dis specific crystal vaults welcome. -------------------------------------------------------------------------------- 2e6bbc7fcc | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: adjust Dis vaults for new level generation Several large Dis vaults disconnected the level and were practically encompasses in their own right; they get promoted. Other large vaults are given ORIENT: float or trimmed as need be to get them to play nice with the new small levels. All stair placing vaults have their placements adjusted for single stairs. -------------------------------------------------------------------------------- e5be5493b6 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 vaults: revise miscelaneous vaults appearing in hell This commit adjusts vaults that are defined in various files other than the branch specific vault files. Vaults that are too large are removed from hell spawning and appropriate conditionals for stairs are added. Vaults that break connectivity (elevators) are also dropped from the hells spawn lists. -------------------------------------------------------------------------------- 4708905124 | Edgar A. Bering IV | 2021-09-01 00:37:29 +0300 feat: only place one up and down stair in the hells This changes the level generator to only place one stair in each hell branch, as a complement to the previous change to level generation size. This commit will currenlty break crawl due to the number of vaults that place disconnected stair bubbles in Hell. Follow-up commits will be adjusting hell vaults to account for all level generator changes. -------------------------------------------------------------------------------- 43dec93354 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: add error checking for some dungeon builder lua -------------------------------------------------------------------------------- 903cbe717e | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: shrink Hell subbranches on floors 1-6 This commit converts hells layouts to use the new dgn.builder_bounds() instead of dgn.max_bounds(), adding parameterization on grid size for some procedural values that were previously hard coded. The dive portion of the hells can be exciting, but quickly becomes a slog if the player must make the dive a second or third time, due to how the stairs work. By shrinking the levels we reduce the time a player spends with unfun repetition and increase the time spent in "good dive moments". A subsequent commit will reduce the number of stairs spawned on each level to 1 guaranteed stone stair. -------------------------------------------------------------------------------- 9424aacb20 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: separate builder_bounds and max_bounds This adds two stub functions dgn_builder_x and dgn_builder_y to allow parameterizing the dungeon buillder's driving dimensions. Subsequent commits will use these to shrink intermediate hell levels. The assumption that GXM and GYM are constants is baked in across the layout code, so layouts will be adapted to use the builder_bounds gradually. Layouts switched to use builder_bounds will be tested for support of various builder sizes. -------------------------------------------------------------------------------- 20ce1ca697 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 fix: resolve a todo in zonify mapping -------------------------------------------------------------------------------- bc17ff6ebb | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 refactor: move padded_bounds to a layout library This function is used with the various omnigrid gridding functions to put a bit of padding to allow the grid to expand into the edge of this padding. There were two versions of it, one in layout_city the other in layout_grids; layout_cellular was implicitly using one of them without an explicit include. This moves the function to omnigrid so that we have only one copy. -------------------------------------------------------------------------------- 43d0ba7266 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: shift timed hell effects to do more strategic damage The effects of the hells serve two purposes. One is to spice up encounters with tactical shifts: new monsters, noise, damage; the other is to deal strategic damage. The previous commits added a branch-wide effect to each hell branch to give them a distinct tactical flavour. This commit shifts the timed-effects to do strategic damage to those who would linger: contam, drain, and stat rot. -------------------------------------------------------------------------------- e744962671 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: persistent hell effects: rot tartarus (Lici) The third of four branch-wide hell effects, meant to give each hell a unique tactical experience. In Tartarus, halve half willpower. Ereshkigal has paralysis, and the new Tar monster set will have some will checking monsters. Lets make it harder for the player to simply Will++++ item their way out of these concerns. -------------------------------------------------------------------------------- 6f13a9c4bf | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: persistent hell effects: fill gehenna with acrid smoke The third of four branch-wide hell effects, meant to give each hell a unique tactical experience. In Gehenna, prevent the use of scrolls. -------------------------------------------------------------------------------- 3d7a220799 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: persistent hell effects: freeze cocytus solid The second of four branch-wide hell effects, meant to give each hell a unique tactical experience. In Cocytus, prevent the use of potions. -------------------------------------------------------------------------------- 49807740c2 | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 feat: persistent hell effects: rust dis The first of four branch-wide hell effects, meant to give each hell a unique tactical experience. In Dis, apply two stacks of corrosion. -------------------------------------------------------------------------------- 79cbbdc86d | Edgar A. Bering IV | 2021-09-01 00:37:28 +0300 refactor: abstract corrosion to a method -------------------------------------------------------------------------------- 21599a725c | Perry Fraser | 2021-08-31 13:00:22 -0700 Have C-glyph altars use temple_god_list() Previously there was a hardcoded list of gods that couldn't generate for C glyphs in dungeons. It turns out this was essentially equivalent to the list already used in temple_god_list(), so this removes that duplication. This also fixes an issue where an altar to Ignis could generate on a few Zot dungeon levels which used random altars. -------------------------------------------------------------------------------- d86dc11844 | Nicholas Feinberg | 2021-08-31 11:53:27 -0700 Bump SCG to L6 (ardl) Cactus giants were a bit stronger than expected, and with the removal of Shadow Creatures, there were no other L6 summons left. -------------------------------------------------------------------------------- 98b9f98406 | Nicholas Feinberg | 2021-08-31 11:50:16 -0700 Fix monster cactus giant display -------------------------------------------------------------------------------- df715e3894 | Perry Fraser | 2021-08-31 08:15:42 -0700 Fix dancing weapon death messages [Committer's notes: - Don't claim that summoned dancing weapons turn to gold on death. - Allow summoned corpseless monsters to create clouds on death, just like other summons. - Fix handling of banished unrand dancing weapons. Closes #2092. ] -------------------------------------------------------------------------------- bc0475efdd | Kate | 2021-08-31 02:52:45 +0100 Prevent cactus spines from working outside LOS -------------------------------------------------------------------------------- bced6e68ee | Nicholas Feinberg | 2021-08-29 19:07:02 -0700 Remove an unused corpse tile Oops! Should fix tests. -------------------------------------------------------------------------------- 8ac975c05d | Nicholas Feinberg | 2021-08-29 17:54:53 -0700 New spell: Summon Cactus Giant (L5 Summoning) Summon Cactus Giant summons a giant cactus warrior. Enemies that hit it in melee take 5d8 AC-reduced spines damage. Oof! The intent is to have another situational/toolbox summoning spell: it's not particularly great against "casters" or "ranged" enemies, but fun against melee foes, particularly ones that move fast rather than hitting hard. To differentiate from Guardian Golem, which has a vaguely similar role, it's a few levels high (L5 1school vs L3 2school). The giants also have giant spiked clubs, mainly for comedy value. They're intended to not do that much against with their attack (as opposed to their spines), so their attacks take 3 turns and their base damage is very low. Giant stats: 1 AC, 2 EV, roughly (27 + spellpower) HP, though it's randomized like other monsters'. Standardish summon duration, like call canine familiar. The spell appears in the Book of Dryads (renamed to Book of the Wilderness) and a new Book of Scorching, which also gets Foxfire and Fireball. (I actually named this book before I came up with the idea for Scorch, but you better bet that's going in there if it lands.) -------------------------------------------------------------------------------- 620d9153ef | Kate | 2021-08-30 00:07:12 +0100 Remove some broken speech lines _fruit_name_ is a key in the randart database and can't be used in the speech database. -------------------------------------------------------------------------------- f6d37e6e1d | Kate | 2021-08-29 22:31:04 +0100 Disable Okawaru Duel in Sprint Instead of crashing, disable the ability in Sprint, since it's not supposed to be possible to leave the single D floor by any means (and the Abyss is also disabled). While it'd be possible to special-case the Arena and enable the branch, it seems likely to break Sprint balance even more than usuali (especially in maps like linesprint and arenasprint, for example). -------------------------------------------------------------------------------- e87a16407d | Nicholas Feinberg | 2021-08-29 08:49:46 -0700 Blame Ignis for fire champs (gammafunk) No idea if this works correctly for cikiller, tbh! -------------------------------------------------------------------------------- 28825b98b6 | Edgar A. Bering IV | 2021-08-29 10:25:10 +0300 docs: first changelog update for 0.28-a0 -------------------------------------------------------------------------------- 2a6f7409c1 | Edgar A. Bering IV | 2021-08-29 08:40:47 +0300 docs: update credits -------------------------------------------------------------------------------- 9e858e973b | Nicholas Feinberg | 2021-08-28 20:09:21 -0700 De-damn missed bolts (ardl) oops -------------------------------------------------------------------------------- 7e9a150488 | Nicholas Feinberg | 2021-08-28 19:41:38 -0700 Add missing Cinder Acolyte icon (Really, swap in the Delver candle, since it fits, and give Delver a lantern instead.) -------------------------------------------------------------------------------- 80eddfa388 | Kate | 2021-08-29 01:18:52 +0100 Fix interactions between noise, fake noise and silence (#12293) "Fake" noise (primarily created by alarm traps and the Orb) was intended to ignore silence and still alert monsters, but didn't actually work since no noise (including fake noise) was ever allowed to propagate through any silenced squares. Instead, allow all noise to propagate through silence, but only allow fake noise to actually originate within silence and to alert monsters in a silenced area. This also fixes problematic behaviour of the Demonspawn silence aura mutation, where the aura blocked all noise from the player from propagating outwards. -------------------------------------------------------------------------------- bb949333c4 | Kate | 2021-08-28 23:10:01 +0100 Give Haunt a summon cap of 8 As a high-level summon it doesn't need as strong a limitation as most of the earlier summons, but it previously had no cap at all - give it a high summon cap to at least make it a little less practical to haunt multiple different targets at once. -------------------------------------------------------------------------------- 1a59d63638 | Kate | 2021-08-28 23:10:01 +0100 Make Shadow Creatures a monster-only spell It doesn't work well with the reduced player summon caps, since a big part of its functionality is being able to create monster bands, and the interaction between bands and the summon cap was already fairly messy. Being able to summon rare branch-specific monsters and big monster bands is a fun effect, but works much better on the already-existent scroll of summoning, which avoids the problems of summon caps and is balanced by being a consumable. -------------------------------------------------------------------------------- db2750068a | Kate | 2021-08-28 23:10:01 +0100 Remove the XP penalty from summon kills With the caps on most summon spells substantially reduced, it should now be reasonable to remove the 50% XP penalty on kills made entirely by allies. Other temporary allies also have the penalty removed, as these show up much less often (for example, charmed allies and summons from items and god abilities) so should have a fairly minimal effect. Undead allies also have the penalty removed, with plans to further adjust corpse-using spells in the future. Currently permanent allies from gods (specifically Beogh and Yredelemnul) are unchanged - these require more substantial reworks to their design, with the plan being to hopefully then fully remove the XP penalty from them when their respective redesigns are worked on. -------------------------------------------------------------------------------- 635202c219 | Kate | 2021-08-28 23:10:01 +0100 Give monsters separate summon caps to players Making summon caps for monsters match the reduced player caps unintentionally weakens a small set of monster summoners whose spells are coincidentally also player-castable. Instead let monsters retain the old caps, and document these in the spell description when examining a monster. -------------------------------------------------------------------------------- af93940d1b | Kate | 2021-08-28 23:10:01 +0100 Reduce most summon spell caps to 1 Summoning magic has long had the downside of kills by allies granting only 50% XP, which works fine in terms of balance due to how hugely powerful summoned allies are, but is very inelegant as well as just feeling bad to many players. The main problem caused by summon spells is how easy it is to quickly and repeatably create a very large number of allies, so to try and balance this better and allow removal of the XP penalty, greatly reduce the summon caps for player-castable summoning spells. Almost all spells are capped at 1 summon, with a few exceptions for spells that wouldn't function with such a low cap (such as Summon Small Mammal where the individual allies are very weak), for a few high-level spells (Summon Hydra and Monstrous Menagerie) which are instead capped at 2, and for the very highest level spells (such as Summon Horrible Things and Dragon's Call) where the high level of investment required can justify their strength. Being able to create allies on demand is still fundamentally an extremely powerful ability so this is very unlikely to cause problems for summon- focused characters - it'll just be required to either hybridise more or to use a wider variety of summon spells. -------------------------------------------------------------------------------- 99b01970c5 | gammafunk | 2021-08-28 16:46:57 -0500 fix: Make a function static -------------------------------------------------------------------------------- ae8ea5ec39 | Edgar A. Bering IV | 2021-08-28 23:15:54 +0300 feat: adjust Mlioglotl's spawn range Mlio's spawn range was picked to cover holes in the distribution of uniques. Unfortunately, an S-branch threat simply isn't all that spooky by Vaults or Depths. Additionally, in Abyss Mlio's one weird trick doesn't do anything. So let's place Mlio in the S branches, corrupting an otherwise peaceful runic experience, and very rarely in the abyssal lair end as the source of the corruption. -------------------------------------------------------------------------------- 832ee520b4 | Edgar A. Bering IV | 2021-08-28 23:11:37 +0300 fix: inscribe the obsidian axe (rayg00n) -------------------------------------------------------------------------------- 47ca004b5c | Nicholas Feinberg | 2021-08-28 12:07:32 -0700 Ban fire championing priests (Lightli) Another god already took that one! -------------------------------------------------------------------------------- 0e18a103e6 | Nicholas Feinberg | 2021-08-28 12:02:53 -0700 Cleanup beogh_follower_convert -------------------------------------------------------------------------------- 1796491f69 | Nicholas Feinberg | 2021-08-28 12:02:53 -0700 Ban fire champion conversions (Lightli) Another god already grabbed that orc! You can't have them! -------------------------------------------------------------------------------- 5b1f6a4db3 | Nicholas Feinberg | 2021-08-28 12:02:53 -0700 Fix fire champion wizmode name -------------------------------------------------------------------------------- 6d487c6445 | Kate | 2021-08-28 19:20:20 +0100 Reduce Lesser Beckoning's power cap As a level 3 spell it's not especially appropriate for it to scale all the way up to 200 power. Instead cap it at 100, with the range scaling up to 5 instead of 7. -------------------------------------------------------------------------------- e22f211cc6 | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis: ability cleanup Swap Foxfire Swarm and Sea of Fire, since foxfires are more powerful in practice. Make all abilities significantly cheaper. Add spacing to the enums. -------------------------------------------------------------------------------- c0270e7ab8 | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis: monster dialogue -------------------------------------------------------------------------------- 3a68cb0a86 | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis: zealot start Gnoll and human should do well with the flexibility, hill orc likes the fire, and mummy likes the rF, ha. -------------------------------------------------------------------------------- 7cb2ebde44 | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis wrath: Fire Champion Chooses the toughest monster in LOS and gives it increased move speed and AF_FIRE permanently. Lots of conditions to try to choose only an interesting monster to fight, not a rat or whatever. Dare you risk the wrath... of the super fire yak? -------------------------------------------------------------------------------- d1c9835b8b | Nicholas Feinberg | 2021-08-28 10:50:13 -0700 Ignis wrath: shaft -------------------------------------------------------------------------------- c171122a48 | Nicholas Feinberg | 2021-08-28 10:50:07 -0700 Ignis wrath: fire elementals -------------------------------------------------------------------------------- 8762c4751e | Nicholas Feinberg | 2021-08-28 10:50:03 -0700 Ignis: add rF=0 to god wrath And tweak duration and messaging. -------------------------------------------------------------------------------- b194a03854 | Nicholas Feinberg | 2021-08-28 10:47:29 -0700 Ignis: wrath description -------------------------------------------------------------------------------- 8c10d7e454 | Nicholas Feinberg | 2021-08-28 10:47:29 -0700 Ignis: ignore amulets of faith And refactor the relevant code in the process. It might be nice to care about "faith (getting discounts on abilities), but maybe there are weird incentives..? Not handling it right now, anyway. -------------------------------------------------------------------------------- dc0d7ab00c | Nicholas Feinberg | 2021-08-28 10:47:19 -0700 Ignis: die After abandoment and mollification, Ignis dies. RIP. -------------------------------------------------------------------------------- 24c43e5e87 | Nicholas Feinberg | 2021-08-28 10:46:20 -0700 Ignis: Rising Flame ability -------------------------------------------------------------------------------- 44ce977461 | Nicholas Feinberg | 2021-08-28 10:46:20 -0700 Ignis: Sea of Fire ability -------------------------------------------------------------------------------- 8782af215f | Nicholas Feinberg | 2021-08-28 10:46:20 -0700 Ignis: Foxfire Swarm ability -------------------------------------------------------------------------------- 68b9825e2d | Nicholas Feinberg | 2021-08-28 10:46:14 -0700 Ignis: Add rF passive -------------------------------------------------------------------------------- 61f1a7678b | Nicholas Feinberg | 2021-08-28 10:46:11 -0700 Ignis: initial implementation A god specifically designed for use as a zealot start. What if your 'starting kit' was a god that got used up, burned out, and pushed you to risk its (weak) wrath? -------------------------------------------------------------------------------- f7720a2501 | Nicholas Feinberg | 2021-08-28 09:09:04 -0700 Fix evolution The last implementation of it required you to be at the next XL to evolve... which was impossible. When you did reach the next XL, you'd need to reach the one after that to evolve, and so on. Instead, require one XL worth of XP for each evolution. -------------------------------------------------------------------------------- 81c34554c2 | Matthew Daley | 2021-08-28 17:43:59 +0300 feat: Show turn counts and real game times in lobby This lets spectators find potentially interesting games to view, i.e. from a speedrunning perspective. webserver/process_handler.py: * Treat the turn count and duration (real game time) as "interesting info" in the wherefile. webserver/static/scripts/client.js: * Show the new turn count and duration fields. Keep the columns hidden until we see at least one game with the new fields, for nicer backwards compatibility. * While at it, rationalise the units shown for idle times ("min" -> "m", and drop the spaces). webserver/static/style.css, webserver/templates/client.html: * Add new fields, defaulting to be hidden until changed by client.js. -------------------------------------------------------------------------------- 4b70cb3502 | Edgar A. Bering IV | 2021-08-28 17:36:23 +0300 docs: update debian package name for DejaVu (Cebolla) Closes #2094 -------------------------------------------------------------------------------- cd7d0065d9 | Aliscans | 2021-08-28 17:30:15 +0300 Change the spelling of some words to Australian English. Change a few places where words were spelt with -eling at the end and where this is not a correct spelling according to https://www.australian-dictionary.com.au/wordcheck/. This only changes things in places where the spellings may be displayed to the user. I include the documentation in this. I haven't changed the changelog, or any of the contrib stuff. This changes: channeling -> channelling dueling -> duelling groveling -> grovelling quarreling -> quarrelling raveling -> ravelling traveling -> travelling tunneling -> tunnelling Closes #2093 -------------------------------------------------------------------------------- 0b7dbbd7ef | Edgar A. Bering IV | 2021-08-28 17:20:41 +0300 fix: a crash bug in clua.target_desc (mgdelmonte) Closes #2090. -------------------------------------------------------------------------------- f02e23bfe7 | Aliscans | 2021-08-28 17:14:03 +0300 Show gnolls how many levels they need to reach a skill target Show gnolls how many levels they need to reach min delay / no shield penalty for an item. The game already told other species how much experience they needed to remove the penalty for a shield, or reach the minimum attack delay for a weapon. This change extends this to gnolls. It doesn't enable gnolls to set a target as they cannot vary how much experience they put into a skill. [ Committer's note: Closes #2085. Refactored lightly in action selection to deduplicate a condition. ] -------------------------------------------------------------------------------- 3f656e82c2 | Nicholas Feinberg | 2021-08-27 14:50:10 -0700 Reinforce transparent stone tiles To make them hopefully look a bit tougher and more distinct from transparent rock. -------------------------------------------------------------------------------- 1c0f7aac2b | Nicholas Feinberg | 2021-08-27 11:45:54 -0700 Fix Dj spell icons on local tiles Closes #2091 Closes #2095 -------------------------------------------------------------------------------- 36ea832cf1 | John Stahara | 2021-08-27 11:40:58 -0700 Don't ever consider books evil Unfortunate from a flavour perspective, but in gameplay terms it's never detrimental to read a book. This allows autopickup to read books, even if your current god forbids you from casting the spells contained within. It isn't the knowledge that's harmful, after all, but how you use it! -------------------------------------------------------------------------------- 048bc9fd10 | Kate | 2021-08-27 01:47:48 +0100 Remove unused handling for self-casting Tukima's Dance -------------------------------------------------------------------------------- 1e3a1f7914 | advil | 2021-08-26 20:29:42 -0400 fix: prevent bad array access for describing unid'd staves Also add a bunch of other checks around this particular crash; the basic problem here was that SK_NONE is greater than NUM_SKILLS and a lot of code that has skill-related arrays doesn't check bounds and stops at NUM_SKILLS. The specific crash was because `staff_skill` returns SK_NONE in cases where it can't find a matching skill, which happens when a staff is unid'd. Because the bug depended on what was in adjacent memory, the crash was somewhat variable. -------------------------------------------------------------------------------- 17d1ee0984 | advil | 2021-08-26 18:35:18 -0400 fix: transparent tags for some vaults It's better to mark vaults transparent than not, because that allows the builder to check for teleport closets itself, and also allows the placement script to more easily check that the intention indicated by a tag matches with what happens when the vault places. This commit has a batch of fixes for vaults that automated testing indicates should be marked transparent. This stops in a somewhat arbitrary place as I was working on this several months ago and haven't managed to get back to it, but eventually this should be checked for all vaults. This commit also includes a few teleport closet fixes for vaults that didn't immediately show up as being marked transparent. -------------------------------------------------------------------------------- 6aaddb815b | advil | 2021-08-26 18:35:18 -0400 feat: script options for checking vault opacity This new set of options to the placement checker script is designed to find vaults that are not marked as transparent but probably should be. To use this, make sure to test with enough iterations so that randomization can play out. It's actually also somewhat useful for finding vaults that aren't marked as transparent and have a teleport island, when going through vaults one by one. -------------------------------------------------------------------------------- c0b50483a2 | wheals | 2021-08-26 21:43:09 +0300 Interrupt explore by default when a shopping target is reached (perryprog) -------------------------------------------------------------------------------- a0e16d178b | wheals | 2021-08-26 21:43:07 +0300 Fix explore being interrupted by autopickupable items Caused by 14faa60; check_for_interesting_features uses the stash to determine whether to stop, but it was being called without actually updating the stash. -------------------------------------------------------------------------------- f6564f113a | Nicholas Feinberg | 2021-08-26 07:55:33 -0700 Remove riposte from long blades It was intended to create strategic variance by encouraging characters with more EV to use long blades and characters with less EV to use other weapon types. In practice, it just created more complexity without corresponding interesting decisions for players. It'd be possible to simplify into a damage bonus from EV (or Dodging, or Dex), which would accomplish the original design goal... but it's not obvious that said goal would produce good gameplay even if it worked. It's quite difficult to find alternative weapon gimmicks. Wu Jian has taken up much of the rest of the design space, and other common suggestions, e.g. adding innate SH to lbl, just add more numbers & problems to the game without contributing any real decisions. Correspondingly, long blades are mostly returned to their old stats from before 4dea7376dac , with some tweaks from ba988d45092 kept. Fencer's Gloves still have riposte until/unless we decide otherwise. -------------------------------------------------------------------------------- 8de209e91f | Nicholas Feinberg | 2021-08-25 18:59:24 -0700 Fix monster slime wall damage -------------------------------------------------------------------------------- 644a552097 | Nicholas Feinberg | 2021-08-25 18:49:31 -0700 Further spriggan druid desc fixes (dilly) -------------------------------------------------------------------------------- c0dc8c719c | Nicholas Feinberg | 2021-08-25 18:29:27 -0700 Remove more acid splash damage To simplify acid damage and make it more visible in monster descriptions, make acid spells deal all of their damage in the initial attack, rather than following up with some in a separate 'acid splash'. Since this acid splash did 2d4 to monsters and 4d5 to players, and I'm using the latter values for monster acid damage, this is a buff for allied ally damage. To compensate, I've lowered Fedhas oklob fire speed by 25%, roughly the complement of the damage increase. Other sources of allied monster acid damage, such as ?summoned yellow draconians or non-summoned oklobs under Fedhas, are still somewhat buffed, but that seems like a small change with few consequences. -------------------------------------------------------------------------------- f4e2d62f27 | Nicholas Feinberg | 2021-08-25 18:18:45 -0700 Split up acid_splash and corrosion -------------------------------------------------------------------------------- 1c58e7f47f | Nicholas Feinberg | 2021-08-25 18:04:40 -0700 Simplify acid cloud damage -------------------------------------------------------------------------------- 1afa1a9824 | Nicholas Feinberg | 2021-08-25 18:04:20 -0700 Remove unused splash_with_acid params -------------------------------------------------------------------------------- e619aef00b | Nicholas Feinberg | 2021-08-25 18:00:25 -0700 Simplify acid wall splashes -------------------------------------------------------------------------------- 1ef7cba1b3 | Nicholas Feinberg | 2021-08-25 17:27:54 -0700 Clarify sp druid death effect (dilly) It wasn't mentioned in the monster description before. -------------------------------------------------------------------------------- 79ebb2a17b | Kate | 2021-08-26 00:39:03 +0100 Add AoE resistible spells to the default force_targeter These targeters are useful for indicating affected monsters and their chances to resist AoE spells, but are normally only accessible through the quiver. Instead add various untargeted AoE resistible spells to the default list of spells where the targeter is always displayed. -------------------------------------------------------------------------------- 9004c80361 | Nicholas Feinberg | 2021-08-25 12:49:15 -0700 Rename Corrupt Locale -> Corrupt (gammafunk) Nothing to really disambiguate against and much more flavourful. -------------------------------------------------------------------------------- 46a7db7966 | Kate | 2021-08-25 18:52:34 +0100 Don't let Ghostly Sacrifice target projectiles (causative) Projectiles are always considered as "aligned" with other actors (since they never make actual direct attacks?), so orbs of destruction fired by anyone were considered valid targets for monster Ghostly Sacrifice. -------------------------------------------------------------------------------- b8bfbab023 | Kate | 2021-08-25 00:13:55 +0100 Shuffle squares for monster Upheaval animation As with player Upheaval, instead of always displaying them in the same order. -------------------------------------------------------------------------------- cf53092a1b | Kate | 2021-08-25 00:01:29 +0100 Remove some dead Upheaval code Since very shortly after the god was implemented, the code to have Upheaval occasionally destroy walls hasn't actually functioned. Also simplify monster Upheaval's implementation - it iterated over radius 2 but then only ever affected squares in radius 1, so make the code reflect that properly. -------------------------------------------------------------------------------- 639a1a48b9 | Kate | 2021-08-24 04:21:53 +0100 Don't crash when casting an uncapped summon Oops. -------------------------------------------------------------------------------- fa261e29c3 | Kate | 2021-08-24 03:42:48 +0100 Don't try to reroll Shadow Creature spell sets Since no monsters have variable spell sets any more. -------------------------------------------------------------------------------- 01758ec4b5 | Kate | 2021-08-24 03:21:47 +0100 Remove variable timeouts from capped summons Summon spells all had custom timers on how long a summon would remain after hitting the summon cap, but they almost all expired after 5-15 aut (with the only exceptions being Summon Horrible Things, and Summon Dragon, which expired after 40 aut). Instead of having a near-meaningless distinction here, make all capped summons expire after 10 aut. -------------------------------------------------------------------------------- 8580c7503b | Kate | 2021-08-24 03:21:34 +0100 Remove some obsolete summon cap handling Since Monstrous Menagerie no longer creates bands, it doesn't need special handling around summon caps. -------------------------------------------------------------------------------- fbb0926a3a | Kate | 2021-08-23 22:41:23 +0100 Use correct pronouns for monster targeting descriptions -------------------------------------------------------------------------------- 8e8b57cc88 | Kate | 2021-08-23 22:37:46 +0100 Improve skill descriptions for god-related skills Instead of adding some details for Trog only, include information about Invocations usage for all gods, as well as describing any god-hated skills (which is still only Trog in that case, but now properly extends the information to skills other than Spellcasting). -------------------------------------------------------------------------------- 68911e0c57 | advil | 2021-08-22 15:45:15 -0400 refactor: handle self-targeting checks better in beam.cc Xom's chessboard fakes smite targeting for a variety of effects by just setting the beam source to a target monster's position. This leads to some conflation of real self-targeting and fake smite-targeting in a bunch of subtle corner cases, and also led to 12637. Rather then handle this on case-by-case basis as in 395adb26f73b for poly and a708605c5b for teleport, this commit restores the general check from pre-395adb26f73 but makes it more restrictive. It also sets the agent for xom's chessboard actions (as the player, tbc) in the course of this. This commit should also fix some related weirdness with wrath that hasn't yet come up. -------------------------------------------------------------------------------- 79c9209bdd | Kate | 2021-08-22 20:17:53 +0100 Simplify some rain cloud behaviour Don't make the chance of rain clouds creating water depend on how much water or lava is adjacent to them. -------------------------------------------------------------------------------- 9cc4ca73b0 | Kate | 2021-08-22 20:17:39 +0100 Make the robe of Clouds' thunder passive So as to continue moving away from activated abilities on equipment (as with other unrands such as the cloak of the Thief and ratskin cloak), give the robe of Clouds a chance of creating a storm cloud on enemies within radius 2 each turn. Also mention its cloud immunity in the description. -------------------------------------------------------------------------------- 5c1c4949f7 | Kate | 2021-08-22 18:12:03 +0100 Fix spacing -------------------------------------------------------------------------------- 5d50cf8172 | Kate | 2021-08-22 18:11:36 +0100 Remove some obsolete ability code And an outdated comment. -------------------------------------------------------------------------------- c3c367e0a5 | Edgar A. Bering IV | 2021-08-22 16:38:42 +0300 feat: corrupt trees into demonic trees For Mliogotl and player corruption, turn (permanently) trees corrupted into demonic trees. This is technically not a "flavour" effect because of the difference in how they burn, but it's close enough and ultra flavourful. -------------------------------------------------------------------------------- b8ca4b6547 | Kate | 2021-08-22 02:59:18 +0100 Adjust some stat zero effects Replace 0 strength's regeneration reduction with -Regen in monster LOS (the same as the mutation), to give it an effect in combat without making resting take excessive time. Also replace 0 intelligence's 4/5 chance for scroll-reading to fail with -Scroll (since it no longer needs to be possible to read remove curse scrolls to unequip cursed -Int gear). This whole mechanic could probably be simplified further since it's such a rare occurence. -------------------------------------------------------------------------------- dd10bd25a4 | Kate | 2021-08-22 02:51:30 +0100 Add a description for the -Regen status light -------------------------------------------------------------------------------- b1a13b149e | Kate | 2021-08-22 01:15:53 +0100 Rework Sap Magic It was very overcomplicated for such a rare effect, and its implementation of applying multiple levels of spell failure penalty required the player to repeatedly check their spell success rates between each cast. Instead of the scaling penalty, make casting spells under Sap Magic always apply a short duration -Cast. (This also makes its effect on players more similar to its effect on monsters of applying antimagic - it'd probably be feasible to make the effects match and implement -Cast for monsters but this doesn't seem worth the effort.) Sap Magic also had a confusing 3/10 chance to have no effect when cast, despite being otherwise irresistible - just remove this failure chance entirely, since the spell already has a fairly low cast rate. -------------------------------------------------------------------------------- 086cc6695f | Nicholas Feinberg | 2021-08-21 14:58:14 -0700 Update Attr status description. -------------------------------------------------------------------------------- 7ea6ab310f | Nicholas Feinberg | 2021-08-21 14:56:42 -0700 Fix a 7-year-old typo oops -------------------------------------------------------------------------------- d9515000ea | Edgar A. Bering IV | 2021-08-21 20:00:48 +0300 fix: silence a compiler warning -------------------------------------------------------------------------------- 237fc358d9 | mgdelmonte | 2021-08-21 19:54:05 +0300 feat: lua access to monster targeting descriptions This commit adds target_desc, target_weapon, target_spell, and target_throw functions to the Lua monster_info object. target_desc returns the targeting description of the monster. The other function returns the descriptions shown if you target a monster with your weapon, a spell, or a thrown item. [ Committer's note: Closes #1922. Rebased and cleaned up commit history. Made the spell target_desc pick up all of the possible fancy addl descs and be future proof for them, as well as crash robust for spells that lack a hitfunc. ] -------------------------------------------------------------------------------- b260e8e558 | Edgar A. Bering IV | 2021-08-21 17:45:34 +0300 fix: Mlio spell logic fixes Move all corrupt locale casting to use the spell_logic structures. Clean up the code to use const refs instead of passing by value. Properly handle a friendly Mlio. -------------------------------------------------------------------------------- b12d812e02 | amcnicky | 2021-08-21 16:07:10 +0300 feat: Mlioglotl, an Abyss themed unique Mlioglotl is a mid game unique with the power to (temporarily) corrupt levels, spawning in Swamp, Vaults, Depths, and Abyss:2 onward. Mlio's corruption produces abyssal summons drawn from the full spawn table; a Swamp-depth character might have to run depending on the roll. The gameplay feel is to force the player to either avoid or swiftly kill before the summons and terrain get out of control. [ Committer's notes: buffed the damage, defenses, and casting frequencies so that Mlio hits appropriately hard for his locales, expanded the spawn range to include V:$ and U:4-5. Gave corruption guaranteed summons (and a roll), and allowed it to roll monsters from the full abyss table. Mlio might pull chaff to his aid, or he might get a hell sentinel and a bone dragon. There will be a lot of variability in the nature of encounters, but this is part of the design vision. The summon duration is shorter, to allow escapes. Simplified and refactored the monster version of corrupt, it doesn't need to be a complete mirror of the player mechanics. Especially don't recolour outside of Mlio's immediate locale. The temp terrain is placed for a shorter duration, so that a long encounter will get some "abyssal churn" feel. Fixed whitespace, cleared unneeded XXX comments other code clean-up. Moved Mlio to the appropriate place in Mon-data and used brown for the console colour so that glyphs don't overlap. Closes #2058 ] -------------------------------------------------------------------------------- 76b539d98b | Nicolae Carpathia | 2021-08-20 11:19:33 -0400 Rearrange existing quotes and add new ones Scroll of tele quote (ADMIN) moved to Swiftness, at PF's suggestion. Existing scroll of fear quote moved to /dev/null, it's not even by Plato, and replaced with old eidolon quote. Add new quotes, featuring T.S. Eliot, Homer, Lovecraft, Pablo Neruda, Shakespeare, Lord Byron, Nine Inch Nails, and more. -------------------------------------------------------------------------------- 1bb7f9241b | Kate | 2021-08-20 15:35:27 +0100 Tweak duel speech weighting So that adding new speech lines doesn't affect their chance to speak. -------------------------------------------------------------------------------- 0f8ce75afc | Kate | 2021-08-20 15:35:27 +0100 Fix spelling and some incorrect speech keys -------------------------------------------------------------------------------- 2b4a79830d | Edgar A. Bering IV | 2021-08-20 17:11:55 +0300 feat: recommend brigand over hunter for Ko (dilly) Recommendations are supposed to be thematic and flavourful as well as suited to the species. Kobolds have AM as a "ranged" recommend, and there's literally a Kobold Brigand monster. What could be more thematic than to be one yourself! Closes #2038 -------------------------------------------------------------------------------- ad6161974e | RojjaCebolla | 2021-08-20 16:57:14 +0300 Add a few more _anger_possessive_ strings -------------------------------------------------------------------------------- c0b1434407 | RojjaCebolla | 2021-08-20 16:56:23 +0300 Add pennants for duel spectators (text string) -------------------------------------------------------------------------------- 8eabd40a87 | RojjaCebolla | 2021-08-20 16:56:23 +0300 Add a couple adjective strings -------------------------------------------------------------------------------- dc40aaacc9 | RojjaCebolla | 2021-08-20 16:56:23 +0300 Add a few more actions for Okawaru Duel spectators -------------------------------------------------------------------------------- 0da4227f7a | RojjaCebolla | 2021-08-20 16:56:23 +0300 Re-add fruit names to the string generators This brings back some of the fruits of 1eb5282a -------------------------------------------------------------------------------- 8e425c6592 | Edgar A. Bering IV | 2021-08-20 13:44:03 +0300 doc: changelog for 0.27.1 main and debian -------------------------------------------------------------------------------- cbf37d0371 | robertxgray | 2021-08-20 12:34:40 +0300 Vampires are not (pure) lifeless undead This cleans up the following undesired effects: - Rage and lignification potions are tagged as useless. - Wanderers can't receive such potions. - Poison ring tagged as useless while bloddless and other poison related side effects. - Kikubaaqudgha does not grant Sublimation of Blood. [ Committer's note: Closes #2055. Adjusted commit message. Tweaked a few other vampire hacks in spl-util.cc. ] -------------------------------------------------------------------------------- b7ea06bb7e | Edgar A. Bering IV | 2021-08-20 12:21:03 +0300 Revert "Don't consider rings of rPois useless for bloodless vampires" This reverts commit e31878e1fe37459b33a9e04917198de829909ca1. A different solution will be commited subsequently. -------------------------------------------------------------------------------- a7b0c1cb7f | Edgar A. Bering IV | 2021-08-20 12:19:53 +0300 doc: update CREDITS -------------------------------------------------------------------------------- 50b444eb91 | Zhang Kai | 2021-08-20 12:17:55 +0300 Update branches.txt Add translation. 增添翻译。 [ Committer's note: Closes #2063. Fixed whitespace, removed incorrectly placed credit line. Corresponding with the PR author on appropriate CREDITS entry. ] -------------------------------------------------------------------------------- b0f16cbe65 | John Stahara | 2021-08-20 12:14:55 +0300 indent fix -------------------------------------------------------------------------------- 080cfb6e2c | John Stahara | 2021-08-20 12:14:55 +0300 "Okay, then" on saying 'n' to warn_hatches prompts -------------------------------------------------------------------------------- 14faa605fd | Aliscans | 2021-08-20 12:01:39 +0300 Check for monsters, objects & features as soon as you move. (#2041) Check for things after the player moves, rather than waiting for the start of the next turn. Improve the accuracy of a