-------------------------------------------------------------------------------- a7dcef7 | Aidan Holm | 2018-07-15 11:29:28 +0800 Fix mutation UI printing formatting tags (kitchen_ace) -------------------------------------------------------------------------------- ffb0f71 | Aidan Holm | 2018-07-15 11:17:22 +0800 Fix god, item UIs printing formatting tags (|amethyst) This was caused by Text(string) no longer parsing its input by default; there might be a few other unconverted uses. This commit also adds a hacky formatted_string::trim() implementation. -------------------------------------------------------------------------------- 283c1ef | advil | 2018-07-14 17:08:57 -0400 Quiet another warning on DGAMELAUNCH builds -------------------------------------------------------------------------------- ee04ee8 | advil | 2018-07-14 16:42:52 -0400 Quick fix for webtiles menu bug The problem seems to be that this global variable was getting out of date at some point, and so referenced a div that is no longer in the DOM. I haven't tracked down why but at least on old UI code this sort of thing would happen when resizing, since the DOM would get completely rebuilt. In any case, in my testing this fixes the bug. -------------------------------------------------------------------------------- 1dba295 | advil | 2018-07-14 16:24:49 -0400 Quiet a warning on some build configurations -------------------------------------------------------------------------------- 5410c3b | advil | 2018-07-14 16:06:00 -0400 tabs to spaces -------------------------------------------------------------------------------- 420b899 | advil | 2018-07-14 16:03:01 -0400 Fix os x compilation The replaced `auto` was getting `long long`, which led to an error on the min call. Hopefully this won't break other OSs. -------------------------------------------------------------------------------- 7732505 | Aidan Holm | 2018-07-15 01:48:22 +0800 Revert "Clip tall monster tiles in webtiles monster list" This commit caused tall monsters to 'smear' as they moved across the webtiles viewport, for reasons I don't entirely understand yet. This reverts commit c0cf510be224db181515dde563bebf1eb9e22036. -------------------------------------------------------------------------------- 6546e2e | Aidan Holm | 2018-07-15 01:17:52 +0800 Fix FS_START_AT_END being ignored Caused by UINT_MAX overflowing to -1 when converted to a signed int. -------------------------------------------------------------------------------- e3c7468 | Aidan Holm | 2018-07-15 00:59:38 +0800 Fix some new UI CSS bugs Scroller shades should be the same colour as the background (currently #040204), and text rendered within UI popups should never have a black background, -------------------------------------------------------------------------------- eec28cc | Aidan Holm | 2018-07-14 17:00:26 +0800 Fix HTML formatted scroller line height detection -------------------------------------------------------------------------------- a1f343f | Aidan Holm | 2018-07-14 15:42:46 +0800 Show ghost species tiles -------------------------------------------------------------------------------- 0f66341 | Aidan Holm | 2018-07-14 15:42:42 +0800 Only give ghosts pumpkin heads on Halloween -------------------------------------------------------------------------------- 3670636 | Aidan Holm | 2018-07-14 14:17:01 +0800 Fix compiler warnings -------------------------------------------------------------------------------- c0cf510 | Aidan Holm | 2018-07-14 13:28:04 +0800 Clip tall monster tiles in webtiles monster list -------------------------------------------------------------------------------- a083f4b | Aidan Holm | 2018-07-14 13:28:04 +0800 Fix cramped spell description text (NormalPerson7) -------------------------------------------------------------------------------- 0d75190 | Aidan Holm | 2018-07-14 13:28:04 +0800 Fix string formatting not being rendered -------------------------------------------------------------------------------- 8f10877 | Aidan Holm | 2018-07-14 13:28:03 +0800 Fix incorrect lookup-help menu flags This resulted in ?/B0 (labyrinth) not working correctly, as its hotkey was interpreted as the beginning of a selection count. -------------------------------------------------------------------------------- 6c7ed9e | Aidan Holm | 2018-07-14 13:28:03 +0800 Fix webtiles menu scrolling with non-100% zoom (NormalPerson7) NormalPerson7 noticed that menus got stuck when scrolling while using certain zoom levels. This was caused by update_visible_indices() not correctly accounting for the page zoom level, and thus always reporting the same (incorrect) supposedly-visible region. Since this function had a lot of handling for the previous implementation, which supported partially loaded menus, I've replaced it with a simpler version that is a reasonably straight-forward conversion of the code in menu.cc. -------------------------------------------------------------------------------- b17f314 | Aidan Holm | 2018-07-14 13:28:03 +0800 Show ring swap menu when wearing from inventory When putting on a ring from the inventory item description, the prompt in the messages region was obscured by the UI shade. When putting on rings in this way, just always show the menu; it's a simple fix and more intuitive than hiding the popup menus. It's still a little weird that (p)utting on the ring immediately dismisses the description popup. -------------------------------------------------------------------------------- 52e19c0 | Aidan Holm | 2018-07-14 13:28:03 +0800 Always set mouse event .held and .mod -------------------------------------------------------------------------------- 36a25f2 | Aidan Holm | 2018-07-14 13:28:03 +0800 Use new hover style for BoxMenuHighlighter -------------------------------------------------------------------------------- e1e3f6e | Aidan Holm | 2018-07-14 13:28:03 +0800 Remove BlackWhiteHighlighter BoxMenuHighlighter seems to do exactly the same thing on console. -------------------------------------------------------------------------------- 129b045 | Aidan Holm | 2018-07-14 13:28:03 +0800 Show msgwin_get_line as a popup when necessary i.e. when there is no game currently playing, or when one or more UI layouts are already being shown (and the message region is obscured). This includes a new HTML input UI, as the problem of the message region being obscured also existed on webtiles. Currently, this is very simplistic, and doesn't use a text box; instead, keystrokes are forwarded to the server, which then updates the HTML API; so every keypress requires a round trip to render. There's quite a few call sites that use cancellable_get_line directly; it's unclear whether there's any special reason for doing so, but they'll need to be converted to use msgwin_get_line() (if possible) to reap the benefits of this commit. -------------------------------------------------------------------------------- 6bfa959 | Aidan Holm | 2018-07-14 13:28:03 +0800 Show popup yesno when not in main UI -------------------------------------------------------------------------------- cb9e76d | Aidan Holm | 2018-07-14 13:28:03 +0800 Fix stale input state on local tiles (Currency) -------------------------------------------------------------------------------- 78a66ff | Aidan Holm | 2018-07-14 13:28:03 +0800 Tweak spacing on ability, spell menus Spell menu: stops the menu from changing width when toggling between views with ! Ability menu: this makes them the same width as the heading, which prevents the item text from wrapping when the menu width is reduced. -------------------------------------------------------------------------------- 954b274 | Aidan Holm | 2018-07-14 13:28:03 +0800 Refactor and improve Menu UI implementation This commit breaks up the functionality previously implemented by the UIMenu widget. Scrolling is now implemented with the UIScroller widget, which provides a more consistent interface, and menu title and more text are rendered with UIText widgets. In addition, the visual style of menu items has been updated and improved, with some rendering fixes and better margins; we now also have mouse cursor effects! It's not all good news, though; unfortunately, the restart-allocation issue is back with a vengeance. This is necessitated by the desire to use one column when there's available space. While this was previously manageable due to UIMenu rendering the entire menu (including title and more), it's now complicated by rendering being split among multiple widgets. This complexity is partly caused by a mismatch between the constraints of the widget layout system and by the desired behaviour of the menu UI. A layout algorithm like Flutter's might be a better match, as it allows widget children to decide their size, rather than the parent choosing the size of its children. It's unclear whether there might be other areas of crawl UI that are a poor fit for the Flutter model, however, and at this point, with the complex bit written (and hopefully bug free), I'd prefer to stick with what's already implemented and working. -------------------------------------------------------------------------------- 1d12019 | Aidan Holm | 2018-07-14 13:28:03 +0800 Add informational scrollbars to scroller widget These cannot (yet) be dragged with the mouse; they only indicate the current scroll position and, to a lesser degree, the amount of scrollable content. -------------------------------------------------------------------------------- ec331d1 | Aidan Holm | 2018-07-14 13:28:03 +0800 Add UI mouse enter/leave events -------------------------------------------------------------------------------- 4af17ab | Aidan Holm | 2018-07-14 13:28:02 +0800 Linebreak save-update prompt text yesno() now uses a menu to show this text, which doesn't wordwrap its prompt text automatically. -------------------------------------------------------------------------------- 82b979e | Aidan Holm | 2018-07-14 13:28:02 +0800 Replace prompt yes/no icons I'm no artist, but these fit the current visual design a little better. -------------------------------------------------------------------------------- 13706d6 | Aidan Holm | 2018-07-14 13:28:02 +0800 Use menu for yesno prompt outside game (Currency) This fixes an issue where the yesno prompt text was not being shown because redraw_screen() was not being called to show updates to the message buffer. Rather than work out what's actually going on there, I've opted to use the TOUCH_UI popup code when outside of a game, as showing the messages panel without a game loaded looks very buggy. mprf() is still used when calling yesno() inside a game, unless TOUCH_UI is defined. -------------------------------------------------------------------------------- f062400 | Aidan Holm | 2018-07-14 13:28:02 +0800 Add more event handling to ui_pump_events (Currency) -------------------------------------------------------------------------------- f843350 | Aidan Holm | 2018-07-14 13:28:02 +0800 Add MF_SWAP_MODE menu mode -------------------------------------------------------------------------------- bec60cc | Aidan Holm | 2018-07-14 13:28:02 +0800 Add item/spell/ability menu adjust mode Functionality is implemented in menu.cc, and is enabled whenever a menu has an `on_entry_swap` callback, which does the actual swapping. An additional `swap_mode_prompt_noun` member is used to generate the swap prompt text. The on_entry_swap callback receives the first item to swap, and either a pointer to the second or a key to swap it to. Swap mode is entered by pressing = on a menu that supports it. An already-existing item is then selected, followed by a letter that may or may not refer to an existing item. Swapping an item to its own letter cancels the swap, but stays in swap mode. At any time, = or ESC cancels the swap and leaves swap mode. -------------------------------------------------------------------------------- bdb2496 | Aidan Holm | 2018-07-14 13:28:02 +0800 Add menu title indentation automatically -------------------------------------------------------------------------------- cdcb5b2 | Aidan Holm | 2018-07-14 13:28:02 +0800 Remove easy_exit_menu option -------------------------------------------------------------------------------- e6dabca | Aidan Holm | 2018-07-14 13:28:02 +0800 Fix SDL tiles arena UI bugs Fixes the arena crashing and otherwise failing to handle window resizing correctly. A mostly straight-forward conversion. ui_delay() is a replacement for delay() that still responds to UI events, although the delay currently cannot be interrupted (which is sub-optimal). In tilereg-map.cc, add_square() checks the current transform to ensure that the square is pixel perfect regardless of the transform, so we need to match the transforms used at buffer-packing- and at render-time. -------------------------------------------------------------------------------- 8af06f9 | Aidan Holm | 2018-07-14 13:28:02 +0800 Prevent webtiles game body from scrolling This prevents webtiles menu scrolling affecting the game window in the background, which looks odd. -------------------------------------------------------------------------------- 8ffa595 | Aidan Holm | 2018-07-14 13:28:02 +0800 Add menu.set_title() indent option The bit where titles are still passed in as a MenuEntry is still weird and hacky, and I'm not happy about the boolean blindness this introduces. But it does fix some bugs. -------------------------------------------------------------------------------- cf2c241 | Aidan Holm | 2018-07-14 13:28:02 +0800 Improve loading splash screen UI Uses the new UI framework, as usual. Now handles resizes correctly, and renders the splash screen with filtering enabled. Todo: separate the DCSS logo from the splash image, so that it can be rendered independently of the scaled splash image. Visual design could do with some polish; some of the splash screens have hard edges that look a little out of place, for example. -------------------------------------------------------------------------------- e1d3802 | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap end-game hiscore list in popup widget -------------------------------------------------------------------------------- 5bc55b2 | Aidan Holm | 2018-07-14 13:28:01 +0800 Remove unnecessary more() and clrscr() A more is already forced by the code below, and the clrscr call messes up the local tiles display. -------------------------------------------------------------------------------- 929062c | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap _print_error_screen() in popup widget -------------------------------------------------------------------------------- 161852b | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap arena startup prompt in popup widget We also add simplistic colour highlighting for the entry; the two teams are highlighted in white, and the ' v ' is lightgrey. -------------------------------------------------------------------------------- 5379f3e | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap tutorial end messages in popup widgets -------------------------------------------------------------------------------- f9c367d | Aidan Holm | 2018-07-14 13:28:01 +0800 Remove CRT menu attaching functionality -------------------------------------------------------------------------------- 3273467 | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap the hiscores menu in a popup widget -------------------------------------------------------------------------------- 7e740b3 | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap the new game menus in popup widgets -------------------------------------------------------------------------------- 6f189af | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap the main menu in a popup widget Like the skill menu, this is for visual consistency. -------------------------------------------------------------------------------- 12418ba | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap doll editor in a popup widget -------------------------------------------------------------------------------- 2e76a7d | Aidan Holm | 2018-07-14 13:28:01 +0800 Wrap skill menu in a popup widget Still the same old PrecisionMenu implementation underneath, but wrapped up in a UIPopup; this is mostly for visual consistency on local tiles. -------------------------------------------------------------------------------- a582a2a | Aidan Holm | 2018-07-14 13:28:01 +0800 Add SDL wrapper API to set mouse cursor We use a switch statement here to explicitly guarantee that our cursor enum values are contiguous and start at zero, since we don't yet wrap all the cursor types that SDL supports. -------------------------------------------------------------------------------- c96d248 | Aidan Holm | 2018-07-14 13:28:01 +0800 Add webtiles formatted scroller highlighting -------------------------------------------------------------------------------- 1039b03 | Aidan Holm | 2018-07-14 13:28:00 +0800 Add HTML spell menus on webtiles -------------------------------------------------------------------------------- 43034bf | Aidan Holm | 2018-07-14 13:28:00 +0800 Add tiles to HTML monster description UI -------------------------------------------------------------------------------- b4c22b7 | Aidan Holm | 2018-07-14 13:28:00 +0800 Add text widget highlighting support -------------------------------------------------------------------------------- 9c721c8 | Aidan Holm | 2018-07-14 13:28:00 +0800 Add formatted_string::substr_bytes() -------------------------------------------------------------------------------- 7e28d6f | Aidan Holm | 2018-07-14 13:28:00 +0800 Prevent some menu resizes when (de)selecting items Specifically, in the pickup and drop menus and in the shop UI, selection change changes the menu title/more text, which can cause the menu width to change. It's hacky, but to work around this for now we just pad the relevant strings. -------------------------------------------------------------------------------- 6fbea35 | Aidan Holm | 2018-07-14 13:28:00 +0800 Add menu title and more padding -------------------------------------------------------------------------------- cb03d4b | Aidan Holm | 2018-07-14 13:28:00 +0800 Show trailing partially visible menu items -------------------------------------------------------------------------------- b1c2063 | Aidan Holm | 2018-07-14 13:28:00 +0800 Add menu overflow gradients -------------------------------------------------------------------------------- 3fb71ae | Aidan Holm | 2018-07-14 13:28:00 +0800 Use a formatted scroller for the help UI -------------------------------------------------------------------------------- 364e786 | Aidan Holm | 2018-07-14 13:28:00 +0800 Add improved deck description UI -------------------------------------------------------------------------------- 1f9488b | Aidan Holm | 2018-07-14 13:28:00 +0800 Synchronize formatted scrollers between clients We always recalculate the line height every time we scroll: it's possible the line height has changed if the page zoom level has changed. When calculating the current scroller position (line number) it's necessary to round to the nearest integer; with non-100% zooms there's some rounding errors that sneak in and produce line numbers that are ever so slightly less than a whole number, and rounding this to a whole number is the most robust solution. -------------------------------------------------------------------------------- bdc67e0 | Aidan Holm | 2018-07-14 13:28:00 +0800 Add scroller widget overflow gradients -------------------------------------------------------------------------------- 60de621 | Aidan Holm | 2018-07-14 13:27:59 +0800 Add HTML formatted scroller UI -------------------------------------------------------------------------------- b0f107b | Aidan Holm | 2018-07-14 13:27:59 +0800 Add HTML version description UI -------------------------------------------------------------------------------- 1c60cbd | Aidan Holm | 2018-07-14 13:27:59 +0800 Add HTML monster description UI -------------------------------------------------------------------------------- 8a2288e | Aidan Holm | 2018-07-14 13:27:59 +0800 Add HTML describe-god UI -------------------------------------------------------------------------------- cd832e5 | Aidan Holm | 2018-07-14 13:27:59 +0800 Add HTML mutations/vamp-attrs UI -------------------------------------------------------------------------------- e6589a7 | Aidan Holm | 2018-07-14 13:27:59 +0800 Add getter for top UI popup -------------------------------------------------------------------------------- f7378a7 | Aidan Holm | 2018-07-14 13:27:59 +0800 Add HTML paneset construct This is the HTML equivalent of the UISwitcher widget: a set of widgets (divs) in the same position, only one of which is visible at any one time, that all maintain the same size. It's implemented as a 1x1 grid, but that might need to be changed for browser compatibility reasons. -------------------------------------------------------------------------------- 35ee80c | Aidan Holm | 2018-07-14 13:27:59 +0800 Implement some webtiles UIs in HTML -------------------------------------------------------------------------------- f2165d8 | Aidan Holm | 2018-07-14 13:27:59 +0800 Add branch tile to ?/B descriptions -------------------------------------------------------------------------------- 1ce9c33 | Aidan Holm | 2018-07-14 13:27:59 +0800 Add webtiles UI stack APIs This commit repurposes the existing C stack of menus into a general stack of UI layers (parallel to the UI widget stack), adding the ability to store one or more JSON data blobs used to construct a HTML UI. Each non-menu, non-CRT stack frame contains a vector of JSON strings; the first is the data used to construct the initial UI, and any extra JSON strings are used to cache state mutation messages separately. When the initial state is large (e.g. crawl manual help page), this permits sending only a short message to all spectators for each mutation (e.g. page scroll), instead of always resending the full state, while also making it possible for newly-joined spectators to become fully up-to-date. -------------------------------------------------------------------------------- 8ed8a87 | Aidan Holm | 2018-07-14 13:27:59 +0800 Implement stack-five UI as a menu -------------------------------------------------------------------------------- 8e67019 | Aidan Holm | 2018-07-14 13:27:59 +0800 Refactor spectator menu tracking -------------------------------------------------------------------------------- 5e79477 | Aidan Holm | 2018-07-14 13:27:59 +0800 Always send full menu data -------------------------------------------------------------------------------- 234bcd4 | Aidan Holm | 2018-07-14 13:27:58 +0800 Fix excessive webtiles traffic from menu deselect_all This is a quick fix: avoid sending one webtiles message per menu item that wasn't originally selected. Also, the "sq" (selected quantity) JSON property has been removed: menu.js wasn't using it. Note that items still need to be sent after a selection change, as the item text may be changed automatically. -------------------------------------------------------------------------------- f6ec910 | Aidan Holm | 2018-07-14 13:27:58 +0800 Shrink webtiles CRT popup in some places This is something of a hack; ideally, the server would send a JSON message containing the data required for the webtiles client to render its own view of popups. -------------------------------------------------------------------------------- 2724650 | Aidan Holm | 2018-07-14 13:27:58 +0800 Make webtiles menu mouse-scrollable -------------------------------------------------------------------------------- 3696671 | Aidan Holm | 2018-07-14 13:27:58 +0800 Add HTML scroller This adds a function that wraps the contents of a div into a scrollable container. - default scrollbars are replaced (they look seriously out of place) - semitransparent overflow 'shades' are added at the top and bottom of the scroll container. In addition, we place the scroll container on its own render layer. Effectively this means that the menu contents are rendered to a texture, rather than rendered directly; this means that scrolling is much faster, as painting now consists of translating and rendering that texture, as opposed to doing a layout pass over the menu items. With large menus (the largest I know of is ?/m .*) this takes menu two-finger scrolling from very janky to perfectly smooth. -------------------------------------------------------------------------------- fc52b2c | Aidan Holm | 2018-07-14 13:27:58 +0800 Improve webtiles menu appearance -------------------------------------------------------------------------------- 582254c | Aidan Holm | 2018-07-14 13:27:58 +0800 Add popup background to webtiles I'm not entirely happy with how this is done, but there doesn't seem to be a better alternative, short of using a canvas. In particular, CSS sprites with multiple backgrounds doesn't work. -------------------------------------------------------------------------------- 22cf74f | Aidan Holm | 2018-07-14 13:27:58 +0800 Add webtiles popup UI stack This commit adds an additional webtiles game API to show popups. Unlike the existing show_dialog() and hide_dialog() functions, the new API supports a stack of popups. This API is not available from the client. This avoids adding a permanent back-compatibility requirement, and also means that no manual merges are necessary on servers. -------------------------------------------------------------------------------- b56509f | Aidan Holm | 2018-07-14 13:27:58 +0800 Render menus with new UI framework This commit replaces most of the menu rendering code with a newer implementation. - MenuDisplay abstraction replaced with a single UIMenu class. This class implements the menu widget used by the UI framework, for both tiles and console builds. - tilereg-menu has been merged into UIMenu. - Misc. other code improvements and bug fixes. Most of the UIMenu implementation is fairly straightforward; the only complication is its width-for-height nature. The menu UI will use one column if there is enough vertical space to display all items, falling back to a two-column layout otherwise, and so the menu's provisional height must be known to calculate its corresponding width. This is incompatible with the UI framework, which can only accomodate widgets whose height varies based on their width. To work around this, the menu widget sets itself to expand vertically to determine the available height; it then disables vertical expansion and requests re-layout, using the determined height in the second layout pass. -------------------------------------------------------------------------------- e4b3838 | Aidan Holm | 2018-07-14 13:27:58 +0800 Add resumable_line_reader This is intended for use as an interim measure, until I get around to adding a text input widget. The base line_reader cannot be used in new UI code, since the UI framework needs to provide the keys that arrive at the widget. The resumable_line_reader works around that by being driven externally with putkey(). -------------------------------------------------------------------------------- dda5ca5 | Aidan Holm | 2018-07-14 13:27:58 +0800 Add ui::getch() This commit adds a ui-layout-aware equivalent to getch(), and allows UI code to associate a layout with a specific keymap context. Currently, UI layouts and their keymap contexts are stored separately; this might change once the distinction between layouts and widgets is clarified. -------------------------------------------------------------------------------- 481745b | Aidan Holm | 2018-07-14 13:27:58 +0800 Make menu columns as narrow as possible -------------------------------------------------------------------------------- ef52903 | Aidan Holm | 2018-07-14 13:27:58 +0800 Replace PopupRegion with menus Pretty straightforward. MenuRegion is next... -------------------------------------------------------------------------------- 50fa2d4 | Aidan Holm | 2018-07-14 13:27:58 +0800 Remove unneeded mouse_control yesno() has its own MOUSE_MODE_YESNO -------------------------------------------------------------------------------- 915e485 | Aidan Holm | 2018-07-14 13:27:57 +0800 Send mouse button pseudo-keys for compatibility -------------------------------------------------------------------------------- 2e207e4 | Aidan Holm | 2018-07-14 13:27:57 +0800 Spruce up the god UI On local tiles: - Expand the UI enough so that switching between panes does not force the height to change. But, if the window is too small, shrink the UI and allow scrolling. - Add the altar tile to the UI. The vertical centring of the god name is sometimes visualy a little iffy when the altar tile is visually unbalanced (e.g. Trog's altar). On all platforms: - Don't adjust the prompt height when switching between god join prompts. Currently, this is only relevant for Gozag, who has some additional fee text. - Don't scroll the top line with the god name or the more text; only scroll the description. - Always scroll / switch pages when the relevant key is pressed, even if a god join prompt is being displayed. -------------------------------------------------------------------------------- d0573e7 | Aidan Holm | 2018-07-14 13:27:57 +0800 Show tiles for more descriptions Skills, abilities, cards (just the generic card tile), and clouds -------------------------------------------------------------------------------- d62d397 | Aidan Holm | 2018-07-14 13:27:57 +0800 Don't resize mutation UI when showing vamp attrs -------------------------------------------------------------------------------- 0867f05 | Aidan Holm | 2018-07-14 13:27:57 +0800 Use new description UIs for ?/I, ?/A, ?/K, ?/F -------------------------------------------------------------------------------- d0d35ae | Aidan Holm | 2018-07-14 13:27:57 +0800 Add tile option to show_description() -------------------------------------------------------------------------------- 2fc808d | Aidan Holm | 2018-07-14 13:27:57 +0800 Add Switcher widget This widget only shows one of its children at a given time, but keeps the same size regardless of the child it is showing. Its size is determined by the size requirements of its children. -------------------------------------------------------------------------------- 36a14b3 | Aidan Holm | 2018-07-14 13:27:57 +0800 Show tiles for all described dungeon features -------------------------------------------------------------------------------- fa58e6d | Aidan Holm | 2018-07-14 13:27:57 +0800 Don't include title twice in show_description() UI -------------------------------------------------------------------------------- bad7c4e | Aidan Holm | 2018-07-14 13:27:57 +0800 Refactor spell-letter to item pairings This commit reimplements the storage for spell-letter pairings as a single structure. The previous implementation had two different structures, and couldn't handle missing letters. -------------------------------------------------------------------------------- b5f1695 | Aidan Holm | 2018-07-14 13:27:57 +0800 Add { -> i alias in item description UI -------------------------------------------------------------------------------- 8bf25d9 | Aidan Holm | 2018-07-14 13:27:57 +0800 Use improved spell description UI for ?/S -------------------------------------------------------------------------------- 6446de9 | Aidan Holm | 2018-07-14 13:27:57 +0800 Add UI widget min/max sizes This is used to limit the size of description popup boxes so that paragraphs don't become fully unwrapped into a single very wide line. -------------------------------------------------------------------------------- a02aae8 | Aidan Holm | 2018-07-14 13:27:56 +0800 Reimplement formatted scroller This is the uber commit that 1) moves the formatted_scroller implementation out of menu.cc and reimplements it with the new UI code, and 2) adjusts everything that used formatted_scroller to account for slight API differences. There's also a few places where this commit reimplements the UI, using the new UI framework instead of a formatted_scroller, for two reasons: 1) we want to show tiles as part of the UI, and 2) we plan to further extend each individual UI (item description, spell description, etc) in ways that require access to the UI widgets (and prevent the use of a description-with-icon UI abstraction). -------------------------------------------------------------------------------- 6b7a2dd | Aidan Holm | 2018-07-14 13:27:56 +0800 Add helper for running UI layers (Currency) -------------------------------------------------------------------------------- daa132a | Aidan Holm | 2018-07-14 13:27:56 +0800 Remove lookup-help spellbook specialization -------------------------------------------------------------------------------- 95e8667 | Aidan Holm | 2018-07-14 13:27:56 +0800 Add DungeonCellBuffer::add_monster() The DungeonCellBuffer renders monsters correctly (full demon parts for example): this function adds a way to render a monster and its status icons to a DungeonCellBuffer, without including the floor, etc: to be used in monster descriptions. -------------------------------------------------------------------------------- 0599262 | Aidan Holm | 2018-07-14 13:27:56 +0800 Add UIDungeon wrapper for DungeonCellBuffer -------------------------------------------------------------------------------- 8742d9a | Aidan Holm | 2018-07-14 13:27:56 +0800 Add UIPopup widget -------------------------------------------------------------------------------- 8ddcb42 | Aidan Holm | 2018-07-14 13:27:56 +0800 Render new UI layouts on top of old UI This change renders the pre-existing tiles UI before rendering the UI hierarchy. Since most of the UI using the new system are popup windows, this works nicely. -------------------------------------------------------------------------------- 0d1085f | Aidan Holm | 2018-07-14 13:27:56 +0800 On console, only redraw dirty part of screen -------------------------------------------------------------------------------- 124b843 | Aidan Holm | 2018-07-14 13:27:56 +0800 Only redraw when screen contents have changed -------------------------------------------------------------------------------- 98b620f | Aidan Holm | 2018-07-14 13:27:56 +0800 Only reallocate widgets with new regions -------------------------------------------------------------------------------- 67b9c87 | Aidan Holm | 2018-07-14 13:27:56 +0800 Hack out small-screen-size panic For testing purposes. -------------------------------------------------------------------------------- 7558cda | Aidan Holm | 2018-07-14 13:27:56 +0800 Add UI layout invalidation -------------------------------------------------------------------------------- 2505a39 | Aidan Holm | 2018-07-14 13:27:56 +0800 Don't expand grid tracks beyond their natural size -------------------------------------------------------------------------------- 5abded6 | Aidan Holm | 2018-07-14 13:27:56 +0800 Add scroller widget This has a single child widget and can be scrolled vertically. -------------------------------------------------------------------------------- ef29da6 | Aidan Holm | 2018-07-14 13:27:56 +0800 Add UI widget event observer API This commit adds a way to register callbacks for UI-related events. This mechanism is intended to facilitate coordination between widgets (as opposed to sub-classing, which customizes behavior within a given widget). Listeners are type-safe, and can be anything convertible to a std::function. Most widgets won't have any listeners attached, so callbacks are stored in structs associated with the widget type, rather than within the target widget itself. -------------------------------------------------------------------------------- aeecdb1 | Aidan Holm | 2018-07-14 13:27:56 +0800 Only render visible grid rows -------------------------------------------------------------------------------- 141eec3 | Aidan Holm | 2018-07-14 13:27:56 +0800 Add text widget Fairly straightforward. Text is set with a formatted_string, and can be ellipsized or wrapped independently. -------------------------------------------------------------------------------- f562428 | Aidan Holm | 2018-07-14 13:27:55 +0800 Add UI scissor stack A stack of scissor regions is needed because scissoring may occur at multiple levels of the hierarchy. Without a stack, a pair of set_scissor() and reset_scissor() will change the scissor region. -------------------------------------------------------------------------------- bc3b7a3 | Aidan Holm | 2018-07-14 13:27:55 +0800 Add rowspan, colspan, and flex_grow to grid -------------------------------------------------------------------------------- 4a7592a | Aidan Holm | 2018-07-14 13:27:55 +0800 Add crt/sdl-specific widget margin helpers -------------------------------------------------------------------------------- dcabc23 | Aidan Holm | 2018-07-14 13:27:55 +0800 Add widget preferred size caching This commit caches the result of a widget's calculations for its preferred width, as well as its preferred height for a given width. The cache for a given widget must be invalidated if it or any of its descendants change any properties that affect their layout. -------------------------------------------------------------------------------- 7936736 | Aidan Holm | 2018-07-14 13:27:55 +0800 Add hierarchical UI system = Introduction = This commit implements the beginnings of a UI widget system. The basic idea is that the UI code should be abstracted somewhat from the rest of crawl. This new code provides a small framework for two main components of the UI: layout and rendering. This has a number of advantages: - Resize support for free. - UI code is aware of the entire UI that needs to be drawn: this meansd no weird edge cases because the event handling loop in one function isn't (and can't) repaint something its caller needs repainted... etc. - No (fewer?) hacks: no peppering redraw() calls all over the place with wild abandon, no CK_REDRAW. In addition, the same UI layout code is used for both SDL tiles and console builds: the only difference is that tiles uses pixel coords, and console uses terminal char coords. Rendering and layout for both platforms is fully abstracted. = Layout / Rendering = get_preferred_size() retrieves a widget's minimum and "natural" size on a given dimension (a "size request"). If retrieving the vertical size request, a prospective width must be given, and the returned minimum and natural size will be calculated according to that width: this allows a text widget to adjust its required height depending on its width, by rewrapping text to fit the width. Container widgets (those that contain other widgets) will generally call this method on their children in order to calculate their own size requirements. When the UI hierarchy needs to be laid out, the horizontal minimum and natural sizes are computed by calling get_preferred_size() on the toplevel widget: this is a recursive process. The viewport (screen/terminal) width is clamped to the minimum and natural widths, and the result is used to compute the vertical size request, again using get_preferred_size(). Likewise, the viewport height is clamped to the result. The resulting viewport width and height are passed to allocate_region(). Each container widget is responsible for laying out its children within its allocated region, and then calling allocate_region() on each of them in turn. Leaf widgets (text/image/etc.) usually pack buffers at this point. Rendering is relatively straight-forward: widgets render their contents to their allocated regions, and then call render() on their children. = API = The main API is designed to be used with existing crawl code. ui_pump_events() is a replacement for the ad-hoc while-getch loops seen throughout the crawl codebase; as it has full knowledge of the UI layout, it can render the full UI, including UI from code completely unrelated to the call site. This function is meant to be used in conjunction with event handlers (implemented in a later commit). -------------------------------------------------------------------------------- 49ce1fb | Aidan Holm | 2018-07-14 13:27:55 +0800 Add tile_def_info() helper This helper works like tile_gui_info(), tile_player_info() et al, except that it takes a tile_def structure, calling whichever texture-specific function is appropriate to retrieve the tile texture info. It's a little strange that this is a method of the ImageManager; ideally the ImageManager would query this function rather than maintain a map of texture to texture-info-getters (which is how this function is currently implemented). -------------------------------------------------------------------------------- 3f26980 | Aidan Holm | 2018-07-14 13:27:55 +0800 Add CK_RESIZE to console input handling This commit adds an interface to specify that getch_ck() should return CK_RESIZE when the terminal is resized. This is necessary for the new UI system to redraw the UI immediately on resize, without repeatedly polling ncurses. Unix requires using ncurses' builtin SIGWINCH handler to interrupt get_wch(), but variants without support for KEY_RESIZE will continue to use the old signal handler, and therefore won't return CK_RESIZE. Whether CK_RESIZE is returned is controlled by set_getch_returns_resizes() This interface isn't ideal, but it's simpler than modifying all existing call sites to handle CK_RESIZE. -------------------------------------------------------------------------------- 1015d74 | Aidan Holm | 2018-07-14 13:27:55 +0800 Revert "Add static files for CBRO ui-overhaul experimental" This reverts commit 101988f953aa354d7553a1fbf43b5dbbc4932be4. -------------------------------------------------------------------------------- a0c6fd2 | gammafunk | 2018-07-13 15:06:51 -0500 A mace-themed ghost transporter vault for Dungeon and Orc Various ogre and giant monsters wait inside a transporter area to remind you to respect things that can hit with a giant stick, lest you end up like the ghost in this vault. Places ogres initially, progressing to two-headed ogres, with a chance to place an ettin, frost giant, or fire giant in the latest depths. One monster of the most dangerous type will have a fancy good_item or randart mace that is either a dire flail or great mace. If this monster is a fire or frost giant, its mace will be flaming or freezing, respectively. -------------------------------------------------------------------------------- d6a3efe | gammafunk | 2018-07-12 02:32:07 -0500 Add a missed changelog item (Ge0ff) -------------------------------------------------------------------------------- 6d95e9e | advil | 2018-07-11 14:27:37 -0400 Enforce minimum buffer sizes for domain sockets On linux these have reasonable defaults, but on OS X (and probably other unixes) the receive buffer default for unix datagram sockets is unreasonably small for crawl's purposes, 4096. This mins the receive buffer at linux's default (which is enough that a crawl map can transfer without errors). For sanity's sake I added a min for the send buffer, but I think this value is much more standard. -------------------------------------------------------------------------------- d5849c7 | advil | 2018-07-11 13:38:02 -0400 Make socket write retries more aggressive Under some circumstances, these writes may block while the webtiles server processes data -- something that happens very quickly, but not as quickly as the send loop in this code. For example, if the socket buffer size is <=4096 (the default on OS X, but not linux), trying to send larger batches of data (such as a map on load or level change) will cause ENOBUFS until the server has had a chance to receive the previous fragment. The previous sleep timing was effectively causing a 500ms sleep per 2048 byte fragment[1], and so since a map can take on the order of 200kb, this was imposing substantial slowdowns on OS X webtiles. This fix first tries some 2ms sleeps, and then backs off to 500ms. 2ms is still more than enough for the webtiles server to do its thing in my testing; we'll see if it causes in problems on live servers (I have no idea how often this case is triggered outside of OS X). I may still accompany this with a change to the default socket size. 1 I'm not sure why it's not every two fragments, but there might have been a few initial bytes in the buffer in real-world scenarios, or some overhead not directly accounted for. -------------------------------------------------------------------------------- b59be55 | advil | 2018-07-11 13:33:42 -0400 Add debug messages for webtiles socket writes These seem like they could probably be useful in the future, too. -------------------------------------------------------------------------------- 34fbaa0 | gammafunk | 2018-07-10 23:40:44 -0500 Add Patashu to the mailmap -------------------------------------------------------------------------------- 4a2a387 | Timothy Stiles | 2018-07-10 23:33:43 -0500 Gnoll tiles (Giik) Made by Giik ( http://the-giik.tumblr.com/ ) Committer's Note: Closes #811. -------------------------------------------------------------------------------- d2f0174 | Alan Malloy | 2018-07-10 16:37:55 -0700 Clarify description of =rCorr and ARTP_RCORR (/u/cstieg1) Hopefully saying 'all sources' of acid and corrosion will reduce player confusion about whether this applies to *Corr. -------------------------------------------------------------------------------- 46e8f3c | gammafunk | 2018-07-10 15:37:36 -0500 A stat drain themed ghost vault for Dungeon and Orc (mikee) Players who don't watch out for those pesky sources of stat drain might end up haunting the transporter vault gammafunk_ghost_stat_death. Dex-draining Quasits are the only threat accompanying the ghost early on, with the quasits being supplemented by int-draining neqoxecs by D:9. There's the usual pile of progressive loot, and the ghost generates over a ring of dexterity or intelligence that has progressively higher chances for being good_item or randart. Based on an initial suggestion from mikee for a ghost vault with a bunch of quasits and a ring of DEX. -------------------------------------------------------------------------------- 65f81ef | gammafunk | 2018-07-10 15:37:20 -0500 Updates to gammafunk_ghost_icy Tweak the numbers of monsters and loot items to have a more consistent progression and fix floor tiles surrounding the vault. -------------------------------------------------------------------------------- fedc9ff | advil | 2018-07-09 10:43:58 -0400 Handle sealed runed doors properly (11508) Monsters could open runed doors while they were sealed, leading to escaping player ghosts. This checks the original terrain for the seal. I lightly refactored some closed door checks in monster AI to be clearer and a bit more general. -------------------------------------------------------------------------------- 8a62e23 | gammafunk | 2018-07-08 16:39:02 -0500 Remove code for using decks when worshiping gods other than Nemelex Back when decks could appear as random items and were retained upon abandonment of Nemelex, cards could potentially be used by players worshiping other gods. Hence there is code in place to prevent generating cloud types that specific gods disapprove of and to track use of Degeneration under Zin. This commit removes this code, since decks no longer generate randomly and are destroyed upon abandonment of Nemelex. It could have a TAG_MAJOR, but the gameplay ramifications of this change are very small. -------------------------------------------------------------------------------- d782b18 | gammafunk | 2018-07-08 16:39:02 -0500 Don't warn Dithmenos worshipers about burning trees (kitchen_ace, 11509) Dith no longer has an anti-fire conduct. -------------------------------------------------------------------------------- acb6733 | advil | 2018-07-08 09:49:36 -0400 Don't dissipate clouds when testing door sealing for tension (11506) As |amethyst suggested, this is happening because clouds will be instantly deleted on terrain changes that leave them out of los (as of 7e89378e288a). The door sealing code tests various door closing options to see which maximizes tension, and these would delete the clouds even if none of them for used, because their los effect is still calculated. This solution simply backs up a copy of env.cloud, since in principle the cloud changes might impact tension. -------------------------------------------------------------------------------- 9281fa2 | gammafunk | 2018-07-06 23:48:07 -0500 Update the changelog through 0.22-a0-604-gc538b7411b -------------------------------------------------------------------------------- c538b74 | gammafunk | 2018-07-06 23:22:08 -0500 Update the changelog for some previous releases The changelog was missing some changelog entries for previous point releases going back to 0.17.1. Add these so that the changelog isn't confusingly missing release information. -------------------------------------------------------------------------------- fc1114d | gammafunk | 2018-07-06 16:58:02 -0500 Make Dithmenos an evil god (mikee) Now that Shadow Step has an HP cost, this reinforces the notion that Dithmenos is an evil god. It wants the entire world to be shrouded in eternal darkness; doesn't that sound just mean and awful? The gameplay consequences of this are few, mostly related to conversion wrath from the good gods, the god-themed artefacts not getting the holy wrath brand, and the inability to summon or phantom mirror holy monsters. It will give Dith a bit more flavor to replace that which was lost when the fire conduct was removed. The new god description text, which is surprisingly non-transifex-like, comes courtesy of mikee. -------------------------------------------------------------------------------- 6d45252 | gammafunk | 2018-07-06 16:57:05 -0500 Rework Dithmenos' Shadow Step restrictions and costs (mikee) Shadow Step currently requires that any target monster be "still" in order for it to be a valid target, which means the monster has to be asleep, paralyzed, or otherwise immobile. This generally requires using the ability near unexplored areas, which is risky even if the player can one-shot the target monster with a stab. Players without good stabbing ability found little use for Shadow Step despite the ability being the only relatively low cost invocable offered. This commit removes the stillness restriction for Shadow Step, instead giving the ability an HP cost of about 8% of max HP. This will give incentive for non-stabbers to use the ability while still being useful for setting up stabs for high-priority targets. Shadow Step still requires the target to be within the Umbra, but no longer requires any notion of monster stillness. Balance-wise, allowing the player to make long chains of shadow step is a concern, but a significant HP cost paired with the current fairly high piety cost prevent this from getting out of hand. As the player loses piety, their access to Shadow Form can be lost and the size of the Umbra decreases, reducing the range of the next shadow step. We can adjust the HP and piety costs accordingly if the current costs aren't sufficient. The ability description has been updated to remove references to stillness and to clarify that the adjacent landing site is randomly chosen. -------------------------------------------------------------------------------- b0ed703 | gammafunk | 2018-07-05 16:10:20 -0500 Give non-menu abilities default flags, document, and reformat Give Wu Jian's Lunge and Whirlwind abilities default flags so people don't think that these actually show up in the menu. It might be nice if the ability enums/entries didn't have to exist just because of action counting, but that would take some reworking of the action counting system. Closes #775. -------------------------------------------------------------------------------- a441c7e | Edgar A. Bering IV | 2018-07-05 16:10:20 -0500 Allow Call Merchant while Starving When porridge was removed from Potion Petition a careless and hungry Gozagite could end up Starving without rations by not paying attention. The only escape was then to abandon Gozag, kill something to eat, and then either re-join or live out the wrath, and hope that you have enough gold to do this successfully. Previous nutrition-granting abilities have been allowed while Starving (Vitalization and Potion Petition) since the "abandon->eat->rejoin/mollify" flow is a cruel screw, so Call Merchant should be allowed (with its guaranteed food shop). -------------------------------------------------------------------------------- ccc8333 | Edgar A. Bering IV | 2018-07-05 16:10:20 -0500 Datify ability hunger checks Add a new flag abflag::starve_ok and add it to abilities that can be used while starving, instead of using a switch/case. -------------------------------------------------------------------------------- 06ccb6e | advil | 2018-07-05 10:28:27 -0400 Fix webtiles chat player urls (Cody Cutler) Broken in caf04dffec4948451bd, because I didn't understand how these were supposed to work. -------------------------------------------------------------------------------- bd89b2e | gammafunk | 2018-07-05 02:22:10 -0500 Adjust the placement of Ilsuiw (alexjurkiewicz) Currently Ilsuiw has a 100% chance of placing on Shoals:4 if she didn't place on Shoals:3. Fighting her will be a more memorable (some would say 'unique') experience if doesn't happen every time on a specific level. This commit introduces a 1/5 chance that her Shoals:4 guardian vault places. It also sets the range of her normal unique vault to Shoals:2-3, both so that she can place on Shoals:2 and so that this vault does not give an additional chance of placing her on Shoals:4. Finally, we give her normal unique vault the typical weight of 50 we use for branch-specific uniques. Now her chances of placement on Shoals:2-3 are more similar to that of placing on Shoals:4. After this commit, mapstat shows her chance of placing overall in shoals is between 40 and 50% (more objstat iterations needed to be sure), with a slightly higher 20-25% chance of placing on Shoals:4 compared to about 10-15% chance for both Shoals:2 and Shoals:3. This is similar to placement of other branch-specific uniques like Polyphemus, Arachne, and Vashnia. Closes #774. -------------------------------------------------------------------------------- fbd32a6 | gammafunk | 2018-07-04 20:49:11 -0500 Simplify out a function This is no longer needed, as longer half-opaque solid features no longer exist. -------------------------------------------------------------------------------- 47e2213 | gammafunk | 2018-07-04 20:45:41 -0500 Clean up a condition and document a possible simplification As the comment mentions, trees should probably be treated as walls by `feat_is_wall()`. -------------------------------------------------------------------------------- be81960 | gammafunk | 2018-07-04 20:36:09 -0500 Merge pull request #796 from ebering/lrd-tree-bug-pr Have trees properly block explosions -------------------------------------------------------------------------------- bea20c6 | gammafunk | 2018-07-04 20:12:54 -0500 Merge pull request #807 from NormalPerson7/fix-cloak-generation-rate Make items for the cloak slot be equally common as other auxiliary armour slots again -------------------------------------------------------------------------------- c01a7f0 | gammafunk | 2018-07-04 18:50:36 -0500 Revise the chance for pulling players deeper into the Abyss The new formula removes the XL15 cutoff for the chance to pull the player deeper into the Abyss upon shift/teleport. The chance formula is now: (XL + 4 - Depth)^2 / (27^2 * (Depth + 5)) Some of the new chances: * Characters at XL 1 have about a 0.1% chance of getting pulled from A:1. * Characters at XL 13 have chances of 5.9%/4.4%/3.3%/2.6% for getting pulled from A:1/A:2/A:3/A:4. * Characters at XL 27 have chances of 20.6%/16.5%/13.4%/11.1% over the same levels. It's relatively easy to escape from the abyss at XL13, and a small chance of getting pulled a level deeper where exits are more common won't have much impact on players at these XLs. This commit also updates comments and spacing and properly declares a function as static. Closes #757. -------------------------------------------------------------------------------- ae4dde8 | Edgar A. Bering IV | 2018-07-04 18:37:40 -0500 Draw higher XL players deeper into the abyss Currently, outside of the abyss, as dungeon threat level goes up, the average banishment depth goes up also. However, if a high XL player enters the abyss voluntarily, they can hang out on A:1 forever. This patch gives a chance that an abyss teleport drives the player deeper into the abyss. The chance scales up with XL and down with depth, and doesn't kick in until XL > depth +13. This has two effects: it increases the lethaltiy of the abyss for higher XL players, and speeds their progress through it. Committer's Note: The chance formula is modified in the next commit to scale the chance without using an XL cutoff. -------------------------------------------------------------------------------- 7d32d7c | gammafunk | 2018-07-02 23:56:40 -0500 Update the description of the mace of variability Don't refer to the chain of chaos spell, which isn't directly castable. Instead refer to the effects right in the description. Also change the flavor text to be more inline with the current weapon behavior. Closes #802. -------------------------------------------------------------------------------- e3ae32f | gammafunk | 2018-07-02 23:49:05 -0500 Remove unused monster casting for chain of chaos This spell used to be castable on a demonspawn monster, but that monster no longer exists. Chain of chaos isn't very good as a monster spell since it applies multiple chaos effects to the player per turn and at range. Chaos breath is ranged but only applies on effect per turn due to its use of clouds, so this is at least a better style of spell or breath to give monsters. This commit removes code used to let monsters cast chain of chaos directly. Monsters can still use the chain of chaos effect from wielding the mace of variability, since that triggers from a melee effect and doesn't need the usual monster spell setup functions. -------------------------------------------------------------------------------- f487629 | gammafunk | 2018-07-02 23:49:05 -0500 Adjust the effects of chaos beams The chaos beam type is only used for the chain of chaos spell cast by the mace of variability and for the impact (non-cloud) effect of apocalypse crab breath. Currently chaos beams select from a set of beams analogous to effects used by the chaos brand, but using mostly flat selection weights. The flat weights effectively give chaos beams much higher weighting relative to the chaos brand for strong effects like banishment, polymorph, hexing or buffing the monster, or miscast effects. This difference isn't very apparent for chaos breath, since the beam is only applied once for impact damage, but for the mace of variability, a chaos arc can hit a monster multiple times in a turn. This commit re-weights the chaos beam effect table to be closer in behaviour to the chaos brand. Beams directly analogous to other brands like flaming, freezing, electrocution, etc now have comparatively higher weight, and rarer effects that only happen when the chaos brand reselects itself have lower weight. Note that this commit has no effect on the behaviour of the chaos brand, monster af_chaos, or chaos clouds; it's only relevant for the mace of variability and impact (non-cloud) effects from chaos breath. It would be ideal to somehow merge the selection of these beam effects with the effect selection used for SPWPN_CHAOS, especially since the latter is already used for all chaos melee and launcher egos as well as chaos clouds. -------------------------------------------------------------------------------- 0c8d57c | gammafunk | 2018-07-02 23:37:48 -0500 Adjust effect damage and enchantment of the mace of variability The mace of variability casts chain of chaos with spell-power ranging from 75 to 149 with an average of 112. Ignoring any damage from the chaos beam effect, the current arc damage formula of 3d(5 + pow / 2) gives the mace's spell damage die of 3d61 per arc on average. This is very high, especially since the monster gets zapped 4 times on average (albeit with spell-power that decreases by 14 on average with each arc). To balance the damage from the mace, reduce the damage formula of chain of chaos to 3d(5 + pow / 6). Now an arc from the spell will do 3d23 damage on average, which is still significant damage even when cast only 1 in 5 melee hits. And of course, in addition to damage, each arc applies random effect from the chaos beam. This commit also lowers the enchantment of the mace to +7 from a previous commit's value of +10. A +7 great mace will be quite strong enough with 1 in 5 attacks casting chain of chaos in addition to the normal chaos ego. Also 7 is a lucky number, which Xom appreciates, and a value lower than the typical +9 max is a **secret reference** to the original unrand behaviour. -------------------------------------------------------------------------------- 9148847 | Edgar A. Bering IV | 2018-07-02 23:36:58 -0500 Add the mace of Variability to ebering_ghost_xom The item is terrifying now that it has chain of chaos, so it can't appear early. But also thematic and good temptation. -------------------------------------------------------------------------------- 8c3e449 | Edgar A. Bering IV | 2018-07-02 23:35:09 -0500 Revise the mace of Variability Having a weapon that was occasionally useless didn't make for a good item. In the tradition of other unrands that are "this brand but more" (Arc Blade, Firestarter, Frostbite, Leech), this changes the mace to have a chance of casting chain of chaos on hit and have a fixed plus. As flavourful as the plus swing is the player is encouraged to wait for the random walk to go up before fighting. Committer's Note: The chain of chaos damage and set of effects as well as the enchantment for this weapon are modified in a subsequent commit. -------------------------------------------------------------------------------- 8c174e5 | Edgar A. Bering IV | 2018-07-01 22:48:40 -0500 Remove self-harm from chain of chaos (gammafunk) The effects (even with a special case preventing banishment and polymorph) didn't make for a good monster spell because of self-harm. This adds a special case to prevent chain of chaos from harming the caster, replacing the beam's flavour with BEAM_VISUAL to keep the arcs going and waste an arc so that the spell has about the same offensive power as before. Banishment and polymorph are now added to the effect list. -------------------------------------------------------------------------------- d5db89c | Chris Campbell | 2018-07-01 17:47:36 +0100 Add Alexandra Shields to credits -------------------------------------------------------------------------------- b62a27e | gammafunk | 2018-07-01 01:33:49 -0500 Port some ghost vaults to the Vaults branch Adapt ebering_ghost_xom, biasface_ghost_orc_armoury, and ploomutoo_gammafunk_potion_laboratory as ghost rooms for Vaults. Ebering's vault is copied basically unchanged, just with some extra space to not make the room too tiny. For Biasface's vault, I've removed the wargs, orc priests, and some of the plain orcs, replacing them with orc high priests, some more orc knights, stone giants, and orc warlords. The armour/weapon/jewellery loot has one piece of good potion or scroll, and the additional warlords that sometimes place have a chance to get fancy gear. Ploomutoo's vault is ported mostly unchanged, using the same monster and loot set that the original vault uses in Depths, but with slightly fewer top-tier monsters and one less loot piece in each chamber. -------------------------------------------------------------------------------- afc7989 | gammafunk | 2018-07-01 01:24:11 -0500 Some ghost vault DES and code cleanups and refactoring Use the general loot functions for lone ghost vaults in the Vaults ghost rooms, adding it to ghost.lua so it's available to those vaults. Trim extra outer spacing or wall in some of these same ghost rooms and remove any special floor tile settings. These tiles look out of place in Vaults rather than conveying a ruined look. Don't try to use sandstone wall tiles in the Gozag ghost vaults since it conveys more of a weathered natural look than it does "gold". Likewise remove the yellow stone wall coloring for console. Move several ghost vaults that have thematic monsters into the "Themed" section of ghost.des, add a missing float ORIENT, and fix a comment. -------------------------------------------------------------------------------- 5148d60 | gammafunk | 2018-07-01 00:49:14 -0500 Updates to ebering_ghost_davey_jones Allow this vault to place on Shoals:$, since it will work fine on this level. Instead of either a kraken or a kraken simulacrum, place either a single kraken or a mix of two kraken simulacrum or spectres, as either of the latter have vastly less HP than a kraken. Add a bit more deep water to give the pair more room to move about. Refactor glyph usage to not use the % glyph for corpses and hence fix a loot item. -------------------------------------------------------------------------------- a172949 | gammafunk | 2018-07-01 00:49:14 -0500 Updates to ebering_ghost_gozag Scale the threats more carefully so that it doesn't feature so many 9 and 8 monsters in earliest depths and so that difficulty increases more smoothly with depth. Always place 2 normal random spawns on average, slowly increasing the monster count by adding 9 and 8 monsters. Tweak the placement of the obsidian statue to increase in chance gradually, making it 100% by Lair branches. To supplement the loot as depth increases, add a mix of either a good loot potion or an antique shop, starting with a 50% chance of one of these on D:9, making up to two of them by the later depths. Simplify the logic of the gold pile function to mostly use absdepth, increasing the value used a bit for Orc. Also add a variant of this vault as a ghost room for Vaults. -------------------------------------------------------------------------------- a6a7277 | Edgar A. Bering IV | 2018-07-01 00:49:14 -0500 Port several ghost vaults to the Vaults branch Committer's Note: Squashed commit that ports the lone ghost vaults ebering_ghost_inner_flame, ebering_ghost_reflecting_pool, and ebering_ghost_disaster_area to vault rooms for Vaults. -------------------------------------------------------------------------------- 0289154 | Edgar A. Bering IV | 2018-07-01 00:49:14 -0500 Davey Jones' / Kraken themed ghost vault for Shoals Guarantees a randart ring, chance of an octopus king ring -------------------------------------------------------------------------------- bb431e2 | Edgar A. Bering IV | 2018-07-01 00:49:14 -0500 Disaster themed lone ghost vault -------------------------------------------------------------------------------- 2af43bd | Edgar A. Bering IV | 2018-07-01 00:49:14 -0500 Gozag themed ghost vault No items, only gold and a Gozag altar. Gold loot is scattered in piles and scales as follows: From 3-9 piles at D:3 to 12-18 at D:15 and below. Further scaling comes from the natural scaling of gold pile size. The monster set has two 998 monster placements and adds some 0's deeper. There is a chance for the central statue to be an oklob in lair or an obsidian statue elsewhere. Committer's Note: Squashed two other subsequent commits by ebering and updated the final commit message based on his notes in the squashed commits. This vault's placement depth, loot, and monster composition will be modified in a subsequent commit. -------------------------------------------------------------------------------- 0116f15 | NormalPerson7 | 2018-06-30 14:22:29 +0100 Make items for the cloak slot be equally common as other aux slots again In commit 651d724, scarves were increased from being 1/6 to 1/4 of items generated for the cloak slot, however the actual increase in spawn rate for scarves was minimal, from 1/30 to 1/28 of all auxiliary slot armours generated, because what this commit actually did was reduce the spawn rate of cloaks from 5/30 to 3/28 by reducing the weight of cloaks. It seems like an accident that this meant the total weight for this random_choose_weighted was not the 30 that a comment implied, and that the cloak slot items (cloaks and scarves combined) were made 2/3 as common as other auxiliary slot armours. As a result, this commit buffs the spawn rate of cloaks and scarves to bring the overall spawn rate in line with that of other auxiliary armours, whilst maintaining the same 3:1 ratio of cloaks:scarves. -------------------------------------------------------------------------------- 4a923d4 | Aidan Holm | 2018-06-30 19:18:02 +0800 Fix Ru sacrifices not giving full piety (Xenobreeder, #11503) For skill sacrifices specifically, the amount of piety gained was recalculated after the sacrifice was performed, i.e. after the skill in question had been dropped to level zero. In testing, sacrificing 27 stealth promised full piety, but granted none. -------------------------------------------------------------------------------- 58866f5 | Chris Campbell | 2018-06-29 18:21:25 +0100 Merge pull request #806 from shieldal/fix-zot-trap-malign-gateway Fix zot traps casting friendly malign gateways (0011042) -------------------------------------------------------------------------------- e1900bc | shieldal | 2018-06-28 22:47:11 -0700 Fix zot traps casting friendly malign gateways -------------------------------------------------------------------------------- 270d1ae | gammafunk | 2018-06-28 22:54:26 -0500 A happy afterlife ghost vault for Dungeon and Lair from hellmonk In hellmonk_ghost_happy_afterlife, a ghost decides to not dwell on the failures they made in life, preferring to just relax next to a nice tree with a nice meal (a ration) and some nice drinks (1-2 potions). Of course, if you disturb its meal it will not hesitate to kill you, since ghosts like killing players more than they like meals they can no longer eat. The potions upgrade in quality and number as depth increases. -------------------------------------------------------------------------------- ff9aefc | gammafunk | 2018-06-28 17:19:05 -0500 A potion ghost vault for Dungeon, Elf, and Depths (Ploomutoo) In ploomutoo_gammafunk_potion_laboratory, an alchemist with a collection of nice potions conducted a fatal experiment resulting in an explosion of mutagenic horrors. Now their ghost haunts a two-chambered lab, guarding loot that contains a number of potions of mutation, high quality random potions, and a piece of aux armour or a robe. Monsters in the first chamber are melee-oriented: ugly things, very ugly things, large abominations, and tentacled monstrosities are all used depending on the depth and branch, supplemented with the occasional glowing orange brain. In the second chamber is the ghost along with shape-shifters and malmutators (neqoxecs and later cacodemons). This vault was originally submitted by ploomutoo with the main layout and a basic set of monsters and loot for dungeon. I modified the monster sets to make the themes of the chambers distinct and to allow placement in other branches. I also scaled the number and composition of loot and monsters as depth increases. Finally, the layout was updated to better allow placement of mutagenic fog machines. -------------------------------------------------------------------------------- b275bf3 | gammafunk | 2018-06-28 15:44:43 -0500 Some ghost vault fixes and refactoring. Make the good loot potion/scroll item lists available as variables for other vaults to use when they're handling their own loot placement. Fix a potion specification error ('cancellation', not 'cancelation') and clean up DES spacing. -------------------------------------------------------------------------------- fc6459a | gammafunk | 2018-06-27 02:14:37 -0500 Updates to gammafunk_ghost_spectres Use monster/loot depth breakpoints consistent with the other vaults and update the wraith composition for later depths. This was placing a high proportion of ordinary wraiths at D:12-, where the player is likely to have have completed both Lair and Orc. Reduce numbers of these and add more freezing wraiths in their place, also slightly increasing the highest tier wraiths in the very latest placement depths. -------------------------------------------------------------------------------- 3e71e8a | gammafunk | 2018-06-27 02:14:37 -0500 Updates to gammafunk_ghost_split For later depths, update the monsters this vault places to use a bit less 0 monsters and a little more of 9 and 8 out-of-depth ones. Early on it's ok if this vault feels less like a 098 vault and more like a vault with in-depth monsters only, but by Lair branches it should really have a significant number of more threatening monsters in addition to the ghost. Also update the wall glyph usage so that the outer or inner walls would use wall types that would seem out of place in certain branches. -------------------------------------------------------------------------------- 1b94d8d | gammafunk | 2018-06-27 02:14:37 -0500 A labyrinth themed ghost vault for Dungeon, Lair, and Orc from Maelrawn In maelrawn_ghost_labyrinth_escape, a player tried to escape from a lab with loot in tow. Sadly, the minotaur was right behind them, and then they ran right back into all the monsters they ditched to reach the lab entrance. This vault places on any level that could normally place a labyrinth (D:10-, Lair, Orc:2), but of course only places through the usual ghost vault chance and additionally has half the usual vault weight. It should be a pretty nasty one, since the minotaur is quite the threat on its own. The vault supplements the minotaur with a few branch monsters that eventually include out-of-depth 9 monsters at later placement depths. It doesn't recreate the more generous loot of an actual Labyrinth portal, but it does place up to 5 items and supplements this with the good loot replacement used by other ghost vaults. -------------------------------------------------------------------------------- d813392 | gammafunk | 2018-06-27 02:14:37 -0500 Add good consumables or equipment to the loot in many ghost vaults Currently, ghost vaults that place monsters in addition to the ghost also place items that upgrade in quality, with the count increasing from 3 to as high as 7 as depth increases. These items are of higher quality than usual floor items, with each item eventually reaching 50% each of superb_item and star_item, but those item classes are highly variable. In later Dungeon levels and beyond, it's common to see no item that's reasonably worth the risk of fighting a ghost along with additional monsters. To provide additional incentive for players to attempt these vaults, this commit adds a `good_ghost_loot()` function that can replace one or two pieces of the "superb_item / star_item" loot with items that have a narrower range of useful possibilities. The first replacement consists of scrolls and potions with weights only for those that are broadly useful, along with aux armour, jewellery, and a small chance for a manual. The aux armour and jewellery have lower weight relative to the scrolls and potions, but upgrade to have good_item and later randart modifiers as depth increases. The first item replacement only has a chance to happen starting from D:9-11, with the chance increasing to 100% by Lair. The second item is a potion or scroll using the same weights as the first item. It has a chance to appear starting in Lair, becoming 100% by the Lair branches. Most ghost vaults that place additional monsters have been updated to call this function and have any necessary change to their loot placement statements. The function defines the items on the 'd' and 'e' glyphs and leaves the calling vault to perform any necessary substitutions if they wish to override this definition or handle multiple instances of those glyphs. A couple vaults that already place specialized loot remain unchanged. -------------------------------------------------------------------------------- 06062c5 | gammafunk | 2018-06-27 02:14:14 -0500 Remove upweighting for gammafunk_ghost_grave This vault was originally the only simple vault that placed a single ghost. We now have a number of others like this that have normal weight, so there's no need to upweight this one in particular. -------------------------------------------------------------------------------- 921cf92 | gammafunk | 2018-06-27 00:16:25 -0500 Consistently use depth breakpoints for ghost vault loot Use the same depth partitions for the Dungeon branch across these vaults. -------------------------------------------------------------------------------- 6e350e3 | gammafunk | 2018-06-27 00:15:07 -0500 Some small ghost vault fixes Add a missing float ORIENT to a ghost vault, remove an erroneous loot substitution and a floor tile statement, don't use wall types inside a vault that would seem out of place in some branches, and clean up a comment and a variable name. -------------------------------------------------------------------------------- c224181 | Chris Campbell | 2018-06-25 22:39:14 +0100 Don't make ancient zymes sicken friendlies (#10769) Neutral zymes (from Corruption for example) will still sicken the player, but friendly ones won't sicken the player and hostile ones won't sicken other hostiles. -------------------------------------------------------------------------------- b306ea2 | Edgar A. Bering IV | 2018-06-25 22:09:14 +0100 Fix bug 11478: Movement-key actions and Wu Jian In _move_player, the easy-open door let control flow continue through the function to behaviors that should only trigger upon moving. The most noticable is the Wu Jian processing, leading to the bug. The function could use some further simplifications, it's a bit spaghetti. Closes #778. -------------------------------------------------------------------------------- 59e8874 | Chris Campbell | 2018-06-25 22:09:14 +0100 Fix bracing -------------------------------------------------------------------------------- 334a0db | Chris Campbell | 2018-06-25 22:09:14 +0100 Don't break Ozo's or cause barb damage on forced level transitions Such as being banished or falling down an unknown shaft. Also re-order some checks. -------------------------------------------------------------------------------- 2b3c548 | Jacob Meigs | 2018-06-25 22:09:00 +0100 Trigger barbs and break Ozo's Armour when taking stairs/walljumping [Cleaned up some code and whitespace, and updated commit message - MarvinPA] Closes #747. -------------------------------------------------------------------------------- 9358b0b | gammafunk | 2018-06-24 18:49:35 -0500 Add a missing ghost setup function to another vault (ebering) Incredibly, I also missed this one that ebering also missed! -------------------------------------------------------------------------------- 28ad1da | gammafunk | 2018-06-24 18:37:47 -0500 Add a missing ghost setup function to a vault (ebering) ebering_ghost_reflecting_pool was missing this. -------------------------------------------------------------------------------- 3b2bdd4 | gammafunk | 2018-06-24 16:51:00 -0500 Ghost vault DES cleanups In gammafunk_ghost_necromancy, specify the Depth in a better way by using 0 weight for Elf. Fix variable initialization for the hydra head code and reformat DES alignment in various vaults. -------------------------------------------------------------------------------- b51906a | gammafunk | 2018-06-24 16:51:00 -0500 Updates to two ghost sewer vaults For ebering_ghost_sewer_d, a single adder guard doesn't scale very wall through D:6. The original sewer entry was just trying to slow the player down a bit to make the portal timer relevant, but monsters in ghost vaults are trying to pose a legitimate threat. Supplement the vault with additional adders in earlier depths and a chance for a bullfrog, adding a guaranteed bullfrog by D:6. Adjust the loot to upwards a little, since this vault places multiple monsters in addition to the ghost. For ebering_ghost_sewer_f, make some similar adjustments. Introduce more monster variety and add some higher tiers of sewer guardians. Lower the average number of monsters placed, since they're a bit nastier, but randomize those numbers. Finally, in both of these vaults, reorganize and reformat some DES statements. -------------------------------------------------------------------------------- 7bfabb5 | gammafunk | 2018-06-24 16:50:59 -0500 Updates for ebering_ghost_xom Instead of placing a dancing dagger with a random ego, place a dancing weapon with a base type that scales with depth and always has the chaos ego. Initially use lower base-damage weapons more commonly found early on, slowly increasing the weapon quality. On each level, define up to three sets of potential dancing weapons: a common class with default weight, a somewhat higher damage/quality set of weapons with lower weight, and at later depths introduce a set of rare weapons with lowest weight. This should make fighting the weapon still potentially scary in later depths as well as a loot item that's more rewarding. Finally, add a "guarded" loot item under the ghost itself, since this ghost vault only ever places one additional monster. -------------------------------------------------------------------------------- 30f0393 | gammafunk | 2018-06-24 16:50:13 -0500 Move a function to the ghost vault lua file and refactor The random_item_def() function will likely be of use to vaults e.g. in Vaults, so move this to ghost.lua and add documentation. Generalize the "artefact" argument to just be an argument string, allowing callers to set whatever additional item properties they want instead of just good_item or randart. -------------------------------------------------------------------------------- 577b210 | Edgar A. Bering IV | 2018-06-23 23:33:14 -0500 Two sewer themed ghost vaults Based on sewer entry vaults d and f, only place in D:3-6 where sewer entries can spawn. -------------------------------------------------------------------------------- 9374e73 | Edgar A. Bering IV | 2018-06-23 23:33:14 -0500 Xom themed ghost vault Has the player ghost, a Xom altar, and a dancing nice dagger which was animated by Xom. A dancing dagger is only a bit tougher than a killer bee, so shouldn't be too excessive, and it is good loot if defeated! -------------------------------------------------------------------------------- 6fc7002 | Edgar A. Bering IV | 2018-06-23 23:31:17 -0500 Reflecting pool ghost vault Lone ghost with different decoration from the gravestone. -------------------------------------------------------------------------------- 617fbbe | Edgar A. Bering IV | 2018-06-23 23:31:13 -0500 Haunted rock garden ghost vault This vault follows roughly the loot scaling of gammafunk_ghost_gravestone with the large rock stack counting for one of the "good items". This will make it appeal more to large rock throwers and less to others, but that's fine. -------------------------------------------------------------------------------- d3eb0d8 | Edgar A. Bering IV | 2018-06-23 23:12:42 -0500 Abstract loot scaling for single ghosts Creates two lua functions for placing the "guarded" and "extra" loot in a ghost vault that places a single ghost, for consistent scaling and to make writing single-ghost vaults easier. -------------------------------------------------------------------------------- ce4f928 | Chris Campbell | 2018-06-24 04:30:50 +0100 Fix a coding convention typo -------------------------------------------------------------------------------- 2d8cebb | Alan Malloy | 2018-06-23 15:05:06 -0700 Add Alcon to mailmap -------------------------------------------------------------------------------- 876ca31 | Alan Malloy | 2018-06-23 15:02:54 -0700 Add Alcon to CREDITS -------------------------------------------------------------------------------- fbd9004 | jnooner | 2018-06-23 14:57:00 -0700 Fix a crash when blinking away a cleaving attacker (amalloy, #718) When working through the list of enemies to cleave, we now check that each enemy is still adjacent. -------------------------------------------------------------------------------- a1b6296 | Edgar A. Bering IV | 2018-06-22 21:57:16 -0400 Have trees to block explosions (Reeces) Trees are not walls, but often should be treated like them. In this particular case they should block the explosion like all other no_transparent opacity features. In particular this prevents LRD from sneaking into places it shouldn't in certain edge-cases. -------------------------------------------------------------------------------- c63589d | Edgar A. Bering IV | 2018-06-22 21:04:52 -0400 Don't treat trees as half-opaque for exclusions Remove a vestige of the old behavior -------------------------------------------------------------------------------- 76cc104 | gammafunk | 2018-06-22 19:30:22 -0500 And icy themed ghost vault for Dungeon, Lair, and Depths (Biasface) An icy cave filled with monsters with cold melee and ranged attacks. The ghost spawns over a pre-type-identified ring of fire; sadly the fallen player did not remember to remove their source of rF- in time. The ring of fire eventually has a chance to be an artifact, with that chance reaching 100% in the latest depths. The other loot is typical for other ghost vaults, a progressive mix of superb_item and star_item. The composition and number of icy monsters increases in difficulty with depth. Based on a vault idea submitted by Biasface. -------------------------------------------------------------------------------- e9e9f76 | Chris Campbell | 2018-06-22 22:49:38 +0100 Remove veto_fragmentation, replace veto_disintegrate with veto_dig Since LRD and disintegration no longer destroy walls. -------------------------------------------------------------------------------- 9b9f9d0 | Chris Campbell | 2018-06-22 22:49:38 +0100 Remove an unused param Monsters no longer spawn from stairs, so stair_type was unused. -------------------------------------------------------------------------------- bbb2ed9 | gammafunk | 2018-06-22 16:28:56 -0500 Merge pull request #795 from ebering/tweak-inner-flame-vault-pr Remove flame clouds from inner flame vault (jboons) -------------------------------------------------------------------------------- bbc7872 | Edgar A. Bering IV | 2018-06-22 17:09:53 -0400 Remove flame clouds from inner flame vault (jboons) Ghosts and monsters were dying to them. Replaced with black smoke, which gives similar flavor but without the monster deaths. -------------------------------------------------------------------------------- 4d20840 | gammafunk | 2018-06-21 16:49:15 -0500 An orcish armoury ghost vault for Dungeon and Orc (Biasface) In biasface_ghost_orc_armoury, a player tried to raid an orcish armoury and was overwhelmed by the defenses. Hopefully you can succeed where they failed...just keep in mind that the player's ghost has joined forces with the orcs in guarding the base. The vault places melee orcs in substantial numbers, introducing a smattering of orc priests after D:3. The ordinary orcs are reinforced with warriors, knights, and a possible warlord in the latest depths. For the top tier orc class used, one such monster will always have a fancy weapon and armour (each either good_item or randart), and the additional loot items are aux armour, general armour, weapon, and jewellery that get progressively introduced and upgraded with good_item. Biasface made the original vault submission. I made some slight layout changes and added many of the item and monster progression details as well as code support for setting equipment on the higher-level orcs. -------------------------------------------------------------------------------- cd2a3d9 | gammafunk | 2018-06-21 16:49:12 -0500 Bug fixes and code generalizations for gammafunk_ghost_hdyra_chop Generalize the random item definition code so that it can be used for a forthcoming vault. Move the general parts to a new `random_item_def()` function that allows specifying the item/ego weights as tables, with the ego optional, as well as the separator to use in the definition. The latter will allow is to use this in items in MONS statements. Simplify the weighting used in this function when both items and egos are given to simply multiply the weights together. A scaling factor is not necessary if we compute the weights this way. In the vault itself, fix the erroneous specification for long swords and rename the function to use 'setup', since it's not initializing anything. -------------------------------------------------------------------------------- bf3ec1f | Chris Campbell | 2018-06-21 20:38:09 +0100 Add nlavsky to CREDITS.txt -------------------------------------------------------------------------------- d75db79 | Chris Campbell | 2018-06-21 20:28:40 +0100 Merge pull request #777 from nlavsky/throw-ally-fix Make Iron Giants and other Throw Ally users obey Sanctuary -------------------------------------------------------------------------------- b6040eb | Chris Campbell | 2018-06-21 20:17:38 +0100 Merge pull request #776 from nlavsky/injury-bond-description Fix Injury Bond description -------------------------------------------------------------------------------- 6e5688e | Muffindrake | 2018-06-21 11:13:13 -0700 Remove duplicate code for attack punctuation (#771) Put the punctuation code into a function and remove exact duplicate used in a different part of the code base. -------------------------------------------------------------------------------- f69a080 | gammafunk | 2018-06-19 21:58:19 -0500 Updates to ebering_funeral_grove Some significant modifications to the monster set for this this vault. Spriggan druids don't work as well in Dungeon and Lair, since Awaken Forest requires it to be hard to get away from trees (i.e. be in Swamp) and Druid's Call needs most level monsters to be beasts (not the case in Dungeon). Rework the monster list, retaining the spriggans that always have polearms, but adding in some wolves/bears and eventually a boggart to replace the spiritual role of the druid. Additionally always give one spriggan an artefact spear or trident both as part of the loot and to highlight the troubles of an unfortunate player stuck in tree form versus a monster with a nasty reach attack. Initially use only ordinary spriggans but later introduce spriggan riders. In Swamp we can use the spriggan druid again and use 098 Swamp monsters instead of wolves/bears. The final average amounts of loots and monsters are similar to the numbers before these changes. Also add better windows into this vault so that any wandering ghost can always be seen, and generally simplify glyph usage and SUBST/NSUBST. Move the decoration statements towards the end of the vault definition where we customarily put these. -------------------------------------------------------------------------------- c87f014 | gammafunk | 2018-06-19 21:53:51 -0500 Updates to ebering_ghost_inner_flame Down-weight the vault in the earlier levels since it places 9 or 8, and spruce up its loot a little in line with the potential threats it can have. Also make it place at least one of either a chunk or a flame cloud to avoid it placing none of either, which would make the theme less clear. Finally, call the current ghost setup function instead of an old one used in PR #700. -------------------------------------------------------------------------------- 52696f8 | Edgar A. Bering IV | 2018-06-19 21:17:27 -0500 Two item themed ghost vaults ebering_ghost_inner_flame is a small 098 room that is blood splattered, has flame clouds, and a guaranteed scroll of immolation. ebering_ghost_funeral_grove is slightly larger, forest-themed guarded by some spriggans plus the ghost. The vault always places a druid and a potion of lignification, the druid watching over the poor dead treeformed player. Committer's Note: The vault ebering_ghost_funeral_grove is modified in a subsequent commit to place a different set of monsters. Notably the druid is only seen in the Swamp branch; see the comments in that follow-up commit for details. -------------------------------------------------------------------------------- 01493d7 | gammafunk | 2018-06-19 16:57:11 -0500 A demon polymorph themed Depths ghost vault from Biasface In this vault, the unfortunate player ghost hovers over a (pre-identified) wand of polymorph, their final act having been an attempt to polymorph a demon into something less threatening. Was it a hellion? A tormentor? Perhaps the player polymorphed a mere neqoxec to avoid getting a **game-ending mutation**? Whatever their choice, the untimely result was a tier 1 demon and, ultimately, a player ghost. The vault also contains a few tier 2 demons (although no tormentors/hellions) and a group of other common demons (tiers 3 and 4). Changes from the original vault include a little vault surgery to make the lava pool larger, more randomization to the composition of demons, and randomization of the numbers and placement of demons. Loot is adjusted to be roughly similar to what other ghost vaults give in Depths. Also make the statue tiles a random assortment of demon-themed ones. -------------------------------------------------------------------------------- b137804 | advil | 2018-06-19 15:16:16 -0400 Add a targeter for wands of digging This now shows you the exact range and path that will be affected by digging, up to map knowledge. Two behavioral changes: 1. If you know that it won't affect anything, it won't let you fire. 2. you can target at any angle (previously, you could only move the targeting cursor on squares that you could see). As with recent passwall changes, this targeter can give you information about the map bounds. -------------------------------------------------------------------------------- 9de5397 | advil | 2018-06-19 15:16:16 -0400 Add a wizmode command to completely wipe out the level map For debugging info leaks; just forgetting isn't usually enough. -------------------------------------------------------------------------------- 0da5cb0 | gammafunk | 2018-06-19 12:06:41 -0500 Adjust the vault muffindrake_ghost_dead_mans_drink Rename this vault to muffindrake_ghost_dead_mans_drink to keep vault naming consistent. Add "portholes" (transparent stone) to some sides of the vault so that the ghost can be seen from outside even if it wanders into the back of the vault. Add randomization to the kinds of derived undead used in this vault and randomize the placement and numbers of monsters, keeping the same average. Increase the loot a little to keep numbers more in line with other Depths ghost vaults. -------------------------------------------------------------------------------- 2547c9b | gammafunk | 2018-06-19 12:06:41 -0500 Adjust the vault muffindrake_ghost_three_little_ghosts Rename this vault to muffindrake_ghost_three_little_ghosts to be in line with other vault name formatting. Don't use diggable rock in the walls in the vault to prevent monsters digging out/in. Instead use stone/crystal/iron progression to make the theme consistent, and since crystal has a nice interaction with the room 2 monsters. Remove outer glass, since vault already reveals each rooms contents as the player progresses. Use a shaman band in the first room instead of just a single non-threatening deep troll. Add randomization to the types and numbers of monsters in the remaining two rooms. Increase loot to be more in line with what we place for other Depths ghost vaults. -------------------------------------------------------------------------------- 95e1b32 | gammafunk | 2018-06-19 12:06:41 -0500 Adjust the vault muffindrake_ghost_dual_entry Rename this vault to muffindrake_ghost_dual_entry to be in line with our other vault names. Add windows for the back of the vault and a dungeon connector so that the player will always be able to inspect it and find any ghost, if they so wish. Also down-weight the vault in its earlier depths of D:10-11. Among ghost vaults it should be a less commonly seen challenge, since it places two 8, a 9, and a lich, which is (almost) guaranteed to overshadow the ghost itself. Randomize the placement of the 1, 2, and 3 monsters, also randomizing their placement numbers slightly but with the same average numbers. Slightly increase loot quality by giving another superb_item instead of gold. -------------------------------------------------------------------------------- 6ea8e7e | Muffindrake | 2018-06-19 12:06:41 -0500 Add four ghost vaults for mainly Depths Committer's Note: Removed a vault from this commit that's not quite ready for merging. -------------------------------------------------------------------------------- 75794bf | advil | 2018-06-18 20:57:21 -0400 Make player ghosts non-recallable (Malacante) Ideally they could be recalled if their vault is open, but there's no way to do that that I know of. -------------------------------------------------------------------------------- 96ba041 | advil | 2018-06-18 16:43:22 -0400 Don't have ghosts teleport with health <50% on stairs This is ancient behavior that is obsolete now that ghosts take stairs normally. -------------------------------------------------------------------------------- b939540 | advil | 2018-06-18 16:37:05 -0400 Update ghost annotations if you can see the ghost transiting I missed this when removing the assumption that ghosts can't change levels. -------------------------------------------------------------------------------- 0943f25 | gammafunk | 2018-06-17 16:03:24 -0500 Use the correct integer variable type With advil's branch implementation (many thanks for that!), the extension of the Vaults layout, and the previous set of vaults, we're ready to merge the spooky_vaults branch. Closes #700. -------------------------------------------------------------------------------- 7f357de | gammafunk | 2018-06-17 15:48:43 -0500 Remove an unused error tracking variable -------------------------------------------------------------------------------- 1d9e83a | gammafunk | 2018-06-17 15:48:43 -0500 TAG MAJOR comment for Forest/Blade branch entries These vault rooms were used to place Forest/Blade entries, but won't be necessary with the next major version increase, since those branches no longer exist. -------------------------------------------------------------------------------- 84fad1d | gammafunk | 2018-06-17 15:48:42 -0500 A ghost vault themed after Okawaru's wrath (hellmonk) In gammafunk_ghost_fury_of_okawaru, the player finds a ghost on the altar of Okawaru along with a bunch of representative Oka wrath monsters and some loot. Although the generated ghost likely wasn't the result of dying to "the Fury of Okawaru", hopefully this vault evokes the common occurrence of players trying and failing to switch from Oka to another god. It places in Dungeon, Orc, Vaults, Elf, and Crypt, and uses warrior, archer, and giant monsters from Oka's wrath set. The Vaults variant place through a separate vault room. Original idea courtesy of hellmonk. Add new and exciting food costs. -------------------------------------------------------------------------------- c41e3e3 | gammafunk | 2018-06-17 15:48:42 -0500 A hydra-themed ghost vault (mikee) In gammafunk_ghost_hydra_chop, a fallen player made the mistake of using a non-flaming edged weapon vs a hydra, leaving their ghost, the weapon, and of course a hydra with more heads than usual. The weapon was not the fallen player's actual weapon, but we can allow a little creative fiction here, especially if the player was a felid!. We place only weapon types usable by all non-felid species and always use a non-flaming ego. There is a 1/3 chance for the weapon to be artefact. The vault can also place a limited amount of additional loot and extra hydras, scaling with depth, with the max possible hydra heads going as high as 16 in late Swamp. Also places in D:8- and Lair. -------------------------------------------------------------------------------- 28d1087f | gammafunk | 2018-06-17 15:48:42 -0500 A ghost vault that places multiple ghosts gammafunk_ghost_cemetery places 2-5 ghosts, with a 50% chance to place only two and decreasing chances for each additional ghost, placing about 2.8 on average. Loot is 1.5 items per ghost with loot quality increasing with depth. This vault places in all ghost vault branches, with half weight in the very early dungeon levels and normal weight elsewhere. It has a separate vault room for the Vaults branch as well. -------------------------------------------------------------------------------- 8f30707 | gammafunk | 2018-06-17 15:48:42 -0500 Some thematic ghost vaults These vaults feature a few different specific themes and hence go in the second section of ghost.des: gammafunk_ghost_necromancy: Part one of a three part spooky ghost vault sequence. Places derived undead from slightly later depth along with a player ghost. Initially places skeletons and zombies, later replaces skeletons with spectral monsters and simulacra, and finally only spectrals and simulacra. In Crypt, Depths, and Zot we possibly throw in lich and curse skulls/curse toes. Places in all branches that place ghosts, using a separate vault room for Vaults. gammafunk_ghost_spectres: Similar to the former vault, but using 'W' monsters: the various types of ghosts, wraiths, and other spectres. This one starts placement later, where wraiths would be not too out-of-depth, since I didn't want to make an early variant featuring only phantoms and hungry ghosts. Like the ghost_necromancy vault, places nasty undead spellcasters in later branches. Places in D:8-, Vaults (through a separate vault room), and Crypt. gammafunk_ghost_ooze: A vault for D:8-, Lair, and Depths that always has a Jiyva altar. From D:8 places slime creatures and jellies initially, introducing death oozes from lair onwards. gammafunk_ghost_mausoleum: A transporter vault that's nastier than the previous two, placing general undead monsters from the relevant branch with chances for some out-of-depth ones. Places in D:3-, Swamp, Crypt, Depths, and Zot. -------------------------------------------------------------------------------- 6d380fd | gammafunk | 2018-06-17 15:48:41 -0500 A set of general ghost vaults These vaults all have progressive loots and monsters, with the number of monsters and number/quality of loot both increasing with depth. gammafunk_ghost_grave: A runed door vault with a ghost near a grave and a small number of loot items, scaling up to three. gammafunk_ghost_split: A runed door vault with a ghost and 0, 9, and 8 monsters. In earliest depths there is only a chance for a single 9, and later the proportion of 8 and 9 compared to normal spawn 0 monsters increases. gammafunk_ghost_arena: A transporter vault with a ghost and 0, 9, and 8 monsters. Similar concept to the ghost_split vault above, but somewhat harder due to being in a transporter. It scales up to higher numbers of monsters an loot, so it will be fairly dangerous, yet more rewarding. The first two vaults have vault room variants adapted for the Vaults branch. -------------------------------------------------------------------------------- c69a6cf | gammafunk | 2018-06-17 15:48:41 -0500 Some ghost vaults for the Vaults branch Update the quick ghost vaults advil made as vault rooms. I've made them place a bigger variety of the Vaults-specific monsters and standardized the loot to be more in line with the other (forthcoming) ghost vaults. Their names have been update to include advil's name and to follow a standard naming convention. -------------------------------------------------------------------------------- a2df02c | gammafunk | 2018-06-17 15:48:26 -0500 Update ghost vault guidelines Mention the necessary ghost vault setup functions and update the guidelines with more specific advice about ghost visibly, wall type usage, and loot. -------------------------------------------------------------------------------- 99b25f0 | gammafunk | 2018-06-17 15:37:08 -0500 Extend the Vaults layout to place ghost vault rooms Vault rooms placing ghosts should now set a `vaults_ghost` tag to be selected as part of the chance for each level to have a ghost vault. The Vaults layout rolls based on the chance value in dat/dlua/ghost.lua and selects from rooms with the vaults_ghost tag. Vault rooms that place ghosts should call the function vaults_ghost_setup() to set this and other tags we want all ghost vaults to have. -------------------------------------------------------------------------------- 30c74a2 | gammafunk | 2018-06-17 15:37:08 -0500 Ghost vault functions and ghost DES file cleanup Add some lua vault setup functions to set tags we'll always need for ghost vaults and set the common ghost vault CHANCE value. For branches other than Vaults, a ghost vault makes a call like: ``` : ghost_setup(G_) ``` Ghost vault rooms in the Vaults branch instead call `vaults_ghost_setup(G_)`, which sets a `vaults_ghost` tag recognized by the Vaults layout. Support for this will be added in a subsequent commit. This commit also organizes ghost.des into sections for future vaults and removes the initial set of test vaults made by advil; those will reappear in a subsequent commit, where they'll be revamped. -------------------------------------------------------------------------------- 9e38d4b | gammafunk | 2018-06-16 23:26:18 -0500 Reformat vault guidelines Use proper subheaders instead of just bold text, and use code blocks for DES examples. -------------------------------------------------------------------------------- b611b69 | advil | 2018-06-16 23:26:18 -0500 Make bones file resolution coarser (first pass) On the old ghost system, there was one bones file per level. Players die at very different rates across the dungeon, but this worked fine, because that just led to lower likelihood of ghosts in some places. In the new system, since we're trying to have ghost generation rates entirely determined by vault placement, this becomes problematic; for example so far in the entire 0.21 cycle there is been exactly one death in Geh:5, so it makes absolutely no sense for this level to have its own bones file and permastore. This commit tries to solve this problem by (i) mostly not having per-level permastores (as of this change, only dungeon and lair do), (ii) in some cases not having per-level bones files (though most of these don't generate ghosts right now), and (iii) grouping all hells together for both bones files and permastores, since even per-hell-branch the death rate is extremely low (just 43 in 0.21 in Geh, for example, only 11 of which even occurred in the first two weeks of release -- barely enough to fill a permastore at current rates). This may need a bunch more tweaking, and it may be worth considering whether dungeon region is the right way to organize bones files at all (alternative: xl, with some kind of subdivision for xl27). (n.b. I wish bones data was in an sqlite db, not a bunch of files, but I think this is unfortunately not practical to consider right now.) -------------------------------------------------------------------------------- e1a807f | advil | 2018-06-16 23:26:18 -0500 Don't allow undead mirrored ghosts This just converts them to human. -------------------------------------------------------------------------------- 3ff1096 | advil | 2018-06-16 23:26:18 -0500 Clean up bones file debugging messaging This centralizes all the complicated #define conditioning in one place, so it's a lot easier to figure out what's going on, and hopefully this will minimize accidental compiler warnings. This relies on a fairly hacky unwind in one place, though. This is all a bit complicated because one wants these messages to show in wizmode on a server, which won't ever have a debug build. -------------------------------------------------------------------------------- f886858 | advil | 2018-06-16 23:26:18 -0500 Don't crash on mprf while loading ghosts Somehow this is a distant side effect of mprf. (prepare_message => silenced => _update_agrid => _actor_areas => monster::halo_radius => monster::holiness => monster::has_attack_flavour) -------------------------------------------------------------------------------- 45f54b8 | advil | 2018-06-16 23:26:18 -0500 Lower ghost chances even more In practice, the old 33% chance provides just an upper bound on placement probability, because bones files can be empty. It's hard to estimate, but I suspect from inspecting bones files from a live server, that the probability of generating a ghost is (on average) usually quite a bit lower, subject to a lot of variability due to server conditions. Since the chances of ghost vault generation now are much closer to an exact probability, they need to be lowered. For now, something like 10% seems reasonable to me; in a 3 rune game this means maybe 4 ghost vaults on average. -------------------------------------------------------------------------------- 0683b26 | advil | 2018-06-16 23:26:17 -0500 Draft some design guidelines for ghost vaults [skip ci] -------------------------------------------------------------------------------- 72bd907 | advil | 2018-06-16 23:26:17 -0500 Improve (old) variable names -------------------------------------------------------------------------------- 7b7af9e | advil | 2018-06-16 23:26:17 -0500 Various vault adjustments based on feedback Possibly these still drop too much loot. -------------------------------------------------------------------------------- 397a453 | advil | 2018-06-16 23:26:17 -0500 Use CHANCE rather than WEIGHT for non-Vaults ghost vaults This is more accurate. Also reduce the chance somewhat. -------------------------------------------------------------------------------- d5aaa04 | advil | 2018-06-16 23:26:17 -0500 Let ghosts use stairs If they are all generated in sealed vaults that a player can chose to open, letting them be able to use stairs seems much more reasonable. (That behavior restriction is a very blunt instrument for balancing, in any case.) -------------------------------------------------------------------------------- 46a0957 | advil | 2018-06-16 23:26:17 -0500 Don't spawn randomly-placed ghosts on level generation With this change, all ghost placement is done by vaults. -------------------------------------------------------------------------------- 30d8ac5 | advil | 2018-06-16 23:26:17 -0500 Tweak ghost vault generation rates This is aiming for a 1/3 chance of generation, following the old ghost placement rates. -------------------------------------------------------------------------------- 0f524d8 | advil | 2018-06-16 23:26:17 -0500 Don't use permastore when rewriting on level veto -------------------------------------------------------------------------------- 9478639 | advil | 2018-06-16 23:26:17 -0500 Add a permanent store for some fallback ghosts This addition is to deal with the question of how to place a ghost vault if there are no bones files: basically, always try to keep around some ghosts to use, rather than deleting all of them all the time. If this idea works out, we may want to pre-seed download versions with some sanitized ghosts. This randomizes names saved in the permastore for online play, but doesn't for offline play. -------------------------------------------------------------------------------- a8b80c1 | advil | 2018-06-16 23:26:17 -0500 Add a description line for mirrored player ghosts These won't be the norm, but I anticipate keeping them around as an emergency fallback. (They could be fun to very occasionally generate on purpose.) -------------------------------------------------------------------------------- a3c4442 | advil | 2018-06-16 23:26:17 -0500 Add some ghost mini-vaults that will place in Vaults Still pretty basic, I don't know much about vault design. The weights might need rethinking, still. -------------------------------------------------------------------------------- ce72dfe | advil | 2018-06-16 23:26:17 -0500 Allow ghosts built from bones files to be placed in vaults This commit is the first proof-of-concept for a potential overhaul of the player ghost system that places ghosts only in sealed (runed/transporter) vaults. Specifically, vaults will accept "player ghost" as a monster name, and on getting this description will try to load a ghost from a bones file for the level being generated. If there is no bones file, it falls back on making a ghost based on the player; this is a placeholder for something better. This idea tries to balance the flavor value of ghosts with the many ways in which they are problematic; ghosts in vaults like those in this commit are entirely optional. (This commit doesn't disable normal ghost generation.) One glaring issue: how to control the distribution of these vaults? Both of the vaults in this commit place a minimum good item, so having them as frequently as current ghosts might be too much (possibly the items should be toned down). With the current (absurd) weight they still don't generate all that often; possibly a WEIGHT setting isn't the right way to do this for these particular vaults. -------------------------------------------------------------------------------- 76e0a5f | Aidan Holm | 2018-06-17 00:51:53 +0800 Only show uncursed worn rings on ring swap menu Previously, this menu would show all jewellery the user was carrying, whether worn or not, including amulets. -------------------------------------------------------------------------------- 5591a09 | Aidan Holm | 2018-06-17 00:12:31 +0800 Remove quotes from tutorial lesson descriptions -------------------------------------------------------------------------------- 991dd4b | Aidan Holm | 2018-06-14 13:58:34 +0800 Fix webtiles lobby flash-of-unstyled-content This prevents the popup box template from briefly being visible while the CSS file (that includes a rule to hide .templates) is loading. -------------------------------------------------------------------------------- c6e99f3 | gammafunk | 2018-06-13 17:00:57 -0500 Merge pull request #788 from NormalPerson7/fix-temple-vault Fix some floor tiles in pf_slime_end_temple -------------------------------------------------------------------------------- 516f575 | gammafunk | 2018-06-13 17:00:20 -0500 Merge pull request #787 from ebering/des-syntax-pr Document glyph default behavior in .des -------------------------------------------------------------------------------- 2526e47 | NormalPerson7 | 2018-06-13 20:47:51 +0100 Fix pf_slime_end_temple Previously this would place erroneous floor tiles on some altars, because it was missing B in the FTILE assignment. -------------------------------------------------------------------------------- ce5a547 | Edgar A. Bering IV | 2018-06-13 14:57:25 -0400 Document glyph default behavior in .des -------------------------------------------------------------------------------- 101988f | Aidan Holm | 2018-06-14 01:30:35 +0800 Add static files for CBRO ui-overhaul experimental These changes are cherry-picked off the ui-overhaul branch (and modified slightly to avoid affecting the lobby page). They shouldn't have any effect on games outside of an ui-overhaul experimental, and will eventually be superseded when ui-overhaul is merged. -------------------------------------------------------------------------------- 19b682e | advil | 2018-06-13 09:50:06 -0600 Replace remaining uses of `*map_find` with explicit ASSERTs `*map_find` is highly dubious, because it assumes that the relevant map is complete with respect to some enum (usually under some specific assumptions), and none of the uses were plausibly cases where this is just going to automatically be fine in the long run. This change converts the checking of that assumption to an explicit ASSERT, rather than a segfault. -------------------------------------------------------------------------------- bd48a76 | advil | 2018-06-13 09:29:38 -0600 Set player as summoner for elemental force I'm not sure why this wasn't done in the first place, and there may be some reason I'm not thinking about. But the immediate impact of this commit is to prevent elemental force from placing tloc clouds when used in abyss, since this is the wrong flavor. -------------------------------------------------------------------------------- 632a1ea | advil | 2018-06-13 09:27:52 -0600 Don't overwrite opaque clouds with non-opaque clouds This will come up mostly for tloc clouds, I think. -------------------------------------------------------------------------------- e4f624a | advil | 2018-06-13 09:27:52 -0600 Don't assume elemental force placement doesn't change clouds This code assumed that the values returned by `cloud_at` were unchanged from the first pass to all points of the second pass. However, in the abyss, placement of elementals was also adding tloc clouds, which are not in the map, and therefore `*map_find` was not safe. This could cause crashes, which were relatively reliably triggered by reading summoning, fog, and triggering elemental force in succession. (I think the impact of summoning was just to get a crowd of already placed monsters around, though I didn't test carefully why this mattered.) -------------------------------------------------------------------------------- 522be1c | advil | 2018-06-13 08:35:55 -0600 Let `user_settings` be determined automatically So that a manual config.py change isn't required. This will by default use the same location as password_db. -------------------------------------------------------------------------------- f26638a | Aidan Holm | 2018-06-11 02:25:50 +0800 Reorder M&F and Axes on skill menu (Arrhythmia) Tavern post: https://crawl.develz.org/tavern/viewtopic.php?f=8&t=25476 This makes the menu order consistent with the crosstraining cycle, as well as with the aptitudes table columns. -------------------------------------------------------------------------------- e4a679f | Edgar A. Bering IV | 2018-06-10 15:27:03 +0800 Clean up uses of unique_ptrs operator bool and operator* allow a lot of superflous .get() calls to be removed, as well as a few ASSERTs that will never trigger and some braces. -------------------------------------------------------------------------------- 5c5de1c | advil | 2018-06-09 16:28:21 -0400 Let ArmourOffDelay be invalidated for undefined items (11494) This can apparently happen (rarely) in local tiles if mouse clicks pile up extremely fast, leading to an ArmourOffDely -> DropItemDelay -> ArmourOffDelay -> DropItemDelay sequence for the same item. Since the item starts off as an inventory item, they all use the same reference for the item, but dropping invalidates the item (see `items.cc:dec_inv_item_quantity`), it is no longer a reference to a valid item after the first drop, leading to a crash. DropItemDelay already handled invalid items. It might also be good to have drop_item just abort if there's already a DropItemDelay scheduled for the item in question, but that's somewhat tricky to do technically, since both item drop delays actually call drop_item. This safety check for ArmourOffDelay still seems reasonable anyways. -------------------------------------------------------------------------------- caf04df | advil | 2018-06-09 14:17:00 -0400 Show mute status in spectator list -------------------------------------------------------------------------------- 2dae380 | advil | 2018-06-09 14:17:00 -0400 Add a way of minimizing and hiding the chat window This adds a third mode to the chat window: it can be minimized into a small box with just a `+` that does not visually change with chat state, in case (for any number of reasons) a player doesn't want to be distracted by chat. The window can be restored by clicking the +, or by hitting F12. There's also a slightly hidden mode that really gets rid of chat, aimed at streamers who are currently just doing this with browser dev tools. To get this, type `/hide forever` in the chat window. To get it back, you will need to reload, or log out and in. When a user types "/hide forever" this will also hide their name from the spectator view in the chat window (basically the same behavior as a console spectator or viewer). Should this instead do something like "n hidden"? None of this state is saved, although it could be if there's demand for that. -------------------------------------------------------------------------------- 56e49a4 | advil | 2018-06-09 14:17:00 -0400 Add an `/unmute *` command, /help, misc cleanups Intentionally making it easier to clear than to add to mute lists. -------------------------------------------------------------------------------- 94a6f44 | advil | 2018-06-09 14:17:00 -0400 Implement mutelist saving with a server-side sqlite db This implements per-user saving of mutelists across sessions. Because I'm paranoid, I used a separate database from the password database; perhaps this is overkill. Part of my concern is that the password database is shared with dgl, and I just didn't want to have to worry about what dgl might do. -------------------------------------------------------------------------------- 186421b | advil | 2018-06-09 14:17:00 -0400 Proof of concept implementation of server-side tileschat mute This implements per-process muting for tileschat in the webserver. There are three commands, "/mute", "/unmute", and "/mutelist"; only the player can use any of these commands. Right now this doesn't save at all, so would need to be reconstructed on every save/reload. It's just a first pass / thought experiment in how better tileschat controls could be implemented, so more work would be needed before merging. There's no indication to anyone except the player who is muted, which might be good to have. I'm not sure this is the best way to do it, especially for a quick fix for spamming. In ##crawl-dev gammafunk and I discussed an alternative that would be client-side, per-user (instead of for the whole channel), and saved in a cookie, which could be better, and wouldn't require any server updates. (It might be possible to adapt the cookie saving idea to the current commit.) -------------------------------------------------------------------------------- bd68aaf | shieldal | 2018-06-09 14:02:06 -0400 Fix grammar in Zin's laws description (0011491) -------------------------------------------------------------------------------- 49b1da7 | advil | 2018-06-08 16:07:07 -0400 Add command sequences to the front of the buffer for crawl.do_commands I think this will finally fix 11489 and related bugs. The basic problem here is that in all attempts at dealing with this before, crawl.do_commands has potentially separated the first element of the sequence from the remainder by pushing the remainder of the sequence to the back of the macro buffer (either the sendkeys buffer in the original version and 3f858e37d316, or the regular buffer in d5c8bedc332) and triggering the first command immediately. If multiple input keys happen very fast, there could be intervening keys at the front of the buffer when the first command is triggered. For autofight, the primary (only?) use of crawl.do_commands, this sometimes resulted in targeting commands in the wrong context, depending on the key. This behavior could happen in online play with lag or network randomness, and I recently discovered it could also be triggered in offline play by e.g. binding the macro sequence `\{9}\{27}` to a key. This change pushes the remainder of the sequence to the front of the regular macro buffer, which guarantees that they won't be separated. The problem that was causing in crashes in d5c8bedc332 won't apply, since it was an ASSERT that only triggers on pushing to the back of the regular macro buffer. This fixes some other weird behavior introduced in 461d14e83c155adf, such as making it impossible to put tab in a macro with other keys; that commit in general probably produced errors in more places than the previous versions. I did not yet change crawl.process_keys similarly, but this maybe should be done. -------------------------------------------------------------------------------- fc9006d | Alex Jurkiewicz | 2018-06-09 00:35:26 +0800 Add error output to unbrace Changes the output of `util/unbrace -n` so it's informative for new contributors. -------------------------------------------------------------------------------- c254099 | Nikolai Lavsky | 2018-06-08 13:45:48 +0300 Make Iron Giants and other Throw Ally users obey Sanctuary Iron Giants can throw monsters at the player protected by Sanctuary. They can do up to 35 damage (random2(HD*2)) per throw without angering Zin. Originally Throw Ally was a Robin-exclusive ability, so this was not a problem. Normally monsters don't use abilities that can harm the player, if the player is in sanctuary. These checks are done in mon-cast.cc:_ms_waste_of_time(). But for spell_harms_target() Throw Ally is not a harmful ability. This is because the ability doesn't have a SPFLAG_TARGETING_MASK flag (either SPFLAG_DIR_OR_TARGET or SPFLAG_TARGET). Since Throw Ally is a smite-targeted ability, the appropriate flag for it is SPFLAG_TARGET. -------------------------------------------------------------------------------- b446440 | advil | 2018-06-07 17:49:45 -0400 Fix (un)woken_rest.rc This entomb function didn't work right because it changed the player's location to a metal wall, which teleported them away. -------------------------------------------------------------------------------- 461d14e | advil | 2018-06-07 16:05:34 -0400 Don't allow crawl.process_keys or crawl.do_commands with pending input Each of these lua calls pushes a sequence into the sendkeys buffer, and immediately triggers the first member of the sequence. If there's anything else in either pending input buffer, (a) it should presumably have priority over new commands, and (b) the remainder of the sequence (if there is one) will get separated from the initial one. For sequences of keys that don't obey this constraint, then crawl.sendkeys is the correct call, it will add things to the back of the buffer only. There is apparently no equivalent call for commands, but it could be added if necessary. -------------------------------------------------------------------------------- 49d386f | Nikolai Lavsky | 2018-06-07 22:01:03 +0300 Fix Injury Bond description Injury Bond affects all allies in LOS, not just one. -------------------------------------------------------------------------------- 11ed031 | gammafunk | 2018-06-05 08:08:25 -0500 Fix glyph usage in two temple entrances (Reeces) Due to a missing substitution, temple_doors_ab would sometimes place a large number of random altars instead of placing stone or rock wall as intended. Fix this, and also add a connecter on the right side of this vault and temple_doors_cd for the cases when these vault sections are not trimmed. This will prevent the resulting passage from simply running into a wall. -------------------------------------------------------------------------------- a0624bf | Chris Campbell | 2018-06-04 16:43:11 +0100 Update some more glyphs in the manual -------------------------------------------------------------------------------- 14ec769 | NormalPerson7 | 2018-06-04 16:27:55 +0100 Remove some obsolete references to rods -------------------------------------------------------------------------------- 7d3bdab | NormalPerson7 | 2018-06-04 16:27:55 +0100 Escape the | character in crawl-manual.rst to fix some formatting -------------------------------------------------------------------------------- bef45da | Chris Campbell | 2018-06-04 16:21:06 +0100 Merge pull request #722 from dplusplus/fix_help fix help; "stick" tag is not available in current version -------------------------------------------------------------------------------- 8c5347a | Chris Campbell | 2018-06-04 16:07:22 +0100 Merge pull request #767 from ebering/vd-full-health-prompt Abort Vampiric Draining at full health -------------------------------------------------------------------------------- 1fb7470 | advil | 2018-06-03 10:13:20 -0400 Quiet some gcc-specific shadow warnings on tiles builds gcc (but not clang) warns if a local variable shadows a member function. This is probably a bit overenthusiastic of gcc, but it doesn't hurt to get back to warning-free compilation. -------------------------------------------------------------------------------- ee5f723 | advil | 2018-06-02 17:00:16 -0400 Use positive -W flags to check for compiler compatibility This is because gcc will only emit a warning for unknown negative (`-Wno-foo`) warning flags if there are other warnings/errors that show up. However, both gcc and clang guarantee a positive and a negative form for all warning flags, so it should be safe to test the positive form (-Wfoo), which will trigger a message from gcc if unknown. -------------------------------------------------------------------------------- 37d83ea | gammafunk | 2018-06-02 11:32:07 -0500 Make Lee's Rapid Deconstruction never break walls This commit removes the ability of LRD to break any type of wall. No changes are made to the types of walls or monsters that LRD can target nor to how damaging the LRD fragments are. LRD provided access to infinite digging and wall destruction without requiring much training, especially if enhancers were used. We'd like to make access to digging relatively limited since infinite digging encourages the player to carefully and tediously dig out paths that are ideal for luring and killing monsters. LRD's destruction of stone/metal/crystal walls also made it too easy for the player to bypass the intended entry of many vaults. The Shatter spell allows some of these things, but it requires far more investment to be castable. The wand of digging, Shatter spell, and other species/god abilities collectively do a good job of providing the player with forms of wall destruction or movement. LRD without wall destruction is still a very strong spell and remains a fairly complicated one due to all of its wall type and monster type interactions. -------------------------------------------------------------------------------- 8c8ef71 | advil | 2018-06-01 12:06:05 -0400 Fix webtiles status artifacts due to custom status light code (11488) When a duration was immediately followed in duration_type by a duration that has some custom webtiles code in tileweb.cc:_update_statuses, the status_info wouldn't be fully reset for the custom status; I'm not sure if this had any noticeable effects beyond the acrobat case, but this would've bitten someone eventually (it's more or less by accident that divine shield follows divine stamina, so one couldn't have both at the same time). For acrobat in particular, 8519d868e99a introduced a check that was missing a continue, meaning that recite cooldown (the next duration in the enum) would show up twice if acrobat was not active. This also replaces a janky static reset function for status_info with a proper constructor that actually guarantees the int is initialized, and switches unnecessary pointer uses of status_info to references. -------------------------------------------------------------------------------- 9e76084 | Edgar A. Bering IV | 2018-06-01 05:47:39 -0500 Make splash_gauntlet patrolling, add bog bodies The splash_gauntlet loses its 'run the gauntlet' theme if the monsters wander off and it's just a lone electric eel. Added bog bodies to the monster mix and the patrolling flag to the vault. The weight preserves the expected number of monsters at 4 + maybe the eel, which might be too heavy with patrolling. Committer's Note: Squashed a previous commit that was reverted and updated commit message accordingly. Closes #763. -------------------------------------------------------------------------------- 17c3723 | gammafunk | 2018-05-30 07:15:45 -0500 Merge pull request #762 from ebering/arrival-vault-pr A knot of arrival vaults. -------------------------------------------------------------------------------- cf5b0c6 | gammafunk | 2018-05-29 07:24:02 -0500 Merge pull request #769 from ebering/uskayaw-stomp-descript Correct Usk stomp description -------------------------------------------------------------------------------- 20ad6ec | Edgar A. Bering IV | 2018-05-28 18:12:24 -0400 Correct Usk stomp description -------------------------------------------------------------------------------- ac93bac | gammafunk | 2018-05-28 16:58:50 -0500 Update an ice cave transporter vault Rename this vault to ice_cave_statue_garden_transporter. The teleporter feature is no more, so having this in the vault name is confusing. Also remove no_tele_into from the second chamber. This wasn't ever necessary, since both chambers have exits. It's also spoilery that reading teleport in the second chamber always took the player to the first chamber. To allow the player to return to the first chamber should they have forgotten something there, make a return transporter in the second chamber that's only reachable from the loot area. Simplify glyph usage now that distinct glyphs aren't needed for no_tele_into purposes. -------------------------------------------------------------------------------- 90f0736 | gammafunk | 2018-05-28 16:58:50 -0500 Mark an unused feature tile for removal after major version change -------------------------------------------------------------------------------- 7c5a50c | gammafunk | 2018-05-28 16:58:44 -0500 Reindent a lua function -------------------------------------------------------------------------------- 04e6133 | gammafunk | 2018-05-28 16:55:36 -0500 Move some unused lua code to the save compat DES file When these functions were deprecated, I kept them in their original files with a TAG_MAJOR comment. Some save compat testing I did seemed to show that they would only properly be seen when found in the original DES file. However it's awkward having these functions lie around in their original files, and it's been about 1.5 releases since the functions were deprecated. The vast majority of games that might have needed the save compat functions are finished by now, and any errors will not be game-breaking. If we do see any live save compat errors due to the functions being moved to compat.des, we can possibly get a copy of the save and do some troubleshooting to look into why the functions aren't loading. -------------------------------------------------------------------------------- 04dac39 | Edgar A. Bering IV | 2018-05-28 03:14:09 -0500 Update old glyph sets for teleporter->transporter DEC/IBM now re-glyph transporters to use the teleporter glyph. old_unicode already used © for teleporters, so the line is deleted. Committer's Note: Closes #765. -------------------------------------------------------------------------------- b72857b | Edgar A. Bering IV | 2018-05-26 18:12:55 -0500 Update options_guide.txt for teleporter->transporter The option display_char no longer cares about teleporter and now takes transporter and transporter_landing. -------------------------------------------------------------------------------- d2a9cce | advil | 2018-05-26 16:41:10 -0400 Explicitly store version history in the save file as a prop This can usually be reconstructed from the morgue, if the morgue is available, but sometimes it's not, and it can be really annoying not to have this info. -------------------------------------------------------------------------------- 10d5862 | advil | 2018-05-26 10:16:39 -0400 Fix shopping list crashes from multiple items with the same name Mainly happening when trying to remove spellbooks from the shopping list. It was possible to get multiple items with the same name on the shopping list, which would then (depending on iterator order) lead to crashes if they were removed. All of the find/delete code behaved unreliably in this case, because it worked by getting the first index by name, which may not actually match up to the `thing` that was passed in, and so the removal order didn't match up with the iterator order. This change generalizes these bits of the shopping list code to not assume that there will be single items associated with any name-level pair. This fix is more of a patch than a complete fix, because: 1. The level_pos checks in this code seem to be still unreliable in ways I haven't fully tracked down yet. 2. Reading the code, it was supposed to be impossible to have multiple items with the same name, but the checks for this are hopelessly broken (as far as I can tell), and probably undesireable anyways. 3. It seems to me that associating shopping list items with level ids, rather than particular shops, is just a fundamental design flaw that makes it impossible to uniquely associate shopping list entries with actual particular items in the game. This will need more of a rewrite to fix, though. -------------------------------------------------------------------------------- 925dece | advil | 2018-05-26 10:16:24 -0400 unbrace -------------------------------------------------------------------------------- 74ca774 | Edgar A. Bering IV | 2018-05-25 16:53:53 -0400 Abort Vampiric Draining at full health The spell will have no effect so don't waste a turn and mp casting it. -------------------------------------------------------------------------------- 6609fc6 | advil | 2018-05-25 14:24:28 -0400 Quiet some gcc warnings (NP7) -------------------------------------------------------------------------------- 97ce8ef | advil | 2018-05-24 16:33:16 -0400 Tweak wall jump messaging -------------------------------------------------------------------------------- e766b1c | advil | 2018-05-24 16:31:03 -0400 Automatically retract mandibles if wall jump is triggered as an ability -------------------------------------------------------------------------------- 154e428 | advil | 2018-05-24 15:36:58 -0400 Tweak passwall range/power Because spell range is always capped by your current vision range in `spell_range`, and passwall range was set to 9, passwall spellpower had a weird interaction where range capped out way before spellpower (at 140 spellpower; would be higher on a Ba I guess). It was also one of those spells where max spellpower was impossible anyways (e.g. 27/27/27 int 50 still didn't do it). This change makes it so that max spellpower = max range (now 7, the practical range for most non-Ba before), with max spellpower adjusted down slightly (120) from where the previous actual cap was, though it's still extremely implausible to get. This commit more or less maintains the status quo with more meaningful spellpower; I'm not really opposed gameplay-wise to longer passwalls being possible, but this would present some problems with the introduction of the targeter in the preceding commit. If someone wants to do this you'd need to start by special-casing it in spl-util.cc:spell_range. -------------------------------------------------------------------------------- cae90e3 | advil | 2018-05-24 15:36:58 -0400 Refactor passwall and add a targeter This commit rewrites the passwall logic to hopefully be much cleaner, and more consistent about revealing map information (following up on 4197694d79069). It adds a targeter that shows the exact possible range of a passwall, covering any possible landing sites, as well as the infrastructure necessary for targeting rays to display out of sight. The commit also fixes a number of other longstanding passwall issues, 6571 and 11229. Now when you abort a passwall with full knowledge of the possible landing sites, it should not waste a turn. One potential issue with this change is that the passwall targeter can reveal map bounds, because the ray won't render. I'm not sure there's anything to be done about this, though, and this is far from the only thing that does (e.g. setting exclusions on out of bounds positions). -------------------------------------------------------------------------------- 89d60a1 | gammafunk | 2018-05-22 23:00:02 -0500 Merge pull request #758 from ebering/banished-cleanup Code cleanup -------------------------------------------------------------------------------- 4197694 | advil | 2018-05-22 18:36:00 -0400 Don't leak information about passwall landing site via exclusions Discovered by u/top_koala, https://www.reddit.com/r/dcss/comments/8l5qhx/passwall_bugexploit_to_help_you_st ab_things/ Basically, exclusions on unseen spaces could be used to avoid stopping earlier than desired if the earlier space is floor. This change will prompt on intermediate exclusions on unseen tiles that would undershoot the actual destination. There is probably still a similar overshoot leak, but I'm less clear on what exactly the check is or whether such a leak is as useful in practice. -------------------------------------------------------------------------------- c9969fe | Edgar A. Bering IV | 2018-05-21 13:09:57 -0400 A knot of arrival vaults. -------------------------------------------------------------------------------- 9628fc8 | Alan Malloy | 2018-05-15 13:00:12 -0700 Document a surprising (to me) pointer alias -------------------------------------------------------------------------------- 2950eec | Alan Malloy | 2018-05-15 13:00:12 -0700 Fix a comparator to be permissible (hexaflexagon, #11472) -------------------------------------------------------------------------------- bed293b | advil | 2018-05-15 09:44:14 -0400 Revert "Revert "Handle just seen monsters better, especially fast ones (791)"" This reverts commit 492bfec932320e40cd2473a1590838919e5ca699. -------------------------------------------------------------------------------- 492bfec | advil | 2018-05-14 20:10:20 -0400 Revert "Handle just seen monsters better, especially fast ones (791)" Getting random crashes in arena test, not sure what's up and I won't be able to look until later. This reverts commit ae1bc95d447d08b7691663c52d789b5344f7abc1. -------------------------------------------------------------------------------- ae1bc95 | advil | 2018-05-14 18:10:29 -0400 Handle just seen monsters better, especially fast ones (791) This improves the handling of several cases of fast monsters that are newly seen. First, it was possible for them to move multiple times in world_reacts with the following buggy pattern: they move into the players los, get announced, shout, and leave los -- this last step is supposed to be announced, but isn't unless it happens on the first move. Second, it was possible for fast monsters to move into and out of los without being announced at all, as long as they were wandering, and now they will be announced in such cases. However, there is an odd consequence of this, which comes from the fact that observing a wandering monster for the first time temporarily changes its behavior. As long as the observation happens in the middle of world_reacts (not on the player's movement), and the monster has more energy, the monster subconsciously tries to stay in the player's los for at least one turn, so the player can get a real glimpse. Consequently, in cases where previously a fast monster would flicker in and out of the player's los with no one being the wiser, the monster will now be marked as SC_JUST_SEEN and most likely stay there for a turn. This probably adds an extra stealth check to such cases. I'm not sure how often this happens in practice, I had to jigger the wander behavior to get it to easily replicate. I thought that when I fixed the core bug, I could simplify things, but this was wrong -- I don't dare remove any code to do with previously unseen monsters. This whole system is completely insane. -------------------------------------------------------------------------------- 1387785 | advil | 2018-05-13 22:07:58 -0400 Clear seen flags when wizmode moving a monster out of view For testing messaging on newly seen monsters, as it is otherwise extremely hard to set up repeatable scenarios. I don't think it should be a problem to have this always happen. -------------------------------------------------------------------------------- b7b63b2 | advil | 2018-05-13 21:26:19 -0400 Relax restrictions on wizmode monster moving This now allows you to move monsters past transparent walls, and even to positions out of los. (It also allows moving into solid features, and into the player's position, but both of these were already possible. The behavior when you move a monster onto another monster is also the same as before - they swap.) -------------------------------------------------------------------------------- e82b8a9 | advil | 2018-05-13 20:23:06 -0400 Properly handle previous offlevel travel targets in map view (11466) Before, this would go to the coordinates of the previous travel target, but without changing levels. -------------------------------------------------------------------------------- acd343e | NormalPerson7 | 2018-05-12 17:05:42 +0800 Dont tell player of dragon scales creation when to be destroyed (#11464) Previously, the message saying scales had been dropped appeared after the message saying they had been destroyed (#11464, Leszczynek), which is erroneous. This commit removes the message for scales being dropped entirely when over water/lava, because the scales were hardly "intact", leaving just the "You hear a splash" message. -------------------------------------------------------------------------------- e8614c9 | Aidan Holm | 2018-05-12 14:37:34 +0800 Edit swastika-shaped arrival vault It's now less of a spiral, and more of a wavy pattern. Perhaps a rename is in order? I also fixed up the slanted corners of the vault, which were not symmetrical. -------------------------------------------------------------------------------- 2b68d14 | Aidan Holm | 2018-05-11 22:05:05 +0800 Add spell library contents to dump Excludes spells you already have memorised, to avoid duplication. -------------------------------------------------------------------------------- beac91d | advil | 2018-05-11 08:46:25 -0400 Add gnolls to mutation test (Sergeek) -------------------------------------------------------------------------------- 97be04f | advil | 2018-05-10 21:55:22 -0400 Fix messaging for oods that have just been created (11469) OODs are created at (0,0) and then get a placement somewhere in the first call of iood_act. If they were to hit a wall immediately (for example if fired point blank into the wall with Z), a check for ood visibility that determined whether to print the crash message was failing, because the player can't see (0,0). This change uses the IOOD's actual starting position after fuzzing for the visibility check and cloud placement. N.b. I think that this position might sometimes be the caster's position or a solid feature in tight quarters, which is presumably why the ood isn't placed immediately; the cloud still doesn't usually show up in these cases for this reason. -------------------------------------------------------------------------------- ad65372 | Edgar A. Bering IV | 2018-05-10 10:40:28 -0400 Code cleanup Remove an unnecessary call to push_features_to_abyss from banished() -------------------------------------------------------------------------------- b855193 | gammafunk | 2018-05-09 17:08:40 -0500 Prevent shafts/teleports into an early cloud vault (MainiacJoe, #11449) That vault places large numbers of cloud generators in a long corridor. Players shafted or teleported into it from early dungeon levels are very likely to have no means of escape depending on where they land. Mark the vault with no_tele_into and clean up DES syntax. -------------------------------------------------------------------------------- 0c774a7 | advil | 2018-05-09 09:46:03 -0400 Add a necessary emptiness check (11467?) Possibly was causing crashes with -D_GLIBCXX_ASSERTIONS on gcc. -------------------------------------------------------------------------------- b098539 | advil | 2018-05-08 10:30:31 -0400 Use "recommended" in the character menu instead of "viable" The intent of this change is to weaken the implication (technically a scalar implicature) that non-highlighted combos are really bad. Right new the inference is that that non-highlighted combos are not viable (because if they were viable they would be highlighted). It's hard to avoid some inference of this kind, but "not recommended" seems much weaker than "not viable". I didn't change the use of "viable" in rc files, or in the underlying code. -------------------------------------------------------------------------------- 9ff8d77 | Poroing | 2018-05-07 21:30:15 -0500 Fix obsolete function name. Committer's Note: automagic.lua is still defining and using a delta_to_vi() lua function. Automagic should be rewritten to use this delta_to_cmd() for the same reason autofight was rewritten in 7aac3cfd. The delta_to_cmd() definition could then be moved to dat/dlua/userbase.lua, which is loaded for clua as well as dlua. -------------------------------------------------------------------------------- 6463fda | advil | 2018-05-07 19:57:09 -0400 Handle startup preferences (esp. name) better when restarting Startup preferences weren't really working properly for new games without completely exiting the program, only restoring handled the various restart cases. Also remove some no-longer-relevant code from 2006. -------------------------------------------------------------------------------- 35e5176 | Alan Malloy | 2018-05-07 13:54:16 -0700 Fix a crash in game startup It was possible (but not guaranteed) to cause a crash by starting a new game after quitting to the menu from a previous game, because we didn't clean up the existing shopping_list, leaving us in an inconsistent state. -------------------------------------------------------------------------------- c217a56 | Aidan Holm | 2018-05-07 23:26:49 +0800 Fix loading of paletted images on SDL tiles Previous code was assuming that all pixel data was contiguous, which was not the case: pixels in a row are contiguous, but rows may be separated. -------------------------------------------------------------------------------- a933591 | Neil Moore | 2018-05-05 12:17:51 -0400 Remove some parentheses to satisfy unbrace. I'm not entirely convinced that prohibiting parentheses around return expressions is a great policy, particularly for multi-line expressions like this one, but whatever. -------------------------------------------------------------------------------- 27b4f7b | Neil Moore | 2018-05-05 12:15:28 -0400 Remove references to obsolete mutation sources (dds1) [skip ci] -------------------------------------------------------------------------------- a245024 | pikaro | 2018-05-05 10:37:43 -0400 Expose current LOS in CLua, adjust autofight and automagic to use it -------------------------------------------------------------------------------- c4eb3cb | gammafunk | 2018-05-05 03:43:31 -0500 A "magic classroom" special room for Depths (Skrybe, #11384) A Depths special room that places spell-casting monsters with small chances to place one of a few spell-using uniques that normally appear in Depths. This only non-formatting changes from the original submission are to add Boris to the unique list and to tweak the least dangerous case that can happen on Depths:1-2 based on the result of a random roll. For that case, place a tengu reaver as the alternate for a lich instead of having small chances for said uniques. These uniques normally spawn through their vaults on Depths:3-5 and are certainly more comparable to fighting an ancient lich that places in the worst case in this special room. Therefore give them weight only in that worst case monster list. -------------------------------------------------------------------------------- 8bb545f | advil | 2018-05-03 22:20:20 -0400 Remove a dubious nullptr-terminated vararg and replace with initializer lists. -------------------------------------------------------------------------------- d0aace3 | advil | 2018-05-03 22:19:08 -0400 Use the sendkeys buffer for local tiles clicking Since this seems to be safer for CMD_... sequences that might be mixed in with other keystrokes. -------------------------------------------------------------------------------- 3f858e3 | advil | 2018-05-03 08:25:09 -0400 Go back to adding autofight commands to the secondary buffer Adding them to the main buffer is causing some occasional crashes that I can't replicate, probably about the interaction of tab with other keys; going back to doing this should avoid triggering the relevant ASSERT. -------------------------------------------------------------------------------- fed312b | advil | 2018-05-02 22:19:27 -0400 Add the ultimate enemy I got tired of wizmode test monsters inconveniently moving around and dying. (How did we not have one of these before?) -------------------------------------------------------------------------------- d5c8bed | advil | 2018-05-02 20:50:19 -0400 Don't convert lua do_commands to keys and back (11095) An actual command_type should be handled ok by anything on the other end of this, so converting to keys immediately is overkill. This was causing problems with keybindings in targeting mode that remapped numbers to the direction commands in unusual ways: the first call converted the commands to keys, and the keys got converted (incorrectly) to vikeys by `unmangle_direction_keys`; they then got converted back to commands, preserving the incorrect mapping. So the exact bug in 11095 is really that unmangle shouldn't be called on the output of command_to_key, since it isn't aware of keybindings. The bug required a somewhat unusual key mapping to surface; in this particular report 6 and 8 were (maybe by accident) swapped relative to their normal position on a keypad, and this is why unmangling went wrong. Only autofight even uses this lua call, so hopefully there are no other consequences to this simplification, but if tab starts acting weirdly, this commit was probably why. -------------------------------------------------------------------------------- 7f50228 | advil | 2018-05-02 00:47:30 -0400 Don't print errors when mouse targeting a ranged weapon Consequence of 991379fdf84c: mouse targeting uses CMD_... sequences directly, and for targeting it uses ones that are targeting context commands. The call in `fire_target_behaviour::get_command` to `key_to_command` uses the default key context, since the four commands it's checking aren't actually targeting keys, but any input was passed through this, and since `key_to_command` validates the context for any commands you give it, the mouse targeting command sequence caused a bunch of errors each time it was called (the errors were basically just cosmetic). If we make a habit of using some `command_type`s in multiple contexts, the context system should probably be refactored to handle that a little bit better. -------------------------------------------------------------------------------- 5dc3fd9 | gammafunk | 2018-04-30 12:14:08 -0500 Replace encased rock with stone in an Elf vault (NormalPerson7) This rock can be turned into earth elementals by deep elf elementalists so that the elementals just remain trapped yet still detectable by antennae. There's no reason to use rock in these inaccessible areas, so replace it with stone. Closes #750. -------------------------------------------------------------------------------- 927ce74 | Chris Campbell | 2018-04-30 16:18:34 +0100 Don't give monsters a movement penalty when escaping engulf -------------------------------------------------------------------------------- 8baa81b | NormalPerson7 | 2018-04-30 16:17:50 +0100 Remove Engulf's movement penalty and make it block all god abilities This commit removes the undocumented 50% movement penalty from Engulf (mentioned by #11458) and makes Engulf block all god abilities. This makes being unbreathing and being able to swim identical for the purposes of Engulf, and removes a special case in Zin's recite. Adds a new lua option you.res_drowning to avoid having to list all of the races and forms which are immune to drowning in the Engulf status description. [Squashed and cleaned up some formatting. Merges #748 PR - MarvinPA] -------------------------------------------------------------------------------- 8519d86 | advil | 2018-04-29 23:44:30 -0400 Have display of the acrobat ev boost in tiles match console Neither the number, nor the color, were showing properly in webtiles, where by properly I mean showing with the timing that they do in console. (As discussed in the dev channel in the past, it isn't entirely clear what the best way to show this is, but I went with the existing behavior.) To get the number to show, the LAST_MOVE_... property needed to be reset slightly later in main.cc, because it was getting cleared before the webtiles redraw (and probably regular tiles too, though I didn't test it); this led to it only appearing under strange circumstances such as resting with 5. To get the color to render, it just needed some explicit casing to get the timing right. As of this commit, the behavior should be the same in tiles/console. I also slightly generalized / unified some of the logic for checking whether to show the acrobat boost. -------------------------------------------------------------------------------- 09e6169 | Aidan Holm | 2018-04-29 02:10:50 +0800 Revert "Allow auto-travel to/from all locations" This reverts commit cd58e32bf33d8759b4cd63677a1ee1a00a8f276d. -------------------------------------------------------------------------------- b94d8b5 | Nikolai Lavsky | 2018-04-29 00:52:57 +0800 Improve Ashenzari's warnings for wands Two fixes: * Ash was giving warning messages for wands of clouds and iceblast even though monsters don't use them. * Ash wasn't warning the player about monsters carrying a wand of enslavement, which can be used to confuse the player. -------------------------------------------------------------------------------- 6184afb | advil | 2018-04-28 10:47:01 -0400 checkwhite / unbrace -------------------------------------------------------------------------------- 24998ea | advil | 2018-04-28 10:20:55 -0400 Encrypt the channel name in .travis.yml so forks can't use it See https://github.com/travis-ci/travis-ci/issues/1094 and https://github.com/mozilla/build-tools/commit/c13a2978e0869219295013eeb52cf52227 ab45ec Hopefully I did the encryption correctly... -------------------------------------------------------------------------------- f65d00e | Jacob Meigs | 2018-04-28 21:58:27 +0800 Remove get_item_info() deck filtering Fixes mantis issue #11435 Small comment change to note decks used_count can be negative. -------------------------------------------------------------------------------- 32d7058 | NormalPerson7 | 2018-04-28 21:00:02 +0800 Allow brand weapon scrolls to give venom under TSO TSO no longer hates venom, and hasn't for almost two years. This was inspired by gammafunk's commit ab1296c. -------------------------------------------------------------------------------- 4f8b0bd | Aidan Holm | 2018-04-28 20:26:00 +0800 Clear useless books from $-list after finding spells Filtered to items that were made useless by the act of finding spells; i.e. if you add an already-useless item to the shopping list and then find some other spells, that item won't be removed, since it wasn't just made useless. -------------------------------------------------------------------------------- cd58e32 | Aidan Holm | 2018-04-28 20:24:37 +0800 Allow auto-travel to/from all locations Auto-travel now supports travelling to and from all locations, including the abyss, pandemonium, hell sub-branches, and timed portals. For abyss and pan, < refers to a branch exit, while > means abyssal stairs and pan transits respectively. Handling pandemonium unfortunately requires a fair bit of special-casing, as it is the only branch with a depth of 1. In future, it might be nice to immediately reply with "I don't know how to get there" when the player is in abyss/pan with no reachable exits, rather than prompting for a destination. An improved prompt could also show "(>) Deeper into the abyss / Another region of pan" when that is the only available destination. -------------------------------------------------------------------------------- 6e0a438 | Aidan Holm | 2018-04-28 20:24:37 +0800 Fix some abyss features having wrong destination Abyssal stairs and exit-via-abyss didn't set their destinations correctly, which broke autotravel. -------------------------------------------------------------------------------- a9d99d6 | Alan Malloy | 2018-04-27 12:42:39 -0700 Simplify a boolean expression -------------------------------------------------------------------------------- 2a24f12 | Alan Malloy | 2018-04-27 12:42:39 -0700 Fix teleport/hatch closets in erik_orc_3 (Leszczynek, #11460) Rather than marking the closets as no-tele, I've simply made sure each tile is reachable by removing some of the maybe-wall tiles. -------------------------------------------------------------------------------- 846bec1 | advil | 2018-04-26 15:01:28 -0400 Add a way of detecting sendkeys problems for stress tests This adds a way to have the stress tests (which heavily use crawl.sendkeys) crash if the keybuffer is flushed before all the queued keys are processed. The intent is to catch situations like 15e00174aab247bba1, where a sendkeys sequence to do with flight became obsolete, and led to the test no longer working (for at least 2 years) because the buffer was flushed after those keys failed, but the rest of the test kept running as normal. Crashes only happen in wizmode with the relevant crawl_state parameter set; non-wizmode still prints an error if this parameter is set. (Maybe this error should always be printed? But there might be all sorts of ways to cause the buffer to flush. Crashing in this circumstance is definitely a very special case thing.) -------------------------------------------------------------------------------- 15e0017 | advil | 2018-04-26 12:58:27 -0400 Fix abyss_short_run.rc (aidanh) This is doubly-broken: Since 1f733d267d2fff9e920c items of flying start flight when worn, and at some point (not sure when) the default key for starting flight seesm to have become `g` anyways. So this test got a silent error on sendkeys('ah'), and failed to ever enter the abyss. -------------------------------------------------------------------------------- 2895223 | NormalPerson7 | 2018-04-26 21:58:50 +0800 Fix the message order when unwielding randart weapons (damerell, #11427) When a randart weapon had Fragile, the weapon would stop flaming/glowing/its visual brand after the weapon had "crumbled to dust", which is erroneous. This was caused by unequip_artefact_effect, containing the check for fragility, being called before the weapon brand's visual effect was dealt with. This commit fixes that by (a) creating a separate helper function unequip_fragile_artefact for dealing with Fragile artefacts, (b) calling this function from unequip_weapon_effect after the brand's visual effect is handled, and (c) calling this function from unequip_artefact_effect only when the artefact is not a weapon. -------------------------------------------------------------------------------- 5dfd9e3 | Yer mivvaggah | 2018-04-25 12:56:12 -0600 don't recommend LTO according to geekosaur, it doesn't do much even when it works. and according to me, cross compiling from Arch to Windows with LTO=y causes teleport scroll crashes! -------------------------------------------------------------------------------- ab1296c | gammafunk | 2018-04-24 19:54:11 -0500 Allow brand weapon scrolls to give flaming and chaos brands under Dith Dith no longer has a fire-hating conduct. -------------------------------------------------------------------------------- 01d5f99 | gammafunk | 2018-04-24 19:54:10 -0500 Allow fire facet mutant beasts under Dith and remove unused code Dith's fire conduct was the only use of this mutant beast facet exclusion code. Now that the conduct no longer exists, this code can be removed. If a new god conduct gets made where mutant beast facets need to be excluded, this commit can be partially reverted. -------------------------------------------------------------------------------- 609ae0a | gammafunk | 2018-04-24 19:20:20 -0500 Allow the ignite blood demonspawn mutation under Dith (gameguard) Dith no longer hates fire, so this mutation should be allowed to work. Fixes bug 11455. -------------------------------------------------------------------------------- 6ec6d78 | gammafunk | 2018-04-24 19:19:28 -0500 Mark some Pakellas code for removal when the major version changes -------------------------------------------------------------------------------- c73351f | Kyle Rawlins | 2018-04-23 17:07:28 -0400 Fix a typo [skip ci] -------------------------------------------------------------------------------- 870eee8 | advil | 2018-04-22 21:43:38 -0400 Ensure that close_all_menus syncs with webtiles clients This is one possible explanation for 11387, that somehow the javascript menu_stack gets out of sync with m_menu_stack on the client side. I haven't managed to reproduce this bug at all, but the two stacks getting out of sync via an extra open_menu immediately following init_menus would lead to the observed behavior, and explain why further menus act as submenus. This change ensures that the javascript stack is entirely empty when client-side close_all_menus is called, which is triggered on redraw. If this fix doesn't work, back to the drawing board. -------------------------------------------------------------------------------- b72a975 | advil | 2018-04-21 13:23:46 -0400 Merge branch 'dokempf_skill_callback' -------------------------------------------------------------------------------- ae935ca | advil | 2018-04-21 13:22:27 -0400 Check the results of the skill_training_needed callback Also some light refactoring to consolidate some related skill checks, and a bug fix: lua code could enable training on a maxed skill (and skill targets could probably be set for this case too). The refactoring shouldn't otherwise change any behavior but who knows with this code, some of the ways that these checks were done were subtly different. Resolves #729, doing the check non-recursively. -------------------------------------------------------------------------------- b03524a | Dominic Kempf | 2018-04-21 13:22:06 -0400 Add player LUA callback skill_training_needed The new skill target mechanism and its lua bindings are a very nice way of implementing automated skill advancement logic. However, when the last skill target is met while gaining experience the skill menu is opened and needs user interaction. The patch introduces a callback `skill_training_needed` in this case. If it returns true, the skill menu is not opened. -------------------------------------------------------------------------------- 646ff71 | advil | 2018-04-21 09:55:09 -0400 Fog spread rate simplification Previously, fog-producing effects had a 50% chance of producing a smoke type with 0 default spread rate, conditioned on smoke color (purple/blue didn't spread, grey/black did). This difference between smoke types predates the introduction of scroll of fog in 7ef7c926, and comes from the days when fog was only produced by miscast effects / xom; it may even predate dcss. It's quite spoilery, and I think it's not very well or easily understood by players, given that it's happening on top of a bunch of other randomness in cloud behavior. It's also, I believe, a contributing factor to newer players not figuring out how to use scrolls of fog. I'm not really even sure if it's intentional, since (especially in early code) you had to read between the lines to know that it was happening. Of course, the first version of fog was intentionally a bit more random (even had a 10% chance of producing miasma), so it might be. This commit makes the default spread rate the same for all four smoke types (and in fact all player-producable los-blockers); as far as I know, the differences between the four smoke types are now just cosmetic. (Spread rate can still be overridden on placing the cloud, but this is used extremely rarely, and not at all for los-blocking clouds that I have found.) This is a buff to scrolls of fog, since blue/purple smoke were likely to be useless for los blocking, and if this needs to be balanced I'd rather do it by decreasing the drop rate (though I tend to think the drop rate is ok at the moment, and definitely shouldn't be halved). It's also a buff for cloak of the thief, which maybe something should be done about. A possible balancing tweak would be to apply some randomness to spread rate independent of smoke color; I'm not currently very in favor of this because I think there's already enough randomness to the initial cloud. Other impacts: miscast effects, xom. Note that this doesn't affect tloc clouds even though they use the same tile/color as purple smoke. It also doesn't change steam, which already spread. -------------------------------------------------------------------------------- 29407c6 | CanOfWorms | 2018-04-21 01:39:22 -0400 Fix some manual acquirement logic Mark invocations skill as useful for Nemelex worshippers and useless for Ru worshippers. -------------------------------------------------------------------------------- 535178c | advil | 2018-04-18 20:04:42 -0400 Fix the octopode + P interaction when wearing many rings (aubilenon) When an octopode is wearing all the rings, and that number is more lines than there are lines in the message window, using P and selecting a ring forced an extremely awkward prompt that required a more, and then a ? if you want to see all the rings at once. This change just has the prompt use the menu from the beginning if there are too many rings to fit in the message window at its current height (the normal situation for webtiles). Annoyingly, there is no easy way to prompt only for rings, so this change shows all jewellery (for now). -------------------------------------------------------------------------------- 68eecb7 | advil | 2018-04-18 17:36:11 -0400 Refactor fsim for retaliatory damage, and to just be a little better It's been a long-standing annoyance that there's no way to check retaliation damage with fsim. This refactor tries to generally clean up how fsim works a bit (providing better abstraction) and use the improvements to handle retaliation damage (long blades, porcupines, etc). Because I unified setup for attack and defense, and tried to make it a bit more robust (using more unwinds, etc) this commit will also improve some special cases (e.g. retaliation damage from porcupines wasn't properly cleared). But, there are no doubt more special cases, and there may be unintended consequences. This commit doesn't change double scale fsim. -------------------------------------------------------------------------------- 76f67b3 | advil | 2018-04-18 17:36:11 -0400 Disable the poison effect in fsim This doesn't impact damage calculations (I think). -------------------------------------------------------------------------------- 5e80d7e | Nikolai Lavsky | 2018-04-18 14:37:33 +0800 Remove books from shopping list on pickup (Kipster) Usually items are removed from the shopping list when they are put into inventory. But after the introduction of spell library books no longer take up inventory space, so the usual code path, _put_item_in_inv() -> _got_item() -> cull_identical_items(), no longer works for them. -------------------------------------------------------------------------------- 7563fe7 | CanOfWorms | 2018-04-18 00:15:01 -0400 Scale skills correctly when checking fail rate Oops... -------------------------------------------------------------------------------- a98e25f | CanOfWorms | 2018-04-17 23:21:45 -0400 Fix ordering in spellpower calculations -------------------------------------------------------------------------------- 802c45d | CanOfWorms | 2018-04-17 22:50:02 -0400 Remove a stepdown in spell success calculations Spell success calculations currently use spellpower calculations to partially determine failure rates, but the stepdown doesn't apply until the player has trained magic skills to a high degree; Specifically, the stepdown applies whenever Spellcasting/2 + Spell School Average*2 > 50 This commit removes the stepdown from spell success (but still leaving it in spellpower calculations) and cleans up the code. To compensate for the buff at high skill levels, level 9 spell difficulty is adjusted. The net effect for level 9 spells is a reduction of about 0.5 to 2.5 in spell schools required to achieve the same failure rate in the 20-27 skill range. By removing the stepdown, spell success penalties due to armour and shields are simpler to quantify in terms of skill levels, e.g. "Wearing this armour penalizes spell success by an amount equal to 5.5 skill levels in all spell schools." Adding this type of information to the item information screen can be done in the future. -------------------------------------------------------------------------------- 201945f | advil | 2018-04-16 19:56:06 -0400 Let webtiles message height be set via `msg_webtiles_height` (aubilenon) Before this commit, the height of the webtiles message pane is inherited from console, but since webtiles is running over a console backend with a fixed size (80x24), it just isn't customizable using the existing options and I couldn't figure out a sensible way of adding better behavior using only the existing options. The only case where the previous behavior had an impact was in spectating (via webtiles) a console player with a customized message pane size. This option just sets the webtiles message pane independent of console, with the console's current size as a min. (N.b. the documentation simplifies this slightly, because the actual situation only makes sense if you have a good grasp on the fact that there is a secret console client.) Caveats: now a console player spectating a webtiles player with this setting will not see a matching messages pane, and a console player with this set will silently affect webtiles spectators. -------------------------------------------------------------------------------- 30dfbe6 | NormalPerson7 | 2018-04-15 23:39:28 +0800 Fix a double prompt on putting on rings with *Drain/*Contam/!P (#11309) Previously, if the player already had two rings on and needed to choose which ring to swap off, check_warning_inscriptions would be called twice, once before choosing which ring to swap off, and once after, causing a double prompt if the ring the player was putting on had *Drain or *Contam. Specifically, this behaviour was bad because the player could cancel putting on the ring by inadvertently pressing Esc/N on the second prompt, after having removed a ring already, resulting in a waste of 5 auts. This commit adds an extra argument to puton_ring which allows the function to be called from JewelleryOnDelay::finish() without checking check_warning_inscriptions, which results in just one check for inscriptions and *Drain/*Contam, occuring the first time the player tries to put the ring on. Hence, after selecting which ring to remove, the ring in question will be put on without prompt. Note that the static function _puton_item is called only by puton_ring. -------------------------------------------------------------------------------- 2d6336e | NormalPerson7 | 2018-04-14 15:20:18 +0800 Fix an extra "the" in "It would be a sin to butcher..." (Reeces) There was a "the" in the mprf description as well as from the name(DESC_THE).c_str(). -------------------------------------------------------------------------------- c608dd7 | NormalPerson7 | 2018-04-13 17:26:04 +0800 Make statue descriptions accurate about no-regen (#11448) This commit gives statues the M_NO_REGEN flag, which will show up in their description as "It cannot regenerate". This wasn't there before because statues cannot regenerate by any means, as seen in the check in monster::heal, whereas other monsters with this flag will still regenerate if given the regeneration status. The check in monster::heal is still checked with this flag on, however, so there is no reason this should change any behaviour. -------------------------------------------------------------------------------- 29664b4 | advil | 2018-04-11 21:40:47 -0400 Make the behavior of DEBUG_ITEM_SCAN more consistent In particular, this will fix up unlinked temporary items on level load consistently on all builds, not just FULLDEBUG builds. What was happening is that DEBUG_ITEM_SCAN is #defined on all builds, but for everything except FULLDEBUG builds, it got #defined in item-scan.cc, which of course interacts with compilation order; the result being that it was *not* defined at the time where tags.cc was built, and the fixup code wouldn't get called. This moves the #define to AppHdr.h (sorry) and does a bunch of other cleanup. It also prints an explicit error when loading the level, though now this will only get printed once; before these errors would get silently fixed up on FULLDEBUG builds only, leading to confusion. It may be that we *don't* want the fixup, since we'll get more saves that way that actually instantiate bugs that trigger this error, but for the moment I am just restoring the intended behavior from dc59d2025591002a2. Players seem to find it disconcerting when this message keeps repeating (e.g. https://crawl.develz.org/mantis/view.php?id=11413&nbn=1#bugnotes) so this makes it a bit easier on them. There's some worry in the comments about DEBUG_ITEM_SCAN being slow, but I think we do want it on always and it's been on for all builds for like 10 years, so I think it's fine. This doesn't interact with unlinked items held by dead monsters, which don't get fixed up by this code (though they could if we want that). -------------------------------------------------------------------------------- 910c0f9 | advil | 2018-04-11 18:46:10 -0400 Remove a swastika-ish arrival vault (11428) There's been some past discussion about whether this really looks like a swastika vs. some kind of spiral, but on console with the rest of the map not revealed (https://crawl.develz.org/mantis/file_download.php?file_id=7665&type=bug ), I agree with the judgment. The past discussion was using a tiles screenshot, which I agree looks different (because the ground doesn't stand out as much I think). -------------------------------------------------------------------------------- 873ca8c | advil | 2018-04-11 18:22:13 -0400 Fix a possible disconnected region in minmay_the_grid_ultimate (11444) If all three of these "s go to x (plus a few others), this region becomes cut off. By symmetry around the diagonal (noticed by aidanh) it seems that the fix is to change these particular "s to `.`. Minmay let us know if we're wrong... -------------------------------------------------------------------------------- d16d139 | Aidan Holm | 2018-04-06 23:01:07 +0800 Remove a bunch of unused variables -------------------------------------------------------------------------------- b46e3d7 | Aidan Holm | 2018-04-06 23:01:07 +0800 Remove some unneeded drawing function calls Fixes github issue #684 -------------------------------------------------------------------------------- a714374 | wheals | 2018-04-05 10:27:17 -0400 Remove process-desc.h. -------------------------------------------------------------------------------- 051d7ab | wheals | 2018-04-05 10:17:43 -0400 Explain how to clear the spell library filter. -------------------------------------------------------------------------------- 915a0fd | Aidan Holm | 2018-04-05 20:17:40 +0800 Add tiles for new game weapon options -------------------------------------------------------------------------------- 83320f9 | Aidan Holm | 2018-04-05 19:16:24 +0800 Add braces -------------------------------------------------------------------------------- 00f67d9 | Aidan Holm | 2018-04-05 19:16:24 +0800 Remove unused show_quote argument -------------------------------------------------------------------------------- eb62f64 | Aidan Holm | 2018-04-05 19:16:24 +0800 Tweak spell library UI and add help page Most of the changes here are removing the slight UI differences on local tiles. Cramming the "press ? for help" text into an already somewhat cluttered bottom line turns out to be a bit of a challenge, but it'll do for now. -------------------------------------------------------------------------------- 7fd3ada | Aidan Holm | 2018-04-05 19:16:24 +0800 Tweak menu select count string spacing -------------------------------------------------------------------------------- c95b66f | Aidan Holm | 2018-04-05 19:16:24 +0800 Remove process_description template monstrosity The given template converted a describe_info into a description string, using an additional parameter that provided a ncurses like interface to drop parts of the description if not everything could fit. This was only ever used for hover descriptions in local tiles (elsewhere, we're making long descriptions scrollable), and was only used to add a droppable prefix about clouds. This prefix is now always shown. Wrapping the text to fit the message region has been moved to MessageRegion::render(), which uses FontWrapper's split(). There's an extra bit to change the ellipsization style. -------------------------------------------------------------------------------- 3e50427 | Aidan Holm | 2018-04-05 19:16:24 +0800 Remove unneeded tiles_crt_control instances All of these instances are followed by code that uses show_description(), which already pushes and pops a menu on webtiles with code internal to Menu. The second string parameter is used to add a class to the menu HTML element to permit per-menu customization, but none of these were in use. (class: "menu_" + tag) -------------------------------------------------------------------------------- 2a239ed | Aidan Holm | 2018-04-05 19:16:23 +0800 Remove no-longer-needed helper function -------------------------------------------------------------------------------- 4ddc6ac | Aidan Holm | 2018-04-05 19:16:23 +0800 Replace all uses of print_description() Replaced with show_description(), which now automatically shows a UI for the description quote. The monster description UI still does its own thing at the moment though. -------------------------------------------------------------------------------- 761eef7 | Aidan Holm | 2018-04-05 19:16:23 +0800 Fix wordwrap on FAQ menu, and support long Q/As -------------------------------------------------------------------------------- 94544a2 | Aidan Holm | 2018-04-05 19:16:23 +0800 Move monster description quote toggle text to bottom -------------------------------------------------------------------------------- dbd6ce8 | Aidan Holm | 2018-04-05 19:16:23 +0800 Add better alternative to print_description() ... better in that show_description() supports scrolling, instead of just ellipsizing the content if it's too long to fit. -------------------------------------------------------------------------------- 5755430 | Aidan Holm | 2018-04-05 19:16:23 +0800 Append newline to ?/m titles (for consistency) -------------------------------------------------------------------------------- dd0f9c7 | Aidan Holm | 2018-04-05 19:16:23 +0800 Make spell memorise text consistent with item actions -------------------------------------------------------------------------------- acbdab5 | Aidan Holm | 2018-04-05 19:16:23 +0800 Remake god description UI with formatted_scroller This commit moves the describe-god UI to a formatted_scroller, and reimplements the religion join yesno prompts as a small state machine. This helps get rid of cgotoxy/the CRT abstraction: the god description functions now build formatted_strings. The god joining prompts are stuffed into the more string of the formatted_scroller, which is... not ideal, but should work until I get a replacement for formatted_scroller up and running. Fixes: - on webtiles, ^ will now show the religion UI in a popup box, instead of clearing the full screen: this matches ?/G behaviour. - religion join prompts can no longer fill up the screen. - the page indicator is now hidden when asking the player to join. Changes: - Message about yes/no only no longer changes based on the key that's pressed. To compensate, adjusted the string slightly to indicate that uppercase Y is required, while N and n are acceptable. - Pressing escape now always leaves the join-religion prompt loop and closes the menu. Regressions: - on webtiles, switching between religion pages now closes the popup before reopening it to the new page. - religion prompts now appear at the bottom of the screen, with the page indicator: not a problem on console, but is sub-optimal on local tiles (until I make local tiles menus boxed, like webtiles menus). -------------------------------------------------------------------------------- 7ef6792 | Aidan Holm | 2018-04-05 19:16:23 +0800 Remove unused webtiles client HTML -------------------------------------------------------------------------------- 0b74486 | Aidan Holm | 2018-04-05 19:16:23 +0800 Fix webtiles console hiding last empty line -------------------------------------------------------------------------------- 7cd8b77 | Aidan Holm | 2018-04-05 19:16:23 +0800 Force webtiles CRT popup to 80-char width This prevents the popup from resizing when scrolling through text of varying width. -------------------------------------------------------------------------------- 993470f | Aidan Holm | 2018-04-05 19:16:23 +0800 Remove unused webtiles menu tags -------------------------------------------------------------------------------- 41d4792 | Aidan Holm | 2018-04-05 19:16:23 +0800 Render menu icons at full size .. as opposed to rendering at the same size as the dungeon view. The dungeon view shrinks tiles to try to fit in the full LOS, but there's no need to do that for menu tiles. Resizing was also not properly handled: scrolling after a resize could cause new menu entries to be initialized, creating a menu with some tiles reduced in size. -------------------------------------------------------------------------------- 391584f | gammafunk | 2018-04-05 05:03:38 -0500 Remove an extra blank line -------------------------------------------------------------------------------- 8a7c851 | gammafunk | 2018-04-05 05:03:38 -0500 Remove the Dithmenos fire conduct Dithmenos' hatred of fiery spells and items isn't an interesting gameplay limitation, since restricting access to one kind of elemental damage has little effect on strategy. Damage from other elemental and non-resistable sources are widely available and can do the same thing that fire elemental damage does. A previous version of the Dith conduct was larger and tried encompass "sources of light", but this didn't work well, since "light" isn't a well-defined notion in crawl. Since the no-fire conduct prevents use of a rather specific set of items without introducing much decision making, it's better to simply not have the conduct. This commit removes Dith's hatred of fire-based items, spells, weapon brands, and summons. For consistency we also remove the god's appreciation of killing fiery monsters. Now Dith doesn't care about fiery things in general, and the shadow mimic works normally with fire-themed attacks. -------------------------------------------------------------------------------- 60b3cfd | Aidan Holm | 2018-04-01 21:44:20 +0800 Deduplicate card types in card description -------------------------------------------------------------------------------- f89cf90 | Aidan Holm | 2018-04-01 21:44:20 +0800 Improve local tiles hover info for clouds -------------------------------------------------------------------------------- 5f88266 | Aidan Holm | 2018-04-01 21:44:20 +0800 Merge WME_KEYPRESS into WME_KEYDOWN There's no actual differentiation between how these events are handled, for now. In future, once we have proper widgets, text entry widgets will need to differentiate between them, but unifying them simplifies UI screen implementation for the time being. -------------------------------------------------------------------------------- 99f3766 | Aidan Holm | 2018-04-01 21:43:59 +0800 Don't randomize ?/F tiles ... so they match the tile in the description popup, which will be added in a future commit. -------------------------------------------------------------------------------- 66d6621 | Aidan Holm | 2018-04-01 21:37:10 +0800 Fix compilation error -------------------------------------------------------------------------------- 276b176 | Aidan Holm | 2018-04-01 21:00:53 +0800 Spruce up the stash search and shopping menus (NormalPerson7, #11376) Add tiles for both of them, and also show feature descriptions for stash search results. This needs to use level_excursion to show instance-specific descriptions (such as trove costs). Picking feature tiles by the search result description is a horrible hack, and is currently buggy for a very small number of features, but it avoids a level_excursion for every menu entry. -------------------------------------------------------------------------------- 285f75a | Aidan Holm | 2018-04-01 21:00:53 +0800 Refactor some code into get_tiles_for_item() The code that adds the background tile assumes that the item is on the same level, which is not always the case, and generally makes this pretty buggy. But a level_excursion would likely be too heavyweight. Blegh. -------------------------------------------------------------------------------- e0921bb | gammafunk | 2018-04-01 05:43:01 -0500 Revamp a lemuel worm vault This vault got nerfed as various worm monsters were removed over the years, with many of the worms formerly in the vault being replaced with ordinary worms of the kind that stop generating by D:6. It was an autoexplore trap due to placing submerging swamp worms earlier than they usually generate. It was later also added to Spider, but not with terribly depth-appropriate monsters. Now swamp worms no longer submerge, hence not causing the same autoexplore problem, and pose a more credible threat at later depths, but the monster set still needs variety and adjustment. This commit reworks the monster set to remove the low-level worms and make the threat level appropriate for all depths and includes Swamp as an eligible placement branch. At pre-D:12 depths it's swamp worms only and in much more limited numbers, with tyrant leeches and a torpor snail showing up at later depths. By Spider and Swamp, a moths of wrath is thrown in with a chance for a couple additional moths of wrath and/or torpors, and most of the worms are tyrant leeches (since these play better with berserk than swamp worms). -------------------------------------------------------------------------------- e799247 | gammafunk | 2018-04-01 05:43:01 -0500 Some vault formatting cleanups -------------------------------------------------------------------------------- 300c91b | gammafunk | 2018-04-01 05:43:01 -0500 Fix and update a Swamp worm vault This vault got a bit broken due to some improper merging in e.g. d131b1cb, something that seems to have happened before and gotten reverted, only to get added again. It was placing normal level spawns where it tried to place specific monsters on a monsters list. It also placed ordinary worms since some of the original worm monsters it used got removed. This commit updates the vault to use the correct glyphs and to use appropriate numbers of swamp worms and tyrant leeches, also varying the number and type of monsters placed a bit. -------------------------------------------------------------------------------- 77ec1f3 | gammafunk | 2018-04-01 05:43:00 -0500 Clean up a swamp entry vault Simplify some glyph usage and thin out the worm population a little, since swamp worms are nastier now. -------------------------------------------------------------------------------- 83361d3 | gammafunk | 2018-04-01 05:43:00 -0500 Give swamp worms Harpoon Shot and further adjustments This commit gives swamp worms Harpoon shot, described in the previous commit and removes their submerging behaviour. Submerging gave swamp worms a trap-like effect that occurred only in water. However the frequency of swamp worms made water navigation more tedious to do in a way that minimizes risk, since many squares could harbor the unseen monster. The Harpoon Shot spell will let swamp worms sometimes move the player into unfavorable shallow water or collide them with deep water, but the player will now always see swamp worms ahead of time. This commit also reduces swamp worm frequency by 33%, giving that weight equally to tyrant leeches and alligators. -------------------------------------------------------------------------------- f80497b | gammafunk | 2018-04-01 05:43:00 -0500 Implement a Harpoon Shot monster spell and give it to iron giants From the spell description: "Fires a long and flexible barbed mass. The ensnared victim will either be pulled adjacent to the caster or collide with anything blocking the way." Harpoon Shot is a range 6 spell that fires a blockable shot which pulls the victim adjacent to the caster when it hits and does damage. It lets monsters reposition the player in range of melee and other spells and possibly deposits them in less favorable terrain like shallow water. Similar to the idea of the old throwing attack previously used by iron giants (and octopode crushers before that), but without repeatedly putting players attempting melee out of melee range. Casters won't use this spell on adjacent targets, nor will they pull victims through or to inhabitable squares or intermediate actors. Instead said squares cause a collision in the same way Force Lance and Draconian Ice breath do (e.g. "You violently stop moving!"), where the victim takes collision damage and further movement ceases. Iron giants now have this spell and have their overall casting frequency reduced so they don't cast more than 50% of the time, putting them more in line with other monsters that have strong melee as well as spells. The spell does relatively light damage (2d17 on iron giants) and does require damage to perform the pull effect, but has relatively good accuracy. -------------------------------------------------------------------------------- efa7288 | gammafunk | 2018-04-01 05:43:00 -0500 Remove copy-and-pasted comments The comments weren't needed, since the beams in question would have had these console colors regardless of the monsters casting. -------------------------------------------------------------------------------- 7905ed6 | gammafunk | 2018-04-01 05:43:00 -0500 Refactor methods related to actor knock-back Move the is_stationary() actor check done in the knockback_actor() method to the can_knockback() method, and have the latter take a ref instead of a pointer. Also update comments accordingly. -------------------------------------------------------------------------------- 2b15929 | Aidan Holm | 2018-03-30 21:36:49 +0800 Fix mousewheel scrolling being reversed vertically SDL 2.0 has the origin in the bottom-left. -------------------------------------------------------------------------------- 7e9e52a | Aidan Holm | 2018-03-30 21:36:47 +0800 Remove unused shopping list code -------------------------------------------------------------------------------- d21a89c | advil | 2018-03-27 22:34:16 -0400 Don't crash after stash search help with messages_at_top=true This probably fixes some other obscure crash possibilities; basically, redraw_screen would leave the cursor region as GOTO_MLIST if `messages_on_top` was set to true, but GOTO_MSG if false (the default). Code that relied on the default behavior would likely crash on a screen write out of bounds, because GOTO_MLIST isn't very big. Exiting out of help screens to a prompt is a likely candidate in general. Probably redraw_screen shouldn't even be able to change region, because side-effects are bad (and probably region shouldn't be bad global state, for that matter), but I have no doubt that there is code that implicitly relies on this. -------------------------------------------------------------------------------- c4e68a0 | Chris Campbell | 2018-03-27 19:44:51 +0100 Let equip_unequip work on weapons (xbon) And fix the options_guide description for it being inaccurate. -------------------------------------------------------------------------------- 4a852b3 | Alex Jurkiewicz | 2018-03-26 10:05:12 -0400 Update chequers_ecumenical_altar_grove * Remove all potentially disconnected areas (every - is adjacent to a ., which should guarantee connectivity). * For double safety, mark potentially disconnected areas as no_tele_into * Reduce the frequency of dead trees * Remove replacement of trees with crystal/rock -------------------------------------------------------------------------------- 4c9dbd0 | advil | 2018-03-26 10:01:35 -0400 Fix prefix behavior for FONTDIR (11430 / sterilizedmilk) -------------------------------------------------------------------------------- f0fe05c | Chris Campbell | 2018-03-25 18:50:02 +0100 Recolour floors in skrybe_limestone_x Since yellow floor looks the same as a monster halo in console unless manually examined. -------------------------------------------------------------------------------- 82e80c5 | gammafunk | 2018-03-24 23:53:44 -0500 A decor vault from Skyrbe (#11384) For Dungeon and Depths. Only changes from the original submission are a more appropriate vault name and slightly cleaned up syntax. -------------------------------------------------------------------------------- 43f9854 | Aidan Holm | 2018-03-25 10:50:25 +0800 Fix door exclusion info leak (Etesian, #10966) -------------------------------------------------------------------------------- 92d99f3 | Chris Campbell | 2018-03-24 17:59:25 +0000 Allow MP-powered wands to fire with 0 MP, don't consider it a bad mut With less than 3 MP, the power bonus is reduced accordingly while still using any available MP. Since wands of healing/hasting/teleportation no longer exist, wands of digging are the only wand that gains no benefit from it so it's much closer to a wild magic-style double-edged mutation. -------------------------------------------------------------------------------- 7d43e34 | Chris Campbell | 2018-03-24 17:58:44 +0000 Allow all forms to use wands All forms could already use most other evoked items - simplify the wide range of form-by-form restrictions by letting them all use wands too. -------------------------------------------------------------------------------- 822b61b | advil | 2018-03-24 12:59:16 -0400 Fix the ash autotravel/autoexplore bug (6503 etc) The problem was that sensed monsters would be immediately marked as MTRAV_KNOWN_UNREACHABLE, but in _mons_has_path_to_player this value was effectively used as a cache to decide whether to recalculate the path to the player. If set, the path would never be recalculated for a sleeping monster, and this function would always return false. There were a bunch of special cases that avoided this issue making it harder to diagnose (there's a hard check for a 1 tile distance that skips pathfinding altogether, if the monster wakes the path gets recalculated, and monsters with known ranged attacks that are visible ignore the pathfinding result, maybe others). This bug also impacted boots of the assassin (e.g. 11322). -------------------------------------------------------------------------------- 6c1b826 | gammafunk | 2018-03-24 03:21:29 -0500 Tweak the layout of a transporter vault Add some doors to the arrival area of gammafunk_sealed_library so that the player will be more likely to need to move out of this room. -------------------------------------------------------------------------------- e3b9353 | gammafunk | 2018-03-24 02:00:43 -0500 Nerf the Hellbinder wizard lab some Recent changes made the wave of demons too strong, mostly due to there being too many tier-2: hellbinder wizlab is ridiculous now, basically hellion island... Reduce the monster count, mostly by removing tier-2 from the chambers near the entrance, and reducing them a bit in the other chambers as well. This is still a tough wizlab that can generates about one hellion and one tormentor per level and can generate more of those, but it's not insane now. -------------------------------------------------------------------------------- c9362ec | Aidan Holm | 2018-03-23 22:37:02 +0800 Fix crash when updating minimap for out-of-map tiles -------------------------------------------------------------------------------- 0df9d5f | Chris Campbell | 2018-03-22 22:14:46 +0000 Don't Gozag bribe summons (#11149) -------------------------------------------------------------------------------- 1df535d | Chris Campbell | 2018-03-22 22:08:09 +0000 Fix messaging for unmelding guardian spirit (#11408) With permanent mutation-based guardian spirit (either as a VS or a Demonspawn) there's no need to print any message when unmelding gear grants a level of guardian spirit. -------------------------------------------------------------------------------- de484de | Chris Campbell | 2018-03-22 21:56:55 +0000 Don't pick up duplicate amulets of the acrobat (#11383) -------------------------------------------------------------------------------- 09c32aa | Chris Campbell | 2018-03-22 20:30:17 +0000 Fix Sap Magic not properly expiring on Felid death (#11354) Along with a couple of WJC attributes that shouldn't persist through death. -------------------------------------------------------------------------------- 3d944cd | Chris Campbell | 2018-03-22 20:02:03 +0000 Allow training evocations with the ratskin cloak Since it has an active ability like the cloak of the Thief. -------------------------------------------------------------------------------- 9b9f04d | Chris Campbell | 2018-03-22 19:36:42 +0000 Add no_tele_into to some closets in grated_community_mu (#11423) -------------------------------------------------------------------------------- f559e6e | Chris Campbell | 2018-03-21 20:53:06 +0000 Make Ozocubu's Armour expire immediately on movement Granting a level of ponderous wasn't a very effective downside and the spell remained extremely widely desirable. Having it break immediately when moving lets it remain strong when cast directly in combat, but completely prevents it from being useful to have active when out of combat. -------------------------------------------------------------------------------- 647f2b0 | Chris Campbell | 2018-03-21 19:38:26 +0000 Fix high-power Dispersal working through walls Other uses of apply_monsters_around_square are all radius 1, so this was only broken for Dispersal once it gained an increased range with spellpower. -------------------------------------------------------------------------------- 99d1f74 | Chris Campbell | 2018-03-19 16:20:43 +0000 Update orb of destruction description (#11419) -------------------------------------------------------------------------------- 1871b15 | advil | 2018-03-17 21:24:05 -0400 Try updating sdl2 contrib again for xinput errors This should have happened in 17e5181afb10e1dfc8 but it apparently didn't take. -------------------------------------------------------------------------------- 9a6c51a | dplusplus | 2018-03-18 00:26:48 +0900 fix help; "stick" tag is not available in current version -------------------------------------------------------------------------------- dd34a7d | Aidan Holm | 2018-03-17 07:21:33 +0800 Fix missing derived undead tile cases The only remaining one is for octopodes, but the spectral tile looks decent and there's no good alternative simulacrum tile, so I've left it at the default for now. -------------------------------------------------------------------------------- 2e20325 | Aidan Holm | 2018-03-17 04:33:36 +0800 Add undead kraken tentacle tiles (Midn8, #11410) To track which tentacles are undead tentacles, we set base_type to the undead type, instead of type; this is *inverted* compared to all other monsters (not great), but requires only minimal changes to the tentacle handling code in tilepick.cc; using the reverse (correct) order requires more extensive refactorings. Adding multiple first/last-tentacle-tile delimiters isn't great, but is necessary for the easy conversion from normal- to undead-tentacle tiles. All of these tiles were automatically generated from the normal kraken tentacle tiles and could definitely be improved. -------------------------------------------------------------------------------- 69bf1f3 | Aidan Holm | 2018-03-16 04:24:09 +0800 Fix minimap being clipped (Malevolent, #11414) update_minimap() in turn expands a clip rectangle in tilereg-map.cc to include the coord. This was not previously being expanded to include the map border, causing the reported issue. -------------------------------------------------------------------------------- fa10ee1 | Nikolai Lavsky | 2018-03-15 21:47:09 +0800 Update dream sheep description Since dream sheep fires are no longer a thing. -------------------------------------------------------------------------------- 8f80174 | Aidan Holm | 2018-03-15 05:14:56 +0800 Fix some weird magic-mapping tile choices The boundary feature checks make the border tiles blend in with the floor/wall. The vaults walls special-case applies to all DCHAR_WALL features, instead of just DNGN_STONE_WALL, because some areas within the vaults have rock walls, which should be shown with the same tile. -------------------------------------------------------------------------------- d774a3c | Aidan Holm | 2018-03-15 04:08:56 +0800 Handle shaft-self and hop in _check_ability_possible() This causes the corresponding menu entries and sidebar tiles to be correctly greyed out when these abilities are not possible. -------------------------------------------------------------------------------- 660f3e5 | Aidan Holm | 2018-03-15 02:52:51 +0800 Use quadruped skeleton for bears and yaks -------------------------------------------------------------------------------- b8b0824 | advil | 2018-03-14 10:59:29 -0400 Don't flush messages (potentially switching regions) on spell search Mostly a problem in wizmode, I think, but basically, cancellable_get_line isn't designed to be used outside of the messages pane. This commit does involve a bit of code duplication, and when I have more time I'd like to convert Menu::title_prompt to use an EditableTextItem, which would involve better abstraction. -------------------------------------------------------------------------------- f8199ec | Chris Campbell | 2018-03-12 23:47:47 +0000 Fix shopping lists always displaying "0 thing" (#11409) -------------------------------------------------------------------------------- 3d7ae58 | gammafunk | 2018-03-12 03:55:16 -0500 Prevent monsters from picking up a loot item in a vault The merfolk impaler would sometimes pick up a weapon loot item and thus lose its ability to reach attack the player across the lava square. Make the item into a superb_item so we can mark the item as no_pickup to prevent this. Previously it used an "acquire any" item, which currently can't take the "no_pickup" tag, and we'd like to avoid using these loot items outside of troves in the first place. -------------------------------------------------------------------------------- 8181cae | gammafunk | 2018-03-12 03:41:39 -0500 Tweak monsters and placement for a float vault (mikee) Allow gammafunk_mikee_crab_dinner to place on D:10- instead of just D:13-, since the vault uses the same threats as it does in Lair, which are not so bad compared to what 8 and 9 glyph vault monsters often generate around D:10. In Depths, use Flayed Ghosts instead of Titans, since although the former are a lot flimsier than what they replace, the Flay effect lowers player HP quickly enough that players might end up actually dying in the vault. In Zot, replace Klowns and Draconians in the vault with Curse Toes for similar reasons. -------------------------------------------------------------------------------- c000056 | Chris Campbell | 2018-03-09 19:30:54 +0000 Reformat some lines For better coding convention-ness and ease of reading. -------------------------------------------------------------------------------- ef6b427 | Alan Malloy | 2018-03-09 11:28:03 -0800 Remove erroneous error message in ability menu Just looking at a menu with Evoke Berserk Rage as an option doesn't always mean you want to go berserk, so you shouldn't get a message telling you you can't. -------------------------------------------------------------------------------- a231a93 | Chris Campbell | 2018-03-09 18:58:30 +0000 Adjust some weapon randart names Remove a couple of overly silly and/or ungrammatical potential names. -------------------------------------------------------------------------------- 1cc83ef | advil | 2018-03-08 09:17:00 -0500 Simplify -------------------------------------------------------------------------------- 10657f7 | advil | 2018-03-08 08:54:42 -0500 Only send tiles exit reason in game_ended on crash (wheals) -------------------------------------------------------------------------------- 5fdf0d7 | Doesnt | 2018-03-07 22:30:27 +0800 Add auto_hide_spells option -------------------------------------------------------------------------------- 0d8bc90 | Alan Malloy | 2018-03-05 17:04:22 -0800 Clarify explanatory text for Tomb card (Yermak) -------------------------------------------------------------------------------- f70c721 | Alan Malloy | 2018-03-05 16:59:19 -0800 Simplify code for changing pluses on mace of Variability. (#716) -------------------------------------------------------------------------------- ab157ee | Alan Malloy | 2018-03-05 13:03:21 -0800 Add NormalPerson7 to CREDITS.txt -------------------------------------------------------------------------------- 9649ee7 | NormalPerson7 | 2018-03-05 12:48:17 -0800 Randomise the placement of the rune in dis_grunt (#715) Randomise the placement of the rune in dis_grunt Previously, the rune would be guaranteed to spawn in one of the two corners nearest to the entrance, making it a trivial exercise to steal the rune with LRD. It functioned as a hoax for new players, because it looks like the rune would place in the central structure. Now, the rune will place in this central structure as expected 20% of the time, to make stealing the rune through LRD on the outer walls not guaranteed. The other 80% of the time it places in one of the four corners, retaining the hoax but also making stealing slightly less trivial. Also add one additional Hell Sentinel to the end vault, location randomised just like the other monsters. It only had 1 Hell Sentinel previously, which was lackluster compared to the boss rooms of other Dis:$ vaults. -------------------------------------------------------------------------------- f0767a5 | Aidan Holm | 2018-03-06 04:03:28 +0800 Revert "Fix wind-blast not applying location effects (advil, Beargit, rangerofthewest, #11253)" This reverts commit 66e28abd87814127e8ae3a727caeabbe4bf002e6. -------------------------------------------------------------------------------- 66e28ab | Aidan Holm | 2018-03-06 03:55:11 +0800 Fix wind-blast not applying location effects (advil, Beargit, rangerofthewest, #11253) Moving actors is postponed in order to print messages in the right order. apply_location_effects() takes care of monsters being blown onto traps (the original issue) and should handle other conditions that weren't previously handled, such as merfolk transformation. -------------------------------------------------------------------------------- dd11e71 | advil | 2018-03-04 21:01:06 -0500 Make phrasing less awkward I didn't proofread this one enough.. -------------------------------------------------------------------------------- 34c0b7b | advil | 2018-03-04 15:21:54 -0500 Cleanups to game restarting and the main menu The main point of this change is to remove a few more die/fail/end calls that boot the player from the main menu regardless of their settings (on exiting from an upgrade prompt, or on an incompatible save), making it act more like a real menu. In order to get this to work right, I needed to do a bunch of other things: * regularize how error/info messages are shown in the main menu (always in the bottom line, where tooltip-type information is shown). It's a bit hacky, but less so than before. * cleaned up an ad hoc message for bad names in the main menu. * support passing a message to be shown in this spot on game_ended. The main use case is game_exit::abort. * improve messages for upgrade prompts * make clearer a previously surreptitious static variable in _show_startup_menu * do a better job returning to the main menu position on restart, to preserve the illusion that nothing has changed. (I couldn't figure out a great way to do this without adding even more global state, unfortunately.) Overall, the fact that we return to the main menu by more or less *restarting the entire program* remains just as insane as it was before. -------------------------------------------------------------------------------- e769cdc | advil | 2018-03-04 15:21:53 -0500 Tell player if monster can never be recited to (m-aigner / 10416) This adapts m-aigner's code from https://github.com/crawl/crawl/pull/379 The previous messaging seemed to have been actively wrong (the HD calculation is different than what seems to happen in god-abil.cc), so I decided it was time to finally merge a version of this, fixing the crash discussed in the PR thread. The new version still only checks particular monsters, so as discussed in the PR thread, something that looks at a monster_info might be desireable. In principle this more accurate info can leak information about a monster's spellset, but for that to happen, I think there would have to be something like a monster with multiple spellsets and subhuman intelligence, which as far as I can tell doesn't exist right now. Calculating over monster_info might deal with that case as well, if it were to ever come about. Resolves #379 -------------------------------------------------------------------------------- 5284510 | Aidan Holm | 2018-03-05 00:50:09 +0800 Add note about tomb walls' early collapse (advil) -------------------------------------------------------------------------------- 2e530e8 | Aidan Holm | 2018-03-05 00:41:21 +0800 Make entombment more consistent (NormalPerson7, #11405) This commit simplifies the set of features that the tomb card effect will convert to a wall. The feat_is_door() check allows closed doors to be filled; before this commit, they were left untouched and could be opened. -------------------------------------------------------------------------------- af95ca0 | Andy Roche | 2018-03-03 13:02:48 -0500 Fix grammar of MUT_SLOW_METABOLISM. -------------------------------------------------------------------------------- f9d0ce5 | Aidan Holm | 2018-03-02 13:46:58 +0800 Fix ctrl-x refresh issue (gammafunk) -------------------------------------------------------------------------------- cace5d2 | wheals | 2018-02-28 11:52:09 -0500 Clarify Lugonu disto protection (Fingolfin). -------------------------------------------------------------------------------- 072727e | wheals | 2018-02-28 11:41:08 -0500 Identify the starting book (Dynast). -------------------------------------------------------------------------------- 848dc5c | advil | 2018-02-28 11:11:19 -0500 Don't allow repeating shop actions with ` Now that this doesn't crash, the only use case we can find for this is expensive miskeys (I suspect the crashes were miskeys themselves). This also prevents repeats on altars, which I'm not sure matters. -------------------------------------------------------------------------------- c6edcda | advil | 2018-02-28 11:00:53 -0500 More consistently check for repeats in menu code This was causing a crash in shop code, which calls draw_more directly, because certain variables are only initialized if the menu has been drawn. For example, the following key sequence triggered it on any shop, ignoring spaces: > ! a ESC ESC ` -------------------------------------------------------------------------------- c8378ba | Aidan Holm | 2018-02-28 04:58:54 +0800 Fix oversized infestation tile (NormalPerson7, #11404) [skip ci] -------------------------------------------------------------------------------- bddf880 | Aidan Holm | 2018-02-22 23:21:27 +0800 Don't do client-side direction key wrangling The on-numpad keys (pgup/down, etc) were converted to arrow keys before they were sent to the server. This is unnecessary, since crawl maps these keys to the correct movement commands, and broke page up/down. This should not introduce any incompatibility with older versions of crawl: crawl began mapping these keys at e75f4e49b8d8, which is included in 0.5 and newer, which is before crawl supported webtiles. -------------------------------------------------------------------------------- dc04c06 | Alan Malloy | 2018-02-21 12:35:47 -0800 Prevent generating some grammatically incorrect randart names Notably, stuff like [GOD]'s [thing that's not a noun]. -------------------------------------------------------------------------------- 6acd07a | Alan Malloy | 2018-02-21 12:35:26 -0800 Fix up a number of comments in randart naming code Mostly this meant removing them, because they didn't say anything useful, but a couple just needed tidying up. -------------------------------------------------------------------------------- 58d4f8e | Alan Malloy | 2018-02-21 12:35:26 -0800 Move one particularly silly weapon name to the jokes section -------------------------------------------------------------------------------- 66ef5e3 | Alan Malloy | 2018-02-21 12:35:26 -0800 We should at least spell our silly words correctly -------------------------------------------------------------------------------- 4884353 | Aidan Holm | 2018-02-22 02:18:15 +0800 Fix memorise menu heading glitch A menu's items are only indented if at least one item has a tile. When switching between memorise-menu pages with zero and >1 spells listed (or vice-versa), the item indentation would change. This caused the subtitle to shift around. To fix this, we just ensure that tile indents are always used by giving this entry an invisible tile. -------------------------------------------------------------------------------- 1f6c355 | Aidan Holm | 2018-02-22 02:17:34 +0800 De-dup memorise menu paging text for local tiles -------------------------------------------------------------------------------- 539252a | advil | 2018-02-20 22:58:05 -0500 Unbrace / checkwhite -------------------------------------------------------------------------------- 54792a9 | advil | 2018-02-20 22:57:13 -0500 Don't let an undocumented texture setting affect fonts This is one of those commits where I'm not really sure what's going on, but it seems that we probably don't want to apply this gl texture filter setting (GL_LINEAR) to glyph textures. Specifically, this was (no idea why) causing local tiles colour_bars to not render properly, as reported by dolemite99 in: https://crawl.develz.org/tavern/viewtopic.php?f=9&t=25131 -------------------------------------------------------------------------------- d711f93 | Chris Campbell | 2018-02-20 15:58:44 +0000 Fix formatting on a help menu -------------------------------------------------------------------------------- 4386d7c | Chris Campbell | 2018-02-20 15:40:57 +0000 Mark PoG only temporarily useless when in Zot but without the orb (|amethyst) Since you could still leave and go elsewhere, so it should still be possible to memorise the spell. -------------------------------------------------------------------------------- be7b7cd | Chris Campbell | 2018-02-20 15:33:12 +0000 Improve spell library display and messaging Mark permanently useless spells as hidden by default, and show a count of hidden spells on the memorisation screen (the formatting here could be better, though). Also improve the messages when adding spells to the library to be less spammy. -------------------------------------------------------------------------------- 6ad8dc3 | Chris Campbell | 2018-02-20 15:30:37 +0000 Don't mark cloud spells as permanently useless under Still Winds -------------------------------------------------------------------------------- 97f78ea | Ian Caltabiano | 2018-02-20 14:05:09 +0000 Mark axes as a preferred weapon type for Ogres (#11391) -------------------------------------------------------------------------------- d1b7544 | Neil Moore | 2018-02-20 09:00:22 -0500 Remove Trog spellbook autopickup special-case. -------------------------------------------------------------------------------- 362d6f4 | Chris Campbell | 2018-02-20 13:55:10 +0000 Note the effect of Invo skill in Nemelex description (#11393) -------------------------------------------------------------------------------- 1b571ea | advil | 2018-02-19 19:38:53 -0500 Remove useless butchering, and improve butchery code With doors pushing items out of the way, there's basically[1] no reason to chop corpses that are entirely inedible for your species. This removes that possibility and accordingly simplifies the butchery interface. Because I tried to improve the messaging, things didn't get much shorter, but hopefully the situation is overall clearer. I also removed a goto. The interface could be even simpler, as there's very little practical reason to use 'n'. 1 There are rare corner cases where a corpse may still jam a door. I think these are rare enough to ignore entirely, but if someone disagrees, the best way to handle it with something like the behavior before this commit I think would be to add a * command to the butchery menu that allows chopping them, similar to many inventory commands, rather than have them show up in the basic butchery list. Alternatively, one could just destroy the corpses. I've coded up a version that does this if anyone wants, but it has weird interactions with god conducts so I paused. -------------------------------------------------------------------------------- 17e5181 | advil | 2018-02-19 19:25:55 -0500 Update sdl2 contrib (maybe fixing XINPUT errors on msys2) -------------------------------------------------------------------------------- 59181c3 | wheals | 2018-02-19 18:56:16 -0500 Don't request books for troves (#11395). -------------------------------------------------------------------------------- 3692b99 | Aidan Holm | 2018-02-19 16:27:47 +0800 Fix ability descriptions not visible on webtiles (droogie, #11390) -------------------------------------------------------------------------------- ae599e4 | Aidan Holm | 2018-02-19 16:27:47 +0800 Colourise the ability menu -------------------------------------------------------------------------------- c2f0fb8 | Aidan Holm | 2018-02-19 16:27:47 +0800 Add _check_ability_dangerous() -------------------------------------------------------------------------------- c850c1e | Aidan Holm | 2018-02-19 16:27:47 +0800 Move ability checks to _check_ability_possible() Among other things this fixes a bug where the SDL tiles ability menu was not correctly indicating that abilities weren't possible. -------------------------------------------------------------------------------- 8cf3520 | Muffindrake | 2018-02-18 03:31:59 -0800 Iron out typo in Zephyr's description -------------------------------------------------------------------------------- 0f5d773 | wheals | 2018-02-17 21:04:51 -0500 Fix Tiles compile/warnings. -------------------------------------------------------------------------------- f4362f2 | wheals | 2018-02-17 21:04:51 -0500 Fix typo/reword. -------------------------------------------------------------------------------- 87fe873 | wheals | 2018-02-17 21:04:51 -0500 Allow searching for spells in the memorise menu. The search matches either on spell names or spell types (so you can see all the translocation spells at a glance, for instance). The extra newline was removed from menu.js since it seems the browser adds its own newline (tested this with the \ menu and it works the same as before). -------------------------------------------------------------------------------- 2cf55e6 | wheals | 2018-02-17 21:04:51 -0500 Remove references to starting books from background descriptions. Better writing very welcome. -------------------------------------------------------------------------------- 692369f | wheals | 2018-02-17 21:04:51 -0500 Show unmemorisable spells in the memorise menu. I wasn't convinced at first this was a good idea, but people pointed out that there ought to be some feedback about what happens to spells that you pick up that you can't memorise, and why you can't memorise them. -------------------------------------------------------------------------------- b0bc94e | wheals | 2018-02-17 21:04:51 -0500 Remove memorising spells from a book by clicking on it. With goldified books, I'm not sure this is ever useful. If you've identified a book, its contents are in your spell library. The one exception might be a book from a store that couldn't fit into your inventory but that's a really small edge case. -------------------------------------------------------------------------------- b0e1f0f | wheals | 2018-02-17 21:04:51 -0500 Prevent some harmless(?) JS errors. -------------------------------------------------------------------------------- b74d8c8 | wheals | 2018-02-17 21:04:51 -0500 Remove some other vestiges. -------------------------------------------------------------------------------- f475dab | wheals | 2018-02-17 21:04:51 -0500 Fix a webtiles bug with using the mouse on menu entries. This would stop working after the first time the entry list was refreshed; previously this affected only the shopping menu but it also affected the memorisation menu as well. -------------------------------------------------------------------------------- b1bc8ad | wheals | 2018-02-17 21:04:51 -0500 Allow hiding spells from the main screen of the memorisation menu. In every game the player runs into tons of spells they have no interest in memorising. Combined with the new spell library, this would tend to lead to tons of clutter. -------------------------------------------------------------------------------- fee09f9 | wheals | 2018-02-17 21:04:51 -0500 Exterminate you.had_book too. -------------------------------------------------------------------------------- e3f13c2 | Doesnt | 2018-02-17 21:04:51 -0500 Don't let Vehumet offer spells that are already in your library -------------------------------------------------------------------------------- 751bf6f | Doesnt | 2018-02-17 21:04:51 -0500 Exterminate seen_spells. Now redundant unless a mechanism is added to make spells leave the library (unlikely). -------------------------------------------------------------------------------- a98daa0 | Doesnt | 2018-02-17 21:04:51 -0500 Replace failed book acquirements with manual acquirements. Except for Xom and Sif gifts. -------------------------------------------------------------------------------- 3921d5a | Doesnt | 2018-02-17 21:04:51 -0500 Mark books with only unlearnable spells as useless -------------------------------------------------------------------------------- f64ed86 | Doesnt | 2018-02-17 21:04:51 -0500 Remove book burning from the tutorial -------------------------------------------------------------------------------- 4c6852c | Doesnt | 2018-02-17 21:04:51 -0500 Remove Trog's Burn Spellbooks ability. Spellbooks are not marked as useless so as to keep autopickup on, since the player may switch gods still. -------------------------------------------------------------------------------- 8827bed | Doesnt | 2018-02-17 21:04:51 -0500 Mark books with no new spells as useless -------------------------------------------------------------------------------- 5f84044 | Doesnt | 2018-02-17 21:04:51 -0500 Implement spell library -------------------------------------------------------------------------------- 464ede7 | Corin Buchanan-Howland | 2018-02-17 15:28:59 -0500 Give monster minotaurs armor and javelins This toughens them up a bit and makes them harder to kite. This is intended primarily as a labyrinth challenge buff, since minotaurs are otherwise only spawned by a few vaults or shape-shifted into. -------------------------------------------------------------------------------- 879740d | Chris Campbell | 2018-02-17 16:29:22 +0000 Make some accuracy penalties consistent for aux unarmed There are still a bunch of weird inconsistencies and it'd be good to properly de-duplicate this code with the regular to_hit calculations. -------------------------------------------------------------------------------- 430cd93 | Chris Campbell | 2018-02-17 16:29:22 +0000 Generalise starvation penalty checks De-duplicates a lot of checks for starving players that don't apply to vampires or ghouls (such as inability to use abilities/spells). Has a couple of minor gameplay effects, with starving ghouls no longer having a penalty to accuracy or damage. -------------------------------------------------------------------------------- 5403bb0 | Chris Campbell | 2018-02-17 16:29:22 +0000 Fix bloodless Vampires having their accuracy penalised -------------------------------------------------------------------------------- f9081d1 | Chris Campbell | 2018-02-17 16:29:22 +0000 Turn res_wind into res_tornado Wind doesn't make much sense as a general resistance, since its main effect is just making a tiny selection of enemies be unexpectedly immune to airstrike and Qazlal wind attacks. It's more reasonable as just tornado immunity, since almost everything that has it casts tornado innately (with Sojobo still being a weird exception due to her air elemental band). -------------------------------------------------------------------------------- c748515 | Chris Campbell | 2018-02-17 16:29:22 +0000 Fix dream sheep genus using a removed monster To avoid problems on save compat break. -------------------------------------------------------------------------------- 1d1b100 | Chris Campbell | 2018-02-17 16:29:22 +0000 Remove dream sheep fires The special-cased sticky flame mechanic isn't really justifiable with sheep now being a real enemy that's intended to be threatening instead of mostly just a joke. -------------------------------------------------------------------------------- 4ac3794 | Aidan Holm | 2018-02-17 22:42:13 +0800 Fix stash menu redraw issues ... and clean up some other odds and ends. -------------------------------------------------------------------------------- ee22f27 | Aidan Holm | 2018-02-17 02:50:44 +0800 Fix some local tiles menu bugs (Etesian, #11389) -------------------------------------------------------------------------------- 9299d87 | Aidan Holm | 2018-02-16 21:44:15 +0800 Fix sending webtiles messages in wrong order -------------------------------------------------------------------------------- 4828832 | Aidan Holm | 2018-02-16 20:04:50 +0800 Add on_single_selection() hook -------------------------------------------------------------------------------- 6a83056 | Aidan Holm | 2018-02-16 20:04:50 +0800 Fix titles persisting between menus -------------------------------------------------------------------------------- 6ffc940 | Chris Campbell | 2018-02-15 19:23:17 +0000 Revert monster minotaur speed and adjust other stats Monster versions of player species are a case where the symmetry should be at least reasonably close, so breaking it substantially by having the monster version be fast isn't a good way of buffing monster minotaurs. Instead increase their health, defenses and HD slightly. -------------------------------------------------------------------------------- 8d23802 | Aidan Holm | 2018-02-15 16:11:28 +0800 Fix use of incorrect tile variants -------------------------------------------------------------------------------- 9b7402f | Aidan Holm | 2018-02-15 15:47:09 +0800 Allow lowercase letters from choose_stat_gain hook -------------------------------------------------------------------------------- 981819d | Aidan Holm | 2018-02-15 15:31:59 +0800 Fix pixel-perfect rect drawing -------------------------------------------------------------------------------- d686732 | Aidan Holm | 2018-02-15 15:01:06 +0800 Seed domino generation with branch:depth Domino generation was randomized for every level load, which caused floor tiles using dominos (only crypt afaik) to vary when reloading the level: going up and down stairs, or saving and reloading the game. Now, the rng is seeded with the current branch and depth as well as the game seed, which is marshalled in saves. Side note: that dominoes.Generate() call takes up most of level load time, even though most levels don't use domino tiles.. -------------------------------------------------------------------------------- 55dd942 | Aidan Holm | 2018-02-15 15:00:00 +0800 Replace you.game_seeds[] with you.game_seed This seed is currently only used for generating tile difficulties for passive mapping, so there's only one seed in the array anyway. More importantly, there's no logical reason for different parts of crawl to use different seeds; this is used to seed domain-specific RNGs, and there's no risk of these RNGs interfering with each other. -------------------------------------------------------------------------------- 3d3d9be | Aidan Holm | 2018-02-15 13:30:15 +0800 Remove useless use of std::map -------------------------------------------------------------------------------- e330310 | Alan Malloy | 2018-02-14 12:33:15 -0800 Add a wizard command to list keys with no assigned command As of the time of this commit, the list of free keys in the main area of a US-English keyboard is pretty short: ] - ^M p ^T ^V -------------------------------------------------------------------------------- 7362139 | Aidan Holm | 2018-02-14 16:30:35 +0800 Fix broken colour_bar rendering on local tiles -------------------------------------------------------------------------------- 9e71ff9 | Aidan Holm | 2018-02-14 13:33:57 +0800 Simplify font atlas lookup LRU management The main purpose of this commit is to improve code clarity. The previous map container implementation and the replacement vector-based implementation perform roughly the same. Should it become necessary (for when offline crawl gets serious about i18n), this new version is also much easier to optimize: - could store index into atlas in glyph table, to remove iteration - could remove LRU vector and add atlas entry hit counters, moving expensive path to atlas eviction. -------------------------------------------------------------------------------- 11d8d7a | Aidan Holm | 2018-02-14 13:33:57 +0800 Don't call map_unicode() for non-renderable glyphs A recent test showed that around 85% of glyphs that hit map_unicode() are spaces. These spaces are coming from the message region and other text regions; they appear to send the entire line to the renderer, not just the text portion. -------------------------------------------------------------------------------- b22368a | wheals | 2018-02-13 15:39:43 -0500 Remove an unnecessary member from ShopMenu. -------------------------------------------------------------------------------- ef5cdb2 | wheals | 2018-02-13 15:25:13 -0500 Move some shop menu code into Menu. This will allow using something similar for the upcoming new memorise menu without code duplication. -------------------------------------------------------------------------------- b5258fd | Aidan Holm | 2018-02-13 15:03:10 +0800 Remove list_commands() redraw parameter -------------------------------------------------------------------------------- e53cf38 | Aidan Holm | 2018-02-13 15:03:10 +0800 Use single column for menus if there's enough space (advil) -------------------------------------------------------------------------------- 11ddb1a | Aidan Holm | 2018-02-13 15:03:10 +0800 Add section dividing line (advil) -------------------------------------------------------------------------------- 368cd01 | Aidan Holm | 2018-02-13 15:03:10 +0800 Move menu title rendering to mdisplay This refactor moves all menu title rendering from the CRT layer to the mdisplay backend, and simplifies a number of interfaces. - Title suffixes have been removed. Instead, code that wishes to update the title dynamically can override calc_title(), which is called whenever the title is about to be changed. - On local tiles only, filtering menus now uses a custom line reader that overrides the displayed title, since the CRT line reader can no longer be used. Using the existing line reader on console and webtiles is fine, and has been left alone. The title is overloaded in this way because it ensures that the filter UI correctly handles resize events: having multiple UI layers try to handle redraw is almost impossible to make work. - update_title() and write_title() have been merged with draw_title() -------------------------------------------------------------------------------- 6e0fa9b | Aidan Holm | 2018-02-13 15:03:10 +0800 Remove Menu text-only option This commit removes the text_only constructor option, and always uses MenuDisplayTile on local tiles, and MenuDisplayText on everything else. (Except for formatted_scrollers). MenuRegion already supports rendering menus without tile icons (when tile_menu_icons = false), so this commit simply adds an additional check that the menu entries have tiles. This removes a whole host of conditional checks, and will allow removal of CRT code on local tiles. -------------------------------------------------------------------------------- 61877e1 | Aidan Holm | 2018-02-13 15:03:10 +0800 2-col tile menus: wrap horizontally and support line scrolling This commit re-adds support for scrolling MenuDisplayTile menus by line, and does a fair amount of general MenuRegion refactoring as well: - Menus now limit the height of each page to ensure that <= 52 items can be shown on a page: this greatly simplifies pagination. In practice, this is slightly shorter than a full 1080p screen. - MenuRegion::place_buffers() has been split into two functions that do layout and pack buffers respectively, rather than having one function that does both. Non-ideal bits: - Scrolling state for tile menus is now mostly located in tilereg-menu.cc, instead of menu.cc: scrolling requires knowledge of the menu item sizes and screen positions, so the MenuDisplayTile scrolling methods mostly proxy MenuRegion methods. - set_menu_display() is used to detect switching between menus. - this predates this commit, but the need to check entry.valid all over the place makes this code pretty bug-prone. -------------------------------------------------------------------------------- c7e3d39 | Aidan Holm | 2018-02-13 15:03:10 +0800 Remove limit on lookup-help results length Menus now automatically handle duplicated hotkeys, so we don't need to limit the length ourselves. Also made the menu use two columns on local tiles. -------------------------------------------------------------------------------- 136611b | Aidan Holm | 2018-02-13 15:03:10 +0800 Refactor Menu scrolling into MenuDisplay This commit moves the scrolling handling for Menus into the MenuDisplay class. This is necessary because the menu itself does not have the layout information necessary to scroll or render the current page of items, only the renderer (MenuDisplay) does. Below, "Tile menu" means a menu using a MenuDisplayTile instance; likewise "Text menu" means a menu using a MenuDisplayText instance. There are a number of other changes+improvements this commit makes: - the two MenuDisplay derived classes have been moved into menu.cc - an MF_USE_TWO_COLUMNS flag has been added for TILES_LOCAL builds - Tile menus force a page break before a duplicate hotkey - Text menus limit their pagesize to 52 rows if duplicate hotkeys are detected. This approach keeps the Text menu scrolling/layout code simple. - showing the --more-- line now works correctly with menus with multiple parts delimited by MEL_END_OF_SECTION - scrolling formatted_scrollers with home/end keys now stays within the current section. This breaks the ? help menu, but I've added a small hack for that. It's still broken on webtiles, but it was like that alrady. Removal of functionality: - Tiles menus can no longer be scrolled by line, as the notion of scrolling by line does not work well when combined with two-column layouts. Scrolling to an item scrolls to the page containing that item. -------------------------------------------------------------------------------- 6a01d73 | Aidan Holm | 2018-02-13 15:03:10 +0800 Remove column_compoer set_pagesize() This was used to add separator newlines to composed text, except at page boundaries. This doesn't work any more because the page size can change on resize, so we just show separator newlines either way. -------------------------------------------------------------------------------- d84e81a | Aidan Holm | 2018-02-13 15:03:10 +0800 Remove unused menu.f_drawitem hook -------------------------------------------------------------------------------- 717c7b6 | Aidan Holm | 2018-02-13 15:03:10 +0800 Explicitly set MF_SINGLESELECT on describe menu -------------------------------------------------------------------------------- 6b2ca4f | Aidan Holm | 2018-02-13 15:03:10 +0800 Assert that menus have a valid selection flag -------------------------------------------------------------------------------- e39abd2 | Aidan Holm | 2018-02-13 15:03:10 +0800 Remove menu.set_maxpagesize interface This was used to prevent hotkeys from being reused on a single page. This changes the behaviour to automatically limit the number of items shown on a single page if any of them are selectable. -------------------------------------------------------------------------------- 5351223 | Alan Malloy | 2018-02-12 16:50:55 -0800 Fix Dowan's reaction to Duvessa dying far away (minmay) Dowan is really more of a moper than a rager. (I accidentally made too broad a change in bf6022e) -------------------------------------------------------------------------------- 89cf10f | advil | 2018-02-12 14:16:27 -0500 Workaround for travis erroring related to ppa.launchpad.net These errors lead to an out-of-date package list being used, which then causes the build to error relating to the libsdl2-dev package. The timeout may need further tweaking, and hopefully there'll be a point where travis will fix this, but this basically works for me in my fork, so I'm going to try adding it to master. See ongoing discussion in the following issue: https://github.com/travis-ci/travis-ci/issues/9112#issuecomment-364629682 -------------------------------------------------------------------------------- 55045ed | Aidan Holm | 2018-02-12 22:58:30 +0800 Fix alignment for ability & spell menu headings -------------------------------------------------------------------------------- 4451672 | Aidan Holm | 2018-02-12 20:49:48 +0800 Check floor items for digit inscriptions The main use-case is reading known scrolls and quaffing known potions from the ground without switching menu sections with , -------------------------------------------------------------------------------- 33bf127 | advil | 2018-02-11 14:25:15 -0500 Have shock serpent retaliation check rElec rElec for the retaliation fineff has apparently not been checked, at all, either for monster or player attackers, since 494c5fece274. For player attackers, this change is a major nerf to shock serpents if you have rElec, so given that they have always been this way, they may need some further balance adjustments to make them not completely trivialized by rElec. This change also prevents shock serpent recursion (pointed out as a bug by u/eazyirl, https://www.reddit.com/r/dcss/comments/7wtmkr/shock_serpent_recursion_has_dungeo n_science_gone/, since shock serpents have rElec+++.) I also added an expose_to_element call to ensure that retaliation triggers qazlal elemental adaptation (also wasn't happening). -------------------------------------------------------------------------------- 198051c | Aidan Holm | 2018-02-10 13:08:49 +0800 Add WME_MOUSEWHEEL The main benefit this brings (apart from code tidiness) is the ability to check whether the next event is a mousewheel event, which will allow processing multiple mousewheel events without redrawing the screen. -------------------------------------------------------------------------------- cc81d7a | Aidan Holm | 2018-02-10 12:39:31 +0800 Use travel keys for ?/B menu entries -------------------------------------------------------------------------------- 7ce444f | Tomas Krag Hansen | 2018-02-08 12:28:21 -0500 Putting the honeycombs back in the bee hives. -------------------------------------------------------------------------------- f028f7a | advil | 2018-02-08 11:10:36 -0500 Show >0 skill message (if needed) when entering skill menu (dds1) Before this would only show when you try to exit the menu without any skills enabled; this will also show it if you enter the menu with 0 skills enabled (e.g. after reaching a skill target with just that skill training). It might make sense to remove the more() before entering the skill menu with 0 skills trained, with this change. -------------------------------------------------------------------------------- 169b76a | Aidan Holm | 2018-02-08 10:18:06 +0800 Fix kbhit() for multi-char textinput events (advil) -------------------------------------------------------------------------------- ba4b0f4 | Corin Buchanan-Howland | 2018-02-07 20:07:34 -0500 Let regeneration amulets work again for players that can heal. I'm on fire! -------------------------------------------------------------------------------- 4ef6cfa | Corin Buchanan-Howland | 2018-02-07 20:06:41 -0500 Fully disable acrobat while using Wu Jian attacks. -------------------------------------------------------------------------------- da3306a | advil | 2018-02-07 09:53:38 -0500 If there's no assert message on crash, put signal into the noun This includes the signal information in the crash milestone if there's no assert message; before, the milestone would just be empty (which I guess translates to "?"). It also will give the signal info on the first line of the crash dump in these circumstances so that any non-windows crash dump always has a cause on the first line. -------------------------------------------------------------------------------- 548d406 | Neil Moore | 2018-02-07 08:44:37 -0500 Make waiting work again. Broken in bc573f345, which made waiting take neither time nor a turn. -------------------------------------------------------------------------------- 65f3478 | Neil Moore | 2018-02-07 08:44:35 -0500 Brace. [skip ci] -------------------------------------------------------------------------------- bc573f3 | Corin Buchanan-Howland | 2018-02-07 08:32:55 -0500 Let amulet of the acrobat work while waiting (Hellmonk) Since otherwise people will be incentivized to move and forth while waiting. Also, some light clean-up on the initial Acrobat commit and actually enable the amulet to spawn. -------------------------------------------------------------------------------- 005426d | Aidan Holm | 2018-02-07 14:56:49 +0800 Handle multiple keys in SDL textinput -------------------------------------------------------------------------------- 870e420 | Corin Buchanan-Howland | 2018-02-06 22:11:05 -0500 Create new amulet: amulet of the acrobat This amulet boosts the EV of the wearer by 15 only during move actions. The boost only applies during the execution of the move action, though the enhanced EV is visible until the player takes another action. The amulet must be worn at full hp before it begins to operate. The thought process here is that there's interesting design space around adding effects to basic actions. The boost size is intentionally quite large to attempt to balance out the amulet doing nothing during turns spent fighting. -------------------------------------------------------------------------------- f2798f9 | Aidan Holm | 2018-02-06 17:36:29 +0800 Make rectangle rendering pixel-perfect Offsetting two of the borders renders all of the corners (previously, the top-left pixel was left out) and ensures that semitransparent pixels are not double-rendered. Pixel-perfection still depends on drivers not stuffing up line rendering; 0.5px should probably be added to all coordinates at some point. -------------------------------------------------------------------------------- fdd7f25 | Corin Buchanan-Howland | 2018-02-05 21:28:36 -0500 Change labyrinth risk-reward: reduce loot This trims 1-3 items from the loot pool the minotaur guards. It's a small adjustment, but I'm not certain it needs too much more. This and the prior commit are short-term adjustments, but I know there are plans for a larger fix in the longer term. -------------------------------------------------------------------------------- 1a64493 | Corin Buchanan-Howland | 2018-02-05 21:24:34 -0500 Change labyrinth risk-reward: buff minotaurs Improve minotaur speed from 10 to 12 and MR from 60 to 100. This should make them quite nasty for the depth labs appear at, though still killable. -------------------------------------------------------------------------------- dab028f | Corin Buchanan-Howland | 2018-02-05 20:58:15 -0500 Improve some god welcome messages (Dingbat) I didn't use any of Dingbat's suggestions, but I was inspired to do this by them. -------------------------------------------------------------------------------- e17c957 | Chris Campbell | 2018-02-05 20:21:44 +0000 Don't allow memorising from books in shops without buying them (drazt1k) -------------------------------------------------------------------------------- 83aada6 | Alan Malloy | 2018-02-05 06:46:40 +0000 Fix a compiler warning: uints are never less than 0 -------------------------------------------------------------------------------- 91cc6d7 | advil | 2018-02-04 13:05:25 -0500 Don't crash if Duvessa dies when Dowan is polymorphed If the new form is non-casting, mons->spells would be empty, leading to a segfault. This commit simply prevents him from getting spells in these cases (which are usually something like a worm). There are also rare cases where this code probably would've worked, overwriting some spells, but these are things like a boggart where we probably want him to keep the poly'd spells. -------------------------------------------------------------------------------- 8de8177 | wheals | 2018-02-04 12:45:05 -0500 Give the actual correct color. Dark blue was too easily confusable with mapping, not much uses brown. -------------------------------------------------------------------------------- db5935f | wheals | 2018-02-04 12:43:46 -0500 Clear the minimap on Abyss shift. -------------------------------------------------------------------------------- 22cbc13 | wheals | 2018-02-04 12:35:12 -0500 Don't show explore horizon around magic mapped locations. Reduces the clutter for Deep Dwarves. -------------------------------------------------------------------------------- 7f09d74 | wheals | 2018-02-04 12:34:39 -0500 Don't show explore horizon in Labyrinth and Abyss. It only contributed to visual clutter. -------------------------------------------------------------------------------- f571278 | wheals | 2018-02-04 12:34:04 -0500 Darken the default explore horizon color. Still open for suggestions on a better one. -------------------------------------------------------------------------------- 83a10e5 | Neil Moore | 2018-02-01 11:37:04 -0500 Fix grammar in Gnoll manual entry (Ge0ff) [skip ci] -------------------------------------------------------------------------------- 6f012ad | Doesnty | 2018-01-30 20:45:14 -0500 Allow Fulminant Prism and Lightning Spire to be cast on traps. (#536) -------------------------------------------------------------------------------- 8af8940 | wheals | 2018-01-30 20:44:46 -0500 Fix a crash when targetting near a friendly monster. Also, unbrace. -------------------------------------------------------------------------------- 090d9d4 | jmbjr | 2018-01-30 20:36:38 -0500 Discourage summoned creatures from Bolting their summoners (jwoodward48ss) (#613) -------------------------------------------------------------------------------- 21b7597 | wheals | 2018-01-30 20:05:21 -0500 Refactor god_hates_item_handling. Removes some duplication of conducts. -------------------------------------------------------------------------------- 47a4871 | wheals | 2018-01-30 18:32:48 -0500 Refactor testing whether items are forbidden. -------------------------------------------------------------------------------- 78804fe | wheals | 2018-01-30 17:16:00 -0500 Remove some leftover purple chunk handling code. -------------------------------------------------------------------------------- 68cc883 | wheals | 2018-01-30 11:03:15 -0500 Require uppercase letters for SID prompt (Sprucery, minmay). -------------------------------------------------------------------------------- fbf05e5 | wheals | 2018-01-30 10:39:49 -0500 Correctly mark partially-ided weapons evil or useless (#9545, #10724). Closes #691 PR. -------------------------------------------------------------------------------- 50b93cf | wheals | 2018-01-30 08:37:12 -0500 Refactor lambdas in l_item_do_stacks (|amethyst). -------------------------------------------------------------------------------- 307c7c3 | Matthew Boeh | 2018-01-29 23:47:03 -0500 Allow lich form to set gargoyle holiness to undead (#688) This was broken in 63fd1ff. -------------------------------------------------------------------------------- 0de994a | wheals | 2018-01-29 23:28:45 -0500 Give jobbed monsters a random base type in ?/M. None of the options here seem ideal: * Showing all possible combinations would make the list way too big, and it would be annoying if ?/M on "red draconian" or on "draconian knight" gave a menu, instead of just showing the specific monster type searched for. * The previous code showed a Platonic ideal of a monster, one that you would never actually find in the wild. Not very useful. * If this randomness is too weird, we could take the approach derived undead do and only show the monster description, but that would be pretty unhelpful. * The solution I went with here might confuse someone who wonders why the description keeps changing. Plus, it still doesn't allow searching for "red draconian monk" directly, for example, so the only way to see a particular combination is to refresh the entry a few times. (This isn't a regression, though, since before it was impossible to see a particular combination.) Fixes #695 issue. -------------------------------------------------------------------------------- 991379f | wheals | 2018-01-29 22:53:28 -0500 Make i, (, and ) in the targetting UI obey keymapping. This is still a bit of a hack; arguably it would be better code-wise to add separate commands for doing these things on the firing screen, but this would add mostly needless work for people remapping their keys. Removes the (totally undocumented that as far as I can see) aliases of ^P for ( and ^N for ). Fixes #706 issue. -------------------------------------------------------------------------------- ea6f5a2 | wheals | 2018-01-29 22:17:14 -0500 Treat wands like other stackables for autopickup (#11305). The alternative implementation would be to make is_stackable_item return true for wands, but that has more far-reaching consequences. -------------------------------------------------------------------------------- c8a8a66 | wheals | 2018-01-29 21:51:43 -0500 Fix local tiles minimap not properly showing transporters. -------------------------------------------------------------------------------- 6540597 | wheals | 2018-01-29 21:51:12 -0500 Fix the order of tile color options to match the enum. Or in one case, to be alphabetical. -------------------------------------------------------------------------------- 13168bc | wheals | 2018-01-29 21:37:44 -0500 Show the explore horizon on the Tiles minimap (AndSDev). Tested on both Webtiles and local. Fixes #389 issue. Closes #392 PR. Closes #394 PR. -------------------------------------------------------------------------------- 89fc7b8 | wheals | 2018-01-29 20:34:52 -0500 Rename feature_def::{d,}map_colour to unseen_colour. To clarify that it is used specifically when the feature has not yet been seen. -------------------------------------------------------------------------------- 82d722a | cut1less | 2018-01-29 19:23:05 -0500 (Console) Use magic mapping colors map_colour() exists but is not called anywhere. This adds a magic-mapping section to where out-of-LOS elements get their color. -------------------------------------------------------------------------------- 314b907 | wheals | 2018-01-28 15:18:53 -0500 Fix an uninitialized variable warning. -------------------------------------------------------------------------------- 8341686 | wheals | 2018-01-28 15:10:21 -0500 Restrict the "treat monster under you as the source" code to Dith shadows. -------------------------------------------------------------------------------- 1c85753 | Corin Buchanan-Howland | 2018-01-28 14:54:24 -0500 Make Dith Shadow Mimic launchers normal (Valarioth, ebering, advil, Snack) Dith now correctly sets shadow mimic launchers to be unbranded and +0 as intended. Thanks to ebering for determining the root cause and advil for writing this code. -------------------------------------------------------------------------------- 70bfd0b | Elan Morin Tedronai | 2018-01-28 11:16:20 -0500 Do not force more prompts for (most) of desolation of salt messages. (#707) Timed portals have a default force more prompt for their initial announcement message. The following messages do not cause additional more prompts by default. This commit makes the Desolation of Salt messages also behave like that. Before this commit, the force_more was defined just as "distant wind". Since "distant" is also used in many of the followup messages to describe how far away the player is from the portal, this caused a lot of additional "more" prompts for the player. -------------------------------------------------------------------------------- dd6f4a9 | Aidan Holm | 2018-01-28 04:13:31 +0800 Add icon for possessable status (Ultraviolent4, #11239) -------------------------------------------------------------------------------- 871f50c | Aidan Holm | 2018-01-28 03:51:09 +0800 Fix typo (Poroing, #11291) -------------------------------------------------------------------------------- bb09730 | Aidan Holm | 2018-01-28 03:46:07 +0800 Fix crash when resizing window while targeting (#11356) -------------------------------------------------------------------------------- 5b255cf | Aidan Holm | 2018-01-27 05:25:19 +0800 Fix spurious spell failure warning for wands (Le_Nerd, #11370) Also removes the unused fail_chance variable, spotted by wheals. -------------------------------------------------------------------------------- beb7240 | advil | 2018-01-25 20:21:15 -0500 Make sudo: required for travis explicit We were grandfathered in to this being the default because the project was created before Feb 15, 2015. It's no longer the default, so any forks after that will get travis errors from running on the container-based enviornment, which doesn't support sudo. -------------------------------------------------------------------------------- 89a7304 | Aidan Holm | 2018-01-26 03:00:20 +0800 Add verbal spell failure description (amalloy) This provides spell safety information to players who are unable to see the colour of the failure rate. The text colour of this prompt has also been changed to lightgrey, in order to make the spell name more distinct. -------------------------------------------------------------------------------- 3ad276d | Aidan Holm | 2018-01-26 03:00:20 +0800 Omit very-dangerous message on 100% spell failure -------------------------------------------------------------------------------- bcde4f2 | John Boyle | 2018-01-26 03:00:20 +0800 Colourize risk of spell failure for last casted spell (aidanh) -------------------------------------------------------------------------------- 505e61d | John Boyle | 2018-01-26 03:00:20 +0800 Prevent casting a spell with 100% failure chance (aidanh) If there's never an advantage for a player to try to cast a spell with 100% failure, why do we even allow it as an option? If there's really some edge case advantage for a player to try to cast a spell with 100% failure, why would we continue to encourage that? Seems like a win/win to just prevent it from being cast in the first place. -------------------------------------------------------------------------------- dc44e7b | John Boyle | 2018-01-26 03:00:20 +0800 Display spell fail % for "dangerous to cast" warning (aidanh, tedric, Zenthirum) These are Zenthirum's changes from the mantis bug report. -------------------------------------------------------------------------------- ee1c82b | Aidan Holm | 2018-01-26 03:00:20 +0800 Add spell_failure_rate_string() -------------------------------------------------------------------------------- 37984e8 | Aidan Holm | 2018-01-26 02:32:34 +0800 Fix ?/I showing descriptions for wrong items There were several problems with the old implementation. get_item_by_name() did fuzzy matching, instead of exact matching, and only a handful of item types were checked in _describe_item(). In addition, a partial match against item types checked first would be used immediately, without checking for a better match of a different type. To fix this, get_item_by_exact_name() is added. The name given to it is compared against the dbname of all possible items, and only an exact match is considered a success. -------------------------------------------------------------------------------- ff2d48b | wheals | 2018-01-25 11:09:24 -0500 List the includable rcfiles in options_guide.txt (Yermak). They were already in the default init.txt, but that tends to get overwritten. -------------------------------------------------------------------------------- 366d4ef | panicbit | 2018-01-25 11:06:25 -0500 Add neo command keys (#566) Probably not going to be more unused than Dvorak or Colemak... -------------------------------------------------------------------------------- 1ac4c55 | wheals | 2018-01-24 21:04:08 -0500 Fix crash when describing memorised spells. -------------------------------------------------------------------------------- b4b8e1f | Aidan Holm | 2018-01-25 07:32:45 +0800 Make Serpent of Hell name wrangling slightly less brittle -------------------------------------------------------------------------------- 2fe0497 | Aidan Holm | 2018-01-25 07:32:45 +0800 Show Serpent of Hell flavour in ?/M list -------------------------------------------------------------------------------- 7cd46d3 | Aidan Holm | 2018-01-25 06:25:49 +0800 Allow memorising from description of book on ground (Yermak, #10799) -------------------------------------------------------------------------------- a32820b | cut1less | 2018-01-25 03:29:34 +0800 Display zombie hands icon for offline tiles users -------------------------------------------------------------------------------- 7da2295 | Aidan Holm | 2018-01-24 22:44:10 +0800 Don't list removed books in ?/s spell descriptions (rchandra, #11287) -------------------------------------------------------------------------------- 6b88ebb | advil | 2018-01-22 16:07:15 -0500 checkwhite [skip ci] -------------------------------------------------------------------------------- 3374514 | advil | 2018-01-22 16:05:46 -0500 Centralize some vault-type-specific guidelines to be easier to find + a bunch of editing and formatting. -------------------------------------------------------------------------------- 23542c2 | Aidan Holm | 2018-01-22 04:58:05 +0800 tiles: show dungeon cursor on mouse-move in X view -------------------------------------------------------------------------------- bd61d0d | wheals | 2018-01-21 15:51:17 -0500 Revert "0.21 tournament reminder." This reverts commit eb883ae61ce99abd1f1afd7a535320dd6b9a2829. -------------------------------------------------------------------------------- de60138 | elliptic | 2018-01-21 15:33:47 -0500 Fix zombie hands math. Damage wasn't exactly multiplied by 0.75 in 55908e5a (because 2dN has expected value N+1, not N). -------------------------------------------------------------------------------- 7adf481 | wheals | 2018-01-21 15:19:44 -0500 Add instructions for compiling local tiles on Windows 10 WSL. -------------------------------------------------------------------------------- b094c4c | wheals | 2018-01-21 15:11:11 -0500 Mark cloud immunity scarves as useless under Qaz. This is in line with scrolls of amnesia under Trog. -------------------------------------------------------------------------------- 94e0ad4 | gammafunk | 2018-01-19 17:42:17 -0600 Remove Borgnjor's Vile Clutch from the Book of Necromancy This is a strong spell that works against most things in the dungeon. The Necromancer start is already very strong without BVC, having animate skeleton/dead for non-resistable damage and vampiric drain for good damage and healing. This commit removes BVC from the Necromancer starting book, leaving it in the Book of Unlife and the Book of Dreams. It's also available through Kiku/Sif gifts, of course. -------------------------------------------------------------------------------- 55908e5 | gammafunk | 2018-01-19 17:42:17 -0600 Reduce the constriction damage from Borgnjor's Vile Clutch This is a level 5 spell that does high damage per cast with good spell power, is applicable to a large majority of monsters, and only checks half AC. Although the damage per turn is not high compared to other level 5 spells, the cumulative damage is high, and the spell has lots of additional utility for restricting monster movement on top of this damage. To help keep the overall usefulness more in line with other level 5 spells, this commit reduces the constriction damage by 25%. -------------------------------------------------------------------------------- 3fd002e | advil | 2018-01-19 17:53:57 -0500 Add transporter landings to sanitize_feature I'm still not really sure how this is happening (and it may be a bug), but somehow abyss terrain can get reused on abyss shifts, including terrain that used to be MMT_VAULT. This seems to occur when the abyss level layout generater is reset, something that happens at least on the first abyss morph after loading a game in the abyss. When it does happen, sanitize_feature is called on the remnant terrain to clean up various things before reusing it. Transporters were already on the list (turning to arches) but not landing sites; I just made landing sites turn to arches as well. This led to a (rare) way that the abyss could break transporter pairs, if ex-vault-terrain is part of what gets reused. I don't know the exact conditions, but I *think* it is some combination of saving/loading at the right distance from the vault, and then having the abyss shift. This probably could use some more investigation. -------------------------------------------------------------------------------- 218e7ff | advil | 2018-01-18 19:23:26 -0500 Don't let lugonu corrupt overwrite transporter landing sites Since it can't overwrite transporters. This is not the bug we were looking for, but it is still *a* bug. (cherry picked from commit 2553a3340b4d1c90901eebb07941a6ff69edc3fc) -------------------------------------------------------------------------------- 246a1cd | advil | 2018-01-18 16:00:29 -0500 Don't infinitely loop with crawl_state.seen_hups on tiles (11353) This could happen if multiple key events were in the SDL queue when SDL_QUIT was received, a situation apparently triggered by windows alt+f4 after the recent SDL2 update. I'm not entirely sure why it's not swallowing the key events any more, but some aspects of modifier key behavior did change, and event order may have changed. This fix ignores all key events after the SDL_QUIT event (or other HUP). This is exactly the possible infinite loop referred to in 2dbd2a41df8c. -------------------------------------------------------------------------------- 7478db5 | advil | 2018-01-17 12:33:40 -0500 Ensure that _getch_mul returns a non-empty keyseq (aidanh) The getch concept seems to imply this, but if somehow you get the SDL event loop to produce only CK_NO_KEY, this assumption would be violated. (Though, crawl didn't obviously have problems when the deque size was 0; it's possible the assumption is still made somewhere in the macro code that I didn't check.) -------------------------------------------------------------------------------- af9c194 | advil | 2018-01-17 12:33:40 -0500 Rewrite text input suppression to use different hacks On most(?) windows and linux setups, numpad keys with numlock on send both a keydown event and a textinput event with the corresponding number; with numlock off only the keydown event is sent. On OS X there is no numlock, but this dual behavior happens always. Crawl is supposed to treat the numpad uniformly regardless of numlock state, so it needs to ignore the double press. For legacy reasons (I think) it also needs to correctly handle just the number input. In the numlock on case (and on OS X), therefore, one or the other has to be suppressed. The previous approach relied on starting and stopping the text input system clearing any upcoming SDL_TEXTINPUT events. On Windows, updating SDL to 2.0.7 has broken this assumption, and this toggle only sometimes works as intended. I couldn't figure out a reasonable way to restore the behavior of this toggle, so here is a new approach. This commit tries to do things without relying on any particular SDL code; if a textinput event immediately follows a matching keydown event, the textinput event is ignored. This of course assumes that these events are adjacent, but in my testing on OS X and windows this has always been true so far. This patch will need some more testing. (I suspect the relevant SDL commit is this one: https://github.com/spurious/SDL-mirror/commit/ff8a1efc51a6ad7de6379cde7047d135ff d7e15e because it changes the timing of textinput events, which were previously guaranteed to be near the keydown; but I haven't tested this hypothesis.) -------------------------------------------------------------------------------- 605b837 | advil | 2018-01-16 20:16:13 -0500 Clear m_glyphs when (re-)configuring fonts Not clearing this breaks changing DPIs (e.g. by dragging across screens, 22212c17e2ada4c5306) because the advances (probably among other things) are apparently still cached here from the previous DPI. -------------------------------------------------------------------------------- 0f8607c | advil | 2018-01-14 15:11:58 -0500 Make ability wall jump work under silence ...like the movement based version. -------------------------------------------------------------------------------- 0fd0111 | Aidan Holm | 2018-01-14 04:01:05 +0800 Fix uninitialized read when handling god speech -------------------------------------------------------------------------------- d698a02 | Aidan Holm | 2018-01-13 06:29:24 +0800 Add some new title artwork (froggy) -------------------------------------------------------------------------------- 1fede22 | advil | 2018-01-11 20:52:08 -0800 Update submodule -------------------------------------------------------------------------------- 7512b04 | advil | 2018-01-11 20:37:56 -0800 Improve support for MSYS2 This check was relying on a uname that MSYS2 doesn't always set, depending on how it is run. SDL2 submodule also needs a related fix. -------------------------------------------------------------------------------- db02301 | advil | 2018-01-11 18:37:05 -0500 Revert 399e2f71cb99 and do it a different way v.1 was a terrible, terrible idea. -------------------------------------------------------------------------------- 2b194f0 | Gregory Chereshnev | 2018-01-11 13:56:55 -0800 Update species.txt A small translation. -------------------------------------------------------------------------------- 399e2f7 | advil | 2018-01-11 15:01:59 -0500 Fix a DEAD MONSTER (u/cervance) Even with clean=false, if inflict_damage recursively triggers the disappearance of a defender that is a summon via the death of the summoner (via usk pain bond), you can get a cleaned up dead defender after the call. This fix addresses only aux attacks, other calls to inflict_damage may still lead to DEAD MONSTER messages. I don't think it is plausible to change things so that the summon isn't cleaned up yet, which would be a better fix in principle (cf. f70bbbcf307f), but I could be wrong. -------------------------------------------------------------------------------- 92e58f9 | Alan Malloy | 2018-01-11 11:26:44 -0800 Simplify printf specifiers for !agi and !brill -------------------------------------------------------------------------------- 116c2a8 | advil | 2018-01-10 12:51:39 -0500 One more -- add a caveat about the font [skip ci] -------------------------------------------------------------------------------- 9254d95 | advil | 2018-01-10 12:48:40 -0500 List recognized language codes in options_guide.txt -------------------------------------------------------------------------------- 0944b2b | Alan Malloy | 2018-01-10 09:44:59 -0800 Mention the 'language' option in options_guide.txt -------------------------------------------------------------------------------- 7da74aa | Alan Malloy | 2018-01-10 09:41:21 -0800 Improve error message when rcfile specifies unknown language -------------------------------------------------------------------------------- 4406e2f | Aidan Holm | 2018-01-11 00:55:49 +0800 fontwrapper-ft: cache glyph metrics outside the atlas This fixes huge lag when trying to calculate the rendered size of huge strings of text (string_width(), string_height()). Previously, glyph metrics were stored with the font atlas metadata, so every glyph lookup required shuffling the LRU metadata: 95% of string_width() runtime was spent inside map_unicode(), and 95% of its runtime was spent updating the LRU metadata. This is pointless, because the glyphs aren't getting rendered (and what happens when a buffer has >256 distinct glyphs in it, anyway...) New solution: store glyph metrics in a big vector keyed by codepoint, for fast access, and auto-expand it as necessary. If memory usage becomes a concern, there are several low hanging fruit: the GlyphInfo struct could be compacted significantly, and the codepoints used in game content (in dat/) fall into distinct bands with about 50% empty space. After this change, string_width() runtime is dominated by next_glyph(). -------------------------------------------------------------------------------- f756b68 | Kyle Rawlins | 2018-01-10 10:06:50 -0500 Tweak build instructions for msys2 Apparently installing the toolchain doesn't set the path automatically. [skip ci] -------------------------------------------------------------------------------- eddfa9b | Alan Malloy | 2018-01-09 17:41:07 -0800 Don't clear unique annotations when you defeat an illusory unique -------------------------------------------------------------------------------- f34168a | Aidan Holm | 2018-01-10 07:36:22 +0800 Fix some unused func/var warnings on console -------------------------------------------------------------------------------- bf6022e | Alan Malloy | 2018-01-09 13:11:22 -0800 Make Duvessa and Dowan react the same to killing each other -------------------------------------------------------------------------------- 6b3d46c | Aidan Holm | 2018-01-09 22:53:21 +0800 Remove redundant spell tiles -------------------------------------------------------------------------------- b6df83e | Aidan Holm | 2018-01-09 22:53:21 +0800 Add generic monster spell tile As distinct from the Error tile. -------------------------------------------------------------------------------- 03c2c45 | Aidan Holm | 2018-01-09 22:53:21 +0800 Add consistent background to monster spell tiles -------------------------------------------------------------------------------- 8ce38db | Aidan Holm | 2018-01-09 22:53:21 +0800 Don't show removed spells in ?/s menu (rchandra, #11287) -------------------------------------------------------------------------------- 25970fc | Aidan Holm | 2018-01-09 22:51:33 +0800 Fix floor features getting a black tile in ?/F A DNGN_UNSEEN tile was being added by FeatureMenuEntry, since the uninitialized position (the origin) was unseen. Normally this didn't matter as menu entry tiles are rendered in a sorted order, with the unseen tile underneath the feature tile, but for floor tiles this sorting placed the floor tile underneath the UNSEEN tile. -------------------------------------------------------------------------------- 3eaed18 | Chris Campbell | 2018-01-09 13:47:07 +0000 Clean up some comment spacing -------------------------------------------------------------------------------- 0a53ea1 | Chris Campbell | 2018-01-09 13:47:07 +0000 Don't place air elemental bands with spriggan air mages Since their tornadoes tend to just kill the spriggans. -------------------------------------------------------------------------------- e097ebc | Chris Campbell | 2018-01-09 13:47:07 +0000 Don't require the rest command to make barbs expire Have them expire when not moving (as with Hop cooldown), rather than having the "wait" command specifically do something special for them. Also slightly increase their base duration, since this does allow for them to expire while doing other things in combat. -------------------------------------------------------------------------------- 299d06e | Chris Campbell | 2018-01-09 13:47:06 +0000 Allow manually cancelling Formicid digging Normally there's no need to manually cancel it (since it's always free and instant to activate, and taking any action other than digging cancels it), but having the digging status active prevents WJC walljumping so there needs to be a way to cancel it without taking an action (other than saving and reloading). -------------------------------------------------------------------------------- 1bb26a1 | Aidan Holm | 2018-01-09 05:47:28 +0800 Fix local tiles resize during yesno and stat gain prompt -------------------------------------------------------------------------------- 76f3efa | Aidan Holm | 2018-01-09 00:33:26 +0800 Shorten Trog ability description to fit in one line -------------------------------------------------------------------------------- 614aadd | gammafunk | 2018-01-07 16:05:44 -0600 Fix a crash when attempting to print constriction status (dweomer) Broken in 5bb8f479, we have an ASSERT when the player is constricted, but we're unable to look up the corresponding monster. This commit uses the proper check for a valid constrictor, returning false in the relevant function if the constrictor is invalid for any reason, which will prevent constriction being printed as a status. -------------------------------------------------------------------------------- 8770677 | Aidan Holm | 2018-01-07 04:00:30 +0800 Choose correct tile for headless vines/starspawn tentacles -------------------------------------------------------------------------------- 7216f87 | Aidan Holm | 2018-01-07 04:00:30 +0800 Don't vary tiles for fake monsters This fixes monsters' tiles varying on the ?/M screen. -------------------------------------------------------------------------------- b9bda1d | Aidan Holm | 2018-01-07 01:26:49 +0800 Fix glyph metric lookup for multibyte utf-8 chars -------------------------------------------------------------------------------- 5d95dd4 | Aidan Holm | 2018-01-07 01:26:42 +0800 Fix some iterations over multibyte utf-8 -------------------------------------------------------------------------------- eb883ae | wheals | 2018-01-05 16:17:53 -0500 0.21 tournament reminder. -------------------------------------------------------------------------------- c6c46c7 | gammafunk | 2018-01-05 12:39:40 -0600 Finalize the changelog for 0.21 -------------------------------------------------------------------------------- 002c468 | gammafunk | 2018-01-04 18:35:51 -0600 Fix the smite targeting of Borgnjor's Vile Clutch (mibe, 11334) Currently the function to determine if susceptible monsters are in LOS considers this spell as a beam exploding spell. This means any monsters or other obstructions along the path to a valid target has the UI's tracer beam explode on the obstruction, causing the beam to not count the valid target as affected. The UI then incorrectly tells the player that no valid target is in view. This commit changes spell_no_hostile_in_range to handle the relevant tracer for smite-targeted spells directly through an explosion at the target. Now the UI correctly ignores obstructions for determining if hostiles are in range for Vile Clutch. TODO: 1) I leave a comment noting how some solid and non-reachable targets should probably be bypassed for the hostile-in-range check. 2) I leave another comment noting how explosion radii data for spells are not stored in any central place, and it would be good to do that. 3) Make the necessary zap_data entries so smite-targeted spells can use the zap tracer loop in spell_no_hostile_in_range to properly determine when a susceptible monster is in view. Currently the UI will only consider range for smite-targeted spells without zap data. This means it will consider e.g. an rWind monster to be a valid hostile in range for Airstrike initially, only preventing the targeting later when the player finally accepts that target in the UI. 4) I'm not actually sure that having to make zap entries for spells only so they can properly consider targets in range is a good idea. Might need to look at what the main intent of zap_data actually is. -------------------------------------------------------------------------------- 8c2458a | gammafunk | 2018-01-04 17:03:26 -0600 Slightly refactor some spell targeting code and update comments -------------------------------------------------------------------------------- 3d2f077 | gammafunk | 2018-01-03 21:21:33 -0600 Enable Wu Jian in stable versions Although this god probably still has significant work to be done (e.g. with Wall Jump), it's stable enough for release. Any server admins with 0.21 need to be sure to pull this commit, otherwise Wu Jian won't be available in that version. This reverts commit bb42413abe9137b984ae9489003580cc3c1e1fdd. -------------------------------------------------------------------------------- 670f5c0 | gammafunk | 2018-01-03 20:55:35 -0600 Enable Gnolls in stable versions This species is ready for release. Any server admins with 0.21 need to make sure to pull this commit, otherwise their 0.21 won't have Gnolls. -------------------------------------------------------------------------------- c6ec8ce | gammafunk | 2018-01-03 14:54:08 -0600 Have all forms of monster movement break indirect constriction (mibe) Previously monsters would continue to be indirectly constricted under Borgnjor's Vile Clutch if they were trampled, yanked with Lesser Beckoning, did a swoop attack, etc, since the move only caused direct constriction to be checked for validity. This commit unifies the checks for all forms of constrictions and simplifies the code to have the validity checks for both happen through a single method. Now any form of movement will cause the monster's zombie hands constriction to end. -------------------------------------------------------------------------------- c5a4238 | gammafunk | 2018-01-03 14:42:36 -0600 Give a static function a clearer name -------------------------------------------------------------------------------- ae4c1f7 | Chris Campbell | 2018-01-03 14:16:34 +0000 Remove duplicate info from a description The fact that it's instant is already automatically displayed. -------------------------------------------------------------------------------- 33df271 | Chris Campbell | 2018-01-03 14:16:34 +0000 Improve some WJC messaging/descriptions -------------------------------------------------------------------------------- d3d06db | Chris Campbell | 2018-01-03 14:16:34 +0000 Coding convention fixes -------------------------------------------------------------------------------- 5354c77 | Chris Campbell | 2018-01-03 14:03:57 +0000 Allow (a)bility-walljump to be used when starving Since the movement-based version can be - although if the ability is changed to be ability-only, it'd probably be fine to revert this again. -------------------------------------------------------------------------------- a749362 | advil | 2018-01-02 17:39:58 -0500 Do post-move things for ability walljump (MarvinPA) I forgot to deal with all this stuff. -------------------------------------------------------------------------------- 00266d7 | Chris Campbell | 2018-01-02 20:43:48 +0000 More completely remove Delayed Fireball Just leave the minimum required compatibility code and treat it like a regular removed spell instead of leaving it as fully functional if it was still memorised. -------------------------------------------------------------------------------- 37babaa | Chris Campbell | 2018-01-02 20:43:47 +0000 Make Yredelemnul's Enslave Soul smite-targeted To make it slightly simpler and easier to use. -------------------------------------------------------------------------------- aaa5eb4 | Chris Campbell | 2018-01-02 20:43:47 +0000 Remove another ability use of LOS_RADIUS Doesn't have any actual effect in this case since the ability is smite-targeted. -------------------------------------------------------------------------------- 083de83 | Chris Campbell | 2018-01-02 20:43:47 +0000 Swap the ranges of Makhleb's Minor/Major destruction (edgefigaro) Since Minor Destruction is very cheap and spammable, limit it slightly with lower range, while increasing Major Destruction's range as it costs piety and includes potential big explosions. Also fix the abilities being able to be cast out of LOS when under an LOS reduction effect. -------------------------------------------------------------------------------- 392ec66 | Chris Campbell | 2018-01-02 20:43:47 +0000 Don't allow firing Draconian breaths out of LOS When wearing the robe of Night, for example. Also allows the full-range breaths to reach range 8 when playing as a Purple Draconian-Barachi hybrid (or if some other method of increasing LOS comes into existence). -------------------------------------------------------------------------------- eb5ee87 | Chris Campbell | 2018-01-02 20:43:47 +0000 Fix Lugonu Banish working on out-of-LOS enemies Had been broken with the addition of Barachi. -------------------------------------------------------------------------------- 9c1766a | Chris Campbell | 2018-01-02 20:43:47 +0000 Remove Shatter from pan lord spell lists It doesn't function very well as a monster spell in general (and should possibly also be removed from Jorgrun) - much more so than other high-level conjurations, it's likely to kill lots of the caster's allies, and especially on very high-HD monsters is able to deal extremely high damage to players without the kinds of restrictions that other scary spells have. -------------------------------------------------------------------------------- 8389209 | Chris Campbell | 2018-01-02 20:43:47 +0000 Adjust messaging for emergency flight So that it makes slightly more sense when swimming forms expire (without really trying to give an explanation as to how the emergency flight works). -------------------------------------------------------------------------------- ce77710 | gammafunk | 2018-01-02 12:12:29 -0600 Correct weapon offsets for the wight monster tile (gorglomux) -------------------------------------------------------------------------------- 34d3fd3 | gammafunk | 2018-01-02 07:32:17 -0600 Updated entropy weaver and tormentor tiles (roctavian, #11340) Entropy weavers don't have a multi-turn spell any more, so we don't need 3 tiles, but it was agreed that the second state is the best rendition for the main tile. The new tormentor is purple, which matches the console color better, but it is *very* purple. Some would claim it is too purple, and I would have no defense against this argument. Roctavian has said he'll redo the tile entirely, but until then we'll use this one. The new tile helps make tormentors distinct from, say, cacodemons, and telling demons apart is the key to dominating the late-game, the end-game, extended, the post-game, and the metagame. -------------------------------------------------------------------------------- 9421e3f | gammafunk | 2018-01-01 17:21:09 -0600 A batch of updated monster tiles (roctavian, #11340) From insects, to orcs, to demons and many things in-between. Also new tiles for many uniques, and Erica now has a version of her tile used when she's not wielding a flaming scimitar, which allows that weapon's tile to display. -------------------------------------------------------------------------------- 90586b7 | gammafunk | 2018-01-01 17:21:09 -0600 A new Shining One altar tile (roctavian, #11340) The iconography is less a reference to Christianity and it's a fun little inside joke for people familiar with the commonly used abbreviation for this god. -------------------------------------------------------------------------------- 1cd5daa | gammafunk | 2018-01-01 17:21:09 -0600 A batch of updated artefact weapon tiles (roctavian, #11340) For random artefacts and the unrands Majin-Bo, Wucad Mu, Leech, and Wyrmbane. The latter is suppose to have its tile upgraded every couple of enchantment, but I haven't yet made the code modifications for that. For now, I've added the later variants and let the first variant be the only one used. Slings and fustibali have their ordinary and ego tiles updated in addition to the artefact ones. -------------------------------------------------------------------------------- 9b14fc1 | gammafunk | 2018-01-01 17:21:09 -0600 A batch of updated elven monster tiles (roctavian, #11340) Updates for all the elven monsters, including the uniques Dowan, Duvessa, and Fannar. Deep elf elementalists are supposed to have one of three tiles that cycles with each UI action as nice way to make them distinct and visualize their elemental nature, but this needs some additional code changes. Right now, using these in a cycle wouldn't display their wielded weapon for any tile except the first variant. I'm adding the variants, but only enabling use of the first one until said code changes can happen. -------------------------------------------------------------------------------- 898fae9 | gammafunk | 2018-01-01 17:21:09 -0600 Some tweaks to plant tiles (roctavian, #11340) -------------------------------------------------------------------------------- 20fe0ec | gammafunk | 2018-01-01 17:21:09 -0600 New and updated zombie and skeleton monster tiles (roctavian, #11340) Improvements to various zombified and skeletal beasts. Now yak zombies, bear zombies, and draconian skeletons have their own distinct tiles. -------------------------------------------------------------------------------- 4f60a59 | advil | 2018-01-01 14:45:26 -0500 Update wall jump info in changelog, options guide, and help To add something about the ability, and try to make very obvious that you can disable the movement-activated mode. (This mode is pretty divisive, between players who find it fun, and players who it drives crazy because it's so easy to trigger accidental wall jumps.) -------------------------------------------------------------------------------- e27d229 | Aidan Holm | 2018-01-02 00:45:03 +0800 Postpone timed portal messages bofore level load (Yermak, #11279) TimedMessaging now ignores all turn events that occur before an ENTERED_LEVEL event, and the ENTERED_LEVEL event now also causes an elapsed time check. -------------------------------------------------------------------------------- 35895e1 | Aidan Holm | 2018-01-01 22:39:09 +0800 Fix spell list column heading alignments -------------------------------------------------------------------------------- 6182cf9 | Aidan Holm | 2018-01-01 19:51:03 +0800 Improve rendering of menu entries with tall tiles This makes the ?/M menu much nicer when big uniques (e.g. hell lords) are shown. On webtiles, the centre of the tall tile was shown, while on local tiles the full tile was shown, with the excess sticking out the top. -------------------------------------------------------------------------------- 3182a47 | Aidan Holm | 2018-01-01 19:51:03 +0800 Add centre parameter to renderer.draw_from_texture() -------------------------------------------------------------------------------- 8a0fcf7 | Aidan Holm | 2018-01-01 19:51:03 +0800 Fix renderer.draw_from_texture() ignoring y_max -------------------------------------------------------------------------------- 01001fb | Aidan Holm | 2018-01-01 19:46:15 +0800 Fix alignment of spellsets with hex-chances -------------------------------------------------------------------------------- dc0ec3b | dplusplus | 2018-01-01 19:18:47 +0800 fix explore_discoveries::cleaned_feature_description() -------------------------------------------------------------------------------- 887ef9c | Aidan Holm | 2018-01-01 18:19:30 +0800 Correctly ellipsize multibyte strings -------------------------------------------------------------------------------- 122557b | Aidan Holm | 2018-01-01 18:19:30 +0800 Fix word-wrapping pt 2: short strings This fixes the case when a newline occurs in the input string before the width limit is reached. We also use the new chop_bytes() to handle newlines correctly. -------------------------------------------------------------------------------- 1fac53a | Aidan Holm | 2018-01-01 18:19:30 +0800 Fix word-wrapping of text with embedded newlines This function is intended to find the point at which a string exceeds a given horizontal width, but neglected to reset the accumulated width after newlines. This caused text wrapped to fit within a rectangular region to be prematurely wrapped. -------------------------------------------------------------------------------- 4e99ca0 | Aidan Holm | 2018-01-01 18:19:30 +0800 Add formatted_string::chop_bytes() chop() uses wcwidth() -- this leads to subtle bugs if you're chopping strings based on indices. -------------------------------------------------------------------------------- 4fa69d9 | Chris Campbell | 2017-12-31 20:05:56 +0000 Mark some Ely abilities as unusable when confused Makes Ely's Purification and Ru's Draw Out Power the only abilities that can be used while confused (since one of their main purposes is to cure it). -------------------------------------------------------------------------------- ec8b4a9 | Chris Campbell | 2017-12-31 20:05:47 +0000 Fix unidentified scarves being targetable by ?enchant armour -------------------------------------------------------------------------------- d89ddbe | Aidan Holm | 2017-12-31 17:48:34 +0800 Fix crash in player doll editor (GuideCritic, #11333) Crash was caused by a collision between this enum and a player doll part tripping up an assertion. No save incompatibility: player doll data is serialized in a manner independently of this enum's value, and mcache_ghost entries have their dolls reconstructed from species and equipment on creation. -------------------------------------------------------------------------------- fd72fac | gammafunk | 2017-12-30 19:28:37 -0600 Preliminary debian changelog entries for 0.21 and 0.22 [skip ci] -------------------------------------------------------------------------------- e7d2b72 | gammafunk | 2017-12-30 19:05:14 -0600 More changelog updates -------------------------------------------------------------------------------- 786e97d | gammafunk | 2017-12-30 18:15:33 -0600 Update the changelog through 0.21-a0-642-g5d013b21 -------------------------------------------------------------------------------- 5d013b2 | Aidan Holm | 2017-12-30 21:22:16 +0800 Fix ghost doll cycling through parts The acting_part member was entirely unused. The i_ghost struct it is part of is hashed to determine ghost appearances. While it is cleared in the (monster_type, monster_type) constructor, it isn't cleared in the (monster*, int) constructor, which seems to be used when monsters move between cells. -------------------------------------------------------------------------------- eef9d7f | Chris Campbell | 2017-12-30 02:26:27 +0000 Tweak Shatter some more Add icy creatures back to the increased damage level (so they now take 2* damage, compared to previously taking 1.5*), make the chances of wall destruction all fixed instead of power-based, and update description. -------------------------------------------------------------------------------- 849abb4 | hellmonk | 2017-12-30 02:00:18 +0000 Simplify shatter damage formula. Will always do either 1, 3, or 6 dice depending on the monster. Notably, shatter will now damage insubstantial monsters (for 1 die of damage), will do normal damage instead of 1/3 to water elementals, and no longer does additional damage to icy monsters. TBH this should be simplified further. [Made some minor further adjustments, adjusting the order of operations for checks on material/flight/insubstantiality for better consistency - MarvinPA] -------------------------------------------------------------------------------- 8afaa31 | Chris Campbell | 2017-12-30 01:20:52 +0000 Simplify LRD explosion damage and size Make each material type have a fixed damage and size, and don't increase damage or size on a cast that destroys a monster or wall. Adjust metal walls to have a fixed chance of destruction once above the power threshold, as alli other wall types already had (instead of a power-based chance - simplifying these further across the board would probably be good). -------------------------------------------------------------------------------- 11b2e07 | advil | 2017-12-29 15:44:44 -0500 Allow wall jump against closed doors via the ability Since the ability is always possible, there's no reason not to allow this now. When moving, moving against a closed door still has the regular behavior for the door type. -------------------------------------------------------------------------------- f6577c8 | advil | 2017-12-29 15:44:44 -0500 Add a targeter/ability for WJC wall jump This adds a way to trigger wall jump via an ability that has you target a wall position; the targeter highlights the landing square and any affected monsters. The behavior of wall jump activated this way should be identical to that of move-triggered wall jump, but this is safer and easier to understand. This ability is always available if the player has wall jump, but doesn't replace move-triggered wall jump. For safer movement, move-triggered wall jump can be disabled in rc by setting `wall_jump_move = false` (default: true) leaving only the ability. The `wall_jump_prompt` option remains, but by default is false. -------------------------------------------------------------------------------- 589fbc3 | Neil Moore | 2017-12-29 07:22:59 -0500 Update new-member instructions slightly. With the move of the private list, the set of people who can edit it is different. [skip ci] -------------------------------------------------------------------------------- 1790b82 | Neil Moore | 2017-12-29 07:22:59 -0500 Champagne and caviar for aidanh. Welcome to the team! [skip ci] -------------------------------------------------------------------------------- af8bc5d | advil | 2017-12-28 22:21:32 -0500 Use random food tiles for rations This is based on a bunch of ideas that came up in ##crawl-dev last week (|amethyst, wheals, maybe others). It may or may not be a good idea UI-wise with this exact tile set (since all the tiles are very focused on one food concept, and might give the wrong impression) but it does make the food tiles, and especially food shops, less monotonous. This approach normalizes to the basic tile (currently the old bread ration tile) in inventory. I've also brought back some old tiles, though I left out the ones I found hardest to identify as food. Handles save compat for the inventory tile name. -------------------------------------------------------------------------------- 4c047d5 | Alan Malloy | 2017-12-27 14:02:52 -0800 Update copyright from 2016 to 2018 It may look a little early to you, but I got a time machine for Christmas. -------------------------------------------------------------------------------- 1e37ce5 | gammafunk | 2017-12-26 07:12:43 -0600 Fix messaging when the Borg's Vile Clutch enchantment expires Previously it would say "You lose your grip on ..." when Vile Clutch expired, since the message was handled in the constriction code after the enchant expired. Move this message into the enchantment expiration code, so it can say "The zombie hands release their grip on..." instead. -------------------------------------------------------------------------------- b5dc200 | gammafunk | 2017-12-26 07:12:43 -0600 Lower the enchantment duration of Borgnjor's Vile Clutch Currently the enchantment lasts a long time relative to how many failed escape attempts a monster is likely to have before it breaks free. This means that monsters that can't or won't move can take especially large amounts of damage from a single cast of Vile Clutch. At starting spell-power levels of around 35 spell-power, the enchantment duration is currently 5 + 0-16 turns for an average of 14 turns. This commit changes the formula from: 5 + random2avg(spellpower / 2) to: 4 + random2avg(spellpower / 10) and using randomized rounding for the division. So at 35 spell-power, the duration will be 4-7 turns for an average of 5.5 turns, and at 100 spell-power this gives 4-13 turns for an average of 8.5 A monster is very likely to escape before these average turns values at those respective spell-powers, so the new duration formula will effectively put a limit on damaging monsters that don't attempt escape without frequently expiring before a monster breaks free. -------------------------------------------------------------------------------- 344d351 | Chris Campbell | 2017-12-24 19:16:26 +0000 Further ghost adjustments Re-allow distortion, since it doesn't have any particular reason to be disabled compared to other threatening early brands, and fix movement speed at 10 rather than allowing slow but not fast ghosts. -------------------------------------------------------------------------------- a19c9dc | advil | 2017-12-24 13:06:03 -0500 Tweak min ghost speed to 10 after further discussion -------------------------------------------------------------------------------- 72aa5ef | advil | 2017-12-24 12:54:02 -0500 Normalize ghost min speed and prevent more ghost brands The particular value of 12 was a suggestion of Lasty's; this may need some more tweaking but I'd like to do something since newghosts won't get merged for 0.21. 10 might be ok, it's probably the modal value right now anyways. N.b. for anyone reading this who isn't familiar with monster speed, 12 is slower than the player. (These changes are likely to get reverted or at least modified for newghosts.) Resolves #570 -------------------------------------------------------------------------------- 87fa41b | advil | 2017-12-24 12:54:02 -0500 Don't generate ghosts in portal branches Also clean up / unify the code that decides where ghosts can place. We probably won't merge any major ghost reform in 0.21, so this is a stopgap to minimize griefing and avoid the balance issues that come from the fact that many of these portals can generate at a wide range of depths. Not sure if disabling wizlabs/desolation is necessary, but I did it for consistency. At the very least, the design of portal branches can make ghosts extremely annoying even for high level players (if you get the ac/hp bag variety). -------------------------------------------------------------------------------- 79970e1 | gammafunk | 2017-12-24 10:23:06 -0600 Show constriction and held statuses show properly (Pekkekke) The logic was inverted, making damaging constriction show up as a "Held" status light instead of "Constr" like it should. Fix this and a similar inversion for monster info. -------------------------------------------------------------------------------- 1119ec1 | advil | 2017-12-23 21:04:11 -0500 Add constriction information to xv in wizmode Also a debug message for zombie hands constriction. -------------------------------------------------------------------------------- 16f8e2c | advil | 2017-12-23 15:06:36 -0500 Fix fontbuf_line_reader in insert mode (aidanh) Remove some vestigial direct writing to crt. -------------------------------------------------------------------------------- 80d1a53 | advil | 2017-12-23 14:46:38 -0500 A couple instances of 0 -> nullptr -------------------------------------------------------------------------------- 55ff828 | advil | 2017-12-23 14:43:21 -0500 Attempt to fix the BVC constriction bug I still haven't replicated this, but as near as I can tell the problem is that in some special cases involving summons, `constriction_damage_defender` can lead to the iterator for constricting becoming invalid. (One symptom is that the crashes happen at a point where defender is nullptr.) This attempts to head off the problem by operating on a copy of constricting when calculating constriction damage. There may still be an underlying problem that this commit doesn't fix. -------------------------------------------------------------------------------- c60411f | gammafunk | 2017-12-23 05:33:01 -0600 Fix monster constriction data not getting marshalled Broken in 5bb8f4791 as part of removing actor.held, we forgot to replace a check with one of ::is_constricted(). A monster saved when it was constricted but not constricting something itself wouldn't have its constriction data marshalled. So it would lose all constriction state upon reload, causing a crash if the actor constricting the monster attempted to constrict it again. In this case, ::is_constricted() would return false for the monster, yet it would already be in its constrictor's constricting map. This commit re-adds the constrictor check and uses the appropriate methods to check constriction state instead of duplicating them. -------------------------------------------------------------------------------- 2783f27 | gammafunk | 2017-12-23 05:33:01 -0600 A status tile for zombie hands constriction (Ultraviolent4) Don't ask. -------------------------------------------------------------------------------- ed4c157 | gammafunk | 2017-12-23 05:33:01 -0600 Shorten some enum names Remove the BORGNJORS_ prefix from the enchantment, beam, zap, and mon-info enums, which makes them significantly shorter and is consistent how we name these enums for other spells. -------------------------------------------------------------------------------- 6cbd37f | Neil Moore | 2017-12-22 21:48:28 -0500 Don't guarantee Corpse Rot in Kiku's first book (hellmonk) Make Corpse Rot alternate with Animate Skeleton instead of Pain, so that Pain is the guaranteed spell. Bloodless characters are still guaranteed all three of those spells, while bloodful characters are guaranteed Sublimation of Blood, so everyone gets at least one spell that isn't in the Book of Necromancy. Also, simplify the logic for doing this a bit. -------------------------------------------------------------------------------- 0010f08 | Neil Moore | 2017-12-22 21:48:16 -0500 Guarantee a corpse-using spell in Kiku's second book. And add a comment about it. We have tried to enforce this guarantee in the past, but never actually wrote it down. -------------------------------------------------------------------------------- 6d9b277 | advil | 2017-12-22 09:26:20 -0500 Fix a comment (wheals) -------------------------------------------------------------------------------- 8e08f28 | gammafunk | 2017-12-22 02:22:13 -0600 Don't have Borgnjor's Vile Clutch constrict friendlies (mibe) I didn't intend for the spell to harm allies, but forgot to add the alignment check initially. With this commit, any allies in the effect area will be unaffected by the spell, and it will work normally on any hostiles in the same area. It's fair question as to whether an enchantment spell should have such favorable selective targeting like this, but it makes using other necromancy ally spells with this spell a lot less annoying. If this selectivity gets removed, the spell will need a proper warning prompt when friendlies would be affected. -------------------------------------------------------------------------------- 760ccf5 | gammafunk | 2017-12-22 02:03:38 -0600 Show the constriction icon monsters under Borg's Vile Clutch (mibe) We could have a spell-specific version of this icon to help disambiguation rare cases when it's not clear what the source of the constriction is, but this will do for now. -------------------------------------------------------------------------------- 5d64845 | gammafunk | 2017-12-21 22:50:25 -0600 More fully remove Cigotuvi's Embrace Descriptions removed and Lugonu's bribe vault uses animate dead in its place. -------------------------------------------------------------------------------- 88d601c | gammafunk | 2017-12-21 22:50:24 -0600 More fully remove Control Undead We missed spell descriptions as well as monster casting code, which wasn't actually used by any monster. In Lugonu's bribe vault, only use Dispel Undead for the randbook Kiku "taunt". -------------------------------------------------------------------------------- d3d47d3 | gammafunk | 2017-12-21 22:50:23 -0600 A spell tile for Borgnjor's Vile Clutch (CanOfWorms) -------------------------------------------------------------------------------- b17dc04 | gammafunk | 2017-12-21 22:50:23 -0600 Fix a method comment (amalloy, PR#678) Thanks for all the feedback in the pull request, amalloy! Closes #678. -------------------------------------------------------------------------------- eccb353 | gammafunk | 2017-12-21 22:50:22 -0600 Tweak a spell description (amalloy, PR#678) Hopefully clarify that the corpses supplying our zombie hands for Vile Clutch were already there and that it's not a corpse-using spell. -------------------------------------------------------------------------------- f540f80 | gammafunk | 2017-12-21 22:50:22 -0600 Correctly use a variable for spell noise (amalloy, PR#678) -------------------------------------------------------------------------------- 5c814b5 | gammafunk | 2017-12-21 22:50:21 -0600 Correct a comment (amalloy, PR#678) -------------------------------------------------------------------------------- d8688e6 | gammafunk | 2017-12-21 22:50:21 -0600 Use nullptr for a null pointer value (amalloy, PR#678) -------------------------------------------------------------------------------- 6bb3b7a | gammafunk | 2017-12-21 22:50:21 -0600 Allow Vile Clutch to work under Sacrifice Love (amalloy, PR#678) This spell isn't actually creating an controllable ally, and Sacrifice Love is otherwise consistent about blocking use of ally monsters. -------------------------------------------------------------------------------- cb6d0b3 | gammafunk | 2017-12-21 22:50:20 -0600 Tweak Kiku's book gifts and remove a double entry (amalloy, PR#678) When removing Control Undead, I simply had Kiku's second gift book always contain Animate dead since there was no other level 4 Necromancy spell. This isn't necessary, since we can choose between Animate Dead and Agony for the first spell, then Vile Clutch and Excruciating Wounds in the second. It's better to have more variety in Kiku's gifts. Also don't mistakenly double the weight of gifting Vile Clutch. -------------------------------------------------------------------------------- 8dea739 | gammafunk | 2017-12-21 22:50:20 -0600 Fix logic in a constriction damage check (amalloy, PR#678) Technically this case should never arise, but don't count not having a constriction attack as having a damaging constriction attack. -------------------------------------------------------------------------------- 417cd8a | gammafunk | 2017-12-21 22:50:19 -0600 Satisfy grammarians (amalloy, PR#678) "I know you didn't write this, but RIP grammar. It's a participle, not a gerund." --amalloy -------------------------------------------------------------------------------- d0a639d | gammafunk | 2017-12-21 22:50:19 -0600 Shorten a spell noise check (amalloy, PR#678) -------------------------------------------------------------------------------- 4099806 | gammafunk | 2017-12-21 22:50:19 -0600 Fix spacing (amalloy, PR#678) -------------------------------------------------------------------------------- d48fd3a | gammafunk | 2017-12-21 22:50:19 -0600 Require solid ground for Borgnjor's Vile Clutch (amalloy, PR#678) It's reasonable to not allow this spell to work when a monster is in deep water or lava given the theme of hands reaching up from the earth. Shallow water is still allowed. -------------------------------------------------------------------------------- 62db60e | gammafunk | 2017-12-21 22:50:18 -0600 Refactor constriction code (amalloy, PR#678) Don't have so many methods handle both direct and indirect constriction, and move repeatedly used logic into methods and functions. Be more consistent about stopping only direct constriction when the reason is based on physical changes, as opposed to level or LOS changes that would affect both forms. -------------------------------------------------------------------------------- e8387de | gammafunk | 2017-12-21 22:50:18 -0600 Remove an old comment Only applicable for save compat, and it will be confusingly left around when TAG MAJOR is increased if not removed. -------------------------------------------------------------------------------- 7a04ea1 | gammafunk | 2017-12-21 22:50:18 -0600 Remove the Twisted Resurrection icon since this is no longer a player spell. -------------------------------------------------------------------------------- b102ffe | gammafunk | 2017-12-21 22:50:18 -0600 Remove Cigotuvi's Embrace This spell had a terrible time competing with the other corpse-using spells and almost never saw actual use by players. It had to compete with corpse-using spells that already effectively increase your defense by making allies in addition to dealing damage through those allies. The time-degeneration aspect needed to limit degenerate tactics made deciding to use this spell over those spells even less likely. It may be possible to re-imagine this spell as a death-channel-like charm that gives defenses when a monster dies. This commit removes this spell until any such rework can be done. -------------------------------------------------------------------------------- e53b2ad | gammafunk | 2017-12-21 22:50:17 -0600 Remove Control Undead This spell was a cheap source of allies in the Necromancy school, a school that already gives hordes of cheap allies. It did this by turning nearly any monster with the undead holiness either directly into a source of out-of-LOS damage or indirectly into a source of damage through any summons the monster made. Due to the out-of-LOS and greater-than-usual ally management aspects of temporarily charmed monsters, enslavement is better kept on the wand of enslavement, which has limited uses due to charges. For dealing with summons via a spell we have aura of abjuration, which at least doesn't both shut down high-level undead summoners and deal loads of damage at the same time. Necromancy has a new damage spell, Borgnjor's Vile Clutch, so that addition and removing Control Undead help shift Necromancy away from feeling like Summonings Redux. -------------------------------------------------------------------------------- 3088ccc | gammafunk | 2017-12-21 22:49:22 -0600 A Level 5 Necromancy/Earth Spell: Borgnjor's Vile Clutch (mikee) A spell used to simultaneously damage a monster and hinder their movement. The in-game spell description: Calls forth hands from corpses interred beneath the dungeon floor long ago. Enemies caught in the area will be held in place and constricted until they break free. This spell helps move the focus of Necromancy a bit away from summoning-like effects and gives the school some synergy with the Earth school. This is a powerful spell likely to remain useful for damage and escape purposes the entire game, but it does require significant investment in two schools that otherwise don't have overlap in spells. For testing purposes it's currently in the Necromancer starting book (the Book of Necromancy), as well as the Book of Unlife and the Book of Dreams. Haven't you ever had a nightmare like that? It may not remain in the Book of Necromancy. Even with the future removal of Control Undead, this book will have 5 spells culminating with Vampiric Drain and Animate Dead, which are very strong. That said, this spell might have a place in that book, possibly depending on other adjustments to its spell list. Kiku's book gifts have been adjusted to include this spell where appropriate. Spell Details: Borgnjor's Vile Clutch is smite-targeted with range 5 and a 3x3 area of effect for applying its enchantment, allowing you to affect monsters up to 6 squares away. To be susceptible, a monster must be visible, on or over ground with a solid floor, meaning normal floor or shallow water, and not resistant to constriction (Note: the solid floor restriction was actually implemented in a subsequent commit). The latter means it must be substantial, not a slime, and not have spines. If a cast is successful, the monster gets a "zombie hands" enchantment and is constricted (and damaged from this constriction) immediately. The overall duration is based on spell-power and is generous enough that a monster is more likely to either escape or die from constriction damage before the enchantment expires. A monster going invisible doesn't stop the enchantment after it's been successfully applied, but the monster's square becoming no longer visible to the player does. Hence you can't constrict monsters out of LOS with this spell. During the enchantment, the monster is indirectly constricted, with the player free to move independently. A player could decide to cast this spell and move away in order to prevent the monster attacking them, but this will give the monster escape attempts as it tries to move. Damage is done over time according constriction rules, but with the constriction base damage calculated by spell-power: 2d(5 + spellpower / 15) Per usual constriction, damage increases over turns of constriction, with a 5 turn step-down that adds half as much additional damage on-average as was added in the previous 5 turns. The chance for a monster to break free depends on spell-power and the number of escape attempts they've made thus far (including the current one): (3 * attempts - 1) / (10 + spellpower / 5) For 40 spell-power, which is typical for when the spell is first able to be cast, this gives a 1/9 chance of the monster breaking free immediately, a 5/18 chance on the next turn, and an 8/18 chance on the third turn. If a monster does break free, it loses the enchantment and the spell can be re-cast. This spell is based on mikee's original tavern proposal at https://crawl.develz.org/tavern/viewtopic.php?p=321376&sid=e6c1c6bba9bbf5ad71299 a95682c8452#p321376 and on discussions had with him (and *not* elliptic) in ##crawl. Zombie Hands is a silly name for a spell, and that's not the name of this spell, except possibly in informal speech. There are no orcs on the moon, and there never will be. -------------------------------------------------------------------------------- 5bb8f47 | gammafunk | 2017-12-21 22:29:53 -0600 Refactor out an enum and actor property The held_type enum was vestigial, since the previous uses are now handled elsewhere. It's only used related to checks whether a monster's constriction does damage and doesn't need to be marshalled. Remove this property and add the necessary save compat to handle transferred games. The constriction damage check is now handled via an actor method. -------------------------------------------------------------------------------- 2314aa1 | Yermak | 2017-12-21 11:43:00 -0500 Require a single keypress to abort ?amnesia This commit puts ?amnesia in line with other scrolls that bring up a menu. There are still inconsistencies left though: any letter keypress that isn't legal exits ?amnesia's menu but not other scrolls' menus; any digit keypress does the opposite: doesn't exit ?amnesia's menu but exits other scrolls' menus; the first string of ?amnesia's menu is coloured in blue (Forget which spell?), the first string of other menus is in white (Identify which item?), the formatting is different too. Resolves #661 -------------------------------------------------------------------------------- e1710fc | Aidan Holm | 2017-12-21 09:56:48 -0500 Add uncollected rune/orb tiles for } menu The uncollected rune/orb tiles were made with the following imagemagick command: convert in.png -normalize +level 12%,18% -fx intensity out.png Brightness normalization isn't perfect, and perhaps the parts of each tile included in the greyed-out version should be restricted; e.g. mnoleg's rune is a little spotty. -------------------------------------------------------------------------------- eac747f | advil | 2017-12-21 09:43:03 -0500 Allow partial loading of bones files, and enforce level limits on load This is a bit hacky: it loads the bones file and then resaves a new one with any remaining ghosts. I'm not sure there's a good alternative without significantly rewriting the bones file format (which I don't really want to do). Previously, level ghost limits were enforced when saving a bones file; this switches to enforcing on load I expect this will make D:3-D:10 bones files fill up with ghosts quicker, not sure if this matters; it also may reduce the average number of ghosts on levels deeper than 10 (though probably not by a lot). If I'm understanding things right, it also preserves early-game ghosts that kill (non-undead) players, which were previously guaranteed to be used only once -- this may matter more than the first two effects (I'm not committed to this aspect of the change). The real end goal of this commit is to allow ghost loading one by one, In preparation for more substantial changes to player ghosts. -------------------------------------------------------------------------------- 79d79c4 | advil | 2017-12-21 09:43:03 -0500 Allow saving arbitrary vectors of ghosts This still uses the player's current level, so it's not independent of global state, but this change allows some more flexibility. -------------------------------------------------------------------------------- 49f8b85 | advil | 2017-12-21 09:43:03 -0500 Move some initialization inside ghost_init -------------------------------------------------------------------------------- 907874f | advil | 2017-12-21 09:43:03 -0500 Refactor ghost load/save to avoid global state This shouldn't have any impact on current behavior, but will be helpful for just about any changes that might happen to ghosts. -------------------------------------------------------------------------------- 8bd9a9d | advil | 2017-12-21 09:43:03 -0500 Don't create buggy ghosts in wizmode If they don't have hp, they lead to problems on save/load. -------------------------------------------------------------------------------- 185da8e | Alan Malloy | 2017-12-19 17:32:53 -0800 Clarify display of Fedhas food-based invocation powers (Stonar, #11330) -------------------------------------------------------------------------------- 2c32b0f | Neil Moore | 2017-12-18 23:58:50 -0500 Pull out likes_chunks ? HS_* : HS_* into a function. -------------------------------------------------------------------------------- 1b93aee | advil | 2017-12-18 23:38:41 -0500 Let carnivores get nutrition out of chunks above full (ranchugoldfish) Missed in the conversion to 1-level mutations, I think. Because of a somewhat odd fallthrough-ish setup in _chunk_nutrition, this was giving gourmand ("extremely unsatisfying") messaging and 4% nutrition to carnivorous players who ate chunks at HS_FULL or above, unless they were actually wearing gourmand. -------------------------------------------------------------------------------- b7d493d | Aidan Holm | 2017-12-18 14:00:07 -0800 Fix extra pixel in demonic rune tile -------------------------------------------------------------------------------- 5a59f16 | Filip Michałowski | 2017-12-18 12:05:24 -0800 Fixed no ability description on R-click (mantis #11231) -------------------------------------------------------------------------------- 50ea28b | Aidan Holm | 2017-12-18 10:58:05 -0500 Fix tiles not properly processing mouse move events The old continue statement never worked at all: its while loop had (!key) as a condition, so it was equivalent to a break. I've moved the check to the start of the MOUSEMOTION handling: there's no point partially processing the event if there's another mouse motion event right behind it. Also updated the comment text a little to clarify. This fix makes targeting mode gloriously smooth when rapidly moving the mouse; probably fixes lag in other places as well. -------------------------------------------------------------------------------- c6e9d75 | wheals | 2017-12-17 20:31:22 -0500 Move some relevant information upwards. -------------------------------------------------------------------------------- eea428d | wheals | 2017-12-17 20:27:53 -0500 Add information about building Crawl on Windows with the WSL. -------------------------------------------------------------------------------- e8bd881 | Isaac Sloat | 2017-12-17 16:06:43 -0600 Retire, belatedly. I don't have the time anymore to work on Crawl (and haven't had time for quite a while now), and I don't foresee myself revisiting this project in the future. I enjoyed contributing to this game, and deeply appreciate the devteam helping me learn the ropes a year ago. I'm looking forward to seeing what Crawl becomes in 2018 and onwards! "I wonder... What does this button do?" [skip ci] -------------------------------------------------------------------------------- 651f7c3 | gammafunk | 2017-12-17 12:31:22 -0500 Remove mutagenic chunks from db_lint [skip ci] -------------------------------------------------------------------------------- 1e3b116 | gammafunk | 2017-12-17 12:31:22 -0500 Remove some mutagenic chunks from a shop -------------------------------------------------------------------------------- 02dccac | Neil Moore | 2017-12-17 12:31:22 -0500 Remove mutagenic chunks from util/monster. Double doh. -------------------------------------------------------------------------------- 643a220 | Neil Moore | 2017-12-17 12:31:22 -0500 Fix broken logic, and remove some vestiges. Doh. The broken logic was in food.cc, where the relative precedences of >= and ?: were not respected. -------------------------------------------------------------------------------- b0796c2 | Neil Moore | 2017-12-17 12:31:22 -0500 Move mutagenic food brand tile to UNUSED. -------------------------------------------------------------------------------- 26a0572 | Neil Moore | 2017-12-17 12:31:22 -0500 Remove mutagenic chunks. Now that potion of mutation has a reasonable change of increasing the number of mutations, this secondary means of gaining single mutations is unnecessary. I for one will miss eating sky beast and ugly thing corpses, but it is for the best. -------------------------------------------------------------------------------- b40dbd6 | Neil Moore | 2017-12-17 12:31:22 -0500 Replace references to fruit in Fedhas ability descriptions. -------------------------------------------------------------------------------- 1eb5282 | Neil Moore | 2017-12-17 12:31:22 -0500 Remove unused fruit-eating messages. -------------------------------------------------------------------------------- 135f6fc | Neil Moore | 2017-12-17 12:31:22 -0500 Checkwhite. [skip ci] -------------------------------------------------------------------------------- 99be76f | Neil Moore | 2017-12-17 12:31:22 -0500 Rename Fruit acquirement back to Food. The only special effect of Fedhas is that foodless races can still acquire food, which doesn't matter for any extant race. -------------------------------------------------------------------------------- 4123852 | Neil Moore | 2017-12-17 12:31:22 -0500 Remove food_is_veggie. Since there is no longer any food prohibited to carnivores. Keep the lua function for compatibility, having it always return false. Also adjust preferred (yellow) food: return true only for Vp blood potions and Gh chunks. -------------------------------------------------------------------------------- fcb2e5d | Neil Moore | 2017-12-17 12:31:22 -0500 Correct objstat nutrition counts for food piles. It was counting only one item per pile towards TotalFooNutr. -------------------------------------------------------------------------------- 420a138 | Neil Moore | 2017-12-17 12:31:22 -0500 Reduce ration nutrition by about 37%. To make up for the increase in permafood from merging the food types. Perhaps it would be better (fewer keypresses) to instead keep the total nutrition and decrease the spawn rate, but that (1) is harder to do, (2) increases variance, and (3) makes it harder to tune food vaults, since the quantum of permafood would be coarser. -------------------------------------------------------------------------------- 5b9873a | Neil Moore | 2017-12-17 12:31:22 -0500 Decrease herb/carn ration nutrition. Preliminary objstat runs show a 36% increase in nutrition for normal characters, a 55% increase for herbivores, and a 72% increase for carnivores. Changing the herbivore/carnivore ration nutrition evens this out, resulting in a 36-37% increase for everyone. -------------------------------------------------------------------------------- 4bc9aef | Neil Moore | 2017-12-17 12:31:22 -0500 Remove obsolete commends in food.des. -------------------------------------------------------------------------------- 204c329 | Neil Moore | 2017-12-17 12:31:22 -0500 Fix swapped herb/carn food values. Doh. -------------------------------------------------------------------------------- b85e219 | Neil Moore | 2017-12-17 12:31:22 -0500 Merge fruit into rations. Existing fruit are converted to rations at a ratio of approximately 5:1, and Fedhas abilities are made to take two rations rather than one fruit. Adjust item weights and quantities in maps to approximate the original amount of nutrition (ish). -------------------------------------------------------------------------------- b1bc957 | Neil Moore | 2017-12-17 12:31:22 -0500 Remove royal jellies. The food, not the monster. RIP puns. -------------------------------------------------------------------------------- a054861 | Neil Moore | 2017-12-17 12:31:22 -0500 Merge bread and meat rations. Taking the average of the two for normal, herbivorous, and carnivorous nutrition. Move the old meat ration tile to UNUSED. The remaining tile should be updated to represent a balanced meal rather than simply bread. Remove some out-of-date nutrition totals from food.des. The new description needs translation, unless we're giving up on that. -------------------------------------------------------------------------------- 0678283 | Neil Moore | 2017-12-17 12:31:22 -0500 Simplify food_def. By listing the nutrition value for each type of vory, rather than a base nutrition value and modifiers. -------------------------------------------------------------------------------- 00fd8db | Neil Moore | 2017-12-17 12:31:22 -0500 Make food restriction mutations single-level. -------------------------------------------------------------------------------- d2a8542 | Neil Moore | 2017-12-17 12:18:28 -0500 Avoid some clang 6.0 warnings. The first change is serious: * Add a virtual destructor to Delay, to avoid undefined behaviour when shared_ptrs are freed. The other two are mostly cosmetic: * Remove an unused 'this' capture from a couple of lambdas. * Disable -Wtautological-unsigned-enum-zero-compare, which warns about construct such as: branch_type b = ...; if (b < 0 || b > NUM_BRANCHES) return false; However, another compiler might give branch_type a signed underlying type, in which case we would still want this check (since the "..." might have a bad casted or unmarshalled value). So, rather than remove the checks, we disable the warnings (but not similar warnings about non-enums). -------------------------------------------------------------------------------- 0e17531 | Neil Moore | 2017-12-17 12:01:15 -0500 Checkwhite. [skip ci] -------------------------------------------------------------------------------- 593960d | Chris Campbell | 2017-12-16 16:53:56 +0000 Fix messaging for Zin mutation potion cleansing -------------------------------------------------------------------------------- 3327e8e | advil | 2017-12-16 11:01:19 -0500 Let !mutation for Zin at ****** (160) just delete mutations First: this isn't intended to be a big major capstone ability even though it happens at high piety, but rather a logical extension of what Zin already does. This sequence of changes leaves zin without a "capstone" ability, which I think is fine. It does leave zin as a god you can join to keep your mutations stable, which seems to bother some people, so this could require more thought. After discussion in idea of using the gift timeout to delete mutations (the original premise of #522). The penalty for drinking !mut was already fairly trivial (10 piety, no penance), and at full piety one could drink these fairly safely -- except that this was communication extremely poorly. This change clarifies the situation, having Zin always cleanse potions of mutation at ******, with no piety hit. After some discussion in the dev channel (with elliptic and |amethyst) this seemed like a reasonable replacement for the capstone ability that lets zin players actually cure mutations that get stuck with. Below 160 piety, Zin still doesn't like drinking !mut (though it's not completely terrible to do); I bumped the piety penalty slightly to 15. At high but not full piety a !mut is still unlikely to add much in the way of new mutations, but will clear them, just at a piety cost. I considered having cleansing just happen unconditionally, but that seems to trivialize zin's mutation protection (as well as making god swapping to cure mutations, if indeed people do that, trivial). Resolves #522 -------------------------------------------------------------------------------- e0a6212 | advil | 2017-12-16 11:01:19 -0500 Change Zin's mutation protection to be 100% at ****** (160) piety. Previously this was 100% at 200 piety and 5% at 160 piety. There was some consensus in ##crawl-dev that having an uncommunicated max point like this was not great. -------------------------------------------------------------------------------- fd779ed | Alex Jurkiewicz | 2017-12-16 11:01:19 -0500 Rework gift messaging s/$GOD will $GIFT as your piety grows./$GOD will $GIFT as you gain piety./ This removes ambiguity around what happens when the player is at maximum piety. -------------------------------------------------------------------------------- 7e31929 | Alex Jurkiewicz | 2017-12-16 11:01:19 -0500 Move all god gifting logic into separate functions This cleans up the gifting logic a bit; despite the ugly diff this commit involves very little code change. Some gods didn't previously set success properly, and so it is conceivable that there will be effects of this happening now. (This is a partial commit of edb395ada69680e9c4055dfea4f325bd6acb3b27 from PR 522 by alexjurkiewicz.) -------------------------------------------------------------------------------- aa2292d | Alex Jurkiewicz | 2017-12-16 11:01:19 -0500 Remove Zin's capstone ability This capstone ability is a bit vestigial, and the following changes to !mutation will fill the needs of zinnites who want to get rid of mutations. (This is a partial commit of 8f7e939df157f7d82f08b4330cb204143006d066 in PR 522 by alexjurkiewicz) -------------------------------------------------------------------------------- 09e1869 | advil | 2017-12-16 10:51:53 -0500 Unbrace -------------------------------------------------------------------------------- 6746751 | advil | 2017-12-16 10:50:39 -0500 Remove an apport special case by using visible_igrd Now, apport will work on items in deep water iff the player can see those items; before it always failed on items deep water with a special message, regardless of whether the player could see items there. Should still always fail on lava. (Partial commit of c5b1387f630209d4807b.) -------------------------------------------------------------------------------- a7bb147 | advil | 2017-12-16 10:50:39 -0500 Fix a fallthrough -------------------------------------------------------------------------------- cc02c76 | advil | 2017-12-16 10:50:39 -0500 Docstrings, commenting, formatting -------------------------------------------------------------------------------- 50984c1 | advil | 2017-12-16 10:50:39 -0500 Use refactored push code for door sealing This should have exactly the same behavior, but this code is a bit complicated. -------------------------------------------------------------------------------- 7555bd9 | advil | 2017-12-16 10:50:38 -0500 Use new push code for abyss generation -------------------------------------------------------------------------------- a3e6914 | advil | 2017-12-16 10:50:38 -0500 Refactor imprison to use new push code This code is hopefully cleaner / better than the old version which is still entangled messily with sealing. -------------------------------------------------------------------------------- fc69bf2 | advil | 2017-12-16 10:50:38 -0500 Push items out of the way when a door is closed, if possible By popular demand, this version pushes items out of the way when closing a door, but refuses to close a door if there are items that can't be moved anywhere. (This can come up with deep water, lava, but also when something like door_vault with a gateway places against a wall.) It should be impossible to get items under doors on this version. -------------------------------------------------------------------------------- d16b88a | Alan Malloy | 2017-12-14 16:32:57 -0800 Don't leak information about unid scarves (Brathek, #11325) -------------------------------------------------------------------------------- d2fb950 | advil | 2017-12-14 12:24:03 -0500 Count WJC passive abilities in morgue files Also refactored walljump into its own function. -------------------------------------------------------------------------------- dbbf329 | Alan Malloy | 2017-12-13 11:30:34 -0800 Fix spelling (|amethyst) -------------------------------------------------------------------------------- 549b18d | advil | 2017-12-13 12:16:16 -0500 Add major tag version history to main repository I wrote this a while ago as a gist, but it seems like a useful supplementary document to the save compat documentation to be able to easily point new contributors to. -------------------------------------------------------------------------------- 08ce2bd | advil | 2017-12-13 11:25:04 -0500 Add malmutate to random effects (|amethyst) This is partly in response to the idea of using random effects lategame as a source of haste/invis on cleared levels, which apparently happens. This change provides a bit of potential long term cost for that beyond draining. As far as I'm aware monsters never use this wand, so this change doesn't add another source of malmutation aside from the self-targeting case. -------------------------------------------------------------------------------- b64b8ae | PabloMansanet | 2017-12-13 10:59:05 -0500 Normalize Number of Attacks under Serpent's Lash As it stands right now, fast races are unfairly punished and slow races rewarded when using Serpent's Lash. There is an aspect of SL that is unavoidable and makes it valuable for slow characters; a free move is worth more for them. However, since number of attacks scales proportionally to the character's move delay, they also enjoyed the additional advantage of hitting more often when lashing. This fix makes it so all characters calculate their number of attacks based on a normalized 10 aut move delay when using Serpent's Lash, regardless of their movement speed. Keep in mind that the formula still factors in attack delay as usual, so it won't allow a character to perform multiple hits with a long attack delay weapon. Resolves #663 -------------------------------------------------------------------------------- adff09b | Aidan Holm | 2017-12-13 00:17:37 -0800 Fix some outdated info in options guide (mibe420) This fixes mantis issue #11323 -------------------------------------------------------------------------------- acddea6 | Kyle Rawlins | 2017-12-11 16:28:34 -0500 Tweak INSTALL.txt wording more (amalloy) [skip ci] -------------------------------------------------------------------------------- 832612b | Kyle Rawlins | 2017-12-11 14:56:45 -0500 Update INSTALL.txt to be less optimistic about MSVC Previously, it made it sound like building with MSVC was supported and could actually work. [skip ci] -------------------------------------------------------------------------------- 8c7b3f5 | advil | 2017-12-08 11:21:02 -0500 Don't crash when a spell_slot rule checks a used letter (11250) Two changes really: first rename vars in add_spell_to_memory to reflect the implicit typing going on in this function, and then fix the now-obvious mistake (bad cast of a spell slot # to a spell_type). -------------------------------------------------------------------------------- f531e82 | Alan Malloy | 2017-12-07 13:39:52 -0800 Don't let liches keep holy-wrath weapons wielded (/u/hexaflexagon) -------------------------------------------------------------------------------- a86a592 | advil | 2017-12-07 10:25:45 -0500 Tweak walljump messaging This changes some of the messaging about failed walljump targeting from walljump v2 to walljump v3. This may result in more message spam, but it doesn't make sense to only complain if there's a monster in los any more. It also tweaks the cancellation behavior in some special cases. -------------------------------------------------------------------------------- 8a80c14 | PabloMansanet | 2017-12-07 10:25:45 -0500 Add prompt for wall jump Adds a GUI prompt before performing a wall jump. It is now necessary to walk against a wall twice to actually jump (although it does not need to be the same segment of wall, in case you change your opinion halfway). There is a RC file option (wall_jump_prompt) to disable this for players who are used to the old behaviour. Hopefully this will significantly reduce accidental wall jumps without forcing the user to detour through the ability menu, and since wall jump spam is not a thing anymore, the extra keypress is not an issue. Resolves #658 -------------------------------------------------------------------------------- a34b322 | Nikolai Lavsky | 2017-12-06 14:07:49 -0800 Add Cling flag to monster info This commit adds Cling to the list of flags displayed by the monster utility. -------------------------------------------------------------------------------- 614d7e5 | gammafunk | 2017-12-06 03:35:07 -0600 Don't allow scarves to generate as random artefacts Scarves are supposed to be distinguished from cloaks by having a special ego that's more powerful than what you could normally find on a cloak. Currently artefact scarves are essentially artefact cloaks guaranteed to have +0 AC. We could try to guarantee a scarf ego for these, but the egos are meant to be strong and standalone. The existing egos could do a better job of this, but that's something that can be worked on. This commit only allows scarves to generate as mundane items, at least until an unrand scarf gets designed. In the meantime we'll still have cloaks for random artefacts on this slot. -------------------------------------------------------------------------------- 22d298a | gammafunk | 2017-12-06 03:35:07 -0600 Slightly refactor some item artefact generation code Don't try (and fail) to repeatedly generate artefact weapons for types that don't allow it. Instead downgrade them to a good_item ahead of time. -------------------------------------------------------------------------------- a8338f0 | Alan Malloy | 2017-12-05 13:46:38 -0800 Mark scarf of spirit shield useless if you have it innately (/u/ClefAria) -------------------------------------------------------------------------------- 1cd18d1 | advil | 2017-12-04 16:20:56 -0500 Don't let Gn change their training settings in tiles (aagocs) This would still get fixed up on save/load, but within a play session on local tiles you could turn on/off training for individual skills in the mouse button panel. -------------------------------------------------------------------------------- 34ea15e | advil | 2017-12-04 16:20:56 -0500 Add some ASSERTs in case gnolls somehow get skills disabled (aagocs) This is a bug, but the previous behavior would be to trap the player in the skill menu until the force-quit the program. -------------------------------------------------------------------------------- b765982 | advil | 2017-12-04 00:29:36 -0500 Update sdl2 submodule with Makefile fix Did I do this right? -------------------------------------------------------------------------------- 43a1781 | advil | 2017-12-03 17:17:53 -0500 Fix a cut and paste error in b82119a2b70b -------------------------------------------------------------------------------- d76cfe0 | CanOfWorms | 2017-12-03 00:36:07 -0500 Updated Thermic Engine doll tile This changes the Thermic Engine's doll tile so that the fire portion looks less like the sticky flame status effect, which is placed in the same area. -------------------------------------------------------------------------------- aaff437 | Neil Moore | 2017-12-02 20:42:45 -0500 Fix an obsolete options example (minmay) [skip ci] -------------------------------------------------------------------------------- 8d4ebbe | gammafunk | 2017-12-02 02:26:34 -0600 Further improvements to the Hellbinder WizLab Use a simple list of common demons (tiers 3 and 4) vs tier 2 demons instead of hand-selecting from each tier and up-weight the tier 2 demons somewhat. Most of the tier 4 and even some tier 3 are weak for this depth, but they'll have a better chance to be relevant if the player is dealing with more of the tier 2. Also increase the size of the Hellbinder's entourage somewhat. For the map layout, open up the area between the bottom two chambers so that there'll be less separation between the map's monsters. In the Hellbinder's chamber, make the Makhleb's altar area have a wall on the other side to give cover to those poor demons from nasty player ranged attacks. -------------------------------------------------------------------------------- cd93bbd | gammafunk | 2017-12-02 02:26:28 -0600 Small adjustments to Cloud Mage WizLab Add doors to the starting area and down-weight fire crabs, since those are pretty weak at this depth. Also improve the Cloud Mage's melee weapon by removing freezing egos on shorblades and adding a possible staff of air. -------------------------------------------------------------------------------- dcb3f5e | advil | 2017-11-30 22:10:09 -0500 Remove old outline font code This code (which was intended for doing a simple form of anti-aliasing on mono glyphs) predates the use of freetype, and in particular the use of a freetype with high-quality modern anti-aliasing. It was accidentally being used on non-mono fonts with bad results. In principle this code could be made to work again by having freetype generate a mono bitmap (FT_RENDER_MODE_MONO), but in practice this seems a bit pointless. -------------------------------------------------------------------------------- 0ee8fc4 | advil | 2017-11-30 22:10:09 -0500 Don't load any fonts as "outline" fonts Freetype antialiases by default, and so the glyph-loading code was applying a simple pseudo-antialiasing algorithm to an already anti-aliased bitmap. The result is a lot of dark pixels with incorrect alpha values, which don't blend properly. I'm not really sure why these specific cases where loaded as outline fonts, but as far as I can tell, nothing should be. -------------------------------------------------------------------------------- 5c865af | Alan Malloy | 2017-11-30 18:20:34 -0800 Improve level 2 MUT_HOP description (longer than what?) -------------------------------------------------------------------------------- 5070ee8 | advil | 2017-11-30 11:11:46 -0500 Prevent a bad linebreak in the skill menu -------------------------------------------------------------------------------- ecc5317 | advil | 2017-11-28 08:47:50 -0500 Do a better job setting cursor size in fontbuf_line_reader (aidanh) The previous version was basically just choosing a random number that accidentally worked out on retina. -------------------------------------------------------------------------------- f08a75f | Neil Moore | 2017-11-27 16:48:02 -0500 Correct grammar for AT_POUNCE and AT_SPORE in x-v (#11300) -------------------------------------------------------------------------------- a8f6b7a | advil | 2017-11-26 18:06:53 -0500 Indicate retina support in mac app bundles I have no idea what the implications of setting NSPrincipalClass are, but apparently you're supposed to do it for retina apps, and it doesn't seem to break anything. -------------------------------------------------------------------------------- a0ee87a | advil | 2017-11-26 16:09:16 -0600 Update Makefile for SDL-2.0.7 on OS X Apparently some more frameworks are needed to link SDL. -------------------------------------------------------------------------------- 0135c5a | gammafunk | 2017-11-26 16:09:16 -0600 Update SDL2 contrib to 2.0.7 This contribe includes an upstream fix that allows MSYS2/mingw compilation to work again. -------------------------------------------------------------------------------- 2eda330 | advil | 2017-11-24 15:21:54 -0500 Remove debugging dprf -------------------------------------------------------------------------------- 52e4085 | advil | 2017-11-24 15:19:32 -0500 Make stabbable tile statuses compatible with attitude statuses Allow ?? icons to show for neutral monsters. This still won't show the ?? icons with friendly monsters (11295) because these icons don't mean confused/sleeping/etc right now -- they mean stabbable. (Friendly monsters are never stabbable.) This probably isn't very intuitive to players (I had no idea myself)... -------------------------------------------------------------------------------- 5dcb9f8 | advil | 2017-11-24 15:19:32 -0500 Reprint monster info after wizmode xF -------------------------------------------------------------------------------- d7c8661 | gammafunk | 2017-11-24 13:51:12 -0600 Prevent getting stranded in Baileys (EMTedronai) Several baileys have areas behind deep water or lava where you can fly to pick up loot or where you might get teleported to. Give these areas exit portals in case players get access to these areas through temporary means, since forcing players to quit if they make a miscalculation about their flight duration isn't something we want. -------------------------------------------------------------------------------- ca0307c | advil | 2017-11-24 10:55:20 -0500 Reword whirlwind descriptions to cue reduced damage (ultraviolent4) "Lightly" might be too weak for 80% but it's an improvement. -------------------------------------------------------------------------------- ab55e39 | PabloMansanet | 2017-11-24 10:17:45 -0500 Fix Whirlwind pin Used to only be cleared after a movement turn, instead of after any time consuming action, which made it able to kite enemies for longer. -------------------------------------------------------------------------------- 1b60429 | gammafunk | 2017-11-23 22:15:06 -0600 WebTiles support for the monster pinned status icon This is for the monster status afflicted by Wu Jian Council's Whirlwind attack. -------------------------------------------------------------------------------- 2afff41 | gammafunk | 2017-11-23 22:06:30 -0600 Add a Tiles monster icon for the pinned status (Ultraviolent4, #11293) This is for the monster status afflicted by Wu Jian Council's Whirlwind attack. -------------------------------------------------------------------------------- 696f58f | gammafunk | 2017-11-22 14:34:37 -0600 Clean up transporter landing sites in a vault (amalloy) In grunt_nemelex_the_gamble, remove the transporter landing site in the area opposite where the player reached, so they won't mistakenly think it has a corresponding transporter they could use to reach that area. -------------------------------------------------------------------------------- 7c12b18 | gammafunk | 2017-11-22 14:34:37 -0600 Clean up item placement and generation in a vault (|amethyst) Don't allow grunt_nemelex_the_gamble to generate items in potentially unreachable areas, and spread its loot items out more decoratively. -------------------------------------------------------------------------------- 4b1fdcf | gammafunk | 2017-11-22 14:34:37 -0600 Move some vault save compat code to compat.des -------------------------------------------------------------------------------- 22212c1 | advil | 2017-11-22 15:33:23 -0500 Correctly handle dragging between displays with different DPI Yes, I realize I'm insane. -------------------------------------------------------------------------------- ef8ecb5 | advil | 2017-11-22 15:33:23 -0500 Refactor high-DPI code This was all over the place (with fonts, wm, and glmanager storing it separately), and fairly confusing on top of that. This change centralizes the density information and code for converting between device / logical pixels. Should have no impact on behavior. -------------------------------------------------------------------------------- a0408e1 | Neil Moore | 2017-11-22 14:13:39 -0500 Make Nemelex's gamble a gamble again. With the addition of transporter landing sites, the player can tell in advance whether the main transporter leads to prize or peril. Prevent that by putting an unused transporter landing in the other possible destination. amalloy pointed out that this could lead to confusion, because the player might think that somewhere on the level there is a transporter that lands in the correct place. Ideally we'd clear out both landing sites (or at least the unused one) after taking the main transporter. I'll leave that for someone who knows markers better than I do. -------------------------------------------------------------------------------- 87dc6a9 | Aidan Holm | 2017-11-22 13:15:18 -0500 Don't (auto)travel via stairs into exclusions [Committer's note: This time without crashing when taking unvisited stairs. -nfm] -------------------------------------------------------------------------------- 4f54bde | Neil Moore | 2017-11-22 13:04:23 -0500 Remove another varargs function. _create_random_element_colour_calc was just a varargs wrapper around the random_element_colour_calc constructor (plus a new). -------------------------------------------------------------------------------- c317228 | gammafunk | 2017-11-22 11:57:54 -0600 Fix monster wand assessment (saltwaterterrapin) Monsters use a formula to decide whether they want to use a given wand based on the monster's HD and the wand's charge value. This formula was broken when the wand charge value was changed to mean the max charge a wand could generate with. Fix this, so that Ijyb, Maurice, and others can happily zap players again. -------------------------------------------------------------------------------- a335af4 | Alan Malloy | 2017-11-22 09:37:22 -0800 Revert "Don't (auto)travel via stairs into exclusions" This reverts commit e9ed347cad6fc9e730c97155aa8f1c449e08c3b4. It caused a segfault on trunk. Reverting for now so it stops breaking, while we have time to fix it. -------------------------------------------------------------------------------- 0e05f1c | Neil Moore | 2017-11-22 12:00:57 -0500 Remove a varargs function and simplify (advil) It was used as a wrapper for a non-varargs function that takes a vector, but with C++11 and initializer lists, we can more easily call the base version directly. While we're at it, remove a few parameters, since the function is only ever called from one place. I didn't go so far as removing the list of {distance, replacement} pairs and making that a static array inside the function, but maybe I should have. -------------------------------------------------------------------------------- 2875ce1 | Neil Moore | 2017-11-22 12:00:57 -0500 Checkwhite. [skip ci] -------------------------------------------------------------------------------- cd31912 | advil | 2017-11-22 10:42:29 -0500 Remove a few references to wasting charges -------------------------------------------------------------------------------- d70176a | advil | 2017-11-22 10:38:31 -0500 Remove pakellas device charge id (everyone gets this now) -------------------------------------------------------------------------------- 31fed6f | advil | 2017-11-22 10:23:52 -0500 Clean up a case of charge id conditioning on pakellas (Yermak, 11289) When picking up an un-id'd paralysis wand, this caused a "will waste charges" message. Possibly passive_t::identify_devices can be removed altogether? Also, is there any way to waste charges any more? -------------------------------------------------------------------------------- e9ed347 | Aidan Holm | 2017-11-22 07:06:29 -0800 Don't (auto)travel via stairs into exclusions This prevents auto-travel via staircases that lead to excluded areas, and asks when traversing staircases into an excluded area. This works only when the staircase's destination is known, and single-tile exclusions on the destination staircase (indicating excluded travel in the reverse direction) are ignored. -------------------------------------------------------------------------------- 5da0f0d | Alan Malloy | 2017-11-21 22:17:42 -0800 Mild copy-editing of changelog.txt -------------------------------------------------------------------------------- 139aec4 | gammafunk | 2017-11-22 00:07:44 -0600 Changelog through 0.21-a0-478-g6b4cb3753b -------------------------------------------------------------------------------- 6b4cb37 | Yermak | 2017-11-21 22:02:20 -0800 Remove Haste reference -------------------------------------------------------------------------------- afc4b18 | Yermak | 2017-11-21 22:01:30 -0800 Add size to % screen -------------------------------------------------------------------------------- d103f4b | advil | 2017-11-21 18:13:31 -0500 Make the anomolous due_jungle_book statue grey (|amethyst) Turns out there was a grey elephant statue tile ready and waiting. -------------------------------------------------------------------------------- cc397bb | advil | 2017-11-21 18:01:26 -0500 Make that one statue in due_jungle_book diggable This is a bit confusing now because none of the other statues in this vault are diggable, but at least as a quick fix this removes one (and possibly the only) case where setting trees on fire was important. (As a player, I think that *this* statue is diggable is cued reasonably well, but this change implies that the other statues are, and might make someone waste a wand charge.) -------------------------------------------------------------------------------- 05767a1 | Neil Moore | 2017-11-21 13:28:47 -0500 Fix brand weapon tile (#11288). Recharging removal changed the order of tiles, but that has to match the enum. Also, add a comment to item-prop-enum.h warning about changing the order. -------------------------------------------------------------------------------- 129e634 | Neil Moore | 2017-11-21 13:28:46 -0500 Checkwhite [skip ci] -------------------------------------------------------------------------------- 223bcb9 | gammafunk | 2017-11-21 00:47:38 -0600 Properly handle autopickup of unknown wands (Zibokwe, |amethyst) Empty wands could previously generate normally, so there were calls to a function that checks for a known empty wand for purposes of hints mode, usefulness, and the Tiles UI. Recent wand charge merging commits had this check look only at charges and not identification, since empty wands no longer normally exist. But this broke the autopickup of unidentified wands due to how the usefulness check is performed, based on what knowledge the player has of such items. This commit restores the empty check to only return true when the wand is both empty and identified, and it either removes the check or tags it for removal with the next major version increase. Empty wands will be properly handled in transferred games and unided wands will have autopickup work normally. After a major version increase, the checks aren't necessary since the items could only be created in wizmode, and even then they won't cause problems when evoked due to a empty charge check in the evocation code. -------------------------------------------------------------------------------- d587bd5 | Chris Campbell | 2017-11-21 00:20:34 +0000 Even more completely remove recharging -------------------------------------------------------------------------------- eeb3749 | Alan Malloy | 2017-11-20 15:55:11 -0800 Put trees on the inside of layout_gridlike, not outside They used to be semitransparent so it made sense for them to form a decorative border around something, but they've been opaque for quite a while now. -------------------------------------------------------------------------------- 268bfee | Alan Malloy | 2017-11-20 15:55:11 -0800 Allow dungeon builder to bulldoze trees for reachability Thanks to /u/azrac_ for reminding us about this bug. -------------------------------------------------------------------------------- 2b5f0e8 | Alan Malloy | 2017-11-20 15:55:11 -0800 Add diagnostic for dungeon connectivity failures -------------------------------------------------------------------------------- 4c202ba | Chris Campbell | 2017-11-20 23:17:53 +0000 More completely remove recharging Remove the scroll from some vaults, and remove support for the actual effect itself too (since it already didn't function properly on merged wand stacks). -------------------------------------------------------------------------------- a1252f7 | Chris Campbell | 2017-11-20 23:15:32 +0000 Add a missing TAG_MAJOR_VERSION check -------------------------------------------------------------------------------- 8120a92 | Chris Campbell | 2017-11-20 22:30:10 +0000 De-pluralise an acquirement prompt entry -------------------------------------------------------------------------------- 0a5f80b | Chris Campbell | 2017-11-20 22:22:53 +0000 Remove wands of lightning To further reduce the very large number of distinct types of direct damage wands/evocables. With its removal, wand of flame is also the only remaining wand that directly duplicates a player spell. -------------------------------------------------------------------------------- c071dca | gammafunk | 2017-11-20 13:25:03 -0600 Don't show scrolls of recharging on the recognized item menu (Yermak) -------------------------------------------------------------------------------- 102393a | gammafunk | 2017-11-20 13:07:52 -0600 Don't show identified wands in the identification scroll menu (reddit) -------------------------------------------------------------------------------- 2470eb2 | Chris Campbell | 2017-11-20 12:42:21 +0000 Make some move-slowing effects more consistent Don't randomise monster speed in shallow water (as with players, just apply a fixed penalty). Don't give monsters a bonus to movespeed under their own Leda's effect (no monsters cast it anyway). Make Root and Frozen apply the same level of slow movement, instead of very slightly different amounts (they do still apply different amounts to players and monsters). -------------------------------------------------------------------------------- 737a915 | gammafunk | 2017-11-19 21:37:41 -0600 Remove wands of confusion This wand is differentiated from the other hex wands ostensibly by being low-level yet having many charges generated. Unfortunately confusion is basically as effective as paralysis at disabling monsters, so in practice a wand of confusion was much more powerful than a wand of paralysis. It's also a wand that duplicates a low-level spell that's easily castable for most characters that find it. Lowering its charges wouldn't make it more interesting as a wand compared to the other four existing hex wands, so this commit removes it. Its weight in wand generation and acquirement is given to paralysis and enslavement with some distributed evenly to the other types in the case of basic item generation. Wanderers receive wands of paralysis when they previously would have received wands of confusion. -------------------------------------------------------------------------------- b644aa4 | gammafunk | 2017-11-19 11:38:01 -0600 Wand Charge Merging V: Remove scrolls of recharging Scrolls of recharging exist to generate more wand charges, yet those are not scarce. Recently wands were changed to no longer lose charges through being partially identified and to have charges merged upon pickup, both of which give access to more wand charges in inventory. Even before those changes, it was common to have many wand charges available in a game and yet have extra scrolls of recharging in inventory. It would be possible to try to extend the effect of this scroll to other evokables, but this can't be done in a universal way for all types, and balance-wise it's better to not generate so many extra evocable charges. This commit removes the scroll of recharging from generation, leaving the scrolls in-game where it's already generated. Its weight for scroll generation is evenly distributed amongst the other scroll types. For the evocations trove, the three recharging scroll items are replaced with two more of the standard evocable or stave items and one guaranteed manual of evocations. Recharging code remains for any games that still have the scroll or Pakellas (which has a wand recharge ability), but is marked for removal after the next save major version increase. -------------------------------------------------------------------------------- d6801f7 | gammafunk | 2017-11-19 11:37:44 -0600 Wand Charge Merging IV: Wands of the same type merge charges upon pickup When the player picks up a wand of a type they already have in inventory, the charges from the new wand are merged into the existing one, and the new wand no longer exists. -------------------------------------------------------------------------------- 6cf28c1 | gammafunk | 2017-11-19 11:35:39 -0600 Remove the wand draining effect from Zot traps This was essentially a form of item destruction and wasn't a very interesting effect. It encouraged the player to drop wands before intentionally stepping on Zot traps (e.g. in Zot:5) or just in general when Zot traps were around and specific types of wands aren't likely to be useful in the near-term. Thankfully Zot traps have plenty of interesting and dangerous effects as it is. -------------------------------------------------------------------------------- 0e0890e | gammafunk | 2017-11-19 11:32:06 -0600 Wand Charge Merging III: Wands are destroyed when out of charges When a player or monster uses the last charge of a wand, the wand is destroyed. In subsequent commits, wands will merge charges upon pickup and recharging scrolls will be removed, so there's no need to have empty wands exist as items. Existing empty wands in current games will continue to exist, but empty wands are no longer generated in special vaults and shops and shouldn't appear in normal games. We still have code to check for empty charges before evoking a wand, and empty wands can still be created in wizmode by setting charges to 0. It might be good to refactor code to make a wand item's existence more directly connected to its charges in some way. -------------------------------------------------------------------------------- d679150 | gammafunk | 2017-11-19 11:31:35 -0600 Remove Pakellas Supercharge Wands no longer have a cap on charges, so this ability is of no use even in trunk games where players worship Pakellas. -------------------------------------------------------------------------------- e566d14 | gammafunk | 2017-11-19 11:28:52 -0600 Wand Charge Merging II: Remove the cap on wand charges A subsequent commit will have wand charges merge between those of the same type, so it's necessary to remove the cap on wand charges. -------------------------------------------------------------------------------- f61038a | gammafunk | 2017-11-19 11:18:46 -0600 Wand Charge Merging I: Remove wand charge identification This is is the first commit in a series to simplify wand management, removing details that are not interesting but that the player has to deal with frequently. The major changes from the player perspective are: 1) Wand charges merge upon pickup when the player already has a wand of that type. 2) Wands no longer have a cap on the number of charges. 3) Remove wand charge identification; now a wand's charges are seen when picked up. 4) Remove scrolls of recharging, since wand charges are already readily available, and the aforementioned changes make them even more so. 5) Wands are destroyed when their last charge is used. This first commit removes wand charge identification, making the current charges of a wand visible when the wand type is identified (which still happens upon pickup). There were a couple proposals to allow the charge wasting/identification system to work with wand charge merging, but they involved complicated presentation of charge information. The player would want to know identified charges, the range of the unidentified charges, and the average number of unidentified charges (based on how many wands of that type they had picked up). Displaying all this information isn't worth it just to make scrolls of identification a bit more useful, so for now we simply identify charge information whenever the wand type is identified. -------------------------------------------------------------------------------- 74feaab | gammafunk | 2017-11-18 14:34:17 -0600 Remove some unused enum values Some inventory selectors were no longer in use, yet the enum values weren't changed to reflect this. -------------------------------------------------------------------------------- 9a9e23e | gammafunk | 2017-11-18 14:34:17 -0600 Mark Pakellas code for removal with major version change -------------------------------------------------------------------------------- d87a9b2 | advil | 2017-11-17 09:59:32 -0500 Add labeling for pinned monsters This needs to be signaled somehow. Resolves #652. See https://github.com/crawl/crawl/pull/652 for detailed discussion of these WJC changes. -------------------------------------------------------------------------------- c17f1d9 | PabloMansanet | 2017-11-17 09:59:32 -0500 Refactor and fix Whirlwind Pin -Moved the Whirlwind Pin effect to a more appropriate location -Took bloat out of main and into god-passive along with other WJC functions -Gave Whirlwind Pin a longer default duration just in case, but kept clearing it at the beginning of the player's turn. -------------------------------------------------------------------------------- 972c5ad | PabloMansanet | 2017-11-17 09:59:32 -0500 Fix order of ability unlocks Ensure casting Serpent's Lash can never cause martial attacks to become unavailable. -------------------------------------------------------------------------------- 8a73434 | PabloMansanet | 2017-11-17 09:59:32 -0500 Add WJC Whirlwind pin effect - Whirlwind now pins enemies in place. Indefinite enchantment that prevents the first monster move (only motion, not actions) and disappears. -------------------------------------------------------------------------------- a30aec3 | PabloMansanet | 2017-11-17 09:59:32 -0500 Rework WJC Serpent's Lash - Halve the piety cost and reduce exhaustion time - Make it first ability to unlock (followed by Lunge, Whirlwind, Wall Jump and HoE) - Slightly reduce the bonus damage (50% - 40%) - Martial attacks made under Serpent's Lash cannot miss - (cosmetic) Since Distraction is no more, made Serpent's Lash blow up targets on death instead, as people have reported really liking the martial gore. -------------------------------------------------------------------------------- 4bd3c4a | PabloMansanet | 2017-11-17 09:59:32 -0500 Rework WJC Wall Jump - Remove distraction mechanic - Remove target limitation - Double time spent in Wall Jump (normalize with walk speed) - Double number of outgoing attacks to compensate - Adapt Serpent's Lash so it works with two-turn Wall Jump -------------------------------------------------------------------------------- 29a2fec | gammafunk | 2017-11-16 20:05:36 -0600 Remove the secret Crawl ASDF project added by the Shadow Dev Team You were never supposed to know of its existence! (It was actually just a normal crawl binary mistakenly added to the repo in the previous commit) -------------------------------------------------------------------------------- aba41f5 | advil | 2017-11-16 18:20:06 -0500 Check for slime walls in i_feel_safe The main issue this commit aims to fix is that lua `feel_safe` uses this function, and really shouldn't return true if the player is in a position where they can be damaged by waiting or taking an unrelated action to the damage source. It could have weird consequences that I haven't spotted, but I did a quick check through i_feel_safe calls and there doesn't seem to be anything too bad. This is a followup of sorts to 56314776da1, and moves one of the checks there into `i_feel_safe`. The particular issue was brought up by the lua butchering script described here: https://crawl.develz.org/tavern/viewtopic.php?p=322979#p322979 Previously, it endlessly loops if there is a corpse next to a slime wall until the corpse goes away (usually the player dies first). For the record that's not a great way to do auto butchering, I wouldn't be shocked if there are other endless loop corner cases it triggers. But, I do think it was making a reasonable assumption about `feel_safe` that was violated. There's also a little bit of rewording I did while checking i_feel_safe calls. -------------------------------------------------------------------------------- 848f44b | advil | 2017-11-11 20:33:49 -0500 Try a little harder to fit the whole tab region in a row This may or may not look great on other computers/fonts than the three that I've tested this on, feel free to change or propose changes if you notice problems. This is basically to make things look better on a retina mac (because of interactions with high-DPI font rendering), but I tested it on two non-retina displays including one that's very small. -------------------------------------------------------------------------------- 6e1775c | advil | 2017-11-11 19:58:37 -0500 Better handle fractional advances in font glyphs in tiles On a high-DPI display, fonts can (and do) use advances that are fractional relative to logical pixels. These were rendering properly, but not being incorporated into layout calculations. Previously, crawl used the truncated logical glyph width to calculate layout (dropping the fractional part), which was leading to all sorts of problems at the edges of the screen. E.g. the stat region with the default font and size had an extra device pixel per glyph relative to what layout calculated its size as, so it extended off the edge of the window. This also impacted the height and width of the message display. This commit properly uses device pixels when calculating text region widths for layout. It also now rounds when converting glyph widths to logical pixels, which will lead to excess whitespace rather than cut off text. There's still a bunch of code that uses multiplication by character widths (mostly in menus) and so isn't properly handling fractional advances yet. (Multiplication by character widths is deprecated!) -------------------------------------------------------------------------------- 28109cb | Alan Malloy | 2017-11-09 15:21:18 -0800 Simplify magic_mapping() by naming some intermediate locals -------------------------------------------------------------------------------- abf74bb | advil | 2017-11-09 12:18:24 -0500 Let mmapping work on saves where forgetting marked everything mapped 4af208bdd212 fixes the forget command, this commit lets mmapping work on saves where forget was used before the fix. -------------------------------------------------------------------------------- 4af208b | Alan Malloy | 2017-11-09 08:51:52 -0800 Make ?mapping work even after forgetting level map (Beargit, EMTedronai) -------------------------------------------------------------------------------- e5bf024 | advil | 2017-11-08 18:22:14 -0500 Add an option for people who really like to restart (Zibokwe) This option allows fully restoring the quick restart behavior I changed in cbc62810bc49e and 34efee411a0df0. I made this a distinct option, with default false, because I don't think it will be the expected behavior for new players, and because lumping it in with existing options would easily lead to a situation where if you set a combo in an rc file, the only way to quit the game is to save or crash. That situation still is possible, but you have to want it to happen. There's now a lot of options around restarting, but at the moment I don't see a way of simplifying it and keeping both old and new behavior (where the new behavior is arguably much more like what new players would expect). -------------------------------------------------------------------------------- f55f1f5 | advil | 2017-11-08 10:21:06 -0500 Don't show training target button when describing non-inv items This applies to item lookup, and when examining floor items. Training target numeric info is still shown as long as you are in a game. It could maybe be convenient to have this button around in some cases, but it doesn't work at all from the lookup screen (which doesn't even render formatted text), so it's better for now to just disable it. -------------------------------------------------------------------------------- 5164969 | advil | 2017-11-08 09:54:51 -0500 Retain skill focusing when setting a target from inv (Shaded Knight) -------------------------------------------------------------------------------- 806c6c2 | advil | 2017-11-07 21:11:52 -0500 Checkwhite / unbrace -------------------------------------------------------------------------------- e7131c6 | advil | 2017-11-07 21:11:52 -0500 Several fixes for repeat/again This commit: * handles empty key sequences gracefully (no crashing on 0`` in a new game). * cleans up state after a repeat cancellation or again failure more carefully. Before, it was possible to get odd/inconsistent states where the previous command didn't match the key sequence. * clears repeat/again state in _reset_game. I wouldn't say this will fix every weirdness in these commands, but this fixes everything I was able to replicate. -------------------------------------------------------------------------------- 6a4a694 | gammafunk | 2017-11-07 14:44:29 -0600 Update descriptions of the Ogre species (Pereza0) In the selection screen description, describe ogres as being competent at magic instead of excellent, and mention their potential use of armour in the manual. Clean up some wording in both places. Closes #646. [skip ci] -------------------------------------------------------------------------------- 01fcc59 | Yermak | 2017-11-07 09:36:54 -0500 Fix identification of floor items in edge cases Items (wands and books) under player will be identified after using Shadow Step, transport, stairs or passage of Golubria. Also Merfolk will now properly change its form after shadowstepping into water. moveto_location_effects() uses 'stepped = true' here because it prevents splash upon landing on water, which fits current behaviour. The only side effect here is that Tonado will run for its full duration while usual blink shortens it severely. Resolves #644 -------------------------------------------------------------------------------- 517d9b7 | Aidan Holm | 2017-11-07 09:08:21 -0500 Add new card tile to lookup-help menu Makes this menu a bit more consistent with the others. I've placed the new tile image in the items/misc with the decks, but really it's more of a GUI icon. -------------------------------------------------------------------------------- f361398 | Aidan Holm | 2017-11-07 09:08:21 -0500 Add item tiles to lookup-help menu -------------------------------------------------------------------------------- 08060ca | Aidan Holm | 2017-11-07 09:08:21 -0500 Show branch tiles in lookup-help menu -------------------------------------------------------------------------------- c5fe4b4 | Aidan Holm | 2017-11-07 08:56:51 -0500 Fix sidebar for large tile_font_stat_size Earlier changes hardcoded the sidebar pixel width. This change now bases the sidebar width mostly on the width of the stat HUD (dependent on its font size), but with a minimum width in tiles as well. There's also a bunch of dead code removal, and the way the stat HUD is fitted into the sidebar is improved slightly as well. -------------------------------------------------------------------------------- 98080a9 | gammafunk | 2017-11-04 09:33:54 -0500 Add EMTedronai to the mailmap -------------------------------------------------------------------------------- d837b2d | gammafunk | 2017-11-04 09:15:28 -0500 Add Yermak to the mailmap -------------------------------------------------------------------------------- 639b47e | Aidan Holm | 2017-11-04 09:41:25 -0400 Fix webtiles section boundaries not being updated -------------------------------------------------------------------------------- 05a6460 | Aidan Holm | 2017-11-04 09:40:05 -0400 Fix health minibars being drawn outside viewport This can happen when viewing the map with X and then panning. -------------------------------------------------------------------------------- 5b1b836 | Yermak | 2017-11-04 09:35:24 -0400 Improve Maurice's message and fix #11241 -------------------------------------------------------------------------------- fc1ce30 | Aidan Holm | 2017-11-03 10:43:47 -0400 Fix title screen lingering when tile_skip_title = true Fixes the tile screen showing on other LAYER_TILE_CONTROL layouts (scenes?) when tile_skip_title = true, such as the doll edit screen. Not sure if the redraw should be conditional, but it works fine like this. Resolves #633. -------------------------------------------------------------------------------- 54598c2 | Yermak | 2017-11-03 10:29:16 -0400 Remove reference to cleared levels from 'Out of the depths' paragraph. -------------------------------------------------------------------------------- d80284d | Aidan Holm | 2017-11-03 09:51:23 -0400 Make dream sheep tile face left Also optimized the tile while I'm at it, why not... -------------------------------------------------------------------------------- dc3326c | Aidan Holm | 2017-11-03 09:13:56 -0400 Fix issue orders prompt when not berserk The previous message should be flushed regardless of whether the player is berserk. The if-condition is causing the "Anything else - Cancel" text to not appear. -------------------------------------------------------------------------------- 0adc95b | Mindcrafter | 2017-11-02 16:03:17 -0700 Improve WJC messaging (sokol815) (#648) -------------------------------------------------------------------------------- 79d0e6c | Mindcrafter | 2017-11-02 13:56:17 -0700 Improve messaging for passage of Golubria (#645) -------------------------------------------------------------------------------- 9d6f0e4 | gammafunk | 2017-11-02 10:57:20 -0500 Give the Vortex monster spell a description -------------------------------------------------------------------------------- ba8bdf1 | Neil Moore | 2017-11-01 19:02:45 -0400 Fix teleport closets in water_boxes_lemuel. -------------------------------------------------------------------------------- 4a39e9c | gammafunk | 2017-11-01 15:18:57 -0500 Rework of the Hall of the Hellbinder This map wasn't very threatening for its depth and had layout problems as well as fixed placement of monsters. The old layout had two far apart sections that could be used to avoid half of the monsters, either skipping to the final area or just clear the map while facing few monsters at a time. Overall the changes in this commit will make the map more threatening but with more generally useful reward items. The new layout has the two chamber sections much closer together, allowing monsters from both sides to more easily travel between. Additionally the kobold and deep elf demonologists have been replaced with a demonspawn blood saint or black sun, and the demons now have randomization as to their location and numbers, placing more monsters overall. Finally, the Hellbinder, who has a better spellset from a previous commit, gets some demonic accompaniment in his chamber and now wields the majin-bo instead of stashing it with his other loot. For said loot, I've scattered 8 consumable items in the chambers that still have some extra weight on thematic items useful in the wizlab, like scrolls of summoning and holy word, or a summoning book containing the aura of abjuration spell. The main loot pile of 12 items has somewhat increased weighting for demon weapons, small weighting for artefact jewellery or a good_item cloak, and uses star_item as the most highly weighted class. One item from this will be a summoning school randbook, as before. -------------------------------------------------------------------------------- a58e5a4 | gammafunk | 2017-11-01 15:17:57 -0500 Adjust the Hellbinder's spell spell set. It previously had only the lower-level demon summoning spells together with its hurl damnation, haste, and blink Away spells. This made it sort of just the old version of deep elf sorcerer. In the soon-to-be revamped wizlab map where the Hellbinder places, this monster always has demon monsters generated nearby, which could prevent it from using damnation effectively. This commit replaces summon minor demon with summon greater demon and give that somewhat higher weight. We could try harder to make this monster something more creative than a cross between a deep elf sorcerer and a demonologist, but this change will at least upgrade its threat level for now. -------------------------------------------------------------------------------- dc66bd4 | gammafunk | 2017-11-01 15:15:08 -0500 Give the Cerebov statue tile a DES name This allows us to choose this specific tile for granite statues. -------------------------------------------------------------------------------- 2694e31 | gammafunk | 2017-11-01 15:15:07 -0500 Revamp of the Cloud Mage WizLab This vault places a very limited set of air-themed monsters, some of which like wind drakes and (especially) insubstantial wisps are too easy for WizLab depth. Much of the loot had a strong focus on flavor (e.g. potions of flight) over being a reasonable reward. This commit revamps the monster list, removing insubstantial wisps and adding shock serpents and spark wasps, two fast electricity themed monsters, as well as the three crab monsters, death drakes, and blizzard demons for more cloud effects. Cloud monsters make the fog machines more relevant, since the player can fight near these to minimize placement of harmful clouds. The biggest weight is on air elementals, but the weights are so that none of these new monsters appear too frequently on-average, especially the nastier ones. The loot has been updated to feature more general consumables potions/scrolls in the two early loot piles that were formerly potion-only, with some extra weight on haste, and a much smaller amount on !resistance, ?silence, and ?fog. One of these will contain an thematic non-consumable item (arguably) helpful for the map. The main loot pile behind the Cloud Mage is updated to feature some higher quality item classes (superb_item and star_item) in addition to the ordinary items. The chance for plain rings of flight are replaced by artefact rings of flight and good_item boots of flying and running. -------------------------------------------------------------------------------- 7d0f330 | gammafunk | 2017-11-01 15:15:07 -0500 Give Sojobo wind immunity Now that her air elementals can use Vortex, rWind will prevent her from taking a large amount of damage every time she summons them. -------------------------------------------------------------------------------- bd10913 | gammafunk | 2017-11-01 15:15:07 -0500 Show wind immunity in monster info This was a hidden resistance that a few monsters have, and it effects player spells like Airstrike and Tornado, as well as the fan of gales, so it's better to show when a monster is immune to such things. -------------------------------------------------------------------------------- c23e797 | gammafunk | 2017-11-01 15:15:07 -0500 Give air elementals Vortex, a weakened form of Tornado Air elementals currently appear primarily in Elf, but they're not effective monsters there. They are extremely fast at speed 25, but have low HP and a weak attack, so when they appear individually they do little damage. This commit gives air elementals a Vortex ability that is a 3-radius tornado with half the normal duration (3 turns instead of 6). Air elementals can close distance very quickly in order to use this effectively, but the limited radius still gives players an opportunity to kill the monster at range if avoiding any damage is necessary. The limited duration prevents the damage levels from being too high, especially since the player can often avoid damage for at least one of the turns when the spell is active. Air elementals have low HD, which gives them low spell-power, so Vortex has a spell-power boost relative to Tornado to make the damage reasonable. A future commit will adjust placement of air elementals in any early vaults or vaults where they otherwise would not be appropriate. -------------------------------------------------------------------------------- c134197 | gammafunk | 2017-11-01 12:39:04 -0500 Add a -force-map option for objstat and mapstat Using this forces those statistics modes to always place the given map on every level generated. This is useful when getting e.g. objstat data for a map on a given level without having to edit the DES file to force the map to place. The map is tested for existence and minivaults are properly handled, but the validity of the map for the given level isn't checked. -------------------------------------------------------------------------------- f2af9a1 | Mindcrafter | 2017-10-31 14:00:03 -0700 Add 'Size' section to game manual (#643) -------------------------------------------------------------------------------- 291f19a | Alan Malloy | 2017-10-25 16:03:24 -0700 Add Yermak to CREDITS -------------------------------------------------------------------------------- 4337635 | Yermak | 2017-10-25 15:57:09 -0700 Fix LARGE_BONE_PLATES colouring in Statue Form -------------------------------------------------------------------------------- cbae7d1 | Alan Malloy | 2017-10-25 14:42:38 -0700 Clarify command-line instructions (Yermak) -------------------------------------------------------------------------------- 0b6bec4 | Aidan Holm | 2017-10-20 17:30:01 -0400 Fix formatted_scroller::line_down() returning wrong boolean 'true' indicates the menu position has changed. -------------------------------------------------------------------------------- 417d9d2 | Aidan Holm | 2017-10-19 18:59:34 -0400 Move MEL_TITLE sectioning to MEL_END_OF_SECTION Commit e7c3f7c9a3ced171f522a22d201bda9d37fed8f0 prevented some in-game menus from being displayed, such as the eating menu when there was a choice of items from both inventory and floor. This fixes that by moving some overloaded functionality into its own MenuEntryLevel. -------------------------------------------------------------------------------- de6fda0 | Aidan Holm | 2017-10-19 18:59:34 -0400 Fix tiles message region resize behaviour This fixes a bug where the message region would add and remove lines repeatedly as the window was slowly made less tall. -------------------------------------------------------------------------------- 2ec2765 | advil | 2017-10-19 15:55:09 -0400 Update mailmap and credits [skip ci] -------------------------------------------------------------------------------- 4a2d380 | Jean Martel | 2017-10-19 10:58:43 -0400 Fix wizmode mutation resistance bug (#623) Remove an unnecessary unwind; force=true for the call to mutate already does this. -------------------------------------------------------------------------------- a924934 | Aidan Holm | 2017-10-18 09:02:41 -0400 Fix tiles UI not being redrawn on expose I use the awesomewm window manager, and when switching to a workspace (tag) with a running instance of crawl-tiles, the tiles window takes several seconds to redraw. Before it redraws, the window contains whatever was in that section of the screen on the previous workspace. This bug does not appear when minimizing and then restoring tiles. -------------------------------------------------------------------------------- 39bf9ee | nlavsky | 2017-10-18 07:21:01 -0400 Fix message displayed when Gh tries to quaff potion of mutation (#622) After f20264c8 ghouls get the "You cannot mutate at present." message when they try to quaff an identified potion of mutation. The "at present" part is not correct, since it's a permanent restriction. This commit fixes that and clarifies the function's description. -------------------------------------------------------------------------------- dc75ea7 | advil | 2017-10-17 19:32:44 -0400 Use device pixels for clipping, not logical pixels glScissor requires device pixels, so without this transformation, clipping wasn't working well on high-DPI devices (e.g. retina). -------------------------------------------------------------------------------- fa7d736 | Aidan Holm | 2017-10-17 22:16:45 +0800 Fix resize+keypress crash on local tiles Sometimes a crash was being caused while rendering the dungeon view tile region, after enlarging the window. This was caused by the tile region having been expanded to fill the new available space, but its backing crawl_view_buffer still having the old size, because the redraw began before the resize operation was complete: 1) TilesFramework::getch_ck() gets WME_RESIZE, does layout, queues a redraw, amd returns CK_REDRAW. 2) This return value bubbles up to _getch_mul() on the way to the for loop in _get_next_keycode(), which has an if-test that should pass for the returned value CK_REDRAW. If it passed, it would resize the crawl_view_buffer to the new size. 3) But execution never gets there, because getch_mul() will check for more key events, calling TilesFramework::getch_ck() again if there are any. getch_ck() will see the queued redraw, and trigger the crash. The fix is to pass the CK_REDRAW sentinel back immediately. Also added assertions to verify that the sizes match. -------------------------------------------------------------------------------- f28a9d0 | Aidan Holm | 2017-10-17 22:16:45 +0800 Fix leaking a freetype context per loaded font The old fontwrapper didn't free its FT_Library handles after use, and used a new one for each call to load_font(). Now, there's a single static FT_Library instance. This code also used to leak memory buffers containing the ttf file contents; that's been fixed as well. -------------------------------------------------------------------------------- 8b534f6 | Aidan Holm | 2017-10-17 22:16:45 +0800 Remove dead code, update docs for tile_layout_priority The functionality corresponding to the gold_turn item in the tile_layout_priority has been removed; this removes some leftover code and removes all mention of the gold_turn item. The item is now ignored to preserve compatibility with existing config files. -------------------------------------------------------------------------------- eff00c1 | Aidan Holm | 2017-10-17 22:16:45 +0800 Ensure TabbedRegion is given enough height to render tab icons -------------------------------------------------------------------------------- c8658d2 | Aidan Holm | 2017-10-17 22:16:45 +0800 Remove useless visual separator The \n======\n separator is not needed, as the file added to the scroller is bracketed by MEL_TITLEs, which prevents scrolling or viewing multiple sections at once. Additionally, the separator has its width specified at menu construction time; this width will not remain appropriate after a resize event. -------------------------------------------------------------------------------- e7c3f7c | Aidan Holm | 2017-10-17 22:16:45 +0800 Stop drawing current menu page after a MEL_TITLE entry This fixes multi-part menus with sections separated by MEL_TITLE entries not working correctly after a resize. Specifically, the scrolling code used to scroll down until any MEL_TITLE entries in the next page were just about to be scrolled into view, but ignored any in the currently visible page. This necessitated padding overly-short sections with empty lines (see code removed from command.cc). Now, menu rendering stops at the first MEL_TITLE within the page region, and the downward-scrolling code handles this correctly. -------------------------------------------------------------------------------- dfbc2d2 | Aidan Holm | 2017-10-17 22:16:45 +0800 Fix menu rendering when window size is reduced This fixes an issue where text rendered by the menu would extend beyond the bounds of the text buffer on tiles, causing memory corruption and a crash. This issue was caused by the maximum number of lines to write being pre-determined, during menu construction. This fix recalculates pagesize based on the maximum page size given by the MenuDisplay instance (which varies on resize), and the menu instance-specific max_pagesize, which is used by some menus to limit the menu size. The smaller of the two is chosen for (re)rendering the menu. -------------------------------------------------------------------------------- 53b8672 | Aidan Holm | 2017-10-17 22:16:45 +0800 Clean unused code, add assertion This code didn't seem to do anything, so I removed it. The assertion guards against memory corruption that occurs when you try to write text after a cgotoxy() with y out of bounds. Note that a similar assert for x is inappropriate, as the for loop truncates any horizontally-out-of-bounds text, and parts of the UI rely on this. -------------------------------------------------------------------------------- 14d58c3 | Aidan Holm | 2017-10-17 22:16:45 +0800 Fix a few tiles rendering glitches - Fixes cursors still being shown on the dungeon viewport even when the cursor has left the dungeon region. - Fixes updated alt text not always being redrawn. -------------------------------------------------------------------------------- 8ed9be3 | Aidan Holm | 2017-10-17 22:16:45 +0800 Improve layout+spacing of tiles main dungeon view This fix does the following: - The sidebar now has fixed width, and is always flush against the right side of the window. - The messages box sticks to the bottom of the screen. - The main dungeon view expands to fill all remaining space, showing parts of partially visible tiles. -------------------------------------------------------------------------------- 740c049 | Aidan Holm | 2017-10-17 22:16:44 +0800 Fix tiles minimap viewport indicator leaving the sidebar Fixed: on wide windows where the character is on the left of the map, the rectangle outline over the minimap indicating the current viewport could overlap the dungeon viewport, leaving the sidebar. -------------------------------------------------------------------------------- a801f16 | Aidan Holm | 2017-10-17 22:16:44 +0800 Fix sidebar monster/inv background flicker on resize On every resize event m_flavour is resized and re-randomized. This caused the individual tiles of the monster and inventory sidebar panels to change between tile variants randomly. This fix uses the panel tile's index to choose the tile instead of m_flavour, so the individual tiles vary in appearance, but not randomly. -------------------------------------------------------------------------------- 43d289b | Aidan Holm | 2017-10-17 22:16:44 +0800 Add GL render clipping support for local tiles -------------------------------------------------------------------------------- d65dc97 | Neil Moore | 2017-10-16 23:04:19 -0400 Staticalise a few functions. Also extract a common subexpression into a variable, and constify another variable. I was tempted to make _exit_type_to_string return a const char *, but since TilesFramework::send_exit_reason needs a string, it wouldn't have actually saved any allocations. It will be nice when we can use string_view. -------------------------------------------------------------------------------- df9fdda | Neil Moore | 2017-10-16 22:48:24 -0400 Avoid a warning from gcc. Depending on optimisation level, it didn't know that we actually covered all the cases here. And theoretically someone could have passed in a casted int and caused us to return who knows what. -------------------------------------------------------------------------------- 022a3cd | Neil Moore | 2017-10-16 22:31:38 -0400 Fix an _add_insert_commands varargs overrun (aidanh, advil) It was impossible to pass a list of zero commands, because the first command argument was *not* considered as a possible terminator. Instead, one needed to pass (..., "desc", 0, 0) or something along those lines. A few callers *didn't* do this, instead passing just a single 0 under the incorrect assumption that it would terminate the varargs list. By sheer luck (because there was typically a zero left somewhere on the stack, from the previous call), that didn't usually crash. Fix the problem by ripping out the varargs altogether, instead taking just a vector of commands that can then be passed on directly to insert_commands. For the version of _add_insert_commands with an "int space_to_colon" argument, the first command actually was treated differently, because it went before the colon instead of replacing a percent sign. Keep it as a separate argument (of the correct type) for that overload, and move it before the description, to match _add_command. FIXME: Those two overloads work differently enough that they should probably not have the same name... -------------------------------------------------------------------------------- 5e037d9 | Neil Moore | 2017-10-16 22:31:36 -0400 Take an argument by const reference. There was no reason to require a copy/move here. -------------------------------------------------------------------------------- ab89da6 | Neil Moore | 2017-10-16 22:31:36 -0400 Don't have a member with the same name as its type. -------------------------------------------------------------------------------- 7cd14ec | advil | 2017-10-16 20:40:53 -0400 Various cleanups, including enum classing the game exit type (|amethyst) Also changed it so leaving the dungeon acts like winning/dying in terms of whether the startup menu can be bypassed. -------------------------------------------------------------------------------- af2b63a | advil | 2017-10-16 19:43:55 -0400 Delete an obsolete comment that I missed [skip ci] -------------------------------------------------------------------------------- cbc6281 | advil | 2017-10-16 19:21:25 -0400 Further tweak restart behavior and options (Zibokwe) This started as an attempt to restore some behavior I'd broken on the previous restart commit where in local tiles (e.g. if restart_after_game was true) if you had the name and combo set in your rc, death dropped you right into a new game. This quick restart mode will now work again (and will work in consoles with `restart_after_game = true`). I didn't quite conform to the old behavior in that quitting will exit to the menu -- this is so there is a way to quit crawl besides saving. We'll see if this bugs tiles players who like to quit a lot, if there are any. In the process of this I re-overengineered the startup/restart process and fixed a few things that have always annoyed me. Most importantly, aborting game setup menus that use game_ended will now never exit the game and always restart (except for dgl/webtiles with the right settings). Now, setting `name_bypasses_menu=false` on webtiles will more cleanly use the menu in webtiles (though it's still somewhat flaky, and arena doesn't work). As before this *shouldn't* have an impact on DGL, hopefully I did that right. -------------------------------------------------------------------------------- d0ff781 | gammafunk | 2017-10-15 19:47:04 -0500 Fix usage of a prompt function that expects a format string -------------------------------------------------------------------------------- d56c60c | advil | 2017-10-15 16:19:54 -0400 Add an option to allow having a name set to not bypass the menu This is primarily to get easy access to the menu on a non-DGL webtiles build. It's ignored on DGL builds. I didn't do anything to avoid having to log in still, and I noticed that this is slightly flaky on some saves for webtiles == you may need to move or something to force a reload. Reminder: dcss uses a login specific rc file for regular webtiles builds, so that's where you'd need to set this. -------------------------------------------------------------------------------- 34efee4 | advil | 2017-10-15 15:36:53 -0400 Over-elaborately enable restart_after_game by default Having this off by default (for console builds) is very confusing, especially to new players, especially for the tutorials. However, as usual, change is hard. This commit tries to balance a bunch of things: what the previous default behavior was, what expectations users might have based on existing rc settings, the behavior on webtiles builds, and the goal of having this option enabled. I did this by making the option ternary (idea due to |amethyst). If set to `false`, quitting/dying will always exit. If set to `true`, quitting/dying will always return to the menu. If set to `maybe`, quitting/dying will return to the menu just in case the startup options (i.e. name) don't bypass the startup menu, otherwise it will exit. As before, the behavior on saving for the maybe/yes cases is configurable with a separate option. The new default for console/webtiles builds is maybe. Local tiles keep their previous default of true. For the vast majority of users who (I'm assuming) don't have a name set in their rc, this will amount to setting the default to true. -------------------------------------------------------------------------------- 397cdb2 | advil | 2017-10-14 23:22:20 -0400 Make the manual bonus match the help (11139) and simplify This was complicated because once upon a time manuals and crosstraining were shown in the same slot as a sum. Things are simpler now. -------------------------------------------------------------------------------- 45f8505 | elliptic | 2017-10-14 17:44:04 -0400 Prevent random switching of gnoll titles when their top skills are tied. For example, previously a GnBe would randomly switch back and forth between titles for Fighting and for its chosen weapon skill (before Invocations surpassed both of them at XL 22ish, that is). This should no longer happen. The reason for replacing shuffle_array() by reverse() instead of just removing that line for gnolls is that this way is consistent with the initial title selection (via init_skill_order()). -------------------------------------------------------------------------------- feb02eb | elliptic | 2017-10-14 17:44:04 -0400 Fix title weirdnesses when two skills are tied. Previously it was occasionally possible to lose a title for a skill while training it and nothing else. Now this shouldn't happen. -------------------------------------------------------------------------------- 9170151 | advil | 2017-10-14 12:59:19 -0400 Prevent cursor from disappearing on right arrow in skill menu (10760) The problem was that the aptitude text item wasn't properly set as unhighlightable, and when the links explicitly provided by the skill menu code give a nullptr, the default menu arrow code takes over. This picks the aptitude item as the next highlightable item to the right (skipping over the intervening box, which happens to not be highlightable, even before EditableTextItem). I think it wasn't changing appearance visually because the default highlight colour is just the default colour for a FormattedTextItem (though I didn't test this carefully). -------------------------------------------------------------------------------- 814e052 | advil | 2017-10-14 08:32:59 -0400 Wipe out text input prefill more thoroughly (11258) Can't assume that the cursor starts at the end, given the other changes I made to text input. -------------------------------------------------------------------------------- bd1fde4 | Corin Buchanan-Howland | 2017-10-13 17:48:02 -0400 Fix a typo (amalloy) -------------------------------------------------------------------------------- 3c89746 | Corin Buchanan-Howland | 2017-10-13 17:33:40 -0400 Try to improve a clumsy Ru message. -------------------------------------------------------------------------------- b6c469d | Corin Buchanan-Howland | 2017-10-13 17:16:48 -0400 Spell out that all Ru's powers scale with piety in Ru god text -------------------------------------------------------------------------------- 4efd3f9 | elliptic | 2017-10-12 20:14:52 -0400 Adjust Gnoll apts: spell schools to +6, Invocations to +9. This helps somewhat with early-game gnoll casters being sort of silly, and also later on it was a little too easy to get high-level spells usable. Having a high Invocations apt helps to open up more god choices and also ensures that a gnoll without a manual will end up with a cool title. -------------------------------------------------------------------------------- 65c131b | advil | 2017-10-12 12:04:26 -0400 Fix boosted HP/Str coloring for berserk cooldown in webtiles (11257) The problem was that "berserk" matched both "berserking" and "berserk cooldown". This fixes that problem but might be nice to be less ad-hoc about statuses with cooldown & naming conventions. (The cooldown part is pretty consistent but the active versions aren't.) -------------------------------------------------------------------------------- b7bfbb7 | advil | 2017-10-12 11:31:50 -0400 Clarify berserk messaging (0011256) In practice, the subside message happens the turn before berserk ends, but this is kind of confusing and also inconsistent with how crawl uses "subside" elsewhere (as the end of the duration). -------------------------------------------------------------------------------- 8928369 | advil | 2017-10-12 00:19:18 -0400 More constraints on partial species name in options (|amethyst) This now only matches the initial part of the species name, and requires a match of >=2 characters. Combo abbreviations always take priority over initial matches. There's still occasional weirdness due to the species enum order, but that won't matter for most people. (E.g. "hi" fails because it matches high elf before hill orc.) -------------------------------------------------------------------------------- 1680097 | gammafunk | 2017-10-11 22:59:01 -0500 Reduce average number of levels needed for unique Pan lords (hellmonk) Currently it takes about 27 Pandemonium levels on-average to see all 4 unique pan lord levels. This is a lot of levels to slog through when any character that can survive a dozen pan levels or so is highly likely to be able to survive another dozen. This commit increases the chance of generating unique Pan lord levels so that it will take about 14 levels to see all 4 on-average. The starting chance of seeing unique Pan lord is 1/20, increasing to a little better than 1/3 after 9 floors, and it takes about 5 floors on-average to see the first one. -------------------------------------------------------------------------------- 45b0a09 | Alan Malloy | 2017-10-11 11:26:03 -0700 Make Pan=>Abyss portals random again (Siegurt) They were accidentally made guaranteed back in 2014 and nobody noticed. -------------------------------------------------------------------------------- b842874 | advil | 2017-10-11 10:09:57 -0400 Use case-insensitive comparison for species selection in options This case was broken, because the species field gets lowercased and str_to_species requires an uppercase first character. This function will also allow partial matches, which is comparable to how job choice already behaves. -------------------------------------------------------------------------------- 1b01441 | advil | 2017-10-11 09:58:02 -0400 Revert an accidental change in 3b2a47dc5e4a (wheals) Will probably do this eventually, but I didn't intend to commit it here. -------------------------------------------------------------------------------- 3b2a47d | advil | 2017-10-11 09:27:04 -0400 Improve error messaging for incompatible combos on new game This is re 11252, which I can't replicate locally. -------------------------------------------------------------------------------- 5b8f553 | advil | 2017-10-09 17:42:01 -0400 Fix a (presumed) precision mistake in ad-hoc fixed point code Caused by grouping multiplication by scale after a division. This change is a very slight buff for gargoyle AC under some conditions (and is much less steppy), but nerfing them by doing low-precision truncating division is kind of silly, so I'm going to assume it's a mistake. -------------------------------------------------------------------------------- 38363bb | advil | 2017-10-08 19:34:32 -0400 Better handle mindelay skills > 27 This fixes the obvious parts of the item description, but there may still be a bug here; there was a crash apparently from looking at sniper at crossbows 27 that I couldn't replicate. -------------------------------------------------------------------------------- 2362ee1 | advil | 2017-10-08 12:02:33 -0400 Make cigotuvi's and ozocobu's act symmetrically Before, casting ozo's would remove cigotuvi's, but not vice versa, so casting it in the right order would get you both. -------------------------------------------------------------------------------- 0c35859 | advil | 2017-10-06 12:17:32 -0400 Make some output.cc code very slightly less brittle This probably only comes up in fulldebug situations, but it's better to group colour/print/goto statements together in case of side-effects. Thanks to |amethyst for help with this one. -------------------------------------------------------------------------------- a060c75 | advil | 2017-10-05 15:19:28 -0400 Fix gnoll / trog interaction (gammafunk) Trog will no longer disable magic skills on join for Trog characters, and fixup will properly repair those. I think the disabling was always happening, but recent commits change the commit logic. (Also remove an unneeded dprf.) -------------------------------------------------------------------------------- d570db1 | Neil Moore | 2017-10-05 06:56:05 -0400 Changelog for 0.21 trunk. Including Wu Jian Council, which was dropped from the changelog before 0.20 release. [skip ci] -------------------------------------------------------------------------------- 330ab2c | Neil Moore | 2017-10-04 09:39:30 -0400 Describe entry layout in species-data.h As in mon-data.h. [skip ci] -------------------------------------------------------------------------------- e0b234a | Neil Moore | 2017-10-04 09:25:48 -0400 Unbrace [skip ci] -------------------------------------------------------------------------------- 2144152 | advil | 2017-10-03 23:51:39 -0400 Actually save a header file It's amazing what bs my compiler will let through. -------------------------------------------------------------------------------- b326f1e | advil | 2017-10-03 23:39:18 -0400 Disable traps & stabbing in a slightly different way This once again ensures that the training percentages are calculated correctly for gnoll training with sacrificed skills (previous commit got this part wrong), and though I think they are used only in the UI, the you.training values are calculated correctly as well. -------------------------------------------------------------------------------- 97c3cd8 | advil | 2017-10-03 23:39:04 -0400 checkwhite [skip ci] -------------------------------------------------------------------------------- 5efb6f4 | advil | 2017-10-03 21:55:13 -0400 Actually disable traps+stabbing for gnolls I think it didn't actually impact training due to fc3775ba1767, but gnolls had you.train set to TRAINING_ENABLED for all skills on game start, and this was making useless skills (including traps,stabbing) show up in morgues. This commit also enforces TRAINING_DISABLED for useless skills on fixup, which should correct games in progress. -------------------------------------------------------------------------------- 325bad4 | advil | 2017-10-03 20:59:24 -0400 Fix prompt_for_quantity on webtiles The use of macro_buf_add was causing weird behavior on this prompt in webtiles (and is a bad idea anyways); this version just uses a prefill. I also tweaked some of the webtiles prefill logic to work better for this case, and let prompt_for_int/float handle esc properly (before if you type a number and then hit esc, it returns that number). Most places that call this function should already be able to handle canceling, because you could do this by hitting enter in an empty text box. -------------------------------------------------------------------------------- e64e265 | advil | 2017-10-03 18:08:21 -0400 Return kill-to-begin to its previous state The version before this commit has a silly mistake in how to calculate what to overwrite. This fix, like the previous version, will not gracefully handle killing double-wide characters. Also cleaned up this function slightly. -------------------------------------------------------------------------------- 36cf2fc | John Olender | 2017-10-02 18:45:02 -0400 initfile.cc: Make sure unistd.h is included for Cygwin targets. Also, update other target checks in the #ifdef chain to check against an appropriate TARGET_OS macro. -------------------------------------------------------------------------------- 90186ba | Velros | 2017-10-02 18:39:18 -0400 Ghoul HP regeneration near submerged enemies While waiting in an area if there are submerged enemies nearby ghoul hp does not regenerate. Occurs very often in swamp with swamp worms. Mutation text in game states: You do not regenerate when monsters are visible. Changed the mutation to ignore submerged enemies. (Issue's: 0011199, 0011197 on Mantis.) -------------------------------------------------------------------------------- e1c23e8 | Rolf K | 2017-10-02 18:34:15 -0400 Fixes for coding style. -------------------------------------------------------------------------------- 0866e71 | Rolf K | 2017-10-02 18:34:15 -0400 Change scarf message to something more funny. -------------------------------------------------------------------------------- 37e4d12 | Rolf K | 2017-10-02 18:34:15 -0400 Fix indentation some more. -------------------------------------------------------------------------------- 50a1d56 | Rolf K | 2017-10-02 18:34:15 -0400 Fix indentation. -------------------------------------------------------------------------------- 4eece15 | Rolf K | 2017-10-02 18:34:15 -0400 Make Xom do different things to cloaks and scarves (in pseudo_miscast). -------------------------------------------------------------------------------- fb491b4 | advil | 2017-10-01 10:07:33 -0400 Clean up some fulldebug spam for gnolls Previously this would, on training, swamp the message log with, for every skill: for every increase of 1 skill point: print a (locally) unique debug message -------------------------------------------------------------------------------- 461fa0c | gammafunk | 2017-10-01 02:38:13 -0500 Re-allow Trog worship for Gnolls Forbidding Gnolls from Trog worship was only strictly necessary because of one extremely minor aspect of Trog's conduct, which is penance for training magical schools, something that is involuntary for Gnolls. The conduct itself likely wouldn't need to exist if we e.g. forbade melee with magical staves instead. Although Trog is not the most interesting god choice for Gnolls, no one likes worship restrictions for very technical reasons, and flavor-wise there's no justification either. This commit has Trog ignore penance for Gnolls due to training spells, but still give the usual penance for memorizing or casting spells. Berserker is also re-enabled as a background choice. The god penance map code needs some generalization to better handle cases like these, which is noted in code comments. -------------------------------------------------------------------------------- 12f17e1 | elliptic | 2017-10-01 01:25:47 -0400 Fix transferred non-gnolls being told that they quaffed a potion of experience. This was harmless and only affected transferred saves, but might as well fix it I guess before more people report it. -------------------------------------------------------------------------------- 6a5e2f3 | elliptic | 2017-09-30 23:38:41 -0400 Allow gnolls to sacrifice arcana, but don't give them extra piety for sacrificing a skill. This is fine now that it doesn't speed up training their other skills. -------------------------------------------------------------------------------- e65fa8f | elliptic | 2017-09-30 21:31:14 -0400 Scale you.total_experience and you.exp_available by 10. This simplifies some of the skill cost code and makes gnoll skill training smoother. Note that these two variables are only used inside the skill training code, and you.experience is still unscaled. -------------------------------------------------------------------------------- 4d9243b | elliptic | 2017-09-30 21:29:36 -0400 Don't claim to have quaffed !exp after saving and reloading a gnoll. -------------------------------------------------------------------------------- 246b9df | elliptic | 2017-09-30 18:31:03 -0400 More gnoll skill code tweaks. This commit does two things to gnoll skill training, and does not affect non-gnolls at all. 1. Gnoll skill training is finer now - previously it used increments of 10 skill points only, now it goes 1 skill point at a time. 2. Gnolls no longer train other skills faster if they sacrifice skills with Ru (e.g. Sacrifice Stealth or Sacrifice Hand). There are two possible issues with this new approach. First, the code is not very efficient. Using &k on a gnoll to go to XL 27 takes about 10 seconds on my machine now. I don't think this will be noticeable outside of wizmode, and there are probably some easy optimizations that can be made - for now, I just went for code transparency. Second, gnoll skill training costs are slightly randomized now (mainly in early game). You can observe this by doing &k5 to go to XL 5 many times in a row (on different characters). I don't think this is necessarily a problem, and it is somewhat unavoidable when using 1 skill point precision at the moment (since the cost of raising a skill by 1 skill point at start is 1/10 of an xp point). It is probably not too hard to fix this by scaling you.total_experience and you.exp_available by a factor of 10 if we want. -------------------------------------------------------------------------------- fc3775b | elliptic | 2017-09-30 16:06:12 -0400 Don't train Stabbing and Traps on gnolls. Also should stop training Ru-sacrificed skills. -------------------------------------------------------------------------------- c36d0dd | advil | 2017-09-30 15:34:49 -0400 Really for real disable all training target UI for gnolls -------------------------------------------------------------------------------- a284228 | elliptic | 2017-09-30 10:35:34 -0400 Make gnoll skills rise evenly. Skills that start higher (because of background) or have a manual will remain higher. Other skills should remain exactly equal though. If we decide to make gnoll apts non-flat, this should handle that fine as well. One side effect is that skills don't rise at all until sometime in XL 3 - the reason is that you don't have enough exp to raise every skill by one skill point until then. I think this is okay, but if we wanted to address this then we could make skill points finer. With a +8 apt, a single skill point takes a skill from 0.0 to 0.8. The implementation is a little ugly, but not too bad. One note: The lines I removed from player.cc could theoretically have affected non-gnolls. I don't think they did in any reasonable circumstances (the only situation I can think of is if all currently trainable skills were at 27) and I don't see how these lines could ever have been a good idea anyway, but it is something to remember. -------------------------------------------------------------------------------- 91e3373 | Neil Moore | 2017-09-29 20:47:07 -0400 Avoid a gcc warning. About shadowing a member variable. -------------------------------------------------------------------------------- efad53e | advil | 2017-09-29 15:30:11 -0400 In skill menu, let = always work, fix crosstrain skills (rchandra x2) This also fixes the gnoll skill help not working. -------------------------------------------------------------------------------- 17ab366 | advil | 2017-09-29 11:31:27 -0400 Remove some doubles, and fix a wrong assumption about shields Weapon mindelay is generally in integers, so in parts of the description code I was discarding fractional parts. However, shields can have non-integer training targets, e.g. bucklers for a formicid have the penalty removed at 2.4. In an earlier commit to try to streamline the description code, I switched part of the shield calculation to integers incorrectly. This version now uses 10-scaled ints for everything and does not assume that any item-based target will be integer. -------------------------------------------------------------------------------- 40bfade | advil | 2017-09-29 11:06:55 -0400 Handle ash boosts better in item desc (|amethyst), + cleanups This also tries to further streamline the description code, which has a bunch of duplicated logic for weapons+missiles+shields. -------------------------------------------------------------------------------- d0d0d88 | advil | 2017-09-29 01:42:11 -0400 Fix skill target behavior for heroism (11240) Yes, three bools is too many, sorry. -------------------------------------------------------------------------------- 7453ecb | advil | 2017-09-29 00:41:54 -0400 For real disable training target UI for gnolls -------------------------------------------------------------------------------- 9255a14 | advil | 2017-09-29 00:36:18 -0400 Only calculate ash bonus for ash characters Luckily this didn't affect anything substantive, just training target estimates. -------------------------------------------------------------------------------- b3271ec | gammafunk | 2017-09-28 22:45:36 -0500 Improve shield offsets for the minotaur monster tile -------------------------------------------------------------------------------- 8d4826a | gammafunk | 2017-09-28 22:28:39 -0500 Fix training restrictions in skill menus and messages for Gnolls (eb) If Gnolls changed their inventory, spells, or abilities in a way that modify the usual training restrictions, their skill menu would show the skill without the '+' indicated it was being trained and they would get a message to that effect, although they would actually continue training the skill normally. This commit prevents those messages and skill menu changes. It may need to be done in a better way elsewhere in the skill code, but this fix will work for now. -------------------------------------------------------------------------------- bc67419 | gammafunk | 2017-09-28 22:27:04 -0500 Don't enable all trainable skills for non-Gnolls in transfered saves -------------------------------------------------------------------------------- 9ae2175 | gammafunk | 2017-09-28 16:28:51 -0500 Unbrace -------------------------------------------------------------------------------- 9a49fba | gammafunk | 2017-09-28 16:28:42 -0500 Declare a function as static -------------------------------------------------------------------------------- 57ddf66 | advil | 2017-09-28 15:57:44 -0400 Don't crash when describing staves The problem was that I wasn't handling SK_NONE properly, but also I didn't handle staves properly for getting mindelay, so both of these are fixed. -------------------------------------------------------------------------------- f4f4644 | advil | 2017-09-28 15:42:42 -0400 Attempt to quiet some gcc warnings I can't replicate these with clang, so I'm not sure if this will do it. -------------------------------------------------------------------------------- 27874c7 | advil | 2017-09-28 11:35:22 -0400 Don't show 100% training rate info in describe for gnolls since they can't change their training rate. -------------------------------------------------------------------------------- c847d3a | advil | 2017-09-28 11:35:22 -0400 Update help file for training targets Also some other reformatting of this help screen. -------------------------------------------------------------------------------- 5029fa9 | advil | 2017-09-28 11:35:22 -0400 Disable training targets for new^3gnolls This just hides them altogether. -------------------------------------------------------------------------------- d461b0e | advil | 2017-09-28 11:35:22 -0400 Add a command to set skill targets from an item description For items that have a particular goal: weapons, missiles, and shields. This also does a bunch of other miscelaneous cleanup of item descriptions. -------------------------------------------------------------------------------- 8c2e61a | advil | 2017-09-28 11:35:22 -0400 Generalize webtiles text input code and use it for skill targets This extracts the webtiles text input code from being specific to the messages window into its own module, adds a new mode where you can get input as a (not very stylish) dialog, and uses this mode to get skill targets in the skill menu. Crucially, this new input mode can work on top of an existing menu-style dialog (though other dialogs will not stack on top of an input dialog). I might eventually get an inline textbox to work in the skill menu, to be more parallel to how console/local tiles work, but this was taking to long and I wanted to just get something that functions. The abstraction of text input into its own require.js module is the first step for this, anyways. -------------------------------------------------------------------------------- f3702fd | advil | 2017-09-28 11:35:22 -0400 Fix a fairly nasty bug leading to blank webtiles sometimes If you use cgotoxy without a region argument at the wrong time, it will use the CRT region, which can change the webtiles UI state. In some circumstances, I think if a menu is still waiting on a timer to close, this will simply blank out the webtiles display. This was manifesting here when you do C-f ? ESC. -------------------------------------------------------------------------------- ea5fd92 | advil | 2017-09-28 11:35:22 -0400 Add UI for skill target editing for console/local tiles This bolts together TextItems and line_readers to make a (very) basic text editing widget (which previously only existed in the form of line_reader in the message pane), and uses it to implement editing for skill targets in the m screen. When viewing skill targets, you can select a target to edit, and the editing happens in place in that part of the skill menu. As part of this process, I attempted to make line_reader very slightly more sane in a number of ways; this commit also includes a local tiles subclass that uses a FontBuffer (for arbitrary positioning of the editing widget, rather than grid positioning). This commit doesn't cover webtiles, and editing only sort of works there (it works basically like on console, but the cursor doesn't show). The next step is to generalize the input box technique currently limited only to the message pane. -------------------------------------------------------------------------------- 42f6fbc | advil | 2017-09-28 11:35:22 -0400 Change skill screen foreground color in help mode to light gray Previously used dark gray, which is kind of confusing, as this color otherwise signals disabled. Also fix a range issue. -------------------------------------------------------------------------------- a7893f8 | advil | 2017-09-28 11:35:22 -0400 Implement training target backend This commit implements the basic backend machinery for skill training targets, as well as a UI for viewing them in the m screen as another mode. Beyond the lua bindings, there is no UI for editing them in this commit, that will come in a future commit. Each skill can be associated with a unique training target, implemented as a 10-scaled skill level value. When the target is reached or passed, the training target is reset to 0 (which means 'off'), and training for that skill is turned off. Targets are checked while training, while setting skill levels, and on load/skill fixup. Because of the way skill training works, targets aren't checked exactly, so a large burst of experience (e.g. killing cerebov, drinking a potion of xp) can overshoot targets, but in practice it gets pretty close. Targets are checked against skill factoring in cross-training and ash bonuses, but not draining. With this commit, training targets can be set and accessed via a pair of lua bindings, you.get_training_target and you.set_training_target. -------------------------------------------------------------------------------- 255219b | advil | 2017-09-28 11:35:22 -0400 Add messaging about skill level targets to weapon information This adds information in the following format to weapon/shield info about when the player will reach mindelay/no penalty (where the first two lines were already there): This weapon's minimum attack delay (0.7) is reached at skill level 26. (Your skill: 20.8) At max training you would reach 26.0 in about 1.0 XLs. At current training (50%) you will reach 26.0 in about 2.3 XLs. The basic idea is that this information allows more informed training allocations at any given point. I decided to use XLs as a measure because I think players generally seem to have sense of XL progression, and for most of the game it's something they're very attuned to. Past XL 27 it will say "the equivalent of N XLs", similar to how felid life gain works. Also, I couldn't think of any other way to quantify this. Using XLs does to some degree reveal the amount of deep weirdness and non-linearity in skill point / XL gain, but so be it. In most cases this is an exact calculation, but there are a few things I wasn't able to perfectly account for. Crosstraining works, but it won't take into account training multiple cross-training skills at the same time. Ash bonuses are approximate, because they give a skill point bonus that is dependent on skill level (level, not points), and this is somewhat hard to calculate. It also uses only current ash piety. Manuals use only the rate modifier, not the exact skill point value in the manual. It ignores draining, ash penance, heroism, and any other skill effects I forgot about. This commit comes with a bunch of refactoring of skill / skill point calculations in order to avoid code duplication and make some calculations slightly clearer. This commit is the first step in a bunch of changes to the skill UI, including skill targets, and the refactoring here sets the stage. For example, the code that produces the weapon info is set up to support arbitrary queries for skill targets. This (post-rebase) version incorporates feedback from various people, especially amalloy. -------------------------------------------------------------------------------- a3d34c2 | gammafunk | 2017-09-28 02:54:35 -0500 Update the manual and the description for Gnolls [skip ci] -------------------------------------------------------------------------------- f4b7489 | gammafunk | 2017-09-28 01:30:43 -0500 Gnolls Redux Part VIII: Save compatibility for stat lock removal When transferring stat-locked Gnoll saves, set their base stats to 10, then randomly give them Str/Int/Dex for each point of the XL/3 stat choices they missed as well as for each point of missed XL/4 SID. Also enable mandatory training of all schools regardless of any previous training selection. -------------------------------------------------------------------------------- f0bd51c | gammafunk | 2017-09-28 01:30:43 -0500 Add a function to get a species definition -------------------------------------------------------------------------------- db0367d | gammafunk | 2017-09-28 01:30:42 -0500 Move species_def to its own definition header -------------------------------------------------------------------------------- 42af060 | gammafunk | 2017-09-28 01:30:41 -0500 Gnolls Redux Part VII: Prevent Ru from offering Sacrifice Arcana This sacrifice would let Gnolls get an additional perk in the form of extra XP not directed into a now-unused school. This is already a low piety sacrifice, so it's better to not offer it to Gnolls instead of trying to adjust the piety awarded. -------------------------------------------------------------------------------- 1447a82 | gammafunk | 2017-09-28 01:30:41 -0500 Gnolls Redux Part VI: Disable Ashenzari skill transfer Gnolls would want to use this ability on a large number of skills to get around their main limitation. Allowing such a substantial bypass of their main species limitation isn't desirable, so we disallow it. -------------------------------------------------------------------------------- 6782bc9 | gammafunk | 2017-09-28 01:30:40 -0500 Gnolls Redux Part V: Disallow worshiping Trog Disallow Gnolls from choosing Berserker at game start and prevent Trog worship from altars. Trog does not appreciate worshipers training magic, and Gnolls are especially bad at not training magic, since they train all schools always. Gnolls of Trogs aren't very interesting given the design of the species, so trying to twist the rules a bit doesn't seem worth it. Go for the GnBe high score while you still can! -------------------------------------------------------------------------------- b8a99bc | gammafunk | 2017-09-28 01:30:40 -0500 Gnolls Redux Part IV: Disable cross-training Cross-training would just be an always-available boost to some schools for Gnolls, since they always train all skills now. With this commit, no cross-training occurs between the usual melee and ranged skills for this species. -------------------------------------------------------------------------------- 0c25114 | gammafunk | 2017-09-28 01:30:36 -0500 Gnolls Redux Part III: Remove stat lock since the stat-lock is no longer part of their design. Gnolls now have stat gain choice normally every three levels and their SID/4 works as well. -------------------------------------------------------------------------------- 8a4a258 | gammafunk | 2017-09-28 01:30:09 -0500 Gnolls Redux Part II: Increase apts and stats (elliptic) Give Gnolls all +8 apts, 10/10/10 starting Str/Int/Dex, and SID/4. The +8 apts will get the player to a bit above skill level 7 in all skills by XL 13 and a bit above skill level 16 by XL 27. We may want to adjust some aptitudes (e.g. melee) to be a bit higher so melee is not so painful, although the extra stat points will help with this to some degree. Likewise we can adjust some aptitudes to be a little lower to help encourage Gnolls not to always use certain schools that work better at lower skill levels. For now we can test these baseline flat apts in trunk and then see what needs adjusting. -------------------------------------------------------------------------------- d2df3b7 | gammafunk | 2017-09-28 01:29:51 -0500 Gnolls Redux Part I: Every skill is always trained (##crawl/not mikee) The current "stat-locked" version of Gnolls tries harder to push the player to not specialize in any one thing without relying on the aptitude change breakpoints used by the initial version of the species. But heavy armor, shields, ranged weapons, and evocations all work well enough with low stats, and melee works well enough when paired with these. On the magic side of things, necromancy and summoning spells work far better with low Int compared to direct damage spell schools. So Gnolls were still able to specialize in certain schools but additionally had a low-stat conduct that players didn't enjoy. The rework started in this commit will have Gnolls become a "reverse-skillrobin" species with very high apts and high stats, but with a drawback where they always train every type of skill at the same time with no ability to disable or focus specific skills. All skills are enabled for training at the same XP percentage at game start, ignoring any training requirements of equipment or spells normally applied to other species. Backgrounds still apply their starting XP into the specific relevant schools, but all further XP gained after the game begins applies to every school. A subsequent commit will adjust Gnoll aptitudes to much higher than the current +3, raise their stats, and remove stat-lock. Even with this aptitude increase, skill levels will raise slowly, but all schools will be available to use in terms of training. It's closer in spirit to the original Gnoll design, but even more explicitly rules out skill specialization and does this without needing aptitude breakpoints. This commit disables all menu actions and lua functions to select or focus skills as a Gnoll and has them always train all skills. Experience potions apply the experience to all skills and no longer present a special skill menu to the player. Future commits will disable cross-training, handle god-related limitations, and implement save compatibility. -------------------------------------------------------------------------------- 6fcecc0 | Neil Moore | 2017-09-24 22:44:14 -0400 Checkwhite (doh) [skip ci] -------------------------------------------------------------------------------- 9d37868 | Neil Moore | 2017-09-24 22:42:31 -0400 Correct and expand a comment. [skip CI] -------------------------------------------------------------------------------- 14ddf8d | Neil Moore | 2017-09-24 21:12:19 -0400 Show MP regen from Etheric Cage on % screen (enarc13) Count its average regen rate of 0.5/turn, and add an asterisk to indicate that there is something different (the regen is not smooth). -------------------------------------------------------------------------------- 622b906 | Neil Moore | 2017-09-23 23:29:49 -0400 Avoid combining MG_FORCE_PLACE + PROX_CLOSE_TO_PLAYER In phial of floods. Most likely this would never actually come up, since the elementals should be in LOS range anyway, but if it did happen, this commit would restore the 0.20 behaviour (placing the elemental out-of-range, rather than squelching them). -------------------------------------------------------------------------------- 377afad | Neil Moore | 2017-09-23 23:29:34 -0400 Don't disconnect out-of-LOS tentacles (#11213) In 0.21-a0-253-g6b34986 we began enforcing PROX_CLOSE_TO_PLAYER even when the monster was placed with MG_FORCE_PLACE. But the tentacle code used that combination, resulting in a failure to place and a can't- happen message once the tentacled monster left LOS radius. Use PROX_ANYWHERE instead. -------------------------------------------------------------------------------- b6be1c8 | Chris Campbell | 2017-09-24 00:10:44 +0100 Improve messaging for stolen gold Especially since current gold is no longer shown on the HUD. -------------------------------------------------------------------------------- 1d62a0f | Chris Campbell | 2017-09-24 00:10:41 +0100 Don't tithe gold stolen by Maurice (Vanguardan) Since tithing on pickup is more piety-efficient than donating gold manually, don't allow players to let Maurice steal gold in order to tithe it again. -------------------------------------------------------------------------------- 6037ffb | gammafunk | 2017-09-22 18:59:05 -0500 Tweak monsters in a crab-themed vault (mikee) The crabs themselves are relatively fragile and don't do much damage, so give them some support from 2-4 monsters that can hit from behind other monsters and have good melee or ranged damage. Entropy weavers in Lair and Dungeon, spriggan druids in Swamp (with some wall squares replaced with trees), Titans in Depths, and Killer Klowns and Draconian Stormcallers/Scorchers on Zot. This commit also fixes some monster substitution errors and simplifies the DES. -------------------------------------------------------------------------------- a722497 | advil | 2017-09-19 22:15:25 -0400 Don't use the entire string when iterating over the result of a split This was resulting in duplicated lines in webtiles in the C-x menu. Unfortunately this fix still doesn't put the selection box on the whole menu item, because of the use of a dummy menu item, but it's hard to get a good fix that does this while taking into account the appearance of console on a webtiles build. Resolves #616, sort of. (That PR gets the selection box right, but doesn't fix the c++ bug, and I'm not very confident it won't affect other menus.) -------------------------------------------------------------------------------- eaec956 | gammafunk | 2017-09-19 12:41:00 -0500 Fix Draconian hat tiles to display properly in WebTiles and in menus Based on the fix in the previous commit, applied to the relevant (and duplicated) code (which we need to de-duplicate). -------------------------------------------------------------------------------- ff8b496 | efredericks | 2017-09-19 12:38:53 -0500 Fixed issue where draconian hat was not shown when equipped [Closes #617 with related fixes in preceding and following commits. --gammafunk] -------------------------------------------------------------------------------- 1afbe6a | gammafunk | 2017-09-19 12:25:50 -0500 Fix player doll order in menus and better document code duplication Have the menus showing player dolls use the same doll tile ordering as the main doll used for the view area. -------------------------------------------------------------------------------- c1afaeb | advil | 2017-09-17 09:09:50 -0400 Fix line pass to not be cblink (11228) This was broken in 44a4606457c614cd71b1c56c259aa7a0d801755e, by replacing ZAP_EXPLOSIVE_BOLT with ZAP_DEBUGGING_RAY for targeter_monster_sequence. Z_D_R does not have can_beam set, and so therefore leads to beam paths not being calculated in the way that targeter_monster_sequence needs for its aiming functions. -------------------------------------------------------------------------------- 0785366 | John Boyle | 2017-09-15 19:37:30 +0100 Disperse clouds under player when evoking wind blasts [Closes #612 PR. Removed the extra message for it, as it was placed in a weird order and doesn't seem entirely necessary. - MarvinPA] -------------------------------------------------------------------------------- 984ae92 | John Boyle | 2017-09-14 18:13:18 -0400 Prevent split slimes from inheriting HELD enchantments (heteroy) After slimes were prevented from eating nets, they seem to have begun inheriting the HELD enchantment if the parent slime was in a net. This manifested as a 'webbed' slime, which was kinda weird. Now, when a slime in a net splits, the new slime has no HELD ench, which actually looks like the slime is oozing through the net. -------------------------------------------------------------------------------- e7f0487 | advil | 2017-09-14 12:25:06 -0400 Remove a secret breakpoint in monster response to noise Previous to this commit, if the perceived noise location was within 3 spaces grid-distance of the player's location, a monster was alerted; otherwise it was disturbed. The difference in behavior for these two is substantial, especially for sleeping monsters: alerting awakens, sets foe to MHITYOU and has the monster shout, thus awakening others. Disturbing awakens, sets them to wander, and has them briefly consider the noise source as a potential movement target but with no foe; in my testing this often does very little (though I'm not sure of the exact details of how wandering monsters with a target do behave or are supposed to behave). Because of this there was secretly a substantial incentive when using things like fireball to target >3 spaces away in how much attention you draw from far away. With this change, there is still incentive to make noises further away from the player's actual location, but this incentive (i.e. the chance of alerting vs. disturbing) scales linearly with grid distance from the player with a 10% chance at LOS_RADIUS. The equation could be further tweaked if needed. This may be an overall nerf as it stands, because now there is some chance of alerting monsters for anywhere you e.g. shoot a fireball (at max range). However, the penalty for shooting fireballs near you is softened. This is sort of a quick fix: ideally the choice of alert vs disturb would make no reference to the player's location at all. The other constraint is of course avoiding chain shouting -- this is why monsters can't just alert on every noise. This commit also fixes a few bugs in DEBUG_NOISE_PROPAGATION. -------------------------------------------------------------------------------- 8204059 | gammafunk | 2017-09-12 17:44:28 -0500 A cloud-themed transporter vault for Dungeon and Lair branches A pre-identified potion of resistance will let the player walk through the clouds either unharmed or with enough damage resisted to make it to the other side, but only if they can kill the monsters in time. Said monsters have damage that's of the same type as the cloud, so it can be partly resisted. Loot is generic, but upgrades gradually with depth and eventually includes a piece of 'good item' auxiliary armor. A mutagenic cloud variant appearing in the latest depths has a couple of cancellation pots instead of the resistance pot and has the player fighting ugly things and very ugly things that shift rapidly in the clouds. All monsters and loot are visible from outside the vault, so the player knows exactly what they're getting into. -------------------------------------------------------------------------------- 8ea824e | gammafunk | 2017-09-12 17:44:28 -0500 Add no_tele_into on some early depth transporter vaults Don't let the player be teleported into transporter vaults appearing before D:7. These vaults are significantly harder on-average compared to other vaults, and in the very earliest levels the player is a lot more likely to have no means of escape. It would be nice to standardize this behaviour for early transporter and runed door vaults so that it was not spoilery for the player as to whether they had to worry about landing in a potentially dangerous area. We would need to come up with consistent rules for applying no_tele_into to such early vaults and also have a way to indicate this behaviour, possibly in the descriptions of the runed doors and transporters features themselves. -------------------------------------------------------------------------------- df84809 | gammafunk | 2017-09-12 17:44:28 -0500 Fix an item definition in a vault -------------------------------------------------------------------------------- a5fc350 | advil | 2017-09-12 00:06:28 -0400 Add an assert This may be too strong. -------------------------------------------------------------------------------- 32e1f36 | advil | 2017-09-12 00:06:28 -0400 Remove a no-longer-necessary loop + an unused condition Previous to this commit, when presented with MONS_ZOMBIE and the like, pick_random_monster would call pick_local_zombifiable_monster to generate a valid (living) monster type for the zombie. As far as I can tell this isn't ever used. Removing this leads to pick_random_monster having the following property: it isn't sensitive to any value for `kind` that it itself can produce as a return value, making it more safe to call iteratively if needed. (For most `kind` values it just picks a random monster.) Anything that needs a zombie type should call pick_local_zombifiable_monster directly. It wasn't needed any more in this case: iteration was creating living monsters out of zombies in tomb and tartarus (11216). -------------------------------------------------------------------------------- b353147 | elliptic | 2017-09-09 22:26:08 -0400 Ogres: improve more non-mace weapon apts. This seems to make sense if the idea of reducing their maces apt was to encourage more weapon diversity. -------------------------------------------------------------------------------- 3e31e41 | advil | 2017-09-07 20:25:15 -0400 Take sacrifice experience into account when validating Ds mutations This is kind of hacky in how it tries to work around wizmode xl changes, and you can still get it to crash in wizmode, but it's better than before. I'm sort of inclined to think that Ds should just lose the mutation(s) while they wait to gain back the levels, but maybe that's too harsh. It's also trickier to implement (though a wizmode version of the code is already there.) -------------------------------------------------------------------------------- f26e180 | Bernhard M. Wiedemann | 2017-09-07 10:32:27 -0700 Sort input file list (#609) so that loadmaps.lua builds in a reproducible way in spite of indeterministic filesystem readdir order See https://reproducible-builds.org/ for why this is good. -------------------------------------------------------------------------------- 12b8181 | advil | 2017-09-07 10:54:25 -0400 Fix a fallthrough that seems harmless but unintentional Harmless (I think?) since you can't already have MUT_INEXPERIENCED if the sac xp ability can trigger, but this could bite changes to sac courage later. -------------------------------------------------------------------------------- bd1db8b | advil | 2017-09-07 10:37:15 -0400 Give Ds extra piety for sacrificing experience In my testing Ds are highly likely to miss out on one mutation, sometimes two; the average was 1.05 in a run of 20 rerolls. This doesn't explicitly describe the extra piety for this case, which seems consistent with the other bonuses in get_sacrifice_piety, but maybe should be told to the player somehow. The exact number could be tweaked, I gave it a huge bonus, but the psychological impact of losing a (high-end) mutation might be worse than the practice. -------------------------------------------------------------------------------- 9b2435e | Alan Malloy | 2017-09-06 13:35:44 -0700 Minor cleanup after #604 - Restrict a variable's scope to where it's needed - Remove its bogus initializer value that is never read -------------------------------------------------------------------------------- 9a62636 | jmbjr | 2017-09-06 13:25:40 -0700 Clarify failure message for quaffing !invis while haloed (Yermak, #11104) (#604) Currently, self-haloing prevents !invis. The issue is, the msg to the player is vague and doesn't clarify that the reason the player can't go invisible at all is due to their weapon (EOS) or their Divine Halo (TSO or Wu Jian). -------------------------------------------------------------------------------- 4c0eb85 | gammafunk | 2017-09-05 22:33:29 -0500 Fix a SUBST that put too many apocalypse crabs in a vault -------------------------------------------------------------------------------- bb444f2 | gammafunk | 2017-09-05 15:15:21 -0500 Generate some monsters awake at level creation time on most levels Each level generation monster (i.e. any monster not generated from a vault) now has a 1/8 chance of being generated awake. These monsters can present the same kind of challenge to players negotiating seemingly cleared areas that spawns used to present. D:1 is excluded from generating these awake monsters, since the player doesn't have the ability to escape upwards and is particularly vulnerable in general. Portals, Abyss, and Pan are unaffected by this change as they either place all monsters through vaults (portals), or have their own monster generation rules: Abyss spawns monsters very frequently and Pan already generates all monsters awake. -------------------------------------------------------------------------------- b9be33d | gammafunk | 2017-09-05 15:15:21 -0500 Add a monster placement proximity type for generating away from stairs Monster with generation proximity PROX_AWAY_FROM_STAIRS will not be placed within LOS_RADIUS squares (i.e. 8 squares) of a stone staircase. Placement positions near hatches, portals, branch entrances etc are still allowed by this proximity type. This will be used in a subsequent commit for making a small portion of level monsters be already awake at generation time. -------------------------------------------------------------------------------- 5a3d65e | gammafunk | 2017-09-05 15:05:24 -0500 Increase numbers of level generation monsters in most branches Monster spawns over time were removed from connected branches in the previous commit, which reduces the XP earned by the player. Results from the xp_by_level table from the morgues of games won in trunk show that anywhere from 8-13% of total XP comes from spawns after level generation, excluding Orb run spawns. To keep XP gained through normal level progression relatively the same, this commit slightly increases the number of monsters generated by the level itself (i.e. not from vaults): Crypt: From 3d8 to 3d10, 3 more on-average. Hell subbranches: From 3d10 + 3d8 to simply 3d23, 6 more on-average. All other connected branches: From 3d10 to 3d12, 3 more on-average. Pandemonium: The die used was changed from 0-27 averaged over 3 rolls to simply 3d8 for consistency, but no change to level generation monsters, since Pan still has spawns. Numbers are unchanged in other branches, since these don't have level generation monsters and either place no monsters or only place monsters through vaults. Some results courtesy of elliptic comparing 2000 GrBe qw games before the change and 2000 after the change show that XL is not changing drastically by branch. In these listings, "current" means trunk including this commit plus the earlier ones to remove spawns and generate some monsters awake, and "previous" means trunk before any of these commits, with spawns still in place and the previous lower numbers of level monsters. XL upon branch entry (previous): Sewer: 6.66, Ossuary: 7.87, Lair: 10.89, Orc: 15.45, Vaults: 17.5, Spider: 17.74, Snake: 17.85, Swamp: 17.87, Shoals: 18.07, Bazaar: 18.87, Depths: 21.38, Zot: 25.69 XL upon branch entry (current) Sewer: 6.7, Ossuary: 7.98, Lair: 10.88, Orc: 15.37, Vaults: 17.32, Swamp: 17.48, Spider: 17.6, Shoals: 17.7, Snake: 17.81, Bazaar: 18.52, Depths: 21.09, Zot: 25.18 XL upon reaching branch end (previous): Lair: 13.06, D: 15.04, Orc: 15.5, Swamp: 18.47, Spider: 18.5, Snake: 18.74, Shoals: 18.87, Depths: 23.7, Vaults: 24.39, Abyss: 26.44, Zot: 26.91 XL upon reaching branch end (current): Lair: 13.04, D: 14.98, Orc: 15.45, Swamp: 18, Spider: 18.37, Shoals: 18.49, Snake: 18.67, Depths: 23.33, Vaults: 23.9, Abyss: 25.95, Zot: 26.71 -------------------------------------------------------------------------------- 1d58f9a | gammafunk | 2017-09-05 01:09:52 -0500 Remove monster spawns over time in most branches Monsters spawns over time are used to provide some complications to retreating and luring as the player has cleared out portions of a level. Additionally these spawns have an out-of-depth (OOD) timer that punishes players who spend significant amounts of time on a level by generating much stronger than usual monsters. Punishing players with OOD monsters isn't necessary if they're clearing a level normally, and if they are spending inordinate amounts of time on the level, generating high XP threats they may well be able to kill leads to players intentionally scumming the spawns. The OOD monster listings in branches like Dungeon and Vaults are generally good at generating worse-than-usual threats for level generation, but generally had the opposite of the intended anti-scumming effect, since it's very hard to guarantee that a single monster can't be killed by a lower-level player. This commit removes monster spawns in most branches as well as the turn-based OOD timer. The Abyss and Pandemonium still generate spawns according to those branches rules. All other connected branches that previously spawned monsters over time no longer do so except during the Orb run, where the usual Orb spawns generate. For monsters that complicate luring, retreating, and general movement through cleared areas, generating some monsters initially awake can have the same effect, and that will be addressed in a subsequent commit. Since spawn removal effectively reduces the number of monsters killed and hence the amount of XP earned, another subsequent commit will slightly increase level monster generation. -------------------------------------------------------------------------------- 6b34986 | gammafunk | 2017-09-05 01:08:45 -0500 Don't try to spawn monsters from stairs Previously level spawns had to chance to generate near stairs on the level, with the monster chosen from the list of the destination level. This would needlessly generate weaker than usual monsters if the destination level was an earlier one and generate dangerous ones e.g. on a Lair level with the Slime Pits entrance. Placing out-of-branch and out-of-depth monsters can more effectively be done at level generation time through branch entry vaults or other vaults where we can keep the frequency and types of these non-branch monsters more under control. The placement of these spawns is also buggy, having been broken for many years by 033b2f59, which resulted in all PROXIMITY_NEAR_STAIRS spawn locations not directly on stairs being rejected. Even if this was fixed, the only behaviour where it would be arguably good is during the Orb run, since the player is trying to reach these to escape the dungeon. But these stairs spawns have been mostly non-working for years, and the current Orb run generates threatening monster placements frequently. This commit removes the PROXIMITY_NEAR_STAIRS proximity type so that all spawns generate at random locations, save for Orb spawns which still have their usual chance to be created near the player. -------------------------------------------------------------------------------- eb74d03 | gammafunk | 2017-09-05 01:08:44 -0500 Replace some 0 pointers with nullptr and simplify -------------------------------------------------------------------------------- 5e8393f | Neil Moore | 2017-09-04 22:30:23 -0400 Fix one more tiles memory leak. The only ones remaining, according to a short valgrind run, are related to SDL_CreateWindow or FT_Load_Glyph (plus a couple buried inside GL, where I doubt we can get to them). I don't know SDL or FreeType well enough to fix those. -------------------------------------------------------------------------------- 788435b | Neil Moore | 2017-09-04 22:14:16 -0400 Avoid leaking a few regions in TilesFramework::shutdown(). It would be better of course to use unique_ptrs so we can let the destructor handle it. -------------------------------------------------------------------------------- 0593ebf | Neil Moore | 2017-09-04 21:58:40 -0400 Avoid a compile-time warning in TOUCH_UI mode. We don't goto done in the TOUCH_UI code here, so don't include the label in that case. -------------------------------------------------------------------------------- a68f6df | Neil Moore | 2017-09-04 21:58:39 -0400 Make sure options.option_behaviour contents are freed. We were careful to avoid leaking the GameOptions on every call to reset_options, but technically we were leaking them once per game. -------------------------------------------------------------------------------- 1d7a809 | Neil Moore | 2017-09-04 21:58:39 -0400 Remove an uninitialised memory access in init_mons_spells. setup_mons_casts calls monster::name indirectory, which eventually looks at the monster's MID in _mon_special_name. So make sure to set it. -------------------------------------------------------------------------------- f6eb2b2 | Neil Moore | 2017-09-04 21:58:39 -0400 Avoid another useless new in popup-related code. This one at least had a matching delete. -------------------------------------------------------------------------------- a5e3c5f | Neil Moore | 2017-09-04 21:58:39 -0400 Fix memory leak in TOUCH_UI popup code. We were never freeing our MenuEntries. Do so. We should really use unique_ptrs in those parts of the menu code that do need pointers (for run-time polymorphism for example). -------------------------------------------------------------------------------- d4adca8 | advil | 2017-09-04 13:27:38 -0400 Don't assume agent is still alive for monster sticky flame The agent can be killed by sticky flame hitting an intermediate monster on reaction-type effects, with Usk's pain bond being the obvious one; the sticky flame then keeps going. An alternative solution might be to have the sticky flame fade away when the caster dies. -------------------------------------------------------------------------------- 597973d | Neil Moore | 2017-09-03 17:01:48 -0400 Better handle Qazlal, scarf, and Cloud Mage cloud immunity. The version of actor_cloud_immune that took a cloud_type did not check for those cases. This affects the self-harm prompt from ignite poison and the "would do no harm" abort from poisonous vapours: All the other callers used the cloud_struct version of the function. Those two callers still don't handle conditional cloud immunity, like that of Fedhas allies and demonic guardians. -------------------------------------------------------------------------------- 28e8582 | Neil Moore | 2017-09-03 16:45:28 -0400 Improve Ignite Poison prompting (syraine) It was not checking for Firestarter, and was checking MUT_IGNITE_BLOOD rather than MUT_FLAME_CLOUD_IMMUNITY. Fix both of those by deferring to actor_cloud_immune rather than trying to reimplement a small part of it. Also, if the player was immune, they would not be prompted about allies. Also, the player would not be prompted about allies (despite the existence of code to do the check): The tracers in _ignite_poison_clouds and _ignite_poison_monsters never reported a negative "value" when the agent was the player, caring only about ignitability of the square and the presence of enemies! Furthermore, a separate bug also prevented ally prompts when the player was cloud-immune. Fix both of those issues as well. -------------------------------------------------------------------------------- 2cbab09 | gammafunk | 2017-09-02 16:56:54 -0500 Fix the overall monster counts in objstat being doubled -------------------------------------------------------------------------------- c4b6860 | gammafunk | 2017-09-02 14:25:12 -0500 Add objstat fields for tracking whether monster are from vaults Add NumNonVault, NumVault, TotalNonVaultXP, and TotalVaultXP, tracking those respective numbers for monsters generated by vaults and those generated directly by the level. -------------------------------------------------------------------------------- 7b8ad69 | advil | 2017-09-02 09:45:40 -0400 Add a test that exercises ghost crabs and therefore random summoning This should head off issues like the one in eb0acef0604d. -------------------------------------------------------------------------------- eb0acef | advil | 2017-09-02 09:15:11 -0400 Don't crash on random monsters For at least some random monsters, .base_type is left as RANDOM_MONSTER and the like, which will fail asserts in mons_genus. I'm not sure of the subtle differences between cls and base_type, but everything else that calls mons_genus here uses cls, so maybe it's right. -------------------------------------------------------------------------------- 87df72b | Alan Malloy | 2017-09-01 16:50:44 -0700 Check an assumption at compile time Before we check an array's `[1]` element, we assert that its type says it has at least that many elements. -------------------------------------------------------------------------------- 9acaae1 | Alan Malloy | 2017-09-01 15:54:27 -0700 util/unbrace -------------------------------------------------------------------------------- c116c14 | Alan Malloy | 2017-09-01 15:54:18 -0700 Actually explain code instead of just saying it's a hack -------------------------------------------------------------------------------- 9d9b8e4 | Alan Malloy | 2017-09-01 15:49:10 -0700 Don't crash when looking at a hydra-shaped block of ice (zelig81) -------------------------------------------------------------------------------- 0929f2e | Neil Moore | 2017-09-01 16:37:41 -0400 Handle more tiles in tiledef_lint TILEP_MONS_OLD_*, TILEG_INVOCATIONS_1_*, TILEG_INACTIVE_*, axed monsters, monsters using dbname: rather than tiles:, and tiles referenced only in tilemcache.cc. [skip ci] -------------------------------------------------------------------------------- d81925b | Neil Moore | 2017-09-01 16:12:17 -0400 Handle spells and monsters in tiledef_lint. Now that most of them are specified in {spl,mon}-data.h rather than tilepick.cc. [skip ci] -------------------------------------------------------------------------------- 6dad0ce | Neil Moore | 2017-09-01 15:51:14 -0400 Try harder to fix travis BUILD_ALL builds. SDL *also* requires Xinerama.h. Use xorg-dev to pull in all the X dev libraries. -------------------------------------------------------------------------------- 8444625 | Neil Moore | 2017-09-01 14:53:59 -0400 Try to fix travis BUILD_ALL builds. SDL requires Xcursor.h, which was not being pulled in. -------------------------------------------------------------------------------- 3587535 | Chris Campbell | 2017-08-31 20:05:33 +0100 Fix spelling in a trove message -------------------------------------------------------------------------------- 14ccbf3 | Alan Malloy | 2017-08-30 16:16:07 -0700 Don't let tiles players use god abilities under penance (UsaSatsui) Fixes https://crawl.develz.org/mantis/view.php?id=11203 -------------------------------------------------------------------------------- 58a7c62 | Nicholas Feinberg | 2017-08-29 15:45:47 -0700 Brace. -------------------------------------------------------------------------------- b48fd38 | Floodkiller | 2017-08-29 15:45:47 -0700 Don't list Chei attribute support for Gnolls (#11183) Don't list Chei supporting attributes for Gnolls in the god description screen. -------------------------------------------------------------------------------- 207ae17 | gammafunk | 2017-08-27 09:59:34 -0500 Tweak stair placement in a float vault Center the staircase instead of randomly picking one of four off-center locations, since this gives more spawn locations for the Shoals merfolk avatar (which we add in this commit) and looks better as well. -------------------------------------------------------------------------------- c774ea6 | gammafunk | 2017-08-27 09:59:34 -0500 A crab-themed vault in collaboration with mikee A runed door float vault that features a deadly spiral progression of crabs, starting with fire crabs, then ghost crabs, and finally an apocalypse crab guarding a pile of loot. Earliest placement is in mid-Lair, but also places in late Dungeon, Depths, Swamp, and Zot, with crab types upgraded as appropriate and with upgraded numbers of crabs and loot in Zot. -------------------------------------------------------------------------------- 812f45e | Alan Malloy | 2017-08-26 23:11:26 -0700 Fix incorrect docstring on update_monster -------------------------------------------------------------------------------- bd5500b | jmbjr | 2017-08-26 23:09:33 -0700 Properly update shafted and banished monster timed-effects (PleasingFungus, #10971) (#601) We now simulate time passing for monsters who were shafted or banished away from the player's floor. -------------------------------------------------------------------------------- fe971b9 | Alan Malloy | 2017-08-23 14:30:40 -0700 Fix order of field initializers (-Wreorder) -------------------------------------------------------------------------------- b89990d | Alan Malloy | 2017-08-23 14:13:16 -0700 Make follower::place return the placed monster This avoids having to do silly stuff like look the monster up in the monster list after placing it. -------------------------------------------------------------------------------- 7a3ad04 | gammafunk | 2017-08-23 12:53:58 -0500 Actually add the xp-tracking-type.h header (doh) -------------------------------------------------------------------------------- 8aba26b | gammafunk | 2017-08-23 12:16:53 -0500 Don't track Orb spawns as generated monsters in xp_by_level (elliptic) The previous logic tried to use a boolean to track whether a monster was a spawn or not, but this didn't allow us to omit Orb spawns from the counting. We now use an enum to describe xp tracking and have Orb spawns use and "untracked" state. This adds some more save compat to handle proper monster marshalling. Monsters from saves before the earlier TAG_MINOR_LEVEL_XP_INFO tag now will simply be untracked instead of simply counted as generated monsters, since we have no way of telling spawn vs generated vs orb spawn. -------------------------------------------------------------------------------- 3eb6d36 | gammafunk | 2017-08-23 11:51:08 -0500 Add an xp_tracking_type enum Add a source header and necessary includes. This will allow proper tacking logic for the xp_by_level dump table. -------------------------------------------------------------------------------- 6d3fd91 | Alan Malloy | 2017-08-22 12:41:43 -0700 Remove a bunch of #if 0 clauses Mostly these were many-years-old TODOs that never got done, or some debugging code meant to be toggled by editing the source. The former are never going to get done, and the latter are doing things the wrong way: they should use some debug variable, if they are important toggles to keep. But I think they're not important, and the authors of these debug options have moved on, so away goes the dead code. If you miss any of these badly, feel free to add them back in controlled by a flag. I left in two #if 0 clauses that looked like they might be valuable someday: - One in dbg-asrt.cc representing partial work towards a solution of a difficult problem (better ASSERTs on Windows tiles) that someone with more expertise in the right area could pick up someday. - One in fontwrapper-ft.cc that enabled some detailed debug logging for font rendering in tiles. This one looks better than most for being converted into a proper flag-toggled log macro. -------------------------------------------------------------------------------- 0631661 | Alan Malloy | 2017-08-21 17:07:09 -0700 Update a hints-mode message -------------------------------------------------------------------------------- 0862e88 | Neil Moore | 2017-08-21 19:23:10 -0400 Fix NaN-stripping in chardump tables. We converted the word "nan" to "N/A", but also needed to handle "-nan", which is important since x86 floating point sets the sign bit on indefinite NaNs. Also handle the MSVC string representations of indefinite NaN, "1#IND" and "-1#IND". I wasn't able to test whether we might also see "1#QNAN": See https://blogs.msdn.microsoft.com/oldnewthing/20130221-00/?p=5183 . -------------------------------------------------------------------------------- ae198ad | Alan Malloy | 2017-08-21 14:27:39 -0700 Simplify code for making mimics cackle A huge chunk of it is defending against _laughs_ not being in monspeak.txt, which is not a very likely scenario. Even if that did happen, the only consequence of removing this extra logic is displaying a worse string to the user (not a segfault or a machanics change). I think it's better to have the simpler code than to defend against a scenario that won't happen (it's under our control) and wouldn't be a big deal if it did. -------------------------------------------------------------------------------- 1ea99b4 | Neil Moore | 2017-08-21 16:52:37 -0400 Don't break when wrapping indented too-long first words. If the line began with indentation, and the indentation plus first word were longer than the wrapping length, we would put the indentation into the result string. This had two problems: 1. (minor) We ended up with a blank or empty line containing only the indentation. 2. (major) If indent == true, we added the indentation back into the input (remaining) string, meaning the input string was unchanged. But in the usual use case of calling wordwrap_line in a loop until the string is empty, that causes an infinite loop. This could be seen in the xp_by_level table prior to 0.21-a0-211-gdd1ebd0. Fix this by refusing to backtrack into space that precedes the first non-space character. Also add an assert that the remaining string is shorter than the original input, and another assert that we aren't asking to break at column 0. If the indentation itself is too wide, we still end up with a blank line. Don't even bother re-adding the indentation in that case, also to avoid an infinite loop. -------------------------------------------------------------------------------- dd1ebd0 | gammafunk | 2017-08-21 15:04:59 -0500 Decrease the width of the xp_by_level morgue table This table is over 80 characters long, and due to a bug in the morgue display code, trying to display this in-game causes a crash. The table doesn't need as much padding as it currently has, so decrease this. The relevant display code will be fixed in a subsequent commit. -------------------------------------------------------------------------------- bfa5647 | gammafunk | 2017-08-20 12:47:28 -0500 Fix turn tracking for turns_by_place and xp_by_level dump tables The turns were being tracked at the end of the input loop, but this lead wildly innacurate turn reporting due to the complicated relationship between the input cycle and world reaction. Move this accounting to where the game's turncount is actually incremented, as this is guaranteed to be when the turn actually changes. -------------------------------------------------------------------------------- b77565a | gammafunk | 2017-08-20 12:47:28 -0500 Save compat for LevelXPInfo tracking -------------------------------------------------------------------------------- 9cb1729 | gammafunk | 2017-08-20 12:47:27 -0500 An xp_by_level XP tracking table for morgues This commit adds a dump table called "xp_by_level" which shows, for each level, the XP gained by the player from generated monsters and level spawns, the percentage of total XP that comes from spawns, counts of monsters killed of these categories, the proportion of these counts that were spawns, and finally the turns spent on the level. Here "generated" refers to monsters that were created upon level creation, as opposed to spawns which get created over time as the player is on the level. This table does not include spawns generated by the Orb, but spawns generated in the Abyss or in other disconnected branches without the Orb are counted. This information will be useful as we look into overhauling the monster spawn system, since we currently don't have a good way to see what proportion of XP comes from generated vs spawned monsters. I am enabling this table by default in morgues for the time being so that we can get some statistics from online games. -------------------------------------------------------------------------------- 4a9efaf | Neil Moore | 2017-08-19 18:46:21 -0400 Remove unused descriptions. Cutlass, Turn Visible ability, and short-range portal. [skip ci] -------------------------------------------------------------------------------- 7d95abb | Neil Moore | 2017-08-19 18:46:21 -0400 Checkwhite. [skip ci] -------------------------------------------------------------------------------- e9f4a53 | Chris Campbell | 2017-08-19 21:07:42 +0100 Improve some berserk checks -------------------------------------------------------------------------------- e2129ae | Alex Jurkiewicz | 2017-08-19 20:23:13 +0100 Gozag: don't offer useless haste/berserk in petition This change was inspired by the request here: https://crawl.develz.org/tavern/viewtopic.php?f=8&t=23992 Since even gods cannot override racial restrictions against berserk (undead, formicid) or haste (formicid), don't let Gozag offer these potions to ineligible species. Previously, the effects would be added to offered potions but have no effect (except increasing the potion cost). This makes offered potions slightly better on average for affected species. [MarvinPA: amended slightly from the PR to only block berserk rage for species where it's always useless, instead of checking temporary statuses that can prevent berserk. Should really have a cleaner check rather than partially duplicating the is_useless_item handling, though. Closes #575.] -------------------------------------------------------------------------------- b066a6e | Chris Campbell | 2017-08-18 17:28:18 +0100 Fix Passwall uselessness message (#11185) -------------------------------------------------------------------------------- adde233 | Chris Campbell | 2017-08-18 17:28:18 +0100 Mark !degeneration as useless for gnolls (#11186) -------------------------------------------------------------------------------- 8501b10 | Benoit Giannangeli | 2017-08-16 10:50:00 -0700 Several arrival vaults -------------------------------------------------------------------------------- b89f83b | Alan Malloy | 2017-08-15 13:30:25 -0700 Globally replace s == "" with s.empty() It's the standard C++ style. -------------------------------------------------------------------------------- 94b3988 | Alan Malloy | 2017-08-15 13:30:25 -0700 Factor out some repeated map-building logic -------------------------------------------------------------------------------- e013ddc | Alan Malloy | 2017-08-15 13:30:25 -0700 Use an rvalue reference to avoid some pointless copies -------------------------------------------------------------------------------- 68382d6 | Alan Malloy | 2017-08-15 13:30:25 -0700 Fix a misplaced semicolon -------------------------------------------------------------------------------- 6a663c0 | Jared Miller | 2017-08-14 15:58:01 -0700 Toggle setting for modifier prefix keys / and * A new setting is introduced called `use_modifier_prefix_keys` that enables and disables '/' behaving as SHIFT and '*' as CTRL. It's set to true by default. -------------------------------------------------------------------------------- c079aee | John Boyle | 2017-08-14 10:05:18 -0700 Fix some spell highlighting -------------------------------------------------------------------------------- 8a2c2cd | John Boyle | 2017-08-14 09:58:10 -0700 Make Dith hate ALL fire spells (bepbepimjep, #10969) -------------------------------------------------------------------------------- 085b6a0 | Neil Moore | 2017-08-13 11:11:16 -0400 Remove several decor vaults. We aren't going to "take back" these symbols. They symbolise real hurt for real people, and have no place in Crawl. -------------------------------------------------------------------------------- 19e426f | gammafunk | 2017-08-13 09:16:08 -0500 Adjustments to a float vault Some changes nzn_random_ring. These are largely small changes but should help make the vault a more effective (and rewarding) challenge: * Remove no_item_gen tag. * Randomize numbers of monsters, keeping the average number in line with the previous numbers. * Don't thin out either loot or trap placement so much, since we're not placing many of either and the monster count doesn't change much with depth increases. * Don't place loot/traps on specific "routes" through the vault, instead randomizing by area. * Don't block half of the vault with deep water or lava, since this tend to simply make the vault easier by stranding non-flying monsters. * Rework statue placement so that any statue monsters are placed in more effective positions and any stone statues don't create choke points. * Make wall randomization use contiguous walls, randomizing each "shell" instead of putting a smattering of different wall types in every shell. * Refactor glyph usage and simplify some syntax. -------------------------------------------------------------------------------- 913a6fd | gammafunk | 2017-08-13 09:16:08 -0500 Clean up water placement in a float vault When placing nzn_motion_control in shoals, don't ever place the merfolk avatar directly next to the upstairs. Also some minor cleanups to SUBST. -------------------------------------------------------------------------------- e734baf | nikheizen | 2017-08-13 08:56:07 -0500 Two float vaults nzn_motion_control Plays off of two strong monsters (manticore and catoblepas) which restrict movement: one with a cost for not moving, one with a cost for moving. Sometimes spawns in Shoals with an avatar for extra fun. nzn_random_ring A highly randomized vault with an altar and a stairs(or shaft) at the center. It contains several traps, and likely some tough enemies. May also contain some decent loot! -------------------------------------------------------------------------------- 42dbe81 | gammafunk | 2017-08-13 08:56:07 -0500 Adjust tags and syntax in some arrival vaults A bunch of arrival vaults had no_trap_gen for no particular reason. Add no_monster_gen to one vault and simplify syntax in another. TODO: Most of these tags should probably be handled in a common setup function so that vaults don't tend to randomly not have e.g. no_monster_gen. That tag in particular may not actually be necessary for arrival vaults, since monsters already don't generate in starting LOS. -------------------------------------------------------------------------------- b1c986f | gammafunk | 2017-08-13 08:56:07 -0500 Touch up a vault and simplify its glyph usage -------------------------------------------------------------------------------- cb95bf9 | nikheizen | 2017-08-13 07:57:30 -0500 Four simple arrival vaults -------------------------------------------------------------------------------- 02e8684 | Alan Malloy | 2017-08-12 19:06:19 +0000 Bring INSTALL instuctions in sync with themselves -------------------------------------------------------------------------------- 3a6ed1e | Alan Malloy | 2017-08-11 10:23:04 -0700 Improve notes for finding unrand items (aolowin) Add a new note type for unrands, and use it for all unrands. -------------------------------------------------------------------------------- 9126a74 | Alan Malloy | 2017-08-10 11:45:51 -0700 Fix whitespace -------------------------------------------------------------------------------- 4333fbb | Alan Malloy | 2017-08-10 11:45:50 -0700 Use hex literals for octorings, since we use it as a mask -------------------------------------------------------------------------------- 1756668 | John Boyle | 2017-08-10 10:18:36 -0700 Adjust spell memorisation warn priority (damerell, #11169) This update always makes hated or loathed spells show up red in the memorisation menu and always provides a warning message if the user tries to memorise these spells. Add a special message for Trog and adjust relative message priority. Previously, the memorisation screen would prioritise "not enough spell levels" over "divinely forbidden or hated". So if you worshiped Yred and didn't have enough spell levels for Statue Form, it would show up as gray, until you finally had enough levels, at which point it would finally show up as red. Similarly, after selecting the spell for memorisation, there were no additional warning messages reminding the user that their god didn't like the spell. Now there's a red warning message. -------------------------------------------------------------------------------- 586d7bb | Neil Moore | 2017-08-10 10:25:56 -0400 Fix a comment (doh) [skip ci] -------------------------------------------------------------------------------- 8038219 | Neil Moore | 2017-08-10 10:14:18 -0400 Don't merge shop and non-shop ammo in stash search (shmup) As a side effect, this changes the behaviour of sort-by-name, making shop items follow non-shop items that have the same qualname. -------------------------------------------------------------------------------- d2bfb5f | Alan Malloy | 2017-08-09 16:02:25 -0700 Simplify some expressions in skills.cc -------------------------------------------------------------------------------- 0b87683 | gammafunk | 2017-08-08 11:46:17 -0500 Document and reindent a shallow water travel condition Explain why travel through shallow water is not penalized for some aquatic/amphibious species. -------------------------------------------------------------------------------- 5fa6cc7 | cut1less | 2017-08-08 11:45:27 -0500 Let shallow water be like floors for water species ...for autoexplore/autotravel purposes. Merfolk are excluded, since they likely won't want to go through leg transformations except for when the travel formula deems optimal. Committer's Note: Closes #556. -------------------------------------------------------------------------------- b3d4b37 | Neil Moore | 2017-08-07 22:55:03 -0400 Update monster swift and corroded icons (Ultraviolent4, #11177, #11178) -------------------------------------------------------------------------------- 25c56e7 | Neil Moore | 2017-08-07 22:45:47 -0400 Improve that mailmap entry by rewriting the email address as well. [skip ci] -------------------------------------------------------------------------------- 0273943 | Neil Moore | 2017-08-07 22:41:39 -0400 Add an old email address for alexjurkiewicz. [skip ci] -------------------------------------------------------------------------------- 99db44b | Neil Moore | 2017-08-07 01:38:24 -0400 Ignore the Mac terminal profile in checkwhite. Since it contains tabs and isn't usually edited by hand. (skip ci) -------------------------------------------------------------------------------- bca40f3 | Neil Moore | 2017-08-07 01:34:22 -0400 Don't infinite-loop when exploring hits a runed door (#11174). Hitting a runed door results in find_travel_pos returning (0, 0), just like greedily exploring into an item. But that caused us to go into a loop doing CMD_INSPECT_FLOOR and continuing the exploration. Instead, detect in _get_non_move_command() when this happens and return CMD_NO_CMD instead of CMD_INSPECT_FLOOR, stopping exploration. -------------------------------------------------------------------------------- 0f4a3b6 | gammafunk | 2017-08-06 04:18:14 -0500 Move a vault from Depths to late Dungeon (mikee) Mikee still hates you, and wants you to actually have a remote chance to die in his vault. This vault was moved to Depths from mid dungeon when Depths was created, but characters capable of surviving in Depths will find this vault very trivial. D:13-15 is a good home for it, since it's a runed door vault that's easy to survive even after opening the door and is only dangerous when you decide to go for the loot. -------------------------------------------------------------------------------- 0398fc9 | Chris Campbell | 2017-08-05 23:26:15 +0100 Merge pull request #584 from shmup/master Use consistent wording on cards -------------------------------------------------------------------------------- 9838b1c | Chris Campbell | 2017-08-05 23:23:01 +0100 Adjust potions of mutation Make them rarer, and reduce the number of mutations removed from 2-6 to 2-4. Closes #579 PR (and see also the discussion on #563). -------------------------------------------------------------------------------- b3930bd | Chris Campbell | 2017-08-05 23:21:20 +0100 Fix Vehumet enhancing the range of evoked spells (#11168) -------------------------------------------------------------------------------- 9610e65 | Chris Campbell | 2017-08-05 23:07:20 +0100 Adjust a wrath message -------------------------------------------------------------------------------- 58e633f | Chris Campbell | 2017-08-05 23:07:20 +0100 Adjust Revivification spell description -------------------------------------------------------------------------------- 4aaa757 | advil | 2017-08-05 11:28:31 -0400 Add a command to temporarily suppress wiz/debug mode for UI testing Does not save. This doesn't get all aspects of debug output, particularly where they are triggered with just an #ifdef, but it suppresses wizmode hud changes, dprfs, and some key description stuff relevant for a wip. -------------------------------------------------------------------------------- 1f5fe70 | Jared Miller | 2017-08-05 10:59:38 -0400 Use consistent wording on cards -------------------------------------------------------------------------------- 3aa3f5d | gammafunk | 2017-08-04 01:48:30 -0500 Fix glyph usage in a vault (alexjurkiewicz, minmay) This was using an undefined monster list glyph instead of the glyph for a plant, which effectively placed additional normal level monsters (many adjacent to the stairs) that were not intended. Closes #577. -------------------------------------------------------------------------------- 12d3df0 | gammafunk | 2017-08-04 00:55:32 -0500 Remove an unused variable -------------------------------------------------------------------------------- ad606a6 | gammafunk | 2017-08-04 00:06:19 -0500 WebTiles support for monster corrosion and swiftness icons -------------------------------------------------------------------------------- 521290c | Alex Jurkiewicz | 2017-08-04 00:05:56 -0500 Improve tile_flags alignment Committer's Note: Closes #580. -------------------------------------------------------------------------------- 286e31c | Alex Jurkiewicz | 2017-08-03 22:27:18 -0500 Add a tiles icon for monster swift status Committer's Note: Displayed when monsters have swift status for fast movement e.g. when alligators use their sprint ability. -------------------------------------------------------------------------------- 2b035f2 | Alex Jurkiewicz | 2017-08-03 22:27:17 -0500 Add a tiles icon for monster corrosion Committer's Note: Displayed when monsters become corroded. -------------------------------------------------------------------------------- b89e0e2 | Corin Buchanan-Howland | 2017-08-03 21:17:52 -0400 Remove a mistaken copy-paste (|amethyst) -------------------------------------------------------------------------------- 77413b7 | gammafunk | 2017-08-03 10:18:11 -0500 Fix autoexplore not starting properly under some conditions (#11159) Broken in dd972a7a, autoexplore would automatically stop running in some cases where it should be sending the command to inspect the floor. Fix the function that determines non-move actions so that it properly handles autoexplore. Refactor run mode and other state changes out of this function, allowing them to happen in the caller, so the logic is cleaner. -------------------------------------------------------------------------------- b8a8bae | gammafunk | 2017-08-02 04:29:05 -0500 Tweak the layout of a abyssal rune vault This vault previously had each chamber leading to a distinct section at the end of the vault, one containing the rune and one containing the exit transporter and a powerful monster. This tended to be a bit confusing to the player if they reached the transporter first, since they might think the transporter will take them over to the rune area, which was visible from the transporter. Additionally even if the player randomly chose the chamber leading to the rune, they could avoid the transporter guardian by possibly using an exit that appeared in the vault if they killed enough monsters, by resting until the abyss shifted them, or by simply reading a teleport scroll, thus avoiding monsters in the other chamber and the transporter guardian. This commit reworks the vault to have both chambers lead to the rune/exit area, making it harder to avoid monsters in either chamber or the transporter guardian, but still allowing the transporter to be used for escape. It also adds a apport-blocking wall to the room holding the rune that works even if doors are opened by monsters. -------------------------------------------------------------------------------- b5400c9 | gammafunk | 2017-08-01 17:41:01 -0500 Fix transporter placement in an abyssal rune vault (advil) -------------------------------------------------------------------------------- 78480df | advil | 2017-07-30 14:15:42 +0200 Fix conditions under which shop contents are included in search (bel) Shop contents will now always be shown unless `shop` appears in the search, and the relevant items don't otherwise match. This commit in particular fixes `.` and `..`, which (because when interpreted as regexes match `shop`) were not showing shop items. -------------------------------------------------------------------------------- 1393dd0 | advil | 2017-07-30 13:48:32 +0200 checkwhite / unbrace -------------------------------------------------------------------------------- a4fe563 | gammafunk | 2017-07-29 17:44:29 -0500 Improve visibility into a Trog-themed transporter vault (EMTedronai) Previously the vault emtedronai_trogs_sanctum only revealed one side of the vault, which didn't include the transporter destination. This version adds another level-connected side to the vault with transparent stone to reveal that destination and moves the transporter to this side. -------------------------------------------------------------------------------- c243083 | gammafunk | 2017-07-25 22:27:09 -0500 Update the lightning rod description -------------------------------------------------------------------------------- cbbc58b | gammafunk | 2017-07-25 22:19:46 -0500 Don't reset lightning rod power charge as long as uses are consecutive Previously when the power charge reached 4 (after 4 turns of consecutive usage), the charge reset to 0 on the next lightning rod usage even if it was consecutive. This commit simply caps the charge increase at 4, only resetting it when a turn is spent not using the lightning rod. This is only relevant when killing enough monsters with the rod to regain a usage charge and hence allow more than 4 consecutive uses, but this is possible when killing monsters worth a lot of XP. TODO: Implement UI like for Searing ray depicting the lightning charge state with a + for each charge level that is reset when a turn is spent not evoking the lightning rod. -------------------------------------------------------------------------------- dcd0815 | gammafunk | 2017-07-25 21:32:54 -0500 Don't reset lightning rod charge power when recharging in wizard mode This variable no longer tracks usage charges, just charge power, so don't reset it. -------------------------------------------------------------------------------- aca7846 | gammafunk | 2017-07-25 21:31:55 -0500 Use key variables to look up lightnind rod properties -------------------------------------------------------------------------------- 612aa8a | gammafunk | 2017-07-25 03:55:20 -0500 Save compat for the lightning rod recharging change When loading old saves that have lightning rod charges used but with some charges remaining, set XP debt based on the number of charges used so players don't get free charges. -------------------------------------------------------------------------------- fc1d822 | gammafunk | 2017-07-25 03:53:19 -0500 Give lightning rods a power bonus only for continuous fire Having used charges now only confers an increasing power bonus when the previous turn was also spent using a lightning rod. Before this commit, the power bonus was conferred regardless of what had been done on the previous turn, since usage charges and charge power were tracked in the same player property. -------------------------------------------------------------------------------- 7fa0e82 | gammafunk | 2017-07-25 03:46:00 -0500 Allow lightning rods to get XP recharge when partially used Previously the lightning rod couldn't recharge unless it was fully used, which is awkward gameplay-wise, since it might encourage players to waste a shot so they could begin recharging and receive many more charges. This commit reworks the charging mechanic so that lightning rods are always recharging when they have charges used. This commit refactors XP evoker charging to allow for different evoker types to have different XP "debt" with each use and for then tracking the available number of charges based on how much XP debt there is. All XP evokers except lightning rod still have a max charge of 1 and set their old XP debt value when used, but now the lightning rod sets a smaller value for each use, increasing XP debt to a maximum of four times this value. -------------------------------------------------------------------------------- 1ab7d47 | gammafunk | 2017-07-23 21:54:53 -0500 Add a travel color option to reduce console map ambiguity (8471) Previously, squares that were safely traversable but forbidden from travel received the same console map color as dangerous squares. This meant that when shallow water was added to the travel_avoid_terrain option, shallow water was rendered the same as deep water (and lava) in the map. This made the map much less useful in branches like Swamp and Shoals. This commit adds a tc_forbidden option defaulting to a color value of light cyan and uses this for all squares that are forbidden by travel but otherwise safely traversable, leaving dangerous squares as cyan. Hence shallow water will always be distinguishable from deep water in the console map by default. -------------------------------------------------------------------------------- dd972a7 | gammafunk | 2017-07-20 23:44:17 -0500 Allow travel to work through explored transporters With this commit, players can target squares on the other side of explored transporters and travel will enter transporters as necessary to reach the given squares without interruption. Previously travel had to be done by targeting the transporter itself and entering manually. TODO: It would be nice to extend the emphasis functionality to allow showing transporters whose destinations were known but which had never been visited. This would let us to automatically add the transporter destination knowledge to the travel cache when a transporter's landing site first came into LOS, allowing a player to verify exactly where a transporter takes them if they wish. We could additionally allow travel to a square behind a transporter that had never been taken (but for which the destination was known) to take the player all the way to the transporter itself but not enter. This is the way runed doors behave, but currently transporters only have two states in the travel cache, known and unknown. Additionally the map emphasis code only allows for emphasised and unemphasised, and "known destination, but never visited" would need to be an intermediate state between "transporter with unseen landing site" and "transporter that has been entered at least once". -------------------------------------------------------------------------------- 31ae3e2 | gammafunk | 2017-07-20 22:53:55 -0500 Add a transporter destination retrieval function -------------------------------------------------------------------------------- 479285b | Chloe Kudryavtsev | 2017-07-19 03:41:08 +0200 Fix various typos in jewellery hints (fixes #571) Fixes: - Repeated "a" - Missing `10 monsters means the open layout isn't a huge problem. So, make two changes: 1) Tweak the monster sets. Old: 6 draconian, 6 dragon, 6(!) ghost moth New: 9-13 dragons, 3 ghost moth, 3 moth of wrath 2) Replace the runed doors with transporters. Now, the player has to step in, walk around the central stone feature, pick up the mask, then get to the exit transporter. There is some randomness built in to which direction the transporters operate in and where they are placed internally. Comitter's Note: Squashed two commits from the PR that fixed some errors and improved the vault layout and loot placement. Closes #567. -------------------------------------------------------------------------------- ea7d1d1 | gammafunk | 2017-07-05 22:55:50 -0500 Rework a digging themed transporter vault Previously gammafunk_dig_for_victory had an escape hatch very near the vault entrance to prevent accidental stranding of characters who can't use evocable dig and had problems with monster positioning. The digging monsters needed careful positioning to ensure groups of monsters were released, and even then the released monsters often had difficulty moving around undiggable transparent stone. This commit reworks the vault to have a less complicated arrangement with less transparent stone and with the escape hatched moved to a central area with monsters, making it less accessible as an escape option. Now two digging monsters are awakened upon entrance to the vault but won't dig until the player has moved significantly into the vault and into the view of a third digging monster near the escape hatch. This third monster is always able to be reachable through player LOS and will dig to allow access to the hatch even for players who can't use evocable dig. The vault has three groups of monsters, but by taking a route through the North or South sides of the vault, the player can to dig out only one of the three groups of monsters and fight only these in a favorable path they've dug before taking on the central group. From there they can get to the loot area potentially before the third group is even released. Generally it's easier to get ambush by multiple groups of monsters in the updated vault, but some tactics (including use of dig) can make the fighting much easier. The vault now can place on Crypt:1-2, has better monster sets in non-Depths/Dungeon branches, and correctly uses a gate to another level in Pan instead of a branch exit. -------------------------------------------------------------------------------- fc5ccf7 | gammafunk | 2017-07-05 22:42:02 -0500 Use a better monster selector in some vaults Use "nonbase draconian" instead of hardcoded lists. -------------------------------------------------------------------------------- 7b58145 | gammafunk | 2017-07-04 20:01:45 -0500 Don't leak information about unseen transporters (#11066) When gathering a list of transporters the player has seen, properly test that the player has actually seen the transporter. Before this commit it was possible to have autoexplore warning about unvisited transporters when the player had not encountered them yet. -------------------------------------------------------------------------------- f2cc702 | gammafunk | 2017-07-04 20:01:44 -0500 Remove a redundant condition Transporters already return true for feat_has_solid_floor(). -------------------------------------------------------------------------------- 9333ff4 | gammafunk | 2017-07-04 20:01:44 -0500 Use an accurate parameter name in a method declaration -------------------------------------------------------------------------------- 2e6bd0f | gammafunk | 2017-07-04 20:01:43 -0500 Improve message when both a runed door and a transporter are unexplored Previously, if both a runed door and a transporter were unexplored, the autoexplore message only indicated the presence of runed door. With this commit, both will be indicated. -------------------------------------------------------------------------------- 6b14a1c | gammafunk | 2017-07-04 20:01:42 -0500 Tweak the transporter minimap color to blue Orange on a single tile was difficult to distinguish from the yellow color used by portals and the color used for branch entrances, whereas 100% blue is well distinguished from other minimap colors in use. -------------------------------------------------------------------------------- 36601da | gammafunk | 2017-07-04 20:01:42 -0500 Reformat the character lists for console glyphs Move comments above the relevant line so the lines don't have to wrap so early, and rewrap spacing to consistently allow unicode char designations and escape symbols. -------------------------------------------------------------------------------- 97cf70a | gammafunk | 2017-07-04 20:01:41 -0500 Save compat to add landing sites for existing transporters When loading a level marshalled by a version before this commit, create transporter landing sites at the destinations of all transporters on the level. There is only one existing subvault that chained transporters together, the_bubble_gammafunk_roulette, and while this will effectively remove two transporters in that vault for levels that placed the old version of the vault, this will not leave the player stranded, since the exit transporter takes the player outside the vault to an otherwise empty square. Other vaults had transporter destinations that were already normal floor tiles, so old placements of these vaults will continue to function after save compat converts the destination tile to a landing site. -------------------------------------------------------------------------------- 3d14fa4 | gammafunk | 2017-07-04 20:01:41 -0500 Rework the transporters in a vault Now transporters have landing sites, don't chain the transporters in the_bubble_gammafunk_roulette, but group them in pairs so that after taking a transporter the player find another nearby. Move the exit transporter off to a location towards the extreme corners of the map instead of mixing it in with the "roulette" transporters. -------------------------------------------------------------------------------- 1597e25 | gammafunk | 2017-07-04 20:01:41 -0500 Make transporters have a designated landing site terrain feature Previously it was not easy to show the player where a transporter would take them even in vaults that tried to make this clear, since a transporter could land the player on any habitable feature. Additionally it would be difficult to implement a UI to allow the player to remind themselves of the destination of a visited transporter. This commit adds a "transporter landing site" terrain feature that is essentially a normal floor tile placed at a transporter's destination for reminder/indication purposes. Eventually the map UI will be modified to allow the player to see a visited transporter's landing site in the travel cache through a designated key. The landing site feature uses the same glyph/tile as a transporter, but is darkgrey in console and greyscale in Tiles with a darker magenta color on the minimap. The feature description makes it clear that it can't be used to return back to the transporter entrance. -------------------------------------------------------------------------------- 06f091e | suomenusko | 2017-07-03 09:52:29 -0400 Change oka and trog acquirement texts to be more informative I think this should be pretty self explanatory. I have always found it mildly annoying when you get a gift in the middle of being shot at by a pack of yaktaurs, only to wonder where it went afterwards since it was just bolts. This changes the gift message text for Oka and Trog to be more specific as to what it gave, specifically ammo, weapon, or armour. -------------------------------------------------------------------------------- dd6ab6a | gammafunk | 2017-06-30 22:53:18 -0500 Move vaults to the proper section in a des file -------------------------------------------------------------------------------- 41815f1 | Mark Donahue | 2017-06-30 22:51:38 -0500 A stone intersection mini vault. Committer's Note: Added transparent tag to the vault and cleaned up commit message. -------------------------------------------------------------------------------- 7bf63f6 | advil | 2017-06-30 17:47:40 +0200 Convert a segfault into an ASSERT failure This is targeting a crash that can happen if a monster-thrown penetration missile causes the attacker to die (e.g. via inner flame) before other monsters are hit. The bug is hard to fix (would need to save the attacker, or rewrite penetration) but this change is easy enough. See e.g. http://crawl.berotato.org/crawl/morgue/Ofeo/crash-Ofeo-20170630-001453.txt -------------------------------------------------------------------------------- a5031da | Chris Campbell | 2017-06-27 21:08:51 +0100 Merge pull request #557 from ufshaikh/doc-change-(ogre-description) Remove manual's reference to Ogres' especially good maces aptitude -------------------------------------------------------------------------------- 54e4307 | gammafunk | 2017-06-27 02:00:57 -0500 Fix ORIENT and DEPTH tags on some float vaults A few transporter vaults in float.des were missing their float orient, hence were placing as minivaults. Fix this, and and for these and a couple other vaults, put the ORIENT line after the DEPTH line to style consistency. For gammafunk_sealed_arena, don't try to place this vault in the Vaults branch. Float vaults don't work in this branch due to how the layout works. This vault would place successfully using `P' in wizard mode when the vault was (accidentally) a minivault, but minivaults are never actually placed in this branch. It may be adaptable to a room vault, but that would require making a separate vault altogether. -------------------------------------------------------------------------------- 13b9641 | Nikhil Addleman | 2017-06-25 11:31:16 -0700 Fix alignment of Items table in crawl_manual.rst -------------------------------------------------------------------------------- 268a196 | advil | 2017-06-25 19:08:56 +0200 Fix behavior of tile_full_screen with some associated refactoring This value defaulted to something it couldn't be set to in the rc file, and the behavior on reading this field was also weird (including a somewhat iffy cast from screen_mode to bool and back that breaks the default setting on an bad value). This lets it be explicitly set to a third value and fixes the documentation. -------------------------------------------------------------------------------- b3e98cc | advil | 2017-06-25 11:06:13 +0200 Ignore negative (relative) window sizes in fullscreen mode This change still lets you set the resolution exactly, but the default of -90,-90 (which is really for windowed mode, I believe) was causing weird behavior. It also isn't clear when you'd want to set the screen resolution in this way, since it is hard to get a good value (some, but apparently not all platforms will just ignore non-standard resolutions anyways). -------------------------------------------------------------------------------- a0cb861 | Corin Buchanan-Howland | 2017-06-24 09:12:31 -0400 Simplify Airstrike damage formula (Hellmonk) The old formula involved multiple layers of nested randomization for no clear benefit. In the words of HellMonk, 'It's easy to replace this damage formula with something much simpler that retains roughly the same mean damage. You want a formula that looks like A + random2(B + div_rand_round(pow,C)). A gives you some constant damage. B > 1 gives you some amount of variability in the damage even at 0 power, and B needs to be at least 1 or the first C points of power won't do anything. C divides spellpower and controls how well the damage scales. Div_rand_round is in there to avoid integer division, which would give really ugly power breakpoints. From there it is just a matter of finding good constants to fit airstrike's mean damage well across all power levels. Duvessa suggested 8 + random2(2 + div_rand_round(pow,7)) on irc. This is slightly stronger at low power and slightly worse at high power. You could just as easily use 8 + random2(1 + div_rand_round(pow,6)) if you wanted it to scale a little better (the average damage is a couple points higher at 200 power). Or, if you really want to get fancy about it, you can find some fraction that gets even closer to the current behavior and multiply power accordingly. The effect of spellpower on damage becomes much clearer with a formula of this type, and it's easy to understand what to tweak if you decide that the balance needs to be adjusted later. You do not preserve some other properties of airstrike's damage formula, including: The first 6 points of power not doing anything (You can preserve this by making B = 0, but this behavior seems bad anyway) The big max damage and the long tail of the distribution The median damage being a few points lower than the mean damage The mode always being 8' -------------------------------------------------------------------------------- 85d6d27 | kenranunderscore | 2017-06-23 15:24:22 -0700 Print a better message when an attempted blink is not possible -------------------------------------------------------------------------------- 1e75fd5 | kenranunderscore | 2017-06-23 15:24:22 -0700 Tree form now fully suppresses the blink and teleportitis mutations -------------------------------------------------------------------------------- db84782 | cut1less | 2017-06-23 14:51:15 -0700 Remove Mottled Draconians from table of aptitudes (#558) -------------------------------------------------------------------------------- 0a4ebe0 | Umer Shaikh | 2017-06-23 14:09:59 -0400 Remove manual's reference to Ogres' especially good maces aptitude Ogres no longer have a particularly good aptitude with maces and flails, as mentioned in the manual. This commit replaces that line with a more up-to-date take on what melee options they find natural. -------------------------------------------------------------------------------- c5150db | Johannes M | 2017-06-22 09:54:35 -0700 Add an autumn forest themed bazaar vault (#551) Add an autumn forest-themed bazaar vault -------------------------------------------------------------------------------- 1f6c8c0 | advil | 2017-06-22 09:01:42 -0400 Restore base value of 5 max kick damage (minmay) Accidentally(?) removed in 6d440e639429. -------------------------------------------------------------------------------- 04744e2 | gammafunk | 2017-06-21 19:52:40 -0500 Allow bazaar vaults to not set floor tile "halos" (Kenran) Previously all shops place in bazaars would always get a circle of floor tiles set around the shop itself. This was done through the main bazaar setup function, so it would be difficult for vault authors to use a different kind of shop decoration. This commit adds default-true argument to the setup function to allow disabling of these floor tile halos on a per-vault basis. -------------------------------------------------------------------------------- 82a99e0 | gammafunk | 2017-06-19 23:29:29 -0500 Make a transporter vault transparent and adjust The vault gammafunk_wand_slinger places a fairly specific types and numbers of monsters, especially early on. This commit makes it transparent to reduce spoilers and adjusts the threat to be a little more forbidable and the reward a little better. Slightly increase the either monster count or difficulty at some depths, making early placements have at least one orc priest, and restrict its max depth to D:13. For non-wand loot we add two gold piles, and add up to two items as the depth increases, but still only giving a single star_item in earlier levels, since at that time a wand is more powerful. -------------------------------------------------------------------------------- 5014f93 | gammafunk | 2017-06-19 23:26:44 -0500 Fix up a transporter vault and move it deeper in the dungeon This vault gammafunk_sealed_library places more monsters on-average compared to the other transporter vaults, nearly all of which have nasty spells. Move it to place on D:12- for Dungeon placements. Fix some errors in the monster definitions and rework the monster loot placement to better balance the types of monsters. Also give the vault extra walling to help keep the library quiet, making it less likely for all monsters to wake up. Finally, replace item defined by a list of magical equipement with a simple jewellery good_item, since that will better appeal to players that don't use spells, and add a couple missing aux armour in the armour item definition. -------------------------------------------------------------------------------- 3dfdc92 | gammafunk | 2017-06-19 23:25:52 -0500 Tweak placement of a trog-themed transporter vault Allow it to place on the final three dungeon levels, since the monsters it places are not significantly more out-of-depth for D:13-14 than they are for D:15. -------------------------------------------------------------------------------- 0c55a54 | gammafunk | 2017-06-19 23:25:51 -0500 Remove a runed door from a vault Tentacled monstrosities are normal level spawns, and this vault is not overly dangerous, since the monstrosity is reavealed before the player can reach it. Also renaming the vault to not indicate that the monster is behind a runed door. -------------------------------------------------------------------------------- 2fc178d | gammafunk | 2017-06-19 23:25:51 -0500 Some tweaks to a transporter vault. In the gammafunk_sealed_arena vault, 8 and 9 roll nothing fairly often in Dungeon , resulting in a lot of missing enemies in that branch, so add two more 9s. Only thin out the 9s in earlier Dungeon, since this vault is not especially dangerous later on and doesn't have a high monster count. Also replace one gold pile with a good_item jewellery and replace another with good_item aux armour in later depths/branches, since the average result of two star_item + 3 superb_item can be quite bad motivation. This rolls mundane jewellery/equip pretty frequently and based on player identification knowledge, so early on it will often be just a jewellery drop, and later on it will have a decent chance of making artefact jewellery. -------------------------------------------------------------------------------- 62f518f | gammafunk | 2017-06-19 23:25:35 -0500 Tweak wall borders in some transporter vaults The vaults changed in this commit prefer to have the monsters inside not wake until they come into view of the player from inside the vault, but had only single tile walls previously, so monsters frequently would wake before the player entered. The vault gammafunk_its_a_trap in particular works best when monsters don't wake, but some very loud things like alarm traps have woken monsters up in this vault. These vaults also all are fully surrounded by floor perimeter that isn't necessary except before any transparent stone, where something is intentionally exposed to the player outside the vault. This commit replaces the floor perimeter with another layer of stone, helping to further insulate the monsters from noise. This also will tend to explose less of the vault to noise, since the vault can now place adjacent to any rock on the level. Industrious players can still make enough noise to wake the monsters in most of these vaults if they wish to (e.g. scrolls of noise and some of the loudest spells). -------------------------------------------------------------------------------- bbb65ab | advil | 2017-06-19 10:38:58 -0400 Warn on placing encompass vaults in the wrong place with &P (kenran) This usually fails / crashes if the vault isn't designed for the place. Then since `wizard_recreate_level` saves (several times!) during its process, this typically leads to a corrupted save. For example, placing a bazaar or other portal vault in the dungeon, and in some cases mixing portal vault types. Even placing depths encompass vaults in D isn't safe in general in my testing. &L is generally ok, because it has far fewer checks. In a few cases this warning is a little over-enthusiastic, e.g. it warns on placing lemuel_river_lethe on depths 1 even though that is technically ok. But anyone using wizmode should be able to handle that. -------------------------------------------------------------------------------- 5e5ddd2 | advil | 2017-06-18 11:36:22 -0400 Prevent crashes when a spiny monster kills itself under Usk pain bond Fix suggested by |amethyst. -------------------------------------------------------------------------------- 32e1473 | advil | 2017-06-17 14:24:01 -0400 Add a bounds check oops -------------------------------------------------------------------------------- 3fa40af | Kyle Rawlins | 2017-06-17 13:08:15 -0400 checkwhite + unbrace -------------------------------------------------------------------------------- 37f9256 | Kyle Rawlins | 2017-06-17 13:01:42 -0400 Fix behavior of translevel autotravel when called on walls (10802) Previously this would do really weird things when called on walls or other non-traversable positions, depending on various factors like whether you were standing on stairs; typically it would try to send you off-level (see Yermak's bug report for the exact conditions). This is triggered when traveling from the `X` display, which always calls translevel travel (even if you're looking at the curent level). The problem was that some of the translevel pathfinding code doesn't differentiate between inaccessible without translevel travel vs plain inaccessible. I left this code as is & added a note about this assumption, and added a check earlier, so X. into a non-traversable feature on the current level fails immediately. If you try to autotravel to a solid (or non-traversable) feature on a different level, this will still send you to that level, but stop when you get there. I'm not sure if this is the ideal behavior. -------------------------------------------------------------------------------- 3f13d09 | Corin Buchanan-Howland | 2017-06-16 19:48:36 -0400 Lessen the odds of corrosion stacking Changed the formula for blocking corrosion from prev_corr in prev_corr+9 to prev_corr in prev_corr+7. The aim is to make spammy corrosion a little less absurd. -------------------------------------------------------------------------------- b9da00d | Corin Buchanan-Howland | 2017-06-16 19:38:23 -0400 Decrease entropy weaver cast rate From 1/5 to 1/8. Hopefully this will make them likely to be machine-gun corrosion machines and also make them more actually threatening. This is not meant to rule out further changes, like giving them staggered casting ala giant eyeballs. -------------------------------------------------------------------------------- 20745e5 | Corin Buchanan-Howland | 2017-06-16 19:23:03 -0400 Make caustic shrikes a normal spawn on Depths:5 again Caustic shrike density was a bit low in the average game. -------------------------------------------------------------------------------- 1c0f2e3 | gammafunk | 2017-06-16 06:13:50 -0500 Add missing branches to Vim DES syntax file and clean up formatting Mostly try to wrap lists of keywords at the 80 line length. -------------------------------------------------------------------------------- e63d07c | gammafunk | 2017-06-16 03:58:57 -0500 Support lua markers in the DES Vim syntax file Parse the lua after the marker definition as lua, allowing multiple lines using backslashes at the end of line. -------------------------------------------------------------------------------- 11b2297 | EMTedronai | 2017-06-16 03:45:06 -0500 Do not hard-code colors in levdes.vim. The hard-coded color definitions in the .des syntax file did not play well together with a lot of vim colorschemes. This commit removes the hard-coded colors and links instead to predefined syntax elements which should be recognized by every Vim colorscheme. Of course this means that it is no longer guaranteed that water is displayed in a blueish color in every colorscheme. But I think being readable in every colorscheme is much more important. If someone is not happy with how the map is displayed in their favorite colorscheme, they still can use an autocmd to change the colorscheme just for the des filetype. The only thing I am not completely happy with is stone (c) and metal (v) walls using the same color definitions. I would link metal walls to something else, but if you use Vim in 8 color mode the fallbacks will usually result in 'v' having either the same color as 'w' or 'W'. And I definitely want to avoid that since it can get quite hard to distinguish in that case. I think 'c' and 'v' are distinct enough to share the same color (and usually they are not used right next to each other). This commit should also resolve the issue of the syntax coloring breaking when changing the colorscheme with an open des file. The issue here was that vim syntax files are not reevaluated when changing colorschemes. This resulted in the hard-coded definitions of the syntax file being overridden by the colorscheme change and not being reapplied afterwards. Committer's Note: Closes #543. -------------------------------------------------------------------------------- 23bf262 | gammafunk | 2017-06-16 03:08:34 -0500 Some adjustements to a transporter vault In emtedronai_trogs_sanctum, make the loot more even between gold and star_item to give the vault more appeal to adventurous players. Also move the exit transporter destination off the entrance transporter, make there be less blood for the blood god, and reformat some of the glyph usage to make it consistent with lower-case for solid terrain, upper-case or symbols for habitable terrain. This closes #548. -------------------------------------------------------------------------------- a9a1f1c | Elan Morin Tedronai | 2017-06-16 03:08:34 -0500 Transporter vault: Trog's Sanctum. Trog's most devout followers finally succeeded in creating a secret haven devoid of all influences of forbidden magic. Will the hero dare to desecrate this sacred place of silent rage? The vault makes sure that the player is aware of the silence by placing the entry transporter inside the silence field. Because of the silence it is very easy to pull all monsters individually and fight them one by one. In the end it comes to the player being able to fight the (potentially berserking) boss monster while being silenced. Mainly magic focussed characters should probably refrain from entering ;-) Unfortunately for the player, the imprisoned magic users are not very grateful for their rescue once the field of silence is being lifted :-/ -------------------------------------------------------------------------------- 7b0e191 | Nicholas Feinberg | 2017-06-15 16:23:48 -0700 Ungroup same-name mons in webtiles list (11110) Probably two orcs named 'Boldo' should get separate entries. Note that mon-info::less_than will also have to change if we want the same behavior for the local tiles monster list, but I'm not sure if it's actually a problem there? -------------------------------------------------------------------------------- 625dad4 | cut1less | 2017-06-15 13:53:53 -0400 Fix viable species/background option -------------------------------------------------------------------------------- dbfcba7 | Kyle Rawlins | 2017-06-15 13:19:37 -0400 Prevent random xom crashes on felid revival If xom_tick got to the point of calling `xom_choose_action`, this would crash on an old assert. This commit lets xom act immediately after revival, which may or may not be desirable (before it was impossible, because the game would crash instead). I've also prevented xom from taking credit for a felid revival (I'm not sure when this triggered before, but it would always trigger in the case that previously crashed. This change is just cosmetic. -------------------------------------------------------------------------------- 828620c | Alan Malloy | 2017-06-14 23:10:59 -0700 Fix a teleport closet in dpeg_arrival_solitude (Slave-to-Armok) -------------------------------------------------------------------------------- b612c23 | advil | 2017-06-13 22:51:06 -0400 Make Hep mutation wording more Hep-specific Based on the second report I've seen about someone new to Hep being confused about this vs regular frail. (The first was me, I even tried to cure it a few times before realizing.) -------------------------------------------------------------------------------- 4ad91a0 | Corin Buchanan-Howland | 2017-06-13 22:26:46 -0400 Make amulet of magic regeneration give a fixed bonus The amulet now gives 1/4th of an mp each turn instead of +50% of current mp regen each turn. Since mana regen is 7/100ths of a mana + 1/100th per 2 maxmp, this amulet now gives regeneration equal to 50 additional mp. This breaks even with the previous version at 36 mp. At less mp, it is better, and at higher mp it is worse. I made this change both for better parallel with the amulet of regen and because the amulet had very little effect in the part of the game where additional mp regeneration would make the most difference. I am hoping that this change will make the amulet a little more competitive with other strong amulets. I'm not particularly worried that having access to faster mp regeneration as an amulet will push magic-heavy builds over the top. -------------------------------------------------------------------------------- 44a88e3 | Corin Buchanan-Howland | 2017-06-13 22:26:45 -0400 Make HP/MP regen display more granular. -------------------------------------------------------------------------------- bf49515 | Corin Buchanan-Howland | 2017-06-12 21:15:17 -0400 Make Fedhas Sunlight targeter accurate Now it shows the radius correctly. -------------------------------------------------------------------------------- ea492e9 | elliptic | 2017-06-11 16:11:24 -0400 Revert "0.20 tournament reminder." This reverts commit 8b44e269dd4b56ba3d8c41eddb8065157e2e9f4f. -------------------------------------------------------------------------------- 941c862 | advil | 2017-06-10 13:12:43 -0400 Add a `-` to the new cooldown status lights Though the wording in % is clear, the "you can't do this" nature of these status displays was only indicated by color (yellow), which was somewhat confusing (e.g. yellow "Recite" = can't recite white "Recite" = reciting) and also not very accessible. This now displays yellow "-Recite", "-Tornado", etc., which might have other misconstruals but I think are overall clearer. -------------------------------------------------------------------------------- 7bf2ba4 | Alan Malloy | 2017-06-08 17:56:14 -0700 Convert launch_retval to an enum class This way we can't accidentally coerce it to a bool. Since we *were* coercing it to a bool in several places, I also fixed the compile errors at those locations. Only one looked like a definite bug (hints-mode prompts about how to use ammo); someone should also look at _mons_has_usable_ranged_weapon, which treated throwable missiles as ranged weapons: it wasn't clear whether that's intended or not, so I left it alone (saying yes, they should count as ranged weapons). This commit was inspired by 2d4c0a5, which did indeed have a bug of exactly this sort. -------------------------------------------------------------------------------- 2d4c0a5 | Alan Malloy | 2017-06-08 17:16:10 -0700 Don't let equipped-weapon accuracy affect throwing accuracy (minmay) -------------------------------------------------------------------------------- 7c8f537 | gammafunk | 2017-06-07 06:19:02 -0500 Fix the Android build by adding l-wiz.cc to the Android.mk build file. -------------------------------------------------------------------------------- df2c162 | advil | 2017-06-06 13:29:33 -0400 Extremely basic lua bindings for fsim This also adds a proof-of-concept test that calls fsim 10 times with a lot of iterations and prints the AvEffDam. -------------------------------------------------------------------------------- c929894 | advil | 2017-06-06 13:29:32 -0400 Fix NOWIZARD builds It seems that this isn't widely used. -------------------------------------------------------------------------------- b82119a | advil | 2017-06-06 13:29:32 -0400 Fix up restoration/sustab innate muts on load The removal of these mutations didn't zero out their innate mutation levels properly, and so saves that underwent the previous upgrade could crash on a mutation validation assert. -------------------------------------------------------------------------------- 1479571 | Kyle Rawlins | 2017-06-05 12:06:49 -0400 Add some more detail to the potion simulator Calculate the mean number of resulting mutations (currently sitting at around 3 if I've got this right). -------------------------------------------------------------------------------- b537e02 | Neil Moore | 2017-06-04 10:52:17 -0400 Make holiday meals of shrikes and bennus. -------------------------------------------------------------------------------- 5e91fef | gammafunk | 2017-06-02 21:33:02 -0500 Remove an entry vault that can get a player stuck behind grates Random blink or Hop can land a player behind the grates. Using transparent rock would fix this, but I've spoken with Doesnt, who prefers removing the vault over making the vault's low security prison theme worse. -------------------------------------------------------------------------------- e4214e1 | gammafunk | 2017-06-02 03:34:39 -0500 Remove the 0.19 survey message The survey is now closed and 0.20 has been released. This reverts commit 99dbe1240bc0091a40e4a3c9e011386fb95b6b0c. -------------------------------------------------------------------------------- 28ea6b7 | advil | 2017-05-29 14:15:02 -0400 Update options doc to reflect default change in tile_web_mouse_control [skip ci] (cherry picked from commit 6b59dc7fbf78e9f6a5c5a43a9eeb167fb5bb8d21) -------------------------------------------------------------------------------- 95c5c02 | gammafunk | 2017-05-28 00:10:36 -0500 Down-weight two transporter overflow vaults Make gammafunk_overflow_arena weight 1 and reduce the number of altars it can place to 3. It was still a common vault even with weight 5, more so for higher numbers of altars which have fewer vaults. This is a challenging overflow vault that I'd like to be relatively rare. Future fixes to mapstat might let me get a better idea of just how common it and other overflows are, but until then err on the side of caution. Also fix some glyph issues with this vault and down-weight gammafunk_temple_of_torment for the same reason as for overflow_arena. -------------------------------------------------------------------------------- 7dc85f4 | gammafunk | 2017-05-27 22:40:40 -0500 Allow transpoters to show up stash searches (qw) This allows another easy way for the player to travel to transporters in addition to `X >'. It might be ideal to have autoexplore move the player next to this location as is done for runed doors, but that's a more complicated change that can be done later. -------------------------------------------------------------------------------- 307f10e | gammafunk | 2017-05-27 21:16:18 -0500 Remove a player-based veto from a vault and adjust placement Instead of a veto based on the player's mutations/race, simply place a down-hatch as an alternative to the dig wand for character that otherwise might not be able to use the wand. This always allows us to not specific set wand charges since if the player runs out, they can still escape. Also adjust placement so that the down-hatch can always place and remove generation in Dis, since this is a loot vault and we try to not have those in Hells. -------------------------------------------------------------------------------- 70e9ed9 | gammafunk | 2017-05-27 20:50:31 -0500 A digging-themed transporter vault The player is given an identified wand of digging with sufficient charges to carve a path to the loot they saw before entering. Two sealed groups of nasty monsters are also visible from the outside, with digging monsters positioned inside so that they will dig through the rock "seals" as they spot the player. Additionally there is little non-diggable terrain, so if the player wants to fight through the monsters in some kind of terrain they can controll, they'd better try to take care of the diggers first. It's possible to use stealth or controlled blinking to get past the digging monsters before they have a chance to release a seal, but this has to be done carefully from the right positions and timing turn-wise. So there are a few different strategies for the vault ranging from trying to tab through the horde with what useful rock they have left to outright sneaky theft. The vault vetos for non-formicid worshipers of Ru who have sacrificed evocations, out of an abundance of caution, since those might enter the vault with no way to teleport out. -------------------------------------------------------------------------------- b2ef3f0 | advil | 2017-05-27 21:18:02 -0400 Handle mutation names with uppercase properly (elliptic) Makes mutation_from_name fully case-insensitive. -------------------------------------------------------------------------------- 8b44e26 | elliptic | 2017-05-26 15:54:40 -0400 0.20 tournament reminder. -------------------------------------------------------------------------------- a058ae7 | Kyle Rawlins | 2017-05-26 15:45:02 -0400 Don't display local tiles tooltip on out of view cell This was causing random-seeming crashes on resize (and switching between fullscreen and windowed). In principle this probably means that something is weird about the mouse position vs the grid at the point of this call, but I couldn't figure that out. -------------------------------------------------------------------------------- ddac83b | Kyle Rawlins | 2017-05-26 10:19:53 -0400 Properly reset m_overlay on resize (LHJW) This was only getting set when the window got too small, never reset when it increased in size, so the overlay color / opacity were permanent for the session (position isn't contingent on this value). -------------------------------------------------------------------------------- 494ec52 | gammafunk | 2017-05-26 06:34:56 -0500 Don't choose non-starting species in random species selection (#11076) Before this commmit, the '*' key to choose a random species could choose e.g. Gnolls in stable. It wouldn't allow actually starting a game with that species, but it shouldn't be selecting non-starting species in the first place. -------------------------------------------------------------------------------- 43b3074 | gammafunk | 2017-05-25 19:34:07 -0500 Fix and balance a float vault There were some errors in gammafunk_corrupted_shrine including using SUBST instead of NSUBST and undefined monster lists. Fix these, and also adjust the vault to not place monsters so close to the center, so that the player can have more freedom of movement, and adjust monster generation levels based on the new lists and to not place so many unseen horrors in Dungeon. -------------------------------------------------------------------------------- 9a7844a | gammafunk | 2017-05-25 01:52:38 -0500 Update the Debian changelog for 0.20 -------------------------------------------------------------------------------- ea9004e | gammafunk | 2017-05-25 01:50:24 -0500 Final 0.20 changelog (cherry picked from commit 8729b15a00de92e01cfa0de3058831651afff87d) -------------------------------------------------------------------------------- 7b23a2f | Kyle Rawlins | 2017-05-24 22:28:05 -0400 Add a changelog entry for best_effort_brighten_foreground With pointers to what options to change. -------------------------------------------------------------------------------- 8cdcbb2 | gammafunk | 2017-05-24 20:55:25 -0500 Tweak the changelog description of Ignition -------------------------------------------------------------------------------- a372141 | Kyle Rawlins | 2017-05-24 11:12:14 -0400 Change default terminal settings for mac build This should use dark gray properly for mac builds by default in my testing. Doesn't address online console players but hopefully works for the release. (Using the new Terminal.app profile will improve the colors, but still work with this default.) -------------------------------------------------------------------------------- aa92ef9 | Pekka Lampila | 2017-05-24 15:48:20 +0200 Regenerate build.h when git version changes. Fixes an issue with version info not being updated when switching between different branches where the only differences are tags and non-code changes. -------------------------------------------------------------------------------- ab6d756 | gammafunk | 2017-05-24 06:15:43 -0500 Fix make install (heftig) Adding settings/mac directory caused the non-recursive copy of settings to fail during the install target, so make this a recursive copy. -------------------------------------------------------------------------------- a051597 | gammafunk | 2017-05-24 06:15:42 -0500 A Zot trap themed transporter vault Shows the player loot and that they'll have to deal with Zot traps if they want to transport in and get it. A line of monsters will move toward the player once far enough in, and these will reach a guantlet of Zot traps very quickly, but there are relatively safe los-blocking corridors for the player nearby. Even inside the corridors, the player has to take care to not let monsters step on an adjacent trap. All traps are pre-identified and there are always walking paths through the vault that won't trigger a single trap. Only places on levels that might normally generate Zot traps. -------------------------------------------------------------------------------- d15e932 | Chris Campbell | 2017-05-24 11:03:30 +0100 Fix a vault typo Closes #542 -------------------------------------------------------------------------------- 210df22 | Kyle Rawlins | 2017-05-23 13:28:52 -0400 Add an official OS X terminal profile for dcss This profile adjusts the colors to be more usable (brighter blue, etc), and the app settings so that things will look ok (no blue map symbols) with either bold_brightens_foreground, allow_extended_colours, or both set to true. If best_effort_brighten_foreground is set, this still gets odd looking blue for dark grey. I'm not quite sure if there's a good way to install this profile automatically, but this commit at least gives us something we can point console players to. (cherry picked from commit aa2fd6273a2a1d66d10efd2aa61b4d6c96b9e3bd) -------------------------------------------------------------------------------- 5d43826 | Doesnty | 2017-05-23 12:21:45 -0400 Don't let Kiku wrath inflict infinite miscasts (#533) Allows either 1 or 2 miscasts, with the average number the same as before. -------------------------------------------------------------------------------- 82ea730 | hawthornbunny | 2017-05-23 12:08:07 -0400 Fix "Wear which item" typo -------------------------------------------------------------------------------- 5396917 | Furbeh | 2017-05-23 11:55:23 -0400 Make cooldowns for DDoor and Berserk accessible through status() -------------------------------------------------------------------------------- 606531c | gammafunk | 2017-05-23 05:33:36 -0500 Balance and overflow altar vault The vault gammafunk_overflow_arena is a vault rewarding high quality loot and can appear quite frequently since it supports between one and five altars. Half its weight and lessen the loot quality somewhat. -------------------------------------------------------------------------------- cd0b456 | gammafunk | 2017-05-23 04:54:01 -0500 Fix an overflow vault crash (Sage1234) The vault gammafunk_temple_of_torment tried to veto when placed in certain depths if Menkaure had already generated, but overflow altar vault placement code can't deal with vetos and the level generation will crash when this veto occurs. This commit makes suitable monster replacements for Menkaure in the vault when he's already generated and removes the veto. -------------------------------------------------------------------------------- 3fd62ac | gammafunk | 2017-05-22 22:05:31 -0500 Tweak advpng compression levels in a png compression script to be consistent with our Makefile, which was changed in 8e3c6a0. -------------------------------------------------------------------------------- ff8e487 | gammafunk | 2017-05-22 22:01:37 -0500 Merge pull request #539 from alexjurkiewicz/advpng Reduce advpng compression webtiles sprite sheets -------------------------------------------------------------------------------- b8b669e | gammafunk | 2017-05-22 20:26:44 -0500 Some tweaks to Cocytus end vaults In coc_mu, the rock border seemed to function as a way to allow characters with dig access to the rest of the level and to the rune itself. With the recent changes to not require flight in these Cocytus end vaults, the border is no longer necessary, so replace it with stone. In coc_old, rework the shallow water path to be at the back of the vault, forcing non-flight users to walk further around, and replace dry land before the doors with shallow water. In coc_dpeg, make there be two shallow water paths to small connecting islands on either side of the starting area, each leading to one pair of islands. Remove the shallow water connections between main islands not in the same pair, so that a player without flight will have to choose a pair to explore, backtracking through the starting vault if they want to visit the other pair (either because they didn't find the rune or because they want the loot). -------------------------------------------------------------------------------- d008f67 | Floodkiller | 2017-05-22 18:15:32 -0500 Remove flight requirements from Hell rune floors Adds solid ground/shallow water pathways in Hell rune floors (mainly Cocytus) in order to avoid requiring the player to obtain a source of flight/translocations to access the rune. Only rune access is kept in mind; the level may be much longer to travel through without flight, and non-rune items may still remain out of reach. Specific breakdown of changed vaults: coc_dpeg- Added a shallow water pathway from the middle to the closest outside island, and added a circular shallow water pathway linking all the outside islands. coc_old- Added a short shallow water pathway across the moat to each entrance to the middle. coc_mu- Created a shallow water path that takes the player to all landmasses on the longer route (flight still required for shorter route). Added a curved shallow water path at the end to Antaeus's island. coc_grunt- Added short shallow water paths in between each island, sink the islands to create more shallow water, shorten the lower wall dividers on each side coc_grunt_cove- Added short shallow water paths connecting the outside islands, with the last island on each side connecting to the center land mass. geh_mu- Added a solid land bridge to access the fortress, and replaced the lava tile in front of the rune with a door. Committer's Note: This commit is a squashed commit of PR 540. Closes #540. -------------------------------------------------------------------------------- cf94df6 | Andrew Minton | 2017-05-22 03:13:43 -0500 Comment fix. Committer's Note: Closes #540. -------------------------------------------------------------------------------- ee15c39 | Andrew Minton | 2017-05-22 02:52:54 -0500 Remove translucent transformations from the_grid_setup Making large vaults out of translucent materials doesn't produce good gameplay, especially with how monster pathfinding works. -------------------------------------------------------------------------------- 3c61f93 | Andrew Minton | 2017-05-22 02:52:53 -0500 Another major the_grid revision Consensus was that the vaults placed too many monsters and too many OOD monsters. So the number of monsters has decreased, most 8s have been replaced with 9s, and most 9s have been replaced with 0s. There are still a few 8s, but they are very rare now. Items in the non-prize subvaults have been reduced as well, so the vaults give much less reward (both experience and items). Also add the float tag to all but the smallest main vaults, to reduce the number of vetos, and fix missing subvaults in the recursive triangle main vaults. -------------------------------------------------------------------------------- 9b971b6 | Andrew Minton | 2017-05-22 02:52:53 -0500 Add no_monster_gen to minmay_the_grid_ultimate -------------------------------------------------------------------------------- 305a42f | Andrew Minton | 2017-05-22 02:52:53 -0500 Remove minmay_the_grid_triangle_9x9_line_8 The vault's size and shape is too awkward to place without vetoing most of the time. -------------------------------------------------------------------------------- 279f716 | Andrew Minton | 2017-05-22 02:52:52 -0500 Fix translucent stone and green crystal in minmay_the_grid_9x9_recursive_3. -------------------------------------------------------------------------------- e494091 | gammafunk | 2017-05-20 00:05:18 -0500 Fix a typo in an equip message (koboldina) -------------------------------------------------------------------------------- af3b9a5 | gammafunk | 2017-05-19 17:42:48 -0500 Move a float vault to its own DES file (Shimatora) The vault gammafunk_the_bubble was failing to place since its subvaults don't have DEPTH tag and were inheriting the default-depth from float.des. Rather than duplicate the parent vault's DEPTH tag in each subvault, move the vault to the_bubble.des. This will allow easier expansion of the vault in the future, as well. -------------------------------------------------------------------------------- 8e3c6a0 | Alex Jurkiewicz | 2017-05-19 11:11:24 +1000 Reduce advpng compression webtiles sprite sheets Here's a quick chart of compression level vs size vs time, using player.png webtiles sprite sheet (three runs per compression level, picking the best run for time): Compression Level Size (kb) Time (s) 1 966 1.7 2 893 3 3 890 21.7 4 885 61 While there's an argument to be made we should use the best possible compression level since all players benefit, going from level 2 to 4 results in 20x slower compression for 1% smaller file, which seems particularly not worth it. -------------------------------------------------------------------------------- 0b12a6d | gammafunk | 2017-05-18 00:14:51 -0500 Updates to the Debian changelog from 0.19 releases -------------------------------------------------------------------------------- f195039 | gammafunk | 2017-05-17 23:30:00 -0500 Two wand-themed transporter vaults A vault with a type-identified wand of flame that asks the player to prepare steamed eel, and a more general wand vault that has the player duel with some baddies that have ranged magic of their own. -------------------------------------------------------------------------------- e03441e | gammafunk | 2017-05-17 23:30:00 -0500 Two overflow transporter vaults A generic overflow for 1-5 altars with an arena-style fight and some loot, as well as an overflow for Kiku+Yred featuring some friends invited over for torment. -------------------------------------------------------------------------------- 2fcdf13 | gammafunk | 2017-05-17 23:30:00 -0500 Some transporter altar vaults for non-temple gods Loot/ambush type vaults for Jiyva, Lucy, and Beogh. -------------------------------------------------------------------------------- 89d5f5d | gammafunk | 2017-05-17 23:29:59 -0500 Two transporter float vaults A sealed library with book and magic-themed loot and a whole classroom of magic users who don't like you interrupting their studies. Also a transparent arena where you have to decide whether you can duke it out with the potential statue + out-of-depth spawns. -------------------------------------------------------------------------------- 05fe413 | gammafunk | 2017-05-17 23:28:27 -0500 Make a minivault a float vault instead This is a fairly substantial vault that doesn't fit the usual minivault profile, so it's better placed as a primary vault. Don't try to place this vault in Vaults, since Vaults layout can't handle it. Also replace one of the superb items with an artifact jewellery, to always make at least one of the generated items universally tempting. -------------------------------------------------------------------------------- 1ee7987 | gammafunk | 2017-05-17 19:24:13 -0500 Remove whitespace from a vault -------------------------------------------------------------------------------- 1289703 | Kyle Rawlins | 2017-05-17 10:50:21 -0400 Fix Makhleb's major destruction (11063) Broken in 4a616ed; I just copied the fix from 00179d9f2c0d into the right place for Makhleb. (Also changed minor destruction just in case it ever becomes relevant.) -------------------------------------------------------------------------------- 0f15420 | Doesnt | 2017-05-16 12:45:43 -0700 Don't let apocalypse crab breath attacks ignore player clarity -------------------------------------------------------------------------------- 174c675 | gammafunk | 2017-05-16 05:55:01 -0500 Changelog through 0.20-a0-1124-g2e29d97 Also a first pass at 0.20 release highlights. -------------------------------------------------------------------------------- 2e29d97 | Neil Moore | 2017-05-14 19:50:20 -0400 Improve abyss_greek_temple wrt WJC. When WJC is not present, disable their altar; when they are, randomize it along with the other altars rather than always placing it in the middle. Also, give the altar the correct floor tile. -------------------------------------------------------------------------------- db355f5 | advil | 2017-05-14 19:46:56 -0400 Add a max for pain bond damage calculation Pain bond damage on the original target is calculated after the recursive call based on hp difference, but in obscure conditions the original target can actually be healed (if a druid dies in the recursion). Don't allow negative damage in the hurt calculations. -------------------------------------------------------------------------------- b7cbeb9 | gammafunk | 2017-05-09 22:29:06 -0500 Disable gnolls in the stable release After some discussion it was felt that there needs to be more work on this species, specifically the way it tries to achieve its aim of pushing the player to learn many skills. Several crawl skills yield high reward for low XP investment, which is a general problem with crawl's skill system, but the Gnoll aptitude system especially pushes the player toward these skills. Crawl already does push players to train a variety of of the most impactful skills, so if Gnolls are to be the species that pushes players to hybridize in a meaningfully different way, it would be better if it didn't try to prevent specialization using aptitude decreases or skill level cutoffs. A secondary problem is that gnolls require more careful checking of skill levels since each skill aptitude independently changes based on the skill's training. One alternative being considered is to lock Gnolls into very low stat levels, but to still give them high aptitudes. This or any other rework will likely not be ready in time for play-testing before feature freeze, so this commit disables Gnolls in stable. When re-enabling Gnolls for stable, simply revert this commit. -------------------------------------------------------------------------------- bb42413 | gammafunk | 2017-05-09 18:52:26 -0500 Disable Wu Jian in stable Making this god trunk-only for the upcoming 0.20 release. There's a general consensus that the god needs more work, and the major idea being explored (merging some powers into Uskayaw) will not be ready in time for the feature freeze. It's also possible that the god will remain as a separate god but with substantial changes to god powers. Trunk players can still play-test Wu Jian, but altars to the god will be unavailable in stable. If re-enabling Wu in stable, simply revert this commit. Note that the two commits preceeding this (d9b63d7e and e512d5f5) should not be reverted as they make actions like this easier in the future. -------------------------------------------------------------------------------- d9b63d7 | gammafunk | 2017-05-09 18:34:46 -0500 Refactor a disabled god check function This is relevant for disabling Wu Jian in stable, but putting this in a seperate commit so it doesn't get reverted if we re-enable that god in stable when it's finished. Make this a switch to allow easier editing/expansion of this function in the future, and use this function for the is_unavailable_god() function. -------------------------------------------------------------------------------- e512d5f | gammafunk | 2017-05-09 18:12:09 -0500 Make more room in an abyss altar vault We keep adding new gods! Expand it and add Wu Jian. -------------------------------------------------------------------------------- 35a2cd3 | advil | 2017-05-09 09:34:44 -0400 Don't let shock serpent self-retaliate when confused (nikheizen) This was recursing from the retaliation, and consequently a shock serpent that bit itself would usually kill itself in a single bite, or come close. -------------------------------------------------------------------------------- 62da73f | Neil Moore | 2017-05-08 17:49:22 -0400 Miscellaneous mon-pick improvements. Relocate some compile-time asserts next to the arrays they concern; name a repeated anonymous type; make a run-time assert into an ASSERT_RANGE; clarify a boolean return value; and replace an if-else with a conditional. -------------------------------------------------------------------------------- aa52201 | advil | 2017-05-06 10:32:23 -0400 Add a comment documenting an assert -------------------------------------------------------------------------------- e0d6ded | Chris Campbell | 2017-05-06 12:29:43 +0100 Revert "Revert "Remove a vile lie about Whirlwind slowing."" It really was removed (in e3bac265ad), and hasn't been added back. This reverts commit 33edf325c0d3db5f1b393bbeebe862a5f7e52d05. -------------------------------------------------------------------------------- 33edf32 | Corin Buchanan-Howland | 2017-05-05 21:05:16 -0400 Revert "Remove a vile lie about Whirlwind slowing." This reverts commit 4e342e6793a809d37be09a5ab871e7988260ae23. Man, I'm on a roll here. -------------------------------------------------------------------------------- 3e41d78 | Corin Buchanan-Howland | 2017-05-05 18:11:39 -0400 Revert "Make altars cycle colors instead of randomly shifting (minmay)" This reverts commit 3634aa33d67a8a98d8faa93d6abfbcb00296fb24. Gonna reconsider this a bit. -------------------------------------------------------------------------------- 3634aa3 | Corin Buchanan-Howland | 2017-05-05 18:01:14 -0400 Make altars cycle colors instead of randomly shifting (minmay) This hopefully lays groundwork for better differentiation of altar colors in console. It also coincidentally stops altar colors from shifting on non- turn-taking screen redraws. Thanks to |amethyst for the template assistance. -------------------------------------------------------------------------------- 4e342e6 | Corin Buchanan-Howland | 2017-05-05 16:39:12 -0400 Remove a vile lie about Whirlwind slowing. -------------------------------------------------------------------------------- 6411727 | Chris Campbell | 2017-05-05 21:19:31 +0100 Adjust minmay_lair_oklob_tunnel (#11052) Remove the hidden lava and greatly reduce the number of plants placed. -------------------------------------------------------------------------------- e3cd172 | Glenn Matthews | 2017-05-04 12:09:28 -0500 Aptitudes table displays -- instead of 0 for unusable skills -------------------------------------------------------------------------------- 6ae5986 | Neil Moore | 2017-05-04 10:31:47 -0400 Unbrace [skip ci] -------------------------------------------------------------------------------- 8dd48ab | Neil Moore | 2017-05-04 10:13:09 -0400 Fix cloud immunity brand in itemspec and debug acq stats. -------------------------------------------------------------------------------- 61cc304 | Neil Moore | 2017-05-04 10:13:09 -0400 Describe monster cloud immunity in xv and ?/m (MarvinPA) -------------------------------------------------------------------------------- 903221b | Neil Moore | 2017-05-04 10:13:08 -0400 Fix up cloud immunity scarf checks. We were ignoring the 'items' parameter for players, and ignoring the scarf entirely for monsters. Furthermore, the check in actor used the wrong method (wearing rather than wearing_ego). -------------------------------------------------------------------------------- 167f86b | Neil Moore | 2017-05-04 10:13:08 -0400 Checkwhite [skip ci] -------------------------------------------------------------------------------- 26be02c | Neil Moore | 2017-05-04 09:08:58 -0400 Simplify [skip ci] -------------------------------------------------------------------------------- 188b92f | Neil Moore | 2017-05-04 09:07:20 -0400 Don't crash when encountering short-named autoexclusions (#17246) -------------------------------------------------------------------------------- 1de9d76 | Isaac Sloat | 2017-05-03 22:30:44 -0500 Remove an unnecessary line break -------------------------------------------------------------------------------- 4c920f5 | Isaac Sloat | 2017-05-03 22:30:44 -0500 Vaccinate the Cloud Mage against clouds (|amethyst) -------------------------------------------------------------------------------- e6c0720 | Isaac Sloat | 2017-05-03 22:30:44 -0500 Clear cloud autoexclusions when cloud-immune Part of this fix involved actually flagging cloud autoexclusions as autoexclusions, which they weren't in the first place. This led to the need to ensure that cloud autoexclusions aren't wiped (the previous implementation checked to see if any monster was actually there, and if not, would clear the exclusion) except when the player has cloud immunity. -------------------------------------------------------------------------------- c5d136c | Isaac Sloat | 2017-05-03 22:30:43 -0500 Don't exclude damaging clouds if immune (mooon) This is something of an indirect fix -- player_view_update_at in view.cc checks this function to determine whether or not these clouds should be excluded. -------------------------------------------------------------------------------- 80909b1 | Isaac Sloat | 2017-05-03 22:30:43 -0500 Add the cloud immunity egos to scarves' repertoire Fear these freezing clouds no longer! -------------------------------------------------------------------------------- e5c4a32 | Isaac Sloat | 2017-05-03 21:50:43 -0500 Add a function for checking cloud immunity Rather than directly checking every time. -------------------------------------------------------------------------------- ff6d183 | Isaac Sloat | 2017-05-03 21:50:10 -0500 Remove cold resistance from scarves It wasn't an interesting enough ego for an exclusive equipment slot giving up AC from cloaks or other scarf egos. -------------------------------------------------------------------------------- 651d724 | Isaac Sloat | 2017-05-03 19:11:15 -0500 Knit more scarves Up from 16%~ of all cloak-slot items, to 25%. Cloaks move down from 83%~ to 75%. -------------------------------------------------------------------------------- 7ae0f1a | Floodkiller | 2017-05-03 19:04:16 -0500 Prevent Gnolls from sacrificing skill Prevents Gnolls from sacrificing skill under Ru. If species_apt_factor is checked for Gnolls, sacrificing skill would result in an incorrect displayed aptitude due to the custom xp table: a -1 apt factor applied to a skill level on a Gnoll that is currently at an effective +4 is not the same as the same skill level at +3 on any other species. If species_apt_factor is not checked, the sacrifice does nothing but grant free piety. -------------------------------------------------------------------------------- 95dc2c4 | Floodkiller | 2017-05-03 19:04:16 -0500 Adjust Gnoll exp table Adjusts the Gnoll skill experience table by shifting the scaling from starting at +4/decreasing by 2 every level after SL 7 to a floor of -6, to starting at +5/decreasing by 2 every level after SL 6 to a floor of -9. The main intention of this change is to drop the floor out to a much lower level, which is intended to more heavily discourage hard focusing a skill to high levels over diversifying/spreading out. The starting aptitude was raised to +5 so that the floor could be -9 instead of +4 to -10, which would cause display issues on the skill screen once the floor was reached (the negative sign would be cut off for space, leaving only color to indicate that it was a negative number). This should be nicer than the current system until about SL 8, slightly rougher until about SL 12, then start costing dramatically more per level afterwards. If this proves to be too rough on early levels, it would be recommended to move the decay starting point to SL 7 (this would have been a buff over the current system all the way until SL 13, which seemed like it might be too much in addition to adding Fearsome Bark and normalizing stat growth). -------------------------------------------------------------------------------- ac3690e | Floodkiller | 2017-05-03 19:04:16 -0500 Replace more instances of Bultungin Bultungin was still used instead of Gnoll in the comments in skillmenu.cc -------------------------------------------------------------------------------- 7d51e6b | Floodkiller | 2017-05-03 19:04:15 -0500 Clean up skill_exp_needed Cleans up skill_exp_needed by moving the two XP tables into the check for the Gnoll species, reducing arrays in memory from 2 to 1. Also, avoids calling species_apt_factor for Gnolls, since it will only ever return 1 due to the way the custom xp table/Gnoll aptitudes are designed. -------------------------------------------------------------------------------- 3fde505 | Diego Essaya | 2017-05-01 21:14:32 -0400 SDL Tiles: Don't disable screen saver -------------------------------------------------------------------------------- d50b1d5 | advil | 2017-05-01 08:38:57 -0400 Preserve messaging that happened during load Previously, `load_messages` would overwrite the entire contents of the circular message buffer at that point in the load process, obscuring any messages that happened earlier in the load process (for example, the mutation fixup error message). If there weren't too many, messages from the load process would still be visible in the message pane, just not preserved; but on debug builds it was typical that a bunch would be lost. Also, the last message in the process was sometimes not yet flushed, and so could be appended succesfully at the time it was flushed, so on non-debug builds that tried to show an error, whether this error got logged was basically a function of its length (and other factors). This commit flushes and saves any messages from during the load process before message loading and appends them to the circular buffer at the end of `load_messages`. -------------------------------------------------------------------------------- 4d0c687 | advil | 2017-05-01 08:38:57 -0400 Don't crash webtiles if a more is triggered too early If enough messages happen before the player chunk is fully loaded, it would trigger a more, which would try to send a whole bunch of information in json form that wasn't there yet, leading to a crash. Probably mostly relevant for debug builds. -------------------------------------------------------------------------------- 4bd2f5b | Chris Campbell | 2017-04-30 19:42:51 +0100 Fill in gaps in chequers_guarded_unrand_mask_of_the_dragon (#11043) -------------------------------------------------------------------------------- 627af9b | Nicholas Feinberg | 2017-04-30 10:09:06 -0700 Add erandtke to the CREDITS Probably should've combined him and Dunk... -------------------------------------------------------------------------------- c284483 | Edward Randtke | 2017-04-30 10:06:42 -0700 Fix movement prompt for swimmers (11000) -------------------------------------------------------------------------------- 7d2332c | Nicholas Feinberg | 2017-04-30 10:05:38 -0700 Add Russell Dunk to the CREDITS -------------------------------------------------------------------------------- 47261af | Russell Dunk | 2017-04-30 10:00:58 -0700 Stomp: warn before damaging allies (11003) [Committer's note: minor code cleanup.] Closes #525. -------------------------------------------------------------------------------- 89cde08 | Nicholas Feinberg | 2017-04-30 09:42:58 -0700 Fix god wrath descriptions (11008) Distinguish between 0 and < 1/4 penance, and bring back some older wording for clarity. -------------------------------------------------------------------------------- 492c16e | Neil Moore | 2017-04-30 12:26:10 -0400 Fix spelling (#11045). [skip ci] -------------------------------------------------------------------------------- b2cf7a4 | Neil Moore | 2017-04-30 08:07:41 -0400 Avoid a two-argument fprintf (miserium) It was breaking builds with -Werror=format-security, and in particular the Android build. -------------------------------------------------------------------------------- 4874019 | Chris Campbell | 2017-04-29 19:02:09 +0100 Bring back some Xom speech as rare welcome text Since it was tragically lost with the removal of the prayer command. -------------------------------------------------------------------------------- cc5f1c2 | Chris Campbell | 2017-04-29 19:02:09 +0100 Shorten Hepliaklqana's welcome line -------------------------------------------------------------------------------- 70c76d2 | advil | 2017-04-29 10:17:13 -0400 Use selectors instead of parent-scoped variables in closures This was causing lingering weirdness on input box+layout related to 10318, 10938, since layout reconstructs the input box, and the parent-scoped variables were stuck with a jquery object that no longer was present in the DOM. Also, focus an input box on layout if there is one. game.js:layout() really needs some less bugfix-y attention. As far as I can tell the messages pane and the stats pane never change size on relayout, so what is this even doing except maybe for an initial layout? -------------------------------------------------------------------------------- c475d56 | advil | 2017-04-29 09:37:53 -0400 Prevent a bad fallthrough (|amethyst) This could (we think) cause a crash when setting `lines(loc[idx])` if loc is empty. -------------------------------------------------------------------------------- 6a0a8e1 | advil | 2017-04-28 20:56:28 -0400 Save compat for spit poison The save compat code added with TAG_MINOR_SPIT_POISON_AGAIN didn't adjust you.innate_mutation, only you.mutation. This could lead to saves that were corrupted in several ways, not all of which are perfectly fixable, but the main case that actually crashed was that the innate level for spit poison could be higher than the total level. This crashes in current versions (a mutation validation check fails), and earlier it would be fixed up on load, but incorrectly (giving the player innate exhale poison). There is no way to differentiate between saves pre-TAG_MINOR_SPIT_POISON_AGAIN where the player actually had exhale poison, which didn't update right, and saves that got incorrectly fixed up, so some saves that went through a buggy update sequence will keep their exhale poison. -------------------------------------------------------------------------------- 49e0d3e | Chris Campbell | 2017-04-28 19:10:21 +0100 Mention Okawaru ammo gifts in the god description -------------------------------------------------------------------------------- 99f7aaf | Chris Campbell | 2017-04-28 19:09:54 +0100 Merge pull request #528 from alexjurkiewicz/oka-ammo-gift-notification Mention Oka ammo gifting when you reach 3* -------------------------------------------------------------------------------- 0c522bc | Kyle Rawlins | 2017-04-28 09:36:55 -0400 Even more changelog editing [skip ci] -------------------------------------------------------------------------------- 6bcfb42 | gammafunk | 2017-04-28 07:52:56 -0500 Update map knowledge when transporting monsters Monsters would appear in the map knowledge for their former location after being transported along with the player. -------------------------------------------------------------------------------- dee899c | Kyle Rawlins | 2017-04-28 08:48:55 -0400 Add GSC change to changelog [skip ci] -------------------------------------------------------------------------------- 76119e3 | Kyle Rawlins | 2017-04-28 08:42:33 -0400 Some light changelog editing [skip ci] -------------------------------------------------------------------------------- a910694 | gammafunk | 2017-04-28 01:42:34 -0500 Add a -dump-disconnect CLI to control mapstat disconnected maps dumps Previously any disconnected map would cause mapstat to dump the map to map.log and exit, but this is undesirable when the primary interest of running the tool is for map statistics. Now this behaviour only happens when this CLI is used. -------------------------------------------------------------------------------- 8446734 | Neil Moore | 2017-04-27 22:35:22 -0400 Checkwhite Also fix several cases of double-spacing where the next sentence begins with a digit, lowercase letter, or punctuation; those aren't caught by checkwhite. [skip CI] -------------------------------------------------------------------------------- 127e8e2 | advil | 2017-04-27 18:25:59 -0400 Don't delete event handlers in messages on layout/resize When `layout` was called, it rebuilt the messages area from scratch using its html. This resets any event handlers on nodes embedded in these, so a layout would strip out event handlers from the input box, including the ones that return the game to its normal state once you're done with the box. The result was that you had to reload the browser to get something playable. This was triggered by any resize, which in several browsers (and possibly sensitive to other settings, such as zoom) can result from a browser find command (10318), especially since crawl doesn't swallow ctrl-f when the search box was open. A re-layout is also apparently triggered when a spectator joins (10938). This fix, instead of rebuilding the messages panel from html, makes a deep copy of it using jquery `clone`, in a way that preserves event handlers. Layout still copies other areas using html, so if anyone ever adds any event handlers in the stats area, this could come up again. Supposedly, the html way is faster, so I left this as-is. (I'm not entirely sure why this would be the best way to do what `layout` is doing in the first place, but I'll leave that for more skilled javascript people.) -------------------------------------------------------------------------------- b8e8b7e | Neil Moore | 2017-04-27 09:47:04 -0400 Provide a const version of actor::ensure_valid_actor. -------------------------------------------------------------------------------- 7d7e1fa | Alex Jurkiewicz | 2017-04-27 23:45:00 +1000 Mention Oka ammo gifting when you reach 3* It's a bit of a pointless message for players that Oka doesn't think need ammunition (since they will never recieve ammunition gifts), but prevents the case where ammunition-needing players receive gifts before the 5* message about receiving gifts. -------------------------------------------------------------------------------- 7b787ac | advil | 2017-04-26 19:32:33 -0400 Calculate the number of WJC movement attacks correctly (ZChris13) The previous version of _wu_jian_number_of_attacks attempted to work around a weirdness of player::attack_delay (that it depends on you.time_taken, which is different on movement turns than attack turns) by basically reversing some of the math buried in there. Based on some empirical testing, I don't think this was working right (although it's fairly complicated). It was overemphasizing delays in some cases and underemphasizing them in others, resulting in particular in cases of 0 attacks when your move speed is higher than your attack speed, which should never happen. (For example, attack speed of 1.3 and move speed of 1.5 from slowing is a good combination for replicating spurious 0 attacks prior to this commit.) This commit works around the weirdness in a possibly easier-to-understand way by using an unwind_var and calculating the value directly. I've tested this a fair amount, and it seems to be doing what would be expected. This change affects all three main movement attack types. Ideally, attack_delay shouldn't have this sort of dependency, but it's called enough in diverse ways that changing it there is risky. -------------------------------------------------------------------------------- bbf974c | advil | 2017-04-26 17:19:49 -0400 Handle damage with genuinely no agent when injury mirror is up E.g. vault-created clouds. -------------------------------------------------------------------------------- 3bd9c97 | Chris Campbell | 2017-04-26 19:38:16 +0100 Update some cooldown status descriptions Exhaustion could potentially be split up again into durations for Ru and WJC (so they can have separate descriptions). -------------------------------------------------------------------------------- b0a1de4 | Chris Campbell | 2017-04-26 10:55:26 +0100 Fix Exhaustion not expiring (#11038) -------------------------------------------------------------------------------- 0491fde | advil | 2017-04-25 20:29:16 -0400 Retroactively add webtiles mouse to the changelog This has been around for a while but hasn't made it to release (or changelog) yet. [skip ci] -------------------------------------------------------------------------------- 9a88637 | advil | 2017-04-25 20:26:13 -0400 Convert YOU_FAULTLESS back to you for injury mirror This prevents a crash when a monster is killed by a reflected ranged attack off the player; the fineff for injury mirror needs someone valid to be at fault. It might be more intuitive if the originating monster gets the mirrored damage, but monster::hurt doesn't have access to this in any particularly easy fashion. I implemented this using an idea from |amethyst in efdfc71969b016ec0438; there's now a static function actor::ensure_valid_actor that normalizes the YOU_FAULTLESS case (and if necessary could try to normalize anything else like this). -------------------------------------------------------------------------------- 7622305 | Chris Campbell | 2017-04-25 21:44:30 +0100 Give Recite an independent cooldown Remove another case of overlapping cooldowns on unrelated abilities, this time between Recite and breath weapons. -------------------------------------------------------------------------------- 19bae6a | Chris Campbell | 2017-04-25 21:42:47 +0100 Give Berserk an independent cooldown As with DDoor, rather than make Exhaustion overlap on various unrelated spells and abilities. Exhaustion remains only as a Ru-specific status as a result, shared between the abilities. -------------------------------------------------------------------------------- d950c8b | Chris Campbell | 2017-04-25 21:40:46 +0100 Make Borgnjor + DDoor only cause normal paralysis Instead of causing extra-long duration paralysis and confusion, just apply normal duration (2-7 turn) paralysis. -------------------------------------------------------------------------------- 0c1af0a | Chris Campbell | 2017-04-25 21:39:49 +0100 Give DDoor an independent cooldown Instead of sharing one with Berserk and Ru abilities, use a separate cooldown as with various other spells (such as Dragon's Call and Tornado). -------------------------------------------------------------------------------- 14f416c | advil | 2017-04-25 12:45:09 -0400 Make monster::name return something more informative for YOU_FAULTLESS Before, it printed this just as a program bug. Also, add an assert that catches the (as-yet-unfixed) reflection+injury mirror crash at a more useful place in monster::hurt; if the agent is invalid there, the fineff will crash later. -------------------------------------------------------------------------------- c5baec5 | gammafunk | 2017-04-25 03:25:34 -0500 Fix WebTiles minimap colors (Raine357) The order of the minimap colors in minimap.js must match the order of the map_feature enume. Fix and document this, and also correct the minimap color value for transporters. -------------------------------------------------------------------------------- 57248f3 | Chris Campbell | 2017-04-24 22:51:54 +0100 Update Monk manual entry Since it apparently still predated them getting their weapon choice in the first place. -------------------------------------------------------------------------------- 537b456 | Chris Campbell | 2017-04-24 22:24:08 +0100 Revert "Remove Monks' starting weapon choice" The change in practice made Monks substantially worse without really making them more interesting, since having no starting weapon skill on a background intended to use melee early made them especially weak on D:1. The bonus piety but worse equipment in comparison to Gladiator is still a reasonable amount of differentiation (considering that Fi/Gl are also relatively similar, for example). This reverts commits b48d95fd49c, af809b6da4c and cd8f41eed80. -------------------------------------------------------------------------------- d0c4d64 | gammafunk | 2017-04-24 03:52:03 -0500 Some transporter vaults The first is a subvaulted minivault with 5 variations that can place in most 3-rune branches, as it uses a 0 and 9 monster set. This vault shows the player the vault loot but doesn't reveal what monsters lie inside. The exit transporter is close to the one of the loot chambers, with the exception of one variant that has a roulette of transporters and mostly open terrain. The player who chooses to enter the vault may have to use teleport to escape if they get overwhelmed and have a hard time reaching the exit transporter. For abyss there's an exit vault and a zot-themed rune vault. The exit that shows the player what they'll have to fight through to get to the exit. The rune vault is a kind of "reverse zot run" through a miniaturized zot:5 vault, starting in the orb chamber. One lung leads to the rune, the other to the exit transporter. -------------------------------------------------------------------------------- e02263c | gammafunk | 2017-04-24 03:50:44 -0500 Rework vaults previously using lua teleporters to use transporters For most of these vaults, replacing the lua teleporter is straightforward. For nemelex_the_gamble, which had its two-way teleporter on a timer, I opt to only place the exit transporter after the player has entered the randomly chosen chamber, and don't place an exit transporter at all in the unselected chamber. This prevents any travel cache info about unexplored transporters remaining. -------------------------------------------------------------------------------- 08d5691 | gammafunk | 2017-04-24 03:18:19 -0500 Implement transporters Transporters are a new feature for inter-level player travel. They work like stairs that take the player to another destination on the same level, allowing adjacent followers and hostiles to travel along. This feature replaces the old poorly supported teleporter feature. The name is changed to "transporter" to prevent confusion that -Tele would affect the use of this feature, which it doesn't. Note that teleporters were not teleporter traps, but rather features that had been used in some vaults such as the Golubria wizlab. The old teleporter feature didn't cooperate with travel, travel cache, or auto-exploration, and had other issues remedied by this new feature. Transporters work the following way: * You choose to enter the transporter by hitting > or < instead of always entering when moving on the transporter square. * Cooperates with autoexplore and the travel cache. Unvisited transporters are marked as unknown like how stairs are, and get a message when autoexplore finishes. Unvisited transporters also make a count annotation on the level, which is lowered as each transporter is explored, just like runed doors. * Allows adjacent followers next to each other in a radius from your position to pass through the transporter with you, provided they can find a safe spot nearby on the other side. Allies follow according to the same distance rules as for stairs. Directly adjacent hostiles will also follow you through, likewise dependent on them finding a habitable spot * Taking a transporter won't be blocked by a monster being on destination, as it will move the monster to a habitable spot nearby. Only if it fails to find one will it block the transport. * Refuses to move the player to a non-habitable destination. Maps should not place transporters that lead to such places, but should this happen due to such placement or due to terrain changes, taking the transporter won't kill the player due to habitability. Placement onto traps or clouds are still possible, but maps should avoid doing this. * Use '>' on map screen to go to allow travel to any reachable transporters. Things that might need addressing: * Doesn't allow travel through a transporter. Could do this with a warning prompt, similar to how travel within a level works when traveling to the destination requires leaving the level. * Monsters/allies don't use transporters on their own. This should probably remain the case, since transporters into vaults will often need transporters out of the vault. Monsters using transporters freely would mean that such vaults won't contain monsters when they wake up. Technical notes: * DES/Lua support For placing transporters, maps should place lua markers at the transporter location and transporter destination using functions transp_dest(name) and transp_dest_loc(name), respectively, where `name' is a string shared by the two markers. When the level is fully generated, the corresponding transporters will be placed at the locations of the markers. This way transporters can be place both within and across vaults without special setup. * Position markers Position markers now have a `feat` field indicating which feature they are for. This is because one position might have a position marker for both hatches from a levels above/below and for a transporter actually at that position due to the way hatches set their markers. Hatches set their position marker on the destination level, but using a position that is the coordinates where the hatch resides on the *source* level. Before this commit, if a down hatch and up hatch occupied the same position and lead to the same level, they would both have to share their chosen destination. Multiple position markers were actually being created for each hatch, but the marker retrieval mechanism had no way to disambiguate and returned the first position marker it found at that position. With this commit, transporters, up hatches, and down hatches can each retrieve the correct position marker. * Save compat Save compat exists for loading travel cache without transporter data and for loading position markers that don't have a feature value. Position markers unmarshalled without a feature value get a value of DNGN_UNSEEN. These will correspond to an up hatch or down hatch, since those were previously the only features that used position markers. The compat code will see when any hatch attempts to read its position marker and fails. If a position marker does actually exist at that location but has a feature value of DNGN_UNSEEN, that marker will be returned and used after the marker's feature value is updated to that of the hatch. -------------------------------------------------------------------------------- ab23864 | gammafunk | 2017-04-24 03:14:32 -0500 Clean up secret moon lore -------------------------------------------------------------------------------- 97bcf2f | gammafunk | 2017-04-24 03:14:22 -0500 Make some functions static and document -------------------------------------------------------------------------------- bd57889 | Neil Moore | 2017-04-23 11:07:01 -0400 Fix grammar in a vault comment. [skip ci] -------------------------------------------------------------------------------- 33e7df7 | advil | 2017-04-23 10:00:01 -0400 Don't keep x,y coords in travel prompt when target isn't the entrance At the travel prompt, selecting ^ and then using > to select a level would try to travel to specific coordinates on that level (based on the branch entrance location). That's already odd, but the presence of explicit coordinates (instead of -1,-1) would also cause a level excursion during autotravel at the level above the target, and if the player hadn't seen that level before, the level excursion would crash. This change just drops the coordinates when changing the default away from the branch entrance in the prompt. I've also slightly refactored a few functions to use return values with const arguments, rather than modifying the arguments, and added some docstrings. Autotravel to explicit coordinates on an unseen level will still crash, but I think that this is the right behavior -- there should just be no way to trigger that from the UI (and this commit removes a way). -------------------------------------------------------------------------------- 0db9e8b | Chris Campbell | 2017-04-23 13:52:26 +0100 Fix a Slime vault being able to place stairs next to acid walls (#11031) -------------------------------------------------------------------------------- fd09691 | Chris Campbell | 2017-04-22 21:15:47 +0100 Simplify Damnation crossbow's damage Previously it dealt standard impact damage, followed by extra damnation-branded impact damage (which was buggy and could affect damnation-resistant creatures), followed by the explosion. Now just deal the standard impact damage and the explosion (and slightly increase the explosion's damage), slightly reducing the spamminess of its damage messaging as a result. -------------------------------------------------------------------------------- f554463 | advil | 2017-04-21 18:15:33 -0400 Prevent doors from being permanently unsealable If a door was sealed, and then opened by an enemy, it would become permanently unsealable. This commit (a) times out terrain change markers properly if the door ever becomes unsealed before the timeout (they weren't cleaned up at all in this case), and (b) properly handles the case where a door is sealed and there is already an existing terrain change marker on that door. Before, such a case, the terrain change marker got modified but the terrain itself wouldn't get updated, meaning that door was permanently unsealable following the situation in (a). -------------------------------------------------------------------------------- 16fac3a | advil | 2017-04-21 18:15:33 -0400 Refactor get_push_space to fix some zin bugs This commit (a) lets the excluded argument work for items, (b) lets items be pushed from deep water to deep water, and (c) lets monsters be pushed to deep water/lava if those spaces are habitable for them. It also fixes a bug in imprison where the final actual movement of items wouldn't use the exclusion spots, which could lead to items being pushed around in multiple steps as the wall is built. -------------------------------------------------------------------------------- 52b1666 | advil | 2017-04-21 18:15:33 -0400 checkwhite Hopefully this doesn't break anything, no idea really, but I got tired of unstaging this every time I run checkwhite. -------------------------------------------------------------------------------- 4d371cd | Nicholas Feinberg | 2017-04-21 08:54:13 -0700 No infinite Fedhas piety from worms (11026) Or other skeleton-less corpses. Though for worms at least, it is kind of thematically appropriate... -------------------------------------------------------------------------------- fcccd65 | gammafunk | 2017-04-21 02:46:01 -0500 Descriptions and tiles for one-way stairs in Tomb (CanOfWorms) Rename the special fixed-destination escape hatches in Tomb and give them unique descriptions and tiles. This helps prevent any confusion as to whether it's intended for the player to use these stairs for normal level progression. -------------------------------------------------------------------------------- b277f92 | advil | 2017-04-20 19:13:11 -0400 Standardize tentacle cleanup This eliminates crashing on interactions with bend space, as far as I can tell. I'm not 100% on the eldritch tentacle part of this, but I also can't figure out any current way to relocate an eldritch tentacle that is practical for testing. -------------------------------------------------------------------------------- 05abe66 | Chris Campbell | 2017-04-20 17:41:51 +0100 Merge pull request #516 from jimperio/master Fix Dvorak keyboard binding -------------------------------------------------------------------------------- b3a76b0 | Chris Campbell | 2017-04-20 17:39:36 +0100 Merge pull request #523 from yrmvgh/patch-17 continue renaming Bultungin to Gnoll -------------------------------------------------------------------------------- 4e41807 | Chris Campbell | 2017-04-20 17:39:12 +0100 Pluralise some gnolls -------------------------------------------------------------------------------- 30bc7f3 | Yer mivvaggah | 2017-04-20 12:34:26 -0400 correct "mock" vault to mock gnoll, not bultungin -------------------------------------------------------------------------------- 3775f13 | Yer mivvaggah | 2017-04-20 12:32:24 -0400 correct comments that mention Bultungin -------------------------------------------------------------------------------- 5ae3f2a | advil | 2017-04-20 11:12:35 -0400 Add a validity check to _apply_to_monsters (|amethyst) This may or may not eliminate some tentacle-related crashes in interaction with bend space, but it's a good idea anyways. -------------------------------------------------------------------------------- c3ddcbd | gammafunk | 2017-04-19 15:56:47 -0500 Move a vault deeper and fix a typo in a vault name Ijyb was moved to start placement on D:3, so adjust goblin_castle to being placing there as well. This vault is fairly tough already and was not meant to place OOD monsters. The typo in Ijyb's placement vault originates from when unique placement was moved from C++ to DES, rip. -------------------------------------------------------------------------------- 4706f7e | advil | 2017-04-18 23:01:57 -0400 Scale cell widths/heights by devicePixelRatio (wheals) Many browsers, though not all, change devicePixelRatio when the user zooms in or out. Since we scale the canvas by this (e.g. in order to handle high DPI devices properly[1]), zooming was messing up calculations of mouse position for purposes of selecting cells. This commit scales cell dimensions appropriately. I've tested this on firefox, chrome, & safari on OS X. It fixes problems with mouse cursor position and zooming on firefox/chrome, and doesn't break safari (which already worked). It needs testing on other platforms, in IE, and on high DPI devices (such as retina displays). [1] refs for scaling reasons: 75d9865c86980b7, 0475afac5cde -------------------------------------------------------------------------------- e4c44be | advil | 2017-04-18 20:40:24 -0400 Check exclusions for wall jump at landing spot, not at the wall This also gets Y/N checks for walljumping into traps, clouds, etc. Should fix 10948, 10987. -------------------------------------------------------------------------------- c4d110f | advil | 2017-04-18 09:56:07 -0400 Remove linearity breakpoint for raw fail rate This is a buff of sorts, but one that doesn't matter for any practical purposes in my testing, and it (arguably) makes what's going on simpler to understand. This change makes e.g. L9s move from 100 faster, but the regular curve still takes over when they get closer to usability so the net impact is minimal. The greatest effect might be for characters with miscast protection, but even there it just enables casting with bad fail rate a few training levels earlier at most. This commit also very slightly tweaks the polynomial to increase fail rates, bringing fail rates to something like 0-3% lower (depending on the details) from what they were with `chance_breaks` (preivously it was more like 0-4). Since the aim wasn't really to buff casting, this could be tweaked further, but the dynamics are somewhat complicated. Also, fix line widths (|amethyst) -------------------------------------------------------------------------------- 99c12e3 | advil | 2017-04-18 09:56:07 -0400 Replace spell success breakpoints with a polynomial Lots of historical consensus that something like this is a good idea -- replacing these pre-dcss breakpoints has been under discussion since at least 2014. This change was originally inspired by minmay's discussion at: https://crawl.develz.org/tavern/viewtopic.php?f=8&t=23414 The argument that swayed me to implement this: "One great effect of getting rid of chance_breaks is that spells transition from 100% to 99% to 98% etc. etc. earlier, instead of staying at 100% for ages and then quickly falling. A 99% fail spell is still useless but it makes it much easier for unspoiled players to tell how close they are to getting it castable, compared to seeing both level 5 and level 9 spells as 100% fail." This uses |amethyst's version of the polynomial, simplified using Horner's rule, taken from comments on the PR that this change was developed under. Following the original calculation using breakpoints, this change is linear after 43 (which is the fixed point for this particular polynomial). Dropping the linearity breakpoint would pull down spell failure rates noticeably in the higher ranges with this polynomial, and may be worth considering -- based on my testing I don't think it'll drastically affect casting for the meaningful part of the fail range, and it is simpler (removes another breakpoint). This change also adds a scale parameter to `stepdown_spellpower` and to `calc_spell_power`, and uses the scale parameter to get higher resolution in `raw_spell_fail`. This results in much more continuous behavior of spell fail rates when training, though it is still not high enough resolution to be perfectly continuous, especially at high skill levels. The behavior of the two changed functions with default arguments remains the same. -------------------------------------------------------------------------------- cba205c | gammafunk | 2017-04-18 03:03:15 -0500 Changelog through 0.20-a0-1020-g7b9e4fe [skip ci] -------------------------------------------------------------------------------- 7b9e4fe | Chris Campbell | 2017-04-17 19:46:10 +0100 List the default for simple_targeting in the options guide (crate) -------------------------------------------------------------------------------- a70dcae | Floodkiller | 2017-04-17 11:59:54 -0700 Update Haste spell description. Removes the reference to contaminating the player from the Haste spell description (it should be impossible for a monster to cast Haste on the player anyway, but this should reduce confusion just in case). -------------------------------------------------------------------------------- e435b50 | Nicholas Feinberg | 2017-04-15 22:19:20 -0700 Make a funny name slightly less so (11016) oops -------------------------------------------------------------------------------- 9cf9c68 | Jomel Imperio | 2017-04-16 10:22:35 +0800 Fix Dvorak keyboard binding Also remove references to `CMD_MAP_FIND_F` and `CMD_TOGGLE_FRIENDLY_PICKUP` from `keybind.txt`. -------------------------------------------------------------------------------- c3250ce | Chris Campbell | 2017-04-15 22:21:26 +0100 Fix holy wrath weapons being cursable when temp-branded (Doesnty) -------------------------------------------------------------------------------- 241539b | gammafunk | 2017-04-15 02:01:37 -0500 Fix doll tiles for the Zephyr bow unrand (geekosaur) -------------------------------------------------------------------------------- 2ec8a95 | Isaac Sloat | 2017-04-14 19:54:59 -0500 Remove SInv from Gn Not only was it discrepant with monster gnolls, it's also not really at all an interesting species perk while also being already used on several other species. -------------------------------------------------------------------------------- 171fa7a | Isaac Sloat | 2017-04-14 19:22:45 -0500 Rename Bultungin to Gnoll As a name 'Bultungin' was too overambitious, and also the species didn't really fit the reference (shapeshifting vampiric hyena). Gnolls already exist in Crawl and are suitably similar in concept, so the species takes their name. They'll take Gnomes' old 'Gn' abbreviation. Gnome abbreviation will be changed to 'Gm' for Sequell and scoring tracking. -------------------------------------------------------------------------------- 928b3ad | Alan Malloy | 2017-04-14 16:38:08 -0700 Convert functions in mon-abil from pointers to refs -------------------------------------------------------------------------------- add7f62 | gammafunk | 2017-04-14 17:12:33 -0500 Save compatability for the change of stone stairs into hatches in Tomb Only needed in a game that has generated a Tomb level already with stone stairs but has at least one ungenerated Tomb level. Since the already generated level will have stone stairs and no necessary hatch name markers, we generate the remaining vaults with stone stairs using 4 specially tagged vaults in tomb.des. If such a game is loaded, a property is set in you.props that will have the builder load the necessary vault so that stone stairs are generated throughout. This level is only ever one specific layout, but should otherwise be a normal level. Old games that haven't generated any Tomb levels will get hatches normally, and old games that have already generated all Tomb levels are unaffected. These vaults will have to be maintained to a reasonable degree before TAG_MAJOR is incremented, which is one disadvantage to this approach. However cleaning up the level to make the hatches upon entry would (probably) be more difficulty and prone to breakage. Tested with saves from trunk with and without a generated Tomb:1, and the compat code appears to work fine. -------------------------------------------------------------------------------- a69911a | gammafunk | 2017-04-14 17:12:26 -0500 Turn stairs in Tomb into fixed-destination escape hatches (Twitch chat) Stair dancing is a convenient technique that's good enough to clear many parts of Tomb levels. Repeated use of stairs is one of the major reasons why players find the branch repetitive and uninteresting. This commit addresses that problem by replacing the usual stone stairs with escape hatches that have fixed destinations. Now when entering the Tomb:2 central ambush, the Tomb:1 outer hall, and Tomb:3, the player must take an escape hatch and has no immediate return stair where they land. Instead they can escape back to the previous level through corresponding escape hatch placed somewhere close by, within 12 spaces or so. Tomb:3 has a more substantive layout change to allow the hatches to work well gameplay-wise. Now there are doors into each of the two loot chambers near the entry area, with escape hatches located in the chambers themselves. Without the door addition, the escape hatches would have needed to be very close to the entry locations to give a good way to proceed for players who can't use translocations or certain god abilities. The terrain of the loot chambers is also slightly altered so that inside chamber tiles near the new door always expose some LOS outside the chamber door. This change also strengthens the theme of Tomb featuring dangerous ambushes and confusing layouts. It's a difficulty increase to Tomb as a whole, since the player can't immediately return to a cleared area to rest, but good tactics work very well for clearing the branch, based on my play-testing. -------------------------------------------------------------------------------- c97906f | gammafunk | 2017-04-14 17:08:36 -0500 Implement escape hatches with fixed destinations Allow setting escape hatch names and hatch destination names via lua markers in vaults. Hatch names are set via a lua marker through the function hatch_name(name), and the destination level sets the destination marker with hatch_destination_name(name) using the same string in `name'. After these are set, the escape hatch will choose this destination instead of a random one. -------------------------------------------------------------------------------- c986637 | advil | 2017-04-13 23:55:27 -0400 Clean up some unnecessary default arguments (Floodkiller) These are probably holdovers from an earlier time. -------------------------------------------------------------------------------- 0de3dc5 | Corin Buchanan-Howland | 2017-04-13 22:09:37 -0400 Rename Krishna to Zephyr With lore and stuff. Gonna be great. -------------------------------------------------------------------------------- 47b2f4d | Corin Buchanan-Howland | 2017-04-13 21:36:53 -0400 Re-rename ring of Avoidance to ring of Phasing Feels more distinctive, and also might be a fun reference for Phase Shift fans. I wouldn't be against a more lore-heavy name for the ring. -------------------------------------------------------------------------------- e6c5631 | gammafunk | 2017-04-12 16:15:19 -0500 Revert "bow of Krishna "Sharnga" -> longbow "The First Bow"" I'm reverting this commit for now, so we can think up some better theme for this unrand. The general change will probably happen unless we decide that Krishna is ok, but probably the bow will get some different lore. This reverts commit 76effe11021bde25e867927bb10e2547c6481409. -------------------------------------------------------------------------------- 0f2fb03 | Isaac Sloat | 2017-04-12 16:07:48 -0500 Update Agnes's description (MarvinPA) [skip ci] -------------------------------------------------------------------------------- 76effe1 | Alex Jurkiewicz | 2017-04-12 16:03:55 -0500 bow of Krishna "Sharnga" -> longbow "The First Bow" It's not great to rely so explicitly on real-world religion for in-game theme, when DCSS doesn't take place in our universe. -------------------------------------------------------------------------------- c3e0a5c | Alex Jurkiewicz | 2017-04-12 16:03:55 -0500 ring of Shaolin -> ring of Avoidance Shaolin's theme was pretty big on eastern exoticism, so replace with a simple theme in line with ring of robustness & brooch of shielding. -------------------------------------------------------------------------------- ec782ac | Alex Jurkiewicz | 2017-04-12 16:03:55 -0500 Remove "imported" from lajatang description It was unconsciously evoking some sort of oriental exoticism, and in lore terms was redundant since all weapons are imported into the dungeon! -------------------------------------------------------------------------------- c81acce | Yer mivvaggah | 2017-04-12 15:57:54 -0500 Update docs for advil's mutation changes (#514) [skip ci] -------------------------------------------------------------------------------- 0e8f6bb | Chris Campbell | 2017-04-11 18:51:25 +0100 Don't make the captain's cutlass chop hydra heads Treat it like all other short blades, and turn it into an actual redefined rapier instead of having its own base type that dealt slicing damage. Closes #511 PR. -------------------------------------------------------------------------------- b5f2a4e | advil | 2017-04-11 11:22:59 -0400 Drop an assert This ended up just needing to recapitulate some code earlier in the function, I added it before I fully understood how levels was chosen. -------------------------------------------------------------------------------- c9099ab | advil | 2017-04-11 09:44:44 -0400 Fix crash on ignite poison Cleanup is already handled in the call to `hurt` in an identical way, so to avoid double death, we can just delete this else (|amethyst). -------------------------------------------------------------------------------- 5e58985 | advil | 2017-04-11 00:34:30 -0400 Fix the build You can't do it like that, says every other compiler but the one I have locally. -------------------------------------------------------------------------------- 8fa4f26 | advil | 2017-04-11 00:16:39 -0400 Fix a false assumption This will let the player know that there is an invisible monster at what would be the wall jump landing site if there are other monsters in los, but I don't see a way around it. (And it is way more confusing to just give the basic "You have no room" message in this case.) -------------------------------------------------------------------------------- 9aa165b | advil | 2017-04-10 23:56:58 -0400 Improve wall jump message when a monster is in the way This case was pretty cryptic to me as a new player to WJC. -------------------------------------------------------------------------------- 2db1666 | advil | 2017-04-10 23:35:21 -0400 Don't let plants cause wall jump messaging (Yermak) This change lets monster_near_iterator to act as a range element; see the change in god-abil.cc for a cleaner for syntax that is now allowed. -------------------------------------------------------------------------------- ba41c3c | Alan Malloy | 2017-04-10 18:42:42 -0700 Use monster& when it's known non-null (|amethyst) -------------------------------------------------------------------------------- 83084bd | Alan Malloy | 2017-04-10 18:42:42 -0700 Make monster_die take a monster& instead of a monster* Most of the changes are provably safe; a few may have been relying on (now removed) nullptr checks in monster_die, but I don't think so. -------------------------------------------------------------------------------- 93344ec | Neil Moore | 2017-04-10 16:00:22 -0400 Turn terrain_property_t into an enum_bitfield. -------------------------------------------------------------------------------- 3ff418b | Chris Campbell | 2017-04-10 18:42:21 +0100 Rename Heaven on Earth to Heavenly Storm A slightly less weird name that better reflects the ability's flavour. -------------------------------------------------------------------------------- 4eb006d | Chris Campbell | 2017-04-10 18:21:13 +0100 Remove the cancel Song of Slaying ability The existence of the ability makes using it more fiddly in practice than just resting off the duration and dealing with the downside of the noise, since it requires manual cancellation once all visible enemies are killed. -------------------------------------------------------------------------------- 4de0a85 | Chris Campbell | 2017-04-10 18:03:47 +0100 Improve Heaven on Earth description -------------------------------------------------------------------------------- 2aed4d8 | Chris Campbell | 2017-04-10 17:47:53 +0100 Adjust Confusing Touch display -------------------------------------------------------------------------------- 6b4a05a | Chris Campbell | 2017-04-10 17:46:58 +0100 Make monster confuse brand from chaos weapons behave consistently Instead of having different effects when targeting other monsters compared to the player. -------------------------------------------------------------------------------- 54150e0 | Chris Campbell | 2017-04-10 17:46:26 +0100 Fix Confusing Touch being able to affect multiple targets in a turn In hydra form, or with WJC whirlwind/walljump attacks, it was possible to hit and affect multiple targets with a single confusing touch before it was expired. -------------------------------------------------------------------------------- e8aa303 | advil | 2017-04-09 22:26:02 -0400 Tweak WJC wall jump messaging Separate the error message logic very slightly from the capability logic. Two improvements that should make these messages less annoying: (i) the game will now only show wall jump error messages (and possibly flash) if there is a monster in LOS, and (ii) it won't ever message when running is stopped by a wall. -------------------------------------------------------------------------------- 35de22d | advil | 2017-04-09 11:52:44 -0400 Improve mutation tests and lua bindings Add a bunch of specific tests for mutation interactions, and improve the behavior of a bunch of lua mutation bindings. (Beware of final boolean arguments in lua bindings!) -------------------------------------------------------------------------------- dc20831 | advil | 2017-04-09 11:52:44 -0400 Fix a deletion case, add some docstrings Fix a regression in this branch, where deleting a mutation could fail to delete a normal mutation if there were temporary mutations. Also, remove an unused parameter for `mutate()`. -------------------------------------------------------------------------------- 2ae7950 | advil | 2017-04-09 11:52:44 -0400 Generalize Ds testing to all species This still spends most of its time on Ds since they have the most potential problems. -------------------------------------------------------------------------------- f97edb8 | advil | 2017-04-09 11:52:44 -0400 Fix innate/non-innate mutation interactions There were a number of ways in which the interaction of innate and non-innate (temporary or normal) mutations were garbled or just not working. This commit fixes all the problems that I am aware of. The main problems involved non-innate mutations not being converted to innate mutations properly in several cases on levelup, when the total mutation level was at the cap. For example, a player with innate hooves 2, and another non-innate hooves/talons level, would not be able to get their innate hooves 3 (and this combines with some weird bookkeeping in certain cases, e.g. for temporary mutation counts). After this commit, levels of innate mutations will consistently permify any existing temporary or nontemporary mutations first (starting with temporary); this is a slight nerf as previously innate mutations would be added on top of 1 or 2 levels of non-innate mutations. (e.g. normal robust 1 + innate robust 1 on level gain would lead to 2 levels of robust.) It appears that the old (not entirely working) behavior was intended to only permify if the total mutation levels was already at the cap. There are likely broken saves out there (especially for DsCK) -- this only fixes the level gain behavior. Also includes improvements to tests and debugging behavior. -------------------------------------------------------------------------------- aec8439 | advil | 2017-04-09 11:52:44 -0400 Add a demonspawn random mutation test Randomly give a Ds a lot of mutations as it levels up. Needless to say, this fails (crashes in validate_mutations) right now. Wizmode level change will always affect Ds mutations even if the player has been at that level before (previously the effect was only on the first level gain). I did this to make debugging and testing Ds mutations much easier. -------------------------------------------------------------------------------- 96a32bd | advil | 2017-04-09 11:52:44 -0400 Add a (c++) validate function for mutations, including Ds muts This reveals that many Ds saves with non-trivial non-innate mutations are broken, because bookkeeping for the case where a non-permanent mutation becomes permanent on levelup is not done correctly. Fix coming in a future commit. The intent is to eventually call this validation function on load, but doing this without the Ds fix will create a whole bunch of save compat issues. -------------------------------------------------------------------------------- f20264c | advil | 2017-04-09 11:52:44 -0400 Rework the mutation api and add lua bindings This commit attempts to improve, reorganize, and better document the mutation api. Previously, there appears to have been confusion about how best to check mutation levels (especially when the mutation mixes different types of permanence, e.g. temporary and innate, or involves forms, e.g. see 9c3079238cf3df88a76), and a number of other issues. This commit introduces canonical ways of getting mutation level information so that the user doesn't have to directly access `you.mutation` etc so much, and along the way fixes a number of bugs related to this. All mutation is accessed via functions on `player`. The old `player_mutation_level` (for finding current mutations modulo forms or other temporary effects) becomes `player::get_mutation_level`; the key new function for accessing the player's mutation information is `player::get_base_mutation_level` which allows a clearer way to tally mutations of different types without knowing how they are stored. The commit also does a bunch of other cleanup necessary for exporting a mutation api to lua, and adds a basic mutation test (`tests/mutation.lua`). More changes: * The logic for trading off opposing mutations wasn't working right when they mixed temporary and non-temporary levels, this should be fixed. * zin will now cure both regular and temporary mutations as part of the capstone. (This should be the only change to game logic that isn't a bugfix in this commit.) * Convert `mutation_activity_type` to an enum class. * add `delete_all_temp_mutations` and fix some temporary mutation logic. * add `mutation_from_name`, encapsulating some code that was previously in `wizard_add_mutation` so it can be used elsewhere. * move code for cleaning up temp mutations in mutation.cc, now called `temp_mutation_wanes`. * encapsulate the mutation part of the overview screen into a function that is exported to lua, and also improve the display of temporary mutations in this overview. -------------------------------------------------------------------------------- 035ce40 | gammafunk | 2017-04-09 05:04:40 -0500 Rework a Lair ending vault (Cheibrodos, #10874) Reduce the difficulty of cheibrodos_lair_end_hotspot and make it more likely that the fighting will take place inside the vault. A list of changes from the author: -Reduced generation for hydras -Lower chance of spawning fire crab in place of lindwurm -Gave more places for the gargoyles to spawn, reducing the chance of mobbing the player -Lower chance of overly dense spawns in one area -Small vault entrance redesign -Thickened outer wall -Slightly more defensible hallways Only change I made was to simplify the placement of the runed door. -------------------------------------------------------------------------------- faf0b63 | gammafunk | 2017-04-09 04:56:49 -0500 Nerf a Dungeon vault (Cheibrodos, #10891) Previously could place two hounds on D:2 in addition to the gnoll. These are OOD, and a bit more than the intended difficulty of the vault. -------------------------------------------------------------------------------- 3e3c7a0 | gammafunk | 2017-04-09 04:47:30 -0500 A batch of vaults from Cheibrodos (#10813) Float and larged themed vaults for Crypt, Elf, Lair, Orc, Shoals, Spider, and Dungeon/Depths. Vaults featuring many different themes, including a witch-hunting guild, an Elven blade-works, an Orc gladiator's arena, a Dungeon fungus farm, an overgrown Lair chateau, and more. Additional a couple sewer entry vaults and some Slime decor vaults continuing the theme of depicting remnants of the branch's lost civilization. Edits were mostly to fix errors with monster names, equipment definitions, a few glyph usage and SHUFFLE/SUBST/NSUBST simplifications. I removed choke-points in crypt_3hun_7po and crypt_cold_storage (it's ok for crypt vaults not to have easy ways to handle a vault). Also removed a hatch in the lair chateau vault, since that vault already has a stone upstairs immediately adjacent. -------------------------------------------------------------------------------- 0df07f8 | gammafunk | 2017-04-09 04:47:30 -0500 Fix monster placement in a vault Document how sewer entry setup expects the vault to define `1' through KMONS. -------------------------------------------------------------------------------- b9bd3e6 | Corin Buchanan-Howland | 2017-04-08 07:51:09 -0400 Make autumn katana a bit less exotic (minmay) -------------------------------------------------------------------------------- 5896763 | advil | 2017-04-07 23:08:56 -0400 Fix distance ordering for collapsed searches The stack location shown/used when hiding duplicates should now always be the closest stack of those that were collapsed. This commit also fixes a bug where sometimes stacks could be collapsed with inventory stacks. -------------------------------------------------------------------------------- cd8f41e | Isaac Sloat | 2017-04-07 13:58:35 -0500 Update Monk description [skip ci] -------------------------------------------------------------------------------- 3f209a8 | Chris Campbell | 2017-04-07 19:04:40 +0100 Remove some flavour overkill The phrasing also doesn't make any sense anyway. -------------------------------------------------------------------------------- b9f0da5 | Chris Campbell | 2017-04-07 18:48:50 +0100 Fix item detection interactions with Ashenzari and Jiyva If abandoning Jiyva with the jelly growth mutation, low-piety Ashenzari detection would overwrite the fixed radius of the mutation's detection. -------------------------------------------------------------------------------- 62cfa5d | Isaac Sloat | 2017-04-06 21:53:48 -0500 Fix compilation (alexjurkiewicz) -------------------------------------------------------------------------------- 3dbb393 | Isaac Sloat | 2017-04-06 21:11:10 -0500 Update Bultungin descriptions -------------------------------------------------------------------------------- 9495522 | Isaac Sloat | 2017-04-06 21:11:10 -0500 Use get_los_radius() for item detection instead of LOS_DEFAULT_RANGE. Probably could find other instances of this throughout the codebase? -------------------------------------------------------------------------------- 7dbbd50 | Isaac Sloat | 2017-04-06 21:11:09 -0500 Document Bultungin's custom XP table -------------------------------------------------------------------------------- 4122960 | Isaac Sloat | 2017-04-06 21:11:09 -0500 Alphabetize species-data.h This file became slightly disordered with various renames and additions. -------------------------------------------------------------------------------- e003528 | Isaac Sloat | 2017-04-06 21:11:09 -0500 Give Bultungins fangs Primarily as a flavor mutation to make them feel more dog (hyena)-like. -------------------------------------------------------------------------------- 171cb2e | Floodkiller | 2017-04-06 21:11:00 -0500 Add a new species: Bultungin Add the Bultungin, humanoids with the heads of dogs. Bultungins are unique in their skill training process: instead of having a static aptitude for each skill, it dynamically scales based on the current skill level of the skill they are attempting to train. They start out with an effective aptitude of +4 for all skills until skill level 7 for each skill. After that, their aptitude for that skill reduces by 2 for each skill level, with a floor of -6 at skill level 11. This makes it more efficient for Bultungins to spread out their skills over attempting to focus on raising a single skill to a high level. It takes a Human 1400 experience to bring a skill from 0 to 7. Bultungin need only 700 XP to get to that point. After 7, however, Humans begin to surpass Bultungin: it takes them only 7050 total XP to advance a skill to level 15 while a Bultungin takes 13693 total XP to get there, nearly twice as much. Bultungins also have see invisible, fangs 1, and can detect any items within 7 tiles with their strong nose. Other attributes include base stats of 7 STR/8 INT/9 DEX with increases of sid/5 levels, +2 MR/level, and baseline XP/HP/MP values. Closes #487. -------------------------------------------------------------------------------- e493e74 | Andrew Minton | 2017-04-06 12:42:17 -0500 Revise and expand the_grid Clarified connectivity rules. "Spiral mode" chance is now 25% (was 50%). Safeguarded against running out of subvaults. Removed the chance of randomly replacing walls with floor, because islands are bad. Added new shapes, main vaults, and subvaults to go with them. -------------------------------------------------------------------------------- dc9e609 | Corin Buchanan-Howland | 2017-04-05 21:00:34 -0400 Remove draconian ghost breath Having draconian ghosts breathe negative energy doesn't make sense from a consistency standpoint (no other muts/attributes are ghostified) or from a balance standpoint. I can't see any good reason to make draconian ghosts significantly more dangerous if they are XL 7 or greater. -------------------------------------------------------------------------------- 783e32d | Neil Moore | 2017-04-05 03:53:35 -0400 Avoid a teleport closet in makhleb_altar_promises_db (#10999) Also avoid generating traps under the demons. -------------------------------------------------------------------------------- 47ad1fd | Corin Buchanan-Howland | 2017-04-04 14:52:44 -0400 Remove the ability to cancel evoked invis prematurely. This was mostly an interface tax to resolve the problem of removing a +Invis item while invisible. This implementation allows you to return to visibility by removing the item, as per before, but now you get the full dose of contamination that letting the Invisibility effect run its course would cause. The only reason to intentionally stop Invis before was to reduce accumulation of contamination. It's no longer possible to reduce this accumulation by taking action. -------------------------------------------------------------------------------- cdeeb85 | Chris Campbell | 2017-04-04 18:55:00 +0100 Don't flash the screen when out-of-LOS monsters cast LOS spells (#10995) -------------------------------------------------------------------------------- 7bb5b86 | Chris Campbell | 2017-04-04 18:37:29 +0100 Fix a monster list info leak when scrying Only scry up to your actual current vision range - fixes #10996, which caused monsters you couldn't yet see to be added to the monster list. -------------------------------------------------------------------------------- 2ca7e2b | Chris Campbell | 2017-04-04 18:37:29 +0100 Unbrace -------------------------------------------------------------------------------- 5e11c12 | Chris Campbell | 2017-04-04 18:37:29 +0100 Fix Ashenzari passive monster detection range It was unintentionally increased in range by the addition of Barachi. -------------------------------------------------------------------------------- d383355 | Alan Malloy | 2017-04-04 10:09:25 -0700 Add a getter for los_radius It would be an error to actually write the global int, bypassing the los-change code. So, it should only be visible as get/set functions. -------------------------------------------------------------------------------- a19df7c | Alan Malloy | 2017-04-04 00:27:23 -0700 Add some parens around a macro argument -------------------------------------------------------------------------------- 92a50c4 | Alan Malloy | 2017-04-03 23:19:30 -0700 Mark ratskin cloak's summons correctly (rumflump, |amethyst) They're not durable summons (like god wrath), but temporary non-summoned allies (like Sticks to Snames). -------------------------------------------------------------------------------- 916514f | Isaac Sloat | 2017-04-03 14:43:36 -0500 Catch a few Barachian remnants Every instance has been changed to Barachim or Barachi, accordingly, except for the adjectival form "Barachian" in species-data.h. -------------------------------------------------------------------------------- 2d876bd | Floodkiller | 2017-04-03 12:11:30 -0500 Remove contamination from Haste. Removes the contamination from gaining and extending the Haste effect, as well as the per-turn contamination gain (and prevention of contamination dissipation) while Haste is ongoing. While Haste was a spell (and to a lesser degree, as a wand), it made sense to limit the amount of times Haste was allowed to be used per tactical encounter, as it could effectively be used as many times as desired throughout the game. However, now that the only source of Haste are potions and unreliable god effects where the player cannot necessarily guarantee they will receive Haste (Potion Petition, calling a potion shop, decks of escape, Xom), tactical limitation no longer seems necessary. -------------------------------------------------------------------------------- 2784f4f | Neil Moore | 2017-04-01 18:17:14 -0400 Split off wizard.cc from main.cc. Ultimately it would be nice to split off all the command handling, movement code, data structure initialization, and miscellaneous commands from main.cc. That would make more of the game's code available to programs like monster that omit main.o. -------------------------------------------------------------------------------- ab879bf | Neil Moore | 2017-04-01 17:35:55 -0400 Split up _compile_time_asserts(). Now that they are namespace-scope declarations in C++11. Rename what's left to _startup_asserts(). -------------------------------------------------------------------------------- 3bf614a | elliptic | 2017-03-31 23:41:20 -0400 Add player lua to tell whether the player is under penance with a specified god. -------------------------------------------------------------------------------- 3d340bb | advil | 2017-03-31 22:13:28 -0400 Fix (or at least improve) resolution of temporary mutations When trying to resolve mutation conflicts, the possibility that an existing mutation was temporary was ignored. This fixes the crash in 10981. I did a bunch of other cleanup and documentation to this code, but it's still a bit of a mess and I suspect there are more special cases that aren't handled. -------------------------------------------------------------------------------- 9cf45f8 | advil | 2017-03-31 22:12:41 -0400 checkwhite [skip ci] -------------------------------------------------------------------------------- a5226df | advil | 2017-03-31 09:53:11 -0400 Fix webtiles rotting HP label (emsyzz, 10968) This didn't actually work for anyone except when reloading the game. -------------------------------------------------------------------------------- ba1b1f9 | Alan Malloy | 2017-03-30 17:36:26 -0700 Be more explicit about a const_cast Previous code worked around a const reference by finding a non-const reference to the same monster in the environment, and then operating on that instead of on the const reference. Instead, just be honest about the fact that while we usually don't need to modify the const thing, in this one case we do, by const_casting it. -------------------------------------------------------------------------------- 1ecfa5a | advil | 2017-03-30 00:06:35 -0400 Fix conjure flame on self messaging (Avigdore) Instead of using the 'suicidal' message, use the message for non-damaging spells that can't target self (in a very indirect way). This is a quick fix, and arguably `direction_chooser::targets_enemies`, which doesn't make a lot of sense right now, should be generalized to handle spells that have to target empty spaces. Right now this concept is implemented as a special case for particular spells, rather than a SPFLAG_ or TARG_ value. Setting SPFLAG_NEUTRAL gets the targeter to be TARG_ANY instead of TARG_HOSTILE, which then is interpreted as something that doesn't target enemies. -------------------------------------------------------------------------------- 04f5055 | advil | 2017-03-29 21:37:00 -0400 Fix interbranch travel in wizmode (elliptic, 10984) This partially reverts some of the simplification part of 9217641b3915, with what is hopefully clearer logic at least. The travel cache needs to be unupdated during wizmode interlevel travel commands, not during wizmode in general. Thanks to elliptic for finding the bug and the culprit commit. -------------------------------------------------------------------------------- 0d0074d | Chris Campbell | 2017-03-29 23:45:28 +0100 Don't try and set charges on Wn boxes of beasts (minmay) -------------------------------------------------------------------------------- 9675bb3 | Chris Campbell | 2017-03-29 23:45:28 +0100 Change Barachi enums to match the species name Fixes them not being highlighted correctly on ?%. Closes #504. -------------------------------------------------------------------------------- af809b6 | sooheon | 2017-03-29 14:56:10 -0500 Move Monks to Adventurer classification As they no longer choose a weapon to begin with, this seems more fitting. -------------------------------------------------------------------------------- b48d95f | sooheon | 2017-03-29 14:56:10 -0500 Remove Monks' starting weapon choice Distribute the weapon skill points to fighting (4), dodging (4), and stealth (4). This results in Monks starting with the highest fighting and dodging in the game, and tied for the highest stealth, but no weapon or related skills. Previous rationale for moving to a weapon choice start was that having such a high skill investment into UC disallowed experimentation. But having weapon choice results in Monks playing far too much like weaker Gladiators. This change mirrors the Monks' saved-up piety: starting with high generalist fighting skills is essentially saved up xp to be used toward a weapon of choice, once one is taken from the floor or an enemy. Though many melee characters start by focusing weapon skill anyways, Monks should see a better return on this strategy given that their supporting skills begin at a higher point. Flavor wise, this fits the idea of a monk who has trained their body for health and discipline, but has not studied a particular weapon. Imagine an ascetic stepping foot into the wrong cave, and being thrown into an adventure. Gameplay wise, it gives a truly different starting experience from Fi/Gl/Hu in the starting levels, and it jives corresponds well to the piety gimmick, in that it is a boost to power *once a condition has been met* (finding an altar, finding a weapon). In the majority of cases, this should be a buff. Monks go from 11 skill points total to 12, and skills are at higher levels, which are more valuable. As soon as a monk picks up any weapon, they should be in a better place than old monks. Further, this is a buff in the case that one quickly finds a good weapon which is different from the type chosen at chargen (0 wasted xp). In the first ~30 turns, this is a nerf to survivability, requiring maximal use of the newly buffed dodge and stealth. -------------------------------------------------------------------------------- eb9d9bd | advil | 2017-03-29 10:49:04 -0400 Remove use of spam threshold to silently exclude other levels This produces pretty confusing behavior when you notice it -- if a level has too much matching stuff on it, it is just silently left out of the search. In practice it's mostly triggered by excess ammo. It's conceivable that this could produce performance problems, so an eye should be kept on this; but if the goal was usability, because ammo is now collapsed by default in searches, this is no longer needed (at least in my testing). -------------------------------------------------------------------------------- a5223d7 | advil | 2017-03-29 10:33:30 -0400 Improve display for collapsed missile searches This now shows both item count and pile count. With the qualname fix, it also sorts needles and tomahawks correctly. -------------------------------------------------------------------------------- 5a89274 | advil | 2017-03-29 10:33:30 -0400 Regularize qualname and basename for missile brands Before, both showed prefix brands but not postfix brands, so e.g. a needle of confusion would have a qualname of "needle" but a curare needle would have a qualname of "curare-tipped needle". With this change qualname shows both prefix and postfix brands, and basename shows neither. I base this on the behavior of other items, such as scrolls and potions. This change may fully resolve 3062. -------------------------------------------------------------------------------- b4023b8 | elliptic | 2017-03-29 10:26:48 -0400 GSC base delay: 1.9 -> 1.8. So that they are more competitive with regular giant clubs, which have only a bit less base damage (20 vs 22) and require only 18 skill to reach min delay as opposed to 24 skill for GSC (before this commit). Note that ogres had a much higher maces apt when GC and GSC delays were last touched (1e3ea62). With the -1 apt that they have now, the cost of raising maces to 24 is much higher. Even after this change, I expect that many chars will prefer to use a GC than to raise maces from 18 to 22. -------------------------------------------------------------------------------- bddf555 | Isaac Sloat | 2017-03-29 01:00:42 -0500 Relocate migrants from process.txt to new_dev_guidelines.md Some of the information in the original process.txt file was not very relevant to outside contributors (how to approach consensus and how our bug/issue trackers work). They've been moved into our advisory file for new developers. [skip ci] -------------------------------------------------------------------------------- 5127991 | Isaac Sloat | 2017-03-29 00:59:09 -0500 Minor cleanups to new_dev_checklist.md [skip ci] -------------------------------------------------------------------------------- aefa9c1 | Isaac Sloat | 2017-03-29 00:59:08 -0500 Totally rewrite and rename process.txt Most of the file referred to particulars of the development process in ancient days (that is, several years ago) which is no longer relevant these days. I've cleaned out most of the rotted information and replaced it with a step-by-step outline for contributors to get their submission reviewed and potentially merged into Crawl. This could use some further language cleanup. There possibly needs to be a 'design_guidelines.txt' created, though I think the Crawl philosophy is sufficient? Maybe a more succinct file would be a good idea. [skip ci] -------------------------------------------------------------------------------- 1ae2c61 | Chris Campbell | 2017-03-28 00:26:09 +0100 Improve some spell descriptions Add some mentions of spells that ignore AC. -------------------------------------------------------------------------------- 560771d | Neil Moore | 2017-03-27 08:01:42 -0400 Improve hat of Pondering description (minmay) It does not protect against the abrasive effects of salt crystal fragments, or against the attacks of saltlings. [skip ci] -------------------------------------------------------------------------------- 2efaa84 | gammafunk | 2017-03-27 01:09:07 -0500 Remove references to Delayed Fireball (Pekkekke) Also indicate tile definitions that can be removed with next major version. [skip ci] -------------------------------------------------------------------------------- fa95efa | advil | 2017-03-26 11:55:57 -0700 Filter distant duplicates in stash search (Siegurt) This implements an idea from Siegurt to show only the closest copies of items when searching stashes. Three kinds of items get collapsed: id'd weapons and armour, and missile stacks. Collapsing is toggleable with '=', which also shows/hides useless items (idea from MarvinPA; there is no separate toggle for useless items, but one can always use better searches). Glowing items do not get collapsed (though non-glowing plain "enchanted" items do by default). Two changes that come with this: filter useless&duplicates is on by default, and sorting search results by name first uses DESC_QUALNAME before the full stash name, which was the previous behavior (i.e. sorting using determiners and numerals). This should in general give more sane results, e.g. previously "3 potions of magic" would get sorted far away from "a potion of magic", and it behaves much better with missiles in particular. There are also some code cleanups to stash searching suggested by |amethyst. -------------------------------------------------------------------------------- 548304e | Chris Campbell | 2017-03-25 19:02:36 +0000 Rework Wu Jian wrath Simplify it substantially, removing the specific ties between certain effects, weapons and brands, as well as the not-very-noticeable summoning placements. -------------------------------------------------------------------------------- 6936b3b | Neil Moore | 2017-03-25 09:28:54 -0400 De-K&R-ify a brace. [skip ci] -------------------------------------------------------------------------------- df3d86c | elliptic | 2017-03-25 09:28:01 -0400 Bring back Sil status light when not using noise bar. -------------------------------------------------------------------------------- b18bc0f | Neil Moore | 2017-03-24 19:43:07 -0400 Data-ify demon<->holy weapon upgrades and downgrades. -------------------------------------------------------------------------------- 6893888 | Neil Moore | 2017-03-24 19:25:59 -0400 Checkwhite. [skip ci] -------------------------------------------------------------------------------- 7688923 | Chris Campbell | 2017-03-24 23:16:41 +0000 Always give Maurice a wand Instead of giving him an increased chance compared to other uniques, treat him like Ijyb (and add a flag for those to both always get a wand). -------------------------------------------------------------------------------- 46c167e | Alan Malloy | 2017-03-24 16:15:08 -0700 Omit some redundant checks -------------------------------------------------------------------------------- 1c438e7 | Alan Malloy | 2017-03-24 16:14:37 -0700 Convert monster's alt weapons when Yred enslaves its soul -------------------------------------------------------------------------------- b278767 | Alan Malloy | 2017-03-24 15:57:42 -0700 Un-break FULLDEBUG builds -------------------------------------------------------------------------------- e5852ff | Alan Malloy | 2017-03-24 14:51:49 -0700 Satisfy PleasingFungus's old TODO by deduplicating -------------------------------------------------------------------------------- d12c4a9 | Alan Malloy | 2017-03-24 14:47:01 -0700 Clarify boolean algebra in _give_wand -------------------------------------------------------------------------------- 0498d72 | Mnoleg | 2017-03-24 16:56:53 -0400 Invert conditional (#501) Replace an empty if branch with a negated condition. * add curly braces -------------------------------------------------------------------------------- c068411 | elliptic | 2017-03-24 15:43:50 -0400 Add an option to replace the noise bar with an equipment bar. The noise bar is great if you are trying to learn which things are noisy. However, the noise bar is (visually) very noisy itself; it is very distracting to have it constantly flashing colours and such if you already have a good sense of which things cause noise. This commit adds an option "equip_bar", false by default, which replaces the noise bar with a display of the (glyphs of) items that you currently have equipped. Usable equipment slots for your character that are currently unfilled are marked with either "." or " " depending on whether the slot is currently available (e.g. shield slot is " " if you are wielding a 2-handed weapon). This bar isn't hugely useful, but at least it provides a quick way to see how many unfilled equipment slots you have... and a row of shiny artefacts can be pretty. Eventually it would be good to have a more customizable HUD where the player can choose items from a set of many different rows or half-rows, but the code requires serious cleanup to support something like that. (This commit also slightly reorders the equipment listing in the % screen: shield and body armour were swapped, as were left and right ring. It felt more natural to have weapon and shield slots be adjacent and also have the first ring slot filled be the first one on the list.) -------------------------------------------------------------------------------- b611367 | Alan Malloy | 2017-03-22 14:53:10 -0700 Remove duplicate word in a comment -------------------------------------------------------------------------------- 1a4ba80 | Neil Moore | 2017-03-21 21:02:20 -0400 Always give Ijyb a wand. And increase her depth slightly to compensate. -------------------------------------------------------------------------------- fe4bc70 | Neil Moore | 2017-03-21 20:53:58 -0400 Checkwhite. [skip ci] -------------------------------------------------------------------------------- 6c36bf5 | Neil Moore | 2017-03-21 20:49:52 -0400 Always give armour to Duvessa and Ijyb (minmay) -------------------------------------------------------------------------------- b43ff02 | Neil Moore | 2017-03-21 20:37:23 -0400 Don't use closing single quote for apostrophes. [skip ci] -------------------------------------------------------------------------------- 8c7ba5d | Neil Moore | 2017-03-21 20:31:53 -0400 Another pop music quote. [skip ci] -------------------------------------------------------------------------------- d863c46 | gammafunk | 2017-03-21 11:43:21 -0500 Remove item level transit code The last code that made items transit levels was removed in 9f24bd51. Add a minor version tag since we're removing an area of the save file. Leave the necessary unmarshalling code for purposes of save compat, but with TAG_MAJOR ifdef. -------------------------------------------------------------------------------- 7e3609c | Chris Campbell | 2017-03-19 20:12:58 +0000 Reword some references to mana in god passive descriptions (|amethyst) Variants on "magic" or "magical power" are the terms that are used for player-visible things. -------------------------------------------------------------------------------- 583f206 | Chris Campbell | 2017-03-19 18:20:59 +0000 Fix Wu Jian messaging (|amethyst) The messages in god-passive.cc were updated, but those aren't used! -------------------------------------------------------------------------------- 27f6fa8 | Chris Campbell | 2017-03-18 20:55:08 +0000 Don't place clouds through walls during Heaven on Earth And just place the minimum number of clouds required to block LOS, instead of multiple big_clouds. -------------------------------------------------------------------------------- bcc9fa8 | Chris Campbell | 2017-03-18 20:31:23 +0000 Further simplify some Wu Jian handling -------------------------------------------------------------------------------- 09a9bfb | Chris Campbell | 2017-03-18 01:43:13 +0000 Adjust WJC distraction Don't apply distraction to already-affected monsters, increase the duration slightly, and don't decrease monster action energy when applying distraction. -------------------------------------------------------------------------------- 55b1e53 | Chris Campbell | 2017-03-18 01:43:13 +0000 Update Wu Jian ability descriptions -------------------------------------------------------------------------------- bcc8d52 | Chris Campbell | 2017-03-18 01:43:13 +0000 Fix spacing and simplify -------------------------------------------------------------------------------- e3bac26 | Chris Campbell | 2017-03-18 01:43:13 +0000 Remove the slowing effect from Whirlwind attacks To make it no longer always superior to standard attacks. It retains its use for attacking multiple targets at once, repositioning and attacking at the same time, etc, but now doesn't encourage players to always use it against single unslowed enemies. -------------------------------------------------------------------------------- 68a6da7 | Chris Campbell | 2017-03-18 01:43:13 +0000 Only allow WJC walljumping when a target would be attacked Require a valid target rather than allow it for heavy use out of combat and for extremely easy escapes. When walljumping fails, indicate the area that it's trying to target, to hopefully make it clearer how the ability is aimed. The distraction should probably also be reworked somewhat to be less spammy but still strong, since it's short-lived but affects full LOS and can be very easily repeated in good terrain. -------------------------------------------------------------------------------- da4b502 | Isaac Sloat | 2017-03-17 18:16:46 -0500 Forbid spawning in Bailey display cases [skip ci] -------------------------------------------------------------------------------- 832831a | Nicholas Feinberg | 2017-03-15 16:30:36 -0700 More Desolation vaults (nicolae, 10974) Entries and subvaults. -------------------------------------------------------------------------------- bf43aa3 | Alan Malloy | 2017-03-15 16:24:17 -0700 armour of the Dragon King -> scales of the Dragon King -------------------------------------------------------------------------------- a2611f4 | Doesnty | 2017-03-15 16:12:22 -0500 Allow (un)wielding items while berserk (#490) Allow players and monsters to (un)wield things while berserk, but warn the player if trying to wield a launcher. -------------------------------------------------------------------------------- 8d29b0b | Neil Moore | 2017-03-15 15:51:10 -0400 Fix WebTiles builds. -------------------------------------------------------------------------------- e40d5b2 | Alan Malloy | 2017-03-15 12:30:29 -0700 Fix Makefile's handling of -s flag -------------------------------------------------------------------------------- 21d059c | Chris Campbell | 2017-03-15 11:50:49 -0700 Don't display stats when examining orbs of destruction Hide irrelevant parts of the descriptions (HP/AC/EV/MR), and refactor to also hide other details like intelligence/size for both projectiles and sensed monsters. -------------------------------------------------------------------------------- d369c8b | Chris Campbell | 2017-03-15 11:50:49 -0700 Fix monsters being coloured grey under mesmerise/fear Caused by a321ce6414. -------------------------------------------------------------------------------- 1ace032 | Alan Malloy | 2017-03-15 11:50:49 -0700 Improve _mark_detected_creature - It takes a const monster& instead of a monster* - It doesn't waste effort computing a bool nobody cares about - It uses query_map_knowledge instead of env.map_knowledge - It doesn't leak information about whether terrain under detected monsters has changed since it was last seen -------------------------------------------------------------------------------- 57f3ab6 | Alan Malloy | 2017-03-15 11:50:49 -0700 Replace a use of env.map_knowledge with query_map_knowledge Isn't it lovely not to do the bounds check by hand? -------------------------------------------------------------------------------- 93d275d | Alan Malloy | 2017-03-15 11:34:36 -0700 Introduce new function query_map_knowledge Lets you ask a question about the player's knowledge of a map cell, with bounds checking implied. Not generally any less verbose than doing it by hand, but presents an API that encourages thinking about bounds-checking, as compared to the current approach where it's easy to forget to check whether the asked-about cell is in bounds. -------------------------------------------------------------------------------- e60a039 | Alan Malloy | 2017-03-15 11:27:24 -0700 Create new header map-cell.h Mostly, declares the data model for functions describing map information. Currently all such functions live in map-knowledge.h, but a future commit will add some more that need to live higher up in the dependency order and therefore can't depend on map-knowledge.h. -------------------------------------------------------------------------------- c7eb419 | Isaac Sloat | 2017-03-15 12:47:56 -0500 Add description for Ratskin Cloak evokable ability [skip ci] -------------------------------------------------------------------------------- 95a9ddd | Isaac Sloat | 2017-03-15 12:46:11 -0500 Add description for Heaven on Earth clouds [skip ci] -------------------------------------------------------------------------------- d29e1c1 | Isaac Sloat | 2017-03-15 12:31:13 -0500 Add Hepliaklqana and Uskayaw welcome lines Also rearrange for alphabetical order. [skip ci] -------------------------------------------------------------------------------- 2c13fcc | Isaac Sloat | 2017-03-15 12:21:16 -0500 Update Stomp description (10976) [skip ci] -------------------------------------------------------------------------------- 0624a50 | Kyle Rawlins | 2017-03-15 08:45:26 -0400 Add a note one documentation in Makefile itself There's info on prefix, SAVEDIR, etc there too that may help in clarifying this issue. -------------------------------------------------------------------------------- 1cde397 | Yer mivvaggah | 2017-03-15 08:45:26 -0400 Specify what "setting a prefix" means -------------------------------------------------------------------------------- 2c7b0bf | advil | 2017-03-14 14:43:07 -0400 Add another mesmerise check Prevent odd artifacts while looking off-level when mesmerised. -------------------------------------------------------------------------------- 9226ecd | Neil Moore | 2017-03-14 14:18:22 -0400 Recalc LOS, clinging, etc. when wizmode xm destroys walls. -------------------------------------------------------------------------------- 3b19a06 | Alan Malloy | 2017-03-14 10:19:09 -0700 Revert cbfb660f8 and 436dd8c64 They seem to be causing serious problems but we don't know why yet. -------------------------------------------------------------------------------- cbfb660 | Chris Campbell | 2017-03-14 15:35:02 +0000 Don't display stats when examining orbs of destruction Hide irrelevant parts of the descriptions (HP/AC/EV/MR), and refactor to also hide other details like intelligence/size for both projectiles and sensed monsters. -------------------------------------------------------------------------------- 436dd8c | Chris Campbell | 2017-03-14 15:05:08 +0000 Fix monsters being coloured grey under mesmerise/fear Caused by a321ce6414. -------------------------------------------------------------------------------- 785f14b | advil | 2017-03-13 23:02:41 -0400 Block mesmerisation through solid features (10962) This changes grates/statues to behave like transparent walls for mesmerisation purposes. -------------------------------------------------------------------------------- 4070442 | advil | 2017-03-12 21:14:09 -0400 Remove some obsolete checks for smite-targeting past transparent walls Affected local tiles mouse targeting -------------------------------------------------------------------------------- cf33cab | advil | 2017-03-12 18:51:48 -0400 Make `get_spell_letter` use `you.spell_letter_table` This function was assuming that alphabetical ordering tracked spell slot order, which hasn't been true for a while. Could've affect macros/lua in any game where spells got reordered, and was definitely affecting local tiles casting with mouse (which uses macros). -------------------------------------------------------------------------------- 1c3bcfd | advil | 2017-03-12 16:40:45 -0400 Fix a return (local tiles mouse bug) This keeps a canceled ctrl-self-click from causing the player to wait. -------------------------------------------------------------------------------- 8880629 | advil | 2017-03-12 13:58:46 -0400 Check map bounds for local tiles right-click (10600) Before this fix, tiles simply crashes when you right-click out of bounds. This check also prevents a blank display when right-clicking an unknown space with no features. -------------------------------------------------------------------------------- d9c272e | Neil Moore | 2017-03-12 09:05:04 -0400 Correct some database comment placements (Alarkh) "Hepliaklqana forms a fragment of your life essence into the memory of your ancestor, Jaydra # not many names!" -------------------------------------------------------------------------------- d30af50 | Neil Moore | 2017-03-12 09:01:43 -0400 Fix a warning (yrmvgh) -------------------------------------------------------------------------------- 92acfd1 | Neil Moore | 2017-03-11 19:59:05 -0500 Correct a few more keys in db_lint and gather_features. Add "awoken tree", various halos, and "Pakellas death" to the list of keys; and remove a few obsolete godspeak keys. [skip ci] -------------------------------------------------------------------------------- 78d7932 | Neil Moore | 2017-03-11 19:51:45 -0500 Fix missing Xom cloud trail speech. [skip ci] -------------------------------------------------------------------------------- f9b334b | Neil Moore | 2017-03-11 19:41:12 -0500 Remove/rename some obsolete descriptions and db entries. -------------------------------------------------------------------------------- fa09539 | Neil Moore | 2017-03-11 19:33:30 -0500 Fix up db_lint and util/gather_*. They were failing to recognise several things because of formatting and other changes in the code. Reorder dragon scales to the end of the ARM_ entries in item-prop.cc to make things easier. Also have util/cpp_version strip out #pragma once to avoid a warning from GNU cpp when passed a header file; and specify C++11. [skip ci] -------------------------------------------------------------------------------- 97e26f1 | Neil Moore | 2017-03-11 19:28:22 -0500 Fix dragon scales when TAG_MAJOR_VERSION > 34. -------------------------------------------------------------------------------- 4680a50 | Neil Moore | 2017-03-11 18:00:30 -0500 Checkwhite (doh) [skip ci] -------------------------------------------------------------------------------- 654850e | Neil Moore | 2017-03-11 17:46:23 -0500 Use more scoped enums and enum bitfields. And lowercase some existing ones. Also, remove the unused mcache_type. -------------------------------------------------------------------------------- 0c3f484 | Neil Moore | 2017-03-11 16:55:17 -0500 Update copyright date in licence.txt [skip ci] -------------------------------------------------------------------------------- d94ac0f | Neil Moore | 2017-03-11 07:44:56 -0500 Update metadata. [skip ci] -------------------------------------------------------------------------------- d83b866 | Neil Moore | 2017-03-11 01:17:02 -0500 Don't crash when ratskin cloak has no room to summon. http://crawl.akrasiac.org/rawdata/astronautguy/crash-astronautguy-20170311-06111 3.txt -------------------------------------------------------------------------------- 0cc194a | Isaac Sloat | 2017-03-10 20:21:40 -0600 Speed up monster Sprinting The effect was somewhat overlookable: a -2 reduction to the cost of moving. This would work out to a couple extra tiles over a screenful approach compared to baseline. Since alligators were already fast in water, this never felt like a meaningful increase to their ability to zip up next to the player. The goal is to increase alligator relevance in Swamp: seeing an alligator means they're likely to catch up to the player almost right away, and they're extra difficult to escape from while in watery terrain. Because of how energy costs work, increasing the movement discount by 1 has a multiplicative effect on their speed, especially in water. Primarily affects alligators in Swamp. Gastronok and Maurice are the other two monsters that have access to SPELL_SPRINT. This change won't make Maurice any deadlier, but Gastronok may need to be moved slightly deeper into the Dungeon. -------------------------------------------------------------------------------- abbfcfc | Nicholas Feinberg | 2017-03-10 10:24:22 -0800 Barachians -> Barachim Move more toward a vaguely Hebrew theme (Barach = 'to flee', or 'to cause others to flee'), in tribute to their newfound divine origins. Move away from a mangled scientific name; Formicids and pals are quite enough for that! Thought: would it be too weird for them to just be Barach/im? -------------------------------------------------------------------------------- 07130c9 | Neil Moore | 2017-03-10 11:53:30 -0500 Re-align mutation conflict table. -------------------------------------------------------------------------------- 162479b | Neil Moore | 2017-03-10 11:52:18 -0500 Make no regen mutation conflict with fast regen (MrMonch). Also, make no regen conflict with inhibited regen, rather than trading off with MUT_SLOW. There was a missing comma. -------------------------------------------------------------------------------- e5a7832 | Isaac Sloat | 2017-03-09 00:08:44 -0600 Fix WJC overview screen (10955) Also contains spacing changse in god_powers. [skip ci] -------------------------------------------------------------------------------- 77b00a3 | Nicholas Feinberg | 2017-03-08 22:07:13 -0800 Fix a Zin recite comment (10944) Monsters at 30 hd actually can't be affected, and allowing that seems to require making zin recite stronger across the board, so... simpler to just fix the comment. -------------------------------------------------------------------------------- 73d9be0 | advil | 2017-03-08 23:44:55 -0500 Update los when clouds spread Wasn't happening at all, apparently. -------------------------------------------------------------------------------- 4f67902 | Isaac Sloat | 2017-03-08 20:01:29 -0600 Add a color for extreme draining Magenta, for situations where the player is super duper drained. In places like the Elven Halls, it's easy to hit Red draining, and continue on being drained way past that point without noticing. A new threshhold should help better alert players that they're in serious trouble. -------------------------------------------------------------------------------- c3a5237 | advil | 2017-03-08 20:24:02 -0500 Consider opacity of old clouds when recalculating los Before this change, a new cloud that was non-opaque could overwrite an old cloud that was opaque without los getting recalculated, leading to rendering issues and crashes when targeting. (Mainly instantiated by OOD condensation clouds in opaque fog.) -------------------------------------------------------------------------------- 4803ca2 | Isaac Sloat | 2017-03-08 18:38:15 -0600 Add Donald lines for Hep/Usk/WJC I hate flavor. -------------------------------------------------------------------------------- 97f89d0 | Isaac Sloat | 2017-03-08 18:35:49 -0600 Steal away ARTP_FOG Used only on the Cloak of the Thief. Instead have the ability directly added when the unrand is equipped. -------------------------------------------------------------------------------- 72f1636 | Isaac Sloat | 2017-03-08 18:35:49 -0600 Refactor Ratskin Cloak code Uses the 'a'bility menu, instead of e'V'oke which is generally reserved for inventory and holdables. Keeps it consistent with other wearables that grant you evocable abilities. This probably should be unified at some point. -------------------------------------------------------------------------------- 939b552 | Neil Moore | 2017-03-08 11:09:36 -0500 Never switch to webtiles CRT mode in cursorxy() Push the fix in 0.20-a0-840-gfcb4723 down into cursorxy. The existing tiles_crt_control in show_map() is still necessary. -------------------------------------------------------------------------------- df58d0c | Neil Moore | 2017-03-08 10:24:54 -0500 Checkwhite. [skip ci] -------------------------------------------------------------------------------- fcb4723 | Neil Moore | 2017-03-08 10:18:08 -0500 Fix use_fake_cursor = false webtiles targeting (#7201, #10965) Broken probably since the dawn of webtiles, but at least since 2013. When doing a cursorxy on the map we need to temporarily disable CRT screen switching. It might be better to move this into cursorxy directly, since as far as I can tell there is only one other caller, which is also protected by a tiles_crt_control{false}. -------------------------------------------------------------------------------- daf5c57 | Floodkiller | 2017-03-07 22:02:27 -0600 Fix more hardcoded 27s. (#489) Fix more hardcoded 27s found in ash_skill_boost(); replaced with MAX_SKILL_LEVEL. -------------------------------------------------------------------------------- 06be174 | advil | 2017-03-07 21:35:32 -0500 Reword WJC powers screen so it doesn't overflow on 80x24 (zackoid) -------------------------------------------------------------------------------- 0f21a4d | Corin Buchanan-Howland | 2017-03-07 17:57:41 -0500 Update Ru sacrifice piety gain (minmay) Lowered the piety gain for sac resistance and sac artifice, the latter due to its lower impact, the former because it was a little too high anyway. Lowered the piety for screaming, because it was low-impact. Raised piety for -ev and -ac, and increased how much ac/ev you sacrifice at once from 3 to 5 in order to make it more impactful. Increased the piety for frail and sac experience, since losing max hp is more impactful than it got credit for. Increrased piety for sac love, since allies are great and most chars can get them somehow. -------------------------------------------------------------------------------- e7e240f | Isaac Sloat | 2017-03-07 10:47:09 -0600 Minor cleaning of Wu Jian description (10964) [skip ci] -------------------------------------------------------------------------------- d6476b5 | advil | 2017-03-07 09:58:02 -0500 Revert add loudness to loudness On consideration, it isn't clear that this works as-is. -------------------------------------------------------------------------------- c59a6f1 | advil | 2017-03-07 09:23:05 -0500 Add loudness to the ring of loudness This uses a multiplier of x2 per ring, which is possibly too steep. It keeps the -stealth effect. -------------------------------------------------------------------------------- c632bec | Neil Moore | 2017-03-06 19:10:53 -0500 Give better message when trying to worship Fedhas/Yred while loveless. -------------------------------------------------------------------------------- 0f01416 | Neil Moore | 2017-03-06 19:10:53 -0500 Add qw persist file to .gitignore. [skip ci] -------------------------------------------------------------------------------- cd1f35f | Floodkiller | 2017-03-06 17:18:07 -0600 Clean up detect_items() (#488) Cleans up the detect_items() method in spl-goditem.cc. Include mutations.h to specifically check for MUT_JELLY_GROWTH instead of implying it if Ashenzari isn't the player's god, initialize map_radius with a starting value of 0, and add some descriptive comments. -------------------------------------------------------------------------------- 2c9a30d | Isaac Sloat | 2017-03-05 18:34:31 -0600 Pre-identify manuals Manual identification was broken in 2c266a969726 - step-over would identify only the first manual in any given game, and all subsequent manuals had to be picked up to identify their types. Fixing this using the book/wand autoidentification approach causes much more issues than it truly solves. So we take a different approach: all manuals come pre-identified. -------------------------------------------------------------------------------- 299e025 | advil | 2017-03-05 19:00:22 -0500 Disallow leaping fungi and make the nervousness code a little less confusing. -------------------------------------------------------------------------------- bdc6353 | Isaac Sloat | 2017-03-05 16:48:46 -0600 Randomize doesnt_xom_only_xom Still has the issue of duplicate mimics, but fixing that takes more effort. Also fixes a minor comment mistake elsewhere. -------------------------------------------------------------------------------- 96581b6 | advil | 2017-03-05 14:35:12 -0500 Let fake_pty (for tests) compile on OS X -------------------------------------------------------------------------------- 242eb58 | Chris Campbell | 2017-03-05 17:50:50 +0000 Give wading in shallow water a fixed movement speed penalty Instead of adjusting movement speed with a randomised multiplier, make wading through shallow water always increase movement delay by 6. Results in approximately the same average wading speed for humans (and slightly faster for nagas/slower for spriggans). -------------------------------------------------------------------------------- e93c148 | advil | 2017-03-05 10:24:54 -0500 Check for map bounds when coloring mesmerise ranges (|amethyst) My first screwup! -------------------------------------------------------------------------------- a321ce6 | advil | 2017-03-05 09:11:50 -0500 Make targeter/mesmerise code & rendering consistent across interfaces This centralizes the code for mesmerise cell darkening (in view.cc, where only tiles/webtiles were dealt with before) and makes it do roughly the same thing at the same time for console/tiles. Before, console would only show the mesmerise range no matter the targeter, and (web)tiles would show only the targeter range even when mesmerise was active and it was a blink-like targeter. Now, blink targeters will appropriately color possible target cells if blinking to that cell is impossible because of mesmerise. This also fixes up a few other issues, such as the console blink targeter not coloring appropriately for transparent walls. -------------------------------------------------------------------------------- dec668e | Chris Campbell | 2017-03-04 17:12:40 +0000 Allow shopping and praying while immobile/netted/mesmerised They were prevented because they used the keys, but they're not movement actions or attempts to actually take staircases so there's no need to block them on the rare occasion that they occur while on top of a shop/altar. Re-enables the very important message "You sway towards the altar of foo." Also allow entering passages of golubria with while mesmerised - previously they could be entered by walking into them (even if the passage would move you away from the beholder), so blocking entering them while already standing on one didn't make much sense. -------------------------------------------------------------------------------- 9aa82c1 | advil | 2017-03-04 11:55:11 -0500 Check for mesmerizers after passwall world_reacts and player_reacts aren't called, because there is 0 time spent on the other side of the wall, but some cleanup needs to happen. I looked into factoring location-related effects out of player_reacts, but this is not very feasible given that all of the location-related effects interact with durations on a real turn, and order matters a fair amount in that faction. This also calls search, because otherwise (I think) it is optimal but spoilery to wait in place for a turn, at least if nothing's around. Of the other relevant effects in player_reacts, this fix ignores two things that are plausible to happen: the possibility of passwalling into a silenced area while singing, and passwalling over lava (while flying) with ozocubu's armour up. Since no time has passed, this is probably ok, and these will get dealt with on the next turn. Other location-based effects: slime wall damage shouldn't happen after 0 time, and constriction is also handled elsewhere so gets appropriately cleared. It also doesn't deal with passwalling into a cloud, but this probably shouldn't do damage immediately. -------------------------------------------------------------------------------- 8f2c41c | advil | 2017-03-04 09:39:00 -0500 Cancel passwall on forced movement from mesmerize (CanOfWorms) This fixes part of 10961, but the interaction of mesmerize with pseudo-movement via passwall and other means is still a mess. -------------------------------------------------------------------------------- 557356e | Chris Campbell | 2017-03-03 22:35:06 +0000 Don't let spatial maelstroms consume malign gateways -------------------------------------------------------------------------------- b8aa111 | Chris Campbell | 2017-03-03 22:17:17 +0000 Refactor handling of endless sea/lava/salt Fixes #10957, so bolts can no longer bounce off endless lava, as well as preventing monsters from being able to try and move into endless salt - which previously was possible for spatial maelstroms. Also remove some unnecessary checks that were already covered by those terrain types always being considered uninhabitable. -------------------------------------------------------------------------------- ed4b268 | Chris Campbell | 2017-03-03 22:16:44 +0000 Remove an unused parameter Finally obsoleted by Djinn removal. -------------------------------------------------------------------------------- b58a58a | Chris Campbell | 2017-03-03 21:12:29 +0000 Remove some obsolete handling for walking through lava Since Lava Orcs are now really removed for real. -------------------------------------------------------------------------------- ec8dada | Chris Campbell | 2017-03-03 19:08:53 +0000 Simplify contamination explosions slightly Don't increase damage to undead, and cap the explosion size at LOS_RADIUS. -------------------------------------------------------------------------------- d5e2b11 | Chris Campbell | 2017-03-03 19:08:50 +0000 Relocate advil in mailmap -------------------------------------------------------------------------------- 6d883fa | Alan Malloy | 2017-03-03 10:01:41 -0800 Fix red sonja sprint temple (escu) 7d8ffb2f replaced an important wall with the altar; this commit reinstates the wall, and puts the altar on a floor tile. -------------------------------------------------------------------------------- 9dd3d4c | Nicholas Feinberg | 2017-03-03 07:46:52 -0800 Prevent eternal Heaven From e.g. dying as a felid with extra lives while Heaven on Earth is active. Credit to "someone on tavern", apparently? Got this one second-hand. Also add a sanity check to avoid future issues. -------------------------------------------------------------------------------- 3c07459 | Yer mivvaggah | 2017-03-03 09:32:29 -0600 Make Pikel less awkward (#484) -------------------------------------------------------------------------------- 58a14f4 | Nicholas Feinberg | 2017-03-03 07:30:55 -0800 Destroy destroy_spellbook (Doesnty) Obsolete since the removal of Sif's no-book-destruction conduct, in 22eb85313b3f15e2c70329041d08e02b1fa0fd41. (oops...) -------------------------------------------------------------------------------- 00179d9 | Nicholas Feinberg | 2017-03-03 07:26:13 -0800 Fix /Random Effects (10960) Broken in... 4a616ededea7... :( -------------------------------------------------------------------------------- af7f6688 | advil | 2017-03-01 23:15:38 -0500 Clear some hud state on _reset_game If the previous game's turn number was lower than the current one, and a more() was triggered at exactly the right time during a load (when hp was set but before maxhp was set), the more() would trigger a HUD redraw that would crash. This commit clears the HUD redraw on turn # settings as part of _reset_game. -------------------------------------------------------------------------------- 25e6c9c | advil | 2017-03-01 23:15:38 -0500 Factor species changing out of wizmode (amalloy) Species changing needs to be available on builds without wizmode for this save compat thing to work. This also does error handling in a somewhat cleaner way. -------------------------------------------------------------------------------- eca223a | advil | 2017-03-01 23:15:38 -0500 Remove temperature even more thoroughly (amalloy) This also adds a minor tag to indicate that temperature is no longer saved. Probably a good idea to have a minor tag for this PR anyways. Includes some other formatting fixes to address amalloy's comments. -------------------------------------------------------------------------------- b54b6f0 | advil | 2017-03-01 23:15:38 -0500 Remove Djinn code Remove most major-tag-bracketed djinn code blocks. This leaves a few things untouched, including the existence of species data, and rltiles. This commit incorporates some fixes from amalloy, as well. -------------------------------------------------------------------------------- f1e2002 | advil | 2017-03-01 23:15:38 -0500 Remove lava orcs This removes most TAG_MAJOR_VERSION blocks for lava orcs. I left a few for save compatibility reasons (temperature is still read and written), and some species data is still there, also for save compat reasons. I didn't touch rltiles because I'm not sure how anything in there works. This commit incorporates some fixes from amalloy, also. -------------------------------------------------------------------------------- f215198 | advil | 2017-03-01 23:15:38 -0500 Convert Djinni to Vine Stalkers on load There's no really great match for Djinni, but Vs seemed ok (|amethyst's suggestion). This is preparatory to cleaning up as much of their excess code as possible. -------------------------------------------------------------------------------- 1ce8af0 | advil | 2017-03-01 23:15:38 -0500 Convert lava orcs to hill orcs on load This commit (after a special warning) converts a LO save into a HO. This is preparatory to removing most LO code. -------------------------------------------------------------------------------- 512f924 | Nicholas Feinberg | 2017-03-01 18:38:51 -0800 Disable berserk penalty for martial attacks Regardless of the overall balance of the god, this seems incorrect. Sorry, didn't note down the reporter for this - reddit, possibly? -------------------------------------------------------------------------------- 8b9f790 | Alan Malloy | 2017-03-01 15:58:26 -0800 Fix temple_doors_cd (ethical_paranoiac) A bug introduced in cc390b85 meant it was accidentally generating many random altars outside the temple. -------------------------------------------------------------------------------- 4a616ed | Nicholas Feinberg | 2017-03-01 14:29:50 -0800 Fix monster Freezing Cloud (Doesnty) Broken by 858c25845014. I did say it was a hacky fix! -------------------------------------------------------------------------------- 1217706 | Nicholas Feinberg | 2017-03-01 14:10:58 -0800 Remove a duplicate poison cloud placement Seems to have been accidentally added in 0464b71d0, probably while trying to implement Poisonous Vapours. -------------------------------------------------------------------------------- 2c266a9 | Alan Malloy | 2017-03-01 11:31:04 -0800 Don't print manuals' types twice when you drop them (minmay) -------------------------------------------------------------------------------- 48d8da1 | Nicholas Feinberg | 2017-03-01 09:56:20 -0800 Fix PProj changelog entry (UsaSatsui) -------------------------------------------------------------------------------- 13927d1 | advil | 2017-03-01 08:39:44 -0500 Add no_trap_gen to an arrival vault (pisechka, Xenobreeder, escu) to preven hydras from killing new players. See http://crawl.xtahua.com/crawl/morgue/pisechka/morgue-pisechka-20170301-125342.tx t -------------------------------------------------------------------------------- a03948b | Kyle Rawlins | 2017-02-28 16:23:41 -0500 Fix up some links in the new developer docs [ci skip] -------------------------------------------------------------------------------- b9d8e5d | Chris Campbell | 2017-02-28 18:04:35 +0000 Move advil from contributors to devs in CREDITS.txt Welcome! -------------------------------------------------------------------------------- 3084b0a | Chris Campbell | 2017-02-28 16:43:39 +0000 Remove yet more divinations (advil) -------------------------------------------------------------------------------- 09bcfd3 | Nicholas Feinberg | 2017-02-27 17:56:22 -0800 Remove Divinations, again Deja vu...? -------------------------------------------------------------------------------- f6451d4 | Chris Campbell | 2017-02-28 00:43:30 +0000 Simplify Spellbinder miscasts Don't base the miscast school on the schools of the spells that the affected monster knows, instead just always use random miscasts. Having the set of miscasts change per-monster was unnecessarily complicated, and also caused it to not affect certain monsters (such as daevas, whose Smiting is affected by antimagic but who previously never miscasted since it's SPTYP_NONE). -------------------------------------------------------------------------------- dea14c4 | Chris Campbell | 2017-02-28 00:05:53 +0000 Remove the Divinations school It only still existed at all to be used for miscasts, and since that's no longer necessary it can finally be removed for good! -------------------------------------------------------------------------------- 19352b5 | Chris Campbell | 2017-02-27 20:01:19 +0000 Rework sources of divinations miscasts The only things that used them (other than fully random miscasts) were the staff of Wucad Mu and Sif Muna wrath. Sif Muna wrath already included all of the divination miscasts separately anyway, so just adjust weights slightly. Give the staff of Wucad Mu its own hand-picked lists of effects instead based on a simplified version of the divination miscast list, with the nice side-effect that they'll be substantially easier to rebalance if needed. -------------------------------------------------------------------------------- 5cc1a67 | Chris Campbell | 2017-02-27 17:16:27 +0000 Fix missing items in pitsprint 7d8ffb2f made the falchion always overwrite the quarterstaff placement. Also restructure the temple area yet again, so it's now future-proofed with space for up to 27 gods. -------------------------------------------------------------------------------- 4ba4951 | Neil Moore | 2017-02-27 00:16:00 -0500 Use windows.h instead of mmsystem.h. [skip ci] since we don't build Windows on travis-ci. -------------------------------------------------------------------------------- 355e369 | Neil Moore | 2017-02-27 00:14:14 -0500 Try to fix Windows builds. Include mmsystem.h if possible, and define SND_ASYNC and SND_NODEFAULT ourselves if necessary. -------------------------------------------------------------------------------- 17250f0 | Isaac Sloat | 2017-02-26 21:06:01 -0600 Add ezyang to CREDITS [skip ci] -------------------------------------------------------------------------------- 7d8ffb2 | Edward Z. Yang | 2017-02-26 20:53:14 -0600 Add Wu Jian Council to sprints. (#479) Signed-off-by: Edward Z. Yang [skip ci] -------------------------------------------------------------------------------- d0efa66 | Neil Moore | 2017-02-26 21:48:01 -0500 Don't trap the player in lemuel_flame_loot_2. -------------------------------------------------------------------------------- 128d08b | Neil Moore | 2017-02-26 21:48:01 -0500 Remove obsolete save_compatibility.txt sentences (advil, MarvinPA) [skip ci] -------------------------------------------------------------------------------- cf00bbb | Neil Moore | 2017-02-26 21:48:01 -0500 Add split-enum and sound headers to MSVC project. -------------------------------------------------------------------------------- a8316f7 | Neil Moore | 2017-02-26 21:48:01 -0500 Use #pragma once in tile tool and util/art-data.pl. -------------------------------------------------------------------------------- 2376135 | Alex Jurkiewicz | 2017-02-26 21:48:01 -0500 Convert from #ifndef *_H to #pragma once (PR #474) [Committer's note: Since #pragma once is supported by every compiler that we support. -nfm] -------------------------------------------------------------------------------- 4270d38 | Autofire | 2017-02-26 21:48:01 -0500 Enhanced sound support (PR #450) This fork features some enhancements for the sound system. Although my plans initially were more ambitious, this will do for now. Adds sound_file_path option, making the current sound option much easier to use. Moved all the sound code to its own set of files for future expansion (I have some plans). Also, makes it painless to fiddle around with PLAY_SOUND_COMMAND, which previously was in AppHdr.h despite being used in just one function. (UPDATE) Adds multiple cues that can be used in place of typical regular expressions. Some examples are PICKUP, MEMORISE_SPELL, and CHANGE QUIVER. See sound.h for a full list. I intend of expanding this. Very incomplete support for a hold_sound option, which is supposed to pause the game while the sound is playing. This pause is intended to be sequential, delaying the rest of the message until the sound finishes. I have two purposes for this: giving battles a real-time feel, and to highlight those epic victories. This feature doesn't work as intended, so I dropped the in-game documentation for now. (UPDATE) Adds one_SDL_sound_channel. Originally, sound behavior depended on whether you were playing with SDL or using the SOUND_PLAY_COMMAND define; if playing with SDL/Tiles, only one sound would play at once, whereas SOUND_PLAY_COMMAND allowed as many sounds as were necessary. By default, one_SDL_sound_channel is set to false, making it behave as SOUND_PLAY_COMMAND. However, players can restore the old behavior by setting this option to true. (UPDATE) The version screen now tells the user how sounds will be played. (i.e. "Windows Multimedia API," "External command," or "SDL_mixer") Anyway, I know this works as intended on Linux and Cygwin, and I did run crawl -test to double check stuff. UPDATE: I have now verified that it works with Tiles! However, I can't test with Windows, Mac, etc. I may or may not have broken the sound stuff. At worst, some more files need to be included in sound.cc. Finally, the game works as normal when compiled without sound support. I only tested this in Linux, but I'm certain that it should be the same everywhere else. Happy crawling! ~Autofire -------------------------------------------------------------------------------- f3a60fd | Alex Jurkiewicz | 2017-02-26 20:41:30 -0600 Add message colouring for Xom stair/shop sliding -------------------------------------------------------------------------------- 3c28938 | Chris Campbell | 2017-02-27 01:08:20 +0000 More save_compatability.txt updates -------------------------------------------------------------------------------- f79451f | Neil Moore | 2017-02-26 19:49:49 -0500 Checkwhite. [skip ci] -------------------------------------------------------------------------------- c051a77 | Neil Moore | 2017-02-26 19:49:40 -0500 Remove signatures and frame story from save_compatibility.txt. So as not to discourage future edits and improvements to existing sections. Documentation is a collaborative effort! [skip ci] -------------------------------------------------------------------------------- 1d7f8f2 | Neil Moore | 2017-02-26 19:49:32 -0500 Improve save_compatibility.txt. Add a section on the general architecture of character, major, and minor tags. Also make section header formatting and numbering more consistent. [skip ci] -------------------------------------------------------------------------------- 73021bd | Nicholas Feinberg | 2017-02-25 20:47:14 -0800 Note WJC piety source in the changelog -------------------------------------------------------------------------------- def7eae | Nicholas Feinberg | 2017-02-25 19:24:58 -0800 Changelog through 0.20-a0-770-g8c33442 -------------------------------------------------------------------------------- 8c33442 | Nicholas Feinberg | 2017-02-25 18:41:05 -0800 Give Barachians LOS 8 (gammafunk) The general feeling was that Barachians were a bit bland, so let's add a new mechanic to interact with their existing Hop and slow movement. They now have +1 LOS, making considerably more spaces visible than for normal races. This is generally considered Bad; in exchange, thus, I'm raising their attributes slightly, increasing level 2 hop range, and also raising most of their aptitudes by +1. As part of the change, the race is rethemed: instead of being barbarians from the arctic south, they're now rebellious former servants of the good gods, which naturally repel shadows. (The opposite of Nightstalker, more or less.) Accordingly, they now have poor Invocations, Necromancy, and Stealth apts. It could be worth making the Robe of Night and the Darkness spell not work for them, for theme reasons, but that's a long and slippery slope. Should Umbra not work? Should they be banned from Dith...? That last in particular was suggested, and might yet happen, but I'm unsure. -------------------------------------------------------------------------------- 6290b7b | Nicholas Feinberg | 2017-02-25 18:38:14 -0800 Change the maximum LOS to 8 Now that we can technically do so. This is to support future planned mechanics. Expected effects: - Some performance impact; iterating over LOS_RADIUS^2 covers about 28% more tiles, so that might be relevant in some contexts. Would require testing to see if it's actually a problem. - mon-place.cc is slightly more reluctant to place monsters near the player, in some contexts. - _mons_has_path_to_player() is slightly more cautious about mons pathing distances. - IOOD and Gell's Gravitas are very slightly stronger. -------------------------------------------------------------------------------- 627c671 | gammafunk | 2017-02-25 19:57:41 -0600 A new dev guidelines document and move team-related docs to a dir A draft of a guidelines doc we've been giving to new team members in markdown format. A few sections like Coding Standards Development Philosophy probably need more work, but the document should also not become too long or duplicate information stored elsewhere. Move this new doc and the new dev checklist to a docs/develop/team subdir. -------------------------------------------------------------------------------- 3afde5b | Chris Campbell | 2017-02-26 00:11:29 +0000 Fix martial attacks working on projectiles (makeAllTheGames) -------------------------------------------------------------------------------- 52e1353 | Chris Campbell | 2017-02-25 21:05:56 +0000 Remove some unrand messages The captain's cutlass message was outdated for TSO worshippers and weirdly worded otherwise, and the Damnation message referred to old hellfire (both of those could potentially get replacements but Damnation in particular is hard to come up with good wording for). The thermic engine message duplicates the unwield message, with the potential of just being spammy in combat when it drops back to +2 enchantment due to misses. -------------------------------------------------------------------------------- 5b3495a | Chris Campbell | 2017-02-25 20:32:02 +0000 Adjust formatting -------------------------------------------------------------------------------- 58a985a | Chris Campbell | 2017-02-25 20:30:41 +0000 Tweak staff of Olgreb description -------------------------------------------------------------------------------- 30c0459 | Chris Campbell | 2017-02-25 20:18:55 +0000 Don't make Xom's divine lightning hurt the player (minmay) It's a particularly rare "good" effect, so shouldn't have a chance of dealing very high damage to the player (and potentially reducing them to 1 HP). -------------------------------------------------------------------------------- 6bc4dfa | Chris Campbell | 2017-02-25 20:14:12 +0000 Give the staff of Dispater fixed HP/MP costs -------------------------------------------------------------------------------- f9d17c3 | Neil Moore | 2017-02-25 11:33:25 -0500 Add "update servers" step to the release guide. -------------------------------------------------------------------------------- 49f5558 | Neil Moore | 2017-02-25 00:09:54 -0500 Checkwhite (doh) [skip ci] -------------------------------------------------------------------------------- ab50500 | Neil Moore | 2017-02-25 00:01:55 -0500 Don't repeatedly generate the same vector of PlaceInfos. Also, fix formatting. -------------------------------------------------------------------------------- 9d7c357 | Alan Malloy | 2017-02-24 20:57:23 -0800 Merge pull request #473 from rawlins/desolation-import-fix Load saves where desolation is incorrectly global -------------------------------------------------------------------------------- 13ddd6e | Isaac Sloat | 2017-02-24 21:23:00 -0600 Allow the ratskin cloak to call rats The ratskin cloak can now summon river or hell rats to accompany you for a brief time. This could use better attachment to Evocations skill, maybe? -------------------------------------------------------------------------------- aefd0f4 | Isaac Sloat | 2017-02-24 21:22:56 -0600 Make the ratskin cloak slightly rattier (minmay) -------------------------------------------------------------------------------- 4c9d53b | advil | 2017-02-24 21:42:33 -0500 Refine the fix for loading corrupt saves (amalloy) This adds an assert to only fix desolation, and uses the iterator order rather than enum order. -------------------------------------------------------------------------------- 4807967 | advil | 2017-02-24 21:40:49 -0500 Correctly clear place info on game reset This fixes a bug that was leading to save corruption in importing to 0.19 and later (10696, 10788). What was happening was this: 1. _reset_game calls player(), which initializes the branch numbers (without actually clearing place info) 2. Then it was calling clear_place_info() which clears all the place info (without initializing the branch numbers). Post 0.19, this leads to branch numbers being set to 127. 3. A save from 0.18 would load, but fill one less place info slot than needed, because desolation didn't exist. This last slot wasn't touched on unmarshalling at all, so was left with its branch number set to 127. This is the global place info slot. 4. This was saved. 5. On load, the spurious 127 branch hit an assert. Because this only happened on _reset_game, to trigger the corruption, you need to exit to the main menu. Importing a game on an initial load is fine. This fix moves all place info initialization to clear_place_info, and calls it from the constructor. -------------------------------------------------------------------------------- be47a56 | Isaac Sloat | 2017-02-24 19:56:12 -0600 Improve the thermic engine vault (regret-index) Make syntax clearer, use NSUBST for monster distribution, and embiggen doors. -------------------------------------------------------------------------------- 905781e | Corin Buchanan-Howland | 2017-02-24 17:13:18 -0500 Fix an assignment-instead-of-evaluation bug (Brannock) -------------------------------------------------------------------------------- 494b376 | Corin Buchanan-Howland | 2017-02-24 16:17:40 -0500 Fix spacing on species menu some more -------------------------------------------------------------------------------- c9fbb92 | Corin Buchanan-Howland | 2017-02-24 15:50:48 -0500 Reduce the amount of space species selection takes up It might help with a web tiles / console bug I can't reproduce locally. -------------------------------------------------------------------------------- b8ae3f3 | Corin Buchanan-Howland | 2017-02-24 15:02:54 -0500 Tweak groups further (MarvinPA, ##crawl-dev) Renaming the groups further, moving Deep Dwarf down to the bottom of Intermediate, moving Halfling up to Beginner, and doing some light sorting within groups. -------------------------------------------------------------------------------- 37d8596 | Isaac Sloat | 2017-02-24 13:56:02 -0600 Alphabetize [skip ci] -------------------------------------------------------------------------------- a2ecc45 | Corin Buchanan-Howland | 2017-02-24 14:38:11 -0500 Adjust species group names and contents (PleasingFungus, ##crawl-dev) -------------------------------------------------------------------------------- 43cdf58 | Corin Buchanan-Howland | 2017-02-24 14:24:30 -0500 Refactor new game menu construct functions to allow species groups (minmay) The idea here is to make it easier for new players to choose which species they want to play. The groups I chose for V1 are based on the difficulty for a new player to learn the species, not overall species power or other attributes. I tried to rank by relative ease of learning within each group as well. Obviously this opens the door to discussion about whether these are the correct groups and how many groups there should be, but any future changes should be a lot easier with this infrastructure in place. The current groups are: "Beginner", SP_HILL_ORC, SP_MINOTAUR, SP_MERFOLK, SP_TROLL, SP_GARGOYLE, SP_BASE_DRACONIAN, SP_DEEP_DWARF, SP_HUMAN, SP_GHOUL, "Intermediate", SP_KOBOLD, SP_HALFLING, SP_DEMONSPAWN, SP_CENTAUR, SP_SPRIGGAN, SP_TENGU, SP_DEEP_ELF, SP_OGRE, SP_VAMPIRE, "Advanced", SP_VINE_STALKER, SP_DEMIGOD, SP_FORMICID, SP_NAGA, SP_OCTOPODE, SP_FELID, SP_BARACHIAN, SP_MUMMY, The old order is still in code as species_order in newgame.cc. For future reference, it is: // comparatively human-like looks SP_HUMAN, SP_DEEP_ELF, SP_DEEP_DWARF, SP_HILL_ORC, // small species SP_HALFLING, SP_KOBOLD, SP_SPRIGGAN, // large species SP_OGRE, SP_TROLL, // significantly different body type from human ("monstrous") SP_NAGA, SP_CENTAUR, SP_MERFOLK, SP_MINOTAUR, SP_TENGU, SP_BASE_DRACONIAN, SP_GARGOYLE, SP_FORMICID, SP_BARACHIAN, // mostly human shape but made of a strange substance SP_VINE_STALKER, // celestial species SP_DEMIGOD, SP_DEMONSPAWN, // undead species SP_MUMMY, SP_GHOUL, SP_VAMPIRE, // not humanoid at all SP_FELID, SP_OCTOPODE, -------------------------------------------------------------------------------- cc014f1 | chereshnev | 2017-02-24 11:37:28 -0600 Update CREDITS.txt (#476) Wrote my name more precisely. [skip ci] -------------------------------------------------------------------------------- 1de7011 | Isaac Sloat | 2017-02-24 11:24:27 -0600 Add SteelNeuron to CREDITS.txt and mailmap Thank you for all your work on the Wu Jian Council! [skip ci] -------------------------------------------------------------------------------- e594533 | PabloMansanet | 2017-02-24 11:04:49 -0600 Fix DEAD_MONSTER message prompt on wall jump -------------------------------------------------------------------------------- 02c9e3c | Corin Buchanan-Howland | 2017-02-24 11:36:06 -0500 Merge special buttons for background and species menus into one function -------------------------------------------------------------------------------- 05c1739 | Corin Buchanan-Howland | 2017-02-24 10:27:00 -0500 Merge _prompt_job and _prompt_species They were ~200 lines of identical code. -------------------------------------------------------------------------------- ab781cd | advil | 2017-02-23 23:52:05 -0500 Load saves where desolation is incorrectly global Some games transferred from pre-0.19 to post-0.19a will then save with desolation's place info incorrectly numbered as the global place slot, triggering an assertion failure on load. This patch loads these files without crashing; it limits the time-frame of this fix with a new minor tag. No one who has tried has been able to duplicate the save file corruption, though we have several saves that result from it, so the root cause may return or still be present. Fixes some saves found attached to 10696 and 10788. -------------------------------------------------------------------------------- 6bb112f | Doesnty | 2017-02-23 20:46:49 -0600 Add Cancel Portal Projectile ability (#471) Portal Projectile has a somewhat dubious side-effect of adding a 1 MP cost to every missile shot. While the spell is useful, its effect is not always desired for the full length of the effect. As the only way to rid oneself of this effect is to wait for the spell to time-out, high spellpower is sometimes bad as it extends the duration of the spell. This commit solves the problem by adding an ability to cancel the effect instantly. -------------------------------------------------------------------------------- b057e68 | ontoclasm | 2017-02-22 18:40:45 -0600 New WJC ability tiles -------------------------------------------------------------------------------- 7c16db2 | Chris Campbell | 2017-02-23 00:05:49 +0000 Fix spacing -------------------------------------------------------------------------------- d3249da | Chris Campbell | 2017-02-22 20:46:26 +0000 Fix wording -------------------------------------------------------------------------------- 514b03d | Chris Campbell | 2017-02-22 20:44:43 +0000 Rework Hepliaklqana ancestor info table -------------------------------------------------------------------------------- 50accb0 | Yer mivvaggah | 2017-02-22 10:14:41 -0600 correct Cerol's creation guides for new enums (#470) * correct Cerol's creation guides for new enums -------------------------------------------------------------------------------- f92fd71 | Neil Moore | 2017-02-22 00:31:37 -0500 Level up from the last !exp in a floor stack (advil, #10904) Background: To avoid an exploit where killing the game in the middle of levelling up from potion of experience gave you both the level and the potion, we deferred the call to level_change() until the very end of drink(), after using up the potion (decrementing its quantity). If the potion was the last one its the stack, that meant that we were checking the sub_type of a destroyed item (to see whether it was POT_EXPERIENCE). Fortunately, destroying an inventory item stack (with dec_inv_item_quantity) does not actually clear the sub_type. So as long as we didn't do anything between those two steps, things were fine, if somewhat fragile. Then someone went and added the ability to drink potions off the floor. Unfortunately, unlike its inventory cousin, dec_mitm_item_quantity *does* clear the sub_type (and everything else) of a destroyed stack... meaning we forgot that the potion was !exp and therefore never ended up calling level_change(). Fix this, and make the inventory case less fragile, by testing whether the potion was !exp before decrementing its quantity. The actual call to level_change() still comes afterwards. -------------------------------------------------------------------------------- 97c0b12 | Neil Moore | 2017-02-21 23:36:39 -0500 Fix levdes.vim syntax. [skip ci] -------------------------------------------------------------------------------- ecde0bf | Isaac Sloat | 2017-02-21 21:57:19 -0600 Less thermic spam (MarvinPA) I probably shouldn't have removed this in the first place, to be honest. Having it show up only occasionally is enough to reinforce the flavor, without bothering the player every single time they finish a combat. [skip ci] -------------------------------------------------------------------------------- 3277076 | Isaac Sloat | 2017-02-21 21:38:22 -0600 More thoroughly rename the Council (|amethyst) I forgot about ijc/IJC strings, oops. -------------------------------------------------------------------------------- 963469a | Isaac Sloat | 2017-02-21 21:33:21 -0600 Rename Ieoh -> Wu The god's name has been discussed multiple times, and the consensus seems to be that it's better, if we're going to use actual Chinese for the god's name, to not have nonsense Chinese mixed in. SteelNeuron originally intended the god to be named Wu Jian Council, so we're returning to that. -------------------------------------------------------------------------------- 23e1c25 | Neil Moore | 2017-02-21 19:58:21 -0500 Checkwhite [skip ci] -------------------------------------------------------------------------------- 9919a89 | Alex Jurkiewicz | 2017-02-21 19:57:55 -0500 Fix DD loading re: inhibited mutation rework And make inhibited regen a random bad mutation again. -------------------------------------------------------------------------------- b931024 | Nicholas Feinberg | 2017-02-21 15:13:45 -0800 Simplify tags.cc TAG_MAJOR_VERSION ifdefs -------------------------------------------------------------------------------- ad756b3 | Alex Jurkiewicz | 2017-02-21 15:09:15 -0800 fix comment -------------------------------------------------------------------------------- 4b0bcd1 | Alex Jurkiewicz | 2017-02-21 15:09:15 -0800 Change slow regeneration to a single level mut Only the second level remains (no regeneration in LOS of monsters), now named "inhibited regeneration". A new mutation "No Regeneration" is added, which is Deep Dwarf only. Ghouls used to get slow regeneration 1, now they receive inhibited regeneration 1, which is worse. :skull: The goal of this change was to remove the mostly ignorable slow regeneration 1 mutation. As well as this, slow regeneration 3 was crushingly bad on anyone but DD, and it wasn't very fun having the chance to get it much more likely if slow regeneration became a two level mutation. -------------------------------------------------------------------------------- f57855b | Nicholas Feinberg | 2017-02-21 14:45:05 -0800 Fix an ancestor name key type (chequers) Intentionally deadnaming him for proper shaming. Booooooooo! -------------------------------------------------------------------------------- 6618013 | Isaac Sloat | 2017-02-21 15:59:03 -0600 Even better thermic engine tiles (CanOfWorms) Now a double sword! -------------------------------------------------------------------------------- 7b2f801 | Isaac Sloat | 2017-02-21 14:16:05 -0600 Tie thermic engine depower to time passed Depowers at a consistent rate even when the wielder is slowed / hasted. Ensure it can't go below +2. -------------------------------------------------------------------------------- 8cd9b41 | Chris Campbell | 2017-02-21 20:04:00 +0000 Scale Singing Sword damage with time taken -------------------------------------------------------------------------------- 0c7a0cf | Chris Campbell | 2017-02-21 20:04:00 +0000 Remove the Flaming/Chilly Death unrands They got squished together into the thermic engine. (Neither of them was very interesting even with their sticky flame/flash freeze mechanics). -------------------------------------------------------------------------------- a6a8411 | Isaac Sloat | 2017-02-21 13:48:20 -0600 Allow the thermic engine to power up 19645da51d made it impossible for the sword to power up without ripostes. Whoops. -------------------------------------------------------------------------------- ff4dff1 | Isaac Sloat | 2017-02-21 13:12:56 -0600 Don't place unrand vaults in Pan (Doesnt) [skip ci] -------------------------------------------------------------------------------- 4fb63ed | Isaac Sloat | 2017-02-21 13:05:25 -0600 Add brannock_guarded_unrand_thermic_engine A vault that separates fiery and icy demons from each other to violate the Second Law of Thermodynamics! References https://en.wikipedia.org/wiki/Maxwell's_demon -------------------------------------------------------------------------------- 19645da | Isaac Sloat | 2017-02-21 13:05:20 -0600 Rapidly depower the thermic engine Used to take ~36 turns to power down fully. Now takes 12, losing a plus every turn that it's not used in combat. Encourages wielders to stay constantly engaged in combat for maximum effect. -------------------------------------------------------------------------------- d8828e9 | Isaac Sloat | 2017-02-21 13:05:16 -0600 Tiles for Maxwell's thermic engine (CanOfWorms) Spiffy! -------------------------------------------------------------------------------- df8f295 | olowin | 2017-02-21 13:04:05 -0600 New unrand: Maxwell's thermic engine A double sword with double the usual number of brands, applying freezing and flaming brands to its unfortunate victims. The engine revs up with each swing taken, intensifying from +2 to +14. (Closes #388.) -------------------------------------------------------------------------------- e118e6b | Chris Campbell | 2017-02-21 17:37:22 +0000 Adjust some form descriptions To use present tense consistently, as well as some minor wording tweaks. -------------------------------------------------------------------------------- f01b4e9 | Isaac Sloat | 2017-02-21 09:42:36 -0600 Capitalize the Council [skip ci] -------------------------------------------------------------------------------- 71b569a | Isaac Sloat | 2017-02-21 00:15:03 -0600 Spellcheck (Lightli) [skip ci] -------------------------------------------------------------------------------- d40821f | Alex Jurkiewicz | 2017-02-20 22:26:27 -0600 Simplify base UC damage for forms (minmay) Blade hands, statue form and dragon form all had base unarmed damage that scaled with strength (and dexterity, for blade hands). Remove this scaling and replace it with flat damage. Naive damage comparison, using the average stats of winning transmuters at various XLs: * XL10 (17str, 20dex) * XL15 (22str, 24dex) * XL20 (25str, 25dex) * XL27 (28str, 28dex) Blade Hands (10% more at XL10, 20% less at XL27): * XL10: Old: 20, New: 22 * XL15: Old: 23, New: 22 * XL20: Old: 25, New: 22 * XL27: Old: 27, New: 22 Statue Form (same at XL10, 20% less at XL27): * XL10: Old: 12, New: 12 * XL15: Old: 13, New: 12 * XL20: Old: 14, New: 12 * XL27: Old: 15, New: 12 Dragon Form (40% more at XL10, same at XL27): * XL10: Old: 23, New: 32 * XL15: Old: 27, New: 32 * XL20: Old: 29, New: 32 * XL27: Old: 31, New: 32 -------------------------------------------------------------------------------- fb6476c | Isaac Sloat | 2017-02-20 19:01:12 -0600 Add advil to credits and mailmap Thank you for all your contributions, advil! -------------------------------------------------------------------------------- 895272c | Alex Jurkiewicz | 2017-02-20 17:00:16 -0800 Break up enum.h This change should help speed up compilation when making changes to enums, since you won't have to recompile as much of the codebase. Also uses '#pragma once' instead of the more traditional '#ifndef MY_DEFINE_H' approach for the new files. A future commit will convert all files to use this guard style. -------------------------------------------------------------------------------- 4c9de2e | Kyle Rawlins | 2017-02-20 18:55:35 -0600 Noisebar tweaks (#466) This significantly cleans up the code for the noise bar and makes the behavior/appearance easier to adjust; now all the color and a lot of the sizing is done in just the css file based on two custom attributes. The appearance/behavior of the bar itself should be unchanged (give or take a few pixels), except for silencing. This commit also rolls in a cleanup/change in how silencing is displayed (PleasingFungus), as well as preventing a json information leak (gammafunk): exact noise values no longer leak outside of wizmode. It also changes Gozag money display to be lightgray instead of gold based on feedback in ##crawl-dev (31f7f79). -------------------------------------------------------------------------------- be8799e | Isaac Sloat | 2017-02-20 14:23:11 -0600 Replace mutation with cancellation in Holy Pan Zin does NOT approve of mutation! These were originally potions of cure mutation, and got overlooked in the great shift. Cancellation is more in keeping with the theme of 'cleansing' -- and it does reduce Contam, after all. -------------------------------------------------------------------------------- bbd08f1 | Isaac Sloat | 2017-02-20 13:55:48 -0600 Make Portal Projectile use Hexes As it's now in the Book of Debilitation, which is otherwise Hex-themed. Helps Arcane Marksmen transition into the spell. Possibly fits better as Charms/Translocations, but there's some thin connection here with Corona and PProj improving player accuracy, as well as with Spectral Weapon. I imagine the victims of this spell will feel effectively hexed when they're instantly skewered by arrows. -------------------------------------------------------------------------------- 16b016f | Isaac Sloat | 2017-02-20 13:55:48 -0600 Make Gell's Gravitas use Tloc only As it no longer confuses monsters, just moves them around. -------------------------------------------------------------------------------- ea68139 | Isaac Sloat | 2017-02-20 13:55:48 -0600 Swap Gravitas and Portal Projectile Arcane Marksmen now get access to Portal Projectile in the Book of Debilitation. Warpers get access to Gell's Gravitas in their starting Book of Spatial Translocations. This should help better unify the theme of both books and starts: Arcane Marksmen get access to spells that are focused around keeping the enemy away (Slow, Cause Fear, Liquefaction) and improving their ranged attacks (Corona, Inner Flame, Portal Projectile). All spells Warpers get now are focused on repositioning themselves or others. Gravitas wasn't very successful in the AM book since other spells already do what it does much more effectively and efficiently. Encouraging Warpers into ranged with Portal Projectile was kind of weird, given that that background should be item-agnostic for the most part. -------------------------------------------------------------------------------- 576ffe5 | Isaac Sloat | 2017-02-20 12:52:15 -0600 Clarify Fighting description (Yewbacca) Also removes all references to "hand-to-hand combat" in the Crawl manual. -------------------------------------------------------------------------------- bd4582c | Isaac Sloat | 2017-02-19 16:02:55 -0600 Merge pull request #468 from Doesnty/deeptroll3 Deep trolls and iron trolls drop blue and gray hides. -------------------------------------------------------------------------------- f4eee11 | Doesnt | 2017-02-19 15:48:47 -0600 Deep trolls and iron trolls drop blue and gray hides. -------------------------------------------------------------------------------- 05b73b7 | Chris Campbell | 2017-02-19 21:06:49 +0000 Adjust some Ieoh Jian descriptions -------------------------------------------------------------------------------- 046a0a6 | Chris Campbell | 2017-02-19 21:06:49 +0000 Generalise some god descriptions Fixes the information being missing for IJC and Ru (and also makes the IJC description too long for 80x24!) -------------------------------------------------------------------------------- 12fdf77 | Neil Moore | 2017-02-19 14:03:13 -0500 Simplify. Return an object directly rather than making a variable; convert an if/else into a ternary expression; and avoid a string literal with magic amounts of whitespace. -------------------------------------------------------------------------------- 5f0ea47 | Neil Moore | 2017-02-19 14:03:12 -0500 Fix formatting. Mostly regarding braces around blocks, functions, and classes / structs / enums. -------------------------------------------------------------------------------- b4dbc05 | Neil Moore | 2017-02-19 14:03:11 -0500 Add -edit-save default output file to .gitignore. [skip ci] -------------------------------------------------------------------------------- 50be3de | Neil Moore | 2017-02-19 14:03:11 -0500 Restore new sqlite contrib version. Reverted in the IJC merge. -------------------------------------------------------------------------------- 0c5bb27 | PabloMansanet | 2017-02-19 09:41:24 -0800 New god: the Ieoh Jian Council -- Gameplay Niche -- IJC is a god based on mobile melee combat, offering strong incentives to fight groups of enemies in the open. It provides melee characters with a strong but relatively flat power increase in the form of special attacks triggered by moving, and offers effective positioning tools to hybrids and ranged characters. IJC is different from other melee focused gods in that its active abilities are unlocked late and lacks any permanent gifts. It is instead focused on offense and constant mobility. Its associated brand is Speed, and to a lesser extent Flaming and Electrocution. -- Theme -- IJC is a council of formerly mortal monks. The theme draws heavily from Chinese imagery and traditional Chinese martial arts in particular. -- Powers -- The god revolves around three "martial attacks" and the interactions between them. The player is incentivized to use these special attacks in difficult fights, and they're designed to prevent any of the three from being overcentralizing or optimal for any particular build. Below is a brief description of each of them, and the justification for each particular effect. Lunge: Triggered by moving towards an enemy. Deals extra damage against slowed or distracted enemies. * It is important that constantly luring and lunging against full-speed monsters isn't optimal; hence, Lunge doesn't impart any status effect, and instead exploits monsters who are already unable to kite effectively. Whirlwind: Triggered by moving from a tile adjacent to an enemy to another tile adjacent to it. Can cause slow. * Whirlwind is the most spammable of the moves, so it is assigned a non-stacking, longer duration debuff so players are incentivized to improvise once the effect triggers. The slow lasts around six turns. Wall Jump: Triggered by moving against a solid obstacle. It propels the character two tiles in the opposite direction, attacking in an area of effect. Can cause a brief distraction to onlookers. * Wall Jump provides the most benefit in terms of positioning and escape, while being the least spammable, and as such is assigned a shorter duration, more tactical debuff (1-3 turns). There isn't a 1-to-1 relation between moving and attacking. Instead, moving causes the player to trigger the appropriate martial attack a number of times, that averages out to the same number of attacks per aut as normal tabbing (thanks to weighted rounding). After the three moves are unlocked, the player unlocks two active abilities. Serpent's Lash: Instant ability with Exhaustion and a moderate Piety cost. Causes your next two movement actions to be instant, and boosts your martial attacks during them. Serpent's Lash can be used as a simple escape, but given how the geometry of the level affects Wall Jump, it's generally more efficient to use martial attacks even when running away, which combines well with the kit. Heaven on Earth: Summons a storm of golden clouds. Provides a hefty Slaying bonus and constantly triggers a powerful opaque fog, reducing visibility and protecting against ranged monsters. The storm is very short lived, but continuing to use martial attacks against multiple enemies refreshes the duration and increases the slaying bonus. It can last indefinitely if the player is able to stay in combat against multiple enemies in the open. Heaven on Earth has explicit synergy with Serpent's Lash, as the latter will prevent the storm from decaying while allowing the player to build it back up quickly. -------------------------------------------------------------------------------- 71b7943 | Chris Campbell | 2017-02-19 12:11:04 +0000 Merge pull request #463 from lischenko/to-to Fix a few typos in docs and source -------------------------------------------------------------------------------- 944838a | Vitaly | 2017-02-18 23:13:44 -0800 Fix a few typos in docs and source Duplicated "to", for example: "Select a spell to read its description or *to to* memorise it" -------------------------------------------------------------------------------- 860b9ab | Chris Campbell | 2017-02-18 18:29:00 +0000 Update some slow/exhaustion comments -------------------------------------------------------------------------------- 05e1fd3 | Chris Campbell | 2017-02-18 18:29:00 +0000 Update some descriptions for spells with cooldowns -------------------------------------------------------------------------------- 5abc3fc | Nicholas Feinberg | 2017-02-18 08:37:33 -0800 Refactor get_noise_perception(), again Avoid state, above all else! -------------------------------------------------------------------------------- b4b6995 | advil | 2017-02-18 16:09:55 +0000 Fix display on excommunication There was an implicit else case that I had missed when the player worships GOD_NO_GOD. This restructures the if to be nested, which I think is much clearer for what needs to happen here. (Closes #462 PR) -------------------------------------------------------------------------------- de5e835 | Chris Campbell | 2017-02-18 16:09:55 +0000 Fix some wizmode gold change issues To correctly redraw the gold display, print a message showing your new gold amount, and to prevent negative gold. -------------------------------------------------------------------------------- 7852e39 | Chris Campbell | 2017-02-18 16:09:55 +0000 Adjust colouring of Gozag gold display To use the standard lightgrey for the value. -------------------------------------------------------------------------------- d0eeda6 | Chris Campbell | 2017-02-18 16:09:55 +0000 Don't allow time step to have a 0 turn duration If for some reason you use it with no invocations skill. Also refactor slightly. -------------------------------------------------------------------------------- 666c526 | Neil Moore | 2017-02-18 10:15:06 -0500 Checkwhite for "French" spacing. [skip ci] -------------------------------------------------------------------------------- f83e07f | Nicholas Feinberg | 2017-02-17 21:06:04 -0800 Fix webtiles, hopefully (advil) -------------------------------------------------------------------------------- 5c496f5 | Nicholas Feinberg | 2017-02-17 20:01:55 -0800 Fix noise meter + temporal distortion (advil) Advil's code, actually! I'm just pushin' it -------------------------------------------------------------------------------- b4e6d0e | Nicholas Feinberg | 2017-02-17 19:34:03 -0800 Fix noise breakpoints (advil) -------------------------------------------------------------------------------- 4c2ed67 | advil | 2017-02-17 19:15:25 -0800 Remove redundant status light for silence This is displayed as part of the noise meter. Closes #454. -------------------------------------------------------------------------------- cc4efd4 | advil | 2017-02-17 19:15:15 -0800 Add a noise meter to the HUD Noise is one of the more complicated systems in dcss, yet it's barely represented in the UI. This is partly because there's just so much information to represent. This commit attempts to partially solve this problem by providing a very simple UI element that summarizes noise heard by the player during the last turn in the form of a meter. This meter peaks at the loudest noise audible at the player's position during that turn, and will switch between several different colors (details vary slightly for different interfaces), described below. I chose to use sound that has propagated to the player, so more distant events will be attenuated by distance and dungeon features -- the idea is to give a measure as to how likely things are to move towards the player's position. While experienced players may have internalized a lot of this, most of this information is not at all apparent to less experienced players, and I think this UI element is potentially extremely useful (as opposed to clutter). 1. lightgray: the noise level at the player's position is within a range that makes it unlikely to propagate outside the player's los (though this can happen depending on terrain). Or more simply: this noise is probably basically ok. Most low-medium melee damage is in this category, as are most low-damage spells. 2. yellow: the noise heard at the player's position is likely to propagate outside the player's los, up to twice the los radius. Or more simply: this noise is bad. Shouting, distant fireballs, high damage melee attacks, high damage spells (e.g. many bolt spells), door creaks are in this category. longbows and bigger crossbows are on the border of this category. 3. red: the noise is like to be heard at a substantial distance, on an open level more than 2x the los radius. Or more simply: this noise is very bad. This category includes howler monkeys, lightning bolt, nearby fireballs, qazlal at pieties above ****. (Though thunder clouds may randomly produce red noise at nearly any piety.) 4. lightmagenta: these sounds are off the meter, the loudest sounds you can make. Includes: shatter, gong, ood collision, orb apport/pickup Potential issues/complications: * This implementation uses a heuristic for branch noise adjustment that is kind of hacky. A better (but much more complicated) solution might be to sample noise at various distances directly from the noise grid. Right now I just use a constant addition or subtraction to model the effects of branch noise; in e.g. shoals or crypt this will push some of the category boundaries for colors around. * An alternative approach would be to not use attenuated noise at all, but find the loudest noise (before propagation) in the player's los. * In wizmode there is also a numeric version of the meter displayed, but I decided this is too uninterpretable to be useful to players. (But, the heuristic for normal noise branches is: in a completely open area a sound of loudness l will propagate approximately l/.85 spaces.) * exposing this to the player may reveal some cases where it is not entirely intuitive that no sound is made. (For example, berserking is silent (but unstealthy) except when opening doors.) This is good! The noise bar replaces gold in the HUD; Gozagites now have gold where the piety bar would be. -------------------------------------------------------------------------------- 7b9d119 | Neil Moore | 2017-02-17 18:45:51 -0500 Checkwhite. [skip ci] -------------------------------------------------------------------------------- f8c7c87 | Neil Moore | 2017-02-17 18:23:52 -0500 Simplify with C++11. -------------------------------------------------------------------------------- b4a80f0 | Neil Moore | 2017-02-17 18:23:28 -0500 Even better mesmerisation pronouns. Look up the correct pronoun for the monster in question, since Jory exists I'm not sure where this message actually appears, though. It's not in xv, ctrl-x, or the x "Here:" short desc, though the latter two do indicate the status with other wordings. -------------------------------------------------------------------------------- 53087c7 | Chris Campbell | 2017-02-17 20:06:05 +0000 Simplify a Beogh/Yred wrath check Don't check piety, penance, invocations and monster HD for Beogh/Yred ally abandonment checks under penance - just roll monster HD. Makes keeping hold of higher-HD allies pretty substantially more likely under Beogh/Yred penance (where the previous check was likely to fail even with full piety and 27 invocations). -------------------------------------------------------------------------------- d6c3c51 | Nicholas Feinberg | 2017-02-16 20:53:35 -0800 Set auto_butcher = 'very hungry' by default (MPA) A compromise between reasonable behaviour for most characters & for those which have other uses for corpses (necromancers, Fedhasites); consistency and an absence of surprises. -------------------------------------------------------------------------------- d9671f9 | Nicholas Feinberg | 2017-02-16 20:43:30 -0800 Ignore adjacent enemies for Beckoning (Yermak) It's not very useful to beckon adjacent enemies, so make the targeter ignore them. -------------------------------------------------------------------------------- 363ecfa | Nicholas Feinberg | 2017-02-16 20:43:30 -0800 Anger allies with Poisonous Vapours (worldfamousw) Monsters weren't annoyed at all when you poisoned them to death, which seems a bit off. -------------------------------------------------------------------------------- e36c403 | Nicholas Feinberg | 2017-02-16 20:43:30 -0800 Rephrase elec trigger message "Explosion of sparks" is perhaps not ideal, since it's no longer loud. Instead, say that "lightning courses through the goblin!" (Apologies to whoever suggested this - I didn't remember to note down your name!) -------------------------------------------------------------------------------- e386282 | Nicholas Feinberg | 2017-02-16 20:43:30 -0800 Remove a stray trace of gender Since sirens/avatars aren't guaranteed female anymore. -------------------------------------------------------------------------------- cb9eda4 | Nicholas Feinberg | 2017-02-16 20:43:30 -0800 Improve frog superhealing Cure -Hop with wizmode super healing. -------------------------------------------------------------------------------- fe9ca37 | ontoclasm | 2017-02-16 20:35:39 -0600 Scarf tiles The player doll tiles still need to be hooked up, as they require their own doll part. -------------------------------------------------------------------------------- 4f99a5f | Nicholas Feinberg | 2017-02-16 17:38:08 -0800 Restore Put-Me-On With a handsome new set of hyphens, to add some class. Also, tweak name weights to account for added/removed names. -------------------------------------------------------------------------------- 389645f | Chris Campbell | 2017-02-17 01:33:10 +0000 Trim some randart names -------------------------------------------------------------------------------- b436c4a | Isaac Sloat | 2017-02-16 19:16:28 -0600 A few randart names (yrmvgh) Also slightly increases weight for armour names. -------------------------------------------------------------------------------- 4091c3c | Isaac Sloat | 2017-02-16 18:57:15 -0600 Merge pull request #456 from alexjurkiewicz/ossuary-alarm Remove alarm traps in ossuary_tomb_3 -------------------------------------------------------------------------------- 4639c04 | Kyle Rawlins | 2017-02-16 19:37:39 -0500 Ensure viewwindow is called in the input loop for instantaneous actions (PR #448) Ensure viewwindow is called in the input loop for instantaneous actions This specifically addresses 10314, where shoals wave/beach tiles weren't being updated after temporal distortion. Temporal distortion results in `you.turn_is_over` being false at this point in the loop, but apparently `viewwindow` needs to be called at this specific time to get the waves right. For non-instantaneous actions, `viewwindow` is called as part of `world_reacts`. -------------------------------------------------------------------------------- 859e9cd | Gregory Chereshnev | 2017-02-16 19:33:32 -0500 Add Void Linux prerequisites to INSTALL.txt (PR #460) Void Linux prerequisites have been added. -------------------------------------------------------------------------------- 02b20f4 | Chris Campbell | 2017-02-16 21:03:02 +0000 Simplify expiry of TSO Divine Shield Make it expire like a regular duration instead of fading away in an extremely complicated way. It keeps the same average duration (with the previous weirdness factored in). -------------------------------------------------------------------------------- cb8b9f6 | Chris Campbell | 2017-02-16 20:47:15 +0000 Adjust message colouring for a warning -------------------------------------------------------------------------------- 9b0dcd9 | Nicholas Feinberg | 2017-02-15 20:29:24 -0800 Increase Barachian stats to human levels Since they seemed to be a fairly weak species overall; this was not intended. The low stats were generally considered the least fun part of their design, so there's no reason to keep em around. Currently their stats are slightly skewed toward str and away from dex, entirely for flavour, since they're supposed to be an awkward, slow-moving race. -------------------------------------------------------------------------------- 4bc97ff | Isaac Sloat | 2017-02-15 18:55:35 -0600 Merge pull request #451 from rawlins/ash-id-stacks Have ash id stacks when standing on them (10580) -------------------------------------------------------------------------------- e0c4e5a | Alex Jurkiewicz | 2017-02-15 18:50:05 -0600 Remove some too-common ancestor names Thanks, Persian friend! -------------------------------------------------------------------------------- 036a0c5 | Alex Jurkiewicz | 2017-02-15 18:17:07 -0500 Remove teleport closets from chequers_ecumenical_altar_grove (#458) As per https://youtu.be/HAh6o6-98_4?t=5m54s -------------------------------------------------------------------------------- 496bc70 | Neil Moore | 2017-02-15 18:08:31 -0500 Don't risk making text blink (advil) Turn off best_effort_brighten_background by default, since that can make things blink on terminals (such as OS X terminal) that do blinking rather than 16-colour backgrounds. -------------------------------------------------------------------------------- d54866b | Isaac Sloat | 2017-02-15 15:42:33 -0600 Better place makeitem.cc comments (|amethyst) [skip ci] -------------------------------------------------------------------------------- d69f00c | Isaac Sloat | 2017-02-15 15:39:55 -0600 Add god_creation.txt (Cerol) All hail Ralph. -------------------------------------------------------------------------------- f56736b | Isaac Sloat | 2017-02-15 14:03:33 -0600 Reduce frequency of !Mutation From 8% of all potions to 6%, very roughly. Total weight has been reduced by 20 but this has a very minimal impact on frequency of other potions. (Overall potion frequency isn't affected.) Also add a comment explaining an unclear condition. This is unused code and could be removed, but maybe one day Xom will consider a potion boring? -------------------------------------------------------------------------------- f178af5 | Isaac Sloat | 2017-02-14 15:24:50 -0600 Merge pull request #453 from alexjurkiewicz/hepl-names Add Zulu, Arabic and Slavic ancestor names -------------------------------------------------------------------------------- 0ac6e19 | chereshnev | 2017-02-14 10:29:49 -0500 Remove an obsolete mailmap entry (#455) I removed my old username and email, because they are obsolete :) -------------------------------------------------------------------------------- 801678d | Glenn Matthews | 2017-02-14 10:23:08 -0500 Don't call get_armour_slot until we know it's an armour item. (#457) Fixes issue 10940 introduced by #423 -------------------------------------------------------------------------------- dc5f830 | Neil Moore | 2017-02-14 10:19:54 -0500 Fix Android cprintf security bug (#10941). If the player's weapon or quiver inscription contains a percent sign, bad things could happen. -------------------------------------------------------------------------------- 4ff03ff | Chris Campbell | 2017-02-13 23:03:44 +0000 Update some default message colouring To remove some obsolete and duplicate entries. -------------------------------------------------------------------------------- 618f40d | Alex Jurkiewicz | 2017-02-13 23:45:00 +1100 Remove alarm traps in ossuary_tomb_3 They were after the player had dealt with (nearly) all monsters in the portal, and the portal is small enough there's no real need to move them earlier. -------------------------------------------------------------------------------- 673355a | Neil Moore | 2017-02-12 13:18:49 -0500 Don't crash when xv-ing polymorphed multi-book casters. If a monster had multiple possible spellbooks and we tracked its seen spells, and that monster is then polymorphed into a spell-less monster, xv on the polymorphed monster would cause a crash. See for example: https://webzook.net/soup/morgue/trunk/LordPiggish/crash-LordPiggish-20170209-030 657.txt Avoid this by (1) clearing the seen spells on polymorph; and, to handle monsters that had already been polymorphed before this fix, (2) clearing the seen spells pop on load of a monster with no spells. -------------------------------------------------------------------------------- 6a0f426 | Alex Jurkiewicz | 2017-02-12 23:45:00 +1100 Add Zulu, Arabic and Slavic ancestor names -------------------------------------------------------------------------------- 62ed22f | Corin Buchanan-Howland | 2017-02-11 20:37:03 -0500 Add MP Regen to % menu There's open space there and just having health regen felt incomplete. -------------------------------------------------------------------------------- dbd815e | Corin Buchanan-Howland | 2017-02-11 20:05:28 -0500 Refactor player MP regen rate into its own method The place where rounding happens has changed a bit, but it shouldn't be significant. -------------------------------------------------------------------------------- d210ae2 | Neil Moore | 2017-02-11 16:12:40 -0500 Make scarves white rather than lightcyan in console. -------------------------------------------------------------------------------- edbf995 | Chris Campbell | 2017-02-11 19:09:10 +0000 Mark potions of cure/beneficial mutation as removed items (Lasty) Fixes them still appearing in the list of unidentified items. -------------------------------------------------------------------------------- 32200f4 | Neil Moore | 2017-02-11 12:43:47 -0500 Formatting fixes. [skip ci] -------------------------------------------------------------------------------- fd5dd0a | Koushik Roy | 2017-02-11 12:43:06 -0500 FreeBSD Compilation Changes (PR #439) * Initial cut at building with clang on FreeBSD * Clean up FreeBSD Changes Clean up the FreeBSD Changes * Revert the changes to Doxygen scripts * Remove debug statements from rltiles Makefile * PR Feedback -------------------------------------------------------------------------------- d5ac1e5 | Neil Moore | 2017-02-11 10:13:45 -0500 Make ossuary_boxes_badplayer wall removal a one-shot. So players don't get the "There is a click" message more than once. -------------------------------------------------------------------------------- ff4aa5c | Neil Moore | 2017-02-10 21:35:19 -0500 Checkwhite, (un)brace, and fix some K&R braces. -------------------------------------------------------------------------------- 68019b6 | Neil Moore | 2017-02-10 21:19:44 -0500 Honestly make this whole thing a closure. That is, make _collect_foe_position in mon-tentacle.cc take a function<> for its sight_check parameter rather than being templated; and use lambdas in its callers, rather than a static function in one place and a callable class in another. Also remove the mons argument of sight_check and make it a capture of said lambdas, since that argument was constant throughout a single call to _collect_foe_position. Constify while we're at it. -------------------------------------------------------------------------------- 6870b83 | Chris Campbell | 2017-02-10 19:33:08 +0000 Fix a swiftness message -------------------------------------------------------------------------------- d2958cf | Chris Campbell | 2017-02-10 19:28:01 +0000 Adjust @ messages, deduplicate some code -------------------------------------------------------------------------------- c37eb77 | Isaac Sloat | 2017-02-09 20:32:56 -0600 Allow tentacle ends as Ignition targets (minmay) -------------------------------------------------------------------------------- c61b052 | Isaac Sloat | 2017-02-09 19:54:40 -0600 Merge pull request #449 from glennmatthews/more-item-name-fixes Several is_useless_item() fixes -------------------------------------------------------------------------------- e33a6fd | Isaac Sloat | 2017-02-09 19:47:55 -0600 Don't let Ignition target firewood or tentacles They can still be affected for the spell, they just won't count as additional sources of blasting. -------------------------------------------------------------------------------- 89ae762 | advil | 2017-02-09 20:10:33 -0500 Have ash id stacks when standing on them (10580) Previously, `god_id_item` was called only from a distance, and then only on the top item of the stack, so items not at the top of the stack would not be id'd when you move onto their square. This fix ids the whole stack when you stand on it if appropriate. This may overcall `god_id_item` but I haven't spotted any detrimental effects. Addresses 10580, 10919. -------------------------------------------------------------------------------- a843dd6 | Isaac Sloat | 2017-02-09 18:44:39 -0600 Fix a few typos (KenranThePanda) [skip ci] -------------------------------------------------------------------------------- af3b657 | Isaac Sloat | 2017-02-09 11:55:10 -0600 More implementation guides by Cerol I wonder if this will lead to more forks...? -------------------------------------------------------------------------------- 6a86534 | Glenn Matthews | 2017-02-09 00:19:19 -0500 is_useless_item: LSTATE_STILL_WINDS is temporary Checks for LSTATE_STILL_WINDS were missing the 'temp' check, meaning that while Still Winds is in effect, the game incorrectly assumed that scroll of fog and wand of clouds were permanently useless. -------------------------------------------------------------------------------- 2e58d04 | Glenn Matthews | 2017-02-09 00:16:23 -0500 is_useless_item: check racial_permanent_flight too Temporary flight items (potion, ring) are useless if you have the ability to permanently fly as a racial ability, whether or not flight is active at this very moment. Previously, these items would toggle uselessness depending on whether you are currently flying. -------------------------------------------------------------------------------- 01f5896 | Isaac Sloat | 2017-02-08 20:13:04 -0600 Rearrange potions.cc slightly Moves the code for Degeneration to *before* the big block of removed potions. -------------------------------------------------------------------------------- b9e5f3f | Isaac Sloat | 2017-02-08 20:13:04 -0600 Rework the Potion of Mutation Shove Mutation, Cure Mutation, and Beneficial Mutation into a blender. The new !Mutation will strip 2-6 mutations, add 1-3 random mutations, then add one good mutation... in that order. It takes the spawn weights of all three previous potions, and thus is now the third most common potion in the game. (On average, ~17 will spawn in a three-rune victory.) This is subject to further change and balancing. === Gameplay effects: Once a character is mutated, then that character is permanently involved in the mutation game unless they worship Zin, because the new potion will only replace their current (mal)mutations. There is a reasonably decent chance (~39%) to acquire only good mutations. Because the new potion removes more mutations than it adds, players won't be able to gather large mutation sets without consuming the meat of mutagenic monsters. Ugly things are on the menu tonight! === A brief explanation of the philosophy behind this change: The current status of Crawl's mutation game is essentially solved: if you get malmutations, quaff Cure Mutation. If you find Beneficial Mutation, quaff it. If you're feeling lucky, or if you absolutely need to get rid of a certain malmutation and are out of Cure Mutation, then quaff Mutation. These choices are not very interesting. Cure Mutation in effect becomes a tax paid for making positioning mistakes against malmutators, and when they run out of !cmut, then for some players malmutators become top priorities, with a risk of 'permanently ruining' their character if they become too malmutated. Since the new potion generates frequently, for now, it ensures that the player will usually have the option to reroll their mutations if they get a set that they decide that they don't want to play with. The decision to reroll is also no longer binary: each mutation set is evaluated in the context of the character's abilities and strengths, and the player will decide "Is it worth risking getting something worse or better?" (Compare the Cure Mutation decision described above.) It creates a mutation baseline for most characters: at least two mutations in any given game (unless they were lucky / savvy enough to never be malmutated, and Zin-ite enough to never succumb to the purple temptation!), and likely 3+. The goal is to increase player control and interaction with the mutation mechanic, and to generate more relevant and interesting decisions that will differ on a character-by-character (or even mutation-by-mutation) basis. === New mutations, good and bad alike, will probably be added to the game. Keep an eye out! Potions of Cure Mutation and Beneficial Mutation have been removed. Most vaults containing Cure/Beneficial potions have been converted to Mutation, or another suitably good item. -------------------------------------------------------------------------------- fc38d6b | Isaac Sloat | 2017-02-08 17:26:20 -0600 Add Cerol to CREDITS.txt -------------------------------------------------------------------------------- 2d7de33 | Isaac Sloat | 2017-02-08 17:26:20 -0600 Add background creation guide (Cerol) -------------------------------------------------------------------------------- bb8d3ca | Nicholas Feinberg | 2017-02-08 10:58:43 -0800 Changelog through 0.20-a0-617-g89cf17a This is probably a bit too verbose, particularly wrt unrands; might be worth a second pass to trim things down at some point. -------------------------------------------------------------------------------- 89cf17a | Nicholas Feinberg | 2017-02-08 10:18:25 -0800 Add Unrand Lore Add some Flavour to bland unrand descriptions. Spice it up! -------------------------------------------------------------------------------- ad7b6bd | Isaac Sloat | 2017-02-08 11:51:35 -0600 Make Ignorance slightly less ignorant Drop the AC, reduce the Int penalty, and boost the SH value. This should make it more of a choice for non-Chei characters; the old Int malus was usually too punishing to be worth considering. -------------------------------------------------------------------------------- f59e5ab | Alex Jurkiewicz | 2017-02-08 11:34:43 -0600 Add chequers_guarded_unrand_mask_of_the_dragon A Zot vault full of dragons, ghost moths (hopefully not too cute as a SInv reference) and draconians. -------------------------------------------------------------------------------- f0b4e37 | Alex Jurkiewicz | 2017-02-08 11:34:07 -0600 Add chequers_guarded_unrand_ignorance A simple vault filled with int-feeding ocs. Taking them out one at a time is difficult! -------------------------------------------------------------------------------- 92415a4 | Chris Campbell | 2017-02-08 07:15:38 +0000 Remove some obsolete RMsl handling Since there are no permanant sources of DMsl, and now no temporary sources of RMsl. -------------------------------------------------------------------------------- 95306a3 | Nicholas Feinberg | 2017-02-07 21:58:28 -0800 Mark Talos's description for removal Since it was removed! -------------------------------------------------------------------------------- 5ffda9c | Nicholas Feinberg | 2017-02-07 20:46:19 -0800 Improve monster AI wrt stationary enemies Monsters should now attack e.g. prisms & spires that are in their way, instead of treating them as permanent obstacles and pathing around them. -------------------------------------------------------------------------------- 3ff0d92 | Nicholas Feinberg | 2017-02-07 20:46:19 -0800 Remove an obsolete FIXME RIP I_HIGH... -------------------------------------------------------------------------------- 37946a9 | Isaac Sloat | 2017-02-07 19:42:14 -0600 Reduce Ignition's damage Playtesting showed the original was overwhelmingly powerful against large crowds. Even with less damage, this version is potent. -------------------------------------------------------------------------------- ab1b74e | Andrew Minton | 2017-02-07 19:42:14 -0600 Replace Delayed Fireball with new spell: Ignition This level 8 Fire spell drops a fireball-like explosion on every monster in LOS. The explosions don't affect the player or allies. The spell is strong against monsters adjacent to one another (as each monster gets hit multiple times) but bad against single targets. Currently the damage per fireball is the same as the regular Fireball spell. Ignition replaces Delayed Fireball in the book of Fire, and Fireball in the book of the Tempests. -------------------------------------------------------------------------------- 9e3d16c | Nicholas Feinberg | 2017-02-07 16:40:09 -0800 Reduce the cost of ego (Brannock) Drop the added cost for un-id'd ego items in shops to less than that of un-id'd artefacts. -------------------------------------------------------------------------------- ca13456 | Chris Campbell | 2017-02-07 21:58:51 +0000 Adjust Conjurer and Air Elementalist spellbooks Replace Battlesphere in the book of Conjurations with Force Lance, as Battlephere tended to overwhelm use of the book's other interesting spells like Fulminant Prism, and Force Lance potentially has some interaction with knocking enemies back into the Prism's range, for example. Also replace the newly-added Summon Lightning Spire in the book of Air with Airstrike, since again the summon spell would be likely to become the major focus of the book. Airstrike's relatively low damage means the existing spells such as Static Discharge and Lightning Bolt should still be important. -------------------------------------------------------------------------------- 56b4ea9 | Chris Campbell | 2017-02-07 21:55:59 +0000 Don't make generation chance for robe of the Archmagi depend on depth Since no other egos do, instead just give them the same chance as robes of resistance. Shouldn't make a large difference overall, but makes them slightly more common early, and slightly rarer later. Also simplify some weightings. -------------------------------------------------------------------------------- 3869b3f | Isaac Sloat | 2017-02-07 15:39:52 -0600 Fix dream sheep messaging out-of-LOS (CanOfWorms) -------------------------------------------------------------------------------- b74b895 | Isaac Sloat | 2017-02-07 15:10:20 -0600 Merge pull request #444 from Doesnty/wand-id-pickup Hack to make unidentified wands respect auto-pickup settings -------------------------------------------------------------------------------- 3ae50c8 | Doesnt | 2017-02-07 12:58:49 -0600 Hack to make unidentified wands respect auto-pickup settings -------------------------------------------------------------------------------- 29d1f57 | Isaac Sloat | 2017-02-06 21:59:22 -0600 Merge pull request #443 from Doesnty/wand-id Identify wands when the player steps on them. -------------------------------------------------------------------------------- 99f07ad | Doesnt | 2017-02-06 20:54:12 -0600 Identify wands when the player steps on them. -------------------------------------------------------------------------------- 16ea627 | Neil Moore | 2017-02-06 18:38:37 -0500 Fix wrong DD ability in A and % screens (Darth_Ra + lepidopteraptor) They both listed the old recharge devices ability. -------------------------------------------------------------------------------- ff0730c | Neil Moore | 2017-02-06 18:31:25 -0500 Add and use armour_is_enchantable. To avoid checking for QDA || scarf in four different places. -------------------------------------------------------------------------------- ec00970 | Chris Campbell | 2017-02-06 23:12:39 +0000 Fix some bracing -------------------------------------------------------------------------------- 78597c5 | Isaac Sloat | 2017-02-06 17:00:17 -0600 One more scarf special case (MarvinPA) -------------------------------------------------------------------------------- 7a846bb | Isaac Sloat | 2017-02-06 16:45:48 -0600 Ensure scarves always generate magical I knew I forgot something!! Also includes some minor code cleanups. -------------------------------------------------------------------------------- 93522cc | Isaac Sloat | 2017-02-06 16:04:07 -0600 Keep hats 50% normal Removing spirit shield meant that plain hats spawned slightly too often; now the weights are fixed. -------------------------------------------------------------------------------- 8f76d39 | Chris Campbell | 2017-02-06 21:01:29 +0000 Mark Recall as useless under Sacrifice Love -------------------------------------------------------------------------------- 148c38f | Chris Campbell | 2017-02-06 20:56:24 +0000 Fix compilation -------------------------------------------------------------------------------- 1faf7d2 | Chris Campbell | 2017-02-06 20:50:54 +0000 Remove some obsolete FAQ entries -------------------------------------------------------------------------------- 990d402 | Chris Campbell | 2017-02-06 20:50:22 +0000 Remove some references to the prayer command -------------------------------------------------------------------------------- 6ba4ff0 | Chris Campbell | 2017-02-06 20:42:30 +0000 Give a message when praying at your current god's altar Since otherwise there's no feedback at all - on any other type of terrain a message is printed, but giving the "You can't go up/down here!" message would be misleading since those are still valid commands for other altars. -------------------------------------------------------------------------------- 7346924 | Chris Campbell | 2017-02-06 20:42:30 +0000 Don't let fungus form wear hats or helmets b5556e9b5b39 attempted (and failed) to fix the original inconsistent behaviour, but due to interactions between the form size and the item types, it was possible to wear helmets without them being melded, but not to equip one after already having transformed. The simpler approach of just preventing headwear entirely is probably better. -------------------------------------------------------------------------------- 0cf97a2 | Isaac Sloat | 2017-02-06 13:53:08 -0600 Move RMsl to the back of the line Since both RMsl and DMsl are very stable statuses now, put them at bottom priority for statuses -- they don't need to be monitored as closely as other, less temporary statuses. Might cause issues with some players not knowing when DMsl deactivated, if they don't have a catch set up for the message and they consistently have so many statuses that it pushes DMsl off the edge. This seems like a very rare occurrence, though. -------------------------------------------------------------------------------- c42f4fd | Isaac Sloat | 2017-02-06 13:53:08 -0600 Recognize scarf RMsl as permanent -------------------------------------------------------------------------------- 36bb54c | Isaac Sloat | 2017-02-06 13:53:08 -0600 Exfoliate dead RMsl code (MarvinPA) -------------------------------------------------------------------------------- 0350dfc | Isaac Sloat | 2017-02-06 13:53:08 -0600 Remove spirit shield from hats It's not good to have too many sources of Guardian Spirit, and this ego fits magical-defense-scarves better than it does hats, imho. Hats might need a new ego to round out their set... -------------------------------------------------------------------------------- 7bdf295 | Isaac Sloat | 2017-02-06 13:53:07 -0600 Introduce a new armour ego: Repulsion This solves the Repel Missiles problem (explained in earlier commits) by tying the effect to an equipment slot. Scarves only. Want RMsl? Wear the scarf of repulsion. Wanted to wear something else instead in that slot, like a randart or something that has AC? Maybe that'll be an interesting decision, and further it's one that takes committment since swapping out equipment slots takes longer than switching around jewelry. You feel repulsive. -------------------------------------------------------------------------------- 2e61058 | Isaac Sloat | 2017-02-06 13:53:07 -0600 Move Lightning Spire from Sky into Air Takes a spell out of the overloaded Book of the Sky and puts it into the Book of Air which'd suffered from the loss of Repel Missiles. Lightning Spire keeps in theme with the unpredictable-yet-controllable spells (Shock, Static Discharge, Lightning Bolt) of the Book of Air. -------------------------------------------------------------------------------- 6993651 | Isaac Sloat | 2017-02-06 13:53:07 -0600 Forget Repel Missiles RMsl has ignited many long and impassioned discussions about the Problem of Charms. With a low barrier of investment and cost, and a highly beneficial effect, players wanted to have RMsl active all the time. The devs alleviated annoyance by making the spell no longer expire based on duration, saving players everywhere hundreds of turns recasting it. Unfortunately, without that tedium cost, it became clear that RMsl was becoming the much-dreaded "no-brainer". Simply finding the spell meant the player became significantly stronger for the rest of the game for a minimal investment cost. Unlike equipment, RMsl doesn't have a meaningful opportunity cost: there's no "enchantment" slot that it's occupying, and the XP / memorisation investment is minimal. "Casters" and "fighters" alike were able to take full advantage of it. Deflect Missiles, while similar, is less problematic due to a much more significant investment/cost/upkeep requirement across the board. Therefore, we're tearing the page containing the Repel Missiles arcana out of the Crawl tome. Goodbye, old faithful friend. (Monsters will still be able to cast it.) -------------------------------------------------------------------------------- 182e11f | Isaac Sloat | 2017-02-06 13:53:06 -0600 Introduce fashionable scarves Scarves are worn in the cloak slot, have 0 AC and cannot be enchanted any further, but are guaranteed to generate with a magical ego. Right now they can generate with cold resistance, spirit shield, or resistance. As much as possible we should avoid overlapping egos between scarves and jewelry. Unique scarf egos are forthcoming. Even then, scarves are distinct from jewelry in taking much more time to swap another item into that slot. The intended design goal is to get players to make tradeoff decisions between having AC and cloak egos, or no AC bonus but a stronger, more magical defensive ego on the scarf. Includes a truly awful custom tile! Better tiles requested. -------------------------------------------------------------------------------- 160a424 | Colin Morris | 2017-02-06 09:46:46 -0800 Remove some spurious warnings on equip attempts. There were some cases where we'd give pointless warning prompts on equip operations that were doomed to fail anyways (e.g. because the corresponding slot was cursed). Defer warning about inscriptions until we're sure the equip operation is possible. Closes #423. -------------------------------------------------------------------------------- d12c374 | Isaac Sloat | 2017-02-05 21:36:15 -0600 Add a default force_more for sleep (10599, advil) Prevents the player from being immediately awakened if they're attacked by a monster before they would have woken up anyway. Normally we catch this in main.cc by triggering a more() if the player can't act, but that doesn't cover for situations where the player never actually gets the hypothetical chance to act before they're affected. There is possibly a cleaner way to do this than turning on an option, but that involves more complicated code than a single line, and there's precedent with banishment and petrification anyway. -------------------------------------------------------------------------------- 60d8699 | Neil Moore | 2017-02-05 15:17:23 -0500 Fix fsim defense mode with passive damage (advil, #10914) The passive damage could reduce the monster to zero damage, leading to messages about DEAD_MONSTER. -------------------------------------------------------------------------------- 2220185 | Neil Moore | 2017-02-05 15:12:51 -0500 Allow macros to work in tiles map mode (suppilulemur, #10917) They worked in console. -------------------------------------------------------------------------------- b2da203 | Neil Moore | 2017-02-05 15:07:52 -0500 Don't let brains gaze (#10916) Also remove the special shout for the extinct 'B' glyph. -------------------------------------------------------------------------------- 15e6a6b | Neil Moore | 2017-02-05 14:06:39 -0500 Fix log message for reduction of evolution level (#10927) -------------------------------------------------------------------------------- cffc55d | Isaac Sloat | 2017-02-05 13:01:58 -0600 Further hush conjured fires -------------------------------------------------------------------------------- 666c3b3 | Isaac Sloat | 2017-02-05 13:00:42 -0600 Merge pull request #440 from jiocy/patch-2 reduce intensity of conjure flame verb -------------------------------------------------------------------------------- 5e19f30 | Neil Moore | 2017-02-05 13:34:05 -0500 Include where needed (#10926) Several files used function<> without explicitly pulling in . This worked in older version of g++, because other headers did pull it in, but it no longer works in g++ 7.0.1. -------------------------------------------------------------------------------- 99e027b | Nicholas Feinberg | 2017-02-05 09:38:36 -0800 Simplify paralysis code There's no need to support paralysis duration being extended, since (blessedly) that can't happen. -------------------------------------------------------------------------------- b845919 | Nicholas Feinberg | 2017-02-05 09:37:54 -0800 Clarify slime creature description (Floodkiller) -------------------------------------------------------------------------------- 991e466 | jiocy | 2017-02-05 07:20:36 -0500 reduce intensity of conjure flame verb "Roar" in Crawl is typically a loud noise, typically one issued by a beast or a Trog-worshipper. Conjure flame, however, is quite a quiet spell and cautious (but inexperienced) players might avoid casting it for fear of a loud "roaring" noise if they fail to check the full spell details in the z ? ! menu. The description of the sound could stand to be toned down a little. Perhaps "The fire ignites dangerously!" would retain some of the original phrase's feeling of power and violence, at the risk of throwing around unnecessary adverbs! Uncertain whether "The fire roars!" was being called by other sources than Conjure Flame, sources which perhaps **are** loud enough to earn a "roar". -------------------------------------------------------------------------------- ab3eba1 | Nicholas Feinberg | 2017-02-04 18:23:10 -0800 Improve death messages from invisible paralysers Vampire knights being one obvious, common offender. -------------------------------------------------------------------------------- 1f986f1 | Nicholas Feinberg | 2017-02-04 18:03:07 -0800 Add frog shout verbs (Haifisch) Beware the slippery slope of the species-specific shout verbs... -------------------------------------------------------------------------------- 47d38b1 | Nicholas Feinberg | 2017-02-04 16:36:41 -0800 Cleanup webs for dead monsters -------------------------------------------------------------------------------- 874d44d | Nicholas Feinberg | 2017-02-04 16:11:51 -0800 Don't make Beckoning anger allies (Yermak) Precise logic here is a little odd... -------------------------------------------------------------------------------- 5b6a9c6 | Nicholas Feinberg | 2017-02-04 16:03:35 -0800 Refactor bolt::nasty_to() Deduplicate various enchantments. More still to be done, as ever... -------------------------------------------------------------------------------- 11c6ccf | Nicholas Feinberg | 2017-02-04 15:48:06 -0800 Try to clarify Divine Shield description Might be somewhat clearer that it's not the Warcraft invincibility ability of the same name? Maybe? -------------------------------------------------------------------------------- bef0b80 | Nicholas Feinberg | 2017-02-04 15:42:06 -0800 Give a memorization warning for Ozo's If your armour is too heavy. -------------------------------------------------------------------------------- 058ffa7 | Nicholas Feinberg | 2017-02-04 15:28:17 -0800 Temporary webs & web cleanup Make webs generated over the course of play (from jumping spiders & sacks of spiders) temporary, destroyed when you or a monster leaves them. Also attempt to partially clean up some other web- related code. -------------------------------------------------------------------------------- 895a516 | Nicholas Feinberg | 2017-02-04 13:40:24 -0800 Minor swap_with_monster() notes Add an assert and a comment. (It checks ATTR_HELD and assumes that refers to a net, but that attribute was re-used for web traps...) -------------------------------------------------------------------------------- 437268c | Neil Moore | 2017-02-04 13:09:55 -0500 Update sqlite3 submodule for Cygwin support (#9528). -------------------------------------------------------------------------------- aa2b1a6 | Neil Moore | 2017-02-04 12:34:57 -0500 Unbreak newer Cygwin builds (AutofireII) Our workaround for missing std::to_string causes an error in newer versions of Cygwin, where std::to_string is present. Instead of testing for Cygwin, test for the same (glibcxx-specific) macro that disabled std::to_string in the first place. Also update a broken link. -------------------------------------------------------------------------------- 892c87b | Neil Moore | 2017-02-03 22:17:47 -0500 Remove a special case for monster Sandblast. -------------------------------------------------------------------------------- f6ae02d | Isaac Sloat | 2017-02-02 23:33:46 -0600 Merge pull request #433 from glennmatthews/flag_useless_known Render useless items in dark grey in Known Items menu -------------------------------------------------------------------------------- 9f38e11 | Neil Moore | 2017-02-02 20:28:44 -0500 Give monster Sandblast full range. -------------------------------------------------------------------------------- 2c1049e | Neil Moore | 2017-02-02 20:25:39 -0500 Don't mark stones/rocks as wieldable. Affecting the w screen and the ' command. -------------------------------------------------------------------------------- c8f91ca | John Olender | 2017-02-02 15:47:25 -0600 Allow travel trails to be cleared while in the level map. For consistency and convenience, adjust the level map to handle CMD_CLEAR_MAP in the same manner as the main screen. -------------------------------------------------------------------------------- f70bbbc | advil | 2017-02-01 16:25:54 -0600 Fix for pain bond and aux attacks (10472) The basic problem was that radiate_pain_bond was called recursively from monster::hurt (which radiate_pain_bond calls), and could loop. When the loop reached the original target, if the embedded call to hurt killed the monster, it was guaranteed to clean up at that point, ignoring the `clean` argument to the original call. In a number of cases that relied on a <1hp monster not being cleaned up, this led to odd messages or crashes. This commit fixes the problem by refactoring the recursion into a single function (radiate_pain_bond) that tracks the original target. It defers cleanup for that target to the outer call of monster::hurt, and so will respect the cleanup_dead argument for that function. As a side effect, pain bond damage is calculated slightly more correctly for passive damage effects. I've tested this as carefully as I can and am fairly confident that it prevents the DEAD_MONSTER messages as well as the crash from constriction, but there were a lot of hard-to-replicate special cases that I haven't tested directly. -------------------------------------------------------------------------------- 403078a | Chris Campbell | 2017-02-01 17:14:15 +0000 Fix Ru wrath description (Doesnty) And reword the messages slightly. -------------------------------------------------------------------------------- 4f8a798 | Nicholas Feinberg | 2017-01-31 10:53:56 -0800 Automatically note god wrath length in description -------------------------------------------------------------------------------- 043a499 | Nicholas Feinberg | 2017-01-31 10:49:14 -0800 Scale penance messages by initial wrath In ?/G and when praying at altars. Now everyone's wrath can finally be upon you... -------------------------------------------------------------------------------- e7d7ddb | Nicholas Feinberg | 2017-01-31 10:36:17 -0800 Expose initial god wraths -------------------------------------------------------------------------------- 64cbba5 | Nicholas Feinberg | 2017-01-31 10:19:04 -0800 Fix Nemelex penance description Overlooked when the passive component of nem wrath was removed in 358a8cc3. -------------------------------------------------------------------------------- 2b9a704 | Chris Campbell | 2017-01-30 21:53:45 +0000 Fix monster upheaval checking player invocations skill -------------------------------------------------------------------------------- 932af17 | Chris Campbell | 2017-01-30 21:38:14 +0000 Let the sword of Cerebov's rF- work on rDamnation monsters Since damnation no longer has any thematic link to fire and fire immunity, as hellfire did previously. -------------------------------------------------------------------------------- 921d738 | Chris Campbell | 2017-01-30 21:02:20 +0000 Remove a hidden side-effect of siren songs Don't make it specifically alert (instead of just disturb) aquatic monsters - the effect was undocumented and even if noted in the description would be mostly invisible, and just waking nearby monsters will still draw them to the source of the noise. As a result also remove the now-unused noise_flag_type - the only other flag had no actual effect (at any point in its existence, seemingly). -------------------------------------------------------------------------------- a051ee5 | Alan Malloy | 2017-01-30 07:53:12 -0800 Fix the way the mac console app calls 'open' -------------------------------------------------------------------------------- e6d1839 | Nicholas Feinberg | 2017-01-28 19:19:04 -0800 Improve monster cloud AI wrt resists (tabstorm) Probably doesn't make sense for Antaeus to absolutely refuse to enter flame clouds just because he has rF-... -------------------------------------------------------------------------------- 174d061 | Chris Campbell | 2017-01-28 19:05:53 +0000 Let auto_butcher take a hunger threshold Still disabled by default, although it's maybe now reasonable to enable it with 'hungry' as the default? -------------------------------------------------------------------------------- bfac325 | Chris Campbell | 2017-01-28 19:05:06 +0000 Update an options_guide entry -------------------------------------------------------------------------------- 052e6ba | Nicholas Feinberg | 2017-01-26 17:00:14 -0800 Don't allow placing > MAX_MONSTERS (10918) This only ever happened in practice in mega-ziggurats (where there are already checks to prevent it) and in wizmode, but it's nice to be a little more careful. Also, remove the special ban on placing wandering monsters when there are already 650 monsters in a level, since it's irrelevant. -------------------------------------------------------------------------------- 5542e2b | Nicholas Feinberg | 2017-01-26 17:00:14 -0800 Remove a weird bit of debug code Seems to be leftover from when krakens were first implemented. -------------------------------------------------------------------------------- c09f9e6 | Nicholas Feinberg | 2017-01-26 10:11:04 -0800 Merge pull request #434 from gordon-quad/colemak colemak keyboard binding fixed -------------------------------------------------------------------------------- 6637667 | Nicholas Feinberg | 2017-01-26 10:09:48 -0800 Merge pull request #436 from nlavsky/patch-1 Update the description of the staff of summoning -------------------------------------------------------------------------------- af1d6b4 | nlavsky | 2017-01-26 22:02:51 +0400 Update the description of the staff of summoning Warding was removed in 0.18, but the description of the staff of summoning still mentions the "{Ward}" stash search prefix. -------------------------------------------------------------------------------- 6a4a307 | gammafunk | 2017-01-26 01:54:48 -0600 Make acid dragons green in console They were previously lightmagenta, the same color as the mottled dragon they replaced, but there's no longer the purple color assocation. Yellow is already taken by golden dragons, so green is a reasonable choice. -------------------------------------------------------------------------------- 8cfaa97 | gammafunk | 2017-01-26 00:53:01 -0600 Fix mouse handling for trackpads on OS X (Wizard_Lore) This restores some of the mouse position update for skipped events that was removed in 555d78b but still correctly tracks the last mouse location for redraw purposes. This seems to fix the lag seen for OS X trackpad users. -------------------------------------------------------------------------------- c48301f | Nicholas Feinberg | 2017-01-25 22:27:24 -0800 Tweak light/ultraheavy dragon scale item tiles Try to make steam/acid/qs scales a little more visually distinct from other types (rather than being straight recolours), and tweak gold dragon scales to make them a little visually bulkier. -------------------------------------------------------------------------------- 3be8840 | Nicholas Feinberg | 2017-01-25 22:00:02 -0800 Reorganize rltiles/mon Arbitrary, but makes me feel better. -------------------------------------------------------------------------------- 24831b1 | Nicholas Feinberg | 2017-01-25 21:23:25 -0800 Give vampire mages ghost hands So that their tiles can display weapons. -------------------------------------------------------------------------------- 753eaab | Neil Moore | 2017-01-25 23:52:07 -0500 Ensure god_passives has the correct number of entries. -------------------------------------------------------------------------------- fc596c4 | Neil Moore | 2017-01-25 23:41:11 -0500 Rationalise, document, and clean up god_passive messages. Use "NOW" as a placeholder for "now", "no longer", or nothing, depending on the context of the message. Still unused. -------------------------------------------------------------------------------- b68a50d | Chris Campbell | 2017-01-26 03:02:22 +0000 Fix descriptions of some unrands -------------------------------------------------------------------------------- 0e2e7d9 | Chris Campbell | 2017-01-26 03:01:58 +0000 Fix a godpassive description These aren't currently visible anywhere, but they might be someday hopefully! -------------------------------------------------------------------------------- 3802a75 | Gordon Quad | 2017-01-25 13:46:26 +0300 colemak keyboard binding fixed -------------------------------------------------------------------------------- 5bdfae7 | Glenn Matthews | 2017-01-24 16:33:30 -0500 Render useless items in dark grey in Known Items menu -------------------------------------------------------------------------------- 0b37eee | Chris Campbell | 2017-01-24 19:45:38 +0000 Remove item-cursing miscast effects Replace the charm/hex item curse miscasts with weakness and vertigo respectively. -------------------------------------------------------------------------------- aaecda2 | Chris Campbell | 2017-01-24 19:45:38 +0000 Adjust various god wraths Let every god have a chance of triggering overwhelming wrath (additional chance of slowing/confusion), instead of Lugonu and the good gods being excluded (but don't bother with overwhelming wrath when also paralysing the player). Remove most cases where god wrath effects gave an extra penance reduction, since in most cases it didn't actually match up with the danger of the effect. Sif Muna's wrath always gave extra penance reduction, so just make abandoning Sif give lower total penance in the first place. -------------------------------------------------------------------------------- 2823eb8 | Chris Campbell | 2017-01-24 19:45:38 +0000 Adjust Cheibriados wrath Remove some of the ineffective low-tension effects in favour of a random miscast effect, and adjust the higher-tension effects (to give the miscasts scaling with XL, and to slightly change the way that multiple fall-through effects trigger). -------------------------------------------------------------------------------- 05004e4 | Chris Campbell | 2017-01-24 19:45:38 +0000 Improve good god wrath descriptions -------------------------------------------------------------------------------- 060976d | Chris Campbell | 2017-01-24 19:45:38 +0000 Rework Elyvilon wrath Elyvilon's wrath was ineffective (weak poison miscasts, lifesaving on monsters giving them 10 HP at most) and exploitable (encouraging carrying many enchanted weapons to be dulled for penance reduction, and killing plants for Ely to heal for more penance reduction!) Remove the active effects entirely, and change it to be an XP-based wrath with a reworked version of the monster lifesaving effect - only working on proper hostiles, with reduced chances of working on weak monsters, and giving them back a reasonable amount of health. It's still intended to be a pretty tame wrath, but hopefully now at least slightly more noticeable and less exploitable. -------------------------------------------------------------------------------- 5f97612 | Chris Campbell | 2017-01-24 02:41:28 +0000 Fix colouring for Nemelex wrath on ^O -------------------------------------------------------------------------------- e079137 | Chris Campbell | 2017-01-24 01:14:53 +0000 Make re-cursing unrands always curse on equip Instead of ARTP_CURSE having different values for some unrands (with a 1/x chance of cursing on equip), make *Curse have a consistent meaning and always curse on equip. Results in the scythe of curses and amulet of bloodlust changing from a 1/3 chance of curse to guaranteed cursing, and no effect on all other cursing unrands. Also removes the (already-unused) tag to just make an unrand generate cursed without re-cursing. -------------------------------------------------------------------------------- a5227f2 | Chris Campbell | 2017-01-24 00:49:55 +0000 Adjust some unrands Reduce the plutonium sword's enchantment slightly, remove *Curse from the shield of Ignorance (since it's not very usefully swappable anyway), and adjust some inscriptions. -------------------------------------------------------------------------------- 839ffe0 | gammafunk | 2017-01-23 01:22:02 -0600 Fix temple entrances vault placement (Spectrina, PleasingFungus) Broken in cc390b8, temple entrance vaults had the wrong tag, and weren't seen as viable temple entry vaults. This resulted in all temple entrances not having any vault, simply a staircase. -------------------------------------------------------------------------------- 02c11fc | Neil Moore | 2017-01-21 21:25:42 -0500 Don't set curses colors if we never initialized curses. This was causing a crash with crawl -objstat Zig (because of Zig Lua killing monsters on placement. -------------------------------------------------------------------------------- 870a0e2 | Chris Campbell | 2017-01-22 01:54:13 +0000 Remove a missed spell from Xom's spell list (frozenca) -------------------------------------------------------------------------------- 8067192 | wheals | 2017-01-21 19:49:15 -0500 Remove unused setting for interrupt_eat -------------------------------------------------------------------------------- 3b403f5 | Neil Moore | 2017-01-21 18:24:01 -0500 Respect restart_after_game in "What is your name today?" (Fixer) Pressing escape at that prompt would exit the entire program, even with restart_after_game = true. This does not fix #7833 (which is mostly about console: tiles has restart_after_game = true by default), but does fix one of the things mentioned in that bug that affected tiles as well. Also change the prompt to make clear that Esc will return to the main menu (or end the game if restart_after_game is off), not go back to the race/ species/weapon selection. -------------------------------------------------------------------------------- a2a529b | Neil Moore | 2017-01-21 16:56:21 -0500 Work around an AMD driver crash on the title screen (Fixer, #10909) Apparently textures of exactly 512x512 cause errors with some versions of the Radeon drivers. Work around that by cropping our single 512x512 loading screen down to 511x511. This might also fix #10290 and friends but that needs tested. -------------------------------------------------------------------------------- 29864a7 | Chris Campbell | 2017-01-21 17:35:18 +0000 Remove a few spells from Xom's spell list Particularly the unarmed-dependent transformations, since they'd tend to either push Xom worshippers towards using UC, or just having to run away and wait out the spells. Closes #399 PR. -------------------------------------------------------------------------------- c86f373 | Chris Campbell | 2017-01-20 23:43:30 +0000 Mark Demonic Guardian as suppressed with sacrifice love -------------------------------------------------------------------------------- 3b0b867 | Chris Campbell | 2017-01-20 23:37:14 +0000 Adjust pricing for some armour and jewellery unrands Give arbitrary values to some unrands with special functionality that the value algorithm can't know about, and factor in some things that it can know about. -------------------------------------------------------------------------------- d259bc4 | Chris Campbell | 2017-01-20 23:37:11 +0000 Fix amulet of reflection pluses not changing their shop price -------------------------------------------------------------------------------- 2c65edc | Chris Campbell | 2017-01-20 20:27:32 +0000 Remove pizza and beef jerky To further reduce the number of different types of food, especially since with all food now taking a single turn to eat, the (already pretty insignificant) distinctions between types are further reduced. This leaves bread and meat rations as the two high-nutrition options, and royal jellies and fruit as the two low-nutrition ones (so carnivore/herbivore distinctions still remain here). -------------------------------------------------------------------------------- 82c27a3 | Neil Moore | 2017-01-20 20:14:09 +0000 Make all food take 1 turn to eat. (The distinction between food types taking different amounts of time to eat wasn't very meaningful, especially with chunks already taking only a single turn - in the rare cases where eating something immediately is important, there would virtually always be enough single-turn food available. - MarvinPA) -------------------------------------------------------------------------------- 555d78b | gammafunk | 2017-01-19 03:22:57 -0600 Fix a longstanding Tiles mouse cursor lag bug (#10278) With the refactoring done in 9e6f58dc to fix window sizing in SDL2, a bug was created where occasionally the mouse would lag in updating the screen when the cursor had moved to a new tile. The mouse event loop doesn't redraw if rapid mouse movement occurs and multiple movement events are in the event queue. Redraws due to mouse movement are supposed to occur due when the mouse moves to a new new tile, but not a new position in the same tile. However when the event loop was restructured in the aforementioned commit, the event was only ignored after first processing mouse position, and the last known mouse position was always updated on the next tick using this new position. So movement events to a new tile followed quickly by other movement events were updating the last known mouse position and then being skipped. By the time the last movement event queue was reached and actually processed fully, the last known mouse position would already be at the new tile location, so it would appear to the event loop that no redraw was needed. The actual redraw would only take place when the mouse moved again (either within tile and after a redraw timeout or to a new tile). This commit fixed the problem by processing the mouse location, including the last known mouse location, only for movement events that aren't skipped, allowing the redraw to always happen when the mouse moves to its destination tile. -------------------------------------------------------------------------------- 0de2c2e | Nicholas Feinberg | 2017-01-18 18:08:26 -0800 Merge pull request #431 from alexjurkiewicz/better-bloodlust Substantially buff the necklace of bloodlust & rename Jihad -------------------------------------------------------------------------------- 523475b | Chris Campbell | 2017-01-19 01:06:20 +0000 Adjust Kobold stat gain -------------------------------------------------------------------------------- 036ebb2 | Chris Campbell | 2017-01-19 01:06:20 +0000 Adjust shop pricing of various weapon unrands For various unrands with special-cased mechanics that the regular pricing algorithm can't take into effect, set a fixed shop value (or adjust the old value, for some of the original fixedarts), based loosely on their original shop value. Also give the acid and penetration brands price modifiers, so that the unrands using those can be handled without a special-cased value instead. -------------------------------------------------------------------------------- 3cd7e3f | Chris Campbell | 2017-01-19 01:06:20 +0000 Don't torment randomly when wielding the sceptre of Torment Only when using it in melee - having a 1/200 chance to torment on any turn while wielded just forces it to be swapped out for travel/exploration etc. -------------------------------------------------------------------------------- 405fccf | Alex Jurkiewicz | 2017-01-18 23:06:59 +1100 Rename Sword of Jihad "Jihad" is a politically loaded word these days and Crawl doesn't have any intention of commenting on the real world. -------------------------------------------------------------------------------- e7aad14 | Alex Jurkiewicz | 2017-01-18 23:06:58 +1100 Substantially buff the necklace of bloodlust It's rare for players to voluntarily use *Rage items, so let's make the item much better. -------------------------------------------------------------------------------- 2241292 | Nicholas Feinberg | 2017-01-17 16:18:05 -0800 Let misc shoals humanoids open doors (10907) Just because it makes more intuitive sense than the alternative; gameplay impact is probably minimal. -------------------------------------------------------------------------------- f50ee04 | Chris Campbell | 2017-01-16 17:32:25 +0000 Update some skill descs in the manual -------------------------------------------------------------------------------- 19c8d8d | Nicholas Feinberg | 2017-01-15 19:29:47 -0800 Round player regen up in % (Lasty) -------------------------------------------------------------------------------- 6327889 | Nicholas Feinberg | 2017-01-14 17:39:33 -0800 Add a warning comment wrt unrands & ?/ -------------------------------------------------------------------------------- e782c16 | Nicholas Feinberg | 2017-01-14 17:39:33 -0800 Define a magic number in makeitem.cc -------------------------------------------------------------------------------- 2d938b1 | Chris Campbell | 2017-01-14 20:32:37 +0000 Fix a warning -------------------------------------------------------------------------------- 45aadb5 | Chris Campbell | 2017-01-14 20:32:09 +0000 Adjust Searing Ray's prompt -------------------------------------------------------------------------------- d88b9fc | Chris Campbell | 2017-01-14 20:18:16 +0000 Don't let Beogh gift highlevel weapons to low level orcs Instead of having a tiny chance to upgrade them. -------------------------------------------------------------------------------- 7fc62c3 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Update changelog through 0.20-a0-484-g71649f8 -------------------------------------------------------------------------------- 8a0f1f4 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Turn Bai Suizhen's thunder into an ench (10730) So that she stops murdering everyone on the level if you leave and come back from another set of stairs. -------------------------------------------------------------------------------- 4ed6182 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Display player regen in % (dpeg) Sometimes nice to see how fast you're regenerating; pretty simple to test by waiting a few turns (or by running the numbers in your head, if you really need to), but can get complex when you're running mutations, artefacts, durations, and so on. It might be nice to use pips here, but any scale that can display REGEN_PIP effects (e.g. amulet of regeneration - which we should be able to show!) can't really also display insane regen stuff like Powered by Death. -------------------------------------------------------------------------------- 22d579f | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Remove Cerebovscumming Don't allow players to get multiple copies of cerebov's sword by taking his rune and then repeatedly disarming him as he pursues you throughout pan. CRITICAL BALANCE FIX Also, add a tile for cerebov-sans-sword. (Sorry to whoever reported this! I didn't include your name in my notes...) -------------------------------------------------------------------------------- ed69ad6 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Ban Cigotuving orc corpses under Beogh Beware The Flavour Cost -------------------------------------------------------------------------------- 3c57230 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Improve Ray status line (dpeg) And describe it in ?/T. -------------------------------------------------------------------------------- c945ec9 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Add a Searing Ray reminder message (dpeg) -------------------------------------------------------------------------------- 4aad59f | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Give Hellbinder & Cloud Mage sInv No sInv was a neat achilles heel for them, but made them way too easy once you'd noticed it. -------------------------------------------------------------------------------- 6efe0ef | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Prefer autopickup items for apport Default targeting. I'm sorry, this was a suggestion/request, but I forget who made it - LordSloth, maybe? Very sorry to whoever it was! -------------------------------------------------------------------------------- ab32824 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Improve Apportation spellpower dependence Instead of capping at 18 spellpower with hard spellpower breakpoints, cap at 50, and display that. (RIP, the last 1000-spellpower-cap spell in the game...) -------------------------------------------------------------------------------- 7ccf162 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Make acid dragons (& scales) less blinding They're a little closer to golden dragons now, but I think they should still be distinguishable. The armour is the only potential problem; might be good to have a different tile for 'light' dragon armour, versus 'heavy'? -------------------------------------------------------------------------------- 6418979 | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Make Poisonous Vapours only hit visible targets For UI reasons; getting "the spell fizzles" when targeting an empty square is all kinds of bad spellfeel! Also, tweak the description to hopefully be a bit more useful. -------------------------------------------------------------------------------- 6a4234e | Nicholas Feinberg | 2017-01-14 12:16:32 -0800 Make Iron Giants more selective About what they toss. Also, fix a relevant debug print. FR: re-allow them to toss orbs of destruction, but actually implement the orbs exploding on whatever they hit! -------------------------------------------------------------------------------- 6d2f28a | Chris Campbell | 2017-01-14 17:31:09 +0000 Don't give random panlords 0 AC/EV -------------------------------------------------------------------------------- 4e2cedd | Chris Campbell | 2017-01-14 17:22:03 +0000 Fix random panlord defenses (Doesnty) Caused by 768198ce16, intending to change them to be inversely related. -------------------------------------------------------------------------------- 5c05303 | Chris Campbell | 2017-01-14 00:49:21 +0000 Adjust some Xom amusement checks Remove some obsoleted and just plain weird checks, and make some scroll amusement values depend on whether they're actually bad for your current species. -------------------------------------------------------------------------------- 521e6c5 | Chris Campbell | 2017-01-13 18:19:02 +0000 Fix wizmode create stairs being backwards (#10898) -------------------------------------------------------------------------------- bb038bd | Nicholas Feinberg | 2017-01-12 18:23:45 -0800 Merge pull request #418 from alexjurkiewicz/smoke-and-mirrors Rework minmay_smoke_and_mirrors (minmay) -------------------------------------------------------------------------------- 25c24e1 | Colin Morris | 2017-01-12 18:08:43 -0800 Don't special case the abyss for tripping checks. -------------------------------------------------------------------------------- 9217641 | Colin Morris | 2017-01-12 18:08:29 -0800 Fix incorrect messages on branch transition Sometimes the game would say "Welcome back to x!" even though it was your first time in x. e.g. https://crawl.develz.org/mantis/view.php?id=10868 This fixes that, and simplifies some of the level transition logic. Closes #427. -------------------------------------------------------------------------------- c52d0eb | Corin Buchanan-Howland | 2017-01-12 10:21:57 -0500 Make poisonous vapours cloud extension correctly use auts (|amethyst) -------------------------------------------------------------------------------- 6513c8f | Chris Campbell | 2017-01-11 18:24:12 +0000 Simplify -------------------------------------------------------------------------------- 526fb3c | Nicholas Feinberg | 2017-01-10 20:37:22 -0800 Fix monster self-haste AI Good ol' copy, and her friend, paste. -------------------------------------------------------------------------------- 5747544 | Nicholas Feinberg | 2017-01-09 19:34:26 -0800 Lovely Barachian tiles (CanOfWorms) *ribbiting intensifies* -------------------------------------------------------------------------------- 698f215 | Neil Moore | 2017-01-09 22:07:28 -0500 Revert "Revert "Class-ify the transformation_type enum."" And fix the inverted form wearability check. This reverts commit 45280e57cd59b73c37a996bfea109a35d5f2f415. -------------------------------------------------------------------------------- 45280e5 | Nicholas Feinberg | 2017-01-09 18:59:59 -0800 Revert "Class-ify the transformation_type enum." Made it impossible to wear anything, somehow. This reverts commit 13ce160d993939d2dfbd5a2193106c0f0bafdb40. -------------------------------------------------------------------------------- 13ce160 | Neil Moore | 2017-01-09 20:54:50 -0500 Class-ify the transformation_type enum. And rename it to "transformation"; perhaps that should be shorter, "transform_t" or "tran_t", to reduce line breaking. Use a constexpr int for NUM_TRANSFORMS, so that the number of forms is easily available without the need to cast. Also, correct a few places that assumed TRAN_NONE == 0. -------------------------------------------------------------------------------- 26612c9 | Neil Moore | 2017-01-09 20:29:32 -0500 Unbrace. [skip ci] -------------------------------------------------------------------------------- bddc754 | Alan Malloy | 2017-01-09 16:29:18 -0800 Don't implicitly coerce TRAN_NONE to int Instead, make it clear what value we care about comparing to. -------------------------------------------------------------------------------- 6b3cd1b | Alan Malloy | 2017-01-09 16:29:18 -0800 A couple copy-editing things in hints-mode text -------------------------------------------------------------------------------- 215b21a | Chris Campbell | 2017-01-09 22:58:27 +0000 Change most multi-holiness monsters to only have a single holiness Giving multiple holinesses to a single monster tended to cause unwanted interactions (such as bad polymorph results on partially-natural monsters) and other complexities, with no particular benefit. Results in a few minor gameplay changes - hell hounds/hogs/rats/ephants become immune to negative energy where they weren't before. Monster demonspawn are currently still natural and demonic (the latter making them torment-immune). -------------------------------------------------------------------------------- c3b7d50 | Nicholas Feinberg | 2017-01-09 14:42:07 -0800 Fix Barachians + water elemental (Yermak) Hooray for code duplication! -------------------------------------------------------------------------------- 2b43fbb | CanOfWorms | 2017-01-07 20:52:36 -0500 Mark Passage of Golubria useless in Zot (Yermak) -------------------------------------------------------------------------------- 91466d2 | Nicholas Feinberg | 2017-01-07 11:13:34 -0800 Remove obsolete tile flag code Became irrelevant when petrify was moved into the 'very stabbable' tier. -------------------------------------------------------------------------------- 7ae5c3f | Nicholas Feinberg | 2017-01-07 10:43:40 -0800 Mark cloudwand useless under Still Winds (Yermak) It should probably fail when you try to evoke it, rather than after you select a target, too... -------------------------------------------------------------------------------- 4e5c00f | Nicholas Feinberg | 2017-01-07 10:21:33 -0800 Finish removing mimic enums -------------------------------------------------------------------------------- 3527015 | Nicholas Feinberg | 2017-01-07 10:03:40 -0800 Remove some unused mimic flags -------------------------------------------------------------------------------- 96be121 | Corin Buchanan-Howland | 2017-01-06 21:23:49 -0500 Rename Noxious Vapours to Poisonous Vapours (MarvinPA, gammafunk) 'Noxious' usually means mephitic clouds in crawl. -------------------------------------------------------------------------------- 0beec18 | Nicholas Feinberg | 2017-01-06 15:47:19 -0800 Use actor_cloud_immune for nox vapour (|amethyst) -------------------------------------------------------------------------------- 6c275fb | Neil Moore | 2017-01-06 18:33:36 -0500 Correct rPois check in noxious vapours targeting. We were checking for rpois == 1, meaning one could cast the spell on a Phantom (rPois+++) but not a Crimson Imp (rPois+). Perhaps this should use actor_cloud_immune instead, but first we'd want a version that only requires a cloud_type and not a whole cloud_struct. Note that the spell leaks information (with 0 time expended) about whether a monster has an unidentified item that grants rPois. -------------------------------------------------------------------------------- 9649680 | Alan Malloy | 2017-01-06 13:06:54 -0800 Revert accidental change to gitignore -------------------------------------------------------------------------------- c6cb2a6 | Alan Malloy | 2017-01-06 11:35:56 -0800 Remove incorrect wizmode help key (DivineHammer, #0010880) -------------------------------------------------------------------------------- 03c7170 | Corin Buchanan-Howland | 2017-01-06 08:05:38 -0500 Simplify some math. -------------------------------------------------------------------------------- 0464b71 | Corin Buchanan-Howland | 2017-01-05 22:04:59 -0500 Add new L2 Poison/Air spell, Noxious Vapours The new spell is a smite-targeted attack that creates an extremely short-lived poisonous cloud on top of the target. The spell can be found in the book of clouds and the Young Poisoner's Handbook, providing Venom Mages with a L2 spell. The motivation for this spell is to create an offensive spell for VM between Sting and OTR. Sting is unreliable and single-target; OTR is reliable and multi-target. This splits the difference, creating a reliable, single-target spell at the cost of more MP. Because it feels redundant, this also removes player Poisonous Cloud from all books, and removes Alistair's Intoxication from the Young Poisoner's Handbook , since the book feels sufficiently full without it. -------------------------------------------------------------------------------- ceecc7e | Nicholas Feinberg | 2017-01-05 15:20:12 -0800 Fix a species mock (Doesnty) I tested the old version, but not the modified one... oops! -------------------------------------------------------------------------------- 89e74e4 | Nicholas Feinberg | 2017-01-05 13:45:39 -0800 Add a barachian dummy monster -------------------------------------------------------------------------------- 1a30b92 | Nicholas Feinberg | 2017-01-05 13:42:40 -0800 New race: Barachians Barachians' marquee ability is Hop, which allows them to blink near a targeted tile - a weaker version of controlled blink, essentially. In exchange, they're somewhat slow-moving (MUT_SLOW 1, half a naga's), which of course makes their hop even more useful, and they have poor attributes - 6/6/6 + sid/5, the same total as ghouls. They're roughly average in their aptitudes, with +1s and -1s used to weakly bias them toward certain skills without making any dominant. Hop is initially range 4, with a fuzz radius of 2 tiles; the player is equally likely to land anywhere within the radius. The ability is limited by a -Hop status; inspired by Barbs, -Hop only wears off while you're not moving. (That is, while you're resting, attacking, or casting spells.) The goal is to avoid making it too easy to run away from enemies indefinitely by repeatedly hopping, and to avoid annoying turncount-optimal behaviour during travel. At XL 13, the player's Hop range increases to 5; this should help it stay somewhat more relevant as the player accumulates more (and more reliable) escape options. A tongue attack was considered, but the design focus of the race is the Hop, and having two frequently-relevant active abilities on a species didn't seem like a good idea. -------------------------------------------------------------------------------- 81164ae | Nicholas Feinberg | 2017-01-05 12:42:51 -0800 Fix special-case brand appearances (10878) Antimagic-branded trog gifts would have no visible appearance (glow, etc) if they generated with a near-zero enchantment - quite rare! -------------------------------------------------------------------------------- 3bc703b | Chris Campbell | 2017-01-05 17:58:26 +0000 Fix monsters casting pain at immune targets (#10875) -------------------------------------------------------------------------------- 18e6404 | Chris Campbell | 2017-01-05 17:48:35 +0000 Remove some obsolete monster formicid handling Secret tech: enslave formicids for powerful allies, then cast silence to make them dig faster????? -------------------------------------------------------------------------------- 2f2b14e | Chris Campbell | 2017-01-05 17:43:43 +0000 Don't let monsters zap wands while confused (#10876) -------------------------------------------------------------------------------- f4ea4dd | Chris Campbell | 2017-01-04 21:49:40 +0000 Don't display HP/AV/EV for sensed monsters (#10861) -------------------------------------------------------------------------------- 93bceec | Nicholas Feinberg | 2017-01-03 21:48:22 -0800 Mention ghoul non-fullness in the manual (Yermak) -------------------------------------------------------------------------------- 9e36e56 | CanOfWorms | 2017-01-02 17:42:24 -0500 Lightning rod tiles -------------------------------------------------------------------------------- 25cc1b4 | Chris Campbell | 2017-01-01 22:49:51 +0000 Make Sandblast respect the !D inscription Why would you ever inscribe stones with !D? Who knows. -------------------------------------------------------------------------------- 8301ae9 | Chris Campbell | 2017-01-01 22:42:58 +0000 Show a message indicating remaining stones when casting Sandblast As with Sticks to Snakes, so that it's still easy to keep track of remaining stones without having to frequently check the inventory when quivering something else more useful for throwing. -------------------------------------------------------------------------------- bd41281 | Nicholas Feinberg | 2017-01-01 12:28:30 -0800 Fix some hardcoded 27s (Floodkiller) For MAX_SKILL_LEVEL. -------------------------------------------------------------------------------- 054b1fe | Chris Campbell | 2017-01-01 13:34:43 +0000 Fix everything being diggable (10869) -------------------------------------------------------------------------------- 059cf21 | Neil Moore | 2016-12-31 19:27:19 -0500 Make /Enslavement work again (Shard1697) Players got "Sorry, this spell is gone!" because the spell was marked as removed before the wand actually used the spell. This has the side effect of allowing players in transferred games with Enslavement memorised to cast it once again. -------------------------------------------------------------------------------- 8b12978 | Chris Campbell | 2016-12-31 17:39:31 +0000 Adjust some backgrounds Make some minor tweaks to starting stats (Arcane Marksman, Gladiator, Skald) and skills (Skald, Venom Mage), and remove some enchanted starting armour (Enchanter). -------------------------------------------------------------------------------- c811625 | Chris Campbell | 2016-12-31 16:05:44 +0000 Adjust and remove some vaults based on eye of devastation digging Remove a few trap vaults that relied on eyes of devastation digging out other monsters, and adjust hangedman_surveillance_ring to replace some grates with doors and require traversing more of the vault in general. -------------------------------------------------------------------------------- 82d1f44 | Chris Campbell | 2016-12-31 16:05:44 +0000 Add sparkles to Ziggurat figurines (regret-index) Make them glow and change colour with increasingly absurd numbers of Ziggurat completions (even though this behaviour is silly and should not be encouraged!) -------------------------------------------------------------------------------- 5132bad | Chris Campbell | 2016-12-31 16:05:44 +0000 Adjust description for lightning rods becoming inert Since they require multiple activations. -------------------------------------------------------------------------------- 2e1f7d5 | Neil Moore | 2016-12-31 10:29:12 -0500 Fix dgl builds (doh) -------------------------------------------------------------------------------- 81ce367 | Neil Moore | 2016-12-31 09:16:02 -0500 Avoid an unused-variable warning in dgl builds. -------------------------------------------------------------------------------- f6b327c | Chris Campbell | 2016-12-31 13:57:50 +0000 Don't crash when marshalling removed rod item info -------------------------------------------------------------------------------- 83c570d | Chris Campbell | 2016-12-31 01:32:33 +0000 Fix tiles compilation -------------------------------------------------------------------------------- 40a51bc | Chris Campbell | 2016-12-31 01:06:53 +0000 Remove some unused disintegration handling -------------------------------------------------------------------------------- 3289933 | Chris Campbell | 2016-12-31 01:06:37 +0000 Let digging destroy statues (|amethyst) Since disintegration no longer does, and some vaults required it for access. -------------------------------------------------------------------------------- e4f0a7c | Chris Campbell | 2016-12-30 23:34:47 +0000 Add a wizard command to recharge XP evokers On &v, with the "item value" command moved to &^V since that seems far less likely to be used. -------------------------------------------------------------------------------- 6d5bc7a | Chris Campbell | 2016-12-30 23:34:47 +0000 Remove an unused parameter -------------------------------------------------------------------------------- 716b500 | Chris Campbell | 2016-12-30 23:34:47 +0000 Replace discs of storms with lightning rods Using XP evoker mechanics but adjusted for a slightly simplified version of the old rod spell. Instead of having its mana use vary and reset depending whether it's used on consecutive turns or not, it now has a fixed 4 charges, with the power increasing each time (and allowing for area targeting as previously when zapped on consecutive turns). Once all 4 charges are used, it becomes inert like a normal XP evoker and the power resets. The bolt now also always hits (instead of having power-dependent accuracy on the first zap but huge fixed accuracy on consecutive zaps), and has fixed noise instead of noise varying depending on charge. -------------------------------------------------------------------------------- c9d5dce | Chris Campbell | 2016-12-30 23:34:47 +0000 Remove an unused member of the bolt struct -------------------------------------------------------------------------------- 8eeb10a | Chris Campbell | 2016-12-30 23:34:47 +0000 Re-use rod tile icons for wands of clouds and scattershot And remove the unused tiles for other rod types. -------------------------------------------------------------------------------- cccf842 | Chris Campbell | 2016-12-30 23:34:46 +0000 Don't allow zapping wands while confused In terms of implementation it's very awkward to make confusion-fuzzing work well with wands of clouds/scattershot now existing, but also generally it's very unlikely to be a useful thing to spend time on while confused, except perhaps when completely surrounded by monsters. -------------------------------------------------------------------------------- 4e4fe7e | Chris Campbell | 2016-12-30 23:34:46 +0000 Adjust some vaults for wand/rod changes Add the appropriate wands back to a few vaults that used to place them as rods, and replace disintegration in earth/digging-themed vaults. -------------------------------------------------------------------------------- 2dbcf0a | Chris Campbell | 2016-12-30 23:34:46 +0000 Remove wands of slowing Along with wands of confusion they duplicate a low-level hex, and as the noticeably weaker effect are fairly unlikely to be made much use of. Removing them also helps shift wands further towards having a smaller selection of effects but with less duplication of existing spells, and there's still a pretty good range of remaining hex wand effects with confusion, paralysis, enslavement and polymorph. -------------------------------------------------------------------------------- 85f13f0 | Chris Campbell | 2016-12-30 23:34:46 +0000 Don't make BEAM_DISINTEGRATION or BEAM_DEVASTATION dig walls Affects the wand of disintegration mostly, since the resistible but high damage is its main effect. Also changes IOOD and eye of devastation bolts, since they're somewhat similar mechanically (in that they just dig to be flashy rather than for any special gameplay reason, and the flashiness is covered nicely just by splattering blood everywhere and making things explode on death). -------------------------------------------------------------------------------- bca2e78 | Chris Campbell | 2016-12-30 23:34:46 +0000 Make wand power scale better with Evocations skill From 15 + Evo * 2.5 to 15 + Evo * 3.5, slightly higher than rod evocations scaling used to be. -------------------------------------------------------------------------------- 7e2a38b | Chris Campbell | 2016-12-30 23:34:46 +0000 Rework the wand of random effects Since it was already not at all just a random other wand's effect, and the addition of clouds/scattershot makes that even less feasible. Give it a new, arbitrary list of effects, and finish refactoring wand code in the process. -------------------------------------------------------------------------------- 44a4606 | Chris Campbell | 2016-12-30 23:34:46 +0000 Remove rods Some rods have fun and unique effects, but the item class itself doesn't work very well - it demands frequent item switching, and creates yet another different item type that provides ranged attacks and summons (on top of launchers, wands, regular evokables, ...). The iron rod and rod of clouds have already been repurposed as high-tier wands. Rods of ignition and inaccuracy are removed outright - they could in theory work as wands, but clouds and iron are probably the better effects and there are already a large number of direct-damage wands. Shadows is also removed outright, as it mostly duplicates an existing scroll and spell (just with very slightly different rules). Lightning rods are another neat effect but wouldn't function as a wand, so are planned to be repurposed into some kind of evokable. -------------------------------------------------------------------------------- 2834ef1 | Chris Campbell | 2016-12-30 23:34:45 +0000 Refactor your_spells Remove an unneeded parameter. -------------------------------------------------------------------------------- d31b6d8 | Chris Campbell | 2016-12-30 23:34:45 +0000 Add the wand of scattershot Reusing the iron rod's effects, as a rare high-tier wand. -------------------------------------------------------------------------------- a59074c | Chris Campbell | 2016-12-30 23:34:45 +0000 Give Disintegrate LOS range Affects the wand, and great orbs of eyes (all of whose other spells have LOS range). -------------------------------------------------------------------------------- f84ef17 | Chris Campbell | 2016-12-30 23:34:45 +0000 Partially refactor wand handling, make wands use spell ranges Handle targeting/prompts etc with the same interface as spellcasting, reducing some code duplication and hopefully cleaning things up generally. The wand of random effects isn't handled here yet and still uses the old codepath. Makes regular wands use normal spell ranges instead of having LOS range as a side-effect - this could still be changed, but since wands of clouds and scattershot don't have LOS range it would still be inconsistent, and seems fine to reduce some wand ranges slightly but to compensate for it elsewhere (most likely by improving wand power scaling). -------------------------------------------------------------------------------- 42a710e | Chris Campbell | 2016-12-30 23:34:45 +0000 Remove mist and rain from wand of clouds effects Since unlike the rod it doesn't continue to recharge for free, make it much more likely to do something useful even at low power. -------------------------------------------------------------------------------- b1e1cac | Chris Campbell | 2016-12-30 23:34:45 +0000 Add the wand of clouds As a rare, high-power wand, using the effects from the rod of clouds. Uses similar handling for rods in terms of implementation, with other wands to be refactored to use the same system later. -------------------------------------------------------------------------------- 87fc977 | Neil Moore | 2016-12-30 18:25:32 -0500 Swap &k and &K commands. Since the latter is very situational (Labs only), and for consistency between &l and &k. -------------------------------------------------------------------------------- d1c1da2 | Neil Moore | 2016-12-30 18:03:05 -0500 Allow resting inside of walls in wizmode. The change to abort a run command early if the target square is uninhabitable (0.20-a0-387-gf587305) also affected resting, but that broke the woken_rest test and probably others. Instead, check for running as opposed to resting. Also, don't abort the run command, but simply avoid the slime wall message, if the target square can't be entered: this change restores the "Why would you want to do that?" message when attempting to run into water, lava, etc. when slime walls are not nearby. -------------------------------------------------------------------------------- 5631477 | Neil Moore | 2016-12-30 17:25:05 -0500 Actually prevent running/resting next to slime walls (doh) I missed the return when refactoring. -------------------------------------------------------------------------------- bf3f530 | Isaac Sloat | 2016-12-30 16:01:28 -0600 Let TSO worshippers use their poison stingers TSO's poison conduct was removed in c6e9da29ea2 -------------------------------------------------------------------------------- 67baa83 | Neil Moore | 2016-12-30 15:50:54 -0500 Make _count_adjacent_slime_walls non-static. Since exactly the same loop was present in terrain.cc already, and something very similar with a tiny optimisation in dungeon.cc. Also use the function replace a couple of loops that look for the existence, rather than number, of adjacent slime walls (in main.cc and travel.cc). The loop in slime_wall_neighbour could also be replaced, but that one is called often enough that there might be performance implications. -------------------------------------------------------------------------------- ac35c17 | Neil Moore | 2016-12-30 15:48:52 -0500 Move mons_is_slime check into actor_slime_wall_immune. So that it has the correct return for great orbs of eyes. Both callers already checked for mons_is_slime, so there is no change to gameplay. -------------------------------------------------------------------------------- 30b8490 | Neil Moore | 2016-12-30 11:52:23 -0500 Use existing Jiyva passives in a few more places. -------------------------------------------------------------------------------- dfafcef | Neil Moore | 2016-12-30 11:50:27 -0500 Don't let Jiyva spawn-on-hit work under penance. Mainly to allow turning it into a passive_t. -------------------------------------------------------------------------------- 9630af8 | Neil Moore | 2016-12-30 11:50:27 -0500 Use a passive_t for slime wall immunity. -------------------------------------------------------------------------------- 4892b34 | Alan Malloy | 2016-12-29 18:38:32 -0800 Make function consistent by removing an extraneous else -------------------------------------------------------------------------------- d82c4c4 | Alan Malloy | 2016-12-29 18:34:35 -0800 Don't 'start eating' stuff that only takes one turn -------------------------------------------------------------------------------- 613a653 | Nicholas Feinberg | 2016-12-29 15:59:34 -0800 Change manual-buffed skills to lightblue (CYC) From red. Discussion here: https://crawl.develz.org/tavern/viewtopic.php?f=17&t=22678 . Note that manuals *theoretically* used both lightred & red before, but in practice, only lightred would ever appear. (Any manuals that appeared in the tutorial would colour the line red instead, but (a) there aren't any, and (b) it doesn't seem especially useful for that colour to appear even if there were.) -------------------------------------------------------------------------------- f587305 | Nicholas Feinberg | 2016-12-29 15:42:40 -0800 Nix nonsensical run warnings (koboldenthusiasm) No need to prompt about running into slime walls if there's an obstacle in the way! -------------------------------------------------------------------------------- 2d247ea | Chris Campbell | 2016-12-28 19:15:30 +0000 Simplify Pain self-damage handling The comment in _spell_zap_effect was incorrect - since 17dfbce6f4, only successfully casting the spell has caused self-damage, not miscasting. This seems like better behaviour anyway, so the handling is moved into _spellcasting_side_effects. -------------------------------------------------------------------------------- 72753d0 | gammafunk | 2016-12-28 13:12:27 -0600 Balance braces in an initialization fixed the broken build in 68c82e3 -------------------------------------------------------------------------------- 68c82e3 | Nicholas Feinberg | 2016-12-28 10:16:53 -0800 Invalidate agrid after silence ends (10636) The invalidate_agrid() in player-reacts.cc would *usually* handle this, but if anything checked the agrid between that invalidation and the actual decrementing of the DUR_SILENCE to 0 (that is, between lines 600 and 859), the agrid would still see DUR_SILENCE as being in effect at your current position, and wouldn't update until something else invalidated the agrid (e.g. another cast of silence). To replicate before this commit, have Darkness active along with Silence; player-reacts.cc:773 will trigger the bug. -------------------------------------------------------------------------------- 34dcd6a | Chris Campbell | 2016-12-28 17:34:09 +0000 Remove an unused spellcasting parameter Obsolete since 54df5be6b9, oops. -------------------------------------------------------------------------------- 289d6af | Neil Moore | 2016-12-28 01:12:54 -0500 Update &l usage in tests. So as not to answer the now-removed skills question. -------------------------------------------------------------------------------- f93df6f | Neil Moore | 2016-12-28 01:12:53 -0500 Correct &K in wizmode menu. It was incorrectely listed in lowercase, but that is the labyrinth shift command. Perhaps &k and &K should be swapped... -------------------------------------------------------------------------------- 73d48a1 | Neil Moore | 2016-12-28 01:05:55 -0500 Disable death in fireworks test. The orb card can kill the player, causing a hang because no one is there to say no at the "Die?" prompt. See for example: https://travis-ci.org/crawl/crawl/jobs/187107765 -------------------------------------------------------------------------------- c0b65bf | Nicholas Feinberg | 2016-12-27 16:43:02 -0800 Split &l; add &K &l simply sets XL; &K sets XL and skills. -------------------------------------------------------------------------------- f1fd183 | Nicholas Feinberg | 2016-12-27 16:03:59 -0800 Simplify siren/avatar song power Merfolk avatars go from 73 to 75 ench power, post-stepdown. Sirens are unaffected. -------------------------------------------------------------------------------- 192cef2 | Nicholas Feinberg | 2016-12-27 15:57:19 -0800 Fix Siren/Avatar Song resist display (JFunk-soup) This has been (slightly) wrong ever since hex resist chance displays were added. -------------------------------------------------------------------------------- a701ec3 | Isaac Sloat | 2016-12-27 17:36:42 -0600 'Great waves' become 'torrents' Zaps another instance of 'great'. -------------------------------------------------------------------------------- c02d24d | Alan Malloy | 2016-12-27 14:27:25 -0800 Remove a vestigial line of code from smite targeter -------------------------------------------------------------------------------- 910a2e5 | Alan Malloy | 2016-12-27 12:12:10 -0800 Rename targetters to targeters (MarvinPA) -------------------------------------------------------------------------------- 2e40481 | Alan Malloy | 2016-12-27 11:43:09 -0800 Replace branching with boolean expression -------------------------------------------------------------------------------- b9ad934 | Nicholas Feinberg | 2016-12-27 09:56:56 -0800 Remove lava acquirement Losing an ?acq because you thoughtlessly read it over dangerous terrain is... not very crawl-y. -------------------------------------------------------------------------------- be7c41a | Nicholas Feinberg | 2016-12-27 09:44:07 -0800 Remove a duplicate acq message We already ask what you want to acquire at the bottom of every acq prompt. (Yes, that means my comment on that pull request was wrong - sorry, Sandman!) Closes #366. -------------------------------------------------------------------------------- d6af2a4 | Alan Malloy | 2016-12-26 21:24:35 -0800 Finish renaming itemprop to item-prop (|amethyst) -------------------------------------------------------------------------------- 71b9d6e | Isaac Sloat | 2016-12-26 21:06:54 -0600 Sandblast blasts sand -------------------------------------------------------------------------------- 4aedf34 | Neil Moore | 2016-12-26 16:39:06 -0500 Fix missing CRs in Visual Studio project. Maybe checkwhite should have a rule for those files instead of skipping them entirely... [skip ci] -------------------------------------------------------------------------------- 454506b | Alan Malloy | 2016-12-26 13:18:31 -0800 Replace contrib, I hope? -------------------------------------------------------------------------------- 03f3333 | Alan Malloy | 2016-12-26 12:52:35 -0800 Add hyphens to some multiwordfilenames -------------------------------------------------------------------------------- f8a1998 | Alan Malloy | 2016-12-26 12:52:35 -0800 Rename files like foo_bar to foo-bar -------------------------------------------------------------------------------- f2875f6 | Neil Moore | 2016-12-26 15:34:22 -0500 Make decks.cc not executable. [skip ci] -------------------------------------------------------------------------------- b62f0a4 | Chris Campbell | 2016-12-26 19:24:54 +0000 Make the Majin-Bo only cost HP on successful casts And simplify some of its code. -------------------------------------------------------------------------------- f934e21 | Chris Campbell | 2016-12-26 18:49:19 +0000 Document some unrand properties -------------------------------------------------------------------------------- c3bf50c | Chris Campbell | 2016-12-26 18:27:53 +0000 Remove CBL from Xom's random spell list It's disproportionately likely to just explode the player, since it can easily be cast early on and with monsters already in range. -------------------------------------------------------------------------------- 3c00ad3 | Chris Campbell | 2016-12-26 17:51:19 +0000 Don't drain intelligence when Xom casts SHT -------------------------------------------------------------------------------- 0e31c27 | Chris Campbell | 2016-12-26 17:51:07 +0000 Don't make Xom cast spells at zero tension Transforming the player out of combat was mostly just likely to force them to rest it off before continuing to explore. -------------------------------------------------------------------------------- 28afc85 | Chris Campbell | 2016-12-26 16:54:51 +0000 Prevent Yredelemnul worship under sacrifice love Technically Injury Mirror and Drain life did still function, but the core of the god was disabled (as with Beogh, who is also disabled even though Smiting and water walking would still work!) -------------------------------------------------------------------------------- e975d06 | Chris Campbell | 2016-12-26 16:36:19 +0000 Tweak Corrupt description -------------------------------------------------------------------------------- 085a5c2 | Chris Campbell | 2016-12-26 16:34:50 +0000 Give Bend Space a fixed HP cost Instead of randomly dealing 1-4 damage, give it a fixed cost of 2HP, so that it can be more clearly displayed as a cost of using the ability. -------------------------------------------------------------------------------- 9f02536 | Chris Campbell | 2016-12-26 16:31:21 +0000 Adjust Enter the Abyss's MP costs Instead of reducing MP by a random amount after applying the initial 9 MP cost, just cost a fixed 10 MP. -------------------------------------------------------------------------------- ee812e9 | Chris Campbell | 2016-12-26 16:28:39 +0000 Randomise some fixed piety costs Enter the Abyss and Beogh Resurrection both had high fixed piety costs. Use the normal piety randomisation instead (with the same average cost). -------------------------------------------------------------------------------- 53eb1ea | Chris Campbell | 2016-12-26 16:26:19 +0000 Let Kryia's armour affect Deep Dwarves Since it no longer interacts with wands of heal wounds (or their replacement innate healing ability), there's no particular need for it to be special-cased. -------------------------------------------------------------------------------- 303077c | Chris Campbell | 2016-12-26 16:22:59 +0000 Rename "no device heal" to "no potion heal" Since that's all that it now affects. -------------------------------------------------------------------------------- c9b4002 | Nicholas Feinberg | 2016-12-23 21:40:38 -0800 Changelog through 0.20-a0-350-ga83eecc -------------------------------------------------------------------------------- a83eecc | Nicholas Feinberg | 2016-12-22 19:42:22 -0800 De-duplicate duplication messages Redundant with the message printed in mon-clone.cc. -------------------------------------------------------------------------------- 200756e | Nicholas Feinberg | 2016-12-22 19:08:10 -0800 Visually mark awakened trees in tiles As in console. -------------------------------------------------------------------------------- d709e23 | Nicholas Feinberg | 2016-12-22 11:19:01 -0800 Fix a copy-paste error (johnny0) oops... -------------------------------------------------------------------------------- 609f6b5 | Nicholas Feinberg | 2016-12-22 09:21:55 -0800 COMPILE_CHECK aptitudes.h -------------------------------------------------------------------------------- d0bbeaa | Nicholas Feinberg | 2016-12-22 09:20:58 -0800 Re-add a removed skill for a removed race Broke a nice assertion. -------------------------------------------------------------------------------- bfb25ec | Nicholas Feinberg | 2016-12-21 17:44:51 -0800 Clarify Summon Guardian Golem description It wasn't really clear at all how the inner flame mechanic worked, or that it existed at all, really - 'overheats' doesn't convey that unless you already know what it means! -------------------------------------------------------------------------------- 34bdcb4 | Nicholas Feinberg | 2016-12-21 16:57:33 -0800 autofight_stop default: 30->50 (Haifisch) Stopping autofight at 30% hp was generally considered to be very low/late; one of the most common pieces of advice to new players was 'raise your autofight_stop!' Let's make our defaults better, instead. -------------------------------------------------------------------------------- 5843844 | Nicholas Feinberg | 2016-12-21 16:54:34 -0800 Update fencer's gloves' description Out of date, since the riposte odds were changed from 50/100% to 33/67%. -------------------------------------------------------------------------------- 68e89da | ontoclasm | 2016-12-21 18:52:04 -0600 DD HW ability tile -------------------------------------------------------------------------------- d2ba6e4 | Isaac Sloat | 2016-12-21 18:41:20 -0600 Give ecumenical altars a real tile (removeelyvilon) -------------------------------------------------------------------------------- e549106 | Isaac Sloat | 2016-12-21 17:29:02 -0600 Allow helmet acquirement Fixes a 21-month-old (0376bd90) bug where even if you could equip helmets you would only ever get hats from acquirement. MB_MAYBE means the player can only equip certain items for that slot, used here to mean mean "If the player can't wear helmets, give them either a helmet or a hat.". This went unnoticed because acquirement vetoes useless items, so Minotaurs et al never received helmets matching expected behavior. -------------------------------------------------------------------------------- 8ddb3e8 | Chris Campbell | 2016-12-21 22:38:17 +0000 Don't let Black Mark work on monsters with no attacks -------------------------------------------------------------------------------- 717130a | Nicholas Feinberg | 2016-12-21 08:36:31 -0800 Simplify prompt_invent_items() It was called by exactly one function, so it probably didn't need ten (!!!) different params. Let's cut it down to one, and rename it appropriately. Note that it still duplicates a ton of prompt_invent_item() code; ideally the two should be merged. -------------------------------------------------------------------------------- e03b16e | Neil Moore | 2016-12-21 09:21:20 -0500 Class-ify and rename inv_prompt_flags. Use the plural for the field and the singular for the flag. Also use a shorter name for the flag because "invent_prompt_flag::manual_list" is a bit much to write. Leave invprompt_flag::none as a "flag" even though it is really an empty field: That way it stays in the same namespace as everything else. -------------------------------------------------------------------------------- 7b05759 | Nicholas Feinberg | 2016-12-20 22:43:52 -0800 Fix a prompt_invent_item misunderstanding -------------------------------------------------------------------------------- 3db6753 | Nicholas Feinberg | 2016-12-20 22:39:35 -0800 Avoid mis-selections of useless items Only allow e.g. wielding non-weapons with * (w*c), or with @w1 or other techniques. Should hopefully avoid unfortunate accidents. Closes #416. -------------------------------------------------------------------------------- d6844ec | Nicholas Feinberg | 2016-12-20 21:53:10 -0800 Remove two seemingly long-unused params For prompt_invent_item(). excluded_slot seems to have been for reading un-id'd scrolls that operated on items (?ea, ?ew1/2, etc); those of course no longer exist. count dates back to the dawn of time, and i haven't the faintest what it was used for or when it became irrelevant. -------------------------------------------------------------------------------- 011acc8 | Nicholas Feinberg | 2016-12-20 21:51:46 -0800 Refactor prompt_invent_item() params Turn five bools into a bitfield, and reorder params to avoid unecessary complication. -------------------------------------------------------------------------------- c925ad2 | Nicholas Feinberg | 2016-12-20 21:51:46 -0800 Finish removing unused trap params Oops... -------------------------------------------------------------------------------- 5b3579f | Isaac Sloat | 2016-12-20 22:53:31 -0600 Buff Earth Elementalist starts by 50% Give them 30 (instead of 20) stones on character generation, to compensate for new Sandblast behavior. -------------------------------------------------------------------------------- d91524c | Isaac Sloat | 2016-12-20 22:53:30 -0600 Update Sandblast/Earth Elementalist descriptions [skip ci] -------------------------------------------------------------------------------- dd029aa | Isaac Sloat | 2016-12-20 22:53:30 -0600 Clean up a conditional in is_useless_item As well as remove a check for large rocks, as they're no longer used in Sandblast. -------------------------------------------------------------------------------- 21fc545 | Isaac Sloat | 2016-12-20 22:53:30 -0600 Prune an unused function -------------------------------------------------------------------------------- a533876 | Isaac Sloat | 2016-12-20 22:53:30 -0600 Make Sandblast range baseline Instead of a special case. -------------------------------------------------------------------------------- bbeb9b0c | Isaac Sloat | 2016-12-20 22:53:29 -0600 Remove large and small ZAP_*SANDBLASTs -------------------------------------------------------------------------------- ef5153f | Isaac Sloat | 2016-12-20 22:53:29 -0600 Rework and simplify Sandblast Condense the three different zaps for Sandblast into one. Quality of life improvement: use stones from inventory instead of requiring that the player wield stones to boost the spell. As a result, it's necessary that the large and small versions of Sandblast are removed: it would have encouraged strategic stone dropping to manipulate the spell's behavior. The new Sandblast works like Sticks to Snakes: consumes a missile in your inventory to power the spell. There is no fallback anymore for this spell, if you're out of stones you can no longer cast Sandblast. RIP Ogre/Troll Earth Elementalists. (Not really, they'll still be fine.) -------------------------------------------------------------------------------- 149db07 | CanOfWorms | 2016-12-20 23:23:25 -0500 Fix a connectivity problem with the_grid -------------------------------------------------------------------------------- 86bbc9b | Chris Campbell | 2016-12-20 23:52:05 +0000 Give Mummies a +2 Spellcasting aptitude To partially imitate Ogres' old aptitude pattern of high spellcasting but low spell schools, which was a fairly interesting feature lost by their rework - Mummies also have a similar thing already with their +0 Fighting and -2 weapon aptitudes. -------------------------------------------------------------------------------- 1b51c6c | Chris Campbell | 2016-12-20 23:08:59 +0000 Make heal wounds, hasting and teleportation consumables slightly more common To partially compensate for the removal of the wands. The weight comes out of useless potions/scrolls (degeneration/noise/random effects). -------------------------------------------------------------------------------- 718b551 | Chris Campbell | 2016-12-20 23:08:59 +0000 Adjust some wand acquirement weights Give some weak wands a tiny bit more weight - they're not likely to be a desirable acquirement target, but are probably better than random effects or flame. -------------------------------------------------------------------------------- a6f7038 | Chris Campbell | 2016-12-20 23:08:59 +0000 Remove wands of hasting and teleportation As per wands of heal wounds. -------------------------------------------------------------------------------- 6aafc7b | Chris Campbell | 2016-12-20 23:08:59 +0000 Replace DD recharging with a heal wounds ability Since the ability to recharge wands is pretty unhelpful without their starting wand of heal wounds, instead give them an ability to directly apply the heal wounds effect. Each use has a chance of rotting maxMP, with a roughly similar chance to the number of charges that would've been gained from recharging a wand instead. -------------------------------------------------------------------------------- 2007a24 | Chris Campbell | 2016-12-20 23:08:59 +0000 Remove wands of heal wounds The top-tier wands (heal wounds, hasting, and teleportation) all share multiple problems. They all provide effects that work best in a limited form (as per Haste and Teleport Self spell removals in the past), but finding any of the wands results in a very large boost to the amount available - with recharging scrolls often to the point of no longer being practically limited. They also don't require/reward Evocations investment like damage/hex wands, and can't really be changed to do so without making them provide a new version of the effect compared to the potions/scrolls. -------------------------------------------------------------------------------- c038824 | Neil Moore | 2016-12-20 02:26:15 -0500 Accept "lang = C" as a synonym for EN. In case someone decides to set it from the locale. -------------------------------------------------------------------------------- 5d5805e | Neil Moore | 2016-12-20 02:26:15 -0500 Class-ify {,f}lang_t, and dataify set_lang() -------------------------------------------------------------------------------- 8346a86 | Corin Buchanan-Howland | 2016-12-19 18:45:56 -0500 Clean up Sac Courage's effect on spellpower Make it slightly close to the way that Augmentation increases spellpower. This is intentionally not quite as clean as -10% to spellpower in order to prevent very large Horror levels from reducing spellpower to 0 or below. Also, remove an inaccurate comment. -------------------------------------------------------------------------------- 2b7a7a5 | Corin Buchanan-Howland | 2016-12-19 18:36:29 -0500 Perform a funectomy on Augmentation Reduce the Augmentation slaying and spellpower bonus from +4/+40% to +3/+30% per level. It should still be pretty fabulous, but slightly more balanced. -------------------------------------------------------------------------------- 10ed074 | Isaac Sloat | 2016-12-19 13:46:03 -0600 Correct a value (|amethyst) A dumb error in 85fd691b71e8. -------------------------------------------------------------------------------- 85fd691 | Isaac Sloat | 2016-12-19 12:09:13 -0600 Fix damage modifiers at 9 and 11 Str (Roleplayer) Fixes a bug that was touched, but not solved, in 6c060d3771dd. -------------------------------------------------------------------------------- 0840a6e | Nicholas Feinberg | 2016-12-19 09:47:35 -0800 Remove support for the old tutorial map poisoned_needle_trap has been unused since 536ad4b089, over five years ago. -------------------------------------------------------------------------------- 3286b33 | Nicholas Feinberg | 2016-12-19 09:45:08 -0800 Rename an archaic trap attribute TODO: remove this along with the rest of mechanical traps :) -------------------------------------------------------------------------------- cba9277 | Chris Campbell | 2016-12-17 22:17:06 +0000 Don't allow self-targeting lightning rods -------------------------------------------------------------------------------- 9000d6b | Chris Campbell | 2016-12-17 21:24:05 +0000 Make more of the Slime vault collapse -------------------------------------------------------------------------------- d0bf4df | Chris Campbell | 2016-12-17 21:03:27 +0000 Use a canned message -------------------------------------------------------------------------------- fb573b8 | Chris Campbell | 2016-12-17 20:08:52 +0000 Tweak wand descriptions again -------------------------------------------------------------------------------- 9f9577c | Chris Campbell | 2016-12-17 19:31:20 +0000 Update some spell/wand descriptions -------------------------------------------------------------------------------- ed96f7e | Chris Campbell | 2016-12-17 15:03:33 +0000 Make infestation scarab-creation into a fineff (#10848) To fix newly-created scarabs being turned hostile when killing their host in an explosion. -------------------------------------------------------------------------------- 575bbf7 | x0_000 | 2016-12-15 22:18:10 -0500 Update some code to item_brand_known -------------------------------------------------------------------------------- eba3175 | x0_000 | 2016-12-15 22:17:34 -0500 Don't leak speed brand when examining inventory Examining a weapon in inventory would reveal if it had the speed brand through the min delay because it didn't check if the brand was pre-identified. This fixes that, as well as adding a new function to check if the brand was known (which will be applied in a few places in a future commit.) -------------------------------------------------------------------------------- 264e157 | Nicholas Feinberg | 2016-12-15 14:15:51 -0800 Clarify a misleading penance message (|amethyst) -------------------------------------------------------------------------------- cb9538e | Nicholas Feinberg | 2016-12-15 14:13:35 -0800 Don't allow resting while on fire (UsaSatsui) As with dangerous clouds. It'd only rest for one turn, but that's a bit too long... -------------------------------------------------------------------------------- ec7c366 | Isaac Sloat | 2016-12-14 15:49:50 -0600 Remove Nemelex evocations reference (10847) [skip ci] -------------------------------------------------------------------------------- 82a587e | Isaac Sloat | 2016-12-14 13:27:32 -0600 Hyphenate carved runes [skip ci] -------------------------------------------------------------------------------- 2473c33 | Nicholas Feinberg | 2016-12-14 11:23:27 -0800 Tweak Slime:$ wall collapse (regret-index) Instead of collapsing all of the walls on TRJ's death (a nasty trap that's hard to de-spoil effectively, and one that makes Slime a less viable third rune choice), just collapse a few, transparent walls. Save compat turns old slime walls transparent, for those who've entered slime:5 but not killed TRJ yet. -------------------------------------------------------------------------------- f222164 | Chris Campbell | 2016-12-14 01:46:44 +0000 Adjust manual entry for Trolls -------------------------------------------------------------------------------- ab3cf41 | gammafunk | 2016-12-14 01:37:09 +0000 Remove High Elves High elves were a relatively uninteresting species in terms of gameplay, feeling somewhat like tengu but with weapon specialization like merfolk. Their theme originates from Tolkien, a source of lore that crawl is trying to borrow less from these days. Their gorgeous blonde hair not withstanding, this particular Tolkien reference wasn't particularly interesting. [Especially with Ogres now also having newly-improved casting apts, there's a very wide range of hybrid/magic-oriented species, with High Elves being increasingly redundant. -MarvinPA] -------------------------------------------------------------------------------- 8e39459 | Chris Campbell | 2016-12-14 01:37:09 +0000 Increase Ogre spellcasting apts, decrease M&F apt As an alternative to the proposal of Basajaunak as a large caster race, instead let Ogres take more advantage of their Ogre Mage heritage, with -1 spell school apts across the board. Also give them more starting int but less str/dex, and significantly decrease their M&F apt - they're still uniquely able to make the most of GSCs but now require more of an investment to do so (and might feasibly consider other weapon types too), and the extra XP cost for GSC usage is likely more than made up for by the XP saved on spell schools. -------------------------------------------------------------------------------- 98a595e | Chris Campbell | 2016-12-14 01:36:04 +0000 Adjust some more coinflips -------------------------------------------------------------------------------- 973fd98 | Chris Campbell | 2016-12-14 01:34:33 +0000 Fix compilation -------------------------------------------------------------------------------- 5ec54a4 | Neil Moore | 2016-12-13 18:48:30 -0500 Remove an unnecessary duplicate check. It was unnecessary both because Summon Dragon is no longer a player spell, and because _choose_dragon_type already handles this case. -------------------------------------------------------------------------------- 6c7fa28 | Neil Moore | 2016-12-13 18:48:30 -0500 Use random_choose instead of coinflip ? a : b. Also random_range in a few places, and random_choose_weighted in a few others. I only caught instances where the coinflip(), ?, and : appeared on the same line. -------------------------------------------------------------------------------- fac7ad8 | Isaac Sloat | 2016-12-13 17:27:35 -0600 Grant gods to demonspawn, too -------------------------------------------------------------------------------- f1302a7 | Isaac Sloat | 2016-12-13 17:27:35 -0600 Make stormcallers follow Qazlal -------------------------------------------------------------------------------- 451e901 | Isaac Sloat | 2016-12-13 17:27:35 -0600 Lower foe_ratio on monster Upheaval Increases the chances that stormcallers will decide to blast the player with Upheaval even if the player is surrounded by allies of the stormcaller. Because Zot draconians and dragons have high HD, this means that stormcallers will, most of the time, only blast summoned drakes. -------------------------------------------------------------------------------- ae82e34 | Chris Campbell | 2016-12-13 22:20:26 +0000 Unbrace -------------------------------------------------------------------------------- ea62d72 | Chris Campbell | 2016-12-13 21:33:13 +0000 Remove some removed items from a vault -------------------------------------------------------------------------------- 0034d1e | Isaac Sloat | 2016-12-13 14:17:06 -0600 Buff ogre mage bands Spawn two 2HO and one ogre, instead of one and two. Ogre mage bands were tab fodder in late Dungeon, let alone Vaults and especially Depths. Giving them more and meaner protectors might make them matter more -- if not, then perhaps they should be moved out of Depths and slightly earlier into the game. -------------------------------------------------------------------------------- 5be6507 | Isaac Sloat | 2016-12-13 14:17:06 -0600 Generate 2HO more frequently They should be somewhat more than twice as common in Dungeon, expanding into the vacuum left by hill giant removal. -------------------------------------------------------------------------------- 4a29806 | Isaac Sloat | 2016-12-13 14:12:05 -0600 Buff two-headed ogres Makes them noticeably nastier than regular ogres and puts them closer to ogre-mage threat levels. Old stats: 6 HD, 33 HP, 1 AC, 4 EV, 17/13 damage New stats: 10 HD, 55 HP, 3 AC, 6 EV, 20/15 damage -------------------------------------------------------------------------------- 305f104 | Isaac Sloat | 2016-12-13 14:12:05 -0600 Remove hill giants There's no real need to have an "introductory" giant, and their vanilla status dilutes the rest of the giants. Cyclops and ettins work better as an early set of giants (compare mid fire/frost/stone and then late titan/juggernaut/iron). Vault surgery has been performed, with two-headed ogre for the most part taking their place. 2HO are being buffed in oncoming commits, and threat level between hill giant / 2HO should remain more or less the same for these affected vaults. -------------------------------------------------------------------------------- 7acc565 | Nicholas Feinberg | 2016-12-13 10:08:53 -0800 Fix spl-cast compile warnings Superfluous braces! -------------------------------------------------------------------------------- 7481458 | Nicholas Feinberg | 2016-12-13 09:22:35 -0800 Mention J's pseudo-TRJ effect (Darox) Should probably also be mentioned in Jiyva powers, but I'm undecided (and don't have a good phrasing in mind). -------------------------------------------------------------------------------- 49f15a8 | Isaac Sloat | 2016-12-13 10:07:15 -0600 Allow TSO followers to summon golden dragons (10845) TSO no longer hates poison, which was why they were previously excluded. -------------------------------------------------------------------------------- 7db01f4 | gammafunk | 2016-12-10 17:12:02 -0600 Merge pull request #422 from aheckler/master Correct link to crawl_manual.rst -------------------------------------------------------------------------------- 45545e5 | Adam Heckler | 2016-12-10 18:04:14 -0500 Correct link to crawl_manual.rst -------------------------------------------------------------------------------- a90a6c4 | Chris Campbell | 2016-12-10 21:59:04 +0000 Update manual information on max MP -------------------------------------------------------------------------------- 7b51309 | Chris Campbell | 2016-12-10 18:30:39 +0000 Prevent learning removed spells In cases where they still exist e.g. in transferred randbooks. -------------------------------------------------------------------------------- 531f2bb | Chris Campbell | 2016-12-10 17:56:41 +0000 Remove Cure Poison from some vault-defined books (#10842) And give the books normal weights instead of mysteriously large ones. -------------------------------------------------------------------------------- 1b7fb01 | Chris Campbell | 2016-12-10 17:49:58 +0000 Remove an unused ability flag Obsolete since ZotDef removal. -------------------------------------------------------------------------------- dd95005 | Chris Campbell | 2016-12-10 17:49:16 +0000 Mark scrolls of noise as bad instead of dangerous Since they're no longer useful for breaking mesmerisation/fear. -------------------------------------------------------------------------------- 8e735b6 | Corin Buchanan-Howland | 2016-12-08 21:47:49 -0500 Don't give an MP regen bonus before amulet of MPRegen is attuned (alexjurkiewicz) -------------------------------------------------------------------------------- 17f5411 | Isaac Sloat | 2016-12-07 13:10:09 -0600 Merge wand and misc acquirement into "Evocables". Distribution is 1/8 chance of getting a rod, else coinflip for wand or misc evocable. This maybe needs further adjustment. -------------------------------------------------------------------------------- b6bde61 | gammafunk | 2016-12-05 23:35:00 -0600 Tweak a mailmap entry -------------------------------------------------------------------------------- 4a7ec2a | Chris Campbell | 2016-12-06 02:15:53 +0000 Adjust skill checks for staff acquirement When deciding which enhancer staff to try and acquire, just look at spell schools instead of also including evocations (no longer relevant since rods are handled by misc acquirement) and spellcasting (since otherwise having spellcasting higher than your spell schools makes it acquiring a relevant enhancer staff far less likely). The decision on which enhancer staff to try and pick should really be weighted by skill instead of just being strictly based on which skill is highest, though. -------------------------------------------------------------------------------- dedccd6 | Nicholas Feinberg | 2016-12-04 08:19:28 -0800 Use an early return for ugly thing colour Closes #420. ^ the funny number...... -------------------------------------------------------------------------------- b1c82ab | John Olender | 2016-12-04 08:18:52 -0800 place_monster(): Factor out ugly thing band colouring. -------------------------------------------------------------------------------- 38049aa | John Olender | 2016-12-04 08:18:47 -0800 Only set an ugly thing band colour for fully-ugly bands (#8343). This is a two-part fix: 1. Only apply a uniform ugly thing colour to a band if the band contains *only* ugly things. 2. Don't let a failed ugly thing band placement influence the colour of the next call to place_monster(). -------------------------------------------------------------------------------- 81abdfb | Chris Campbell | 2016-12-03 20:37:50 +0000 Don't allow cancelling movement for free when confused and barbed (#10838) Make the prompt display before redirecting movement when confused, so that it still displays regardless of whether the movement ends up being redirected into an attack or not. -------------------------------------------------------------------------------- 358a8cc | Chris Campbell | 2016-12-03 18:28:12 +0000 Make Nemelex wrath reclaim all decks When abandoning Nemelex, all decks are revoked. As a result, Nemelex wrath no longer has the lingering passive component of swapping out cards for punishment cards, only the active punishment effects. Various places (such as card power calculations) now assume that it's not possible to be in possession of any decks without worshipping Nemelex, and save compat handling removes decks from anyone who's worshipped Nemelex in the past. -------------------------------------------------------------------------------- cb1eca7 | Chris Campbell | 2016-12-02 14:31:20 +0000 Make Zin penance end sanctuary Breaking sanctuary by attacking caused penance, but the reverse wasn't true when (for example) gaining penance by casting necromancy spells while under sanctuary. -------------------------------------------------------------------------------- b24ad0c | Chris Campbell | 2016-12-02 14:31:15 +0000 Simplify handling of TSO, Makhleb, Trog allies on abandonment Since all of these are summons and can't follow across floors any more, don't use dactions to make them go hostile wherever they are in the dungeon. Instead just make all these allies disappear on abandonment (also removing various extra special-casing for TSO allies to go neutral on converting to other good gods). -------------------------------------------------------------------------------- c929cd2 | Nicholas Feinberg | 2016-12-01 17:01:07 -0800 Fix webtiles Divine Shield highlight (johnny0) Broken by 8ce114c4a87b. -------------------------------------------------------------------------------- f5ffb0e | Nicholas Feinberg | 2016-12-01 12:21:22 -0800 Update Chilling Breath description -------------------------------------------------------------------------------- cba8977 | Nicholas Feinberg | 2016-12-01 12:11:52 -0800 Make monster white drac breath check AC (minmay) Honestly thought this happened a long time ago. (It started ignoring AC in b45f3dca4.) Weird, surprising, unjustified special case. A strong justification is needed to justify ignoring AC. -------------------------------------------------------------------------------- abb291d | Chris Campbell | 2016-11-30 22:30:08 +0000 Make wizmode superhealing remove weakness -------------------------------------------------------------------------------- 9f7bdd3 | Chris Campbell | 2016-11-30 22:16:11 +0000 Adjust monster damage descriptions Feels like an improvement, but could probably still do with reworking somehow for more clarity and less wordiness. -------------------------------------------------------------------------------- f93e2a1 | CanOfWorms | 2016-11-30 15:59:00 -0500 Paint it red Speciifically, the spriggan rider mounts since wasps no longer exist. -------------------------------------------------------------------------------- 627bfb6 | Nicholas Feinberg | 2016-11-30 09:21:40 -0800 Changelog updates through 0.20-a0-252-gcc89fee -------------------------------------------------------------------------------- cc89fee | Chris Campbell | 2016-11-30 13:24:18 +0000 Fix acid dragon scales randarts not displaying rCorr (ProzacElf) -------------------------------------------------------------------------------- 16a58bf | Neil Moore | 2016-11-29 22:03:56 -0500 Add a couple of altar quotes (#10834) [skip ci] -------------------------------------------------------------------------------- 85c58e0 | Neil Moore | 2016-11-29 21:55:36 -0500 Class-ify an enum. -------------------------------------------------------------------------------- c814f40 | Neil Moore | 2016-11-29 21:55:36 -0500 Checkwhite. [skip ci] -------------------------------------------------------------------------------- a311f3f | Nicholas Feinberg | 2016-11-29 18:23:33 -0800 Replace an int return value with an enum For elyvilon_lifesaving(). -------------------------------------------------------------------------------- a1ad696 | Alex Jurkiewicz | 2016-11-30 12:59:37 +1100 Rework minmay_smoke_and_mirrors (minmay) < minmay> changes: doesn't generate in depths, just has wizards, a little less nuts loot, more consistent monster density < minmay> and it has warlock's mirror -------------------------------------------------------------------------------- 0f58866 | Nicholas Feinberg | 2016-11-29 16:55:17 -0800 Merge pull request #411 from johnny-0/flip_colour_prefer_background_change Adjust the background colour for invisible flipped colours (|amethyst) -------------------------------------------------------------------------------- 4747f57 | Isaac Sloat | 2016-11-29 18:52:11 -0600 Fix spirit shield interaction with waking (|amethyst) Fixes a case where a player who took exactly their current health in damage but had it reduced below fatal via Spirit Shield wouldn't wake up. -------------------------------------------------------------------------------- 2162eaf | Nicholas Feinberg | 2016-11-29 16:48:53 -0800 Hints mode/tutorial text tweaks The berserk hint was out of date; others were slightly unclear. -------------------------------------------------------------------------------- 8dd271d | Roarke | 2016-11-29 16:48:53 -0800 Change Louise's Weapon List Give Louise a short list of one-handed weapons to fit her shield, and give her a good item to make the new list more impactful. Closes #417. -------------------------------------------------------------------------------- ffcfc1b | Isaac Sloat | 2016-11-29 18:28:37 -0600 Don't let killing blows wake sleeping characters Allows us to track which characters were killed while sleeping. -------------------------------------------------------------------------------- e0d8a1c | Nicholas Feinberg | 2016-11-29 15:34:41 -0800 Fix the tutorial typo (chequers) -------------------------------------------------------------------------------- 409887a | Aaron Golden | 2016-11-29 15:34:29 -0800 Add a symlink to init.txt for Mac OS X users Mac OS X users will never expect to find init.txt inside the .app bundle. The standard place for such files on Mac OS X is in ~/Library/Application Support/, so on startup we should put a symbolic link to whatever init.txt file we're going to use in ~/Library/Application Support/Dungeon Crawl Stone Soup (or wherever we're putting morgue and saves anyway). Note that symlink will not overwrite an existing file. Closes #385. -------------------------------------------------------------------------------- f5528ca | Nicholas Feinberg | 2016-11-29 15:18:30 -0800 Merge pull request #414 from aegolden/FixMakefilePrefix Prevent Makefile from blowing away the prefix and chroot_prefix -------------------------------------------------------------------------------- f5c78d3 | Aaron Golden | 2016-11-29 15:17:22 -0800 Rename APPLE_GCC to APPLE_PLATFORM This variable reflects whether or not the Makefile's detected a Darwin environment, and really doesn't have anything to do with gcc, so let's call it just APPLE_PLATFORM instead of APPLE_GCC. Nowadays Apple machines are typically building with clang. Closes #400. -------------------------------------------------------------------------------- 5d318e2 | Aaron Golden | 2016-11-29 15:12:42 -0800 Simplify Mac OS X build instructions in INSTALL.txt APPLE_GCC and NO_PKGCONFIG are both set automatically when the Makefile detects uname -s == Darwin, and CONTRIB_SDL is not used anywhere in the Makefile and has no effect. On Mac OS X you can build console with just "make" and tiles with "make TILES=y" -------------------------------------------------------------------------------- 78c6870 | Aaron Golden | 2016-11-29 15:12:42 -0800 Remove logic related to trying to find oldest available Mac OS X SDK We don't need to try to find the oldest available Mac OS X SDK. It's perfectly fine to build against the latest available SDK (which is the default behavior if we specify no SDK root) and to target a hard coded earlier Mac OS X version. -------------------------------------------------------------------------------- aebe036 | Aaron Golden | 2016-11-29 15:12:42 -0800 Change Mac OS X build arguments There is no reason to specify the SDK root because we can always build with the latest available Mac OS X SDK. The minimum version of Mac OS X that the binary supports can be less than the SDK with which the binary was built. We can set the deployment target all the way back to 10.7 as long as we also build using clang's libc++ instead of gcc's libstdc++. Strangely, if you try to set the deployment target less than 10.9 and use libstdc++, some necesary headers (e.g. cinttypes) are not found in the standard places. But this is not a problem if we build using clang's libc++. -------------------------------------------------------------------------------- 355e7a9 | Alex Jurkiewicz | 2016-11-29 15:10:54 -0800 Add the orb status light whenever in Zot Also, add a status help entry for 'Orb'. Closes #390. -------------------------------------------------------------------------------- 867de38 | Nicholas Feinberg | 2016-11-29 15:01:26 -0800 Make 'spreading flames' non-opaque (Aka 'forest fires'.) The reasoning, I suppose, was that there were still trees inside blocking some vision, except that single trees now block LOS (whereas opaque clouds take 2), and nothing in the name, description or tile of the clouds hinted at that...? -------------------------------------------------------------------------------- 7dccb13 | Nicholas Feinberg | 2016-11-29 14:57:12 -0800 Remove fast dissipation for opaque non-LOS clouds Steam clouds and forest fires are the only damaging opaque clouds the player can create, and neither is particularly easy to abuse. -------------------------------------------------------------------------------- 53ab4a8 | Nicholas Feinberg | 2016-11-29 14:56:10 -0800 Simplify ink cloud special cases Made silly by e6e0e65fc82d. -------------------------------------------------------------------------------- e6e0e65 | Chris Campbell | 2016-11-29 20:48:09 +0000 Adjust some cloud/terrain interactions Don't make fire/cold clouds time out faster over water/lava respectively, and don't make rain/storm clouds cause ring of flames to end prematurely. Also substantially reduce the amount of steam placed by fire clouds and beams when placed over water. -------------------------------------------------------------------------------- 74fa834 | Chris Campbell | 2016-11-29 20:02:24 +0000 Don't make noise affect mesmerisation/fear It was a very well-hidden interaction that was unlikely to be useful even for anyone who did know about it. -------------------------------------------------------------------------------- 7ac7cdc | Chris Campbell | 2016-11-29 15:14:39 +0000 Fix vault warden description (#10816) -------------------------------------------------------------------------------- c242636 | gammafunk | 2016-11-29 06:56:18 -0600 Don't down-weight a vault and make most of its monsters non-patrolling This vault recently got nerfs place fewer monsters and specifically fewer hydras, so it doesn't need any special down-weighting. Remove a very small down-weighting for choosing hydras over dire elephants, since these are comparable threats and the number of either that place in this vault is much less than one on-average. Also remove the patrolling tag on all monsters except the avatar. The other vault monsters work fine outside the vault on land, and extensive use of patrolling will lead the player to shout a lot more. -------------------------------------------------------------------------------- 410101a | Alan Malloy | 2016-11-29 00:41:22 -0800 Merge pull request #415 from aegolden/FixCardToolTip Remove special case for tiles tool tip for cards (fixes #391) -------------------------------------------------------------------------------- 066d66b | regret-index | 2016-11-29 01:29:52 -0500 Nerf ushabti miasma spam, fix up tomb fodder sets again Giving ushabti miasma blasts without changing their spell rate, then folding anubis guards into them to thus bring them to nearly every Tomb floor, is a brutally excessive amount of rot and cloud spam. They appear in much more reliable and swarming numbers than the rare death drakes, get reliable support on average than death drakes with mummy summons, and don't have the draconic breath timer (...outside of Warning Cry, which is silly but whatever). Cut the chance of Death Rattle casts from 57/200 to 36/200. Also, provide a third tomb fodder set that doesn't use either of the awkward replacements meant to dilute guardian mummy curse bombing, a set that relies more on providing less than miniscule odds to place ancient champions and bennu. Not the cleanest of solutions, but if Tomb can't pull together enough fodder to provide coherent variety for the length it wants then we should probably review what's currently there as stands (death scarabs are stuck in an awkward limbo now, death curse effects themselves could be cleaned up). -------------------------------------------------------------------------------- b69ddcd | Alan Malloy | 2016-11-28 18:54:55 -0800 Simplify displaying an affirmation to Zin. if (one_chance_in(9) && one_chance_in(3)) {...} // :( -------------------------------------------------------------------------------- 9481238 | Alan Malloy | 2016-11-28 17:47:28 -0800 Ashenzari messages? In my Zin verses? (damerell) Fix #10832, introduced in cc38ccbfa -------------------------------------------------------------------------------- 4ebf0c7 | Alan Malloy | 2016-11-28 17:37:45 -0800 Simplify citing chapter and verse for Zin recite -------------------------------------------------------------------------------- 21f8257 | Nicholas Feinberg | 2016-11-28 11:23:24 -0800 Improve Elixir card messaging In play, it was totally unclear what it did, if anything. -------------------------------------------------------------------------------- 1c5f1cc | Nicholas Feinberg | 2016-11-28 11:23:24 -0800 Pain card level 2 rework Pain card's level 2 summoned a flayed ghost and instantly flayed every natural monster onscreen. This was pretty much always worse than level 1! Rework: - Change the flaying from a single level of normal Flay (~20% of monster HP) to 40% of their HP. Of course, once the ghost goes down, all that HP will come right back... - If there's no space to spawn the flayed ghost, downgrade to level 1 (Bolt of Draining) instead of silently failing. - Don't deal 5 damage to the player. -------------------------------------------------------------------------------- 17e8ceb | Chris Campbell | 2016-11-27 19:01:42 +0000 Adjust a god worship message -------------------------------------------------------------------------------- 962fb7d | Chris Campbell | 2016-11-27 19:01:02 +0000 Remove obsolete Nemelex/sac artifice handling -------------------------------------------------------------------------------- a0e9fd5 | Chris Campbell | 2016-11-27 18:06:51 +0000 Fix pizza syntax -------------------------------------------------------------------------------- c881eda | Aaron Golden | 2016-11-26 20:51:11 -0800 Remove special case for tiles tool tip for cards (fixes #391) Cards are now evoked like normal miscellany type objects, so there shouldn't be a special case to say left clicking cards will "wield" them. -------------------------------------------------------------------------------- b74cb0e | CanOfWorms | 2016-11-26 17:26:40 -0500 Tweak iron imp tiles (Yermak) Differentiate them more from skeletons on the ground. -------------------------------------------------------------------------------- c646d03 | Nicholas Feinberg | 2016-11-26 11:20:13 -0800 Uncomment an assert Accidentally left in with the last commit. -------------------------------------------------------------------------------- 73c396f | Nicholas Feinberg | 2016-11-26 11:17:27 -0800 Fix nondeterministic spectral hydra descriptions Something of a hack, sorry. -------------------------------------------------------------------------------- b8fcc81 | Nicholas Feinberg | 2016-11-26 10:53:28 -0800 Fix a zombified hydra crash (wazuzu) -------------------------------------------------------------------------------- 454d93f | Aaron Golden | 2016-11-26 10:39:46 -0800 Prevent Makefile from blowing away the prefix and chroot_prefix The Makefile was initializing prefix and chroot_prefix to empty strings, but never actually wrote anything "useful" to these variables. The builder is meant to be able to specify prefix (per the examples in the Typical parameters notes at the top of the Makefile). chroot_prefix is also probably meant to be specified similarly, though it seems to be an undocumented option. -------------------------------------------------------------------------------- d6c29eb | Chris Campbell | 2016-11-26 01:07:49 +0000 Fix messaging for enchanting scales (#10827) -------------------------------------------------------------------------------- de3baf9 | Nicholas Feinberg | 2016-11-25 07:41:36 -0800 Revert "Add two flavour vaults to Pan." (10821) Putting a portal to Zot in Pan really, really breaks things! This reverts commit 41cc41e0000da643753aa7e5981967ce1a43f225. -------------------------------------------------------------------------------- 55166f7 | Pekka Lampila | 2016-11-24 20:52:13 +0200 Fix two version tag tests. -------------------------------------------------------------------------------- e566022 | Chris Campbell | 2016-11-24 17:56:44 +0000 Remove unused code -------------------------------------------------------------------------------- a7b90b8 | Chris Campbell | 2016-11-24 17:46:02 +0000 Don't colour poison spells/abilities red under TSO (johnny0) -------------------------------------------------------------------------------- 89283e9 | Nicholas Feinberg | 2016-11-24 09:08:59 -0800 Fix a enum.h comment Thought I'd included this in the last commit, but I only ran --amend, not -a --amend... -------------------------------------------------------------------------------- e9bc5e3 | Alex Jurkiewicz | 2016-11-23 21:28:48 -0800 Don't count Abyss gold for Gozag's service fee Currently, wandering through the Abyss (say AK starts) can inflate the service fee beyond what the player has actually accessible to them. Closes #409. -------------------------------------------------------------------------------- 08ddd88 | Nicholas Feinberg | 2016-11-23 21:19:01 -0800 Merge pull request #403 from alexjurkiewicz/qaz-firewood Don't create Qaz clouds over firewood -------------------------------------------------------------------------------- 851c6fa | Isaac Sloat | 2016-11-23 22:20:54 -0600 Add version tags to a bugfix (gammafunk) So it gets caught when we update versions. -------------------------------------------------------------------------------- 18a743d | Isaac Sloat | 2016-11-23 22:10:50 -0600 Truly remove mottled draconians (alcopop) -------------------------------------------------------------------------------- bc1e2de | Alex Jurkiewicz | 2016-11-24 11:38:48 +1100 Don't create Qaz clouds over firewood (Yermak) The messages generated by burning/freezing flora made resting in certain places (especially lair) quite spammy/tedious. Hopefully doesn't prevent any cool tech? -------------------------------------------------------------------------------- ef923fd | Nicholas Feinberg | 2016-11-23 16:18:59 -0800 Merge pull request #404 from alexjurkiewicz/golubria-useless-check Mark Passage of Golubria useless with Orb (Yermak) -------------------------------------------------------------------------------- 5f06afe | Alex Jurkiewicz | 2016-11-24 10:39:58 +1100 Mark Passage of Golubria useless with Orb (Yermak) -------------------------------------------------------------------------------- a7a6885 | John Olender | 2016-11-23 18:37:18 -0500 Adjust the background colour for invisible flipped colours (|amethyst) When a colour flip would likely result in an invisible glyph, prefer to resolve the issue by adjusting the background colour instead of the foreground colour. This typically results in a significantly more noticeable flip than one resolved using a foreground colour adjustment. Additionally, adjust some related comments for clarity. -------------------------------------------------------------------------------- 1294df6 | Nicholas Feinberg | 2016-11-23 14:28:05 -0800 Merge pull request #407 from johnny-0/377_fixes Terminal rendering option fixes (for PR #377) -------------------------------------------------------------------------------- 879807e | Nicholas Feinberg | 2016-11-23 13:46:46 -0800 Tweak monster damage descs slightly (chequers) "plus scimitar of flaming damage" -> "plus its scimitar of flaming". Marginally shorter, scans slightly better (no repeated 'damage' in the full text). -------------------------------------------------------------------------------- f34b5b9 | gammafunk | 2016-11-23 04:48:22 -0600 Update the debian changelog for 0.19.0 and 0.19.1 (cherry picked from commit 4efbe43a2758ae53bad7f5d6ddd58d731596d73f) -------------------------------------------------------------------------------- 06126e9 | gammafunk | 2016-11-23 04:48:15 -0600 Colorize the entire survey message (cherry picked from commit d9ab002a8e8054638c5a17911ff9d8e67438562a) -------------------------------------------------------------------------------- 99dbe12 | Nicholas Feinberg | 2016-11-23 04:48:13 -0600 Let people know about the survey Not pushing this until we actually have a survey link up on the page. (cherry picked from commit bbb48694f4ac266cbb00c7eb3ec0376d8ef2edd9) -------------------------------------------------------------------------------- 8a14b9e | gammafunk | 2016-11-23 04:47:56 -0600 Update the changelog for the 0.19.1 bugfix release (cherry picked from commit d501a8f714272a5372813300cd11c303a3c5cb67) -------------------------------------------------------------------------------- 891e962 | John Olender | 2016-11-22 22:34:40 -0500 Add allow_extended_colours to the options guide TOC. [skip ci] -------------------------------------------------------------------------------- e35ada9 | John Olender | 2016-11-22 22:34:25 -0500 Remove the no_dark_brand option (|amethyst) The option was retooled as a workaround for terminals with a broken bright black colour. For these terminals, darkgrey may be displayed as black due to the terminal's implementation or a bogus default colour palette. However: * These terminals are quite rare. * The default values for the other bright color assumption options provide protection against invisible darkgrey-on-black glyphs. * no_dark_brand's dependence on other rendering options is not obvious at first glance. This creates an additional configuration burden for users who wish to allow rendering of darkgrey-on-black on capable terminals. * If a user insists on using a terminal with a broken darkgrey while enabling bright colour assumptions, invisible glyphs may be avoided by setting the colour.darkgrey option to any non-darkgrey colour. -------------------------------------------------------------------------------- e5586d949a | Isaac Sloat | 2016-11-22 20:08:29 -0600 Fix glyph color for acid dragons Avoid having too many Ds share the same color. Acid dragons move back to LIGHTMAGENTA that mottled dragons used. -------------------------------------------------------------------------------- 67c1175 | Neil Moore | 2016-11-22 19:16:51 -0500 Fix demonspawn copy-paste error (doh) -------------------------------------------------------------------------------- de25b03 | Neil Moore | 2016-11-22 19:07:57 -0500 Refactor draco/demonspawn generation further. The four functions did pretty much the same thing, so make them wrappers around a single function. -------------------------------------------------------------------------------- ad8db62 | Neil Moore | 2016-11-22 18:57:22 -0500 Add mons_is_removed, use it for ghostification and drac generation Also, remove the #if TAG_MAJOR_VERSION around the draconian checks now that the code does not depend on the specific list of removed monsters. -------------------------------------------------------------------------------- ea02cb5 | Neil Moore | 2016-11-22 18:55:38 -0500 Don't crash when Grand Finale fails. See for example http://crawl.berotato.org/crawl/morgue/brahma/crash-brahma-20161122-230045.txt Introduced in 0.20-a0-80-g14a9077. The fail_check in uskayaw_grand_finale returned bool(SPRET_FAIL), which happens to be true, causing us to return SPRET_SUCCESS. Have the function instead return a spret_type like the other abilities with fail parameters. -------------------------------------------------------------------------------- 1dd45c8 | Neil Moore | 2016-11-22 18:48:18 -0500 Checkwhite. [skip ci] -------------------------------------------------------------------------------- 08e0bf9 | Isaac Sloat | 2016-11-22 16:53:07 -0600 Future-proof LAST_DRACONIAN and LAST_DEMONSPAWN enums -------------------------------------------------------------------------------- ce2cec4 | Isaac Sloat | 2016-11-22 16:53:07 -0600 Refactor draconian and demonspawn variety selection Fixes a build error and removes several magic numbers. -------------------------------------------------------------------------------- 05fa499 | John Olender | 2016-11-22 17:14:14 -0500 Improve the documentation for the new terminal colour options. * Fix the foreground_colour option name and change every remaining 'color', other than the example TERM values, to 'colour'. * Place the terminal colour options in the table of contents. * Note the conditions which cause each option to [not] have an effect. Additionally, provide some example TERM values for popular terminals in the allow_extended_colours description. [skip ci] -------------------------------------------------------------------------------- a951d0f | Chris Campbell | 2016-11-22 20:28:17 +0000 Replace High Council with Folly in a guarded unrand vault instead (minmay) -------------------------------------------------------------------------------- 172aa85 | Alan Malloy | 2016-11-22 12:25:09 -0800 Fix compilation - gotta have compatible return types -------------------------------------------------------------------------------- a5c5602 | Alan Malloy | 2016-11-22 12:16:13 -0800 Refactor messaging for holy damage scaling -------------------------------------------------------------------------------- 858dfd8 | Chris Campbell | 2016-11-22 20:11:10 +0000 Remove a High Council vault -------------------------------------------------------------------------------- 2d9ae9d | Chris Campbell | 2016-11-22 20:04:18 +0000 Don't let monsters cast Fulminant Prism It's not a spell that really functions in monster hands, since using it as a player very much depends on making the most of monster AI being generally dumb and predictable. -------------------------------------------------------------------------------- 6ea533f | Chris Campbell | 2016-11-22 20:04:18 +0000 Remove the hat of the High Council It's one of a very large number of mechanically similar unrands that improve spellcasting in some way at a cost (robe of Folly, hat of Pondering, Majin-Bo, Maxwell's Etheric Cage) and probably has the least interesting downside of them (and orange crystal plate is also similar in practice, since it has Archmagi but reduces success by virtue of being CPA). -------------------------------------------------------------------------------- fa64ebb | Isaac Sloat | 2016-11-22 13:42:37 -0600 Fix vaults containing draconian callers / zealots -------------------------------------------------------------------------------- df2855f | Isaac Sloat | 2016-11-22 13:42:37 -0600 Minor cleanup to stash.lua and dc-mon.txt A few crumbs from the draconian culling... -------------------------------------------------------------------------------- c70ed55 | Isaac Sloat | 2016-11-22 13:42:37 -0600 Refactor draconian job and color selection Necessary due to removals of mottled and zealot. -------------------------------------------------------------------------------- 0b5e84b | Isaac Sloat | 2016-11-22 13:42:36 -0600 Transform draconian callers into stormcallers Takes some flavor and mechanics from draconian zealots. Stormcallers are priests of Qazlal who can Smite, Summon Drakes, and cast Upheaval. -------------------------------------------------------------------------------- 92b0916 | Isaac Sloat | 2016-11-22 13:42:36 -0600 Implement monster Upheaval For draconian stormcallers. -------------------------------------------------------------------------------- 0cf1cc1 | Isaac Sloat | 2016-11-22 13:42:35 -0600 Remove draconian zealots They were filler in draconian packs. -------------------------------------------------------------------------------- d0ada4d | Isaac Sloat | 2016-11-22 13:42:35 -0600 Save compatibility for mottled draconians Player mottled draconians get ABIL_BREATHE_FIRE to compensate for removal of sticky flame breath. -------------------------------------------------------------------------------- 9f27697 | Isaac Sloat | 2016-11-22 13:42:34 -0600 Grant rCorr to acid dragon scales -------------------------------------------------------------------------------- 2211f76 | Isaac Sloat | 2016-11-22 13:42:34 -0600 Remove a sticky flame resistance check As mottled dragon scales are no more. -------------------------------------------------------------------------------- f863914 | Isaac Sloat | 2016-11-22 13:42:33 -0600 Replace mottled dragons with acid dragons Concurrent with new yellow draconians. Note that acid dragons spit acid, instead of breathe splashes of acid. -------------------------------------------------------------------------------- 29bf9f2 | Isaac Sloat | 2016-11-22 13:42:33 -0600 Rework draconian acid breath Takes mottled sticky flame behavior: short range and splashing. -------------------------------------------------------------------------------- 8991fe2 | Isaac Sloat | 2016-11-22 13:42:32 -0600 Remove ABIL_BREATHE_STICKY_FLAME With the removal of mottled draconians and dragons, nothing remains in the game that uses this ability. -------------------------------------------------------------------------------- d147df4 | Isaac Sloat | 2016-11-22 13:30:31 -0600 Remove mottled draconian species The 0.19 changes to sticky breath wasn't enough to differentiate them or make them exicting ... nor is it enough to save them from the unyielding blade of Removal. -------------------------------------------------------------------------------- 1ccc08d | Isaac Sloat | 2016-11-22 13:30:31 -0600 Remove mottled draconian monsters Somehow even more unremarkable than player mottled draconians. Their removal will strengthen draconian variety, making the individual colors stand out more. Draconians had too much variety between ten colors and seven jobs, which ended up all bleeding together. This is a case where "less is more". -------------------------------------------------------------------------------- 157c32f | Nicholas Feinberg | 2016-11-22 11:04:33 -0800 Fix a statue xv crash AT_SHOOT is an abomination. Trivia: cherubs now have nondeterministic xv descriptions. -------------------------------------------------------------------------------- 33a96a6 | Shmuale Mark | 2016-11-22 11:48:41 -0500 Remove more poison conduct code. -------------------------------------------------------------------------------- c17e143 | John Olender | 2016-11-22 08:37:02 -0500 Don't clobber failsafe colors set conditionally (amalloy) Remove the failsafe color sets left in from debugging. -------------------------------------------------------------------------------- 958a910 | Chris Campbell | 2016-11-22 13:17:08 +0000 Adjust holy damage for resistance changes Cleansing Flame (from Seraphs only) now has slightly lower base damage, so deals less damage to demons/undead, but more to normal characters as the damage is no longer halved for non-evil creatures. Holy Flame impact base damage is halved, resulting in the same (not insignificant) damage to normal characters, and substantially less absurd amounts of damage to demons/undead. Clouds of holy flame themselves previously did the same damage to everything (other than holy creatures being completely immune), but now deal slightly less damage to normal characters and slightly more to demons/undead. -------------------------------------------------------------------------------- c6e9da2 | Chris Campbell | 2016-11-22 13:17:08 +0000 Remove TSO's poison conduct In order to focus TSO on fewer, more interesting conducts - specifically the newly-simplified stabbing conduct, as well as the necromancy/evil conduct, which while still fairly complicated is a lot more well-defined than the poison conduct was (since it did weird things like allow you to use Poison Arrow on poison-immune targets, or to poison evil monsters). -------------------------------------------------------------------------------- 66c1950 | Chris Campbell | 2016-11-22 13:17:08 +0000 Reword TSO's DID_SEE_MONSTER conduct -------------------------------------------------------------------------------- e92b557 | Chris Campbell | 2016-11-22 13:17:06 +0000 Simplify TSO's stabbing conduct Instead of causing penance for "unchivalric" attacks, just passively suppress all stabs (including against evil/unintelligent monsters where stabbing was previously allowed), and allow attacking normally otherwise. Disarming monsters with the captain's cutlass is no longer considered unchivalric (it could be suppressed too but that seems extra-fiddly to communicate). Also renames "cleanse" back to "holy" in monster, since that's now actually a reasonably accurate description of the resist. -------------------------------------------------------------------------------- 8e82014 | Chris Campbell | 2016-11-22 13:16:43 +0000 Simplify holy damage BEAM_HOLY and BEAM_HOLY_FLAME being different damage types was a huge weird mess. Remove BEAM_HOLY_FLAME, and also refactor BEAM_HOLY to use resist_adjust_damage to calculate damage. Non-"evil" creatures now also take the same damage as evil ones (rather than it being halved as previously), with holy creatures remaining immune and undead/demonic creatures still taking 150% damage. Clouds of blessed fire previously dealt no damage to holy creatures, but full damage otherwise (extremely confusingly, the *impact* from holy flame breath dealt BEAM_HOLY damage and so behaved as described above). The clouds now also deal BEAM_HOLY damage. -------------------------------------------------------------------------------- 2449017 | gammafunk | 2016-11-22 06:11:56 -0600 Update and simplify Windows MSYS2 instructions Recent versions of MSYS2 no longer require fixes to the shortcuts. Also clarify that users generally want the 64-bit version and better indicate which MSYS2 shell they should choose. Remove a lot of extra wording and some ancient instructions for the old msysgit setup. -------------------------------------------------------------------------------- 755e310 | Neil Moore | 2016-11-21 16:49:13 -0500 Remove tournament reminder. This reverts commit 69bea3c96884dfad5637b34c1565fbed7438e6a6. -------------------------------------------------------------------------------- 0ef8409 | Nicholas Feinberg | 2016-11-20 21:12:17 -0800 Brutally nerf Confusing Touch/fungus form Use the old numbers for non-natural monster vulnerability, reducing odds to affect monsters across the board (but especially for high- HD monsters). Goal is to reduce the long-term usefulness/global applicability of confusing touch (given its spell level); fungus form is collateral. -------------------------------------------------------------------------------- 1c03bc9 | Nicholas Feinberg | 2016-11-20 21:02:41 -0800 More Demonic Guardian tweaks Revert the changes to level 1 and 2 demonic guardian frequency, and refactor slightly. -------------------------------------------------------------------------------- b6cfb21 | Nicholas Feinberg | 2016-11-20 20:54:49 -0800 Merge pull request #398 from alexjurkiewicz/dguardian-mechanics Simplify demonic guardian spawning/despawning -------------------------------------------------------------------------------- 49b0324 | Nicholas Feinberg | 2016-11-20 20:44:33 -0800 Display odds for Confusing Touch/Fungus Form Resolves #383. Also, seeing these numbers makes me realize I should probably re-nerf Confusing Touch. -------------------------------------------------------------------------------- 70fc19a | Nicholas Feinberg | 2016-11-20 20:02:45 -0800 Give Bai Suzhen bonus scales enchant (CanOfWorms) To match the other non-Purgy uniques. Also, downgrade Snorg's enchant to +1-3, from the +2-4 the others have. Possibly Bai could be upgraded (+2-6?), but +6 stormda is a bit much... -------------------------------------------------------------------------------- 19b4cc5 | Nicholas Feinberg | 2016-11-20 19:46:49 -0800 Merge pull request #377 from johnny-0/curses_control_rendering_assumptions_rebase Controlling Crawl's Curses Color Conjectures -------------------------------------------------------------------------------- 18cc4de | Neil Moore | 2016-11-20 17:30:29 -0500 Satisfy the parenthesis police. Specifically, util/checkwhite [skip ci] -------------------------------------------------------------------------------- e3b074c | Neil Moore | 2016-11-20 17:15:52 -0500 Turn a magic number dice definition into a constant. And constexprify dice_def while we're at it. -------------------------------------------------------------------------------- 43a23e1 | Chris Campbell | 2016-11-20 22:04:45 +0000 Document XL-based unarmed attacks for badforms (nagdon) -------------------------------------------------------------------------------- a00ea97 | Chris Campbell | 2016-11-20 21:51:31 +0000 Add form descriptions to status lookup (?/T) And include more complete information in spell descriptions where relevant (although this all results in a bunch more duplicated information). -------------------------------------------------------------------------------- b5556e9 | Chris Campbell | 2016-11-20 21:51:04 +0000 Let fungus form wear all helmets Instead of only hats, not hard helmets. Only partially restricting the slot is unnecessarily complicated (although it might be better to fully restrict it instead). -------------------------------------------------------------------------------- bed7403 | Chris Campbell | 2016-11-20 21:51:04 +0000 Tweak a transformation message -------------------------------------------------------------------------------- 4cd936b | Chris Campbell | 2016-11-20 21:51:04 +0000 Let wispform evoke (non-wand) evokables It was the only form with such a restriction, and is still one of the most complicated and heavily-restricted forms otherwise. -------------------------------------------------------------------------------- 70de9b6 | Chris Campbell | 2016-11-20 21:51:04 +0000 De-duplicate some spellcasting checks For whether the spellcasting command is valid to use in tiles. -------------------------------------------------------------------------------- de011df | Chris Campbell | 2016-11-20 21:51:03 +0000 Remove the small chance of hostile polymorph picking a "good" form Since badforms (wisp, tree, pig, bat, fungus) now behave vaguely consistently in terms of weakly using XL for damage, don't let regular UC-using forms be options for hostile polymorph effects. -------------------------------------------------------------------------------- 9726809 | Chris Campbell | 2016-11-20 21:51:03 +0000 Make non-weapon-wielding badforms consistently use XL instead of UC for attacks Previously it was just applied to wisp and fungus form - instead apply it to all badforms except Tree (which can still use weapons), but make it substantially less effective overall so that melee in badforms won't generally be equivalent to having high levels of UC skill. -------------------------------------------------------------------------------- 9c31eae | Chris Campbell | 2016-11-20 21:51:03 +0000 Don't allow Vampires to be batformed by polymorph effects It was weird in many ways, since unlike other forms it worked when satiated or below and not when full, and Vampire batform is distinct from batform as a negative polymorph effect for other species in multiple ways. They should probably be split into two separate forms, but even then it would be strange for Vampires to be able to be transformed into another different type of bat. -------------------------------------------------------------------------------- 0f5b31f | Chris Campbell | 2016-11-20 21:51:03 +0000 Simplify batform melee attacks Remove its special-cased faster attack speed and reduced benefit from unarmed combat skill, and give it a base damage of 1 for both Vampire and non-Vampire bats (instead of 2 for Vampires and 1 otherwise). -------------------------------------------------------------------------------- 77d4e8a | Chris Campbell | 2016-11-20 21:51:03 +0000 Remove porcupine form It was barely distinct from pig form. -------------------------------------------------------------------------------- b1ff10d | Chris Campbell | 2016-11-20 21:51:03 +0000 Don't make wispform sometimes move unreliably It still has a similar effect with its random blinking - sometimes redirecting regular movement to another square is pretty unnecessarily complex for an already very complicated form. -------------------------------------------------------------------------------- 7693dad | Nicholas Feinberg | 2016-11-20 13:16:25 -0800 De-essayify Antaeus's description (MarvinPA) Fannar, Antaeus... seems like there's some connection, but what? -------------------------------------------------------------------------------- 5877242 | Nicholas Feinberg | 2016-11-20 13:04:17 -0800 Add a flavor vault -------------------------------------------------------------------------------- 5c10bcf | Nicholas Feinberg | 2016-11-20 13:04:17 -0800 Make vampire feeding a single-turn action Making it a delay causes common annoyances ("All the blood oozes out of the corpse!"), and isn't super great for 'balance', either - it's pretty much always better to just bottle blood (once you can) instead of drinking from a corpse directly. I think it'll probably still be usually better to bottle blood, since you're usually not urgently hungry as a vampire, but the simple 'eating' action can be, at least, a little simpler. -------------------------------------------------------------------------------- 8a2a5c2 | Nicholas Feinberg | 2016-11-20 13:03:48 -0800 Simplify melee confusion effects Make them equally effective against all holinesses. -------------------------------------------------------------------------------- 86b24f6 | Nicholas Feinberg | 2016-11-20 13:03:48 -0800 Refactor: Move Fire Storm into a zap Note that the comment about ench_power has not been true for a very long time; possibly since before Stone Soup? -------------------------------------------------------------------------------- 3892ab6 | Nicholas Feinberg | 2016-11-20 13:03:48 -0800 Remove hunger-over-time costs for invis/haste Weird mechanical cruft, serving no purpose. I suspect most players don't know they existed, and there's no real reason they should. -------------------------------------------------------------------------------- 24d6f97 | Nicholas Feinberg | 2016-11-20 13:03:48 -0800 Move Poisonous Cloud to level 5 (from 6) For much the same reason as Venom Bolt is L5 while Bolt of Cold is L6: it's not as strong a damage type, and, even against non-immune enemies, it doesn't do as much damage. -------------------------------------------------------------------------------- c50ae36 | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Improve mon weapon damage display (elliptic) -------------------------------------------------------------------------------- 6399215 | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Simplify (amalloy) -------------------------------------------------------------------------------- 94140ce | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Add an AF_PURE_FIRE description hack There's probably a better way to do this. -------------------------------------------------------------------------------- 6b34e32 | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 List damage for elemental AFs -------------------------------------------------------------------------------- 20a5569 | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Tweak a few attack flavour descs "Constrict for 6 damage and constriction" sounded silly. "...and ongoing constriction" is slightly better... if not good. -------------------------------------------------------------------------------- 600fc78 | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Improve descs of monsters with multiple attacks Merge multiple attacks (e.g. "It can attack twice for up to 20 damage each...)" and handle hydras correctly. -------------------------------------------------------------------------------- 27a15eb | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Mention monster weapon use in attack descriptions Ugly, and would be nice if it calculated damage for current weapons... (e.g. "up to 19 damage (32 with its giant spiked club)"). -------------------------------------------------------------------------------- ce4e231 | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Re-describe monster attack flavours A little verbose... -------------------------------------------------------------------------------- 29da077 | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 First pass on displaying monster damage -------------------------------------------------------------------------------- 5a4a499 | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Expose flavour_triggers_damageless() -------------------------------------------------------------------------------- ceffc2c | Nicholas Feinberg | 2016-11-20 13:02:10 -0800 Refactor monster attack names Preparation for a future change. -------------------------------------------------------------------------------- 4d0003c | Nicholas Feinberg | 2016-11-20 13:01:36 -0800 Give unique's hides bonus enchantment That is, Snorg's and Xtahua's. All get a random +2-4 enchant. A little bonus for killing them. (Purgy just giving a troll hide at all is a good reward for his depth.) -------------------------------------------------------------------------------- 3f3950b | Nicholas Feinberg | 2016-11-20 12:53:39 -0800 Reduce monster MR with lowered HD I.e. when drained or malmutated. Draining previously reduced MR, and that was part of the initial intent of temp draining, to allow an interesting synergy between hex effects (both spells & wands) and draining. When monster MR was simplified, this effect vanished. Let's bring it back. -------------------------------------------------------------------------------- 84ee52c | Nicholas Feinberg | 2016-11-20 12:53:28 -0800 Message for god gift piety breakpoints Since this wasn't communicated before, and probably should be. -------------------------------------------------------------------------------- 9d93480 | Nicholas Feinberg | 2016-11-20 12:53:00 -0800 Remove list of abilities from the % screen Almost entirely useless. (Keep it in the chardump, though; in a slightly different order, but I don't think that matters.) -------------------------------------------------------------------------------- dcea25d | Nicholas Feinberg | 2016-11-20 12:52:56 -0800 % screen: change spell level display From listing # of spells memorized to # of slots used. Latter is marginally more useful. -------------------------------------------------------------------------------- 4009af9 | Nicholas Feinberg | 2016-11-20 12:52:32 -0800 Hell lord descriptions These have been sitting unused around for 2-3 years, but people seemed to like them. -------------------------------------------------------------------------------- 032f40a | Nicholas Feinberg | 2016-11-20 12:52:26 -0800 Add some flavor text to hell features (r-i) Not sure who's reading these, but they could probably be a bit more grimdark than they were. 'Creepy!', really? -------------------------------------------------------------------------------- 930d327 | Chris Campbell | 2016-11-20 18:15:28 +0000 Clean up obsolete stasis code, clarify Formicid messaging Since "stasis" isn't a defined term with any context any more, describe what its actual effects are on the 'A' screen for Formicids, and clean up a lot of dead code relating to stasis as an potential item. -------------------------------------------------------------------------------- 6e69d53 | Nicholas Feinberg | 2016-11-19 16:38:33 -0800 Fix OS X 10.8 compilation (10791) -------------------------------------------------------------------------------- 14a9077 | Nicholas Feinberg | 2016-11-19 07:53:51 -0800 Improve grand finale's fail check Check *after* targeting! -------------------------------------------------------------------------------- e854f58 | gammafunk | 2016-11-19 02:42:17 -0600 Clean up some ecumenical altar vaults Spruce up the decorative features in one vault to not place them in such an awkward mix. Better use of no_(item|monster)_gen through KMASK, and clean up a few typos. -------------------------------------------------------------------------------- e188847 | elliptic | 2016-11-19 00:06:52 -0500 Make converting at a faded altar take a turn (qw). -------------------------------------------------------------------------------- 476458c | Nicholas Feinberg | 2016-11-18 15:01:39 -0800 Don't allow power leap to jump in place When constricted & failing to escape, or when trying to jump onto an invisible target. That could in principle anger allies without a prompt in a very unexpected way, which seems quite unfair to the player. This unfortunately applies exhaust in those cases, which I'd rather not, but it's sort of tricky to avoid while still taking up a turn. -------------------------------------------------------------------------------- 4a30dff | Nicholas Feinberg | 2016-11-18 14:54:22 -0800 More abort_if_stationary() improvements Don't double-message (no MSG_STATIONARY + MSG_OK), and apply the check *before* the ability failure chance, not after. Do the same for the DUR_EXHAUST checks for a few ru abilities. -------------------------------------------------------------------------------- dc19589 | Nicholas Feinberg | 2016-11-18 14:43:23 -0800 ru_power_leap: minor refactoring return_val was only ever used while 'true', and the comment was strangely equivocal. -------------------------------------------------------------------------------- 455aab1 | Nicholas Feinberg | 2016-11-18 14:38:22 -0800 Turn a macro into a static function down with macros, up with readable code -------------------------------------------------------------------------------- 65ed1cb | Nicholas Feinberg | 2016-11-18 07:50:52 -0800 Fix save compat for all saves Broken by a43205b747151e. -------------------------------------------------------------------------------- c6c1bd8 | Neil Moore | 2016-11-18 06:48:15 -0500 Update prebuilt yaccage. For the changes to CHANCE in 0.20-a0-69-ga43205b. [skip ci] since Travis doesn't use prebuilt/ -------------------------------------------------------------------------------- 11d6418 | Nicholas Feinberg | 2016-11-17 18:54:19 -0800 Fix Degeneration card messages It'd print "nothing happened" every time the card triggered, unless any *non-polymorphable* enemies were affected. Introduced in 582fb7041. -------------------------------------------------------------------------------- b95951f | Nicholas Feinberg | 2016-11-17 18:18:26 -0800 Reduce Xom cleave duration 10x Severity goes up to 200, and we probably don't want cleaving to last over 2000 turns... -------------------------------------------------------------------------------- a43205b | gammafunk | 2016-11-17 17:01:17 -0600 Remove priority from map CHANCE specifications The previous specification allowed setting a priority using the form: CHANCE: PRIORITY : NUMBER | PERCENT [(DEPTH)] [, ...] The only time this was used in the current codebase was if priority was 0, in which it was considered a "dummy chance" that allowed the vault to still be selected when looking for maps by DEPTH. Vaults specifying CHANCE are usually processed seperately from non-CHANCE vaults so that the former can have an absolute roll to decide their inclusion. For dummy vaults, however, they are intended to balance selection of non-CHANCE vaults, sometimes making the vault selector place (effectively) no vault at all, and their CHANCE is actually a specification of how often this is to happen. All non-zero priorities were ignored in vault selection, so it only existed as a hack for dummy vaults. This commit removes priority from the chance specification and simply looks for the dummy tag instead. All dummy vaults that specified priority have had this removed, but will behave exactly as they did before, selection-wise. The des syntax guide is updated appropriately. The new CHANCE specification is simply: CHANCE: NUMBER | PERCENT [(DEPTH)] The version compat code in this commit discards all des cache made from a previous version, causing the cache to be rebuilt. -------------------------------------------------------------------------------- 9e2464e | Alex Jurkiewicz | 2016-11-18 07:43:18 +1100 Simplify demonic guardian spawning/despawning Don't despawn demonic guardian based on tension, instead make them behave more like normal summons. This changes the life timer enchantment from a 'guaranteed minimum' duration to 'summon length' duration -- double it in recompense. Finally, lower the tension requirements to spawn a guardian at level 1 & 2. -------------------------------------------------------------------------------- 2fb812e | Neil Moore | 2016-11-17 15:39:49 -0500 Unbrace and checkwhite. [skip ci] -------------------------------------------------------------------------------- 692ad8f | Neil Moore | 2016-11-17 15:34:47 -0500 Remove mon_attack_def::attk(). It was a strange factory function that could have been replaced with a constructor or, as of C++11, a braced initializer. Do that. -------------------------------------------------------------------------------- 13908c1 | Nicholas Feinberg | 2016-11-17 11:35:12 -0800 Improve fire vortex description -------------------------------------------------------------------------------- 2948d44 | gammafunk | 2016-11-17 03:27:41 -0600 Correct some CHANCE statements in altar vaults Chance priority isn't actually used for anything in non-dummy vaults and will be removed in a subsequent commit. Use WEIGHT statements to give certain vaults the intended lower likelihood in the set while preserving the same overall chance of one being chosen. Closes #374. -------------------------------------------------------------------------------- 44f1fda | Alex Jurkiewicz | 2016-11-17 03:27:41 -0600 Reduce altar variability for ecumenical minitemple It's sort of cool to see more than one ecumenical altar in the same place, but not *that* cool. Cap the number of ecumenical altars at two. -------------------------------------------------------------------------------- 560cfa5 | Alex Jurkiewicz | 2016-11-17 03:27:41 -0600 Give better names and unflatten vault chances -------------------------------------------------------------------------------- f9282ea | Alex Jurkiewicz | 2016-11-17 03:27:41 -0600 Add more ecumenical altar vaults And increase the variety of the existing ones. -------------------------------------------------------------------------------- a1b20b4 | regret-index | 2016-11-16 19:38:15 -0500 .des re-order: lair.des Seperated from the review to properly highlight the former commit's edits. File contents order for the rest of the exhaustive review: branch entries, regular vaults [vault sets, decorative vaults, remaining vaults], ending vaults (for Lair here, split into small and large). -------------------------------------------------------------------------------- 621994a | regret-index | 2016-11-16 19:35:48 -0500 Exhaustive vault review: lair.des Headers forced into the house style of line order / more-readable glyphs / avoiding "nothing" definitions when possible, loose randomization reined in, comments added and cleaned up, the works. The majority of the early-D trash outside select Lair entrances, which is no longer representative of Lair's contents, has mostly been replaced with smaller numbers of Lair's actual easy spawns (bullfrogs, porcupines, the like). Written-out highlights mostly pertain to branch end vaults, with fresh contexts and death data: * evil_forest: Nerf, due to its heavy reliance on branch guests, spoilers, and a dense end-loaded difficulty point. The 50% chance for both a sixfirhy and a sun demon has been removed, and hard caps restrict dire elephant / hydra / tier-4 demon use. * water_temple: Nerf, pending known author updates, for the same causes as evil_forest. Dire elephant and hydras are more limited (even more pernient here with the shallow water!), and overall population is lowered. * catoblepas_cave: Tweak, with the low opposition variety left after the departure of dream sheep. Restrict and lower death yaks numbers, but have two randomized manticore placements (running out of distinct themed Lair end vault contents, catoblepas hybrid status sharing, good synergy with barbs versus herds / petrifying clouds). * guppyfry_[]_dragon: Tweak, since other vaults have encroached in on the idea of the standard dragons in Lair while using more weird or diverse populations, by adding a swamp dragon (layout seems swampy enough, essentially unused in Lair) while marginally reducing other dragon spawns. * tendril_chambers: Tweak, by throwing out the tier below water moccasin and placing more of said water moccasins / wyverns instead. * caniform_friends: Buff, due to continuing to lag far behind in death stats. Hounds are gone, while more raiju / hell hounds / OODs are placed. * lair_in_review: Buff, with reshaping and rescaling to deal with how there's less raw material to spare for tiered sets since the vault's inception. * enchanted_forest: Buff, due to the nerf boggarts are from young spriggan druids. More of said boggarts, and a shift from redbacks to... dream sheep. Also, a slight widening of forest corridors. -------------------------------------------------------------------------------- ced5a84 | John Olender | 2016-11-15 20:25:15 -0500 libunix.cc: Use flip_colour() for CHATTR_REVERSE. For consistency with other reversals, such as fakecursorxy(), place the flip *after* the curses color attrs have been determined for the non-reversed colours. -------------------------------------------------------------------------------- 209134b | John Olender | 2016-11-15 20:25:15 -0500 libunix.cc: Factor out color flipping code from flip_colour(cchar_t). Provide an overloaded flip_colour() function which works directly with curses color pairs and character attributes. Adjust the cchar_t version to use this new function. -------------------------------------------------------------------------------- 9c562f3 | John Olender | 2016-11-15 20:21:03 -0500 Add options for controlling 8-color best-effort brightening. Add two options, best_effort_brighten_background and best_effort_brighten_foreground, which control whether or not best-effort brightening is performed when blink_brightens_background and bold_brightens_foreground are disabled, respectively. These new options are set to true by default. -------------------------------------------------------------------------------- 66a9409 | Chris Campbell | 2016-11-15 21:06:07 +0000 Refactor chaos brand/attack flavour handling Removes some code duplication between SPWPN_CHAOS and AF_CHAOTIC. -------------------------------------------------------------------------------- 3545740 | Chris Campbell | 2016-11-15 21:00:38 +0000 Adjust various chaos effects * Remove the (non-functional) PPT_MORE polymorph, and instead just have a single plain polymorph effect. * Let the petrification effect work on players, and reduce its chance of triggering. * Remove vorpal from the SPWPN_CHAOS brand list. * Adjust checks for brand susceptibility to have more consistent holiness checks and to always reroll against unaffected targets. * Add some previously SPWPN_CHAOS-only checks to AF_CHAOS attacks, in case of monster vs monster combat. -------------------------------------------------------------------------------- ba216ac | Benoit Giannangeli | 2016-11-15 18:24:05 +0000 Removed healing possible chaos effect [Committer's note: It's a fairly uninteresting effect, and as with healing on wands of random effects has weird undesirable interactions with using chaos to heal rot. Closes #395 PR.] -------------------------------------------------------------------------------- cf10e2f | Chris Campbell | 2016-11-15 17:50:39 +0000 Remove some references to troll hides Since they're upgraded to troll leather on save transfer. -------------------------------------------------------------------------------- aa82c5c | Chris Campbell | 2016-11-15 17:50:39 +0000 Fix messaging for dragon scale troves (#10783) -------------------------------------------------------------------------------- 4202570 | Nicholas Feinberg | 2016-11-15 09:47:35 -0800 Chop various artefact names By popular demand. -------------------------------------------------------------------------------- 9b36e26 | hellmonk | 2016-11-15 09:38:54 -0800 Add more randart names [Committer's note: removed more fun.] -------------------------------------------------------------------------------- 52ebc14 | hellmonk | 2016-11-15 09:36:59 -0800 Add some randart names [Committer's note: trimmed about half of the sillier ones. No fun allowed, IMO] -------------------------------------------------------------------------------- 255f07d | John Olender | 2016-11-14 22:06:11 -0500 options_guide.txt: Fix the bold_brightens_foreground option name. Also, apply a checkwhite spacing fix. -------------------------------------------------------------------------------- 027d3fc | Nicholas Feinberg | 2016-11-14 15:55:46 -0800 Don't bias cloud generators orthogonally No reason for them to avoid diagonal moves. -------------------------------------------------------------------------------- dbf1079 | Nicholas Feinberg | 2016-11-14 15:55:43 -0800 Pull random_walk() into its own function And replace a very obsolete enum comparison with a call to is_solid(). -------------------------------------------------------------------------------- 31edf53 | Nicholas Feinberg | 2016-11-14 15:55:38 -0800 Remove an ancient & terrible dlua hack -------------------------------------------------------------------------------- b128378 | Neil Moore | 2016-11-14 18:18:50 -0500 Allow Dith shadow to attack diagonally and to reach. It only copied orthogonal attacks, unless you had reaching, in which case it copied diagonal attacks too, but not reaching attacks. -------------------------------------------------------------------------------- e094bde | Neil Moore | 2016-11-14 18:09:31 -0500 Fix DEBUG_PATHFIND compilation. [skip ci] because none of Travis's builds use this option. -------------------------------------------------------------------------------- 4a4b873 | ontoclasm | 2016-11-12 14:54:13 -0600 Fix Nem's invo skill tile -------------------------------------------------------------------------------- b3e417c | Nicholas Feinberg | 2016-11-11 20:53:58 -0800 Fix an @e1 crash (Murtidash, |amethyst) can_eat() asserted that the object it was given was at least vaguely edible (food or, for vampires, a corpse), but some of its callers didn't actually check for that. Simplified, per |amethyst's suggestions. -------------------------------------------------------------------------------- 0100fe6 | Nicholas Feinberg | 2016-11-11 16:35:31 -0800 Fix spacing (heftig) -------------------------------------------------------------------------------- f6f757a | Nicholas Feinberg | 2016-11-11 16:21:54 -0800 Fix compilation (Zibokwe) -------------------------------------------------------------------------------- cefe5f0 | Nicholas Feinberg | 2016-11-11 15:22:34 -0800 Tweak SPARM_ARCHERY description (10759) Could do with further work; possibly, as gammafunk suggested, could mention 'launchers and thrown weapons'? Though we'd have to explain what a launcher is... -------------------------------------------------------------------------------- 2417096 | Nicholas Feinberg | 2016-11-11 14:58:40 -0800 Let J neutralize shapeshifters (9954) Removes weird cases in which you see a slime, it's hostile, but you're not allowed to attack it. If they stay neutral afterward, that's not a big deal. The condition dates back to the very first J commit, and seems to be a copy-paste from Beogh logic. (Where it's not problematic.) -------------------------------------------------------------------------------- b6e7b4f | Nicholas Feinberg | 2016-11-10 20:54:04 -0800 Fedhas Fungal Bloom ability tile -------------------------------------------------------------------------------- 8de2fe2 | Nicholas Feinberg | 2016-11-10 11:27:19 -0800 Don't make notes for tentacles (ElanMorin) -------------------------------------------------------------------------------- 7d30548 | Chris Campbell | 2016-11-09 23:32:05 +0000 Fix compilation Testing things before committing is a good idea. -------------------------------------------------------------------------------- 96dadd9 | Chris Campbell | 2016-11-09 23:22:31 +0000 Fix inverted logic -------------------------------------------------------------------------------- a52155b | Chris Campbell | 2016-11-09 23:19:22 +0000 Don't count tentacles towards horror levels Now that they're not always displayed as harmless. -------------------------------------------------------------------------------- a906eb6 | Chris Campbell | 2016-11-09 22:05:06 +0000 Display tentacles with the same threat level as their parents (#10747) -------------------------------------------------------------------------------- 82dbd4d | Chris Campbell | 2016-11-09 21:45:31 +0000 Don't mention prayer in Fedhas conduct description (#10773) Just leave the line that "Fedhas likes when corpses rot away" (whether naturally or via the ability). -------------------------------------------------------------------------------- 996f6e0 | Isaac Sloat | 2016-11-08 14:34:08 -0600 Rename sirens to merfolk sirens -------------------------------------------------------------------------------- b8e7c72 | Nicholas Feinberg | 2016-11-07 20:52:00 -0800 Fix Awaken Forest/stairs interaction (minmay) Changing levels while a spriggan druid with Awaken Forest active *would* continue the Awaken Forest effect, but would *not* display it (different tree names/console colours, etc). Should be fixed. -------------------------------------------------------------------------------- f4154e2 | Chris Campbell | 2016-11-08 00:17:31 +0000 Don't make demon tridents one-handed for small races (WalkerBoh) Accidentally changed in e972ad551e97 - the intention had been to leave them as-is for Halflings/Kobolds and just change Spriggan handednesses. -------------------------------------------------------------------------------- 2d0337a | Chris Campbell | 2016-11-07 23:59:25 +0000 Remove frilled lizards from a Swamp entry vault -------------------------------------------------------------------------------- 41cc41e | David Ploog | 2016-11-07 04:14:50 +0100 Add two flavour vaults to Pan. Trying to establish a link between Pan (as the home of the pan lords) and the presence of pan lords during the orb run: these vaults feature orb guardians reared/kept in Pan, probably to be sent to Zot. One of the vaults has a portal to Zot. -------------------------------------------------------------------------------- cc13513 | Nicholas Feinberg | 2016-11-06 18:39:23 -0800 Remove an obscure poly special case Uniques would keep their spells when polymorphed into a different form of human inteligence, unless the poly target had innate spells (e.g. naga spit). This would sometimes be displayed in their description, and sometimes not. No. -------------------------------------------------------------------------------- 03dcb65 | David Ploog | 2016-11-07 02:44:22 +0100 Fix minmay_sewer_w. There was a small chance to have no floor/shallow water path to the final area. I want my scroll of blinking back! -------------------------------------------------------------------------------- 154eb2c | Chris Campbell | 2016-11-06 20:00:10 +0000 Remove the unused OPER_ID -------------------------------------------------------------------------------- e6c2eab | Chris Campbell | 2016-11-06 20:00:10 +0000 Adjust some ability descriptions -------------------------------------------------------------------------------- 884808d | Nicholas Feinberg | 2016-11-06 11:20:55 -0800 Don't scream at non-monsters (minmay) IOODs etc & tentacles. -------------------------------------------------------------------------------- 8907a59 | Nicholas Feinberg | 2016-11-06 08:56:12 -0800 Fix volcano_lake Broken in 25837f4635819232bf978c05a3311698d1a99773. (Gained a 1/6 chance to generate no path to the center.) -------------------------------------------------------------------------------- 9fff63e | Neil Moore | 2016-11-06 09:28:21 -0500 Cut lass. Added in 0.19-a0-129-g2caaceb, maybe as a merge error. Without a tile or a reasonable price, it probably shouldn't exist. -------------------------------------------------------------------------------- 7876e6c | Eino Keskitalo | 2016-11-06 15:40:49 +0200 Since Nemelex has become the only source of cards, adjust the god's powers description accordingly. -------------------------------------------------------------------------------- c069335 | Eino Kewlskitalo | 2016-11-06 15:10:04 +0200 Fix 'slightlycontaminated' -------------------------------------------------------------------------------- d4fea00 | Nicholas Feinberg | 2016-11-05 10:41:14 -0700 Fix vault wand generation (10766) Broken by 3a282c79a5fa. -------------------------------------------------------------------------------- 3a282c7 | Neil Moore | 2016-11-05 01:42:53 -0400 Always show max charges for wands of known type. In item names, e.g. "wand of confusion (?/48) {zapped:2}". It's a little ugly for "wand of confusion (?/48) {empty}" to differ from "wand of confusion (0/48)", but really the ugliness was already there, just less salient. -------------------------------------------------------------------------------- 69bea3c | Nicholas Feinberg | 2016-11-04 12:55:38 -0700 0.19 tournament reminder -------------------------------------------------------------------------------- 0876c8e | Neil Moore | 2016-11-02 19:04:02 -0400 Fix source code alignment. [skip ci] -------------------------------------------------------------------------------- 26ddc15 | Nicholas Feinberg | 2016-11-02 08:47:56 -0700 * (Medar) -------------------------------------------------------------------------------- c0f5d7e | Nicholas Feinberg | 2016-11-02 08:32:23 -0700 Remove an incorrect changelog entry Tomb's ambient noise was made *less* significant, not more; the Desolation's ambient noise didn't exist before, and the other two had relatively minor tweaks to ambient noise. (Slime was also tweaked!) Simplest to remove it from the changelog entirely. -------------------------------------------------------------------------------- f589edf | Pekka Lampila | 2016-11-02 10:34:12 +0200 Remove res_statdrain mention from docs. (Mattias) [skip ci] -------------------------------------------------------------------------------- 90c15da | Neil Moore | 2016-11-02 02:13:40 -0400 Don't animate walls in webtiles as though they were water (#8740) This was fixed a couple of years ago (0.15-a0-1730-g078e12a) for local tiles, but the bug also affected webtiles. It wasn't noticed because water animations are off by default there. -------------------------------------------------------------------------------- a97c7b5 | Neil Moore | 2016-11-01 14:58:47 -0400 Use correct zap info for meph targetter (10754). We were targetting with ZAP_BREATHE_MEPHITIC, which passes through targets, unlike the spell. -------------------------------------------------------------------------------- 6776aff | Neil Moore | 2016-11-01 14:58:47 -0400 Fix a compiler warning. "spell_hd" shadows a member function of monster_info. -------------------------------------------------------------------------------- 62d82d9 | Nicholas Feinberg | 2016-10-31 15:43:56 -0700 Restrict blessings to currently-friendly followers Weird to heal an ally that's currenlty hostile, edge case though that is. -------------------------------------------------------------------------------- 0e8e6b5 | Nicholas Feinberg | 2016-10-31 13:21:37 -0700 Fix discord/hep ancestor interaction (10753) Not pushing this into stable because I'm frankly worried it'll somehow cause more bugs than it fixes. -------------------------------------------------------------------------------- 11bd45b | Nicholas Feinberg | 2016-10-31 13:04:35 -0700 Fix slime creature MHP display (Tux) -------------------------------------------------------------------------------- 5cb335a | Nicholas Feinberg | 2016-10-31 12:53:46 -0700 Don't let trog burn books through glass (Yermak) Didn't really work. Would be nice if the messaging was better for this - right now it says that you can't *see* any books, which doesn't seem quite right... -------------------------------------------------------------------------------- 34c0f31 | Nicholas Feinberg | 2016-10-31 12:46:22 -0700 Don't waste time failing to eat chunks (Yermak) When you're too full to eat them, don't even start. -------------------------------------------------------------------------------- d166d5d | Nicholas Feinberg | 2016-10-30 14:14:15 -0700 Fix unique hide inscriptions Got lost a few commits back. -------------------------------------------------------------------------------- 334f831 | Nicholas Feinberg | 2016-10-29 15:00:51 -0700 Minor changelog tweaks (proofreading etc) -------------------------------------------------------------------------------- 2b0e13a | Nicholas Feinberg | 2016-10-27 14:25:24 -0700 Simplify vampire transformation logic Since you can't be insta-killed by transformations ending anymore. -------------------------------------------------------------------------------- 56c49a2 | Shmuale Mark | 2016-10-27 15:45:24 -0400 Fix some false positives in the doublezap indicator (darox). -------------------------------------------------------------------------------- 8ddec94 | Isaac Sloat | 2016-10-26 19:21:20 -0500 Finalize 0.19 changelog -------------------------------------------------------------------------------- 70ed36a | Shmuale Mark | 2016-10-25 23:13:28 -0400 For trunk, make webtiles mouse control on by default. Don't cherry-pick this. -------------------------------------------------------------------------------- 330ea1e | Shmuale Mark | 2016-10-25 23:12:47 -0400 Make webtiles mouse control an option (off by default). -------------------------------------------------------------------------------- 874f678 | Nicholas Feinberg | 2016-10-25 17:31:07 -0700 Fix Fire Storm aborting Bug introduced by 59ea75df (sort of): the warnings for "this beam would hit you/a pal, are you sure?" triggered *after* spell failure was checked. -------------------------------------------------------------------------------- 5180b6b | Nicholas Feinberg | 2016-10-25 16:27:23 -0700 Tweak Channel Magic description "a magical power regeneration ability" seemed very awkward. Not totally satisfied with this version either, but I think it scans a little better. -------------------------------------------------------------------------------- 052ff51 | Nicholas Feinberg | 2016-10-25 08:01:29 -0700 Fix freezing vapours description (Darox) The curse of the copy-paste... -------------------------------------------------------------------------------- 59670f6 | Nicholas Feinberg | 2016-10-24 15:13:11 -0700 Display Hep's transfer radius at 5* Hopefully not more confusing than helpful... -------------------------------------------------------------------------------- f4bb0bd | Nicholas Feinberg | 2016-10-24 12:34:43 -0700 Reduce Hepliaklqanal piety gain Make it take longer for the god to bloom, especially with weaker builds (since piety decay really eats into slow piety gains). Slightly decrease piety costs so that they'll be usable. -------------------------------------------------------------------------------- ebf9562 | Nicholas Feinberg | 2016-10-24 12:04:51 -0700 Remove some changelog highlights (MarvinPA) RIP... -------------------------------------------------------------------------------- c9712f4 | Nicholas Feinberg | 2016-10-24 12:01:54 -0700 Cut ancestor cast freq from 40 -> 25 Nerfs. -------------------------------------------------------------------------------- 3941b7a | Nicholas Feinberg | 2016-10-24 11:59:22 -0700 Remove status effect cures from Idealise A marginal effect (that most people didn't realize existed!); unecessary complexity. Now that ancestors are unliving and that there's little penalty for their deaths, the effect is pretty irrelevant. -------------------------------------------------------------------------------- 24d37aa | Nicholas Feinberg | 2016-10-24 11:55:51 -0700 Add Nemelex to the changelog (regret-index) -------------------------------------------------------------------------------- d7ada34 | Nicholas Feinberg | 2016-10-24 11:38:10 -0700 Fix display for monsters with variant spell HD E.g. ancestors (mostly only relevant in debug mode) and monsters in Aura of Brilliance. -------------------------------------------------------------------------------- ae7261f | Nicholas Feinberg | 2016-10-24 11:29:30 -0700 Add more info on mon spells in debug mode Sort of partially reverts aed18fcb5788f1636f232d2658a23e68c. -------------------------------------------------------------------------------- 21f43f3 | Nicholas Feinberg | 2016-10-24 11:18:15 -0700 Penultimate 0.19 changelog tweaks regret-index reminded me to finally go through and decide on some highlights for the release. -------------------------------------------------------------------------------- 9be4e74 | Nicholas Feinberg | 2016-10-24 11:06:12 -0700 Fencer's Gloves: Dex+6 -> +3 *Riposte is a strong and distinctive effect on its own. +Dex is thematic, but we no longer need to give a huge amount of it to make the Gloves interesting. Better to save the design/conceptual space for other items. -------------------------------------------------------------------------------- 1e9a4c1 | Nicholas Feinberg | 2016-10-23 11:43:59 -0700 Count poly'd orcs as true companions (10592) Prevents certain bugs involving orcs not being removed from the companion list after being polymorphed, and seems like a better behaviour generally; much more convenience in being able to recall your pals, etc. TODO: save compat fixes for the two people who hit this bug already. -------------------------------------------------------------------------------- 6e2d87a | Eino Keskitalo | 2016-10-23 11:24:40 +0300 Duvessa speaks Australian English "Practice" is the noun, "practise" is the verb [skip ci] -------------------------------------------------------------------------------- 83281cb | Chris Campbell | 2016-10-22 22:11:41 +0100 Partially update some manual appendices The appendix of commands is overall still hugely out-of-date and incomplete, and the information already exists in-game in the various ? menus with a higher chance of being accurate. Probably the manual should just explain the different modes and that '?' will give a list of commands, rather than duplicate everything. -------------------------------------------------------------------------------- 10983cd | Nicholas Feinberg | 2016-10-22 10:15:31 -0700 Fix the gcc build (possibly) -------------------------------------------------------------------------------- 76efe36 | Chris Campbell | 2016-10-22 17:53:45 +0100 Fix vaults being able to create ego dragon scales (#10079) -------------------------------------------------------------------------------- 8249929 | Chris Campbell | 2016-10-22 16:44:51 +0100 Adjust lamp of fire/fan of gales descriptions (#10579) -------------------------------------------------------------------------------- 2e573fe | Chris Campbell | 2016-10-22 16:29:58 +0100 Adjust some feature descriptions -------------------------------------------------------------------------------- 55031db | Chris Campbell | 2016-10-22 15:25:23 +0100 Remove some obsoleted speech lines And adjust a couple of others. -------------------------------------------------------------------------------- dd0aef2 | Nicholas Feinberg | 2016-10-21 22:50:09 -0700 Fix a mouse_control syntax error -------------------------------------------------------------------------------- 0723303 | Nicholas Feinberg | 2016-10-21 22:35:31 -0700 Fix an Awaken Earth crash (10410) <|amethyst> hm, if x is 79 <|amethyst> say the coord is (79, 69)... we encode that as 69*70 + 79 = 4909 <|amethyst> then 4909 % 70 == 9 and 4909 / 70 == 70 <|amethyst> so it gets changed to (9, 70) which is out of bounds Also fix another potential prism bug while I was looking at it. -------------------------------------------------------------------------------- c6909e3 | Nicholas Feinberg | 2016-10-21 22:12:31 -0700 Warn for dangerous lichform unwields (10490) Welcome, to the Corner Case. -------------------------------------------------------------------------------- d23083c | Nicholas Feinberg | 2016-10-21 21:44:28 -0700 Revert mut food prompt This reverts commit f46b2cedc9ad8b2486b3233dff19ae086fedb1cf. Redundant with d09ab47ac29d7. Oops! -------------------------------------------------------------------------------- 3ec191d | Nicholas Feinberg | 2016-10-21 21:43:43 -0700 Merge pull request #355 from suncrab/bad-food-prompt Prompt for confirmation before eating mutagenic/forbidden/noxious food (10657) -------------------------------------------------------------------------------- 43c011f | Nicholas Feinberg | 2016-10-21 13:42:24 -0700 Fix a chaos effect copy-paste (regret-index) Introduced in fd0a92bab93. -------------------------------------------------------------------------------- cff654f | Nicholas Feinberg | 2016-10-20 15:03:25 -0700 Make chunks take 1 turn to eat (minmay) With interruptible eating and auto_eat_chunks on by default, having chunk-eating be an interruptible action was a huge nightmare - constant annoying 'continue eating?' prompts. Making eating uninterruptible again would make auto_eat_chunks too dangerous for people Playing To Win to use, and turning off auto_eat_chunks gives the player more food makework. The balance impact of this game should hopefully be fairly small, and shouldn't ruin the excitement of the tactical food game. -------------------------------------------------------------------------------- 480c79d | Nicholas Feinberg | 2016-10-20 10:02:17 -0700 Remove a drowning reference -------------------------------------------------------------------------------- e8b2aad | Nicholas Feinberg | 2016-10-20 09:56:22 -0700 Warn for poison ammo under TSO (10549) wow, what great code i just wrote -------------------------------------------------------------------------------- 6d7e2b4 | Nicholas Feinberg | 2016-10-20 09:33:15 -0700 Continue vampire zerk while thirsty (10741) When berserk activation drops a vampire player into 'thirsty', continue the berserk instead of instantly ending it. The alternative was banning berserk while the player is satiated, but that seems sort of bad. -------------------------------------------------------------------------------- ead39cf | Nicholas Feinberg | 2016-10-19 23:30:22 -0700 Update manual section ?6, inscriptions (9944) Remove a very redundant and difficult to maintain section. -------------------------------------------------------------------------------- 8424084 | Nicholas Feinberg | 2016-10-19 23:03:06 -0700 Remove double battlespheres (9732, 9796, 10356) When battlespheres (and other temporary monsters) take shafts, vaporize them instead of placing them on the next level. -------------------------------------------------------------------------------- 9b75343 | Nicholas Feinberg | 2016-10-19 22:52:48 -0700 Handle auras in cleanup (9948, 10618, 10636) Direct calls to monster_cleanup(), from e.g. shaft traps, transit, etc., didn't deal with monster auras (halo, silence, umbra). -------------------------------------------------------------------------------- 25144d5 | Nicholas Feinberg | 2016-10-19 22:44:41 -0700 Don't consume rings when identifying them (10663) With the item_slot rcfile option, you could end up automatically swapping a newly-identified item with the ID stack that identified it. The bug was that this would result in the ID'd item (in the ID scrolls' old inventory slot) being consumed *instead* of an ID scroll. -------------------------------------------------------------------------------- 2d93087 | Neil Moore | 2016-10-18 21:24:33 -0400 Checkwhite (doh) [skip ci] -------------------------------------------------------------------------------- dc02945 | Neil Moore | 2016-10-18 21:21:51 -0400 Simplify and refactor MfAv positioning code. Mostly cleaning up flow control, but also using grid_distance instead of (x-y).rdist(). -------------------------------------------------------------------------------- c712c6c | Neil Moore | 2016-10-18 20:50:27 -0400 Fix a minor logical error in MfAv positioning. We could theoretically be comparing distance to a default-initialized (so (0,0)) best_target. Practical effects are nil. -------------------------------------------------------------------------------- 611e798 | Nicholas Feinberg | 2016-10-18 10:42:37 -0700 Minor refactor to hide code -------------------------------------------------------------------------------- 783e625 | Nicholas Feinberg | 2016-10-17 17:58:13 -0700 Re-remove the Sword of the Doom Knight (r-i) From a vault. -------------------------------------------------------------------------------- 0b9551f | Nicholas Feinberg | 2016-10-17 17:43:21 -0700 Remove the Book of Envenomations from vaults -------------------------------------------------------------------------------- ffa48aa | Nicholas Feinberg | 2016-10-17 16:09:24 -0700 s/tags/labels (chequers) -------------------------------------------------------------------------------- 321e2ff | Nicholas Feinberg | 2016-10-17 15:51:14 -0700 First pass on github bug template -------------------------------------------------------------------------------- e1d1fe8 | Isaac Sloat | 2016-10-17 10:39:17 -0700 Fix religion screen flicker while atheist In webtiles. -------------------------------------------------------------------------------- 261845d | Nicholas Feinberg | 2016-10-17 08:32:57 -0700 Changelog through 0.19-a0-1889-g9c603be -------------------------------------------------------------------------------- 9c603be | Corin Buchanan-Howland | 2016-10-16 19:04:05 -0400 Remove amulets of dismissal These suffered from two serious issues: first, players didn't enjoy playing with them, for much the same reasons as distortion weapons. Second, they were significantly too life-saving, potentially getting players out of life- threatening situations without requiring the player to take any actions. -------------------------------------------------------------------------------- 6ba2374 | Nicholas Feinberg | 2016-10-16 07:33:59 -0700 Fix gozagites getting hides (chequers) I re-broke this in the last commit that was supposed to fix it... -------------------------------------------------------------------------------- bc010ea | Nicholas Feinberg | 2016-10-16 07:32:40 -0700 Give the Amulet of Invis a tile (10737) Overlooked when it was added. -------------------------------------------------------------------------------- 55aeeb9 | John Olender | 2016-10-16 00:58:03 -0400 libunix.cc: Use wide character curses highlight macros. This file uses XSI wide-character curses functions when getting/setting attributes. These functions are designed to work with specific wide-character highlight macros (e.g., WA_BOLD instead of A_BOLD). Update the file to use these specific macros; do not rely on the curses implementation defining WA_ macros exactly as their A_ counterparts. -------------------------------------------------------------------------------- 3d9e987 | John Olender | 2016-10-16 00:58:03 -0400 libunix.cc: Set the screen's attributes in write_char_at(). Add a declaration for this function and some documentation. This rendering issue was particularly frustrating to narrow down, so a hefty internal doxygen block is included with the function definition. Remove a redundant cursor move in fakecursorxy(). -------------------------------------------------------------------------------- afa4d10 | John Olender | 2016-10-16 00:58:03 -0400 direction_chooser: Don't reverse the target coord when drawing beams. The target coordinate's colors will likely be reversed or otherwise changed by the terminal's cursor. For curses terminals, a reversal attempt is guaranteed when the use_fake_cursor option is enabled. Avoid a double color reversal by omitting the reverse color flag for the target coordinate. -------------------------------------------------------------------------------- 172b3b1 | John Olender | 2016-10-16 00:51:57 -0400 libunix.cc: Manually reverse colors for CHATTR_REVERSE. Directly translating CHATTR_REVERSE to A_REVERSE is a problem when using an eight color palette. The terminal reverses the colors, but not the character attributes used for brightening. So, manually reverse the foreground and background colors when CHATTR_REVERSE is used, ensuring the appropriate brightening attrs are set for each color. Reserve A_REVERSE for failover rendering. -------------------------------------------------------------------------------- d64a0f0 | Neil Moore | 2016-10-14 15:46:01 -0400 Don't crash when monsters Bind Souls in Arena (#10719) We were setting the foe of the new undead to MHITYOU unconditionally, but MHITYOU is forbidden in Arena mode (see the assertion in handle_behaviour). -------------------------------------------------------------------------------- 564c9e0 | Neil Moore | 2016-10-14 14:57:50 -0400 Allow targetting mottled drac breath past range 1 (Brannock) Its range was increased, but the targetter didn't know that, so the UI implied range 1, and targetting further away required the ! key. We fix that problem, but leave another: the targetter doesn't actually check the path to the target, so it pretends to be a smite-targetted spell. The targetter_splash class should be replaced by something based on targetter_beam instead, along the lines of the IMB targetter. -------------------------------------------------------------------------------- ab8686d | Nicholas Feinberg | 2016-10-14 11:45:17 -0700 Possibly fix statue_of_worship (10735) -------------------------------------------------------------------------------- c9e4fd8 | gammafunk | 2016-10-14 00:46:55 -0500 Change the glyph color of hornets to yellow Due to their rework, these monsters can be found more frequently with other y that can be berserked. Moving hornets to yellow prevents confusion between these and other angry bugs. -------------------------------------------------------------------------------- bb73ea0 | m-aigner | 2016-10-13 17:14:37 -0700 Fix inner flame ally targetting (10639) [Committer's note: refactored heavily, removed obsolete Virulence logic (wrong since a7827471a7ca).] Closes #381. -------------------------------------------------------------------------------- 9366f7c | Nicholas Feinberg | 2016-10-13 17:01:41 -0700 Improve mon-gear plus naming/documentation -------------------------------------------------------------------------------- eaac499 | Nicholas Feinberg | 2016-10-13 17:01:41 -0700 Fix mon-gear forced brand/plus behaviour (DrKe) Previously, forcing a brand on a monster's weapon (e.g. SPWPN_FLAMING) would force it to always be +0 unless the plusses were explicitly specified, and vice-versa for brands. This makes the brand and plus have (roughly) the default behaviour unless explicitly specified. Closes #382. -------------------------------------------------------------------------------- d95bc26 | Neil Moore | 2016-10-13 17:34:03 -0400 Better abbreviate "of" spells in util/monster was: Greater Servant of Makhleb -> g.makhleb now: Greater Servant of Makhleb -> g.s.makhleb -------------------------------------------------------------------------------- cbc8a98 | Nicholas Feinberg | 2016-10-12 21:02:46 -0700 Remove a redundant line (wheals) Supposedly, mitm items will no longer contain shop items. Hopefully... -------------------------------------------------------------------------------- 5dbd49c | Neil Moore | 2016-10-12 23:40:07 -0400 Remove variadic insert_commands() Since in C++11 we can just pass an initializer list to the vector version of the function. -------------------------------------------------------------------------------- 252a6bc | Neil Moore | 2016-10-12 23:40:07 -0400 Fix prayer message colours with re-bound CMD_GO_UPSTAIRS. We were adding an extra <, but that was only appropriate if the command was actually bound to the < key, and would cause broken highlighting in other cases. Thanks to PleasingFungus for suggesting to use insert_commands() here. -------------------------------------------------------------------------------- 4fea3da | Nicholas Feinberg | 2016-10-12 20:13:43 -0700 Fix derived undead avg MHP display (chequers) -------------------------------------------------------------------------------- 096aae6 | gammafunk | 2016-10-12 21:00:36 -0500 Refactor a river vault For chequers_big_river, reduce and make consistent the floor padding and the vault connectors. Remove the padding behind the rock placements, since these seemed to create a lot of dead ends in generated levels. Add some fuzzed water/floor/rare plants along the existing deep water/water/plant fuzzing; previously the vault did this in a more manual fashion. Finally, make the vault only place in D and Depths, since those have more use of water and layouts that help the vault seem more natural. -------------------------------------------------------------------------------- f3c996c | gammafunk | 2016-10-12 20:01:14 -0500 Consolidate overflow temples and code cleanup Make a single chequers_temple_overflow_statue_of_worship place 2-4 altars, with code to handle the variable number. -------------------------------------------------------------------------------- 71bd320 | Alex Jurkiewicz | 2016-10-12 20:00:39 -0500 Some vaults. * chequers_temple_overflow_statue_of_worship: two very simple overflow vaults. * chequers_temple_overflow_minitemple: variable size minitemple that places some ecumenical altars. * chequers_big_river: big, level-defining feature that splits the map in twain (well, hopefully). Commiter's Note: Closes #193. The other commit in this PR wasn't merged, since the issue was addressed in f468e8a. -------------------------------------------------------------------------------- f468e8a | gammafunk | 2016-10-12 17:43:29 -0500 Rework of a wizard prison vault The evilmike_wizard_prison vault is well known for its unique theme of wizards imprison behind grates and under a silence field, however some aspects of this vault were annoying. Players wanted to individually dig out and kill any of the dangerous monsters before going to the vicinity of the silent spectre, so they'd not have to fight them all at once. Furthermore the vault had two areas with loot hidden behind diggable walls that could easily be missed. This commit reworks the vault to have undiggable prisons for the wizard monsters, where the walls are removed when the player enters LOS of the spectre, which is itself behind a runed door. Hence when players open the runed door and see the spectre, all monsters are released. Additionally the vault always has a known teleport trap in front of the spectre. For most players, the spectre will wake up immediate and enter the teleport trap, thus removing the silence field. Especially stealthy or lucky characters might have a few turns before the specter wakes up, allowing them to trigger the teleport trap themselves, thus keeping the spectre in the vault. All loot has been moved into normally accessible areas behind the runed door, and the vault itself has been refactored to be my symmetrical and to have less excess size given the current radius of the silent spectre. The guaranteed ancient lich is moved to a prison behind the rune door, near the loot, and has another nasty imprisoned friend to keep him company. I've added randomization to the soul eater & curse skull placement, and put distributions on the numbers of monsters. -------------------------------------------------------------------------------- c32fe5a | Chris Campbell | 2016-10-12 22:06:27 +0100 Fix colouring of prayer messaging -------------------------------------------------------------------------------- 5fb031f | Nicholas Feinberg | 2016-10-12 07:46:13 -0700 Fix tutorial 5 (removal of prayer) -------------------------------------------------------------------------------- 8505d8b | Neil Moore | 2016-10-12 08:51:47 -0400 Don't include altars in X<> cycling (dpeg) -------------------------------------------------------------------------------- 50c3308 | Neil Moore | 2016-10-12 08:50:52 -0400 Staticalise a function, unbrace, and checkwhite. -------------------------------------------------------------------------------- e6f2195 | Nicholas Feinberg | 2016-10-11 21:41:25 -0700 Add a (p)rayer reminder at altars Hitting p (or any other unbound key) at an altar will remind you what key you should press. This should help players transition into the new regime. Note that this gets incorrectly parsed as a colour ("< or >"), and thus highlighted red; I couldn't figure out how to fix this. Sorry! -------------------------------------------------------------------------------- cc38ccb | Nicholas Feinberg | 2016-10-11 18:49:00 -0700 Remove the (p)rayer command Just use > or < to pray at altars instead, as with shops. One command down, 6,000 to go... -------------------------------------------------------------------------------- 207f91a | Nicholas Feinberg | 2016-10-11 18:44:19 -0700 Move Fedhas's prayer effect into an ability It's quite silly to have the 'pray' key do things for exactly one god (hard to learn!), and with auto-piety for corpse decay, it shouldn't be necessary to use the ability nearly as often. It'd be nice if the ability didn't let you waste time doing nothing, or at least prompted for it... and probably the ghoul/ necrophage interaction shouldn't exist. (I could go either way on the zombie thing. It's cute!) -------------------------------------------------------------------------------- 4fde920 | Nicholas Feinberg | 2016-10-11 18:44:19 -0700 Rot all corpses for Fedhasites when leaving levels Giving piety for doing so. A small nerf to tactical flexibility, a nice buff to... well, not quite optimal play, but lazier play, at least. -------------------------------------------------------------------------------- f0d375d | Nicholas Feinberg | 2016-10-11 18:44:19 -0700 Make Fedhas appreciate all corpse decay (minmay) No need to hit 'p' unless you urgently need toadstools or piety right now, or unless you're about to leave the level. -------------------------------------------------------------------------------- 35def1e | regret-index | 2016-10-11 13:37:38 -0400 Fix a sewer map's connectivity (Lasty) -------------------------------------------------------------------------------- 4fc2e42 | Chris Campbell | 2016-10-11 18:12:11 +0100 Let Beogh enchant, upgrade and uncurse ranged weapons Gives a similar chance to try and upgrade/enchant ranged weapons as with melee weapons, gifting ammunition if that fails. -------------------------------------------------------------------------------- b217fe3 | Chris Campbell | 2016-10-11 18:12:11 +0100 Let friendly dryads cast awaken forest under Fedhas (#10660) -------------------------------------------------------------------------------- 687ba86 | Chris Campbell | 2016-10-11 18:12:11 +0100 Document area effects when examining the floor (#10565) -------------------------------------------------------------------------------- 2ede8b9 | Corin Buchanan-Howland | 2016-10-11 11:38:15 -0400 Revert updates to sewer_minmay_w This reverts part of dfe47cf5 because it broke connectivity. -------------------------------------------------------------------------------- 32653aa | Nicholas Feinberg | 2016-10-10 21:36:34 -0700 Make glowing items cost more in shops (Drazool) Since it seemed silly that they didn't. -------------------------------------------------------------------------------- b7442ac | Nicholas Feinberg | 2016-10-10 20:49:42 -0700 Lesser Beckoning power cap: 50 -> 200 A vicious nerf, per request. (Was too strong, and power cap wasn't relevant beyond the early game.) -------------------------------------------------------------------------------- cf7509b | Nicholas Feinberg | 2016-10-10 19:33:51 -0700 Fix a vault comment typo -------------------------------------------------------------------------------- a656266 | gammafunk | 2016-10-10 21:23:14 -0500 Some vaults from Cheibrodos (10716) Float vaults with monsters and loot for Dungeon, Lair, Lair branches, Elf, and Depths, many with layouts inspired by biology themes. This commit also removes roderic_lost_polar_bear, since this vault is almost completely identical to simply generating a polar bear normally in Lair, and the theme of "polar bears lost in Lair" is now better covered by cheibrodos_lair_lostbears. -------------------------------------------------------------------------------- c11d922 | Chris Campbell | 2016-10-10 09:59:51 +0100 Fix lightgrey contamination causing backlit (Leszczynek) -------------------------------------------------------------------------------- 3228ea0 | Nicholas Feinberg | 2016-10-09 16:08:06 -0700 Various scale/hide fixes (Lightli, DrKe) Don't drop them under Gozag, do drop them from shapeshifted dragons, don't drop them from monsters shapeshifted into dragons. Unfortunately makes messages worse for uniques dropping hides or scales (Purgy, Xtahua); patches welcome? Also, mostly unrelated, but don't give hints mode butchering reminders under Gozag. -------------------------------------------------------------------------------- 63fd1ff | Alan Malloy | 2016-10-09 12:28:11 -0700 Make sure vampires in statue form get rPois+++ (papilio) -------------------------------------------------------------------------------- 2383789 | Nicholas Feinberg | 2016-10-08 21:45:16 -0700 Tweak dragon scale drop message From "You see +0 dragon scales" to "The fire dragon's scales are intact enough to wear." -------------------------------------------------------------------------------- ba71d7c | Nicholas Feinberg | 2016-10-08 21:45:16 -0700 Rename: dragon armour -> dragon scales E.g. "Here: +0 fire dragon scales". Requested to satiate the Flavour Gods. -------------------------------------------------------------------------------- cd7d164 | Nicholas Feinberg | 2016-10-08 21:45:06 -0700 Remove hides Butchering dragons/trolls to get their hides and then enchanting them into armour was probably the closest thing to crafting that Crawl had. It was reasonably thematic, and the actual enchanting part felt kind of cool, but it also added complexity and confusion without any corresponding improvements in gameplay or 'strategic choices'. (Does Crawl really need a whole set of armours that you can use, but shouldn't? Should mummies and spriggans need to go around butchering things...?) Dragons and trolls now have a chance of leaving armour along with their corpse, whenever they leave one. -------------------------------------------------------------------------------- 9ebbe8c | Nicholas Feinberg | 2016-10-08 21:27:12 -0700 Fix the build (travis) oops -------------------------------------------------------------------------------- 42248b2 | Nicholas Feinberg | 2016-10-08 21:02:34 -0700 Pad floor use UI vertically (dpeg, wheals) -------------------------------------------------------------------------------- 3f91102 | Nicholas Feinberg | 2016-10-08 20:38:27 -0700 Fix local tiles UI refs in the web tut (Gooch181) -------------------------------------------------------------------------------- 72f4b67 | Nicholas Feinberg | 2016-10-08 16:44:11 -0700 Better &t support for brands In wizmode artefact tweak mode, specify brands by name (e.g. "vampirism") instead of by raw enum. -------------------------------------------------------------------------------- c934513 | Nicholas Feinberg | 2016-10-08 16:20:59 -0700 Put a save-compat hack in TAG_MAJOR_VERSION tags Might be possible to remove it entirely; 3cea9f3a is the relevant commit to investigate. -------------------------------------------------------------------------------- f1e0166 | Chris Campbell | 2016-10-08 18:30:48 +0100 Update some contamination descriptions (Tux[Qyou]) -------------------------------------------------------------------------------- 63cf2ba | Chris Campbell | 2016-10-08 14:17:05 +0100 Allow batform to quaff potions and open doors It was a fairly weird exception - all the other player bad-polymorph forms can read and quaff, and even wisp/pig/porcupine could use doors. Also makes Vampire batform a little better and less fiddly. -------------------------------------------------------------------------------- 0ef4e39 | Chris Campbell | 2016-10-08 14:17:05 +0100 Don't trigger *Rage artefacts when attacking firewood The mutation already didn't trigger on firewood. -------------------------------------------------------------------------------- 49dc4b2 | Chris Campbell | 2016-10-08 14:17:05 +0100 Don't special-case Xom berserk penalties Make it slightly rarer, but remove the special behaviour of allowing non-attack actions with no penalty. -------------------------------------------------------------------------------- dfe47cf | regret-index | 2016-10-08 01:33:02 -0400 Author-influenced vault edits -------------------------------------------------------------------------------- 25837f4 | regret-index | 2016-10-08 01:04:32 -0400 Volcano buffs! Volcanoes have always had an unusually wide and unlinked monster set due to early values of mystique and possibility from very long lists. While it was a decent shift a good while ago to shift the sets away from villages of gnolls and orcs or beasts coloured red in console, the current generic fill-in monster sets still include broad ranges of unusual picks. With Volcanoes holding a fraction of kills of Ice Caves, as they present harder map gimmick presence and clouds with quite a few less regular monsters, it seems reasonable to once more try and push the sets a little more upwards. Generic sets shared across several volcano maps are now split in three rather than two, and are trimmed yet still broad: * Remaining humanoid sets: Centaurs and yaktaurs, ogres, or salamanders, plus one base red draconian / downgraded hell knight. All are still equipped with fiery weapons and armour, and each is a 15% chance. * Demons set: red devil / red ugly thing / hell hound, smoke demon / sun demon, orc sorcerer / worse equips hell knight. 20% chance. * Beasts set: hell hound / steam dragon / fire bat band, hell hog / lindwurm, fire dragon / fire crab(!). 20% chance. * Elemental set: fire elemental / earth elemental / gargoyle, efreet, stone giant(!). 15% chance. Cuts: hill giants, orc warriors and knights, deep elf mages and knights, Urug + Erolcha + Nessos + Harold, crimson imps, komodo dragons, manticores, fire vortices, most "mixed" sets. It's a bit of a shame to lose the uniques, but they hardly had wide terrain or heavy support to benefit from. Komodos and vortexes both still appear in singular maps each, at any rate. After this clean-up and some header clean-up, there are also some per-vault shifts: * Weights have been shifted, made slightly flatter across maps but diminishing the two lua-based layouts and the toenail bunker. * All maps with extremely broad potential lava monster chances have gotten hard minimums and maximums, higher than previous averages. Not that lava snakes and fire bats are too scary. * volcano_grotto loses the lasher statue subvault and firespitter statues: volcanoes have enough potential gimmick mechanics without portal-unique vault defines (and a new elemental statue ontop of the codified ice statue is excessive). Obsidian statues, playing off of fiery hell themes, replace adjusted firespitter uses. * volcano_tomb replaces its mummies and vampires with skeletal warriors. Both undead types, while interestingly flavourful here, are too weak and tangential to the fire (+ earth) volcano themes to be so prominent as a portal vault set-up. A regular vault or two trying out "sealed vampires / mummies under lava" is better than this. They also get much more flame clouds and wider chambers, to try and assist the poor weaker skeletons beforehand. * volcano_bunker, which places humans with maces and toenail golems, replaces the former with wizards. Equally eccentric, but with more fireballs, paralysis, and banishment. * volcano_caves has weird random chamber access fixed up. Some of the loot quality has gone up correspondingly. The two flaming-branded weapons in every volcano are now guaranteed to be big two-handers or even top-tier weapons, without any more morningstars or halberds litering the piles. The free good_item enchantments on them are gone, though, and as per always one might not find the weapon types they'd like. Armour quality and generic item quality have also been adjusted. TODO: Make some volcano_lakes subvaults. -------------------------------------------------------------------------------- 9eb87fe | Alan Malloy | 2016-10-07 21:09:33 -0700 Make a comment more explicit -------------------------------------------------------------------------------- 6b7851e | Nicholas Feinberg | 2016-10-07 19:58:36 -0700 Merge pull request #378 from drke2/vp Give Jory better weapons (Roarke) -------------------------------------------------------------------------------- e88bd62 | DrKe | 2016-10-07 19:53:32 -0700 Specify weapon list for Jory (Roarke) Good item great sword, glaive, or battleaxe, with great sword having triple weight. -------------------------------------------------------------------------------- 8d6b64e | regret-index | 2016-10-07 19:38:54 -0400 Adjust Lair's spawns and OOD table some more Branches without out-of-depth-monsters caps have per-monster distributions scaled for their floors, and quick introductions of ood caps without accomodations for the approached depths beyond their regular floors will have unusual effects for OOD fuzz. As such, a variety of monster ranges have been adjusted to better accomodate potential OOD spawns (including some unfortunate hacks in consciously using multiple entries per-monster). There is at most a ~0.2% margin of adjustment to initial spawns in Lair:1-5, though Lair:6 should have a whole ~2.2% of its spawns not be wyverns nor a ~0.8% be blink frogs in exchange for ~0.5% of spawns being death yaks and catoblepas. Dire elephants and lair branch representatives in alligators / anacondas / manticores / wolf spiders are also now only 53% of the potential rare spawns past the 10000 aut mark- non-Lair monsters shouldn't completely overtake the other spawns. The other 47% is now occupied by fire crabs, dream sheep, and torpor snails, each of which is arguably more dangerous. A large chunk of the space inbetween regular floor spawns and the bottom of the pool is prominently filled with hydras and black mambas, which might be more noticeable, anyway. Lair:6 has recieved a nominal but fuzzed buff in danger, due to its end vaults most likely taking long enough to see more OODs. It was always a leap in spawns outside of the vaults themselves, anyway- 40% of early D trash in earlier versions and 40% empty spawns in later versions vanish from regular distribution disappear for that floor. The effects of this overall will take a long while to notice, anyway, with how complicated OOD calls are in regular generation- only the new monsters will be any really noticeable. -------------------------------------------------------------------------------- d4c818f | Chris Campbell | 2016-10-07 22:57:54 +0100 Apply orbrun teleport restrictions throughout Zot Makes teleports delayed and blinks uncontrolled for all of Zot as well as the orbrun, and also prevents Passage of Golubria from working. Applying the restrictions for all of Zot instead of just on the orb pickup makes it easier to communicate them, as well as preventing things like using PoG to immediately escape the orb chamber. It does have the downside of being -cTele-like behaviour, although this did already exist on the orbrun itself. -------------------------------------------------------------------------------- 05e0fc3 | Chris Campbell | 2016-10-07 22:57:54 +0100 Make Berserk cost hunger on activation instead of on expiry Moves the 700 hunger cost to be part of the activation cost for Trog berserk and evocable berserk, rather than at the end of the effect. As an activation cost, the hunger amount is randomised but works out as very slightly less on average for Trog berserk, and slightly more on average for evocable berserk. Involuntary berserk (and consumable berserk from potions) no longer has a hunger cost, and so *Rage artifacts and the mutation can trigger regardless of hunger level. Also adjusts ability activation so that highly hungering abilities become unusable at a hunger state threshold, rather than being usable until the exact point when they could starve you (so Berserk, Divine Vigour, Corruption etc are unusable once Near Starving, rather than being usable until a specific hunger value midway through Near Starving). -------------------------------------------------------------------------------- 8a8ed2c | gammafunk | 2016-10-07 15:54:56 -0500 A new fiery Lair end vault from Cheibrodos Featuring various fiery delights, including lava snakes, molten gargoyles, and special guest appearances by a possible lindwurm or fire crab (Cheibrodos favorite monster in the game). The final showdown is with a fire dragon guarding a small hoard. Other scaly lair baddies make appearances to round out the cast. Some notes about this vault for any future work: * Feels rather like a volcano with more monsters and no random fire clouds. This is not a huge problem, but it one suggestion offered to address it was to try a kind of "fire and ice" theme that works off of the bifurcated nature of the vault. * The final showdown is close to two other lair end vaults that feature a fire dragon, and probably isn't an especially challenging one if you can take care of everything leading up to that poin. It may be advisable to move some friends to the dragon's chamber, or possibly work the end vault to not need an actual door. The "fire and ice" rework mentioned above would be another route to address this. -------------------------------------------------------------------------------- a614c4e | Chris Campbell | 2016-10-07 20:29:27 +0100 Don't autobutcher unless exploring (#10721) Makes it a little more usable with necromancy spells, as well as making it consistent with auto_eat (in that it won't waste your time by triggering when you're right around the corner from a monster and manually walking away from them). -------------------------------------------------------------------------------- 174f941 | Isaac Sloat | 2016-10-06 22:33:05 -0500 Don't let alligator bands spawn in Lair For OOD alligators. -------------------------------------------------------------------------------- 04aa7a8 | Isaac Sloat | 2016-10-06 22:33:05 -0500 Add some OOD-only monsters for Lair Dire elephants, alligators, manticores, wolf spiders, and anacondas. Don't stick around too long! -------------------------------------------------------------------------------- 68243f5 | Isaac Sloat | 2016-10-06 21:36:32 -0500 Enable out-of-depth table for Lair -------------------------------------------------------------------------------- 823c5cb | Isaac Sloat | 2016-10-06 21:07:29 -0500 Slightly adjust Lair spawn distribution Dream sheep spawn ~0.5% more often in Lair: 6. Wyverns show up slightly more often on Lair 3-4 and less often on 5-6. Death yaks are unchanged in-game - their changes are to prepare for an OOD table for Lair. -------------------------------------------------------------------------------- 21c7ecd | Nicholas Feinberg | 2016-10-06 12:48:12 -0700 Hell fish zombies: simplify -------------------------------------------------------------------------------- ae2e04e | Nicholas Feinberg | 2016-10-06 12:38:45 -0700 Remove skeletonless skeletons from Hell Introduced by 1485906a677b. -------------------------------------------------------------------------------- 42c593c | Corin Buchanan-Howland | 2016-10-05 22:01:41 -0400 Let Uskayaw make a wrathful noise (DrKe) -------------------------------------------------------------------------------- bf060b2 | Chris Campbell | 2016-10-05 18:40:45 +0100 Don't generate river rats or iguanas in Lair They're still placed by some vaults, but probably shouldn't be. Replace them mostly with MONS_NO_MONSTER, with practically no effect on total XP (but yet another tragic nerf to TotalGhoulNutr). -------------------------------------------------------------------------------- fd294f3 | Chris Campbell | 2016-10-05 18:14:29 +0100 Fix AF_POISON_PARALYSE logic (|amethyst) -------------------------------------------------------------------------------- bfcb2be | Chris Campbell | 2016-10-05 17:25:40 +0100 Really remove player haste spell (gammafunk) -------------------------------------------------------------------------------- a09e929 | Chris Campbell | 2016-10-05 10:39:14 +0100 Don't make Xom find grey glow interesting Caused by e9e2c28324f2db. -------------------------------------------------------------------------------- d4844a0 | Chris Campbell | 2016-10-05 10:31:16 +0100 Adjust Irradiate contamination cost again It's now actually safe to cast when below lightgrey contamination, and can be safely cast 3-4 times. -------------------------------------------------------------------------------- e97c279 | John Olender | 2016-10-05 02:19:21 -0400 libunix.cc: Do not keep track of flipped cchars in fakecursorxy(). There is no guarantee that the associated cell hasn't been modified before another call to fakecursorxy(). It is quite possible that a character identical to the saved flipped character has been written to saved cell location in the interim. This intentional coloring would be wiped out and replaced with the stale saved character on the next call to fakecursorxy(). For example, this problem is seen when a beam is targeted through a monster and the beam results in the cchar_t combination as a flip. This is tough to produce in a standard 8/16 color terminal (due to flips changing color pairs), but is a common occurrence on monochrome terminals. Remove the resulting unused functions. Remove the char_info alias type and update the now-lone function which uses the alias to use cchar_t directly. -------------------------------------------------------------------------------- e6b039b | John Olender | 2016-10-05 02:17:20 -0400 libunix.cc: Make failsafe output from curs_attr() more predictable. Instead of using the current default color as a failsafe, use the *default* default color of white-on-black. This generally makes failsafe output more noticeable, especially when default colors have been changed. -------------------------------------------------------------------------------- 4007336 | Nicholas Feinberg | 2016-10-04 17:48:19 -0700 Give efreet their swords back (in tiles) Went missing with the new tiles. -------------------------------------------------------------------------------- 000dc29 | Nicholas Feinberg | 2016-10-04 17:48:19 -0700 mon-gear.cc / spectral orc refactoring Remove a very ugly argument that existed solely for Nergalle's fake "Death Channel". Expected gameplay effects: all minotaurs are now nudists. -------------------------------------------------------------------------------- 423c4d9 | Chris Campbell | 2016-10-05 01:08:27 +0100 Add a newline -------------------------------------------------------------------------------- b9d7604 | Chris Campbell | 2016-10-05 01:06:04 +0100 Randomise contamination levels of spells/abilities To prevent knowing exact contamination when using spells like Controlled Blink, with lightgrey contamination now generally indicating when another cast risks causing yellow glow. -------------------------------------------------------------------------------- f200629 | Chris Campbell | 2016-10-05 01:06:04 +0100 Reduce Irradiate's contamination level Only allowing it to be cast once safely made it pretty undesirable spell to use. It can now be cast 2-4 times safely, and since a new sub-level of contamination is now displayed it doesn't require the player to count casts. -------------------------------------------------------------------------------- e87717a | Chris Campbell | 2016-10-05 01:06:04 +0100 Don't reduce contamination when monsters debuff the player Make it uniquely an effect of the potion of cancellation, rather than allowing weird behaviour like breathing at yourself as a purple draconian to reduce contamination. -------------------------------------------------------------------------------- e9e2c28 | Chris Campbell | 2016-10-05 01:06:04 +0100 Add another sub-level of contamination when near yellow glow And refactor some contamination handling. -------------------------------------------------------------------------------- 558363c | Chris Campbell | 2016-10-05 01:06:04 +0100 Reword MR aptitude description (PleasingFungus) -------------------------------------------------------------------------------- fb1adf4 | gammafunk | 2016-10-04 18:54:57 -0500 Some vaults from Doesnt (10630) An assortment of vaults: some arrivals, a shop for people scared of hydras, a xom altar where (spoilers) xom plays a trick on you, a vault where some wizards experimented with dancing weapons and had a little accident, and an abyssal rune vault that might leave you feeling a little brain-dead. -------------------------------------------------------------------------------- b4acfea | elliptic | 2016-10-04 19:50:17 -0400 Let randarts generate with protection or chaos brands. Now that protection is less boring it makes sense to enable it on randarts. If it is still too boring, chaos brand randarts should make up for that... -------------------------------------------------------------------------------- 5e8c22d | Nicholas Feinberg | 2016-10-04 15:45:02 -0700 Fix allies buffing/healing the player (10691) Special targeting functions that set beam.target to coord_def() (aka origin()) were getting snagged in setup_mons_cast(), which set the beam's target to the monster's foe if it was origin() (interpreted there as 'default/unset'). Use a different out-of-bounds coordinate (probably should be exported to a static function...) -------------------------------------------------------------------------------- d17bd63 | Nicholas Feinberg | 2016-10-04 15:17:09 -0700 Remove a hints.cc hack -------------------------------------------------------------------------------- 97ff39f | Chris Campbell | 2016-10-04 22:03:37 +0100 Remove some obsolete Haste handling -------------------------------------------------------------------------------- 34fa0a2 | Corin Buchanan-Howland | 2016-10-04 22:03:30 +0100 Remove Haste spell for players. (cherry picked from commit a7ebeb5a6256f31bd016c90ec8d173f3be2c9120. Haste isn't an effect that should be available in unlimited spell form, and works much better as a consumable. The wand is also potentially not great due to the existence of recharging, but the spell is a much worse offender so is a good change to start with! -MarvinPA) -------------------------------------------------------------------------------- 1cb667b | Chris Campbell | 2016-10-04 22:03:23 +0100 Adjust AF_PARALYSE once more Fixes it never applying paralyse to creatures with rPois+, and being able to affect poison-immune creatures (side-effects of a32af4e0 and ba1b758b respectively). It now just has a fixed chance to try and apply paralysis instead of slow, and the standard 2/3 chance of piercing rPois for both the paralysis and slowing effects. Also rename it to AF_POISON_PARALYSE, since that's a bit closer to accurately describing it. -------------------------------------------------------------------------------- f624816 | Chris Campbell | 2016-10-04 21:08:39 +0100 Rename check_stealth to player_stealth -------------------------------------------------------------------------------- f8ee9a6 | Chris Campbell | 2016-10-04 21:02:12 +0100 Display Felid bonus stealth on 'A' -------------------------------------------------------------------------------- 21eb84b | Chris Campbell | 2016-10-04 21:02:12 +0100 Reduce Ogre/Troll/Centaur stealth apts by 1 To compensate for their greatly improved stealth modifier. The races with high stealth generally already had huge stealth apts (Na/Vp/Sp), or bonus stealth (Fe/Op), and also didn't lose all that much stealth with the fixed modifier. -------------------------------------------------------------------------------- c296747 | Chris Campbell | 2016-10-04 21:02:12 +0100 Display MR on the ?% aptitude table -------------------------------------------------------------------------------- 55d2e7d | Chris Campbell | 2016-10-04 21:02:12 +0100 Give shadow form a stealth multiplier -------------------------------------------------------------------------------- 605dc7b | Chris Campbell | 2016-10-04 21:02:12 +0100 Give Vampires fixed stealth bonuses when thirsty Instead of adjusting stealth modifiers, give fixed bonus stealth when thirsty, and an increased bonus when bloodless or in batform. Results in less of a bonus once at particularly high stealth skill, but a more significant bonus early. -------------------------------------------------------------------------------- e0c9574 | Chris Campbell | 2016-10-04 21:02:12 +0100 Re-order some stealth handling Apply multiplicative changes after additive ones (other than confusion's, which is still applied first), since there didn't seem to be any particular logic to the previous behaviour (where for example, mutation stealth wasn't halved by fumbling in shallow water, and Felid blade paws stealth penalty??? was the only penalty that was reduced by being confused). -------------------------------------------------------------------------------- 9627c65 | Chris Campbell | 2016-10-04 21:02:12 +0100 Remove species/form stealth modifiers Instead give all characters a fixed modifier of 15. The modifiers were a much more complex way of achieving differentiation that could be easily gotten through adjusting aptitudes instead. -------------------------------------------------------------------------------- acbfa36 | John Olender | 2016-10-04 01:27:05 -0400 libunix.cc: Add and use functions which check for color pair existence. Knowing if a specific color pair is exists is important for determining which default background colors are valid. It is similarly important for deciding which pairs can be flipped by swapping colors (versus purely modifying character attributes). Add a new function to determine whether or not a pair exists for the passed color combination. Split the curs_calc_pair_safe() function into two overloaded functions: - A two-argument version which strips colors as necessary and uses the file-scoped global default colors. - A four-argument version which uses passed color values directly and works with explicitly-supplied default colors. Update curs_set_default_colors() and flip_colour() to use these new functions. Modify setup_color_pairs() to a lesser degree and make sure all initial pairs are generated before setting default colours. For flip_colour(), monochrome terminals are taken care of in a more generic manner; they are treated as any other color combination without a reverse pair. Additionally, for curs_set_default_colors(): Don't reset the default foreground color when a default background color is rejected due to a pair shortage. The default foreground color's validity is not related to this particular check. Along with this adjustment, provide a clearer comment on why these default background colors are rejected. -------------------------------------------------------------------------------- 28b16ba | Corin Buchanan-Howland | 2016-10-03 22:09:30 -0400 Make Uskayaw ignore all damage over time (PleasingFungus) This removes the kind of janky requirement to both try to deal damage and also succeed at dealing damage. Now merely succeeding is required. The goal here is to make the piety gain condition clearer and harder to game while still prohibiting DOT effects that allow the player to maintain piety while not fighting. -------------------------------------------------------------------------------- 47717c6 | Isaac Sloat | 2016-10-03 19:41:18 -0500 Minor tweaks to SPWPN_VAMPIRISM -------------------------------------------------------------------------------- 99f4d21 | John Olender | 2016-10-03 07:42:55 -0400 libunix.cc: Update default color checks for monochrome terminals. First, always check for non-indexable default colours. This check was designed to deal with terminals without enough pairs to exhaustively combine every foreground and background color. It works equally well for denying default color changes on monochrome terminals. These terminals would otherwise need another special case, so just always perform the check. Second, use the use_default_colors() function for monochrome terminals instead of assume_default_colors(). When not dealing with other colors, matching the terminal's default color is both desirable and safe. On a side note, remove the redundant call to use_default_colors() for color terminals. The requirement that use_default_colors() be used before assume_default_colors() was dropped in 2004. http://invisible-mirror.net/ncurses/NEWS.html#index-t20041030 -------------------------------------------------------------------------------- 026f1ef | Neil Moore | 2016-10-03 07:12:31 -0400 Allow arena monsters to pick up items (Styar) Rather than just one team. -------------------------------------------------------------------------------- cdd9768 | John Olender | 2016-10-03 05:38:22 -0400 libunix.cc: Fix rendering on monochrome terminals. Provide some extra considerations for monochrome terminals when determining attributes and flipping colors. These changes allow crawl to render adequately on such terminals. For simplicity and compatibility, treat all terminals with less than eight colors as monochrome. -------------------------------------------------------------------------------- 85cf057 | John Olender | 2016-10-03 05:17:36 -0400 libunix.cc: Do not simply reverse the default pair in flip_colour(). For consistency, look up the default fg/bg colors and treat the default pair like any other color flip. -------------------------------------------------------------------------------- c5c554d | John Olender | 2016-10-03 04:47:50 -0400 libunix.cc: Checkwhite and unbrace. -------------------------------------------------------------------------------- a32af4e | Isaac Sloat | 2016-10-03 00:19:23 -0500 Further simplify AF_PARALYSE (MarvinPA) Also fixes a terribly mistaken comment. -------------------------------------------------------------------------------- 8eae0f7 | Isaac Sloat | 2016-10-02 23:22:30 -0500 Fix a save compatibility crash (Gerad) Darn corrupters striking from beyond versions! -------------------------------------------------------------------------------- df4f055 | gammafunk | 2016-10-02 23:01:29 -0500 Some fixes and cleanups for alphashops (nicolae) Fix randomizations of the shop contents and move a random choice function to the util library. Also make edits for recent item type renames, clean up formatting, and remove yet another brazen attempt at self-promotion. Zin reminds us to remain ever-vigilant in our quest to remain pure. -------------------------------------------------------------------------------- 230130f | Nicholas Feinberg | 2016-10-02 19:05:08 -0700 Try to improve some hints mode text -------------------------------------------------------------------------------- 6d44ad7 | Nicholas Feinberg | 2016-10-02 19:05:08 -0700 Remove awful hints mode starting prompt Just confusing and disorienting. Don't ask me if i want to see a single screen, show me it and get it over with! -------------------------------------------------------------------------------- f5c1b34 | Nicholas Feinberg | 2016-10-02 19:05:04 -0700 Revise hints.cc It's still bad, but slightly more modern. -------------------------------------------------------------------------------- c8f66bb | Nicholas Feinberg | 2016-10-02 15:08:36 -0700 Update Elemental Force descriptions (10713) -------------------------------------------------------------------------------- 81ad427 | Alan Malloy | 2016-10-02 11:05:26 -0700 % is 'character overview', not 'show resistances' (Tangar) -------------------------------------------------------------------------------- d4668896 | Nicholas Feinberg | 2016-10-02 09:34:41 -0700 Improve &v Allow listing all items' values, not just artefacts. -------------------------------------------------------------------------------- 452a841 | Nicholas Feinberg | 2016-10-02 07:42:39 -0700 Axe wasps (Tekks, Grognorb) -------------------------------------------------------------------------------- 6cc5790 | John Olender | 2016-10-02 04:29:37 -0400 libunix.cc: Don't avoid creating pairs with the same fg/bg color. This was a leftover idea which was made irrelevant by two factors: - Remapping (white, black) on a default color change solves the "one extra pair" problem. - The 8-color palette needs these pairs to implement brightening via attributes. These prevent the rest of diagonal from ever reclaiming a full-background-color worth of palette, completely defeating what little purpose these savings would have had. -------------------------------------------------------------------------------- 5152dc3 | John Olender | 2016-10-02 03:19:11 -0400 libunix.cc: Fix some bogus algebra in the setup_colour_pairs() notes. -------------------------------------------------------------------------------- aa426e4 | John Olender | 2016-10-02 02:23:06 -0400 libunix.cc: Allow changing color depth during gameplay. Allocate the maximum number of color pairs usable by the game by default. This allows quick switching between supported color modes with few screen refreshes. Adjust how color pairs are organized to ensure that there are always enough pairs for 8-color/64-pair and 16-color/256-pair terminals. Provide some notes on how these changes may impact future 256-color support. -------------------------------------------------------------------------------- 5bac298 | John Olender | 2016-10-02 02:20:58 -0400 Lua options: Correct the binding name for allow_extended_colours. -------------------------------------------------------------------------------- 7aee5af | Isaac Sloat | 2016-10-02 00:32:33 -0500 Properly sort abominations Abominations and monstrosities are much closer to aberrations than to demons. -------------------------------------------------------------------------------- 64c2a32 | Neil Moore | 2016-10-02 01:30:32 -0400 Re-constexprify coord_def::rdist() (Brannock) By using a constexpr version of abs, since the standard does not guarantee std::abs is constexpr (which caused the OS X compile errors fixed by fe7938f27). -------------------------------------------------------------------------------- 3adc94d | Isaac Sloat | 2016-10-01 22:22:45 -0500 Remove Corrupt Body No longer used by any monster in the game, per 11e23973af981f72e11a81b33fc4b7279050af8e -------------------------------------------------------------------------------- e893076 | Isaac Sloat | 2016-10-01 22:22:45 -0500 Replace Corrupt Body with Corrupting Pulse (regret-index) -------------------------------------------------------------------------------- fe7938f | Nicholas Feinberg | 2016-10-01 20:16:59 -0700 Fix OS X compilation (sooheon) Partially reverts dfd3b10. -------------------------------------------------------------------------------- 4233171 | Nicholas Feinberg | 2016-10-01 19:10:29 -0700 monster: rHoly -> rCleanse (Cimanyd) Don't claim that monsters vulnerable to Cleansing Flame and Holy Flames are vulnerable to "holy" in util/monster's display, since that sounds like they're vulnerable to holy wrath. Instead, call it 'cleanse'. (Probably it doesn't need to be mentioned at all!) -------------------------------------------------------------------------------- c283b47 | regret-index | 2016-10-01 21:59:51 -0400 Exaggerate and diminish demonspawn monsters some more Demonspawn monsters might as well do something more while it takes months for given developers to bother to throw out the tangled code. Their defensive combination aspects blend together, after all. Extended's problems are indefinite due to its redundancies and length, but the monsters unique to it shouldn't fall to the same issues. * Standardize some minor variations in demonspawn health / damage stats. * Give the infernal and gelid demonspawn full elemental resistance. It's too obtuse and subtle flavour for them to have only two pips as part of symmetry with the possibility of player demonspawn having the corresponding rF+ / rC+ scales + fascet. Likewise, bump up monstrous demonspawn aux damage and health, since the lack of a weapon in exchange for implied Robust is a mixed exchange, and provide torturous demonspawn rN+++ since they lost their hidden Augmentation / Powered By Pain effects (clearly, they're out of date). A reference list of what should be straightforward results that nobody can or will remember anyway: * Infernal [demonspawn] have rF+++ and AF_FIRE melee. * Gelid [demonspawn] have rC+++ and icemail: 10 extra AC until they're hit by fire. * Torturous [demonspawn] have rN+++ and spines. * Monstrous [demonspawn] have doubled health, no weapon, and extra melee hits. * Give corrupters Corrupting Pulse (wretched stars) over the current unique temporary mutation hex Corrupt Body. They didn't originally get it because their current temporary mutation beam had a specific flavour group of mutations to apply (removed for being invisible and obscure) and because Corrupting Pulse used to apply to valid allies (removed for being a case-specific weakening interaction). One can argue that their summons blocking debilitative beams is nicely generous, but extended should be aggressive. They'll still cast it at half of the wretched star rate, anyway. * Trim Malign Offering off of black suns. They already have multiple non-unique spells for the sake of doing more than their allies-buff, and the spell is too weak for Pan- the other spells are cast more to compensate. * Tweak the bands to use less mixed un-classed demonspawn: one less base monster in classed demonspawn bands, and much more of a chance to stick to thematic or the same demons in the rare chances base ones spawn. The point of the base demonspawn is to emphasize and introduce those fascet attributes, but spawning too many of them mixed together muddies them in the long depths of Pan and Extended. Still left to do: replace the Sap Magic mechanic to resemble sifcasting so it can be cast more often by warmongers, not spawn two long demon-focused branches with overlapping themes in every game, probably just forcibly bond the base attributes to classes anyway. -------------------------------------------------------------------------------- dfd3b10 | Neil Moore | 2016-10-01 20:51:32 -0400 Constexprify coord_def. -------------------------------------------------------------------------------- 021e741 | Nicholas Feinberg | 2016-10-01 16:43:31 -0700 Count Riposte actions separately (gammafunk) For morgues. -------------------------------------------------------------------------------- 67fe6ff | gammafunk | 2016-10-01 18:24:24 -0500 Fix an arrival vault (gwarl) Originaly was a decorative cage, but single trees are now opaque. Switched to have clear stone and to have trees fully surrounding the vault, to prevent accidental digging hijinks. -------------------------------------------------------------------------------- 6116449 | Chris Campbell | 2016-10-02 00:15:35 +0100 Remove some references to the lantern of shadows -------------------------------------------------------------------------------- 679d492 | Chris Campbell | 2016-10-01 23:12:46 +0100 Update syntax.txt -------------------------------------------------------------------------------- b375097 | Chris Campbell | 2016-10-01 22:56:31 +0100 Don't give Spriggans piety for polearms skill with Sac Hand 05e545665a4 fixed them losing their polearms skill, but they would still be granted the piety for it. -------------------------------------------------------------------------------- ba1b758 | Isaac Sloat | 2016-10-01 16:00:57 -0500 Emancipate paralytic poison (MarvinPA) -------------------------------------------------------------------------------- 20b3632 | Isaac Sloat | 2016-10-01 15:51:31 -0500 Clean up AF_PARALYSE Remove special cases and average out the numbers where applicable. Also, it can no longer paralyse/slow enemies that were not poisoned. -------------------------------------------------------------------------------- 5324d1a | Isaac Sloat | 2016-10-01 15:51:31 -0500 Nerf hornets As they're much more common now, their stats have been placed halfway between wasp and old hornet. -------------------------------------------------------------------------------- 61ff0df | Isaac Sloat | 2016-10-01 15:51:30 -0500 Remove wasps The two monsters were too similar to justify the distinction. Wasps have been removed. Hornets are kept, as the're a specific species. Spriggan riders now tame and train hornets. -------------------------------------------------------------------------------- 5bd6118 | Chris Campbell | 2016-10-01 21:49:25 +0100 Remove Jiyva's jelly paralyse ability It was a fairly fiddly ability that in practice would usually just be used to grab as much of the Slime:$ loot as possible, since elsewhere most item eating happens off-screen. -------------------------------------------------------------------------------- 428efd8 | Nicholas Feinberg | 2016-10-01 13:36:28 -0700 Tweak Book of the Warp Swap Portal Projectile in, replacing Summon Forest; the latter's already in two other books, and the former would be nice to see at least a little more often. -------------------------------------------------------------------------------- 4bb99f6 | Nicholas Feinberg | 2016-10-01 13:36:28 -0700 Only auto-memorize level 1 spells at game start Don't start new Warper with a spell they can't memorize! -------------------------------------------------------------------------------- fcbf923 | Nicholas Feinberg | 2016-10-01 13:36:28 -0700 New spell: Lesser Beckoning (L3 Tloc) Beam-targeted spell that moves the target adjacent to the caster. Won't move victims into instakill terrain (lava etc), but will move them over such terrain. Can move monsters into traps. Range starts at 2, and caps at 7 (LOS_RADIUS) at 50 power; if the effect is too powerful, doubling the power cap to 100 might be one way to adjust it. (Alternately, it could gain a second school; tloc/earth?) Intended to be a fun utility effect. It's currently in Party Tricks and in Spatial Translocations, replacing Apportation in the latter; that means that Warper no longer starts with a spell, but that's probably OK. -------------------------------------------------------------------------------- a95302d | Isaac Sloat | 2016-10-01 13:45:08 -0500 Fix Hepliaklqana's name -------------------------------------------------------------------------------- ebd07a4 | Chris Campbell | 2016-10-01 19:40:37 +0100 Fix branch noise messaging for branches with other entry messages Doesn't ever come up currently, but any branch that had its own special entry message previously wouldn't have displayed messaging about branch noise, if it was also noisy/quiet. -------------------------------------------------------------------------------- 515da45 | Chris Campbell | 2016-10-01 19:40:37 +0100 Remove an unnecessary mimic apportation special case It's fine to put mimics under the player now, since they don't turn into monsters. -------------------------------------------------------------------------------- cdbbc62 | Nicholas Feinberg | 2016-10-01 11:39:41 -0700 Don't rest by clicking on stats in local tiles Instead, display the % screen. Would be really nice to display tooltips for whatever stat you're mousing, but you'd need to have some concept of where each element is... -------------------------------------------------------------------------------- 89de447 | m-aigner | 2016-10-01 18:30:10 +0100 Make silencable abilities display correctly in xv, for real. (Committer's note: Closes #372 PR, and fixes Mantis #10649). -------------------------------------------------------------------------------- 8ae7a5b | Alan Malloy | 2016-10-01 10:25:06 -0700 Revert accidental commit of wudzu -------------------------------------------------------------------------------- b0f0fea | CoreyK | 2016-10-01 13:02:43 -0400 wudzu description and ability key adjustments -------------------------------------------------------------------------------- 61e4b27 | CoreyK | 2016-10-01 13:02:42 -0400 wudzu wrath -------------------------------------------------------------------------------- 2476d88 | CoreyK | 2016-10-01 13:02:41 -0400 aux armour thorns, 2* and 4* -------------------------------------------------------------------------------- f7ff26a | CoreyK | 2016-10-01 13:02:40 -0400 5* wudzu ability: briar patch -------------------------------------------------------------------------------- 539bf7f | CoreyK | 2016-10-01 13:02:39 -0400 3* wudzu ability: summon vines -------------------------------------------------------------------------------- 47d1c54 | CoreyK | 2016-10-01 13:02:38 -0400 at * wudzu worshippers get the equivalent of spiny 1 -------------------------------------------------------------------------------- 24b151c | CoreyK | 2016-10-01 13:02:37 -0400 Thorn body armour when worshipping Wudzu -------------------------------------------------------------------------------- ad64241 | CoreyK | 2016-10-01 13:02:35 -0400 Shell for the god Wudzu (name subject to change I very much hope) -------------------------------------------------------------------------------- 44f2206 | Nicholas Feinberg | 2016-10-01 09:10:15 -0700 Deduplicate player::is_habitable_feat() -------------------------------------------------------------------------------- 6dcb786 | Isaac Sloat | 2016-10-01 00:13:30 -0500 Fully remove an Eringya leftover Goodbye, vine-covered golems. You will forevermore rest in our courtyard, being consumed by the call of nature. -------------------------------------------------------------------------------- 333ee72 | Nicholas Feinberg | 2016-09-30 21:25:10 -0700 Remove old references to searching (Oliverkatt) Since you can no longer search for traps while resting. The tilereg-stat case is very strange - why do we allow resting by clicking on your AC? -------------------------------------------------------------------------------- c9b17de | Nicholas Feinberg | 2016-09-30 21:23:47 -0700 Mention hitting Esc in name select (Oliverkatt) -------------------------------------------------------------------------------- 0bcaf2e | elliptic | 2016-09-30 21:55:54 -0400 Actually zero you.time_taken for macro delays that don't do anything (|amethyst). Previously a macro that didn't take any actions (e.g. calling a nonexistent or empty user-defined lua function) would still waste a turn (unless there was a visible monster to interrupt the delay). -------------------------------------------------------------------------------- da47fb9 | Isaac Sloat | 2016-09-30 18:25:14 -0500 Fix broken pan_disco_hall (MarvinPA) Removing chaos champions without giving them a replacement mangled the monster placement in the vault. As blood saints received Call of Chaos, they've been placed as a replacement until a more suitable choice can be made. -------------------------------------------------------------------------------- b753e76 | John Olender | 2016-09-30 18:08:26 -0400 Only brighten skill colours for skills which are actively training. A skill may not be trainable but can still be listed in the skill menu. Cross-trained weapon skills often fall into this category, for example. Avoid brightening the colour for such skills. -------------------------------------------------------------------------------- 3cdf1d8 | John Olender | 2016-09-30 18:08:26 -0400 skill_menu.cc: Avoid color clashes with darkgrey. The no_dark_brand option is enabled by default, which means darkgrey-on-black is rendered using a safety foreground colour. To keep contrast with lightgrey on the default black background, it ends up rendered as blue-on-black. To avoid a clash with darkgrey-as-blue and another colour in the skill menu, change the colour of enhanced skills from blue to green. Addtionally, move the manual bonus text from green to red to keep each colour in the menu mostly distinct. -------------------------------------------------------------------------------- ffe185b | John Olender | 2016-09-30 18:08:26 -0400 Allow control over curses color rendering assumptions. Consider a character with identically-displayed foreground and background colors a failure condition. If such a scenario is detected, adjust the output to be visible. The default background colour is the default failsafe colour for the background. When there is a clash with the default background colour, choose black, or blue if the default background colour is black or white. Related changes: - Provide the safest-possible rendering assumptions by default. - Update the curses code to support both basic 8-color rendering and native 16-color rendering. - Add and update options related to curses rendering: - Add "blink_brightens_background" and "bold_brightens_foregound" options. These allow independent control over the assumptions that A_BLINK and A_BOLD will actually adjust their respective colour. - Update "no_dark_brand" to affect all darkgrey output, not just brands. - Convert the unused "num_colours" option to "allow_extended_colours". Note that curses and the current terminfo both have to directly support the number of internal colours for this setting to have any effect. - Update the "background_colour" option to reverse-map backgrounds to black. Add a corresponding "foreground_colour" option which reverse-maps lightgrey foregrounds. - Update the documentation for the terminal rendering options. - Attempt to change the default colour assumptions for the terminal. This change allows the "background_colour" and "foreground_colour" options to work as expected, provided both curses and the terminal support the feature. Additional implementation notes: - Update the code to use curses calls with discrete attr_t and color_pair arguments. This allows more than 256 color pairs to be used, and is quite important when using 16 or more colors. - Adjust many of the functions and variables to specifically use the COLOURS enum when dealing with internal colours. - Fix flip_colour's handling of bright colors in 8-color mode. - Add documentation and declarations for many of the touched functions. - Adjust the value of the COLFLAG_CURSES_BRIGHTEN flag to directly coincide with the bright colours in the 16-color palette. -------------------------------------------------------------------------------- bb2db12 | Nicholas Feinberg | 2016-09-30 11:19:53 -0700 erik_arrival_cave_to_temple fixes (divsky) Removed 1/3 chance of statues, which orc wizards could blink past them. Not intended for D:1. Could alternately remove the orc wizards (and priests, now) and re-add statues, which would let players with digging return to loot the vault later... not super excited about that, though. Made a few other tweaks in line with the vault being intended to be purely decorative. -------------------------------------------------------------------------------- 7aebecb | Nicholas Feinberg | 2016-09-30 09:46:27 -0700 Don't warn about falling to your death (10698) Since you can't anymore, probably. -------------------------------------------------------------------------------- c9128b4 | Nicholas Feinberg | 2016-09-30 09:36:55 -0700 Fix monster max HP display for edge cases Player ghosts/illusions and various vault-modified monsters. -------------------------------------------------------------------------------- 048f9dc | Nicholas Feinberg | 2016-09-29 21:25:06 -0700 Merge pull request #370 from aegolden/DeadStoreCleanup Clean up two dead assignments -------------------------------------------------------------------------------- 0b18a7b | Isaac Sloat | 2016-09-29 17:37:18 -0500 Replace fire/ice with quicksilver/shadow in Zot Fire and ice dragons were little more than popcorn by the time characters are doing Zot, even when berserked by a moth of wrath. They show up in plenty of other parts of the Dungeon, and swamp dragons are already excluded from Zot for being too weak. Quicksilver dragons and their dispelling breath have been introduced in their place. Shadow dragon spawn rates have been flattened, making them show up on early Zot floors much more frequently than previously. Q and S each should represent 4 to 5% of Zot's population. -------------------------------------------------------------------------------- 1e0734d | Nicholas Feinberg | 2016-09-29 14:56:14 -0700 Skill manual generation tweaks Remove the bias toward unarmed combat & stealth in manual generation - was added as an ugly hack when traps & doors and stabbing were removed, respectively. Also refactor a little. -------------------------------------------------------------------------------- 8b4ba7c | Nicholas Feinberg | 2016-09-29 14:29:58 -0700 _generate_book_item() refactoring -------------------------------------------------------------------------------- 50cf0f4 | Nicholas Feinberg | 2016-09-29 14:18:05 -0700 Fix spellbook rarity (|amethyst) Some spellbooks are supposed to be rarer than others - well, to spawn less often at lower depths - but this functionality had been broken since 0f4b659d, eight years ago. Probably that means it's not very important, so I wouldn't be surprised to see this removed again. -------------------------------------------------------------------------------- d99315e | Isaac Sloat | 2016-09-29 16:16:07 -0500 Refactor demonspawn job selection -------------------------------------------------------------------------------- a1f7210 | Isaac Sloat | 2016-09-29 16:16:07 -0500 Teach Call of Chaos to blood saints Gives them a second spell in their repertoire, and rounds off the four demonspawn classes: they now all have at least one way to help each other through buffs or inflicting statuses on the enemy. -------------------------------------------------------------------------------- d0de9cb | Isaac Sloat | 2016-09-29 16:16:07 -0500 Remove chaos champions After multiple attempts to give them sufficiently chaotic abilities and spells were unsuccessful, chaos champions never really fulfilled their design intent. Their Call of Chaos spell will be moved to blood saints. Their spawn weightings have been spread out evenly across the other four classes. This reduces the number of possible demonspawn combinations from 20 to 16. -------------------------------------------------------------------------------- 8492434 | Isaac Sloat | 2016-09-29 16:16:06 -0500 Remove putrid demonspawn They were not as successful as the other demonspawn types: poison immunity is not something that's relevant by the time the player is doing Pandemonium, and their fast regeneration was contigent on having corpses nearby, which is something that's in short supply in Pan even with fellow demonspawn. Their spawn weighting has been spread out evenly across the other four types. The number of possible demonspawn combos have been reduced from 25 to 20. This should help make demonspawn packs in Pandemonium more focused and sensible. -------------------------------------------------------------------------------- c873335 | Nicholas Feinberg | 2016-09-29 13:55:02 -0700 Merge pull request #375 from aegolden/AddSemicolon Add missing semicolon -------------------------------------------------------------------------------- c98162a | Aaron Golden | 2016-09-29 13:43:57 -0700 Add missing semicolon -------------------------------------------------------------------------------- 958f1b5 | Alan Malloy | 2016-09-29 11:20:26 -0700 Don't call artefact amulets of nothing 'buggy' (simmarine) -------------------------------------------------------------------------------- 6009954 | Nicholas Feinberg | 2016-09-29 07:37:43 -0700 Remove accidental bonus ac (10703) Introduced in b62331c89af3ce. -------------------------------------------------------------------------------- c855d72 | regret-index | 2016-09-28 20:22:20 -0400 Reconnect kennysheep_demon_jail A while back as I was editing this vault I changed the connector door entrance glyphs for the sake of different floor tiles, which had the side effect of no explicit entrances to the vault and thus the potential of complete isolation from the level. Whoops. Fixed here. -------------------------------------------------------------------------------- 84977a8 | Chris Campbell | 2016-09-29 00:19:29 +0100 Show when trees have been animated by awaken forest -------------------------------------------------------------------------------- 1b80ca8 | Chris Campbell | 2016-09-28 22:51:51 +0100 Simplify branch noise handling (PleasingFungus) Instead of supporting fine-grained variation in ambient noise levels, use an enum and a fixed value for loud/quiet branches. -------------------------------------------------------------------------------- c7c1317 | Chris Campbell | 2016-09-28 19:13:29 +0100 Decrease Slime noise level to -6 To make quiet branches (Slime, Crypt, Tomb) consistently use the same value. -------------------------------------------------------------------------------- 5ad3e2d | Chris Campbell | 2016-09-28 19:12:32 +0100 Adjust and deduplicate messaging for ambient noise -------------------------------------------------------------------------------- a59010f | Nicholas Feinberg | 2016-09-28 09:38:34 -0700 More salt floor/wall tiles (CanOfWorms) Note to self, for future reference: reduce brightness by 20% when importing -------------------------------------------------------------------------------- cab94ab | Nicholas Feinberg | 2016-09-27 17:45:13 -0700 Remove plutonium sword abuse Don't let it affect magic immune monsters, e.g. plants (to avoid Certain Players from turning plants into free xp) Alternate solution: could revert this and tag polymorphed monsters that were originally firewood as MF_NO_REWARD? -------------------------------------------------------------------------------- fd0a92b | Nicholas Feinberg | 2016-09-27 17:16:29 -0700 Refactor chaos effects Move into data. -------------------------------------------------------------------------------- ff403d4 | regret-index | 2016-09-27 17:49:14 -0400 Somewhat clean-up golem_gauntlet_mu Trim out the D uniques it always had, as they're out of place in Depths. Also standardize the header, provide cloud origin point indicators, and place some hatches to escape certain islands. -------------------------------------------------------------------------------- bbe854a | Nicholas Feinberg | 2016-09-27 13:58:42 -0700 Replace ushabti negative energy with miasma More exciting than negative energy - esp in tomb, where players are likely to be hugely resistant to negative energy, if not immune - and no longer conflicts with death scarabs, since they lost their miasma trails. -------------------------------------------------------------------------------- 60952de | Isaac Sloat | 2016-09-27 15:06:40 -0500 Rename greatslings to fustibali Part of a campaign to make Crawl names more distinct and to reduce overuse of certain prefixes. Did you know: https://en.wikipedia.org/wiki/Sling_(weapon)#Staff_sling http://www.encasedinsteel.co.uk/2013/05/24/the-mighty-staff-sling/ -------------------------------------------------------------------------------- 7454d6f | Isaac Sloat | 2016-09-27 13:55:57 -0500 Add monspeak lines for bullfrog -------------------------------------------------------------------------------- ba988d4 | DrKe | 2016-09-27 13:26:00 -0500 Adjust stats of some long blades Scimitar accuracy -2 -> +0, great sword damage 14 -> 15 and delay 16 -> 17. -------------------------------------------------------------------------------- 77406d5 | Isaac Sloat | 2016-09-27 12:52:39 -0500 Rename greater naga to nagaraja Part of a campaign to make Crawl creature names more distinct and to reduce overuse of certain prefixes. Did you know: https://en.wikipedia.org/wiki/Nagaraja Also: https://en.wikipedia.org/wiki/Raja -------------------------------------------------------------------------------- fa80773 | Nicholas Feinberg | 2016-09-27 09:31:18 -0700 Fix Hep ally max HP display (chequers) -------------------------------------------------------------------------------- 6dc86a0 | Nicholas Feinberg | 2016-09-27 07:54:35 -0700 Improve messages_at_top for screenreaders (NiallH) Should actually render messages before the rest of the screen, which should make it more useful for screen readers, possibly. Would be nice to have a better way to test this. ...also, this code should probably be deduplicated. -------------------------------------------------------------------------------- bd66c22 | Nicholas Feinberg | 2016-09-26 20:50:01 -0700 Don't spawn enemies with Elemental Force Could only happen if you weren't tracking whose clouds were whose (there's no UI for this, of course!) and accidentally summoned elementals from your enemy's clouds. No prompt, of course. Silly! Currently you can only summon from your own clouds; probably you should just be allowed to summon friendly elementals from all clouds, but apparently I was persuaded not to do this back in April (for reasons I don't recall), so I'm leaning toward a conservative approach for now. -------------------------------------------------------------------------------- 5ffe1b7 | Nicholas Feinberg | 2016-09-26 20:44:42 -0700 Partially refactor qazlal_elemental_force Deduplicate. -------------------------------------------------------------------------------- 52bc8b1 | Nicholas Feinberg | 2016-09-26 20:18:44 -0700 Make Qazlal's cloud immunity global (Arrhythmia) Instead of only applying to your own clouds. The UI for the previous behaviour was very bad (no indication, other than a warning prompt when you tried to walk into hostile clouds!), and the buff is limited and situational. Simpler behvaiour is good! -------------------------------------------------------------------------------- c670439 | Nicholas Feinberg | 2016-09-26 19:55:30 -0700 Add an overlooked changelog entry -------------------------------------------------------------------------------- 7954118 | John Deeny | 2016-09-26 20:53:11 -0400 Replace get_menu_colour_prefix_tags with menu_colour_item_name (#373) -------------------------------------------------------------------------------- e29cd90 | Neil Moore | 2016-09-26 20:34:55 -0400 Generate wide aptitude table from the Makefile. In docs/aptitudes-wide.txt. Not currently used in-game. -------------------------------------------------------------------------------- 4b0b555 | Neil Moore | 2016-09-26 20:23:04 -0400 Add a template for wide aptitude tables. Currently unused, but it might be useful for wide screens. Run: util/gen-apt.pl aptitudes-wide.txt ../docs/template/apt-tmpl-wide.txt species-data.h aptitudes.h -------------------------------------------------------------------------------- 0595f0e | Neil Moore | 2016-09-25 22:49:47 -0400 Remove a stray comment (doh) [skip ci] -------------------------------------------------------------------------------- 05e5456 | Neil Moore | 2016-09-25 22:46:05 -0400 Remove some vestiges of spriggan handedness. Sac Hand no longer needs to remove Polearms skill from Spriggans, and SpFi can now start with spears, war axes, or long swords. -------------------------------------------------------------------------------- a26c10b | Nicholas Feinberg | 2016-09-25 19:31:07 -0700 Changelog through 0.19-a0-1694-g2dd932f -------------------------------------------------------------------------------- 2dd932f | Neil Moore | 2016-09-25 21:20:18 -0400 Don't crash when drawing weaponless Agnes. http://crawl.berotato.org/crawl/morgue/lessens/crash-lessens-20160926-011315.txt -------------------------------------------------------------------------------- 92623fe | Neil Moore | 2016-09-25 19:18:56 -0400 Constify and simplify get_menu_colour_prefix_tags. -------------------------------------------------------------------------------- 68728bb | Alan Malloy | 2016-09-25 13:06:17 -0700 Merge pull request #371 from jdeeny/color_identified Color the text when an object is identified by a scroll of identify. -------------------------------------------------------------------------------- 0ee7079 | jdeeny | 2016-09-25 13:49:44 -0600 Color the text when an object is identified. For example, if following Chei, a potion of haste would be shown in red when identified. Previously, the text was always grey. -------------------------------------------------------------------------------- 9e0fcb6 | Neil Moore | 2016-09-25 10:40:48 -0400 Add help to checkwhite and unbrace. Displayed with --help or -h. Also, fail and display the help if bad options were supplied. [skip ci] -------------------------------------------------------------------------------- cb872fc | Neil Moore | 2016-09-25 10:40:48 -0400 Add option checkwhite -r to leave CRs (gammafunk, Brannock) This should make it a little easier to use git's autocrlf option. -------------------------------------------------------------------------------- 3040f7a | Neil Moore | 2016-09-25 10:40:48 -0400 Avoid a member-shadowing warning. -------------------------------------------------------------------------------- af949d0 | Neil Moore | 2016-09-25 10:40:47 -0400 Checkwhite. [skip ci] -------------------------------------------------------------------------------- d8690b2 | Aaron Golden | 2016-09-24 17:58:44 -0700 Clean up dead store "vector * results = &results_in" The results variable is overwritten before being read in every code path following the initialization, so the value stored during initialization is never read. -------------------------------------------------------------------------------- 5598110 | Aaron Golden | 2016-09-24 17:58:44 -0700 Clean up dead store "moving = false" The function returns immediately after this assignment so moving is not read. -------------------------------------------------------------------------------- 35356ef | Chris Campbell | 2016-09-24 20:57:15 +0100 Simplify constriction escapes As with webs, remove the dependence on strength, as well as some other complicated handling for monsters where size factored into escape chance (and tiny monsters never escaped constriction), despite the fact that most monsters don't even try to escape. -------------------------------------------------------------------------------- 614e038 | Chris Campbell | 2016-09-24 19:58:59 +0100 Simplify web escape chances Make it a fixed chance, rather than dependent on strength - the dependence wouldn't really affect any decisionmaking in practice, so just gave strength an additional very niche effect on top of its main effects of affecting damage, AEVP, etc. -------------------------------------------------------------------------------- 34c2bd0 | Chris Campbell | 2016-09-24 19:48:46 +0100 Add Lua .persist files to .gitignore -------------------------------------------------------------------------------- 2e5aaf6 | Chris Campbell | 2016-09-24 19:42:26 +0100 Update wording for tiny weapon/armour restrictions (nikheizen) -------------------------------------------------------------------------------- 5114f93 | Nicholas Feinberg | 2016-09-23 16:58:35 -0700 oops -------------------------------------------------------------------------------- b62331c | Nicholas Feinberg | 2016-09-23 16:57:06 -0700 Simplify local AC colour display code (ontoclasm) This could also be used to simplify webtiles' equivalent AC colour code. -------------------------------------------------------------------------------- 71ce815 | Nicholas Feinberg | 2016-09-23 16:36:57 -0700 Credit Crawl's fourth Aaron And add him (aegolden) to the mailmap. -------------------------------------------------------------------------------- 00af8a7 | Aaron Golden | 2016-09-23 16:31:02 -0700 Exclude "MacOSX.sdk" from SDK search in OS X build In Sierra with Xcode 8 installed an SDK "MacOSX.sdk" with no version number appears in the list of installed SDKs and this causes the SDK version to come out empty. We should exclude this special case from the list of SDKs to consider so we find only the versioned SDKs. This change gets crawl building again on Mac OS X using, e.g. "make APPLE_GCC=y NO_PKGCONFIG=y CONTRIB_SDL=y TILES=y". Closes #367. -------------------------------------------------------------------------------- 8ce114c | Chris Campbell | 2016-09-23 20:10:14 +0100 Update webtiles HUD highlighting (#10695) Highlight AC in webtiles when a protection weapon is active. Also add a check for DS sanguine armour and TSO's divine shield, and remove some obsolete checks. Still possibly highlighted in console but not in webtiles: DS icemail mutation, Qazlal shielding? -------------------------------------------------------------------------------- a65e377 | gammafunk | 2016-09-23 03:14:22 -0500 Some vaults from Cheibrodos for D, Depths, and Snake (10678) Various cleanups and tweaks, mostly to add a bit of randomness to monster numbers. Vault cheibrodos_gamma_graves remains unmerged for now, pending some changes. -------------------------------------------------------------------------------- 39ae8cc | Nicholas Feinberg | 2016-09-22 14:55:08 -0700 Save compat tomb:3 hack (10641) (MarvinPA) Fixing, more or less, an issue caused by bc45de5b2ef5c301. -------------------------------------------------------------------------------- c11f27c | Nicholas Feinberg | 2016-09-22 14:33:26 -0700 Revert "Render mons average HP as linear glyphs" Turns out this looked awful everyw