Main | My View | View Issues | Change Log | Wiki | Tavern | News
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000506 [DCSS] Testing and Feedback minor have not tried 2010-01-22 11:37 2010-09-12 20:05
Reporter evktalo View Status public  
Assigned To rob
Priority high Resolution done  
Status closed   Product Branch 0.6 ancient branch
Summary 0000506: Message window anomalities
Description The message window code has been overhauled. It is now in the master branch for testing. There are still things on the todo list (see Additional Information).

Please report any troubles you see here.

(Separate reports that are a part of this can be marked as "child" issues.)
Additional Information From message.cc

 * Todo:
 * - change uses of cancelable_get_line to msgwin_get_line
 * - Handle resizing properly, in particular initial resize.
 *
 * Maybe:
 * - Redraw message window at same places that cause refresh?
 * - condensing across turns?
Tags No tags attached.
Attached Files

- Relationships
related to 0000512new More helpful and unified scrolling prompts for formatted_scroller. 
related to 0000063closedrob initial - in the message window shows up even when a turn hasn't gone by 
related to 0000712closed reduce number of messages for butchering 
parent of 0000505closedrob Being paralyzed no longer offers a --more-- prompt each turn. 
parent of 0000128closedrob Clear message window less often 
parent of 0000549closedrob ^P clearing messages 
parent of 0000542closedrob Message history doesn't break long messages into shorter sections (g5e625c3) 
parent of 0000592resolvedrob extra --more-- prompts 
parent of 0000695closedrob Passing a --more-- prompt does not clear the messagewindow. 
parent of 0000716closedrob Using small_more=false overwrites last message 
parent of 0000713closedrob only 6 message lines with default config (?) 
parent of 0000722resolvedrob Single line message for summons do not colour properly 
parent of 0000292closedrob Morgue's message history is missing last line 
parent of 0000870resolvedrob Sometimes the -more- prompt doesn't happen and messages are skipped over. 
related to 0000612closedrob Using new "x" clears message window 

-  Notes
(0001417)
evktalo (administrator)
2010-01-22 11:39
edited on: 2010-01-22 18:04

 When the window message is full and I get a happening which would cause a --more-- prompt before (for instance: gaining a level), the prompt is not shown. This with clear_messages off. (i.e. old "delay_message_clear = on", i.e. the default)

edit: (snip wrong quote)

--Eino
(0001424)
rob (developer)
2010-01-22 14:07

 The issue you mention above is probably the same as 0000505, which has been fixed now.
(0001430)
rob (developer)
2010-01-22 16:17

 Updated todo list.
(0001438)
jpeg (manager)
2010-01-22 17:01

 Viewing the message history gives no indication that you can scroll. Indeed, when I first had a look at it with a freshly reloaded character I thought the message history was broken and didn't remember messages from before saving, and only later it occured to me that I could try the arrow keys anyway.
(0001443)
evktalo (administrator)
2010-01-22 18:05
edited on: 2010-01-22 18:33

 Updated the TODO list in this item as well. --Eino

edit: Oops, I just managed to revert it to an unfresh version. Should be ok now!
(0001449)
rob (developer)
2010-01-22 18:32

 jpeg: The message history is now displayed using a formatted_scroller; probably formatted_scroller should output a helpful message at the bottom by default, like it does for help.
(0001662)
rob (developer)
2010-01-26 11:57

 Sync todo list. The remaining issues aren't critical.
(0001700)
Kyrris (reporter)
2010-01-27 01:32

 Now the right hand ring is not showing.
(0001779)
evktalo (administrator)
2010-01-27 21:52

 Confirming what Kyrris said. This on the current build running on CDO, 0.6.0-a1-2851-gbfdd453.

--Eino
(0001796)
rob (developer)
2010-01-28 12:07

 Ring prompt should be fixed.

There's some issues left with the more prompts:
- Is the '+' more prompt visible enough?
- --more-- can cause '+' still
- There shouldn't be a '+' after an actual prompt (MSGCH_PROMPT is not enough, there needs to be a getch())
(0001851)
Napkin (administrator)
2010-01-29 22:12

 Assigned to Rob since he's doing most of this great work :)
(0003999)
rob (developer)
2010-04-06 21:44

 This seems to be done.

- Issue History
Date Modified Username Field Change
2010-01-22 11:37 evktalo New Issue
2010-01-22 11:37 evktalo Status new => acknowledged
2010-01-22 11:39 evktalo Note Added: 0001417
2010-01-22 11:40 evktalo Relationship added parent of 0000505
2010-01-22 11:40 evktalo Relationship added parent of 0000128
2010-01-22 14:07 rob Note Added: 0001424
2010-01-22 16:17 rob Note Added: 0001430
2010-01-22 16:17 rob Additional Information Updated
2010-01-22 17:01 jpeg Note Added: 0001438
2010-01-22 18:04 evktalo Note Edited: 0001417
2010-01-22 18:05 evktalo Note Added: 0001443
2010-01-22 18:05 evktalo Additional Information Updated
2010-01-22 18:32 rob Note Added: 0001449
2010-01-22 18:33 evktalo Additional Information Updated
2010-01-22 18:33 evktalo Note Edited: 0001443
2010-01-22 18:36 rob Relationship added related to 0000512
2010-01-22 20:51 rob Relationship added related to 0000063
2010-01-25 20:30 rob Relationship added parent of 0000549
2010-01-25 20:30 rob Relationship added parent of 0000542
2010-01-26 08:47 rob Issue Monitored: rob
2010-01-26 11:57 rob Note Added: 0001662
2010-01-26 11:57 rob Additional Information Updated
2010-01-27 01:32 Kyrris Note Added: 0001700
2010-01-27 21:52 evktalo Note Added: 0001779
2010-01-28 12:07 rob Note Added: 0001796
2010-01-28 14:03 rob Relationship added parent of 0000592
2010-01-29 20:05 Napkin Relationship added parent of 0000612
2010-01-29 22:12 Napkin Note Added: 0001851
2010-01-29 22:12 Napkin Assigned To => rob
2010-01-29 22:12 Napkin Status acknowledged => assigned
2010-02-04 09:51 rob Relationship replaced related to 0000612
2010-02-05 10:30 rob Relationship added parent of 0000695
2010-02-06 22:52 rob Relationship added parent of 0000716
2010-02-06 22:52 rob Relationship added parent of 0000713
2010-02-06 22:53 rob Relationship added parent of 0000712
2010-02-06 22:53 rob Relationship added parent of 0000722
2010-02-09 22:47 rob Relationship added parent of 0000292
2010-02-21 17:56 rob Relationship added parent of 0000870
2010-04-06 21:44 rob Relationship replaced related to 0000712
2010-04-06 21:44 rob Note Added: 0003999
2010-04-06 21:44 rob Status assigned => resolved
2010-04-06 21:44 rob Fixed in Branch => 0.7 development branch
2010-04-06 21:44 rob Resolution open => done
2010-09-12 20:05 evktalo Status resolved => closed

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker