0004875: Find Enhancement Request - search against + - Dungeon Crawl Stone Soup Tracker

(0015778)
neil (administrator)
2011-11-09 15:36

You can; you just have to write it as "\+3" because the plus sign is special in regular expressions. It might make sense, though, to do this automatically at the beginning of the search expression, since + isn't valid there.

(0015779)
XuaXua (reporter)
2011-11-09 15:44

Didn't realize it was using regex.

There is no comment regarding using "\+" on the help screen via '?' after 'Ctrl-f'

(0015780)
neil (administrator)
2011-11-09 16:02

I guess it could use a comment like:

Many non-alphanumeric characters, including but not limited to .*|?+()[]{}, have special meaning. To search for such a character literally, prefix it with backslash (\):
rC\+\+ find randarts providing two levels of cold resistance
\(0\) find wands known to have zero charges

(0015792)
Kyrris (reporter)
2011-11-10 12:49

While it is certainly nice to have regexp handling of search terms, I think it's much more realistic to assume people will expect to be entering a plaintext string.

(0015794)
XuaXua (reporter)
2011-11-10 14:27
edited on: 2011-11-10 14:28

Would it be problematic if the search text entry assumed everything entered was a string (literal) unless the entry was prefixed by a certain character that could be removed from the regex that followed? For example, enter '|' and follow with the regex.

Examples:
|rC\+*+

finds rC+ and rC++

rC++
and
|rC\+\+

finds only rC++

---

Basically, if you leave out the '|' prefix, all special regex characters will be escaped with '\'

(0021870)
mumra (developer)
2013-03-27 07:50

Added a couple of examples to the stash tracker help for searching plusses

(0022116)
XuaXua (reporter)
2013-04-03 06:24

Examples are acceptable.

Notes
(0015778) neil (administrator) 2011-11-09 15:36	You can; you just have to write it as "\+3" because the plus sign is special in regular expressions. It might make sense, though, to do this automatically at the beginning of the search expression, since + isn't valid there.

(0015779) XuaXua (reporter) 2011-11-09 15:44	Didn't realize it was using regex. There is no comment regarding using "\+" on the help screen via '?' after 'Ctrl-f'

(0015780) neil (administrator) 2011-11-09 16:02	I guess it could use a comment like: Many non-alphanumeric characters, including but not limited to .*\|?+()[]{}, have special meaning. To search for such a character literally, prefix it with backslash (\): rC\+\+ find randarts providing two levels of cold resistance \(0\) find wands known to have zero charges

(0015792) Kyrris (reporter) 2011-11-10 12:49	While it is certainly nice to have regexp handling of search terms, I think it's much more realistic to assume people will expect to be entering a plaintext string.

(0015794) XuaXua (reporter) 2011-11-10 14:27 edited on: 2011-11-10 14:28	Would it be problematic if the search text entry assumed everything entered was a string (literal) unless the entry was prefixed by a certain character that could be removed from the regex that followed? For example, enter '\|' and follow with the regex. Examples: \|rC\+*+ finds rC+ and rC++ rC++ and \|rC\+\+ finds only rC++ --- Basically, if you leave out the '\|' prefix, all special regex characters will be escaped with '\'

(0021870) mumra (developer) 2013-03-27 07:50	Added a couple of examples to the stash tracker help for searching plusses

(0022116) XuaXua (reporter) 2013-04-03 06:24	Examples are acceptable.

Issue History
Date Modified	Username	Field	Change
2011-11-09 15:28	XuaXua	New Issue
2011-11-09 15:36	neil	Note Added: 0015778
2011-11-09 15:44	XuaXua	Note Added: 0015779
2011-11-09 16:02	neil	Note Added: 0015780
2011-11-10 12:49	Kyrris	Note Added: 0015792
2011-11-10 14:27	XuaXua	Note Added: 0015794
2011-11-10 14:28	XuaXua	Note Edited: 0015794
2013-03-27 07:50	mumra	Note Added: 0021870
2013-03-27 07:50	mumra	Status	new => resolved
2013-03-27 07:50	mumra	Fixed in Branch	=> 0.12 development branch
2013-03-27 07:50	mumra	Resolution	open => done
2013-03-27 07:50	mumra	Assigned To	=> mumra
2013-04-03 06:24	XuaXua	Note Added: 0022116
2013-04-03 06:24	XuaXua	Status	resolved => closed

Relationships